Issues in RrsigTest.php (master) - Issues in master - Badcow/DNS - Measure and Improve Code Quality continuously with Scrutinizer

Issues (166)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/Rdata/RrsigTest.php (8 issues)

Labels

Severity

Major 8

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);

/*
 * This file is part of Badcow DNS Library.
 *
 * (c) Samuel Williams <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Badcow\DNS\Tests\Rdata;

use Badcow\DNS\Algorithms;
use Badcow\DNS\Parser\Parser;
use Badcow\DNS\Rdata\A;
use Badcow\DNS\Rdata\Factory;
use Badcow\DNS\Rdata\RRSIG;
use Badcow\DNS\Rdata\UnsupportedTypeException;
use PHPUnit\Framework\TestCase;

class RrsigTest extends TestCase
{
    private static $signature = 'oJB1W6WNGv+ldvQ3WDG0MQkg5IEhjRip8WTrPYGv07h108dUKGMeDPKijVCHX3DDKdfb+v6oB9wfuh3DTJXUA'.
        'fI/M0zmO/zz8bW0Rznl8O3tGNazPwQKkRN20XPXV6nwwfoXmJQbsLNrLfkGJ5D6fwFm8nN+6pBzeDQfsS3Ap3o=';

    public function testToText(): void
    {
        if (2147483647 === PHP_INT_MAX) {
            $this->markTestSkipped('RRSIG test does not work on 32-bit systems.');
        }

        $expectation = 'A 5 3 86400 20050322173103 20030220173103 2642 example.com. '.self::$signature;

        $rrsig = new RRSIG();

        $rrsig->setTypeCovered('A');
        $rrsig->setAlgorithm(Algorithms::RSASHA1);
        $rrsig->setLabels(3);
        $rrsig->setOriginalTtl(86400);
        $rrsig->setSignatureExpiration(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20050322173103'));

        $rrsig->setSignatureInception(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20030220173103'));

        $rrsig->setKeyTag(2642);
        $rrsig->setSignersName('example.com.');
        $rrsig->setSignature(base64_decode(self::$signature));

        $this->assertEquals($expectation, $rrsig->toText());
    }

    public function testFactory(): void
    {
        $rrsig = Factory::RRSIG(
            A::TYPE,
            Algorithms::RSASHA1,
            3,
            86400,
            \DateTime::createFromFormat('Ymd', '20220101'),

            \DateTime::createFromFormat('Ymd', '20180101'),

            2642,
            'example.com.',
            self::$signature
        );

        $this->assertEquals(A::TYPE, $rrsig->getTypeCovered());
        $this->assertEquals(Algorithms::RSASHA1, $rrsig->getAlgorithm());
        $this->assertEquals(3, $rrsig->getLabels());
        $this->assertEquals(86400, $rrsig->getOriginalTtl());
        $this->assertEquals(\DateTime::createFromFormat('Ymd', '20220101'), $rrsig->getSignatureExpiration());
        $this->assertEquals(\DateTime::createFromFormat('Ymd', '20180101'), $rrsig->getSignatureInception());
        $this->assertEquals(2642, $rrsig->getKeyTag());
        $this->assertEquals('example.com.', $rrsig->getSignersName());
        $this->assertEquals(self::$signature, $rrsig->getSignature());
    }

    public function testFromText(): void
    {
        $text = 'A 5 3 86400 20050322173103 20030220173103 2642 example.com. '.self::$signature;

        $rrsig = new RRSIG();
        $rrsig->setTypeCovered('A');
        $rrsig->setAlgorithm(Algorithms::RSASHA1);
        $rrsig->setLabels(3);
        $rrsig->setOriginalTtl(86400);
        $rrsig->setSignatureExpiration(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20050322173103'));

        $rrsig->setSignatureInception(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20030220173103'));

        $rrsig->setKeyTag(2642);
        $rrsig->setSignersName('example.com.');
        $rrsig->setSignature(base64_decode(self::$signature));

        $fromText = new RRSIG();
        $fromText->fromText($text);
        $this->assertEquals($rrsig, $fromText);
    }

    /**
     * @throws UnsupportedTypeException
     */
    public function testWire(): void
    {
        $rrsig = new RRSIG();
        $rrsig->setTypeCovered('A');
        $rrsig->setAlgorithm(Algorithms::RSASHA1);
        $rrsig->setLabels(3);
        $rrsig->setOriginalTtl(86400);
        $rrsig->setSignatureExpiration(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20050322173103'));

        $rrsig->setSignatureInception(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20030220173103'));

        $rrsig->setKeyTag(2642);
        $rrsig->setSignersName('example.com.');
        $rrsig->setSignature(self::$signature);

        $wireFormat = $rrsig->toWire();
        $rdLength = strlen($wireFormat);
        $wireFormat = 'abcd'.$wireFormat;
        $offset = 4;

        $fromWire = new RRSIG();
        $fromWire->fromWire($wireFormat, $offset, $rdLength);
        $this->assertEquals($rrsig, $fromWire);
        $this->assertEquals(4 + $rdLength, $offset);
    }

    public function testIssue75(): void
    {
        $string = <<<'DNS'
$ORIGIN example.com.
 RRSIG	A 5 3 86400 20050322173103 20030220173103 2642 example.com. (
		sLGSfcmcvXQ4EGMXrUFFE1JO17AxhspZY8xXiCLEDN95
		S90KgnDUKzzIUTjjGao0G7XpzhoCgsXyAyJeTgTwa4v5
		ICV8xCF1dpUMb7aHRw2l0MA2dDZ30w33QTqU7TEbETpy
		NqTbK9qaabsTTXSIGg2ChKV8MwiGm/TyjnARjVo= )
DNS;
        $binarySignature = base64_decode('sLGSfcmcvXQ4EGMXrUFFE1JO17AxhspZY8xXiCLEDN95
		S90KgnDUKzzIUTjjGao0G7XpzhoCgsXyAyJeTgTwa4v5
		ICV8xCF1dpUMb7aHRw2l0MA2dDZ30w33QTqU7TEbETpy
		NqTbK9qaabsTTXSIGg2ChKV8MwiGm/TyjnARjVo=');

        $zone = Parser::parse('example.com.', $string);
        $this->assertCount(1, $zone);
        $rr = $zone[0];
        $rrsig = $rr->getRdata();

        $this->assertEquals('example.com.', $rr->getName());
        $this->assertEquals(RRSIG::TYPE, $rrsig->getType());

        $this->assertEquals(A::TYPE, $rrsig->getTypeCovered());
        $this->assertEquals(Algorithms::RSASHA1, $rrsig->getAlgorithm());
        $this->assertEquals(3, $rrsig->getLabels());
        $this->assertEquals(86400, $rrsig->getOriginalTtl());
        $this->assertEquals(\DateTime::createFromFormat('YmdHis', '20050322173103'), $rrsig->getSignatureExpiration());
        $this->assertEquals(\DateTime::createFromFormat('YmdHis', '20030220173103'), $rrsig->getSignatureInception());
        $this->assertEquals(2642, $rrsig->getKeyTag());
        $this->assertEquals('example.com.', $rrsig->getSignersName());
        $this->assertEquals($binarySignature, $rrsig->getSignature());
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			/*
6			* This file is part of Badcow DNS Library.
7			*
8			* (c) Samuel Williams <[email protected]>
9			*
10			* For the full copyright and license information, please view the LICENSE
11			* file that was distributed with this source code.
12			*/
13
14			namespace Badcow\DNS\Tests\Rdata;
15
16			use Badcow\DNS\Algorithms;
17			use Badcow\DNS\Parser\Parser;
18			use Badcow\DNS\Rdata\A;
19			use Badcow\DNS\Rdata\Factory;
20			use Badcow\DNS\Rdata\RRSIG;
21			use Badcow\DNS\Rdata\UnsupportedTypeException;
22			use PHPUnit\Framework\TestCase;
23
24			class RrsigTest extends TestCase
25			{
26			private static $signature = 'oJB1W6WNGv+ldvQ3WDG0MQkg5IEhjRip8WTrPYGv07h108dUKGMeDPKijVCHX3DDKdfb+v6oB9wfuh3DTJXUA'.
27			'fI/M0zmO/zz8bW0Rznl8O3tGNazPwQKkRN20XPXV6nwwfoXmJQbsLNrLfkGJ5D6fwFm8nN+6pBzeDQfsS3Ap3o=';
28
29			public function testToText(): void
30			{
31			if (2147483647 === PHP_INT_MAX) {
32			$this->markTestSkipped('RRSIG test does not work on 32-bit systems.');
33			}
34
35			$expectation = 'A 5 3 86400 20050322173103 20030220173103 2642 example.com. '.self::$signature;
36
37			$rrsig = new RRSIG();
38
39			$rrsig->setTypeCovered('A');
40			$rrsig->setAlgorithm(Algorithms::RSASHA1);
41			$rrsig->setLabels(3);
42			$rrsig->setOriginalTtl(86400);
43			$rrsig->setSignatureExpiration(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20050322173103'));
			0 ignored issues – show Security Bug introduced 2021-01-21 22:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\DateTime::createFromFor...RMAT, '20050322173103')` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Badcow\DNS\Rdata\RRSIG::setSignatureExpiration()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
44			$rrsig->setSignatureInception(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20030220173103'));
			0 ignored issues – show Security Bug introduced 2021-01-21 22:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\DateTime::createFromFor...RMAT, '20030220173103')` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Badcow\DNS\Rdata\RRSIG::setSignatureInception()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
45			$rrsig->setKeyTag(2642);
46			$rrsig->setSignersName('example.com.');
47			$rrsig->setSignature(base64_decode(self::$signature));
48
49			$this->assertEquals($expectation, $rrsig->toText());
50			}
51
52			public function testFactory(): void
53			{
54			$rrsig = Factory::RRSIG(
55			A::TYPE,
56			Algorithms::RSASHA1,
57			3,
58			86400,
59			\DateTime::createFromFormat('Ymd', '20220101'),
			0 ignored issues – show Security Bug introduced 2021-01-21 22:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\DateTime::createFromFormat('Ymd', '20220101')` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Badcow\DNS\Rdata\Factory::RRSIG()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
60			\DateTime::createFromFormat('Ymd', '20180101'),
			0 ignored issues – show Security Bug introduced 2021-01-21 22:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\DateTime::createFromFormat('Ymd', '20180101')` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Badcow\DNS\Rdata\Factory::RRSIG()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
61			2642,
62			'example.com.',
63			self::$signature
64			);
65
66			$this->assertEquals(A::TYPE, $rrsig->getTypeCovered());
67			$this->assertEquals(Algorithms::RSASHA1, $rrsig->getAlgorithm());
68			$this->assertEquals(3, $rrsig->getLabels());
69			$this->assertEquals(86400, $rrsig->getOriginalTtl());
70			$this->assertEquals(\DateTime::createFromFormat('Ymd', '20220101'), $rrsig->getSignatureExpiration());
71			$this->assertEquals(\DateTime::createFromFormat('Ymd', '20180101'), $rrsig->getSignatureInception());
72			$this->assertEquals(2642, $rrsig->getKeyTag());
73			$this->assertEquals('example.com.', $rrsig->getSignersName());
74			$this->assertEquals(self::$signature, $rrsig->getSignature());
75			}
76
77			public function testFromText(): void
78			{
79			$text = 'A 5 3 86400 20050322173103 20030220173103 2642 example.com. '.self::$signature;
80
81			$rrsig = new RRSIG();
82			$rrsig->setTypeCovered('A');
83			$rrsig->setAlgorithm(Algorithms::RSASHA1);
84			$rrsig->setLabels(3);
85			$rrsig->setOriginalTtl(86400);
86			$rrsig->setSignatureExpiration(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20050322173103'));
			0 ignored issues – show Security Bug introduced 2021-01-21 22:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\DateTime::createFromFor...RMAT, '20050322173103')` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Badcow\DNS\Rdata\RRSIG::setSignatureExpiration()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
87			$rrsig->setSignatureInception(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20030220173103'));
			0 ignored issues – show Security Bug introduced 2021-01-21 22:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\DateTime::createFromFor...RMAT, '20030220173103')` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Badcow\DNS\Rdata\RRSIG::setSignatureInception()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
88			$rrsig->setKeyTag(2642);
89			$rrsig->setSignersName('example.com.');
90			$rrsig->setSignature(base64_decode(self::$signature));
91
92			$fromText = new RRSIG();
93			$fromText->fromText($text);
94			$this->assertEquals($rrsig, $fromText);
95			}
96
97			/**
98			* @throws UnsupportedTypeException
99			*/
100			public function testWire(): void
101			{
102			$rrsig = new RRSIG();
103			$rrsig->setTypeCovered('A');
104			$rrsig->setAlgorithm(Algorithms::RSASHA1);
105			$rrsig->setLabels(3);
106			$rrsig->setOriginalTtl(86400);
107			$rrsig->setSignatureExpiration(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20050322173103'));
			0 ignored issues – show Security Bug introduced 2021-01-21 22:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\DateTime::createFromFor...RMAT, '20050322173103')` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Badcow\DNS\Rdata\RRSIG::setSignatureExpiration()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
108			$rrsig->setSignatureInception(\DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20030220173103'));
			0 ignored issues – show Security Bug introduced 2021-01-21 22:25 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `\DateTime::createFromFor...RMAT, '20030220173103')` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `Badcow\DNS\Rdata\RRSIG::setSignatureInception()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
109			$rrsig->setKeyTag(2642);
110			$rrsig->setSignersName('example.com.');
111			$rrsig->setSignature(self::$signature);
112
113			$wireFormat = $rrsig->toWire();
114			$rdLength = strlen($wireFormat);
115			$wireFormat = 'abcd'.$wireFormat;
116			$offset = 4;
117
118			$fromWire = new RRSIG();
119			$fromWire->fromWire($wireFormat, $offset, $rdLength);
120			$this->assertEquals($rrsig, $fromWire);
121			$this->assertEquals(4 + $rdLength, $offset);
122			}
123
124			public function testIssue75(): void
125			{
126			$string = <<<'DNS'
127			$ORIGIN example.com.
128			RRSIG A 5 3 86400 20050322173103 20030220173103 2642 example.com. (
129			sLGSfcmcvXQ4EGMXrUFFE1JO17AxhspZY8xXiCLEDN95
130			S90KgnDUKzzIUTjjGao0G7XpzhoCgsXyAyJeTgTwa4v5
131			ICV8xCF1dpUMb7aHRw2l0MA2dDZ30w33QTqU7TEbETpy
132			NqTbK9qaabsTTXSIGg2ChKV8MwiGm/TyjnARjVo= )
133			DNS;
134			$binarySignature = base64_decode('sLGSfcmcvXQ4EGMXrUFFE1JO17AxhspZY8xXiCLEDN95
135			S90KgnDUKzzIUTjjGao0G7XpzhoCgsXyAyJeTgTwa4v5
136			ICV8xCF1dpUMb7aHRw2l0MA2dDZ30w33QTqU7TEbETpy
137			NqTbK9qaabsTTXSIGg2ChKV8MwiGm/TyjnARjVo=');
138
139			$zone = Parser::parse('example.com.', $string);
140			$this->assertCount(1, $zone);
141			$rr = $zone[0];
142			$rrsig = $rr->getRdata();
143
144			$this->assertEquals('example.com.', $rr->getName());
145			$this->assertEquals(RRSIG::TYPE, $rrsig->getType());
146
147			$this->assertEquals(A::TYPE, $rrsig->getTypeCovered());
148			$this->assertEquals(Algorithms::RSASHA1, $rrsig->getAlgorithm());
149			$this->assertEquals(3, $rrsig->getLabels());
150			$this->assertEquals(86400, $rrsig->getOriginalTtl());
151			$this->assertEquals(\DateTime::createFromFormat('YmdHis', '20050322173103'), $rrsig->getSignatureExpiration());
152			$this->assertEquals(\DateTime::createFromFormat('YmdHis', '20030220173103'), $rrsig->getSignatureInception());
153			$this->assertEquals(2642, $rrsig->getKeyTag());
154			$this->assertEquals('example.com.', $rrsig->getSignersName());
155			$this->assertEquals($binarySignature, $rrsig->getSignature());
156			}
157			}
158

Badcow / DNS

Issues (166)

Security Analysis no request data

tests/Rdata/RrsigTest.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like