| Conditions | 1 |
| Paths | 1 |
| Total Lines | 121 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 59 | public static function buildTestZone(): Zone |
||
| 60 | { |
||
| 61 | $soa = new ResourceRecord(); |
||
| 62 | $soa->setClass('IN'); |
||
| 63 | $soa->setName('@'); |
||
| 64 | $soa->setRdata(Factory::SOA( |
||
| 65 | 'example.com.', |
||
| 66 | 'postmaster.example.com.', |
||
| 67 | 2015050801, |
||
| 68 | 3600, |
||
| 69 | 14400, |
||
| 70 | 604800, |
||
| 71 | 3600 |
||
| 72 | )); |
||
| 73 | |||
| 74 | $ns1 = new ResourceRecord(); |
||
| 75 | $ns1->setClass('IN'); |
||
| 76 | $ns1->setName('@'); |
||
| 77 | $ns1->setTtl(14400); |
||
| 78 | $ns1->setRdata(Factory::NS('ns1.example.net.au.')); |
||
| 79 | |||
| 80 | $ns2 = new ResourceRecord(); |
||
| 81 | $ns2->setClass('IN'); |
||
| 82 | $ns2->setName('@'); |
||
| 83 | $ns2->setTtl(14400); |
||
| 84 | $ns2->setRdata(Factory::NS('ns2.example.net.au.')); |
||
| 85 | |||
| 86 | $a_record = new ResourceRecord(); |
||
| 87 | $a_record->setName('subdomain.au'); |
||
| 88 | $a_record->setRdata(Factory::A('192.168.1.2')); |
||
| 89 | $a_record->setComment('This is a local ip.'); |
||
| 90 | |||
| 91 | $cname = new ResourceRecord(); |
||
| 92 | $cname->setName('alias'); |
||
| 93 | $cname->setRdata(Factory::CNAME('subdomain.au.example.com.')); |
||
| 94 | |||
| 95 | $aaaa = ResourceRecord::create( |
||
| 96 | 'ipv6domain', |
||
| 97 | Factory::AAAA('::1'), |
||
| 98 | 3600, |
||
| 99 | Classes::INTERNET, |
||
| 100 | 'This is an IPv6 domain.' |
||
| 101 | ); |
||
| 102 | |||
| 103 | $mx1 = new ResourceRecord(); |
||
| 104 | $mx1->setName('@'); |
||
| 105 | $mx1->setRdata(Factory::MX(10, 'mail-gw1.example.net.')); |
||
| 106 | |||
| 107 | $mx2 = new ResourceRecord(); |
||
| 108 | $mx2->setName('@'); |
||
| 109 | $mx2->setRdata(Factory::MX(20, 'mail-gw2.example.net.')); |
||
| 110 | |||
| 111 | $mx3 = new ResourceRecord(); |
||
| 112 | $mx3->setName('@'); |
||
| 113 | $mx3->setRdata(Factory::MX(30, 'mail-gw3.example.net.')); |
||
| 114 | |||
| 115 | $txt = new ResourceRecord(); |
||
| 116 | $txt->setName('example.net.'); |
||
| 117 | $txt->setRdata(Factory::TXT('v=spf1 ip4:192.0.2.0/24 ip4:198.51.100.123 a -all')); |
||
| 118 | $txt->setClass(Classes::INTERNET); |
||
| 119 | |||
| 120 | $loc = new ResourceRecord(); |
||
| 121 | $loc->setName('canberra'); |
||
| 122 | $loc->setRdata(Factory::LOC( |
||
| 123 | -35.3075, //Lat |
||
| 124 | 149.1244, //Lon |
||
| 125 | 500, //Alt |
||
| 126 | 20.12, //Size |
||
| 127 | 200.3, //HP |
||
| 128 | 300.1 //VP |
||
| 129 | )); |
||
| 130 | $loc->setComment('This is Canberra'); |
||
| 131 | $loc->setClass(Classes::INTERNET); |
||
| 132 | |||
| 133 | $dname = new ResourceRecord(); |
||
| 134 | $dname->setName('bar.example.com.'); |
||
| 135 | $dname->setClass(Classes::INTERNET); |
||
| 136 | $dname->setRdata(Factory::Dname('foo.example.com.')); |
||
| 137 | |||
| 138 | $hinfo = new ResourceRecord(); |
||
| 139 | $hinfo->setName('@'); |
||
| 140 | $hinfo->setClass(Classes::INTERNET); |
||
| 141 | $hinfo->setRdata(Factory::HINFO('2.7GHz', 'Ubuntu 12.04')); |
||
| 142 | |||
| 143 | $srv = new ResourceRecord(); |
||
| 144 | $srv->setName('_ftp._tcp'); |
||
| 145 | $srv->setClass('IN'); |
||
| 146 | $srv->setRdata(Factory::SRV(10, 10, 21, 'files')); |
||
| 147 | |||
| 148 | $rrsig = new ResourceRecord(); |
||
| 149 | $rrsig->setName('example.com.'); |
||
| 150 | $rrsig->setRdata(Factory::RRSIG( |
||
| 151 | A::TYPE, |
||
| 152 | Algorithms::ECDSAP384SHA384, |
||
| 153 | 2, |
||
| 154 | 3600, |
||
| 155 | \DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20200112073532'), |
||
|
|
|||
| 156 | \DateTime::createFromFormat(RRSIG::TIME_FORMAT, '20191229133101'), |
||
| 157 | 12345, |
||
| 158 | 'example.com.', |
||
| 159 | base64_decode('bDts/7a5qbal6s3ZYzS5puPSjEfys5yI6R/kprBBRDEfVcT6YwPaDT3VkVjKXdvpKX2/DwpijNAWkjpfsewCLmeImx3RgkzfuxfipRKtBUguiPTBhkj/ft2halJziVXl') |
||
| 160 | )); |
||
| 161 | |||
| 162 | return new Zone('example.com.', 3600, [ |
||
| 163 | $soa, |
||
| 164 | $ns1, |
||
| 165 | $ns2, |
||
| 166 | $a_record, |
||
| 167 | $aaaa, |
||
| 168 | $loc, |
||
| 169 | $dname, |
||
| 170 | $mx3, |
||
| 171 | $mx1, |
||
| 172 | $mx2, |
||
| 173 | $cname, |
||
| 174 | $txt, |
||
| 175 | $hinfo, |
||
| 176 | $srv, |
||
| 177 | $rrsig, |
||
| 178 | ]); |
||
| 179 | } |
||
| 180 | } |
||
| 181 |