Conditions | 1 |
Paths | 1 |
Total Lines | 87 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
28 | private static function buildTestZone(): Zone |
||
29 | { |
||
30 | $zone = new Zone('example.com.'); |
||
31 | $zone->setDefaultTtl(3600); |
||
32 | |||
33 | $soa = new ResourceRecord(); |
||
34 | $soa->setName('@'); |
||
35 | $soa->setRdata(Factory::SOA( |
||
36 | '@', |
||
37 | 'post', |
||
38 | 2014110501, |
||
39 | 3600, |
||
40 | 14400, |
||
41 | 604800, |
||
42 | 3600 |
||
43 | )); |
||
44 | |||
45 | $soa->setClass(Classes::INTERNET); |
||
46 | |||
47 | $ns1 = new ResourceRecord(); |
||
48 | $ns1->setName('@'); |
||
49 | $ns1->setRdata(Factory::NS('ns1.nameserver.com.')); |
||
50 | |||
51 | $ns2 = new ResourceRecord(); |
||
52 | $ns2->setName('@'); |
||
53 | $ns2->setRdata(Factory::NS('ns2.nameserver.com.')); |
||
54 | |||
55 | $a = new ResourceRecord(); |
||
56 | $a->setName('sub.domain'); |
||
57 | $a->setRdata(Factory::A('192.168.1.42')); |
||
58 | $a->setComment('This is a local ip.'); |
||
59 | |||
60 | $a6 = new ResourceRecord(); |
||
61 | $a6->setName('ipv6.domain'); |
||
62 | $a6->setRdata(Factory::AAAA('::1')); |
||
63 | $a6->setComment('This is an IPv6 domain.'); |
||
64 | |||
65 | $mx1 = new ResourceRecord(); |
||
66 | $mx1->setName('@'); |
||
67 | $mx1->setRdata(Factory::MX(10, 'mail-gw1.example.net.')); |
||
68 | |||
69 | $mx2 = new ResourceRecord(); |
||
70 | $mx2->setName('@'); |
||
71 | $mx2->setRdata(Factory::MX(20, 'mail-gw2.example.net.')); |
||
72 | |||
73 | $mx3 = new ResourceRecord(); |
||
74 | $mx3->setName('@'); |
||
75 | $mx3->setRdata(Factory::MX(30, 'mail-gw3.example.net.')); |
||
76 | |||
77 | $loc = new ResourceRecord(); |
||
78 | $loc->setName('canberra'); |
||
79 | $loc->setRdata(Factory::LOC( |
||
80 | -35.3075, //Lat |
||
81 | 149.1244, //Lon |
||
82 | 500, //Alt |
||
83 | 20.12, //Size |
||
84 | 200.3, //HP |
||
85 | 300.1 //VP |
||
86 | )); |
||
87 | $loc->setComment('This is Canberra'); |
||
88 | |||
89 | $srv = new ResourceRecord(); |
||
90 | $srv->setName('_ftp._tcp'); |
||
91 | $srv->setClass('IN'); |
||
92 | $srv->setRdata(Factory::SRV(10, 10, 21, 'files')); |
||
93 | |||
94 | $zone->fromList($loc, $mx2, $srv); |
||
95 | $zone->addResourceRecord($soa); |
||
96 | $zone->addResourceRecord($ns1); |
||
97 | $zone->addResourceRecord($mx3); |
||
98 | $zone->addResourceRecord($a); |
||
99 | $zone->addResourceRecord($a6); |
||
100 | $zone->addResourceRecord($ns2); |
||
101 | $zone->addResourceRecord($mx1); |
||
102 | |||
103 | $apl = new APL(); |
||
104 | $apl->addAddressRange(IPBlock::create('192.168.0.0/23')); |
||
105 | $apl->addAddressRange(IPBlock::create('192.168.1.64/28'), false); |
||
106 | $apl->addAddressRange(IPBlock::create('2001:acad:1::/112'), true); |
||
107 | $apl->addAddressRange(IPBlock::create('2001:acad:1::8/128'), false); |
||
108 | |||
109 | $multicast = ResourceRecord::create('multicast', $apl); |
||
110 | |||
111 | $zone->addResourceRecord($multicast); |
||
112 | |||
113 | return $zone; |
||
114 | } |
||
115 | |||
191 |