Conditions | 1 |
Paths | 1 |
Total Lines | 79 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
55 | public function testWire1(): void |
||
56 | { |
||
57 | $data = $this->getWireTestData(1); |
||
58 | |||
59 | $msg = Message::fromWire($data); |
||
60 | |||
61 | $this->assertInstanceOf(Message::class, $msg); |
||
62 | |||
63 | $this->assertEquals(10, $msg->getId()); |
||
64 | $this->assertEquals(true, $msg->isResponse()); |
||
65 | $this->assertEquals(false, $msg->isQuery()); |
||
66 | $this->assertEquals(Opcode::QUERY, $msg->getOpcode()); |
||
67 | $this->assertEquals(true, $msg->isAuthoritative()); |
||
68 | $this->assertEquals(false, $msg->isTruncated()); |
||
69 | $this->assertEquals(true, $msg->isRecursionDesired()); |
||
70 | $this->assertEquals(true, $msg->isRecursionAvailable()); |
||
71 | $this->assertEquals(0, $msg->getBit9()); |
||
72 | $this->assertEquals(false, $msg->isAuthenticData()); |
||
73 | $this->assertEquals(false, $msg->isCheckingDisabled()); |
||
74 | $this->assertEquals(Rcode::NOERROR, $msg->getRcode()); |
||
75 | |||
76 | $this->assertEquals(1, $msg->countQuestions()); |
||
77 | $this->assertEquals(3, $msg->countAnswers()); |
||
78 | $this->assertEquals(0, $msg->countAuthoritatives()); |
||
79 | $this->assertEquals(3, $msg->countAdditionals()); |
||
80 | |||
81 | $question = $msg->getQuestions()[0]; |
||
82 | $this->assertEquals('vix.com.', $question->getName()); |
||
83 | $this->assertEquals(1, $question->getClassId()); |
||
84 | $this->assertEquals(2, $question->getTypeCode()); |
||
85 | |||
86 | $ns1 = $msg->getAnswers()[0]; |
||
87 | $this->assertInstanceOf(ResourceRecord::class, $ns1); |
||
88 | $this->assertEquals('vix.com.', $ns1->getName()); |
||
89 | $this->assertEquals(3600, $ns1->getTtl()); |
||
90 | $this->assertEquals(Classes::INTERNET, $ns1->getClass()); |
||
91 | $this->assertInstanceOf(NS::class, $ns1->getRdata()); |
||
92 | $this->assertEquals('isrv1.pa.vix.com.', $ns1->getRdata()->getTarget()); |
||
|
|||
93 | |||
94 | $ns2 = $msg->getAnswers()[1]; |
||
95 | $this->assertInstanceOf(ResourceRecord::class, $ns2); |
||
96 | $this->assertEquals('vix.com.', $ns2->getName()); |
||
97 | $this->assertEquals(3600, $ns2->getTtl()); |
||
98 | $this->assertEquals(Classes::INTERNET, $ns2->getClass()); |
||
99 | $this->assertInstanceOf(NS::class, $ns2->getRdata()); |
||
100 | $this->assertEquals('ns-ext.vix.com.', $ns2->getRdata()->getTarget()); |
||
101 | |||
102 | $ns3 = $msg->getAnswers()[2]; |
||
103 | $this->assertInstanceOf(ResourceRecord::class, $ns3); |
||
104 | $this->assertEquals('vix.com.', $ns3->getName()); |
||
105 | $this->assertEquals(3600, $ns3->getTtl()); |
||
106 | $this->assertEquals(Classes::INTERNET, $ns3->getClass()); |
||
107 | $this->assertInstanceOf(NS::class, $ns3->getRdata()); |
||
108 | $this->assertEquals('ns1.gnac.com.', $ns3->getRdata()->getTarget()); |
||
109 | |||
110 | $a1 = $msg->getAdditionals()[0]; |
||
111 | $this->assertInstanceOf(ResourceRecord::class, $a1); |
||
112 | $this->assertEquals('isrv1.pa.vix.com.', $a1->getName()); |
||
113 | $this->assertEquals(3600, $a1->getTtl()); |
||
114 | $this->assertEquals(Classes::INTERNET, $a1->getClass()); |
||
115 | $this->assertInstanceOf(A::class, $a1->getRdata()); |
||
116 | $this->assertEquals('204.152.184.134', $a1->getRdata()->getAddress()); |
||
117 | |||
118 | $a2 = $msg->getAdditionals()[1]; |
||
119 | $this->assertInstanceOf(ResourceRecord::class, $a2); |
||
120 | $this->assertEquals('ns-ext.vix.com.', $a2->getName()); |
||
121 | $this->assertEquals(3600, $a2->getTtl()); |
||
122 | $this->assertEquals(Classes::INTERNET, $a2->getClass()); |
||
123 | $this->assertInstanceOf(A::class, $a2->getRdata()); |
||
124 | $this->assertEquals('204.152.184.64', $a2->getRdata()->getAddress()); |
||
125 | |||
126 | $a3 = $msg->getAdditionals()[2]; |
||
127 | $this->assertInstanceOf(ResourceRecord::class, $a3); |
||
128 | $this->assertEquals('ns1.gnac.com.', $a3->getName()); |
||
129 | $this->assertEquals(172362, $a3->getTtl()); |
||
130 | $this->assertEquals(Classes::INTERNET, $a3->getClass()); |
||
131 | $this->assertInstanceOf(A::class, $a3->getRdata()); |
||
132 | $this->assertEquals('198.151.248.246', $a3->getRdata()->getAddress()); |
||
133 | } |
||
134 | |||
305 |
Let’s take a look at an example:
In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break.
Available Fixes
Change the type-hint for the parameter:
Add an additional type-check:
Add the method to the interface: