TextStringType - Code Metrics - Inspection of "Some work on the Info object" - Bacon/BaconPdf - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a05270...10fb5b )

by Ben

created 2015-11-28 01:15 UTC

TextStringType A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	25
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	2
c	1
b	0
f	0
lcom	1
cbo	2
dl	0
loc	25
rs	10

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	4	1
A	writeToStream()	0	6	1

<?php
/**
 * BaconPdf
 *
 * @link      http://github.com/Bacon/BaconPdf For the canonical source repository
 * @copyright 2015 Ben 'DASPRiD' Scholzen
 * @license   http://opensource.org/licenses/BSD-2-Clause Simplified BSD License
 */

namespace Bacon\Pdf\Type;

use Bacon\Pdf\Object\AbstractObject;
use Bacon\Pdf\Object\LiteralStringObject;
use SplFileObject;

/**
 * Text string type as defined by section 3.8.1
 */
class TextStringType extends AbstractObject
{
    /**
     * @var string
     */
    private $value;

    /**
     * @param string $value
     */
    public function __construct($value)
    {
        $this->value = $value;
    }

    /**
     * {@inheritdoc}
     */
    public function writeToStream(SplFileObject $fileObject, $encryptionKey)
    {
        (new LiteralStringObject(
            "\xfe\xff" . iconv('UTF-8', 'UTF-16BE', $this->value)
        ))->writeToStream($fileObject, $encryptionKey);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2			/**
3			* BaconPdf
4			*
5			* @link http://github.com/Bacon/BaconPdf For the canonical source repository
6			* @copyright 2015 Ben 'DASPRiD' Scholzen
7			* @license http://opensource.org/licenses/BSD-2-Clause Simplified BSD License
8			*/
9
10			namespace Bacon\Pdf\Type;
11
12			use Bacon\Pdf\Object\AbstractObject;
13			use Bacon\Pdf\Object\LiteralStringObject;
14			use SplFileObject;
15
16			/**
17			* Text string type as defined by section 3.8.1
18			*/
19			class TextStringType extends AbstractObject
20			{
21			/**
22			* @var string
23			*/
24			private $value;
25
26			/**
27			* @param string $value
28			*/
29			public function __construct($value)
30			{
31			$this->value = $value;
32			}
33
34			/**
35			* {@inheritdoc}
36			*/
37			public function writeToStream(SplFileObject $fileObject, $encryptionKey)
38			{
39			(new LiteralStringObject(
40			"\xfe\xff" . iconv('UTF-8', 'UTF-16BE', $this->value)
41			))->writeToStream($fileObject, $encryptionKey);
			0 ignored issues – show Documentation introduced 2015-11-28 01:18 UTC by Report Bug Copy Issue Report `$fileObject` is of type `object<SplFileObject>`, but the function expects a `object<Bacon\Pdf\Object\SplFileObject>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
42			}
43			}
44

Bacon / BaconPdf

Push — master ( a05270...10fb5b )

TextStringType A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like