Total Complexity | 41 |
Total Lines | 286 |
Duplicated Lines | 0 % |
Changes | 3 | ||
Bugs | 0 | Features | 1 |
Complex classes like Client often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Client, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
8 | final class Client implements ClientInterface |
||
9 | { |
||
10 | const API_URL_SCHEMA = 'https'; |
||
11 | |||
12 | /** |
||
13 | * API BASE URL without authentication query parameter |
||
14 | * https://api.deepl.com/v2/[resource] |
||
15 | */ |
||
16 | const API_URL_BASE_NO_AUTH = '%s://%s/v%s/%s'; |
||
17 | |||
18 | /** |
||
19 | * DeepL API Version (v2 is default since 2018) |
||
20 | * |
||
21 | * @var integer |
||
22 | */ |
||
23 | protected $apiVersion; |
||
24 | |||
25 | /** |
||
26 | * DeepL API Auth Key (DeepL Pro access required) |
||
27 | * |
||
28 | * @var string |
||
29 | */ |
||
30 | protected $authKey; |
||
31 | |||
32 | /** |
||
33 | * cURL resource |
||
34 | * |
||
35 | * @var resource |
||
36 | */ |
||
37 | protected $curl; |
||
38 | |||
39 | /** |
||
40 | * Hostname of the API (in most cases api.deepl.com) |
||
41 | * |
||
42 | * @var string |
||
43 | */ |
||
44 | protected $host; |
||
45 | |||
46 | /** |
||
47 | * Maximum number of seconds the query should take |
||
48 | * |
||
49 | * @var int|null |
||
50 | */ |
||
51 | protected $timeout = null; |
||
52 | |||
53 | /** |
||
54 | * URL of the proxy used to connect to DeepL (if needed) |
||
55 | * |
||
56 | * @var string|null |
||
57 | */ |
||
58 | protected $proxy = null; |
||
59 | |||
60 | /** |
||
61 | * Credentials for the proxy used to connect to DeepL (username:password) |
||
62 | * |
||
63 | * @var string|null |
||
64 | */ |
||
65 | protected $proxyCredentials = null; |
||
66 | |||
67 | /** |
||
68 | * DeepL constructor |
||
69 | * |
||
70 | * @param string $authKey |
||
71 | * @param integer $apiVersion |
||
72 | * @param string $host |
||
73 | */ |
||
74 | public function __construct($authKey, $apiVersion = 2, $host = 'api.deepl.com') |
||
75 | { |
||
76 | $this->authKey = $authKey; |
||
77 | $this->apiVersion = $apiVersion; |
||
78 | $this->host = $host; |
||
79 | $this->curl = curl_init(); |
||
|
|||
80 | |||
81 | curl_setopt($this->curl, CURLOPT_RETURNTRANSFER, 1); |
||
82 | } |
||
83 | |||
84 | /** |
||
85 | * DeepL destructor |
||
86 | */ |
||
87 | public function __destruct() |
||
88 | { |
||
89 | if ($this->curl && is_resource($this->curl)) { |
||
90 | curl_close($this->curl); |
||
91 | } |
||
92 | } |
||
93 | |||
94 | /** |
||
95 | * Make a request to the given URL |
||
96 | * |
||
97 | * @param string $url |
||
98 | * @param string $body |
||
99 | * @param string $method |
||
100 | * |
||
101 | * @return array |
||
102 | * |
||
103 | * @throws DeepLException |
||
104 | */ |
||
105 | public function request($url, $body = '', $method = 'POST') |
||
106 | { |
||
107 | switch ($method) { |
||
108 | case 'DELETE': |
||
109 | curl_setopt($this->curl, CURLOPT_CUSTOMREQUEST, 'DELETE'); |
||
110 | break; |
||
111 | case 'POST': |
||
112 | curl_setopt($this->curl, CURLOPT_POST, true); |
||
113 | curl_setopt($this->curl, CURLOPT_POSTFIELDS, $body); |
||
114 | break; |
||
115 | case 'GET': |
||
116 | default: |
||
117 | break; |
||
118 | } |
||
119 | |||
120 | curl_setopt($this->curl, CURLOPT_URL, $url); |
||
121 | |||
122 | curl_setopt($this->curl, CURLOPT_HTTPHEADER, ['Content-Type: application/x-www-form-urlencoded']); |
||
123 | curl_setopt($this->curl, CURLOPT_HTTPHEADER, ['Authorization: DeepL-Auth-Key ' . $this->authKey]); |
||
124 | |||
125 | if ($this->proxy !== null) { |
||
126 | curl_setopt($this->curl, CURLOPT_PROXY, $this->proxy); |
||
127 | } |
||
128 | |||
129 | if ($this->proxyCredentials !== null) { |
||
130 | curl_setopt($this->curl, CURLOPT_PROXYAUTH, $this->proxyCredentials); |
||
131 | } |
||
132 | |||
133 | if ($this->timeout !== null) { |
||
134 | curl_setopt($this->curl, CURLOPT_TIMEOUT, $this->timeout); |
||
135 | } |
||
136 | |||
137 | $response = curl_exec($this->curl); |
||
138 | |||
139 | if (curl_errno($this->curl)) { |
||
140 | throw new DeepLException('There was a cURL Request Error : ' . curl_error($this->curl)); |
||
141 | } |
||
142 | $httpCode = curl_getinfo($this->curl, CURLINFO_HTTP_CODE); |
||
143 | |||
144 | return $this->handleResponse($response, $httpCode); |
||
145 | } |
||
146 | |||
147 | /** |
||
148 | * Set a proxy to use for querying the DeepL API if needed |
||
149 | * |
||
150 | * @param string $proxy Proxy URL (e.g 'http://proxy-domain.com:3128') |
||
151 | */ |
||
152 | public function setProxy($proxy) |
||
153 | { |
||
154 | $this->proxy = $proxy; |
||
155 | } |
||
156 | |||
157 | /** |
||
158 | * Set the proxy credentials |
||
159 | * |
||
160 | * @param string $proxyCredentials proxy credentials (using 'username:password' format) |
||
161 | */ |
||
162 | public function setProxyCredentials($proxyCredentials) |
||
163 | { |
||
164 | $this->proxyCredentials = $proxyCredentials; |
||
165 | } |
||
166 | |||
167 | /** |
||
168 | * Set a timeout for queries to the DeepL API |
||
169 | * |
||
170 | * @param int $timeout Timeout in seconds |
||
171 | */ |
||
172 | public function setTimeout($timeout) |
||
173 | { |
||
174 | $this->timeout = $timeout; |
||
175 | } |
||
176 | |||
177 | /** |
||
178 | * Creates the Base-Url which all the API-resources have in common. |
||
179 | * |
||
180 | * @param string $resource |
||
181 | * @param bool $withAuth |
||
182 | * |
||
183 | * @return string |
||
184 | */ |
||
185 | public function buildBaseUrl(string $resource = 'translate'): string |
||
193 | ); |
||
194 | } |
||
195 | |||
196 | /** |
||
197 | * @param array $paramsArray |
||
198 | * |
||
199 | * @return string |
||
200 | */ |
||
201 | public function buildQuery($paramsArray) |
||
225 | } |
||
226 | |||
227 | /** |
||
228 | * Handles the different kind of response returned from API, array, string or null |
||
229 | * |
||
230 | * @param $response |
||
231 | * @param $httpCode |
||
232 | * |
||
233 | * @return array|mixed|null |
||
234 | * |
||
235 | * @throws DeepLException |
||
236 | */ |
||
237 | private function handleResponse($response, $httpCode) |
||
296 |
Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly.
For example, imagine you have a variable
$accountId
that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to theid
property of an instance of theAccount
class. This class holds a proper account, so the id value must no longer be false.Either this assignment is in error or a type check should be added for that assignment.