SimpleReaderTest - Code Metrics - Inspection of "Add tests" - Babacooll/TextFile - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 28b764...a7b092 )

by Michaël

created 2016-03-05 12:50 UTC

SimpleReaderTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	222
Duplicated Lines	9.91 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
wmc	14
c	1
b	0
f	1
lcom	1
cbo	3
dl	22
loc	222
rs	10

14 Methods

Rating	Name	Duplication	Size	Complexity
A	testGetLinesRange()	0	12	1
A	testGetNextLineContentFromStart()	0	13	1
A	testGetNextLineContent()	0	15	1
A	testGetNextLineContentOutOfBounds()	11	11	1
A	testGetPreviousLineContent()	0	15	1
A	testGetPreviousLineContentOutOfBounds()	11	11	1
A	testGetCurrentLineContent()	0	15	1
A	testGetLineContent()	0	9	1
A	testGetLineContentOutOfBoundsTooHigh()	0	9	1
A	testGetLineContentOutOfBoundsTooLow()	0	9	1
A	testGetNextCharacterContent()	0	11	1
A	testGetPreviousCharacterContent()	0	11	1
A	testGetCharacterContent()	0	9	1
A	testCleanLineContent()	0	6	1

How to fix Duplicated Code

<?php

namespace TextFile\Tests\Reader;

use TextFile\Reader\SimpleReader;
use TextFile\Tests\TextFileTestCase;
use TextFile\Walker\SimpleWalker;

/**
 * Class SimpleReaderTest
 *
 * @package TextFile\Tests\Reader
 */
class SimpleReaderTest extends TextFileTestCase
{
    /**
     * @covers TextFile\Reader\SimpleReader::getLinesRange
     */
    public function testGetLinesRange()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');
        $range    = $reader->getLinesRange($file, 0, 2);

        $this->assertInstanceOf('\LimitIterator', $range);

        $this->assertCount(2, $range);
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getNextLineContent
     */
    public function testGetNextLineContentFromStart()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $this->assertEquals('second', $reader->getNextLineContent($file));

        // Test if pointer is correctly reset

        $this->assertEquals('second', $reader->getNextLineContent($file));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getNextLineContent
     */
    public function testGetNextLineContent()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $file->seek(2);

        $this->assertEquals('fourth', $reader->getNextLineContent($file));

        // Test if pointer is correctly reset

        $this->assertEquals('fourth', $reader->getNextLineContent($file));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getNextLineContent
     *
     * @expectedException \TextFile\Exception\OutOfBoundsException
     */
    public function testGetNextLineContentOutOfBounds()

    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $file->seek(5);

        $reader->getNextLineContent($file);
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getPreviousLineContent
     */
    public function testGetPreviousLineContent()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $file->seek(2);

        $this->assertEquals('second', $reader->getPreviousLineContent($file));

        // Test if pointer is correctly reset

        $this->assertEquals('second', $reader->getPreviousLineContent($file));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getPreviousLineContent
     *
     * @expectedException \TextFile\Exception\OutOfBoundsException
     */
    public function testGetPreviousLineContentOutOfBounds()

    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $file->seek(0);

        $reader->getPreviousLineContent($file);
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getCurrentLineContent
     */
    public function testGetCurrentLineContent()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $file->seek(2);

        $this->assertEquals('third', $reader->getCurrentLineContent($file));

        // Test if pointer is correctly reset

        $this->assertEquals('third', $reader->getCurrentLineContent($file));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getLineContent
     */
    public function testGetLineContent()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $this->assertEquals('third', $reader->getLineContent($file, 2));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getLineContent
     *
     * @expectedException \TextFile\Exception\OutOfBoundsException
     */
    public function testGetLineContentOutOfBoundsTooHigh()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $this->assertEquals('third', $reader->getLineContent($file, 9));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getLineContent
     *
     * @expectedException \TextFile\Exception\OutOfBoundsException
     */
    public function testGetLineContentOutOfBoundsTooLow()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $this->assertEquals('third', $reader->getLineContent($file, -1));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getNextCharacterContent
     */
    public function testGetNextCharacterContent()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $file->fseek(2);

        $this->assertEquals('r', $reader->getNextCharacterContent($file));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getPreviousCharacterContent
     */
    public function testGetPreviousCharacterContent()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $file->fseek(2);

        $this->assertEquals('i', $reader->getPreviousCharacterContent($file));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getCharacterContent
     */
    public function testGetCharacterContent()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
        $file     = new \SplFileObject($filePath, 'r+');

        $this->assertEquals('r', $reader->getCharacterContent($file, 2));
    }

    /**
     * @covers TextFile\Reader\SimpleReader::getPreviousCharacterContent
     */
    public function testCleanLineContent()
    {
        $reader = new SimpleReader(new SimpleWalker());

        $this->assertEmpty($reader->cleanLineContent(PHP_EOL));
    }
}


1		<?php
2
3		namespace TextFile\Tests\Reader;
4
5		use TextFile\Reader\SimpleReader;
6		use TextFile\Tests\TextFileTestCase;
7		use TextFile\Walker\SimpleWalker;
8
9		/**
10		* Class SimpleReaderTest
11		*
12		* @package TextFile\Tests\Reader
13		*/
14		class SimpleReaderTest extends TextFileTestCase
15		{
16		/**
17		* @covers TextFile\Reader\SimpleReader::getLinesRange
18		*/
19		public function testGetLinesRange()
20		{
21		$reader = new SimpleReader(new SimpleWalker());
22
23		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
24		$file = new \SplFileObject($filePath, 'r+');
25		$range = $reader->getLinesRange($file, 0, 2);
26
27		$this->assertInstanceOf('\LimitIterator', $range);
28
29		$this->assertCount(2, $range);
30		}
31
32		/**
33		* @covers TextFile\Reader\SimpleReader::getNextLineContent
34		*/
35		public function testGetNextLineContentFromStart()
36		{
37		$reader = new SimpleReader(new SimpleWalker());
38
39		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
40		$file = new \SplFileObject($filePath, 'r+');
41
42		$this->assertEquals('second', $reader->getNextLineContent($file));
43
44		// Test if pointer is correctly reset
45
46		$this->assertEquals('second', $reader->getNextLineContent($file));
47		}
48
49		/**
50		* @covers TextFile\Reader\SimpleReader::getNextLineContent
51		*/
52		public function testGetNextLineContent()
53		{
54		$reader = new SimpleReader(new SimpleWalker());
55
56		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
57		$file = new \SplFileObject($filePath, 'r+');
58
59		$file->seek(2);
60
61		$this->assertEquals('fourth', $reader->getNextLineContent($file));
62
63		// Test if pointer is correctly reset
64
65		$this->assertEquals('fourth', $reader->getNextLineContent($file));
66		}
67
68		/**
69		* @covers TextFile\Reader\SimpleReader::getNextLineContent
70		*
71		* @expectedException \TextFile\Exception\OutOfBoundsException
72		*/
73	View Code Duplication	public function testGetNextLineContentOutOfBounds()
		0 ignored issues – show Duplication introduced 2016-03-05 12:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
74		{
75		$reader = new SimpleReader(new SimpleWalker());
76
77		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
78		$file = new \SplFileObject($filePath, 'r+');
79
80		$file->seek(5);
81
82		$reader->getNextLineContent($file);
83		}
84
85		/**
86		* @covers TextFile\Reader\SimpleReader::getPreviousLineContent
87		*/
88		public function testGetPreviousLineContent()
89		{
90		$reader = new SimpleReader(new SimpleWalker());
91
92		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
93		$file = new \SplFileObject($filePath, 'r+');
94
95		$file->seek(2);
96
97		$this->assertEquals('second', $reader->getPreviousLineContent($file));
98
99		// Test if pointer is correctly reset
100
101		$this->assertEquals('second', $reader->getPreviousLineContent($file));
102		}
103
104		/**
105		* @covers TextFile\Reader\SimpleReader::getPreviousLineContent
106		*
107		* @expectedException \TextFile\Exception\OutOfBoundsException
108		*/
109	View Code Duplication	public function testGetPreviousLineContentOutOfBounds()
		0 ignored issues – show Duplication introduced 2016-03-05 12:53 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
110		{
111		$reader = new SimpleReader(new SimpleWalker());
112
113		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
114		$file = new \SplFileObject($filePath, 'r+');
115
116		$file->seek(0);
117
118		$reader->getPreviousLineContent($file);
119		}
120
121		/**
122		* @covers TextFile\Reader\SimpleReader::getCurrentLineContent
123		*/
124		public function testGetCurrentLineContent()
125		{
126		$reader = new SimpleReader(new SimpleWalker());
127
128		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
129		$file = new \SplFileObject($filePath, 'r+');
130
131		$file->seek(2);
132
133		$this->assertEquals('third', $reader->getCurrentLineContent($file));
134
135		// Test if pointer is correctly reset
136
137		$this->assertEquals('third', $reader->getCurrentLineContent($file));
138		}
139
140		/**
141		* @covers TextFile\Reader\SimpleReader::getLineContent
142		*/
143		public function testGetLineContent()
144		{
145		$reader = new SimpleReader(new SimpleWalker());
146
147		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
148		$file = new \SplFileObject($filePath, 'r+');
149
150		$this->assertEquals('third', $reader->getLineContent($file, 2));
151		}
152
153		/**
154		* @covers TextFile\Reader\SimpleReader::getLineContent
155		*
156		* @expectedException \TextFile\Exception\OutOfBoundsException
157		*/
158		public function testGetLineContentOutOfBoundsTooHigh()
159		{
160		$reader = new SimpleReader(new SimpleWalker());
161
162		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
163		$file = new \SplFileObject($filePath, 'r+');
164
165		$this->assertEquals('third', $reader->getLineContent($file, 9));
166		}
167
168		/**
169		* @covers TextFile\Reader\SimpleReader::getLineContent
170		*
171		* @expectedException \TextFile\Exception\OutOfBoundsException
172		*/
173		public function testGetLineContentOutOfBoundsTooLow()
174		{
175		$reader = new SimpleReader(new SimpleWalker());
176
177		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
178		$file = new \SplFileObject($filePath, 'r+');
179
180		$this->assertEquals('third', $reader->getLineContent($file, -1));
181		}
182
183		/**
184		* @covers TextFile\Reader\SimpleReader::getNextCharacterContent
185		*/
186		public function testGetNextCharacterContent()
187		{
188		$reader = new SimpleReader(new SimpleWalker());
189
190		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
191		$file = new \SplFileObject($filePath, 'r+');
192
193		$file->fseek(2);
194
195		$this->assertEquals('r', $reader->getNextCharacterContent($file));
196		}
197
198		/**
199		* @covers TextFile\Reader\SimpleReader::getPreviousCharacterContent
200		*/
201		public function testGetPreviousCharacterContent()
202		{
203		$reader = new SimpleReader(new SimpleWalker());
204
205		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
206		$file = new \SplFileObject($filePath, 'r+');
207
208		$file->fseek(2);
209
210		$this->assertEquals('i', $reader->getPreviousCharacterContent($file));
211		}
212
213		/**
214		* @covers TextFile\Reader\SimpleReader::getCharacterContent
215		*/
216		public function testGetCharacterContent()
217		{
218		$reader = new SimpleReader(new SimpleWalker());
219
220		$filePath = $this->createTestFileFromFixtures('complex_multiline_file.txt');
221		$file = new \SplFileObject($filePath, 'r+');
222
223		$this->assertEquals('r', $reader->getCharacterContent($file, 2));
224		}
225
226		/**
227		* @covers TextFile\Reader\SimpleReader::getPreviousCharacterContent
228		*/
229		public function testCleanLineContent()
230		{
231		$reader = new SimpleReader(new SimpleWalker());
232
233		$this->assertEmpty($reader->cleanLineContent(PHP_EOL));
234		}
235		}
236

Babacooll / TextFile

Push — master ( 28b764...a7b092 )

SimpleReaderTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like