Native::initialize() - Code Metrics - Inspection of "Add Drupal 8 support" - BR0kEN-/TqExtension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#16)

by Sergii

created 2017-02-27 20:45 UTC

Native::initialize() A

↳ Parent: Native

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	6
nc	2
nop	0

<?php
/**
 * @author Sergii Bondarenko, <[email protected]>
 */
namespace Drupal\TqExtension\Utils\DatePicker;

class Native extends DatePickerBase
{
    /**
     * @var string
     */
    private $format = '';
    /**
     * @var string
     */
    private $time = '';
    /**
     * @var string
     */
    private $formatted = '';

    /**
     * {@inheritdoc}
     */
    public function initialize()
    {
        $this->format = $this->jQuery("data('drupalDateFormat')");

        if (empty($this->format)) {
            throw new \RuntimeException('Unknown date format.');
        }

        $this->time = strtotime($this->date);
$answer = 42;

$correct = false;

$correct = (bool) $answer;
        $this->formatted = date($this->format, $this->time);
    }

    /**
     * {@inheritdoc}
     */
    public function isDateAvailable()
    {
        $ranges = [];

        foreach (['min', 'max'] as $range) {
            $value = $this->element->getAttribute($range);
            // If no range was set then use the original date as its value.
            $ranges[$range] = null === $value ? $this->time : strtotime($value);
        }

        if ($this->time < $ranges['min'] || $this->time > $ranges['max']) {
            throw new \Exception(sprintf('The "%s" is not available for choosing.', $this->date));
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function setDate()
    {
        $this->jQuery("val('$this->formatted')");

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function isDateSelected()
    {
        $value = $this->jQuery('val()');

        self::debug(['Comparing "%s" with "%s".'], [$value, $this->formatted]);

        if ($value !== $this->formatted) {
            throw new \Exception(sprintf('DatePicker contains the "%s" but should "%s".', $value, $this->formatted));
        }

        return $this;
    }
}


1			<?php
2			/**
3			* @author Sergii Bondarenko, <[email protected]>
4			*/
5			namespace Drupal\TqExtension\Utils\DatePicker;
6
7			class Native extends DatePickerBase
8			{
9			/**
10			* @var string
11			*/
12			private $format = '';
13			/**
14			* @var string
15			*/
16			private $time = '';
17			/**
18			* @var string
19			*/
20			private $formatted = '';
21
22			/**
23			* {@inheritdoc}
24			*/
25			public function initialize()
26			{
27			$this->format = $this->jQuery("data('drupalDateFormat')");
28
29			if (empty($this->format)) {
30			throw new \RuntimeException('Unknown date format.');
31			}
32
33			$this->time = strtotime($this->date);
			0 ignored issues – show Documentation Bug introduced 2017-02-19 14:41 UTC by Report Bug Copy Issue Report The property `$time` was declared of type `string`, but `strtotime($this->date)` is of type `integer`. Maybe add a type cast? This check looks for assignments to scalar types that may be of the wrong type. To ensure the code behaves as expected, it may be a good idea to add an explicit type cast. $answer = 42; $correct = false; $correct = (bool) $answer; Loading history...
34			$this->formatted = date($this->format, $this->time);
35			}
36
37			/**
38			* {@inheritdoc}
39			*/
40			public function isDateAvailable()
41			{
42			$ranges = [];
43
44			foreach (['min', 'max'] as $range) {
45			$value = $this->element->getAttribute($range);
46			// If no range was set then use the original date as its value.
47			$ranges[$range] = null === $value ? $this->time : strtotime($value);
48			}
49
50			if ($this->time < $ranges['min'] \|\| $this->time > $ranges['max']) {
51			throw new \Exception(sprintf('The "%s" is not available for choosing.', $this->date));
52			}
53
54			return $this;
55			}
56
57			/**
58			* {@inheritdoc}
59			*/
60			public function setDate()
61			{
62			$this->jQuery("val('$this->formatted')");
63
64			return $this;
65			}
66
67			/**
68			* {@inheritdoc}
69			*/
70			public function isDateSelected()
71			{
72			$value = $this->jQuery('val()');
73
74			self::debug(['Comparing "%s" with "%s".'], [$value, $this->formatted]);
75
76			if ($value !== $this->formatted) {
77			throw new \Exception(sprintf('DatePicker contains the "%s" but should "%s".', $value, $this->formatted));
78			}
79
80			return $this;
81			}
82			}
83

BR0kEN- / TqExtension

Pull Request — master (#16)

Native::initialize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like