NodeContext::iVisitNodePageOfType() - Code Metrics - Inspection of "Add node context to facilitate node operations" - BR0kEN-/TqExtension - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#6)

unknown

created 2016-04-05 07:32 UTC

NodeContext::iVisitNodePageOfType() B

↳ Parent: NodeContext

Complexity

Conditions	3
Paths	4

Size

Total Lines	24
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	24
rs	8.9713
cc	3
eloc	17
nc	4
nop	3

<?php
/**
 * @author Sergii Bondarenko, <[email protected]>
 */
namespace Drupal\TqExtension\Context\Node;

use Drupal\TqExtension\Context\RawTqContext;

class NodeContext extends RawTqContext
{
    /**
     * @When /^I (visit|view|edit) "([^"]+)" node of type "([^"]+)"$/
     */
    public function iVisitNodePageOfType($operation, $title, $type) {
        if ($operation == 'visit') {
            $operation = 'view';
        }
        $query = new \EntityFieldQuery();
        $result = $query
            ->entityCondition('entity_type', 'node')
            // @todo: Add support for CT label.
            ->entityCondition('bundle', strtolower($type))
            ->propertyCondition('title', $title)
            ->range(0, 1)
            ->execute();

        if (empty($result['node'])) {
            $params = array(
                '@title' => $title,
                '@type' => $type,
            );
            throw new \Exception(format_string("Node @title of @type not found.", $params));
        }

        $nid = key($result['node']);
        $this->getSession()->visit($this->locatePath('/node/' . $nid . '/' . $operation));
    }

    /**
     * @When I edit this node
     */
    public function iEditThisNode()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (preg_match("@node/(\d+)@", $_GET['q'], $matches)) {
            $this->getSession()->visit($this->locatePath('/node/' . $matches[1] . '/edit'));
        }
        else {
            throw new \Exception("You're not currently on a node page.");
        }
    }
}


1			<?php
2			/**
3			* @author Sergii Bondarenko, <[email protected]>
4			*/
5			namespace Drupal\TqExtension\Context\Node;
6
7			use Drupal\TqExtension\Context\RawTqContext;
8
9			class NodeContext extends RawTqContext
10			{
11			/**
12			* @When /^I (visit\|view\|edit) "([^"]+)" node of type "([^"]+)"$/
13			*/
14			public function iVisitNodePageOfType($operation, $title, $type) {
15			if ($operation == 'visit') {
16			$operation = 'view';
17			}
18			$query = new \EntityFieldQuery();
19			$result = $query
20			->entityCondition('entity_type', 'node')
21			// @todo: Add support for CT label.
22			->entityCondition('bundle', strtolower($type))
23			->propertyCondition('title', $title)
24			->range(0, 1)
25			->execute();
26
27			if (empty($result['node'])) {
28			$params = array(
29			'@title' => $title,
30			'@type' => $type,
31			);
32			throw new \Exception(format_string("Node @title of @type not found.", $params));
33			}
34
35			$nid = key($result['node']);
36			$this->getSession()->visit($this->locatePath('/node/' . $nid . '/' . $operation));
37			}
38
39			/**
40			* @When I edit this node
41			*/
42			public function iEditThisNode()
			0 ignored issues – show Coding Style introduced 2016-04-05 07:34 UTC by Report Bug Copy Issue Report `iEditThisNode` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
43			{
44			if (preg_match("@node/(\d+)@", $_GET['q'], $matches)) {
45			$this->getSession()->visit($this->locatePath('/node/' . $matches[1] . '/edit'));
46			}
47			else {
48			throw new \Exception("You're not currently on a node page.");
49			}
50			}
51			}
52

BR0kEN- / TqExtension

Pull Request — master (#6)

NodeContext::iVisitNodePageOfType() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like