RawUserContext - Code Metrics - BR0kEN-/TqExtension - Measure and Improve Code Quality continuously with Scrutinizer

RawUserContext A
last analyzed 2018-03-22 11:11 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	214
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	9

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	25
lcom	2
cbo	9
dl	0
loc	214
ccs	0
cts	97
cp	0
rs	10
c	0
b	0
f	0

9 Methods

Rating	Name	Size	Complexity
A	entityType()	4	1
A	getCurrentId()	4	2
A	getIdByArguments()	6	1
A	createUserWithRoles()	11	2
A	loginUser()	13	2
B	fillLoginForm()	25	4
A	isLoggedIn()	13	2
A	logoutUser()	6	2
C	createTestUser()	66	9

<?php
/**
 * @author Sergii Bondarenko, <[email protected]>
 */
namespace Drupal\TqExtension\Context\User;

// Contexts.
use Drupal\TqExtension\Context\RawTqContext;
// Utils.
use Drupal\TqExtension\Utils\BaseEntity;
use Drupal\TqExtension\Utils\Database\FetchField;
use Drupal\TqExtension\Utils\EntityDrupalWrapper;

class RawUserContext extends RawTqContext
{
    use BaseEntity;

    /**
     * {@inheritdoc}
     */
    protected function entityType()
    {
        return 'user';
    }

    /**
     * {@inheritdoc}
     */
    public function getCurrentId()
    {
        return empty($this->user->uid) ? 0 : $this->user->uid;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * @param string $column
     *   Column of a "users" table.
     * @param string $value
     *   Expected value in column.
     *
     * @return int
     */
    public function getIdByArguments($column, $value)
    {
        return (new FetchField('users', 'uid'))
            ->condition($column, $value)
            ->execute();
    }

    /**
     * @param string $roles
     *   Necessary user roles separated by comma.
     * @param array $fields
     *
     * @return \stdClass
     */
    public function createUserWithRoles($roles, array $fields = [])
    {
        $user = $this->createTestUser($fields);
        $driver = $this->getDriver();

        foreach (array_map('trim', explode(',', $roles)) as $role) {
            $driver->userAddRole($user, $role);
        }

        return $user;
    }

    /**
     * @throws \Exception
     */
    public function loginUser()
    {
        $this->logoutUser();

        if (empty($this->user)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            throw new \Exception('Tried to login without a user.');
        }

        $this->fillLoginForm([
            'username' => $this->user->name,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'password' => $this->user->pass,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        ]);
    }

    /**
     * @param array $props
     *   An array with two keys: "username" and "password". Both of them are required.
     * @param string $message
     *   An error message, that will be thrown when user cannot be authenticated.
     *
     * @throws \Behat\Mink\Exception\ElementNotFoundException
     *   When one of a fields cannot be not found.
     * @throws \Exception
     *   When login process failed.
     * @throws \WebDriver\Exception\NoSuchElement
     *   When log in button cannot be found.
     */
    public function fillLoginForm(array $props, $message = '')
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->visitPath('/user/login');
        $formContext = $this->getFormContext();

        foreach (['username', 'password'] as $prop) {
            $formContext->fillField($this->getDrupalText($prop . '_field'), $props[$prop]);
        }

        $this->getWorkingElement()->pressButton($this->getDrupalText('log_in'));

        if (!$this->isLoggedIn()) {
            if (empty($message)) {
                $message = sprintf(
                    'Failed to login as a user "%s" with password "%s".',
                    $props['username'],
                    $props['password']
                );
            }

            throw new \Exception($message);
        }

        $GLOBALS['user'] = $this->user = user_load_by_name($props['username']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * Cookies are set when at least one page of the site has been visited. This
     * action done in "beforeScenario" hook of TqContext.
     *
     * @see TqContext::beforeScenario()
     *
     * @return bool
     */
    public function isLoggedIn()
    {
        $cookieName = session_name();
        $cookie = $this->getSession()->getCookie($cookieName);

        if (null !== $cookie) {
            $this->getSession('goutte')->setCookie($cookieName, $cookie);

            return true;
        }

        return false;
    }

    public function logoutUser()
    {
        if ($this->isLoggedIn()) {
            $this->logout();
        }
    }

    /**
     * @param array $fields
     *   Additional data for user account.
     *
     * @throws \Exception
     *
     * @return \stdClass
     */
    public function createTestUser(array $fields = [])
    {
        $random = $this->getRandom();
        $username = $random->name(8);
        $user = [
            'uid' => 0,
            'name' => $username,
            'pass' => $random->name(16),
            'mail' => "[email protected]",
            'roles' => [
                DRUPAL_AUTHENTICATED_RID => 'authenticated user',
            ],
        ];

        $user = (object) $user;

        if (!empty($fields)) {
            $entity = new EntityDrupalWrapper('user');
            $required = $entity->getRequiredFields();

            // Fill fields. Field can be found by name or label.
            foreach ($fields as $field_name => $value) {
                $field_info = $entity->getFieldInfo($field_name);

                if (!empty($field_info)) {
                    $field_name = $field_info['field_name'];
                }

                $user->$field_name = $value;

                // Remove field from $required if it was there and filled.
                unset($required[$field_name]);
            }

            // Throw an exception when one of required fields was not filled.
            if (!empty($required)) {
                throw new \Exception(sprintf(
                    'The following fields "%s" are required and has not filled.',
                    implode('", "', $required)
                ));
            }
        }

        if (isset($user->name)) {
            $existing_user = user_load_by_name($user->name);

            if (!empty($existing_user)) {
                user_delete($existing_user->uid);
            }
        }

        // $this->user always exist but when no user created it has "false" as a value.
        // Variable stored to another because RawDrupalContext::userCreate() will modify
        // it and this will affect for future actions.
        if (!empty($this->user)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $tmp = $this->user;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        $this->userCreate($user);

        if (isset($tmp)) {
            $this->user = $tmp;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        return $user;
    }
}


1			<?php
2			/**
3			* @author Sergii Bondarenko, <[email protected]>
4			*/
5			namespace Drupal\TqExtension\Context\User;
6
7			// Contexts.
8			use Drupal\TqExtension\Context\RawTqContext;
9			// Utils.
10			use Drupal\TqExtension\Utils\BaseEntity;
11			use Drupal\TqExtension\Utils\Database\FetchField;
12			use Drupal\TqExtension\Utils\EntityDrupalWrapper;
13
14			class RawUserContext extends RawTqContext
15			{
16			use BaseEntity;
17
18			/**
19			* {@inheritdoc}
20			*/
21			protected function entityType()
22			{
23			return 'user';
24			}
25
26			/**
27			* {@inheritdoc}
28			*/
29			public function getCurrentId()
30			{
31			return empty($this->user->uid) ? 0 : $this->user->uid;
			0 ignored issues – show Documentation introduced 2018-03-14 13:58 UTC by Report Bug Copy Issue Report The property `user` does not exist on `object<Drupal\TqExtensio...xt\User\RawUserContext>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
32			}
33
34			/**
35			* @param string $column
36			* Column of a "users" table.
37			* @param string $value
38			* Expected value in column.
39			*
40			* @return int
41			*/
42			public function getIdByArguments($column, $value)
43			{
44			return (new FetchField('users', 'uid'))
45			->condition($column, $value)
46			->execute();
47			}
48
49			/**
50			* @param string $roles
51			* Necessary user roles separated by comma.
52			* @param array $fields
53			*
54			* @return \stdClass
55			*/
56			public function createUserWithRoles($roles, array $fields = [])
57			{
58			$user = $this->createTestUser($fields);
59			$driver = $this->getDriver();
60
61			foreach (array_map('trim', explode(',', $roles)) as $role) {
62			$driver->userAddRole($user, $role);
63			}
64
65			return $user;
66			}
67
68			/**
69			* @throws \Exception
70			*/
71			public function loginUser()
72			{
73			$this->logoutUser();
74
75			if (empty($this->user)) {
			0 ignored issues – show Documentation introduced 2018-03-14 13:58 UTC by Report Bug Copy Issue Report The property `user` does not exist on `object<Drupal\TqExtensio...xt\User\RawUserContext>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
76			throw new \Exception('Tried to login without a user.');
77			}
78
79			$this->fillLoginForm([
80			'username' => $this->user->name,
			0 ignored issues – show Documentation introduced 2018-03-14 13:58 UTC by Report Bug Copy Issue Report The property `user` does not exist on `object<Drupal\TqExtensio...xt\User\RawUserContext>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
81			'password' => $this->user->pass,
			0 ignored issues – show Documentation introduced 2018-03-14 13:58 UTC by Report Bug Copy Issue Report The property `user` does not exist on `object<Drupal\TqExtensio...xt\User\RawUserContext>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
82			]);
83			}
84
85			/**
86			* @param array $props
87			* An array with two keys: "username" and "password". Both of them are required.
88			* @param string $message
89			* An error message, that will be thrown when user cannot be authenticated.
90			*
91			* @throws \Behat\Mink\Exception\ElementNotFoundException
92			* When one of a fields cannot be not found.
93			* @throws \Exception
94			* When login process failed.
95			* @throws \WebDriver\Exception\NoSuchElement
96			* When log in button cannot be found.
97			*/
98			public function fillLoginForm(array $props, $message = '')
			0 ignored issues – show Coding Style introduced 2018-03-22 11:11 UTC by Report Bug Copy Issue Report `fillLoginForm` uses the super-global variable `$GLOBALS` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
99			{
100			$this->visitPath('/user/login');
101			$formContext = $this->getFormContext();
102
103			foreach (['username', 'password'] as $prop) {
104			$formContext->fillField($this->getDrupalText($prop . '_field'), $props[$prop]);
105			}
106
107			$this->getWorkingElement()->pressButton($this->getDrupalText('log_in'));
108
109			if (!$this->isLoggedIn()) {
110			if (empty($message)) {
111			$message = sprintf(
112			'Failed to login as a user "%s" with password "%s".',
113			$props['username'],
114			$props['password']
115			);
116			}
117
118			throw new \Exception($message);
119			}
120
121			$GLOBALS['user'] = $this->user = user_load_by_name($props['username']);
			0 ignored issues – show Documentation introduced 2018-03-22 11:11 UTC by Report Bug Copy Issue Report The property `user` does not exist on `object<Drupal\TqExtensio...xt\User\RawUserContext>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
122			}
123
124			/**
125			* Cookies are set when at least one page of the site has been visited. This
126			* action done in "beforeScenario" hook of TqContext.
127			*
128			* @see TqContext::beforeScenario()
129			*
130			* @return bool
131			*/
132			public function isLoggedIn()
133			{
134			$cookieName = session_name();
135			$cookie = $this->getSession()->getCookie($cookieName);
136
137			if (null !== $cookie) {
138			$this->getSession('goutte')->setCookie($cookieName, $cookie);
139
140			return true;
141			}
142
143			return false;
144			}
145
146			public function logoutUser()
147			{
148			if ($this->isLoggedIn()) {
149			$this->logout();
150			}
151			}
152
153			/**
154			* @param array $fields
155			* Additional data for user account.
156			*
157			* @throws \Exception
158			*
159			* @return \stdClass
160			*/
161			public function createTestUser(array $fields = [])
162			{
163			$random = $this->getRandom();
164			$username = $random->name(8);
165			$user = [
166			'uid' => 0,
167			'name' => $username,
168			'pass' => $random->name(16),
169			'mail' => "[email protected]",
170			'roles' => [
171			DRUPAL_AUTHENTICATED_RID => 'authenticated user',
172			],
173			];
174
175			$user = (object) $user;
176
177			if (!empty($fields)) {
178			$entity = new EntityDrupalWrapper('user');
179			$required = $entity->getRequiredFields();
180
181			// Fill fields. Field can be found by name or label.
182			foreach ($fields as $field_name => $value) {
183			$field_info = $entity->getFieldInfo($field_name);
184
185			if (!empty($field_info)) {
186			$field_name = $field_info['field_name'];
187			}
188
189			$user->$field_name = $value;
190
191			// Remove field from $required if it was there and filled.
192			unset($required[$field_name]);
193			}
194
195			// Throw an exception when one of required fields was not filled.
196			if (!empty($required)) {
197			throw new \Exception(sprintf(
198			'The following fields "%s" are required and has not filled.',
199			implode('", "', $required)
200			));
201			}
202			}
203
204			if (isset($user->name)) {
205			$existing_user = user_load_by_name($user->name);
206
207			if (!empty($existing_user)) {
208			user_delete($existing_user->uid);
209			}
210			}
211
212			// $this->user always exist but when no user created it has "false" as a value.
213			// Variable stored to another because RawDrupalContext::userCreate() will modify
214			// it and this will affect for future actions.
215			if (!empty($this->user)) {
			0 ignored issues – show Documentation introduced 2018-03-14 13:58 UTC by Report Bug Copy Issue Report The property `user` does not exist on `object<Drupal\TqExtensio...xt\User\RawUserContext>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
216			$tmp = $this->user;
			0 ignored issues – show Documentation introduced 2018-03-14 13:58 UTC by Report Bug Copy Issue Report The property `user` does not exist on `object<Drupal\TqExtensio...xt\User\RawUserContext>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
217			}
218
219			$this->userCreate($user);
220
221			if (isset($tmp)) {
222			$this->user = $tmp;
			0 ignored issues – show Documentation introduced 2018-03-14 13:58 UTC by Report Bug Copy Issue Report The property `user` does not exist on `object<Drupal\TqExtensio...xt\User\RawUserContext>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
223			}
224
225			return $user;
226			}
227			}
228

BR0kEN- / TqExtension

RawUserContext A last analyzed 2018-03-22 11:11 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

9 Methods

Duplication Side-by-Side

Filter issues like

RawUserContext A
last analyzed 2018-03-22 11:11 UTC