webhook - Code Metrics - Inspection of "Adding a little more details" - BPTproto/BPT-Multi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 2ad3f1...bfb9d3 )

by Miaad

created 2022-06-19 19:49 UTC

webhook A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	39
Duplicated Lines	0 %

Importance

Changes

Metric	Value
wmc	11
eloc	21
dl	0
loc	39
rs	10
c	0
b	0
f	0

4 Methods

Rating	Name	Size	Complexity
A	init()	7	2
A	deleteOldLocks()	9	4
A	processUpdate()	7	2
A	telegramVerify()	5	3

<?php

namespace BPT\receiver;

use BPT\BPT;
use BPT\lock;
use BPT\logger;
use BPT\settings;
use BPT\tools;
use BPT\types\update;

class webhook {
    public static function init () {
        if (lock::exist('BPT-HOOK')) {
            self::telegramVerify();
            BPT::$update = self::processUpdate();
        }
        else {
            self::deleteOldLocks();
        }
    }

    public static function telegramVerify() {
        if (settings::$telegram_verify) {
            if (!tools::isTelegram($_SERVER['REMOTE_ADDR'])) {
                logger::write('not authorized access denied. IP : '.$_SERVER['REMOTE_ADDR'],'error');
                BPT::close();
            }
        }
    }

    public static function processUpdate(): update {
        $update = json_decode(file_get_contents("php://input"));
        if ($update) {
            return new update($update);
        }
        else {
            BPT::close();
interface ReturnsInt {
    public function returnsIntHinted(): int;
}

class MyClass implements ReturnsInt {
    public function returnsIntHinted(): int
    {
        if (foo()) {
            return 123;
        }
        // here: null is implicitly returned
    }
}
        }
    }

    public static function deleteOldLocks() {
        if (lock::exist('BPT-MULTI')) {
            lock::delete('BPT-MULTI');
        }
        if (lock::exist('BPT-MULTI-2')) {
            lock::delete('BPT-MULTI-2');
        }
        if (lock::exist('getUpdate')) {
            lock::delete('getUpdate');
        }
    }
}

1			<?php
2
3			namespace BPT\receiver;
4
5			use BPT\BPT;
6			use BPT\lock;
7			use BPT\logger;
8			use BPT\settings;
9			use BPT\tools;
10			use BPT\types\update;
11
12			class webhook {
13			public static function init () {
14			if (lock::exist('BPT-HOOK')) {
15			self::telegramVerify();
16			BPT::$update = self::processUpdate();
17			}
18			else {
19			self::deleteOldLocks();
20			}
21			}
22
23			public static function telegramVerify() {
24			if (settings::$telegram_verify) {
25			if (!tools::isTelegram($_SERVER['REMOTE_ADDR'])) {
26			logger::write('not authorized access denied. IP : '.$_SERVER['REMOTE_ADDR'],'error');
27			BPT::close();
28			}
29			}
30			}
31
32			public static function processUpdate(): update {
33			$update = json_decode(file_get_contents("php://input"));
34			if ($update) {
35			return new update($update);
36			}
37			else {
38			BPT::close();
			0 ignored issues – show Bug Best Practice introduced 2022-06-19 19:50 UTC by Report Bug Copy Issue Report In this branch, the function will implicitly return `null` which is incompatible with the type-hinted return `BPT\types\update`. Consider adding a return statement or allowing `null` as return value. For hinted functions/methods where all return statements with the correct type are only reachable via conditions, ?null? gets implicitly returned which may be incompatible with the hinted type. Let?s take a look at an example: interface ReturnsInt { public function returnsIntHinted(): int; } class MyClass implements ReturnsInt { public function returnsIntHinted(): int { if (foo()) { return 123; } // here: null is implicitly returned } } Loading history...
39			}
40			}
41
42			public static function deleteOldLocks() {
43			if (lock::exist('BPT-MULTI')) {
44			lock::delete('BPT-MULTI');
45			}
46			if (lock::exist('BPT-MULTI-2')) {
47			lock::delete('BPT-MULTI-2');
48			}
49			if (lock::exist('getUpdate')) {
50			lock::delete('getUpdate');
51			}
52			}
53			}

BPTproto / BPT-Multi

Push — main ( 2ad3f1...bfb9d3 )

webhook A

Complexity

Size/Duplication

Importance

4 Methods

Duplication Side-by-Side

Filter issues like