Handller::__construct() - Code Metrics - Inspection of "update handller.php" - BPTproto/BPT-Multi - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — main ( 2690c9...b16527 )

by Alireza

created 2022-06-26 06:44 UTC

Handller::__construct() B

↳ Parent: Handller

Complexity

Conditions	7
Paths	7

Size

Total Lines	30
Code Lines	23

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
eloc	23
c	1
b	0
f	0
dl	0
loc	30
rs	8.6186
cc	7
nc	7
nop	1

<?php

  //define namespace
  namespace BPT\Database;
  
  //use class
  use BPT\Database\Database;
  
  /**
   * 
   */
  class Handller extends Database
  {
      
      /**
       * 
       */
      public function __construct(array $settings)
      {
        if(in_array($settings['type'],self::TYPES)){
              if($settings['type'] === 'Mysqli'){
                  if(self::CheckParam($settings)){
                 $db = new Mysqlidb([
filter:
    dependency_paths: ["lib/*"]
                'host' => $this->host,
                'username' => $this->username,
                'password' => $this->password,
                'db' => $this->dbname,
                'charset' => $this->charset
                ]);
                if($db){

                  $this->connect = $db;
               } else {
                  throw new \exception('a problem to connecting');
                 }
               } else {
                  throw new \exception('required parameters not found');
               }
             }
              if($settings['type'] === 'Json' and isset($settings['dbname'])){
                $this->type = $settings['type'];
                $this->dbname = $settings['dbname'];
                parent::Json_init();
              } else {
                throw new \exception('parameter dbanme not found');
             }
          } else {
              throw new \exception('parameter type not found');
          }
      }
      
      private static function CheckParam(array $array){
         if(isset($array['username']) && isset($array['dbname']) && isset($array['password'])){
            $this->host = $array['host'] ?? 'localhost';
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
            $this->username = $array['username'];
            $this->dbname = $array['dbname'];
            $this->password = $array['password'];
            $this->charset = $array['charset'] ?? 'utf8mb4';
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
             return true;
         } else {
             return false;
         }
      }
  }

1			<?php
2
3			//define namespace
4			namespace BPT\Database;
5
6			//use class
7			use BPT\Database\Database;
8
9			/**
10			*
11			*/
12			class Handller extends Database
13			{
14
15			/**
16			*
17			*/
18			public function __construct(array $settings)
19			{
20			if(in_array($settings['type'],self::TYPES)){
21			if($settings['type'] === 'Mysqli'){
22			if(self::CheckParam($settings)){
23			$db = new Mysqlidb([
			0 ignored issues – show Bug introduced 2022-06-26 06:47 UTC by Report Bug Copy Issue Report The type `BPT\Database\Mysqlidb` was not found. Maybe you did not declare it correctly or list all dependencies? The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g. `excluded_paths: ["lib/"]`, you can move it to the dependency path list as follows: filter: dependency_paths: ["lib/"] For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths Loading history...
24			'host' => $this->host,
25			'username' => $this->username,
26			'password' => $this->password,
27			'db' => $this->dbname,
28			'charset' => $this->charset
29			]);
30			if($db){
			0 ignored issues – show introduced 2022-06-26 06:47 UTC by Report Bug Copy Issue Report `$db` is of type `BPT\Database\Mysqlidb`, thus it always evaluated to `true`. Loading history...
31			$this->connect = $db;
32			} else {
33			throw new \exception('a problem to connecting');
34			}
35			} else {
36			throw new \exception('required parameters not found');
37			}
38			}
39			if($settings['type'] === 'Json' and isset($settings['dbname'])){
40			$this->type = $settings['type'];
41			$this->dbname = $settings['dbname'];
42			parent::Json_init();
43			} else {
44			throw new \exception('parameter dbanme not found');
45			}
46			} else {
47			throw new \exception('parameter type not found');
48			}
49			}
50
51			private static function CheckParam(array $array){
52			if(isset($array['username']) && isset($array['dbname']) && isset($array['password'])){
53			$this->host = $array['host'] ?? 'localhost';
			0 ignored issues – show Comprehensibility Best Practice introduced 2022-06-26 06:47 UTC by Report Bug Copy Issue Report Using `$this` inside a static method is generally not recommended and can lead to errors in newer PHP versions. Loading history... Documentation Bug introduced 2022-06-26 06:47 UTC by Report Bug Copy Issue Report It seems like `$array['host'] ?? 'localhost'` can also be of type `string`. However, the property `$host` is declared as type `BPT\Database\host`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
54			$this->username = $array['username'];
55			$this->dbname = $array['dbname'];
56			$this->password = $array['password'];
57			$this->charset = $array['charset'] ?? 'utf8mb4';
			0 ignored issues – show Documentation Bug introduced 2022-06-26 06:47 UTC by Report Bug Copy Issue Report It seems like `$array['charset'] ?? 'utf8mb4'` can also be of type `string`. However, the property `$charset` is declared as type `BPT\Database\charset`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
58			return true;
59			} else {
60			return false;
61			}
62			}
63			}

BPTproto / BPT-Multi

Push — main ( 2690c9...b16527 )

Handller::__construct() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like