Passed
Pull Request — master (#4692)
by David
09:04
created
html/inc/prefs_util.inc 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -42,9 +42,9 @@  discard block
 block discarded – undo
42 42
 }
43 43
 
44 44
 abstract class PREF {
45
-    public $desc;       // short description
46
-    public $tooltip;    // longer description, shown as tooltip
47
-    public $tag;        // the pref's primary XML tag
45
+    public $desc; // short description
46
+    public $tooltip; // longer description, shown as tooltip
47
+    public $tag; // the pref's primary XML tag
48 48
     function __construct($desc, $tooltip, $tag) {
49 49
         $this->desc = $desc;
50 50
         $this->tooltip = $tooltip;
@@ -122,15 +122,15 @@  discard block
 block discarded – undo
122 122
 
123 123
 class PREF_BOOL extends PREF {
124 124
     public $default;
125
-    public $invert;     // show to user in opposite sense
126
-    function __construct($desc, $tooltip, $tag, $default, $invert=false) {
125
+    public $invert; // show to user in opposite sense
126
+    function __construct($desc, $tooltip, $tag, $default, $invert = false) {
127 127
         $this->default = $default;
128 128
         $this->invert = $invert;
129 129
         parent::__construct($desc, $tooltip, $tag);
130 130
     }
131 131
     function show_value($prefs) {
132 132
         $tag = $this->tag;
133
-        $v = $this->invert?!$prefs->$tag:$prefs->$tag;
133
+        $v = $this->invert ? !$prefs->$tag : $prefs->$tag;
134 134
         echo "<td>".readonly_checkbox($v)."</td>";
135 135
     }
136 136
     function show_form($prefs, $error) {
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         }
143 143
         echo "<td ".VALUE_ATTRS.">"
144 144
             ."<input type=checkbox name=$this->tag "
145
-            . ($checked?"checked":"")
145
+            . ($checked ? "checked" : "")
146 146
             ."></td>
147 147
         ";
148 148
     }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     function xml_string($prefs) {
156 156
         $tag = $this->tag;
157 157
         return "<$tag>"
158
-            .($prefs->$tag?"1":"0")
158
+            .($prefs->$tag ? "1" : "0")
159 159
             ."</$tag>\n";
160 160
     }
161 161
     function xml_parse(&$prefs, $name, $text) {
@@ -175,9 +175,9 @@  discard block
 block discarded – undo
175 175
     public $consent_type_id; // the consent_type_id from the consent_type table
176 176
     public $consent_name; // the consent_name to configure
177 177
     public $default;
178
-    public $invert;     // show to user in opposite sense
178
+    public $invert; // show to user in opposite sense
179 179
 
180
-    function __construct($desc, $tooltip, $tag, $consent_type_id, $consent_name, $default, $invert=false) {
180
+    function __construct($desc, $tooltip, $tag, $consent_type_id, $consent_name, $default, $invert = false) {
181 181
         $this->consent_type_id = $consent_type_id;
182 182
         $this->consent_name = $consent_name;
183 183
         $this->default = $default;
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
         } else {
232 232
             $value = false;
233 233
         }
234
-        echo "<td>" . readonly_checkbox($value) . "</td>";
234
+        echo "<td>".readonly_checkbox($value)."</td>";
235 235
     }
236 236
     function show_form($user, $error) {
237 237
         $consent_type_id = $this->consent_type_id;
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         }
248 248
         echo "<td ".VALUE_ATTRS.">"
249 249
             ."<input type=checkbox name=$this->tag "
250
-            . ($checked?"checked":"")
250
+            . ($checked ? "checked" : "")
251 251
             ."></td>
252 252
         ";
253 253
     }
@@ -264,8 +264,8 @@  discard block
 block discarded – undo
264 264
         // to this consent type.
265 265
         $cr = BoincLatestConsent::lookup("userid={$user->id} AND consent_type_id='${consent_type_id}'");
266 266
 
267
-        if ( (($cr) and ($cr->consent_flag!=$flag)) or
268
-             (!$cr) ) {
267
+        if ((($cr) and ($cr->consent_flag != $flag)) or
268
+             (!$cr)) {
269 269
             $rc = consent_to_a_policy($user, $consent_type_id, $flag, 0, 'Webform', time());
270 270
             if (!$rc) {
271 271
                 error_page(tra("Database error:").BoincDb::error());
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
         // this is the value if they check the box
302 302
     public $scale;
303 303
 
304
-    function __construct($suffix, $min, $max, $default, $scale=1, $default2=0) {
304
+    function __construct($suffix, $min, $max, $default, $scale = 1, $default2 = 0) {
305 305
         $this->suffix = " $suffix";
306 306
         $this->min = $min;
307 307
         $this->max = $max;
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
         $v .= "$this->suffix ";
321 321
         return $v;
322 322
     }
323
-    function form_str($tag, $v, $had_error, $disabled=false, $id=null) {
323
+    function form_str($tag, $v, $had_error, $disabled = false, $id = null) {
324 324
         if (is_numeric($v)) {
325 325
             $v /= $this->scale;
326 326
             if (!$had_error && ($v < $this->min || $v > $this->max)) {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
             }
329 329
         }
330 330
         if ($disabled) $v = "";
331
-        $i = $id?"id=\"$id\"":"";
331
+        $i = $id ? "id=\"$id\"" : "";
332 332
         return '<input type="text" size="5" class="form-control input-sm" name="'.$tag.'" value="'.$v."\" $disabled $i> &nbsp; $this->suffix ";
333 333
     }
334 334
     function form_convert($in, &$out, &$error) {
@@ -451,8 +451,8 @@  discard block
 block discarded – undo
451 451
         $text_id = $this->tag;
452 452
         $default = $this->num_spec->get_default();
453 453
         $val = $prefs->$tag;
454
-        $c = $val?"checked":"";
455
-        $d = $val?"":"disabled";
454
+        $c = $val ? "checked" : "";
455
+        $d = $val ? "" : "disabled";
456 456
         echo "<td $attrs>"
457 457
             ."<input type=checkbox id=$checkbox_id onClick=\"checkbox_clicked('$checkbox_id', '$text_id', $default)\" $c> &nbsp;"
458 458
             .$this->num_spec->form_str($tag, $prefs->$tag, $had_error, $d, $text_id)
@@ -565,8 +565,8 @@  discard block
 block discarded – undo
565 565
 function hour_select($x, $name, $id, $d) {
566 566
     $s = "";
567 567
     $s .= "<select class=\"selectbox form-control input-sm\" name=$name id=$id $d>\n";
568
-    for ($i=0; $i<24; $i++) {
569
-        $sel = ($x == $i)?"selected":"";
568
+    for ($i = 0; $i < 24; $i++) {
569
+        $sel = ($x == $i) ? "selected" : "";
570 570
         $s .= "<option value=$i $sel> $i:00";
571 571
     }
572 572
     $s .= "</select>\n";
@@ -667,7 +667,7 @@  discard block
 block discarded – undo
667 667
 
668 668
 // row_defs - Display a value for all 4 venues in one row
669 669
 //
670
-function row_defs($pre, $item, $post, $type, $prefs, $tooltip=null) {
670
+function row_defs($pre, $item, $post, $type, $prefs, $tooltip = null) {
671 671
     $gen = $prefs->$item;
672 672
     $hom  = (isset($prefs->home) && isset($prefs->home->$item)) ? $prefs->home->$item : "--";
673 673
     $schl = (isset($prefs->school) && isset($prefs->school->$item)) ? $prefs->school->$item : "--";
@@ -679,10 +679,10 @@  discard block
 block discarded – undo
679 679
         echo "<tr>";
680 680
     }
681 681
     echo "<td ".NAME_ATTRS.">$pre</td>";
682
-    row_field($gen,  $type);
683
-    row_field($hom,  $type);
682
+    row_field($gen, $type);
683
+    row_field($hom, $type);
684 684
     row_field($schl, $type);
685
-    row_field($wrk,  $type);
685
+    row_field($wrk, $type);
686 686
     echo "<td align=left>$post</td></tr>\n";
687 687
 }
688 688
 
@@ -692,16 +692,16 @@  discard block
 block discarded – undo
692 692
 function row_field($value, $type) {
693 693
     echo "<td>";
694 694
     $type = $value === "--" ? "--" : $type;
695
-    switch($type) {
695
+    switch ($type) {
696 696
     case "yesno":
697
-        echo $value ?tra("yes"):tra("no");
697
+        echo $value ?tra("yes") : tra("no");
698 698
         break;
699 699
     case "noyes":
700
-        echo $value ?tra("no"):tra("yes");
700
+        echo $value ?tra("no") : tra("yes");
701 701
         break;
702 702
     case "limit":
703 703
         $x = max_bytes_display_mode($value);
704
-        $y = "$x " . BYTE_ABBR;
704
+        $y = "$x ".BYTE_ABBR;
705 705
         echo $x ? "$y" : tra("no limit");
706 706
         break;
707 707
     case "minutes":
Please login to merge, or discard this patch.
drupal/sites/default/boinc/modules/boincuser/boincuser.admin.inc 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
     '#default_value' => $default['boinc_server_status_url'],
121 121
     '#description' => t('An absolute URL or path relative to the site base to the server status page (e.g. %full_url or just %relative_url).',
122 122
       array(
123
-        '%full_url' => $base_url . '/server_status.php',
123
+        '%full_url' => $base_url.'/server_status.php',
124 124
         '%relative_url' => 'server_status.php',
125 125
       )
126 126
     ),
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     '#default_value' => $default['boinc_app_list_url'],
132 132
     '#description' => t('An absolute URL or path relative to the site base to the applications page (e.g. %full_url or just %relative_url).',
133 133
       array(
134
-        '%full_url' => $base_url . '/apps.php',
134
+        '%full_url' => $base_url.'/apps.php',
135 135
         '%relative_url' => 'apps.php',
136 136
       )
137 137
     ),
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
     '#type' => 'checkbox',
355 355
     '#title' => t('Enable create_account.php RPC'),
356 356
     '#default_value' => $default['boinc_weboptions_enableaccountcreateRPC'],
357
-    '#description' => t('If checked, users will be able to create an account remotely using the create_account.php RPC. This option is independent of the user regsitration option found in ') . l(t('User management -> User settings'), '/admin/user/settings') . '. If enabled, user <b>may not be able to see and agree to the terms-of-use</b> to your site\'s privacy and data retention policies!',
357
+    '#description' => t('If checked, users will be able to create an account remotely using the create_account.php RPC. This option is independent of the user regsitration option found in ').l(t('User management -> User settings'), '/admin/user/settings').'. If enabled, user <b>may not be able to see and agree to the terms-of-use</b> to your site\'s privacy and data retention policies!',
358 358
   );
359 359
 
360 360
   $form['boinc_weboptions_registrationtitle'] = array(
@@ -409,32 +409,32 @@  discard block
 block discarded – undo
409 409
     '#rows' => 8,
410 410
     '#description' => t('A list of Drupal URLs/paths to ignore for Terms of Use (ToU). If the option above \'Are existing users forced to agree to the Terms of Use?\' is activated, then some paths need to be ignored when checking if a user has agreed to the ToU. A good example is the logout path, "logout", or else users will not be able to logout!
411 411
 <p>There is a default list of paths that must be ignored or else the site will not function. They are not included in this box. Here you may provide additional paths to be ignored, for example the privacy policy page may be accessible so that users may read it before agreeing to the site\'s ToU.
412
-<p>Paths should be entered one per line. All paths should be <em>lower-case</em> and  should not include a leading \'/\'. Example: account/info/edit will allow the user to visit ' . $base_url . '/account/info/edit without first agreeing to the ToU. Regexp are allowed. Example: account/* will allow the user to visit any path starting with ' . $base_url . '/account/.'),
412
+<p>Paths should be entered one per line. All paths should be <em>lower-case</em> and  should not include a leading \'/\'. Example: account/info/edit will allow the user to visit ' . $base_url.'/account/info/edit without first agreeing to the ToU. Regexp are allowed. Example: account/* will allow the user to visit any path starting with '.$base_url.'/account/.'),
413 413
   );
414 414
 
415 415
   $form['pathtitle'] = array(
416 416
     '#value' => '<h3>Path Options</h3>',
417 417
   );
418 418
 
419
-  $form['boinc_weboptions_accountfinish'] = array (
419
+  $form['boinc_weboptions_accountfinish'] = array(
420 420
     '#type' => 'textfield',
421 421
     '#title' => t('Path to a custom account_finish.php page, should be a path to a node'),
422 422
     '#description' => t('Provide a path to a node which will serve as your site\'s landing page for users create an account using the BOINC client manager. They will be directed to this page after the account is created. If blank, a default account_finish page will be used.<br>Examples: account_finish, content/welcome, node/123'),
423 423
     '#default_value' => $default['boinc_weboptions_accountfinish'],
424 424
   );
425
-  $form['boinc_weboptions_moderationpage'] = array (
425
+  $form['boinc_weboptions_moderationpage'] = array(
426 426
     '#type' => 'textfield',
427 427
     '#title' => t('Path to the site\'s content moderation info page, should be a path to a node'),
428 428
     '#description' => t('Provide a path to a node which will serve as your site\'s page for account/content moderation information. This will be used on the default account_finish page. If blank, no link to a moderation page will be provided. If a path is provided to the custom account_finish.php page (above), this field will be ignored.<br>Examples: moderation, content/moderation, node/456'),
429 429
     '#default_value' => $default['boinc_weboptions_moderationpage'],
430 430
   );
431
-  $form['boinc_weboptions_rulespolicies'] = array (
431
+  $form['boinc_weboptions_rulespolicies'] = array(
432 432
     '#type' => 'textfield',
433 433
     '#title' => t('Path to the site\'s rule and policies page, should be a path to a node'),
434 434
     '#description' => t('Provide a path to a node which will serve as your site\'s rules and policies page. This will be used on the Join page shown to new users. If blank, no link to a rules and policies page will be provided.<br>Examples: rules-and-policies, node/789'),
435 435
     '#default_value' => $default['boinc_weboptions_rulespolicies'],
436 436
   );
437
-  $form['boinc_other_frontpage'] = array (
437
+  $form['boinc_other_frontpage'] = array(
438 438
     '#type' => 'textarea',
439 439
     '#title' => bts('Message for site\'s Home Page', array(), NULL, 'boinc:admin-boinc-other-options'),
440 440
     '#default_value' => $default['boinc_other_frontpage'],
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
     '#value' => '<h3>Other Options</h3>',
448 448
   );
449 449
 
450
-  $form['boinc_weboptions_blacklisted_usernames'] = array (
450
+  $form['boinc_weboptions_blacklisted_usernames'] = array(
451 451
     '#type' => 'textarea',
452 452
     '#title' => t('BOINC username blacklist'),
453 453
     '#default_value' => $default['boinc_weboptions_blacklisted_usernames'],
@@ -466,17 +466,17 @@  discard block
 block discarded – undo
466 466
   $values = $form_state['values'];
467 467
 
468 468
   $accountfinish = $values['boinc_weboptions_accountfinish'];
469
-  if ( ($accountfinish) AND (!drupal_lookup_path('source', $accountfinish)) ) {
469
+  if (($accountfinish) AND (!drupal_lookup_path('source', $accountfinish))) {
470 470
     form_set_error('boinc weboptions_accountfinish', t('Path to custom account finish page not found. Please provide a valid path, or leave blank to unset.'));
471 471
   }
472 472
 
473 473
   $moderationpage = $values['boinc_weboptions_moderationpage'];
474
-  if ( ($moderationpage) AND (!drupal_lookup_path('source', $moderationpage)) ) {
474
+  if (($moderationpage) AND (!drupal_lookup_path('source', $moderationpage))) {
475 475
     form_set_error('boinc weboptions_moderationpage', t('Path to moderation page not found. Please provide a valid path, or leave blank to unset.'));
476 476
   }
477 477
 
478 478
   $rulespolicies = $values['boinc_weboptions_rulespolicies'];
479
-  if ( ($rulespolicies) AND (!drupal_lookup_path('source', $rulespolicies)) ) {
479
+  if (($rulespolicies) AND (!drupal_lookup_path('source', $rulespolicies))) {
480 480
     form_set_error('boinc weboptions_rulespolicies', t('Path to rules and policies page not found. Please provide a valid path, or leave blank to unset.'));
481 481
   }
482 482
 }
@@ -485,5 +485,5 @@  discard block
 block discarded – undo
485 485
   * Submit BOINC other form
486 486
   */
487 487
 function boincuser_admin_weboptions_submit($form, &$form_state) {
488
-  drupal_set_message( bts("Status: Drupa-BOINC Web site options have been updated", array(), NULL, 'boinc:admin-boinc-website-options') );
488
+  drupal_set_message(bts("Status: Drupa-BOINC Web site options have been updated", array(), NULL, 'boinc:admin-boinc-website-options'));
489 489
 }
Please login to merge, or discard this patch.
html/inc/user.inc 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 // they've participated in
34 34
 //
35 35
 function get_other_projects($user) {
36
-    $cpid = md5($user->cross_project_id . $user->email_addr);
36
+    $cpid = md5($user->cross_project_id.$user->email_addr);
37 37
     $url = "http://boinc.netsoft-online.com/get_user.php?cpid=".$cpid;
38 38
 
39 39
     // Check the cache for that URL
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
     }
175 175
 
176 176
     if (!NO_STATS) {
177
-        $cpid = md5($user->cross_project_id . $user->email_addr);
177
+        $cpid = md5($user->cross_project_id.$user->email_addr);
178 178
         $x = "";
179 179
         shuffle($cpid_stats_sites);
180 180
         foreach ($cpid_stats_sites as $site) {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 // if $badge_height is > 0, show badges
329 329
 // if $name_limit, limit name to N chars
330 330
 //
331
-function user_links($user, $badge_height=0, $name_limit=0) {
331
+function user_links($user, $badge_height = 0, $name_limit = 0) {
332 332
     BoincForumPrefs::lookup($user);
333 333
     if (is_banished($user)) {
334 334
         return "(banished: ID $user->id)";
@@ -343,13 +343,13 @@  discard block
 block discarded – undo
343 343
         $name = substr($name, 0, $name_limit)."...";
344 344
     }
345 345
     $x .= " <a href=\"".url_base()."show_user.php?userid=".$user->id."\">".$name."</a>";
346
-    if (function_exists("project_user_links")){
346
+    if (function_exists("project_user_links")) {
347 347
         $x .= project_user_links($user);
348 348
     }
349 349
     if ($badge_height) {
350 350
         $x .= badges_string(true, $user, $badge_height);
351 351
     }
352
-    return $name_limit?"<nobr>$x</nobr>":$x;
352
+    return $name_limit ? "<nobr>$x</nobr>" : $x;
353 353
 }
354 354
 
355 355
 function show_community_private($user) {
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
 
397 397
             // if there's a foundership request, notify the founder
398 398
             //
399
-            if ($user->id==$team->userid && $team->ping_user >0) {
399
+            if ($user->id == $team->userid && $team->ping_user > 0) {
400 400
                 $x .= "<p class=\"text-danger\">".tra("(foundership change request pending)")."</p>";
401 401
             }
402 402
             row2(tra("Member of team"), $x);
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
     $x = "<a href=\"user_search.php\">".tra("Find friends")."</a><br/>\n";
422 422
     $n = count($friends);
423 423
     if ($n) {
424
-        foreach($friends as $friend) {
424
+        foreach ($friends as $friend) {
425 425
             $fuser = BoincUser::lookup_id($friend->user_dest);
426 426
             if (!$fuser) continue;
427 427
             $x .= friend_links($fuser);
@@ -464,7 +464,7 @@  discard block
 block discarded – undo
464 464
 // Returns a cacheable community links data object
465 465
 // @param user The user to produce a community links object for
466 466
 
467
-function get_community_links_object($user){
467
+function get_community_links_object($user) {
468 468
     $cache_object = new StdClass;
469 469
     $cache_object->post_count = total_posts($user);
470 470
     $cache_object->user = $user;
@@ -472,7 +472,7 @@  discard block
 block discarded – undo
472 472
     $cache_object->friends = array();
473 473
 
474 474
     $friends = BoincFriend::enum("user_src=$user->id and reciprocated=1");
475
-    foreach($friends as $friend) {
475
+    foreach ($friends as $friend) {
476 476
         $fuser = BoincUser::lookup_id($friend->user_dest);
477 477
         if (!$fuser) continue;
478 478
         $cache_object->friends[] = $fuser;
@@ -480,7 +480,7 @@  discard block
 block discarded – undo
480 480
     return $cache_object;
481 481
 }
482 482
 
483
-function community_links($clo, $logged_in_user){
483
+function community_links($clo, $logged_in_user) {
484 484
     $user = $clo->user;
485 485
     $team = $clo->team;
486 486
     $friends = $clo->friends;
@@ -506,15 +506,15 @@  discard block
 block discarded – undo
506 506
                 "<a href=\"friend.php?action=cancel_confirm&userid=$user->id\">".tra("Cancel friendship")."</a>"
507 507
             );
508 508
         } else if ($friend) {
509
-            row2(tra("Friends"),  "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Request pending")."</a>");
509
+            row2(tra("Friends"), "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Request pending")."</a>");
510 510
         } else {
511
-            row2(tra("Friends"),  "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Add as friend")."</a>");
511
+            row2(tra("Friends"), "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Add as friend")."</a>");
512 512
         }
513 513
     }
514 514
     
515 515
     if ($friends) {
516 516
         $x = "";
517
-        foreach($friends as $friend) {
517
+        foreach ($friends as $friend) {
518 518
             $x .= friend_links($friend);
519 519
         }
520 520
         row2(tra("Friends")." (".sizeof($friends).")", $x);
@@ -558,6 +558,6 @@  discard block
 block discarded – undo
558 558
 }
559 559
 
560 560
 
561
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
561
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
562 562
 
563 563
 ?>
Please login to merge, or discard this patch.
default/boinc/modules/boincuser/boincuser_delete/boincuser_delete.module 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -93,9 +93,9 @@  discard block
 block discarded – undo
93 93
 function boincuser_delete_form_alter(&$form, $form_state, $form_id) {
94 94
   global $user;
95 95
 
96
-  switch($form_id) {
96
+  switch ($form_id) {
97 97
     case 'user_profile_form':
98
-      if ( user_access('delete own account') AND ($form['#uid'] == $user->uid) AND (arg(3)=='') ) {
98
+      if (user_access('delete own account') AND ($form['#uid'] == $user->uid) AND (arg(3) == '')) {
99 99
         $form['delete'] = array(
100 100
           '#type' => 'submit',
101 101
           '#value' => bts('Delete Account', array(), null, 'boinc:delete-user-account'),
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
           '#suffix' => '</li>',
106 106
         );
107 107
       }
108
-      else if ( user_access('administer users') ) {
108
+      else if (user_access('administer users')) {
109 109
         $form['delete'] = array(
110 110
           '#type' => 'submit',
111 111
           '#value' => bts('Delete Account', array(), null, 'boinc:delete-user-account'),
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
           break;
159 159
       }
160 160
 
161
-      $question = 'Are you sure you want to delete the account <em>' . htmlspecialchars($form['_account']['#value']->boincuser_name) . '</em>?';
161
+      $question = 'Are you sure you want to delete the account <em>'.htmlspecialchars($form['_account']['#value']->boincuser_name).'</em>?';
162 162
       drupal_set_title($question);
163 163
 
164 164
       unset($form['description']);
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
       );
178 178
       $form['main']['fs1']['help'] = array(
179 179
         '#value' => bts(
180
-          "<p>In order to delete your account, you must provide your password below. You will then be sent an email to the email address on record, with a one-time token that expires in 24-hours. Clicking on this link will bring you to a second form where you must enter your password again. After doing so your account will be deleted.</p>" .
180
+          "<p>In order to delete your account, you must provide your password below. You will then be sent an email to the email address on record, with a one-time token that expires in 24-hours. Clicking on this link will bring you to a second form where you must enter your password again. After doing so your account will be deleted.</p>".
181 181
           "<p>If necessary, you may !link first before deleting your account. But you must wait <b>seven (7) days</b> after an email address change before you may delete your account.</p>",
182 182
           array(
183 183
             '!link' => l(bts('change your email address', array(), NULL, 'boinc:delete-user-account'), '/account/info/edit'),
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
 
190 190
       if ($dtypes == 'user_decides') {
191 191
         $form['main']['common'] = array(
192
-          '#value'  => bts('All choices: ', array(), NULL, 'boinc:delete-user-account') . $common_acts . '<p>' . bts('Disabled means some of your personal data, such as your username and email address, are kept on our systems. Choose \'delete your account\' if you want all personal data to be removed.', array(), NULL, 'boinc:delete-user-account'),
192
+          '#value'  => bts('All choices: ', array(), NULL, 'boinc:delete-user-account').$common_acts.'<p>'.bts('Disabled means some of your personal data, such as your username and email address, are kept on our systems. Choose \'delete your account\' if you want all personal data to be removed.', array(), NULL, 'boinc:delete-user-account'),
193 193
           '#prefix' => "<div id='delete-instructions'>",
194 194
           '#suffix' => "</div>",
195 195
           '#weight' => 20,
@@ -257,7 +257,7 @@  discard block
 block discarded – undo
257 257
         '#weight' => 1010,
258 258
       );
259 259
 
260
-      $form['#redirect'] = 'account/' . $uid;
260
+      $form['#redirect'] = 'account/'.$uid;
261 261
       $form['#validate'] = array('boincuser_delete_validate');
262 262
       $form['#submit'] = array('boincuser_delete_submit');
263 263
       break;
@@ -317,7 +317,7 @@  discard block
 block discarded – undo
317 317
   global $base_path;
318 318
   module_load_include('inc', 'rules', 'modules/system.rules');
319 319
   $site_name = variable_get('site_name', 'Drupal-BOINC');
320
-  $site_url = $base_url . $base_path . "user/login";
320
+  $site_url = $base_url.$base_path."user/login";
321 321
 
322 322
   // Perform the requested operation
323 323
   $op = $form_state['values']['user_delete_action'];
@@ -364,7 +364,7 @@  discard block
 block discarded – undo
364 364
   );
365 365
   rules_action_mail_to_user($account, $settings);
366 366
 
367
-  drupal_set_message(bts("INFO: You have requested account deletion. Please check your email for further instructions.", array(), NULL, 'boinc:delete-user-account'),'info');
367
+  drupal_set_message(bts("INFO: You have requested account deletion. Please check your email for further instructions.", array(), NULL, 'boinc:delete-user-account'), 'info');
368 368
 
369 369
   $redirect = variable_get('boincuser_delete_redirect', '<front>');
370 370
   // Redirect
@@ -458,7 +458,7 @@  discard block
 block discarded – undo
458 458
     '#weight' => 1002,
459 459
   );
460 460
   $form['form control tabs'] = array(
461
-    '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/") . '</li>',
461
+    '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/").'</li>',
462 462
     '#weight' => 1003,
463 463
   );
464 464
   $form['form control tabs suffix'] = array(
@@ -548,7 +548,7 @@  discard block
 block discarded – undo
548 548
     '#weight' => 1002,
549 549
   );
550 550
   $form['form control tabs'] = array(
551
-    '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/") . '</li>',
551
+    '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/").'</li>',
552 552
     '#weight' => 1003,
553 553
   );
554 554
   $form['form control tabs suffix'] = array(
Please login to merge, or discard this patch.
drupal/sites/default/boinc/modules/boincuser/includes/boincuser.helpers.inc 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -165,8 +165,8 @@  discard block
 block discarded – undo
165 165
       WHERE n.type = 'profile'
166 166
       AND n.status = 1
167 167
       AND n.moderate = 0
168
-      " . ($never_been_picked ? " AND bu.uotd_time = 0 " : '') . "
169
-      " . ($active_users ? " AND bu.boinc_id IN ({$active_users}) " : '') . "
168
+      " . ($never_been_picked ? " AND bu.uotd_time = 0 " : '')."
169
+      " . ($active_users ? " AND bu.boinc_id IN ({$active_users}) " : '')."
170 170
       ORDER BY RAND()
171 171
       LIMIT 1"
172 172
     ));
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
  * this function is called, it may be called with optional parameters
213 213
  * new and prev email.
214 214
  */
215
-function _boincuser_send_emailchange($account, $new_email=NULL, $prev_email=NULL, $adminuser=FALSE) {
215
+function _boincuser_send_emailchange($account, $new_email = NULL, $prev_email = NULL, $adminuser = FALSE) {
216 216
   require_boinc('token');
217 217
   module_load_include('inc', 'rules', 'modules/system.rules');
218 218
 
@@ -303,7 +303,7 @@  discard block
 block discarded – undo
303 303
     // Name is limited to 60 characters, but we want to leave space to add a
304 304
     // tally if needed (for users with duplicate names); Limit to 56 chars and
305 305
     // replace the middle of the string with "..." if too long
306
-    $cleaned_name = substr_replace($cleaned_name, '...', 28, ($name_length-56)+3);
306
+    $cleaned_name = substr_replace($cleaned_name, '...', 28, ($name_length - 56) + 3);
307 307
   }
308 308
 
309 309
   // Determine if there are duplicate names, if so append a number to end.
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
     // delimiters. Curly brace is not really allowed un URLs, but a
374 374
     // more robust function would first check for these curly braces
375 375
     // in the path_to_ignore patterms, just in case.
376
-    if (preg_match('{' . $pi . '}', $path)) {
376
+    if (preg_match('{'.$pi.'}', $path)) {
377 377
       return TRUE;
378 378
     }
379 379
   }
@@ -499,15 +499,15 @@  discard block
 block discarded – undo
499 499
   elseif (!in_array($_GET['q'], $page_blacklist)) {
500 500
     watchdog('boincuser', 'The BOINC scheduling server settings are not yet
501 501
         configured. Please !verify for the settings to become effective.',
502
-          array('!verify' => l(t('verify the default values') . ' <strong>' . 
503
-            t('and') . '</strong> ' . t('save the configuration'),
502
+          array('!verify' => l(t('verify the default values').' <strong>'. 
503
+            t('and').'</strong> '.t('save the configuration'),
504 504
             'admin/boinc/scheduler', array('html' => TRUE))
505 505
           ), WATCHDOG_WARNING);
506 506
     if (user_access('administer site configuration')) {
507 507
       drupal_set_message(t('The BOINC scheduling server settings are not yet
508 508
           configured. Please !verify for the settings to become effective',
509
-            array('!verify' => l(t('verify the default values') . ' <strong>' . 
510
-              t('and') . '</strong> ' . t('save the configuration'),
509
+            array('!verify' => l(t('verify the default values').' <strong>'. 
510
+              t('and').'</strong> '.t('save the configuration'),
511 511
               'admin/boinc/scheduler', array('html' => TRUE))
512 512
             )), 'warning', FALSE);
513 513
     }
@@ -569,7 +569,7 @@  discard block
 block discarded – undo
569 569
  */
570 570
 function _boincuser_node_profile_delete_submit($form, &$form_state) {
571 571
   $node = $form['#node'];
572
-  $deleteurl = 'node/'. $node->nid .'/delete';
572
+  $deleteurl = 'node/'.$node->nid.'/delete';
573 573
   $afterq = 'destination=account';
574 574
   drupal_goto($deleteurl, $afterq);
575 575
 }
@@ -599,8 +599,8 @@  discard block
 block discarded – undo
599 599
   $view = views_get_current_view();
600 600
   $account_id = $view->args[0];
601 601
   $friend_count = flag_friend_get_friend_count($account_id);
602
-  return '<h2 class="pane-title">' . bts('Friends (@count)', 
603
-    array('@count' => $friend_count)) . '</h2>';
602
+  return '<h2 class="pane-title">'.bts('Friends (@count)', 
603
+    array('@count' => $friend_count)).'</h2>';
604 604
 }
605 605
 
606 606
 /**
@@ -613,7 +613,7 @@  discard block
 block discarded – undo
613 613
   $result = db_query_range("SELECT id,name FROM {user} WHERE name LIKE '%s%'", $string, 0, 10);
614 614
   db_set_active('default');
615 615
   while ($user = db_fetch_object($result)) {
616
-      $matches[$user->name . '_' . $user->id] = htmlentities($user->name) . " (" . $user->id . ')';
616
+      $matches[$user->name.'_'.$user->id] = htmlentities($user->name)." (".$user->id.')';
617 617
   }
618 618
 
619 619
   drupal_json((object)$matches);
Please login to merge, or discard this patch.
html/inc/account.inc 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -100,7 +100,7 @@  discard block
 block discarded – undo
100 100
             tra("Must be at least %1 characters", $min_passwd_length),
101 101
             tra("Password")
102 102
         ),
103
-        "passwd", "", "password",'id="passwd"',passwd_visible_checkbox("passwd")
103
+        "passwd", "", "password", 'id="passwd"', passwd_visible_checkbox("passwd")
104 104
     );
105 105
     if (USER_COUNTRY) {
106 106
         form_select(
@@ -145,9 +145,9 @@  discard block
 block discarded – undo
145 145
     } else {
146 146
         $x = tra("Email address:");
147 147
     }
148
-    form_input_text($x, "email_addr", '', 'text', $attrs='autofocus tabindex="1"');
148
+    form_input_text($x, "email_addr", '', 'text', $attrs = 'autofocus tabindex="1"');
149 149
     form_input_text(
150
-        tra("Password:").'<br><small><a href="get_passwd.php">' . tra("forgot password?") . "</a></small>",
150
+        tra("Password:").'<br><small><a href="get_passwd.php">'.tra("forgot password?")."</a></small>",
151 151
         "passwd",
152 152
         "",
153 153
         "password",
Please login to merge, or discard this patch.
html/inc/util_basic.inc 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -46,10 +46,10 @@  discard block
 block discarded – undo
46 46
     ";
47 47
 }
48 48
 
49
-function xml_error($num, $msg=null, $file=null, $line=null) {
49
+function xml_error($num, $msg = null, $file = null, $line = null) {
50 50
     global $xml_outer_tag;
51 51
     if (!$msg) {
52
-        switch($num) {
52
+        switch ($num) {
53 53
         case -112: $msg = "Invalid XML"; break;
54 54
         case -136: $msg = "Not found"; break;
55 55
         case -137: $msg = "Name or email address is not unique"; break;
@@ -95,7 +95,7 @@  discard block
 block discarded – undo
95 95
 // If it's a single-tag element, and it's present, just return the tag
96 96
 //
97 97
 function parse_element($xml, $tag) {
98
-    $closetag = "</" . substr($tag,1);
98
+    $closetag = "</".substr($tag, 1);
99 99
     $x = strstr($xml, $tag);
100 100
     if ($x) {
101 101
         if (strstr($tag, "/>")) return $tag;
@@ -111,8 +111,8 @@  discard block
 block discarded – undo
111 111
 
112 112
 function parse_next_element($xml, $tag, &$cursor) {
113 113
     $element = null;
114
-    $closetag = "</" . substr($tag,1);
115
-    $pos = substr($xml,$cursor);
114
+    $closetag = "</".substr($tag, 1);
115
+    $pos = substr($xml, $cursor);
116 116
     $x = strstr($pos, $tag);
117 117
     if ($x) {
118 118
         if (strstr($tag, "/>")) return $tag;
Please login to merge, or discard this patch.
html/user/get_project_config.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,10 +30,10 @@  discard block
 block discarded – undo
30 30
 //
31 31
 function show_platforms() {
32 32
     $xmlFragment = unserialize(get_cached_data(3600, "project_config_platform_xml"));
33
-    if ($xmlFragment==false){
33
+    if ($xmlFragment == false) {
34 34
         $platforms = BoincDB::get()->enum_fields("platform, DBNAME.app_version, DBNAME.app", "BoincPlatform", "platform.name, platform.user_friendly_name, plan_class", "app_version.platformid = platform.id and app_version.appid = app.id and app_version.deprecated=0 and app.deprecated=0 group by platform.name, plan_class", "");
35 35
         $xmlFragment = "    <platforms>";
36
-        foreach ($platforms as $platform){
36
+        foreach ($platforms as $platform) {
37 37
             $xmlFragment .= "
38 38
             <platform>
39 39
                 <platform_name>$platform->name</platform_name>
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
 if (defined('TERMSOFUSE_FILE')) {
116 116
   $tou_file = TERMSOFUSE_FILE;
117 117
 } else {
118
-  $tou_file =  "../../terms_of_use.txt";
118
+  $tou_file = "../../terms_of_use.txt";
119 119
 }
120 120
 if (file_exists($tou_file)) {
121 121
     $terms_of_use = trim(file_get_contents($tou_file));
Please login to merge, or discard this patch.
html/ops/mass_email_script.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
 $globals->batch = 1000;
56 56
 $globals->lapsed_interval = 60*86400;
57 57
 
58
-for ($i=1; $i<$argc; $i++) {
58
+for ($i = 1; $i < $argc; $i++) {
59 59
     if ($argv[$i] == "--batch") {
60 60
         $i++;
61 61
         $globals->batch = $argv[$i];
@@ -169,7 +169,7 @@  discard block
 block discarded – undo
169 169
         gmdate('d F Y', $user->create_time),
170 170
         number_format($user->total_credit, 0),
171 171
         opt_out_url($user),
172
-        floor((time() - $user->last_rpc_time) / 86400),
172
+        floor((time() - $user->last_rpc_time)/86400),
173 173
     );
174 174
     return preg_replace($pat, $rep, $template);
175 175
 }
@@ -238,7 +238,7 @@  discard block
 block discarded – undo
238 238
     while ($user = _mysql_fetch_object($result)) {
239 239
         handle_user($user);
240 240
         $startid = $user->id;
241
-        fputs($log, $user->id . "\n");
241
+        fputs($log, $user->id."\n");
242 242
         fflush($log);
243 243
     }
244 244
     _mysql_free_result($result);
@@ -252,7 +252,7 @@  discard block
 block discarded – undo
252 252
     $user = _mysql_fetch_object($result);
253 253
     if ($user) {
254 254
         handle_user($user);
255
-        fputs($log, $user->id . "\n");
255
+        fputs($log, $user->id."\n");
256 256
         fflush($log);
257 257
     }
258 258
     _mysql_free_result($result);
@@ -289,7 +289,7 @@  discard block
 block discarded – undo
289 289
     } else {
290 290
         $fid = fopen($id_file, 'r');
291 291
         if (!$fid) {
292
-            echo  $id_file . ' not found - create ID list and run again\n';
292
+            echo  $id_file.' not found - create ID list and run again\n';
293 293
             exit();
294 294
         }
295 295
         $thisid = 0;
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
         }
301 301
         fclose($fid);
302 302
     }
303
-    echo 'All done!' . "\n";
303
+    echo 'All done!'."\n";
304 304
 }
305 305
 
306 306
 if (!function_exists('make_php_mailer')) {
Please login to merge, or discard this patch.