BOINC / boinc

html/ops/update_profile_pages.php

Doc Comments +8 added lines

@@ -98,6 +98,9 @@ 
 // Generates a standard set of links between associated multi-page documents.
 //  All linked files must be of the form "$filename_<page number>.html".
 
+/**
+ * @param integer $currPageNum
+ */
 function write_page_links($filename, $currPageNum, $numPages) {
     echo "<p>Page $currPageNum of $numPages</p>";
 
@@ -332,6 +335,11 @@ 
 // A generalized function to produce some number of pages summarizing a
 // set of user profiles.
 
+/**
+ * @param integer $rowsPerPage
+ * @param integer $colsPerPage
+ * @param string $dir
+ */
 function build_profile_pages(
     $members, $title, $rowsPerPage, $colsPerPage, $dir, $base_filename
 ) {

Indentation +1 added lines, -1 removed lines

@@ -200,7 +200,7 @@
         for ($row = 0; $row < $height; $row++) {
             echo "<tr>";
             for ($col = 0; $col < $width; $col++) {
-	            if ($count < $numIds) {
+                if ($count < $numIds) {
                     echo "<td class=\"bordered\" align=\"center\">
                         <a href=\"".secure_url_base()."view_profile.php?userid=".$userIds[$count]."\"><img src=\"".secure_url_base().IMAGE_URL.$userIds[$count]."_sm.jpg\"></a>
                     </td>";

Spacing +15 added lines, -15 removed lines

@@ -39,7 +39,7 @@ 
 
 // TODO: convert to new DB interface
 
-$alphabet = array('A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z','0','1','2','3','4','5','6','7','8','9');
+$alphabet = array('A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9');
 
 
 // Builds a summary table of user profiles.
@@ -53,7 +53,7 @@ 
 function show_user_table($members, $offset, $numToDisplay, $cols) {
     start_table();
 
-    $rows = ceil($numToDisplay / $cols);
+    $rows = ceil($numToDisplay/$cols);
     $count = $offset;
     $numMembers = count($members);
 
@@ -151,7 +151,7 @@ 
     // Build an array of IDs of all users with pictures in their profiles.
     $userIds = array();
     $numIds = 0;
-    foreach($profiles as $profile) {
+    foreach ($profiles as $profile) {
         $user = BoincUser::lookup_id($profile->userid);
         if (!$user) continue; // maybe we should delete the profile if user is non-existent anymore?
         if ($user->name) {
@@ -171,7 +171,7 @@ 
 //        shuffle($userIds);
 //    }
 
-    $numPages = ceil(count($userIds)/($width * $height));
+    $numPages = ceil(count($userIds)/($width*$height));
 
     // Make sure that a page is generated even when no profiles with pictures
     // exist in order to avoid 404 errors from the profile_menu page.
@@ -185,7 +185,7 @@ 
     $count = 0;
 
     for ($page = 1; $page <= $numPages; $page++) {
-        $filename = PROFILE_PATH . "user_gallery_" . $page . ".html";
+        $filename = PROFILE_PATH."user_gallery_".$page.".html";
         open_output_buffer();
 
         page_head("Profile gallery: page $page of $numPages", null, false, "../");
@@ -244,7 +244,7 @@ 
     // of the userids who belong to those countries.
     // Format: array[country][index] = userid.
 
-    foreach($profiles as $profile) {
+    foreach ($profiles as $profile) {
         $user = BoincUser::lookup_id($profile->userid);
         if (!$user) continue; // maybe we should delete the profile if user is non-existent anymore?
         if ($user->country) {
@@ -264,7 +264,7 @@ 
     // TODO: Define a constant for the desired number of rows per page.
 
     foreach ($countries as $country) {
-        $baseFileName =  "profile_country_" . get_legal_filename($country);
+        $baseFileName = "profile_country_".get_legal_filename($country);
         build_profile_pages(
             $countryMembers[$country],
             "User Profiles from $country", 5, 2,
@@ -290,7 +290,7 @@ 
     $numIds = 0;
     $members = array();
 
-    foreach($profiles as $profile) {
+    foreach ($profiles as $profile) {
         $user = BoincUser::lookup_id($profile->userid);
         if (!$user) continue; // maybe we should delete the profile if user is non-existent anymore?
         if ($user->name) {
@@ -335,11 +335,11 @@ 
 function build_profile_pages(
     $members, $title, $rowsPerPage, $colsPerPage, $dir, $base_filename
 ) {
-    $numPerPage = $rowsPerPage * $colsPerPage;
-    $numPages = ceil(count($members) / $numPerPage);
+    $numPerPage = $rowsPerPage*$colsPerPage;
+    $numPages = ceil(count($members)/$numPerPage);
 
     for ($page = 1; $page <= $numPages; $page++) {
-        $filename = $dir . $base_filename . "_" . $page . ".html";
+        $filename = $dir.$base_filename."_".$page.".html";
         open_output_buffer();
 
         $pagetitle = $title.": Page $page of $numPages";
@@ -347,7 +347,7 @@ 
 
         echo "Last updated ", pretty_time_str(time()), "<p>\n";
 
-        $offset = (($page-1) * $rowsPerPage * $colsPerPage);
+        $offset = (($page - 1)*$rowsPerPage*$colsPerPage);
 
         show_user_table($members, $offset, $numPerPage, $colsPerPage);
 
@@ -364,11 +364,11 @@ 
     print_debug_msg("Beginning to build country summary page...");
     $countries = array_keys($countryMembers);
 
-    $filename = PROFILE_PATH . "profile_country.html";
+    $filename = PROFILE_PATH."profile_country.html";
     open_output_buffer();
 
     page_head("User Profiles by Country", null, null, "../");
-    echo "Last updated " . pretty_time_str(time()) . "<p>";
+    echo "Last updated ".pretty_time_str(time())."<p>";
 
     start_table();
     row_heading_array(array("Country", "Profiles"));
@@ -413,7 +413,7 @@ 
 
 $caching = true;
 
-if (@$argv[1]=="-d") $debug=true;
+if (@$argv[1] == "-d") $debug = true;
 
 build_country_pages();
 build_alpha_pages();

Braces +22 added lines, -7 removed lines

@@ -32,8 +32,10 @@ 
 
 function print_debug_msg($text) {
     global $debug;
-    if ($debug) echo $text."\n";
-}
+    if ($debug) {
+        echo $text."\n";
+    }
+    }
 
 db_init();
 
@@ -153,7 +155,10 @@ 
     $numIds = 0;
     foreach($profiles as $profile) {
         $user = BoincUser::lookup_id($profile->userid);
-        if (!$user) continue; // maybe we should delete the profile if user is non-existent anymore?
+        if (!$user) {
+            continue;
+        }
+        // maybe we should delete the profile if user is non-existent anymore?
         if ($user->name) {
             $userIds[] = $profile->userid;
             $numIds++;
@@ -161,7 +166,9 @@ 
     }
 
     $msg = "$numIds users have profiles AND uploaded a picture";
-    if (profile_screening()) $msg .= " AND were screened by the project";
+    if (profile_screening()) {
+        $msg .= " AND were screened by the project";
+    }
     print_debug_msg($msg);
 
 // don't randomize; makes things hard for people who sift profiles
@@ -246,7 +253,10 @@ 
 
     foreach($profiles as $profile) {
         $user = BoincUser::lookup_id($profile->userid);
-        if (!$user) continue; // maybe we should delete the profile if user is non-existent anymore?
+        if (!$user) {
+            continue;
+        }
+        // maybe we should delete the profile if user is non-existent anymore?
         if ($user->country) {
             $countryMembers[$user->country][] = $user->id;
             $numIds++;
@@ -292,7 +302,10 @@ 
 
     foreach($profiles as $profile) {
         $user = BoincUser::lookup_id($profile->userid);
-        if (!$user) continue; // maybe we should delete the profile if user is non-existent anymore?
+        if (!$user) {
+            continue;
+        }
+        // maybe we should delete the profile if user is non-existent anymore?
         if ($user->name) {
             $name = ltrim($user->name);
             $members[strtoupper($name[0])][] = $user->id;
@@ -413,7 +426,9 @@ 
 
 $caching = true;
 
-if (@$argv[1]=="-d") $debug=true;
+if (@$argv[1]=="-d") {
+    $debug=true;
+}
 
 build_country_pages();
 build_alpha_pages();

html/ops/wd_nresults_changing.php

Doc Comments +3 added lines

@@ -23,6 +23,9 @@
 $cli_only = true;
 include_once("util_ops.inc");
 
+/**
+ * @param string $x
+ */
 function fail($x) {
     $f = fopen("error_log", "a");
     if (!$f) return false;

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
     return $lines;
 }
 
-function write_count_file($n,$m) {
+function write_count_file($n, $m) {
     $f = fopen("nresults", "w");
     if (!$f) return false;
     $x = sprintf("%d\n%d\n", $n, $m);
@@ -80,12 +80,12 @@ 
     }
     $n = read_count_file();
     if ($n == false) {
-        write_count_file($m,$p);
+        write_count_file($m, $p);
         exit();
     }
     if (trim($n[0]) == $m && trim($n[1]) == $p) {
         fail("Result count hasn't changed\n");
     }
-    write_count_file($m,$p);
+    write_count_file($m, $p);
 
 ?>

Braces +15 added lines, -5 removed lines

@@ -25,7 +25,9 @@ 
 
 function fail($x) {
     $f = fopen("error_log", "a");
-    if (!$f) return false;
+    if (!$f) {
+        return false;
+    }
     fputs($f, "[".strftime("%T %D")."] ");
     fputs($f, $x);
     fclose($f);
@@ -37,13 +39,17 @@ 
         return false;
     }
     $lines = file("nresults");
-    if (!$lines) return false;
+    if (!$lines) {
+        return false;
+    }
     return $lines;
 }
 
 function write_count_file($n,$m) {
     $f = fopen("nresults", "w");
-    if (!$f) return false;
+    if (!$f) {
+        return false;
+    }
     $x = sprintf("%d\n%d\n", $n, $m);
     fwrite($f, $x);
     fclose($f);
@@ -52,7 +58,9 @@ 
 
 function get_working_count_from_db() {
     $result = _mysql_query("select count(*) from result where server_state = 4");
-    if (!$result) return false;
+    if (!$result) {
+        return false;
+    }
     $count = _mysql_fetch_array($result);
     _mysql_free_result($result);
     return $count[0];
@@ -60,7 +68,9 @@ 
 
 function get_count_from_db() {
     $result = _mysql_query("select count(*) from result");
-    if (!$result) return false;
+    if (!$result) {
+        return false;
+    }
     $count = _mysql_fetch_array($result);
     _mysql_free_result($result);
     return $count[0];

html/project.sample/project.inc

Doc Comments +9 added lines

@@ -108,6 +108,10 @@ 
 // If you include any links, prepend URL with $prefix
 // if you need to open divs here close them in project_footer()
 //
+/**
+ * @param string $prefix
+ * @param boolean $is_main
+ */
 function project_banner($title, $prefix, $is_main) {
     if ($is_main) {
         echo '<img class="img-responsive" src="img/water.jpg">';
@@ -119,6 +123,11 @@ 
 }
 //$fixed_navbar = true;
 
+/**
+ * @param boolean $show_return
+ * @param boolean $show_date
+ * @param string $prefix
+ */
 function project_footer($show_return, $show_date, $prefix) {
     // If you include any links, prepend URL with $prefix
     //

Spacing +5 added lines, -5 removed lines

@@ -48,7 +48,7 @@ 
 
 define("FORUM_QA_MERGED_MODE", true);
     // Set to true to merge Message boards and Q&A section
-define ("DISABLE_PROFILES", true);
+define("DISABLE_PROFILES", true);
     // enable profiles only after enabling reCAPTCHA
     // http://boinc.berkeley.edu/trac/wiki/ProtectionFromSpam
 define("USE_STOPFORUMSPAM", true);
@@ -183,15 +183,15 @@ 
     </ol>", PROJECT);
 }
 
-function project_workunit($wu){
+function project_workunit($wu) {
     // shown in the workunit page
 }
 
-function project_user_summary($user){
+function project_user_summary($user) {
     // shown in the user summary page
 }
 
-function project_user_page_private($user){
+function project_user_page_private($user) {
     // shown in the private account page
 }
 
@@ -258,7 +258,7 @@ 
     array("name" => "Uppercase", "short_name" => "UC", "appids" => array(1, 25)),
 );
 
-function project_user_credit($user){
+function project_user_credit($user) {
     global $sub_projects;
     foreach ($sub_projects as $sp) {
         show_app_credit_user($user, $sp["name"], $sp["appids"]);

html/project.sample/project_specific_prefs.inc

Doc Comments +16 added lines

@@ -32,6 +32,9 @@ 
 //      Parse form variables into XML, and return it.
 //      Also error-check values, and return errors in $errors->*
 
+/**
+ * @param string $name
+ */
 function option($name, $val) {
     $x = ($name == $val) ?  "selected" : "";
     return "<option name='$name' $x>$name\n";
@@ -90,6 +93,10 @@ 
     return $x;
 }
 
+/**
+ * @param string $name
+ * @param integer $max
+ */
 function number_select($name, $max, $n) {
     $sel = ($n == 0) ? "selected":"";
     $x = "<select class=\"form-control input-sm\" name=$name> <option value=0 $sel>".tra("No limit")."</option>";
@@ -106,6 +113,9 @@ 
     return tra("No limit");
 }
 
+/**
+ * @param stdClass $prefs
+ */
 function project_specific_prefs_edit($prefs, $error=false) {
     global $app_array;
     if (COLOR_PREFS) {
@@ -162,6 +172,9 @@ 
     }
 }
 
+/**
+ * @param boolean $error
+ */
 function project_specific_prefs_parse_form(&$error) {
     global $app_array;
     $x = "";
@@ -216,6 +229,9 @@ 
     return $x;
 }
 
+/**
+ * @param stdClass $prefs
+ */
 function project_specific_prefs_show($prefs, $columns=false) {
     global $app_array;
     if ($columns) {

Spacing +15 added lines, -15 removed lines

@@ -33,7 +33,7 @@ 
 //      Also error-check values, and return errors in $errors->*
 
 function option($name, $val) {
-    $x = ($name == $val) ?  "selected" : "";
+    $x = ($name == $val) ? "selected" : "";
     return "<option name='$name' $x>$name\n";
 }
 
@@ -53,7 +53,7 @@ 
 if (APP_SELECT_PREFS) {
     $app_array = array();
     $apps = BoincApp::enum("deprecated=0");
-    foreach($apps as $app) {
+    foreach ($apps as $app) {
         $app_array[] = array($app->id, $app->user_friendly_name);
     }
 } else {
@@ -91,10 +91,10 @@ 
 }
 
 function number_select($name, $max, $n) {
-    $sel = ($n == 0) ? "selected":"";
+    $sel = ($n == 0) ? "selected" : "";
     $x = "<select class=\"form-control input-sm\" name=$name> <option value=0 $sel>".tra("No limit")."</option>";
-    for ($i=1; $i<=$max; $i++) {
-        $sel = ($n == $i) ? "selected":"";
+    for ($i = 1; $i <= $max; $i++) {
+        $sel = ($n == $i) ? "selected" : "";
         $x .= "<option value=$i $sel>$i</option>";
     }
     $x .= "</select>";
@@ -106,7 +106,7 @@ 
     return tra("No limit");
 }
 
-function project_specific_prefs_edit($prefs, $error=false) {
+function project_specific_prefs_edit($prefs, $error = false) {
     global $app_array;
     if (COLOR_PREFS) {
         $x = $prefs->color_scheme;
@@ -132,15 +132,15 @@ 
             } else {
                 $present = true;
             }
-            $checked = $present?"checked":"";
+            $checked = $present ? "checked" : "";
             $x .= "<input type=checkbox name=app_id_$app_id $checked> $app_name<br>";
         }
         tooltip_row2(APP_SELECT_TOOLTIP, APP_SELECT_DESC, $x);
-        $checked = $prefs->allow_non_preferred_apps?"checked":"";
+        $checked = $prefs->allow_non_preferred_apps ? "checked" : "";
         row2(ACCEPT_ANY_DESC, "<input type=checkbox name=allow_non_preferred_apps $checked>");
     }
     if (NON_GRAPHICAL_PREF) {
-        $checked = $prefs->non_graphical?"checked":"";
+        $checked = $prefs->non_graphical ? "checked" : "";
         row2(
             NON_GRAPHICAL_DESC,
             "<input type=checkbox name=non_graphical $checked>"
@@ -216,11 +216,11 @@ 
     return $x;
 }
 
-function project_specific_prefs_show($prefs, $columns=false) {
+function project_specific_prefs_show($prefs, $columns = false) {
     global $app_array;
     if ($columns) {
         if (COLOR_PREFS) {
-            row_defs(COLOR_DESC,"color_scheme", "", "", $prefs);
+            row_defs(COLOR_DESC, "color_scheme", "", "", $prefs);
         }
         if (GFX_CPU_PREFS) {
             row_defs(MAX_GFX_CPU_PCT_DESC, "max_gfx_cpu_pct", "", "", $prefs);
@@ -254,7 +254,7 @@ 
             row2(ACCEPT_ANY_DESC, $prefs->allow_non_preferred_apps_text);
         }
         if (NON_GRAPHICAL_PREF) {
-            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical?tra("yes"):tra("no"));
+            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical ? tra("yes") : tra("no"));
         }
         if (MAX_JOBS_PREF) {
             row2(tra("Max # jobs"), limit_string($prefs->max_jobs));
@@ -277,12 +277,12 @@ 
         $cursor = 0;
         while ($thisxml = parse_next_element($prefs_xml, "<app_id>", $cursor)) {
             if (is_numeric($thisxml)) {
-                $n = (int) $thisxml;
+                $n = (int)$thisxml;
                 $prefs->app_ids[] = $n;
             }
         }
         $prefs->allow_non_preferred_apps = parse_element($prefs_xml, "<allow_non_preferred_apps>");
-        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps?"yes":"no";
+        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps ? "yes" : "no";
     }
     if (NON_GRAPHICAL_PREF) {
         $prefs->non_graphical = parse_bool($prefs_xml, "non_graphical");
@@ -296,6 +296,6 @@ 
     return $prefs;
 }
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 
 ?>

Braces +12 added lines, -4 removed lines

@@ -102,7 +102,9 @@ 
 }
 
 function limit_string($val) {
-    if ($val) return $val;
+    if ($val) {
+        return $val;
+    }
     return tra("No limit");
 }
 
@@ -227,9 +229,15 @@ 
         }
         if (APP_SELECT_PREFS) {
             $prefs->app_id_text = selected_app_text($prefs);
-            if ($prefs->home) $prefs->home->app_id_text = selected_app_text($prefs->home);
-            if ($prefs->school) $prefs->school->app_id_text = selected_app_text($prefs->school);
-            if ($prefs->work) $prefs->work->app_id_text = selected_app_text($prefs->work);
+            if ($prefs->home) {
+                $prefs->home->app_id_text = selected_app_text($prefs->home);
+            }
+            if ($prefs->school) {
+                $prefs->school->app_id_text = selected_app_text($prefs->school);
+            }
+            if ($prefs->work) {
+                $prefs->work->app_id_text = selected_app_text($prefs->work);
+            }
             row_defs(APP_SELECT_DESC, "app_id_text", "", "", $prefs, APP_SELECT_TOOLTIP);
             row_defs(ACCEPT_ANY_DESC, "allow_non_preferred_apps_text", "", "", $prefs);
         }

html/user/bolt_sched.php

Doc Comments +6 added lines

@@ -28,6 +28,9 @@ 
 require_once("../inc/bolt_util.inc");
 require_once("../inc/util.inc");
 
+/**
+ * @param string $tag
+ */
 function debug_show_state($state, $tag) {
     global $user;
     global $refresh;
@@ -82,6 +85,9 @@ 
 
 // A page is being shown to the user; make a record of it
 //
+/**
+ * @param integer $mode
+ */
 function create_view($iter, $mode, $prev_view_id) {
     global $user;
     global $course;

Spacing +6 added lines, -6 removed lines

@@ -77,7 +77,7 @@ 
 }
 
 function default_mode($item) {
-    return $item->is_exercise()?BOLT_MODE_SHOW:BOLT_MODE_LESSON;
+    return $item->is_exercise() ? BOLT_MODE_SHOW : BOLT_MODE_LESSON;
 }
 
 // A page is being shown to the user; make a record of it
@@ -170,7 +170,7 @@ 
 
 // show an item (lesson, exercise, answer page)
 //
-function show_item($iter, $view_id, $prev_view_id, $mode, $repeat=null) {
+function show_item($iter, $view_id, $prev_view_id, $mode, $repeat = null) {
     global $user;
     global $course;
     global $bolt_ex;
@@ -224,7 +224,7 @@ 
     if ($repeat) {
         $avg = number_format($repeat->avg_score*100, 0);
         echo "<p>Score on this exercise set: $avg%";
-        if ($repeat->flags & REVIEW) {
+        if ($repeat->flags&REVIEW) {
             //echo "<pre>";
             //print_r($repeat);
             //echo "</pre>";
@@ -232,11 +232,11 @@ 
             $r = "<a href=bolt_sched.php?$url_args&action=review&view_id=$view_id&unit_name=$name>Review, then repeat exercises</a>";
             $links[] = $r;
         }
-        if ($repeat->flags & REPEAT) {
+        if ($repeat->flags&REPEAT) {
             $r = "<a href=bolt_sched.php?$url_args&action=repeat&view_id=$view_id>Repeat exercises</a>";
             $links[] = $r;
         }
-        if ($repeat->flags & NEXT) {
+        if ($repeat->flags&NEXT) {
             $links[] = $next;
         }
     } else {
@@ -462,7 +462,7 @@ 
     $bolt_ex->score = 0;
     $bolt_query_string = $item->query_string;
     srand($view_id);
-    ob_start();     // buffer output to avoid showing exercise text
+    ob_start(); // buffer output to avoid showing exercise text
     require($item->filename);
     ob_end_clean();
 

Braces +40 added lines, -14 removed lines

@@ -61,7 +61,9 @@ 
 //
 function finalize_view($view_id, $action) {
     global $user;
-    if (!$view_id) return null;
+    if (!$view_id) {
+        return null;
+    }
     $view = BoltView::lookup_id($view_id);
     if (!$view) {
         error_page("no view");
@@ -104,11 +106,15 @@ 
         <link rel=stylesheet type=text/css href=bolt.css>
         </head><body>
     ";
-    if (function_exists('bolt_header')) bolt_header();
-}
+    if (function_exists('bolt_header')) {
+        bolt_header();
+    }
+    }
 
 function page_footer() {
-    if (function_exists('bolt_footer')) bolt_footer();
+    if (function_exists('bolt_footer')) {
+        bolt_footer();
+    }
     echo "</body></html>";
 }
 
@@ -206,19 +212,25 @@ 
             }
             srand($view_id);
             require($item->filename);
-            if (function_exists('bolt_divide')) bolt_divide();
+            if (function_exists('bolt_divide')) {
+                bolt_divide();
+            }
             $next = "<input type=image src=img/next.gif value=OK></form>";
             break;
         case BOLT_MODE_ANSWER:
             require($item->filename);
-            if (function_exists('bolt_divide')) bolt_divide();
+            if (function_exists('bolt_divide')) {
+                bolt_divide();
+            }
             $score_pct = number_format($bolt_ex->score*100);
             echo "Score: $score_pct%";
             break;
         }
     } else {
         require_once($item->filename);
-        if (function_exists('bolt_divide')) bolt_divide();
+        if (function_exists('bolt_divide')) {
+            bolt_divide();
+        }
     }
 
     if ($repeat) {
@@ -270,7 +282,9 @@ 
     page_header();
     $bolt_query_string = $item->query_string;
     require_once($item->filename);
-    if (function_exists('bolt_divide')) bolt_divide();
+    if (function_exists('bolt_divide')) {
+        bolt_divide();
+    }
     $score_pct = number_format($score*100);
     echo "Score: $score_pct%";
     page_footer();
@@ -297,9 +311,13 @@ 
     global $refresh;
 
     $xset_result = BoltXsetResult::lookup_id($refresh->xset_result_id);
-    if (!$xset_result) error_page("Exercise set result not found");
+    if (!$xset_result) {
+        error_page("Exercise set result not found");
+    }
     $view = BoltView::lookup_id($xset_result->view_id);
-    if (!$view) error_page("view not found");
+    if (!$view) {
+        error_page("view not found");
+    }
     $iter = new BoltIter($course_doc);
     $iter->decode_state($view->state);
     $iter->at();
@@ -355,9 +373,15 @@ 
 $url_args = "course_id=$course_id";
 if ($refresh_id) {
     $refresh = BoltRefreshRec::lookup_id($refresh_id);
-    if (!$refresh) error_page("No such refresh");
-    if ($refresh->user_id != $user->id) error_page("Wrong user");
-    if ($refresh->course_id != $course_id) error_page("Wrong course");
+    if (!$refresh) {
+        error_page("No such refresh");
+    }
+    if ($refresh->user_id != $user->id) {
+        error_page("Wrong user");
+    }
+    if ($refresh->course_id != $course_id) {
+        error_page("Wrong course");
+    }
     $url_args .= "&refresh_id=$refresh_id";
 }
 $course = BoltCourse::lookup_id($course_id);
@@ -492,7 +516,9 @@ 
         $is_last = $xset->xset_record_score(
             $iter, $bolt_ex->score, $view->id, $avg_score, $repeat
         );
-        if ($repeat) $repeat->avg_score = $avg_score;
+        if ($repeat) {
+            $repeat->avg_score = $avg_score;
+        }
         if ($is_last) {
             // if the exercise set if finished, make or update DB records
             //

html/user/create_profile.php

Doc Comments +10 added lines

@@ -31,6 +31,10 @@ 
 // If $selection is provided, and if it matches one of the entries in the file,
 // it will be selected by default.
 //
+/**
+ * @param string $name
+ * @param string $filename
+ */
 function show_combo_box($name, $filename, $selection=null) {
     echo "<select name=\"$name\" class=\"form-control\">\n";
 
@@ -185,6 +189,9 @@ 
     show_language_selection($profile);
 }
 
+/**
+ * @param string $name
+ */
 function show_textarea($name, $text) {
     rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">" . $text . "</textarea>");
 }
@@ -311,6 +318,9 @@ 
     page_tail();
 }
 
+/**
+ * @param string $warning
+ */
 function show_profile_form($profile, $warning=null) {
     if ($profile) {
         page_head(tra("Edit your profile"), null, null, null, boinc_recaptcha_get_head_extra());

Spacing +20 added lines, -20 removed lines

@@ -31,7 +31,7 @@ 
 // If $selection is provided, and if it matches one of the entries in the file,
 // it will be selected by default.
 //
-function show_combo_box($name, $filename, $selection=null) {
+function show_combo_box($name, $filename, $selection = null) {
     echo "<select name=\"$name\" class=\"form-control\">\n";
 
     $file = fopen($filename, "r");
@@ -62,14 +62,14 @@ 
 <tr><td colspan=2>
 <table border=0 cellpadding=5
 <tr>
-<td valign=top><a href=\"" . IMAGE_URL . $profile->userid . '.jpg' . "\"><img src=\"" . IMAGE_URL . $profile->userid . '_sm.jpg' . "\"></a>
+<td valign=top><a href=\"" . IMAGE_URL.$profile->userid.'.jpg'."\"><img src=\"".IMAGE_URL.$profile->userid.'_sm.jpg'."\"></a>
 </td>
-<td valign=top>" .tra("%1 Your profile picture is shown to the left.",  $warning) ."
+<td valign=top>" .tra("%1 Your profile picture is shown to the left.", $warning)."
 <p>".
-tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB") ."<br />
+tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB")."<br />
 <input name=picture type=file><br>
 <p>".
-tra("To remove it from your profile, check this box:") . "
+tra("To remove it from your profile, check this box:")."
 <input type=checkbox name=delete_pic>
 <p>
 </td></tr>";
@@ -77,7 +77,7 @@ 
         end_table();
         echo "</td></tr>";
     } else {
-        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB") . "
+        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB")."
 <p>
 <input name=picture type=file>
         ");
@@ -92,7 +92,7 @@ 
     row1(tra("Language"));
     echo "<tr><td>
         <p>" .
-        tra("Select the language in which your profile is written:") . "
+        tra("Select the language in which your profile is written:")."
         <p>
     ";
     if (isset($profile->language)) {
@@ -110,7 +110,7 @@ 
     if ($publickey) {
         table_row(boinc_recaptcha_get_html($publickey));
     }
-    table_row("<p><input class=\"btn btn-default\" type=\"submit\" value=\"".tra("Create/edit profile") ."\" name=\"submit\">");
+    table_row("<p><input class=\"btn btn-default\" type=\"submit\" value=\"".tra("Create/edit profile")."\" name=\"submit\">");
 }
 
 // Returns an array containing:
@@ -124,7 +124,7 @@ 
 
     // Determine if the filetype uploaded is supported.
     // TODO: Change these to constants.
-    switch($size[2]) {
+    switch ($size[2]) {
     case '2':    // JPEG
         $image = imageCreateFromJPEG($fileName);
         break;
@@ -161,7 +161,7 @@ 
 
 function show_description() {
     echo "
-        <p>" .tra("Your %1profile%2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT) . "
+        <p>" .tra("Your %1profile%2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT)."
         <p>
     ";
 }
@@ -179,14 +179,14 @@ 
     row1(show_profile_heading1());
     rowify(show_profile_question1().html_info());
     show_textarea("response1", $response1);
-    row1( show_profile_heading2());
-    rowify( show_profile_question2().html_info());
+    row1(show_profile_heading2());
+    rowify(show_profile_question2().html_info());
     show_textarea("response2", $response2);
     show_language_selection($profile);
 }
 
 function show_textarea($name, $text) {
-    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">" . $text . "</textarea>");
+    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">".$text."</textarea>");
 }
 
 // $profile is null if user doesn't already have a profile.
@@ -233,8 +233,8 @@ 
         $delete_pic = "off";
     }
 
-    if (strlen($response1)==0 &&
-        strlen($response2)==0 &&
+    if (strlen($response1) == 0 &&
+        strlen($response2) == 0 &&
         $delete_pic != "on" &&
         !is_uploaded_file($_FILES['picture']['tmp_name'])
     ) {
@@ -248,7 +248,7 @@ 
         $profile->verification = 0;
     }
 
-    $profile ? $has_picture = $profile->has_picture: $has_picture = false;
+    $profile ? $has_picture = $profile->has_picture : $has_picture = false;
 
     if (is_uploaded_file($_FILES['picture']['tmp_name'])) {
         $has_picture = true;
@@ -263,13 +263,13 @@ 
 
         // Write the original image file to disk.
         // TODO: define a constant for image quality.
-        ImageJPEG($images[0], IMAGE_PATH . $user->id . '.jpg');
-        ImageJPEG($images[1], IMAGE_PATH . $user->id . '_sm.jpg');
+        ImageJPEG($images[0], IMAGE_PATH.$user->id.'.jpg');
+        ImageJPEG($images[1], IMAGE_PATH.$user->id.'_sm.jpg');
     }
     $response1 = sanitize_html($response1);
     $response2 = sanitize_html($response2);
 
-    $has_picture = $has_picture?1:0;
+    $has_picture = $has_picture ? 1 : 0;
     if ($profile) {
         $query = " response1 = '".BoincDb::escape_string($response1)."',"
             ." response2 = '".BoincDb::escape_string($response2)."',"
@@ -311,7 +311,7 @@ 
     page_tail();
 }
 
-function show_profile_form($profile, $warning=null) {
+function show_profile_form($profile, $warning = null) {
     if ($profile) {
         page_head(tra("Edit your profile"), null, null, null, boinc_recaptcha_get_head_extra());
     } else {

Braces +6 added lines, -2 removed lines

@@ -22,7 +22,9 @@ 
 require_once("../inc/akismet.inc");
 require_once("../inc/recaptchalib.php");
 
-if (DISABLE_PROFILES) error_page("Profiles are disabled");
+if (DISABLE_PROFILES) {
+    error_page("Profiles are disabled");
+}
 
 check_get_args(array());
 
@@ -252,7 +254,9 @@ 
 
     if (is_uploaded_file($_FILES['picture']['tmp_name'])) {
         $has_picture = true;
-        if ($profile) $profile->verification = 0;
+        if ($profile) {
+            $profile->verification = 0;
+        }
 
         // echo "<br>Name: " . $_FILES['picture']['name'];
         // echo "<br>Type: " . $_FILES['picture']['type'];

html/user/download.php

Doc Comments +3 added lines

@@ -26,6 +26,9 @@
 // that will send the needed cookies
 // and optionally download the appropriate installer,
 //
+/**
+ * @param boolean $download
+ */
 function concierge_url($user, $download) {
     global $master_url;
     $project_name = parse_config(get_config(), "<long_name>");

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
     $project_desc = parse_config(get_config(), "<project_desc>");
     $project_inst = parse_config(get_config(), "<project_inst>");
     $user = get_logged_in_user(false);
-    $x =  "http://boinc.berkeley.edu/concierge.php";
+    $x = "http://boinc.berkeley.edu/concierge.php";
     $x .= "?master_url=".urlencode($master_url);
     $x .= "&project_name=".urlencode($project_name);
     if ($project_desc) {
@@ -63,7 +63,7 @@ 
     $dlv = "BOINC";
     $dl = "BOINC";
     if ($mcv) {
-        $dlv .= " version " . version_string_maj_min_rel($mcv). " or later";
+        $dlv .= " version ".version_string_maj_min_rel($mcv)." or later";
     }
 
     $verb = "this is";

html/user/forum_reply.php

Doc Comments +3 added lines

@@ -178,6 +178,9 @@
     row2($x1, $x2, false, "20%");
 }
 
+/**
+ * @param string $text
+ */
 function quote_text($text) {
     $text = "[quote]" . $text . "[/quote]";
     return $text;

Spacing +13 added lines, -13 removed lines

@@ -50,7 +50,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -65,11 +65,11 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
-    if (post_str('add_signature',true)=="add_it"){
-        $add_signature=true;    // set a flag and concatenate later
-    }  else {
-        $add_signature=false;
+if ($content && (!$preview)) {
+    if (post_str('add_signature', true) == "add_it") {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
+        $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
     if (!akismet_check($logged_in_user, $content)) {
@@ -88,7 +88,7 @@ 
     }
 }
 
-page_head(tra("Post to thread"),'','','', $bbcode_js);
+page_head(tra("Post to thread"), '', '', '', $bbcode_js);
 
 show_forum_header($logged_in_user);
 
@@ -142,7 +142,7 @@ 
     $x1 = tra("Message:").html_info().post_warning();
     $x2 = "";
     if ($parent_post) {
-        $x2 .=" ".tra("reply to %1Message ID%2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
+        $x2 .= " ".tra("reply to %1Message ID%2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
     }
     $x2 .= "<form action=forum_reply.php?thread=".$thread->id;
 
@@ -153,7 +153,7 @@ 
     $x2 .= " method=\"post\" name=\"post\" onsubmit=\"return checkForm(this)\">\n";
     $x2 .= form_tokens($logged_in_user->authenticator);
     $x2 .= start_table_str().$bbcode_html.end_table_str()."<textarea class=\"form-control\" name=\"content\" rows=\"18\">";
-    $no_quote = get_int("no_quote", true)==1;
+    $no_quote = get_int("no_quote", true) == 1;
     if ($preview) {
         $x2 .= htmlspecialchars($content);
     } else if (!$no_quote) {
@@ -162,9 +162,9 @@ 
         }
     }
     if (!$logged_in_user->prefs->no_signature_by_default) {
-        $enable_signature="checked=\"true\"";
+        $enable_signature = "checked=\"true\"";
     } else {
-        $enable_signature="";
+        $enable_signature = "";
     }
     $x2 .= "</textarea><p> </p>
         <input class=\"btn btn-default btn-sm \" type=\"submit\" name=\"preview\" value=\"".tra("Preview")."\">
@@ -179,9 +179,9 @@ 
 }
 
 function quote_text($text) {
-    $text = "[quote]" . $text . "[/quote]";
+    $text = "[quote]".$text."[/quote]";
     return $text;
 }
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

Braces +4 added lines, -2 removed lines

@@ -25,7 +25,9 @@ 
 require_once('../inc/bbcode_html.inc');
 require_once('../inc/akismet.inc');
 
-if (DISABLE_FORUMS) error_page("Forums are disabled");
+if (DISABLE_FORUMS) {
+    error_page("Forums are disabled");
+}
 
 $logged_in_user = get_logged_in_user(true);
 BoincForumPrefs::lookup($logged_in_user);
@@ -68,7 +70,7 @@ 
 if ($content && (!$preview)){
     if (post_str('add_signature',true)=="add_it"){
         $add_signature=true;    // set a flag and concatenate later
-    }  else {
+    } else {
         $add_signature=false;
     }
     check_tokens($logged_in_user->authenticator);

html/user/gpu_list.php

Doc Comments +10 added lines

@@ -29,6 +29,9 @@ 
 // take a host.serialnum field (which may encode several GPUs)
 // and extract the model name for the given vendor
 //
+/**
+ * @param string $vendor
+ */
 function get_gpu_model($x, $vendor) {
     $descs = explode("]", $x);
     array_pop($descs);
@@ -60,6 +63,10 @@ 
 // $x->linux
 // $x->mac
 //
+/**
+ * @param string $vendor
+ * @param string $alt_vendor
+ */
 function get_gpu_list($vendor, $alt_vendor=null) {
     $clause = "plan_class like '%$vendor%'";
     if ($alt_vendor) {
@@ -144,6 +151,9 @@ 
     return $x1->avg_time > $x2->avg_time;
 }
 
+/**
+ * @param string $name
+ */
 function show_list($models, $name) {
     echo "<td><h2>$name</h2>\n";
     if (!count($models)) {

Spacing +6 added lines, -6 removed lines

@@ -60,7 +60,7 @@ 
 // $x->linux
 // $x->mac
 //
-function get_gpu_list($vendor, $alt_vendor=null) {
+function get_gpu_list($vendor, $alt_vendor = null) {
     $clause = "plan_class like '%$vendor%'";
     if ($alt_vendor) {
         $clause .= " or plan_class like '%$alt_vendor%'";
@@ -73,7 +73,7 @@ 
     }
 
     $av_ids = "";
-    foreach($avs as $av) {
+    foreach ($avs as $av) {
         $av_ids .= "$av->id, ";
     }
     if ($vendor == "cuda") {
@@ -176,14 +176,14 @@ 
         echo tra("No GPU tasks reported");
         return;
     }
-    $have_win = count($x->win)>0;
-    $have_mac = count($x->mac)>0;
-    $have_linux = count($x->linux)>0;
+    $have_win = count($x->win) > 0;
+    $have_mac = count($x->mac) > 0;
+    $have_linux = count($x->linux) > 0;
     $n = 0;
     if ($have_win) $n++;
     if ($have_mac) $n++;
     if ($have_linux) $n++;
-    $show_total = $n>1;
+    $show_total = $n > 1;
     start_table();
     echo "<tr>";
     if ($show_total) {

Braces +36 added lines, -12 removed lines

@@ -35,8 +35,12 @@ 
     foreach ($descs as $desc) {
         $desc = trim($desc, "[");
         $d = explode("|", $desc);
-        if ($d[0] == "BOINC") continue;
-        if ($d[0] != $vendor) continue;
+        if ($d[0] == "BOINC") {
+            continue;
+        }
+        if ($d[0] != $vendor) {
+            continue;
+        }
         return $d[1];
     }
     return null;
@@ -98,9 +102,13 @@ 
     $mac = array();
     foreach ($results as $r) {
         $h = BoincHost::lookup_id($r->hostid);
-        if (!$h) continue;
+        if (!$h) {
+            continue;
+        }
         $wu = BoincWorkunit::lookup_id($r->workunitid);
-        if (!$wu) continue;
+        if (!$wu) {
+            continue;
+        }
         $v = "";
         if ($vendor == "cuda") {
             $v = "CUDA";
@@ -110,7 +118,9 @@ 
             $v = "CAL";
         }
         $model = get_gpu_model($h->serialnum, $v);
-        if (!$model) continue;
+        if (!$model) {
+            continue;
+        }
         add_model($model, $r, $wu, $total);
         if (strstr($h->os_name, "Windows")) {
             add_model($model, $r, $wu, $win);
@@ -152,18 +162,26 @@ 
     }
     $max_count = 0;
     foreach ($models as $model=>$x) {
-        if ($x->count > $max_count) $max_count = $x->count;
+        if ($x->count > $max_count) {
+            $max_count = $x->count;
+        }
         $x->avg_time = $x->time/$x->count;
     }
     $min_time = 1e9;
     foreach ($models as $model=>$x) {
-        if ($x->count < $max_count/10) continue;
-        if ($x->avg_time < $min_time) $min_time = $x->avg_time;
+        if ($x->count < $max_count/10) {
+            continue;
+        }
+        if ($x->avg_time < $min_time) {
+            $min_time = $x->avg_time;
+        }
     }
     uasort($models, 'gpucmp');
     echo "<ol>\n";
     foreach ($models as $model=>$x) {
-        if ($x->count < $max_count/10) continue;
+        if ($x->count < $max_count/10) {
+            continue;
+        }
         $s = number_format($min_time/$x->avg_time, 3);
         echo "<li>($s)  $model\n";
     }
@@ -180,9 +198,15 @@ 
     $have_mac = count($x->mac)>0;
     $have_linux = count($x->linux)>0;
     $n = 0;
-    if ($have_win) $n++;
-    if ($have_mac) $n++;
-    if ($have_linux) $n++;
+    if ($have_win) {
+        $n++;
+    }
+    if ($have_mac) {
+        $n++;
+    }
+    if ($have_linux) {
+        $n++;
+    }
     $show_total = $n>1;
     start_table();
     echo "<tr>";