BOINC / boinc

html/ops/credit_study.php

Doc Comments +3 added lines

@@ -66,6 +66,9 @@
 // $x is an array of result/host objects;
 // return the variance among claimed credits given an FP weight
 //
+/**
+ * @param double $fpw
+ */
 function fpw_var($results, $fpw) {
     $cc = array();
     foreach ($results as $r) {

Spacing +9 added lines, -9 removed lines

@@ -32,7 +32,7 @@ 
 function mean($x) {
     $sum = 0;
     $n = count($x);
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $sum += $x[$i];
     }
     return $sum/$n;
@@ -42,7 +42,7 @@ 
     $sum = 0;
     $n = count($x);
     $m = mean($x);
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $d = $x[$i] - $m;
         $sum += $d*$d;
         //echo "$x[$i] ";
@@ -56,10 +56,10 @@ 
 // returns the claimed credit for a given result/host and FP weight
 //
 function cc($x, $fpw) {
-    $cps = $x->p_fpops*$fpw + $x->p_iops*(1-$fpw);
+    $cps = $x->p_fpops*$fpw + $x->p_iops*(1 - $fpw);
     $cps /= 1e9;
     $cps /= 864;
-    $cc = $x->cpu_time * $cps;
+    $cc = $x->cpu_time*$cps;
     return $cc;
 }
 
@@ -84,7 +84,7 @@ 
     $nwus = 4000;
 
     $sum = array();
-    for ($i=0; $i<=10; $i++) {
+    for ($i = 0; $i <= 10; $i++) {
         $sum[] = 0;
     }
     $r1 = _mysql_query(
@@ -96,7 +96,7 @@ 
         $r2 = _mysql_query("select * from result where workunitid=$wu->id");
         $found_zero = false;
         while ($result = _mysql_fetch_object($r2)) {
-            if ($result->granted_credit==0) continue;   // skip invalid
+            if ($result->granted_credit == 0) continue; // skip invalid
             $host = BoincHost::lookup_id($result->hostid);
             $r = new StdClass;
             $r->cpu_time = $result->cpu_time;
@@ -105,8 +105,8 @@ 
             $results[] = $r;
         }
         //echo "Wu $wu->id -------------\n";
-        if (count($results)<2) continue;
-        for ($i=0; $i<=10; $i++) {
+        if (count($results) < 2) continue;
+        for ($i = 0; $i <= 10; $i++) {
             $fpw = $i/10.;
             $sum[$i] += fpw_var($results, $fpw);
         }
@@ -120,7 +120,7 @@ 
 Number of workunits analyzed: $n
 
 ";
-    for ($i=0; $i<=10; $i++) {
+    for ($i = 0; $i <= 10; $i++) {
         $fpw = $i/10.;
         $r = $sum[$i]/$n;
         echo "FP weight $fpw: variance is $r\n";

Braces +7 added lines, -2 removed lines

@@ -96,7 +96,10 @@ 
         $r2 = _mysql_query("select * from result where workunitid=$wu->id");
         $found_zero = false;
         while ($result = _mysql_fetch_object($r2)) {
-            if ($result->granted_credit==0) continue;   // skip invalid
+            if ($result->granted_credit==0) {
+                continue;
+            }
+            // skip invalid
             $host = BoincHost::lookup_id($result->hostid);
             $r = new StdClass;
             $r->cpu_time = $result->cpu_time;
@@ -105,7 +108,9 @@ 
             $results[] = $r;
         }
         //echo "Wu $wu->id -------------\n";
-        if (count($results)<2) continue;
+        if (count($results)<2) {
+            continue;
+        }
         for ($i=0; $i<=10; $i++) {
             $fpw = $i/10.;
             $sum[$i] += fpw_var($results, $fpw);

html/ops/eah_server_status.php

Doc Comments +3 added lines

@@ -65,6 +65,9 @@
     return $running;
 }
 
+/**
+ * @param boolean $running
+ */
 function show_status($host, $function, $running) {
     echo "<tr><td>$function</td><td>$host</td>";
     if ($running) {

Indentation +3 added lines, -3 removed lines

@@ -41,9 +41,9 @@
 }
 
 function find_oldest() {
-   $result=_mysql_query("select name,create_time from result where server_state=2 order by create_time limit 1");
-   $x = _mysql_fetch_object($result);
-   return $x->create_time;
+    $result=_mysql_query("select name,create_time from result where server_state=2 order by create_time limit 1");
+    $x = _mysql_fetch_object($result);
+    return $x->create_time;
 }
 
 function daemon_status($host, $pidname) {

Spacing +22 added lines, -22 removed lines

@@ -41,7 +41,7 @@ 
 }
 
 function find_oldest() {
-   $result=_mysql_query("select name,create_time from result where server_state=2 order by create_time limit 1");
+   $result = _mysql_query("select name,create_time from result where server_state=2 order by create_time limit 1");
    $x = _mysql_fetch_object($result);
    return $x->create_time;
 }
@@ -88,25 +88,25 @@ 
 
 
 
-$dbrc = db_init(1);    // 1=soft, remember that DB might be down
+$dbrc = db_init(1); // 1=soft, remember that DB might be down
 
-page_head(PROJECT . " - Server Status");
+page_head(PROJECT." - Server Status");
 
 
 // Date stamp
 
 
-echo "<br ALIGN=RIGHT> ".PROJECT. " server status as of ".
-    date("g:i A T"). " on ". date("l, j F Y ") .
+echo "<br ALIGN=RIGHT> ".PROJECT." server status as of ".
+    date("g:i A T")." on ".date("l, j F Y ").
     " (updated every $Nmin minutes).\n";
 
-$proc_uptime=exec("cat /proc/uptime | cut -d\" \" -f-1");
+$proc_uptime = exec("cat /proc/uptime | cut -d\" \" -f-1");
 $days = (int)($proc_uptime/86400);
-$hours=(int)($proc_uptime/3600);
-$hours=$hours % 24;
-$minutes=(int)($proc_uptime/60);
-$minutes=$minutes % 60;
-echo "<br ALIGN=RIGHT>The ".PROJECT. " main server has been continuously up for ". "$days"." days "."$hours"." hours "."$minutes"." minutes.\n<P>";
+$hours = (int)($proc_uptime/3600);
+$hours = $hours%24;
+$minutes = (int)($proc_uptime/60);
+$minutes = $minutes%60;
+echo "<br ALIGN=RIGHT>The ".PROJECT." main server has been continuously up for "."$days"." days "."$hours"." hours "."$minutes"." minutes.\n<P>";
 
 // tables side by side
 echo "<TABLE><TR><TD align=center> \n";
@@ -152,11 +152,11 @@ 
 if ($dbrc) {
     echo "The database server is not accessable";
 } else {
-    $now=time(0);
-    $s_day=24*3600;
-    $d_ago=$now-$s_day;
-    $s_week=7*$s_day;
-    $w_ago=$now-$s_week;
+    $now = time(0);
+    $s_day = 24*3600;
+    $d_ago = $now - $s_day;
+    $s_week = 7*$s_day;
+    $w_ago = $now - $s_week;
 
     echo "
         <table border=2 cellpadding=6>
@@ -276,12 +276,12 @@ 
         <tr><td>invalid</td><td>".number_format($n)."</td></tr>
     ";
 
-    $n = time(0)-find_oldest();
+    $n = time(0) - find_oldest();
     $days = (int)($n/86400);
-    $hours=(int)($n/3600);
-    $hours=$hours % 24;
-    $minutes=(int)($n/60);
-    $minutes=$minutes % 60;
+    $hours = (int)($n/3600);
+    $hours = $hours%24;
+    $minutes = (int)($n/60);
+    $minutes = $minutes%60;
     echo "
         <tr><td>Oldest Unsent Result</td><td>".$days." d ".$hours." h ".$minutes." m</td></tr>
     ";
@@ -297,7 +297,7 @@ 
 
 // Display cgi-bin restriction status
 
-if (  file_exists("../../cgi-bin/.htaccess") ) {
+if (file_exists("../../cgi-bin/.htaccess")) {
     echo "<P><font color=RED>
         <b>The ".PROJECT." scheduler is currently restricted 
 	  to uwm.edu and a few other domains.

html/ops/fix_prefs.php

Doc Comments +3 added lines

@@ -12,6 +12,9 @@
 // insert "\n</venue>\n" before "</global_preferences>"
 // This fixes an XML error introduced at some point in the past
 //
+/**
+ * @return string
+ */
 function repair_prefs($prefs) {
     if (strstr($prefs, '\"')) {
         return str_replace('\"', '"', $prefs);

Braces +6 added lines, -2 removed lines

@@ -17,7 +17,9 @@ 
         return str_replace('\"', '"', $prefs);
     }
     $x = strstr($prefs, "</global_preferences>", true);
-    if (!$x) return null;
+    if (!$x) {
+        return null;
+    }
     return "$x\n    </venue>\n</global_preferences>\n";
 }
 
@@ -60,7 +62,9 @@ 
     $m = $n + 1000;
     $users = BoincUser::enum("id >= $n and id < $m");
     //echo "processing from $n\n";
-    if (!$users) break;
+    if (!$users) {
+        break;
+    }
     process_set($users);
     $n = $m;
 }

html/ops/make_puser.php

Doc Comments +6 added lines

@@ -24,12 +24,18 @@
 
 db_init();
 
+/**
+ * @param string $tag
+ */
 function parse_num($xml, $tag) {
     $x = parse_element($xml, $tag);
     if (!$x) return 0;
     return $x;
 }
 
+/**
+ * @param string $tag
+ */
 function parse_boolint($xml, $tag) {
     $x = parse_bool($xml, $tag);
     if ($x) return 1;

Braces +6 added lines, -2 removed lines

@@ -26,13 +26,17 @@
 
 function parse_num($xml, $tag) {
     $x = parse_element($xml, $tag);
-    if (!$x) return 0;
+    if (!$x) {
+        return 0;
+    }
     return $x;
 }
 
 function parse_boolint($xml, $tag) {
     $x = parse_bool($xml, $tag);
-    if ($x) return 1;
+    if ($x) {
+        return 1;
+    }
     return 0;
 }
 

html/ops/mass_email_script.php

Doc Comments +6 added lines

@@ -231,6 +231,9 @@ 
     }
 }
 
+/**
+ * @param resource $log
+ */
 function do_batch($startid, $n, $log) {
     $result = _mysql_query(
         "select * from user where id>$startid order by id limit $n"
@@ -245,6 +248,9 @@ 
     return $startid;
 }
 
+/**
+ * @param resource $log
+ */
 function do_one($thisid, $log) {
     $result = _mysql_query(
         "select * from user where id=$thisid"

Spacing +6 added lines, -6 removed lines

@@ -55,7 +55,7 @@ 
 $globals->batch = 1000;
 $globals->lapsed_interval = 60*86400;
 
-for ($i=1; $i<$argc; $i++) {
+for ($i = 1; $i < $argc; $i++) {
     if ($argv[$i] == "--batch") {
         $i++;
         $globals->batch = $argv[$i];
@@ -169,7 +169,7 @@ 
         gmdate('d F Y', $user->create_time),
         number_format($user->total_credit, 0),
         opt_out_url($user),
-        floor((time() - $user->last_rpc_time) / 86400),
+        floor((time() - $user->last_rpc_time)/86400),
     );
     return preg_replace($pat, $rep, $template);
 }
@@ -238,7 +238,7 @@ 
     while ($user = _mysql_fetch_object($result)) {
         handle_user($user);
         $startid = $user->id;
-        fputs($log, $user->id . "\n");
+        fputs($log, $user->id."\n");
         fflush($log);
     }
     _mysql_free_result($result);
@@ -252,7 +252,7 @@ 
     $user = _mysql_fetch_object($result);
     if ($user) {
         handle_user($user);
-        fputs($log, $user->id . "\n");
+        fputs($log, $user->id."\n");
         fflush($log);
     }
     _mysql_free_result($result);
@@ -289,7 +289,7 @@ 
     } else {
         $fid = fopen($id_file, 'r'); 
         if (!$fid) {
-            echo  $id_file . ' not found - create ID list and run again\n';
+            echo  $id_file.' not found - create ID list and run again\n';
             exit();
         }
         $thisid = 0;
@@ -300,7 +300,7 @@ 
         }
         fclose($fid);
     }
-    echo 'All done!' . "\n";
+    echo 'All done!'."\n";
 }
 
 if (!function_exists('make_php_mailer')) {

Braces +6 added lines, -2 removed lines

@@ -150,7 +150,9 @@ 
     $x = 0;
     $result = _mysql_query("select rpc_time from host where userid=$user->id");
     while ($host = _mysql_fetch_object($result)) {
-        if ($host->rpc_time > $x) $x = $host->rpc_time;
+        if ($host->rpc_time > $x) {
+            $x = $host->rpc_time;
+        }
     }
     _mysql_free_result($result);
     return $x;
@@ -283,7 +285,9 @@ 
     if ($id_file == "") {
         while (1) {
             $new_startid = do_batch($startid, $globals->batch, $f);
-            if ($new_startid == $startid) break;
+            if ($new_startid == $startid) {
+                break;
+            }
             $startid = $new_startid;
         }
     } else {

html/ops/notify.php

Doc Comments +3 added lines

@@ -39,6 +39,9 @@
     BoincNotify::delete_aux("create_time < $t");
 }
 
+/**
+ * @param string $message
+ */
 function send_notify_email($userid, $message) {
     $user = BoincUser::lookup_id($userid);
     $subject = "Daily notification summary from ".PROJECT;

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
 // delete notifications older than 90 days
 //
 function delete_old_notifies() {
-    $t = time()-90*86400;
+    $t = time() - 90*86400;
     BoincNotify::delete_aux("create_time < $t");
 }
 
@@ -61,7 +61,7 @@ 
 function send_notify_emails() {
     $db = BoincDb::get();
 
-    $t = time() - (86400 + 3600);  // 1-hour slop factor
+    $t = time() - (86400 + 3600); // 1-hour slop factor
     $query = "select notify.* from ".$db->db_name.".notify, ".$db->db_name.".forum_preferences where forum_preferences.pm_notification=2 and notify.userid = forum_preferences.userid and notify.create_time > $t";
 
     $notifies = BoincNotify::enum_general($query);

html/ops/remote_server_status.php

Doc Comments +6 added lines

@@ -41,6 +41,9 @@ 
 
 // see if a web server is running at the given URL
 //
+/**
+ * @param string $url
+ */
 function web_server_running($url) {
     $u = parse_url($url);
     $url = $u['scheme']."://".$u['host'];
@@ -56,6 +59,9 @@ 
 
 // see if the given daemon is running on the host by checking its PID
 //
+/**
+ * @param string $host
+ */
 function is_daemon_running($host, $d) {
     if ($d->pid_file) {
         $path = "../../pid_$host/".(string)$d->pid_file;

Spacing +7 added lines, -7 removed lines

@@ -80,41 +80,41 @@
         die("can't parse config file\n");
     }
     $config = $c->config;
-    $master_url = (string) $config->master_url;
+    $master_url = (string)$config->master_url;
     $u = parse_url($master_url);
     $master_host = $u["host"];
 
-    $url = (string) $config->download_url;
+    $url = (string)$config->download_url;
     $u = parse_url($url);
     $h = $u["host"];
     if ($h != $master_host) {
         $y = new StdClass;
         $y->cmd = 'Download server';
         $y->host = $h;
-        $y->status = web_server_running($url)?1:0;
+        $y->status = web_server_running($url) ? 1 : 0;
         $x[] = $y;
     }
-    $url = (string) $config->upload_url;
+    $url = (string)$config->upload_url;
     $u = parse_url($url);
     $h = $u["host"];
     if ($h != $master_host) {
         $y = new StdClass;
         $y->cmd = 'Upload server';
         $y->host = $h;
-        $y->status = web_server_running($url)?1:0;
+        $y->status = web_server_running($url) ? 1 : 0;
         $x[] = $y;
     }
 
     $main_host = (string)$c->config->host;
     if ($c->config->www_host) {
-        $web_host = (string) $c->config->www_host;
+        $web_host = (string)$c->config->www_host;
     } else {
         $web_host = $main_host;
     }
     $daemons = $c->daemons;
     foreach ($daemons->daemon as $d) {
         if ((int)$d->disabled != 0) continue;
-        $host = $d->host?(string)$d->host:$main_host;
+        $host = $d->host ? (string)$d->host : $main_host;
         if ($host != $web_host) {
             $y = new StdClass;
             $y->cmd = (string)$d->cmd;

Braces +9 added lines, -3 removed lines

@@ -65,10 +65,14 @@ 
         $path = "../../pid_$host/$prog".".pid";
     }
     $pid = trim(@file_get_contents($path));
-    if ($pid === false) return false;
+    if ($pid === false) {
+        return false;
+    }
     $cmd = "ssh $host 'ps $pid'";
     $out = exec($cmd);
-    if (strstr($out, $pid)) return true;
+    if (strstr($out, $pid)) {
+        return true;
+    }
     return false;
 }
 
@@ -113,7 +117,9 @@ 
     }
     $daemons = $c->daemons;
     foreach ($daemons->daemon as $d) {
-        if ((int)$d->disabled != 0) continue;
+        if ((int)$d->disabled != 0) {
+            continue;
+        }
         $host = $d->host?(string)$d->host:$main_host;
         if ($host != $web_host) {
             $y = new StdClass;

html/ops/single_job_setup.php

Doc Comments +8 added lines

@@ -107,10 +107,18 @@
     }
 }
 
+/**
+ * @param integer $i
+ *
+ * @return string
+ */
 function app_version_dir($app_name, $i, $platform) {
     return "apps/$app_name/1.$i/$platform";
 }
 
+/**
+ * @param integer $i
+ */
 function make_app_version_dir($app_name, $i, $platform) {
     @mkdir("apps/$app_name");
     @mkdir("apps/$app_name/1.$i");

Braces +6 added lines, -2 removed lines

@@ -132,7 +132,9 @@ 
     $have_latest_wrapper = false;
     while (1) {
         $app_dir = app_version_dir($app_name, $i, $platform);
-        if (!file_exists($app_dir)) break;
+        if (!file_exists($app_dir)) {
+            break;
+        }
         $latest_i = $i;
         $i++;
     }
@@ -200,7 +202,9 @@ 
     }
 }
 
-if ($argc != 2) usage();
+if ($argc != 2) {
+    usage();
+}
 $boinc_samples_dir = $argv[1];
 check_wrapper_exists();
 get_includes();

html/ops/team_export.php

Doc Comments +3 added lines

@@ -58,6 +58,9 @@
     return $x;
 }
 
+/**
+ * @param resource $f
+ */
 function handle_team($team, $f) {
     echo "Team: $team->name\n";
     $user = BoincUser::lookup_id($team->userid);

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
     $f = fopen("temp.xml", "w");
     $teams = BoincTeam::enum(null);
     fwrite($f, "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<teams>\n");
-    foreach($teams as $team) {
+    foreach ($teams as $team) {
         handle_team($team, $f);
     }
     fwrite($f, "</teams>\n");