Completed
Pull Request — master (#1824)
by Christian
11:34
created
drupal/sites/default/boinc/modules/contrib/wysiwyg/wysiwyg.module 6 patches
Doc Comments   +6 added lines, -4 removed lines patch added patch discarded remove patch
@@ -674,6 +674,7 @@  discard block
 block discarded – undo
674 674
 
675 675
 /**
676 676
  * Remove a profile from the database.
677
+ * @param stdClass $wysiwyg
677 678
  */
678 679
 function wysiwyg_profile_delete($wysiwyg) {
679 680
   if (!isset($wysiwyg->format)) {
@@ -922,7 +923,7 @@  discard block
 block discarded – undo
922 923
  *   Whether to prefix the resulting path with base_path().
923 924
  *
924 925
  * @return
925
- *   The path to the specified library.
926
+ string   The path to the specified library.
926 927
  *
927 928
  * @ingroup libraries
928 929
  */
@@ -1014,7 +1015,7 @@  discard block
 block discarded – undo
1014 1015
 /**
1015 1016
  * Return a list of directories by modules implementing wysiwyg_include_directory().
1016 1017
  *
1017
- * @param $plugintype
1018
+ * @param string $plugintype
1018 1019
  *   The type of a plugin; can be 'editors'.
1019 1020
  *
1020 1021
  * @return
@@ -1039,10 +1040,11 @@  discard block
 block discarded – undo
1039 1040
  *
1040 1041
  * @param $module
1041 1042
  *   The module that owns the hook.
1042
- * @param $identifier
1043
+ * @param string $identifier
1043 1044
  *   Either the module or 'wysiwyg_' . $file->name
1044
- * @param $hook
1045
+ * @param string $hook
1045 1046
  *   The name of the hook being invoked.
1047
+ * @param string $path
1046 1048
  */
1047 1049
 function _wysiwyg_process_include($module, $identifier, $path, $hook) {
1048 1050
   $function = $identifier . '_' . $hook;
Please login to merge, or discard this patch.
Indentation   +416 added lines, -416 removed lines patch added patch discarded remove patch
@@ -9,19 +9,19 @@  discard block
 block discarded – undo
9 9
  * Implementation of hook_menu().
10 10
  */
11 11
 function wysiwyg_menu() {
12
-  $items['admin/settings/wysiwyg'] = array(
12
+    $items['admin/settings/wysiwyg'] = array(
13 13
     'title' => 'Wysiwyg profiles',
14 14
     'page callback' => 'drupal_get_form',
15 15
     'page arguments' => array('wysiwyg_profile_overview'),
16 16
     'description' => 'Configure client-side editors.',
17 17
     'access arguments' => array('administer filters'),
18 18
     'file' => 'wysiwyg.admin.inc',
19
-  );
20
-  $items['admin/settings/wysiwyg/profile'] = array(
19
+    );
20
+    $items['admin/settings/wysiwyg/profile'] = array(
21 21
     'title' => 'List',
22 22
     'type' => MENU_DEFAULT_LOCAL_TASK,
23
-  );
24
-  $items['admin/settings/wysiwyg/profile/%wysiwyg_profile/edit'] = array(
23
+    );
24
+    $items['admin/settings/wysiwyg/profile/%wysiwyg_profile/edit'] = array(
25 25
     'title' => 'Edit',
26 26
     'page callback' => 'drupal_get_form',
27 27
     'page arguments' => array('wysiwyg_profile_form', 4),
@@ -30,8 +30,8 @@  discard block
 block discarded – undo
30 30
     'tab_root' => 'admin/settings/wysiwyg/profile',
31 31
     'tab_parent' => 'admin/settings/wysiwyg/profile/%wysiwyg_profile',
32 32
     'type' => MENU_LOCAL_TASK,
33
-  );
34
-  $items['admin/settings/wysiwyg/profile/%wysiwyg_profile/delete'] = array(
33
+    );
34
+    $items['admin/settings/wysiwyg/profile/%wysiwyg_profile/delete'] = array(
35 35
     'title' => 'Remove',
36 36
     'page callback' => 'drupal_get_form',
37 37
     'page arguments' => array('wysiwyg_profile_delete_confirm', 4),
@@ -41,15 +41,15 @@  discard block
 block discarded – undo
41 41
     'tab_parent' => 'admin/settings/wysiwyg/profile/%wysiwyg_profile',
42 42
     'type' => MENU_LOCAL_TASK,
43 43
     'weight' => 10,
44
-  );
45
-  $items['wysiwyg/%'] = array(
44
+    );
45
+    $items['wysiwyg/%'] = array(
46 46
     'page callback' => 'wysiwyg_dialog',
47 47
     'page arguments' => array(1),
48 48
     'access arguments' => array('access content'),
49 49
     'type' => MENU_CALLBACK,
50 50
     'file' => 'wysiwyg.dialog.inc',
51
-  );
52
-  return $items;
51
+    );
52
+    return $items;
53 53
 }
54 54
 
55 55
 /**
@@ -59,37 +59,37 @@  discard block
 block discarded – undo
59 59
  * @see template_preprocess_page(), theme.inc
60 60
  */
61 61
 function wysiwyg_theme() {
62
-  return array(
62
+    return array(
63 63
     'wysiwyg_profile_overview' => array(
64
-      'arguments' => array('form' => NULL),
64
+        'arguments' => array('form' => NULL),
65 65
     ),
66 66
     'wysiwyg_admin_button_table' => array(
67
-      'arguments' => array('form' => NULL),
67
+        'arguments' => array('form' => NULL),
68 68
     ),
69 69
     'wysiwyg_dialog_page' => array(
70
-      'arguments' => array('content' => NULL, 'show_messages' => TRUE),
71
-      'file' => 'wysiwyg.dialog.inc',
72
-      'template' => 'wysiwyg-dialog-page',
70
+        'arguments' => array('content' => NULL, 'show_messages' => TRUE),
71
+        'file' => 'wysiwyg.dialog.inc',
72
+        'template' => 'wysiwyg-dialog-page',
73 73
     ),
74
-  );
74
+    );
75 75
 }
76 76
 
77 77
 /**
78 78
  * Implementation of hook_help().
79 79
  */
80 80
 function wysiwyg_help($path, $arg) {
81
-  switch ($path) {
81
+    switch ($path) {
82 82
     case 'admin/settings/wysiwyg':
83 83
       $output = '<p>' . t('A Wysiwyg profile is associated with an input format. A Wysiwyg profile defines which client-side editor is loaded with a particular input format, what buttons or themes are enabled for the editor, how the editor is displayed, and a few other editor-specific functions.') . '</p>';
84
-      return $output;
85
-  }
84
+        return $output;
85
+    }
86 86
 }
87 87
 
88 88
 /**
89 89
  * Clear wysiwyg cache on admin/build/modules form.
90 90
  */
91 91
 function wysiwyg_form_system_modules_alter(&$form, $form_state) {
92
-  wysiwyg_profile_load_all(TRUE);
92
+    wysiwyg_profile_load_all(TRUE);
93 93
 }
94 94
 
95 95
 /**
@@ -104,11 +104,11 @@  discard block
 block discarded – undo
104 104
  * @see wysiwyg_process_form()
105 105
  */
106 106
 function wysiwyg_form_alter(&$form, &$form_state) {
107
-  $form['#after_build'][] = 'wysiwyg_process_form';
108
-  // Teaser splitter is unconditionally removed and NOT supported.
109
-  if (isset($form['body_field'])) {
107
+    $form['#after_build'][] = 'wysiwyg_process_form';
108
+    // Teaser splitter is unconditionally removed and NOT supported.
109
+    if (isset($form['body_field'])) {
110 110
     unset($form['body_field']['teaser_js']);
111
-  }
111
+    }
112 112
 }
113 113
 
114 114
 /**
@@ -123,53 +123,53 @@  discard block
 block discarded – undo
123 123
  * @see wysiwyg_elements(), filter_form()
124 124
  */
125 125
 function wysiwyg_process_form(&$form) {
126
-  // Iterate over element children; resetting array keys to access last index.
127
-  if ($children = array_values(element_children($form))) {
126
+    // Iterate over element children; resetting array keys to access last index.
127
+    if ($children = array_values(element_children($form))) {
128 128
     foreach ($children as $index => $item) {
129
-      $element = &$form[$item];
129
+        $element = &$form[$item];
130 130
 
131
-      // filter_form() always uses the key 'format'. We need a type-agnostic
132
-      // match to prevent false positives. Also, there must have been at least
133
-      // one element on this level.
134
-      if (($item === 'format' || $item === 'signature_format') && $index > 0) {
131
+        // filter_form() always uses the key 'format'. We need a type-agnostic
132
+        // match to prevent false positives. Also, there must have been at least
133
+        // one element on this level.
134
+        if (($item === 'format' || $item === 'signature_format') && $index > 0) {
135 135
         // Make sure we either match a input format selector or input format
136 136
         // guidelines (displayed if user has access to one input format only).
137 137
         if ((isset($element['#type']) && $element['#type'] == 'fieldset') || isset($element['format']['guidelines'])) {
138
-          // The element before this element is the target form field.
139
-          $field = &$form[$children[$index - 1]];
138
+            // The element before this element is the target form field.
139
+            $field = &$form[$children[$index - 1]];
140 140
 
141
-          // Allow modules to programmatically enforce no client-side editor by
142
-          // setting the #wysiwyg property to FALSE.
143
-          if (isset($field['#wysiwyg']) && !$field['#wysiwyg']) {
141
+            // Allow modules to programmatically enforce no client-side editor by
142
+            // setting the #wysiwyg property to FALSE.
143
+            if (isset($field['#wysiwyg']) && !$field['#wysiwyg']) {
144 144
             // A 'format' element should not have any child elements that may
145 145
             // need processing, so it should be safe to skip the recursion that
146 146
             // happens at the end of this function, and move on to the next
147 147
             // element on the same level.
148 148
             continue;
149
-          }
150
-
151
-          // If this textarea is #resizable and we will load at least one
152
-          // editor, then only load the behavior and let the 'none' editor
153
-          // attach/detach it to avoid hi-jacking the UI. Due to our CSS class
154
-          // parsing, we can add arbitrary parameters for each input format.
155
-          // The #resizable property will be removed below, if at least one
156
-          // profile has been loaded.
157
-          $extra_class = '';
158
-          if (!empty($field['#resizable'])) {
149
+            }
150
+
151
+            // If this textarea is #resizable and we will load at least one
152
+            // editor, then only load the behavior and let the 'none' editor
153
+            // attach/detach it to avoid hi-jacking the UI. Due to our CSS class
154
+            // parsing, we can add arbitrary parameters for each input format.
155
+            // The #resizable property will be removed below, if at least one
156
+            // profile has been loaded.
157
+            $extra_class = '';
158
+            if (!empty($field['#resizable'])) {
159 159
             $extra_class = ' wysiwyg-resizable-1';
160 160
             drupal_add_js('misc/textarea.js');
161
-          }
162
-
163
-          // Determine the available input formats. The last child element is a
164
-          // link to "More information about formatting options". When only one
165
-          // input format is displayed, we also have to remove formatting
166
-          // guidelines, stored in the child 'format'.
167
-          $formats = element_children($element);
168
-          array_pop($formats);
169
-          if (($key = array_search('format', $formats)) !== FALSE) {
161
+            }
162
+
163
+            // Determine the available input formats. The last child element is a
164
+            // link to "More information about formatting options". When only one
165
+            // input format is displayed, we also have to remove formatting
166
+            // guidelines, stored in the child 'format'.
167
+            $formats = element_children($element);
168
+            array_pop($formats);
169
+            if (($key = array_search('format', $formats)) !== FALSE) {
170 170
             unset($formats[$key]);
171
-          }
172
-          foreach ($formats as $format) {
171
+            }
172
+            foreach ($formats as $format) {
173 173
             // Default to 'none' editor (Drupal's default behaviors).
174 174
             $editor = 'none';
175 175
             $status = 1;
@@ -177,51 +177,51 @@  discard block
 block discarded – undo
177 177
             // Fetch the profile associated to this input format.
178 178
             $profile = wysiwyg_get_profile($format);
179 179
             if ($profile) {
180
-              $loaded = TRUE;
181
-              $editor = $profile->editor;
182
-              $status = (int) wysiwyg_user_get_status($profile);
183
-              if (isset($profile->settings['show_toggle'])) {
180
+                $loaded = TRUE;
181
+                $editor = $profile->editor;
182
+                $status = (int) wysiwyg_user_get_status($profile);
183
+                if (isset($profile->settings['show_toggle'])) {
184 184
                 $toggle = (int) $profile->settings['show_toggle'];
185
-              }
186
-              // Check editor theme (and reset it if not/no longer available).
187
-              $theme = wysiwyg_get_editor_themes($profile, (isset($profile->settings['theme']) ? $profile->settings['theme'] : ''));
188
-
189
-              // Add plugin settings (first) for this input format.
190
-              wysiwyg_add_plugin_settings($profile);
191
-              // Add profile settings for this input format.
192
-              wysiwyg_add_editor_settings($profile, $theme);
185
+                }
186
+                // Check editor theme (and reset it if not/no longer available).
187
+                $theme = wysiwyg_get_editor_themes($profile, (isset($profile->settings['theme']) ? $profile->settings['theme'] : ''));
188
+
189
+                // Add plugin settings (first) for this input format.
190
+                wysiwyg_add_plugin_settings($profile);
191
+                // Add profile settings for this input format.
192
+                wysiwyg_add_editor_settings($profile, $theme);
193 193
             }
194 194
 
195 195
             // Use a prefix/suffix for a single input format, or attach to input
196 196
             // format selector radio buttons.
197 197
             if (isset($element['format']['guidelines'])) {
198
-              $element['format']['guidelines']['#prefix'] = '<div class="wysiwyg wysiwyg-format-' . $format . ' wysiwyg-editor-' . $editor . ' wysiwyg-field-' . $field['#id'] . ' wysiwyg-status-' . $status . ' wysiwyg-toggle-' . $toggle . $extra_class . '">';
199
-              $element['format']['guidelines']['#suffix'] = '</div>';
200
-              // Edge-case: Default format contains no input filters.
201
-              if (empty($element['format']['guidelines']['#value'])) {
198
+                $element['format']['guidelines']['#prefix'] = '<div class="wysiwyg wysiwyg-format-' . $format . ' wysiwyg-editor-' . $editor . ' wysiwyg-field-' . $field['#id'] . ' wysiwyg-status-' . $status . ' wysiwyg-toggle-' . $toggle . $extra_class . '">';
199
+                $element['format']['guidelines']['#suffix'] = '</div>';
200
+                // Edge-case: Default format contains no input filters.
201
+                if (empty($element['format']['guidelines']['#value'])) {
202 202
                 $element['format']['guidelines']['#value'] = ' ';
203
-              }
203
+                }
204 204
             }
205 205
             else {
206
-              $element[$format]['#attributes']['class'] = (isset($element[$format]['#attributes']['class']) ? $element[$format]['#attributes']['class'] . ' ' : '');
207
-              $element[$format]['#attributes']['class'] .= 'wysiwyg wysiwyg-format-' . $format . ' wysiwyg-editor-' . $editor . ' wysiwyg-field-' . $field['#id'] . ' wysiwyg-status-' . $status . ' wysiwyg-toggle-' . $toggle . $extra_class;
206
+                $element[$format]['#attributes']['class'] = (isset($element[$format]['#attributes']['class']) ? $element[$format]['#attributes']['class'] . ' ' : '');
207
+                $element[$format]['#attributes']['class'] .= 'wysiwyg wysiwyg-format-' . $format . ' wysiwyg-editor-' . $editor . ' wysiwyg-field-' . $field['#id'] . ' wysiwyg-status-' . $status . ' wysiwyg-toggle-' . $toggle . $extra_class;
208
+            }
208 209
             }
209
-          }
210 210
 
211
-          // If we loaded at least one editor, then the 'none' editor will
212
-          // handle resizable textareas instead of core.
213
-          if (isset($loaded) && !empty($field['#resizable'])) {
211
+            // If we loaded at least one editor, then the 'none' editor will
212
+            // handle resizable textareas instead of core.
213
+            if (isset($loaded) && !empty($field['#resizable'])) {
214 214
             $field['#resizable'] = FALSE;
215
-          }
215
+            }
216 216
         }
217 217
         // If this element is 'format', do not recurse further.
218 218
         continue;
219
-      }
220
-      // Recurse into children.
221
-      wysiwyg_process_form($element);
219
+        }
220
+        // Recurse into children.
221
+        wysiwyg_process_form($element);
222
+    }
222 223
     }
223
-  }
224
-  return $form;
224
+    return $form;
225 225
 }
226 226
 
227 227
 /**
@@ -239,12 +239,12 @@  discard block
 block discarded – undo
239 239
  * @see wysiwyg_load_editor(), wysiwyg_get_editor()
240 240
  */
241 241
 function wysiwyg_get_profile($format) {
242
-  if ($profile = wysiwyg_profile_load($format)) {
242
+    if ($profile = wysiwyg_profile_load($format)) {
243 243
     if (wysiwyg_load_editor($profile)) {
244
-      return $profile;
244
+        return $profile;
245
+    }
245 246
     }
246
-  }
247
-  return FALSE;
247
+    return FALSE;
248 248
 }
249 249
 
250 250
 /**
@@ -259,82 +259,82 @@  discard block
 block discarded – undo
259 259
  * @see wysiwyg_get_profile()
260 260
  */
261 261
 function wysiwyg_load_editor($profile) {
262
-  static $settings_added;
263
-  static $loaded = array();
262
+    static $settings_added;
263
+    static $loaded = array();
264 264
 
265
-  $name = $profile->editor;
266
-  // Library files must be loaded only once.
267
-  if (!isset($loaded[$name])) {
265
+    $name = $profile->editor;
266
+    // Library files must be loaded only once.
267
+    if (!isset($loaded[$name])) {
268 268
     // Load editor.
269 269
     $editor = wysiwyg_get_editor($name);
270 270
     if ($editor) {
271
-      // Determine library files to load.
272
-      // @todo Allow to configure the library/execMode to use.
273
-      if (isset($profile->settings['library']) && isset($editor['libraries'][$profile->settings['library']])) {
271
+        // Determine library files to load.
272
+        // @todo Allow to configure the library/execMode to use.
273
+        if (isset($profile->settings['library']) && isset($editor['libraries'][$profile->settings['library']])) {
274 274
         $library = $profile->settings['library'];
275 275
         $files = $editor['libraries'][$library]['files'];
276
-      }
277
-      else {
276
+        }
277
+        else {
278 278
         // Fallback to the first defined library by default (external libraries can change).
279 279
         $library = key($editor['libraries']);
280 280
         $files = array_shift($editor['libraries']);
281 281
         $files = $files['files'];
282
-      }
283
-      foreach ($files as $file => $options) {
282
+        }
283
+        foreach ($files as $file => $options) {
284 284
         if (is_array($options)) {
285
-          $options += array('type' => 'module', 'scope' => 'header', 'defer' => FALSE, 'cache' => TRUE, 'preprocess' => TRUE);
286
-          drupal_add_js($editor['library path'] . '/' . $file, $options['type'], $options['scope'], $options['defer'], $options['cache'], $options['preprocess']);
285
+            $options += array('type' => 'module', 'scope' => 'header', 'defer' => FALSE, 'cache' => TRUE, 'preprocess' => TRUE);
286
+            drupal_add_js($editor['library path'] . '/' . $file, $options['type'], $options['scope'], $options['defer'], $options['cache'], $options['preprocess']);
287 287
         }
288 288
         else {
289
-          drupal_add_js($editor['library path'] . '/' . $options);
289
+            drupal_add_js($editor['library path'] . '/' . $options);
290 290
         }
291
-      }
292
-      // If editor defines an additional load callback, invoke it.
293
-      // @todo Isn't the settings callback sufficient?
294
-      if (isset($editor['load callback']) && function_exists($editor['load callback'])) {
291
+        }
292
+        // If editor defines an additional load callback, invoke it.
293
+        // @todo Isn't the settings callback sufficient?
294
+        if (isset($editor['load callback']) && function_exists($editor['load callback'])) {
295 295
         $editor['load callback']($editor, $library);
296
-      }
297
-      // Load JavaScript integration files for this editor.
298
-      $files = array();
299
-      if (isset($editor['js files'])) {
296
+        }
297
+        // Load JavaScript integration files for this editor.
298
+        $files = array();
299
+        if (isset($editor['js files'])) {
300 300
         $files = $editor['js files'];
301
-      }
302
-      foreach ($files as $file) {
301
+        }
302
+        foreach ($files as $file) {
303 303
         drupal_add_js($editor['js path'] . '/' . $file);
304
-      }
305
-      // Load CSS stylesheets for this editor.
306
-      $files = array();
307
-      if (isset($editor['css files'])) {
304
+        }
305
+        // Load CSS stylesheets for this editor.
306
+        $files = array();
307
+        if (isset($editor['css files'])) {
308 308
         $files = $editor['css files'];
309
-      }
310
-      foreach ($files as $file) {
309
+        }
310
+        foreach ($files as $file) {
311 311
         drupal_add_css($editor['css path'] . '/' . $file);
312
-      }
312
+        }
313 313
 
314
-      drupal_add_js(array('wysiwyg' => array(
314
+        drupal_add_js(array('wysiwyg' => array(
315 315
         'configs' => array($editor['name'] => array('global' => array(
316
-          // @todo Move into (global) editor settings.
317
-          // If JS compression is enabled, at least TinyMCE is unable to determine
318
-          // its own base path and exec mode since it can't find the script name.
319
-          'editorBasePath' => base_path() . $editor['library path'],
320
-          'execMode' => $library,
316
+            // @todo Move into (global) editor settings.
317
+            // If JS compression is enabled, at least TinyMCE is unable to determine
318
+            // its own base path and exec mode since it can't find the script name.
319
+            'editorBasePath' => base_path() . $editor['library path'],
320
+            'execMode' => $library,
321 321
         ))),
322
-      )), 'setting');
322
+        )), 'setting');
323 323
 
324
-      $loaded[$name] = TRUE;
324
+        $loaded[$name] = TRUE;
325 325
     }
326 326
     else {
327
-      $loaded[$name] = FALSE;
327
+        $loaded[$name] = FALSE;
328
+    }
328 329
     }
329
-  }
330 330
 
331
-  // Add basic Wysiwyg settings if any editor has been added.
332
-  if (!isset($settings_added) && $loaded[$name]) {
331
+    // Add basic Wysiwyg settings if any editor has been added.
332
+    if (!isset($settings_added) && $loaded[$name]) {
333 333
     drupal_add_js(array('wysiwyg' => array(
334
-      'configs' => array(),
335
-      'plugins' => array(),
336
-      'disable' => t('Disable rich-text'),
337
-      'enable' => t('Enable rich-text'),
334
+        'configs' => array(),
335
+        'plugins' => array(),
336
+        'disable' => t('Disable rich-text'),
337
+        'enable' => t('Enable rich-text'),
338 338
     )), 'setting');
339 339
 
340 340
     $path = drupal_get_path('module', 'wysiwyg');
@@ -355,26 +355,26 @@  discard block
 block discarded – undo
355 355
     drupal_add_js($path . '/wysiwyg.js', 'module', 'footer');
356 356
 
357 357
     $settings_added = TRUE;
358
-  }
358
+    }
359 359
 
360
-  return $loaded[$name];
360
+    return $loaded[$name];
361 361
 }
362 362
 
363 363
 /**
364 364
  * Add editor settings for a given input format.
365 365
  */
366 366
 function wysiwyg_add_editor_settings($profile, $theme) {
367
-  static $formats = array();
367
+    static $formats = array();
368 368
 
369
-  if (!isset($formats[$profile->format])) {
369
+    if (!isset($formats[$profile->format])) {
370 370
     $config = wysiwyg_get_editor_config($profile, $theme);
371 371
     // drupal_to_js() does not properly convert numeric array keys, so we need
372 372
     // to use a string instead of the format id.
373 373
     if ($config) {
374
-      drupal_add_js(array('wysiwyg' => array('configs' => array($profile->editor => array('format' . $profile->format => $config)))), 'setting');
374
+        drupal_add_js(array('wysiwyg' => array('configs' => array($profile->editor => array('format' . $profile->format => $config)))), 'setting');
375 375
     }
376 376
     $formats[$profile->format] = TRUE;
377
-  }
377
+    }
378 378
 }
379 379
 
380 380
 /**
@@ -402,86 +402,86 @@  discard block
 block discarded – undo
402 402
  *   and simplify this entire function.
403 403
  */
404 404
 function wysiwyg_add_plugin_settings($profile) {
405
-  static $plugins = array();
406
-  static $processed_plugins = array();
407
-  static $processed_formats = array();
405
+    static $plugins = array();
406
+    static $processed_plugins = array();
407
+    static $processed_formats = array();
408 408
 
409
-  // Each input format must only processed once.
410
-  // @todo ...as long as we do not have multiple profiles per format.
411
-  if (isset($processed_formats[$profile->format])) {
409
+    // Each input format must only processed once.
410
+    // @todo ...as long as we do not have multiple profiles per format.
411
+    if (isset($processed_formats[$profile->format])) {
412 412
     return;
413
-  }
414
-  $processed_formats[$profile->format] = TRUE;
413
+    }
414
+    $processed_formats[$profile->format] = TRUE;
415 415
 
416
-  $editor = wysiwyg_get_editor($profile->editor);
416
+    $editor = wysiwyg_get_editor($profile->editor);
417 417
 
418
-  // Collect native plugins for this editor provided via hook_wysiwyg_plugin()
419
-  // and Drupal plugins provided via hook_wysiwyg_include_directory().
420
-  if (!array_key_exists($editor['name'], $plugins)) {
418
+    // Collect native plugins for this editor provided via hook_wysiwyg_plugin()
419
+    // and Drupal plugins provided via hook_wysiwyg_include_directory().
420
+    if (!array_key_exists($editor['name'], $plugins)) {
421 421
     $plugins[$editor['name']] = wysiwyg_get_plugins($editor['name']);
422
-  }
422
+    }
423 423
 
424
-  // Nothing to do, if there are no plugins.
425
-  if (empty($plugins[$editor['name']])) {
424
+    // Nothing to do, if there are no plugins.
425
+    if (empty($plugins[$editor['name']])) {
426 426
     return;
427
-  }
427
+    }
428 428
 
429
-  // Determine name of proxy plugin for Drupal plugins.
430
-  $proxy = (isset($editor['proxy plugin']) ? key($editor['proxy plugin']) : '');
429
+    // Determine name of proxy plugin for Drupal plugins.
430
+    $proxy = (isset($editor['proxy plugin']) ? key($editor['proxy plugin']) : '');
431 431
 
432
-  // Process native editor plugins.
433
-  if (isset($editor['plugin settings callback'])) {
432
+    // Process native editor plugins.
433
+    if (isset($editor['plugin settings callback'])) {
434 434
     // @todo Require PHP 5.1 in 3.x and use array_intersect_key().
435 435
     $profile_plugins_native = array();
436 436
     foreach ($plugins[$editor['name']] as $plugin => $meta) {
437
-      // Skip Drupal plugins (handled below).
438
-      if ($plugin === $proxy) {
437
+        // Skip Drupal plugins (handled below).
438
+        if ($plugin === $proxy) {
439 439
         continue;
440
-      }
441
-      // Only keep native plugins that are enabled in this profile.
442
-      if (isset($profile->settings['buttons'][$plugin])) {
440
+        }
441
+        // Only keep native plugins that are enabled in this profile.
442
+        if (isset($profile->settings['buttons'][$plugin])) {
443 443
         $profile_plugins_native[$plugin] = $meta;
444
-      }
444
+        }
445 445
     }
446 446
     // Invoke the editor's plugin settings callback, so it can populate the
447 447
     // settings for native external plugins with required values.
448 448
     $settings_native = call_user_func($editor['plugin settings callback'], $editor, $profile, $profile_plugins_native);
449 449
 
450 450
     if ($settings_native) {
451
-      drupal_add_js(array('wysiwyg' => array('plugins' => array('format' . $profile->format => array('native' => $settings_native)))), 'setting');
451
+        drupal_add_js(array('wysiwyg' => array('plugins' => array('format' . $profile->format => array('native' => $settings_native)))), 'setting');
452
+    }
452 453
     }
453
-  }
454 454
 
455
-  // Process Drupal plugins.
456
-  if ($proxy && isset($editor['proxy plugin settings callback'])) {
455
+    // Process Drupal plugins.
456
+    if ($proxy && isset($editor['proxy plugin settings callback'])) {
457 457
     $profile_plugins_drupal = array();
458 458
     foreach (wysiwyg_get_all_plugins() as $plugin => $meta) {
459
-      if (isset($profile->settings['buttons'][$proxy][$plugin])) {
459
+        if (isset($profile->settings['buttons'][$proxy][$plugin])) {
460 460
         // JavaScript and plugin-specific settings for Drupal plugins must be
461 461
         // loaded and processed only once. Plugin information is cached
462 462
         // statically to pass it to the editor's proxy plugin settings callback.
463 463
         if (!isset($processed_plugins[$proxy][$plugin])) {
464
-          $profile_plugins_drupal[$plugin] = $processed_plugins[$proxy][$plugin] = $meta;
465
-          // Load the Drupal plugin's JavaScript.
466
-          drupal_add_js($meta['js path'] . '/' . $meta['js file']);
467
-          // Add plugin-specific settings.
468
-          if (isset($meta['settings'])) {
464
+            $profile_plugins_drupal[$plugin] = $processed_plugins[$proxy][$plugin] = $meta;
465
+            // Load the Drupal plugin's JavaScript.
466
+            drupal_add_js($meta['js path'] . '/' . $meta['js file']);
467
+            // Add plugin-specific settings.
468
+            if (isset($meta['settings'])) {
469 469
             drupal_add_js(array('wysiwyg' => array('plugins' => array('drupal' => array($plugin => $meta['settings'])))), 'setting');
470
-          }
470
+            }
471 471
         }
472 472
         else {
473
-          $profile_plugins_drupal[$plugin] = $processed_plugins[$proxy][$plugin];
473
+            $profile_plugins_drupal[$plugin] = $processed_plugins[$proxy][$plugin];
474
+        }
474 475
         }
475
-      }
476 476
     }
477 477
     // Invoke the editor's proxy plugin settings callback, so it can populate
478 478
     // the settings for Drupal plugins with custom, required values.
479 479
     $settings_drupal = call_user_func($editor['proxy plugin settings callback'], $editor, $profile, $profile_plugins_drupal);
480 480
 
481 481
     if ($settings_drupal) {
482
-      drupal_add_js(array('wysiwyg' => array('plugins' => array('format' . $profile->format => array('drupal' => $settings_drupal)))), 'setting');
482
+        drupal_add_js(array('wysiwyg' => array('plugins' => array('format' . $profile->format => array('drupal' => $settings_drupal)))), 'setting');
483
+    }
483 484
     }
484
-  }
485 485
 }
486 486
 
487 487
 /**
@@ -499,28 +499,28 @@  discard block
 block discarded – undo
499 499
  *   was given.
500 500
  */
501 501
 function wysiwyg_get_editor_themes(&$profile, $selected_theme = NULL) {
502
-  static $themes = array();
502
+    static $themes = array();
503 503
 
504
-  if (!isset($themes[$profile->editor])) {
504
+    if (!isset($themes[$profile->editor])) {
505 505
     $editor = wysiwyg_get_editor($profile->editor);
506 506
     if (isset($editor['themes callback']) && function_exists($editor['themes callback'])) {
507
-      $themes[$editor['name']] = $editor['themes callback']($editor, $profile);
507
+        $themes[$editor['name']] = $editor['themes callback']($editor, $profile);
508 508
     }
509 509
     // Fallback to 'default' otherwise.
510 510
     else {
511
-      $themes[$editor['name']] = array('default');
511
+        $themes[$editor['name']] = array('default');
512
+    }
512 513
     }
513
-  }
514 514
 
515
-  // Check optional $selected_theme argument, if given.
516
-  if (isset($selected_theme)) {
515
+    // Check optional $selected_theme argument, if given.
516
+    if (isset($selected_theme)) {
517 517
     // If the passed theme name does not exist, use the first available.
518 518
     if (!in_array($selected_theme, $themes[$profile->editor])) {
519
-      $selected_theme = $profile->settings['theme'] = $themes[$profile->editor][0];
519
+        $selected_theme = $profile->settings['theme'] = $themes[$profile->editor][0];
520
+    }
520 521
     }
521
-  }
522 522
 
523
-  return isset($selected_theme) ? $selected_theme : $themes[$profile->editor];
523
+    return isset($selected_theme) ? $selected_theme : $themes[$profile->editor];
524 524
 }
525 525
 
526 526
 /**
@@ -533,42 +533,42 @@  discard block
 block discarded – undo
533 533
  *   An array for each plugin.
534 534
  */
535 535
 function wysiwyg_get_plugins($editor_name) {
536
-  $plugins = array();
537
-  if (!empty($editor_name)) {
536
+    $plugins = array();
537
+    if (!empty($editor_name)) {
538 538
     $editor = wysiwyg_get_editor($editor_name);
539 539
     // Add internal editor plugins.
540 540
     if (isset($editor['plugin callback']) && function_exists($editor['plugin callback'])) {
541
-      $plugins = $editor['plugin callback']($editor);
541
+        $plugins = $editor['plugin callback']($editor);
542 542
     }
543 543
     // Add editor plugins provided via hook_wysiwyg_plugin().
544 544
     $plugins = array_merge($plugins, module_invoke_all('wysiwyg_plugin', $editor['name'], $editor['installed version']));
545 545
     // Add API plugins provided by Drupal modules.
546 546
     // @todo We need to pass the filepath to the plugin icon for Drupal plugins.
547 547
     if (isset($editor['proxy plugin'])) {
548
-      $plugins += $editor['proxy plugin'];
549
-      $proxy = key($editor['proxy plugin']);
550
-      foreach (wysiwyg_get_all_plugins() as $plugin_name => $info) {
548
+        $plugins += $editor['proxy plugin'];
549
+        $proxy = key($editor['proxy plugin']);
550
+        foreach (wysiwyg_get_all_plugins() as $plugin_name => $info) {
551 551
         $plugins[$proxy]['buttons'][$plugin_name] = $info['title'];
552
-      }
552
+        }
553
+    }
553 554
     }
554
-  }
555
-  return $plugins;
555
+    return $plugins;
556 556
 }
557 557
 
558 558
 /**
559 559
  * Return an array of initial editor settings for a Wysiwyg profile.
560 560
  */
561 561
 function wysiwyg_get_editor_config($profile, $theme) {
562
-  $editor = wysiwyg_get_editor($profile->editor);
563
-  $settings = array();
564
-  if (!empty($editor['settings callback']) && function_exists($editor['settings callback'])) {
562
+    $editor = wysiwyg_get_editor($profile->editor);
563
+    $settings = array();
564
+    if (!empty($editor['settings callback']) && function_exists($editor['settings callback'])) {
565 565
     $settings = $editor['settings callback']($editor, $profile->settings, $theme);
566 566
 
567 567
     // Allow other modules to alter the editor settings for this format.
568 568
     $context = array('editor' => $editor, 'profile' => $profile, 'theme' => $theme);
569 569
     drupal_alter('wysiwyg_editor_settings', $settings, $context);
570
-  }
571
-  return $settings;
570
+    }
571
+    return $settings;
572 572
 }
573 573
 
574 574
 /**
@@ -581,106 +581,106 @@  discard block
 block discarded – undo
581 581
  *   An array containing CSS files, including proper base path.
582 582
  */
583 583
 function wysiwyg_get_css() {
584
-  static $files;
584
+    static $files;
585 585
 
586
-  if (isset($files)) {
586
+    if (isset($files)) {
587 587
     return $files;
588
-  }
589
-  // In node form previews, the theme has not been initialized yet.
590
-  if (!empty($_POST)) {
588
+    }
589
+    // In node form previews, the theme has not been initialized yet.
590
+    if (!empty($_POST)) {
591 591
     init_theme();
592
-  }
592
+    }
593 593
 
594
-  $files = array();
595
-  foreach (drupal_add_css() as $media => $css) {
594
+    $files = array();
595
+    foreach (drupal_add_css() as $media => $css) {
596 596
     if ($media != 'print') {
597
-      foreach ($css['theme'] as $filepath => $preprocess) {
597
+        foreach ($css['theme'] as $filepath => $preprocess) {
598 598
         if (file_exists($filepath)) {
599
-          $files[] = base_path() . $filepath;
599
+            $files[] = base_path() . $filepath;
600
+        }
600 601
         }
601
-      }
602 602
     }
603
-  }
604
-  return $files;
603
+    }
604
+    return $files;
605 605
 }
606 606
 
607 607
 /**
608 608
  * Load profile for a given input format.
609 609
  */
610 610
 function wysiwyg_profile_load($format) {
611
-  static $profiles;
611
+    static $profiles;
612 612
 
613
-  if (!isset($profiles) || !array_key_exists($format, $profiles)) {
613
+    if (!isset($profiles) || !array_key_exists($format, $profiles)) {
614 614
     $profiles = wysiwyg_profile_load_all();
615
-  }
615
+    }
616 616
 
617
-  return (isset($profiles[$format]) ? $profiles[$format] : FALSE);
617
+    return (isset($profiles[$format]) ? $profiles[$format] : FALSE);
618 618
 }
619 619
 
620 620
 /**
621 621
  * Load all profiles.
622 622
  */
623 623
 function wysiwyg_profile_load_all($reset = FALSE) {
624
-  static $profiles;
624
+    static $profiles;
625 625
 
626
-  if ($reset || !isset($profiles)) {
626
+    if ($reset || !isset($profiles)) {
627 627
     $profiles = array();
628 628
     if (!$reset && ($cache = cache_get('wysiwyg:profiles', 'cache')) && is_array($cache->data)) {
629
-      $profiles = $cache->data;
630
-      return $profiles;
629
+        $profiles = $cache->data;
630
+        return $profiles;
631 631
     }
632 632
     // If Exportables and CTools are installed, use their API to load both
633 633
     // wysiwyg profiles from code and from the database
634 634
     if (module_exists('ctools') && module_exists('exportables')) {
635
-      if (exportables_api_version('2.0') && ctools_api_version('1.7')) {
635
+        if (exportables_api_version('2.0') && ctools_api_version('1.7')) {
636 636
         $input_formats = exportables_load_all('input_formats');
637 637
         ctools_include('export');
638 638
         $ctools_profiles = ctools_export_load_object('wysiwyg');
639 639
         // Wysiwyg module still use numeric ids as keys
640 640
         foreach ($ctools_profiles as $machine_name => $profile) {
641
-          $profile->format = $input_formats[$machine_name];
642
-          $profiles[$profile->format] = $profile;
641
+            $profile->format = $input_formats[$machine_name];
642
+            $profiles[$profile->format] = $profile;
643
+        }
643 644
         }
644
-      }
645 645
     }
646 646
 
647 647
     // DB profiles will always override Features profiles from flat files.
648 648
     $result = db_query('SELECT format, editor, settings FROM {wysiwyg}');
649 649
     while ($profile = db_fetch_object($result)) {
650
-      if (!isset($profiles[$profile->format])) {
650
+        if (!isset($profiles[$profile->format])) {
651 651
         $profile->settings = unserialize($profile->settings);
652 652
         $profiles[$profile->format] = $profile;
653
-      }
653
+        }
654 654
     }
655 655
 
656 656
     drupal_alter('wysiwyg_load_profiles', $profiles);
657 657
     cache_set('wysiwyg:profiles', $profiles);
658
-  }
658
+    }
659 659
 
660
-  return $profiles;
660
+    return $profiles;
661 661
 }
662
- /**
663
- * Wysiwyg profiles list callback.
664
- */
662
+    /**
663
+     * Wysiwyg profiles list callback.
664
+     */
665 665
 function wysiwyg_profile_list() {
666
-  $profiles = wysiwyg_profile_load_all(TRUE);
667
-  $filter_formats = filter_formats();
668
-  $list = array();
669
-  foreach ($profiles as $profile) {
666
+    $profiles = wysiwyg_profile_load_all(TRUE);
667
+    $filter_formats = filter_formats();
668
+    $list = array();
669
+    foreach ($profiles as $profile) {
670 670
     $list[$profile->machine] = t('@format (@editor)', array('@editor' => $profile->editor, '@format' => $filter_formats[$profile->format]->name));
671
-  }
672
-  return $list;
671
+    }
672
+    return $list;
673 673
 }
674 674
 
675 675
 /**
676 676
  * Remove a profile from the database.
677 677
  */
678 678
 function wysiwyg_profile_delete($wysiwyg) {
679
-  if (!isset($wysiwyg->format)) {
679
+    if (!isset($wysiwyg->format)) {
680 680
     $input_formats = exportables_load_all('input_formats');
681 681
     $wysiwyg->format = $input_formats[$wysiwyg->machine];
682
-  }
683
-  db_query("DELETE FROM {wysiwyg} WHERE format = %d", $wysiwyg->format);
682
+    }
683
+    db_query("DELETE FROM {wysiwyg} WHERE format = %d", $wysiwyg->format);
684 684
 }
685 685
 
686 686
 
@@ -689,68 +689,68 @@  discard block
 block discarded – undo
689 689
  * Implementation of hook_user().
690 690
  */
691 691
 function wysiwyg_user($op, &$edit, $account, $category = NULL) {
692
-  if ($op == 'form' && $category == 'account') {
692
+    if ($op == 'form' && $category == 'account') {
693 693
     $user_formats = filter_formats();
694 694
     $options = array();
695 695
     $options_default = array();
696 696
     foreach (wysiwyg_profile_load_all() as $format => $profile) {
697
-      // Only show profiles that have user_choose enabled.
698
-      if (!empty($profile->settings['user_choose']) && isset($user_formats[$format])) {
697
+        // Only show profiles that have user_choose enabled.
698
+        if (!empty($profile->settings['user_choose']) && isset($user_formats[$format])) {
699 699
         $options[$format] = check_plain($user_formats[$format]->name);
700 700
         if (wysiwyg_user_get_status($profile, $account)) {
701
-          $options_default[] = $format;
701
+            $options_default[] = $format;
702
+        }
702 703
         }
703
-      }
704 704
     }
705 705
     if (!empty($options)) {
706
-      $form['wysiwyg']['wysiwyg_status'] = array(
706
+        $form['wysiwyg']['wysiwyg_status'] = array(
707 707
         '#type' => 'checkboxes',
708 708
         '#title' => t('Text formats enabled for rich-text editing'),
709 709
         '#options' => $options,
710 710
         '#default_value' => $options_default,
711
-      );
712
-      return $form;
711
+        );
712
+        return $form;
713 713
     }
714
-  }
715
-  elseif ($op == 'insert' || $op == 'update') {
714
+    }
715
+    elseif ($op == 'insert' || $op == 'update') {
716 716
     if (isset($edit['wysiwyg_status'])) {
717
-      db_query("DELETE FROM {wysiwyg_user} WHERE uid = %d", $account->uid);
718
-      foreach ($edit['wysiwyg_status'] as $format => $status) {
717
+        db_query("DELETE FROM {wysiwyg_user} WHERE uid = %d", $account->uid);
718
+        foreach ($edit['wysiwyg_status'] as $format => $status) {
719 719
         db_query("INSERT INTO {wysiwyg_user} (uid, format, status) VALUES (%d, %d, %d)", array(
720
-          $account->uid,
721
-          $format,
722
-          (int) (bool) $status,
720
+            $account->uid,
721
+            $format,
722
+            (int) (bool) $status,
723 723
         ));
724
-      }
724
+        }
725
+    }
725 726
     }
726
-  }
727 727
 }
728 728
 
729 729
 function wysiwyg_user_get_status($profile, $account = NULL) {
730
-  global $user;
730
+    global $user;
731 731
 
732
-  if (!isset($account)) {
732
+    if (!isset($account)) {
733 733
     $account = $user;
734
-  }
734
+    }
735 735
 
736
-  // Default wysiwyg editor status information is only required on forms, so we
737
-  // do not pre-emptively load and attach this information on every user_load().
738
-  if (!isset($account->wysiwyg_status)) {
736
+    // Default wysiwyg editor status information is only required on forms, so we
737
+    // do not pre-emptively load and attach this information on every user_load().
738
+    if (!isset($account->wysiwyg_status)) {
739 739
     $account->wysiwyg_status = array();
740 740
     $result = db_query("SELECT format, status FROM {wysiwyg_user} WHERE uid = %d", $account->uid);
741 741
     while ($row = db_fetch_object($result)) {
742
-      $account->wysiwyg_status[$row->format] = $row->status;
742
+        $account->wysiwyg_status[$row->format] = $row->status;
743
+    }
743 744
     }
744
-  }
745 745
 
746
-  if (!empty($profile->settings['user_choose']) && isset($account->wysiwyg_status[$profile->format])) {
746
+    if (!empty($profile->settings['user_choose']) && isset($account->wysiwyg_status[$profile->format])) {
747 747
     $status = $account->wysiwyg_status[$profile->format];
748
-  }
749
-  else {
748
+    }
749
+    else {
750 750
     $status = isset($profile->settings['default']) ? $profile->settings['default'] : TRUE;
751
-  }
751
+    }
752 752
 
753
-  return (bool) $status;
753
+    return (bool) $status;
754 754
 }
755 755
 
756 756
 /**
@@ -772,110 +772,110 @@  discard block
 block discarded – undo
772 772
  *   installed properly.
773 773
  */
774 774
 function wysiwyg_get_editor($name) {
775
-  $editors = wysiwyg_get_all_editors();
776
-  return isset($editors[$name]) && $editors[$name]['installed'] ? $editors[$name] : FALSE;
775
+    $editors = wysiwyg_get_all_editors();
776
+    return isset($editors[$name]) && $editors[$name]['installed'] ? $editors[$name] : FALSE;
777 777
 }
778 778
 
779 779
 /**
780 780
  * Compile a list holding all supported editors including installed editor version information.
781 781
  */
782 782
 function wysiwyg_get_all_editors() {
783
-  static $editors;
783
+    static $editors;
784 784
 
785
-  if (isset($editors)) {
785
+    if (isset($editors)) {
786 786
     return $editors;
787
-  }
787
+    }
788 788
 
789
-  $editors = wysiwyg_load_includes('editors', 'editor');
790
-  foreach ($editors as $editor => $properties) {
789
+    $editors = wysiwyg_load_includes('editors', 'editor');
790
+    foreach ($editors as $editor => $properties) {
791 791
     // Fill in required properties.
792 792
     $editors[$editor] += array(
793
-      'title' => '',
794
-      'vendor url' => '',
795
-      'download url' => '',
796
-      'editor path' => wysiwyg_get_path($editors[$editor]['name']),
797
-      'library path' => wysiwyg_get_path($editors[$editor]['name']),
798
-      'libraries' => array(),
799
-      'version callback' => NULL,
800
-      'themes callback' => NULL,
801
-      'settings callback' => NULL,
802
-      'plugin callback' => NULL,
803
-      'plugin settings callback' => NULL,
804
-      'versions' => array(),
805
-      'js path' => $editors[$editor]['path'] . '/js',
806
-      'css path' => $editors[$editor]['path'] . '/css',
793
+        'title' => '',
794
+        'vendor url' => '',
795
+        'download url' => '',
796
+        'editor path' => wysiwyg_get_path($editors[$editor]['name']),
797
+        'library path' => wysiwyg_get_path($editors[$editor]['name']),
798
+        'libraries' => array(),
799
+        'version callback' => NULL,
800
+        'themes callback' => NULL,
801
+        'settings callback' => NULL,
802
+        'plugin callback' => NULL,
803
+        'plugin settings callback' => NULL,
804
+        'versions' => array(),
805
+        'js path' => $editors[$editor]['path'] . '/js',
806
+        'css path' => $editors[$editor]['path'] . '/css',
807 807
     );
808 808
     // Check whether library is present.
809 809
     if (!($editors[$editor]['installed'] = file_exists($editors[$editor]['library path']))) {
810
-      continue;
810
+        continue;
811 811
     }
812 812
     // Detect library version.
813 813
     if (function_exists($editors[$editor]['version callback'])) {
814
-      $editors[$editor]['installed version'] = $editors[$editor]['version callback']($editors[$editor]);
814
+        $editors[$editor]['installed version'] = $editors[$editor]['version callback']($editors[$editor]);
815 815
     }
816 816
     if (empty($editors[$editor]['installed version'])) {
817
-      $editors[$editor]['error'] = t('The version of %editor could not be detected.', array('%editor' => $properties['title']));
818
-      $editors[$editor]['installed'] = FALSE;
819
-      continue;
817
+        $editors[$editor]['error'] = t('The version of %editor could not be detected.', array('%editor' => $properties['title']));
818
+        $editors[$editor]['installed'] = FALSE;
819
+        continue;
820 820
     }
821 821
     // Determine to which supported version the installed version maps.
822 822
     ksort($editors[$editor]['versions']);
823 823
     $version = 0;
824 824
     foreach ($editors[$editor]['versions'] as $supported_version => $version_properties) {
825
-      if (version_compare($editors[$editor]['installed version'], $supported_version, '>=')) {
825
+        if (version_compare($editors[$editor]['installed version'], $supported_version, '>=')) {
826 826
         $version = $supported_version;
827
-      }
827
+        }
828 828
     }
829 829
     if (!$version) {
830
-      $editors[$editor]['error'] = t('The installed version %version of %editor is not supported.', array('%version' => $editors[$editor]['installed version'], '%editor' => $editors[$editor]['title']));
831
-      $editors[$editor]['installed'] = FALSE;
832
-      continue;
830
+        $editors[$editor]['error'] = t('The installed version %version of %editor is not supported.', array('%version' => $editors[$editor]['installed version'], '%editor' => $editors[$editor]['title']));
831
+        $editors[$editor]['installed'] = FALSE;
832
+        continue;
833 833
     }
834 834
     // Apply library version specific definitions and overrides.
835 835
     $editors[$editor] = array_merge($editors[$editor], $editors[$editor]['versions'][$version]);
836 836
     unset($editors[$editor]['versions']);
837
-  }
838
-  return $editors;
837
+    }
838
+    return $editors;
839 839
 }
840 840
 
841 841
 /**
842 842
  * Invoke hook_wysiwyg_plugin() in all modules.
843 843
  */
844 844
 function wysiwyg_get_all_plugins() {
845
-  static $plugins;
845
+    static $plugins;
846 846
 
847
-  if (isset($plugins)) {
847
+    if (isset($plugins)) {
848 848
     return $plugins;
849
-  }
849
+    }
850 850
 
851
-  $plugins = wysiwyg_load_includes('plugins', 'plugin');
852
-  foreach ($plugins as $name => $properties) {
851
+    $plugins = wysiwyg_load_includes('plugins', 'plugin');
852
+    foreach ($plugins as $name => $properties) {
853 853
     $plugin = &$plugins[$name];
854 854
     // Fill in required/default properties.
855 855
     $plugin += array(
856
-      'title' => $plugin['name'],
857
-      'vendor url' => '',
858
-      'js path' => $plugin['path'] . '/' . $plugin['name'],
859
-      'js file' => $plugin['name'] . '.js',
860
-      'css path' => $plugin['path'] . '/' . $plugin['name'],
861
-      'css file' => $plugin['name'] . '.css',
862
-      'icon path' => $plugin['path'] . '/' . $plugin['name'] . '/images',
863
-      'icon file' => $plugin['name'] . '.png',
864
-      'dialog path' => $plugin['name'],
865
-      'dialog settings' => array(),
866
-      'settings callback' => NULL,
867
-      'settings form callback' => NULL,
856
+        'title' => $plugin['name'],
857
+        'vendor url' => '',
858
+        'js path' => $plugin['path'] . '/' . $plugin['name'],
859
+        'js file' => $plugin['name'] . '.js',
860
+        'css path' => $plugin['path'] . '/' . $plugin['name'],
861
+        'css file' => $plugin['name'] . '.css',
862
+        'icon path' => $plugin['path'] . '/' . $plugin['name'] . '/images',
863
+        'icon file' => $plugin['name'] . '.png',
864
+        'dialog path' => $plugin['name'],
865
+        'dialog settings' => array(),
866
+        'settings callback' => NULL,
867
+        'settings form callback' => NULL,
868 868
     );
869 869
     // Fill in default settings.
870 870
     $plugin['settings'] += array(
871
-      'path' => base_path() . $plugin['path'] . '/' . $plugin['name'],
871
+        'path' => base_path() . $plugin['path'] . '/' . $plugin['name'],
872 872
     );
873 873
     // Check whether library is present.
874 874
     if (!($plugin['installed'] = file_exists($plugin['js path'] . '/' . $plugin['js file']))) {
875
-      continue;
875
+        continue;
876
+    }
876 877
     }
877
-  }
878
-  return $plugins;
878
+    return $plugins;
879 879
 }
880 880
 
881 881
 /**
@@ -891,26 +891,26 @@  discard block
 block discarded – undo
891 891
  * @see wysiwyg_get_directories(), _wysiwyg_process_include()
892 892
  */
893 893
 function wysiwyg_load_includes($type = 'editors', $hook = 'editor', $file = NULL) {
894
-  // Determine implementations.
895
-  $directories = wysiwyg_get_directories($type);
896
-  $directories['wysiwyg'] = drupal_get_path('module', 'wysiwyg') . '/' . $type;
897
-  $file_list = array();
898
-  foreach ($directories as $module => $path) {
894
+    // Determine implementations.
895
+    $directories = wysiwyg_get_directories($type);
896
+    $directories['wysiwyg'] = drupal_get_path('module', 'wysiwyg') . '/' . $type;
897
+    $file_list = array();
898
+    foreach ($directories as $module => $path) {
899 899
     $file_list[$module] = drupal_system_listing("$file" . '.inc$', $path, 'name', 0);
900
-  }
900
+    }
901 901
 
902
-  // Load implementations.
903
-  $info = array();
904
-  foreach (array_filter($file_list) as $module => $files) {
902
+    // Load implementations.
903
+    $info = array();
904
+    foreach (array_filter($file_list) as $module => $files) {
905 905
     foreach ($files as $file) {
906
-      include_once './' . $file->filename;
907
-      $result = _wysiwyg_process_include($module, $module . '_' . $file->name, dirname($file->filename), $hook);
908
-      if (is_array($result)) {
906
+        include_once './' . $file->filename;
907
+        $result = _wysiwyg_process_include($module, $module . '_' . $file->name, dirname($file->filename), $hook);
908
+        if (is_array($result)) {
909 909
         $info = array_merge($info, $result);
910
-      }
910
+        }
911 911
     }
912
-  }
913
-  return $info;
912
+    }
913
+    return $info;
914 914
 }
915 915
 
916 916
 /**
@@ -927,20 +927,20 @@  discard block
 block discarded – undo
927 927
  * @ingroup libraries
928 928
  */
929 929
 function wysiwyg_get_path($library, $base_path = FALSE) {
930
-  static $libraries;
930
+    static $libraries;
931 931
 
932
-  if (!isset($libraries)) {
932
+    if (!isset($libraries)) {
933 933
     $libraries = wysiwyg_get_libraries();
934
-  }
935
-  if (!isset($libraries[$library])) {
934
+    }
935
+    if (!isset($libraries[$library])) {
936 936
     // Most often, external libraries can be shared across multiple sites.
937 937
     return 'sites/all/libraries/' . $library;
938
-  }
938
+    }
939 939
 
940
-  $path = ($base_path ? base_path() : '');
941
-  $path .= $libraries[$library];
940
+    $path = ($base_path ? base_path() : '');
941
+    $path .= $libraries[$library];
942 942
 
943
-  return $path;
943
+    return $path;
944 944
 }
945 945
 
946 946
 /**
@@ -960,55 +960,55 @@  discard block
 block discarded – undo
960 960
  * @ingroup libraries
961 961
  */
962 962
 function wysiwyg_get_libraries() {
963
-  global $profile;
964
-
965
-  // When this function is called during Drupal's initial installation process,
966
-  // the name of the profile that is about to be installed is stored in the
967
-  // global $profile variable. At all other times, the regular system variable
968
-  // contains the name of the current profile, and we can call variable_get()
969
-  // to determine the profile.
970
-  if (!isset($profile)) {
963
+    global $profile;
964
+
965
+    // When this function is called during Drupal's initial installation process,
966
+    // the name of the profile that is about to be installed is stored in the
967
+    // global $profile variable. At all other times, the regular system variable
968
+    // contains the name of the current profile, and we can call variable_get()
969
+    // to determine the profile.
970
+    if (!isset($profile)) {
971 971
     $profile = variable_get('install_profile', 'default');
972
-  }
972
+    }
973 973
 
974
-  $directory = 'libraries';
975
-  $searchdir = array();
976
-  $config = conf_path();
974
+    $directory = 'libraries';
975
+    $searchdir = array();
976
+    $config = conf_path();
977 977
 
978
-  // The 'profiles' directory contains pristine collections of modules and
979
-  // themes as organized by a distribution.  It is pristine in the same way
980
-  // that /modules is pristine for core; users should avoid changing anything
981
-  // there in favor of sites/all or sites/<domain> directories.
982
-  if (file_exists("profiles/$profile/$directory")) {
978
+    // The 'profiles' directory contains pristine collections of modules and
979
+    // themes as organized by a distribution.  It is pristine in the same way
980
+    // that /modules is pristine for core; users should avoid changing anything
981
+    // there in favor of sites/all or sites/<domain> directories.
982
+    if (file_exists("profiles/$profile/$directory")) {
983 983
     $searchdir[] = "profiles/$profile/$directory";
984
-  }
984
+    }
985 985
 
986
-  // Always search sites/all/*.
987
-  $searchdir[] = 'sites/all/' . $directory;
986
+    // Always search sites/all/*.
987
+    $searchdir[] = 'sites/all/' . $directory;
988 988
 
989
-  // Also search sites/<domain>/*.
990
-  if (file_exists("$config/$directory")) {
989
+    // Also search sites/<domain>/*.
990
+    if (file_exists("$config/$directory")) {
991 991
     $searchdir[] = "$config/$directory";
992
-  }
992
+    }
993 993
 
994
-  // Retrieve list of directories.
995
-  // @todo Core: Allow to scan for directories.
996
-  $directories = array();
997
-  $nomask = array('CVS');
998
-  foreach ($searchdir as $dir) {
994
+    // Retrieve list of directories.
995
+    // @todo Core: Allow to scan for directories.
996
+    $directories = array();
997
+    $nomask = array('CVS');
998
+    foreach ($searchdir as $dir) {
999 999
     if (is_dir($dir) && $handle = opendir($dir)) {
1000
-      while (FALSE !== ($file = readdir($handle))) {
1000
+        while (FALSE !== ($file = readdir($handle))) {
1001 1001
         if (!in_array($file, $nomask) && $file[0] != '.') {
1002
-          if (is_dir("$dir/$file")) {
1002
+            if (is_dir("$dir/$file")) {
1003 1003
             $directories[$file] = "$dir/$file";
1004
-          }
1004
+            }
1005
+        }
1005 1006
         }
1006
-      }
1007
-      closedir($handle);
1007
+        closedir($handle);
1008
+    }
1008 1009
     }
1009
-  }
1010 1010
 
1011
-  return $directories;
1011
+    return $directories;
1012 1012
 }
1013 1013
 
1014 1014
 /**
@@ -1024,14 +1024,14 @@  discard block
 block discarded – undo
1024 1024
  * @see wysiwyg_load_includes(), _wysiwyg_process_include()
1025 1025
  */
1026 1026
 function wysiwyg_get_directories($plugintype) {
1027
-  $directories = array();
1028
-  foreach (module_implements('wysiwyg_include_directory') as $module) {
1027
+    $directories = array();
1028
+    foreach (module_implements('wysiwyg_include_directory') as $module) {
1029 1029
     $result = module_invoke($module, 'wysiwyg_include_directory', $plugintype);
1030 1030
     if (isset($result) && is_string($result)) {
1031
-      $directories[$module] = drupal_get_path('module', $module) . '/' . $result;
1031
+        $directories[$module] = drupal_get_path('module', $module) . '/' . $result;
1032 1032
     }
1033
-  }
1034
-  return $directories;
1033
+    }
1034
+    return $directories;
1035 1035
 }
1036 1036
 
1037 1037
 /**
@@ -1045,22 +1045,22 @@  discard block
 block discarded – undo
1045 1045
  *   The name of the hook being invoked.
1046 1046
  */
1047 1047
 function _wysiwyg_process_include($module, $identifier, $path, $hook) {
1048
-  $function = $identifier . '_' . $hook;
1049
-  if (!function_exists($function)) {
1048
+    $function = $identifier . '_' . $hook;
1049
+    if (!function_exists($function)) {
1050 1050
     return NULL;
1051
-  }
1052
-  $result = $function();
1053
-  if (!isset($result) || !is_array($result)) {
1051
+    }
1052
+    $result = $function();
1053
+    if (!isset($result) || !is_array($result)) {
1054 1054
     return NULL;
1055
-  }
1055
+    }
1056 1056
 
1057
-  // Fill in defaults.
1058
-  foreach ($result as $editor => $properties) {
1057
+    // Fill in defaults.
1058
+    foreach ($result as $editor => $properties) {
1059 1059
     $result[$editor]['module'] = $module;
1060 1060
     $result[$editor]['name'] = $editor;
1061 1061
     $result[$editor]['path'] = $path;
1062
-  }
1063
-  return $result;
1062
+    }
1063
+    return $result;
1064 1064
 }
1065 1065
 
1066 1066
 /**
@@ -1079,12 +1079,12 @@  discard block
 block discarded – undo
1079 1079
  * installed.
1080 1080
  */
1081 1081
 function wysiwyg_features_api() {
1082
-  $return = array();
1083
-  if (module_exists('exportables') && module_exists('ctools')) {
1082
+    $return = array();
1083
+    if (module_exists('exportables') && module_exists('ctools')) {
1084 1084
     module_load_include('inc', 'features', 'includes/features.ctools');
1085 1085
     $return = ctools_component_features_api('wysiwyg');
1086
-  }
1087
-  return $return;
1086
+    }
1087
+    return $return;
1088 1088
 }
1089 1089
 
1090 1090
 /**
@@ -1094,10 +1094,10 @@  discard block
 block discarded – undo
1094 1094
  */
1095 1095
 function wysiwyg_features_export($data, &$export, $module_name = '') {
1096 1096
 
1097
-  $return = ctools_component_features_export('wysiwyg', $data, $export, $module_name);
1098
-  $export['dependencies']['exportables'] = 'exportables';
1097
+    $return = ctools_component_features_export('wysiwyg', $data, $export, $module_name);
1098
+    $export['dependencies']['exportables'] = 'exportables';
1099 1099
 
1100
-  return $return;
1100
+    return $return;
1101 1101
 }
1102 1102
 
1103 1103
 /**
Please login to merge, or discard this patch.
Switch Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -79,9 +79,9 @@
 block discarded – undo
79 79
  */
80 80
 function wysiwyg_help($path, $arg) {
81 81
   switch ($path) {
82
-    case 'admin/settings/wysiwyg':
83
-      $output = '<p>' . t('A Wysiwyg profile is associated with an input format. A Wysiwyg profile defines which client-side editor is loaded with a particular input format, what buttons or themes are enabled for the editor, how the editor is displayed, and a few other editor-specific functions.') . '</p>';
84
-      return $output;
82
+  case 'admin/settings/wysiwyg':
83
+    $output = '<p>' . t('A Wysiwyg profile is associated with an input format. A Wysiwyg profile defines which client-side editor is loaded with a particular input format, what buttons or themes are enabled for the editor, how the editor is displayed, and a few other editor-specific functions.') . '</p>';
84
+    return $output;
85 85
   }
86 86
 }
87 87
 
Please login to merge, or discard this patch.
Spacing   +39 added lines, -39 removed lines patch added patch discarded remove patch
@@ -80,7 +80,7 @@  discard block
 block discarded – undo
80 80
 function wysiwyg_help($path, $arg) {
81 81
   switch ($path) {
82 82
     case 'admin/settings/wysiwyg':
83
-      $output = '<p>' . t('A Wysiwyg profile is associated with an input format. A Wysiwyg profile defines which client-side editor is loaded with a particular input format, what buttons or themes are enabled for the editor, how the editor is displayed, and a few other editor-specific functions.') . '</p>';
83
+      $output = '<p>'.t('A Wysiwyg profile is associated with an input format. A Wysiwyg profile defines which client-side editor is loaded with a particular input format, what buttons or themes are enabled for the editor, how the editor is displayed, and a few other editor-specific functions.').'</p>';
84 84
       return $output;
85 85
   }
86 86
 }
@@ -179,9 +179,9 @@  discard block
 block discarded – undo
179 179
             if ($profile) {
180 180
               $loaded = TRUE;
181 181
               $editor = $profile->editor;
182
-              $status = (int) wysiwyg_user_get_status($profile);
182
+              $status = (int)wysiwyg_user_get_status($profile);
183 183
               if (isset($profile->settings['show_toggle'])) {
184
-                $toggle = (int) $profile->settings['show_toggle'];
184
+                $toggle = (int)$profile->settings['show_toggle'];
185 185
               }
186 186
               // Check editor theme (and reset it if not/no longer available).
187 187
               $theme = wysiwyg_get_editor_themes($profile, (isset($profile->settings['theme']) ? $profile->settings['theme'] : ''));
@@ -195,7 +195,7 @@  discard block
 block discarded – undo
195 195
             // Use a prefix/suffix for a single input format, or attach to input
196 196
             // format selector radio buttons.
197 197
             if (isset($element['format']['guidelines'])) {
198
-              $element['format']['guidelines']['#prefix'] = '<div class="wysiwyg wysiwyg-format-' . $format . ' wysiwyg-editor-' . $editor . ' wysiwyg-field-' . $field['#id'] . ' wysiwyg-status-' . $status . ' wysiwyg-toggle-' . $toggle . $extra_class . '">';
198
+              $element['format']['guidelines']['#prefix'] = '<div class="wysiwyg wysiwyg-format-'.$format.' wysiwyg-editor-'.$editor.' wysiwyg-field-'.$field['#id'].' wysiwyg-status-'.$status.' wysiwyg-toggle-'.$toggle.$extra_class.'">';
199 199
               $element['format']['guidelines']['#suffix'] = '</div>';
200 200
               // Edge-case: Default format contains no input filters.
201 201
               if (empty($element['format']['guidelines']['#value'])) {
@@ -203,8 +203,8 @@  discard block
 block discarded – undo
203 203
               }
204 204
             }
205 205
             else {
206
-              $element[$format]['#attributes']['class'] = (isset($element[$format]['#attributes']['class']) ? $element[$format]['#attributes']['class'] . ' ' : '');
207
-              $element[$format]['#attributes']['class'] .= 'wysiwyg wysiwyg-format-' . $format . ' wysiwyg-editor-' . $editor . ' wysiwyg-field-' . $field['#id'] . ' wysiwyg-status-' . $status . ' wysiwyg-toggle-' . $toggle . $extra_class;
206
+              $element[$format]['#attributes']['class'] = (isset($element[$format]['#attributes']['class']) ? $element[$format]['#attributes']['class'].' ' : '');
207
+              $element[$format]['#attributes']['class'] .= 'wysiwyg wysiwyg-format-'.$format.' wysiwyg-editor-'.$editor.' wysiwyg-field-'.$field['#id'].' wysiwyg-status-'.$status.' wysiwyg-toggle-'.$toggle.$extra_class;
208 208
             }
209 209
           }
210 210
 
@@ -283,10 +283,10 @@  discard block
 block discarded – undo
283 283
       foreach ($files as $file => $options) {
284 284
         if (is_array($options)) {
285 285
           $options += array('type' => 'module', 'scope' => 'header', 'defer' => FALSE, 'cache' => TRUE, 'preprocess' => TRUE);
286
-          drupal_add_js($editor['library path'] . '/' . $file, $options['type'], $options['scope'], $options['defer'], $options['cache'], $options['preprocess']);
286
+          drupal_add_js($editor['library path'].'/'.$file, $options['type'], $options['scope'], $options['defer'], $options['cache'], $options['preprocess']);
287 287
         }
288 288
         else {
289
-          drupal_add_js($editor['library path'] . '/' . $options);
289
+          drupal_add_js($editor['library path'].'/'.$options);
290 290
         }
291 291
       }
292 292
       // If editor defines an additional load callback, invoke it.
@@ -300,7 +300,7 @@  discard block
 block discarded – undo
300 300
         $files = $editor['js files'];
301 301
       }
302 302
       foreach ($files as $file) {
303
-        drupal_add_js($editor['js path'] . '/' . $file);
303
+        drupal_add_js($editor['js path'].'/'.$file);
304 304
       }
305 305
       // Load CSS stylesheets for this editor.
306 306
       $files = array();
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
         $files = $editor['css files'];
309 309
       }
310 310
       foreach ($files as $file) {
311
-        drupal_add_css($editor['css path'] . '/' . $file);
311
+        drupal_add_css($editor['css path'].'/'.$file);
312 312
       }
313 313
 
314 314
       drupal_add_js(array('wysiwyg' => array(
@@ -316,7 +316,7 @@  discard block
 block discarded – undo
316 316
           // @todo Move into (global) editor settings.
317 317
           // If JS compression is enabled, at least TinyMCE is unable to determine
318 318
           // its own base path and exec mode since it can't find the script name.
319
-          'editorBasePath' => base_path() . $editor['library path'],
319
+          'editorBasePath' => base_path().$editor['library path'],
320 320
           'execMode' => $library,
321 321
         ))),
322 322
       )), 'setting');
@@ -340,11 +340,11 @@  discard block
 block discarded – undo
340 340
     $path = drupal_get_path('module', 'wysiwyg');
341 341
     // Initialize our namespaces in the *header* to do not force editor
342 342
     // integration scripts to check and define Drupal.wysiwyg on its own.
343
-    drupal_add_js($path . '/wysiwyg.init.js', 'core');
343
+    drupal_add_js($path.'/wysiwyg.init.js', 'core');
344 344
 
345 345
     // The 'none' editor is a special editor implementation, allowing us to
346 346
     // attach and detach regular Drupal behaviors just like any other editor.
347
-    drupal_add_js($path . '/editors/js/none.js');
347
+    drupal_add_js($path.'/editors/js/none.js');
348 348
 
349 349
     // Add wysiwyg.js to the footer to ensure it's executed after the
350 350
     // Drupal.settings array has been rendered and populated. Also, since editor
@@ -352,7 +352,7 @@  discard block
 block discarded – undo
352 352
     // and Drupal.wysiwygInit() must be executed AFTER editors registered
353 353
     // their callbacks and BEFORE Drupal.behaviors are applied, this must come
354 354
     // last.
355
-    drupal_add_js($path . '/wysiwyg.js', 'module', 'footer');
355
+    drupal_add_js($path.'/wysiwyg.js', 'module', 'footer');
356 356
 
357 357
     $settings_added = TRUE;
358 358
   }
@@ -371,7 +371,7 @@  discard block
 block discarded – undo
371 371
     // drupal_to_js() does not properly convert numeric array keys, so we need
372 372
     // to use a string instead of the format id.
373 373
     if ($config) {
374
-      drupal_add_js(array('wysiwyg' => array('configs' => array($profile->editor => array('format' . $profile->format => $config)))), 'setting');
374
+      drupal_add_js(array('wysiwyg' => array('configs' => array($profile->editor => array('format'.$profile->format => $config)))), 'setting');
375 375
     }
376 376
     $formats[$profile->format] = TRUE;
377 377
   }
@@ -448,7 +448,7 @@  discard block
 block discarded – undo
448 448
     $settings_native = call_user_func($editor['plugin settings callback'], $editor, $profile, $profile_plugins_native);
449 449
 
450 450
     if ($settings_native) {
451
-      drupal_add_js(array('wysiwyg' => array('plugins' => array('format' . $profile->format => array('native' => $settings_native)))), 'setting');
451
+      drupal_add_js(array('wysiwyg' => array('plugins' => array('format'.$profile->format => array('native' => $settings_native)))), 'setting');
452 452
     }
453 453
   }
454 454
 
@@ -463,7 +463,7 @@  discard block
 block discarded – undo
463 463
         if (!isset($processed_plugins[$proxy][$plugin])) {
464 464
           $profile_plugins_drupal[$plugin] = $processed_plugins[$proxy][$plugin] = $meta;
465 465
           // Load the Drupal plugin's JavaScript.
466
-          drupal_add_js($meta['js path'] . '/' . $meta['js file']);
466
+          drupal_add_js($meta['js path'].'/'.$meta['js file']);
467 467
           // Add plugin-specific settings.
468 468
           if (isset($meta['settings'])) {
469 469
             drupal_add_js(array('wysiwyg' => array('plugins' => array('drupal' => array($plugin => $meta['settings'])))), 'setting');
@@ -479,7 +479,7 @@  discard block
 block discarded – undo
479 479
     $settings_drupal = call_user_func($editor['proxy plugin settings callback'], $editor, $profile, $profile_plugins_drupal);
480 480
 
481 481
     if ($settings_drupal) {
482
-      drupal_add_js(array('wysiwyg' => array('plugins' => array('format' . $profile->format => array('drupal' => $settings_drupal)))), 'setting');
482
+      drupal_add_js(array('wysiwyg' => array('plugins' => array('format'.$profile->format => array('drupal' => $settings_drupal)))), 'setting');
483 483
     }
484 484
   }
485 485
 }
@@ -596,7 +596,7 @@  discard block
 block discarded – undo
596 596
     if ($media != 'print') {
597 597
       foreach ($css['theme'] as $filepath => $preprocess) {
598 598
         if (file_exists($filepath)) {
599
-          $files[] = base_path() . $filepath;
599
+          $files[] = base_path().$filepath;
600 600
         }
601 601
       }
602 602
     }
@@ -719,7 +719,7 @@  discard block
 block discarded – undo
719 719
         db_query("INSERT INTO {wysiwyg_user} (uid, format, status) VALUES (%d, %d, %d)", array(
720 720
           $account->uid,
721 721
           $format,
722
-          (int) (bool) $status,
722
+          (int)(bool)$status,
723 723
         ));
724 724
       }
725 725
     }
@@ -750,7 +750,7 @@  discard block
 block discarded – undo
750 750
     $status = isset($profile->settings['default']) ? $profile->settings['default'] : TRUE;
751 751
   }
752 752
 
753
-  return (bool) $status;
753
+  return (bool)$status;
754 754
 }
755 755
 
756 756
 /**
@@ -802,8 +802,8 @@  discard block
 block discarded – undo
802 802
       'plugin callback' => NULL,
803 803
       'plugin settings callback' => NULL,
804 804
       'versions' => array(),
805
-      'js path' => $editors[$editor]['path'] . '/js',
806
-      'css path' => $editors[$editor]['path'] . '/css',
805
+      'js path' => $editors[$editor]['path'].'/js',
806
+      'css path' => $editors[$editor]['path'].'/css',
807 807
     );
808 808
     // Check whether library is present.
809 809
     if (!($editors[$editor]['installed'] = file_exists($editors[$editor]['library path']))) {
@@ -855,12 +855,12 @@  discard block
 block discarded – undo
855 855
     $plugin += array(
856 856
       'title' => $plugin['name'],
857 857
       'vendor url' => '',
858
-      'js path' => $plugin['path'] . '/' . $plugin['name'],
859
-      'js file' => $plugin['name'] . '.js',
860
-      'css path' => $plugin['path'] . '/' . $plugin['name'],
861
-      'css file' => $plugin['name'] . '.css',
862
-      'icon path' => $plugin['path'] . '/' . $plugin['name'] . '/images',
863
-      'icon file' => $plugin['name'] . '.png',
858
+      'js path' => $plugin['path'].'/'.$plugin['name'],
859
+      'js file' => $plugin['name'].'.js',
860
+      'css path' => $plugin['path'].'/'.$plugin['name'],
861
+      'css file' => $plugin['name'].'.css',
862
+      'icon path' => $plugin['path'].'/'.$plugin['name'].'/images',
863
+      'icon file' => $plugin['name'].'.png',
864 864
       'dialog path' => $plugin['name'],
865 865
       'dialog settings' => array(),
866 866
       'settings callback' => NULL,
@@ -868,10 +868,10 @@  discard block
 block discarded – undo
868 868
     );
869 869
     // Fill in default settings.
870 870
     $plugin['settings'] += array(
871
-      'path' => base_path() . $plugin['path'] . '/' . $plugin['name'],
871
+      'path' => base_path().$plugin['path'].'/'.$plugin['name'],
872 872
     );
873 873
     // Check whether library is present.
874
-    if (!($plugin['installed'] = file_exists($plugin['js path'] . '/' . $plugin['js file']))) {
874
+    if (!($plugin['installed'] = file_exists($plugin['js path'].'/'.$plugin['js file']))) {
875 875
       continue;
876 876
     }
877 877
   }
@@ -893,18 +893,18 @@  discard block
 block discarded – undo
893 893
 function wysiwyg_load_includes($type = 'editors', $hook = 'editor', $file = NULL) {
894 894
   // Determine implementations.
895 895
   $directories = wysiwyg_get_directories($type);
896
-  $directories['wysiwyg'] = drupal_get_path('module', 'wysiwyg') . '/' . $type;
896
+  $directories['wysiwyg'] = drupal_get_path('module', 'wysiwyg').'/'.$type;
897 897
   $file_list = array();
898 898
   foreach ($directories as $module => $path) {
899
-    $file_list[$module] = drupal_system_listing("$file" . '.inc$', $path, 'name', 0);
899
+    $file_list[$module] = drupal_system_listing("$file".'.inc$', $path, 'name', 0);
900 900
   }
901 901
 
902 902
   // Load implementations.
903 903
   $info = array();
904 904
   foreach (array_filter($file_list) as $module => $files) {
905 905
     foreach ($files as $file) {
906
-      include_once './' . $file->filename;
907
-      $result = _wysiwyg_process_include($module, $module . '_' . $file->name, dirname($file->filename), $hook);
906
+      include_once './'.$file->filename;
907
+      $result = _wysiwyg_process_include($module, $module.'_'.$file->name, dirname($file->filename), $hook);
908 908
       if (is_array($result)) {
909 909
         $info = array_merge($info, $result);
910 910
       }
@@ -934,7 +934,7 @@  discard block
 block discarded – undo
934 934
   }
935 935
   if (!isset($libraries[$library])) {
936 936
     // Most often, external libraries can be shared across multiple sites.
937
-    return 'sites/all/libraries/' . $library;
937
+    return 'sites/all/libraries/'.$library;
938 938
   }
939 939
 
940 940
   $path = ($base_path ? base_path() : '');
@@ -984,7 +984,7 @@  discard block
 block discarded – undo
984 984
   }
985 985
 
986 986
   // Always search sites/all/*.
987
-  $searchdir[] = 'sites/all/' . $directory;
987
+  $searchdir[] = 'sites/all/'.$directory;
988 988
 
989 989
   // Also search sites/<domain>/*.
990 990
   if (file_exists("$config/$directory")) {
@@ -1028,7 +1028,7 @@  discard block
 block discarded – undo
1028 1028
   foreach (module_implements('wysiwyg_include_directory') as $module) {
1029 1029
     $result = module_invoke($module, 'wysiwyg_include_directory', $plugintype);
1030 1030
     if (isset($result) && is_string($result)) {
1031
-      $directories[$module] = drupal_get_path('module', $module) . '/' . $result;
1031
+      $directories[$module] = drupal_get_path('module', $module).'/'.$result;
1032 1032
     }
1033 1033
   }
1034 1034
   return $directories;
@@ -1045,7 +1045,7 @@  discard block
 block discarded – undo
1045 1045
  *   The name of the hook being invoked.
1046 1046
  */
1047 1047
 function _wysiwyg_process_include($module, $identifier, $path, $hook) {
1048
-  $function = $identifier . '_' . $hook;
1048
+  $function = $identifier.'_'.$hook;
1049 1049
   if (!function_exists($function)) {
1050 1050
     return NULL;
1051 1051
   }
Please login to merge, or discard this patch.
Braces   +7 added lines, -14 removed lines patch added patch discarded remove patch
@@ -201,8 +201,7 @@  discard block
 block discarded – undo
201 201
               if (empty($element['format']['guidelines']['#value'])) {
202 202
                 $element['format']['guidelines']['#value'] = ' ';
203 203
               }
204
-            }
205
-            else {
204
+            } else {
206 205
               $element[$format]['#attributes']['class'] = (isset($element[$format]['#attributes']['class']) ? $element[$format]['#attributes']['class'] . ' ' : '');
207 206
               $element[$format]['#attributes']['class'] .= 'wysiwyg wysiwyg-format-' . $format . ' wysiwyg-editor-' . $editor . ' wysiwyg-field-' . $field['#id'] . ' wysiwyg-status-' . $status . ' wysiwyg-toggle-' . $toggle . $extra_class;
208 207
             }
@@ -273,8 +272,7 @@  discard block
 block discarded – undo
273 272
       if (isset($profile->settings['library']) && isset($editor['libraries'][$profile->settings['library']])) {
274 273
         $library = $profile->settings['library'];
275 274
         $files = $editor['libraries'][$library]['files'];
276
-      }
277
-      else {
275
+      } else {
278 276
         // Fallback to the first defined library by default (external libraries can change).
279 277
         $library = key($editor['libraries']);
280 278
         $files = array_shift($editor['libraries']);
@@ -284,8 +282,7 @@  discard block
 block discarded – undo
284 282
         if (is_array($options)) {
285 283
           $options += array('type' => 'module', 'scope' => 'header', 'defer' => FALSE, 'cache' => TRUE, 'preprocess' => TRUE);
286 284
           drupal_add_js($editor['library path'] . '/' . $file, $options['type'], $options['scope'], $options['defer'], $options['cache'], $options['preprocess']);
287
-        }
288
-        else {
285
+        } else {
289 286
           drupal_add_js($editor['library path'] . '/' . $options);
290 287
         }
291 288
       }
@@ -322,8 +319,7 @@  discard block
 block discarded – undo
322 319
       )), 'setting');
323 320
 
324 321
       $loaded[$name] = TRUE;
325
-    }
326
-    else {
322
+    } else {
327 323
       $loaded[$name] = FALSE;
328 324
     }
329 325
   }
@@ -468,8 +464,7 @@  discard block
 block discarded – undo
468 464
           if (isset($meta['settings'])) {
469 465
             drupal_add_js(array('wysiwyg' => array('plugins' => array('drupal' => array($plugin => $meta['settings'])))), 'setting');
470 466
           }
471
-        }
472
-        else {
467
+        } else {
473 468
           $profile_plugins_drupal[$plugin] = $processed_plugins[$proxy][$plugin];
474 469
         }
475 470
       }
@@ -711,8 +706,7 @@  discard block
 block discarded – undo
711 706
       );
712 707
       return $form;
713 708
     }
714
-  }
715
-  elseif ($op == 'insert' || $op == 'update') {
709
+  } elseif ($op == 'insert' || $op == 'update') {
716 710
     if (isset($edit['wysiwyg_status'])) {
717 711
       db_query("DELETE FROM {wysiwyg_user} WHERE uid = %d", $account->uid);
718 712
       foreach ($edit['wysiwyg_status'] as $format => $status) {
@@ -745,8 +739,7 @@  discard block
 block discarded – undo
745 739
 
746 740
   if (!empty($profile->settings['user_choose']) && isset($account->wysiwyg_status[$profile->format])) {
747 741
     $status = $account->wysiwyg_status[$profile->format];
748
-  }
749
-  else {
742
+  } else {
750 743
     $status = isset($profile->settings['default']) ? $profile->settings['default'] : TRUE;
751 744
   }
752 745
 
Please login to merge, or discard this patch.
Upper-Lower-Casing   +36 added lines, -36 removed lines patch added patch discarded remove patch
@@ -61,13 +61,13 @@  discard block
 block discarded – undo
61 61
 function wysiwyg_theme() {
62 62
   return array(
63 63
     'wysiwyg_profile_overview' => array(
64
-      'arguments' => array('form' => NULL),
64
+      'arguments' => array('form' => null),
65 65
     ),
66 66
     'wysiwyg_admin_button_table' => array(
67
-      'arguments' => array('form' => NULL),
67
+      'arguments' => array('form' => null),
68 68
     ),
69 69
     'wysiwyg_dialog_page' => array(
70
-      'arguments' => array('content' => NULL, 'show_messages' => TRUE),
70
+      'arguments' => array('content' => null, 'show_messages' => true),
71 71
       'file' => 'wysiwyg.dialog.inc',
72 72
       'template' => 'wysiwyg-dialog-page',
73 73
     ),
@@ -89,7 +89,7 @@  discard block
 block discarded – undo
89 89
  * Clear wysiwyg cache on admin/build/modules form.
90 90
  */
91 91
 function wysiwyg_form_system_modules_alter(&$form, $form_state) {
92
-  wysiwyg_profile_load_all(TRUE);
92
+  wysiwyg_profile_load_all(true);
93 93
 }
94 94
 
95 95
 /**
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
           // guidelines, stored in the child 'format'.
167 167
           $formats = element_children($element);
168 168
           array_pop($formats);
169
-          if (($key = array_search('format', $formats)) !== FALSE) {
169
+          if (($key = array_search('format', $formats)) !== false) {
170 170
             unset($formats[$key]);
171 171
           }
172 172
           foreach ($formats as $format) {
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
             // Fetch the profile associated to this input format.
178 178
             $profile = wysiwyg_get_profile($format);
179 179
             if ($profile) {
180
-              $loaded = TRUE;
180
+              $loaded = true;
181 181
               $editor = $profile->editor;
182 182
               $status = (int) wysiwyg_user_get_status($profile);
183 183
               if (isset($profile->settings['show_toggle'])) {
@@ -211,7 +211,7 @@  discard block
 block discarded – undo
211 211
           // If we loaded at least one editor, then the 'none' editor will
212 212
           // handle resizable textareas instead of core.
213 213
           if (isset($loaded) && !empty($field['#resizable'])) {
214
-            $field['#resizable'] = FALSE;
214
+            $field['#resizable'] = false;
215 215
           }
216 216
         }
217 217
         // If this element is 'format', do not recurse further.
@@ -244,7 +244,7 @@  discard block
 block discarded – undo
244 244
       return $profile;
245 245
     }
246 246
   }
247
-  return FALSE;
247
+  return false;
248 248
 }
249 249
 
250 250
 /**
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
       }
283 283
       foreach ($files as $file => $options) {
284 284
         if (is_array($options)) {
285
-          $options += array('type' => 'module', 'scope' => 'header', 'defer' => FALSE, 'cache' => TRUE, 'preprocess' => TRUE);
285
+          $options += array('type' => 'module', 'scope' => 'header', 'defer' => false, 'cache' => true, 'preprocess' => true);
286 286
           drupal_add_js($editor['library path'] . '/' . $file, $options['type'], $options['scope'], $options['defer'], $options['cache'], $options['preprocess']);
287 287
         }
288 288
         else {
@@ -321,10 +321,10 @@  discard block
 block discarded – undo
321 321
         ))),
322 322
       )), 'setting');
323 323
 
324
-      $loaded[$name] = TRUE;
324
+      $loaded[$name] = true;
325 325
     }
326 326
     else {
327
-      $loaded[$name] = FALSE;
327
+      $loaded[$name] = false;
328 328
     }
329 329
   }
330 330
 
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
     // last.
355 355
     drupal_add_js($path . '/wysiwyg.js', 'module', 'footer');
356 356
 
357
-    $settings_added = TRUE;
357
+    $settings_added = true;
358 358
   }
359 359
 
360 360
   return $loaded[$name];
@@ -373,7 +373,7 @@  discard block
 block discarded – undo
373 373
     if ($config) {
374 374
       drupal_add_js(array('wysiwyg' => array('configs' => array($profile->editor => array('format' . $profile->format => $config)))), 'setting');
375 375
     }
376
-    $formats[$profile->format] = TRUE;
376
+    $formats[$profile->format] = true;
377 377
   }
378 378
 }
379 379
 
@@ -411,7 +411,7 @@  discard block
 block discarded – undo
411 411
   if (isset($processed_formats[$profile->format])) {
412 412
     return;
413 413
   }
414
-  $processed_formats[$profile->format] = TRUE;
414
+  $processed_formats[$profile->format] = true;
415 415
 
416 416
   $editor = wysiwyg_get_editor($profile->editor);
417 417
 
@@ -498,7 +498,7 @@  discard block
 block discarded – undo
498 498
  *   An array of theme names, or a single, checked theme name if $selected_theme
499 499
  *   was given.
500 500
  */
501
-function wysiwyg_get_editor_themes(&$profile, $selected_theme = NULL) {
501
+function wysiwyg_get_editor_themes(&$profile, $selected_theme = null) {
502 502
   static $themes = array();
503 503
 
504 504
   if (!isset($themes[$profile->editor])) {
@@ -614,13 +614,13 @@  discard block
 block discarded – undo
614 614
     $profiles = wysiwyg_profile_load_all();
615 615
   }
616 616
 
617
-  return (isset($profiles[$format]) ? $profiles[$format] : FALSE);
617
+  return (isset($profiles[$format]) ? $profiles[$format] : false);
618 618
 }
619 619
 
620 620
 /**
621 621
  * Load all profiles.
622 622
  */
623
-function wysiwyg_profile_load_all($reset = FALSE) {
623
+function wysiwyg_profile_load_all($reset = false) {
624 624
   static $profiles;
625 625
 
626 626
   if ($reset || !isset($profiles)) {
@@ -663,7 +663,7 @@  discard block
 block discarded – undo
663 663
  * Wysiwyg profiles list callback.
664 664
  */
665 665
 function wysiwyg_profile_list() {
666
-  $profiles = wysiwyg_profile_load_all(TRUE);
666
+  $profiles = wysiwyg_profile_load_all(true);
667 667
   $filter_formats = filter_formats();
668 668
   $list = array();
669 669
   foreach ($profiles as $profile) {
@@ -688,7 +688,7 @@  discard block
 block discarded – undo
688 688
 /**
689 689
  * Implementation of hook_user().
690 690
  */
691
-function wysiwyg_user($op, &$edit, $account, $category = NULL) {
691
+function wysiwyg_user($op, &$edit, $account, $category = null) {
692 692
   if ($op == 'form' && $category == 'account') {
693 693
     $user_formats = filter_formats();
694 694
     $options = array();
@@ -726,7 +726,7 @@  discard block
 block discarded – undo
726 726
   }
727 727
 }
728 728
 
729
-function wysiwyg_user_get_status($profile, $account = NULL) {
729
+function wysiwyg_user_get_status($profile, $account = null) {
730 730
   global $user;
731 731
 
732 732
   if (!isset($account)) {
@@ -747,7 +747,7 @@  discard block
 block discarded – undo
747 747
     $status = $account->wysiwyg_status[$profile->format];
748 748
   }
749 749
   else {
750
-    $status = isset($profile->settings['default']) ? $profile->settings['default'] : TRUE;
750
+    $status = isset($profile->settings['default']) ? $profile->settings['default'] : true;
751 751
   }
752 752
 
753 753
   return (bool) $status;
@@ -773,7 +773,7 @@  discard block
 block discarded – undo
773 773
  */
774 774
 function wysiwyg_get_editor($name) {
775 775
   $editors = wysiwyg_get_all_editors();
776
-  return isset($editors[$name]) && $editors[$name]['installed'] ? $editors[$name] : FALSE;
776
+  return isset($editors[$name]) && $editors[$name]['installed'] ? $editors[$name] : false;
777 777
 }
778 778
 
779 779
 /**
@@ -796,11 +796,11 @@  discard block
 block discarded – undo
796 796
       'editor path' => wysiwyg_get_path($editors[$editor]['name']),
797 797
       'library path' => wysiwyg_get_path($editors[$editor]['name']),
798 798
       'libraries' => array(),
799
-      'version callback' => NULL,
800
-      'themes callback' => NULL,
801
-      'settings callback' => NULL,
802
-      'plugin callback' => NULL,
803
-      'plugin settings callback' => NULL,
799
+      'version callback' => null,
800
+      'themes callback' => null,
801
+      'settings callback' => null,
802
+      'plugin callback' => null,
803
+      'plugin settings callback' => null,
804 804
       'versions' => array(),
805 805
       'js path' => $editors[$editor]['path'] . '/js',
806 806
       'css path' => $editors[$editor]['path'] . '/css',
@@ -815,7 +815,7 @@  discard block
 block discarded – undo
815 815
     }
816 816
     if (empty($editors[$editor]['installed version'])) {
817 817
       $editors[$editor]['error'] = t('The version of %editor could not be detected.', array('%editor' => $properties['title']));
818
-      $editors[$editor]['installed'] = FALSE;
818
+      $editors[$editor]['installed'] = false;
819 819
       continue;
820 820
     }
821 821
     // Determine to which supported version the installed version maps.
@@ -828,7 +828,7 @@  discard block
 block discarded – undo
828 828
     }
829 829
     if (!$version) {
830 830
       $editors[$editor]['error'] = t('The installed version %version of %editor is not supported.', array('%version' => $editors[$editor]['installed version'], '%editor' => $editors[$editor]['title']));
831
-      $editors[$editor]['installed'] = FALSE;
831
+      $editors[$editor]['installed'] = false;
832 832
       continue;
833 833
     }
834 834
     // Apply library version specific definitions and overrides.
@@ -863,8 +863,8 @@  discard block
 block discarded – undo
863 863
       'icon file' => $plugin['name'] . '.png',
864 864
       'dialog path' => $plugin['name'],
865 865
       'dialog settings' => array(),
866
-      'settings callback' => NULL,
867
-      'settings form callback' => NULL,
866
+      'settings callback' => null,
867
+      'settings form callback' => null,
868 868
     );
869 869
     // Fill in default settings.
870 870
     $plugin['settings'] += array(
@@ -890,7 +890,7 @@  discard block
 block discarded – undo
890 890
  *
891 891
  * @see wysiwyg_get_directories(), _wysiwyg_process_include()
892 892
  */
893
-function wysiwyg_load_includes($type = 'editors', $hook = 'editor', $file = NULL) {
893
+function wysiwyg_load_includes($type = 'editors', $hook = 'editor', $file = null) {
894 894
   // Determine implementations.
895 895
   $directories = wysiwyg_get_directories($type);
896 896
   $directories['wysiwyg'] = drupal_get_path('module', 'wysiwyg') . '/' . $type;
@@ -926,7 +926,7 @@  discard block
 block discarded – undo
926 926
  *
927 927
  * @ingroup libraries
928 928
  */
929
-function wysiwyg_get_path($library, $base_path = FALSE) {
929
+function wysiwyg_get_path($library, $base_path = false) {
930 930
   static $libraries;
931 931
 
932 932
   if (!isset($libraries)) {
@@ -997,7 +997,7 @@  discard block
 block discarded – undo
997 997
   $nomask = array('CVS');
998 998
   foreach ($searchdir as $dir) {
999 999
     if (is_dir($dir) && $handle = opendir($dir)) {
1000
-      while (FALSE !== ($file = readdir($handle))) {
1000
+      while (false !== ($file = readdir($handle))) {
1001 1001
         if (!in_array($file, $nomask) && $file[0] != '.') {
1002 1002
           if (is_dir("$dir/$file")) {
1003 1003
             $directories[$file] = "$dir/$file";
@@ -1047,11 +1047,11 @@  discard block
 block discarded – undo
1047 1047
 function _wysiwyg_process_include($module, $identifier, $path, $hook) {
1048 1048
   $function = $identifier . '_' . $hook;
1049 1049
   if (!function_exists($function)) {
1050
-    return NULL;
1050
+    return null;
1051 1051
   }
1052 1052
   $result = $function();
1053 1053
   if (!isset($result) || !is_array($result)) {
1054
-    return NULL;
1054
+    return null;
1055 1055
   }
1056 1056
 
1057 1057
   // Fill in defaults.
Please login to merge, or discard this patch.
html/inc/account.inc 3 patches
Doc Comments   +7 added lines patch added patch discarded remove patch
@@ -18,6 +18,10 @@  discard block
 block discarded – undo
18 18
 
19 19
 // forms for account creation and login
20 20
 
21
+/**
22
+ * @param integer $teamid
23
+ * @param string $next_url
24
+ */
21 25
 function create_account_form($teamid, $next_url) {
22 26
     global $recaptcha_public_key;
23 27
     echo "
@@ -92,6 +96,9 @@  discard block
 block discarded – undo
92 96
     echo "</form>\n";
93 97
 }
94 98
 
99
+/**
100
+ * @param string $next_url
101
+ */
95 102
 function login_form($next_url) {
96 103
     echo "
97 104
         <form name=\"f\" method=\"post\" action=\"".secure_url_base()."/login_action.php\">
Please login to merge, or discard this patch.
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -35,10 +35,10 @@
 block discarded – undo
35 35
     // Using invitation codes to restrict access?
36 36
     //
37 37
     if (defined('INVITE_CODES')) {
38
-         row2(
39
-             tra("Invitation Code")."<br><small>".tra("A valid invitation code is required to create an account.")."</small>",
40
-             '<input class="form-control" type="text" name="invite_code" size="30" >'
41
-         );
38
+            row2(
39
+                tra("Invitation Code")."<br><small>".tra("A valid invitation code is required to create an account.")."</small>",
40
+                '<input class="form-control" type="text" name="invite_code" size="30" >'
41
+            );
42 42
     }
43 43
 
44 44
     row2(
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
         $x .= '<br><small><a href="get_passwd.php">'.tra("forgot email address?")."</a></small>";
108 108
     }
109 109
     row2($x, '<input class="form-control" name=email_addr type="text" size=40 tabindex=1>');
110
-    row2(tra("Password:") . '<br><small><a href="get_passwd.php">' . tra("forgot password?") . "</a></small>",
110
+    row2(tra("Password:").'<br><small><a href="get_passwd.php">'.tra("forgot password?")."</a></small>",
111 111
         '<input class="form-control" type="password" name="passwd" size="40" tabindex="2">'
112 112
     );
113 113
     row2(tra("Stay logged in"),
Please login to merge, or discard this patch.
html/inc/akismet.inc 4 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -52,6 +52,9 @@
 block discarded – undo
52 52
     }
53 53
 }
54 54
 
55
+/**
56
+ * @param string $path
57
+ */
55 58
 function akismet_request($request, $host, $path, $port = 80) {
56 59
     $http_request  = "POST $path HTTP/1.0\r\n";
57 60
     $http_request .= "Host: $host\r\n";
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -26,7 +26,7 @@  discard block
 block discarded – undo
26 26
 
27 27
     $master_url_enc = urlencode($master_url);
28 28
     $response = akismet_request("key=$key&blog=$master_url_enc", "rest.akismet.com", "/1.1/verify-key");
29
-    if ("valid" == $response[1] ) {
29
+    if ("valid" == $response[1]) {
30 30
         $post = urlencode($post);
31 31
         $ip = urlencode($_SERVER['REMOTE_ADDR']);
32 32
         $referrer = urlencode($_SERVER['HTTP_REFERER']);
@@ -56,15 +56,15 @@  discard block
 block discarded – undo
56 56
     $http_request  = "POST $path HTTP/1.0\r\n";
57 57
     $http_request .= "Host: $host\r\n";
58 58
     $http_request .= "Content-Type: application/x-www-form-urlencoded; charset=utf-8\r\n";
59
-    $http_request .= "Content-Length: " . strlen($request) . "\r\n";
59
+    $http_request .= "Content-Length: ".strlen($request)."\r\n";
60 60
     $http_request .= "User-Agent: BOINC | Akismet 1.1\r\n";
61 61
     $http_request .= "\r\n";
62 62
     $http_request .= $request;
63 63
 
64 64
     $response = '';
65
-    if( false !== ( $fs = @fsockopen($host, $port, $errno, $errstr, 3) ) ) {
65
+    if (false !== ($fs = @fsockopen($host, $port, $errno, $errstr, 3))) {
66 66
         fwrite($fs, $http_request);
67
-        while ( !feof($fs) )
67
+        while (!feof($fs))
68 68
             $response .= fgets($fs, 1160); // One TCP-IP packet
69 69
         fclose($fs);
70 70
         $response = explode("\r\n\r\n", $response, 2);
Please login to merge, or discard this patch.
Braces   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -42,7 +42,8 @@  discard block
 block discarded – undo
42 42
 
43 43
         $response = akismet_request($request, "$key.rest.akismet.com", "/1.1/comment-check");
44 44
 
45
-        if ("true" == $response[1]) { // Akismet says it's spam
45
+        if ("true" == $response[1]) {
46
+// Akismet says it's spam
46 47
             return false;
47 48
         } else {
48 49
             return true;
@@ -64,8 +65,10 @@  discard block
 block discarded – undo
64 65
     $response = '';
65 66
     if( false !== ( $fs = @fsockopen($host, $port, $errno, $errstr, 3) ) ) {
66 67
         fwrite($fs, $http_request);
67
-        while ( !feof($fs) )
68
-            $response .= fgets($fs, 1160); // One TCP-IP packet
68
+        while ( !feof($fs) ) {
69
+                    $response .= fgets($fs, 1160);
70
+        }
71
+        // One TCP-IP packet
69 72
         fclose($fs);
70 73
         $response = explode("\r\n\r\n", $response, 2);
71 74
     }
Please login to merge, or discard this patch.
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -53,7 +53,7 @@
 block discarded – undo
53 53
 }
54 54
 
55 55
 function akismet_request($request, $host, $path, $port = 80) {
56
-    $http_request  = "POST $path HTTP/1.0\r\n";
56
+    $http_request  = "post $path HTTP/1.0\r\n";
57 57
     $http_request .= "Host: $host\r\n";
58 58
     $http_request .= "Content-Type: application/x-www-form-urlencoded; charset=utf-8\r\n";
59 59
     $http_request .= "Content-Length: " . strlen($request) . "\r\n";
Please login to merge, or discard this patch.
html/inc/boinc_db.inc 3 patches
Doc Comments   +107 added lines patch added patch discarded remove patch
@@ -40,6 +40,10 @@  discard block
 block discarded – undo
40 40
     // 2: only use replica_db_user, only try replica_db_host
41 41
     // can be set projectwide using <replica_fallback_mode>
42 42
     //
43
+
44
+    /**
45
+     * @param boolean $readonly
46
+     */
43 47
     static function get_aux($readonly, $fallback_mode = 0) {
44 48
         $config = get_config();
45 49
         $user = parse_config($config, '<db_user>');
@@ -204,6 +208,10 @@  discard block
 block discarded – undo
204 208
         $db = BoincDb::get();
205 209
         return $db->count('user', $clause);
206 210
     }
211
+
212
+    /**
213
+     * @param string $field
214
+     */
207 215
     static function max($field) {
208 216
         $db = BoincDb::get();
209 217
         return $db->max('user', $field);
@@ -216,6 +224,10 @@  discard block
 block discarded – undo
216 224
         $db = BoincDb::get();
217 225
         return $db->enum('user', 'BoincUser', $where_clause, $order_clause);
218 226
     }
227
+
228
+    /**
229
+     * @param string $fields
230
+     */
219 231
     static function enum_fields($fields, $where_clause, $order_clause=null) {
220 232
         $db = BoincDb::get();
221 233
         return $db->enum_fields(
@@ -233,10 +245,19 @@  discard block
 block discarded – undo
233 245
         $db->delete_aux('profile', "userid=$this->id");
234 246
         return $db->delete($this, 'user');
235 247
     }
248
+
249
+    /**
250
+     * @param string $field
251
+     */
236 252
     static function sum($field) {
237 253
         $db = BoincDb::get();
238 254
         return $db->sum('user', $field);
239 255
     }
256
+
257
+    /**
258
+     * @param string $field
259
+     * @param string $clause
260
+     */
240 261
     static function percentile($field, $clause, $pct) {
241 262
         $db = BoincDb::get();
242 263
         return $db->percentile('user', $field, $clause, $pct);
@@ -245,6 +266,10 @@  discard block
 block discarded – undo
245 266
 
246 267
 class BoincTeam {
247 268
     static $cache;
269
+
270
+    /**
271
+     * @param string $clause
272
+     */
248 273
     static function insert($clause) {
249 274
         $db = BoincDb::get();
250 275
         $ret = $db->insert('team', $clause);
@@ -282,14 +307,27 @@  discard block
 block discarded – undo
282 307
         $db = BoincDb::get();
283 308
         return $db->delete($this, 'team');
284 309
     }
310
+
311
+    /**
312
+     * @param string $field
313
+     * @param string $clause
314
+     */
285 315
     static function percentile($field, $clause, $pct) {
286 316
         $db = BoincDb::get();
287 317
         return $db->percentile('team', $field, $clause, $pct);
288 318
     }
319
+
320
+    /**
321
+     * @param string $field
322
+     */
289 323
     static function max($field) {
290 324
         $db = BoincDb::get();
291 325
         return $db->max('team', $field);
292 326
     }
327
+
328
+    /**
329
+     * @param string $fields
330
+     */
293 331
     static function enum_fields($fields, $where_clause, $order_clause=null) {
294 332
         $db = BoincDb::get();
295 333
         return $db->enum_fields(
@@ -326,6 +364,12 @@  discard block
 block discarded – undo
326 364
         $db = BoincDb::get();
327 365
         return $db->enum('host', 'BoincHost', $where_clause, $order_clause);
328 366
     }
367
+
368
+    /**
369
+     * @param string $fields
370
+     * @param string $where_clause
371
+     * @param string $order_clause
372
+     */
329 373
     static function enum_fields($fields, $where_clause, $order_clause=null) {
330 374
         $db = BoincDb::get();
331 375
         return $db->enum_fields(
@@ -358,6 +402,10 @@  discard block
 block discarded – undo
358 402
         $db = BoincDb::get();
359 403
         return $db->enum('result', 'BoincResult', $where_clause);
360 404
     }
405
+
406
+	/**
407
+	 * @param string $fields
408
+	 */
361 409
 	static function enum_fields($fields, $where_clause, $order_clause) {
362 410
         $db = BoincDb::get();
363 411
 		return $db->enum_fields('result', 'BoincResult', $fields, $where_clause, $order_clause);
@@ -412,6 +460,10 @@  discard block
 block discarded – undo
412 460
         $db = BoincDb::get();
413 461
         return $db->update_aux('workunit', $clause);
414 462
     }
463
+
464
+    /**
465
+     * @param string $clause
466
+     */
415 467
     static function count($clause) {
416 468
         $db = BoincDb::get();
417 469
         return $db->count('workunit', $clause);
@@ -427,6 +479,10 @@  discard block
 block discarded – undo
427 479
         $db = BoincDb::get();
428 480
         return $db->lookup('app', 'BoincApp', $clause);
429 481
     }
482
+
483
+    /**
484
+     * @param string $where_clause
485
+     */
430 486
     static function enum($where_clause) {
431 487
         $db = BoincDb::get();
432 488
         return $db->enum('app', 'BoincApp', $where_clause);
@@ -441,6 +497,11 @@  discard block
 block discarded – undo
441 497
         $db = BoincDb::get();
442 498
         return $db->update($this, 'app', $clause);
443 499
     }
500
+
501
+    /**
502
+     * @param string $field
503
+     * @param string $clause
504
+     */
444 505
     static function sum($field, $clause=null) {
445 506
         $db = BoincDb::get();
446 507
         return $db->sum('app', $field, $clause);
@@ -473,6 +534,10 @@  discard block
 block discarded – undo
473 534
 }
474 535
 
475 536
 class BoincProfile {
537
+
538
+    /**
539
+     * @param string $fields
540
+     */
476 541
     static function lookup_fields($fields, $clause) {
477 542
         $db = BoincDb::get();
478 543
         return $db->lookup_fields('profile', 'BoincProfile', $fields, $clause);
@@ -489,18 +554,37 @@  discard block
 block discarded – undo
489 554
         $db = BoincDb::get();
490 555
         return $db->update_aux('profile', $clause.' where userid='.$this->userid);
491 556
     }
557
+
558
+    /**
559
+     * @param string $clause
560
+     */
492 561
     static function update_aux($clause) {
493 562
         $db = BoincDb::get();
494 563
         return $db->update_aux('profile', $clause);
495 564
     }
565
+
566
+    /**
567
+     * @param string $clause
568
+     */
496 569
     static function insert($clause) {
497 570
         $db = BoincDb::get();
498 571
         return $db->insert('profile', $clause);
499 572
     }
573
+
574
+    /**
575
+     * @param string $where_clause
576
+     * @param string $order_clause
577
+     */
500 578
     static function enum($where_clause=null, $order_clause=null) {
501 579
         $db = BoincDb::get();
502 580
         return $db->enum('profile', 'BoincProfile', $where_clause, $order_clause);
503 581
     }
582
+
583
+    /**
584
+     * @param string $fields
585
+     * @param string $where_clause
586
+     * @param string $order_clause
587
+     */
504 588
     static function enum_fields($fields, $where_clause=null, $order_clause=null) {
505 589
         $db = BoincDb::get();
506 590
         return $db->enum_fields('profile', 'BoincProfile', $fields, $where_clause, $order_clause);
@@ -568,6 +652,10 @@  discard block
 block discarded – undo
568 652
 }
569 653
 
570 654
 class BoincPlatform {
655
+
656
+    /**
657
+     * @param string $where_clause
658
+     */
571 659
     static function enum($where_clause) {
572 660
         $db = BoincDb::get();
573 661
         return $db->enum('platform', 'BoincPlatform', $where_clause);
@@ -648,6 +736,10 @@  discard block
 block discarded – undo
648 736
 }
649 737
 
650 738
 class BoincBadge {
739
+
740
+    /**
741
+     * @param string $where_clause
742
+     */
651 743
     static function enum($where_clause) {
652 744
         $db = BoincDb::get();
653 745
         return $db->enum('badge', 'BoincBadge', $where_clause);
@@ -743,6 +835,11 @@  discard block
 block discarded – undo
743 835
         $db = BoincDb::get();
744 836
         return $db->enum('credit_user', 'BoincCreditUser', $where_clause);
745 837
     }
838
+
839
+    /**
840
+     * @param string $field
841
+     * @param string $clause
842
+     */
746 843
     static function sum($field, $clause) {
747 844
         $db = BoincDb::get();
748 845
         return $db->sum('credit_user', $field, $clause);
@@ -766,6 +863,11 @@  discard block
 block discarded – undo
766 863
         $db = BoincDb::get();
767 864
         return $db->enum('credit_team', 'BoincCreditTeam', $where_clause);
768 865
     }
866
+
867
+    /**
868
+     * @param string $field
869
+     * @param string $clause
870
+     */
769 871
     static function sum($field, $clause) {
770 872
         $db = BoincDb::get();
771 873
         return $db->sum('credit_team', $field, $clause);
@@ -780,6 +882,11 @@  discard block
 block discarded – undo
780 882
 // 
781 883
 // apply this to any user-supplied strings used in queries
782 884
 // 
885
+/**
886
+ * @param string $x
887
+ *
888
+ * @return string
889
+ */
783 890
 function boinc_real_escape_string($x) {
784 891
     if (version_compare(phpversion(),"4.3.0")>=0) {
785 892
         return BoincDb::escape_string($x);
Please login to merge, or discard this patch.
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -358,10 +358,10 @@
 block discarded – undo
358 358
         $db = BoincDb::get();
359 359
         return $db->enum('result', 'BoincResult', $where_clause);
360 360
     }
361
-	static function enum_fields($fields, $where_clause, $order_clause) {
361
+    static function enum_fields($fields, $where_clause, $order_clause) {
362 362
         $db = BoincDb::get();
363
-		return $db->enum_fields('result', 'BoincResult', $fields, $where_clause, $order_clause);
364
-	}
363
+        return $db->enum_fields('result', 'BoincResult', $fields, $where_clause, $order_clause);
364
+    }
365 365
     function update($clause) {
366 366
         $db = BoincDb::get();
367 367
         return $db->update($this, 'result', $clause);
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -212,11 +212,11 @@  discard block
 block discarded – undo
212 212
         $db = BoincDb::get();
213 213
         return $db->update($this, 'user', $clause);
214 214
     }
215
-    static function enum($where_clause, $order_clause=null) {
215
+    static function enum($where_clause, $order_clause = null) {
216 216
         $db = BoincDb::get();
217 217
         return $db->enum('user', 'BoincUser', $where_clause, $order_clause);
218 218
     }
219
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
219
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
220 220
         $db = BoincDb::get();
221 221
         return $db->enum_fields(
222 222
             'user', 'BoincUser', $fields, $where_clause, $order_clause
@@ -265,7 +265,7 @@  discard block
 block discarded – undo
265 265
         $db = BoincDb::get();
266 266
         return $db->update($this, 'team', $clause);
267 267
     }
268
-    static function enum($where_clause, $order_clause=null) {
268
+    static function enum($where_clause, $order_clause = null) {
269 269
         $db = BoincDb::get();
270 270
         return $db->enum('team', 'BoincTeam', $where_clause, $order_clause);
271 271
     }
@@ -290,7 +290,7 @@  discard block
 block discarded – undo
290 290
         $db = BoincDb::get();
291 291
         return $db->max('team', $field);
292 292
     }
293
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
293
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
294 294
         $db = BoincDb::get();
295 295
         return $db->enum_fields(
296 296
             'team', 'BoincTeam', $fields, $where_clause, $order_clause
@@ -322,11 +322,11 @@  discard block
 block discarded – undo
322 322
         $db = BoincDb::get();
323 323
         return $db->delete($this, 'host');
324 324
     }
325
-    static function enum($where_clause, $order_clause=null) {
325
+    static function enum($where_clause, $order_clause = null) {
326 326
         $db = BoincDb::get();
327 327
         return $db->enum('host', 'BoincHost', $where_clause, $order_clause);
328 328
     }
329
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
329
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
330 330
         $db = BoincDb::get();
331 331
         return $db->enum_fields(
332 332
             'host', 'BoincHost', $fields, $where_clause, $order_clause
@@ -441,7 +441,7 @@  discard block
 block discarded – undo
441 441
         $db = BoincDb::get();
442 442
         return $db->update($this, 'app', $clause);
443 443
     }
444
-    static function sum($field, $clause=null) {
444
+    static function sum($field, $clause = null) {
445 445
         $db = BoincDb::get();
446 446
         return $db->sum('app', $field, $clause);
447 447
     }
@@ -497,11 +497,11 @@  discard block
 block discarded – undo
497 497
         $db = BoincDb::get();
498 498
         return $db->insert('profile', $clause);
499 499
     }
500
-    static function enum($where_clause=null, $order_clause=null) {
500
+    static function enum($where_clause = null, $order_clause = null) {
501 501
         $db = BoincDb::get();
502 502
         return $db->enum('profile', 'BoincProfile', $where_clause, $order_clause);
503 503
     }
504
-    static function enum_fields($fields, $where_clause=null, $order_clause=null) {
504
+    static function enum_fields($fields, $where_clause = null, $order_clause = null) {
505 505
         $db = BoincDb::get();
506 506
         return $db->enum_fields('profile', 'BoincProfile', $fields, $where_clause, $order_clause);
507 507
     }
@@ -781,7 +781,7 @@  discard block
 block discarded – undo
781 781
 // apply this to any user-supplied strings used in queries
782 782
 // 
783 783
 function boinc_real_escape_string($x) {
784
-    if (version_compare(phpversion(),"4.3.0")>=0) {
784
+    if (version_compare(phpversion(), "4.3.0") >= 0) {
785 785
         return BoincDb::escape_string($x);
786 786
     } else {
787 787
         $x = str_replace("'", "\'", $x);
Please login to merge, or discard this patch.
html/inc/bolt.inc 2 patches
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -246,6 +246,9 @@  discard block
 block discarded – undo
246 246
 
247 247
 }
248 248
 
249
+/**
250
+ * @param string $n
251
+ */
249 252
 function name($n) {
250 253
     return array('name', $n);
251 254
 }
@@ -254,10 +257,16 @@  discard block
 block discarded – undo
254 257
     return array('title', $n);
255 258
 }
256 259
 
260
+/**
261
+ * @param integer $n
262
+ */
257 263
 function number($n) {
258 264
     return array('number', $n);
259 265
 }
260 266
 
267
+/**
268
+ * @param string $n
269
+ */
261 270
 function filename($n) {
262 271
     return array('filename', $n);
263 272
 }
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
     public $title;
31 31
         // Optional; used when showing course history outline.
32 32
     public $is_item;
33
-    public $attrs;        // course-defined
33
+    public $attrs; // course-defined
34 34
 
35 35
     abstract function walk(&$iter, $incr, &$frac_done);
36 36
         // multi-purpose function for traversing a course.
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
             $this->query_string = null;
56 56
         } else {
57 57
             $this->filename = substr($filename, 0, $p);
58
-            $this->query_string = substr($filename, $p+1);
58
+            $this->query_string = substr($filename, $p + 1);
59 59
         }
60 60
         $this->name = $filename;
61 61
         $this->title = $title;
@@ -162,7 +162,7 @@  discard block
 block discarded – undo
162 162
             // look up unit by name
163 163
             //
164 164
             $child = null;
165
-            for ($i=0; $i<$n; $i++) {
165
+            for ($i = 0; $i < $n; $i++) {
166 166
                 $c = $this->units[$i];
167 167
                 if ($c->name == $child_name) {
168 168
                     $child = $c;
@@ -177,7 +177,7 @@  discard block
 block discarded – undo
177 177
                 if ($i >= $n) {
178 178
                     // and if index is too big, use last unit
179 179
                     //
180
-                    $i = $n-1;
180
+                    $i = $n - 1;
181 181
                 }
182 182
                 $child = $this->units[$i];
183 183
             }
@@ -197,7 +197,7 @@  discard block
 block discarded – undo
197 197
                         $this->finished($iter);
198 198
                         return true;
199 199
                     } else {
200
-                        $i = ($i+1)%$n;
200
+                        $i = ($i + 1)%$n;
201 201
                     }
202 202
                 }
203 203
             }
@@ -235,7 +235,7 @@  discard block
 block discarded – undo
235 235
         if (array_key_exists($this->name, $state)) {
236 236
             $state_rec = $state[$this->name];
237 237
             $child_name = $state_rec['child_name'];
238
-            foreach($this->units as $c) {
238
+            foreach ($this->units as $c) {
239 239
                 if ($c->name == $child_name) {
240 240
                     return $c;
241 241
                 }
Please login to merge, or discard this patch.
html/inc/bolt_ex.inc 2 patches
Doc Comments   +8 added lines patch added patch discarded remove patch
@@ -240,6 +240,10 @@  discard block
 block discarded – undo
240 240
 
241 241
 class BoltFitbField {
242 242
     public $textarea, $nrows, $ncols;
243
+
244
+    /**
245
+     * @param boolean $textarea
246
+     */
243 247
     function __construct($textarea, $nrows, $ncols) {
244 248
         $this->textarea = $textarea;
245 249
         $this->nrows = $nrows;
@@ -258,6 +262,10 @@  discard block
 block discarded – undo
258 262
 class BoltFitbAnswer {
259 263
     public $type;   // 0=constant, 1=regexp, 2=func
260 264
     public $ans;
265
+
266
+    /**
267
+     * @param integer $type
268
+     */
261 269
     function __construct($type, $ans) {
262 270
         $this->type = $type;
263 271
         $this->ans = $ans;
Please login to merge, or discard this patch.
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -21,11 +21,11 @@  discard block
 block discarded – undo
21 21
 // The following is a global var accessed by exercise functions.
22 22
 //
23 23
 $bolt_ex = null;
24
-$bolt_ex->mode = 0;     // input: SHOW/SCORE/ANSWER
25
-$bolt_ex->index = 0;    // input: sequence of this exercise in file
26
-$bolt_ex->score = 0;    // input/output: cumulative score (if mode = SCORE)
27
-$bolt_ex->weight = 0;   // input/output: cumulative weight
28
-$bolt_ex->query_string = "";    // user's response (if SCORE or ANSWER)
24
+$bolt_ex->mode = 0; // input: SHOW/SCORE/ANSWER
25
+$bolt_ex->index = 0; // input: sequence of this exercise in file
26
+$bolt_ex->score = 0; // input/output: cumulative score (if mode = SCORE)
27
+$bolt_ex->weight = 0; // input/output: cumulative weight
28
+$bolt_ex->query_string = ""; // user's response (if SCORE or ANSWER)
29 29
 
30 30
 function weight($w) {
31 31
     return array('weight', $w);
@@ -170,9 +170,9 @@  discard block
 block discarded – undo
170 170
             $response = isset($$key);
171 171
             $r = $choice[1];
172 172
             $correct = ($r && $response) || (!$r && !$response);
173
-            $color = $correct?"#88ff88":"#ff8888";
174
-            table_row($c, $r?"yes":"no",
175
-                array($response?"yes":"no", "bgcolor=$color")
173
+            $color = $correct ? "#88ff88" : "#ff8888";
174
+            table_row($c, $r ? "yes" : "no",
175
+                array($response ? "yes" : "no", "bgcolor=$color")
176 176
             );
177 177
             $i++;
178 178
         }
@@ -215,11 +215,11 @@  discard block
 block discarded – undo
215 215
         if ($y > $rect[3]) $right = false;
216 216
         $cx = $rect[0];
217 217
         $cy = $rect[2];
218
-        $sizex = $rect[1]-$rect[0];
219
-        $sizey = $rect[3]-$rect[2];
220
-        $ax = $x-4;
221
-        $ay = $y-4;
222
-        $color = $right?"green":"red";
218
+        $sizex = $rect[1] - $rect[0];
219
+        $sizey = $rect[3] - $rect[2];
220
+        $ax = $x - 4;
221
+        $ay = $y - 4;
222
+        $color = $right ? "green" : "red";
223 223
         if ($right) {
224 224
             echo "The point you selected (shown in green) is correct.";
225 225
         } else {
@@ -256,7 +256,7 @@  discard block
 block discarded – undo
256 256
 }
257 257
 
258 258
 class BoltFitbAnswer {
259
-    public $type;   // 0=constant, 1=regexp, 2=func
259
+    public $type; // 0=constant, 1=regexp, 2=func
260 260
     public $ans;
261 261
     function __construct($type, $ans) {
262 262
         $this->type = $type;
Please login to merge, or discard this patch.
html/inc/bolt_select.inc 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -52,6 +52,9 @@
 block discarded – undo
52 52
     }
53 53
 }
54 54
 
55
+/**
56
+ * @param string $n
57
+ */
55 58
 function valuator($n) {
56 59
     return array('valuator', $n);
57 60
 }
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -18,7 +18,7 @@
 block discarded – undo
18 18
 
19 19
 function select_cmp($a, $b) {
20 20
     if ($a->value == $b->value) return 0;
21
-    return ($a->value < $b->value)?1:-1;
21
+    return ($a->value < $b->value) ? 1 : -1;
22 22
 }
23 23
 
24 24
 class BoltSelect extends BoltSet {
Please login to merge, or discard this patch.
html/inc/bolt_snap.inc 1 patch
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -45,6 +45,9 @@  discard block
 block discarded – undo
45 45
     return "../bolt_snap/compare_snapshot_$x";
46 46
 }
47 47
 
48
+/**
49
+ * @param null|integer $dur
50
+ */
48 51
 function write_compare_snapshot($course_id, $select_name, $xset_name, $dur) {
49 52
     $now = time();
50 53
     $start = $now - $dur*86400;
@@ -127,6 +130,9 @@  discard block
 block discarded – undo
127 130
     return "../bolt_snap/map_snapshot_".$course_id;
128 131
 }
129 132
 
133
+/**
134
+ * @param null|integer $dur
135
+ */
130 136
 function write_map_snapshot($course_id, $dur) {
131 137
     $now = time();
132 138
     $start = $now - $dur*86400;
Please login to merge, or discard this patch.
html/inc/bolt_util_ops.inc 2 patches
Doc Comments   +21 added lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@  discard block
 block discarded – undo
23 23
 
24 24
 // get names of units of a given type
25 25
 
26
+/**
27
+ * @param string $type
28
+ */
26 29
 function units_of_type($unit, $type) {
27 30
     $names = array();
28 31
     if (get_class($unit) == $type) {
@@ -118,6 +121,10 @@  discard block
 block discarded – undo
118 121
 
119 122
 //////////// graph drawing
120 123
 
124
+/**
125
+ * @param integer $n
126
+ * @param integer $width
127
+ */
121 128
 function compare_bar($title, $n, $width, $lo, $hi) {
122 129
     $x1 = $width*$lo;
123 130
     $x2 = $width*($hi-$lo);
@@ -137,6 +144,9 @@  discard block
 block discarded – undo
137 144
     ";
138 145
 }
139 146
 
147
+/**
148
+ * @param integer $width
149
+ */
140 150
 function compare_bar_insuff($title, $width) {
141 151
     return "
142 152
         <tr>
@@ -150,6 +160,10 @@  discard block
 block discarded – undo
150 160
     ";
151 161
 }
152 162
 
163
+/**
164
+ * @param integer[] $x
165
+ * @param integer $width
166
+ */
153 167
 function outcome_graph($x, $width) {
154 168
     $n = $x[0]+$x[1]+$x[2];
155 169
     if (!$n) return empty_cell();
@@ -182,6 +196,9 @@  discard block
 block discarded – undo
182 196
     return $s;
183 197
 }
184 198
 
199
+/**
200
+ * @param integer $w
201
+ */
185 202
 function time_graph($t, $w) {
186 203
     if ($t == 0) return "<td>---</td>";
187 204
     $x = (log10($t)+2)*$w/4;
@@ -193,6 +210,10 @@  discard block
 block discarded – undo
193 210
     </td>";
194 211
 }
195 212
 
213
+/**
214
+ * @param integer $t
215
+ * @param integer $w
216
+ */
196 217
 function score_graph($t, $w) {
197 218
     if ($t == 0) return "<td>---</td>";
198 219
     $x = $t*$w;
Please login to merge, or discard this patch.
Spacing   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -89,10 +89,10 @@  discard block
 block discarded – undo
89 89
         $n++;
90 90
         $delta = $x - $m;
91 91
         $m += $delta/$n;
92
-        $m2 += $delta*($x-$m);
92
+        $m2 += $delta*($x - $m);
93 93
     }
94 94
     $mean = $m;
95
-    $stdev = sqrt($m2/($n-1));
95
+    $stdev = sqrt($m2/($n - 1));
96 96
 }
97 97
 
98 98
 // approximate the 90% confidence interval for the mean of an array
@@ -103,13 +103,13 @@  discard block
 block discarded – undo
103 103
 
104 104
     // I'm too lazy to compute the t distribution
105 105
     $t_90 = 1.7;
106
-    $d = $t_90 * $stdev / sqrt($n);
106
+    $d = $t_90*$stdev/sqrt($n);
107 107
     $lo = $mean - $d;
108 108
     $hi = $mean + $d;
109 109
 }
110 110
 
111 111
 function test_stats() {
112
-    $a = array(1,1,1,1,0,1,1,1,3, 1, 1, 1, 1);
112
+    $a = array(1, 1, 1, 1, 0, 1, 1, 1, 3, 1, 1, 1, 1);
113 113
     mean_stdev($a, $mean, $stdev);
114 114
     echo "mean: $mean stdev: $stdev\n";
115 115
     conf_int_90($a, $lo, $hi);
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
 
121 121
 function compare_bar($title, $n, $width, $lo, $hi) {
122 122
     $x1 = $width*$lo;
123
-    $x2 = $width*($hi-$lo);
123
+    $x2 = $width*($hi - $lo);
124 124
     $a1 = number_format($lo*100);
125 125
     $a2 = number_format($hi*100);
126 126
     return "
@@ -151,12 +151,12 @@  discard block
 block discarded – undo
151 151
 }
152 152
 
153 153
 function outcome_graph($x, $width) {
154
-    $n = $x[0]+$x[1]+$x[2];
154
+    $n = $x[0] + $x[1] + $x[2];
155 155
     if (!$n) return empty_cell();
156 156
     $x0 = $width*$x[1]/$n;
157 157
     $x1 = $width*$x[0]/$n;
158 158
     $x2 = $width*$x[2]/$n;
159
-    if ($x[1]/$n>0.05) {
159
+    if ($x[1]/$n > 0.05) {
160 160
         $t0 = number_format(100*$x[1]/$n)."%";
161 161
     } else {
162 162
         $t0 = "";
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
 
185 185
 function time_graph($t, $w) {
186 186
     if ($t == 0) return "<td>---</td>";
187
-    $x = (log10($t)+2)*$w/4;
187
+    $x = (log10($t) + 2)*$w/4;
188 188
     $t = number_format($t, 1);
189 189
     return "<td>
190 190
         <table class=bolt_bar><tr>
@@ -196,7 +196,7 @@  discard block
 block discarded – undo
196 196
 function score_graph($t, $w) {
197 197
     if ($t == 0) return "<td>---</td>";
198 198
     $x = $t*$w;
199
-    $y = (1-$t)*$w;
199
+    $y = (1 - $t)*$w;
200 200
     $t = number_format($t*100);
201 201
     $s = "<td>
202 202
         <table class=bolt_bar><tr>
Please login to merge, or discard this patch.