get_inputs() - Code Metrics - Inspection of "Merge pull request #6378 from BOINC/dpa_json_form" - BOINC/boinc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 03d969...bf76ef )

by Vitalii

created 2025-06-10 11:34 UTC

get_inputs() B

↳ Parent: Project

Complexity

Conditions	10
Paths	17

Size

Total Lines	28
Code Lines	24

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	10
eloc	24
c	1
b	0
f	1
nc	17
nop	1
dl	0
loc	28
rs	7.6666

How to fix Complexity

<?php

// the following functions return a [value, errmsg] pair.
// The errmsg is null if no error

function get_num($field) {
    $x = get_str($field->name);
    if ($field->type == 'integer') {
        if (filter_var($x, FILTER_VALIDATE_INT) === false) {
            return [null, 'not an integer'];
        }
        $x = intval($x);
    } else {
        if (filter_var($x, FILTER_VALIDATE_FLOAT) === false) {
            return [null, 'not a float'];
        }
        $x = floatval($x);
    }
    if (isset($field->min_value)) {
        if ($x < $field->min_value) {
            return [null, 'value is less than min'];
        }
    }
    if (isset($field->max_value)) {
        if ($x > $field->max_value) {
            return [null, 'value is greater than max'];
        }
    }
    return [$x, null];
}

function get_multi($field) {
    $x = get_array($field->name);
    $n = count($x);
    if (isset($field->min_items)) {
        if ($n < $field->min_items) {
            return [null, 'too few items selected'];
        }
    }
    if (isset($field->max_items)) {
        if ($n > $field->max_items) {
            return [null, 'too many items selected'];
        }
    }
    return [$x, null];
}

// returns either
// - an object containing the field values, or
// - a list of [title, errmsg] pairs
//
function get_inputs($form_desc) {
    $vals = new StdClass;
    $errs = [];
    foreach ($form_desc->fields as $field) {
        switch ($field->type) {
        case 'text':
        case 'select':
        case 'file_select':
            $err = null;
            $val = get_str($field->name);
            break;
        case 'integer':
        case 'float':
            [$val, $err] = get_num($field);
            break;
        case 'select_multi':
        case 'file_select_multi':
            [$val, $err] = get_multi($field);
            break;
        }
        if ($err) {

            $errs[] = [$field->title, $err];
        } else {
            $x = $field->name;
            $vals->$x = $val;

        }
    }
    return [$vals, $errs];
}

?>


1			<?php
2
3			// the following functions return a [value, errmsg] pair.
4			// The errmsg is null if no error
5
6			function get_num($field) {
7			$x = get_str($field->name);
8			if ($field->type == 'integer') {
9			if (filter_var($x, FILTER_VALIDATE_INT) === false) {
10			return [null, 'not an integer'];
11			}
12			$x = intval($x);
13			} else {
14			if (filter_var($x, FILTER_VALIDATE_FLOAT) === false) {
15			return [null, 'not a float'];
16			}
17			$x = floatval($x);
18			}
19			if (isset($field->min_value)) {
20			if ($x < $field->min_value) {
21			return [null, 'value is less than min'];
22			}
23			}
24			if (isset($field->max_value)) {
25			if ($x > $field->max_value) {
26			return [null, 'value is greater than max'];
27			}
28			}
29			return [$x, null];
30			}
31
32			function get_multi($field) {
33			$x = get_array($field->name);
34			$n = count($x);
35			if (isset($field->min_items)) {
36			if ($n < $field->min_items) {
37			return [null, 'too few items selected'];
38			}
39			}
40			if (isset($field->max_items)) {
41			if ($n > $field->max_items) {
42			return [null, 'too many items selected'];
43			}
44			}
45			return [$x, null];
46			}
47
48			// returns either
49			// - an object containing the field values, or
50			// - a list of [title, errmsg] pairs
51			//
52			function get_inputs($form_desc) {
53			$vals = new StdClass;
54			$errs = [];
55			foreach ($form_desc->fields as $field) {
56			switch ($field->type) {
57			case 'text':
58			case 'select':
59			case 'file_select':
60			$err = null;
61			$val = get_str($field->name);
62			break;
63			case 'integer':
64			case 'float':
65			[$val, $err] = get_num($field);
66			break;
67			case 'select_multi':
68			case 'file_select_multi':
69			[$val, $err] = get_multi($field);
70			break;
71			}
72			if ($err) {
			0 ignored issues – show Comprehensibility Best Practice introduced 2025-06-09 04:28 UTC by Report Bug Copy Issue Report The variable `$err` does not seem to be defined for all execution paths leading up to this point. Loading history...
73			$errs[] = [$field->title, $err];
74			} else {
75			$x = $field->name;
76			$vals->$x = $val;
			0 ignored issues – show Comprehensibility Best Practice introduced 2025-06-09 04:28 UTC by Report Bug Copy Issue Report The variable `$val` does not seem to be defined for all execution paths leading up to this point. Loading history...
77			}
78			}
79			return [$vals, $errs];
80			}
81
82			?>
83

BOINC / boinc

Push — master ( 03d969...bf76ef )

get_inputs() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like