form() - Code Metrics - Inspection of "Merge pull request #6378 from BOINC/dpa_json_form" - BOINC/boinc - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 03d969...bf76ef )

by Vitalii

created 2025-06-10 11:34 UTC

form() B

↳ Parent: Project

Complexity

Conditions	11
Paths	20

Size

Total Lines	43
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
cc	11
eloc	37
c	1
b	0
f	1
nc	20
nop	2
dl	0
loc	43
rs	7.3166

How to fix Complexity

<?php

// generate a form from a JSON spec

require_once('../inc/util.inc');
require_once('../inc/sandbox.inc');

function sb_file_select($user, $suffix=null) {
    $sbfiles = sandbox_file_names($user);
    $sbitems = [];
    $exp = null;
    if ($suffix) {
        $exp = sprintf('/%s$/', $suffix);
    }
    foreach ($sbfiles as $f) {
        if ($exp && !preg_match($exp, $f)) continue;
        $sbitems[] = [$f, $f];
    }
    return $sbitems;
}

function form($user, $json_fname) {
    $form_desc = json_decode(file_get_contents($json_fname));
    if (!$form_desc) {
        error_page('parse error in JSON file');
    }
    page_head_select2($form_desc->title);
    form_start($form_desc->handler);
    foreach ($form_desc->fields as $field) {
        switch ($field->type) {
        case 'text':
        case 'integer':
        case 'float':
            form_input_text($field->title, $field->name);
            break;
        case 'file_select':
            $items = sb_file_select($user, $field->suffix);
            form_select($field->title, $field->name, $items);
            break;
        case 'file_select_multi':
            $items = sb_file_select($user, $field->suffix);
            form_select2_multi(
                $field->title, $field->name, $items, null, "id=$field->name"
            );
            break;
        case 'select':
            form_select($field->title, $field->name, $field->items);
            break;
        case 'select_multi':
            form_select2_multi(
                $field->title, $field->name, $field->items,
                null, "id=$field->name"
            );
            break;
        default:

            echo "unknown field type $field->type";
            exit;

        case 'radio':

            break;
        }
    }
    form_submit('OK');
    form_end();
    page_tail();
}

$json_fname = get_str('json_fname');
if (!is_valid_filename($json_fname)) {
    error_page('filename');
}
$user = get_logged_in_user();
class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
$object = $a->getObject();
form($user, $json_fname);
?>


1			<?php
2
3			// generate a form from a JSON spec
4
5			require_once('../inc/util.inc');
6			require_once('../inc/sandbox.inc');
7
8			function sb_file_select($user, $suffix=null) {
9			$sbfiles = sandbox_file_names($user);
10			$sbitems = [];
11			$exp = null;
12			if ($suffix) {
13			$exp = sprintf('/%s$/', $suffix);
14			}
15			foreach ($sbfiles as $f) {
16			if ($exp && !preg_match($exp, $f)) continue;
17			$sbitems[] = [$f, $f];
18			}
19			return $sbitems;
20			}
21
22			function form($user, $json_fname) {
23			$form_desc = json_decode(file_get_contents($json_fname));
24			if (!$form_desc) {
25			error_page('parse error in JSON file');
26			}
27			page_head_select2($form_desc->title);
28			form_start($form_desc->handler);
29			foreach ($form_desc->fields as $field) {
30			switch ($field->type) {
31			case 'text':
32			case 'integer':
33			case 'float':
34			form_input_text($field->title, $field->name);
35			break;
36			case 'file_select':
37			$items = sb_file_select($user, $field->suffix);
38			form_select($field->title, $field->name, $items);
39			break;
40			case 'file_select_multi':
41			$items = sb_file_select($user, $field->suffix);
42			form_select2_multi(
43			$field->title, $field->name, $items, null, "id=$field->name"
44			);
45			break;
46			case 'select':
47			form_select($field->title, $field->name, $field->items);
48			break;
49			case 'select_multi':
50			form_select2_multi(
51			$field->title, $field->name, $field->items,
52			null, "id=$field->name"
53			);
54			break;
55			default:
			0 ignored issues – show Coding Style introduced 2025-06-09 07:38 UTC by Report Bug Copy Issue Report DEFAULT keyword must be indented 4 spaces from SWITCH keyword Loading history...
56			echo "unknown field type $field->type";
57			exit;
			0 ignored issues – show Best Practice introduced 2025-06-09 07:38 UTC by Report Bug Copy Issue Report Using `exit` here is not recommended. In general, usage of exit should be done with care and only when running in a scripting context like a CLI script. Loading history...
58			case 'radio':
			0 ignored issues – show Coding Style introduced 2025-06-09 04:28 UTC by Report Bug Copy Issue Report Empty CASE statements are not allowed Loading history...
59			break;
60			}
61			}
62			form_submit('OK');
63			form_end();
64			page_tail();
65			}
66
67			$json_fname = get_str('json_fname');
68			if (!is_valid_filename($json_fname)) {
69			error_page('filename');
70			}
71			$user = get_logged_in_user();
			0 ignored issues – show Bug introduced 2025-06-09 04:28 UTC by Report Bug Copy Issue Report Are you sure the assignment to `$user` is correct as `get_logged_in_user()` seems to always return `null`. This check looks for function or method calls that always return null and whose return value is assigned to a variable. class A { function getObject() { return null; } } $a = new A(); $object = $a->getObject(); The method `getObject()` can return nothing but null, so it makes no sense to assign that value to a variable. The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes. Loading history...
72			form($user, $json_fname);
73			?>
74

BOINC / boinc

Push — master ( 03d969...bf76ef )

form() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like