Passed
Pull Request — master (#3312)
by David
06:57
created
html/ops/update_forum_activities.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@
 block discarded – undo
40 40
     }
41 41
     if ($is_helpdesk) {
42 42
         $diff = ($now - $thread->create_time)/86400;
43
-        $activity = ($thread->sufferers+1)/$diff;
43
+        $activity = ($thread->sufferers + 1)/$diff;
44 44
         echo "thread $thread->id helpdesk $diff $activity\n";
45 45
     } else {
46 46
         $posts = BoincPost::enum("thread=$thread->id");
Please login to merge, or discard this patch.
html/ops/sample_table_stats.php 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -26,25 +26,25 @@
 block discarded – undo
26 26
     row_array(array("Name", "Engine", "Version", "Row Format", "Rows", "Avg Row Length (KB)", "Data Length (MB)", "Max Data Length (MB)", "Index Length (MB)", "Data free (MB)", "Create Time", "Update Time", "Check Time", "Create Options", "Comment"));
27 27
     _mysql_select_db($db);
28 28
     $result = _mysql_query("show table status");
29
-    while($row = _mysql_fetch_array($result)) {
29
+    while ($row = _mysql_fetch_array($result)) {
30 30
         $size += ($row["Data_length"] + $row["Index_length"]);
31 31
         $engine = $row["Engine"];
32 32
         if (!$engine) $engine = $row["Type"];
33 33
         row_array(array(
34 34
             $row["Name"],
35 35
             $engine,
36
-            $row["Version"] ,
37
-            $row["Row_format"] ,
38
-            $row["Rows"] ,
39
-            round($row["Avg_row_length"]/1024,2) ,
40
-            round($row["Data_length"]/(1024*1024),2) ,
41
-            round($row["Max_data_length"]/(1024*1024),2) ,
42
-            round($row["Index_length"]/(1024*1024),2) ,
43
-            round($row["Data_free"]/(1024*1024),2) ,
44
-            $row["Create_time"] ,
45
-            $row["Update_time"] ,
46
-            $row["Check_time"] ,
47
-            $row["Create_options"] ,
36
+            $row["Version"],
37
+            $row["Row_format"],
38
+            $row["Rows"],
39
+            round($row["Avg_row_length"]/1024, 2),
40
+            round($row["Data_length"]/(1024*1024), 2),
41
+            round($row["Max_data_length"]/(1024*1024), 2),
42
+            round($row["Index_length"]/(1024*1024), 2),
43
+            round($row["Data_free"]/(1024*1024), 2),
44
+            $row["Create_time"],
45
+            $row["Update_time"],
46
+            $row["Check_time"],
47
+            $row["Create_options"],
48 48
             $row["Comment"]
49 49
         ));
50 50
     }
Please login to merge, or discard this patch.
html/ops/bolt_compare.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,9 +122,9 @@
 block discarded – undo
122 122
         <input type=hidden name=xset_name value=\"$xset_name\">
123 123
         <table width=600><tr><td>
124 124
     ";
125
-    filter_form($filter?$filter->name():"", $filter_cat);
125
+    filter_form($filter ? $filter->name() : "", $filter_cat);
126 126
     echo "</td><td>";
127
-    breakdown_form($breakdown?$breakdown->name():"");
127
+    breakdown_form($breakdown ? $breakdown->name() : "");
128 128
     echo "
129 129
         </td></tr></table>
130 130
         <p>
Please login to merge, or discard this patch.
html/ops/bossa_example4_make_jobs.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -55,7 +55,7 @@
 block discarded – undo
55 55
     exit("Usage: bossa_example4_make_jobs.php --dir d\n");
56 56
 }
57 57
 
58
-for ($i=1; $i<$argc; $i++) {
58
+for ($i = 1; $i < $argc; $i++) {
59 59
     if ($argv[$i] == '--dir') $dir = $argv[++$i];
60 60
     else usage();
61 61
 }
Please login to merge, or discard this patch.
html/ops/db_cleanse.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
     $n = 0;
52 52
     while (1) {
53 53
         $n++;
54
-        if ($n % 1000 == 0) echo "$n\n";
54
+        if ($n%1000 == 0) echo "$n\n";
55 55
         $x = fgets($fres);
56 56
         if (!$x) break;
57 57
         list($reswuid, $resid) = sscanf($x, "%d %d");
Please login to merge, or discard this patch.
html/ops/profile_screen_action.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
 db_init();
25 25
 
26 26
 admin_page_head("screen profile action");
27
-for ($i=0; $i<$n; $i++) {
27
+for ($i = 0; $i < $n; $i++) {
28 28
     $y = "user".$i;
29 29
     $val = $_GET[$y];
30 30
     $x = "userid".$i;
@@ -51,5 +51,5 @@  discard block
 block discarded – undo
51 51
 
52 52
 admin_page_tail();
53 53
 
54
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
54
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
55 55
 ?>
Please login to merge, or discard this patch.
html/ops/nvidia.php 2 patches
Indentation   +80 added lines, -80 removed lines patch added patch discarded remove patch
@@ -68,93 +68,93 @@
 block discarded – undo
68 68
 }
69 69
 
70 70
 function analyze_nvidia() {
71
-	$hosts_total = 0;     // number of hosts 6.2 or better
72
-	$hosts_gpu = 0;     // number with an nvidia gpu
73
-	$rac_total =0;
74
-	$rac_gpu = 0;
75
-	$linux_total = 0;
76
-	$linux_gpus = 0;
77
-	$windows_total = 0;
78
-	$windows_gpus = 0;
79
-	$model = array();   // name -> count
80
-	$ram = array();     // size -> count
81
-	$driver = array();  // vers -> count
82
-	$ngpus = array();   // ngpus -> count
71
+    $hosts_total = 0;     // number of hosts 6.2 or better
72
+    $hosts_gpu = 0;     // number with an nvidia gpu
73
+    $rac_total =0;
74
+    $rac_gpu = 0;
75
+    $linux_total = 0;
76
+    $linux_gpus = 0;
77
+    $windows_total = 0;
78
+    $windows_gpus = 0;
79
+    $model = array();   // name -> count
80
+    $ram = array();     // size -> count
81
+    $driver = array();  // vers -> count
82
+    $ngpus = array();   // ngpus -> count
83 83
 
84
-	$hosts = BoincHost::enum("expavg_credit > 10 and serialnum<>''");
85
-	foreach($hosts as $host) {
86
-		$boinc_vers = parse_vers($host->serialnum);
87
-		if (!$boinc_vers) continue;
88
-		if ($boinc_vers->major < 6) continue;
89
-		$is_linux = false;
90
-		if (strstr($host->os_name, "Linux")) {
91
-			$linux_total++;
92
-			$is_linux = true;
93
-		} else if (strstr($host->os_name, "Windows")) {
94
-			$windows_total++;
95
-		} else {
96
-			continue;
97
-		}
98
-		$hosts_total++;
99
-		$rac_total += $host->expavg_credit;
100
-		$gpu = parse_cuda($host->serialnum);
101
-		if (!$gpu) {
102
-			continue;
103
-		}
104
-		$hosts_gpu++;
105
-		$rac_gpu += $host->expavg_credit;
106
-		if ($is_linux) {
107
-			$linux_gpus++;
108
-		} else {
109
-			$windows_gpus++;
110
-		}
111
-		inc($model, $gpu->model);
112
-		inc($ram, $gpu->ram);
113
-		inc($driver, $gpu->driver);
114
-		inc($ngpus, $gpu->ngpus);
115
-	}
84
+    $hosts = BoincHost::enum("expavg_credit > 10 and serialnum<>''");
85
+    foreach($hosts as $host) {
86
+        $boinc_vers = parse_vers($host->serialnum);
87
+        if (!$boinc_vers) continue;
88
+        if ($boinc_vers->major < 6) continue;
89
+        $is_linux = false;
90
+        if (strstr($host->os_name, "Linux")) {
91
+            $linux_total++;
92
+            $is_linux = true;
93
+        } else if (strstr($host->os_name, "Windows")) {
94
+            $windows_total++;
95
+        } else {
96
+            continue;
97
+        }
98
+        $hosts_total++;
99
+        $rac_total += $host->expavg_credit;
100
+        $gpu = parse_cuda($host->serialnum);
101
+        if (!$gpu) {
102
+            continue;
103
+        }
104
+        $hosts_gpu++;
105
+        $rac_gpu += $host->expavg_credit;
106
+        if ($is_linux) {
107
+            $linux_gpus++;
108
+        } else {
109
+            $windows_gpus++;
110
+        }
111
+        inc($model, $gpu->model);
112
+        inc($ram, $gpu->ram);
113
+        inc($driver, $gpu->driver);
114
+        inc($ngpus, $gpu->ngpus);
115
+    }
116 116
 
117
-	$pct = 100*($hosts_gpu/$hosts_total);
118
-	echo "ntotal: $hosts_total   ngpus: $hosts_gpu ($pct %)\n";
119
-	$pct = 100*($windows_gpus/$windows_total);
120
-	echo "Windows: total $windows_total gpus $windows_gpus ($pct %)\n";
121
-	$pct = 100*($linux_gpus/$linux_total);
122
-	echo "Linux: total $linux_total gpus $linux_gpus ($pct %)\n";
117
+    $pct = 100*($hosts_gpu/$hosts_total);
118
+    echo "ntotal: $hosts_total   ngpus: $hosts_gpu ($pct %)\n";
119
+    $pct = 100*($windows_gpus/$windows_total);
120
+    echo "Windows: total $windows_total gpus $windows_gpus ($pct %)\n";
121
+    $pct = 100*($linux_gpus/$linux_total);
122
+    echo "Linux: total $linux_total gpus $linux_gpus ($pct %)\n";
123 123
 
124
-	$rac_non_gpu = $rac_total - $rac_gpu;
125
-	$hosts_non_gpu = $hosts_total - $hosts_gpu;
126
-	$a = $rac_gpu/$hosts_gpu;
127
-	$b = $rac_non_gpu/$hosts_non_gpu;
128
-	echo "Avg RAC: GPU: $a non-GPU: $b\n";
124
+    $rac_non_gpu = $rac_total - $rac_gpu;
125
+    $hosts_non_gpu = $hosts_total - $hosts_gpu;
126
+    $a = $rac_gpu/$hosts_gpu;
127
+    $b = $rac_non_gpu/$hosts_non_gpu;
128
+    echo "Avg RAC: GPU: $a non-GPU: $b\n";
129 129
 
130
-	arsort($model);
131
-	foreach($model as $m=>$c) {
132
-		echo "$m $c\n";
133
-	}
134
-	print_r($ram);
135
-	print_r($driver);
136
-	print_r($ngpus);
130
+    arsort($model);
131
+    foreach($model as $m=>$c) {
132
+        echo "$m $c\n";
133
+    }
134
+    print_r($ram);
135
+    print_r($driver);
136
+    print_r($ngpus);
137 137
 }
138 138
 
139 139
 function analyze_all() {
140
-	$total = 0;
141
-	$nnv = 0;
142
-	$nati = 0;
143
-	$nboth = 0;
144
-	$hosts = BoincHost::enum("expavg_credit > 10 and serialnum<>''");
145
-	foreach($hosts as $host) {
146
-		$boinc_vers = parse_vers($host->serialnum);
147
-		if (!$boinc_vers) continue;
148
-		if ($boinc_vers->major < 6) continue;
149
-		if ($boinc_vers->major == 6 && $boinc_vers->minor < 10) continue;
150
-		$total++;
151
-		$has_nv = strstr($host->serialnum, 'CUDA');
152
-		$has_ati = strstr($host->serialnum, 'ATI');
153
-		if ($has_nv) $nnv++;
154
-		if ($has_ati) $nati++;
155
-		if ($has_nv && $has_ati) $nboth++;
156
-	}
157
-	echo "total: $total NVIDIA: $nnv ATI: $nati both: $nboth\n";
140
+    $total = 0;
141
+    $nnv = 0;
142
+    $nati = 0;
143
+    $nboth = 0;
144
+    $hosts = BoincHost::enum("expavg_credit > 10 and serialnum<>''");
145
+    foreach($hosts as $host) {
146
+        $boinc_vers = parse_vers($host->serialnum);
147
+        if (!$boinc_vers) continue;
148
+        if ($boinc_vers->major < 6) continue;
149
+        if ($boinc_vers->major == 6 && $boinc_vers->minor < 10) continue;
150
+        $total++;
151
+        $has_nv = strstr($host->serialnum, 'CUDA');
152
+        $has_ati = strstr($host->serialnum, 'ATI');
153
+        if ($has_nv) $nnv++;
154
+        if ($has_ati) $nati++;
155
+        if ($has_nv && $has_ati) $nboth++;
156
+    }
157
+    echo "total: $total NVIDIA: $nnv ATI: $nati both: $nboth\n";
158 158
 }
159 159
 
160 160
 analyze_all();
Please login to merge, or discard this patch.
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 $cli_only = true;
22 22
 require_once("../inc/util_ops.inc");
23 23
 
24
-ini_set ("memory_limit", "8000M");
24
+ini_set("memory_limit", "8000M");
25 25
 set_time_limit(0);
26 26
 
27 27
 error_reporting(E_ALL);
@@ -68,21 +68,21 @@  discard block
 block discarded – undo
68 68
 }
69 69
 
70 70
 function analyze_nvidia() {
71
-	$hosts_total = 0;     // number of hosts 6.2 or better
72
-	$hosts_gpu = 0;     // number with an nvidia gpu
73
-	$rac_total =0;
71
+	$hosts_total = 0; // number of hosts 6.2 or better
72
+	$hosts_gpu = 0; // number with an nvidia gpu
73
+	$rac_total = 0;
74 74
 	$rac_gpu = 0;
75 75
 	$linux_total = 0;
76 76
 	$linux_gpus = 0;
77 77
 	$windows_total = 0;
78 78
 	$windows_gpus = 0;
79
-	$model = array();   // name -> count
80
-	$ram = array();     // size -> count
81
-	$driver = array();  // vers -> count
82
-	$ngpus = array();   // ngpus -> count
79
+	$model = array(); // name -> count
80
+	$ram = array(); // size -> count
81
+	$driver = array(); // vers -> count
82
+	$ngpus = array(); // ngpus -> count
83 83
 
84 84
 	$hosts = BoincHost::enum("expavg_credit > 10 and serialnum<>''");
85
-	foreach($hosts as $host) {
85
+	foreach ($hosts as $host) {
86 86
 		$boinc_vers = parse_vers($host->serialnum);
87 87
 		if (!$boinc_vers) continue;
88 88
 		if ($boinc_vers->major < 6) continue;
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 	echo "Avg RAC: GPU: $a non-GPU: $b\n";
129 129
 
130 130
 	arsort($model);
131
-	foreach($model as $m=>$c) {
131
+	foreach ($model as $m=>$c) {
132 132
 		echo "$m $c\n";
133 133
 	}
134 134
 	print_r($ram);
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 	$nati = 0;
143 143
 	$nboth = 0;
144 144
 	$hosts = BoincHost::enum("expavg_credit > 10 and serialnum<>''");
145
-	foreach($hosts as $host) {
145
+	foreach ($hosts as $host) {
146 146
 		$boinc_vers = parse_vers($host->serialnum);
147 147
 		if (!$boinc_vers) continue;
148 148
 		if ($boinc_vers->major < 6) continue;
Please login to merge, or discard this patch.
html/ops/app_details.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
     row2("Plan class", $av->plan_class);
52 52
     row2("Version num", $av->version_num);
53 53
     row2("Jobs validated", $av->pfc_n);
54
-    row2("Average efficiency", $av->pfc_avg?1/$av->pfc_avg:"---");
54
+    row2("Average efficiency", $av->pfc_avg ? 1/$av->pfc_avg : "---");
55 55
     row2("Credit scale factor", $av->pfc_scale);
56 56
     row2("Average credit", $av->expavg_credit);
57 57
     end_table();
Please login to merge, or discard this patch.
html/ops/manage_app_versions.php 2 patches
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
       "deprecated?",
73 73
       ""
74 74
     );
75
-    $clause = $all?"true":"deprecated = 0";
75
+    $clause = $all ? "true" : "deprecated = 0";
76 76
     $avs = BoincAppVersion::enum(
77 77
         "$clause order by appid, platformid, plan_class, version_num"
78 78
     );
@@ -80,20 +80,20 @@  discard block
 block discarded – undo
80 80
     foreach ($avs as $av) {
81 81
         // grey out deprecated versions 
82 82
         //
83
-        $f1=$f2='';
83
+        $f1 = $f2 = '';
84 84
         if ($av->deprecated == 1) {
85
-            $f1="<font color='GREY'>";
86
-            $f2="</font>";
85
+            $f1 = "<font color='GREY'>";
86
+            $f2 = "</font>";
87 87
         }
88 88
 
89
-        $all_value = $all?1:0;
89
+        $all_value = $all ? 1 : 0;
90 90
         $app = $apps[$av->appid];
91 91
         // ignore app versions of deprecated apps by default
92 92
         if ($all_value == 0 && $app->deprecated == 1) {
93 93
             continue;
94 94
         }
95 95
         echo "<tr class=row$i><form action=manage_app_versions.php?all=$all_value#av_$av->id method=POST>\n";
96
-        $i = 1-$i;
96
+        $i = 1 - $i;
97 97
         echo "<input type=hidden name=id value=$av->id>";
98 98
         echo "  <TD>$f1 <a id='av_$av->id' href=db_action.php?table=app_version&id=$av->id>$av->id</a> $f2</TD>\n";
99 99
 
@@ -110,15 +110,15 @@  discard block
 block discarded – undo
110 110
         $v = $av->min_core_version;
111 111
         echo "  <TD><input type='text' size='4' name=min_core_version value='$v'></TD>\n";
112 112
 
113
-        $v=$av->max_core_version;
113
+        $v = $av->max_core_version;
114 114
         echo "  <TD><input type='text' size='4' name=max_core_version value='$v'></TD>\n";
115 115
 
116
-        $v='';
117
-        if ($av->beta) $v=' CHECKED ';
116
+        $v = '';
117
+        if ($av->beta) $v = ' CHECKED ';
118 118
         echo "  <TD> <input name=beta type='checkbox' $v></TD>\n";
119 119
 
120
-        $v='';
121
-        if ($av->deprecated) $v=' CHECKED ';
120
+        $v = '';
121
+        if ($av->deprecated) $v = ' CHECKED ';
122 122
         echo "  <TD> <input name=deprecated type='checkbox' $v></TD>\n";
123 123
 
124 124
         if (!in_rops()) {
Please login to merge, or discard this patch.
Indentation   +9 added lines, -9 removed lines patch added patch discarded remove patch
@@ -62,15 +62,15 @@
 block discarded – undo
62 62
     start_table("");
63 63
     table_header(
64 64
         "ID #<br><small>click for details</small>",
65
-      "Application<br><small>click for details</small>",
66
-      "Version",
67
-      "Platform",
68
-      "Plan class",
69
-      "minimum<br>client version",
70
-      "maximum<br>client version",
71
-      "beta?",
72
-      "deprecated?",
73
-      ""
65
+        "Application<br><small>click for details</small>",
66
+        "Version",
67
+        "Platform",
68
+        "Plan class",
69
+        "minimum<br>client version",
70
+        "maximum<br>client version",
71
+        "beta?",
72
+        "deprecated?",
73
+        ""
74 74
     );
75 75
     $clause = $all?"true":"deprecated = 0";
76 76
     $avs = BoincAppVersion::enum(
Please login to merge, or discard this patch.