BOINC / boinc

html/user/forum_thread_status.php

Spacing +2 added lines, -2 removed lines

@@ -35,14 +35,14 @@
 }
 
 $owner = BoincUser::lookup_id($thread->owner);
-if ($logged_in_user->id == $owner->id){
+if ($logged_in_user->id == $owner->id) {
     $action = get_str("action");
     if ($action == "set") {
         $ret = $thread->update("status=1");
     } else {
         $ret = $thread->update("status=0");
     }
-    if (!$ret){
+    if (!$ret) {
         error_page("Could not update the status of the thread: ".$thread->id);
     }
 } else {

Braces +2 added lines, -2 removed lines

@@ -35,14 +35,14 @@
 }
 
 $owner = BoincUser::lookup_id($thread->owner);
-if ($logged_in_user->id == $owner->id){
+if ($logged_in_user->id == $owner->id) {
     $action = get_str("action");
     if ($action == "set") {
         $ret = $thread->update("status=1");
     } else {
         $ret = $thread->update("status=0");
     }
-    if (!$ret){
+    if (!$ret) {
         error_page("Could not update the status of the thread: ".$thread->id);
     }
 } else {

html/user/lammps.php

Indentation +14 added lines, -14 removed lines

@@ -35,7 +35,7 @@ 
     $ppid=$pstatus['pid'];
     $ret=`ps -o pid --no-heading --ppid $ppid`;
     //echo "parent pid is $ppid\nterninate it\n";
-     proc_terminate($p);
+        proc_terminate($p);
     // echo "child process is $ret\n";
     $pids=preg_split('/\s+/',$ret);
     foreach($pids as $pid){
@@ -61,9 +61,9 @@ 
     while (1) {
         $ctime=time();
         if($ctime-$stime >=2 and ! file_exists("log.1")){
-           if($GLOBALS["debug"]) echo "time out "."<br>";
-           terminate_job($p);
-           break;
+            if($GLOBALS["debug"]) echo "time out "."<br>";
+            terminate_job($p);
+            break;
         }
         if (file_exists("log.1")) {
             list($avg_cpu, $test_steps) = calc_step_cpu("log.1");
@@ -112,7 +112,7 @@ 
     }
     fclose($fd);
     //$total_steps = $loopno*$looprun;
-     if($GLOBALS["debug"])print "total_steps = ".$total_steps."<br>";
+        if($GLOBALS["debug"])print "total_steps = ".$total_steps."<br>";
     return $total_steps;
 }
 
@@ -147,12 +147,12 @@ 
         $cpu = (float)$arr[2];
         //echo "step=".$step." cpu=".$cpu."\n";
         if ($cpu==0) {
-           $count=0;
-           $start_step = $step;
+            $count=0;
+            $start_step = $step;
         } else {
             $count+=1;
             if($GLOBALS["debug"])echo "step=".$step." cpu=".$cpu."count=".$count."<br>";
-           if($count >= 10) {
+            if($count >= 10) {
                 $end_step = $step;
                 $steps = $end_step-$start_step;
                 $avg_cpu = $cpu/$steps;
@@ -183,7 +183,7 @@ 
 
         if(preg_match("/^\s*dump\s+(\d)\s+/", $line,$matches))
         {
-             if($GLOBALS["debug"]){print "matches=";print_r($matches);}
+                if($GLOBALS["debug"]){print "matches=";print_r($matches);}
 
             $dump_types=(int)$matches[1];
             break;
@@ -198,7 +198,7 @@ 
         echo "can not open file $cmd_file\n";
         exit(-1);
     }
-     if($GLOBALS["debug"]) print "structure_file_size=".$structure_file_size."<br>";
+        if($GLOBALS["debug"]) print "structure_file_size=".$structure_file_size."<br>";
 
     $loopno=1;
     $looprun=1;
@@ -216,8 +216,8 @@ 
     }
     fclose($fd);
     if($GLOBALS["debug"]){
-         print "max loopno(number of loops to run)=".$loopno."<br>";
-         print "max looprun(steps for each loop)=".$looprun."<br>";
+            print "max loopno(number of loops to run)=".$loopno."<br>";
+            print "max looprun(steps for each loop)=".$looprun."<br>";
     }
     //$est_size = $loopno*$structure_file_size*0.8*$dump_types;
     $test_log_size = filesize("log.1");
@@ -368,7 +368,7 @@ 
             <br>Please refer to the following Error Message:<br><p>
         ";
         foreach($err_msgs as $line){
-             $err=$err.$line."<br>";
+                $err=$err.$line."<br>";
         }
         $err=$err." <p>
             <a href=sandbox.php><strong> File_Sandbox </strong></a>
@@ -393,7 +393,7 @@ 
     //
     $njobs = count(file($cmdline_file_path));
     $secs_est = estimated_makespan($njobs, $info->rsc_fpops_est);
-     if($GLOBALS["debug"])echo "secs_est is $secs_est\n";
+        if($GLOBALS["debug"])echo "secs_est is $secs_est\n";
     //assume the server's flops is 1.5G and the average client's flops is 1G
     $hrs_est = number_format($secs_est*1.5/60, 2);
     //$hrs_est = number_format($secs_est, 2);

Braces +19 added lines, -20 removed lines

@@ -38,8 +38,8 @@ 
      proc_terminate($p);
     // echo "child process is $ret\n";
     $pids=preg_split('/\s+/',$ret);
-    foreach($pids as $pid){
-        if(is_numeric($pid)){
+    foreach($pids as $pid) {
+        if(is_numeric($pid)) {
             if($GLOBALS["debug"])echo "killing child process $pid\n";
             posix_kill($pid,9);
         }
@@ -60,7 +60,7 @@ 
     $p = proc_open("$cmd", $descs, $pipes);
     while (1) {
         $ctime=time();
-        if($ctime-$stime >=2 and ! file_exists("log.1")){
+        if($ctime-$stime >=2 and ! file_exists("log.1")) {
            if($GLOBALS["debug"]) echo "time out "."<br>";
            terminate_job($p);
            break;
@@ -157,7 +157,7 @@ 
                 $steps = $end_step-$start_step;
                 $avg_cpu = $cpu/$steps;
                 #$avg_cpu = $cpu/$count;
-                if ($GLOBALS["debug"]){
+                if ($GLOBALS["debug"]) {
                     echo "test steps is ".$steps."<br>";
                     echo "avg_cpu is ".$avg_cpu."<br>";
                 }
@@ -169,20 +169,19 @@ 
     return array($avg_cpu,$test_steps);
 }
 
-function calc_est_size($lammps_script, $structure_file, $cmd_file,$test_steps){
+function calc_est_size($lammps_script, $structure_file, $cmd_file,$test_steps) {
     $dump_types = 0;
     $fd = fopen($lammps_script,"r");
-    if (!$fd){
+    if (!$fd) {
         echo "can not open file $lammps_script\n";
         exit(-1);
     }
-    while (!feof($fd)){
+    while (!feof($fd)) {
         $line = fgets($fd, 4096);
         //if (preg_match("/^\s*dump/", $line)
         //    and preg_match_all("/dump\S+\.\w{3}/", $line, $matches, PREG_PATTERN_ORDER))
 
-        if(preg_match("/^\s*dump\s+(\d)\s+/", $line,$matches))
-        {
+        if(preg_match("/^\s*dump\s+(\d)\s+/", $line,$matches)) {
              if($GLOBALS["debug"]){print "matches=";print_r($matches);}
 
             $dump_types=(int)$matches[1];
@@ -194,7 +193,7 @@ 
 
     $structure_file_size = filesize($structure_file);
     $fd = fopen($cmd_file,"r");
-    if (!$fd){
+    if (!$fd) {
         echo "can not open file $cmd_file\n";
         exit(-1);
     }
@@ -202,10 +201,10 @@ 
 
     $loopno=1;
     $looprun=1;
-    while (!feof($fd)){
+    while (!feof($fd)) {
         $line = fgets($fd,4096);
-        if(preg_match("/loopnumber\s+\d+/", $line, $matches)){
-            if(preg_match("/\d+/", $matches[0], $no)){
+        if(preg_match("/loopnumber\s+\d+/", $line, $matches)) {
+            if(preg_match("/\d+/", $matches[0], $no)) {
                 //$loopno=$no[0];
                 if($no[0]>$loopno)$loopno=$no[0];
             }
@@ -215,7 +214,7 @@ 
         }
     }
     fclose($fd);
-    if($GLOBALS["debug"]){
+    if($GLOBALS["debug"]) {
          print "max loopno(number of loops to run)=".$loopno."<br>";
          print "max looprun(steps for each loop)=".$looprun."<br>";
     }
@@ -231,7 +230,7 @@ 
     $app_fixed_size = 5e7;
     $est_size = $log_size+$dump_size+$app_fixed_size;
 
-    if($GLOBALS["debug"]){
+    if($GLOBALS["debug"]) {
         print "test_steps=".$test_steps."<br>";
         print "test_log_size=".$test_log_size."<br>";
         print "log_size1=".$log_size1."<br>";
@@ -367,7 +366,7 @@ 
         $err="Your test job <strong>failed</strong>
             <br>Please refer to the following Error Message:<br><p>
         ";
-        foreach($err_msgs as $line){
+        foreach($err_msgs as $line) {
              $err=$err.$line."<br>";
         }
         $err=$err." <p>
@@ -380,9 +379,9 @@ 
     $info->rsc_fpops_est = $est_cpu_time * 1.5e9;
     $info->rsc_fpops_bound = $info->rsc_fpops_est * 20;
 
-    if ($disk==0){
+    if ($disk==0) {
         $info->rsc_disk_bound=1000000;
-    } else{
+    } else {
         $info->rsc_disk_bound = $disk;
     }
 
@@ -444,7 +443,7 @@ 
 
     $njobs=0;
     $cmdlines = file($info->cmdline_file_path);
-    foreach ($cmdlines as $cmdline){
+    foreach ($cmdlines as $cmdline) {
         if (preg_match("/^\s*-var/", $cmdline)) {
             $njobs++;
         }
@@ -460,7 +459,7 @@ 
 
     $i = 0;
     foreach ($cmdlines as $cmdline) {
-        if (preg_match("/^\s*-var/", $cmdline)){
+        if (preg_match("/^\s*-var/", $cmdline)) {
             submit_job($app, $batch_id, $info, $cmdline, $i);
             $i++;
         }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -430,7 +430,7 @@
     //echo "<br> $cmd\n";
 
     system($cmd, $ret);
-    if ($ret === FALSE) {
+    if ($ret === false) {
         error_page("can't create job");
     } else {
         header('Location: submit.php');

Spacing +74 added lines, -74 removed lines

@@ -17,7 +17,7 @@ 
 
 display_errors();
 
-$debug=0;
+$debug = 0;
 
 // test a LAMMPS job
 //
@@ -30,17 +30,17 @@ 
 // output: success flag, CPU time per step, est. disk usage per job
 //
 function terminate_job($p) {
-    $pstatus=proc_get_status($p);
-    $ppid=$pstatus['pid'];
-    $ret=`ps -o pid --no-heading --ppid $ppid`;
+    $pstatus = proc_get_status($p);
+    $ppid = $pstatus['pid'];
+    $ret = `ps -o pid --no-heading --ppid $ppid`;
     //echo "parent pid is $ppid\nterninate it\n";
      proc_terminate($p);
     // echo "child process is $ret\n";
-    $pids=preg_split('/\s+/',$ret);
-    foreach($pids as $pid){
-        if(is_numeric($pid)){
-            if($GLOBALS["debug"])echo "killing child process $pid\n";
-            posix_kill($pid,9);
+    $pids = preg_split('/\s+/', $ret);
+    foreach ($pids as $pid) {
+        if (is_numeric($pid)) {
+            if ($GLOBALS["debug"])echo "killing child process $pid\n";
+            posix_kill($pid, 9);
         }
     }
 }
@@ -51,23 +51,23 @@ 
     $descs = array();
     $pipes = array();
     $options = file("cmd_variables");
-    $options[0] = chop($options[0],"\n");
+    $options[0] = chop($options[0], "\n");
     $cmd = "../lmp_linux ".$options[0]."&>output";
     if ($GLOBALS["debug"]) echo $cmd."<br>";
     system("unzip pot_files >/dev/null");
     $stime = time();
     $p = proc_open("$cmd", $descs, $pipes);
     while (1) {
-        $ctime=time();
-        if($ctime-$stime >=2 and ! file_exists("log.1")){
-           if($GLOBALS["debug"]) echo "time out "."<br>";
+        $ctime = time();
+        if ($ctime - $stime >= 2 and !file_exists("log.1")) {
+           if ($GLOBALS["debug"]) echo "time out "."<br>";
            terminate_job($p);
            break;
         }
         if (file_exists("log.1")) {
             list($avg_cpu, $test_steps) = calc_step_cpu("log.1");
             if ($avg_cpu != 0) {
-                if($GLOBALS["debug"])echo "avg_cpu is ".$avg_cpu."<br>";
+                if ($GLOBALS["debug"])echo "avg_cpu is ".$avg_cpu."<br>";
                 terminate_job($p);
                 $test_result = 1;
                 break;
@@ -86,32 +86,32 @@ 
 }
 
 function get_total_steps($cmd_file) {
-    $fd = fopen($cmd_file,"r");
+    $fd = fopen($cmd_file, "r");
     if (!$fd) {
         echo "can not open file $cmd_file\n";
         exit(-1);
     }
     $this_loopno = 1;
     $this_looprun = 1;
-    $total_steps=1;
+    $total_steps = 1;
     while (!feof($fd)) {
-        $line = fgets($fd,4096);
+        $line = fgets($fd, 4096);
         if (preg_match("/loopnumber\s+\d+/", $line, $matches)
             && preg_match("/\d+/", $matches[0], $no)
         ) {
-            $this_loopno=$no[0];
+            $this_loopno = $no[0];
         }
         if (preg_match("/looprun\s+\d+/", $line, $matches)
             and preg_match("/\d+/", $matches[0], $no)
         ) {
-            $this_looprun=$no[0];
-            if($this_loopno*$this_looprun>$total_steps)$total_steps=$this_loopno*$this_looprun;
+            $this_looprun = $no[0];
+            if ($this_loopno*$this_looprun > $total_steps)$total_steps = $this_loopno*$this_looprun;
         }
 
     }
     fclose($fd);
     //$total_steps = $loopno*$looprun;
-     if($GLOBALS["debug"])print "total_steps = ".$total_steps."<br>";
+     if ($GLOBALS["debug"])print "total_steps = ".$total_steps."<br>";
     return $total_steps;
 }
 
@@ -129,8 +129,8 @@ 
     }
     $count = 0;
     while (!feof($fd)) {
-        $line = fgets($fd,4096);
-        if (preg_match('/^Step\s+CPU/',$line)) {
+        $line = fgets($fd, 4096);
+        if (preg_match('/^Step\s+CPU/', $line)) {
             //echo $line."\n";
             $start = 1;
             continue;
@@ -139,24 +139,24 @@ 
         $arr = preg_split("/\s+/", $line);
         //print_r($arr);
 
-        if (count($arr) <=6 || !is_numeric($arr[1])) {
+        if (count($arr) <= 6 || !is_numeric($arr[1])) {
             continue;
         }
         $step = (int)$arr[1];
         $cpu = (float)$arr[2];
         //echo "step=".$step." cpu=".$cpu."\n";
-        if ($cpu==0) {
-           $count=0;
+        if ($cpu == 0) {
+           $count = 0;
            $start_step = $step;
         } else {
-            $count+=1;
-            if($GLOBALS["debug"])echo "step=".$step." cpu=".$cpu."count=".$count."<br>";
-           if($count >= 10) {
+            $count += 1;
+            if ($GLOBALS["debug"])echo "step=".$step." cpu=".$cpu."count=".$count."<br>";
+           if ($count >= 10) {
                 $end_step = $step;
-                $steps = $end_step-$start_step;
+                $steps = $end_step - $start_step;
                 $avg_cpu = $cpu/$steps;
                 #$avg_cpu = $cpu/$count;
-                if ($GLOBALS["debug"]){
+                if ($GLOBALS["debug"]) {
                     echo "test steps is ".$steps."<br>";
                     echo "avg_cpu is ".$avg_cpu."<br>";
                 }
@@ -165,56 +165,56 @@ 
             }
         }
     }
-    return array($avg_cpu,$test_steps);
+    return array($avg_cpu, $test_steps);
 }
 
-function calc_est_size($lammps_script, $structure_file, $cmd_file,$test_steps){
+function calc_est_size($lammps_script, $structure_file, $cmd_file, $test_steps) {
     $dump_types = 0;
-    $fd = fopen($lammps_script,"r");
-    if (!$fd){
+    $fd = fopen($lammps_script, "r");
+    if (!$fd) {
         echo "can not open file $lammps_script\n";
         exit(-1);
     }
-    while (!feof($fd)){
+    while (!feof($fd)) {
         $line = fgets($fd, 4096);
         //if (preg_match("/^\s*dump/", $line)
         //    and preg_match_all("/dump\S+\.\w{3}/", $line, $matches, PREG_PATTERN_ORDER))
 
-        if(preg_match("/^\s*dump\s+(\d)\s+/", $line,$matches))
+        if (preg_match("/^\s*dump\s+(\d)\s+/", $line, $matches))
         {
-             if($GLOBALS["debug"]){print "matches=";print_r($matches);}
+             if ($GLOBALS["debug"]) {print "matches="; print_r($matches); }
 
-            $dump_types=(int)$matches[1];
+            $dump_types = (int)$matches[1];
             break;
         }
     }
     fclose($fd);
-    if($GLOBALS["debug"])print "dump_types= ".$dump_types."<br>";
+    if ($GLOBALS["debug"])print "dump_types= ".$dump_types."<br>";
 
     $structure_file_size = filesize($structure_file);
-    $fd = fopen($cmd_file,"r");
-    if (!$fd){
+    $fd = fopen($cmd_file, "r");
+    if (!$fd) {
         echo "can not open file $cmd_file\n";
         exit(-1);
     }
-     if($GLOBALS["debug"]) print "structure_file_size=".$structure_file_size."<br>";
-
-    $loopno=1;
-    $looprun=1;
-    while (!feof($fd)){
-        $line = fgets($fd,4096);
-        if(preg_match("/loopnumber\s+\d+/", $line, $matches)){
-            if(preg_match("/\d+/", $matches[0], $no)){
+     if ($GLOBALS["debug"]) print "structure_file_size=".$structure_file_size."<br>";
+
+    $loopno = 1;
+    $looprun = 1;
+    while (!feof($fd)) {
+        $line = fgets($fd, 4096);
+        if (preg_match("/loopnumber\s+\d+/", $line, $matches)) {
+            if (preg_match("/\d+/", $matches[0], $no)) {
                 //$loopno=$no[0];
-                if($no[0]>$loopno)$loopno=$no[0];
+                if ($no[0] > $loopno)$loopno = $no[0];
             }
         }
         if (preg_match("/looprun\s+\d+/", $line, $matches) and preg_match("/\d+/", $matches[0], $no)) {
-            if($no[0]>$looprun)$looprun=$no[0];
+            if ($no[0] > $looprun)$looprun = $no[0];
         }
     }
     fclose($fd);
-    if($GLOBALS["debug"]){
+    if ($GLOBALS["debug"]) {
          print "max loopno(number of loops to run)=".$loopno."<br>";
          print "max looprun(steps for each loop)=".$looprun."<br>";
     }
@@ -225,12 +225,12 @@ 
     $dump_files = glob("dump1*");
     $test_dump_file = $dump_files[0];
     $test_dump_size = filesize($test_dump_file);
-    $dump_size1 = $test_dump_size+0.5*$test_dump_size*ceil(($looprun-$test_steps)/$test_steps);
+    $dump_size1 = $test_dump_size + 0.5*$test_dump_size*ceil(($looprun - $test_steps)/$test_steps);
     $dump_size = $loopno*$dump_size1*$dump_types;
     $app_fixed_size = 5e7;
-    $est_size = $log_size+$dump_size+$app_fixed_size;
+    $est_size = $log_size + $dump_size + $app_fixed_size;
 
-    if($GLOBALS["debug"]){
+    if ($GLOBALS["debug"]) {
         print "test_steps=".$test_steps."<br>";
         print "test_log_size=".$test_log_size."<br>";
         print "log_size1=".$log_size1."<br>";
@@ -321,7 +321,7 @@ 
     if ($njobs < $nhosts) {
         return $flops_per_job/$median_flops;
     } else {
-        $k = (int)(($njobs+$nhosts-1)/$nhosts);
+        $k = (int)(($njobs + $nhosts - 1)/$nhosts);
         return $k*$flops_per_job/$median_flops;
     }
 }
@@ -361,27 +361,27 @@ 
     if ($GLOBALS["debug"]) {
         print "est_cpu_time is ".$est_cpu_time."<br>";
     }
-    if ($error==0) {
-        $err_msgs=file("output");
-        $err="Your test job <strong>failed</strong>
+    if ($error == 0) {
+        $err_msgs = file("output");
+        $err = "Your test job <strong>failed</strong>
             <br>Please refer to the following Error Message:<br><p>
         ";
-        foreach($err_msgs as $line){
-             $err=$err.$line."<br>";
+        foreach ($err_msgs as $line) {
+             $err = $err.$line."<br>";
         }
-        $err=$err." <p>
+        $err = $err." <p>
             <a href=sandbox.php><strong> File_Sandbox </strong></a>
         ";
         error_page($err);
     }
 
     system("rm *");
-    $info->rsc_fpops_est = $est_cpu_time * 1.5e9;
-    $info->rsc_fpops_bound = $info->rsc_fpops_est * 20;
+    $info->rsc_fpops_est = $est_cpu_time*1.5e9;
+    $info->rsc_fpops_bound = $info->rsc_fpops_est*20;
 
-    if ($disk==0){
-        $info->rsc_disk_bound=1000000;
-    } else{
+    if ($disk == 0) {
+        $info->rsc_disk_bound = 1000000;
+    } else {
         $info->rsc_disk_bound = $disk;
     }
 
@@ -392,7 +392,7 @@ 
     //
     $njobs = count(file($cmdline_file_path));
     $secs_est = estimated_makespan($njobs, $info->rsc_fpops_est);
-     if($GLOBALS["debug"])echo "secs_est is $secs_est\n";
+     if ($GLOBALS["debug"])echo "secs_est is $secs_est\n";
     //assume the server's flops is 1.5G and the average client's flops is 1G
     $hrs_est = number_format($secs_est*1.5/60, 2);
     //$hrs_est = number_format($secs_est, 2);
@@ -416,8 +416,8 @@ 
 }
 
 function submit_job($app, $batch_id, $info, $cmdline, $i) {
-    $client_disk=$info->rsc_disk_bound*2;
-    if($client_disk<500000000) $client_disk=500000000;
+    $client_disk = $info->rsc_disk_bound*2;
+    if ($client_disk < 500000000) $client_disk = 500000000;
     $cmd = "cd ../..; ./bin/create_work --appname $app->name --batch $batch_id --rsc_fpops_est $info->rsc_fpops_est --rsc_fpops_bound $info->rsc_fpops_bound --rsc_disk_bound $client_disk";
     if ($cmdline) {
         $cmd .= " --command_line \"$cmdline\"";
@@ -441,9 +441,9 @@ 
     $x = file_get_contents("$tmpfile");
     $info = unserialize($x);
 
-    $njobs=0;
+    $njobs = 0;
     $cmdlines = file($info->cmdline_file_path);
-    foreach ($cmdlines as $cmdline){
+    foreach ($cmdlines as $cmdline) {
         if (preg_match("/^\s*-var/", $cmdline)) {
             $njobs++;
         }
@@ -459,7 +459,7 @@ 
 
     $i = 0;
     foreach ($cmdlines as $cmdline) {
-        if (preg_match("/^\s*-var/", $cmdline)){
+        if (preg_match("/^\s*-var/", $cmdline)) {
             submit_job($app, $batch_id, $info, $cmdline, $i);
             $i++;
         }

html/user/show_user.php

Braces +3 added lines, -3 removed lines

@@ -39,12 +39,12 @@ 
 }
 $format = get_str("format", true);
 
-if ($format=="xml"){
+if ($format=="xml") {
     // don't do caching for XML
     xml_header();
     $retval = db_init_xml();
     if ($retval) xml_error($retval);
-    if ($auth){
+    if ($auth) {
         $user = BoincUser::lookup_auth($auth);
         $show_hosts = true;
     } else {
@@ -60,7 +60,7 @@ 
     //
     $cache_args="userid=".$id;
     $cached_data = get_cached_data(USER_PAGE_TTL, $cache_args);
-    if ($cached_data){
+    if ($cached_data) {
         // We found some old but non-stale data, let's use it
         $data = unserialize($cached_data);
         $user = $data->user;

Spacing +5 added lines, -5 removed lines

@@ -38,12 +38,12 @@ 
 }
 $format = get_str("format", true);
 
-if ($format=="xml"){
+if ($format == "xml") {
     // don't do caching for XML
     xml_header();
     $retval = db_init_xml();
     if ($retval) xml_error($retval);
-    if ($auth){
+    if ($auth) {
         $user = BoincUser::lookup_auth($auth);
         $show_hosts = true;
     } else {
@@ -57,9 +57,9 @@ 
     // The page may be presented in many different languages,
     // so here we cache the data instead
     //
-    $cache_args="userid=".$id;
+    $cache_args = "userid=".$id;
     $cached_data = get_cached_data(USER_PAGE_TTL, $cache_args);
-    if ($cached_data){
+    if ($cached_data) {
         // We found some old but non-stale data, let's use it
         $data = unserialize($cached_data);
         $user = $data->user;
@@ -75,7 +75,7 @@ 
         }
         BoincForumPrefs::lookup($user);
         $user = @get_other_projects($user);
-        $community_links =  get_community_links_object($user);
+        $community_links = get_community_links_object($user);
 
         $data = new StdClass;
         $data->user = $user;

html/user/notify_rss.php

Spacing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
 } else {
     $last_mod_time = time();
 }
-$create_date  = gmdate('D, d M Y H:i:s', $last_mod_time) . ' GMT';
+$create_date = gmdate('D, d M Y H:i:s', $last_mod_time).' GMT';
 
 header("Expires: ".gmdate('D, d M Y H:i:s', time())." GMT");
 header("Last-Modified: ".$create_date);

html/ops/bbcode_convert_signature.php

Spacing +4 added lines, -4 removed lines

@@ -42,15 +42,15 @@
     $start_id = 0; //Set this to something else if you like
     $forum_preferencess = _mysql_query("select * from forum_preferences where userid>$start_id order by userid");
     echo _mysql_error();
-    $i=0;
-    while ($forum_preferences = _mysql_fetch_object($forum_preferencess)){
+    $i = 0;
+    while ($forum_preferences = _mysql_fetch_object($forum_preferencess)) {
         $i++;
         if ($i%100 == 0) {                      //For every 100 forum_preferencess
-            echo $forum_preferences->userid.". "; flush();   // print out where we are
+            echo $forum_preferences->userid.". "; flush(); // print out where we are
             //usleep(200000);
         }
 
-        if ($forum_preferences->userid > $start_id){
+        if ($forum_preferences->userid > $start_id) {
             fix_forum_preferences($forum_preferences);
         }
     }

Braces +4 added lines, -3 removed lines

@@ -43,14 +43,15 @@
     $forum_preferencess = _mysql_query("select * from forum_preferences where userid>$start_id order by userid");
     echo _mysql_error();
     $i=0;
-    while ($forum_preferences = _mysql_fetch_object($forum_preferencess)){
+    while ($forum_preferences = _mysql_fetch_object($forum_preferencess)) {
         $i++;
-        if ($i%100 == 0) {                      //For every 100 forum_preferencess
+        if ($i%100 == 0) {
+//For every 100 forum_preferencess
             echo $forum_preferences->userid.". "; flush();   // print out where we are
             //usleep(200000);
         }
 
-        if ($forum_preferences->userid > $start_id){
+        if ($forum_preferences->userid > $start_id) {
             fix_forum_preferences($forum_preferences);
         }
     }

html/ops/user_graph.php

Spacing +5 added lines, -5 removed lines

@@ -26,13 +26,13 @@ 
 
 
     // Create the graph. These two calls are always required
-    $graph = new Graph(350,250,"auto");
+    $graph = new Graph(350, 250, "auto");
     //$graph->SetScale("lin");
     //$graph->SetScale("textlin");
     $graph->SetScale("loglin");
 
     // Create the linear plot
-    $lineplot=new BarPlot($arr, $xarr);
+    $lineplot = new BarPlot($arr, $xarr);
     $lineplot->SetColor("blue");
 
     // Add the plot to the graph
@@ -44,7 +44,7 @@ 
 
 function show_text($xarr, $yarr) {
     $n = sizeof($xarr);
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         echo "<br>$xarr[$i] $yarr[$i]\n";
     }
 }
@@ -90,9 +90,9 @@ 
         if ($ind > $maxind) $maxind = $ind;
     }
     $xarr = array();
-    for ($i=0; $i<=$maxind; $i++) {
+    for ($i = 0; $i <= $maxind; $i++) {
         $xarr[$i] = $i;
-        if (is_null($yarr[$i])) $yarr[$i]=0;
+        if (is_null($yarr[$i])) $yarr[$i] = 0;
     }
     if ($show_text) {
         show_text($xarr, $yarr);

html/ops/bbcode_convert.php

Spacing +4 added lines, -4 removed lines

@@ -44,15 +44,15 @@
     $start_id = 0; //Set this to something else if you like
     $posts = _mysql_query("select * from post where id>$start_id order by id");
     echo _mysql_error();
-    $i=0;
-    while ($post = _mysql_fetch_object($posts)){
+    $i = 0;
+    while ($post = _mysql_fetch_object($posts)) {
         $i++;
         if ($i%100 == 0) {                      //For every 100 posts
-            echo $post->id.". "; flush();   // print out where we are
+            echo $post->id.". "; flush(); // print out where we are
             //usleep(200000);
         }
 
-        if ($post->id > $start_id){
+        if ($post->id > $start_id) {
             fix_post($post);
         }
     }

Braces +4 added lines, -3 removed lines

@@ -45,14 +45,15 @@
     $posts = _mysql_query("select * from post where id>$start_id order by id");
     echo _mysql_error();
     $i=0;
-    while ($post = _mysql_fetch_object($posts)){
+    while ($post = _mysql_fetch_object($posts)) {
         $i++;
-        if ($i%100 == 0) {                      //For every 100 posts
+        if ($i%100 == 0) {
+//For every 100 posts
             echo $post->id.". "; flush();   // print out where we are
             //usleep(200000);
         }
 
-        if ($post->id > $start_id){
+        if ($post->id > $start_id) {
             fix_post($post);
         }
     }

html/ops/list_new_users.php

Braces +3 added lines, -4 removed lines

@@ -67,7 +67,7 @@ 
     $email_validated = $row->email_validated;
 
     $team_name="";
-    if($row->teamid > 0){
+    if($row->teamid > 0) {
         $team = BoincTeam::lookup_id($row->teamid);
         $team_name = $team->name;
     }
@@ -80,7 +80,7 @@ 
     if ($special_bits != "0") {
         for ($i = 0; $i < 7; $i++) {
             $bit = substr($special_bits, $i, 1);
-            if ($bit == '1'){
+            if ($bit == '1') {
                 if (!empty($roles)) {
                     $roles .= ", ";
                 }
@@ -97,8 +97,7 @@ 
         $dt = $user->banished_until - time();
         if( $dt > 0 ) {
             $x = "<span style=\"color: #ff0000\">Currently banished</span>";
-        }
-        else {
+        } else {
             $x = "<span style=\"color: #ff9900\">Previously banished</span>";
         }
         $roles .= $x;

Spacing +6 added lines, -6 removed lines

@@ -27,7 +27,7 @@ 
 \***********************************************************************/
 
 $limit = get_int('limit', true);
-if (! $limit > 0 ) $limit = 30;
+if (!$limit > 0) $limit = 30;
 
 
 
@@ -48,7 +48,7 @@ 
 echo "<input class=\"btn btn-default\" type=\"submit\" value=\"Display\">\n";
 echo "</form>\n";
 
-$query="SELECT * FROM user ORDER BY create_time DESC LIMIT $limit";
+$query = "SELECT * FROM user ORDER BY create_time DESC LIMIT $limit";
 $result = _mysql_query($query);
 if (_mysql_num_rows($result) < 1) {
     echo "There are no new users.";
@@ -66,8 +66,8 @@ 
     $joined = time_str($row->create_time);
     $email_validated = $row->email_validated;
 
-    $team_name="";
-    if($row->teamid > 0){
+    $team_name = "";
+    if ($row->teamid > 0) {
         $team = BoincTeam::lookup_id($row->teamid);
         $team_name = $team->name;
     }
@@ -80,7 +80,7 @@ 
     if ($special_bits != "0") {
         for ($i = 0; $i < 7; $i++) {
             $bit = substr($special_bits, $i, 1);
-            if ($bit == '1'){
+            if ($bit == '1') {
                 if (!empty($roles)) {
                     $roles .= ", ";
                 }
@@ -95,7 +95,7 @@ 
     // Banished?
     if (!empty($user->banished_until)) {
         $dt = $user->banished_until - time();
-        if( $dt > 0 ) {
+        if ($dt > 0) {
             $x = "<span style=\"color: #ff0000\">Currently banished</span>";
         }
         else {

html/ops/db_form.php

Indentation +6 added lines, -6 removed lines

@@ -35,10 +35,10 @@ 
 start_table();
 
 switch($table){
-	case "platform":
-		break;
-	case "app":
-		break;
+    case "platform":
+        break;
+    case "app":
+        break;
     case "app_version":
         print_detail_field();
         print_query_field();
@@ -89,8 +89,8 @@ 
     case "user":
         print_query_field();
         break;
-	default:
-		echo "Unknown table name\n";
+    default:
+        echo "Unknown table name\n";
         exit();
 }
 

Switch Indentation +50 added lines, -50 removed lines

@@ -35,63 +35,63 @@
 start_table();
 
 switch($table){
-	case "platform":
-		break;
-	case "app":
-		break;
-    case "app_version":
-        print_detail_field();
-        print_query_field();
-        break;
-    case "host":
-        echo "
+case "platform":
+	break;
+case "app":
+	break;
+case "app_version":
+    print_detail_field();
+    print_query_field();
+    break;
+case "host":
+    echo "
             <tr>
             <td align=\"right\">Show Aggregate Information</td>
             <td>
         ";
-        print_checkbox("", "show_aggregate", $show_aggregate);
-        echo "
+    print_checkbox("", "show_aggregate", $show_aggregate);
+    echo "
             </td>
             </tr>
         ";
-        print_detail_field();
-        print_query_field();
-        break;
-    case "workunit":
-        print_detail_field();
-        print_query_field();
-        echo "<input type=\"hidden\" name=\"sort_by\" value=\"id\">\n";
-        break;
-    case "result":
-        echo "<tr><td align=\"right\">Server state</td><td> ";
-        server_state_select();
-        echo "</td></tr>\n";
-        //print_text_field( "Batch number:", "batch", $batch );
-        echo "<tr><td align=\"right\">Outcome</td><td>";
-        outcome_select();
-        echo "</td></tr>\n";
-        echo "<tr><td align=\"right\">Client state</td><td>";
-        client_state_select();
-        echo "</td></tr>\n";
-        echo "<tr><td align=\"right\">Validate state</td><td>";
-        validate_state_select();
-        echo "</td></tr>\n";
-        echo "<tr><td align=\"right\">Sort by</td><td>";
-        result_sort_select();
-        sort_order_select();
-        echo "</td></tr>\n";
-        print_detail_field();
-        print_query_field();
-        break;
-    case "team":
-        print_query_field();
-        break;
-    case "user":
-        print_query_field();
-        break;
-	default:
-		echo "Unknown table name\n";
-        exit();
+    print_detail_field();
+    print_query_field();
+    break;
+case "workunit":
+    print_detail_field();
+    print_query_field();
+    echo "<input type=\"hidden\" name=\"sort_by\" value=\"id\">\n";
+    break;
+case "result":
+    echo "<tr><td align=\"right\">Server state</td><td> ";
+    server_state_select();
+    echo "</td></tr>\n";
+    //print_text_field( "Batch number:", "batch", $batch );
+    echo "<tr><td align=\"right\">Outcome</td><td>";
+    outcome_select();
+    echo "</td></tr>\n";
+    echo "<tr><td align=\"right\">Client state</td><td>";
+    client_state_select();
+    echo "</td></tr>\n";
+    echo "<tr><td align=\"right\">Validate state</td><td>";
+    validate_state_select();
+    echo "</td></tr>\n";
+    echo "<tr><td align=\"right\">Sort by</td><td>";
+    result_sort_select();
+    sort_order_select();
+    echo "</td></tr>\n";
+    print_detail_field();
+    print_query_field();
+    break;
+case "team":
+    print_query_field();
+    break;
+case "user":
+    print_query_field();
+    break;
+default:
+	echo "Unknown table name\n";
+       exit();
 }
 
 row2("Number of entries to show", "<input name=\"nresults\" value=\"20\">");

Braces +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
 start_table();
 
-switch($table){
+switch($table) {
 	case "platform":
 		break;
 	case "app":

Spacing +1 added lines, -1 removed lines

@@ -34,7 +34,7 @@
 
 start_table();
 
-switch($table){
+switch ($table) {
 	case "platform":
 		break;
 	case "app":