BOINC / boinc

html/project.sample/project.inc

Doc Comments +9 added lines

@@ -108,6 +108,10 @@ 
 // If you include any links, prepend URL with $prefix
 // if you need to open divs here close them in project_footer()
 //
+/**
+ * @param string $prefix
+ * @param boolean $is_main
+ */
 function project_banner($title, $prefix, $is_main) {
     if ($is_main) {
         echo '<img class="img-responsive" src="img/water.jpg">';
@@ -119,6 +123,11 @@ 
 }
 //$fixed_navbar = true;
 
+/**
+ * @param boolean $show_return
+ * @param boolean $show_date
+ * @param string $prefix
+ */
 function project_footer($show_return, $show_date, $prefix) {
     // If you include any links, prepend URL with $prefix
     //

Braces +4 added lines, -4 removed lines

@@ -183,15 +183,15 @@ 
     </ol>", PROJECT);
 }
 
-function project_workunit($wu){
+function project_workunit($wu) {
     // shown in the workunit page
 }
 
-function project_user_summary($user){
+function project_user_summary($user) {
     // shown in the user summary page
 }
 
-function project_user_page_private($user){
+function project_user_page_private($user) {
     // shown in the private account page
 }
 
@@ -258,7 +258,7 @@ 
     array("name" => "Uppercase", "short_name" => "UC", "appids" => array(1, 25)),
 );
 
-function project_user_credit($user){
+function project_user_credit($user) {
     global $sub_projects;
     foreach ($sub_projects as $sp) {
         show_app_credit_user($user, $sp["name"], $sp["appids"]);

Spacing +5 added lines, -5 removed lines

@@ -48,7 +48,7 @@ 
 
 define("FORUM_QA_MERGED_MODE", true);
     // Set to true to merge Message boards and Q&A section
-define ("DISABLE_PROFILES", true);
+define("DISABLE_PROFILES", true);
     // enable profiles only after enabling reCAPTCHA
     // https://boinc.berkeley.edu/trac/wiki/ProtectionFromSpam
 define("USE_STOPFORUMSPAM", true);
@@ -183,15 +183,15 @@ 
     </ol>", PROJECT);
 }
 
-function project_workunit($wu){
+function project_workunit($wu) {
     // shown in the workunit page
 }
 
-function project_user_summary($user){
+function project_user_summary($user) {
     // shown in the user summary page
 }
 
-function project_user_page_private($user){
+function project_user_page_private($user) {
     // shown in the private account page
 }
 
@@ -258,7 +258,7 @@ 
     array("name" => "Uppercase", "short_name" => "UC", "appids" => array(1, 25)),
 );
 
-function project_user_credit($user){
+function project_user_credit($user) {
     global $sub_projects;
     foreach ($sub_projects as $sp) {
         show_app_credit_user($user, $sp["name"], $sp["appids"]);

html/project.sample/project_specific_prefs.inc

Doc Comments +16 added lines

@@ -32,6 +32,9 @@ 
 //      Parse form variables into XML, and return it.
 //      Also error-check values, and return errors in $errors->*
 
+/**
+ * @param string $name
+ */
 function option($name, $val) {
     $x = ($name == $val) ?  "selected" : "";
     return "<option name='$name' $x>$name\n";
@@ -90,6 +93,10 @@ 
     return $x;
 }
 
+/**
+ * @param string $name
+ * @param integer $max
+ */
 function number_select($name, $max, $n) {
     $sel = ($n == 0) ? "selected":"";
     $x = "<select class=\"form-control input-sm\" name=$name> <option value=0 $sel>".tra("No limit")."</option>";
@@ -106,6 +113,9 @@ 
     return tra("No limit");
 }
 
+/**
+ * @param stdClass $prefs
+ */
 function project_specific_prefs_edit($prefs, $error=false) {
     global $app_array;
     if (COLOR_PREFS) {
@@ -162,6 +172,9 @@ 
     }
 }
 
+/**
+ * @param boolean $error
+ */
 function project_specific_prefs_parse_form(&$error) {
     global $app_array;
     $x = "";
@@ -216,6 +229,9 @@ 
     return $x;
 }
 
+/**
+ * @param stdClass $prefs
+ */
 function project_specific_prefs_show($prefs, $columns=false) {
     global $app_array;
     if ($columns) {

Spacing +15 added lines, -15 removed lines

@@ -33,7 +33,7 @@ 
 //      Also error-check values, and return errors in $errors->*
 
 function option($name, $val) {
-    $x = ($name == $val) ?  "selected" : "";
+    $x = ($name == $val) ? "selected" : "";
     return "<option name='$name' $x>$name\n";
 }
 
@@ -53,7 +53,7 @@ 
 if (APP_SELECT_PREFS) {
     $app_array = array();
     $apps = BoincApp::enum("deprecated=0");
-    foreach($apps as $app) {
+    foreach ($apps as $app) {
         $app_array[] = array($app->id, $app->user_friendly_name);
     }
 } else {
@@ -91,10 +91,10 @@ 
 }
 
 function number_select($name, $max, $n) {
-    $sel = ($n == 0) ? "selected":"";
+    $sel = ($n == 0) ? "selected" : "";
     $x = "<select class=\"form-control input-sm\" name=$name> <option value=0 $sel>".tra("No limit")."</option>";
-    for ($i=1; $i<=$max; $i++) {
-        $sel = ($n == $i) ? "selected":"";
+    for ($i = 1; $i <= $max; $i++) {
+        $sel = ($n == $i) ? "selected" : "";
         $x .= "<option value=$i $sel>$i</option>";
     }
     $x .= "</select>";
@@ -106,7 +106,7 @@ 
     return tra("No limit");
 }
 
-function project_specific_prefs_edit($prefs, $error=false) {
+function project_specific_prefs_edit($prefs, $error = false) {
     global $app_array;
     if (COLOR_PREFS) {
         $x = $prefs->color_scheme;
@@ -132,15 +132,15 @@ 
             } else {
                 $present = true;
             }
-            $checked = $present?"checked":"";
+            $checked = $present ? "checked" : "";
             $x .= "<input type=checkbox name=app_id_$app_id $checked> $app_name<br>";
         }
         tooltip_row2(APP_SELECT_TOOLTIP, APP_SELECT_DESC, $x);
-        $checked = $prefs->allow_non_preferred_apps?"checked":"";
+        $checked = $prefs->allow_non_preferred_apps ? "checked" : "";
         row2(ACCEPT_ANY_DESC, "<input type=checkbox name=allow_non_preferred_apps $checked>");
     }
     if (NON_GRAPHICAL_PREF) {
-        $checked = $prefs->non_graphical?"checked":"";
+        $checked = $prefs->non_graphical ? "checked" : "";
         row2(
             NON_GRAPHICAL_DESC,
             "<input type=checkbox name=non_graphical $checked>"
@@ -216,11 +216,11 @@ 
     return $x;
 }
 
-function project_specific_prefs_show($prefs, $columns=false) {
+function project_specific_prefs_show($prefs, $columns = false) {
     global $app_array;
     if ($columns) {
         if (COLOR_PREFS) {
-            row_defs(COLOR_DESC,"color_scheme", "", "", $prefs);
+            row_defs(COLOR_DESC, "color_scheme", "", "", $prefs);
         }
         if (GFX_CPU_PREFS) {
             row_defs(MAX_GFX_CPU_PCT_DESC, "max_gfx_cpu_pct", "", "", $prefs);
@@ -254,7 +254,7 @@ 
             row2(ACCEPT_ANY_DESC, $prefs->allow_non_preferred_apps_text);
         }
         if (NON_GRAPHICAL_PREF) {
-            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical?tra("yes"):tra("no"));
+            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical ?tra("yes") : tra("no"));
         }
         if (MAX_JOBS_PREF) {
             row2(tra("Max # jobs"), limit_string($prefs->max_jobs));
@@ -277,12 +277,12 @@ 
         $cursor = 0;
         while ($thisxml = parse_next_element($prefs_xml, "<app_id>", $cursor)) {
             if (is_numeric($thisxml)) {
-                $n = (int) $thisxml;
+                $n = (int)$thisxml;
                 $prefs->app_ids[] = $n;
             }
         }
         $prefs->allow_non_preferred_apps = parse_element($prefs_xml, "<allow_non_preferred_apps>");
-        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps?"yes":"no";
+        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps ? "yes" : "no";
     }
     if (NON_GRAPHICAL_PREF) {
         $prefs->non_graphical = parse_bool($prefs_xml, "non_graphical");
@@ -296,6 +296,6 @@ 
     return $prefs;
 }
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 
 ?>

html/user/bolt_sched.php

Doc Comments +6 added lines

@@ -28,6 +28,9 @@ 
 require_once("../inc/bolt_util.inc");
 require_once("../inc/util.inc");
 
+/**
+ * @param string $tag
+ */
 function debug_show_state($state, $tag) {
     global $user;
     global $refresh;
@@ -82,6 +85,9 @@ 
 
 // A page is being shown to the user; make a record of it
 //
+/**
+ * @param integer $mode
+ */
 function create_view($iter, $mode, $prev_view_id) {
     global $user;
     global $course;

Spacing +3 added lines, -3 removed lines

@@ -77,7 +77,7 @@ 
 }
 
 function default_mode($item) {
-    return $item->is_exercise()?BOLT_MODE_SHOW:BOLT_MODE_LESSON;
+    return $item->is_exercise() ?BOLT_MODE_SHOW:BOLT_MODE_LESSON;
 }
 
 // A page is being shown to the user; make a record of it
@@ -170,7 +170,7 @@ 
 
 // show an item (lesson, exercise, answer page)
 //
-function show_item($iter, $view_id, $prev_view_id, $mode, $repeat=null) {
+function show_item($iter, $view_id, $prev_view_id, $mode, $repeat = null) {
     global $user;
     global $course;
     global $bolt_ex;
@@ -462,7 +462,7 @@ 
     $bolt_ex->score = 0;
     $bolt_query_string = $item->query_string;
     srand($view_id);
-    ob_start();     // buffer output to avoid showing exercise text
+    ob_start(); // buffer output to avoid showing exercise text
     require($item->filename);
     ob_end_clean();
 

html/user/create_profile.php

Doc Comments +10 added lines

@@ -31,6 +31,10 @@ 
 // If $selection is provided, and if it matches one of the entries in the file,
 // it will be selected by default.
 //
+/**
+ * @param string $name
+ * @param string $filename
+ */
 function show_combo_box($name, $filename, $selection=null) {
     echo "<select name=\"$name\" class=\"form-control\">\n";
 
@@ -185,6 +189,9 @@ 
     show_language_selection($profile);
 }
 
+/**
+ * @param string $name
+ */
 function show_textarea($name, $text) {
     rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">" . $text . "</textarea>");
 }
@@ -311,6 +318,9 @@ 
     page_tail();
 }
 
+/**
+ * @param string $warning
+ */
 function show_profile_form($profile, $warning=null) {
     if ($profile) {
         page_head(tra("Edit your profile"), null, null, null, boinc_recaptcha_get_head_extra());

Spacing +20 added lines, -20 removed lines

@@ -31,7 +31,7 @@ 
 // If $selection is provided, and if it matches one of the entries in the file,
 // it will be selected by default.
 //
-function show_combo_box($name, $filename, $selection=null) {
+function show_combo_box($name, $filename, $selection = null) {
     echo "<select name=\"$name\" class=\"form-control\">\n";
 
     $file = fopen($filename, "r");
@@ -62,14 +62,14 @@ 
 <tr><td colspan=2>
 <table border=0 cellpadding=5
 <tr>
-<td valign=top><a href=\"" . IMAGE_URL . $profile->userid . '.jpg' . "\"><img src=\"" . IMAGE_URL . $profile->userid . '_sm.jpg' . "\"></a>
+<td valign=top><a href=\"" . IMAGE_URL.$profile->userid.'.jpg'."\"><img src=\"".IMAGE_URL.$profile->userid.'_sm.jpg'."\"></a>
 </td>
-<td valign=top>" .tra("%1 Your profile picture is shown to the left.",  $warning) ."
+<td valign=top>" .tra("%1 Your profile picture is shown to the left.", $warning)."
 <p>".
-tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB") ."<br />
+tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB")."<br />
 <input name=picture type=file><br>
 <p>".
-tra("To remove it from your profile, check this box:") . "
+tra("To remove it from your profile, check this box:")."
 <input type=checkbox name=delete_pic>
 <p>
 </td></tr>";
@@ -77,7 +77,7 @@ 
         end_table();
         echo "</td></tr>";
     } else {
-        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB") . "
+        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB")."
 <p>
 <input name=picture type=file>
         ");
@@ -92,7 +92,7 @@ 
     row1(tra("Language"));
     echo "<tr><td>
         <p>" .
-        tra("Select the language in which your profile is written:") . "
+        tra("Select the language in which your profile is written:")."
         <p>
     ";
     if (isset($profile->language)) {
@@ -110,7 +110,7 @@ 
     if ($publickey) {
         table_row(boinc_recaptcha_get_html($publickey));
     }
-    table_row("<p><input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Create/edit profile") ."\" name=\"submit\">");
+    table_row("<p><input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Create/edit profile")."\" name=\"submit\">");
 }
 
 // Returns an array containing:
@@ -124,7 +124,7 @@ 
 
     // Determine if the filetype uploaded is supported.
     // TODO: Change these to constants.
-    switch($size[2]) {
+    switch ($size[2]) {
     case '2':    // JPEG
         $image = imageCreateFromJPEG($fileName);
         break;
@@ -161,7 +161,7 @@ 
 
 function show_description() {
     echo "
-        <p>" .tra("Your %1 profile %2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT) . "
+        <p>" .tra("Your %1 profile %2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT)."
         <p>
     ";
 }
@@ -179,14 +179,14 @@ 
     row1(show_profile_heading1());
     rowify(show_profile_question1().bbcode_info());
     show_textarea("response1", $response1);
-    row1( show_profile_heading2());
-    rowify( show_profile_question2().bbcode_info());
+    row1(show_profile_heading2());
+    rowify(show_profile_question2().bbcode_info());
     show_textarea("response2", $response2);
     show_language_selection($profile);
 }
 
 function show_textarea($name, $text) {
-    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">" . $text . "</textarea>");
+    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">".$text."</textarea>");
 }
 
 // $profile is null if user doesn't already have a profile.
@@ -233,8 +233,8 @@ 
         $delete_pic = "off";
     }
 
-    if (strlen($response1)==0 &&
-        strlen($response2)==0 &&
+    if (strlen($response1) == 0 &&
+        strlen($response2) == 0 &&
         $delete_pic != "on" &&
         !is_uploaded_file($_FILES['picture']['tmp_name'])
     ) {
@@ -248,7 +248,7 @@ 
         $profile->verification = 0;
     }
 
-    $profile ? $has_picture = $profile->has_picture: $has_picture = false;
+    $profile ? $has_picture = $profile->has_picture : $has_picture = false;
 
     if (is_uploaded_file($_FILES['picture']['tmp_name'])) {
         $has_picture = true;
@@ -263,13 +263,13 @@ 
 
         // Write the original image file to disk.
         // TODO: define a constant for image quality.
-        ImageJPEG($images[0], IMAGE_PATH . $user->id . '.jpg');
-        ImageJPEG($images[1], IMAGE_PATH . $user->id . '_sm.jpg');
+        ImageJPEG($images[0], IMAGE_PATH.$user->id.'.jpg');
+        ImageJPEG($images[1], IMAGE_PATH.$user->id.'_sm.jpg');
     }
     $response1 = sanitize_html($response1);
     $response2 = sanitize_html($response2);
 
-    $has_picture = $has_picture?1:0;
+    $has_picture = $has_picture ? 1 : 0;
     if ($profile) {
         $query = " response1 = '".BoincDb::escape_string($response1)."',"
             ." response2 = '".BoincDb::escape_string($response2)."',"
@@ -311,7 +311,7 @@ 
     page_tail();
 }
 
-function show_profile_form($profile, $warning=null) {
+function show_profile_form($profile, $warning = null) {
     if ($profile) {
         page_head(tra("Edit your profile"), null, null, null, boinc_recaptcha_get_head_extra());
     } else {

html/user/forum_reply.php

Doc Comments +3 added lines

@@ -178,6 +178,9 @@
     row2($x1, $x2, false, "20%");
 }
 
+/**
+ * @param string $text
+ */
 function quote_text($text) {
     $text = "[quote]" . $text . "[/quote]";
     return $text;

Braces +4 added lines, -4 removed lines

@@ -50,7 +50,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -65,10 +65,10 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
-    if (post_str('add_signature',true)=="add_it"){
+if ($content && (!$preview)) {
+    if (post_str('add_signature',true)=="add_it") {
         $add_signature=true;    // set a flag and concatenate later
-    }  else {
+    } else {
         $add_signature=false;
     }
     check_tokens($logged_in_user->authenticator);

Spacing +13 added lines, -13 removed lines

@@ -50,7 +50,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -65,11 +65,11 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
-    if (post_str('add_signature',true)=="add_it"){
-        $add_signature=true;    // set a flag and concatenate later
-    }  else {
-        $add_signature=false;
+if ($content && (!$preview)) {
+    if (post_str('add_signature', true) == "add_it") {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
+        $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
     if (!akismet_check($logged_in_user, $content)) {
@@ -88,7 +88,7 @@ 
     }
 }
 
-page_head(tra("Post to thread"),'','','', $bbcode_js);
+page_head(tra("Post to thread"), '', '', '', $bbcode_js);
 
 show_forum_header($logged_in_user);
 
@@ -142,7 +142,7 @@ 
     $x1 = tra("Message:").bbcode_info().post_warning();
     $x2 = "";
     if ($parent_post) {
-        $x2 .=" ".tra("reply to %1 Message ID %2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
+        $x2 .= " ".tra("reply to %1 Message ID %2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
     }
     $x2 .= "<form action=forum_reply.php?thread=".$thread->id;
 
@@ -153,7 +153,7 @@ 
     $x2 .= " method=\"post\" name=\"post\" onsubmit=\"return checkForm(this)\">\n";
     $x2 .= form_tokens($logged_in_user->authenticator);
     $x2 .= start_table_str().$bbcode_html.end_table_str()."<textarea class=\"form-control\" name=\"content\" rows=\"18\">";
-    $no_quote = get_int("no_quote", true)==1;
+    $no_quote = get_int("no_quote", true) == 1;
     if ($preview) {
         $x2 .= htmlspecialchars($content);
     } else if (!$no_quote) {
@@ -162,9 +162,9 @@ 
         }
     }
     if (!$logged_in_user->prefs->no_signature_by_default) {
-        $enable_signature="checked=\"true\"";
+        $enable_signature = "checked=\"true\"";
     } else {
-        $enable_signature="";
+        $enable_signature = "";
     }
     $x2 .= "</textarea><p> </p>
         <input class=\"btn btn-primary btn-sm \" type=\"submit\" name=\"preview\" value=\"".tra("Preview")."\">
@@ -179,9 +179,9 @@ 
 }
 
 function quote_text($text) {
-    $text = "[quote]" . $text . "[/quote]";
+    $text = "[quote]".$text."[/quote]";
     return $text;
 }
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

html/user/gpu_list.php

Doc Comments +10 added lines

@@ -29,6 +29,9 @@ 
 // take a host.serialnum field (which may encode several GPUs)
 // and extract the model name for the given vendor
 //
+/**
+ * @param string $vendor
+ */
 function get_gpu_model($x, $vendor) {
     $descs = explode("]", $x);
     array_pop($descs);
@@ -60,6 +63,10 @@ 
 // $x->linux
 // $x->mac
 //
+/**
+ * @param string $vendor
+ * @param string $alt_vendor
+ */
 function get_gpu_list($vendor, $alt_vendor=null) {
     $clause = "plan_class like '%$vendor%'";
     if ($alt_vendor) {
@@ -144,6 +151,9 @@ 
     return $x1->avg_time > $x2->avg_time;
 }
 
+/**
+ * @param string $name
+ */
 function show_list($models, $name) {
     echo "<td><h2>$name</h2>\n";
     if (!count($models)) {

Spacing +6 added lines, -6 removed lines

@@ -60,7 +60,7 @@ 
 // $x->linux
 // $x->mac
 //
-function get_gpu_list($vendor, $alt_vendor=null) {
+function get_gpu_list($vendor, $alt_vendor = null) {
     $clause = "plan_class like '%$vendor%'";
     if ($alt_vendor) {
         $clause .= " or plan_class like '%$alt_vendor%'";
@@ -73,7 +73,7 @@ 
     }
 
     $av_ids = "";
-    foreach($avs as $av) {
+    foreach ($avs as $av) {
         $av_ids .= "$av->id, ";
     }
     if ($vendor == "cuda") {
@@ -176,14 +176,14 @@ 
         echo tra("No GPU tasks reported");
         return;
     }
-    $have_win = count($x->win)>0;
-    $have_mac = count($x->mac)>0;
-    $have_linux = count($x->linux)>0;
+    $have_win = count($x->win) > 0;
+    $have_mac = count($x->mac) > 0;
+    $have_linux = count($x->linux) > 0;
     $n = 0;
     if ($have_win) $n++;
     if ($have_mac) $n++;
     if ($have_linux) $n++;
-    $show_total = $n>1;
+    $show_total = $n > 1;
     start_table();
     echo "<tr>";
     if ($show_total) {

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -196,7 +196,7 @@
 }
 
 $d = get_cached_data(86400);
-$data = FALSE;
+$data = false;
 if ($d) {
     $data = unserialize($d);
 }

html/user/host_app_versions.php

Doc Comments +3 added lines

@@ -18,6 +18,9 @@
 
 require_once("../inc/util.inc");
 
+/**
+ * @param integer $t
+ */
 function rsc_name($t) {
     switch ($t) {
     case 2: return tra("CPU");

Spacing +2 added lines, -2 removed lines

@@ -40,7 +40,7 @@ 
         if (!$show_dep && $app->deprecated) {
             return null;
         }
-        $rsc_type = $gavid % 1000000;
+        $rsc_type = $gavid%1000000;
         $r = rsc_name($rsc_type);
         return "$app->user_friendly_name (".tra("anonymous platform").", $r)";
     } else {
@@ -60,7 +60,7 @@ 
         }
         $platform = BoincPlatform::lookup_id($av->platformid);
         if (!$platform) return tra("Missing platform");
-        $pc = (strlen($av->plan_class))?"($av->plan_class)":"";
+        $pc = (strlen($av->plan_class)) ? "($av->plan_class)" : "";
         $v = number_format($av->version_num/100, 2);
         return "$app->user_friendly_name $v $platform->name $pc";
     }

html/user/host_edit_action.php

Doc Comments +3 added lines

@@ -20,6 +20,9 @@
 require_once("../inc/util.inc");
 require_once("../inc/host.inc");
 
+/**
+ * @param string $msg
+ */
 function fail($msg) {
     echo "Error: $msg";
     page_tail();

Spacing +1 added lines, -1 removed lines

@@ -41,7 +41,7 @@
 $nhosts = get_int("nhosts");
 $hostid = get_int("id_0");
 $latest_host = get_host($hostid, $user);
-for ($i=1; $i<$nhosts; $i++) {
+for ($i = 1; $i < $nhosts; $i++) {
     $var = "id_$i";
     $hostid = get_int($var, true);
     if (!$hostid) continue;

html/user/lammps.php

Doc Comments +26 added lines

@@ -30,6 +30,9 @@ 
 //
 // output: success flag, CPU time per step, est. disk usage per job
 //
+/**
+ * @param resource $p
+ */
 function terminate_job($p) {
     $pstatus=proc_get_status($p);
     $ppid=$pstatus['pid'];
@@ -86,6 +89,9 @@ 
     return array($test_result, $total_cpu, $disk_space);
 }
 
+/**
+ * @param string $cmd_file
+ */
 function get_total_steps($cmd_file) {
     $fd = fopen($cmd_file,"r");
     if (!$fd) {
@@ -116,6 +122,9 @@ 
     return $total_steps;
 }
 
+/**
+ * @param string $filename
+ */
 function calc_step_cpu($filename) {
     $fd = fopen("$filename", "r");
     $start_line = "Step CPU ";
@@ -169,6 +178,11 @@ 
     return array($avg_cpu,$test_steps);
 }
 
+/**
+ * @param string $lammps_script
+ * @param string $structure_file
+ * @param string $cmd_file
+ */
 function calc_est_size($lammps_script, $structure_file, $cmd_file,$test_steps){
     $dump_types = 0;
     $fd = fopen($lammps_script,"r");
@@ -280,6 +294,11 @@ 
 
 // verify that an input file exists in sandbox, and return its physical path
 //
+/**
+ * @param string $name
+ *
+ * @return string
+ */
 function get_file_path($user, $name) {
     $fname = get_str($name);
 
@@ -308,6 +327,10 @@ 
 //
 // Note: these are both extremely optimistic estimates
 //
+/**
+ * @param integer $njobs
+ * @param double $flops_per_job
+ */
 function estimated_makespan($njobs, $flops_per_job) {
     $nhosts = BoincHost::count("expavg_credit > 1");
     if ($nhosts < 10) {
@@ -416,6 +439,9 @@ 
     page_tail();
 }
 
+/**
+ * @param integer $i
+ */
 function submit_job($app, $batch_id, $info, $cmdline, $i) {
     $client_disk=$info->rsc_disk_bound*2;
     if($client_disk<500000000) $client_disk=500000000;

Indentation +14 added lines, -14 removed lines

@@ -35,7 +35,7 @@ 
     $ppid=$pstatus['pid'];
     $ret=`ps -o pid --no-heading --ppid $ppid`;
     //echo "parent pid is $ppid\nterninate it\n";
-     proc_terminate($p);
+        proc_terminate($p);
     // echo "child process is $ret\n";
     $pids=preg_split('/\s+/',$ret);
     foreach($pids as $pid){
@@ -61,9 +61,9 @@ 
     while (1) {
         $ctime=time();
         if($ctime-$stime >=2 and ! file_exists("log.1")){
-           if($GLOBALS["debug"]) echo "time out "."<br>";
-           terminate_job($p);
-           break;
+            if($GLOBALS["debug"]) echo "time out "."<br>";
+            terminate_job($p);
+            break;
         } 
         if (file_exists("log.1")) {
             list($avg_cpu, $test_steps) = calc_step_cpu("log.1");
@@ -112,7 +112,7 @@ 
     }
     fclose($fd);
     //$total_steps = $loopno*$looprun;
-     if($GLOBALS["debug"])print "total_steps = ".$total_steps."<br>";
+        if($GLOBALS["debug"])print "total_steps = ".$total_steps."<br>";
     return $total_steps;
 }
 
@@ -147,12 +147,12 @@ 
         $cpu = (float)$arr[2];
         //echo "step=".$step." cpu=".$cpu."\n";
         if ($cpu==0) {
-           $count=0;
-           $start_step = $step;
+            $count=0;
+            $start_step = $step;
         } else {
             $count+=1;
             if($GLOBALS["debug"])echo "step=".$step." cpu=".$cpu."count=".$count."<br>";
-           if($count >= 10) {
+            if($count >= 10) {
                 $end_step = $step;
                 $steps = $end_step-$start_step;
                 $avg_cpu = $cpu/$steps;
@@ -183,7 +183,7 @@ 
         
         if(preg_match("/^\s*dump\s+(\d)\s+/", $line,$matches))
         {        
-             if($GLOBALS["debug"]){print "matches=";print_r($matches);}
+                if($GLOBALS["debug"]){print "matches=";print_r($matches);}
 
             $dump_types=(int)$matches[1];
             break;
@@ -198,7 +198,7 @@ 
         echo "can not open file $cmd_file\n";
         exit(-1);
     }
-     if($GLOBALS["debug"]) print "structure_file_size=".$structure_file_size."<br>";
+        if($GLOBALS["debug"]) print "structure_file_size=".$structure_file_size."<br>";
    
     $loopno=1;
     $looprun=1;
@@ -216,8 +216,8 @@ 
     }
     fclose($fd);
     if($GLOBALS["debug"]){
-         print "max loopno(number of loops to run)=".$loopno."<br>";
-         print "max looprun(steps for each loop)=".$looprun."<br>";
+            print "max loopno(number of loops to run)=".$loopno."<br>";
+            print "max looprun(steps for each loop)=".$looprun."<br>";
     }
     //$est_size = $loopno*$structure_file_size*0.8*$dump_types;
     $test_log_size = filesize("log.1");
@@ -368,7 +368,7 @@ 
             <br>Please refer to the following Error Message:<br><p>
         ";
         foreach($err_msgs as $line){
-             $err=$err.$line."<br>";
+                $err=$err.$line."<br>";
         }
         $err=$err." <p>
             <a href=sandbox.php><strong> File_Sandbox </strong></a>
@@ -393,7 +393,7 @@ 
     //
     $njobs = count(file($cmdline_file_path));
     $secs_est = estimated_makespan($njobs, $info->rsc_fpops_est);
-     if($GLOBALS["debug"])echo "secs_est is $secs_est\n";
+        if($GLOBALS["debug"])echo "secs_est is $secs_est\n";
     //assume the server's flops is 1.5G and the average client's flops is 1G
     $hrs_est = number_format($secs_est*1.5/60, 2);
     //$hrs_est = number_format($secs_est, 2);

Spacing +73 added lines, -73 removed lines

@@ -18,7 +18,7 @@ 
 require_once("../inc/util.inc");
 require_once("../inc/submit_db.inc");
 require_once("../inc/sandbox.inc");
-$debug=0;
+$debug = 0;
 
 // test a LAMMPS job
 //
@@ -31,17 +31,17 @@ 
 // output: success flag, CPU time per step, est. disk usage per job
 //
 function terminate_job($p) {
-    $pstatus=proc_get_status($p);
-    $ppid=$pstatus['pid'];
-    $ret=`ps -o pid --no-heading --ppid $ppid`;
+    $pstatus = proc_get_status($p);
+    $ppid = $pstatus['pid'];
+    $ret = `ps -o pid --no-heading --ppid $ppid`;
     //echo "parent pid is $ppid\nterninate it\n";
      proc_terminate($p);
     // echo "child process is $ret\n";
-    $pids=preg_split('/\s+/',$ret);
-    foreach($pids as $pid){
-        if(is_numeric($pid)){
-            if($GLOBALS["debug"])echo "killing child process $pid\n";
-            posix_kill($pid,9);
+    $pids = preg_split('/\s+/', $ret);
+    foreach ($pids as $pid) {
+        if (is_numeric($pid)) {
+            if ($GLOBALS["debug"])echo "killing child process $pid\n";
+            posix_kill($pid, 9);
         }
     }
 }
@@ -52,23 +52,23 @@ 
     $descs = array();
     $pipes = array();
     $options = file("cmd_variables");
-    $options[0] = chop($options[0],"\n");
+    $options[0] = chop($options[0], "\n");
     $cmd = "../lmp_linux ".$options[0]."&>output";
     if ($GLOBALS["debug"]) echo $cmd."<br>";
     system("unzip pot_files >/dev/null");
     $stime = time();
     $p = proc_open("$cmd", $descs, $pipes);
     while (1) {
-        $ctime=time();
-        if($ctime-$stime >=2 and ! file_exists("log.1")){
-           if($GLOBALS["debug"]) echo "time out "."<br>";
+        $ctime = time();
+        if ($ctime - $stime >= 2 and !file_exists("log.1")) {
+           if ($GLOBALS["debug"]) echo "time out "."<br>";
            terminate_job($p);
            break;
         } 
         if (file_exists("log.1")) {
             list($avg_cpu, $test_steps) = calc_step_cpu("log.1");
             if ($avg_cpu != 0) {
-                if($GLOBALS["debug"])echo "avg_cpu is ".$avg_cpu."<br>";
+                if ($GLOBALS["debug"])echo "avg_cpu is ".$avg_cpu."<br>";
                 terminate_job($p);
                 $test_result = 1;
                 break;
@@ -87,32 +87,32 @@ 
 }
 
 function get_total_steps($cmd_file) {
-    $fd = fopen($cmd_file,"r");
+    $fd = fopen($cmd_file, "r");
     if (!$fd) {
         echo "can not open file $cmd_file\n";
         exit(-1);
     }
     $this_loopno = 1;
     $this_looprun = 1;
-    $total_steps=1;
+    $total_steps = 1;
     while (!feof($fd)) {
-        $line = fgets($fd,4096);
+        $line = fgets($fd, 4096);
         if (preg_match("/loopnumber\s+\d+/", $line, $matches)
             && preg_match("/\d+/", $matches[0], $no)
         ) {
-            $this_loopno=$no[0];
+            $this_loopno = $no[0];
         }
         if (preg_match("/looprun\s+\d+/", $line, $matches)
             and preg_match("/\d+/", $matches[0], $no)
         ) {
-            $this_looprun=$no[0];
-            if($this_loopno*$this_looprun>$total_steps)$total_steps=$this_loopno*$this_looprun;
+            $this_looprun = $no[0];
+            if ($this_loopno*$this_looprun > $total_steps)$total_steps = $this_loopno*$this_looprun;
         }
 
     }
     fclose($fd);
     //$total_steps = $loopno*$looprun;
-     if($GLOBALS["debug"])print "total_steps = ".$total_steps."<br>";
+     if ($GLOBALS["debug"])print "total_steps = ".$total_steps."<br>";
     return $total_steps;
 }
 
@@ -130,8 +130,8 @@ 
     }
     $count = 0;
     while (!feof($fd)) {
-        $line = fgets($fd,4096);
-        if (preg_match('/^Step\s+CPU/',$line)) {
+        $line = fgets($fd, 4096);
+        if (preg_match('/^Step\s+CPU/', $line)) {
             //echo $line."\n";
             $start = 1;
             continue;
@@ -140,24 +140,24 @@ 
         $arr = preg_split("/\s+/", $line);
         //print_r($arr);
 
-        if (count($arr) <=6 || !is_numeric($arr[1])) {
+        if (count($arr) <= 6 || !is_numeric($arr[1])) {
             continue;
         }
         $step = (int)$arr[1];
         $cpu = (float)$arr[2];
         //echo "step=".$step." cpu=".$cpu."\n";
-        if ($cpu==0) {
-           $count=0;
+        if ($cpu == 0) {
+           $count = 0;
            $start_step = $step;
         } else {
-            $count+=1;
-            if($GLOBALS["debug"])echo "step=".$step." cpu=".$cpu."count=".$count."<br>";
-           if($count >= 10) {
+            $count += 1;
+            if ($GLOBALS["debug"])echo "step=".$step." cpu=".$cpu."count=".$count."<br>";
+           if ($count >= 10) {
                 $end_step = $step;
-                $steps = $end_step-$start_step;
+                $steps = $end_step - $start_step;
                 $avg_cpu = $cpu/$steps;
                 #$avg_cpu = $cpu/$count;
-                if ($GLOBALS["debug"]){
+                if ($GLOBALS["debug"]) {
                     echo "test steps is ".$steps."<br>";
                     echo "avg_cpu is ".$avg_cpu."<br>";
                 }
@@ -166,56 +166,56 @@ 
             }
         }
     }
-    return array($avg_cpu,$test_steps);
+    return array($avg_cpu, $test_steps);
 }
 
-function calc_est_size($lammps_script, $structure_file, $cmd_file,$test_steps){
+function calc_est_size($lammps_script, $structure_file, $cmd_file, $test_steps) {
     $dump_types = 0;
-    $fd = fopen($lammps_script,"r");
-    if (!$fd){
+    $fd = fopen($lammps_script, "r");
+    if (!$fd) {
         echo "can not open file $lammps_script\n";
         exit(-1);
     }
-    while (!feof($fd)){
+    while (!feof($fd)) {
         $line = fgets($fd, 4096);
         //if (preg_match("/^\s*dump/", $line)
         //    and preg_match_all("/dump\S+\.\w{3}/", $line, $matches, PREG_PATTERN_ORDER))
         
-        if(preg_match("/^\s*dump\s+(\d)\s+/", $line,$matches))
+        if (preg_match("/^\s*dump\s+(\d)\s+/", $line, $matches))
         {        
-             if($GLOBALS["debug"]){print "matches=";print_r($matches);}
+             if ($GLOBALS["debug"]) {print "matches="; print_r($matches); }
 
-            $dump_types=(int)$matches[1];
+            $dump_types = (int)$matches[1];
             break;
         }
     }
     fclose($fd);
-    if($GLOBALS["debug"])print "dump_types= ".$dump_types."<br>";
+    if ($GLOBALS["debug"])print "dump_types= ".$dump_types."<br>";
 
     $structure_file_size = filesize($structure_file);
-    $fd = fopen($cmd_file,"r");
-    if (!$fd){
+    $fd = fopen($cmd_file, "r");
+    if (!$fd) {
         echo "can not open file $cmd_file\n";
         exit(-1);
     }
-     if($GLOBALS["debug"]) print "structure_file_size=".$structure_file_size."<br>";
+     if ($GLOBALS["debug"]) print "structure_file_size=".$structure_file_size."<br>";
    
-    $loopno=1;
-    $looprun=1;
-    while (!feof($fd)){
-        $line = fgets($fd,4096);
-        if(preg_match("/loopnumber\s+\d+/", $line, $matches)){
-            if(preg_match("/\d+/", $matches[0], $no)){
+    $loopno = 1;
+    $looprun = 1;
+    while (!feof($fd)) {
+        $line = fgets($fd, 4096);
+        if (preg_match("/loopnumber\s+\d+/", $line, $matches)) {
+            if (preg_match("/\d+/", $matches[0], $no)) {
                 //$loopno=$no[0];
-                if($no[0]>$loopno)$loopno=$no[0];
+                if ($no[0] > $loopno)$loopno = $no[0];
             }
         }
         if (preg_match("/looprun\s+\d+/", $line, $matches) and preg_match("/\d+/", $matches[0], $no)) {
-            if($no[0]>$looprun)$looprun=$no[0];
+            if ($no[0] > $looprun)$looprun = $no[0];
         }
     }
     fclose($fd);
-    if($GLOBALS["debug"]){
+    if ($GLOBALS["debug"]) {
          print "max loopno(number of loops to run)=".$loopno."<br>";
          print "max looprun(steps for each loop)=".$looprun."<br>";
     }
@@ -226,12 +226,12 @@ 
     $dump_files = glob("dump1*");
     $test_dump_file = $dump_files[0];
     $test_dump_size = filesize($test_dump_file);
-    $dump_size1 = $test_dump_size+0.5*$test_dump_size*ceil(($looprun-$test_steps)/$test_steps);
+    $dump_size1 = $test_dump_size + 0.5*$test_dump_size*ceil(($looprun - $test_steps)/$test_steps);
     $dump_size = $loopno*$dump_size1*$dump_types;
     $app_fixed_size = 5e7;
-    $est_size = $log_size+$dump_size+$app_fixed_size;
+    $est_size = $log_size + $dump_size + $app_fixed_size;
     
-    if($GLOBALS["debug"]){
+    if ($GLOBALS["debug"]) {
         print "test_steps=".$test_steps."<br>";
         print "test_log_size=".$test_log_size."<br>";
         print "log_size1=".$log_size1."<br>";
@@ -322,7 +322,7 @@ 
     if ($njobs < $nhosts) {
         return $flops_per_job/$median_flops;
     } else {
-        $k = (int)(($njobs+$nhosts-1)/$nhosts);
+        $k = (int)(($njobs + $nhosts - 1)/$nhosts);
         return $k*$flops_per_job/$median_flops;
     }
 }
@@ -362,27 +362,27 @@ 
     if ($GLOBALS["debug"]) {
         print "est_cpu_time is ".$est_cpu_time."<br>";
     }
-    if ($error==0) {
-        $err_msgs=file("output");
-        $err="Your test job <strong>failed</strong>
+    if ($error == 0) {
+        $err_msgs = file("output");
+        $err = "Your test job <strong>failed</strong>
             <br>Please refer to the following Error Message:<br><p>
         ";
-        foreach($err_msgs as $line){
-             $err=$err.$line."<br>";
+        foreach ($err_msgs as $line) {
+             $err = $err.$line."<br>";
         }
-        $err=$err." <p>
+        $err = $err." <p>
             <a href=sandbox.php><strong> File_Sandbox </strong></a>
         ";
         error_page($err);
     }
 
     system("rm *");
-    $info->rsc_fpops_est = $est_cpu_time * 1.5e9;
-    $info->rsc_fpops_bound = $info->rsc_fpops_est * 20;
+    $info->rsc_fpops_est = $est_cpu_time*1.5e9;
+    $info->rsc_fpops_bound = $info->rsc_fpops_est*20;
     
-    if ($disk==0){
-        $info->rsc_disk_bound=1000000;
-    } else{
+    if ($disk == 0) {
+        $info->rsc_disk_bound = 1000000;
+    } else {
         $info->rsc_disk_bound = $disk;
     }
 
@@ -393,7 +393,7 @@ 
     //
     $njobs = count(file($cmdline_file_path));
     $secs_est = estimated_makespan($njobs, $info->rsc_fpops_est);
-     if($GLOBALS["debug"])echo "secs_est is $secs_est\n";
+     if ($GLOBALS["debug"])echo "secs_est is $secs_est\n";
     //assume the server's flops is 1.5G and the average client's flops is 1G
     $hrs_est = number_format($secs_est*1.5/60, 2);
     //$hrs_est = number_format($secs_est, 2);
@@ -417,8 +417,8 @@ 
 }
 
 function submit_job($app, $batch_id, $info, $cmdline, $i) {
-    $client_disk=$info->rsc_disk_bound*2;
-    if($client_disk<500000000) $client_disk=500000000;
+    $client_disk = $info->rsc_disk_bound*2;
+    if ($client_disk < 500000000) $client_disk = 500000000;
     $cmd = "cd ../..; ./bin/create_work --appname $app->name --batch $batch_id --rsc_fpops_est $info->rsc_fpops_est --rsc_fpops_bound $info->rsc_fpops_bound --rsc_disk_bound $client_disk";
     if ($cmdline) {
         $cmd .= " --command_line \"$cmdline\"";
@@ -442,9 +442,9 @@ 
     $x = file_get_contents("$tmpfile");
     $info = unserialize($x);
 
-    $njobs=0;
+    $njobs = 0;
     $cmdlines = file($info->cmdline_file_path);
-    foreach ($cmdlines as $cmdline){
+    foreach ($cmdlines as $cmdline) {
         if (preg_match("/^\s*-var/", $cmdline)) {
             $njobs++;
         }
@@ -460,7 +460,7 @@ 
 
     $i = 0;
     foreach ($cmdlines as $cmdline) {
-        if (preg_match("/^\s*-var/", $cmdline)){
+        if (preg_match("/^\s*-var/", $cmdline)) {
             submit_job($app, $batch_id, $info, $cmdline, $i);
             $i++;
         }

Braces +19 added lines, -20 removed lines

@@ -38,8 +38,8 @@ 
      proc_terminate($p);
     // echo "child process is $ret\n";
     $pids=preg_split('/\s+/',$ret);
-    foreach($pids as $pid){
-        if(is_numeric($pid)){
+    foreach($pids as $pid) {
+        if(is_numeric($pid)) {
             if($GLOBALS["debug"])echo "killing child process $pid\n";
             posix_kill($pid,9);
         }
@@ -60,7 +60,7 @@ 
     $p = proc_open("$cmd", $descs, $pipes);
     while (1) {
         $ctime=time();
-        if($ctime-$stime >=2 and ! file_exists("log.1")){
+        if($ctime-$stime >=2 and ! file_exists("log.1")) {
            if($GLOBALS["debug"]) echo "time out "."<br>";
            terminate_job($p);
            break;
@@ -157,7 +157,7 @@ 
                 $steps = $end_step-$start_step;
                 $avg_cpu = $cpu/$steps;
                 #$avg_cpu = $cpu/$count;
-                if ($GLOBALS["debug"]){
+                if ($GLOBALS["debug"]) {
                     echo "test steps is ".$steps."<br>";
                     echo "avg_cpu is ".$avg_cpu."<br>";
                 }
@@ -169,20 +169,19 @@ 
     return array($avg_cpu,$test_steps);
 }
 
-function calc_est_size($lammps_script, $structure_file, $cmd_file,$test_steps){
+function calc_est_size($lammps_script, $structure_file, $cmd_file,$test_steps) {
     $dump_types = 0;
     $fd = fopen($lammps_script,"r");
-    if (!$fd){
+    if (!$fd) {
         echo "can not open file $lammps_script\n";
         exit(-1);
     }
-    while (!feof($fd)){
+    while (!feof($fd)) {
         $line = fgets($fd, 4096);
         //if (preg_match("/^\s*dump/", $line)
         //    and preg_match_all("/dump\S+\.\w{3}/", $line, $matches, PREG_PATTERN_ORDER))
         
-        if(preg_match("/^\s*dump\s+(\d)\s+/", $line,$matches))
-        {        
+        if(preg_match("/^\s*dump\s+(\d)\s+/", $line,$matches)) {
              if($GLOBALS["debug"]){print "matches=";print_r($matches);}
 
             $dump_types=(int)$matches[1];
@@ -194,7 +193,7 @@ 
 
     $structure_file_size = filesize($structure_file);
     $fd = fopen($cmd_file,"r");
-    if (!$fd){
+    if (!$fd) {
         echo "can not open file $cmd_file\n";
         exit(-1);
     }
@@ -202,10 +201,10 @@ 
    
     $loopno=1;
     $looprun=1;
-    while (!feof($fd)){
+    while (!feof($fd)) {
         $line = fgets($fd,4096);
-        if(preg_match("/loopnumber\s+\d+/", $line, $matches)){
-            if(preg_match("/\d+/", $matches[0], $no)){
+        if(preg_match("/loopnumber\s+\d+/", $line, $matches)) {
+            if(preg_match("/\d+/", $matches[0], $no)) {
                 //$loopno=$no[0];
                 if($no[0]>$loopno)$loopno=$no[0];
             }
@@ -215,7 +214,7 @@ 
         }
     }
     fclose($fd);
-    if($GLOBALS["debug"]){
+    if($GLOBALS["debug"]) {
          print "max loopno(number of loops to run)=".$loopno."<br>";
          print "max looprun(steps for each loop)=".$looprun."<br>";
     }
@@ -231,7 +230,7 @@ 
     $app_fixed_size = 5e7;
     $est_size = $log_size+$dump_size+$app_fixed_size;
     
-    if($GLOBALS["debug"]){
+    if($GLOBALS["debug"]) {
         print "test_steps=".$test_steps."<br>";
         print "test_log_size=".$test_log_size."<br>";
         print "log_size1=".$log_size1."<br>";
@@ -367,7 +366,7 @@ 
         $err="Your test job <strong>failed</strong>
             <br>Please refer to the following Error Message:<br><p>
         ";
-        foreach($err_msgs as $line){
+        foreach($err_msgs as $line) {
              $err=$err.$line."<br>";
         }
         $err=$err." <p>
@@ -380,9 +379,9 @@ 
     $info->rsc_fpops_est = $est_cpu_time * 1.5e9;
     $info->rsc_fpops_bound = $info->rsc_fpops_est * 20;
     
-    if ($disk==0){
+    if ($disk==0) {
         $info->rsc_disk_bound=1000000;
-    } else{
+    } else {
         $info->rsc_disk_bound = $disk;
     }
 
@@ -444,7 +443,7 @@ 
 
     $njobs=0;
     $cmdlines = file($info->cmdline_file_path);
-    foreach ($cmdlines as $cmdline){
+    foreach ($cmdlines as $cmdline) {
         if (preg_match("/^\s*-var/", $cmdline)) {
             $njobs++;
         }
@@ -460,7 +459,7 @@ 
 
     $i = 0;
     foreach ($cmdlines as $cmdline) {
-        if (preg_match("/^\s*-var/", $cmdline)){
+        if (preg_match("/^\s*-var/", $cmdline)) {
             submit_job($app, $batch_id, $info, $cmdline, $i);
             $i++;
         }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -430,7 +430,7 @@
     //echo "<br> $cmd\n"; 
 
     system($cmd, $ret);
-    if ($ret === FALSE) {
+    if ($ret === false) {
         error_page("can't create job");
     } else {
         header('Location: submit.php');