BOINC / boinc

html/inc/forum.inc

Spacing +85 added lines, -85 removed lines

@@ -24,7 +24,7 @@ 
 require_once("../inc/text_transform.inc");
 
 define('THREADS_PER_PAGE', 50);
-define('FORUM_LH_PCT', '25%');      // width of LH column
+define('FORUM_LH_PCT', '25%'); // width of LH column
 
 $forum_error = "";
     // for functions that return null on error,
@@ -55,7 +55,7 @@ 
 define('THREAD_SOLVED', 1);
 
 define('AVATAR_WIDTH', 100);
-define('AVATAR_HEIGHT',100);
+define('AVATAR_HEIGHT', 100);
 
 define('ST_NEW_TIME', 1209600); //3600*24*14 - 14 days
 define('ST_NEW', 'New member');
@@ -80,24 +80,24 @@ 
 define('IMAGE_HIDDEN', 'img/hidden.png');
 define('IMAGE_STICKY_LOCKED', 'img/sticky_locked_post.png');
 define('IMAGE_POST', 'img/post.png');
-define('NEW_IMAGE_HEIGHT','15');
+define('NEW_IMAGE_HEIGHT', '15');
 define('EMPHASIZE_IMAGE', 'img/emphasized_post.png');
-define('EMPHASIZE_IMAGE_HEIGHT','15');
+define('EMPHASIZE_IMAGE_HEIGHT', '15');
 define('FILTER_IMAGE', 'img/filtered_post.png');
-define('FILTER_IMAGE_HEIGHT','15');
+define('FILTER_IMAGE_HEIGHT', '15');
 define('RATE_POSITIVE_IMAGE', 'img/rate_positive.png');
-define('RATE_POSITIVE_IMAGE_HEIGHT','9');
+define('RATE_POSITIVE_IMAGE_HEIGHT', '9');
 define('RATE_NEGATIVE_IMAGE', 'img/rate_negative.png');
-define('RATE_NEGATIVE_IMAGE_HEIGHT','9');
+define('RATE_NEGATIVE_IMAGE_HEIGHT', '9');
 define('REPORT_POST_IMAGE', 'img/report_post.png');
-define('REPORT_POST_IMAGE_HEIGHT','9');
+define('REPORT_POST_IMAGE_HEIGHT', '9');
 
 define('SOLUTION', tra('This answered my question'));
 define('SUFFERER', tra('I also have this question'));
 define('OFF_TOPIC', tra('Off-topic'));
 
-define ('DEFAULT_LOW_RATING_THRESHOLD', -25);
-define ('DEFAULT_HIGH_RATING_THRESHOLD', 5);
+define('DEFAULT_LOW_RATING_THRESHOLD', -25);
+define('DEFAULT_HIGH_RATING_THRESHOLD', 5);
 
 // special user attributes
 //
@@ -175,15 +175,15 @@ 
 
 // return forum/thread title, with links.
 //
-function forum_title($category, $forum, $thread, $link_thread=false) {
+function forum_title($category, $forum, $thread, $link_thread = false) {
     if ($category) {
         $is_helpdesk = $category->is_helpdesk;
     } else {
         $is_helpdesk = false;
     }
 
-    $where = $is_helpdesk?tra("Questions and Answers"):tra("Message boards");
-    $top_url = $is_helpdesk?"forum_help_desk.php":"forum_index.php";
+    $where = $is_helpdesk ?tra("Questions and Answers") : tra("Message boards");
+    $top_url = $is_helpdesk ? "forum_help_desk.php" : "forum_index.php";
 
     $x = '';
     if (!$forum && !$thread) {
@@ -217,7 +217,7 @@ 
     return $x;
 }
 
-function team_forum_title($forum, $thread=null, $link_thread=false) {
+function team_forum_title($forum, $thread = null, $link_thread = false) {
     $team = BoincTeam::lookup_id($forum->category);
     $x = sprintf('<a href="forum_index.php">%s</a> :',
         tra("Message boards")
@@ -251,12 +251,12 @@ 
 }
 
 function page_link($url, $page_num, $items_per_page, $text) {
-    return " <a href=\"$url&amp;start=" . $page_num*$items_per_page . "\">$text</a> ";
+    return " <a href=\"$url&amp;start=".$page_num*$items_per_page."\">$text</a> ";
 }
 
 // return a string for navigating pages
 //
-function page_links($url, $nitems, $items_per_page, $start){
+function page_links($url, $nitems, $items_per_page, $start) {
     // How many pages to potentially show before and after this one:
     $preshow = 3;
     $postshow = 3;
@@ -264,14 +264,14 @@ 
     $x = "";
 
     if ($nitems <= $items_per_page) return "";
-    $npages = ceil($nitems / $items_per_page);
-    $curpage = ceil($start / $items_per_page);
+    $npages = ceil($nitems/$items_per_page);
+    $curpage = ceil($start/$items_per_page);
 
     // If this is not the first page, display "previous"
     //
-    if ($curpage > 0){
+    if ($curpage > 0) {
         $x .= page_link(
-            $url, $curpage-1, $items_per_page,
+            $url, $curpage - 1, $items_per_page,
             tra("Previous")." &middot; "
         );
     }
@@ -286,8 +286,8 @@ 
     }
     // Display a list of pages surrounding this one
     //
-    for ($i=$curpage-$preshow; $i<=$curpage+$postshow; $i++){
-        $page_str = (string)($i+1);
+    for ($i = $curpage - $preshow; $i <= $curpage + $postshow; $i++) {
+        $page_str = (string)($i + 1);
         if ($i < 0) continue;
         if ($i >= $npages) break;
 
@@ -296,20 +296,20 @@ 
         } else {
             $x .= page_link($url, $i, $items_per_page, $page_str);
         }
-        if ($i == $npages-1) break;
-        if ($i == $curpage+$postshow) break;
+        if ($i == $npages - 1) break;
+        if ($i == $curpage + $postshow) break;
         $x .= " &middot; ";
     }
 
-    if ($curpage + $postshow < $npages-1) {
+    if ($curpage + $postshow < $npages - 1) {
         $x .= " . . . ";
-        $x .= page_link($url, $npages-1, $items_per_page, $npages);
+        $x .= page_link($url, $npages - 1, $items_per_page, $npages);
     }
     // If there is a next page
     //
-    if ($curpage < $npages-1){
+    if ($curpage < $npages - 1) {
         $x .= page_link(
-            $url, $curpage+1, $items_per_page,
+            $url, $curpage + 1, $items_per_page,
             " &middot; ".tra("Next")
         );
     }
@@ -330,7 +330,7 @@ 
 function cleanup_title($title) {
     $x = sanitize_tags(bb2html($title));
     $x = trim($x);
-    if (strlen($x)==0) return "(no title)";
+    if (strlen($x) == 0) return "(no title)";
     else return $x;
 }
 
@@ -392,7 +392,7 @@ 
             $i = 0;
             foreach ($posts as $post) {
                 if ($post->id == $postid) {
-                    $start = $i - ($i % $num_to_show);
+                    $start = $i - ($i%$num_to_show);
                     $jump_to_post = $post;
                     break;
                 }
@@ -419,7 +419,7 @@ 
             // if jump to post, figure out what page to show
             //
             if ($jump_to_post) {
-                $start = $ibest - ($ibest % $num_to_show);
+                $start = $ibest - ($ibest%$num_to_show);
             } else {
                 $start = $default_start;
             }
@@ -527,8 +527,8 @@ 
 // Generates a table row with two cells: author and message
 //
 function show_post(
-    $post, $thread, $forum, $logged_in_user, $start=0,
-    $latest_viewed=0, $controls=FORUM_CONTROLS, $filter=true
+    $post, $thread, $forum, $logged_in_user, $start = 0,
+    $latest_viewed = 0, $controls = FORUM_CONTROLS, $filter = true
 ) {
     global $country_to_iso3166_2;
 
@@ -536,7 +536,7 @@ 
 
     // If the user no longer exists, skip the post
     //
-    if (!$user){
+    if (!$user) {
         return;
     }
 
@@ -557,9 +557,9 @@ 
     // check whether the poster is on the list of people to ignore
     //
     $ignore_poster = false;
-    if ($logged_in_user){
+    if ($logged_in_user) {
         $tokens = url_tokens($logged_in_user->authenticator);
-        if (is_ignoring($logged_in_user, $user)){
+        if (is_ignoring($logged_in_user, $user)) {
             $ignore_poster = true;
         }
     }
@@ -573,8 +573,8 @@ 
             if (is_moderator($logged_in_user, $forum)) {
                 $can_edit = true;
             } else if (can_reply($thread, $forum, $logged_in_user)) {
-                $time_limit = $post->timestamp+MAXIMUM_EDIT_TIME;
-                $can_edit = time()<$time_limit;
+                $time_limit = $post->timestamp + MAXIMUM_EDIT_TIME;
+                $can_edit = time() < $time_limit;
             } else {
                 $can_edit = false;
             }
@@ -584,24 +584,24 @@ 
     // Print the special user lines, if any
     //
     global $special_user_bitfield;
-    $fstatus="";
+    $fstatus = "";
     $keys = array_keys($special_user_bitfield);
     $is_posted_by_special = false;
-    for ($i=0; $i<sizeof($special_user_bitfield);$i++) {
+    for ($i = 0; $i < sizeof($special_user_bitfield); $i++) {
         if ($user->prefs && $user->prefs->privilege($keys[$i])) {
-            $fstatus.="<nobr>".$special_user_bitfield[$keys[$i]]."<nobr><br>";
+            $fstatus .= "<nobr>".$special_user_bitfield[$keys[$i]]."<nobr><br>";
             $is_posted_by_special = true;
         }
     }
 
     // Highlight special users if set in prefs;
     //
-    if ($logged_in_user && $logged_in_user->prefs){
+    if ($logged_in_user && $logged_in_user->prefs) {
         $highlight = $logged_in_user->prefs->highlight_special && $is_posted_by_special;
     } else {
         $highlight = $is_posted_by_special;
     }
-    $class = $highlight?' style="border-left: 5px solid LightGreen" ':'';
+    $class = $highlight ? ' style="border-left: 5px solid LightGreen" ' : '';
 
     // row and start of author col
     //
@@ -613,12 +613,12 @@ 
 
     echo user_links($user, 0, 30);
     echo "<br>";
-    if ($user->create_time > time()-ST_NEW_TIME) $fstatus.=ST_NEW."<br>";
+    if ($user->create_time > time() - ST_NEW_TIME) $fstatus .= ST_NEW."<br>";
     echo "<span class=\"small\">";
     if ($fstatus) echo "$fstatus";
 
-    if (!$filter || !$ignore_poster){
-        if ($user->prefs && $user->prefs->avatar!="" && (!$logged_in_user || ($logged_in_user->prefs->hide_avatars==false))) {
+    if (!$filter || !$ignore_poster) {
+        if ($user->prefs && $user->prefs->avatar != "" && (!$logged_in_user || ($logged_in_user->prefs->hide_avatars == false))) {
             echo "<img width=\"".AVATAR_WIDTH."\" height=\"".AVATAR_HEIGHT."\" src=\"".avatar_url($user->prefs->avatar)."\" alt=\"Avatar\"><br>";
         }
     }
@@ -626,14 +626,14 @@ 
 
     $url = "pm.php?action=new&amp;userid=".$user->id;
     $name = $user->name;
-    show_button_small($url, tra("Send message"), tra("Send %1 a private message",$name));
+    show_button_small($url, tra("Send message"), tra("Send %1 a private message", $name));
     echo '<br>'.tra("Joined: %1", gmdate('j M y', $user->create_time)), "<br>";
 
     if (!isset($user->nposts)) {
         $user->nposts = BoincPost::count("user=$user->id");
     }
 
-    if (function_exists('project_forum_user_info')){
+    if (function_exists('project_forum_user_info')) {
         project_forum_user_info($user);
     } else {
         echo tra("Posts: %1", $user->nposts)."<br>";
@@ -642,8 +642,8 @@ 
         //
         //echo "ID: ".$user->id."<br>";
         if (!NO_COMPUTING) {
-            echo tra("Credit: %1", number_format($user->total_credit)) ."<br>";
-            echo tra("RAC: %1",    number_format($user->expavg_credit))."<br>";
+            echo tra("Credit: %1", number_format($user->total_credit))."<br>";
+            echo tra("RAC: %1", number_format($user->expavg_credit))."<br>";
         }
 
         // to use this feature:
@@ -672,7 +672,7 @@ 
         echo "<form action=\"forum_rate.php?post=", $post->id, "\" method=\"post\">";
     }
 
-    if ($logged_in_user && $post->timestamp > $latest_viewed){
+    if ($logged_in_user && $post->timestamp > $latest_viewed) {
         show_image(NEW_IMAGE, tra("You haven't read this message yet"), tra("Unread"), NEW_IMAGE_HEIGHT);
     }
 
@@ -692,8 +692,8 @@ 
     if ($post->modified) {
         echo "<br>".tra("Last modified: %1", pretty_time_Str($post->modified));
     }
-    if ($ignore_poster && $filter){
-        echo "<br>" .tra(
+    if ($ignore_poster && $filter) {
+        echo "<br>".tra(
             "This post is hidden because the sender is on your 'ignore' list.  Click %1 here %2 to view hidden posts",
             "<a href=\"?id=".$thread->id."&amp;filter=false&amp;start=$start#".$post->id."\">",
             "</a>"
@@ -706,7 +706,7 @@ 
         <p>
     ";
 
-    if (!$filter || !$ignore_poster){
+    if (!$filter || !$ignore_poster) {
         $posttext = $post->content;
 
         // If the creator of this post has a signature and
@@ -714,7 +714,7 @@ 
         // user has signatures enabled: show it
         //
         $posttext = output_transform($posttext, $options);
-        if ($post->signature && (!$logged_in_user || !$logged_in_user->prefs->hide_signatures)){
+        if ($post->signature && (!$logged_in_user || !$logged_in_user->prefs->hide_signatures)) {
             $sig = output_transform($user->prefs->signature, $options);
             $posttext .= "<hr>$sig\n";
         }
@@ -748,10 +748,10 @@ 
         }
         if (($controls == FORUM_CONTROLS) && (can_reply($thread, $forum, $logged_in_user))) {
             echo "&nbsp;&nbsp;&nbsp;&nbsp;";
-            $url = "forum_reply.php?thread=" . $thread->id . "&amp;post=" . $post->id . "&amp;no_quote=1#input";
+            $url = "forum_reply.php?thread=".$thread->id."&amp;post=".$post->id."&amp;no_quote=1#input";
             // "Reply" is used as a verb
             show_button($url, tra("Reply"), tra("Post a reply to this message"));
-            $url = "forum_reply.php?thread=" . $thread->id . "&amp;post=" . $post->id . "#input";
+            $url = "forum_reply.php?thread=".$thread->id."&amp;post=".$post->id."#input";
             // "Quote" is used as a verb
             show_button($url, tra("Quote"), tra("Post a reply by quoting this message"));
         }
@@ -773,7 +773,7 @@ 
     $content = output_transform($post->content, $options);
     $when = time_diff_str($post->timestamp, time());
     $user = BoincUser::lookup_id($post->user);
-    if (!$user){
+    if (!$user) {
         return;
     }
 
@@ -787,10 +787,10 @@ 
     switch ($forum->parent_type) {
     case 0:
         $category = BoincCategory::lookup_id($forum->category);
-        $title= forum_title($category, $forum, $thread, true);
+        $title = forum_title($category, $forum, $thread, true);
         break;
     case 1:
-        $title= team_forum_title($forum);
+        $title = team_forum_title($forum);
         break;
     }
     row_array([
@@ -828,9 +828,9 @@ 
 function post_rules() {
     if (defined('FORUM_RULES')) return FORUM_RULES;
     if (function_exists("project_forum_post_rules")) {
-      $project_rules=project_forum_post_rules();
+      $project_rules = project_forum_post_rules();
     } else {
-      $project_rules="";
+      $project_rules = "";
     }
     return sprintf("
         <ul>
@@ -859,7 +859,7 @@ 
     );
 }
 
-function post_warning($forum=null) {
+function post_warning($forum = null) {
     $x = '<p><div style="text-align:left">';
 
     // let projects add extra instructions in specific forums,
@@ -945,7 +945,7 @@ 
     $content = substr($content, 0, 64000);
     $content = BoincDb::escape_string($content);
     $now = time();
-    $sig = $signature?1:0;
+    $sig = $signature ? 1 : 0;
     $id = BoincPost::insert("(thread, user, timestamp, content, modified, parent_post, score, votes, signature, hidden) values ($thread->id, $user->id, $now, '$content', 0, $parent_id, 0, 0, $sig, 0)");
     if (!$id) {
         $forum_error = "Failed to add post to DB.";
@@ -965,7 +965,7 @@ 
 //
 function update_thread_timestamp($thread) {
     $posts = BoincPost::enum("thread=$thread->id and hidden=0 order by timestamp desc limit 1");
-    if (count($posts)>0) {
+    if (count($posts) > 0) {
         $post = $posts[0];
         $thread->update("timestamp=$post->timestamp");
     }
@@ -973,7 +973,7 @@ 
 
 function update_forum_timestamp($forum) {
     $threads = BoincThread::enum("forum=$forum->id and hidden=0 order by timestamp desc limit 1");
-    if (count($threads)>0) {
+    if (count($threads) > 0) {
         $thread = $threads[0];
         $forum->update("timestamp=$thread->timestamp");
     }
@@ -996,7 +996,7 @@ 
     if (is_news_forum($forum) && !$export) {
         $status = 1;
     }
-    $id  = BoincThread::insert("(forum, owner, status, title, timestamp, views, replies, activity, sufferers, score, votes, create_time, hidden, sticky, locked) values ($forum->id, $user->id, $status, '$title', $now, 0, -1, 0, 0, 0, 0, $now, 0, 0, 0)");
+    $id = BoincThread::insert("(forum, owner, status, title, timestamp, views, replies, activity, sufferers, score, votes, create_time, hidden, sticky, locked) values ($forum->id, $user->id, $status, '$title', $now, 0, -1, 0, 0, 0, 0, $now, 0, 0, 0)");
     if (!$id) {
         $forum_error = "Failed to add thread to DB.";
         return null;
@@ -1125,22 +1125,22 @@ 
 // $sticky - bool (not directly passed to SQL)
 //
 function get_forum_threads(
-    $forumID, $start=-1, $nRec=-1, $sort_style=MODIFIED_NEW,
+    $forumID, $start = -1, $nRec = -1, $sort_style = MODIFIED_NEW,
     $show_hidden = 0, $sticky = 1
 ) {
     //if (! (is_numeric($forumID) && is_numeric($min) && is_numeric($nRec))) {
     //    return NULL;  // Something is wrong here.
     //}
 
-    $sql = 'forum = ' . $forumID ;
+    $sql = 'forum = '.$forumID;
     $stickysql = "";
-    if ($sticky){
+    if ($sticky) {
         $stickysql = "sticky DESC, ";
     }
     if (!$show_hidden) {
         $sql .= ' AND hidden = 0';
     }
-    switch($sort_style) {
+    switch ($sort_style) {
     case MODIFIED_NEW:
         $sql .= ' ORDER BY '.$stickysql.'timestamp DESC';
         break;
@@ -1193,7 +1193,7 @@ 
     if (!$show_hidden) {
         $sql .= ' AND hidden = 0';
     }
-    switch($sort_style) {
+    switch ($sort_style) {
     case CREATE_TIME_NEW:
         $sql .= ' ORDER BY timestamp desc';
         break;
@@ -1215,7 +1215,7 @@ 
 //
 function show_post_moderation_links(
     $config, $logged_in_user, $post, $forum, $tokens
-){
+) {
     $moderators_allowed_to_ban = parse_bool($config, "moderators_allowed_to_ban");
     $moderators_vote_to_ban = parse_bool($config, "moderators_vote_to_ban");
 
@@ -1302,14 +1302,14 @@ 
     // We do not tell the (ab)user how much this is -
     // no need to make it easy for them to break the system.
     //
-    if ($user->total_credit<$forum->post_min_total_credit || $user->expavg_credit<$forum->post_min_expavg_credit) {
+    if ($user->total_credit < $forum->post_min_total_credit || $user->expavg_credit < $forum->post_min_expavg_credit) {
         error_page(tra("To create a new thread in %1 you must have a certain level of average credit. This is to protect against abuse of the system.", $forum->title));
     }
 
     // If the user is posting faster than forum regulations allow
     // Tell the user to wait a while before creating any more posts
     //
-    if (time()-$user->prefs->last_post <$forum->post_min_interval) {
+    if (time() - $user->prefs->last_post < $forum->post_min_interval) {
         error_page(tra("You cannot create threads right now. Please wait before trying again. This is to protect against abuse of the system."));
     }
 }
@@ -1335,10 +1335,10 @@ 
 // - edit their posts at any time
 // - hide/unhide/move threads and posts
 
-function is_moderator($user, $forum=null) {
+function is_moderator($user, $forum = null) {
     if (!$user) return false;
     BoincForumPrefs::lookup($user);
-    $type = $forum?$forum->parent_type:0;
+    $type = $forum ? $forum->parent_type : 0;
     switch ($type) {
     case 0:
         if ($user->prefs->privilege(S_MODERATOR)) return true;
@@ -1355,7 +1355,7 @@ 
     return false;
 }
 
-function thread_list_header($subscriptions=false) {
+function thread_list_header($subscriptions = false) {
     if ($subscriptions) {
         $x = [
             tra("Thread"),
@@ -1378,13 +1378,13 @@ 
 // show a 1-line summary of thread and its forum.
 // Used for search results and subscription list
 //
-function thread_list_item($thread, $user, $subscriptions=false) {
+function thread_list_item($thread, $user, $subscriptions = false) {
     $thread_forum = BoincForum::lookup_id($thread->forum);
     if (!$thread_forum) return;
     if (!is_forum_visible_to_user($thread_forum, $user)) return;
     $owner = BoincUser::lookup_id($thread->owner);
     if (!$owner) return;
-    switch($thread_forum->parent_type) {
+    switch ($thread_forum->parent_type) {
     case 0:
         $category = BoincCategory::lookup_id($thread_forum->category);
         $title = forum_title($category, $thread_forum, $thread, true);
@@ -1405,7 +1405,7 @@ 
     } else {
         $x = [
             $title,
-            $thread->replies+1,
+            $thread->replies + 1,
             user_links($owner),
             $thread->views,
             time_diff_str($thread->timestamp, time())
@@ -1440,13 +1440,13 @@ 
 
 function subscribed_thread_web_line($notify) {
     $thread = BoincThread::lookup_id($notify->opaque);
-    return tra("New posts in the thread %1","<a href=forum_thread.php?id=$thread->id>$thread->title</a>");
+    return tra("New posts in the thread %1", "<a href=forum_thread.php?id=$thread->id>$thread->title</a>");
 }
 
 function subscribed_thread_rss($notify) {
     $thread = BoincThread::lookup_id($notify->opaque);
     $title = tra("New posts in subscribed thread");
-    $msg = tra("There are new posts in the thread '%1'",$thread->title);
+    $msg = tra("There are new posts in the thread '%1'", $thread->title);
     $url = secure_url_base()."forum_thread.php?id=$thread->id";
     return [$title, $msg, $url];
 }
@@ -1458,13 +1458,13 @@ 
 
 function subscribed_forum_web_line($notify) {
     $forum = BoincForum::lookup_id($notify->opaque);
-    return tra("New threads in the forum %1","<a href=forum_forum.php?id=$forum->id>$forum->title</a>");
+    return tra("New threads in the forum %1", "<a href=forum_forum.php?id=$forum->id>$forum->title</a>");
 }
 
 function subscribed_forum_rss($notify) {
     $forum = BoincForum::lookup_id($notify->opaque);
     $title = tra("New posts in subscribed forum");
-    $msg = tra("There are new threads in the forum '%1'",$forum->title);
+    $msg = tra("There are new threads in the forum '%1'", $forum->title);
     $url = secure_url_base()."forum_forum.php?id=$forum->id";
     return [$title, $msg, $url];
 }

html/inc/text_transform.inc

Spacing +24 added lines, -24 removed lines

@@ -26,13 +26,13 @@ 
 require_once('../inc/sanitize_html.inc');
 
 class output_options {
-    var $bb2html;            // BBCode as HTML? (on)
-    var $images_as_links;    // Images as hyperlinks? (off)
-    var $link_popup;        // Links in new windows? (off)
-    var $nl2br;                // Convert newlines to <br>'s? (on)
-    var $htmlitems;            // Convert special chars to HTML entities? (on)
-    var $htmlscrub;            // Scrub "bad" HTML tags? (off)
-    var $highlight_terms;// Array of terms to be highlighted (off)
+    var $bb2html; // BBCode as HTML? (on)
+    var $images_as_links; // Images as hyperlinks? (off)
+    var $link_popup; // Links in new windows? (off)
+    var $nl2br; // Convert newlines to <br>'s? (on)
+    var $htmlitems; // Convert special chars to HTML entities? (on)
+    var $htmlscrub; // Scrub "bad" HTML tags? (off)
+    var $highlight_terms; // Array of terms to be highlighted (off)
 
     // Constructor - set the defaults.
 
@@ -68,7 +68,7 @@ 
         $options = new output_options; // Defaults in the class definition
     }
     if ($options->htmlitems) {
-        $text = htmlspecialchars($text, ENT_COMPAT | ENT_HTML401 | ENT_SUBSTITUTE);
+        $text = htmlspecialchars($text, ENT_COMPAT|ENT_HTML401|ENT_SUBSTITUTE);
     }
     if (is_array($options->highlight_terms)) {
         $text = highlight_terms($text, $options->highlight_terms);
@@ -104,7 +104,7 @@ 
 // If $export is true, don't use BOINC CSS
 
 function substr2($s, $n1, $n2) {
-    return substr($s, $n1, $n2-$n1);
+    return substr($s, $n1, $n2 - $n1);
 }
 
 // process non-nestable constructs: [pre] and [code]
@@ -177,7 +177,7 @@ 
 
     $httpsregex = "(?:\"?)https\:\/\/([^\[\"<\ ]+)(?:\"?)";
     // List of allowable tags
-    $bbtags = array (
+    $bbtags = array(
         "@\[b\](.*?)\[/b\]@is",
         "@\[i\](.*?)\[/i\]@is",
         "@\[u\](.*?)\[/u\]@is",
@@ -206,7 +206,7 @@ 
 
     // What the above tags are turned in to
     if ($export) {
-        $htmltags = array (
+        $htmltags = array(
             "<b>\\1</b>",
             "<i>\\1</i>",
             "<u>\\1</u>",
@@ -233,7 +233,7 @@ 
             "<a href=\"https://github.com/BOINC/boinc/wiki/\\1\">\\1</a>",
         );
     } else {
-        $htmltags = array (
+        $htmltags = array(
             "<b>\\1</b>",
             "<i>\\1</i>",
             "<u>\\1</u>",
@@ -265,7 +265,7 @@ 
     $lasttext = "";
     $i = 0;
     // $i<1000 to prevent DoS
-    while ($text != $lasttext && $i<1000) {
+    while ($text != $lasttext && $i < 1000) {
         $lasttext = $text;
         $text = preg_replace($bbtags, $htmltags, $text);
         $i = $i + 1;
@@ -275,7 +275,7 @@ 
     return $text;
 }
 
-function bb2html($text, $export=false) {
+function bb2html($text, $export = false) {
     $text = replace_pre_code($text, $export);
     return bb2html_aux($text, $export);
 }
@@ -284,7 +284,7 @@ 
 // for example inside <pre> containers
 // The original \n was retained after the br when it was added
 //
-function remove_br($text){
+function remove_br($text) {
     return str_replace("<br />", "", $text);
 }
 
@@ -292,19 +292,19 @@ 
 //
 function externalize_links($text) {
     // TODO:  Convert this to PCRE
-    $i=0;
-    $linkpos=true;
+    $i = 0;
+    $linkpos = true;
     $out = "";
-    while (true){
+    while (true) {
         // Find a link
         //
-        $linkpos=strpos($text, "<a ", $i);
-        if ($linkpos===false) break;
+        $linkpos = strpos($text, "<a ", $i);
+        if ($linkpos === false) break;
 
         // Replace with target='_new'
         //
-        $out .= substr($text, $i, $linkpos-$i)."<a target=\"_new\" ";
-        $i = $linkpos+3;
+        $out .= substr($text, $i, $linkpos - $i)."<a target=\"_new\" ";
+        $i = $linkpos + 3;
     }
     $out .= substr($text, $i);
     return $out;
@@ -312,7 +312,7 @@ 
 
 // Converts image tags to links to the images.
 //
-function image_as_link($text){
+function image_as_link($text) {
     $pattern = '@<img([\S\s]+?)src=([^>]+?)>@si';
     $replacement = '<a href=${2}>[Image link]</a>';
     return preg_replace($pattern, $replacement, $text);
@@ -330,5 +330,5 @@ 
     return str_ireplace($search, $replace, $text);
 }
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>

html/user/forum_edit.php

Spacing +10 added lines, -10 removed lines

@@ -42,7 +42,7 @@ 
 
 $post_owner = BoincUser::lookup_id($post->user);
 if (($logged_in_user->id != $post_owner->id) || (can_reply($thread, $forum, $logged_in_user) == false)) {
-    error_page (tra("You are not authorized to edit this post."));
+    error_page(tra("You are not authorized to edit this post."));
 }
 
 $thread_owner = BoincUser::lookup_id($thread->owner);
@@ -51,13 +51,13 @@ 
 // (ie. not a response to another post)
 // allow the user to modify the thread title
 //
-$can_edit_title = ($post->parent_post==0 && $thread_owner->id==$logged_in_user->id && !is_banished($logged_in_user));
+$can_edit_title = ($post->parent_post == 0 && $thread_owner->id == $logged_in_user->id && !is_banished($logged_in_user));
 
 $content = post_str("content", true);
 $title = post_str("title", true);
 $preview = post_str("preview", true);
 
-if (post_str('submit',true) && (!$preview)) {
+if (post_str('submit', true) && (!$preview)) {
     if (POST_MAX_LINKS
         && link_count($content) > POST_MAX_LINKS
         && !is_moderator($logged_in_user, $forum)
@@ -66,7 +66,7 @@ 
     }
     check_tokens($logged_in_user->authenticator);
 
-    $add_signature = (post_str('add_signature', true) == "1")?1:0;
+    $add_signature = (post_str('add_signature', true) == "1") ? 1 : 0;
     $content = substr($content, 0, 64000);
     $content = trim($content);
     if (strlen($content)) {
@@ -74,7 +74,7 @@ 
         $now = time();
         $post->update("signature=$add_signature, content='$content', modified=$now");
 
-        if ($can_edit_title){
+        if ($can_edit_title) {
             $title = trim($title);
             $title = sanitize_tags($title);
             $title = BoincDb::escape_string($title);
@@ -87,7 +87,7 @@ 
     }
 }
 
-page_head(tra("Edit post"),'','','', $bbcode_js);
+page_head(tra("Edit post"), '', '', '', $bbcode_js);
 
 switch ($forum->parent_type) {
 case 0:
@@ -122,7 +122,7 @@ 
         sprintf(
             '<input type="text" size=%d name="title" value="%s">',
             80,
-            htmlspecialchars($preview?$title:$thread->title)
+            htmlspecialchars($preview ? $title : $thread->title)
         ),
         null, FORUM_LH_PCT
     );
@@ -139,7 +139,7 @@ 
         $bbcode_html,
         12,
         80,
-        htmlspecialchars($preview?$content:$post->content)
+        htmlspecialchars($preview ? $content : $post->content)
     ),
     null, FORUM_LH_PCT
 );
@@ -149,7 +149,7 @@ 
         '<input id="add_signature" name="add_signature" value="1" type="checkbox" %s>
         <label for="add_signature">%s</label>
         ',
-        $post->signature?'checked="true"':'',
+        $post->signature ? 'checked="true"' : '',
         tra("Add my signature to this post")
     ),
     null, FORUM_LH_PCT
@@ -170,5 +170,5 @@ 
 
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>

html/user/forum_reply.php

Spacing +8 added lines, -8 removed lines

@@ -56,7 +56,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -71,7 +71,7 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
+if ($content && (!$preview)) {
     check_tokens($logged_in_user->authenticator);
     if (!akismet_check($logged_in_user, $content)) {
         $warning = tra("Your post has been flagged as spam by the Akismet anti-spam system. Please modify your text and try again.");
@@ -93,7 +93,7 @@ 
     }
 }
 
-page_head(tra("Post to thread")." '$thread->title'",'','','', $bbcode_js);
+page_head(tra("Post to thread")." '$thread->title'", '', '', '', $bbcode_js);
 
 if ($parent_post) {
     echo sprintf(
@@ -161,7 +161,7 @@ 
     $x2 .= " method=\"post\" name=\"post\" onsubmit=\"return checkForm(this)\">\n";
     $x2 .= form_tokens($logged_in_user->authenticator);
     $x2 .= $bbcode_html."<textarea class=\"form-control\" name=\"content\" rows=\"18\">";
-    $no_quote = get_int("no_quote", true)==1;
+    $no_quote = get_int("no_quote", true) == 1;
     if ($preview) {
         $x2 .= htmlspecialchars($content);
     } else if (!$no_quote) {
@@ -170,9 +170,9 @@ 
         }
     }
     if (!$logged_in_user->prefs->no_signature_by_default) {
-        $enable_signature='checked="true"';
+        $enable_signature = 'checked="true"';
     } else {
-        $enable_signature="";
+        $enable_signature = "";
     }
     $x2 .= sprintf('</textarea><p> </p>
         <input class="btn btn-sm" %s type="submit" name="preview" value="%s">
@@ -200,11 +200,11 @@ 
     return sprintf(
         'In reply to %s\'s message of %s:
         [quote]%s[/quote]',
-        $user?$user->name:'unknown user',
+        $user ? $user->name : 'unknown user',
         date_str($post->timestamp),
         htmlspecialchars($post->content)
     );
 }
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

html/user/forum_search_action.php

Spacing +24 added lines, -24 removed lines

@@ -31,10 +31,10 @@ 
 // Optionally filters by forum, user, time, or hidden if specified.
 //
 function search_thread_titles(
-    $keyword_list, $forum="", $user="", $time="", $limit=200,
-    $sort_style=CREATE_TIME_NEW, $show_hidden = false
-){
-    $search_string="%";
+    $keyword_list, $forum = "", $user = "", $time = "", $limit = 200,
+    $sort_style = CREATE_TIME_NEW, $show_hidden = false
+) {
+    $search_string = "%";
     foreach ($keyword_list as $key => $word) {
         $search_string .= BoincDb::escape_string($word)."%";
     }
@@ -51,7 +51,7 @@ 
     if (!$show_hidden) {
         $query .= " and thread.hidden = 0";
     }
-    switch($sort_style) {
+    switch ($sort_style) {
     case MODIFIED_NEW:
         $query .= ' ORDER BY timestamp DESC';
         break;
@@ -84,11 +84,11 @@ 
 //
 function search_post_content(
     $keyword_list, $forum, $user, $time, $limit, $sort_style, $show_hidden
-){
+) {
     $db = BoincDb::get();
 
-    $search_string="%";
-    foreach ($keyword_list as $key => $word){
+    $search_string = "%";
+    foreach ($keyword_list as $key => $word) {
         $search_string .= BoincDb::escape_string($word)."%";
     }
     $optional_join = "";
@@ -100,20 +100,20 @@ 
     }
     $query = "select post.* from ".$db->db_name.".post".$optional_join." where content like '".$search_string."'";
     if ($forum) {
-        $query.=" and forum = $forum->id";
+        $query .= " and forum = $forum->id";
     }
     if ($user) {
-        $query.=" and post.user = $user->id ";
+        $query .= " and post.user = $user->id ";
     }
     if ($time) {
-        $query.=" and post.timestamp > $time";
+        $query .= " and post.timestamp > $time";
     }
     if (!$show_hidden) {
         $query .= " AND post.hidden = 0";
     }
-    switch($sort_style) {
+    switch ($sort_style) {
     case VIEWS_MOST:
-        $query.= ' ORDER BY views DESC';
+        $query .= ' ORDER BY views DESC';
         break;
     case CREATE_TIME_NEW:
         $query .= ' ORDER by post.timestamp desc';
@@ -128,13 +128,13 @@ 
         $query .= ' ORDER BY post.timestamp DESC';
         break;
     }
-    $query.= " limit $limit";
+    $query .= " limit $limit";
     return BoincPost::enum_general($query);
 }
 
 $logged_in_user = get_logged_in_user(false);
 BoincForumPrefs::lookup($logged_in_user);
-if ($logged_in_user && $logged_in_user->prefs->privilege(S_MODERATOR)){
+if ($logged_in_user && $logged_in_user->prefs->privilege(S_MODERATOR)) {
     $show_hidden_posts = true;
 } else {
     $show_hidden_posts = false;
@@ -147,7 +147,7 @@ 
 $search_max_time = post_int("search_max_time");
 $search_forum = post_int("search_forum");
 $search_sort = post_int("search_sort");
-$search_list = explode(" ",$search_keywords);
+$search_list = explode(" ", $search_keywords);
 if ($search_max_time) {
     $min_timestamp = time() - ($search_max_time*3600*24);
 } else {
@@ -156,7 +156,7 @@ 
 
 $limit = 100;
 
-if ($search_forum==-1){
+if ($search_forum == -1) {
     $forum = null;
 } else if ($search_forum) {
     $forum = BoincForum::lookup_id($search_forum);
@@ -173,11 +173,11 @@ 
 
 // Display the threads while we search for posts
 //
-if (count($threads)){
-    echo "<h3>" . tra("Thread titles matching your query:") . "</h3>";
+if (count($threads)) {
+    echo "<h3>".tra("Thread titles matching your query:")."</h3>";
     start_table('table-striped');
     thread_list_header();
-    foreach ($threads as $thread){
+    foreach ($threads as $thread) {
         if ($thread->hidden) continue;
         thread_list_item($thread, $logged_in_user);
     }
@@ -193,8 +193,8 @@ 
     $show_hidden_posts
 );
 
-if (count($posts)){
-    echo "<h3>" . tra("Messages matching your query:") . "</h3>";
+if (count($posts)) {
+    echo "<h3>".tra("Messages matching your query:")."</h3>";
     start_table('table-striped');
     row_heading_array(['Info', 'Post'], ['', 'width=70%']);
     $n = 1;
@@ -217,7 +217,7 @@ 
     end_table();
 }
 
-if (!count($threads) && !count($posts)){
+if (!count($threads) && !count($posts)) {
     echo "<p>".tra("Sorry, couldn't find anything matching your search query. You can try to broaden your search by using less words (or less specific words).")."</p>
     <p>"
     .tra("You can also %1 try the same search on Google. %2",
@@ -228,5 +228,5 @@ 
 echo "<p><a href=\"forum_search.php\">".tra("Perform another search")."</a></p>";
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>

html/user/forum_post.php

Spacing +10 added lines, -10 removed lines

@@ -56,10 +56,10 @@ 
 $preview = post_str("preview", true);
 $warning = null;
 
-if ($content && $title && (!$preview)){
+if ($content && $title && (!$preview)) {
     if (post_str('add_signature', true)) {
-        $add_signature = true;    // set a flag and concatenate later
-    }  else {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
         $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
@@ -74,14 +74,14 @@ 
             if (post_str('subscribe', true)) {
                 BoincSubscription::replace($logged_in_user->id, $thread->id);
             }
-            header('Location: forum_thread.php?id=' . $thread->id);
+            header('Location: forum_thread.php?id='.$thread->id);
         } else {
             error_page("Can't create thread.  $forum_error");
         }
     }
 }
 
-page_head(tra("Create new thread"),'','','', $bbcode_js);
+page_head(tra("Create new thread"), '', '', '', $bbcode_js);
 show_forum_header($logged_in_user);
 
 if ($warning) {
@@ -122,7 +122,7 @@ 
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
 }
 
-if ($force_title && $title){
+if ($force_title && $title) {
     row2(
         tra("Title"),
         sprintf(
@@ -136,7 +136,7 @@ 
     row2(
         tra("Title").$submit_help,
         sprintf('<input type="text" class="form-control" name="title" value="%s">',
-            $title?htmlspecialchars($title):''
+            $title ?htmlspecialchars($title) : ''
         ),
         null, FORUM_LH_PCT
     );
@@ -147,7 +147,7 @@ 
     sprintf(
         '%s <textarea class="form-control" name="content" rows="12" cols="80">%s</textarea>',
         $bbcode_html,
-        $content?htmlspecialchars($content):''
+        $content ?htmlspecialchars($content) : ''
     ),
     null, FORUM_LH_PCT
 );
@@ -155,7 +155,7 @@ 
 if (!$logged_in_user->prefs->no_signature_by_default) {
     $enable_signature = 'checked="true"';
 } else {
-    $enable_signature='';
+    $enable_signature = '';
 }
 
 if (is_news_forum($forum)) {
@@ -195,5 +195,5 @@ 
 
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>