BOINC / boinc

html/user/submit.php

Braces +1 added lines, -1 removed lines

@@ -369,7 +369,7 @@
             $text = "---";
             if ($batch->state == BATCH_STATE_COMPLETE) {
                 $y = '<font color="red">failed</font>';
-            }   else {
+            } else {
                 $y = "in progress";
             }
         }

Spacing +7 added lines, -7 removed lines

@@ -365,11 +365,11 @@ 
 function progress_bar($batch, $wus, $width) {
     $w_success = $width*$batch->fraction_done;
     $w_fail = $width*$batch->nerror_jobs/$batch->njobs;
-    $nsuccess = $batch->njobs * $batch->fraction_done;
+    $nsuccess = $batch->njobs*$batch->fraction_done;
     $nsent = wus_nsent($wus);
     $nprog = $nsent - $nsuccess - $batch->nerror_jobs;
     $w_prog = $width*$nprog/$batch->njobs;
-    $nunsent = $batch->njobs-$nsent;
+    $nunsent = $batch->njobs - $nsent;
     $w_unsent = $width*$nunsent/$batch->njobs;
     $x = '<table height=20><tr>';
     if ($w_fail) {
@@ -407,7 +407,7 @@ 
     page_head("Batch $batch_id");
     start_table();
     row2("name", $batch->name);
-    row2("application", $app?$app->name:'---');
+    row2("application", $app ? $app->name : '---');
     row2("state", batch_state_string($batch->state));
     //row2("# jobs", $batch->njobs);
     //row2("# error jobs", $batch->nerror_jobs);
@@ -454,7 +454,7 @@ 
         "Canonical instance<br><small>click to see result page on BOINC server</smallp>",
         "Download Results"
     );
-    foreach($wus as $wu) {
+    foreach ($wus as $wu) {
         $resultid = $wu->canonical_resultid;
         if ($resultid) {
             $x = "<a href=result.php?resultid=$resultid>$resultid</a>";
@@ -465,7 +465,7 @@ 
             $text = "---";
             if ($batch->state == BATCH_STATE_COMPLETE) {
                 $y = '<font color="red">failed</font>';
-            }   else {
+            } else {
                 $y = "in progress";
             }
         }
@@ -530,7 +530,7 @@ 
     $results = BoincResult::enum("workunitid=$wuid");
     $upload_dir = parse_config(get_config(), "<upload_dir>");
     $fanout = parse_config(get_config(), "<uldl_dir_fanout>");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         echo "<tr>
             <td><a href=result.php?resultid=$result->id>$result->id &middot; $result->name </a></td>
             <td>".state_string($result)."</td>
@@ -540,7 +540,7 @@ 
         if ($result->server_state == 5) {
             $phys_names = get_outfile_names($result);
             $log_names = get_outfile_log_names($result);
-            for ($i=0; $i<count($phys_names); $i++) {
+            for ($i = 0; $i < count($phys_names); $i++) {
                 $url = sprintf(
                     'get_output2.php?cmd=result&result_id=%d&file_num=%d',
                     $result->id, $i

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -404,7 +404,7 @@ 
     $wus = BoincWorkunit::enum("batch = $batch->id");
     $batch = get_batch_params($batch, $wus);
 
-    page_head("Batch $batch_id");
+    page_head("batch $batch_id");
     start_table();
     row2("name", $batch->name);
     row2("application", $app?$app->name:'---');
@@ -489,7 +489,7 @@ 
     $wu = BoincWorkunit::lookup_id($wuid);
     if (!$wu) error_page("no such job");
 
-    page_head("Job $wuid");
+    page_head("job $wuid");
 
     echo "
         <a href=workunit.php?wuid=$wuid>Workunit details</a> &middot;

html/user/forum_reply.php

Braces +4 added lines, -4 removed lines

@@ -50,7 +50,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -65,10 +65,10 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
-    if (post_str('add_signature',true)=="add_it"){
+if ($content && (!$preview)) {
+    if (post_str('add_signature',true)=="add_it") {
         $add_signature=true;    // set a flag and concatenate later
-    }  else {
+    } else {
         $add_signature=false;
     }
     check_tokens($logged_in_user->authenticator);

Spacing +13 added lines, -13 removed lines

@@ -50,7 +50,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -65,11 +65,11 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
-    if (post_str('add_signature',true)=="add_it"){
-        $add_signature=true;    // set a flag and concatenate later
-    }  else {
-        $add_signature=false;
+if ($content && (!$preview)) {
+    if (post_str('add_signature', true) == "add_it") {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
+        $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
     if (!akismet_check($logged_in_user, $content)) {
@@ -88,7 +88,7 @@ 
     }
 }
 
-page_head(tra("Post to thread"),'','','', $bbcode_js);
+page_head(tra("Post to thread"), '', '', '', $bbcode_js);
 
 show_forum_header($logged_in_user);
 
@@ -142,7 +142,7 @@ 
     $x1 = tra("Message:").bbcode_info().post_warning();
     $x2 = "";
     if ($parent_post) {
-        $x2 .=" ".tra("reply to %1 Message ID %2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
+        $x2 .= " ".tra("reply to %1 Message ID %2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
     }
     $x2 .= "<form action=forum_reply.php?thread=".$thread->id;
 
@@ -153,7 +153,7 @@ 
     $x2 .= " method=\"post\" name=\"post\" onsubmit=\"return checkForm(this)\">\n";
     $x2 .= form_tokens($logged_in_user->authenticator);
     $x2 .= start_table_str().$bbcode_html.end_table_str()."<textarea class=\"form-control\" name=\"content\" rows=\"18\">";
-    $no_quote = get_int("no_quote", true)==1;
+    $no_quote = get_int("no_quote", true) == 1;
     if ($preview) {
         $x2 .= htmlspecialchars($content);
     } else if (!$no_quote) {
@@ -162,9 +162,9 @@ 
         }
     }
     if (!$logged_in_user->prefs->no_signature_by_default) {
-        $enable_signature="checked=\"true\"";
+        $enable_signature = "checked=\"true\"";
     } else {
-        $enable_signature="";
+        $enable_signature = "";
     }
     $x2 .= "</textarea><p> </p>
         <input class=\"btn btn-primary btn-sm \" type=\"submit\" name=\"preview\" value=\"".tra("Preview")."\">
@@ -179,9 +179,9 @@ 
 }
 
 function quote_text($text) {
-    $text = "[quote]" . $text . "[/quote]";
+    $text = "[quote]".$text."[/quote]";
     return $text;
 }
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

html/user/submit_status.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     if (!$batch || $batch->user_id != $user->id) {
         error_page("no batch");
     }
-    page_head("Batch $batch->id");
+    page_head("batch $batch->id");
     $results = BoincResult::enum("batch=$batch->id order by workunitid");
     result_table_start(true, true, null);
     foreach ($results as $result) {

html/user/edit_forum_preferences_form.php

Braces +6 added lines, -5 removed lines

@@ -53,8 +53,9 @@ 
 // ------------ Forum identity -----------
 
 $select_0 = $select_1 = $select_2 = "";
-if (strlen($user->prefs->avatar)){
-    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18)=="//www.gravatar.com") { // Gravatar
+if (strlen($user->prefs->avatar)) {
+    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18)=="//www.gravatar.com") {
+// Gravatar
         $select_1 = "checked=\"true\"";
     } else {
         $select_2 = "checked=\"true\"";
@@ -73,7 +74,7 @@ 
     <input type=\"radio\" id=\"avatar_select_2\" name=\"avatar_select\" value=\"2\" ".$select_2.">
         <label for=\"avatar_select_2\">".tra("Use this uploaded avatar:")."</label> <input type=\"file\" name=\"picture\">"
 );
-if (strlen($user->prefs->avatar)){
+if (strlen($user->prefs->avatar)) {
     row2(tra("Avatar preview")."<br><p class=\"text-muted\">".tra("This is how your avatar will look")."</p>",
     "<img src=\"".$user->prefs->avatar."\" width=\"100\" height=\"100\">");
 }
@@ -92,7 +93,7 @@ 
     textarea_with_counter("signature", 250, $signature)
     ."<br><input type=\"checkbox\" name=\"signature_by_default\" ".$signature_by_default."> ".tra("Attach signature by default")
 );
-if ($user->prefs->signature!=""){
+if ($user->prefs->signature!="") {
     row2(tra("Signature preview").
         "<br><p class=\"text-muted\">".tra("This is how your signature will look in the forums")."</p>",
         output_transform($user->prefs->signature)
@@ -138,7 +139,7 @@ 
 
 $filtered_userlist = get_ignored_list($user);
 $forum_filtered_userlist = "";
-for ($i=0; $i<sizeof($filtered_userlist); $i++){
+for ($i=0; $i<sizeof($filtered_userlist); $i++) {
     $id = (int)$filtered_userlist[$i];
     if ($id) {
         $filtered_user = BoincUser::lookup_id($id);

Spacing +19 added lines, -19 removed lines

@@ -38,9 +38,9 @@ 
 // ------------ Notification -----------
 
 row1(tra("Notifications"));
-$ch0 = $user->prefs->pm_notification==0?"checked":"";
-$ch1 = $user->prefs->pm_notification==1?"checked":"";
-$ch2 = $user->prefs->pm_notification==2?"checked":"";
+$ch0 = $user->prefs->pm_notification == 0 ? "checked" : "";
+$ch1 = $user->prefs->pm_notification == 1 ? "checked" : "";
+$ch2 = $user->prefs->pm_notification == 2 ? "checked" : "";
 row2(
     tra("How should we notify you of new private messages, friend requests, posts in subscribed threads, and other events?"),
     "<input type=radio name=pm_notification value=0 $ch0> ".tra("On my Account page (no email)")."
@@ -53,8 +53,8 @@ 
 // ------------ Forum identity -----------
 
 $select_0 = $select_1 = $select_2 = "";
-if (strlen($user->prefs->avatar)){
-    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18)=="//www.gravatar.com") { // Gravatar
+if (strlen($user->prefs->avatar)) {
+    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18) == "//www.gravatar.com") { // Gravatar
         $select_1 = "checked=\"true\"";
     } else {
         $select_2 = "checked=\"true\"";
@@ -73,15 +73,15 @@ 
     <input type=\"radio\" id=\"avatar_select_2\" name=\"avatar_select\" value=\"2\" ".$select_2.">
         <label for=\"avatar_select_2\">".tra("Use this uploaded avatar:")."</label> <input type=\"file\" name=\"picture\">"
 );
-if (strlen($user->prefs->avatar)){
+if (strlen($user->prefs->avatar)) {
     row2(tra("Avatar preview")."<br><p class=\"text-muted\">".tra("This is how your avatar will look")."</p>",
     "<img src=\"".$user->prefs->avatar."\" width=\"100\" height=\"100\">");
 }
 
-$signature_by_default = $user->prefs->no_signature_by_default==false?"checked=\"checked\"":"";
+$signature_by_default = $user->prefs->no_signature_by_default == false ? "checked=\"checked\"" : "";
 
-$signature=$user->prefs->signature;
-$maxlen=250;
+$signature = $user->prefs->signature;
+$maxlen = 250;
 row2(
     tra("Signature for message board posts")
     .bbcode_info()
@@ -92,7 +92,7 @@ 
     textarea_with_counter("signature", 250, $signature)
     ."<br><input type=\"checkbox\" name=\"signature_by_default\" ".$signature_by_default."> ".tra("Attach signature by default")
 );
-if ($user->prefs->signature!=""){
+if ($user->prefs->signature != "") {
     row2(tra("Signature preview").
         "<br><p class=\"text-muted\">".tra("This is how your signature will look in the forums")."</p>",
         output_transform($user->prefs->signature)
@@ -101,13 +101,13 @@ 
 
 // ------------ Message display  -----------
 
-$forum_hide_avatars = $user->prefs->hide_avatars?"checked=\"checked\"":"";
-$forum_hide_signatures = $user->prefs->hide_signatures?"checked=\"checked\"":"";
-$forum_link_popup = $user->prefs->link_popup?"checked=\"checked\"":"";
-$forum_image_as_link = $user->prefs->images_as_links?"checked=\"checked\"":"";
-$forum_jump_to_unread = $user->prefs->jump_to_unread?"checked=\"checked\"":"";
-$forum_ignore_sticky_posts = $user->prefs->ignore_sticky_posts?"checked=\"checked\"":"";
-$forum_highlight_special = $user->prefs->highlight_special?"checked=\"checked\"":"";
+$forum_hide_avatars = $user->prefs->hide_avatars ? "checked=\"checked\"" : "";
+$forum_hide_signatures = $user->prefs->hide_signatures ? "checked=\"checked\"" : "";
+$forum_link_popup = $user->prefs->link_popup ? "checked=\"checked\"" : "";
+$forum_image_as_link = $user->prefs->images_as_links ? "checked=\"checked\"" : "";
+$forum_jump_to_unread = $user->prefs->jump_to_unread ? "checked=\"checked\"" : "";
+$forum_ignore_sticky_posts = $user->prefs->ignore_sticky_posts ? "checked=\"checked\"" : "";
+$forum_highlight_special = $user->prefs->highlight_special ? "checked=\"checked\"" : "";
 
 $forum_minimum_wrap_postcount = intval($user->prefs->minimum_wrap_postcount);
 $forum_display_wrap_postcount = intval($user->prefs->display_wrap_postcount);
@@ -138,7 +138,7 @@ 
 
 $filtered_userlist = get_ignored_list($user);
 $forum_filtered_userlist = "";
-for ($i=0; $i<sizeof($filtered_userlist); $i++){
+for ($i = 0; $i < sizeof($filtered_userlist); $i++) {
     $id = (int)$filtered_userlist[$i];
     if ($id) {
         $filtered_user = BoincUser::lookup_id($id);
@@ -168,5 +168,5 @@ 
 end_table();
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>

html/user/submit_rpc_handler.php

Braces +2 added lines, -1 removed lines

@@ -691,7 +691,8 @@
         <id>$result->id</id>
         <state>".state_string($result)."</state>
 ";
-        if ($result->server_state == 5) {   // over?
+        if ($result->server_state == 5) {
+// over?
             $paths = get_outfile_paths($result);
             foreach($paths as $path) {
                 if (is_file($path)) {

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -595,7 +595,7 @@
 // return a batch specified by the command, using either ID or name
 //
 function get_batch($r) {
-    $batch = NULL;
+    $batch = null;
     if (!empty($r->batch_id)) {
         $batch_id = (int)($r->batch_id);
         $batch = BoincBatch::lookup_id($batch_id);

Switch Indentation +18 added lines, -18 removed lines

@@ -1049,24 +1049,24 @@
 log_write("----- Handling RPC; command ".$r->getName());
 
 switch ($r->getName()) {
-    case 'abort_batch': handle_abort_batch($r); break;
-    case 'abort_jobs': handle_abort_jobs($r); break;
-    case 'create_batch': create_batch($r); break;
-    case 'estimate_batch': estimate_batch($r); break;
-    case 'get_templates': get_templates($r); break;
-    case 'ping': ping($r); break;
-    case 'query_batch': query_batch($r); break;
-    case 'query_batch2': query_batch2($r); break;
-    case 'query_batches': query_batches($r); break;
-    case 'query_job': query_job($r); break;
-    case 'query_completed_job': query_completed_job($r); break;
-    case 'retire_batch': handle_retire_batch($r); break;
-    case 'set_expire_time': handle_set_expire_time($r); break;
-    case 'submit_batch': submit_batch($r); break;
-    default:
-        log_write("bad command");
-        xml_error(-1, "bad command: ".$r->getName());
-        break;
+case 'abort_batch': handle_abort_batch($r); break;
+case 'abort_jobs': handle_abort_jobs($r); break;
+case 'create_batch': create_batch($r); break;
+case 'estimate_batch': estimate_batch($r); break;
+case 'get_templates': get_templates($r); break;
+case 'ping': ping($r); break;
+case 'query_batch': query_batch($r); break;
+case 'query_batch2': query_batch2($r); break;
+case 'query_batches': query_batches($r); break;
+case 'query_job': query_job($r); break;
+case 'query_completed_job': query_completed_job($r); break;
+case 'retire_batch': handle_retire_batch($r); break;
+case 'set_expire_time': handle_set_expire_time($r); break;
+case 'submit_batch': submit_batch($r); break;
+default:
+    log_write("bad command");
+    xml_error(-1, "bad command: ".$r->getName());
+    break;
 }
 
 log_write("RPC done");

Spacing +31 added lines, -31 removed lines

@@ -58,7 +58,7 @@ 
     if ($template) {
         $t = (double)$template->workunit->rsc_fpops_est;
     }
-    foreach($r->batch->job as $job) {
+    foreach ($r->batch->job as $job) {
         $y = (double)$job->rsc_fpops_est;
         if ($y) {
             $x += $y;
@@ -84,7 +84,7 @@ 
 function est_elapsed_time($r, $template) {
     // crude estimate: batch FLOPs / project FLOPS
     //
-    return batch_flop_count($r, $template) / project_flops();
+    return batch_flop_count($r, $template)/project_flops();
 }
 
 // if batch-level input template filename was given, read it;
@@ -94,9 +94,9 @@ 
 //
 function read_input_template($app, $r) {
     if ((isset($r->batch)) && (isset($r->batch->workunit_template_file)) && ($r->batch->workunit_template_file)) {
-        $path = project_dir() . "/templates/".$r->batch->workunit_template_file;
+        $path = project_dir()."/templates/".$r->batch->workunit_template_file;
     } else {
-        $path = project_dir() . "/templates/$app->name"."_in";
+        $path = project_dir()."/templates/$app->name"."_in";
     }
     if (file_exists($path)) {
         $x = simplexml_load_file($path);
@@ -141,7 +141,7 @@ 
 function validate_batch($jobs, $template) {
     $i = 0;
     $n = count($template->file_info);
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         $m = count($job->input_files);
         if ($n != $m) {
             log_write("wrong # of input files for job $i: need $n, got $m");
@@ -202,7 +202,7 @@ 
 // stage all the files
 //
 function stage_files(&$jobs) {
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         foreach ($job->input_files as $file) {
             if ($file->mode != "remote") {
                 $file->name = stage_file($file);
@@ -215,7 +215,7 @@ 
 //
 function submit_jobs(
     $jobs, $job_params, $app, $batch_id, $priority, $app_version_num,
-    $input_template_filename,        // batch-level; can also specify per job
+    $input_template_filename, // batch-level; can also specify per job
     $output_template_filename,
     $user
 ) {
@@ -225,7 +225,7 @@ 
     // one line per job
     //
     $x = "";
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         if ($job->name) {
             $x .= " --wu_name $job->name";
         }
@@ -260,7 +260,7 @@ 
         $x .= "\n";
     }
 
-    $cmd = "cd " . project_dir() . "; ./bin/create_work --appname $app->name --batch $batch_id";
+    $cmd = "cd ".project_dir()."; ./bin/create_work --appname $app->name --batch $batch_id";
 
     if ($user->seti_id) {
         $cmd .= " --target_user $user->id ";
@@ -296,7 +296,7 @@ 
 
     // send stdin/stderr to a temp file
     $cmd .= sprintf(' >%s 2>&1',
-        "/tmp/create_work_" . getmypid() . ".err"
+        "/tmp/create_work_".getmypid().".err"
     );
 
     $h = popen($cmd, "w");
@@ -369,7 +369,7 @@ 
 //
 function xml_get_jobs($r) {
     $jobs = array();
-    foreach($r->batch->job as $j) {
+    foreach ($r->batch->job as $j) {
         $job = new StdClass;
         $job->input_files = array();
         $job->command_line = (string)$j->command_line;
@@ -420,16 +420,16 @@ 
 //
 function logical_end_time($r, $jobs, $user, $app) {
     $total_flops = 0;
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         //print_r($job);
         if ($job->rsc_fpops_est) {
             $total_flops += $job->rsc_fpops_est;
         } else if ($job->input_template && $job->input_template->workunit->rsc_fpops_est) {
-            $total_flops += (double) $job->input_template->workunit->rsc_fpops_est;
+            $total_flops += (double)$job->input_template->workunit->rsc_fpops_est;
         } else if ($r->batch->job_params->rsc_fpops_est) {
-            $total_flops += (double) $r->batch->job_params->rsc_fpops_est;
+            $total_flops += (double)$r->batch->job_params->rsc_fpops_est;
         } else {
-            $x = (double) $template->workunit->rsc_fpops_est;
+            $x = (double)$template->workunit->rsc_fpops_est;
             if ($x) {
                 $total_flops += $x;
             } else {
@@ -437,7 +437,7 @@ 
             }
         }
     }
-    $cmd = "cd " . project_dir() . "/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
+    $cmd = "cd ".project_dir()."/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
     $x = exec($cmd);
     if (!is_numeric($x) || (double)$x == 0) {
         xml_error(-1, "$cmd returned $x");
@@ -515,15 +515,15 @@ 
     }
 
     $job_params = new StdClass;
-    $job_params->rsc_disk_bound = (double) $r->batch->job_params->rsc_disk_bound;
-    $job_params->rsc_fpops_est = (double) $r->batch->job_params->rsc_fpops_est;
-    $job_params->rsc_fpops_bound = (double) $r->batch->job_params->rsc_fpops_bound;
-    $job_params->rsc_memory_bound = (double) $r->batch->job_params->rsc_memory_bound;
-    $job_params->delay_bound = (double) $r->batch->job_params->delay_bound;
+    $job_params->rsc_disk_bound = (double)$r->batch->job_params->rsc_disk_bound;
+    $job_params->rsc_fpops_est = (double)$r->batch->job_params->rsc_fpops_est;
+    $job_params->rsc_fpops_bound = (double)$r->batch->job_params->rsc_fpops_bound;
+    $job_params->rsc_memory_bound = (double)$r->batch->job_params->rsc_memory_bound;
+    $job_params->delay_bound = (double)$r->batch->job_params->delay_bound;
         // could add quorum-related stuff
 
-    $input_template_filename = (string) $r->batch->input_template_filename;
-    $output_template_filename = (string) $r->batch->output_template_filename;
+    $input_template_filename = (string)$r->batch->input_template_filename;
+    $output_template_filename = (string)$r->batch->output_template_filename;
         // possibly empty
 
     submit_jobs(
@@ -613,7 +613,7 @@ 
 }
 
 function n_outfiles($wu) {
-    $path = project_dir() . "/$wu->output_template_filename";
+    $path = project_dir()."/$wu->output_template_filename";
     $r = simplexml_load_file($path);
     return count($r->file_info);
 }
@@ -820,7 +820,7 @@ 
 ";
         if ($result->server_state == 5) {   // over?
             $paths = get_outfile_paths($result);
-            foreach($paths as $path) {
+            foreach ($paths as $path) {
                 if (is_file($path)) {
                     $size = filesize($path);
                     echo "        <outfile>
@@ -864,7 +864,7 @@ 
     } else {
         $results = BoincResult::enum("workunitid=$job_id");
         foreach ($results as $r) {
-            switch($r->outcome) {
+            switch ($r->outcome) {
             case 1:
             case 3:
             case 6:
@@ -979,8 +979,8 @@ 
     }
 
     list($user, $user_submit) = check_remote_submit_permissions($r, $app);
-    $in = file_get_contents(project_dir() . "/templates/".$app->name."_in");
-    $out = file_get_contents(project_dir() . "/templates/".$app->name."_out");
+    $in = file_get_contents(project_dir()."/templates/".$app->name."_in");
+    $out = file_get_contents(project_dir()."/templates/".$app->name."_out");
     if ($in === false || $out === false) {
         log_write("template file missing");
         xml_error(-1, "template file missing");
@@ -992,7 +992,7 @@ 
 
 function ping($r) {
     xml_start_tag("ping");
-    BoincDb::get();     // errors out if DB down or web disabled
+    BoincDb::get(); // errors out if DB down or web disabled
     echo "<success>1</success>
         </ping>
     ";
@@ -1059,9 +1059,9 @@ 
 $request_log = parse_config(get_config(), "<remote_submit_request_log>");
 if ($request_log) {
     $log_dir = parse_config(get_config(), "<log_dir>");
-    $request_log = $log_dir . "/" . $request_log;
+    $request_log = $log_dir."/".$request_log;
     if ($file = fopen($request_log, "a")) {
-        fwrite($file, "\n<submit_rpc_handler date=\"" . date(DATE_ATOM) . "\">\n" . $_POST['request'] . "\n</submit_rpc_handler>\n");
+        fwrite($file, "\n<submit_rpc_handler date=\"".date(DATE_ATOM)."\">\n".$_POST['request']."\n</submit_rpc_handler>\n");
         fclose($file);
     }
 }

html/user/get_project_config.php

Braces +2 added lines, -2 removed lines

@@ -28,10 +28,10 @@
 //
 function show_platforms() {
     $xmlFragment = unserialize(get_cached_data(3600, "project_config_platform_xml"));
-    if ($xmlFragment==false){
+    if ($xmlFragment==false) {
         $platforms = BoincDB::get()->enum_fields("platform, DBNAME.app_version, DBNAME.app", "BoincPlatform", "platform.name, platform.user_friendly_name, plan_class", "app_version.platformid = platform.id and app_version.appid = app.id and app_version.deprecated=0 and app.deprecated=0 group by platform.name, plan_class", "");
         $xmlFragment = "    <platforms>";
-        foreach ($platforms as $platform){
+        foreach ($platforms as $platform) {
             $xmlFragment .= "
             <platform>
                 <platform_name>$platform->name</platform_name>

Indentation +4 added lines, -4 removed lines

@@ -86,11 +86,11 @@ 
 }
 
 if ($disable_account_creation || defined('INVITE_CODES')) {
-	echo "    <account_creation_disabled/>\n";
+    echo "    <account_creation_disabled/>\n";
 }
 
 if (defined('INVITE_CODES')) {
-	echo "    <invite_code_required/>\n";
+    echo "    <invite_code_required/>\n";
 }
 
 echo "    <min_passwd_length>$min_passwd_length</min_passwd_length>\n";
@@ -113,9 +113,9 @@ 
 // the terms_of_use.txt file in the project base directory.
 //
 if (defined('TERMSOFUSE_FILE')) {
-  $tou_file = TERMSOFUSE_FILE;
+    $tou_file = TERMSOFUSE_FILE;
 } else {
-  $tou_file =  "../../terms_of_use.txt";
+    $tou_file =  "../../terms_of_use.txt";
 }
 if (file_exists($tou_file)) {
     $terms_of_use = trim(file_get_contents($tou_file));

Spacing +3 added lines, -3 removed lines

@@ -30,10 +30,10 @@ 
 //
 function show_platforms() {
     $xmlFragment = unserialize(get_cached_data(3600, "project_config_platform_xml"));
-    if ($xmlFragment==false){
+    if ($xmlFragment == false) {
         $platforms = BoincDB::get()->enum_fields("platform, DBNAME.app_version, DBNAME.app", "BoincPlatform", "platform.name, platform.user_friendly_name, plan_class", "app_version.platformid = platform.id and app_version.appid = app.id and app_version.deprecated=0 and app.deprecated=0 group by platform.name, plan_class", "");
         $xmlFragment = "    <platforms>";
-        foreach ($platforms as $platform){
+        foreach ($platforms as $platform) {
             $xmlFragment .= "
             <platform>
                 <platform_name>$platform->name</platform_name>
@@ -115,7 +115,7 @@ 
 if (defined('TERMSOFUSE_FILE')) {
   $tou_file = TERMSOFUSE_FILE;
 } else {
-  $tou_file =  "../../terms_of_use.txt";
+  $tou_file = "../../terms_of_use.txt";
 }
 if (file_exists($tou_file)) {
     $terms_of_use = trim(file_get_contents($tou_file));

html/user/forum_search.php

Braces +4 added lines, -4 removed lines

@@ -56,7 +56,7 @@ 
     </select>");
 
 $forumid = null;
-if (get_str("forumid",true)){
+if (get_str("forumid",true)) {
     $forumid = get_str("forumid");
 }
 $forumlist="<option value=\"-1\">".tra("All")."</option>";
@@ -64,7 +64,7 @@ 
 foreach ($categories as $category) {
     $forums = BoincForum::enum("parent_type=0 and category=$category->id");
     foreach ($forums as $forum) {
-        if ($forum->id==$forumid){
+        if ($forum->id==$forumid) {
             $forumlist.="<option selected value=\"".$forum->id."\">".$forum->title."</option>";
         } else {
             $forumlist.="<option value=\"".$forum->id."\">".$forum->title."</option>";
@@ -76,8 +76,8 @@ 
     '<select class="form-control" name="search_forum">'.$forumlist.'</select');
 
 $sortlist = null;
-foreach ($thread_sort_styles as $id => $style){
-    if ($id == CREATE_TIME_NEW){
+foreach ($thread_sort_styles as $id => $style) {
+    if ($id == CREATE_TIME_NEW) {
         $sortlist.="<option selected value=\"".$id."\">".$style."</option>";
     } else {
         $sortlist.="<option value=\"".$id."\">".$style."</option>";

Spacing +11 added lines, -11 removed lines

@@ -56,18 +56,18 @@ 
     </select>");
 
 $forumid = null;
-if (get_str("forumid",true)){
+if (get_str("forumid", true)) {
     $forumid = get_str("forumid");
 }
-$forumlist="<option value=\"-1\">".tra("All")."</option>";
+$forumlist = "<option value=\"-1\">".tra("All")."</option>";
 $categories = BoincCategory::enum();
 foreach ($categories as $category) {
     $forums = BoincForum::enum("parent_type=0 and category=$category->id");
     foreach ($forums as $forum) {
-        if ($forum->id==$forumid){
-            $forumlist.="<option selected value=\"".$forum->id."\">".$forum->title."</option>";
+        if ($forum->id == $forumid) {
+            $forumlist .= "<option selected value=\"".$forum->id."\">".$forum->title."</option>";
         } else {
-            $forumlist.="<option value=\"".$forum->id."\">".$forum->title."</option>";
+            $forumlist .= "<option value=\"".$forum->id."\">".$forum->title."</option>";
         }
     }
 }
@@ -76,22 +76,22 @@ 
     '<select class="form-control" name="search_forum">'.$forumlist.'</select');
 
 $sortlist = null;
-foreach ($thread_sort_styles as $id => $style){
-    if ($id == CREATE_TIME_NEW){
-        $sortlist.="<option selected value=\"".$id."\">".$style."</option>";
+foreach ($thread_sort_styles as $id => $style) {
+    if ($id == CREATE_TIME_NEW) {
+        $sortlist .= "<option selected value=\"".$id."\">".$style."</option>";
     } else {
-        $sortlist.="<option value=\"".$id."\">".$style."</option>";
+        $sortlist .= "<option value=\"".$id."\">".$style."</option>";
     }
 }
 row2(tra("Sort by"),
     '<select class="form-control" name="search_sort">'.$sortlist.'</select');
 
 row1("&nbsp;");
-row2("","<input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Start the search")."\">");
+row2("", "<input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Start the search")."\">");
 echo "</form>";
 end_table();
 
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>

html/user/create_account_form.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -57,7 +57,7 @@
     $team = BoincTeam::lookup_id($teamid);
     $user = BoincUser::lookup_id($team->userid);
     if (!$user) {
-        error_page("Team $team->name has no founder");
+        error_page("team $team->name has no founder");
         $teamid = 0;
     } else {
         echo "<b>".tra("This account will belong to the team %1 and will have the project preferences of its founder.", "<a href=\"team_display.php?teamid=$team->id\">$team->name</a>")."</b><p>";

Spacing +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
     }
 }
 
-form_start("create_account_action.php","post");
+form_start("create_account_action.php", "post");
 create_account_form($teamid, $next_url);
 global $recaptcha_public_key;
 if ($recaptcha_public_key) {
@@ -77,5 +77,5 @@ 
 
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>

html/user/forum_edit.php

Braces +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
         $now = time();
         $post->update("signature=$add_signature, content='$content', modified=$now");
     
-        if ($can_edit_title){
+        if ($can_edit_title) {
             $title = trim($title);
             $title = sanitize_tags($title);
             $title = BoincDb::escape_string($title);

Spacing +9 added lines, -9 removed lines

@@ -44,7 +44,7 @@ 
 
 $post_owner = BoincUser::lookup_id($post->user);
 if (($logged_in_user->id != $post_owner->id) || (can_reply($thread, $forum, $logged_in_user) == false)) {
-    error_page (tra("You are not authorized to edit this post."));
+    error_page(tra("You are not authorized to edit this post."));
 }
 
 $thread_owner = BoincUser::lookup_id($thread->owner);
@@ -53,13 +53,13 @@ 
 // (ie. not a response to another post)
 // allow the user to modify the thread title
 //
-$can_edit_title = ($post->parent_post==0 && $thread_owner->id==$logged_in_user->id && !is_banished($logged_in_user));
+$can_edit_title = ($post->parent_post == 0 && $thread_owner->id == $logged_in_user->id && !is_banished($logged_in_user));
 
 $content = post_str("content", true);
 $title = post_str("title", true);
 $preview = post_str("preview", true);
 
-if (post_str('submit',true) && (!$preview)) {
+if (post_str('submit', true) && (!$preview)) {
     if (POST_MAX_LINKS
         && link_count($content) > POST_MAX_LINKS
         && !is_moderator($logged_in_user, $forum)
@@ -68,7 +68,7 @@ 
     }
     check_tokens($logged_in_user->authenticator);
     
-    $add_signature = (post_str('add_signature', true) == "1")?1:0;
+    $add_signature = (post_str('add_signature', true) == "1") ? 1 : 0;
     $content = substr($content, 0, 64000);
     $content = trim($content);
     if (strlen($content)) {
@@ -76,7 +76,7 @@ 
         $now = time();
         $post->update("signature=$add_signature, content='$content', modified=$now");
     
-        if ($can_edit_title){
+        if ($can_edit_title) {
             $title = trim($title);
             $title = sanitize_tags($title);
             $title = BoincDb::escape_string($title);
@@ -89,7 +89,7 @@ 
     }
 }
 
-page_head(tra("Edit post"),'','','', $bbcode_js);
+page_head(tra("Edit post"), '', '', '', $bbcode_js);
 
 show_forum_header($logged_in_user);
 switch ($forum->parent_type) {
@@ -144,9 +144,9 @@ 
 }
 
 if ($post->signature) {
-    $enable_signature="checked=\"true\"";
+    $enable_signature = "checked=\"true\"";
 } else {
-    $enable_signature="";
+    $enable_signature = "";
 }
 row2("", "<input id=\"add_signature\" name=\"add_signature\" value=\"1\" ".$enable_signature." type=\"checkbox\">
     <label for=\"add_signature\">".tra("Add my signature to this post")."</label>");
@@ -159,5 +159,5 @@ 
 
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>