BOINC / boinc

html/inc/profile.inc

Spacing +9 added lines, -9 removed lines

@@ -71,7 +71,7 @@ 
     if (!$user->has_profile) return null;
     $profile = BoincProfile::lookup("userid=$user->id");
     if (!$profile->has_picture) return null;
-    if (profile_screening() && $profile->verification!=1) return null;
+    if (profile_screening() && $profile->verification != 1) return null;
     return profile_thumb_url($user->id);
 }
 
@@ -125,11 +125,11 @@ 
         return $image;
     }
 
-    ($origWidth > $origHeight)? $scalar = ($origWidth / $targetWidth) : $scalar = ($origHeight / $targetHeight);
+    ($origWidth > $origHeight) ? $scalar = ($origWidth/$targetWidth) : $scalar = ($origHeight/$targetHeight);
 
     if ($scalar != 0) {
-        $destWidth = $origWidth / $scalar;
-        $destHeight = $origHeight / $scalar;
+        $destWidth = $origWidth/$scalar;
+        $destHeight = $origHeight/$scalar;
     } else {
         $destWidth = $origWidth;
         $destHeight = $origHeight;
@@ -138,7 +138,7 @@ 
     $gd_info = gd_info();
     $v = $gd_info["GD Version"];
     $v = explode('.', $v);
-    $v = (int)$v[0];        // major version
+    $v = (int)$v[0]; // major version
     if ($v >= 2) {
         // If you are using a modern PHP/GD installation that does
         // 'truecolor' images, this is what's needed.
@@ -181,7 +181,7 @@ 
         $options->htmlitems = false;
         $temp = output_transform($profile->response1, $options);
         $temp = sanitize_tags($temp);
-        $description = "(\"" . sub_sentence($temp, ' ', MAX_DESC_LENGTH, true) . "\")";
+        $description = "(\"".sub_sentence($temp, ' ', MAX_DESC_LENGTH, true)."\")";
 
     }
 
@@ -191,7 +191,7 @@ 
 
 function check_whether_to_show_profile($user, $logged_in_user) {
     $min_credit = parse_config(get_config(), "<profile_min_credit>");
-    if (!$logged_in_user && $min_credit && $user->expavg_credit < $min_credit ) {
+    if (!$logged_in_user && $min_credit && $user->expavg_credit < $min_credit) {
         error_page(
            tra("To prevent spam, profiles of users with an average credit of less than %1 are displayed only to logged-in users. We apologize for this inconvenience.", $min_credit)
         );
@@ -229,7 +229,7 @@ 
     //
     $show_picture = $profile->has_picture;
     if (profile_screening()) {
-        if (!$screen_mode && !$can_edit && $profile->verification!=1) {
+        if (!$screen_mode && !$can_edit && $profile->verification != 1) {
             $show_picture = false;
         }
     }
@@ -245,7 +245,7 @@ 
     // yet verified.  This will tell them if other users can't view it yet, or
     // if there is a problem with it and they need to replace it.
     //
-    if (profile_screening() && $profile->has_picture && $can_edit && $profile->verification!=1) {
+    if (profile_screening() && $profile->has_picture && $can_edit && $profile->verification != 1) {
         row1(offensive_profile_warning($profile->verification));
     }
 

Indentation +1 added lines, -1 removed lines

@@ -193,7 +193,7 @@
     $min_credit = parse_config(get_config(), "<profile_min_credit>");
     if (!$logged_in_user && $min_credit && $user->expavg_credit < $min_credit ) {
         error_page(
-           tra("To prevent spam, profiles of users with an average credit of less than %1 are displayed only to logged-in users. We apologize for this inconvenience.", $min_credit)
+            tra("To prevent spam, profiles of users with an average credit of less than %1 are displayed only to logged-in users. We apologize for this inconvenience.", $min_credit)
         );
     }
 }

html/ops/sample_table_stats.php

Spacing +13 added lines, -13 removed lines

@@ -27,25 +27,25 @@
     row_array(array("Name", "Engine", "Version", "Row Format", "Rows", "Avg Row Length (KB)", "Data Length (MB)", "Max Data Length (MB)", "Index Length (MB)", "Data free (MB)", "Create Time", "Update Time", "Check Time", "Create Options", "Comment"));
     db_init();
     $result = _mysql_query("show table status");
-    while($row = _mysql_fetch_array($result)) {
+    while ($row = _mysql_fetch_array($result)) {
         $size += ($row["Data_length"] + $row["Index_length"]);
         $engine = $row["Engine"];
         //if (!$engine) $engine = $row["Type"];
         row_array(array(
             $row["Name"],
             $engine,
-            $row["Version"] ,
-            $row["Row_format"] ,
-            $row["Rows"] ,
-            round($row["Avg_row_length"]/1024,2) ,
-            round($row["Data_length"]/(1024*1024),2) ,
-            round($row["Max_data_length"]/(1024*1024),2) ,
-            round($row["Index_length"]/(1024*1024),2) ,
-            round($row["Data_free"]/(1024*1024),2) ,
-            $row["Create_time"] ,
-            $row["Update_time"] ,
-            $row["Check_time"] ,
-            $row["Create_options"] ,
+            $row["Version"],
+            $row["Row_format"],
+            $row["Rows"],
+            round($row["Avg_row_length"]/1024, 2),
+            round($row["Data_length"]/(1024*1024), 2),
+            round($row["Max_data_length"]/(1024*1024), 2),
+            round($row["Index_length"]/(1024*1024), 2),
+            round($row["Data_free"]/(1024*1024), 2),
+            $row["Create_time"],
+            $row["Update_time"],
+            $row["Check_time"],
+            $row["Create_options"],
             $row["Comment"]
         ));
     }

html/user/sandbox.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -218,13 +218,13 @@
 function get_file($user) {
     $dir = sandbox_dir($user);
     $url = post_str('url');
-    if (filter_var($url, FILTER_VALIDATE_URL) === FALSE) {
+    if (filter_var($url, FILTER_VALIDATE_URL) === false) {
         error_page('Not a valid URL');
     }
     $fname = basename($url);
     $path = "$dir/$fname";
     if (file_exists($path)) {
-        error_page("File $fname exists; delete it first.");
+        error_page("file $fname exists; delete it first.");
     }
     copy($url, $path);
     $notice = "Fetched file from <strong>$url</strong><br/>";

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
     page_tail();
 }
 
-function list_files($user, $notice=null) {
+function list_files($user, $notice = null) {
     $dir = sandbox_dir($user);
     if (!is_dir($dir)) error_page("Can't open sandbox directory");
     page_head("File sandbox");
@@ -168,7 +168,7 @@ 
     $notice = "";
     $dir = sandbox_dir($user);
     $count = count($_FILES['new_file']['tmp_name']);
-    for ($i=0; $i<$count; $i++) {
+    for ($i = 0; $i < $count; $i++) {
         $tmp_name = $_FILES['new_file']['tmp_name'][$i];
         if (!is_uploaded_file($tmp_name)) {
             error_page("$tmp_name is not uploaded file");

html/inc/consent.inc

Spacing +5 added lines, -5 removed lines

@@ -21,7 +21,7 @@ 
 require_once("../inc/boinc_db.inc");
 require_once("../inc/util.inc");
 
-define('CONSENT_TYPE_ENROLL','ENROLL');
+define('CONSENT_TYPE_ENROLL', 'ENROLL');
 
 function check_termsofuse() {
     return defined('TERMSOFUSE_FILE') and file_exists(TERMSOFUSE_FILE);
@@ -32,13 +32,13 @@ 
     $source, $ctime = 0
 ) {
     $mys = BoincDb::escape_string($source);
-    if ($ctime==0) {
+    if ($ctime == 0) {
         $mytime = $user->create_time;
     } else {
         $mytime = $ctime;
     }
     return BoincConsent::insert(
-        "(userid, consent_type_id, consent_time, consent_flag, consent_not_required, source) " .
+        "(userid, consent_type_id, consent_time, consent_flag, consent_not_required, source) ".
         "values($user->id, $consent_type_id, $mytime, $consent_flag, $consent_not_required, '$mys')"
     );
 
@@ -65,10 +65,10 @@ 
 // The integer is the consent_type_id- the id from consent_type table.
 // If the boolean is FALSE, the integer returned is -1.
 //
-function check_consent_type($name, $checkenabled=TRUE) {
+function check_consent_type($name, $checkenabled = TRUE) {
     $name = BoincDb::escape_string($name);
     $ct = BoincConsentType::lookup("shortname = '$name'");
-    if ($ct and ( !$checkenabled or ($ct->enabled)) ) {
+    if ($ct and (!$checkenabled or ($ct->enabled))) {
         return array(TRUE, $ct->id);
     }
     return array(FALSE, -1);

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -52,10 +52,10 @@ 
             "userid=$user->id AND consent_type_id=$ctid AND consent_flag=1"
         );
         if ($consent_result) {
-            return TRUE;
+            return true;
         }
     }
-    return FALSE;
+    return false;
 }
 
 // Check if a particular consent_type name is available.
@@ -65,13 +65,13 @@ 
 // The integer is the consent_type_id- the id from consent_type table.
 // If the boolean is FALSE, the integer returned is -1.
 //
-function check_consent_type($name, $checkenabled=TRUE) {
+function check_consent_type($name, $checkenabled=true) {
     $name = BoincDb::escape_string($name);
     $ct = BoincConsentType::lookup("shortname = '$name'");
     if ($ct and ( !$checkenabled or ($ct->enabled)) ) {
-        return array(TRUE, $ct->id);
+        return array(true, $ct->id);
     }
-    return array(FALSE, -1);
+    return array(false, -1);
 }
 
 // When a user uses the Web site to login, this function checks the

html/user/openid_login.php

Spacing +3 added lines, -3 removed lines

@@ -16,7 +16,7 @@ 
 // You should have received a copy of the GNU Lesser General Public License
 // along with BOINC.  If not, see <http://www.gnu.org/licenses/>.
 
-NOT FINISHED.   DON'T USE
+NOT FINISHED.DON'T USE
 
 require 'openid.php';
 include_once("../inc/boinc_db.inc");
@@ -26,14 +26,14 @@ 
 
 function show_error($str) {
     page_head("Can't create account");
-    echo "$str<br>\n";
+    echo "$str < br > \n";
     page_tail();
     exit();
 }
 
 try {
     $openid = new LightOpenID;
-    echo "<pre>";
+    echo " < pre > ";
     if(!$openid->mode) {
         if(isset($_POST['openid_identifier'])) {
             $openid->identity = $_POST['openid_identifier'];

html/user/prefs_edit.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 $subset = sanitize_tags(get_str("subset"));
 $venue = sanitize_tags(get_str("venue", true));
 $columns = get_int("cols", true);
-$c = $columns?"&cols=$columns":"";
+$c = $columns ? "&cols=$columns" : "";
 check_subset($subset);
 if ($action) {
     check_tokens($user->authenticator);

html/inc/util_basic.inc

Spacing +6 added lines, -6 removed lines

@@ -56,10 +56,10 @@ 
     return file_exists("$d/stop_sched");
 }
 
-function xml_error($num=-1, $msg=null, $file=null, $line=null) {
+function xml_error($num = -1, $msg = null, $file = null, $line = null) {
     global $xml_outer_tag;
     if (!$msg) {
-        switch($num) {
+        switch ($num) {
         case -112: $msg = "Invalid XML"; break;
         case -136: $msg = "Not found"; break;
         case -137: $msg = "Name or email address is not unique"; break;
@@ -105,7 +105,7 @@ 
 // If it's a single-tag element, and it's present, just return the tag
 //
 function parse_element($xml, $tag) {
-    $closetag = "</" . substr($tag,1);
+    $closetag = "</".substr($tag, 1);
     $x = strstr($xml, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -121,8 +121,8 @@ 
 
 function parse_next_element($xml, $tag, &$cursor) {
     $element = null;
-    $closetag = "</" . substr($tag,1);
-    $pos = substr($xml,$cursor);
+    $closetag = "</".substr($tag, 1);
+    $pos = substr($xml, $cursor);
     $x = strstr($pos, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -222,7 +222,7 @@ 
 // whose OSs may have such restrictions.
 //
 function is_valid_filename($x) {
-    if (strlen($x)>255) return false;
+    if (strlen($x) > 255) return false;
     // \w means A-Za-z0-9_
     return preg_match('/^[\w\-.]+$/', $x);
 }

html/user/forum_thread_vote.php

Spacing +1 added lines, -1 removed lines

@@ -30,6 +30,6 @@
 if (!$thread) error_page('No such thread');
 $logged_in_user = get_logged_in_user();
 
-$posts = get_thread_posts($threadid, 0,true);
+$posts = get_thread_posts($threadid, 0, true);
 header("Location: forum_rate.php?choice=p&post=".$posts[0]->id);
 ?>

html/user/forum_moderate_post.php

Spacing +5 added lines, -5 removed lines

@@ -50,7 +50,7 @@ 
 start_table();
 
 $get_reason = true;
-if (get_str('action')=="hide") {
+if (get_str('action') == "hide") {
     //display input that selects reason
     echo "<input type=hidden name=action value=hide>";
     row1(tra("Hide post"));
@@ -67,12 +67,12 @@ 
             )
         )
     );
-} elseif (get_str('action')=="move") {
+} elseif (get_str('action') == "move") {
     row1(tra("Move post"));
     echo "<input type=hidden name=action value=move>";
     row2(tra("Destination thread ID:"), "<input name=\"threadid\">");
     // TODO: display where to move the post as a dropdown instead of having to get ID
-} elseif (get_str('action')=="banish_user") {
+} elseif (get_str('action') == "banish_user") {
     $userid = get_int('userid');
     $user = BoincUser::lookup_id($userid);
     if (!$user) {
@@ -80,7 +80,7 @@ 
     }
     BoincForumPrefs::lookup($user);
     $x = $user->prefs->banished_until;
-    if ($x>time()) {
+    if ($x > time()) {
         error_page(tra("User is already banished"));
     }
     row1(tra("Banish user"));
@@ -98,7 +98,7 @@ 
     echo "<input type=\"hidden\" name=\"id\" value=\"".$postid."\">\n";
     echo "<input type=\"hidden\" name=\"userid\" value=\"".$userid."\">\n";
     echo "<input type=\"hidden\" name=\"confirmed\" value=\"yes\">\n";
-} elseif (get_str('action')=="delete") {
+} elseif (get_str('action') == "delete") {
     echo "<input type=hidden name=action value=delete>";
     row2(
         "Are you sure want to delete this post?  This cannot be undone.",