BOINC / boinc

html/ops/fix_prefs.php

Doc Comments +3 added lines

@@ -12,6 +12,9 @@
 // insert "\n</venue>\n" before "</global_preferences>"
 // This fixes an XML error introduced at some point in the past
 //
+/**
+ * @return string
+ */
 function repair_prefs($prefs) {
     if (strstr($prefs, '\"')) {
         return str_replace('\"', '"', $prefs);

html/ops/make_puser.php

Doc Comments +6 added lines

@@ -24,12 +24,18 @@
 
 db_init();
 
+/**
+ * @param string $tag
+ */
 function parse_num($xml, $tag) {
     $x = parse_element($xml, $tag);
     if (!$x) return 0;
     return $x;
 }
 
+/**
+ * @param string $tag
+ */
 function parse_boolint($xml, $tag) {
     $x = parse_bool($xml, $tag);
     if ($x) return 1;

html/ops/mass_email_script.php

Doc Comments +6 added lines

@@ -231,6 +231,9 @@ 
     }
 }
 
+/**
+ * @param resource $log
+ */
 function do_batch($startid, $n, $log) {
     $result = _mysql_query(
         "select * from user where id>$startid order by id limit $n"
@@ -245,6 +248,9 @@ 
     return $startid;
 }
 
+/**
+ * @param resource $log
+ */
 function do_one($thisid, $log) {
     $result = _mysql_query(
         "select * from user where id=$thisid"

Spacing +6 added lines, -6 removed lines

@@ -55,7 +55,7 @@ 
 $globals->batch = 1000;
 $globals->lapsed_interval = 60*86400;
 
-for ($i=1; $i<$argc; $i++) {
+for ($i = 1; $i < $argc; $i++) {
     if ($argv[$i] == "--batch") {
         $i++;
         $globals->batch = $argv[$i];
@@ -169,7 +169,7 @@ 
         gmdate('d F Y', $user->create_time),
         number_format($user->total_credit, 0),
         opt_out_url($user),
-        floor((time() - $user->last_rpc_time) / 86400),
+        floor((time() - $user->last_rpc_time)/86400),
     );
     return preg_replace($pat, $rep, $template);
 }
@@ -238,7 +238,7 @@ 
     while ($user = _mysql_fetch_object($result)) {
         handle_user($user);
         $startid = $user->id;
-        fputs($log, $user->id . "\n");
+        fputs($log, $user->id."\n");
         fflush($log);
     }
     _mysql_free_result($result);
@@ -252,7 +252,7 @@ 
     $user = _mysql_fetch_object($result);
     if ($user) {
         handle_user($user);
-        fputs($log, $user->id . "\n");
+        fputs($log, $user->id."\n");
         fflush($log);
     }
     _mysql_free_result($result);
@@ -289,7 +289,7 @@ 
     } else {
         $fid = fopen($id_file, 'r'); 
         if (!$fid) {
-            echo  $id_file . ' not found - create ID list and run again\n';
+            echo  $id_file.' not found - create ID list and run again\n';
             exit();
         }
         $thisid = 0;
@@ -300,7 +300,7 @@ 
         }
         fclose($fid);
     }
-    echo 'All done!' . "\n";
+    echo 'All done!'."\n";
 }
 
 if (!function_exists('make_php_mailer')) {

html/ops/notify.php

Doc Comments +3 added lines

@@ -39,6 +39,9 @@
     BoincNotify::delete_aux("create_time < $t");
 }
 
+/**
+ * @param string $message
+ */
 function send_notify_email($userid, $message) {
     $user = BoincUser::lookup_id($userid);
     $subject = "Daily notification summary from ".PROJECT;

Spacing +2 added lines, -2 removed lines

@@ -35,7 +35,7 @@ 
 // delete notifications older than 90 days
 //
 function delete_old_notifies() {
-    $t = time()-90*86400;
+    $t = time() - 90*86400;
     BoincNotify::delete_aux("create_time < $t");
 }
 
@@ -61,7 +61,7 @@ 
 function send_notify_emails() {
     $db = BoincDb::get();
 
-    $t = time() - (86400 + 3600);  // 1-hour slop factor
+    $t = time() - (86400 + 3600); // 1-hour slop factor
     $query = "select notify.* from ".$db->db_name.".notify, ".$db->db_name.".forum_preferences where forum_preferences.pm_notification=2 and notify.userid = forum_preferences.userid and notify.create_time > $t";
 
     $notifies = BoincNotify::enum_general($query);

html/ops/remote_server_status.php

Doc Comments +6 added lines

@@ -41,6 +41,9 @@ 
 
 // see if a web server is running at the given URL
 //
+/**
+ * @param string $url
+ */
 function web_server_running($url) {
     $u = parse_url($url);
     $url = $u['scheme']."://".$u['host'];
@@ -56,6 +59,9 @@ 
 
 // see if the given daemon is running on the host by checking its PID
 //
+/**
+ * @param string $host
+ */
 function is_daemon_running($host, $d) {
     if ($d->pid_file) {
         $path = "../../pid_$host/".(string)$d->pid_file;

Spacing +7 added lines, -7 removed lines

@@ -80,41 +80,41 @@
         die("can't parse config file\n");
     }
     $config = $c->config;
-    $master_url = (string) $config->master_url;
+    $master_url = (string)$config->master_url;
     $u = parse_url($master_url);
     $master_host = $u["host"];
 
-    $url = (string) $config->download_url;
+    $url = (string)$config->download_url;
     $u = parse_url($url);
     $h = $u["host"];
     if ($h != $master_host) {
         $y = new StdClass;
         $y->cmd = 'Download server';
         $y->host = $h;
-        $y->status = web_server_running($url)?1:0;
+        $y->status = web_server_running($url) ? 1 : 0;
         $x[] = $y;
     }
-    $url = (string) $config->upload_url;
+    $url = (string)$config->upload_url;
     $u = parse_url($url);
     $h = $u["host"];
     if ($h != $master_host) {
         $y = new StdClass;
         $y->cmd = 'Upload server';
         $y->host = $h;
-        $y->status = web_server_running($url)?1:0;
+        $y->status = web_server_running($url) ? 1 : 0;
         $x[] = $y;
     }
 
     $main_host = (string)$c->config->host;
     if ($c->config->www_host) {
-        $web_host = (string) $c->config->www_host;
+        $web_host = (string)$c->config->www_host;
     } else {
         $web_host = $main_host;
     }
     $daemons = $c->daemons;
     foreach ($daemons->daemon as $d) {
         if ((int)$d->disabled != 0) continue;
-        $host = $d->host?(string)$d->host:$main_host;
+        $host = $d->host ? (string)$d->host : $main_host;
         if ($host != $web_host) {
             $y = new StdClass;
             $y->cmd = (string)$d->cmd;

html/ops/single_job_setup.php

Doc Comments +8 added lines

@@ -107,10 +107,18 @@
     }
 }
 
+/**
+ * @param integer $i
+ *
+ * @return string
+ */
 function app_version_dir($app_name, $i, $platform) {
     return "apps/$app_name/1.$i/$platform";
 }
 
+/**
+ * @param integer $i
+ */
 function make_app_version_dir($app_name, $i, $platform) {
     @mkdir("apps/$app_name");
     @mkdir("apps/$app_name/1.$i");

html/ops/team_export.php

Doc Comments +3 added lines

@@ -58,6 +58,9 @@
     return $x;
 }
 
+/**
+ * @param resource $f
+ */
 function handle_team($team, $f) {
     echo "Team: $team->name\n";
     $user = BoincUser::lookup_id($team->userid);

Spacing +1 added lines, -1 removed lines

@@ -100,7 +100,7 @@
     $f = fopen("temp.xml", "w");
     $teams = BoincTeam::enum(null);
     fwrite($f, "<?xml version=\"1.0\" encoding=\"utf-8\"?>\n<teams>\n");
-    foreach($teams as $team) {
+    foreach ($teams as $team) {
         handle_team($team, $f);
     }
     fwrite($f, "</teams>\n");

html/ops/team_import.php

Doc Comments +9 added lines

@@ -88,6 +88,9 @@ 
     return null;
 }
 
+/**
+ * @param stdClass $t
+ */
 function valid_team($t) {
     if (!$t->id) return false;
     if (!$t->name) return false;
@@ -96,6 +99,9 @@ 
     return true;
 }
 
+/**
+ * @param stdClass $t
+ */
 function update_team($t, $team, $user) {
     global $dry_run;
     if (
@@ -126,6 +132,9 @@ 
     }
 }
 
+/**
+ * @param stdClass $t
+ */
 function insert_case($t, $user) {
     global $master_url;
     global $dry_run;

Spacing +1 added lines, -1 removed lines

@@ -227,7 +227,7 @@
         if ($team->seti_id) {
             if ($team->seti_id == $t->id) {
                 echo "   case 1\n";
-                update_team($t, $team, $user);      // update1 case
+                update_team($t, $team, $user); // update1 case
             } else {
                 echo "   team exists but has wrong seti_id\n";
             }

Braces +3 added lines, -6 removed lines

@@ -63,8 +63,7 @@ 
             $t->user_postal_code = decode($t->user_postal_code);
             $t->user_url = decode($t->user_url);
             return $t;
-        }
-        else if (strstr($s, '<name>')) $t->name = parse_element($s, '<name>');
+        } else if (strstr($s, '<name>')) $t->name = parse_element($s, '<name>');
         else if (strstr($s, '<url>')) $t->url = parse_element($s, '<url>');
         else if (strstr($s, '<type>')) $t->type = parse_element($s, '<type>');
         else if (strstr($s, '<name_html>')) $t->name_html = parse_element($s, '<name_html>');
@@ -73,14 +72,12 @@ 
                 if (strstr($s, '</description>')) break;
                 $t->description .= $s;
             }
-        }
-        else if (strstr($s, '<country>')) $t->country = parse_element($s, '<country>');
+        } else if (strstr($s, '<country>')) $t->country = parse_element($s, '<country>');
         else if (strstr($s, '<id>')) $t->id = parse_element($s, '<id>');
         else if (strstr($s, '<user_email_munged>')) {
             $user_email_munged = parse_element($s, '<user_email_munged>');
             $t->user_email = str_rot13($user_email_munged);
-        }
-        else if (strstr($s, '<user_name>')) $t->user_name = parse_element($s, '<user_name>');
+        } else if (strstr($s, '<user_name>')) $t->user_name = parse_element($s, '<user_name>');
         else if (strstr($s, '<user_country>')) $t->user_country = parse_element($s, '<user_country>');
         else if (strstr($s, '<user_postal_code>')) $t->user_postal_code = parse_element($s, '<user_postal_code>');
         else if (strstr($s, '<user_url>')) $t->user_url = parse_element($s, '<user_url>');

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -212,7 +212,7 @@
         return;
     }
 
-    echo "Processing $t->name $t->user_email\n";
+    echo "processing $t->name $t->user_email\n";
     $user = BoincUser::lookup_email_addr($t->user_email);
     $team = BoincTeam::lookup_name($t->name);
     if ($team) {

html/ops/update_profile_pages.php

Doc Comments +8 added lines

@@ -98,6 +98,9 @@ 
 // Generates a standard set of links between associated multi-page documents.
 //  All linked files must be of the form "$filename_<page number>.html".
 
+/**
+ * @param integer $currPageNum
+ */
 function write_page_links($filename, $currPageNum, $numPages) {
     echo "<p>Page $currPageNum of $numPages</p>";
 
@@ -332,6 +335,11 @@ 
 // A generalized function to produce some number of pages summarizing a
 // set of user profiles.
 
+/**
+ * @param integer $rowsPerPage
+ * @param integer $colsPerPage
+ * @param string $dir
+ */
 function build_profile_pages(
     $members, $title, $rowsPerPage, $colsPerPage, $dir, $base_filename
 ) {

Indentation +1 added lines, -1 removed lines

@@ -200,7 +200,7 @@
         for ($row = 0; $row < $height; $row++) {
             echo "<tr>";
             for ($col = 0; $col < $width; $col++) {
-	            if ($count < $numIds) {
+                if ($count < $numIds) {
                     echo "<td class=\"bordered\" align=\"center\">
                         <a href=\"".secure_url_base()."view_profile.php?userid=".$userIds[$count]."\"><img src=\"".secure_url_base().IMAGE_URL.$userIds[$count]."_sm.jpg\"></a>
                     </td>";

Spacing +15 added lines, -15 removed lines

@@ -39,7 +39,7 @@ 
 
 // TODO: convert to new DB interface
 
-$alphabet = array('A','B','C','D','E','F','G','H','I','J','K','L','M','N','O','P','Q','R','S','T','U','V','W','X','Y','Z','0','1','2','3','4','5','6','7','8','9');
+$alphabet = array('A', 'B', 'C', 'D', 'E', 'F', 'G', 'H', 'I', 'J', 'K', 'L', 'M', 'N', 'O', 'P', 'Q', 'R', 'S', 'T', 'U', 'V', 'W', 'X', 'Y', 'Z', '0', '1', '2', '3', '4', '5', '6', '7', '8', '9');
 
 
 // Builds a summary table of user profiles.
@@ -53,7 +53,7 @@ 
 function show_user_table($members, $offset, $numToDisplay, $cols) {
     start_table();
 
-    $rows = ceil($numToDisplay / $cols);
+    $rows = ceil($numToDisplay/$cols);
     $count = $offset;
     $numMembers = count($members);
 
@@ -151,7 +151,7 @@ 
     // Build an array of IDs of all users with pictures in their profiles.
     $userIds = array();
     $numIds = 0;
-    foreach($profiles as $profile) {
+    foreach ($profiles as $profile) {
         $user = BoincUser::lookup_id($profile->userid);
         if (!$user) continue; // maybe we should delete the profile if user is non-existent anymore?
         if ($user->name) {
@@ -171,7 +171,7 @@ 
 //        shuffle($userIds);
 //    }
 
-    $numPages = ceil(count($userIds)/($width * $height));
+    $numPages = ceil(count($userIds)/($width*$height));
 
     // Make sure that a page is generated even when no profiles with pictures
     // exist in order to avoid 404 errors from the profile_menu page.
@@ -185,7 +185,7 @@ 
     $count = 0;
 
     for ($page = 1; $page <= $numPages; $page++) {
-        $filename = PROFILE_PATH . "user_gallery_" . $page . ".html";
+        $filename = PROFILE_PATH."user_gallery_".$page.".html";
         open_output_buffer();
 
         page_head("Profile gallery: page $page of $numPages", null, false, "../");
@@ -244,7 +244,7 @@ 
     // of the userids who belong to those countries.
     // Format: array[country][index] = userid.
 
-    foreach($profiles as $profile) {
+    foreach ($profiles as $profile) {
         $user = BoincUser::lookup_id($profile->userid);
         if (!$user) continue; // maybe we should delete the profile if user is non-existent anymore?
         if ($user->country) {
@@ -264,7 +264,7 @@ 
     // TODO: Define a constant for the desired number of rows per page.
 
     foreach ($countries as $country) {
-        $baseFileName =  "profile_country_" . get_legal_filename($country);
+        $baseFileName = "profile_country_".get_legal_filename($country);
         build_profile_pages(
             $countryMembers[$country],
             "User Profiles from $country", 5, 2,
@@ -290,7 +290,7 @@ 
     $numIds = 0;
     $members = array();
 
-    foreach($profiles as $profile) {
+    foreach ($profiles as $profile) {
         $user = BoincUser::lookup_id($profile->userid);
         if (!$user) continue; // maybe we should delete the profile if user is non-existent anymore?
         if ($user->name) {
@@ -335,11 +335,11 @@ 
 function build_profile_pages(
     $members, $title, $rowsPerPage, $colsPerPage, $dir, $base_filename
 ) {
-    $numPerPage = $rowsPerPage * $colsPerPage;
-    $numPages = ceil(count($members) / $numPerPage);
+    $numPerPage = $rowsPerPage*$colsPerPage;
+    $numPages = ceil(count($members)/$numPerPage);
 
     for ($page = 1; $page <= $numPages; $page++) {
-        $filename = $dir . $base_filename . "_" . $page . ".html";
+        $filename = $dir.$base_filename."_".$page.".html";
         open_output_buffer();
 
         $pagetitle = $title.": Page $page of $numPages";
@@ -347,7 +347,7 @@ 
 
         echo "Last updated ", pretty_time_str(time()), "<p>\n";
 
-        $offset = (($page-1) * $rowsPerPage * $colsPerPage);
+        $offset = (($page - 1)*$rowsPerPage*$colsPerPage);
 
         show_user_table($members, $offset, $numPerPage, $colsPerPage);
 
@@ -364,11 +364,11 @@ 
     print_debug_msg("Beginning to build country summary page...");
     $countries = array_keys($countryMembers);
 
-    $filename = PROFILE_PATH . "profile_country.html";
+    $filename = PROFILE_PATH."profile_country.html";
     open_output_buffer();
 
     page_head("User Profiles by Country", null, null, "../");
-    echo "Last updated " . pretty_time_str(time()) . "<p>";
+    echo "Last updated ".pretty_time_str(time())."<p>";
 
     start_table();
     row_heading_array(array("Country", "Profiles"));
@@ -413,7 +413,7 @@ 
 
 $caching = true;
 
-if (@$argv[1]=="-d") $debug=true;
+if (@$argv[1] == "-d") $debug = true;
 
 build_country_pages();
 build_alpha_pages();

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -180,7 +180,7 @@
         $numPages = 1;
     }
 
-    print_debug_msg("Generating $numPages pages");
+    print_debug_msg("generating $numPages pages");
 
     $count = 0;