BOINC / boinc

html/inc/user.inc

Doc Comments +3 added lines

@@ -113,6 +113,9 @@
     return ($a->expavg_credit < $b->expavg_credit)? 1 : -1;
 }
 
+/**
+ * @param boolean $personal
+ */
 function show_other_projects($user, $personal) {
     if (!isset($user->projects)) return;
     if (count($user->projects) < 2) return;

Spacing +16 added lines, -16 removed lines

@@ -33,13 +33,13 @@ 
 // they've participated in
 //
 function get_other_projects($user) {
-    $cpid = md5($user->cross_project_id . $user->email_addr);
+    $cpid = md5($user->cross_project_id.$user->email_addr);
     $url = "http://boinc.netsoft-online.com/get_user.php?cpid=".$cpid;
 
     // Check the cache for that URL
     //
     $cacheddata = get_cached_data(REMOTE_PROJECTS_TTL, $url);
-    if ($cacheddata){
+    if ($cacheddata) {
         $remote = unserialize($cacheddata);
     } else {
         // Fetch the XML, use curl if fopen() is disallowed
@@ -110,7 +110,7 @@ 
 
 function cmp($a, $b) {
     if ($a->expavg_credit == $b->expavg_credit) return 0;
-    return ($a->expavg_credit < $b->expavg_credit)? 1 : -1;
+    return ($a->expavg_credit < $b->expavg_credit) ? 1 : -1;
 }
 
 function show_other_projects($user, $personal) {
@@ -133,7 +133,7 @@ 
         ),
         array("", ALIGN_RIGHT, ALIGN_RIGHT, ALIGN_RIGHT)
     );
-    foreach($user->projects as $project) {
+    foreach ($user->projects as $project) {
         show_project($project);
     }
     end_table();
@@ -174,7 +174,7 @@ 
     }
 
     if (!NO_STATS) {
-        $cpid = md5($user->cross_project_id . $user->email_addr);
+        $cpid = md5($user->cross_project_id.$user->email_addr);
         $x = "";
         shuffle($cpid_stats_sites);
         foreach ($cpid_stats_sites as $site) {
@@ -320,7 +320,7 @@ 
 // show user name, with links to profile if present.
 // if $badge_height is > 0, show badges
 //
-function user_links($user, $badge_height=0) {
+function user_links($user, $badge_height = 0) {
     BoincForumPrefs::lookup($user);
     if (is_banished($user)) {
         return "(banished: ID $user->id)";
@@ -331,7 +331,7 @@ 
         $x .= ' <a href="'.url_base().'view_profile.php?userid='.$user->id.'"><img title="View the profile of '.$user->name.'" src="'.$img_url.'" alt="Profile"></a>';
     }
     $x .= " <a href=\"".url_base()."show_user.php?userid=".$user->id."\">".$user->name."</a>";
-    if (function_exists("project_user_links")){
+    if (function_exists("project_user_links")) {
         $x .= project_user_links($user);
     }
     if ($badge_height) {
@@ -384,7 +384,7 @@ 
 
             // if there's a foundership request, notify the founder
             //
-            if ($user->id==$team->userid && $team->ping_user >0) {
+            if ($user->id == $team->userid && $team->ping_user > 0) {
                 $x .= "<p class=\"text-danger\">".tra("(foundership change request pending)")."</p>";
             }
             row2(tra("Member of team"), $x);
@@ -409,7 +409,7 @@ 
     $x = "<a href=\"user_search.php\">".tra("Find friends")."</a><br/>\n";
     $n = count($friends);
     if ($n) {
-        foreach($friends as $friend) {
+        foreach ($friends as $friend) {
             $fuser = BoincUser::lookup_id($friend->user_dest);
             if (!$fuser) continue;
             $x .= friend_links($fuser);
@@ -452,7 +452,7 @@ 
 // Returns a cacheable community links data object
 // @param user The user to produce a community links object for
 
-function get_community_links_object($user){
+function get_community_links_object($user) {
     $cache_object = new StdClass;
     $cache_object->post_count = total_posts($user);
     $cache_object->user = $user;
@@ -460,7 +460,7 @@ 
     $cache_object->friends = array();
 
     $friends = BoincFriend::enum("user_src=$user->id and reciprocated=1");
-    foreach($friends as $friend) {
+    foreach ($friends as $friend) {
         $fuser = BoincUser::lookup_id($friend->user_dest);
         if (!$fuser) continue;
         $cache_object->friends[] = $fuser;
@@ -468,7 +468,7 @@ 
     return $cache_object;
 }
 
-function community_links($clo, $logged_in_user){
+function community_links($clo, $logged_in_user) {
     $user = $clo->user;
     $team = $clo->team;
     $friends = $clo->friends;
@@ -494,15 +494,15 @@ 
                 "<a href=\"friend.php?action=cancel_confirm&userid=$user->id\">".tra("Cancel friendship")."</a>"
             );
         } else if ($friend) {
-            row2(tra("Friends"),  "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Request pending")."</a>");
+            row2(tra("Friends"), "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Request pending")."</a>");
         } else {
-            row2(tra("Friends"),  "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Add as friend")."</a>");
+            row2(tra("Friends"), "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Add as friend")."</a>");
         }
     }
     
     if ($friends) {
         $x = "";
-        foreach($friends as $friend) {
+        foreach ($friends as $friend) {
             $x .= friend_links($friend);
         }
         row2(tra("Friends")." (".sizeof($friends).")", $x);
@@ -546,6 +546,6 @@ 
     );
 }
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 
 ?>

Braces +4 added lines, -4 removed lines

@@ -39,7 +39,7 @@ 
     // Check the cache for that URL
     //
     $cacheddata = get_cached_data(REMOTE_PROJECTS_TTL, $url);
-    if ($cacheddata){
+    if ($cacheddata) {
         $remote = unserialize($cacheddata);
     } else {
         // Fetch the XML, use curl if fopen() is disallowed
@@ -331,7 +331,7 @@ 
         $x .= ' <a href="'.url_base().'view_profile.php?userid='.$user->id.'"><img title="View the profile of '.$user->name.'" src="'.$img_url.'" alt="Profile"></a>';
     }
     $x .= " <a href=\"".url_base()."show_user.php?userid=".$user->id."\">".$user->name."</a>";
-    if (function_exists("project_user_links")){
+    if (function_exists("project_user_links")) {
         $x .= project_user_links($user);
     }
     if ($badge_height) {
@@ -452,7 +452,7 @@ 
 // Returns a cacheable community links data object
 // @param user The user to produce a community links object for
 
-function get_community_links_object($user){
+function get_community_links_object($user) {
     $cache_object = new StdClass;
     $cache_object->post_count = total_posts($user);
     $cache_object->user = $user;
@@ -468,7 +468,7 @@ 
     return $cache_object;
 }
 
-function community_links($clo, $logged_in_user){
+function community_links($clo, $logged_in_user) {
     $user = $clo->user;
     $team = $clo->team;
     $friends = $clo->friends;

html/inc/util_ops.inc

Doc Comments +17 added lines

@@ -65,10 +65,17 @@ 
          . "<p>\n";
 }
 
+/**
+ * @param string $x
+ */
 function row($x, $y) {
     echo "<tr><td valign=\"top\" align=\"right\">$x</td>\n<td>$y</td>\n</tr>\n";
 }
 
+/**
+ * @param string $color
+ * @param string $x
+ */
 function c_row2($color, $x, $y) {
     echo "<tr bgcolor=\"$color\"><td align=\"right\">$x</td><td>$y</td></tr>\n";
 }
@@ -134,6 +141,9 @@ 
 
 // allow access only if logged in as user in a given set
 //
+/**
+ * @param integer[] $admin_user_ids
+ */
 function auth_ops_userid($admin_user_ids) {
     $user = get_logged_in_user_ops();
     if (!$user) {
@@ -288,6 +298,10 @@ 
 
 ////// badge-related stuff
 
+/**
+ * @param string $name
+ * @param string $title
+ */
 function get_badge($name, $title, $image_url) {
     $b = BoincBadge::lookup("name='$name'");
     if ($b) return $b;
@@ -319,6 +333,9 @@ 
 
 // unassign all badges except the given one
 //
+/**
+ * @param integer $k
+ */
 function unassign_badges($is_user, $item, $badges, $k) {
     $list = null;
     for ($i=0; $i<count($badges); $i++) {

Indentation +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
 
 function print_text_field($text,$name,$value) {
     echo "$text <input type=\"text\" size=\"10\" name=\"$name\" value=\"$value\">\n"
-         . "<p>\n";
+            . "<p>\n";
 }
 
 function row($x, $y) {
@@ -378,7 +378,7 @@ 
         $db->do_query($q4);
         return 2;
     } else if (!$db->do_query($q3)) {
-      echo "MySQL command '$q3' failed:<br/>unable to cancel workunits and trigger transitioner.<br>\n";
+        echo "MySQL command '$q3' failed:<br/>unable to cancel workunits and trigger transitioner.<br>\n";
         $db->do_query($q4);
         return 3;
     }

Spacing +10 added lines, -10 removed lines

@@ -46,21 +46,21 @@ 
 
 // TODO: get rid of all the following
 
-function print_checkbox($text,$name,$checked) {
+function print_checkbox($text, $name, $checked) {
     echo "<input type=\"checkbox\" name=\"$name\""
-        . (strlen($checked) ? " checked=\"checked\"" : "") . ">"
+        . (strlen($checked) ? " checked=\"checked\"" : "").">"
         . "$text\n"
         . "<p>\n";
 }
 
-function print_radio_button($text,$name,$value,$checked) {
+function print_radio_button($text, $name, $value, $checked) {
     echo "<input type=\"radio\" name=\"$name\" value=\"$value\""
-        . (strlen($checked) ? " checked=\"checked\"" : "") . ">"
+        . (strlen($checked) ? " checked=\"checked\"" : "").">"
         . "$text\n"
         . "<br>\n";
 }
 
-function print_text_field($text,$name,$value) {
+function print_text_field($text, $name, $value) {
     echo "$text <input type=\"text\" size=\"10\" name=\"$name\" value=\"$value\">\n"
          . "<p>\n";
 }
@@ -91,7 +91,7 @@ 
     if ($host == null) {
         $host = "localhost";
     }
-    $in = fopen("php://stdin","r");
+    $in = fopen("php://stdin", "r");
     print "Database username (default: owner of mysqld process): ";
     $user = rtrim(fgets($in, 80));
     print "Database password (if any): ";
@@ -103,7 +103,7 @@ 
     }
 }
 
-function print_login_form_ops($next_url='') {
+function print_login_form_ops($next_url = '') {
     if ($next_url == '') $next_url = $_SERVER['REQUEST_URI'];
     start_table();
     echo "
@@ -200,7 +200,7 @@ 
 // return a list of the current, non-deprecated ones
 //
 function current_versions($avs) {
-    foreach($avs as $av) {
+    foreach ($avs as $av) {
         foreach ($avs as $av2) {
             if ($av->id == $av2->id) continue;
             if ($av->platformid == $av2->platformid && $av->plan_class == $av2->plan_class && $av->version_num > $av2->version_num) {
@@ -209,7 +209,7 @@ 
         }
     }
     $x = array();
-    foreach($avs as $av) {
+    foreach ($avs as $av) {
         if (!$av->deprecated) $x[] = $av;
     }
     return $x;
@@ -321,7 +321,7 @@ 
 //
 function unassign_badges($is_user, $item, $badges, $k) {
     $list = null;
-    for ($i=0; $i<count($badges); $i++) {
+    for ($i = 0; $i < count($badges); $i++) {
         if ($i == $k) continue;
         $badge = $badges[$i];
         if ($list) {

Braces +1 added lines, -1 removed lines

@@ -74,7 +74,7 @@
 }
 
 function show_profile_link_ops($user) {
-    if ($user->has_profile) { 
+    if ($user->has_profile) {
         row2("Profile",
             "<a href=\"".url_base()."view_profile.php?userid=$user->id\">View</a>"
         );

html/inc/web_rpc_api.inc

Doc Comments +14 added lines

@@ -21,6 +21,9 @@ 
 // my PHP currently doesn't support file_get_contents(https://...)
 // so do it with Curl
 //
+/**
+ * @param string $url
+ */
 function fetch_url($url) {
     if (0) {
         return file_get_contents($url);
@@ -35,6 +38,11 @@ 
     }
 }
 
+/**
+ * @param string $project_url
+ * @param string $email_addr
+ * @param string $passwd_hash
+ */
 function lookup_account(
     $project_url,
     $email_addr,
@@ -57,6 +65,12 @@ 
 
 // return (authenticator, errmsg)
 //
+/**
+ * @param string $project_url
+ * @param string $email_addr
+ * @param string $passwd_hash
+ * @param string $user_name
+ */
 function create_account(
     $project_url,
     $email_addr,

html/inc/xml.inc

Doc Comments +3 added lines

@@ -57,6 +57,9 @@
 
 $xml_outer_tag = "";
 
+/**
+ * @param string $tag
+ */
 function xml_start_tag($tag) {
     global $xml_outer_tag;
     echo "<$tag>\n";

html/ops/badge_assign_custom.php

Doc Comments +6 added lines

@@ -72,6 +72,9 @@ 
 // badge_name_prefix should be user or team
 // sub_project is an array with name and short_name as in $sub_projects
 //
+/**
+ * @param string $badge_name_prefix
+ */
 function get_badges(
     $badge_name_prefix, $badge_level_names, $badge_images, $sub_project
 ) {
@@ -105,6 +108,9 @@ 
 // decide which subproject badge to assign, if any.
 // Unassign other badges.
 //
+/**
+ * @param string $where_clause
+ */
 function assign_sub_badge($is_user, $item, $levels, $badges, $where_clause) {
     if ($is_user) {
         $sub_total = BoincCreditUser::sum('total', "where userid=".$item->id." and ($where_clause)");

Spacing +6 added lines, -6 removed lines

@@ -77,7 +77,7 @@ 
 ) {
     $badges = array();
     $limit = count($badge_level_names);
-    for ($i=0; $i < $limit; $i++) {
+    for ($i = 0; $i < $limit; $i++) {
         $badges[$i] = get_badge($badge_name_prefix."_".$sub_project["short_name"]."_".$i, "$badge_level_names[$i] in ".$sub_project["name"]." credit", $sub_project["short_name"].$badge_images[$i]);
     }
     return $badges;
@@ -90,7 +90,7 @@ 
     // count from highest to lowest level, so the user get's assigned the
     // highest possible level and the lower levels get removed
     //
-    for ($i=count($levels)-1; $i>=0; $i--) {
+    for ($i = count($levels) - 1; $i >= 0; $i--) {
         if ($item->total_credit >= $levels[$i]) {
             assign_badge($is_user, $item, $badges[$i]);
             unassign_badges($is_user, $item, $badges, $i);
@@ -114,7 +114,7 @@ 
     // count from highest to lowest level, so the user get's assigned the
     // highest possible level and the lower levels get removed
     //
-    for ($i=count($levels)-1; $i>=0; $i--) {
+    for ($i = count($levels) - 1; $i >= 0; $i--) {
         if ($sub_total >= $levels[$i]) {
             assign_badge($is_user, $item, $badges[$i]);
             unassign_badges($is_user, $item, $badges, $i);
@@ -134,7 +134,7 @@ 
     $is_user, $badge_levels, $badge_level_names, $badge_images,
     $subprojects_list
 ) {
-    $kind = $is_user?"user":"team";
+    $kind = $is_user ? "user" : "team";
 
     // get badges for all subprojects including total
     //
@@ -143,7 +143,7 @@ 
     }
 
     $n = 0;
-    $maxid = $is_user?BoincUser::max("id"):BoincTeam::max("id");
+    $maxid = $is_user ?BoincUser::max("id") : BoincTeam::max("id");
     while ($n <= $maxid) {
         $m = $n + 1000;
         if ($is_user) {
@@ -161,7 +161,7 @@ 
                     assign_tot_badge($is_user, $item, $badge_levels, $badges["total"]);
                 } else {
                     // appids come from project/project.inc
-                    $where_clause = "appid in (". implode(',', $sp["appids"]) .")";
+                    $where_clause = "appid in (".implode(',', $sp["appids"]).")";
                     assign_sub_badge(
                         $is_user, $item, $badge_levels, $badges[$sp["short_name"]],
                         $where_clause

html/ops/bolt_map.php

Doc Comments +16 added lines

@@ -173,6 +173,9 @@ 
     return $x;
 }
 
+/**
+ * @param integer $mode
+ */
 function get_nquestions($unit, $mode) {
     global $snap;
 
@@ -187,6 +190,9 @@ 
     return 0;
 }
 
+/**
+ * @param integer $mode
+ */
 function get_views($unit, $mode) {
     global $snap;
 
@@ -231,6 +237,10 @@ 
 
 $rownum = 0;
 
+/**
+ * @param string $class
+ * @param boolean $is_answer
+ */
 function show_unit_row($unit, $class, $level, $is_answer) {
     global $breakdown, $breakdown_cat;
     global $rownum, $course_id;
@@ -319,6 +329,9 @@ 
     echo "</tr>\n";
 }
 
+/**
+ * @param string $class
+ */
 function breakdown_class($class) {
     switch ($class) {
     case "BoltLesson":
@@ -356,6 +369,9 @@ 
     }
 }
 
+/**
+ * @param integer $level
+ */
 function show_unit_recurse($unit, $level) {
     show_unit($unit, $level);
     if ($unit->is_item) return;

Braces +1 added lines, -1 removed lines

@@ -243,7 +243,7 @@
             <td><br></td>
             <td><br></td>
         ";
-    } else  {
+    } else {
         $c = class_name($class);
         echo "
             <td><b>".spaces($level)."$unit->name</b></td>

Spacing +9 added lines, -9 removed lines

@@ -103,7 +103,7 @@ 
 
 function spaces($level) {
     $x = "";
-    for ($i=0; $i<$level; $i++) {
+    for ($i = 0; $i < $level; $i++) {
         $x .= "&nbsp;&nbsp;&nbsp;&nbsp;";
     }
     return $x;
@@ -136,7 +136,7 @@ 
 function avg_score($array) {
     $sum = 0;
     $n = count($array);
-    if ($n ==0) return 0;
+    if ($n == 0) return 0;
     foreach ($array as $a) {
         $sum += $a->score;
     }
@@ -152,7 +152,7 @@ 
             $n++;
         }
     }
-    if ($n ==0) return 0;
+    if ($n == 0) return 0;
     return $sum/$n;
 }
 
@@ -235,7 +235,7 @@ 
     global $breakdown, $breakdown_cat;
     global $rownum, $course_id;
 
-    $a = $is_answer?" (answer)":"";
+    $a = $is_answer ? " (answer)" : "";
     $j = ($rownum++)%2;
     echo "<tr class=row$j>";
     if ($breakdown && $breakdown_cat) {
@@ -243,7 +243,7 @@ 
             <td><br></td>
             <td><br></td>
         ";
-    } else  {
+    } else {
         $c = class_name($class);
         echo "
             <td><b>".spaces($level)."$unit->name</b></td>
@@ -277,7 +277,7 @@ 
         echo time_graph($t, 200);
         break;
     case "BoltExercise":
-        $mode = $is_answer?BOLT_MODE_ANSWER:BOLT_MODE_SHOW;
+        $mode = $is_answer ?BOLT_MODE_ANSWER:BOLT_MODE_SHOW;
         $views = get_views($unit, $mode);
         $n = count($views);
         $out = outcomes($views);
@@ -360,7 +360,7 @@ 
     show_unit($unit, $level);
     if ($unit->is_item) return;
     foreach ($unit->units as $u) {
-        show_unit_recurse($u, $level+1);
+        show_unit_recurse($u, $level + 1);
     }
 }
 
@@ -402,9 +402,9 @@ 
         <input type=hidden name=course_id value=$course_id>
         <table width=600><tr><td valign=top>
     ";
-    filter_form($filter?$filter->name():"", $filter_cat);
+    filter_form($filter ? $filter->name() : "", $filter_cat);
     echo "</td><td valign=top>";
-    breakdown_form($breakdown?$breakdown->name():"");
+    breakdown_form($breakdown ? $breakdown->name() : "");
     echo "
         </td></tr></table>
         <p>

html/ops/bossa_admin.php

Doc Comments +3 added lines

@@ -34,6 +34,9 @@
     require_once($file);
 }
 
+/**
+ * @param integer $i
+ */
 function show_bossa_app($app, $i) {
     $j = $i%2;
     echo "<tr class=row$j>

Spacing +5 added lines, -5 removed lines

@@ -101,9 +101,9 @@ 
     ";
     start_table();
     row1("User settings");
-    $x = ($flags&BOLT_FLAGS_SHOW_ALL)?"checked":"";
+    $x = ($flags&BOLT_FLAGS_SHOW_ALL) ? "checked" : "";
     row2("Show hidden apps?", "<input type=checkbox name=show_all $x>");
-    $x = ($flags&BOLT_FLAGS_DEBUG)?"checked":"";
+    $x = ($flags&BOLT_FLAGS_DEBUG) ? "checked" : "";
     row2("Show debugging output?", "<input type=checkbox name=debug $x>");
     row2("", "<input class=\"btn btn-default\" type=submit value=\"Update user\">");
     end_table();
@@ -171,7 +171,7 @@ 
     foreach ($jobs as $job) {
         $t = time_str($job->create_time);
         $s = job_state_string($job->state);
-        $j = $i++ % 2;
+        $j = $i++%2;
         echo "<tr class=row$j>
             <td>
                 $job->id <a href=bossa_admin.php?action=job_show_insts&job_id=$job->id>(details)</a><br>
@@ -203,7 +203,7 @@ 
         table_row(
             "$batch->id | <a href=bossa_admin.php?action=show_batch&batch_id=$batch->id>show jobs</a> | <a href=bossa_admin.php?action=clear_batch_confirm&batch_id=$batch->id>delete instances</a>",
             "$batch->name",
-            $batch->calibration?"yes":"no",
+            $batch->calibration ? "yes" : "no",
             time_str($batch->create_time),
             BossaJob::count("batch_id=$batch->id"),
             BossaJob::count("batch_id=$batch->id and state=2")
@@ -333,7 +333,7 @@ 
     if (!$time_estimate) $time_estimate = 60;
     $time_limit = get_str('time_limit');
     if (!$time_limit) $time_limit = 3600;
-    $calibration_frac = get_str('calibration_frac' , true);
+    $calibration_frac = get_str('calibration_frac', true);
     if (!$calibration_frac) $calibration_frac = 0;
     $now = time();
     $app_id = BossaApp::insert("(create_time, name, short_name, description, bolt_course_id, time_estimate, time_limit, calibration_frac) values ($now, '$name', '$short_name', '$description', $courseid, $time_estimate, $time_limit, $calibration_frac)");

html/ops/bossa_example_make_files.php

Doc Comments +9 added lines

@@ -28,6 +28,9 @@ 
 require_once("../inc/util_basic.inc");
 require_once("../inc/util_ops.inc");
 
+/**
+ * @param integer $range
+ */
 function rand_color($im, $range) {
     $mid = 200;
     $lo = $mid - $range;
@@ -35,12 +38,18 @@ 
     return imagecolorallocate($im, rand($lo,$hi), rand($lo,$hi), rand($lo,$hi));
 }
 
+/**
+ * @param resource $im
+ */
 function add_ellipse($im, $case) {
     imagefilledellipse(
         $im, $case->cx, $case->cy, $case->w, $case->h, rand_color($im, 50)
     );
 }
 
+/**
+ * @param resource $im
+ */
 function add_rect($im) {
     $cx = rand(-100, 600);
     $cy = rand(-100, 400);

Spacing +5 added lines, -5 removed lines

@@ -32,7 +32,7 @@ 
     $mid = 200;
     $lo = $mid - $range;
     $hi = $mid + $range;
-    return imagecolorallocate($im, rand($lo,$hi), rand($lo,$hi), rand($lo,$hi));
+    return imagecolorallocate($im, rand($lo, $hi), rand($lo, $hi), rand($lo, $hi));
 }
 
 function add_ellipse($im, $case) {
@@ -46,14 +46,14 @@ 
     $cy = rand(-100, 400);
     $w = rand(50, 100);
     $h = rand(50, 100);
-    imagefilledrectangle($im, $cx, $cy, $cx+$w, $cy+$h, rand_color($im, 50));
+    imagefilledrectangle($im, $cx, $cy, $cx + $w, $cy + $h, rand_color($im, 50));
 }
 
 
 function make_image($case) {
     $im = imagecreatetruecolor(600, 400);
     imagefill($im, 0, 0, imagecolorallocate($im, 255, 255, 255));
-    for ($i=0; $i<400; $i++) {
+    for ($i = 0; $i < 400; $i++) {
         add_rect($im);
     }
     $im2 = imagecreatetruecolor(600, 400);
@@ -85,7 +85,7 @@ 
 $nfiles = 0;
 $dir = null;
 $ellipse_frac = 0.5;
-for ($i=1; $i<$argc; $i++) {
+for ($i = 1; $i < $argc; $i++) {
     if ($argv[$i] == '--nfiles') $nfiles = $argv[++$i];
     elseif ($argv[$i] == '--dir') $dir = $argv[++$i];
     elseif ($argv[$i] == '--ellipse_frac') $ellipse_frac = $argv[++$i];
@@ -99,7 +99,7 @@ 
     exit("$dir is not a directory\n");
 }
 
-for ($i=0; $i<$nfiles; $i++) {
+for ($i = 0; $i < $nfiles; $i++) {
     $path = "$dir/$i.png";
     $anspath = "$dir/$i.ans";
     $case = make_test_case($ellipse_frac);

html/ops/credit_study.php

Doc Comments +3 added lines

@@ -66,6 +66,9 @@
 // $x is an array of result/host objects;
 // return the variance among claimed credits given an FP weight
 //
+/**
+ * @param double $fpw
+ */
 function fpw_var($results, $fpw) {
     $cc = array();
     foreach ($results as $r) {

Spacing +9 added lines, -9 removed lines

@@ -32,7 +32,7 @@ 
 function mean($x) {
     $sum = 0;
     $n = count($x);
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $sum += $x[$i];
     }
     return $sum/$n;
@@ -42,7 +42,7 @@ 
     $sum = 0;
     $n = count($x);
     $m = mean($x);
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $d = $x[$i] - $m;
         $sum += $d*$d;
         //echo "$x[$i] ";
@@ -56,10 +56,10 @@ 
 // returns the claimed credit for a given result/host and FP weight
 //
 function cc($x, $fpw) {
-    $cps = $x->p_fpops*$fpw + $x->p_iops*(1-$fpw);
+    $cps = $x->p_fpops*$fpw + $x->p_iops*(1 - $fpw);
     $cps /= 1e9;
     $cps /= 864;
-    $cc = $x->cpu_time * $cps;
+    $cc = $x->cpu_time*$cps;
     return $cc;
 }
 
@@ -84,7 +84,7 @@ 
     $nwus = 4000;
 
     $sum = array();
-    for ($i=0; $i<=10; $i++) {
+    for ($i = 0; $i <= 10; $i++) {
         $sum[] = 0;
     }
     $r1 = _mysql_query(
@@ -96,7 +96,7 @@ 
         $r2 = _mysql_query("select * from result where workunitid=$wu->id");
         $found_zero = false;
         while ($result = _mysql_fetch_object($r2)) {
-            if ($result->granted_credit==0) continue;   // skip invalid
+            if ($result->granted_credit == 0) continue; // skip invalid
             $host = BoincHost::lookup_id($result->hostid);
             $r = new StdClass;
             $r->cpu_time = $result->cpu_time;
@@ -105,8 +105,8 @@ 
             $results[] = $r;
         }
         //echo "Wu $wu->id -------------\n";
-        if (count($results)<2) continue;
-        for ($i=0; $i<=10; $i++) {
+        if (count($results) < 2) continue;
+        for ($i = 0; $i <= 10; $i++) {
             $fpw = $i/10.;
             $sum[$i] += fpw_var($results, $fpw);
         }
@@ -120,7 +120,7 @@ 
 Number of workunits analyzed: $n
 
 ";
-    for ($i=0; $i<=10; $i++) {
+    for ($i = 0; $i <= 10; $i++) {
         $fpw = $i/10.;
         $r = $sum[$i]/$n;
         echo "FP weight $fpw: variance is $r\n";