BOINC / boinc

html/user/kw_prefs.php

Spacing +3 added lines, -3 removed lines

@@ -93,9 +93,9 @@
     global $job_keywords;
     $kw = $job_keywords[$id];
     $u = $uprefs[$id];
-    $yes_checked = ($u == KW_YES)?"checked":"";
-    $no_checked = ($u == KW_NO)?"checked":"";
-    $maybe_checked = ($u == KW_MAYBE)?"checked":"";
+    $yes_checked = ($u == KW_YES) ? "checked" : "";
+    $no_checked = ($u == KW_NO) ? "checked" : "";
+    $maybe_checked = ($u == KW_MAYBE) ? "checked" : "";
 
     echo sprintf('<tr id="%s" hidden>%s', "row$id", "\n");
     echo sprintf('   <td width=50%% id="%s"></td>%s', "text$id", "\n");

html/inc/kw_prefs.inc

Spacing +3 added lines, -3 removed lines

@@ -31,14 +31,14 @@
     if (file_exists($path)) {
         $x = file($path);
         $yes = explode(' ', trim($x[0]));
-        if ($yes[0]=='') $yes=[];
+        if ($yes[0] == '') $yes = [];
         $yes = array_map('intval', $yes);
         $no = explode(' ', trim($x[1]));
-        if ($no[0]=='') $no=[];
+        if ($no[0] == '') $no = [];
         $no = array_map('intval', $no);
         return [$yes, $no];
     } else {
-        return [[],[]];
+        return [[], []];
     }
 }
 

html/inc/recaptchalib.inc

Spacing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
 
 function boinc_recaptcha_get_html($publickey) {
     if ($publickey) {
-        return '<div class="g-recaptcha" data-sitekey="' . $publickey . '"></div>';
+        return '<div class="g-recaptcha" data-sitekey="'.$publickey.'"></div>';
     } else {
         return '';
     }

html/user/submit_rpc_handler.php

Spacing +30 added lines, -30 removed lines

@@ -59,7 +59,7 @@ 
     if ($template) {
         $t = (double)$template->workunit->rsc_fpops_est;
     }
-    foreach($r->batch->job as $job) {
+    foreach ($r->batch->job as $job) {
         $y = (double)$job->rsc_fpops_est;
         if ($y) {
             $x += $y;
@@ -85,7 +85,7 @@ 
 function est_elapsed_time($r, $template) {
     // crude estimate: batch FLOPs / project FLOPS
     //
-    return batch_flop_count($r, $template) / project_flops();
+    return batch_flop_count($r, $template)/project_flops();
 }
 
 // if batch-level input template filename was given, read it;
@@ -95,9 +95,9 @@ 
 //
 function read_input_template($app, $r) {
     if ((isset($r->batch)) && (isset($r->batch->workunit_template_file)) && ($r->batch->workunit_template_file)) {
-        $path = project_dir() . "/templates/".$r->batch->workunit_template_file;
+        $path = project_dir()."/templates/".$r->batch->workunit_template_file;
     } else {
-        $path = project_dir() . "/templates/$app->name"."_in";
+        $path = project_dir()."/templates/$app->name"."_in";
     }
     if (file_exists($path)) {
         $x = simplexml_load_file($path);
@@ -145,7 +145,7 @@ 
 function validate_batch($jobs, $template) {
     $i = 0;
     $n = count($template->file_info);
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         $m = count($job->input_files);
         if ($n != $m) {
             log_write("wrong # of input files for job $i: need $n, got $m");
@@ -214,7 +214,7 @@ 
 // stage all the files
 //
 function stage_files(&$jobs, $user) {
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         foreach ($job->input_files as $file) {
             if ($file->mode != "remote") {
                 $file->name = stage_file($file, $user);
@@ -227,7 +227,7 @@ 
 //
 function submit_jobs(
     $jobs, $job_params, $app, $batch_id, $priority, $app_version_num,
-    $input_template_filename,        // batch-level; can also specify per job
+    $input_template_filename, // batch-level; can also specify per job
     $output_template_filename,
     $user
 ) {
@@ -237,7 +237,7 @@ 
     // one line per job
     //
     $x = "";
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         if ($job->name) {
             $x .= " --wu_name $job->name";
         }
@@ -272,7 +272,7 @@ 
         $x .= "\n";
     }
 
-    $cmd = "cd " . project_dir() . "; ./bin/create_work --appname $app->name --batch $batch_id";
+    $cmd = "cd ".project_dir()."; ./bin/create_work --appname $app->name --batch $batch_id";
 
     if ($user->seti_id) {
         $cmd .= " --target_user $user->id ";
@@ -383,7 +383,7 @@ 
 //
 function xml_get_jobs($r) {
     $jobs = array();
-    foreach($r->batch->job as $j) {
+    foreach ($r->batch->job as $j) {
         $job = new StdClass;
         $job->input_files = array();
         $job->command_line = (string)$j->command_line;
@@ -436,16 +436,16 @@ 
 //
 function logical_end_time($r, $jobs, $user, $app) {
     $total_flops = 0;
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         //print_r($job);
         if ($job->rsc_fpops_est) {
             $total_flops += $job->rsc_fpops_est;
         } else if ($job->input_template && $job->input_template->workunit->rsc_fpops_est) {
-            $total_flops += (double) $job->input_template->workunit->rsc_fpops_est;
+            $total_flops += (double)$job->input_template->workunit->rsc_fpops_est;
         } else if ($r->batch->job_params->rsc_fpops_est) {
-            $total_flops += (double) $r->batch->job_params->rsc_fpops_est;
+            $total_flops += (double)$r->batch->job_params->rsc_fpops_est;
         } else {
-            $x = (double) $template->workunit->rsc_fpops_est;
+            $x = (double)$template->workunit->rsc_fpops_est;
             if ($x) {
                 $total_flops += $x;
             } else {
@@ -453,7 +453,7 @@ 
             }
         }
     }
-    $cmd = "cd " . project_dir() . "/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
+    $cmd = "cd ".project_dir()."/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
     $x = exec($cmd);
     if (!is_numeric($x) || (double)$x == 0) {
         xml_error(-1, "$cmd returned $x");
@@ -538,15 +538,15 @@ 
     }
 
     $job_params = new StdClass;
-    $job_params->rsc_disk_bound = (double) $r->batch->job_params->rsc_disk_bound;
-    $job_params->rsc_fpops_est = (double) $r->batch->job_params->rsc_fpops_est;
-    $job_params->rsc_fpops_bound = (double) $r->batch->job_params->rsc_fpops_bound;
-    $job_params->rsc_memory_bound = (double) $r->batch->job_params->rsc_memory_bound;
-    $job_params->delay_bound = (double) $r->batch->job_params->delay_bound;
+    $job_params->rsc_disk_bound = (double)$r->batch->job_params->rsc_disk_bound;
+    $job_params->rsc_fpops_est = (double)$r->batch->job_params->rsc_fpops_est;
+    $job_params->rsc_fpops_bound = (double)$r->batch->job_params->rsc_fpops_bound;
+    $job_params->rsc_memory_bound = (double)$r->batch->job_params->rsc_memory_bound;
+    $job_params->delay_bound = (double)$r->batch->job_params->delay_bound;
         // could add quorum-related stuff
 
-    $input_template_filename = (string) $r->batch->input_template_filename;
-    $output_template_filename = (string) $r->batch->output_template_filename;
+    $input_template_filename = (string)$r->batch->input_template_filename;
+    $output_template_filename = (string)$r->batch->output_template_filename;
         // possibly empty
 
     submit_jobs(
@@ -639,7 +639,7 @@ 
 }
 
 function n_outfiles($wu) {
-    $path = project_dir() . "/$wu->output_template_filename";
+    $path = project_dir()."/$wu->output_template_filename";
     $r = simplexml_load_file($path);
     return count($r->file_info);
 }
@@ -846,7 +846,7 @@ 
 ";
         if ($result->server_state == 5) {   // over?
             $paths = get_outfile_paths($result);
-            foreach($paths as $path) {
+            foreach ($paths as $path) {
                 if (is_file($path)) {
                     $size = filesize($path);
                     echo "        <outfile>
@@ -890,7 +890,7 @@ 
     } else {
         $results = BoincResult::enum("workunitid=$job_id");
         foreach ($results as $r) {
-            switch($r->outcome) {
+            switch ($r->outcome) {
             case 1:
             case 3:
             case 6:
@@ -1005,8 +1005,8 @@ 
     }
 
     $user = check_remote_submit_permissions($r, $app);
-    $in = file_get_contents(project_dir() . "/templates/".$app->name."_in");
-    $out = file_get_contents(project_dir() . "/templates/".$app->name."_out");
+    $in = file_get_contents(project_dir()."/templates/".$app->name."_in");
+    $out = file_get_contents(project_dir()."/templates/".$app->name."_out");
     if ($in === false || $out === false) {
         log_write("template file missing");
         xml_error(-1, "template file missing");
@@ -1018,7 +1018,7 @@ 
 
 function ping($r) {
     xml_start_tag("ping");
-    BoincDb::get();     // errors out if DB down or web disabled
+    BoincDb::get(); // errors out if DB down or web disabled
     echo "<success>1</success>
         </ping>
     ";
@@ -1092,9 +1092,9 @@ 
 $request_log = parse_config(get_config(), "<remote_submit_request_log>");
 if ($request_log) {
     $log_dir = parse_config(get_config(), "<log_dir>");
-    $request_log = $log_dir . "/" . $request_log;
+    $request_log = $log_dir."/".$request_log;
     if ($file = fopen($request_log, "a")) {
-        fwrite($file, "\n<submit_rpc_handler date=\"" . date(DATE_ATOM) . "\">\n" . $req . "\n</submit_rpc_handler>\n");
+        fwrite($file, "\n<submit_rpc_handler date=\"".date(DATE_ATOM)."\">\n".$req."\n</submit_rpc_handler>\n");
         fclose($file);
     }
 }

html/inc/submit_util.inc

Spacing +4 added lines, -4 removed lines

@@ -179,7 +179,7 @@ 
     foreach ($res_in_prog as $res) {
         $wus_in_prog[$res->workunitid] = true;
     }
-    unset($res_in_progress);    // does this do anything?
+    unset($res_in_progress); // does this do anything?
 
     $fp_total = 0;
     $fp_done = 0;
@@ -352,7 +352,7 @@ 
 // get the total size of output files of a batch
 //
 function batch_output_file_size($batchid) {
-    $batch_td_size=0;
+    $batch_td_size = 0;
     $wus = BoincWorkunit::enum_fields(
         'canonical_resultid',
         "batch=$batchid"
@@ -385,7 +385,7 @@ 
 }
 
 function boinc_get_wu_output_files_url($user, $wu_id) {
-    $auth_str =  md5($user->authenticator.$wu_id);
+    $auth_str = md5($user->authenticator.$wu_id);
     return "get_output.php?cmd=workunit_files&wu_id=$wu_id&auth_str=$auth_str";
 }
 
@@ -419,7 +419,7 @@ 
     if (!file_exists($path)) return null;
     $x = file_get_contents($path);
     $n = sscanf($x, "%s %d", $md5, $size);
-    if ($n != 2 || strlen($md5)!=32) {
+    if ($n != 2 || strlen($md5) != 32) {
         return null;
     }
     return [$md5, $size];

html/user/json_form.php

Spacing +1 added lines, -1 removed lines

@@ -5,7 +5,7 @@
 require_once('../inc/util.inc');
 require_once('../inc/sandbox.inc');
 
-function sb_file_select($user, $suffix=null) {
+function sb_file_select($user, $suffix = null) {
     $sbfiles = sandbox_file_names($user);
     $sbitems = [];
     $exp = null;

html/user/weak_auth.php

Spacing +7 added lines, -7 removed lines

@@ -30,14 +30,14 @@ 
 $master_url = master_url();
 $idx = strpos($master_url, '://');
 if ($idx) {
-    $url = substr($master_url, $idx+strlen('://'));
+    $url = substr($master_url, $idx + strlen('://'));
 } else {
     $url = $master_url;
 }
 
 // convert invalid characters into underscores
 //
-for ($i=0; $i<strlen($url); $i++) {
+for ($i = 0; $i < strlen($url); $i++) {
     $c = $url[$i];
     if (!ctype_alnum($c) && $c != '.' && $c != '-' && $c != '_') {
         $url[$i] = '_';
@@ -46,7 +46,7 @@ 
 
 //remove trailing underscore(s)
 //
-$account_file = "account_" . rtrim($url, '_') . ".xml";
+$account_file = "account_".rtrim($url, '_').".xml";
 
 page_head(tra("Account keys"));
 text_start();
@@ -58,12 +58,12 @@ 
     <p>",
     tra("This key can be used to:"),
     "<ul>
-    <li><a href=get_passwd.php>",tra("log in to your account on the web"),"</a>;
+    <li><a href=get_passwd.php>",tra("log in to your account on the web"), "</a>;
     <li>",
         tra("attach a computer to your account without using the BOINC Manager.
        To do so, install BOINC,
        create a file named %1 in the BOINC
-       data directory, and set its contents to:","<b>$account_file</b>"),"
+       data directory, and set its contents to:","<b>$account_file</b>"), "
     <p><pre>",
     htmlspecialchars(
 "<account>
@@ -77,10 +77,10 @@ 
     as described above, but cannot be used to log in to your account or change it in any way.
     If you want to attach untrusted or insecure computers to your account,
     do so using your weak account key.
-    Your weak account key is:"),"
+    Your weak account key is:"), "
     <p><pre>$weak_auth</pre><p>
     ",
-    tra("The key depends on your account's email address and password.  If you change either of these, the weak account key will change."),"
+    tra("The key depends on your account's email address and password.  If you change either of these, the weak account key will change."), "
     </td></tr></table>"
 ;
 text_end();

html/user/submit_stats.php

Spacing +7 added lines, -7 removed lines

@@ -199,25 +199,25 @@ 
     $min = 1e99;
     $max = 0;
     foreach ($results as $r) {
-        $f = $r->flops / (4.3e9 *3600);
+        $f = $r->flops/(4.3e9*3600);
         if ($f > $max) $max = $f;
         if ($f < $min) $min = $f;
         $x[] = $f;
     }
     $n = 800;
     $count = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $count[$i] = 0;
     }
     $range = $max - $min;
     foreach ($x as $f) {
-        $d = intval($n*($f-$min)/$range);
-        if ($d >= $n) $d = $n-1;
+        $d = intval($n*($f - $min)/$range);
+        if ($d >= $n) $d = $n - 1;
         $count[$d] += 1;
     }
     $data = [];
-    for ($i=0; $i<$n; $i++) {
-        $data[] = [$min+($i*$range)/$n, $count[$i]];
+    for ($i = 0; $i < $n; $i++) {
+        $data[] = [$min + ($i*$range)/$n, $count[$i]];
     }
     graph($data, 'hours', 'count');
     page_tail();
@@ -225,7 +225,7 @@ 
 
 $batch = BoincBatch::lookup_id(get_int('batch_id'));
 if (!$batch) error_page('no batch');
-switch(get_str('action')) {
+switch (get_str('action')) {
 case 'err_host':
     err_host($batch);
     break;

html/inc/host.inc

Spacing +20 added lines, -20 removed lines

@@ -32,12 +32,12 @@ 
 
 function sched_log_name($x) {
     if ($x == 0) return "NO_SUCH_LOG";
-    return gmdate('Y-m-d_H/Y-m-d_H:i', $x) . ".txt";
+    return gmdate('Y-m-d_H/Y-m-d_H:i', $x).".txt";
 }
 
 function sched_log_link($x) {
     if (file_exists("sched_logs")) {
-        return "<a href=\"../sched_logs/" . sched_log_name($x) . "\">" . time_str($x) . "</a>";
+        return "<a href=\"../sched_logs/".sched_log_name($x)."\">".time_str($x)."</a>";
     } else {
         return time_str($x);
     }
@@ -45,7 +45,7 @@ 
 
 function location_form($host) {
     $none = "selected";
-    $h=$w=$s=$m="";
+    $h = $w = $s = $m = "";
     if ($host->venue == "home") $h = "selected";
     if ($host->venue == "work") $w = "selected";
     if ($host->venue == "school") $s = "selected";
@@ -99,7 +99,7 @@ 
             row2(tra("Product name"), $host->product_name);
         }
         $x = $host->timezone/3600;
-        if ($x >= 0) $x="+$x";
+        if ($x >= 0) $x = "+$x";
         row2(tra("Local Standard Time"), tra("UTC %1 hours", $x));
     } else {
         $owner = BoincUser::lookup_id($host->userid);
@@ -293,20 +293,20 @@ 
 // Older clients may have the old-style serialnum in the DB
 // despite the server being upgraded.
 //
-function vbox_desc($parsed_ser){
+function vbox_desc($parsed_ser) {
     if (empty($parsed_ser['vbox'])) return '---';
     $f = $parsed_ser['vbox'];
     $desc = sprintf('Virtualbox (%s) %s',
         $f[1], tra("installed")
     );
-    if (sizeof($f)<=2){
+    if (sizeof($f) <= 2) {
         return $desc;
     }
-    if ($f[2]=="1" and $f[3]=="1") {
+    if ($f[2] == "1" and $f[3] == "1") {
         return $desc.tra(", CPU has hardware virtualization support and it is enabled");
-    } elseif ($f[2]=="1" and $f[3]=="0") {
+    } elseif ($f[2] == "1" and $f[3] == "0") {
         return $desc.tra(", CPU has hardware virtualization support but it is disabled");
-    } elseif ($f[2]=="0") {
+    } elseif ($f[2] == "0") {
         return $desc.tra(", CPU does not have hardware virtualization support");
     }
     return $desc;
@@ -331,13 +331,13 @@ 
 
 // return a human-readable version of the GPU info
 //
-function gpu_desc($parsed_ser, $detail=true) {
+function gpu_desc($parsed_ser, $detail = true) {
     $str = "";
     foreach ($parsed_ser as $d) {
         if (!is_gpu_type($d[0])) continue;
         if (count($d) < 4) continue;
         if ($str) $str .= "<p>";
-        if ($d[2]!="" && $d[2]!="1") $str .= "[".$d[2]."] ";
+        if ($d[2] != "" && $d[2] != "1") $str .= "[".$d[2]."] ";
         if ($d[0] == "CUDA") {
             $str .= "NVIDIA";
         } else if ($d[0] == "CAL") {
@@ -543,14 +543,14 @@ 
     if ($pos1 === false) return $x;
     $pos2 = strpos($model, ']');
     if ($pos2 === false) return $x;
-    $a = substr($model, $pos1+1, $pos2-$pos1-1);
+    $a = substr($model, $pos1 + 1, $pos2 - $pos1 - 1);
     $y = explode(" ", $a);
     if (count($y) == 0) return $x;
     if ($y[0] == "Family") {
         $x->info = $a;
     } else {
         $x->arch = $y[0];
-        $x->info = substr($a, strlen($y[0])+1);
+        $x->info = substr($a, strlen($y[0]) + 1);
     }
     return $x;
 }
@@ -639,7 +639,7 @@ 
     $avg_time = 0;
 
     $results = BoincResult::enum("hostid=$hostid order by received_time");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         if ($result->granted_credit <= 0) continue;
         $total += $result->granted_credit;
 
@@ -732,7 +732,7 @@ 
 
 function link_url($sort, $rev, $show_all) {
     global $userid;
-    $x = $userid ? "&userid=$userid":"";
+    $x = $userid ? "&userid=$userid" : "";
     return "hosts_user.php?sort=$sort&rev=$rev&show_all=$show_all$x";
 }
 
@@ -806,7 +806,7 @@ 
 }
 
 function show_user_hosts($userid, $private, $show_all, $sort, $rev) {
-    $desc = false;  // whether the sort order's default is decreasing
+    $desc = false; // whether the sort order's default is decreasing
     switch ($sort) {
     case "total_credit": $sort_clause = "total_credit"; $desc = true; break;
     case "expavg_credit": $sort_clause = "expavg_credit"; $desc = true; break;
@@ -829,7 +829,7 @@ 
     more_or_less($sort, $rev, $show_all);
 
     $now = time();
-    $old_hosts=0;
+    $old_hosts = 0;
     $i = 1;
     $hosts = BoincHost::enum("userid=$userid order by $sort_clause limit 100");
     $any_product_name = false;
@@ -841,9 +841,9 @@ 
     }
     user_host_table_start($private, $sort, $rev, $show_all, $any_product_name);
     foreach ($hosts as $host) {
-        $is_old=false;
+        $is_old = false;
         if (($now - $host->rpc_time) > 30*86400) {
-            $is_old=true;
+            $is_old = true;
             $old_hosts++;
         }
         if (!$show_all && $is_old) continue;
@@ -852,7 +852,7 @@ 
     }
     end_table();
 
-    if ($old_hosts>0) {
+    if ($old_hosts > 0) {
         more_or_less($sort, $rev, $show_all);
     }