Passed
Pull Request — master (#4130)
by Christian
15:24 queued 03:30
created
html/ops/nvidia.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@  discard block
 block discarded – undo
21 21
 $cli_only = true;
22 22
 require_once("../inc/util_ops.inc");
23 23
 
24
-ini_set ("memory_limit", "8000M");
24
+ini_set("memory_limit", "8000M");
25 25
 set_time_limit(0);
26 26
 
27 27
 error_reporting(E_ALL);
@@ -68,21 +68,21 @@  discard block
 block discarded – undo
68 68
 }
69 69
 
70 70
 function analyze_nvidia() {
71
-	$hosts_total = 0;     // number of hosts 6.2 or better
72
-	$hosts_gpu = 0;     // number with an nvidia gpu
73
-	$rac_total =0;
71
+	$hosts_total = 0; // number of hosts 6.2 or better
72
+	$hosts_gpu = 0; // number with an nvidia gpu
73
+	$rac_total = 0;
74 74
 	$rac_gpu = 0;
75 75
 	$linux_total = 0;
76 76
 	$linux_gpus = 0;
77 77
 	$windows_total = 0;
78 78
 	$windows_gpus = 0;
79
-	$model = array();   // name -> count
80
-	$ram = array();     // size -> count
81
-	$driver = array();  // vers -> count
82
-	$ngpus = array();   // ngpus -> count
79
+	$model = array(); // name -> count
80
+	$ram = array(); // size -> count
81
+	$driver = array(); // vers -> count
82
+	$ngpus = array(); // ngpus -> count
83 83
 
84 84
 	$hosts = BoincHost::enum("expavg_credit > 10 and serialnum<>''");
85
-	foreach($hosts as $host) {
85
+	foreach ($hosts as $host) {
86 86
 		$boinc_vers = parse_vers($host->serialnum);
87 87
 		if (!$boinc_vers) continue;
88 88
 		if ($boinc_vers->major < 6) continue;
@@ -128,7 +128,7 @@  discard block
 block discarded – undo
128 128
 	echo "Avg RAC: GPU: $a non-GPU: $b\n";
129 129
 
130 130
 	arsort($model);
131
-	foreach($model as $m=>$c) {
131
+	foreach ($model as $m=>$c) {
132 132
 		echo "$m $c\n";
133 133
 	}
134 134
 	print_r($ram);
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
 	$nati = 0;
143 143
 	$nboth = 0;
144 144
 	$hosts = BoincHost::enum("expavg_credit > 10 and serialnum<>''");
145
-	foreach($hosts as $host) {
145
+	foreach ($hosts as $host) {
146 146
 		$boinc_vers = parse_vers($host->serialnum);
147 147
 		if (!$boinc_vers) continue;
148 148
 		if ($boinc_vers->major < 6) continue;
Please login to merge, or discard this patch.
html/ops/app_details.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@
 block discarded – undo
51 51
     row2("Plan class", $av->plan_class);
52 52
     row2("Version num", $av->version_num);
53 53
     row2("Jobs validated", $av->pfc_n);
54
-    row2("Average efficiency", $av->pfc_avg?1/$av->pfc_avg:"---");
54
+    row2("Average efficiency", $av->pfc_avg ? 1/$av->pfc_avg : "---");
55 55
     row2("Credit scale factor", $av->pfc_scale);
56 56
     row2("Average credit", $av->expavg_credit);
57 57
     end_table();
Please login to merge, or discard this patch.
html/ops/manage_app_versions.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -72,7 +72,7 @@  discard block
 block discarded – undo
72 72
       "deprecated?",
73 73
       ""
74 74
     );
75
-    $clause = $all?"true":"deprecated = 0";
75
+    $clause = $all ? "true" : "deprecated = 0";
76 76
     $avs = BoincAppVersion::enum(
77 77
         "$clause order by appid, platformid, plan_class, version_num"
78 78
     );
@@ -80,20 +80,20 @@  discard block
 block discarded – undo
80 80
     foreach ($avs as $av) {
81 81
         // grey out deprecated versions 
82 82
         //
83
-        $f1=$f2='';
83
+        $f1 = $f2 = '';
84 84
         if ($av->deprecated == 1) {
85
-            $f1="<font color='GREY'>";
86
-            $f2="</font>";
85
+            $f1 = "<font color='GREY'>";
86
+            $f2 = "</font>";
87 87
         }
88 88
 
89
-        $all_value = $all?1:0;
89
+        $all_value = $all ? 1 : 0;
90 90
         $app = $apps[$av->appid];
91 91
         // ignore app versions of deprecated apps by default
92 92
         if ($all_value == 0 && $app->deprecated == 1) {
93 93
             continue;
94 94
         }
95 95
         echo "<tr class=row$i><form action=manage_app_versions.php?all=$all_value#av_$av->id method=POST>\n";
96
-        $i = 1-$i;
96
+        $i = 1 - $i;
97 97
         echo "<input type=hidden name=id value=$av->id>";
98 98
         echo "  <TD>$f1 <a id='av_$av->id' href=db_action.php?table=app_version&id=$av->id>$av->id</a> $f2</TD>\n";
99 99
 
@@ -110,15 +110,15 @@  discard block
 block discarded – undo
110 110
         $v = $av->min_core_version;
111 111
         echo "  <TD><input type='text' size='4' name=min_core_version value='$v'></TD>\n";
112 112
 
113
-        $v=$av->max_core_version;
113
+        $v = $av->max_core_version;
114 114
         echo "  <TD><input type='text' size='4' name=max_core_version value='$v'></TD>\n";
115 115
 
116
-        $v='';
117
-        if ($av->beta) $v=' CHECKED ';
116
+        $v = '';
117
+        if ($av->beta) $v = ' CHECKED ';
118 118
         echo "  <TD> <input name=beta type='checkbox' $v></TD>\n";
119 119
 
120
-        $v='';
121
-        if ($av->deprecated) $v=' CHECKED ';
120
+        $v = '';
121
+        if ($av->deprecated) $v = ' CHECKED ';
122 122
         echo "  <TD> <input name=deprecated type='checkbox' $v></TD>\n";
123 123
 
124 124
         if (!in_rops()) {
Please login to merge, or discard this patch.
html/ops/team_import.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -227,7 +227,7 @@
 block discarded – undo
227 227
         if ($team->seti_id) {
228 228
             if ($team->seti_id == $t->id) {
229 229
                 echo "   case 1\n";
230
-                update_team($t, $team, $user);      // update1 case
230
+                update_team($t, $team, $user); // update1 case
231 231
             } else {
232 232
                 echo "   team exists but has wrong seti_id\n";
233 233
             }
Please login to merge, or discard this patch.
html/ops/repair_validator_problem.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -49,7 +49,7 @@
 block discarded – undo
49 49
     _mysql_free_result($r2);
50 50
     $nunsent = $x[0];
51 51
 
52
-    if ($nsuccess>=3 and $nunsent==0) {
52
+    if ($nsuccess >= 3 and $nunsent == 0) {
53 53
         echo "WU $wu->id has $nsuccess success, $nunsent unsent \n";
54 54
         _mysql_query("update workunit set need_validate=1 where id=$wu->id");
55 55
     }
Please login to merge, or discard this patch.
html/ops/notify.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
 // delete notifications older than 90 days
36 36
 //
37 37
 function delete_old_notifies() {
38
-    $t = time()-90*86400;
38
+    $t = time() - 90*86400;
39 39
     BoincNotify::delete_aux("create_time < $t");
40 40
 }
41 41
 
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
 function send_notify_emails() {
62 62
     $db = BoincDb::get();
63 63
 
64
-    $t = time() - (86400 + 3600);  // 1-hour slop factor
64
+    $t = time() - (86400 + 3600); // 1-hour slop factor
65 65
     $query = "select notify.* from ".$db->db_name.".notify, ".$db->db_name.".forum_preferences where forum_preferences.pm_notification=2 and notify.userid = forum_preferences.userid and notify.create_time > $t";
66 66
 
67 67
     $notifies = BoincNotify::enum_general($query);
Please login to merge, or discard this patch.
html/ops/pass_percentage_by_appversion.php 1 patch
Spacing   +11 added lines, -11 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@  discard block
 block discarded – undo
106 106
 $db = BoincDb::get(true);
107 107
 $result = $db->do_query($main_query);
108 108
 
109
-if($db->base_errno()) {
109
+if ($db->base_errno()) {
110 110
     echo $db->base_error();
111 111
 }
112 112
 
@@ -127,7 +127,7 @@  discard block
 block discarded – undo
127 127
     echo "</td>\n";
128 128
 
129 129
     echo "  <td align=\"left\" valign=\"top\">";
130
-    if($res->platform)
130
+    if ($res->platform)
131 131
         echo $res->platform;
132 132
     else
133 133
         echo "unknown";
@@ -144,31 +144,31 @@  discard block
 block discarded – undo
144 144
     echo "&nbsp;&nbsp;</td>\n";
145 145
 
146 146
     $abs = $res->pass_count;
147
-    $perc = $abs / $tot * 100;
147
+    $perc = $abs/$tot*100;
148 148
     echo "  <td align=\"right\" valign=\"top\">";
149 149
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
150 150
     echo "</td>\n";
151 151
 
152 152
     $abs = $res->fail_count;
153
-    $perc = $abs / $tot * 100;
153
+    $perc = $abs/$tot*100;
154 154
     echo "  <td align=\"right\" valign=\"top\">";
155 155
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
156 156
     echo "</td>\n";
157 157
 
158 158
     $abs = $res->fail_count1;
159
-    $perc = $abs / $tot * 100;
159
+    $perc = $abs/$tot*100;
160 160
     echo "  <td align=\"right\" valign=\"top\">";
161 161
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
162 162
     echo "</td>\n";
163 163
 
164 164
     $abs = $res->fail_count2;
165
-    $perc = $abs / $tot * 100;
165
+    $perc = $abs/$tot*100;
166 166
     echo "  <td align=\"right\" valign=\"top\">";
167 167
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
168 168
     echo "</td>\n";
169 169
 
170 170
     $abs = $res->fail_count3;
171
-    $perc = $abs / $tot * 100;
171
+    $perc = $abs/$tot*100;
172 172
     echo "  <td align=\"right\" valign=\"top\">";
173 173
     if ($abs > 0) {
174 174
         echo "<a title=\"$abs\" href=\"ordered_client_errors.php?appid=$query_appid&nsecs=$query_nsecs&appverid=$res->app_version_id\">";
@@ -179,25 +179,25 @@  discard block
 block discarded – undo
179 179
     echo "</td>\n";
180 180
 
181 181
     $abs = $res->fail_count4;
182
-    $perc = $abs / $tot * 100;
182
+    $perc = $abs/$tot*100;
183 183
     echo "  <td align=\"right\" valign=\"top\">";
184 184
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
185 185
     echo "</td>\n";
186 186
 
187 187
     $abs = $res->fail_count5;
188
-    $perc = $abs / $tot * 100;
188
+    $perc = $abs/$tot*100;
189 189
     echo "  <td align=\"right\" valign=\"top\">";
190 190
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
191 191
     echo "</td>\n";
192 192
 
193 193
     $abs = $res->fail_count6;
194
-    $perc = $abs / $tot * 100;
194
+    $perc = $abs/$tot*100;
195 195
     echo "  <td align=\"right\" valign=\"top\">";
196 196
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
197 197
     echo "</td>\n";
198 198
 
199 199
     $abs = $res->fail_count7;
200
-    $perc = $abs / $tot * 100;
200
+    $perc = $abs/$tot*100;
201 201
     echo "  <td align=\"right\" valign=\"top\">";
202 202
     if ($abs > 0) {
203 203
         echo "<a title=\"$abs\" href=\"db_action.php?table=result&server_state=5&outcome=6&detail=low&nresults=20&clauses=app_version_id+%3D+$res->app_version_id\">";
Please login to merge, or discard this patch.
html/ops/watchdogs.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@
 block discarded – undo
43 43
         sound_alarm("log file ".$file." missing");
44 44
     } else if ($t > $last_time) {
45 45
         $lines = file($file);
46
-        $last_line = $lines[count($lines)-1];
46
+        $last_line = $lines[count($lines) - 1];
47 47
         sound_alarm($last_line);
48 48
     }
49 49
 }
Please login to merge, or discard this patch.
html/ops/hrclass_summary.php 1 patch
Spacing   +42 added lines, -42 removed lines patch added patch discarded remove patch
@@ -21,45 +21,45 @@  discard block
 block discarded – undo
21 21
 // TODO: convert to use new DB interface
22 22
 // TODO: document in the wiki
23 23
 
24
-include_once( "../inc/db.inc" );
25
-include_once( "../inc/util.inc" );
26
-include_once( "../inc/db_ops.inc" );
27
-include_once( "../inc/util_ops.inc" );
28
-include_once( "../inc/prefs.inc" );
29
-
30
-$system_string[ 128 ] = "No OS";
31
-$system_string[ 256 ] = "Linux";
32
-$system_string[ 384 ] = "Windows";
33
-$system_string[ 512 ] = "Darwin";
34
-$system_string[ 640 ] = "FreeBSD";
35
-
36
-$cpu_string[ 0 ]  = "Unspecified";
37
-$cpu_string[ 1 ]  = "No cpu";
38
-$cpu_string[ 2 ]  = "Intel";
39
-$cpu_string[ 3 ]  = "AMD";
40
-$cpu_string[ 4 ]  = "Macintosh";
41
-$cpu_string[ 5 ]  = "AMD Athlon";
42
-$cpu_string[ 6 ]  = "AMD Duron";
43
-$cpu_string[ 7 ]  = "AMD Sempron";
44
-$cpu_string[ 8 ]  = "AMD Opteron";
45
-$cpu_string[ 9 ]  = "AMD Athlon 64";
46
-$cpu_string[ 10 ] = "AMD Athlon XP";
47
-$cpu_string[ 11 ] = "Intel Xeon";
48
-$cpu_string[ 12 ] = "Intel Celeron";
49
-$cpu_string[ 13 ] = "Intel Pentium";
50
-$cpu_string[ 14 ] = "Intel Pentium II";
51
-$cpu_string[ 15 ] = "Intel Pentium III";
52
-$cpu_string[ 16 ] = "Intel Pentium 4";
53
-$cpu_string[ 17 ] = "Intel Pentium D";
54
-$cpu_string[ 18 ] = "Intel Pentium M";
55
-$cpu_string[ 19 ] = "AMD Athlon MP";
56
-$cpu_string[ 20 ] = "AMD Turion";
57
-$cpu_string[ 21 ] = "Intel Core2";
24
+include_once("../inc/db.inc");
25
+include_once("../inc/util.inc");
26
+include_once("../inc/db_ops.inc");
27
+include_once("../inc/util_ops.inc");
28
+include_once("../inc/prefs.inc");
29
+
30
+$system_string[128] = "No OS";
31
+$system_string[256] = "Linux";
32
+$system_string[384] = "Windows";
33
+$system_string[512] = "Darwin";
34
+$system_string[640] = "FreeBSD";
35
+
36
+$cpu_string[0]  = "Unspecified";
37
+$cpu_string[1]  = "No cpu";
38
+$cpu_string[2]  = "Intel";
39
+$cpu_string[3]  = "AMD";
40
+$cpu_string[4]  = "Macintosh";
41
+$cpu_string[5]  = "AMD Athlon";
42
+$cpu_string[6]  = "AMD Duron";
43
+$cpu_string[7]  = "AMD Sempron";
44
+$cpu_string[8]  = "AMD Opteron";
45
+$cpu_string[9]  = "AMD Athlon 64";
46
+$cpu_string[10] = "AMD Athlon XP";
47
+$cpu_string[11] = "Intel Xeon";
48
+$cpu_string[12] = "Intel Celeron";
49
+$cpu_string[13] = "Intel Pentium";
50
+$cpu_string[14] = "Intel Pentium II";
51
+$cpu_string[15] = "Intel Pentium III";
52
+$cpu_string[16] = "Intel Pentium 4";
53
+$cpu_string[17] = "Intel Pentium D";
54
+$cpu_string[18] = "Intel Pentium M";
55
+$cpu_string[19] = "AMD Athlon MP";
56
+$cpu_string[20] = "AMD Turion";
57
+$cpu_string[21] = "Intel Core2";
58 58
 
59 59
 $query = "SELECT COUNT(workunit.id) AS count FROM workunit LEFT JOIN result ON workunit.id=result.workunitid WHERE result.server_state=2 AND workunit.hr_class=";
60 60
 
61 61
 function get_mysql_count($hr_class) {
62
-    $result = _mysql_query("select count(id) as count from workunit where hr_class=" . $hr_class);
62
+    $result = _mysql_query("select count(id) as count from workunit where hr_class=".$hr_class);
63 63
     $count = _mysql_fetch_object($result);
64 64
     _mysql_free_result($result);
65 65
     return $count->count;
@@ -82,19 +82,19 @@  discard block
 block discarded – undo
82 82
     "hr_class", "System", "CPU", "# unsent results"
83 83
 );
84 84
 
85
-$unsentresults = get_mysql_count( 0 );
85
+$unsentresults = get_mysql_count(0);
86 86
 table_row(
87
-    make_reset_url(0), $system_string[ 128 ], $cpu_string[ 0 ], $unsentresults  );
87
+    make_reset_url(0), $system_string[128], $cpu_string[0], $unsentresults  );
88 88
 
89
-for ($system = 2; $system < 6; ++$system ) {
90
-    for ($cpu = 1; $cpu < 22; ++$cpu ) {
91
-        $hr_class=128*$system+$cpu;
89
+for ($system = 2; $system < 6; ++$system) {
90
+    for ($cpu = 1; $cpu < 22; ++$cpu) {
91
+        $hr_class = 128*$system + $cpu;
92 92
 
93
-        $unsentresults = get_mysql_count( $hr_class );
93
+        $unsentresults = get_mysql_count($hr_class);
94 94
 
95 95
         table_row(
96 96
             make_reset_url($hr_class),
97
-            $system_string[$system * 128],
97
+            $system_string[$system*128],
98 98
             $cpu_string[$cpu],
99 99
             $unsentresults
100 100
         );
Please login to merge, or discard this patch.