BOINC / boinc

html/ops/bolt_map.php

Braces +1 added lines, -1 removed lines

@@ -243,7 +243,7 @@
             <td><br></td>
             <td><br></td>
         ";
-    } else  {
+    } else {
         $c = class_name($class);
         echo "
             <td><b>".spaces($level)."$unit->name</b></td>

Spacing +9 added lines, -9 removed lines

@@ -103,7 +103,7 @@ 
 
 function spaces($level) {
     $x = "";
-    for ($i=0; $i<$level; $i++) {
+    for ($i = 0; $i < $level; $i++) {
         $x .= "&nbsp;&nbsp;&nbsp;&nbsp;";
     }
     return $x;
@@ -136,7 +136,7 @@ 
 function avg_score($array) {
     $sum = 0;
     $n = count($array);
-    if ($n ==0) return 0;
+    if ($n == 0) return 0;
     foreach ($array as $a) {
         $sum += $a->score;
     }
@@ -152,7 +152,7 @@ 
             $n++;
         }
     }
-    if ($n ==0) return 0;
+    if ($n == 0) return 0;
     return $sum/$n;
 }
 
@@ -235,7 +235,7 @@ 
     global $breakdown, $breakdown_cat;
     global $rownum, $course_id;
 
-    $a = $is_answer?" (answer)":"";
+    $a = $is_answer ? " (answer)" : "";
     $j = ($rownum++)%2;
     echo "<tr class=row$j>";
     if ($breakdown && $breakdown_cat) {
@@ -243,7 +243,7 @@ 
             <td><br></td>
             <td><br></td>
         ";
-    } else  {
+    } else {
         $c = class_name($class);
         echo "
             <td><b>".spaces($level)."$unit->name</b></td>
@@ -277,7 +277,7 @@ 
         echo time_graph($t, 200);
         break;
     case "BoltExercise":
-        $mode = $is_answer?BOLT_MODE_ANSWER:BOLT_MODE_SHOW;
+        $mode = $is_answer ?BOLT_MODE_ANSWER:BOLT_MODE_SHOW;
         $views = get_views($unit, $mode);
         $n = count($views);
         $out = outcomes($views);
@@ -360,7 +360,7 @@ 
     show_unit($unit, $level);
     if ($unit->is_item) return;
     foreach ($unit->units as $u) {
-        show_unit_recurse($u, $level+1);
+        show_unit_recurse($u, $level + 1);
     }
 }
 
@@ -402,9 +402,9 @@ 
         <input type=hidden name=course_id value=$course_id>
         <table width=600><tr><td valign=top>
     ";
-    filter_form($filter?$filter->name():"", $filter_cat);
+    filter_form($filter ? $filter->name() : "", $filter_cat);
     echo "</td><td valign=top>";
-    breakdown_form($breakdown?$breakdown->name():"");
+    breakdown_form($breakdown ? $breakdown->name() : "");
     echo "
         </td></tr></table>
         <p>

html/ops/manage_apps.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     $n = post_str("fraction_done_exact", true)?1:0;
     $app->update("fraction_done_exact=$n");
 
-    echo "Application $id updated.
+    echo "application $id updated.
         <p>
         You must restart the project for this to take effect.
     ";

Spacing +14 added lines, -14 removed lines

@@ -25,7 +25,7 @@ 
     $app = BoincApp::lookup_id($id);
     if (!$app) admin_error_page("no such app");
 
-    $n = post_str("deprecated", true)?1:0;
+    $n = post_str("deprecated", true) ? 1 : 0;
     $app->update("deprecated=$n");
 
     $n = post_num("weight");
@@ -37,16 +37,16 @@ 
     $n = post_int("target_nresults");
     $app->update("target_nresults=$n");
 
-    $n = post_str("homogeneous_app_version", true)?1:0;
+    $n = post_str("homogeneous_app_version", true) ? 1 : 0;
     $app->update("homogeneous_app_version=$n");
 
-    $n = post_str("non_cpu_intensive", true)?1:0;
+    $n = post_str("non_cpu_intensive", true) ? 1 : 0;
     $app->update("non_cpu_intensive=$n");
 
-    $n = post_str("beta", true)?1:0;
+    $n = post_str("beta", true) ? 1 : 0;
     $app->update("beta=$n");
 
-    $n = post_str("fraction_done_exact", true)?1:0;
+    $n = post_str("fraction_done_exact", true) ? 1 : 0;
     $app->update("fraction_done_exact=$n");
 
     echo "Application $id updated.
@@ -58,7 +58,7 @@ 
 function add_app() {
     $name = BoincDb::escape_string(post_str('add_name'));
     $user_friendly_name = BoincDb::escape_string(post_str('add_user_friendly_name'));
-    if (empty($name) || empty($user_friendly_name) ) {
+    if (empty($name) || empty($user_friendly_name)) {
         admin_error_page(
             "To add a new application please supply both a brief name and a longer 'user-friendly' name.</font></p>"
         );
@@ -81,11 +81,11 @@ 
         <h2>Edit applications</h2>
     ";
 
-    $app_clause="deprecated=0";
-    $action_url="manage_apps.php";
-    if($all) {
+    $app_clause = "deprecated=0";
+    $action_url = "manage_apps.php";
+    if ($all) {
         $app_clause = "";
-        $action_url="manage_apps.php?all=1";
+        $action_url = "manage_apps.php?all=1";
         echo "<a href=\"manage_apps.php\">Don't show deprecated applications</a>";
     } else {
         echo "<a href=\"manage_apps.php?all=1\">Show deprecated applications</a>";
@@ -117,8 +117,8 @@ 
     $apps = BoincApp::enum($app_clause);
     foreach ($apps as $app) {
         // grey-out deprecated versions
-        $f1=$f2='';
-        if ($app->deprecated==1) {
+        $f1 = $f2 = '';
+        if ($app->deprecated == 1) {
             $f1 = "<font color='GREY'>";
             $f2 = "</font>";
         }
@@ -128,7 +128,7 @@ 
 
         echo "  <TD align='left'>$f1<a href=app_details.php?appid=$app->id>$app->name</a><br> $app->user_friendly_name $f2</TD>\n";
 
-        echo "  <TD align='center'>$f1 " .date_str($app->create_time)."$f2</TD>\n";
+        echo "  <TD align='center'>$f1 ".date_str($app->create_time)."$f2</TD>\n";
 
         $v = $app->weight;
         echo "  <TD align='center'>
@@ -151,7 +151,7 @@ 
         ";
 
         $v = '';
-        if ($app->homogeneous_app_version) $v=' CHECKED ';
+        if ($app->homogeneous_app_version) $v = ' CHECKED ';
         echo "  <TD align='center'>
             <input name='homogeneous_app_version' type='checkbox' $v></TD>
         ";

html/ops/build_po.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
 "X-Poedit-SourceCharset: utf-8\\n"
 
 
-HDR;
+hdr;
 
 $out = fopen("en.po", "w");
 

html/user/forum_post.php

Braces +4 added lines, -4 removed lines

@@ -53,10 +53,10 @@ 
 $preview = post_str("preview", true);
 $warning = null;
 
-if ($content && $title && (!$preview)){
-    if (post_str('add_signature', true) == "add_it"){
+if ($content && $title && (!$preview)) {
+    if (post_str('add_signature', true) == "add_it") {
         $add_signature = true;    // set a flag and concatenate later
-    }  else {
+    } else {
         $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
@@ -111,7 +111,7 @@ 
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
 }
 
-if ($force_title && $title){
+if ($force_title && $title) {
     row2(tra("Title"), htmlspecialchars($title)."<input type=\"hidden\" name=\"title\" value=\"".htmlspecialchars($title)."\">");
 } else {
     row2(tra("Title").$submit_help,

Spacing +12 added lines, -12 removed lines

@@ -56,10 +56,10 @@ 
 $preview = post_str("preview", true);
 $warning = null;
 
-if ($content && $title && (!$preview)){
-    if (post_str('add_signature', true) == "add_it"){
-        $add_signature = true;    // set a flag and concatenate later
-    }  else {
+if ($content && $title && (!$preview)) {
+    if (post_str('add_signature', true) == "add_it") {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
         $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
@@ -71,14 +71,14 @@ 
             $title, $content, $logged_in_user, $forum, $add_signature, $export
         );
         if ($thread) {
-            header('Location: forum_thread.php?id=' . $thread->id);
+            header('Location: forum_thread.php?id='.$thread->id);
         } else {
             error_page("Can't create thread.  $forum_error");
         }
     }
 }
 
-page_head(tra("Create new thread"),'','','', $bbcode_js);
+page_head(tra("Create new thread"), '', '', '', $bbcode_js);
 show_forum_header($logged_in_user);
 
 if ($warning) {
@@ -119,12 +119,12 @@ 
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
 }
 
-if ($force_title && $title){
+if ($force_title && $title) {
     row2(tra("Title"), htmlspecialchars($title)."<input type=\"hidden\" name=\"title\" value=\"".htmlspecialchars($title)."\">");
 } else {
     row2(tra("Title").$submit_help,
         sprintf('<input type="text" class="form-control" name="title" value="%s">',
-            $title?htmlspecialchars($title):''
+            $title ?htmlspecialchars($title) : ''
         )
     );
 }
@@ -134,14 +134,14 @@ 
 echo $bbcode_html;
 end_table();
 echo sprintf('<textarea class="form-control" name="content" rows="12" cols="80">%s</textarea>',
-    $content?htmlspecialchars($content):''
+    $content ?htmlspecialchars($content) : ''
 );
 echo "</td></tr>";
 
 if (!$logged_in_user->prefs->no_signature_by_default) {
-    $enable_signature="checked=\"true\"";
+    $enable_signature = "checked=\"true\"";
 } else {
-    $enable_signature="";
+    $enable_signature = "";
 }
 
 if (is_news_forum($forum)) {
@@ -157,5 +157,5 @@ 
 
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

html/user/server_status.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -251,7 +251,7 @@
         $pid = file_get_contents($path);
         if ($pid) {
             $pid = trim($pid);
-            $out = Array();
+            $out = array();
             exec("ps -ww $pid", $out);
             foreach ($out as $y) {
                 if (strstr($y, (string)$pid)) return 1;

Spacing +9 added lines, -9 removed lines

@@ -180,7 +180,7 @@ 
             $avg = round($app->info->avg, 2);
             $min = round($app->info->min, 2);
             $max = round($app->info->max, 2);
-            $x = $max?"$avg ($min - $max)":"---";
+            $x = $max ? "$avg ($min - $max)" : "---";
             $u = $app->info->users;
         } else {
             $x = '---';
@@ -273,7 +273,7 @@ 
         $cmd = trim($cmd);
         $x = explode(" ", $cmd);
         $prog = $x[0];
-        $pidname = $prog . '.pid';
+        $pidname = $prog.'.pid';
     }
     $path = "../../pid_$host/$pidname";
     if (is_file($path)) {
@@ -314,12 +314,12 @@ 
     }
     $master_host = $u["host"];
     if ($config->www_host) {
-        $web_host = trim((string) $config->www_host);
+        $web_host = trim((string)$config->www_host);
     } else {
         $web_host = $main_host;
     }
     if ($config->sched_host) {
-        $sched_host = trim((string) $config->sched_host);
+        $sched_host = trim((string)$config->sched_host);
     } else {
         $sched_host = $main_host;
     }
@@ -329,7 +329,7 @@ 
 
     // the upload and download servers are sort of daemons too
     //
-    $url = trim((string) $config->download_url);
+    $url = trim((string)$config->download_url);
     $u = parse_url($url);
     $h = $u["host"];
     if ($h == $master_host) {
@@ -341,14 +341,14 @@ 
     } else {
         $have_remote = true;
     }
-    $url = trim((string) $config->upload_url);
+    $url = trim((string)$config->upload_url);
     $u = parse_url($url);
     $h = $u["host"];
     if ($h == $master_host) {
         $y = new StdClass;
         $y->cmd = "Upload server";
         $y->host = $h;
-        $y->status = !file_exists("../../stop_upload");;
+        $y->status = !file_exists("../../stop_upload"); ;
         $local_daemons[] = $y;
     } else {
         $have_remote = true;
@@ -360,7 +360,7 @@ 
         $y = new StdClass;
         $y->cmd = "Scheduler";
         $y->host = $sched_host;
-        $y->status = !file_exists("../../stop_sched");;
+        $y->status = !file_exists("../../stop_sched"); ;
         $local_daemons[] = $y;
     } else {
         $have_remote = true;
@@ -376,7 +376,7 @@ 
             $disabled_daemons[] = $x;
             continue;
         }
-        $host = $d->host?(string)$d->host:$main_host;
+        $host = $d->host ? (string)$d->host : $main_host;
         if ($host != $web_host) {
             $have_remote = true;
             continue;

html/user/submit.php

Braces +1 added lines, -1 removed lines

@@ -369,7 +369,7 @@
             $text = "---";
             if ($batch->state == BATCH_STATE_COMPLETE) {
                 $y = '<font color="red">failed</font>';
-            }   else {
+            } else {
                 $y = "in progress";
             }
         }

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -308,7 +308,7 @@ 
     $wus = BoincWorkunit::enum("batch = $batch->id");
     $batch = get_batch_params($batch, $wus);
 
-    page_head("Batch $batch_id");
+    page_head("batch $batch_id");
     start_table();
     row2("name", $batch->name);
     row2("application", $app->name);
@@ -393,7 +393,7 @@ 
     $wu = BoincWorkunit::lookup_id($wuid);
     if (!$wu) error_page("no such job");
 
-    page_head("Job $wuid");
+    page_head("job $wuid");
 
     echo "
         <a href=workunit.php?wuid=$wuid>Workunit details</a> &middot;

Spacing +4 added lines, -4 removed lines

@@ -412,9 +412,9 @@ 
         "Canonical instance<br><small>click to see result page on BOINC server</smallp>",
         "Download Results"
     );
-    foreach($wus as $wu) {
+    foreach ($wus as $wu) {
         $resultid = $wu->canonical_resultid;
-        $durl = boinc_get_wu_output_files_url($user,$wu->id);
+        $durl = boinc_get_wu_output_files_url($user, $wu->id);
         if ($resultid) {
             $x = "<a href=result.php?resultid=$resultid>$resultid</a>";
             $y = '<font color="green">completed</font>';
@@ -424,7 +424,7 @@ 
             $text = "---";
             if ($batch->state == BATCH_STATE_COMPLETE) {
                 $y = '<font color="red">failed</font>';
-            }   else {
+            } else {
                 $y = "in progress";
             }
         }
@@ -489,7 +489,7 @@ 
     $results = BoincResult::enum("workunitid=$wuid");
     $upload_dir = parse_config(get_config(), "<upload_dir>");
     $fanout = parse_config(get_config(), "<uldl_dir_fanout>");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         echo "<tr>
             <td><a href=result.php?resultid=$result->id>$result->id &middot; $result->name </a></td>
             <td>".state_string($result)."</td>

html/user/bolt.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
         $view = BoltView::lookup_id($e->last_view_id);
         $ago = time_diff(time() - $view->start_time);
         $pct = number_format($view->fraction_done*100, 0);
-        $status = "Started $start
+        $status = "started $start
             <br>Last visit: $ago ago
             <br>$pct% done
         ";

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     if ($course->hidden && !($user->bolt->flags&BOLT_FLAG_SHOW_ALL)) {
         continue;
     }
-    $e = $user?BoltEnrollment::lookup($user->id, $course->id):null;
+    $e = $user ?BoltEnrollment::lookup($user->id, $course->id) : null;
     if ($e) {
         $start = date_str($e->create_time);
         $view = BoltView::lookup_id($e->last_view_id);

html/user/forum_reply.php

Braces +4 added lines, -4 removed lines

@@ -50,7 +50,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -65,10 +65,10 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
-    if (post_str('add_signature',true)=="add_it"){
+if ($content && (!$preview)) {
+    if (post_str('add_signature',true)=="add_it") {
         $add_signature=true;    // set a flag and concatenate later
-    }  else {
+    } else {
         $add_signature=false;
     }
     check_tokens($logged_in_user->authenticator);

Spacing +13 added lines, -13 removed lines

@@ -50,7 +50,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -65,11 +65,11 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
-    if (post_str('add_signature',true)=="add_it"){
-        $add_signature=true;    // set a flag and concatenate later
-    }  else {
-        $add_signature=false;
+if ($content && (!$preview)) {
+    if (post_str('add_signature', true) == "add_it") {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
+        $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
     if (!akismet_check($logged_in_user, $content)) {
@@ -88,7 +88,7 @@ 
     }
 }
 
-page_head(tra("Post to thread"),'','','', $bbcode_js);
+page_head(tra("Post to thread"), '', '', '', $bbcode_js);
 
 show_forum_header($logged_in_user);
 
@@ -142,7 +142,7 @@ 
     $x1 = tra("Message:").bbcode_info().post_warning();
     $x2 = "";
     if ($parent_post) {
-        $x2 .=" ".tra("reply to %1 Message ID %2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
+        $x2 .= " ".tra("reply to %1 Message ID %2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
     }
     $x2 .= "<form action=forum_reply.php?thread=".$thread->id;
 
@@ -153,7 +153,7 @@ 
     $x2 .= " method=\"post\" name=\"post\" onsubmit=\"return checkForm(this)\">\n";
     $x2 .= form_tokens($logged_in_user->authenticator);
     $x2 .= start_table_str().$bbcode_html.end_table_str()."<textarea class=\"form-control\" name=\"content\" rows=\"18\">";
-    $no_quote = get_int("no_quote", true)==1;
+    $no_quote = get_int("no_quote", true) == 1;
     if ($preview) {
         $x2 .= htmlspecialchars($content);
     } else if (!$no_quote) {
@@ -162,9 +162,9 @@ 
         }
     }
     if (!$logged_in_user->prefs->no_signature_by_default) {
-        $enable_signature="checked=\"true\"";
+        $enable_signature = "checked=\"true\"";
     } else {
-        $enable_signature="";
+        $enable_signature = "";
     }
     $x2 .= "</textarea><p> </p>
         <input class=\"btn btn-primary btn-sm \" type=\"submit\" name=\"preview\" value=\"".tra("Preview")."\">
@@ -179,9 +179,9 @@ 
 }
 
 function quote_text($text) {
-    $text = "[quote]" . $text . "[/quote]";
+    $text = "[quote]".$text."[/quote]";
     return $text;
 }
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

html/user/submit_status.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     if (!$batch || $batch->user_id != $user->id) {
         error_page("no batch");
     }
-    page_head("Batch $batch->id");
+    page_head("batch $batch->id");
     $results = BoincResult::enum("batch=$batch->id order by workunitid");
     result_table_start(true, true, null);
     foreach ($results as $result) {