BOINC / boinc

html/inc/notify.inc

Spacing +1 added lines, -1 removed lines

@@ -46,7 +46,7 @@
         return;
     }
 
-    $news_date=gmdate('D, d M Y H:i:s',$notify->create_time) . ' GMT';
+    $news_date = gmdate('D, d M Y H:i:s', $notify->create_time).' GMT';
     echo "<item>
         <title><![CDATA[$title]]></title>
         <guid>".url_base()."_notify_$notify->id</guid>

html/inc/akismet.inc

Spacing +4 added lines, -4 removed lines

@@ -26,7 +26,7 @@ 
 
     $master_url_enc = urlencode($master_url);
     $response = akismet_request("key=$key&blog=$master_url_enc", "rest.akismet.com", "/1.1/verify-key");
-    if ("valid" == $response[1] ) {
+    if ("valid" == $response[1]) {
         $post = urlencode($post);
         $ip = urlencode($_SERVER['REMOTE_ADDR']);
         $referrer = urlencode($_SERVER['HTTP_REFERER']);
@@ -56,15 +56,15 @@ 
     $http_request  = "POST $path HTTP/1.0\r\n";
     $http_request .= "Host: $host\r\n";
     $http_request .= "Content-Type: application/x-www-form-urlencoded; charset=utf-8\r\n";
-    $http_request .= "Content-Length: " . strlen($request) . "\r\n";
+    $http_request .= "Content-Length: ".strlen($request)."\r\n";
     $http_request .= "User-Agent: BOINC | Akismet 1.1\r\n";
     $http_request .= "\r\n";
     $http_request .= $request;
 
     $response = '';
-    if( false !== ( $fs = @fsockopen($host, $port, $errno, $errstr, 3) ) ) {
+    if (false !== ($fs = @fsockopen($host, $port, $errno, $errstr, 3))) {
         fwrite($fs, $http_request);
-        while ( !feof($fs) )
+        while (!feof($fs))
             $response .= fgets($fs, 1160); // One TCP-IP packet
         fclose($fs);
         $response = explode("\r\n\r\n", $response, 2);

Braces +6 added lines, -3 removed lines

@@ -42,7 +42,8 @@ 
 
         $response = akismet_request($request, "$key.rest.akismet.com", "/1.1/comment-check");
 
-        if ("true" == $response[1]) { // Akismet says it's spam
+        if ("true" == $response[1]) {
+// Akismet says it's spam
             return false;
         } else {
             return true;
@@ -64,8 +65,10 @@ 
     $response = '';
     if( false !== ( $fs = @fsockopen($host, $port, $errno, $errstr, 3) ) ) {
         fwrite($fs, $http_request);
-        while ( !feof($fs) )
-            $response .= fgets($fs, 1160); // One TCP-IP packet
+        while ( !feof($fs) ) {
+                    $response .= fgets($fs, 1160);
+        }
+        // One TCP-IP packet
         fclose($fs);
         $response = explode("\r\n\r\n", $response, 2);
     }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 }
 
 function akismet_request($request, $host, $path, $port = 80) {
-    $http_request  = "POST $path HTTP/1.0\r\n";
+    $http_request  = "post $path HTTP/1.0\r\n";
     $http_request .= "Host: $host\r\n";
     $http_request .= "Content-Type: application/x-www-form-urlencoded; charset=utf-8\r\n";
     $http_request .= "Content-Length: " . strlen($request) . "\r\n";

drupal/sites/default/boinc/modules/boincuser/views/views_handler_argument_boincteam_id.inc

Indentation +4 added lines, -4 removed lines

@@ -7,15 +7,15 @@
  */
 
 class views_handler_argument_boincteam_id extends views_handler_argument_numeric {
-  function construct() {
+    function construct() {
     parent::construct();
-  }
+    }
 
-  function set_argument($arg) {
+    function set_argument($arg) {
     // When setting the ID argument, convert to BOINC ID
     $id = is_numeric($arg) ? $arg : 0;
     $boinc_id = db_result(db_query("SELECT team_id FROM {boincteam} WHERE nid = %d", $id));
     $this->argument = $boinc_id;
     return $this->validate_arg($boinc_id);
-  }
+    }
 }

drupal/sites/default/boinc/modules/boincuser/views/views_handler_argument_boincuser_id.inc

Indentation +4 added lines, -4 removed lines

@@ -7,15 +7,15 @@
  */
 
 class views_handler_argument_boincuser_id extends views_handler_argument_numeric {
-  function construct() {
+    function construct() {
     parent::construct();
-  }
+    }
 
-  function set_argument($arg) {
+    function set_argument($arg) {
     // When setting the ID argument, convert to BOINC ID
     $id = is_numeric($arg) ? $arg : 0;
     $boinc_id = db_result(db_query("SELECT boinc_id FROM {boincuser} WHERE uid = %d", $id));
     $this->argument = $boinc_id;
     return $this->validate_arg($boinc_id);
-  }
+    }
 }

drupal/sites/default/boinc/modules/boincimport/views/views_handler_argument_boincteam_id.inc

Indentation +4 added lines, -4 removed lines

@@ -7,15 +7,15 @@
  */
 
 class views_handler_argument_boincteam_id extends views_handler_argument_numeric {
-  function construct() {
+    function construct() {
     parent::construct();
-  }
+    }
 
-  function set_argument($arg) {
+    function set_argument($arg) {
     // When setting the ID argument, convert to BOINC ID
     $id = is_numeric($arg) ? $arg : 0;
     $boinc_id = db_result(db_query("SELECT team_id FROM {boincteam} WHERE nid = %d", $id));
     $this->argument = $boinc_id;
     return $this->validate_arg($boinc_id);
-  }
+    }
 }

html/ops/manage_special_users_action.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -26,7 +26,7 @@
 $bitset = '';
 
 for ($i=0;$i<S_NFLAGS;$i++) {
-    if (post_int("role".$i, TRUE) == '1') {
+    if (post_int("role".$i, true) == '1') {
         $bitset = str_pad($bitset, $i+1, '1');
     } else {
         $bitset = str_pad($bitset, $i+1, '0');

Spacing +3 added lines, -3 removed lines

@@ -25,11 +25,11 @@
 
 $bitset = '';
 
-for ($i=0;$i<S_NFLAGS;$i++) {
+for ($i = 0; $i < S_NFLAGS; $i++) {
     if (post_int("role".$i, TRUE) == '1') {
-        $bitset = str_pad($bitset, $i+1, '1');
+        $bitset = str_pad($bitset, $i + 1, '1');
     } else {
-        $bitset = str_pad($bitset, $i+1, '0');
+        $bitset = str_pad($bitset, $i + 1, '0');
     }
 }
 if ($bitset == "0000000") $bitset = '';

html/ops/manage_user.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -141,7 +141,7 @@
     global $special_user_bitfield;
     $Nbf = sizeof($special_user_bitfield);
 
-    admin_page_head("Management $user->name");
+    admin_page_head("management $user->name");
 
     if (!defined("POST_REPORT_EMAILS")) {
         echo "<p><font color='RED'>

Braces +4 added lines, -4 removed lines

@@ -39,8 +39,8 @@ 
 
 // Delete a user if they have no credit, results, or posts
 //
-function possibly_delete_user($user){
-    if ($user->total_credit > 0.0){
+function possibly_delete_user($user) {
+    if ($user->total_credit > 0.0) {
         admin_error_page("Cannot delete user: User has credit.");
     }
 
@@ -56,7 +56,7 @@ 
         admin_error_page("Cannot delete user: User has forum posts.");
     }
 
-    if ($user->teamid){
+    if ($user->teamid) {
         user_quit_team($user);
     }
     delete_user($user);
@@ -100,7 +100,7 @@ 
 
             // put a timestamp in wiki to trigger re-validation of credentials
 
-            if (function_exists('touch_wiki_user')){
+            if (function_exists('touch_wiki_user')) {
                 touch_wiki_user($user);
             }
 

Spacing +23 added lines, -23 removed lines

@@ -39,8 +39,8 @@ 
 
 // Delete a user if they have no credit, results, or posts
 //
-function possibly_delete_user($user){
-    if ($user->total_credit > 0.0){
+function possibly_delete_user($user) {
+    if ($user->total_credit > 0.0) {
         admin_error_page("Cannot delete user: User has credit.");
     }
 
@@ -56,7 +56,7 @@ 
         admin_error_page("Cannot delete user: User has forum posts.");
     }
 
-    if ($user->teamid){
+    if ($user->teamid) {
         user_quit_team($user);
     }
     delete_user($user);
@@ -67,8 +67,8 @@ 
 function handle_special_user($user) {
     global $special_user_bitfield;
     $Nbf = sizeof($special_user_bitfield);
-    $bits="";
-    for ($i=0; $i<$Nbf; $i++) {
+    $bits = "";
+    for ($i = 0; $i < $Nbf; $i++) {
         $key = "special_user_$i";
         if (array_key_exists($key, $_POST) && $_POST[$key]) {
             $bits .= "1";
@@ -94,35 +94,35 @@ 
         );
     } else {
         if (is_numeric($dt)) {
-            $t = $dt>0 ? time()+$dt : 0;
+            $t = $dt > 0 ? time() + $dt : 0;
             $q = "UPDATE forum_preferences SET banished_until=$t WHERE userid=$user->id";
             _mysql_query($q);
 
             // put a timestamp in wiki to trigger re-validation of credentials
 
-            if (function_exists('touch_wiki_user')){
+            if (function_exists('touch_wiki_user')) {
                 touch_wiki_user($user);
             }
 
             // Send suspension e-mail to user and administrators
 
-            if ($dt>0) {
-                $subject = PROJECT." posting privileges suspended for ". $user->name;
+            if ($dt > 0) {
+                $subject = PROJECT." posting privileges suspended for ".$user->name;
                 $body = "
-Forum posting privileges for the " .PROJECT. " user \"".$user->name."\"
-have been suspended for " .time_diff($dt). " by ".$g_logged_in_user->name.".
+Forum posting privileges for the " .PROJECT." user \"".$user->name."\"
+have been suspended for " .time_diff($dt)." by ".$g_logged_in_user->name.".
 The reason given was:
 
 $reason
 
-The suspension will end at " .time_str($t)."\n";
+The suspension will end at ".time_str($t)."\n";
             } else {
-                $subject = PROJECT." user ". $user->name. " unsuspended";
+                $subject = PROJECT." user ".$user->name." unsuspended";
                 $body = "
-Forum posting privileges for the " .PROJECT. " user \"".$user->name."\"
+Forum posting privileges for the " .PROJECT." user \"".$user->name."\"
 have been restored by ".$g_logged_in_user->name."\n";
                 if ($reason) {
-                    $body.="The reason given was:\n\n   $reason\n";
+                    $body .= "The reason given was:\n\n   $reason\n";
                 }
             }
 
@@ -186,13 +186,13 @@ 
     row1("Special User Status");
 
     echo "<tr>\n";
-    for ($i=0; $i<$Nbf; $i++) {
+    for ($i = 0; $i < $Nbf; $i++) {
         $bit = substr($user->prefs->special_user, $i, 1);
         echo "<tr><td><input type='checkbox'' name='special_user_".$i."' value='1'";
         if ($bit == 1) {
             echo " checked='checked'";
         }
-        echo ">". $special_user_bitfield[$i] ."</td></tr>\n";
+        echo ">".$special_user_bitfield[$i]."</td></tr>\n";
     }
     echo "</tr>";
 
@@ -217,10 +217,10 @@ 
     if ($user->prefs->banished_until) {
         $dt = $user->prefs->banished_until - time();
         if ($dt > 0) {
-            $x = " Suspended until " . time_str($user->prefs->banished_until)
-                ."<br/> (Expires in " . time_diff($dt) .")" ;
+            $x = " Suspended until ".time_str($user->prefs->banished_until)
+                ."<br/> (Expires in ".time_diff($dt).")";
         } else {
-            $x = " last suspended " . time_str($user->prefs->banished_until);
+            $x = " last suspended ".time_str($user->prefs->banished_until);
         }
         row1($x);
     } else {
@@ -238,11 +238,11 @@ 
     ";
     echo "
         <input type='radio' name='suspend_for' value='172800'> 48 hours  <br/>
-        <input type='radio' name='suspend_for' value='",86400*7,"'> 1 week  <br/>
-        <input type='radio' name='suspend_for' value='",86400*14,"'> 2 weeks  <br/>
+        <input type='radio' name='suspend_for' value='",86400*7, "'> 1 week  <br/>
+        <input type='radio' name='suspend_for' value='",86400*14, "'> 2 weeks  <br/>
     ";
 
-    if ($dt>0) {
+    if ($dt > 0) {
         echo "
             <input type='radio' name='suspend_for' value='-1'>  <b>unsuspend</b>   <br/>";
     }

html/ops/manage_apps.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -49,7 +49,7 @@
     $n = post_str("fraction_done_exact", true)?1:0;
     $app->update("fraction_done_exact=$n");
 
-    echo "Application $id updated.
+    echo "application $id updated.
         <p>
         You must restart the project for this to take effect.
     ";

Spacing +14 added lines, -14 removed lines

@@ -25,7 +25,7 @@ 
     $app = BoincApp::lookup_id($id);
     if (!$app) admin_error_page("no such app");
 
-    $n = post_str("deprecated", true)?1:0;
+    $n = post_str("deprecated", true) ? 1 : 0;
     $app->update("deprecated=$n");
 
     $n = post_num("weight");
@@ -37,16 +37,16 @@ 
     $n = post_int("target_nresults");
     $app->update("target_nresults=$n");
 
-    $n = post_str("homogeneous_app_version", true)?1:0;
+    $n = post_str("homogeneous_app_version", true) ? 1 : 0;
     $app->update("homogeneous_app_version=$n");
 
-    $n = post_str("non_cpu_intensive", true)?1:0;
+    $n = post_str("non_cpu_intensive", true) ? 1 : 0;
     $app->update("non_cpu_intensive=$n");
 
-    $n = post_str("beta", true)?1:0;
+    $n = post_str("beta", true) ? 1 : 0;
     $app->update("beta=$n");
 
-    $n = post_str("fraction_done_exact", true)?1:0;
+    $n = post_str("fraction_done_exact", true) ? 1 : 0;
     $app->update("fraction_done_exact=$n");
 
     echo "Application $id updated.
@@ -58,7 +58,7 @@ 
 function add_app() {
     $name = BoincDb::escape_string(post_str('add_name'));
     $user_friendly_name = BoincDb::escape_string(post_str('add_user_friendly_name'));
-    if (empty($name) || empty($user_friendly_name) ) {
+    if (empty($name) || empty($user_friendly_name)) {
         admin_error_page(
             "To add a new application please supply both a brief name and a longer 'user-friendly' name.</font></p>"
         );
@@ -81,11 +81,11 @@ 
         <h2>Edit applications</h2>
     ";
 
-    $app_clause="deprecated=0";
-    $action_url="manage_apps.php";
-    if($all) {
+    $app_clause = "deprecated=0";
+    $action_url = "manage_apps.php";
+    if ($all) {
         $app_clause = "";
-        $action_url="manage_apps.php?all=1";
+        $action_url = "manage_apps.php?all=1";
         echo "<a href=\"manage_apps.php\">Don't show deprecated applications</a>";
     } else {
         echo "<a href=\"manage_apps.php?all=1\">Show deprecated applications</a>";
@@ -117,8 +117,8 @@ 
     $apps = BoincApp::enum($app_clause);
     foreach ($apps as $app) {
         // grey-out deprecated versions
-        $f1=$f2='';
-        if ($app->deprecated==1) {
+        $f1 = $f2 = '';
+        if ($app->deprecated == 1) {
             $f1 = "<font color='GREY'>";
             $f2 = "</font>";
         }
@@ -128,7 +128,7 @@ 
 
         echo "  <TD align='left'>$f1<a href=app_details.php?appid=$app->id>$app->name</a><br> $app->user_friendly_name $f2</TD>\n";
 
-        echo "  <TD align='center'>$f1 " .date_str($app->create_time)."$f2</TD>\n";
+        echo "  <TD align='center'>$f1 ".date_str($app->create_time)."$f2</TD>\n";
 
         $v = $app->weight;
         echo "  <TD align='center'>
@@ -151,7 +151,7 @@ 
         ";
 
         $v = '';
-        if ($app->homogeneous_app_version) $v=' CHECKED ';
+        if ($app->homogeneous_app_version) $v = ' CHECKED ';
         echo "  <TD align='center'>
             <input name='homogeneous_app_version' type='checkbox' $v></TD>
         ";

html/ops/cancel_workunits.php

Braces +2 added lines, -1 removed lines

@@ -100,7 +100,8 @@
     echo "</p>\n";
     echo "</form>\n";
 
-} else { // if ($qclause)
+} else {
+// if ($qclause)
 
     $query = "SELECT id, name FROM workunit WHERE canonical_resultid = 0 AND error_mask = 0 AND $qclause;";
     $db = BoincDb::get(true);

Spacing +3 added lines, -3 removed lines

@@ -29,7 +29,7 @@ 
 admin_page_head("Cancel Jobs");
 
 $limit = get_int('limit', true);
-if (!$limit || $limit==0) {
+if (!$limit || $limit == 0) {
     $limit = 100;
 }
 
@@ -42,9 +42,9 @@ 
 $clause = get_str('clause', true);
 
 if ($minid && $maxid) {
-    $qclause = "id >=" . $minid . " AND id <=" . $maxid;
+    $qclause = "id >=".$minid." AND id <=".$maxid;
 } else if ($list) {
-    $qclause = "id IN (" . $list . ")";
+    $qclause = "id IN (".$list.")";
 } else if ($uclause) {
     $qclause = urldecode($uclause);
 } else if ($clause) {