BOINC / boinc

html/user/forum_post.php

Braces +3 added lines, -3 removed lines

@@ -56,10 +56,10 @@ 
 $preview = post_str("preview", true);
 $warning = null;
 
-if ($content && $title && (!$preview)){
+if ($content && $title && (!$preview)) {
     if (post_str('add_signature', true)) {
         $add_signature = true;    // set a flag and concatenate later
-    }  else {
+    } else {
         $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
@@ -122,7 +122,7 @@ 
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
 }
 
-if ($force_title && $title){
+if ($force_title && $title) {
     row2(
         tra("Title"),
         sprintf(

Spacing +9 added lines, -9 removed lines

@@ -56,10 +56,10 @@ 
 $preview = post_str("preview", true);
 $warning = null;
 
-if ($content && $title && (!$preview)){
+if ($content && $title && (!$preview)) {
     if (post_str('add_signature', true)) {
-        $add_signature = true;    // set a flag and concatenate later
-    }  else {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
         $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
@@ -74,14 +74,14 @@ 
             if (post_str('subscribe', true)) {
                 BoincSubscription::replace($logged_in_user->id, $thread->id);
             }
-            header('Location: forum_thread.php?id=' . $thread->id);
+            header('Location: forum_thread.php?id='.$thread->id);
         } else {
             error_page("Can't create thread.  $forum_error");
         }
     }
 }
 
-page_head(tra("Create new thread"),'','','', $bbcode_js);
+page_head(tra("Create new thread"), '', '', '', $bbcode_js);
 show_forum_header($logged_in_user);
 
 if ($warning) {
@@ -122,7 +122,7 @@ 
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
 }
 
-if ($force_title && $title){
+if ($force_title && $title) {
     row2(
         tra("Title"),
         sprintf(
@@ -136,7 +136,7 @@ 
     row2(
         tra("Title").$submit_help,
         sprintf('<input type="text" class="form-control" name="title" value="%s">',
-            $title?htmlspecialchars($title):''
+            $title ?htmlspecialchars($title) : ''
         ),
         null, FORUM_LH_PCT
     );
@@ -147,7 +147,7 @@ 
     sprintf(
         '%s <textarea class="form-control" name="content" rows="12" cols="80">%s</textarea>',
         $bbcode_html,
-        $content?htmlspecialchars($content):''
+        $content ?htmlspecialchars($content) : ''
     ),
     null, FORUM_LH_PCT
 );
@@ -155,7 +155,7 @@ 
 if (!$logged_in_user->prefs->no_signature_by_default) {
     $enable_signature = 'checked="true"';
 } else {
-    $enable_signature='';
+    $enable_signature = '';
 }
 
 if (is_news_forum($forum)) {

html/ops/host_stats.php

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
     if ($n === false) return '';
     $m = strpos($p, ']', $n);
     if ($m === false) return '';
-    $x = substr($p, $n+5, $m-$n-5);
+    $x = substr($p, $n + 5, $m - $n - 5);
 
     $n = strpos($x, ' ');
     if ($n !== false) return substr($x, 0, $n);
@@ -47,7 +47,7 @@ 
     if ($n === false) return '';
     $m = strpos($p, ']', $n);
     if ($m === false) return '';
-    $x = substr($p, $n+5, $m-$n-5);
+    $x = substr($p, $n + 5, $m - $n - 5);
     $n = strpos($x, '_');
     if ($n !== false) return substr($x, 0, $n);
     $n = strpos($x, 'r');
@@ -57,7 +57,7 @@ 
 
 function main() {
     global $max_days;
-    $t = time()-$max_days*86400;
+    $t = time() - $max_days*86400;
     $hosts = BoincHost::enum("rpc_time>$t");
     $descs = [];
     foreach ($hosts as $host) {

html/inc/db_conn.inc

Spacing +8 added lines, -8 removed lines

@@ -22,12 +22,12 @@ 
 // Intended to be subclassed (e.g., BoincDb, BossaDb)
 //
 class DbConn {
-    var $db_conn;       // a mysqli object
-    var $db_name;       // the DB name
+    var $db_conn; // a mysqli object
+    var $db_name; // the DB name
 
     function init_conn($user, $passwd, $host, $name) {
         $x = explode(":", $host);
-        if (sizeof($x)>1) {
+        if (sizeof($x) > 1) {
             $host = $x[0];
             $port = $x[1];
         } else {
@@ -35,7 +35,7 @@ 
         }
         try {
             $this->db_conn = @new mysqli($host, $user, $passwd, $name, $port);
-        } catch(Exception $e) {
+        } catch (Exception $e) {
             return false;
         }
         if (mysqli_connect_error()) {
@@ -136,7 +136,7 @@ 
         return $this->enum_general($classname, $query);
     }
 
-    function enum($table, $classname, $where_clause=null, $order_clause=null) {
+    function enum($table, $classname, $where_clause = null, $order_clause = null) {
         return self::enum_fields(
             $table, $classname, '*', $where_clause, $order_clause
         );
@@ -181,15 +181,15 @@ 
         if ($x) return (double)$x->$field;
         return false;
     }
-    function count($table, $clause="TRUE") {
+    function count($table, $clause = "TRUE") {
         $query = "select count(*) as total from DBNAME.$table where $clause";
         return $this->get_int($query, 'total');
     }
-    function sum($table, $field, $clause="") {
+    function sum($table, $field, $clause = "") {
         $query = "select sum($field) as total from DBNAME.$table $clause";
         return $this->get_double($query, 'total');
     }
-    function max($table, $field, $clause="") {
+    function max($table, $field, $clause = "") {
         $query = "select max($field) as total from DBNAME.$table $clause";
         return $this->get_double($query, 'total');
     }

html/inc/util_basic.inc

Spacing +5 added lines, -5 removed lines

@@ -56,10 +56,10 @@ 
     return file_exists("$d/stop_sched");
 }
 
-function xml_error($num=-1, $msg=null, $file=null, $line=null) {
+function xml_error($num = -1, $msg = null, $file = null, $line = null) {
     global $xml_outer_tag;
     if (!$msg) {
-        switch($num) {
+        switch ($num) {
         case -112: $msg = "Invalid XML"; break;
         case -136: $msg = "Not found"; break;
         case -137: $msg = "Name or email address is not unique"; break;
@@ -105,7 +105,7 @@ 
 // If it's a single-tag element, and it's present, just return the tag
 //
 function parse_element($xml, $tag) {
-    $closetag = "</" . substr($tag,1);
+    $closetag = "</".substr($tag, 1);
     $x = strstr($xml, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -121,8 +121,8 @@ 
 
 function parse_next_element($xml, $tag, &$cursor) {
     $element = null;
-    $closetag = "</" . substr($tag,1);
-    $pos = substr($xml,$cursor);
+    $closetag = "</".substr($tag, 1);
+    $pos = substr($xml, $cursor);
     $x = strstr($pos, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;

html/user/get_output2.php

Spacing +4 added lines, -4 removed lines

@@ -51,7 +51,7 @@ 
     if ($user->authenticator != $auth) die('bad auth');
 }
 
-function do_result_aux($result, $batch, $file_num=null) {
+function do_result_aux($result, $batch, $file_num = null) {
     $phys_names = get_outfile_phys_names($result);
     $log_names = get_outfile_log_names($result);
     if ($file_num !== null) {
@@ -71,7 +71,7 @@ 
         $dir_path = "submit/$batch->id/$result->name";
         system("rm -r $dir_path");
         mkdir($dir_path);
-        for ($i=0; $i<count($phys_names); $i++) {
+        for ($i = 0; $i < count($phys_names); $i++) {
             $cmd = sprintf('ln -s %s %s/%s',
                 upload_path($phys_names[$i]),
                 $dir_path,
@@ -88,7 +88,7 @@ 
     }
 }
 
-function do_result($result_id, $auth, $file_num=null) {
+function do_result($result_id, $auth, $file_num = null) {
     $result = BoincResult::lookup_id($result_id);
     if (!$result) die("no result $result_id");
     $workunit = BoincWorkunit::lookup_id($result->workunitid);
@@ -135,7 +135,7 @@ 
             system($cmd);
         } else {
             mkdir(sprintf('%s/%s', $dir_path, $result->name));
-            for ($i=0; $i<count($phys_names); $i++) {
+            for ($i = 0; $i < count($phys_names); $i++) {
                 $cmd = sprintf('ln -s %s %s/%s/%s',
                     upload_path($phys_names[$i]),
                     $dir_path,

html/inc/submit_util.inc

Spacing +3 added lines, -3 removed lines

@@ -300,7 +300,7 @@ 
 // get the total size of output files of a batch
 //
 function batch_output_file_size($batchid) {
-    $batch_td_size=0;
+    $batch_td_size = 0;
     $wus = BoincWorkunit::enum("batch=$batchid");
     $fanout = parse_config(get_config(), "<uldl_dir_fanout>");
     $upload_dir = parse_config(get_config(), "<upload_dir>");
@@ -330,7 +330,7 @@ 
 }
 
 function boinc_get_wu_output_files_url($user, $wu_id) {
-    $auth_str =  md5($user->authenticator.$wu_id);
+    $auth_str = md5($user->authenticator.$wu_id);
     return "get_output.php?cmd=workunit_files&wu_id=$wu_id&auth_str=$auth_str";
 }
 
@@ -364,7 +364,7 @@ 
     if (!file_exists($path)) return null;
     $x = file_get_contents($path);
     $n = sscanf($x, "%s %d", $md5, $size);
-    if ($n != 2 || strlen($md5)!=32) {
+    if ($n != 2 || strlen($md5) != 32) {
         return null;
     }
     return [$md5, $size];

html/inc/bootstrap.inc

Spacing +20 added lines, -20 removed lines

@@ -141,12 +141,12 @@ 
         // prefix for links; needed for pages not in top dir
     $user,
         // logged-in user, if any
-    $fixed=false,
+    $fixed = false,
         // if true, navbar is fixed at top of page.
         // NOTE: if you do this, you must set a global var $fixed_navbar
         // to true at compile time
         // (it needs to be set when page_head() is called).
-    $inverse=false
+    $inverse = false
         // white on black?
 ) {
     global $master_url;
@@ -215,7 +215,7 @@ 
 // output a panel.
 // $content_func is a function that generates the panel contents
 //
-function panel($title, $content_func, $class="panel-primary", $body_class="") {
+function panel($title, $content_func, $class = "panel-primary", $body_class = "") {
     echo sprintf('<div class="panel %s">
         ', $class
     );
@@ -242,7 +242,7 @@ 
 // $left_width is the width of left column in 1/12 units.
 // $arg is passed to the functions.
 //
-function grid($top_func, $left_func, $right_func, $left_width=6, $arg=null) {
+function grid($top_func, $left_func, $right_func, $left_width = 6, $arg = null) {
     echo '
         <div class="container-fluid">
     ';
@@ -257,7 +257,7 @@ 
             </div>
         ';
     }
-    $right_width = 12-$left_width;
+    $right_width = 12 - $left_width;
     echo '
         <div class="row">
         <div class="col-sm-'.$left_width.'">
@@ -281,7 +281,7 @@ 
 //      use extra = "name=x"
 //      call forum_focus(x, foo) after defining the field
 //
-function form_start($action, $method='get', $extra='') {
+function form_start($action, $method = 'get', $extra = '') {
     echo sprintf(
         '<div class="container-fluid">
         <form class="form-horizontal" method="%s" action="%s" %s>'
@@ -313,7 +313,7 @@ 
 // just the input field
 //
 function form_input_text_field(
-    $name, $value='', $type='text', $attrs='', $extra=''
+    $name, $value = '', $type = 'text', $attrs = '', $extra = ''
 ) {
     return sprintf(
         '<input %s type="%s" class="form-control" name="%s" value="%s">%s',
@@ -324,7 +324,7 @@ 
 // the whole row
 //
 function form_input_text(
-    $label, $name, $value='', $type='text', $attrs='', $extra=''
+    $label, $name, $value = '', $type = 'text', $attrs = '', $extra = ''
 ) {
     echo sprintf('
         <div class="form-group">
@@ -352,7 +352,7 @@ 
     );
 }
 
-function form_input_textarea($label, $name, $value='', $nrows=4) {
+function form_input_textarea($label, $name, $value = '', $nrows = 4) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -368,7 +368,7 @@ 
 
 // $items is either a string of <option> elements, or an array
 //
-function form_select($label, $name, $items, $selected=null) {
+function form_select($label, $name, $items, $selected = null) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -381,7 +381,7 @@ 
         foreach ($items as $i) {
             echo sprintf(
                 '<option %s value=%s>%s</option>',
-                ($i[0]==$selected)?'selected':'',
+                ($i[0] == $selected) ? 'selected' : '',
                 $i[0], $i[1]
             );
         }
@@ -394,7 +394,7 @@ 
 // same, for multiple select.
 // $selected, if non-null, is a list of selected values
 //
-function form_select_multiple($label, $name, $items, $selected=null) {
+function form_select_multiple($label, $name, $items, $selected = null) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -406,7 +406,7 @@ 
     foreach ($items as $i) {
         echo sprintf(
             '<option %s value=%s>%s</option>',
-            ($selected && in_array($i[0], $selected))?'selected':'',
+            ($selected && in_array($i[0], $selected)) ? 'selected' : '',
             $i[0], $i[1]
         );
     }
@@ -415,12 +415,12 @@ 
 
 // return a list of string for checkbox items
 //
-function checkbox_item_strings($items, $attrs='') {
+function checkbox_item_strings($items, $attrs = '') {
     $x = [];
     foreach ($items as $i) {
         $x[] = sprintf('<input %s type="checkbox" name="%s" %s> %s
             ',
-            $attrs, $i[0], $i[2]?"checked":"", $i[1]
+            $attrs, $i[0], $i[2] ? "checked" : "", $i[1]
         );
     }
     return $x;
@@ -428,7 +428,7 @@ 
 
 // $items is list of (name, label, checked)
 //
-function form_checkboxes($label, $items, $attrs='') {
+function form_checkboxes($label, $items, $attrs = '') {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s">%s</label>
@@ -454,7 +454,7 @@ 
         FORM_LEFT_CLASS, $label, FORM_RIGHT_CLASS
     );
     foreach ($items as $i) {
-        $checked = ($selected == $i[0])?"checked":"";
+        $checked = ($selected == $i[0]) ? "checked" : "";
         echo sprintf('<input type="radio" name="%s" value="%s" %s> %s <br>
             ',
             $name, $i[0], $checked, $i[1]
@@ -487,7 +487,7 @@ 
 ';
 }
 
-function form_submit($text, $attrs='') {
+function form_submit($text, $attrs = '') {
     form_general(
         "",
         sprintf(
@@ -497,7 +497,7 @@ 
     );
 }
 
-function form_checkbox($label, $name, $checked=false) {
+function form_checkbox($label, $name, $checked = false) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s">%s</label>
@@ -508,6 +508,6 @@ 
     echo sprintf('
         <input type="checkbox" name="%s" %s>
         </div>
-        ', $name, $checked?"checked":""
+        ', $name, $checked ? "checked" : ""
     );
 }

html/user/sandbox.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -165,7 +165,7 @@
     $fname = basename($url);
     $path = "$dir/$fname";
     if (file_exists($path)) {
-        error_page("File $fname exists; delete it first.");
+        error_page("file $fname exists; delete it first.");
     }
     copy($url, $path);
     $notice = "Fetched file from <strong>$url</strong><br/>";

Spacing +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
     $notice = "";
     $dir = sandbox_dir($user);
     $count = count($_FILES['new_file']['tmp_name']);
-    for ($i=0; $i<$count; $i++) {
+    for ($i = 0; $i < $count; $i++) {
         $tmp_name = $_FILES['new_file']['tmp_name'][$i];
         if (!is_uploaded_file($tmp_name)) {
             error_page("$tmp_name is not uploaded file");

html/user/buda.php

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -92,7 +92,7 @@ 
     if (!is_valid_filename($app)) die('bad arg');
     $variant = get_str('variant');
     if (!is_valid_filename($variant)) die('bad arg');
-    page_head("App $app variant $variant");
+    page_head("app $app variant $variant");
     $dir = "$buda_root/$app/$variant";
     start_table();
     table_header('name', 'size', 'md5');
@@ -136,7 +136,7 @@ 
     form_input_hidden('app', $app);
     form_input_hidden('action', 'variant_action');
     form_input_text('Plan class', 'variant');
-    form_select("Dockerfile$sb", 'dockerfile', $sbitems);
+    form_select("dockerfile$sb", 'dockerfile', $sbitems);
     form_select_multiple("Application files$sb", 'app_files', $sbitems);
     form_input_text(
         'Input file names<br><small>Space-separated</small>',
@@ -222,7 +222,7 @@ 
     // Note: we don't currently allow indirect file access.
     // If we did, we'd need to create job.toml to mount project dir
 
-    app_list("Variant $variant added for app $app.");
+    app_list("variant $variant added for app $app.");
 }
 
 function variant_delete() {
@@ -249,7 +249,7 @@ 
         if ($ret) {
             error_page("delete failed");
         }
-        $notice = "Variant $variant of app $app removed.";
+        $notice = "variant $variant of app $app removed.";
         app_list($notice);
     } else {
         page_head("Confirm");
@@ -278,7 +278,7 @@ 
         if ($ret) {
             error_page('delete failed');
         }
-        $notice = "App $app removed.";
+        $notice = "app $app removed.";
         app_list($notice);
     } else {
         page_head('Confirm');
@@ -307,7 +307,7 @@ 
     if (!is_valid_filename($name)) die("bad arg: $name");
     $dir = "$buda_root/$name";
     if (file_exists($dir)) {
-        error_page("App $name already exists.");
+        error_page("app $name already exists.");
     }
     mkdir($dir);
     header("Location: buda.php");

Spacing +3 added lines, -3 removed lines

@@ -32,7 +32,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -96,7 +96,7 @@ 
     $dir = "$buda_root/$app/$variant";
     start_table();
     table_header('name', 'size', 'md5');
-    foreach(scandir($dir) as $f) {
+    foreach (scandir($dir) as $f) {
         if ($f[0] == '.') continue;
         [$md5, $size] = parse_info_file("$dir/.md5/$f");
         table_row(
@@ -172,7 +172,7 @@ 
     //
     $x = "<input_template>\n";
     $ninfiles = 1 + count($variant_desc->input_file_names) + count($variant_desc->app_files);
-    for ($i=0; $i<$ninfiles; $i++) {
+    for ($i = 0; $i < $ninfiles; $i++) {
         $x .= "   <file_info>\n      <no_delete/>\n   </file_info>\n";
     }
     $x .= "   <workunit>\n";