@@ -58,7 +58,7 @@ |
||
| 58 | 58 | //panel(null, 'panel_contents'); |
| 59 | 59 | } |
| 60 | 60 | |
| 61 | -function left(){ |
|
| 61 | +function left() { |
|
| 62 | 62 | global $user, $no_web_account_creation, $master_url, $project_id; |
| 63 | 63 | panel( |
| 64 | 64 | $user?tra("Welcome, %1", $user->name):tra("What is %1?", PROJECT), |
@@ -104,7 +104,7 @@ |
||
| 104 | 104 | // set to 1. |
| 105 | 105 | if ($consent_flag==0) { |
| 106 | 106 | $rc = consent_to_a_policy($user, $ctid, 0, 1, $source); |
| 107 | - } else { |
|
| 107 | + } else { |
|
| 108 | 108 | $rc = consent_to_a_policy($user, $ctid, 1, 0, $source); |
| 109 | 109 | } |
| 110 | 110 | if (!$rc) { |
@@ -430,8 +430,7 @@ discard block |
||
| 430 | 430 | $user_info .= ' <div class="picture">'; |
| 431 | 431 | if (is_array($user_image) AND $user_image['image']['filepath']) { |
| 432 | 432 | $user_info .= theme('imagefield_image', $user_image['image'], $user_image['alt'], $user_image['alt'], array(), false); |
| 433 | - } |
|
| 434 | - elseif (is_string($user_image)) { |
|
| 433 | + } elseif (is_string($user_image)) { |
|
| 435 | 434 | $user_info .= '<img src="' . $user_image . '"/>'; |
| 436 | 435 | } |
| 437 | 436 | $user_info .= ' </div>'; |
@@ -473,8 +472,7 @@ discard block |
||
| 473 | 472 | // If a specific comment is being referenced, go back to it on cancel |
| 474 | 473 | if ($comment_ref = $form['pid']['#value']) { |
| 475 | 474 | $cancel_url = "goto/comment/{$comment_ref}"; |
| 476 | - } |
|
| 477 | - else { |
|
| 475 | + } else { |
|
| 478 | 476 | $cancel_url = "node/{$form['nid']['#value']}"; |
| 479 | 477 | } |
| 480 | 478 | |
@@ -528,8 +526,7 @@ discard block |
||
| 528 | 526 | '#weight' => 1000, |
| 529 | 527 | ); |
| 530 | 528 | } |
| 531 | - } |
|
| 532 | - else { |
|
| 529 | + } else { |
|
| 533 | 530 | $form = NULL; |
| 534 | 531 | $form['from'] = array( |
| 535 | 532 | '#type' => 'item', |
@@ -626,8 +623,7 @@ discard block |
||
| 626 | 623 | 'title' => bts('Reply to this topic with a quote', array(), NULL, 'boinc:forum-reply-to-comment') |
| 627 | 624 | ); |
| 628 | 625 | } |
| 629 | - } |
|
| 630 | - else { |
|
| 626 | + } else { |
|
| 631 | 627 | // Standard EDIT, DELETE, and REPLY links are created by Drupal, but we want to alter them |
| 632 | 628 | if (isset($links['comment_delete'])) { |
| 633 | 629 | $links['comment_delete']['attributes'] = array( |
@@ -681,8 +677,7 @@ discard block |
||
| 681 | 677 | 'title' => bts('Remove sticky status from this topic', array(), NULL, 'boinc:forum-unsticky-comment') |
| 682 | 678 | ) |
| 683 | 679 | ); |
| 684 | - } |
|
| 685 | - else { |
|
| 680 | + } else { |
|
| 686 | 681 | $links['make_sticky'] = array( |
| 687 | 682 | 'title' => bts('Make sticky', array(), NULL, 'boinc:forum-sticky-comment'), |
| 688 | 683 | 'href' => "{$node_control}/sticky", |
@@ -699,8 +694,7 @@ discard block |
||
| 699 | 694 | 'title' => bts('Lock this thread for comments', array(), NULL, 'boinc:forum-lock-comment') |
| 700 | 695 | ) |
| 701 | 696 | ); |
| 702 | - } |
|
| 703 | - else { |
|
| 697 | + } else { |
|
| 704 | 698 | $links['unlock'] = array( |
| 705 | 699 | 'title' => bts('Unlock', array(), NULL, 'boinc:forum-unlock-comment'), |
| 706 | 700 | 'href' => "{$node_control}/unlock", |
@@ -717,8 +711,7 @@ discard block |
||
| 717 | 711 | 'title' => bts('Hide this topic', array(), NULL, 'boinc:forum-hide-comment') |
| 718 | 712 | ) |
| 719 | 713 | ); |
| 720 | - } |
|
| 721 | - else { |
|
| 714 | + } else { |
|
| 722 | 715 | $links['unhide'] = array( |
| 723 | 716 | 'title' => bts('Unhide', array(), NULL, 'boinc:forum-unhide-comment'), |
| 724 | 717 | 'href' => "{$node_control}/unhide", |
@@ -729,8 +722,7 @@ discard block |
||
| 729 | 722 | } |
| 730 | 723 | }// if user_access('edit any forum topic') |
| 731 | 724 | } |
| 732 | - } |
|
| 733 | - else if ($type=='comment') { |
|
| 725 | + } else if ($type=='comment') { |
|
| 734 | 726 | $node = node_load($object->nid); |
| 735 | 727 | $nid = $object->nid; |
| 736 | 728 | $cid = $object->cid; |
@@ -771,8 +763,7 @@ discard block |
||
| 771 | 763 | 'title' => bts('Hide this comment', array(), NULL, 'boinc:forum-hide-comment') |
| 772 | 764 | ) |
| 773 | 765 | ); |
| 774 | - } |
|
| 775 | - else { |
|
| 766 | + } else { |
|
| 776 | 767 | $links['unhide'] = array( |
| 777 | 768 | 'title' => bts('Unhide', array(), NULL, 'boinc:forum-unhide-comment'), |
| 778 | 769 | 'href' => "{$comment_control}/unhide", |
@@ -958,8 +949,7 @@ discard block |
||
| 958 | 949 | watchdog('am_set_info', "XML validation error in global_prefs: {$errors[0]->message} at line {$errors[0]->line}" . |
| 959 | 950 | ': <br/>' . htmlentities($lines[$errors[0]->line - 1]), array(), WATCHDOG_ERROR); |
| 960 | 951 | } |
| 961 | - } |
|
| 962 | - elseif ($project_prefs) { |
|
| 952 | + } elseif ($project_prefs) { |
|
| 963 | 953 | $xml->loadXML($project_prefs, LIBXML_NOBLANKS); |
| 964 | 954 | if ($errors = libxml_get_errors($xml)) { |
| 965 | 955 | $lines = explode("\r", $project_prefs); |
@@ -1002,8 +992,7 @@ discard block |
||
| 1002 | 992 | node_save($content_profile); |
| 1003 | 993 | } |
| 1004 | 994 | } |
| 1005 | - } |
|
| 1006 | - else { |
|
| 995 | + } else { |
|
| 1007 | 996 | $xml = array( |
| 1008 | 997 | 'error' => array( |
| 1009 | 998 | 'error_num' => -112, |
@@ -1138,8 +1127,7 @@ discard block |
||
| 1138 | 1127 | node_save($node); |
| 1139 | 1128 | // Save the team IDs to a BOINC <--> Drupal reference table. |
| 1140 | 1129 | db_query('INSERT INTO {boincteam} (team_id, nid) VALUES (%d, %d)', $boincteam_id, $node->nid); |
| 1141 | - } |
|
| 1142 | - else { |
|
| 1130 | + } else { |
|
| 1143 | 1131 | $xml['create_team_reply']['warning'] = t( |
| 1144 | 1132 | 'There was a problem integrating this team into Drupal. Please |
| 1145 | 1133 | contact @project administrators!', array('@project' => PROJECT) |
@@ -1154,8 +1142,7 @@ discard block |
||
| 1154 | 1142 | // Delete from the BOINC DB if we can't sync with Drupal |
| 1155 | 1143 | $boincteam::delete(); |
| 1156 | 1144 | } |
| 1157 | - } |
|
| 1158 | - else { |
|
| 1145 | + } else { |
|
| 1159 | 1146 | $xml['create_team_reply']['warning'] = t( |
| 1160 | 1147 | 'There was a problem integrating this team into Drupal. Please |
| 1161 | 1148 | contact @project administrators!', array('@project' => PROJECT) |
@@ -1169,8 +1156,7 @@ discard block |
||
| 1169 | 1156 | ); |
| 1170 | 1157 | } |
| 1171 | 1158 | } |
| 1172 | - } |
|
| 1173 | - else { |
|
| 1159 | + } else { |
|
| 1174 | 1160 | $xml = array( |
| 1175 | 1161 | 'error' => array( |
| 1176 | 1162 | 'error_num' => -1, |
@@ -1239,8 +1225,7 @@ discard block |
||
| 1239 | 1225 | ); |
| 1240 | 1226 | $xml['users']['user'][] = $team_member; |
| 1241 | 1227 | } |
| 1242 | - } |
|
| 1243 | - else { |
|
| 1228 | + } else { |
|
| 1244 | 1229 | // Query BOINC database user table |
| 1245 | 1230 | db_set_active('boinc_rw'); |
| 1246 | 1231 | $result = db_query(" |
@@ -1293,8 +1278,7 @@ discard block |
||
| 1293 | 1278 | $xml['users']['user'][] = $team_members[$member->boinc_id]; |
| 1294 | 1279 | } |
| 1295 | 1280 | } // end if credit_only |
| 1296 | - } |
|
| 1297 | - else { |
|
| 1281 | + } else { |
|
| 1298 | 1282 | $xml = array( |
| 1299 | 1283 | 'error' => array( |
| 1300 | 1284 | 'error_num' => -136, |
@@ -1343,24 +1327,19 @@ discard block |
||
| 1343 | 1327 | if ($avatar_image) { |
| 1344 | 1328 | $profile_node->field_image[0] = $avatar_image; |
| 1345 | 1329 | node_save($profile_node); |
| 1346 | - } |
|
| 1347 | - else { |
|
| 1330 | + } else { |
|
| 1348 | 1331 | $error = 'Error saving avatar to profile'; |
| 1349 | 1332 | } |
| 1350 | - } |
|
| 1351 | - else { |
|
| 1333 | + } else { |
|
| 1352 | 1334 | $error = 'Unable to load user profile'; |
| 1353 | 1335 | } |
| 1354 | - } |
|
| 1355 | - else { |
|
| 1336 | + } else { |
|
| 1356 | 1337 | $error = 'User has no profile, so avatar could not be added'; |
| 1357 | 1338 | } |
| 1358 | - } |
|
| 1359 | - else { |
|
| 1339 | + } else { |
|
| 1360 | 1340 | $error = 'Unable to save remote image'; |
| 1361 | 1341 | } |
| 1362 | - } |
|
| 1363 | - else { |
|
| 1342 | + } else { |
|
| 1364 | 1343 | $error = 'Could not find avatar image at URL'; |
| 1365 | 1344 | } |
| 1366 | 1345 | } |
@@ -1387,8 +1366,7 @@ discard block |
||
| 1387 | 1366 | 'success' => NULL, |
| 1388 | 1367 | ), |
| 1389 | 1368 | ); |
| 1390 | - } |
|
| 1391 | - else { |
|
| 1369 | + } else { |
|
| 1392 | 1370 | // Failure |
| 1393 | 1371 | $xml = array( |
| 1394 | 1372 | 'error' => array( |
@@ -1397,8 +1375,7 @@ discard block |
||
| 1397 | 1375 | ), |
| 1398 | 1376 | ); |
| 1399 | 1377 | } |
| 1400 | - } |
|
| 1401 | - else { |
|
| 1378 | + } else { |
|
| 1402 | 1379 | // Drupal user not found |
| 1403 | 1380 | $xml = array( |
| 1404 | 1381 | 'error' => array( |
@@ -1407,8 +1384,7 @@ discard block |
||
| 1407 | 1384 | ), |
| 1408 | 1385 | ); |
| 1409 | 1386 | } |
| 1410 | - } |
|
| 1411 | - else { |
|
| 1387 | + } else { |
|
| 1412 | 1388 | // BOINC user not found |
| 1413 | 1389 | $xml = array( |
| 1414 | 1390 | 'error' => array( |
@@ -1526,8 +1502,7 @@ discard block |
||
| 1526 | 1502 | ), |
| 1527 | 1503 | ); |
| 1528 | 1504 | } |
| 1529 | - } |
|
| 1530 | - else { |
|
| 1505 | + } else { |
|
| 1531 | 1506 | $xml = array( |
| 1532 | 1507 | 'error' => array( |
| 1533 | 1508 | 'error_num' => -136, |
@@ -1651,8 +1626,7 @@ discard block |
||
| 1651 | 1626 | // Get the number of comments per page |
| 1652 | 1627 | if ($user->comments_per_page) { |
| 1653 | 1628 | $comments_per_page = $user->comments_per_page; |
| 1654 | - } |
|
| 1655 | - else { |
|
| 1629 | + } else { |
|
| 1656 | 1630 | $node = node_load($object->nid); |
| 1657 | 1631 | $comments_per_page = variable_get( |
| 1658 | 1632 | "comment_default_per_page_{$node->type}", 50 |
@@ -1673,8 +1647,7 @@ discard block |
||
| 1673 | 1647 | // Check for a login, then redirect to the user's friend requests page |
| 1674 | 1648 | if ($user->uid) { |
| 1675 | 1649 | drupal_goto("account/{$user->uid}/friends/pending"); |
| 1676 | - } |
|
| 1677 | - else { |
|
| 1650 | + } else { |
|
| 1678 | 1651 | drupal_goto('user/login', array( |
| 1679 | 1652 | 'destination' => 'goto/friend-requests' |
| 1680 | 1653 | )); |
@@ -1950,8 +1923,7 @@ discard block |
||
| 1950 | 1923 | if ($moderator_rid !== FALSE) { |
| 1951 | 1924 | $settings['recipients'] = array($moderator_rid); |
| 1952 | 1925 | rules_action_mail_to_users_of_role($settings); |
| 1953 | - } |
|
| 1954 | - else { |
|
| 1926 | + } else { |
|
| 1955 | 1927 | watchdog( |
| 1956 | 1928 | 'boinccore', |
| 1957 | 1929 | 'Unable to identify members of the moderator role to send moderator notifications!', |
@@ -1982,8 +1954,7 @@ discard block |
||
| 1982 | 1954 | } |
| 1983 | 1955 | if (empty($args)) { |
| 1984 | 1956 | return $string; |
| 1985 | - } |
|
| 1986 | - else { |
|
| 1957 | + } else { |
|
| 1987 | 1958 | // Transform arguments before inserting them. |
| 1988 | 1959 | foreach ($args as $key => $value) { |
| 1989 | 1960 | switch ($key [0]) { |
@@ -53,8 +53,7 @@ |
||
| 53 | 53 | $boincusername = (!empty($account)) ? $account->boincuser_name : variable_get('anonymous', 'Anonymous'); |
| 54 | 54 | $replace = TRUE; |
| 55 | 55 | } |
| 56 | - } |
|
| 57 | - elseif ($nid && _quote_variable_get('node_link_display')) { |
|
| 56 | + } elseif ($nid && _quote_variable_get('node_link_display')) { |
|
| 58 | 57 | $node = node_load(array('nid' => $nid)); |
| 59 | 58 | if (in_array($node->type, _quote_variable_get('node_types'))) { |
| 60 | 59 | $account = user_load($node->uid); |
@@ -418,11 +418,9 @@ discard block |
||
| 418 | 418 | |
| 419 | 419 | if ($edit['boincuser_name']) { |
| 420 | 420 | $myname = $edit['boincuser_name']; |
| 421 | - } |
|
| 422 | - else if ($edit['name']) { |
|
| 421 | + } else if ($edit['name']) { |
|
| 423 | 422 | $myname = $edit['name']; |
| 424 | - } |
|
| 425 | - else { |
|
| 423 | + } else { |
|
| 426 | 424 | $myname = 'noname'; |
| 427 | 425 | } |
| 428 | 426 | |
@@ -434,8 +432,7 @@ discard block |
||
| 434 | 432 | // If the 'pass' variable is already a hash, then don't hash it again. |
| 435 | 433 | if ($edit['boinchash_flag']) { |
| 436 | 434 | $user_params['passwd_hash'] = $edit['pass']; |
| 437 | - } |
|
| 438 | - else { |
|
| 435 | + } else { |
|
| 439 | 436 | // The passwd_hash here is only the md5() hash. This is |
| 440 | 437 | // because BOINC make_user(), called later, will run |
| 441 | 438 | // password_hash() on this md5 hash. |
@@ -506,8 +503,7 @@ discard block |
||
| 506 | 503 | $prev_email = $account->mail; |
| 507 | 504 | $mytime = (user_access('administer users')) ? $boinc_user->email_addr_change_time : time(); |
| 508 | 505 | $querypart = "email_addr='{$lower_email_addr}', passwd_hash='{$passwd_hash}', previous_email_addr = '{$prev_email}', email_addr_change_time = $mytime"; |
| 509 | - } |
|
| 510 | - else { |
|
| 506 | + } else { |
|
| 511 | 507 | $querypart = "email_addr='{$lower_email_addr}', passwd_hash='{$passwd_hash}'"; |
| 512 | 508 | } |
| 513 | 509 | |
@@ -750,8 +746,7 @@ discard block |
||
| 750 | 746 | case FLAG_FRIEND_APPROVAL: |
| 751 | 747 | if ($action == 'flag') { |
| 752 | 748 | $form['flag_friend_submit']['#value'] = bts('Approve request', array(), NULL, 'boinc:friends-page'); |
| 753 | - } |
|
| 754 | - elseif ($action == 'unflag') { |
|
| 749 | + } elseif ($action == 'unflag') { |
|
| 755 | 750 | unset($form['actions']); |
| 756 | 751 | $form['flag_friend_submit']['#value'] = bts('Deny request', array(), NULL, 'boinc:friends-page'); |
| 757 | 752 | } |
@@ -1527,8 +1522,7 @@ discard block |
||
| 1527 | 1522 | array( |
| 1528 | 1523 | '!boinccmd' => l('boinccmd --project_attach', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'), |
| 1529 | 1524 | ), NULL, 'boinc:join-page') . '</li>'; |
| 1530 | - } |
|
| 1531 | - else { |
|
| 1525 | + } else { |
|
| 1532 | 1526 | $output .= '<li>' . bts("If you're running a command-line version of BOINC, |
| 1533 | 1527 | please follow the <b>!instructionslink</b> to first <i>create an account</i>, and then <i>attach</i> to this project. Use the same project URL as above.", |
| 1534 | 1528 | array( |
@@ -1563,8 +1557,7 @@ discard block |
||
| 1563 | 1557 | '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'), |
| 1564 | 1558 | '@sitename' => $site_name, |
| 1565 | 1559 | ), NULL, 'boinc:join-page') . '</li>'; |
| 1566 | - } |
|
| 1567 | - else if ( menu_valid_path(array('link_path' => $ruleslink)) ) { |
|
| 1560 | + } else if ( menu_valid_path(array('link_path' => $ruleslink)) ) { |
|
| 1568 | 1561 | $output .= ' <li>' . bts("Read our !rules_and_policies.", array( |
| 1569 | 1562 | '!rules_and_policies' => l(bts('Rules and Policies', array(), NULL, 'boinc:join-page'), $ruleslink), |
| 1570 | 1563 | ), NULL, 'boinc:join-page') . '</li>'; |
@@ -1606,8 +1599,7 @@ discard block |
||
| 1606 | 1599 | )); |
| 1607 | 1600 | if ($current_uotd->uotd_time < strtotime('today midnight')) { |
| 1608 | 1601 | $uotd = boincuser_select_user_of_the_day(); |
| 1609 | - } |
|
| 1610 | - else { |
|
| 1602 | + } else { |
|
| 1611 | 1603 | $uotd = user_load($current_uotd->uid); |
| 1612 | 1604 | } |
| 1613 | 1605 | $uotd_image = boincuser_get_user_profile_image($uotd->uid, FALSE); |
@@ -1618,8 +1610,7 @@ discard block |
||
| 1618 | 1610 | $output .= ' <div>' . bts($site_message, array(), NULL, "project:front page") . ' ' . l(bts('Learn more', array(), NULL, 'boinc:front-page'), 'about') . '</div>'; |
| 1619 | 1611 | if ($user->uid) { |
| 1620 | 1612 | $output .= ' <div>' . l(bts('View account', array(), NULL, 'boinc:front-page'), 'dashboard', array('attributes' => array('class' => 'join button'))) . '</div>'; |
| 1621 | - } |
|
| 1622 | - else { |
|
| 1613 | + } else { |
|
| 1623 | 1614 | $output .= ' <div>' . l(bts('Join now', array(), NULL, 'boinc:front-page'), 'join', array('attributes' => array('class' => 'join button'))) . '</div>'; |
| 1624 | 1615 | } |
| 1625 | 1616 | $output .= '</div>'; |
@@ -1704,12 +1695,10 @@ discard block |
||
| 1704 | 1695 | if ( ($params['passwd_hash'] == $boinc_user->passwd_hash) or |
| 1705 | 1696 | password_verify($params['passwd_hash'], $boinc_user->passwd_hash) ) { |
| 1706 | 1697 | $output = array('authenticator' => $boinc_user->authenticator); |
| 1707 | - } |
|
| 1708 | - else { |
|
| 1698 | + } else { |
|
| 1709 | 1699 | xml_error(-137); |
| 1710 | 1700 | } |
| 1711 | - } |
|
| 1712 | - else { |
|
| 1701 | + } else { |
|
| 1713 | 1702 | // Verify that there isn't somehow a Drupal user already (not possible with proper function) |
| 1714 | 1703 | if ($existing_user = user_load(array('mail' => $params['email_addr']))) { |
| 1715 | 1704 | xml_error(-137, 'account error'); |
@@ -2193,7 +2182,9 @@ discard block |
||
| 2193 | 2182 | 'cpid' => $cpid |
| 2194 | 2183 | ); |
| 2195 | 2184 | $args = array(); |
| 2196 | - foreach ($get as $arg => $value) $args[] = "{$arg}=" . rawurlencode($value); |
|
| 2185 | + foreach ($get as $arg => $value) { |
|
| 2186 | + $args[] = "{$arg}=" . rawurlencode($value); |
|
| 2187 | + } |
|
| 2197 | 2188 | $query = '?' . implode('&', $args); |
| 2198 | 2189 | |
| 2199 | 2190 | // Load XML from RPC |
@@ -2324,8 +2315,7 @@ discard block |
||
| 2324 | 2315 | if ($node->uid == 0 || strlen($node->name) == 0) { |
| 2325 | 2316 | // @see user_validate_name(). !'0' === TRUE. |
| 2326 | 2317 | $document->ss_name = '0'; |
| 2327 | - } |
|
| 2328 | - else { |
|
| 2318 | + } else { |
|
| 2329 | 2319 | $document->ss_name = $account->boincuser_name; |
| 2330 | 2320 | // We want the name to be searchable for keywords. |
| 2331 | 2321 | $document->tos_name = $account->boincuser_name; |
@@ -64,8 +64,7 @@ discard block |
||
| 64 | 64 | $t->user_postal_code = decode($t->user_postal_code); |
| 65 | 65 | $t->user_url = decode($t->user_url); |
| 66 | 66 | return $t; |
| 67 | - } |
|
| 68 | - else if (strstr($s, '<name>')) $t->name = parse_element($s, '<name>'); |
|
| 67 | + } else if (strstr($s, '<name>')) $t->name = parse_element($s, '<name>'); |
|
| 69 | 68 | else if (strstr($s, '<url>')) $t->url = parse_element($s, '<url>'); |
| 70 | 69 | else if (strstr($s, '<type>')) $t->type = parse_element($s, '<type>'); |
| 71 | 70 | else if (strstr($s, '<name_html>')) $t->name_html = parse_element($s, '<name_html>'); |
@@ -74,14 +73,12 @@ discard block |
||
| 74 | 73 | if (strstr($s, '</description>')) break; |
| 75 | 74 | $t->description .= $s; |
| 76 | 75 | } |
| 77 | - } |
|
| 78 | - else if (strstr($s, '<country>')) $t->country = parse_element($s, '<country>'); |
|
| 76 | + } else if (strstr($s, '<country>')) $t->country = parse_element($s, '<country>'); |
|
| 79 | 77 | else if (strstr($s, '<id>')) $t->id = parse_element($s, '<id>'); |
| 80 | 78 | else if (strstr($s, '<user_email_munged>')) { |
| 81 | 79 | $user_email_munged = parse_element($s, '<user_email_munged>'); |
| 82 | 80 | $t->user_email = str_rot13($user_email_munged); |
| 83 | - } |
|
| 84 | - else if (strstr($s, '<user_name>')) $t->user_name = parse_element($s, '<user_name>'); |
|
| 81 | + } else if (strstr($s, '<user_name>')) $t->user_name = parse_element($s, '<user_name>'); |
|
| 85 | 82 | else if (strstr($s, '<user_country>')) $t->user_country = parse_element($s, '<user_country>'); |
| 86 | 83 | else if (strstr($s, '<user_postal_code>')) $t->user_postal_code = parse_element($s, '<user_postal_code>'); |
| 87 | 84 | else if (strstr($s, '<user_url>')) $t->user_url = parse_element($s, '<user_url>'); |
@@ -140,8 +137,7 @@ discard block |
||
| 140 | 137 | list($checkct, $ctid) = check_consent_type(CONSENT_TYPE_ENROLL); |
| 141 | 138 | if ($checkct) { |
| 142 | 139 | echo " cannot make user when an consent to terms of use is required\n"; |
| 143 | - } |
|
| 144 | - else { |
|
| 140 | + } else { |
|
| 145 | 141 | echo " making user $t->user_email\n"; |
| 146 | 142 | $user = make_user($t->user_email, $t->user_name, random_string()); |
| 147 | 143 | if (!$user) { |
@@ -46,8 +46,7 @@ discard block |
||
| 46 | 46 | if ($toggle == "Click to Enable") { |
| 47 | 47 | $state = 1; |
| 48 | 48 | $action = "Enabled"; |
| 49 | - } |
|
| 50 | - else { |
|
| 49 | + } else { |
|
| 51 | 50 | $state = 0; |
| 52 | 51 | $action = "Disabled"; |
| 53 | 52 | } |
@@ -91,12 +90,10 @@ discard block |
||
| 91 | 90 | if (!in_rops()) { |
| 92 | 91 | if (!($ct->enabled)) { |
| 93 | 92 | echo " <td><input class=\"btn btn-default\" name=toggleenabled type=submit value=\"Click to Enable\"></td>"; |
| 94 | - } |
|
| 95 | - else { |
|
| 93 | + } else { |
|
| 96 | 94 | echo " <td><input class=\"btn btn-default\" name=toggleenabled type=submit value=\"Click to Disable\"></td>"; |
| 97 | 95 | } |
| 98 | - } |
|
| 99 | - else { |
|
| 96 | + } else { |
|
| 100 | 97 | echo " <td>$ct->enabled</td>"; |
| 101 | 98 | } |
| 102 | 99 | |
@@ -107,12 +104,10 @@ discard block |
||
| 107 | 104 | if (!in_rops()) { |
| 108 | 105 | if (!($ct->privacypref)) { |
| 109 | 106 | echo " <td><input class=\"btn btn-default\" name=toggleprivacypref type=submit value=\"Click to Enable\"></td>"; |
| 110 | - } |
|
| 111 | - else { |
|
| 107 | + } else { |
|
| 112 | 108 | echo " <td><input class=\"btn btn-default\" name=toggleprivacypref type=submit value=\"Click to Disable\"></td>"; |
| 113 | 109 | } |
| 114 | - } |
|
| 115 | - else { |
|
| 110 | + } else { |
|
| 116 | 111 | echo " <td>$ct->privacypref</td>"; |
| 117 | 112 | } |
| 118 | 113 | |
@@ -156,11 +151,9 @@ discard block |
||
| 156 | 151 | |
| 157 | 152 | if (post_str("add_consenttype", true)) { |
| 158 | 153 | add_consenttype(); |
| 159 | -} |
|
| 160 | -else if (post_str("toggleenabled", true)) { |
|
| 154 | +} else if (post_str("toggleenabled", true)) { |
|
| 161 | 155 | mct_toggle_field("enabled"); |
| 162 | -} |
|
| 163 | -else if (post_str("toggleprivacypref", true)) { |
|
| 156 | +} else if (post_str("toggleprivacypref", true)) { |
|
| 164 | 157 | mct_toggle_field("privacypref"); |
| 165 | 158 | } |
| 166 | 159 | |
@@ -127,8 +127,7 @@ discard block |
||
| 127 | 127 | if (isset($prefs[$name]['@value'])) { |
| 128 | 128 | $default[$name] = $prefs[$name]['@value']; |
| 129 | 129 | } |
| 130 | - } |
|
| 131 | - else { |
|
| 130 | + } else { |
|
| 132 | 131 | $default[$name] = $prefs[$name]; |
| 133 | 132 | } |
| 134 | 133 | } |
@@ -655,8 +654,7 @@ discard block |
||
| 655 | 654 | // Save the preset selection (or lack thereof) |
| 656 | 655 | if (!$preset OR $preset == 'custom') { |
| 657 | 656 | $prefs['preset'] = 'custom'; |
| 658 | - } |
|
| 659 | - else { |
|
| 657 | + } else { |
|
| 660 | 658 | $prefs['preset'] = $preset; |
| 661 | 659 | } |
| 662 | 660 | |
@@ -671,8 +669,7 @@ discard block |
||
| 671 | 669 | if (!$result) { |
| 672 | 670 | watchdog('boincwork', 'Error updating global prefs for user @id: @message', array('@id' => $account->id, '@message' => mysqli_error()), WATCHDOG_ERROR); |
| 673 | 671 | drupal_set_message(t('Your changes could not be saved. Please contact support!'), 'error'); |
| 674 | - } |
|
| 675 | - elseif (!drupal_get_messages('status', FALSE)) { |
|
| 672 | + } elseif (!drupal_get_messages('status', FALSE)) { |
|
| 676 | 673 | // Show this message if the set wasn't created automatically (in which case |
| 677 | 674 | // there is a message tailored to that) { |
| 678 | 675 | drupal_set_message(t('Your preferences have been updated. |
@@ -927,8 +924,7 @@ discard block |
||
| 927 | 924 | if (boincwork_host_merge($old_host, $current_host, $message)) { |
| 928 | 925 | $merged[$old_host->id] = $old_host->id; |
| 929 | 926 | $current_host = boincwork_host_get_info($current_host_id); |
| 930 | - } |
|
| 931 | - else { |
|
| 927 | + } else { |
|
| 932 | 928 | $errors[$old_host->id] = $message; |
| 933 | 929 | } |
| 934 | 930 | } |
@@ -944,8 +940,7 @@ discard block |
||
| 944 | 940 | $oxford_comma = ''; |
| 945 | 941 | } |
| 946 | 942 | $list = implode(', ', $list) . $oxford_comma . ' ' . $conjunction . ' ' . $last; |
| 947 | - } |
|
| 948 | - else { |
|
| 943 | + } else { |
|
| 949 | 944 | $list = $last; |
| 950 | 945 | } |
| 951 | 946 | if (count($merged) == 1) { |
@@ -956,8 +951,7 @@ discard block |
||
| 956 | 951 | '@id' => $current_host_id |
| 957 | 952 | ), |
| 958 | 953 | NULL, 'boinc:account-host-merge')); |
| 959 | - } |
|
| 960 | - else { |
|
| 954 | + } else { |
|
| 961 | 955 | drupal_set_message(bts( |
| 962 | 956 | 'Computers @old_ids have been merged successfully into @id.', |
| 963 | 957 | array( |
@@ -1023,11 +1017,9 @@ discard block |
||
| 1023 | 1017 | if ($account->boincuser_default_pref_set == $venue) { |
| 1024 | 1018 | $venue_is_default = TRUE; |
| 1025 | 1019 | } |
| 1026 | - } |
|
| 1027 | - elseif (!$venue OR $venue == 'generic') { |
|
| 1020 | + } elseif (!$venue OR $venue == 'generic') { |
|
| 1028 | 1021 | $venue_is_default = TRUE; |
| 1029 | - } |
|
| 1030 | - else { |
|
| 1022 | + } else { |
|
| 1031 | 1023 | $venue_is_default = FALSE; |
| 1032 | 1024 | } |
| 1033 | 1025 | |
@@ -1047,8 +1039,7 @@ discard block |
||
| 1047 | 1039 | if (isset($prefs[$name]['@value'])) { |
| 1048 | 1040 | $default[$name] = $prefs[$name]['@value']; |
| 1049 | 1041 | } |
| 1050 | - } |
|
| 1051 | - else { |
|
| 1042 | + } else { |
|
| 1052 | 1043 | $default[$name] = $prefs[$name]; |
| 1053 | 1044 | } |
| 1054 | 1045 | } |
@@ -1232,16 +1223,13 @@ discard block |
||
| 1232 | 1223 | foreach ($element as $ordered_element) { |
| 1233 | 1224 | if (isset($ordered_element['@position'])) { |
| 1234 | 1225 | $ordered_array[$ordered_element['@position']] = array($type => $ordered_element); |
| 1235 | - } |
|
| 1236 | - else { |
|
| 1226 | + } else { |
|
| 1237 | 1227 | $unordered_array[] = array($type => $ordered_element); |
| 1238 | 1228 | } |
| 1239 | 1229 | } |
| 1240 | - } |
|
| 1241 | - elseif (isset($element['@position'])) { |
|
| 1230 | + } elseif (isset($element['@position'])) { |
|
| 1242 | 1231 | $ordered_array[$element['@position']] = array($type => $element); |
| 1243 | - } |
|
| 1244 | - else { |
|
| 1232 | + } else { |
|
| 1245 | 1233 | $unordered_array[] = array($type => $element); |
| 1246 | 1234 | } |
| 1247 | 1235 | } |
@@ -1356,8 +1344,7 @@ discard block |
||
| 1356 | 1344 | // Update the user's default preference set |
| 1357 | 1345 | if ($edit['default_set']['default_venue']) { |
| 1358 | 1346 | boincwork_set_default_venue($venue); |
| 1359 | - } |
|
| 1360 | - elseif ($venue == $account->boincuser_default_pref_set) { |
|
| 1347 | + } elseif ($venue == $account->boincuser_default_pref_set) { |
|
| 1361 | 1348 | // User has cleared out the default venue setting |
| 1362 | 1349 | boincwork_set_default_venue(); |
| 1363 | 1350 | } |
@@ -1365,8 +1352,7 @@ discard block |
||
| 1365 | 1352 | if (!$result) { |
| 1366 | 1353 | watchdog('boincwork', 'Error updating project prefs for user @id: @message', array('@id' => $user->id, '@message' => mysqli_error()), WATCHDOG_ERROR); |
| 1367 | 1354 | drupal_set_message(t('Your changes could not be saved. Please contact support!'), 'error'); |
| 1368 | - } |
|
| 1369 | - elseif (!drupal_get_messages('status', FALSE)) { |
|
| 1355 | + } elseif (!drupal_get_messages('status', FALSE)) { |
|
| 1370 | 1356 | // Show this message if the set wasn't created automatically (in which case |
| 1371 | 1357 | // there is a message tailored to that) |
| 1372 | 1358 | drupal_set_message(t('Your preferences have been updated. |
@@ -1519,8 +1505,7 @@ discard block |
||
| 1519 | 1505 | // Upload an avatar (pulled from profile_node_form): |
| 1520 | 1506 | if (!empty($profile_form['field_image'])) { |
| 1521 | 1507 | $form['field_image'] = $profile_form['field_image']; |
| 1522 | - } |
|
| 1523 | - else { |
|
| 1508 | + } else { |
|
| 1524 | 1509 | $form['field_image'] = array( |
| 1525 | 1510 | '#value' => '<div class="form-item">' |
| 1526 | 1511 | . '<label class="placeholder">' |
@@ -1690,8 +1675,7 @@ discard block |
||
| 1690 | 1675 | global $base_url; |
| 1691 | 1676 | if ($edit['language'] != language_default('language')) { |
| 1692 | 1677 | $form_state['redirect'] = $base_url . '/' . $edit['language'] . '/' . $_GET['q']; |
| 1693 | - } |
|
| 1694 | - else { |
|
| 1678 | + } else { |
|
| 1695 | 1679 | $form_state['redirect'] = $base_url . '/' . $_GET['q']; |
| 1696 | 1680 | } |
| 1697 | 1681 | } |
@@ -1882,8 +1866,7 @@ discard block |
||
| 1882 | 1866 | $row[] = drupal_render($form['ignoreblock']['delete'][$key]); |
| 1883 | 1867 | $rows[] = $row; |
| 1884 | 1868 | } |
| 1885 | - } |
|
| 1886 | - else { |
|
| 1869 | + } else { |
|
| 1887 | 1870 | $rows[] = array( |
| 1888 | 1871 | array( |
| 1889 | 1872 | 'data' => bts('You have not added any users to your Ignore List.', array(), NULL, 'boinc:ignore-user-list'), |
@@ -135,8 +135,7 @@ discard block |
||
| 135 | 135 | |
| 136 | 136 | if (!$name) { |
| 137 | 137 | form_set_error('name', bts('Team name is required.', array(), NULL, 'boinc:team-create/edit')); |
| 138 | - } |
|
| 139 | - else { |
|
| 138 | + } else { |
|
| 140 | 139 | require_boinc('boinc_db'); |
| 141 | 140 | if (BoincTeam::lookup_name($name)) { |
| 142 | 141 | form_set_error('name', bts('A team named "@name" already exists.', |
@@ -177,8 +176,7 @@ discard block |
||
| 177 | 176 | if ($boinc_team) { |
| 178 | 177 | $boinc_user = BoincUser::lookup_id($account->boincuser_id); |
| 179 | 178 | user_join_team($boinc_team, $boinc_user); |
| 180 | - } |
|
| 181 | - else { |
|
| 179 | + } else { |
|
| 182 | 180 | drupal_set_message(t('Teams cannot be created at this time. The @project administrators have been notified.', array('@project' => PROJECT))); |
| 183 | 181 | rules_invoke_event('boincteam_create_team_error', $values['name'], variable_get('boinc_admin_mailing_list_subject_tag', '')); |
| 184 | 182 | watchdog('BOINC team', 'BOINC teams cannot be created for an unknown |
@@ -212,8 +210,7 @@ discard block |
||
| 212 | 210 | if (module_exists('pathauto')) { |
| 213 | 211 | module_load_include('inc', 'pathauto', 'pathauto'); |
| 214 | 212 | $node['path'] = pathauto_cleanstring($values['name']); |
| 215 | - } |
|
| 216 | - else { |
|
| 213 | + } else { |
|
| 217 | 214 | drupal_set_message(t('Teams cannot be created at this time. The @project administrators have been notified.', array('@project' => PROJECT))); |
| 218 | 215 | rules_invoke_event('boincteam_create_team_nopathauto_error', $values['name'], variable_get('boinc_admin_mailing_list_subject_tag', '')); |
| 219 | 216 | watchdog('BOINC team', 'BOINC teams require the Pathauto module. Teams |
@@ -381,8 +378,7 @@ discard block |
||
| 381 | 378 | $form['form control tabs'] = array( |
| 382 | 379 | '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), strstr($_GET['q'], '/edit', TRUE)) . '</li>' |
| 383 | 380 | ); |
| 384 | - } |
|
| 385 | - else { |
|
| 381 | + } else { |
|
| 386 | 382 | $form['description'] = array( |
| 387 | 383 | '#prefix' => '<div class="form-item"><label>' . bts('Description', array(), NULL, 'boinc:team-description') . ':</label></div><div class="form-item">', |
| 388 | 384 | '#value' => $default['description'], |
@@ -412,12 +408,10 @@ discard block |
||
| 412 | 408 | |
| 413 | 409 | if ($form_state['storage']['is_boinc_wide']) { |
| 414 | 410 | form_set_error('none', bts('This team is managed by the BOINC-wide teams system and cannot be updated here.', array(), NULL, 'boinc:team-create/edit')); |
| 415 | - } |
|
| 416 | - else { |
|
| 411 | + } else { |
|
| 417 | 412 | if (!$name) { |
| 418 | 413 | form_set_error('name', bts('Team name is required.', array(), NULL, 'boinc:team-create/edit')); |
| 419 | - } |
|
| 420 | - else { |
|
| 414 | + } else { |
|
| 421 | 415 | $team = node_load($form_state['storage']['team_id']); |
| 422 | 416 | if ($name != $team->title) { |
| 423 | 417 | // If changing the name ("title" in Drupal terms), check that the new name is available |
@@ -559,8 +553,7 @@ discard block |
||
| 559 | 553 | |
| 560 | 554 | if (!$values['username']) { |
| 561 | 555 | form_set_error('username', bts('BOINC username is required.', array(), NULL, 'boinc:team-add-admin')); |
| 562 | - } |
|
| 563 | - else { |
|
| 556 | + } else { |
|
| 564 | 557 | // Load user account associated with username |
| 565 | 558 | $account = boincuser_privatemsg_name_lookup($values['username']); |
| 566 | 559 | // Validate the account |
@@ -570,24 +563,21 @@ discard block |
||
| 570 | 563 | '@username' => $account->boincuser_name |
| 571 | 564 | ), |
| 572 | 565 | NULL, 'boinc:team-add-admin')); |
| 573 | - } |
|
| 574 | - elseif (boincteam_is_founder($team_id, $account->uid)) { |
|
| 566 | + } elseif (boincteam_is_founder($team_id, $account->uid)) { |
|
| 575 | 567 | form_set_error('username', bts('@user is the founder of @team! Team founder already have all admin privileges.', |
| 576 | 568 | array( |
| 577 | 569 | '@user' => $account->boincuser_name, |
| 578 | 570 | '@team' => $team->title, |
| 579 | 571 | ), |
| 580 | 572 | NULL, 'boinc:team-add-admin')); |
| 581 | - } |
|
| 582 | - elseif (boincteam_is_admin($team_id, $account->uid)) { |
|
| 573 | + } elseif (boincteam_is_admin($team_id, $account->uid)) { |
|
| 583 | 574 | form_set_error('username', bts('@user is already an admin of @team.', |
| 584 | 575 | array( |
| 585 | 576 | '@user' => $account->boincuser_name, |
| 586 | 577 | '@team' => $team->title, |
| 587 | 578 | ), |
| 588 | 579 | NULL, 'boinc:team-add-admin')); |
| 589 | - } |
|
| 590 | - else { |
|
| 580 | + } else { |
|
| 591 | 581 | $form_state['storage']['boincuser_id'] = $account->boincuser_id; |
| 592 | 582 | $form_state['storage']['boincuser_name'] = $account->boincuser_name; |
| 593 | 583 | } |
@@ -645,8 +635,7 @@ discard block |
||
| 645 | 635 | if (isset($form_state['values'])) { |
| 646 | 636 | $subject = $form_state['values']['subject']; |
| 647 | 637 | $body = $form_state['values']['body']; |
| 648 | - } |
|
| 649 | - else { |
|
| 638 | + } else { |
|
| 650 | 639 | $subject = ''; |
| 651 | 640 | $body = ''; |
| 652 | 641 | } |