BOINC / boinc

html/user/buda.php

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -198,7 +198,7 @@ 
     form_input_hidden('app', $app);
     form_input_hidden('action', 'variant_action');
     form_input_text("Plan class$pc", 'variant');
-    form_select("Dockerfile$sb", 'dockerfile', $sbitems);
+    form_select("dockerfile$sb", 'dockerfile', $sbitems);
     form_select2_multi("Application files$sb", 'app_files', $sbitems, null);
     form_input_text(
         'Input file names<br><small>Space-separated</small>',
@@ -383,7 +383,7 @@ 
     // Note: we don't currently allow indirect file access.
     // If we did, we'd need to create job.toml to mount project dir
 
-    app_list("Variant $variant added for app $app.");
+    app_list("variant $variant added for app $app.");
 }
 
 function variant_delete() {
@@ -410,7 +410,7 @@ 
         if ($ret) {
             error_page("delete failed");
         }
-        $notice = "Variant $variant of app $app removed.";
+        $notice = "variant $variant of app $app removed.";
         app_list($notice);
     } else {
         page_head("Confirm");
@@ -440,7 +440,7 @@ 
         if ($ret) {
             error_page('delete failed');
         }
-        $notice = "App $app removed.";
+        $notice = "app $app removed.";
         app_list($notice);
     } else {
         page_head('Confirm');
@@ -505,7 +505,7 @@ 
         }
         $dir = "$buda_root/$name";
         if (file_exists($dir)) {
-            error_page("App $name already exists.");
+            error_page("app $name already exists.");
         }
         mkdir($dir);
         $desc->user_id = $user->id;

Spacing +9 added lines, -9 removed lines

@@ -54,7 +54,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -256,7 +256,7 @@ 
     //
     $x = "<input_template>\n";
     $ninfiles = 1 + count($variant_desc->input_file_names) + count($variant_desc->app_files);
-    for ($i=0; $i<$ninfiles; $i++) {
+    for ($i = 0; $i < $ninfiles; $i++) {
         $x .= "   <file_info>\n      <sticky/>\n      <no_delete/>\n      <executable/>\n   </file_info>\n";
     }
     $x .= "   <workunit>\n";
@@ -286,7 +286,7 @@ 
     );
 
     $x .= sprintf("      <max_delay>%f</max_delay>\n",
-        $variant_desc->max_delay * 86400.
+        $variant_desc->max_delay*86400.
     );
 
     $x .= "   </workunit>\n<input_template>\n";
@@ -467,8 +467,8 @@ 
     }
 }
 
-function app_form($desc=null) {
-    page_head_select2($desc?"Edit BUDA app $desc->name":'Create BUDA app');
+function app_form($desc = null) {
+    page_head_select2($desc ? "Edit BUDA app $desc->name" : 'Create BUDA app');
     form_start('buda.php');
     form_input_hidden('action', 'app_action');
     if ($desc) {
@@ -479,22 +479,22 @@ 
         form_input_text('Internal name<br><small>No spaces</small>', 'name');
     }
     form_input_text('User-visible name', 'long_name',
-        $desc?$desc->long_name:null
+        $desc ? $desc->long_name : null
     );
     form_input_textarea(
         'Description<br><small>... of what the app does and of the research goals</small>',
         'description',
-        $desc?$desc->description:null
+        $desc ? $desc->description : null
     );
     form_select2_multi('Science keywords',
         'sci_kw',
         keyword_select_options(KW_CATEGORY_SCIENCE),
-        $desc?$desc->sci_kw:null
+        $desc ? $desc->sci_kw : null
     );
     form_input_text(
         'URL of web page describing app',
         'url',
-        $desc?$desc->url:''
+        $desc ? $desc->url : ''
     );
     // don't include location keywords;
     // various people may submit jobs to this app

html/user/show_apps.php

Spacing +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
             $desc->long_name,
             $desc->description,
             kw_array_to_str($desc->sci_kw),
-            empty($desc->url)?'':"<a href=$desc->url>View</a>",
+            empty($desc->url) ? '' : "<a href=$desc->url>View</a>",
             'Yes'
         );
     }

html/inc/keywords.inc

Spacing +63 added lines, -63 removed lines

@@ -24,72 +24,72 @@ 
 define('KW_CATEGORY_SCIENCE', 0);
 define('KW_CATEGORY_LOC', 1);
 
-define('KW_ASTRONOMY',      1);
-define('KW_SETI',           2);
-define('KW_PULSARS',        3);
-define('KW_GW',             4);
-define('KW_COSMOLOGY',      5);
-define('KW_PHYSICS',        6);
+define('KW_ASTRONOMY', 1);
+define('KW_SETI', 2);
+define('KW_PULSARS', 3);
+define('KW_GW', 4);
+define('KW_COSMOLOGY', 5);
+define('KW_PHYSICS', 6);
 define('KW_PARTICLE_PHYSICS', 7);
-define('KW_NANOSCIENCE',    8);
-define('KW_BIOMED',         9);
+define('KW_NANOSCIENCE', 8);
+define('KW_BIOMED', 9);
 define('KW_DRUG_DISCOVERY', 10);
-define('KW_PROTEINS',       11);
-define('KW_GENETICS',       12);
-define('KW_DISEASE',        13);
-define('KW_CANCER',         14);
-define('KW_MATH_CS',        15);
-define('KW_AI',             16);
-define('KW_OCEANIA',        17);
-define('KW_AUSTRALIA',      18);
+define('KW_PROTEINS', 11);
+define('KW_GENETICS', 12);
+define('KW_DISEASE', 13);
+define('KW_CANCER', 14);
+define('KW_MATH_CS', 15);
+define('KW_AI', 16);
+define('KW_OCEANIA', 17);
+define('KW_AUSTRALIA', 18);
 
-define('KW_EUROPE',         20);
-define('KW_GERMANY',        21);
-define('KW_ASIA',           22);
-define('KW_AMERICAS',       23);
-define('KW_US',             24);
-define('KW_UCB',            25);
-define('KW_AEI',            26);
-define('KW_CERN',           27);
-define('KW_UW',             28);
-define('KW_EARTH_SCI',      29);
-define('KW_SPAIN',          30);
-define('KW_SAN_JORGE',      31);
-define('KW_NUMBER_THEORY',  32);
-define('KW_CRYPTO',         33);
-define('KW_ENV_RESEARCH',   34);
-define('KW_CLIMATE',        35);
-define('KW_CZECH',          36);
+define('KW_EUROPE', 20);
+define('KW_GERMANY', 21);
+define('KW_ASIA', 22);
+define('KW_AMERICAS', 23);
+define('KW_US', 24);
+define('KW_UCB', 25);
+define('KW_AEI', 26);
+define('KW_CERN', 27);
+define('KW_UW', 28);
+define('KW_EARTH_SCI', 29);
+define('KW_SPAIN', 30);
+define('KW_SAN_JORGE', 31);
+define('KW_NUMBER_THEORY', 32);
+define('KW_CRYPTO', 33);
+define('KW_ENV_RESEARCH', 34);
+define('KW_CLIMATE', 35);
+define('KW_CZECH', 36);
 define('KW_CHARLES_PRAGUE', 37);
-define('KW_RECHENKRAFT',    38);
-define('KW_RHEINMAIN',      39);
-define('KW_HUNGARY',        40);
-define('KW_IRELAND',        41);
-define('KW_UC_DUBLIN',      42);
-define('KW_POLAND',         43);
-define('KW_RUSSIA',         44);
+define('KW_RECHENKRAFT', 38);
+define('KW_RHEINMAIN', 39);
+define('KW_HUNGARY', 40);
+define('KW_IRELAND', 41);
+define('KW_UC_DUBLIN', 42);
+define('KW_POLAND', 43);
+define('KW_RUSSIA', 44);
 define('KW_SW_STATE_RUSSIA', 45);
-define('KW_RAS',            46);
-define('KW_PRBB',           47);
-define('KW_UK',             48);
-define('KW_OXFORD',         49);
-define('KW_CHINA',          50);
-define('KW_U_DAYTON',       51);
-define('KW_WRIGHT_STATE',   52);
-define('KW_USC',            53);
-define('KW_FULLERTON',      54);
-define('KW_ARIZONA_STATE',  55);
-define('KW_U_ILLINOIS',     56);
-define('KW_U_WARSAW',       57);
-define('KW_RPI',            58);
-define('KW_INTERNATIONAL',  59);
-define('KW_UND',            60);
-define('KW_HOLLAND',        61);
-define('KW_CHEMISTRY',      62);
-define('KW_GAMES',          63);
-define('KW_VIRUS',          64);
-define('KW_FRANCE',         65);
-define('KW_CANADA',         66);
+define('KW_RAS', 46);
+define('KW_PRBB', 47);
+define('KW_UK', 48);
+define('KW_OXFORD', 49);
+define('KW_CHINA', 50);
+define('KW_U_DAYTON', 51);
+define('KW_WRIGHT_STATE', 52);
+define('KW_USC', 53);
+define('KW_FULLERTON', 54);
+define('KW_ARIZONA_STATE', 55);
+define('KW_U_ILLINOIS', 56);
+define('KW_U_WARSAW', 57);
+define('KW_RPI', 58);
+define('KW_INTERNATIONAL', 59);
+define('KW_UND', 60);
+define('KW_HOLLAND', 61);
+define('KW_CHEMISTRY', 62);
+define('KW_GAMES', 63);
+define('KW_VIRUS', 64);
+define('KW_FRANCE', 65);
+define('KW_CANADA', 66);
 
 $job_keywords = array();
 
@@ -330,7 +330,7 @@ 
     }
 }
 
-function kw_options($id, $indent='') {
+function kw_options($id, $indent = '') {
     global $job_keywords;
     $kw = $job_keywords[$id];
     $opts = [[$id, "$indent$kw->name"]];
@@ -347,7 +347,7 @@ 
     return $kw->name;
 }
 
-function kw_array_to_str($kws, $sep='<br>') {
+function kw_array_to_str($kws, $sep = '<br>') {
     $x = array_map('strval', $kws);
     $x = array_map('kw_id_to_name', $x);
     return implode($sep, $x);

html/user/manage_project.php

Spacing +6 added lines, -6 removed lines

@@ -36,7 +36,7 @@ 
             $app = BoincApp::lookup_id($ua->app_id);
             $names[] = $app->name;
         }
-        $sub = $names?implode(', ', $names):'---';
+        $sub = $names ?implode(', ', $names) : '---';
     }
     if ($u->manage_all) {
         $admin = 'All applications';
@@ -47,7 +47,7 @@ 
             $app = BoincApp::lookup_id($ua->app_id);
             $names[] = $app->name;
         }
-        $admin = $names?implode(', ', $names):'---';
+        $admin = $names ?implode(', ', $names) : '---';
     }
 
     table_row(
@@ -59,7 +59,7 @@ 
         $admin,
         $u->quota,
         $u->max_jobs_in_progress,
-        ($u->logical_start_time > time())?local_time_str($u->logical_start_time):'---'
+        ($u->logical_start_time > time()) ?local_time_str($u->logical_start_time) : '---'
     );
 }
 
@@ -184,18 +184,18 @@ 
     $manage_apps = array_map('intval', $manage_apps);
     foreach ($apps as $app) {
         $s = in_array($app->id, $submit_apps);
-        $m = in_array($app->id, $manage_apps)?1:0;
+        $m = in_array($app->id, $manage_apps) ? 1 : 0;
         if ($s || $m) {
             BoincUserSubmitApp::insert(
                 "(user_id, app_id, manage) values ($user_id, $app->id, $m)"
             );
         }
     }
-    $quota = (double) get_str('quota');
+    $quota = (double)get_str('quota');
     if ($quota != $us->quota) {
         $us->update("quota=$quota");
     }
-    $mj = (int) get_str('max_jobs_in_progress');
+    $mj = (int)get_str('max_jobs_in_progress');
     if ($mj != $us->max_jobs_in_progress) {
         $us->update("max_jobs_in_progress=$mj");
     }

html/inc/bootstrap.inc

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -210,7 +210,7 @@
                                 ];
                             } else {
                                 $x[] = [
-                                    "Manage $app->name",
+                                    "manage $app->name",
                                     "manage_project.php"
                                 ];
                             }

Spacing +23 added lines, -23 removed lines

@@ -141,12 +141,12 @@ 
         // prefix for links; needed for pages not in top dir
     $user,
         // logged-in user, if any
-    $fixed=false,
+    $fixed = false,
         // if true, navbar is fixed at top of page.
         // NOTE: if you do this, you must set a global var $fixed_navbar
         // to true at compile time
         // (it needs to be set when page_head() is called).
-    $inverse=false
+    $inverse = false
         // white on black?
 ) {
     $master_url = master_url();
@@ -246,7 +246,7 @@ 
 // output a panel.
 // $content_func is a function that generates the panel contents
 //
-function panel($title, $content_func, $class="panel-primary", $body_class="") {
+function panel($title, $content_func, $class = "panel-primary", $body_class = "") {
     echo sprintf('<div class="panel %s">
         ', $class
     );
@@ -273,7 +273,7 @@ 
 // $left_width is the width of left column in 1/12 units.
 // $arg is passed to the functions.
 //
-function grid($top_func, $left_func, $right_func, $left_width=6, $arg=null) {
+function grid($top_func, $left_func, $right_func, $left_width = 6, $arg = null) {
     echo '
         <div class="container-fluid">
     ';
@@ -288,7 +288,7 @@ 
             </div>
         ';
     }
-    $right_width = 12-$left_width;
+    $right_width = 12 - $left_width;
     echo '
         <div class="row">
         <div class="col-sm-'.$left_width.'">
@@ -312,7 +312,7 @@ 
 //      use extra = "name=x"
 //      call forum_focus(x, foo) after defining the field
 //
-function form_start($action, $method='get', $extra='') {
+function form_start($action, $method = 'get', $extra = '') {
     echo sprintf(
         '<div class="container-fluid">
         <form class="form-horizontal" method="%s" action="%s" %s>'
@@ -344,7 +344,7 @@ 
 // just the input field
 //
 function form_input_text_field(
-    $name, $value='', $type='text', $attrs='', $extra=''
+    $name, $value = '', $type = 'text', $attrs = '', $extra = ''
 ) {
     return sprintf(
         '<input %s type="%s" class="form-control" name="%s" value="%s">%s',
@@ -355,7 +355,7 @@ 
 // the whole row
 //
 function form_input_text(
-    $label, $name, $value='', $type='text', $attrs='', $extra=''
+    $label, $name, $value = '', $type = 'text', $attrs = '', $extra = ''
 ) {
     echo sprintf('
         <div class="form-group">
@@ -383,7 +383,7 @@ 
     );
 }
 
-function form_input_textarea($label, $name, $value='', $nrows=4) {
+function form_input_textarea($label, $name, $value = '', $nrows = 4) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -400,7 +400,7 @@ 
 // $items is either a string of <option> elements,
 // or an array of [value, name] pairs
 //
-function form_select($label, $name, $items, $selected=null) {
+function form_select($label, $name, $items, $selected = null) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -413,7 +413,7 @@ 
         foreach ($items as $i) {
             echo sprintf(
                 '<option %s value=%s>%s</option>',
-                ($i[0]==$selected)?'selected':'',
+                ($i[0] == $selected) ? 'selected' : '',
                 $i[0], $i[1]
             );
         }
@@ -426,7 +426,7 @@ 
 // same, for multiple select.
 // $selected, if non-null, is a list of selected values
 //
-function form_select_multiple($label, $name, $items, $selected=null, $size=0) {
+function form_select_multiple($label, $name, $items, $selected = null, $size = 0) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -438,7 +438,7 @@ 
     foreach ($items as $i) {
         echo sprintf(
             '<option %s value=%s>%s</option>',
-            ($selected && in_array($i[0], $selected))?'selected':'',
+            ($selected && in_array($i[0], $selected)) ? 'selected' : '',
             $i[0], $i[1]
         );
     }
@@ -447,12 +447,12 @@ 
 
 // return a list of strings for checkbox items
 //
-function checkbox_item_strings($items, $attrs='') {
+function checkbox_item_strings($items, $attrs = '') {
     $x = [];
     foreach ($items as $i) {
         $x[] = sprintf('<input %s type="checkbox" name="%s" %s> %s
             ',
-            $attrs, $i[0], $i[2]?"checked":"", $i[1]
+            $attrs, $i[0], $i[2] ? "checked" : "", $i[1]
         );
     }
     return $x;
@@ -460,7 +460,7 @@ 
 
 // $items is list of (name, label, checked)
 //
-function form_checkboxes($label, $items, $attrs='') {
+function form_checkboxes($label, $items, $attrs = '') {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s">%s</label>
@@ -479,7 +479,7 @@ 
 //
 function form_radio_buttons(
     $label, $name, $items, $selected,
-    $assign_ids=false       // assign IDs to buttons based on names
+    $assign_ids = false       // assign IDs to buttons based on names
 ) {
     echo sprintf('
         <div class="form-group">
@@ -489,7 +489,7 @@ 
         FORM_LEFT_CLASS, $label, FORM_RIGHT_CLASS
     );
     foreach ($items as $i) {
-        $checked = ($selected == $i[0])?"checked":"";
+        $checked = ($selected == $i[0]) ? "checked" : "";
         if ($assign_ids) {
             $id = sprintf('id="%s_%s"', $name, $i[0]);
         } else {
@@ -527,7 +527,7 @@ 
 ';
 }
 
-function form_submit($text, $attrs='') {
+function form_submit($text, $attrs = '') {
     form_general(
         "",
         sprintf(
@@ -537,7 +537,7 @@ 
     );
 }
 
-function form_checkbox($label, $name, $checked=false) {
+function form_checkbox($label, $name, $checked = false) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s">%s</label>
@@ -549,7 +549,7 @@ 
               <input type="checkbox" name="%s" %s>
            </div>
         </div>
-        ', $name, $checked?"checked":""
+        ', $name, $checked ? "checked" : ""
     );
 }
 
@@ -577,7 +577,7 @@ 
 // $selected is the list of selected values.
 // $extra is e.g. id=foo
 //
-function form_select2_multi($label, $name, $items, $selected=null, $extra='') {
+function form_select2_multi($label, $name, $items, $selected = null, $extra = '') {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -589,7 +589,7 @@ 
     foreach ($items as $i) {
         echo sprintf(
             '<option %s value=%s>%s</option>',
-            ($selected && in_array($i[0], $selected))?'selected':'',
+            ($selected && in_array($i[0], $selected)) ? 'selected' : '',
             $i[0], $i[1]
         );
     }

html/inc/submit_util.inc

Spacing +4 added lines, -4 removed lines

@@ -178,7 +178,7 @@ 
     foreach ($res_in_prog as $res) {
         $wus_in_prog[$res->workunitid] = true;
     }
-    unset($res_in_progress);    // does this do anything?
+    unset($res_in_progress); // does this do anything?
 
     $fp_total = 0;
     $fp_done = 0;
@@ -320,7 +320,7 @@ 
 // get the total size of output files of a batch
 //
 function batch_output_file_size($batchid) {
-    $batch_td_size=0;
+    $batch_td_size = 0;
     $wus = BoincWorkunit::enum("batch=$batchid");
     $fanout = parse_config(get_config(), "<uldl_dir_fanout>");
     $upload_dir = parse_config(get_config(), "<upload_dir>");
@@ -350,7 +350,7 @@ 
 }
 
 function boinc_get_wu_output_files_url($user, $wu_id) {
-    $auth_str =  md5($user->authenticator.$wu_id);
+    $auth_str = md5($user->authenticator.$wu_id);
     return "get_output.php?cmd=workunit_files&wu_id=$wu_id&auth_str=$auth_str";
 }
 
@@ -384,7 +384,7 @@ 
     if (!file_exists($path)) return null;
     $x = file_get_contents($path);
     $n = sscanf($x, "%s %d", $md5, $size);
-    if ($n != 2 || strlen($md5)!=32) {
+    if ($n != 2 || strlen($md5) != 32) {
         return null;
     }
     return [$md5, $size];

html/inc/boinc_db.inc

Indentation +3 added lines, -3 removed lines

@@ -362,12 +362,12 @@
         $db = BoincDb::get();
         return $db->enum('result', 'BoincResult', $where_clause);
     }
-	static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause=null) {
         $db = BoincDb::get();
-		return $db->enum_fields(
+        return $db->enum_fields(
             'result', 'BoincResult', $fields, $where_clause, $order_clause
         );
-	}
+    }
     function update($clause) {
         $db = BoincDb::get();
         return $db->update($this, 'result', $clause);

Spacing +21 added lines, -21 removed lines

@@ -44,8 +44,8 @@ 
 // close() closes the connection.
 
 class BoincDb {
-    static $instance;       // a DbConn object, or null
-    static $dbnum;          // which replica we're connected to
+    static $instance; // a DbConn object, or null
+    static $dbnum; // which replica we're connected to
 
     // connect to DB $dbnum (0, 1, ...)
     // If the requested DB doesn't exist or connection fails, connect to DB 0.
@@ -56,7 +56,7 @@ 
         self::$instance = null;
         $config = get_config();
         if ($dbnum) {
-            $r = $dbnum==1?'':strval($dbnum);
+            $r = $dbnum == 1 ? '' : strval($dbnum);
             $host = parse_config($config, sprintf('<replica%s_db_host>', $r));
             $name = parse_config($config, sprintf('<replica%s_db_name>', $r));
             $user = parse_config($config, sprintf('<replica%s_db_user>', $r));
@@ -204,11 +204,11 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'user', $clause);
     }
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('user', 'BoincUser', $where_clause, $order_clause);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields(
             'user', 'BoincUser', $fields, $where_clause, $order_clause
@@ -258,7 +258,7 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'team', $clause);
     }
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('team', 'BoincTeam', $where_clause, $order_clause);
     }
@@ -283,7 +283,7 @@ 
         $db = BoincDb::get();
         return $db->max('team', $field);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields(
             'team', 'BoincTeam', $fields, $where_clause, $order_clause
@@ -321,11 +321,11 @@ 
         $db = BoincDb::get();
         return $db->delete($this, 'host');
     }
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('host', 'BoincHost', $where_clause, $order_clause);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields(
             'host', 'BoincHost', $fields, $where_clause, $order_clause
@@ -362,7 +362,7 @@ 
         $db = BoincDb::get();
         return $db->enum('result', 'BoincResult', $where_clause);
     }
-	static function enum_fields($fields, $where_clause, $order_clause=null) {
+	static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
 		return $db->enum_fields(
             'result', 'BoincResult', $fields, $where_clause, $order_clause
@@ -411,7 +411,7 @@ 
         $db = BoincDb::get();
         return $db->enum('workunit', 'BoincWorkunit', $where_clause);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields('workunit', 'BoincWorkunit', $fields, $where_clause, $order_clause);
     }
@@ -453,7 +453,7 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'app', $clause);
     }
-    static function sum($field, $clause=null) {
+    static function sum($field, $clause = null) {
         $db = BoincDb::get();
         return $db->sum('app', $field, $clause);
     }
@@ -511,11 +511,11 @@ 
         $db = BoincDb::get();
         return $db->insert('profile', $clause);
     }
-    static function enum($where_clause=null, $order_clause=null) {
+    static function enum($where_clause = null, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('profile', 'BoincProfile', $where_clause, $order_clause);
     }
-    static function enum_fields($fields, $where_clause=null, $order_clause=null) {
+    static function enum_fields($fields, $where_clause = null, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields('profile', 'BoincProfile', $fields, $where_clause, $order_clause);
     }
@@ -910,12 +910,12 @@ 
         return $db->enum('consent', 'BoincConsent', $where_clause);
     }
 
-    static function insert ($clause) {
+    static function insert($clause) {
         $db = BoincDb::get();
         return $db->insert('consent', $clause);
     }
 
-    static function update ($clause) {
+    static function update($clause) {
         $db = BoincDb::get();
         return $db->update_aux('consent', $clause);
     }
@@ -940,17 +940,17 @@ 
         return $db->lookup('consent_type', 'BoincConsentType', $clause);
     }
 
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('consent_type', 'BoincConsentType', $where_clause, $order_clause);
     }
 
-    static function insert ($clause) {
+    static function insert($clause) {
         $db = BoincDb::get();
         return $db->insert('consent_type', $clause);
     }
 
-    static function update ($clause) {
+    static function update($clause) {
         $db = BoincDb::get();
         return $db->update_aux('consent_type', $clause);
     }
@@ -976,7 +976,7 @@ 
         return $db->lookup('latest_consent', 'BoincLatestConsent', $clause);
     }
 
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('latest_consent', 'BoincLatestConsent', $where_clause, $order_clause);
     }
@@ -987,7 +987,7 @@ 
 // apply this to any user-supplied strings used in queries
 //
 function boinc_real_escape_string($x) {
-    if (version_compare(phpversion(),"4.3.0")>=0) {
+    if (version_compare(phpversion(), "4.3.0") >= 0) {
         return BoincDb::escape_string($x);
     } else {
         $x = str_replace("'", "\'", $x);

html/user/job_fpops.php

Spacing +3 added lines, -3 removed lines

@@ -35,7 +35,7 @@ 
             $host = BoincHost::lookup_id($res->hostid);
             $hosts[$res->hostid] = $host;
         }
-        $fpops = $res->cpu_time * $host->p_fpops;
+        $fpops = $res->cpu_time*$host->p_fpops;
         $samples[] = $res->cpu_time;
         //$fpops /= 1e9;
         //echo "$res->cpu_time $fpops\n";
@@ -45,11 +45,11 @@ 
 }
 
 function show($samples) {
-    $x = [0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0];
+    $x = [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0];
     foreach ($samples as $s) {
         $x[(int)log10($s)] += 1;
     }
-    for ($i=0; $i<16; $i++) {
+    for ($i = 0; $i < 16; $i++) {
         echo sprintf("%d: %d\n", $i, $x[$i]);
     }
 }

html/user/buda_submit.php

Spacing +7 added lines, -7 removed lines

@@ -84,7 +84,7 @@ 
 //
 function unzip_batch_file($user, $batch_file) {
     @mkdir("../../buda_batches");
-    for ($i=0; $i<1000; $i++) {
+    for ($i = 0; $i < 1000; $i++) {
         $batch_dir = "../../buda_batches/$i";
         $batch_dir_name = $i;
         $ret = @mkdir($batch_dir);
@@ -135,7 +135,7 @@ 
         }
         $job_files = [];
         $cmdline = '';
-        foreach(scandir("$batch_dir/$fname") as $f2) {
+        foreach (scandir("$batch_dir/$fname") as $f2) {
             if ($f2[0] == '.') continue;
             if ($f2 == 'cmdline') {
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -185,7 +185,7 @@ 
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
     $n = count($batch_desc->shared_files);
     $batch_desc->shared_files_phys_names = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -195,7 +195,7 @@ 
     foreach ($batch_desc->jobs as $job) {
         $n = count($batch_desc->unshared_files);
         $job->phys_names = [];
-        for ($i=0; $i<$n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $path = sprintf('%s/%s/%s',
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
             );
@@ -243,7 +243,7 @@ 
     }
     $wrapper_cmdline = sprintf('"--dockerfile %s %s %s"',
         $variant_desc->dockerfile,
-        $wrapper_verbose?'--verbose':'',
+        $wrapper_verbose ? '--verbose' : '',
         $cmdline
     );
     $cmd = sprintf(
@@ -289,7 +289,7 @@ 
     $max_runtime_days = (double)$max_runtime_days;
     if ($max_runtime_days <= 0) error_page('bad runtime limit');
     if ($max_runtime_days > 100) error_page('bad runtime limit');
-    $max_fpops = $max_runtime_days * 3.5e9 * 86400;
+    $max_fpops = $max_runtime_days*3.5e9*86400;
 
     $exp_runtime_days = get_str('exp_runtime_days');
     if (!is_numeric($exp_runtime_days)) error_page('bad expected runtime');
@@ -299,7 +299,7 @@ 
     if ($exp_runtime_days > $max_runtime_days) {
         error_page('exp must be < max runtime');
     }
-    $exp_fpops = $exp_runtime_days * 3.5e9 * 86400;
+    $exp_fpops = $exp_runtime_days*3.5e9*86400;
 
     $app_desc = get_buda_desc($app);