BOINC / boinc

html/user/forum_index.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -79,7 +79,7 @@
         if ($first) {
             $first = false;
             echo "<p>";
-            echo forum_title($category, NULL, NULL);
+            echo forum_title($category, null, null);
             echo "<p>";
             show_mark_as_read_button($user);
             start_table('table-striped');

Spacing +2 added lines, -2 removed lines

@@ -69,7 +69,7 @@ 
         project_forum_index_intro();
     }
 
-    if (defined('FORUM_QA_MERGED_MODE') && FORUM_QA_MERGED_MODE){
+    if (defined('FORUM_QA_MERGED_MODE') && FORUM_QA_MERGED_MODE) {
         $categories = BoincCategory::enum("true order by orderID");
     } else {
         echo "<p>"
@@ -210,5 +210,5 @@ 
 } else {
     main($user);
 }
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>

Braces +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
         project_forum_index_intro();
     }
 
-    if (defined('FORUM_QA_MERGED_MODE') && FORUM_QA_MERGED_MODE){
+    if (defined('FORUM_QA_MERGED_MODE') && FORUM_QA_MERGED_MODE) {
         $categories = BoincCategory::enum("true order by orderID");
     } else {
         echo "<p>"

html/user/user_permissions.php

Spacing +6 added lines, -6 removed lines

@@ -27,7 +27,7 @@ 
     start_table('table-striped');
 
     $x = ['User'];
-    for ($i=0; $i<S_NFLAGS; $i++) {
+    for ($i = 0; $i < S_NFLAGS; $i++) {
         $x[] = $special_user_bitfield[$i];
     }
     $x[] = '';
@@ -42,9 +42,9 @@ 
             $pref->userid
         );
         $x = ["$user->name ($user->id)"];
-        for ($j=0; $j<S_NFLAGS; $j++) {
+        for ($j = 0; $j < S_NFLAGS; $j++) {
             $bit = substr($pref->special_user, $j, 1);
-            $c = ($bit == 1)?"checked":"";
+            $c = ($bit == 1) ? "checked" : "";
             $x[] = sprintf(
                 '<input type="checkbox" name="role%d" value="1" %s>',
                 $j, $c
@@ -57,7 +57,7 @@ 
 
     echo '<form action="user_permissions.php" method="POST">';
     $x = ['Add User ID: <input type="text" name="userid" size="6">'];
-    for ($j=0; $j<S_NFLAGS; $j++) {
+    for ($j = 0; $j < S_NFLAGS; $j++) {
         $x[] = sprintf(
             '<input type="checkbox" name="role%d" value="1">',
             $j
@@ -77,7 +77,7 @@ 
     if (!$user) error_page('no user');
     BoincForumPrefs::lookup($user);
 
-    for ($i=0; $i<S_NFLAGS; $i++) {
+    for ($i = 0; $i < S_NFLAGS; $i++) {
         if (post_int("role$i", true) == 1) {
             $bitset .= '1';
             echo "<br> setting $i";
@@ -103,5 +103,5 @@ 
     user_permissions_form();
 }
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>

html/ops/botnet.php

Spacing +1 added lines, -1 removed lines

@@ -7,7 +7,7 @@
 //      add other criteria like # of countries (based on IP addr)
 //      consider only hosts with recent last RPC time
 
-define ('MAX_HOSTS', 100);
+define('MAX_HOSTS', 100);
 
 require_once('../inc/boinc_db.inc');
 

html/user/forum_reply.php

Spacing +8 added lines, -8 removed lines

@@ -56,7 +56,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -71,7 +71,7 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
+if ($content && (!$preview)) {
     check_tokens($logged_in_user->authenticator);
     if (!akismet_check($logged_in_user, $content)) {
         $warning = tra("Your post has been flagged as spam by the Akismet anti-spam system. Please modify your text and try again.");
@@ -93,7 +93,7 @@ 
     }
 }
 
-page_head(tra("Post to thread")." '$thread->title'",'','','', $bbcode_js);
+page_head(tra("Post to thread")." '$thread->title'", '', '', '', $bbcode_js);
 
 if ($parent_post) {
     echo sprintf(
@@ -161,7 +161,7 @@ 
     $x2 .= " method=\"post\" name=\"post\" onsubmit=\"return checkForm(this)\">\n";
     $x2 .= form_tokens($logged_in_user->authenticator);
     $x2 .= $bbcode_html."<textarea class=\"form-control\" name=\"content\" rows=\"18\">";
-    $no_quote = get_int("no_quote", true)==1;
+    $no_quote = get_int("no_quote", true) == 1;
     if ($preview) {
         $x2 .= htmlspecialchars($content);
     } else if (!$no_quote) {
@@ -170,9 +170,9 @@ 
         }
     }
     if (!$logged_in_user->prefs->no_signature_by_default) {
-        $enable_signature='checked="true"';
+        $enable_signature = 'checked="true"';
     } else {
-        $enable_signature="";
+        $enable_signature = "";
     }
     $x2 .= sprintf('</textarea><p> </p>
         <input class="btn btn-sm" %s type="submit" name="preview" value="%s">
@@ -200,11 +200,11 @@ 
     return sprintf(
         'In reply to %s\'s message of %s:
         [quote]%s[/quote]',
-        $user?$user->name:'unknown user',
+        $user ? $user->name : 'unknown user',
         date_str($post->timestamp),
         htmlspecialchars($post->content)
     );
 }
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

Braces +2 added lines, -2 removed lines

@@ -56,7 +56,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -71,7 +71,7 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
+if ($content && (!$preview)) {
     check_tokens($logged_in_user->authenticator);
     if (!akismet_check($logged_in_user, $content)) {
         $warning = tra("Your post has been flagged as spam by the Akismet anti-spam system. Please modify your text and try again.");

html/user/forum_post.php

Spacing +10 added lines, -10 removed lines

@@ -56,10 +56,10 @@ 
 $preview = post_str("preview", true);
 $warning = null;
 
-if ($content && $title && (!$preview)){
+if ($content && $title && (!$preview)) {
     if (post_str('add_signature', true)) {
-        $add_signature = true;    // set a flag and concatenate later
-    }  else {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
         $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
@@ -74,14 +74,14 @@ 
             if (post_str('subscribe', true)) {
                 BoincSubscription::replace($logged_in_user->id, $thread->id);
             }
-            header('Location: forum_thread.php?id=' . $thread->id);
+            header('Location: forum_thread.php?id='.$thread->id);
         } else {
             error_page("Can't create thread.  $forum_error");
         }
     }
 }
 
-page_head(tra("Create new thread"),'','','', $bbcode_js);
+page_head(tra("Create new thread"), '', '', '', $bbcode_js);
 show_forum_header($logged_in_user);
 
 if ($warning) {
@@ -122,7 +122,7 @@ 
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
 }
 
-if ($force_title && $title){
+if ($force_title && $title) {
     row2(
         tra("Title"),
         sprintf(
@@ -136,7 +136,7 @@ 
     row2(
         tra("Title").$submit_help,
         sprintf('<input type="text" class="form-control" name="title" value="%s">',
-            $title?htmlspecialchars($title):''
+            $title ?htmlspecialchars($title) : ''
         ),
         null, FORUM_LH_PCT
     );
@@ -147,7 +147,7 @@ 
     sprintf(
         '%s <textarea class="form-control" name="content" rows="12" cols="80">%s</textarea>',
         $bbcode_html,
-        $content?htmlspecialchars($content):''
+        $content ?htmlspecialchars($content) : ''
     ),
     null, FORUM_LH_PCT
 );
@@ -155,7 +155,7 @@ 
 if (!$logged_in_user->prefs->no_signature_by_default) {
     $enable_signature = 'checked="true"';
 } else {
-    $enable_signature='';
+    $enable_signature = '';
 }
 
 if (is_news_forum($forum)) {
@@ -195,5 +195,5 @@ 
 
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

Braces +3 added lines, -3 removed lines

@@ -56,10 +56,10 @@ 
 $preview = post_str("preview", true);
 $warning = null;
 
-if ($content && $title && (!$preview)){
+if ($content && $title && (!$preview)) {
     if (post_str('add_signature', true)) {
         $add_signature = true;    // set a flag and concatenate later
-    }  else {
+    } else {
         $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
@@ -122,7 +122,7 @@ 
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
 }
 
-if ($force_title && $title){
+if ($force_title && $title) {
     row2(
         tra("Title"),
         sprintf(

html/inc/pm.inc

Spacing +12 added lines, -12 removed lines

@@ -51,7 +51,7 @@ 
     return $x;
 }
 
-function pm_team_form($user, $teamid, $error=null) {
+function pm_team_form($user, $teamid, $error = null) {
     global $bbcode_html, $bbcode_js;
     $team = BoincTeam::lookup_id($teamid);
     if (!$team) {
@@ -61,7 +61,7 @@ 
         error_page("not admin");
     }
 
-    page_head(tra("Send message to team"),'','','', $bbcode_js);
+    page_head(tra("Send message to team"), '', '', '', $bbcode_js);
 
     $subject = post_str("subject", true);
     $content = post_str("content", true);
@@ -113,7 +113,7 @@ 
 function pm_form_page($replyto, $userid, $error = null) {
     global $bbcode_html, $bbcode_js;
     global $g_logged_in_user;
-    page_head(tra("Send private message"),'','','', $bbcode_js);
+    page_head(tra("Send private message"), '', '', '', $bbcode_js);
 
     if (post_str("preview", true) == tra("Preview")) {
         $content = post_str("content", true);
@@ -137,7 +137,7 @@ 
         if (!$user) {
             error_page("Sender no longer exists");
         }
-        $writeto = UNIQUE_USER_NAME?$user->name:$userid." (".$user->name.")";
+        $writeto = UNIQUE_USER_NAME ? $user->name : $userid." (".$user->name.")";
         $subject = $message->subject;
         if (substr($subject, 0, 3) != "re:") {
             $subject = "re: ".$subject;
@@ -147,15 +147,15 @@ 
         if (!$user) {
             error_page("Sender no longer exists");
         }
-        $writeto = UNIQUE_USER_NAME?$user->name:$userid." (".$user->name.")";
+        $writeto = UNIQUE_USER_NAME ? $user->name : $userid." (".$user->name.")";
     } else {
         $writeto = sanitize_tags(post_str("to", true));
         $subject = post_str("subject", true);
         $content = post_str("content", true);
     }
 
-    $content = $content?htmlspecialchars($content):'';
-    $subject = $subject?htmlspecialchars($subject):'';
+    $content = $content ?htmlspecialchars($content) : '';
+    $subject = $subject ?htmlspecialchars($subject) : '';
 
     if ($error != null) {
         echo "<p class=\"text-danger\">".$error."</p>\n";
@@ -211,7 +211,7 @@ 
 function send_pm_notification_email(
     $logged_in_user, $to_user, $subject, $content
 ) {
-    $message  = "
+    $message = "
 You have received a new private message at ".PROJECT.".
 
 From: $logged_in_user->name (ID $logged_in_user->id)
@@ -241,7 +241,7 @@ 
     $pm = BoincPrivateMessage::lookup_id($notify->opaque);
     $from_user = BoincUser::lookup_id($pm->senderid);
     if (!$pm || !$from_user) return null;
-    return "<a href=pm.php>".tra("Private message%1 from %2, subject:" , "</a>", $from_user->name )." $pm->subject";
+    return "<a href=pm.php>".tra("Private message%1 from %2, subject:", "</a>", $from_user->name)." $pm->subject";
 }
 
 function pm_send_msg($from_user, $to_user, $subject, $content, $send_email) {
@@ -305,11 +305,11 @@ 
 
 function pm_email_remind($user) {
     if (!$user->prefs->pm_notification) {
-        return "<br><small>" .
+        return "<br><small>".
             tra(
                 "For email notification, %1 edit community prefs %2",
                 '<a href="edit_forum_preferences_form.php">', '</a>'
-            ) .
+            ).
             "</small>"
         ;
     }
@@ -335,5 +335,5 @@ 
     }
 }
 
-$cvs_version_tracker[]="\$Id: pm.inc 14019 2007-11-01 23:04:39Z davea $";
+$cvs_version_tracker[] = "\$Id: pm.inc 14019 2007-11-01 23:04:39Z davea $";
 ?>

html/ops/host_stats.php

Spacing +3 added lines, -3 removed lines

@@ -33,7 +33,7 @@ 
     if ($n === false) return '';
     $m = strpos($p, ']', $n);
     if ($m === false) return '';
-    $x = substr($p, $n+5, $m-$n-5);
+    $x = substr($p, $n + 5, $m - $n - 5);
 
     $n = strpos($x, ' ');
     if ($n !== false) return substr($x, 0, $n);
@@ -47,7 +47,7 @@ 
     if ($n === false) return '';
     $m = strpos($p, ']', $n);
     if ($m === false) return '';
-    $x = substr($p, $n+5, $m-$n-5);
+    $x = substr($p, $n + 5, $m - $n - 5);
     $n = strpos($x, '_');
     if ($n !== false) return substr($x, 0, $n);
     $n = strpos($x, 'r');
@@ -57,7 +57,7 @@ 
 
 function main() {
     global $max_days;
-    $t = time()-$max_days*86400;
+    $t = time() - $max_days*86400;
     $hosts = BoincHost::enum("rpc_time>$t");
     $descs = [];
     foreach ($hosts as $host) {

html/user/buda.php

Spacing +2 added lines, -2 removed lines

@@ -32,7 +32,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -102,7 +102,7 @@ 
     $dir = "$buda_root/$app/$variant";
     start_table();
     table_header('name', 'size', 'md5');
-    foreach(scandir($dir) as $f) {
+    foreach (scandir($dir) as $f) {
         if ($f[0] == '.') continue;
         [$md5, $size] = parse_info_file("$dir/.md5/$f");
         table_row(

Upper-Lower-Casing +6 added lines, -6 removed lines

@@ -92,7 +92,7 @@ 
     if (!is_valid_filename($app)) die('bad arg');
     $variant = get_str('variant');
     if (!is_valid_filename($variant)) die('bad arg');
-    page_head("App $app variant $variant");
+    page_head("app $app variant $variant");
     $dir = "$buda_root/$app/$variant";
     start_table();
     table_header('name', 'size', 'md5');
@@ -136,7 +136,7 @@ 
     form_input_hidden('app', $app);
     form_input_hidden('action', 'variant_action');
     form_input_text('Plan class', 'variant');
-    form_select("Dockerfile$sb", 'dockerfile', $sbitems);
+    form_select("dockerfile$sb", 'dockerfile', $sbitems);
     form_select_multiple("Application files$sb", 'app_files', $sbitems);
     form_input_text(
         'Input file names<br><small>Space-separated</small>',
@@ -222,7 +222,7 @@ 
     // Note: we don't currently allow indirect file access.
     // If we did, we'd need to create job.toml to mount project dir
 
-    app_list("Variant $variant added for app $app.");
+    app_list("variant $variant added for app $app.");
 }
 
 function variant_delete() {
@@ -249,7 +249,7 @@ 
         if ($ret) {
             error_page("delete failed");
         }
-        $notice = "Variant $variant of app $app removed.";
+        $notice = "variant $variant of app $app removed.";
         app_list($notice);
     } else {
         page_head("Confirm");
@@ -278,7 +278,7 @@ 
         if ($ret) {
             error_page('delete failed');
         }
-        $notice = "App $app removed.";
+        $notice = "app $app removed.";
         app_list($notice);
     } else {
         page_head('Confirm');
@@ -307,7 +307,7 @@ 
     if (!is_valid_filename($name)) die("bad arg: $name");
     $dir = "$buda_root/$name";
     if (file_exists($dir)) {
-        error_page("App $name already exists.");
+        error_page("app $name already exists.");
     }
     mkdir($dir);
     header("Location: buda.php");

html/inc/db_conn.inc

Spacing +8 added lines, -8 removed lines

@@ -22,12 +22,12 @@ 
 // Intended to be subclassed (e.g., BoincDb, BossaDb)
 //
 class DbConn {
-    var $db_conn;       // a mysqli object
-    var $db_name;       // the DB name
+    var $db_conn; // a mysqli object
+    var $db_name; // the DB name
 
     function init_conn($user, $passwd, $host, $name) {
         $x = explode(":", $host);
-        if (sizeof($x)>1) {
+        if (sizeof($x) > 1) {
             $host = $x[0];
             $port = $x[1];
         } else {
@@ -35,7 +35,7 @@ 
         }
         try {
             $this->db_conn = @new mysqli($host, $user, $passwd, $name, $port);
-        } catch(Exception $e) {
+        } catch (Exception $e) {
             return false;
         }
         if (mysqli_connect_error()) {
@@ -136,7 +136,7 @@ 
         return $this->enum_general($classname, $query);
     }
 
-    function enum($table, $classname, $where_clause=null, $order_clause=null) {
+    function enum($table, $classname, $where_clause = null, $order_clause = null) {
         return self::enum_fields(
             $table, $classname, '*', $where_clause, $order_clause
         );
@@ -181,15 +181,15 @@ 
         if ($x) return (double)$x->$field;
         return false;
     }
-    function count($table, $clause="TRUE") {
+    function count($table, $clause = "TRUE") {
         $query = "select count(*) as total from DBNAME.$table where $clause";
         return $this->get_int($query, 'total');
     }
-    function sum($table, $field, $clause="") {
+    function sum($table, $field, $clause = "") {
         $query = "select sum($field) as total from DBNAME.$table $clause";
         return $this->get_double($query, 'total');
     }
-    function max($table, $field, $clause="") {
+    function max($table, $field, $clause = "") {
         $query = "select max($field) as total from DBNAME.$table $clause";
         return $this->get_double($query, 'total');
     }