BOINC / boinc

html/user/user_search.php

Spacing +6 added lines, -6 removed lines

@@ -25,7 +25,7 @@ 
     $y = [];
     $x[] = sprintf('%s%s',
         user_links($user, BADGE_HEIGHT_MEDIUM),
-        UNIQUE_USER_NAME?'':" (ID $user->id)"
+        UNIQUE_USER_NAME ? '' : " (ID $user->id)"
     );
     $y[] = null;
     if (!DISABLE_TEAMS) {
@@ -108,7 +108,7 @@ 
     $where = "true";
     $search_string = get_str('search_string');
     if (strlen($search_string)) {
-        if (strlen($search_string)<3) {
+        if (strlen($search_string) < 3) {
             error_page(tra("search string must be at least 3 characters"));
         }
         $s = BoincDb::escape_string($search_string);
@@ -140,17 +140,17 @@ 
     $search_type = get_str('search_type', true);
     $order_clause = "id desc";
     if ($search_type == 'rac') {
-        $order_clause ="expavg_credit desc";
+        $order_clause = "expavg_credit desc";
     } else if ($search_type == 'total') {
-        $order_clause ="total_credit desc";
+        $order_clause = "total_credit desc";
     }
 
     $fields = "id, create_time, name, country, total_credit, expavg_credit, teamid, url, has_profile, donated";
     $users = BoincUser::enum_fields($fields, $where, "order by $order_clause limit 100");
     page_head(tra("User search results"));
-    $n=0;
+    $n = 0;
     foreach ($users as $user) {
-        if ($n==0) {
+        if ($n == 0) {
             start_table('table-striped');
             $x = ['Name'];
             $y = [null];

html/user/user_permissions.php

Spacing +5 added lines, -5 removed lines

@@ -27,7 +27,7 @@ 
     start_table('table-striped');
 
     $x = ['User'];
-    for ($i=0; $i<S_NFLAGS; $i++) {
+    for ($i = 0; $i < S_NFLAGS; $i++) {
         $x[] = $special_user_bitfield[$i];
     }
     $x[] = '';
@@ -42,9 +42,9 @@ 
             $pref->userid
         );
         $x = ["$user->name ($user->id)"];
-        for ($j=0; $j<S_NFLAGS; $j++) {
+        for ($j = 0; $j < S_NFLAGS; $j++) {
             $bit = substr($pref->special_user, $j, 1);
-            $c = ($bit == 1)?"checked":"";
+            $c = ($bit == 1) ? "checked" : "";
             $x[] = sprintf(
                 '<input type="checkbox" name="role%d" value="1" %s>',
                 $j, $c
@@ -57,7 +57,7 @@ 
 
     echo '<form action="user_permissions.php" method="POST">';
     $x = ['Add User ID: <input type="text" name="userid" size="6">'];
-    for ($j=0; $j<S_NFLAGS; $j++) {
+    for ($j = 0; $j < S_NFLAGS; $j++) {
         $x[] = sprintf(
             '<input type="checkbox" name="role%d" value="1">',
             $j
@@ -77,7 +77,7 @@ 
     if (!$user) error_page('no user');
     BoincForumPrefs::lookup($user);
 
-    for ($i=0; $i<S_NFLAGS; $i++) {
+    for ($i = 0; $i < S_NFLAGS; $i++) {
         if (post_int("role$i", true) == 1) {
             $bitset .= '1';
             echo "<br> setting $i";

html/project.sample/project_specific_prefs.inc

Spacing +14 added lines, -14 removed lines

@@ -33,7 +33,7 @@ 
 //      Also error-check values, and return errors in $errors->*
 
 function option($name, $val) {
-    $x = ($name == $val) ?  "selected" : "";
+    $x = ($name == $val) ? "selected" : "";
     return "<option name='$name' $x>$name\n";
 }
 
@@ -53,7 +53,7 @@ 
 if (APP_SELECT_PREFS) {
     $app_array = array();
     $apps = BoincApp::enum("deprecated=0");
-    foreach($apps as $app) {
+    foreach ($apps as $app) {
         $app_array[] = array($app->id, $app->user_friendly_name);
     }
 } else {
@@ -91,10 +91,10 @@ 
 }
 
 function number_select($name, $max, $n) {
-    $sel = ($n == 0) ? "selected":"";
+    $sel = ($n == 0) ? "selected" : "";
     $x = "<select class=\"form-control input-sm\" name=$name> <option value=0 $sel>".tra("No limit")."</option>";
-    for ($i=1; $i<=$max; $i++) {
-        $sel = ($n == $i) ? "selected":"";
+    for ($i = 1; $i <= $max; $i++) {
+        $sel = ($n == $i) ? "selected" : "";
         $x .= "<option value=$i $sel>$i</option>";
     }
     $x .= "</select>";
@@ -106,7 +106,7 @@ 
     return tra("No limit");
 }
 
-function project_specific_prefs_edit($prefs, $error=false) {
+function project_specific_prefs_edit($prefs, $error = false) {
     global $app_array;
     if (COLOR_PREFS) {
         $x = $prefs->color_scheme;
@@ -132,15 +132,15 @@ 
             } else {
                 $present = true;
             }
-            $checked = $present?"checked":"";
+            $checked = $present ? "checked" : "";
             $x .= "<input type=checkbox name=app_id_$app_id $checked> $app_name<br>";
         }
         tooltip_row2(APP_SELECT_TOOLTIP, APP_SELECT_DESC, $x);
-        $checked = $prefs->allow_non_preferred_apps?"checked":"";
+        $checked = $prefs->allow_non_preferred_apps ? "checked" : "";
         row2(ACCEPT_ANY_DESC, "<input type=checkbox name=allow_non_preferred_apps $checked>");
     }
     if (NON_GRAPHICAL_PREF) {
-        $checked = $prefs->non_graphical?"checked":"";
+        $checked = $prefs->non_graphical ? "checked" : "";
         row2(
             NON_GRAPHICAL_DESC,
             "<input type=checkbox name=non_graphical $checked>"
@@ -216,11 +216,11 @@ 
     return $x;
 }
 
-function project_specific_prefs_show($prefs, $columns=false) {
+function project_specific_prefs_show($prefs, $columns = false) {
     global $app_array;
     if ($columns) {
         if (COLOR_PREFS) {
-            row_defs(COLOR_DESC,"color_scheme", "", "", $prefs);
+            row_defs(COLOR_DESC, "color_scheme", "", "", $prefs);
         }
         if (GFX_CPU_PREFS) {
             row_defs(MAX_GFX_CPU_PCT_DESC, "max_gfx_cpu_pct", "", "", $prefs);
@@ -254,7 +254,7 @@ 
             row2(ACCEPT_ANY_DESC, $prefs->allow_non_preferred_apps_text);
         }
         if (NON_GRAPHICAL_PREF) {
-            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical?tra("yes"):tra("no"));
+            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical ?tra("yes") : tra("no"));
         }
         if (MAX_JOBS_PREF) {
             row2(tra("Max # jobs"), limit_string($prefs->max_jobs));
@@ -277,12 +277,12 @@ 
         $cursor = 0;
         while ($thisxml = parse_next_element($prefs_xml, "<app_id>", $cursor)) {
             if (is_numeric($thisxml)) {
-                $n = (int) $thisxml;
+                $n = (int)$thisxml;
                 $prefs->app_ids[] = $n;
             }
         }
         $prefs->allow_non_preferred_apps = parse_element($prefs_xml, "<allow_non_preferred_apps>");
-        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps?"yes":"no";
+        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps ? "yes" : "no";
     }
     if (NON_GRAPHICAL_PREF) {
         $prefs->non_graphical = parse_bool($prefs_xml, "non_graphical");

html/inc/stats_sites.inc

Spacing +2 added lines, -2 removed lines

@@ -147,11 +147,11 @@
 
 function site_list($sites) {
     echo "<ul>\n";
-    for ($i=0; $i<count($sites); $i++) {
+    for ($i = 0; $i < count($sites); $i++) {
         $s = $sites[$i];
         $url = $s[0];
         $name = $s[1];
-        $comment = array_key_exists(2, $s)?$s[2]:"";
+        $comment = array_key_exists(2, $s) ? $s[2] : "";
         echo "<li><a href=\"$url\">$name</a> $comment\n";
     }
     echo "</ul>\n";

html/inc/team.inc

Spacing +16 added lines, -16 removed lines

@@ -40,7 +40,7 @@ 
     row2('<b>'.tra('Search criteria (use one or more)').'</b>', '');
     row2(
         tra('Key words').'<br><small>'.tra('Find teams with these words in their names or descriptions').'</small>',
-        '<input class="form-control" type="text" name="keywords" value="' . htmlspecialchars($params->keywords) . '">');
+        '<input class="form-control" type="text" name="keywords" value="'.htmlspecialchars($params->keywords).'">');
     row2_init(tra('Country'));
     echo '<select class="form-control" name="country"><option value="" selected>---</option>';
     $country = $params->country;
@@ -48,7 +48,7 @@ 
     echo country_select_options($country);
     echo "</select></td></tr>\n";
     row2(tra('Type of team'), team_type_select($params->type, true));
-    $checked = $params->active?"checked":"";
+    $checked = $params->active ? "checked" : "";
     row2(tra('Show only active teams'), "<input type=checkbox name=active $checked>");
     row2("", "<input class=\"btn btn-primary\" type=submit name=submit value=\"".tra('Search')."\">");
     end_table();
@@ -95,7 +95,7 @@ 
     row2("Created", date_str($team->create_time));
     if (defined("SHOW_NONVALIDATED_TEAMS")) {
         $founder = $team->founder;
-        row2("Founder email validated", $founder->email_validated?"Yes":"No (team will not be exported)");
+        row2("Founder email validated", $founder->email_validated ? "Yes" : "No (team will not be exported)");
     }
     if (strlen($team->url)) {;
         if (strstr($team->url, "http://")) {
@@ -168,7 +168,7 @@ 
     }
     row1(tra('Members'));
     row2(tra('Founder'),
-        $team->founder?user_links($team->founder, BADGE_HEIGHT_MEDIUM):"---"
+        $team->founder ?user_links($team->founder, BADGE_HEIGHT_MEDIUM) : "---"
     );
     if (count($team->admins)) {
         $first = true;
@@ -355,7 +355,7 @@ 
     foreach ($deltas as $delta) {
         $u = BoincUser::lookup_id($delta->userid);
         if ($u->teamid == $teamid) {
-            $new_members[] = $u->id;  // they might have later quit
+            $new_members[] = $u->id; // they might have later quit
         }
     }
     return array_unique($new_members);
@@ -438,7 +438,7 @@ 
     if (!$user->teamid) return;
     $user->update("teamid=0");
     $team = BoincTeam::lookup_id($user->teamid);
-    if ($team && $team->ping_user==$user->id) {
+    if ($team && $team->ping_user == $user->id) {
         $team->update("ping_user=-ping_user");
     }
     BoincTeamAdmin::delete("teamid=$user->teamid and userid=$user->id");
@@ -477,33 +477,33 @@ 
     start_table();
     row2(tra('Team name, text version').'
         <br><p class=\"text-muted\">'.tra('Don\'t use HTML tags.').'</p>',
-        '<input class="form-control" name="name" type="text" size="50" value="'.($team?$team->name:"").'">'
+        '<input class="form-control" name="name" type="text" size="50" value="'.($team ? $team->name : "").'">'
     );
     row2(tra('Team name, HTML version').'
         <br><p class=\"text-muted\">
         '.tra('You may use %1 limited HTML tags %2.', '<a href="html.php" target="_new">', '</a>').'
         '.tra('If you don\'t know HTML, leave this box blank.').'</p>',
-        '<input class="form-control" name="name_html" type="text" size="50" value="'.str_replace('"',"'",($team?$team->name_html:"")).'">'
+        '<input class="form-control" name="name_html" type="text" size="50" value="'.str_replace('"', "'", ($team ? $team->name_html : "")).'">'
     );
     row2(tra('URL of team web page, if any').':<br><font size=-2>('.tra('without "http://"').')
         '.tra('This URL will be linked to from the team\'s page on this site.'),
-        '<input class="form-control" type="text" name="url" size="60" value="'.($team?$team->url:"").'">'
+        '<input class="form-control" type="text" name="url" size="60" value="'.($team ? $team->url : "").'">'
     );
     row2(tra('Description of team').':
         <br><p class=\"text-muted\">
         '.tra('You may use %1 limited HTML tags %2.', '<a href="html.php" target="_new">', '</a>').'
         </p>',
-        '<textarea class="form-control" name="description" rows=10>'.($team?$team->description:"").'</textarea>'
+        '<textarea class="form-control" name="description" rows=10>'.($team ? $team->description : "").'</textarea>'
     );
 
-    row2(tra('Type of team').':', team_type_select($team?$team->type:null));
+    row2(tra('Type of team').':', team_type_select($team ? $team->type : null));
 
     row2_init(tra('Country'));
     echo '<select class="form-control" name="country">';
-    echo country_select_options($team?$team->country:null);
+    echo country_select_options($team ? $team->country : null);
     echo "</select></td></tr>\n";
 
-    $x = (!$team || $team->joinable)?"checked":"";
+    $x = (!$team || $team->joinable) ? "checked" : "";
     row2(tra("Accept new members?"), "<input type=checkbox name=joinable $x>");
     // Check if we're using reCaptcha to prevent spam accounts
     //
@@ -571,12 +571,12 @@ 
 //
 function new_transfer_request_ok($team, $now) {
     if ($team->ping_user <= 0) {
-        if ($team->ping_time < $now - 60 * 86400) {
+        if ($team->ping_time < $now - 60*86400) {
             return true;
         }
         return false;
     }
-    if ($team->ping_time < $now - 90 * 86400) {
+    if ($team->ping_time < $now - 90*86400) {
         return true;
     }
     return false;
@@ -611,7 +611,7 @@ 
     if (!is_valid_country($country)) {
         $country = tra('None');
     }
-    $country = BoincDb::escape_string($country);  // for Cote d'Ivoire
+    $country = BoincDb::escape_string($country); // for Cote d'Ivoire
 
     $clause = sprintf(
         "(userid, create_time, name, name_lc, url, type, name_html, description, country, nusers, expavg_time) values(%d, %d, '%s', '%s', '%s', %d, '%s', '%s', '%s', %d, unix_timestamp())",

html/inc/profile.inc

Spacing +9 added lines, -9 removed lines

@@ -71,7 +71,7 @@ 
     if (!$user->has_profile) return null;
     $profile = BoincProfile::lookup("userid=$user->id");
     if (!$profile->has_picture) return null;
-    if (profile_screening() && $profile->verification!=1) return null;
+    if (profile_screening() && $profile->verification != 1) return null;
     return profile_thumb_url($user->id);
 }
 
@@ -125,11 +125,11 @@ 
         return $image;
     }
 
-    ($origWidth > $origHeight)? $scalar = ($origWidth / $targetWidth) : $scalar = ($origHeight / $targetHeight);
+    ($origWidth > $origHeight) ? $scalar = ($origWidth/$targetWidth) : $scalar = ($origHeight/$targetHeight);
 
     if ($scalar != 0) {
-        $destWidth = $origWidth / $scalar;
-        $destHeight = $origHeight / $scalar;
+        $destWidth = $origWidth/$scalar;
+        $destHeight = $origHeight/$scalar;
     } else {
         $destWidth = $origWidth;
         $destHeight = $origHeight;
@@ -138,7 +138,7 @@ 
     $gd_info = gd_info();
     $v = $gd_info["GD Version"];
     $v = explode('.', $v);
-    $v = (int)$v[0];        // major version
+    $v = (int)$v[0]; // major version
     if ($v >= 2) {
         // If you are using a modern PHP/GD installation that does
         // 'truecolor' images, this is what's needed.
@@ -181,7 +181,7 @@ 
         $options->htmlitems = false;
         $temp = output_transform($profile->response1, $options);
         $temp = sanitize_tags($temp);
-        $description = "(\"" . sub_sentence($temp, ' ', MAX_DESC_LENGTH, true) . "\")";
+        $description = "(\"".sub_sentence($temp, ' ', MAX_DESC_LENGTH, true)."\")";
 
     }
 
@@ -191,7 +191,7 @@ 
 
 function check_whether_to_show_profile($user, $logged_in_user) {
     $min_credit = parse_config(get_config(), "<profile_min_credit>");
-    if (!$logged_in_user && $min_credit && $user->expavg_credit < $min_credit ) {
+    if (!$logged_in_user && $min_credit && $user->expavg_credit < $min_credit) {
         error_page(
            tra("To prevent spam, profiles of users with an average credit of less than %1 are displayed only to logged-in users. We apologize for this inconvenience.", $min_credit)
         );
@@ -229,7 +229,7 @@ 
     //
     $show_picture = $profile->has_picture;
     if (profile_screening()) {
-        if (!$screen_mode && !$can_edit && $profile->verification!=1) {
+        if (!$screen_mode && !$can_edit && $profile->verification != 1) {
             $show_picture = false;
         }
     }
@@ -245,7 +245,7 @@ 
     // yet verified.  This will tell them if other users can't view it yet, or
     // if there is a problem with it and they need to replace it.
     //
-    if (profile_screening() && $profile->has_picture && $can_edit && $profile->verification!=1) {
+    if (profile_screening() && $profile->has_picture && $can_edit && $profile->verification != 1) {
         row1(offensive_profile_warning($profile->verification));
     }
 

Indentation +1 added lines, -1 removed lines

@@ -193,7 +193,7 @@
     $min_credit = parse_config(get_config(), "<profile_min_credit>");
     if (!$logged_in_user && $min_credit && $user->expavg_credit < $min_credit ) {
         error_page(
-           tra("To prevent spam, profiles of users with an average credit of less than %1 are displayed only to logged-in users. We apologize for this inconvenience.", $min_credit)
+            tra("To prevent spam, profiles of users with an average credit of less than %1 are displayed only to logged-in users. We apologize for this inconvenience.", $min_credit)
         );
     }
 }

html/ops/sample_table_stats.php

Spacing +13 added lines, -13 removed lines

@@ -27,25 +27,25 @@
     row_array(array("Name", "Engine", "Version", "Row Format", "Rows", "Avg Row Length (KB)", "Data Length (MB)", "Max Data Length (MB)", "Index Length (MB)", "Data free (MB)", "Create Time", "Update Time", "Check Time", "Create Options", "Comment"));
     db_init();
     $result = _mysql_query("show table status");
-    while($row = _mysql_fetch_array($result)) {
+    while ($row = _mysql_fetch_array($result)) {
         $size += ($row["Data_length"] + $row["Index_length"]);
         $engine = $row["Engine"];
         //if (!$engine) $engine = $row["Type"];
         row_array(array(
             $row["Name"],
             $engine,
-            $row["Version"] ,
-            $row["Row_format"] ,
-            $row["Rows"] ,
-            round($row["Avg_row_length"]/1024,2) ,
-            round($row["Data_length"]/(1024*1024),2) ,
-            round($row["Max_data_length"]/(1024*1024),2) ,
-            round($row["Index_length"]/(1024*1024),2) ,
-            round($row["Data_free"]/(1024*1024),2) ,
-            $row["Create_time"] ,
-            $row["Update_time"] ,
-            $row["Check_time"] ,
-            $row["Create_options"] ,
+            $row["Version"],
+            $row["Row_format"],
+            $row["Rows"],
+            round($row["Avg_row_length"]/1024, 2),
+            round($row["Data_length"]/(1024*1024), 2),
+            round($row["Max_data_length"]/(1024*1024), 2),
+            round($row["Index_length"]/(1024*1024), 2),
+            round($row["Data_free"]/(1024*1024), 2),
+            $row["Create_time"],
+            $row["Update_time"],
+            $row["Check_time"],
+            $row["Create_options"],
             $row["Comment"]
         ));
     }

html/user/sandbox.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -218,13 +218,13 @@
 function get_file($user) {
     $dir = sandbox_dir($user);
     $url = post_str('url');
-    if (filter_var($url, FILTER_VALIDATE_URL) === FALSE) {
+    if (filter_var($url, FILTER_VALIDATE_URL) === false) {
         error_page('Not a valid URL');
     }
     $fname = basename($url);
     $path = "$dir/$fname";
     if (file_exists($path)) {
-        error_page("File $fname exists; delete it first.");
+        error_page("file $fname exists; delete it first.");
     }
     copy($url, $path);
     $notice = "Fetched file from <strong>$url</strong><br/>";

Spacing +2 added lines, -2 removed lines

@@ -84,7 +84,7 @@ 
     page_tail();
 }
 
-function list_files($user, $notice=null) {
+function list_files($user, $notice = null) {
     $dir = sandbox_dir($user);
     if (!is_dir($dir)) error_page("Can't open sandbox directory");
     page_head("File sandbox");
@@ -168,7 +168,7 @@ 
     $notice = "";
     $dir = sandbox_dir($user);
     $count = count($_FILES['new_file']['tmp_name']);
-    for ($i=0; $i<$count; $i++) {
+    for ($i = 0; $i < $count; $i++) {
         $tmp_name = $_FILES['new_file']['tmp_name'][$i];
         if (!is_uploaded_file($tmp_name)) {
             error_page("$tmp_name is not uploaded file");

html/inc/consent.inc

Spacing +5 added lines, -5 removed lines

@@ -21,7 +21,7 @@ 
 require_once("../inc/boinc_db.inc");
 require_once("../inc/util.inc");
 
-define('CONSENT_TYPE_ENROLL','ENROLL');
+define('CONSENT_TYPE_ENROLL', 'ENROLL');
 
 function check_termsofuse() {
     return defined('TERMSOFUSE_FILE') and file_exists(TERMSOFUSE_FILE);
@@ -32,13 +32,13 @@ 
     $source, $ctime = 0
 ) {
     $mys = BoincDb::escape_string($source);
-    if ($ctime==0) {
+    if ($ctime == 0) {
         $mytime = $user->create_time;
     } else {
         $mytime = $ctime;
     }
     return BoincConsent::insert(
-        "(userid, consent_type_id, consent_time, consent_flag, consent_not_required, source) " .
+        "(userid, consent_type_id, consent_time, consent_flag, consent_not_required, source) ".
         "values($user->id, $consent_type_id, $mytime, $consent_flag, $consent_not_required, '$mys')"
     );
 
@@ -65,10 +65,10 @@ 
 // The integer is the consent_type_id- the id from consent_type table.
 // If the boolean is FALSE, the integer returned is -1.
 //
-function check_consent_type($name, $checkenabled=TRUE) {
+function check_consent_type($name, $checkenabled = TRUE) {
     $name = BoincDb::escape_string($name);
     $ct = BoincConsentType::lookup("shortname = '$name'");
-    if ($ct and ( !$checkenabled or ($ct->enabled)) ) {
+    if ($ct and (!$checkenabled or ($ct->enabled))) {
         return array(TRUE, $ct->id);
     }
     return array(FALSE, -1);

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -52,10 +52,10 @@ 
             "userid=$user->id AND consent_type_id=$ctid AND consent_flag=1"
         );
         if ($consent_result) {
-            return TRUE;
+            return true;
         }
     }
-    return FALSE;
+    return false;
 }
 
 // Check if a particular consent_type name is available.
@@ -65,13 +65,13 @@ 
 // The integer is the consent_type_id- the id from consent_type table.
 // If the boolean is FALSE, the integer returned is -1.
 //
-function check_consent_type($name, $checkenabled=TRUE) {
+function check_consent_type($name, $checkenabled=true) {
     $name = BoincDb::escape_string($name);
     $ct = BoincConsentType::lookup("shortname = '$name'");
     if ($ct and ( !$checkenabled or ($ct->enabled)) ) {
-        return array(TRUE, $ct->id);
+        return array(true, $ct->id);
     }
-    return array(FALSE, -1);
+    return array(false, -1);
 }
 
 // When a user uses the Web site to login, this function checks the