Passed
Push — dpa_docker_wrapper12 ( e18bd7 )
by David
08:59
created
html/user/forum_index.php 3 patches
Upper-Lower-Casing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@
 block discarded – undo
79 79
         if ($first) {
80 80
             $first = false;
81 81
             echo "<p>";
82
-            echo forum_title($category, NULL, NULL);
82
+            echo forum_title($category, null, null);
83 83
             echo "<p>";
84 84
             show_mark_as_read_button($user);
85 85
             start_table('table-striped');
Please login to merge, or discard this patch.
Braces   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -69,7 +69,7 @@
 block discarded – undo
69 69
         project_forum_index_intro();
70 70
     }
71 71
 
72
-    if (defined('FORUM_QA_MERGED_MODE') && FORUM_QA_MERGED_MODE){
72
+    if (defined('FORUM_QA_MERGED_MODE') && FORUM_QA_MERGED_MODE) {
73 73
         $categories = BoincCategory::enum("true order by orderID");
74 74
     } else {
75 75
         echo "<p>"
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@
 block discarded – undo
58 58
         project_forum_index_intro();
59 59
     }
60 60
 
61
-    if (defined('FORUM_QA_MERGED_MODE') && FORUM_QA_MERGED_MODE){
61
+    if (defined('FORUM_QA_MERGED_MODE') && FORUM_QA_MERGED_MODE) {
62 62
         $categories = BoincCategory::enum("true order by orderID");
63 63
     } else {
64 64
         echo "<p>"
Please login to merge, or discard this patch.
html/ops/botnet.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,7 @@
 block discarded – undo
7 7
 //      add other criteria like # of countries (based on IP addr)
8 8
 //      consider only hosts with recent last RPC time
9 9
 
10
-define ('MAX_HOSTS', 100);
10
+define('MAX_HOSTS', 100);
11 11
 
12 12
 require_once('../inc/boinc_db.inc');
13 13
 
Please login to merge, or discard this patch.
html/user/forum_reply.php 2 patches
Braces   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     $parent_post_id = 0;
57 57
 }
58 58
 
59
-if ($filter != "false"){
59
+if ($filter != "false") {
60 60
     $filter = true;
61 61
 } else {
62 62
     $filter = false;
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 }
72 72
 
73 73
 $warning = null;
74
-if ($content && (!$preview)){
74
+if ($content && (!$preview)) {
75 75
     check_tokens($logged_in_user->authenticator);
76 76
     if (!akismet_check($logged_in_user, $content)) {
77 77
         $warning = tra("Your post has been flagged as spam by the Akismet anti-spam system. Please modify your text and try again.");
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -56,7 +56,7 @@  discard block
 block discarded – undo
56 56
     $parent_post_id = 0;
57 57
 }
58 58
 
59
-if ($filter != "false"){
59
+if ($filter != "false") {
60 60
     $filter = true;
61 61
 } else {
62 62
     $filter = false;
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
 }
72 72
 
73 73
 $warning = null;
74
-if ($content && (!$preview)){
74
+if ($content && (!$preview)) {
75 75
     check_tokens($logged_in_user->authenticator);
76 76
     if (!akismet_check($logged_in_user, $content)) {
77 77
         $warning = tra("Your post has been flagged as spam by the Akismet anti-spam system. Please modify your text and try again.");
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     }
94 94
 }
95 95
 
96
-page_head(tra("Post to thread")." '$thread->title'",'','','', $bbcode_js);
96
+page_head(tra("Post to thread")." '$thread->title'", '', '', '', $bbcode_js);
97 97
 
98 98
 if ($parent_post) {
99 99
     echo sprintf(
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
     $x2 .= " method=\"post\" name=\"post\" onsubmit=\"return checkForm(this)\">\n";
162 162
     $x2 .= form_tokens($logged_in_user->authenticator);
163 163
     $x2 .= $bbcode_html."<textarea class=\"form-control\" name=\"content\" rows=\"18\">";
164
-    $no_quote = get_int("no_quote", true)==1;
164
+    $no_quote = get_int("no_quote", true) == 1;
165 165
     if ($preview) {
166 166
         $x2 .= htmlspecialchars($content);
167 167
     } else if (!$no_quote) {
@@ -170,9 +170,9 @@  discard block
 block discarded – undo
170 170
         }
171 171
     }
172 172
     if (!$logged_in_user->prefs->no_signature_by_default) {
173
-        $enable_signature='checked="true"';
173
+        $enable_signature = 'checked="true"';
174 174
     } else {
175
-        $enable_signature="";
175
+        $enable_signature = "";
176 176
     }
177 177
     $x2 .= sprintf('</textarea><p> </p>
178 178
         <input class="btn btn-sm" %s type="submit" name="preview" value="%s">
@@ -200,7 +200,7 @@  discard block
 block discarded – undo
200 200
     return sprintf(
201 201
         'In reply to %s\'s message of %s:
202 202
         [quote]%s[/quote]',
203
-        $user?$user->name:'unknown user',
203
+        $user ? $user->name : 'unknown user',
204 204
         date_str($post->timestamp),
205 205
         htmlspecialchars($post->content)
206 206
     );
Please login to merge, or discard this patch.
html/user/forum_user_posts.php 2 patches
Indentation   +12 added lines, -12 removed lines patch added patch discarded remove patch
@@ -91,9 +91,9 @@  discard block
 block discarded – undo
91 91
         if ($forum->parent_type == 1) {
92 92
             // post to team msg board
93 93
             if ($forum->category == $teamid) {
94
-				if ($thread->hidden && !$show_team_hidden) {
95
-					continue;
96
-				}
94
+                if ($thread->hidden && !$show_team_hidden) {
95
+                    continue;
96
+                }
97 97
                 if ($post->hidden && !$show_team_hidden) {
98 98
                     continue;
99 99
                 }
@@ -101,18 +101,18 @@  discard block
 block discarded – undo
101 101
                 continue;
102 102
             }
103 103
         } else {
104
-			if ($thread->hidden && !$show_hidden) {
105
-				continue;
106
-			}
104
+            if ($thread->hidden && !$show_hidden) {
105
+                continue;
106
+            }
107 107
             if ($post->hidden && !$show_hidden) {
108 108
                 continue;
109 109
             }
110 110
         }
111 111
     }
112
-	if ($n == $offset + $items_per_page) {
113
-		$show_next = true;
114
-		break;
115
-	}
112
+    if ($n == $offset + $items_per_page) {
113
+        $show_next = true;
114
+        break;
115
+    }
116 116
     if ($n >= $offset) {
117 117
         show_post_and_context($post, $thread, $forum, $options, $n+1);
118 118
     }
@@ -121,12 +121,12 @@  discard block
 block discarded – undo
121 121
 end_table();
122 122
 
123 123
 if ($offset) {
124
-	$x = $offset - $items_per_page;
124
+    $x = $offset - $items_per_page;
125 125
     echo "<a href=forum_user_posts.php?userid=$userid&offset=$x>
126 126
 		<b>".tra("Previous %1", $items_per_page)."</b>
127 127
 		</a>
128 128
     ";
129
-	if ($show_next) echo " &middot; ";
129
+    if ($show_next) echo " &middot; ";
130 130
 }
131 131
 
132 132
 if ($show_next) {
Please login to merge, or discard this patch.
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -29,7 +29,7 @@  discard block
 block discarded – undo
29 29
 $user = BoincUser::lookup_id($userid);
30 30
 if (!$user) error_page('no such user');
31 31
 $offset = get_int("offset", true);
32
-if (!$offset) $offset=0;
32
+if (!$offset) $offset = 0;
33 33
 $items_per_page = 20;
34 34
 
35 35
 $logged_in_user = get_logged_in_user(false);
@@ -114,7 +114,7 @@  discard block
 block discarded – undo
114 114
 		break;
115 115
 	}
116 116
     if ($n >= $offset) {
117
-        show_post_and_context($post, $thread, $forum, $options, $n+1);
117
+        show_post_and_context($post, $thread, $forum, $options, $n + 1);
118 118
     }
119 119
     $n++;
120 120
 }
Please login to merge, or discard this patch.
html/user/forum_post.php 2 patches
Braces   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -56,10 +56,10 @@  discard block
 block discarded – undo
56 56
 $preview = post_str("preview", true);
57 57
 $warning = null;
58 58
 
59
-if ($content && $title && (!$preview)){
59
+if ($content && $title && (!$preview)) {
60 60
     if (post_str('add_signature', true)) {
61 61
         $add_signature = true;    // set a flag and concatenate later
62
-    }  else {
62
+    } else {
63 63
         $add_signature = false;
64 64
     }
65 65
     check_tokens($logged_in_user->authenticator);
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
123 123
 }
124 124
 
125
-if ($force_title && $title){
125
+if ($force_title && $title) {
126 126
     row2(
127 127
         tra("Title"),
128 128
         sprintf(
Please login to merge, or discard this patch.
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
     error_page("Forums are disabled");
44 44
 }
45 45
 
46
-if (user_can_create_thread($logged_in_user, $forum)=='no') {
46
+if (user_can_create_thread($logged_in_user, $forum) == 'no') {
47 47
     error_page(tra("Only project admins may create a thread here. However, you may reply to existing threads."));
48 48
 }
49 49
 check_post_access($logged_in_user, $forum);
@@ -56,10 +56,10 @@  discard block
 block discarded – undo
56 56
 $preview = post_str("preview", true);
57 57
 $warning = null;
58 58
 
59
-if ($content && $title && (!$preview)){
59
+if ($content && $title && (!$preview)) {
60 60
     if (post_str('add_signature', true)) {
61
-        $add_signature = true;    // set a flag and concatenate later
62
-    }  else {
61
+        $add_signature = true; // set a flag and concatenate later
62
+    } else {
63 63
         $add_signature = false;
64 64
     }
65 65
     check_tokens($logged_in_user->authenticator);
@@ -74,14 +74,14 @@  discard block
 block discarded – undo
74 74
             if (post_str('subscribe', true)) {
75 75
                 BoincSubscription::replace($logged_in_user->id, $thread->id);
76 76
             }
77
-            header('Location: forum_thread.php?id=' . $thread->id);
77
+            header('Location: forum_thread.php?id='.$thread->id);
78 78
         } else {
79 79
             error_page("Can't create thread.  $forum_error");
80 80
         }
81 81
     }
82 82
 }
83 83
 
84
-page_head(tra("Create new thread"),'','','', $bbcode_js);
84
+page_head(tra("Create new thread"), '', '', '', $bbcode_js);
85 85
 show_forum_header($logged_in_user);
86 86
 
87 87
 if ($warning) {
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
123 123
 }
124 124
 
125
-if ($force_title && $title){
125
+if ($force_title && $title) {
126 126
     row2(
127 127
         tra("Title"),
128 128
         sprintf(
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
     row2(
137 137
         tra("Title").$submit_help,
138 138
         sprintf('<input type="text" class="form-control" name="title" value="%s">',
139
-            $title?htmlspecialchars($title):''
139
+            $title ?htmlspecialchars($title) : ''
140 140
         ),
141 141
         null, FORUM_LH_PCT
142 142
     );
@@ -147,7 +147,7 @@  discard block
 block discarded – undo
147 147
     sprintf(
148 148
         '%s <textarea class="form-control" name="content" rows="12" cols="80">%s</textarea>',
149 149
         $bbcode_html,
150
-        $content?htmlspecialchars($content):''
150
+        $content ?htmlspecialchars($content) : ''
151 151
     ),
152 152
     null, FORUM_LH_PCT
153 153
 );
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
 if (!$logged_in_user->prefs->no_signature_by_default) {
156 156
     $enable_signature = 'checked="true"';
157 157
 } else {
158
-    $enable_signature='';
158
+    $enable_signature = '';
159 159
 }
160 160
 
161 161
 if (is_news_forum($forum)) {
Please login to merge, or discard this patch.
html/ops/host_stats.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
     if ($n === false) return '';
34 34
     $m = strpos($p, ']', $n);
35 35
     if ($m === false) return '';
36
-    $x = substr($p, $n+5, $m-$n-5);
36
+    $x = substr($p, $n + 5, $m - $n - 5);
37 37
 
38 38
     $n = strpos($x, ' ');
39 39
     if ($n !== false) return substr($x, 0, $n);
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
     if ($n === false) return '';
48 48
     $m = strpos($p, ']', $n);
49 49
     if ($m === false) return '';
50
-    $x = substr($p, $n+5, $m-$n-5);
50
+    $x = substr($p, $n + 5, $m - $n - 5);
51 51
     $n = strpos($x, '_');
52 52
     if ($n !== false) return substr($x, 0, $n);
53 53
     $n = strpos($x, 'r');
@@ -57,7 +57,7 @@  discard block
 block discarded – undo
57 57
 
58 58
 function main() {
59 59
     global $max_days;
60
-    $t = time()-$max_days*86400;
60
+    $t = time() - $max_days*86400;
61 61
     $hosts = BoincHost::enum("rpc_time>$t");
62 62
     $descs = [];
63 63
     foreach ($hosts as $host) {
Please login to merge, or discard this patch.
html/inc/db_conn.inc 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -22,12 +22,12 @@  discard block
 block discarded – undo
22 22
 // Intended to be subclassed (e.g., BoincDb, BossaDb)
23 23
 //
24 24
 class DbConn {
25
-    var $db_conn;       // a mysqli object
26
-    var $db_name;       // the DB name
25
+    var $db_conn; // a mysqli object
26
+    var $db_name; // the DB name
27 27
 
28 28
     function init_conn($user, $passwd, $host, $name) {
29 29
         $x = explode(":", $host);
30
-        if (sizeof($x)>1) {
30
+        if (sizeof($x) > 1) {
31 31
             $host = $x[0];
32 32
             $port = $x[1];
33 33
         } else {
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
         }
36 36
         try {
37 37
             $this->db_conn = @new mysqli($host, $user, $passwd, $name, $port);
38
-        } catch(Exception $e) {
38
+        } catch (Exception $e) {
39 39
             return false;
40 40
         }
41 41
         if (mysqli_connect_error()) {
@@ -136,7 +136,7 @@  discard block
 block discarded – undo
136 136
         return $this->enum_general($classname, $query);
137 137
     }
138 138
 
139
-    function enum($table, $classname, $where_clause=null, $order_clause=null) {
139
+    function enum($table, $classname, $where_clause = null, $order_clause = null) {
140 140
         return self::enum_fields(
141 141
             $table, $classname, '*', $where_clause, $order_clause
142 142
         );
@@ -181,15 +181,15 @@  discard block
 block discarded – undo
181 181
         if ($x) return (double)$x->$field;
182 182
         return false;
183 183
     }
184
-    function count($table, $clause="TRUE") {
184
+    function count($table, $clause = "TRUE") {
185 185
         $query = "select count(*) as total from DBNAME.$table where $clause";
186 186
         return $this->get_int($query, 'total');
187 187
     }
188
-    function sum($table, $field, $clause="") {
188
+    function sum($table, $field, $clause = "") {
189 189
         $query = "select sum($field) as total from DBNAME.$table $clause";
190 190
         return $this->get_double($query, 'total');
191 191
     }
192
-    function max($table, $field, $clause="") {
192
+    function max($table, $field, $clause = "") {
193 193
         $query = "select max($field) as total from DBNAME.$table $clause";
194 194
         return $this->get_double($query, 'total');
195 195
     }
Please login to merge, or discard this patch.
html/user/get_output2.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
     if ($user->authenticator != $auth) die('bad auth');
52 52
 }
53 53
 
54
-function do_result_aux($result, $batch, $file_num=null) {
54
+function do_result_aux($result, $batch, $file_num = null) {
55 55
     $phys_names = get_outfile_phys_names($result);
56 56
     $log_names = get_outfile_log_names($result);
57 57
     if ($file_num !== null) {
@@ -71,7 +71,7 @@  discard block
 block discarded – undo
71 71
         $dir_path = "submit/$batch->id/$result->name";
72 72
         system("rm -r $dir_path");
73 73
         mkdir($dir_path);
74
-        for ($i=0; $i<count($phys_names); $i++) {
74
+        for ($i = 0; $i < count($phys_names); $i++) {
75 75
             $cmd = sprintf('ln -s %s %s/%s',
76 76
                 upload_path($phys_names[$i]),
77 77
                 $dir_path,
@@ -88,7 +88,7 @@  discard block
 block discarded – undo
88 88
     }
89 89
 }
90 90
 
91
-function do_result($result_id, $auth, $file_num=null) {
91
+function do_result($result_id, $auth, $file_num = null) {
92 92
     $result = BoincResult::lookup_id($result_id);
93 93
     if (!$result) die("no result $result_id");
94 94
     $workunit = BoincWorkunit::lookup_id($result->workunitid);
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
             system($cmd);
136 136
         } else {
137 137
             mkdir(sprintf('%s/%s', $dir_path, $result->name));
138
-            for ($i=0; $i<count($phys_names); $i++) {
138
+            for ($i = 0; $i < count($phys_names); $i++) {
139 139
                 $cmd = sprintf('ln -s %s %s/%s/%s',
140 140
                     upload_path($phys_names[$i]),
141 141
                     $dir_path,
Please login to merge, or discard this patch.
html/inc/sandbox.inc 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -91,7 +91,7 @@  discard block
 block discarded – undo
91 91
 // return list of files matching given pattern,
92 92
 // in the format used for form_select() and form_select_multiple()
93 93
 //
94
-function sandbox_select_items($user, $pattern=null) {
94
+function sandbox_select_items($user, $pattern = null) {
95 95
     $sbfiles = sandbox_file_names($user);
96 96
     $sbitems = [];
97 97
     foreach ($sbfiles as $f) {
@@ -112,7 +112,7 @@  discard block
 block discarded – undo
112 112
     }
113 113
     $files = sandbox_file_names($user);
114 114
     foreach ($files as $f) {
115
-        if ($regexp && !preg_match("/$regexp/",$f)) continue;
115
+        if ($regexp && !preg_match("/$regexp/", $f)) continue;
116 116
         $x .= "<option value=\"$f\">$f</option>\n";
117 117
     }
118 118
     $x .= "</select>\n";
@@ -160,8 +160,8 @@  discard block
 block discarded – undo
160 160
             '%s <a href="%s&sort_field=%s&sort_rev=%d">%s</a>',
161 161
             $title,
162 162
             $url, $sort_field,
163
-            $sort_rev?0:1,
164
-            $sort_rev?'&uarr;':'&darr;'
163
+            $sort_rev ? 0 : 1,
164
+            $sort_rev ? '&uarr;' : '&darr;'
165 165
         );
166 166
     } else {
167 167
         return sprintf(
Please login to merge, or discard this patch.