Passed
Pull Request — master (#3196)
by Christian
10:54
created
html/user/create_profile.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 // If $selection is provided, and if it matches one of the entries in the file,
33 33
 // it will be selected by default.
34 34
 //
35
-function show_combo_box($name, $filename, $selection=null) {
35
+function show_combo_box($name, $filename, $selection = null) {
36 36
     echo "<select name=\"$name\" class=\"form-control\">\n";
37 37
 
38 38
     $file = fopen($filename, "r");
@@ -63,14 +63,14 @@  discard block
 block discarded – undo
63 63
 <tr><td colspan=2>
64 64
 <table border=0 cellpadding=5
65 65
 <tr>
66
-<td valign=top><a href=\"" . IMAGE_URL . $profile->userid . '.jpg' . "\"><img src=\"" . IMAGE_URL . $profile->userid . '_sm.jpg' . "\"></a>
66
+<td valign=top><a href=\"" . IMAGE_URL.$profile->userid.'.jpg'."\"><img src=\"".IMAGE_URL.$profile->userid.'_sm.jpg'."\"></a>
67 67
 </td>
68
-<td valign=top>" .tra("%1 Your profile picture is shown to the left.",  $warning) ."
68
+<td valign=top>" .tra("%1 Your profile picture is shown to the left.", $warning)."
69 69
 <p>".
70
-tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB") ."<br />
70
+tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB")."<br />
71 71
 <input name=picture type=file><br>
72 72
 <p>".
73
-tra("To remove it from your profile, check this box:") . "
73
+tra("To remove it from your profile, check this box:")."
74 74
 <input type=checkbox name=delete_pic>
75 75
 <p>
76 76
 </td></tr>";
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         end_table();
79 79
         echo "</td></tr>";
80 80
     } else {
81
-        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB") . "
81
+        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB")."
82 82
 <p>
83 83
 <input name=picture type=file>
84 84
         ");
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     row1(tra("Language"));
94 94
     echo "<tr><td>
95 95
         <p>" .
96
-        tra("Select the language in which your profile is written:") . "
96
+        tra("Select the language in which your profile is written:")."
97 97
         <p>
98 98
     ";
99 99
     if (isset($profile->language)) {
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     if ($recaptcha_public_key) {
111 111
         table_row(boinc_recaptcha_get_html($recaptcha_public_key));
112 112
     }
113
-    table_row("<p><input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Create/edit profile") ."\" name=\"submit\">");
113
+    table_row("<p><input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Create/edit profile")."\" name=\"submit\">");
114 114
 }
115 115
 
116 116
 // Returns an array containing:
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 
125 125
     // Determine if the filetype uploaded is supported.
126 126
     // TODO: Change these to constants.
127
-    switch($size[2]) {
127
+    switch ($size[2]) {
128 128
     case '2':    // JPEG
129 129
         $image = imageCreateFromJPEG($fileName);
130 130
         break;
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
 
162 162
 function show_description() {
163 163
     echo "
164
-        <p>" .tra("Your %1 profile %2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT) . "
164
+        <p>" .tra("Your %1 profile %2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT)."
165 165
         <p>
166 166
     ";
167 167
 }
@@ -179,14 +179,14 @@  discard block
 block discarded – undo
179 179
     row1(show_profile_heading1());
180 180
     rowify(show_profile_question1().bbcode_info());
181 181
     show_textarea("response1", $response1);
182
-    row1( show_profile_heading2());
183
-    rowify( show_profile_question2().bbcode_info());
182
+    row1(show_profile_heading2());
183
+    rowify(show_profile_question2().bbcode_info());
184 184
     show_textarea("response2", $response2);
185 185
     show_language_selection($profile);
186 186
 }
187 187
 
188 188
 function show_textarea($name, $text) {
189
-    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">" . $text . "</textarea>");
189
+    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">".$text."</textarea>");
190 190
 }
191 191
 
192 192
 // $profile is null if user doesn't already have a profile.
@@ -232,8 +232,8 @@  discard block
 block discarded – undo
232 232
         $delete_pic = "off";
233 233
     }
234 234
 
235
-    if (strlen($response1)==0 &&
236
-        strlen($response2)==0 &&
235
+    if (strlen($response1) == 0 &&
236
+        strlen($response2) == 0 &&
237 237
         $delete_pic != "on" &&
238 238
         !is_uploaded_file($_FILES['picture']['tmp_name'])
239 239
     ) {
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         $profile->verification = 0;
248 248
     }
249 249
 
250
-    $profile ? $has_picture = $profile->has_picture: $has_picture = false;
250
+    $profile ? $has_picture = $profile->has_picture : $has_picture = false;
251 251
 
252 252
     if (is_uploaded_file($_FILES['picture']['tmp_name'])) {
253 253
         $has_picture = true;
@@ -262,13 +262,13 @@  discard block
 block discarded – undo
262 262
 
263 263
         // Write the original image file to disk.
264 264
         // TODO: define a constant for image quality.
265
-        ImageJPEG($images[0], IMAGE_PATH . $user->id . '.jpg');
266
-        ImageJPEG($images[1], IMAGE_PATH . $user->id . '_sm.jpg');
265
+        ImageJPEG($images[0], IMAGE_PATH.$user->id.'.jpg');
266
+        ImageJPEG($images[1], IMAGE_PATH.$user->id.'_sm.jpg');
267 267
     }
268 268
     $response1 = sanitize_html($response1);
269 269
     $response2 = sanitize_html($response2);
270 270
 
271
-    $has_picture = $has_picture?1:0;
271
+    $has_picture = $has_picture ? 1 : 0;
272 272
     if ($profile) {
273 273
         $query = " response1 = '".BoincDb::escape_string($response1)."',"
274 274
             ." response2 = '".BoincDb::escape_string($response2)."',"
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
     page_tail();
311 311
 }
312 312
 
313
-function show_profile_form($profile, $warning=null) {
313
+function show_profile_form($profile, $warning = null) {
314 314
     if ($profile) {
315 315
         page_head(tra("Edit your profile"), null, null, null, boinc_recaptcha_get_head_extra());
316 316
     } else {
Please login to merge, or discard this patch.
html/inc/delete_account.inc 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 if (!defined("DELETE_DELAY")) define("DELETE_DELAY", 2);
43 43
 
44 44
 function is_delete_account_token_valid($userid, $token) {
45
-    if (!is_valid_token($userid, $token, TOKEN_TYPE_DELETE_ACCOUNT) ) {
45
+    if (!is_valid_token($userid, $token, TOKEN_TYPE_DELETE_ACCOUNT)) {
46 46
         sleep(LOGIN_FAIL_SLEEP_SEC);
47 47
         return false;
48 48
     }
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 //
127 127
 function is_over_but_not_validated($res) {
128 128
     if ($res->server_state == RESULT_SERVER_STATE_OVER && $res->outcome == RESULT_OUTCOME_SUCCESS &&
129
-            ($res->validate_state == VALIDATE_STATE_INIT || $res->validate_state == VALIDATE_STATE_INCONCLUSIVE) ) {
129
+            ($res->validate_state == VALIDATE_STATE_INIT || $res->validate_state == VALIDATE_STATE_INCONCLUSIVE)) {
130 130
         return true;
131 131
     }    
132 132
     return false;
@@ -144,8 +144,8 @@  discard block
 block discarded – undo
144 144
 //
145 145
 function cancel_results_for_user($user) {
146 146
     $ress = BoincResult::enum("userid = $user->id");
147
-    $cancel_clause="server_state=".RESULT_SERVER_STATE_OVER.", outcome=".RESULT_OUTCOME_CLIENT_DETACHED.", validate_state=".VALIDATE_STATE_INVALID;
148
-    $set_id_clause="hostid=0, userid=0";
147
+    $cancel_clause = "server_state=".RESULT_SERVER_STATE_OVER.", outcome=".RESULT_OUTCOME_CLIENT_DETACHED.", validate_state=".VALIDATE_STATE_INVALID;
148
+    $set_id_clause = "hostid=0, userid=0";
149 149
     foreach ($ress as $res) {
150 150
         if (is_in_progress($res) || is_over_but_not_validated($res)) {
151 151
             $res->update($cancel_clause.", ".$set_id_clause);
@@ -168,12 +168,12 @@  discard block
 block discarded – undo
168 168
 
169 169
     // delete remote submit user
170 170
     //
171
-    delete_remote_submit_user($user);  // from submit_util.inc
171
+    delete_remote_submit_user($user); // from submit_util.inc
172 172
     
173 173
     // remove user's team records
174 174
     //
175
-    user_erase_team_owner($user);      // from team.inc
176
-    user_quit_team($user);        // from team.inc
175
+    user_erase_team_owner($user); // from team.inc
176
+    user_quit_team($user); // from team.inc
177 177
     user_erase_team_delta($user); // from team.inc
178 178
     
179 179
     // Items that do not have logic elsewhere
@@ -199,6 +199,6 @@  discard block
 block discarded – undo
199 199
     BoincConsent::delete_for_user($user->id);
200 200
 
201 201
     // final action
202
-    delete_user($user);  //from user_util.inc
202
+    delete_user($user); //from user_util.inc
203 203
     return 0;
204 204
 }
Please login to merge, or discard this patch.
default/boinc/modules/boincuser/boincuser_quote/boincuser_quote.module 3 patches
Braces   +1 added lines, -2 removed lines patch added patch discarded remove patch
@@ -53,8 +53,7 @@
 block discarded – undo
53 53
             $boincusername = (!empty($account)) ? $account->boincuser_name : variable_get('anonymous', 'Anonymous');
54 54
             $replace = TRUE;
55 55
           }
56
-        }
57
-        elseif ($nid && _quote_variable_get('node_link_display')) {
56
+        } elseif ($nid && _quote_variable_get('node_link_display')) {
58 57
           $node = node_load(array('nid' => $nid));
59 58
           if (in_array($node->type, _quote_variable_get('node_types'))) {
60 59
             $account = user_load($node->uid);
Please login to merge, or discard this patch.
Upper-Lower-Casing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -45,13 +45,13 @@  discard block
 block discarded – undo
45 45
         $nid = arg(2);
46 46
         $cid = arg(3);
47 47
 
48
-        $replace = FALSE;
48
+        $replace = false;
49 49
         if ($cid) {
50 50
           $comment = db_fetch_object(db_query('SELECT c.*, u.uid, u.name AS registered_name FROM {comments} c INNER JOIN {users} u ON c.uid = u.uid WHERE c.cid = %d AND c.status = 0', $cid));
51 51
           if ($comment->uid) {
52 52
             $account = user_load($comment->uid);
53 53
             $boincusername = (!empty($account)) ? $account->boincuser_name : variable_get('anonymous', 'Anonymous');
54
-            $replace = TRUE;
54
+            $replace = true;
55 55
           }
56 56
         }
57 57
         elseif ($nid && _quote_variable_get('node_link_display')) {
@@ -59,7 +59,7 @@  discard block
 block discarded – undo
59 59
           if (in_array($node->type, _quote_variable_get('node_types'))) {
60 60
             $account = user_load($node->uid);
61 61
             $boincusername = (!empty($account)) ? $account->boincuser_name : variable_get('anonymous', 'Anonymous');
62
-            $replace = TRUE;
62
+            $replace = true;
63 63
           }
64 64
         }
65 65
 
Please login to merge, or discard this patch.
Indentation   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -31,43 +31,43 @@
 block discarded – undo
31 31
  */
32 32
 
33 33
 function boincuser_quote_form_alter(&$form, $form_state, $form_id) {
34
-  switch ($form_id) {
35
-  // Comment form
36
-  case 'comment_form':
34
+    switch ($form_id) {
35
+    // Comment form
36
+    case 'comment_form':
37 37
     // If there is a quote as part of the comment body, replace the
38 38
     // first instance of quote=author with quote=boincusername. This
39 39
     // is done with regexp.
40 40
     // Modify for quotes only
41 41
     if ((isset($_POST['quote']) || isset($_GET['quote']) && $_GET['quote'])) {
42
-      // If default_value is already set, then modify it
43
-      if (isset($form['comment_filter']['comment']['#default_value'])) {
42
+        // If default_value is already set, then modify it
43
+        if (isset($form['comment_filter']['comment']['#default_value'])) {
44 44
         $nid = arg(2);
45 45
         $cid = arg(3);
46 46
 
47 47
         $replace = FALSE;
48 48
         if ($cid) {
49
-          $comment = db_fetch_object(db_query('SELECT c.*, u.uid, u.name AS registered_name FROM {comments} c INNER JOIN {users} u ON c.uid = u.uid WHERE c.cid = %d AND c.status = 0', $cid));
50
-          if ($comment->uid) {
49
+            $comment = db_fetch_object(db_query('SELECT c.*, u.uid, u.name AS registered_name FROM {comments} c INNER JOIN {users} u ON c.uid = u.uid WHERE c.cid = %d AND c.status = 0', $cid));
50
+            if ($comment->uid) {
51 51
             $account = user_load($comment->uid);
52 52
             $boincusername = (!empty($account)) ? $account->boincuser_name : variable_get('anonymous', 'Anonymous');
53 53
             $replace = TRUE;
54
-          }
54
+            }
55 55
         }
56 56
         elseif ($nid && _quote_variable_get('node_link_display')) {
57
-          $node = node_load(array('nid' => $nid));
58
-          if (in_array($node->type, _quote_variable_get('node_types'))) {
57
+            $node = node_load(array('nid' => $nid));
58
+            if (in_array($node->type, _quote_variable_get('node_types'))) {
59 59
             $account = user_load($node->uid);
60 60
             $boincusername = (!empty($account)) ? $account->boincuser_name : variable_get('anonymous', 'Anonymous');
61 61
             $replace = TRUE;
62
-          }
62
+            }
63 63
         }
64 64
 
65 65
         // Replace the quoted author name (drupal name) with BOINC username.
66 66
         if ($replace) {
67
-          $form['comment_filter']['comment']['#default_value'] = preg_replace("/\[quote=(.*?)\]/", "[quote=${boincusername}]", $form['comment_filter']['comment']['#default_value'], 1);
67
+            $form['comment_filter']['comment']['#default_value'] = preg_replace("/\[quote=(.*?)\]/", "[quote=${boincusername}]", $form['comment_filter']['comment']['#default_value'], 1);
68
+        }
68 69
         }
69
-      }
70 70
     }
71 71
     break;
72
-  }
72
+    }
73 73
 }
Please login to merge, or discard this patch.
drupal/sites/default/boinc/modules/boincuser/includes/boincuser.forms.inc 4 patches
Braces   +4 added lines, -7 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@  discard block
 block discarded – undo
145 145
 /**
146 146
  * Create BOINC account
147 147
  */
148
-function boincuser_register_make_user($params) {    
148
+function boincuser_register_make_user($params) {
149 149
   // Include BOINC user library
150 150
   require_boinc('user_util');
151 151
   // Create the BOINC user
@@ -343,8 +343,7 @@  discard block
 block discarded – undo
343 343
   if (!$account) {
344 344
     global $user;
345 345
     $account = user_load($user->id);
346
-  }
347
-  elseif (is_numeric($account)) {
346
+  } elseif (is_numeric($account)) {
348 347
     $account = user_load($account);
349 348
   }
350 349
   
@@ -420,13 +419,11 @@  discard block
 block discarded – undo
420 419
     // (except in cases where password is being reset)
421 420
     if (isset($_SESSION['reset_pass'])) {
422 421
       unset($_SESSION['reset_pass']);
423
-    }
424
-    else {
422
+    } else {
425 423
       $given_hash = md5($edit['current_pass'] . strtolower($account->mail));
426 424
       if (!$edit['current_pass']) {
427 425
         form_set_error('current_pass', bts('Authentication is required when changing E-mail address or setting new password.', array(), NULL, 'boinc:account-credentials-change'));
428
-      }
429
-      elseif ( (!password_verify($given_hash, $boinc_user->passwd_hash)) and ($given_hash != $boinc_user->passwd_hash) ) {
426
+      } elseif ( (!password_verify($given_hash, $boinc_user->passwd_hash)) and ($given_hash != $boinc_user->passwd_hash) ) {
430 427
         form_set_error('current_pass', bts('Password entered is not valid. Please verify that it is correct.', array(), NULL, 'boinc:account-credentials-change'));
431 428
       }
432 429
 
Please login to merge, or discard this patch.
Spacing   +39 added lines, -39 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
   // Call our custom authentication function to check for an existing BOINC user
36 36
   if (!boincuser_login_authenticate($form_state['values'])) {
37 37
     // Authentication failed; set an error accordingly
38
-    form_set_error('name', bts('Sorry, unrecognized email address or password.', array(), NULL, 'boinc:forgot-password') . ' ' . l(bts('Have you forgotten your password?', array(), NULL, 'boinc:forgot-password'), 'user/password'));
38
+    form_set_error('name', bts('Sorry, unrecognized email address or password.', array(), NULL, 'boinc:forgot-password').' '.l(bts('Have you forgotten your password?', array(), NULL, 'boinc:forgot-password'), 'user/password'));
39 39
   }
40 40
 }
41 41
 
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
   } else {
85 85
     // Create a Drupal user from the BOINC user
86 86
     if ($user = boincuser_register_make_drupal_user($boinc_user)) {
87
-      watchdog('user', 'New external user: %email using module %module.', array('%email' => $email_addr, '%module' => $module), WATCHDOG_NOTICE, l(t('edit'), 'user/'. $user->uid .'/edit'));
87
+      watchdog('user', 'New external user: %email using module %module.', array('%email' => $email_addr, '%module' => $module), WATCHDOG_NOTICE, l(t('edit'), 'user/'.$user->uid.'/edit'));
88 88
     }
89 89
   }
90 90
 }
@@ -394,14 +394,14 @@  discard block
 block discarded – undo
394 394
     // set email address lower-case
395 395
     $edit['mail'] = strtolower($edit['mail']);
396 396
 
397
-    $boinc_user_already_exists = ( BoincUser::lookup_email_addr($edit['mail']) || BoincUser::lookup_prev_email_addr($edit['mail']) );
397
+    $boinc_user_already_exists = (BoincUser::lookup_email_addr($edit['mail']) || BoincUser::lookup_prev_email_addr($edit['mail']));
398 398
     if ($boinc_user_already_exists) {
399 399
       form_set_error('mail', bts('A BOINC account already exists for @email.', array('@email' => $edit['mail']), NULL, 'boinc:add-new-user'));
400 400
     }
401 401
 
402 402
     // Check email has not been changed in last X days (default X=7).
403
-    $duration = 86400 * 7;
404
-    if ( (($boinc_user->email_addr_change_time + $duration) > time()) and (!(user_access('administer users'))) ) {
403
+    $duration = 86400*7;
404
+    if ((($boinc_user->email_addr_change_time + $duration) > time()) and (!(user_access('administer users')))) {
405 405
       form_set_error('email_addr_change_time',
406 406
         bts('Your email address was changed within the past seven (7) days. You must wait until !futuredate to change your email again. If you need to reverse this change, please look for an email sent to !prev_email_addr.',
407 407
         array(
@@ -422,11 +422,11 @@  discard block
 block discarded – undo
422 422
       unset($_SESSION['reset_pass']);
423 423
     }
424 424
     else {
425
-      $given_hash = md5($edit['current_pass'] . strtolower($account->mail));
425
+      $given_hash = md5($edit['current_pass'].strtolower($account->mail));
426 426
       if (!$edit['current_pass']) {
427 427
         form_set_error('current_pass', bts('Authentication is required when changing E-mail address or setting new password.', array(), NULL, 'boinc:account-credentials-change'));
428 428
       }
429
-      elseif ( (!password_verify($given_hash, $boinc_user->passwd_hash)) and ($given_hash != $boinc_user->passwd_hash) ) {
429
+      elseif ((!password_verify($given_hash, $boinc_user->passwd_hash)) and ($given_hash != $boinc_user->passwd_hash)) {
430 430
         form_set_error('current_pass', bts('Password entered is not valid. Please verify that it is correct.', array(), NULL, 'boinc:account-credentials-change'));
431 431
       }
432 432
 
@@ -489,29 +489,29 @@  discard block
 block discarded – undo
489 489
   $project_domain = $headers['Host'];
490 490
   $form['heading'] = array(
491 491
     '#type' => 'markup',
492
-    '#value' => '<h3>' . bts("If you forgot your account's email address, or you can't receive email there:", array(), NULL, 'boinc:authenticator-login-page') . '</h3>'
492
+    '#value' => '<h3>'.bts("If you forgot your account's email address, or you can't receive email there:", array(), NULL, 'boinc:authenticator-login-page').'</h3>'
493 493
   );
494 494
   $form['instructions'] = array(
495 495
     '#type' => 'markup',
496
-    '#value' => '' .
497
-      '<p>' . bts("If you have run BOINC under the account, you can still access it. Here's how:", array(), NULL, 'boinc:authenticator-login-page') .
498
-      '  <ul>' .
499
-      '    <li>' . bts('Go to the BOINC data directory on your computer (see !boinc_wiki for help finding this).', array('!boinc_wiki' => l(bts('BOINC documentation', array(), NULL, 'boinc:authenticator-login-page'), 'http://boinc.berkeley.edu/wiki/BOINC_Data_directory')), NULL, 'boinc:authenticator-login-page') . '</li>' .
500
-      '    <li>' . bts('Find your account file for this project; it will have a name like %file (where the project URL is %url).', array('%file' => "account_{$project_domain}.xml", '%url' => "http://{$project_domain}"), NULL, 'boinc:authenticator-login-page') . '</li>' .
501
-      '    <li>' . bts("Open the file in a text editor like Notepad. You'll see something like:", array(), NULL, 'boinc:authenticator-login-page') .
502
-      '      <pre>' .
503
-      '&lt;account&gt;' . "\n" .
504
-      "  &lt;master_url&gt;http://{$project_domain}/&lt;/master_url&gt;" . "\n" .
505
-      '  &lt;authenticator&gt;8b8496fdd26df7dc0423ecd43c09a56b&lt;/authenticator&gt;' . "\n" .
506
-      "  &lt;project_name&gt;{$project_name}&lt;/project_name&gt;" . "\n" .
507
-      '  ...' . "\n" .
508
-      '&lt;/account&gt;' .
509
-      '      </pre>' .
510
-      '    </li>' .
511
-      '    <li>' . bts('Select and Copy the string between &lt;authenticator&gt; and &lt;/authenticator&gt; (%auth in the above example).', array('%auth' => '8b8496fdd26df7dc0423ecd43c09a56b'), NULL, 'boinc:authenticator-login-page') . '</li>' .
512
-      '    <li>' . bts('Paste the string into the field below, and click OK.', array(), NULL, 'boinc:authenticator-login-page') . '</li>' .
513
-      '    <li>' . bts('You will now be logged in to your account; update the email and password of your account.', array(), NULL, 'boinc:authenticator-login-page') . '</li>' .
514
-      '  </ul>' .
496
+    '#value' => ''.
497
+      '<p>'.bts("If you have run BOINC under the account, you can still access it. Here's how:", array(), NULL, 'boinc:authenticator-login-page').
498
+      '  <ul>'.
499
+      '    <li>'.bts('Go to the BOINC data directory on your computer (see !boinc_wiki for help finding this).', array('!boinc_wiki' => l(bts('BOINC documentation', array(), NULL, 'boinc:authenticator-login-page'), 'http://boinc.berkeley.edu/wiki/BOINC_Data_directory')), NULL, 'boinc:authenticator-login-page').'</li>'.
500
+      '    <li>'.bts('Find your account file for this project; it will have a name like %file (where the project URL is %url).', array('%file' => "account_{$project_domain}.xml", '%url' => "http://{$project_domain}"), NULL, 'boinc:authenticator-login-page').'</li>'.
501
+      '    <li>'.bts("Open the file in a text editor like Notepad. You'll see something like:", array(), NULL, 'boinc:authenticator-login-page').
502
+      '      <pre>'.
503
+      '&lt;account&gt;'."\n".
504
+      "  &lt;master_url&gt;http://{$project_domain}/&lt;/master_url&gt;"."\n".
505
+      '  &lt;authenticator&gt;8b8496fdd26df7dc0423ecd43c09a56b&lt;/authenticator&gt;'."\n".
506
+      "  &lt;project_name&gt;{$project_name}&lt;/project_name&gt;"."\n".
507
+      '  ...'."\n".
508
+      '&lt;/account&gt;'.
509
+      '      </pre>'.
510
+      '    </li>'.
511
+      '    <li>'.bts('Select and Copy the string between &lt;authenticator&gt; and &lt;/authenticator&gt; (%auth in the above example).', array('%auth' => '8b8496fdd26df7dc0423ecd43c09a56b'), NULL, 'boinc:authenticator-login-page').'</li>'.
512
+      '    <li>'.bts('Paste the string into the field below, and click OK.', array(), NULL, 'boinc:authenticator-login-page').'</li>'.
513
+      '    <li>'.bts('You will now be logged in to your account; update the email and password of your account.', array(), NULL, 'boinc:authenticator-login-page').'</li>'.
514
+      '  </ul>'.
515 515
       '</p>'
516 516
   );
517 517
   $form['authenticator'] = array(
@@ -536,7 +536,7 @@  discard block
 block discarded – undo
536 536
     '#weight' => 1002,
537 537
   );
538 538
   $form['form control tabs'] = array(
539
-    '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/password') . '</li>',
539
+    '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/password').'</li>',
540 540
     '#weight' => 1003,
541 541
   );
542 542
   $form['form control tabs suffix'] = array(
@@ -599,7 +599,7 @@  discard block
 block discarded – undo
599 599
     '#weight' => 1002,
600 600
   );
601 601
   $form['form control tabs'] = array(
602
-    '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/{$uid}") . '</li>',
602
+    '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/{$uid}").'</li>',
603 603
     '#weight' => 1003,
604 604
   );
605 605
   $form['form control tabs suffix'] = array(
@@ -650,7 +650,7 @@  discard block
 block discarded – undo
650 650
     '#weight' => 1002,
651 651
   );
652 652
   $form['form control tabs'] = array(
653
-    '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/{$uid}") . '</li>',
653
+    '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/{$uid}").'</li>',
654 654
     '#weight' => 1003,
655 655
   );
656 656
   $form['form control tabs suffix'] = array(
@@ -667,7 +667,7 @@  discard block
 block discarded – undo
667 667
   $uid = $form_state['storage']['ban_user_uid'];
668 668
   $reason = $form_state['values']['reason'];
669 669
   $duration = $form_state['values']['duration'];
670
-  if ($duration) $duration = $duration * 24*60*60;
670
+  if ($duration) $duration = $duration*24*60*60;
671 671
   boincuser_moderate_user_ban($uid, $reason, $duration);
672 672
 }
673 673
 
@@ -694,10 +694,10 @@  discard block
 block discarded – undo
694 694
     drupal_goto();
695 695
   }
696 696
 
697
-  drupal_set_message( bts('WARNING: You have not agreed to our terms of use. Please agree to the terms of use before continuing.', array(), NULL, 'boinc:termsofuse-form'), 'warning' );
697
+  drupal_set_message(bts('WARNING: You have not agreed to our terms of use. Please agree to the terms of use before continuing.', array(), NULL, 'boinc:termsofuse-form'), 'warning');
698 698
 
699 699
   $form = array();
700
-  drupal_add_js(drupal_get_path('module', 'boincuser') . '/boincuser.js');
700
+  drupal_add_js(drupal_get_path('module', 'boincuser').'/boincuser.js');
701 701
   $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
702 702
 
703 703
   // Fieldset to hold all of the form as a container
@@ -710,7 +710,7 @@  discard block
 block discarded – undo
710 710
 
711 711
   $form['termsofuse']['title1'] = array(
712 712
     '#weight' => -12,
713
-    '#value' => '<h2>' . bts( variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), NULL, 'project:termsofuse-form' ) . '</h2>',
713
+    '#value' => '<h2>'.bts(variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), NULL, 'project:termsofuse-form').'</h2>',
714 714
     '#prefix' => '<div id="register-title1">',
715 715
     '#suffix' => '</div>',
716 716
   );
@@ -745,12 +745,12 @@  discard block
 block discarded – undo
745 745
     '#suffix' => '</li>',
746 746
   );
747 747
   $form['form control tabs'] = array(
748
-    '#value' => '<li class="tab">' . l(bts('NO - LOGOUT', array(), NULL, 'boinc:form-cancel'), '/logout') . '</li>',
748
+    '#value' => '<li class="tab">'.l(bts('NO - LOGOUT', array(), NULL, 'boinc:form-cancel'), '/logout').'</li>',
749 749
   );
750 750
   if (module_exists('boincuser_delete')) {
751
-    $deletelink = '/user/' . $user->uid . '/delete';
751
+    $deletelink = '/user/'.$user->uid.'/delete';
752 752
     $form['deleteaccount'] = array(
753
-      '#value' => '<li class="tab">' . l(bts('NO - DELETE ACCOUNT', array(), NULL, 'boinc:form-delete-user'), $deletelink) . '</li>',
753
+      '#value' => '<li class="tab">'.l(bts('NO - DELETE ACCOUNT', array(), NULL, 'boinc:form-delete-user'), $deletelink).'</li>',
754 754
     );
755 755
   }
756 756
 
@@ -843,7 +843,7 @@  discard block
 block discarded – undo
843 843
   $form['buttons']['submit']['#suffix'] = '</li>';
844 844
   $form['buttons']['submit']['#weight'] = 1002;
845 845
   $form['buttons']['cancel'] = array(
846
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/info/edit') . '</li>',
846
+      '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/info/edit').'</li>',
847 847
       '#weight' => 1005,
848 848
   );
849 849
   $form['buttons']['form control tabs suffix'] = array(
@@ -887,7 +887,7 @@  discard block
 block discarded – undo
887 887
 
888 888
   // Set new password based on previous email address and entered
889 889
   // password.
890
-  $new_passwd_hash = password_hash( md5($form_state['values']['pass'].$pem), PASSWORD_DEFAULT);
890
+  $new_passwd_hash = password_hash(md5($form_state['values']['pass'].$pem), PASSWORD_DEFAULT);
891 891
 
892 892
   $boinc_user->update("email_addr='${pem}', previous_email_addr='', email_addr_change_time=0, passwd_hash='${new_passwd_hash}'");
893 893
 
Please login to merge, or discard this patch.
Upper-Lower-Casing   +67 added lines, -67 removed lines patch added patch discarded remove patch
@@ -35,7 +35,7 @@  discard block
 block discarded – undo
35 35
   // Call our custom authentication function to check for an existing BOINC user
36 36
   if (!boincuser_login_authenticate($form_state['values'])) {
37 37
     // Authentication failed; set an error accordingly
38
-    form_set_error('name', bts('Sorry, unrecognized email address or password.', array(), NULL, 'boinc:forgot-password') . ' ' . l(bts('Have you forgotten your password?', array(), NULL, 'boinc:forgot-password'), 'user/password'));
38
+    form_set_error('name', bts('Sorry, unrecognized email address or password.', array(), null, 'boinc:forgot-password') . ' ' . l(bts('Have you forgotten your password?', array(), null, 'boinc:forgot-password'), 'user/password'));
39 39
   }
40 40
 }
41 41
 
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
   $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
106 106
   if (!empty($termsofuse)) {
107 107
     if (!$form_state['values']['termsofuse']['agreeTOU']) {
108
-      form_set_error('termsofuse', bts('ERROR: You must acknowledge our terms of use by clicking the checkbox before registering for an account.', NULL, 'boinc:register-new-user'));
108
+      form_set_error('termsofuse', bts('ERROR: You must acknowledge our terms of use by clicking the checkbox before registering for an account.', null, 'boinc:register-new-user'));
109 109
       return false;
110 110
     }
111 111
   }
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
         array(
122 122
           '@email' => $lower_email_addr,
123 123
           '@project' => variable_get('site_name', 'Drupal-BOINC')
124
-        ), NULL, 'boinc:register-new-user')
124
+        ), null, 'boinc:register-new-user')
125 125
     );
126 126
   }
127 127
 
@@ -133,7 +133,7 @@  discard block
 block discarded – undo
133 133
   $boinc_user = BoincUser::lookup_email_addr($lower_email_addr);
134 134
   if ($boinc_user) {
135 135
     // User already exists
136
-    form_set_error('mail', bts('An account already exists for @email. Log in or request password assistance to access your @project account.', array('@email' => $lower_email_addr, '@project' => PROJECT), NULL, 'boinc:add-new-user'));
136
+    form_set_error('mail', bts('An account already exists for @email. Log in or request password assistance to access your @project account.', array('@email' => $lower_email_addr, '@project' => PROJECT), null, 'boinc:add-new-user'));
137 137
     return false;
138 138
   }
139 139
 
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
 function boincuser_create_drupal_user($boinc_user) {
176 176
   require_boinc('forum_db');
177 177
   BoincForumPrefs::lookup($boinc_user);
178
-  $account = NULL;
178
+  $account = null;
179 179
   $module = 'boincuser';
180 180
   
181 181
   // Verify that this account has not already been imported
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
     $boinc_user->id)
185 185
   );
186 186
   if ($already_imported) {
187
-    return NULL;
187
+    return null;
188 188
   }
189 189
   
190 190
   // Email is limited to 64 characters...
@@ -198,7 +198,7 @@  discard block
 block discarded – undo
198 198
   if ($already_imported) {
199 199
     drupal_set_message(t('An account for @email already exists', array('@email' => $boinc_email)), 'warning');
200 200
     watchdog('boincimport', 'An account for @email already exists', array('@email' => $boinc_email), WATCHDOG_WARNING); 
201
-    return NULL;
201
+    return null;
202 202
   }
203 203
   
204 204
   // Make sure name is unique
@@ -236,7 +236,7 @@  discard block
 block discarded – undo
236 236
   // Terminate if an error occured during user_save().
237 237
   if (!$account) {
238 238
     drupal_set_message(t("Error saving user account."), 'error');
239
-    return NULL;
239
+    return null;
240 240
   }
241 241
   
242 242
   // Cross reference the Drupal and BOINC accounts
@@ -267,7 +267,7 @@  discard block
 block discarded – undo
267 267
   $profile_opinions = null;
268 268
   $profile_image = null;
269 269
   $avatar_image = null;
270
-  $profile_approved = NULL;
270
+  $profile_approved = null;
271 271
   
272 272
   // Load the BOINC profile, if available
273 273
   if ($boinc_user->has_profile) {
@@ -277,17 +277,17 @@  discard block
 block discarded – undo
277 277
     if ($boinc_profile->has_picture) {
278 278
       // Load picture; load validators; determine where to store it in Drupal
279 279
       $image_path = "{$image_dir}/{$boinc_user->id}.jpg";
280
-      $profile_image = get_cck_image_object($image_path, 'field_profile_image', 'profile', TRUE);
280
+      $profile_image = get_cck_image_object($image_path, 'field_profile_image', 'profile', true);
281 281
       // If the user does not have a different image as an avatar, use this one
282 282
       if (!$boinc_user->prefs->avatar) {
283
-        $avatar_image = get_cck_image_object($image_path, 'field_image', 'profile', TRUE);
283
+        $avatar_image = get_cck_image_object($image_path, 'field_image', 'profile', true);
284 284
       }
285 285
     }
286 286
     if ($boinc_user->prefs->avatar) {
287 287
       $image_path = "{$image_dir}/{$boinc_user->id}_avatar.jpg";
288
-      $avatar_image = get_cck_image_object($image_path, 'field_image', 'profile', TRUE);
288
+      $avatar_image = get_cck_image_object($image_path, 'field_image', 'profile', true);
289 289
     }
290
-    $profile_approved = $boinc_profile->verification ? TRUE : FALSE;
290
+    $profile_approved = $boinc_profile->verification ? true : false;
291 291
   }
292 292
   $default_input_format = db_result(db_query("
293 293
     SELECT format FROM {filter_formats} WHERE name = '%s'", 'Rich text'));
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
   node_save($profile_node);
321 321
   
322 322
   // Mark profile as approved if it has already been vetted somehow
323
-  if ($profile_approved OR !$boinc_user->has_profile) {
323
+  if ($profile_approved or !$boinc_user->has_profile) {
324 324
     $profile_node->moderate = 0;
325 325
     node_save($profile_node);
326 326
   }
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
 /**
342 342
  * Convert any BOINC forum thread subscriptions to Drupal flag subscriptions
343 343
  */
344
-function boincuser_pull_subscriptions($account = NULL) {
344
+function boincuser_pull_subscriptions($account = null) {
345 345
   if (!$account) {
346 346
     global $user;
347 347
     $account = user_load($user->id);
@@ -385,7 +385,7 @@  discard block
 block discarded – undo
385 385
   // Include BOINC database objects library, load BOINC account data
386 386
   require_boinc('boinc_db');
387 387
   $boinc_user = BoincUser::lookup_email_addr($account->mail);
388
-  $changing_email = ($edit['mail'] AND $edit['mail'] != $account->mail) ? true : false;
388
+  $changing_email = ($edit['mail'] and $edit['mail'] != $account->mail) ? true : false;
389 389
   $changing_pass = ($edit['pass']) ? true : false;
390 390
   if ($changing_email) {
391 391
     // E-mail address is set to change; check for an existing BOINC user
@@ -398,7 +398,7 @@  discard block
 block discarded – undo
398 398
 
399 399
     $boinc_user_already_exists = ( BoincUser::lookup_email_addr($edit['mail']) || BoincUser::lookup_prev_email_addr($edit['mail']) );
400 400
     if ($boinc_user_already_exists) {
401
-      form_set_error('mail', bts('A BOINC account already exists for @email.', array('@email' => $edit['mail']), NULL, 'boinc:add-new-user'));
401
+      form_set_error('mail', bts('A BOINC account already exists for @email.', array('@email' => $edit['mail']), null, 'boinc:add-new-user'));
402 402
     }
403 403
 
404 404
     // Check email has not been changed in last X days (default X=7).
@@ -410,14 +410,14 @@  discard block
 block discarded – undo
410 410
           '!futuredate' => date('F j, Y \a\t H:i T', $boinc_user->email_addr_change_time + $duration),
411 411
           '!prev_email_addr' => $boinc_user->previous_email_addr,
412 412
         ),
413
-        NULL, 'boinc:account-credentials-change')
413
+        null, 'boinc:account-credentials-change')
414 414
       );
415 415
     }
416 416
   }
417 417
 
418 418
   // If user is changing email or password, require that the current
419 419
   // password has been given as well.
420
-  if (($changing_email OR $changing_pass) AND !user_access('administer users')) {
420
+  if (($changing_email or $changing_pass) and !user_access('administer users')) {
421 421
     // If changing email or password, require current password
422 422
     // (except in cases where password is being reset)
423 423
     if (isset($_SESSION['reset_pass'])) {
@@ -426,10 +426,10 @@  discard block
 block discarded – undo
426 426
     else {
427 427
       $given_hash = md5($edit['current_pass'] . strtolower($account->mail));
428 428
       if (!$edit['current_pass']) {
429
-        form_set_error('current_pass', bts('Authentication is required when changing E-mail address or setting new password.', array(), NULL, 'boinc:account-credentials-change'));
429
+        form_set_error('current_pass', bts('Authentication is required when changing E-mail address or setting new password.', array(), null, 'boinc:account-credentials-change'));
430 430
       }
431 431
       elseif ( (!password_verify($given_hash, $boinc_user->passwd_hash)) and ($given_hash != $boinc_user->passwd_hash) ) {
432
-        form_set_error('current_pass', bts('Password entered is not valid. Please verify that it is correct.', array(), NULL, 'boinc:account-credentials-change'));
432
+        form_set_error('current_pass', bts('Password entered is not valid. Please verify that it is correct.', array(), null, 'boinc:account-credentials-change'));
433 433
       }
434 434
 
435 435
     }
@@ -437,8 +437,8 @@  discard block
 block discarded – undo
437 437
 
438 438
   // If an admin tries to change the email and NOT the password, show
439 439
   // error message. BOINC requires both to be changed together.
440
-  if ($changing_email AND !$changing_pass AND user_access('administer users')) {
441
-    form_set_error('pass', bts('If changing a user\'s email, you must also change the password simultaneously.', array(), NULL, 'boinc:account-credentials-change'));
440
+  if ($changing_email and !$changing_pass and user_access('administer users')) {
441
+    form_set_error('pass', bts('If changing a user\'s email, you must also change the password simultaneously.', array(), null, 'boinc:account-credentials-change'));
442 442
   }
443 443
   
444 444
   // Expansion required to allow account key in place of passwd...?
@@ -457,8 +457,8 @@  discard block
 block discarded – undo
457 457
   $edit = $form_state['values'];
458 458
   // The Drupal submit function expects a "name" field, even though
459 459
   // it contains an email address and we will not allow a user name
460
-  if (!$edit['name']) form_set_error('name', bts('Please enter your email address', array(), NULL, 'boinc:forgot-password'));
461
-  elseif (!valid_email_address($edit['name'])) form_set_error('name', bts('@email is not a well formed email address, please verify', array('@email' => $edit['name']), NULL, 'boinc:forgot-password'));
460
+  if (!$edit['name']) form_set_error('name', bts('Please enter your email address', array(), null, 'boinc:forgot-password'));
461
+  elseif (!valid_email_address($edit['name'])) form_set_error('name', bts('@email is not a well formed email address, please verify', array('@email' => $edit['name']), null, 'boinc:forgot-password'));
462 462
   else {
463 463
     // set email addrress to lower case
464 464
     $lower_email_addr = strtolower($edit['name']);
@@ -476,8 +476,8 @@  discard block
 block discarded – undo
476 476
       form_set_error('name', bts('No account exists for @email -- please create an account using a BOINC client -- !instructions',
477 477
       array(
478 478
           '@email' => $edit['name'],
479
-          '!instructions' => l(bts('Instructions', array(), NULL, 'boinc:forgot-password'), 'join')
480
-      ), NULL, 'boinc:forgot-password'));
479
+          '!instructions' => l(bts('Instructions', array(), null, 'boinc:forgot-password'), 'join')
480
+      ), null, 'boinc:forgot-password'));
481 481
     }
482 482
   }
483 483
 }
@@ -491,16 +491,16 @@  discard block
 block discarded – undo
491 491
   $project_domain = $headers['Host'];
492 492
   $form['heading'] = array(
493 493
     '#type' => 'markup',
494
-    '#value' => '<h3>' . bts("If you forgot your account's email address, or you can't receive email there:", array(), NULL, 'boinc:authenticator-login-page') . '</h3>'
494
+    '#value' => '<h3>' . bts("If you forgot your account's email address, or you can't receive email there:", array(), null, 'boinc:authenticator-login-page') . '</h3>'
495 495
   );
496 496
   $form['instructions'] = array(
497 497
     '#type' => 'markup',
498 498
     '#value' => '' .
499
-      '<p>' . bts("If you have run BOINC under the account, you can still access it. Here's how:", array(), NULL, 'boinc:authenticator-login-page') .
499
+      '<p>' . bts("If you have run BOINC under the account, you can still access it. Here's how:", array(), null, 'boinc:authenticator-login-page') .
500 500
       '  <ul>' .
501
-      '    <li>' . bts('Go to the BOINC data directory on your computer (see !boinc_wiki for help finding this).', array('!boinc_wiki' => l(bts('BOINC documentation', array(), NULL, 'boinc:authenticator-login-page'), 'http://boinc.berkeley.edu/wiki/BOINC_Data_directory')), NULL, 'boinc:authenticator-login-page') . '</li>' .
502
-      '    <li>' . bts('Find your account file for this project; it will have a name like %file (where the project URL is %url).', array('%file' => "account_{$project_domain}.xml", '%url' => "http://{$project_domain}"), NULL, 'boinc:authenticator-login-page') . '</li>' .
503
-      '    <li>' . bts("Open the file in a text editor like Notepad. You'll see something like:", array(), NULL, 'boinc:authenticator-login-page') .
501
+      '    <li>' . bts('Go to the BOINC data directory on your computer (see !boinc_wiki for help finding this).', array('!boinc_wiki' => l(bts('BOINC documentation', array(), null, 'boinc:authenticator-login-page'), 'http://boinc.berkeley.edu/wiki/BOINC_Data_directory')), null, 'boinc:authenticator-login-page') . '</li>' .
502
+      '    <li>' . bts('Find your account file for this project; it will have a name like %file (where the project URL is %url).', array('%file' => "account_{$project_domain}.xml", '%url' => "http://{$project_domain}"), null, 'boinc:authenticator-login-page') . '</li>' .
503
+      '    <li>' . bts("Open the file in a text editor like Notepad. You'll see something like:", array(), null, 'boinc:authenticator-login-page') .
504 504
       '      <pre>' .
505 505
       '&lt;account&gt;' . "\n" .
506 506
       "  &lt;master_url&gt;http://{$project_domain}/&lt;/master_url&gt;" . "\n" .
@@ -510,18 +510,18 @@  discard block
 block discarded – undo
510 510
       '&lt;/account&gt;' .
511 511
       '      </pre>' .
512 512
       '    </li>' .
513
-      '    <li>' . bts('Select and Copy the string between &lt;authenticator&gt; and &lt;/authenticator&gt; (%auth in the above example).', array('%auth' => '8b8496fdd26df7dc0423ecd43c09a56b'), NULL, 'boinc:authenticator-login-page') . '</li>' .
514
-      '    <li>' . bts('Paste the string into the field below, and click OK.', array(), NULL, 'boinc:authenticator-login-page') . '</li>' .
515
-      '    <li>' . bts('You will now be logged in to your account; update the email and password of your account.', array(), NULL, 'boinc:authenticator-login-page') . '</li>' .
513
+      '    <li>' . bts('Select and Copy the string between &lt;authenticator&gt; and &lt;/authenticator&gt; (%auth in the above example).', array('%auth' => '8b8496fdd26df7dc0423ecd43c09a56b'), null, 'boinc:authenticator-login-page') . '</li>' .
514
+      '    <li>' . bts('Paste the string into the field below, and click OK.', array(), null, 'boinc:authenticator-login-page') . '</li>' .
515
+      '    <li>' . bts('You will now be logged in to your account; update the email and password of your account.', array(), null, 'boinc:authenticator-login-page') . '</li>' .
516 516
       '  </ul>' .
517 517
       '</p>'
518 518
   );
519 519
   $form['authenticator'] = array(
520
-    '#title' => bts('Log in with authenticator', array(), NULL, 'boinc:authenticator-login-page'),
520
+    '#title' => bts('Log in with authenticator', array(), null, 'boinc:authenticator-login-page'),
521 521
     '#type' => 'textfield',
522 522
     '#size' => 60,
523 523
     '#maxlength' => 32,
524
-    '#required' => TRUE,
524
+    '#required' => true,
525 525
     '#description' => null
526 526
   );
527 527
   
@@ -533,12 +533,12 @@  discard block
 block discarded – undo
533 533
   $form['submit'] = array(
534 534
     '#prefix' => '<li class="first tab">',
535 535
     '#type' => 'submit',
536
-    '#value' => bts('OK', array(), NULL, 'boinc:form-ok'),
536
+    '#value' => bts('OK', array(), null, 'boinc:form-ok'),
537 537
     '#suffix' => '</li>',
538 538
     '#weight' => 1002,
539 539
   );
540 540
   $form['form control tabs'] = array(
541
-    '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/password') . '</li>',
541
+    '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), 'user/password') . '</li>',
542 542
     '#weight' => 1003,
543 543
   );
544 544
   $form['form control tabs suffix'] = array(
@@ -555,11 +555,11 @@  discard block
 block discarded – undo
555 555
   $authenticator = $form_state['values']['authenticator'];
556 556
   if (strlen($authenticator) != 32) {
557 557
     // We notify the form API that this field has failed validation.
558
-    form_set_error('authenticator', bts('That authenticator is not valid.', array(), NULL, 'boinc:authenticator-login-page'));
558
+    form_set_error('authenticator', bts('That authenticator is not valid.', array(), null, 'boinc:authenticator-login-page'));
559 559
   } else {
560 560
     require_boinc('boinc_db');
561 561
     $boinc_user = BoincUser::lookup("authenticator='".addslashes($authenticator)."'");
562
-    if (!$boinc_user) form_set_error('authenticator', bts('There is no account with that authenticator.', array(), NULL, 'boinc:authenticator-login-page'));
562
+    if (!$boinc_user) form_set_error('authenticator', bts('There is no account with that authenticator.', array(), null, 'boinc:authenticator-login-page'));
563 563
   }
564 564
 }
565 565
 
@@ -582,9 +582,9 @@  discard block
 block discarded – undo
582 582
 function boincuser_moderate_profile_reject_form(&$form_state, $uid) {
583 583
   $form_state['storage']['reject_profile_uid'] = $uid;
584 584
   $form['reason'] = array(
585
-    '#title' => bts('Reason for rejecting this profile', array(), NULL, 'boinc:moderate-user'),
585
+    '#title' => bts('Reason for rejecting this profile', array(), null, 'boinc:moderate-user'),
586 586
     '#type' => 'textarea',
587
-    '#description' => bts('This reason will be included in an email to the user. Please write a brief explanation of the problem and how to fix it.', array(), NULL, 'boinc:moderate-user'),
587
+    '#description' => bts('This reason will be included in an email to the user. Please write a brief explanation of the problem and how to fix it.', array(), null, 'boinc:moderate-user'),
588 588
     '#default_value' => '',
589 589
   );
590 590
   
@@ -596,12 +596,12 @@  discard block
 block discarded – undo
596 596
   $form['submit'] = array(
597 597
     '#prefix' => '<li class="first tab">',
598 598
     '#type' => 'submit',
599
-    '#value' => bts('Submit', array(), NULL, 'boinc:form-submit'),
599
+    '#value' => bts('Submit', array(), null, 'boinc:form-submit'),
600 600
     '#suffix' => '</li>',
601 601
     '#weight' => 1002,
602 602
   );
603 603
   $form['form control tabs'] = array(
604
-    '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/{$uid}") . '</li>',
604
+    '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), "account/{$uid}") . '</li>',
605 605
     '#weight' => 1003,
606 606
   );
607 607
   $form['form control tabs suffix'] = array(
@@ -627,15 +627,15 @@  discard block
 block discarded – undo
627 627
 function boincuser_moderate_user_ban_form(&$form_state, $uid) {
628 628
   $form_state['storage']['ban_user_uid'] = $uid;
629 629
   $form['reason'] = array(
630
-    '#title' => bts('Reason for banning this user', array(), NULL, 'boinc:moderate-user'),
630
+    '#title' => bts('Reason for banning this user', array(), null, 'boinc:moderate-user'),
631 631
     '#type' => 'textarea',
632
-    '#description' => bts('This reason will be included in an email to the user. Please write a brief explanation of why the user is being banned.', array(), NULL, 'boinc:moderate-user'),
632
+    '#description' => bts('This reason will be included in an email to the user. Please write a brief explanation of why the user is being banned.', array(), null, 'boinc:moderate-user'),
633 633
     '#default_value' => '',
634 634
   );
635 635
   $form['duration'] = array(
636
-    '#title' => bts('Duration of the ban', array(), NULL, 'boinc:moderate-user'),
636
+    '#title' => bts('Duration of the ban', array(), null, 'boinc:moderate-user'),
637 637
     '#type' => 'textfield',
638
-    '#description' => bts('The number of days until the ban expires. Set to 0 to ban permanently.', array(), NULL, 'boinc:moderate-user'),
638
+    '#description' => bts('The number of days until the ban expires. Set to 0 to ban permanently.', array(), null, 'boinc:moderate-user'),
639 639
     '#default_value' => '',
640 640
   );
641 641
   
@@ -647,12 +647,12 @@  discard block
 block discarded – undo
647 647
   $form['submit'] = array(
648 648
     '#prefix' => '<li class="first tab">',
649 649
     '#type' => 'submit',
650
-    '#value' => bts('Submit', array(), NULL, 'boinc:form-submit'),
650
+    '#value' => bts('Submit', array(), null, 'boinc:form-submit'),
651 651
     '#suffix' => '</li>',
652 652
     '#weight' => 1002,
653 653
   );
654 654
   $form['form control tabs'] = array(
655
-    '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/{$uid}") . '</li>',
655
+    '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), "account/{$uid}") . '</li>',
656 656
     '#weight' => 1003,
657 657
   );
658 658
   $form['form control tabs suffix'] = array(
@@ -696,7 +696,7 @@  discard block
 block discarded – undo
696 696
     drupal_goto();
697 697
   }
698 698
 
699
-  drupal_set_message( bts('WARNING: You have not agreed to our terms of use. Please agree to the terms of use before continuing.', array(), NULL, 'boinc:termsofuse-form'), 'warning' );
699
+  drupal_set_message( bts('WARNING: You have not agreed to our terms of use. Please agree to the terms of use before continuing.', array(), null, 'boinc:termsofuse-form'), 'warning' );
700 700
 
701 701
   $form = array();
702 702
   drupal_add_js(drupal_get_path('module', 'boincuser') . '/boincuser.js');
@@ -707,12 +707,12 @@  discard block
 block discarded – undo
707 707
     '#type'   => 'fieldset',
708 708
     '#prefix' => '<div id="termsofuse-wrapper">', // This is our wrapper div.
709 709
     '#suffix' => '</div>',
710
-    '#tree'   => TRUE,
710
+    '#tree'   => true,
711 711
   );
712 712
 
713 713
   $form['termsofuse']['title1'] = array(
714 714
     '#weight' => -12,
715
-    '#value' => '<h2>' . bts( variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), NULL, 'project:termsofuse-form' ) . '</h2>',
715
+    '#value' => '<h2>' . bts( variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), null, 'project:termsofuse-form' ) . '</h2>',
716 716
     '#prefix' => '<div id="register-title1">',
717 717
     '#suffix' => '</div>',
718 718
   );
@@ -720,14 +720,14 @@  discard block
 block discarded – undo
720 720
   // Terms of use section
721 721
   $form['termsofuse']['body'] = array(
722 722
     '#weight' => -10,
723
-    '#value' => bts($termsofuse, array(), NULL, 'project:termsofuse-form'),
723
+    '#value' => bts($termsofuse, array(), null, 'project:termsofuse-form'),
724 724
     '#prefix' => '<div id="register-termsofuse">',
725 725
     '#suffix' => '</div>',
726 726
   );
727 727
 
728 728
   $form['termsofuse']['agreeTOU'] = array(
729 729
     '#type'   => 'checkbox',
730
-    '#title'  => bts(variable_get('boinc_weboptions_agreequestion', 'Do you agree with the above terms of use?'), array(), NULL, 'project:termsofuse-form'),
730
+    '#title'  => bts(variable_get('boinc_weboptions_agreequestion', 'Do you agree with the above terms of use?'), array(), null, 'project:termsofuse-form'),
731 731
     '#weight' => -8,
732 732
     '#prefix' => '<div id="register-checkbox">',
733 733
     '#suffix' => '</div>',
@@ -743,16 +743,16 @@  discard block
 block discarded – undo
743 743
   $form['submit'] = array(
744 744
     '#prefix' => '<p><p><p><li class="first tab" id="register-submit">',
745 745
     '#type' => 'submit',
746
-    '#value' => bts('Yes', array(), NULL, 'boinc:form-submit'),
746
+    '#value' => bts('Yes', array(), null, 'boinc:form-submit'),
747 747
     '#suffix' => '</li>',
748 748
   );
749 749
   $form['form control tabs'] = array(
750
-    '#value' => '<li class="tab">' . l(bts('NO - LOGOUT', array(), NULL, 'boinc:form-cancel'), '/logout') . '</li>',
750
+    '#value' => '<li class="tab">' . l(bts('NO - LOGOUT', array(), null, 'boinc:form-cancel'), '/logout') . '</li>',
751 751
   );
752 752
   if (module_exists('boincuser_delete')) {
753 753
     $deletelink = '/user/' . $user->uid . '/delete';
754 754
     $form['deleteaccount'] = array(
755
-      '#value' => '<li class="tab">' . l(bts('NO - DELETE ACCOUNT', array(), NULL, 'boinc:form-delete-user'), $deletelink) . '</li>',
755
+      '#value' => '<li class="tab">' . l(bts('NO - DELETE ACCOUNT', array(), null, 'boinc:form-delete-user'), $deletelink) . '</li>',
756 756
     );
757 757
   }
758 758
 
@@ -768,7 +768,7 @@  discard block
 block discarded – undo
768 768
 function boincuser_termsofuse_form_validate($form, &$form_state) {
769 769
   // Check TOU agreement
770 770
   if (!$form_state['values']['termsofuse']['agreeTOU']) {
771
-    form_set_error('termsofuse', bts('ERROR: You must acknowledge our terms of use by clicking the checkbox before registering for an account.', array(), NULL, 'boinc:termsofuse-form'));
771
+    form_set_error('termsofuse', bts('ERROR: You must acknowledge our terms of use by clicking the checkbox before registering for an account.', array(), null, 'boinc:termsofuse-form'));
772 772
   }
773 773
 }
774 774
 
@@ -777,7 +777,7 @@  discard block
 block discarded – undo
777 777
   if (!boincuser_consentto_termsofuse($user)) {
778 778
     form_set_error('termsofuse',
779 779
       bts('There was an error in agreeing to the terms of use. The @project administrators have been notified.',
780
-        array('@project' => variable_get('site_name', 'Drupal-BOINC')), NULL, 'boinc:termsofuse-form')
780
+        array('@project' => variable_get('site_name', 'Drupal-BOINC')), null, 'boinc:termsofuse-form')
781 781
     );
782 782
   }
783 783
 
@@ -810,9 +810,9 @@  discard block
 block discarded – undo
810 810
   if (!is_valid_token($boincid, $token, 'E')) {
811 811
     drupal_set_message(bts('ERROR: You have supplied an incorrect (most likely expired) token. Please obtain a new token by !link your email address.',
812 812
     array(
813
-      '!link' => l(bts('changing', array(), NULL, 'boinc:revert-email-change'), "/account/info/edit"),
813
+      '!link' => l(bts('changing', array(), null, 'boinc:revert-email-change'), "/account/info/edit"),
814 814
     ),
815
-    NULL, 'boinc:revert-email-change'), 'error');
815
+    null, 'boinc:revert-email-change'), 'error');
816 816
     drupal_goto();
817 817
   }
818 818
 
@@ -827,7 +827,7 @@  discard block
 block discarded – undo
827 827
       array(
828 828
         '!prev_email' => $account->boincuser_previous_email_addr,
829 829
       ),
830
-      NULL, 'boinc:revert-email-change').
830
+      null, 'boinc:revert-email-change').
831 831
     '</p>',
832 832
   );
833 833
 
@@ -844,11 +844,11 @@  discard block
 block discarded – undo
844 844
   );
845 845
   $form['buttons']['submit']['#type'] = 'submit';
846 846
   $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
847
-  $form['buttons']['submit']['#value'] = bts('Submit', array(), NULL, 'boinc:form-submit');
847
+  $form['buttons']['submit']['#value'] = bts('Submit', array(), null, 'boinc:form-submit');
848 848
   $form['buttons']['submit']['#suffix'] = '</li>';
849 849
   $form['buttons']['submit']['#weight'] = 1002;
850 850
   $form['buttons']['cancel'] = array(
851
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/info/edit') . '</li>',
851
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), 'user/info/edit') . '</li>',
852 852
       '#weight' => 1005,
853 853
   );
854 854
   $form['buttons']['form control tabs suffix'] = array(
@@ -874,7 +874,7 @@  discard block
 block discarded – undo
874 874
         array(
875 875
           '@email' => $boinc_user->previous_email_addr,
876 876
           '@project' => variable_get('site_name', 'Drupal-BOINC'),
877
-        ), NULL, 'boinc:add-new-user'));
877
+        ), null, 'boinc:add-new-user'));
878 878
   }
879 879
 
880 880
 }
Please login to merge, or discard this patch.
Indentation   +429 added lines, -429 removed lines patch added patch discarded remove patch
@@ -15,59 +15,59 @@  discard block
 block discarded – undo
15 15
  * Form validation handler for login
16 16
  */
17 17
 function boincuser_login_validate($form, &$form_state) {
18
-  /* // SAMPLE: To try validation with Drupal first...
18
+    /* // SAMPLE: To try validation with Drupal first...
19 19
   global $user;
20 20
   if (!empty($user->uid)) {
21 21
     // Authentication with Drupal was successful
22 22
     return;
23 23
   }*/
24 24
   
25
-  // Set name for logging purposes
26
-  $form_state['values']['name'] = $form_state['values']['email'];
25
+    // Set name for logging purposes
26
+    $form_state['values']['name'] = $form_state['values']['email'];
27 27
   
28
-  // Bypass BOINC validation if passed the name of user 1
29
-  $user_1 = user_load(1);
30
-  if ($form_state['values']['email'] == $user_1->name) {
28
+    // Bypass BOINC validation if passed the name of user 1
29
+    $user_1 = user_load(1);
30
+    if ($form_state['values']['email'] == $user_1->name) {
31 31
     user_authenticate($form_state['values']);
32 32
     return;
33
-  }
33
+    }
34 34
   
35
-  // Call our custom authentication function to check for an existing BOINC user
36
-  if (!boincuser_login_authenticate($form_state['values'])) {
35
+    // Call our custom authentication function to check for an existing BOINC user
36
+    if (!boincuser_login_authenticate($form_state['values'])) {
37 37
     // Authentication failed; set an error accordingly
38 38
     form_set_error('name', bts('Sorry, unrecognized email address or password.', array(), NULL, 'boinc:forgot-password') . ' ' . l(bts('Have you forgotten your password?', array(), NULL, 'boinc:forgot-password'), 'user/password'));
39
-  }
39
+    }
40 40
 }
41 41
 
42 42
 /**
43 43
  * Custom authentication function to check BOINC account information
44 44
  */
45 45
 function boincuser_login_authenticate($form_values) {
46
-  global $boincuser_authenticated;
47
-  $lower_email_addr = strtolower($form_values['email']);
48
-  $passwd = $form_values['pass'];
49
-  $passwd_hash = md5($passwd.$lower_email_addr);
46
+    global $boincuser_authenticated;
47
+    $lower_email_addr = strtolower($form_values['email']);
48
+    $passwd = $form_values['pass'];
49
+    $passwd_hash = md5($passwd.$lower_email_addr);
50 50
   
51
-  // Include BOINC user library
52
-  require_boinc('boinc_db');
53
-  require_boinc('user_util');
51
+    // Include BOINC user library
52
+    require_boinc('boinc_db');
53
+    require_boinc('user_util');
54 54
 
55
-  // Get the BOINC user and check credentials
56
-  $boinc_user = BoincUser::lookup_email_addr($lower_email_addr);
57
-  if (!$boinc_user) return false;
55
+    // Get the BOINC user and check credentials
56
+    $boinc_user = BoincUser::lookup_email_addr($lower_email_addr);
57
+    if (!$boinc_user) return false;
58 58
 
59
-  if (!check_passwd_hash($boinc_user, $passwd_hash)) {
59
+    if (!check_passwd_hash($boinc_user, $passwd_hash)) {
60 60
     return false;
61
-  }
61
+    }
62 62
 
63
-  // BOINC authentication successful; log in and synchronize accounts
64
-  boincuser_login_register($boinc_user);
65
-  // Write session, update timestamp, run user 'login' hook.
66
-  user_authenticate_finalize($form_values);
67
-  // Use a global variable to save the fact that we did authentication.
68
-  $boincuser_authenticated = true;
63
+    // BOINC authentication successful; log in and synchronize accounts
64
+    boincuser_login_register($boinc_user);
65
+    // Write session, update timestamp, run user 'login' hook.
66
+    user_authenticate_finalize($form_values);
67
+    // Use a global variable to save the fact that we did authentication.
68
+    $boincuser_authenticated = true;
69 69
 
70
-  return true;
70
+    return true;
71 71
 }
72 72
 
73 73
 /**
@@ -75,18 +75,18 @@  discard block
 block discarded – undo
75 75
  * Drupal accounts
76 76
  */
77 77
 function boincuser_login_register($boinc_user) {
78
-  global $user;
79
-  require_boinc('boinc_db');
80
-  // If a Drupal account already exists, log in
81
-  $existing_user = user_load(array('mail' => $boinc_user->email_addr));
82
-  if (!empty($existing_user->uid)) {
78
+    global $user;
79
+    require_boinc('boinc_db');
80
+    // If a Drupal account already exists, log in
81
+    $existing_user = user_load(array('mail' => $boinc_user->email_addr));
82
+    if (!empty($existing_user->uid)) {
83 83
     $user = $existing_user;
84
-  } else {
84
+    } else {
85 85
     // Create a Drupal user from the BOINC user
86 86
     if ($user = boincuser_register_make_drupal_user($boinc_user)) {
87
-      watchdog('user', 'New external user: %email using module %module.', array('%email' => $email_addr, '%module' => $module), WATCHDOG_NOTICE, l(t('edit'), 'user/'. $user->uid .'/edit'));
87
+        watchdog('user', 'New external user: %email using module %module.', array('%email' => $email_addr, '%module' => $module), WATCHDOG_NOTICE, l(t('edit'), 'user/'. $user->uid .'/edit'));
88
+    }
88 89
     }
89
-  }
90 90
 }
91 91
 
92 92
 
@@ -98,113 +98,113 @@  discard block
 block discarded – undo
98 98
  * New user registration validation handler.
99 99
  */
100 100
 function boincuser_register_validate($form, &$form_state) {
101
-  // Include BOINC database objects library
102
-  require_boinc('boinc_db');
101
+    // Include BOINC database objects library
102
+    require_boinc('boinc_db');
103 103
 
104
-  // Check terms of use agreement
105
-  $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
106
-  if (!empty($termsofuse)) {
104
+    // Check terms of use agreement
105
+    $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
106
+    if (!empty($termsofuse)) {
107 107
     if (!$form_state['values']['termsofuse']['agreeTOU']) {
108
-      form_set_error('termsofuse', bts('ERROR: You must acknowledge our terms of use by clicking the checkbox before registering for an account.', NULL, 'boinc:register-new-user'));
109
-      return false;
108
+        form_set_error('termsofuse', bts('ERROR: You must acknowledge our terms of use by clicking the checkbox before registering for an account.', NULL, 'boinc:register-new-user'));
109
+        return false;
110
+    }
110 111
     }
111
-  }
112 112
 
113
-  // Lower-case the email address
114
-  $lower_email_addr = strtolower($form_state['values']['mail']);
115
-  $tmp_user = BoincUser::lookup_prev_email_addr($lower_email_addr);
116
-  if ($tmp_user) {
113
+    // Lower-case the email address
114
+    $lower_email_addr = strtolower($form_state['values']['mail']);
115
+    $tmp_user = BoincUser::lookup_prev_email_addr($lower_email_addr);
116
+    if ($tmp_user) {
117 117
     // User already exists
118 118
     rules_invoke_event('boincuser_change_email_error', $lower_email_addr, variable_get('boinc_admin_mailing_list_subject_tag', ''));
119 119
     form_set_error('mail',
120
-      bts('An account already exists for @email. The @project administrators have been notified.',
120
+        bts('An account already exists for @email. The @project administrators have been notified.',
121 121
         array(
122
-          '@email' => $lower_email_addr,
123
-          '@project' => variable_get('site_name', 'Drupal-BOINC')
122
+            '@email' => $lower_email_addr,
123
+            '@project' => variable_get('site_name', 'Drupal-BOINC')
124 124
         ), NULL, 'boinc:register-new-user')
125 125
     );
126
-  }
126
+    }
127 127
 
128
-  // Check for an existing BOINC user
129
-  // This is somewhat redundent as Drupal will also check if the email
130
-  // is a duplicate. However, in the case where there is no Drupal
131
-  // account, but a BOINC account exists with this email, the check
132
-  // will fail.
133
-  $boinc_user = BoincUser::lookup_email_addr($lower_email_addr);
134
-  if ($boinc_user) {
128
+    // Check for an existing BOINC user
129
+    // This is somewhat redundent as Drupal will also check if the email
130
+    // is a duplicate. However, in the case where there is no Drupal
131
+    // account, but a BOINC account exists with this email, the check
132
+    // will fail.
133
+    $boinc_user = BoincUser::lookup_email_addr($lower_email_addr);
134
+    if ($boinc_user) {
135 135
     // User already exists
136 136
     form_set_error('mail', bts('An account already exists for @email. Log in or request password assistance to access your @project account.', array('@email' => $lower_email_addr, '@project' => PROJECT), NULL, 'boinc:add-new-user'));
137 137
     return false;
138
-  }
138
+    }
139 139
 
140
-  // Check Drupal name is not a duplicate, and create a proper drupal
141
-  // name from the boinc username.
142
-  $form_state['values']['name'] = create_proper_drupalname($form_state['values']['boincuser_name']);
140
+    // Check Drupal name is not a duplicate, and create a proper drupal
141
+    // name from the boinc username.
142
+    $form_state['values']['name'] = create_proper_drupalname($form_state['values']['boincuser_name']);
143 143
 
144
-  return true;
144
+    return true;
145 145
 }
146 146
 
147 147
 /**
148 148
  * Create BOINC account
149 149
  */
150 150
 function boincuser_register_make_user($params) {    
151
-  // Include BOINC user library
152
-  require_boinc('user_util');
153
-  // Create the BOINC user
154
-  $boinc_user = make_user($params['email_addr'], $params['name'], $params['passwd_hash'], $params['country'], $params['postal_code']);
155
-  return $boinc_user;
151
+    // Include BOINC user library
152
+    require_boinc('user_util');
153
+    // Create the BOINC user
154
+    $boinc_user = make_user($params['email_addr'], $params['name'], $params['passwd_hash'], $params['country'], $params['postal_code']);
155
+    return $boinc_user;
156 156
 }
157 157
 
158 158
 /**
159 159
  * Create Drupal account from existing BOINC account
160 160
  */
161 161
 function boincuser_register_make_drupal_user($boinc_user) {
162
-  $account = null;
163
-  if (is_numeric($boinc_user)) {
162
+    $account = null;
163
+    if (is_numeric($boinc_user)) {
164 164
     $boinc_user = boincuser_load($boinc_user);
165
-  }
166
-  if ($boinc_user) {
165
+    }
166
+    if ($boinc_user) {
167 167
     $account = boincuser_create_drupal_user($boinc_user);
168 168
     if ($account) {
169
-      boincuser_create_drupal_profile($account, $boinc_user);
169
+        boincuser_create_drupal_profile($account, $boinc_user);
170
+    }
170 171
     }
171
-  }
172
-  return $account;
172
+    return $account;
173 173
 }
174 174
 
175 175
 function boincuser_create_drupal_user($boinc_user) {
176
-  require_boinc('forum_db');
177
-  BoincForumPrefs::lookup($boinc_user);
178
-  $account = NULL;
179
-  $module = 'boincuser';
176
+    require_boinc('forum_db');
177
+    BoincForumPrefs::lookup($boinc_user);
178
+    $account = NULL;
179
+    $module = 'boincuser';
180 180
   
181
-  // Verify that this account has not already been imported
182
-  $already_imported = db_result(db_query('
181
+    // Verify that this account has not already been imported
182
+    $already_imported = db_result(db_query('
183 183
     SELECT COUNT(*) FROM {boincuser} WHERE boinc_id = %d',
184 184
     $boinc_user->id)
185
-  );
186
-  if ($already_imported) {
185
+    );
186
+    if ($already_imported) {
187 187
     return NULL;
188
-  }
188
+    }
189 189
   
190
-  // Email is limited to 64 characters...
191
-  $boinc_email = substr($boinc_user->email_addr, 0, 64);
190
+    // Email is limited to 64 characters...
191
+    $boinc_email = substr($boinc_user->email_addr, 0, 64);
192 192
   
193
-  // Email should be unique
194
-  $already_imported = db_result(db_query("
193
+    // Email should be unique
194
+    $already_imported = db_result(db_query("
195 195
     SELECT COUNT(*) FROM {users} WHERE mail = '%s'",
196 196
     $boinc_email)
197
-  );
198
-  if ($already_imported) {
197
+    );
198
+    if ($already_imported) {
199 199
     drupal_set_message(t('An account for @email already exists', array('@email' => $boinc_email)), 'warning');
200 200
     watchdog('boincimport', 'An account for @email already exists', array('@email' => $boinc_email), WATCHDOG_WARNING); 
201 201
     return NULL;
202
-  }
202
+    }
203 203
   
204
-  // Make sure name is unique
205
-  $unique_name = create_proper_drupalname($boinc_user->name);
204
+    // Make sure name is unique
205
+    $unique_name = create_proper_drupalname($boinc_user->name);
206 206
   
207
-  $userinfo = array(
207
+    $userinfo = array(
208 208
     'name' => $unique_name,
209 209
     'pass' => $boinc_user->passwd_hash,
210 210
     'mail' => $boinc_email,
@@ -214,126 +214,126 @@  discard block
 block discarded – undo
214 214
     'status' => 1,
215 215
     "authname_{$module}" => $boinc_email,
216 216
     'access' => time()
217
-  );
217
+    );
218 218
   
219
-  $in_penalty = ($boinc_user->prefs->banished_until > time());
219
+    $in_penalty = ($boinc_user->prefs->banished_until > time());
220 220
   
221
-  // Add user to community member role (if no current penalty)
222
-  if (!$in_penalty) {
221
+    // Add user to community member role (if no current penalty)
222
+    if (!$in_penalty) {
223 223
     $community_role = array_search('community member', user_roles(true)); 
224 224
     $userinfo['roles'] = array(
225
-      $community_role => ''
225
+        $community_role => ''
226 226
     );
227
-  }
227
+    }
228 228
   
229
-  // Mark account as imported so a BOINC account is not created on Insert (i.e. user_save)
230
-  $_SESSION['importedUser'] = true;
231
-  $account = user_save('', $userinfo);
229
+    // Mark account as imported so a BOINC account is not created on Insert (i.e. user_save)
230
+    $_SESSION['importedUser'] = true;
231
+    $account = user_save('', $userinfo);
232 232
   
233
-  // Drupal overrides the original registration date, so update to the correct date
234
-  $account = user_save($account, array('created' => $userinfo['created']));
233
+    // Drupal overrides the original registration date, so update to the correct date
234
+    $account = user_save($account, array('created' => $userinfo['created']));
235 235
   
236
-  // Terminate if an error occured during user_save().
237
-  if (!$account) {
236
+    // Terminate if an error occured during user_save().
237
+    if (!$account) {
238 238
     drupal_set_message(t("Error saving user account."), 'error');
239 239
     return NULL;
240
-  }
240
+    }
241 241
   
242
-  // Cross reference the Drupal and BOINC accounts
243
-  boincuser_account_cross_reference($account->uid, $boinc_user->id);
242
+    // Cross reference the Drupal and BOINC accounts
243
+    boincuser_account_cross_reference($account->uid, $boinc_user->id);
244 244
   
245
-  if ($in_penalty) {
245
+    if ($in_penalty) {
246 246
     // Import the timestamp of when the penalty period will be over
247 247
     $boincuser_record = array(
248
-      'uid' => $account->uid,
249
-      'penalty_expiration' => $boinc_user->prefs->banished_until,
248
+        'uid' => $account->uid,
249
+        'penalty_expiration' => $boinc_user->prefs->banished_until,
250 250
     );
251 251
     drupal_write_record('boincuser', $boincuser_record, 'uid');
252
-  }
252
+    }
253 253
   
254
-  return $account;
254
+    return $account;
255 255
 }
256 256
 
257 257
 function boincuser_create_drupal_profile($account, $boinc_user) {
258 258
   
259
-  require_boinc('forum_db');
260
-  BoincForumPrefs::lookup($boinc_user);
259
+    require_boinc('forum_db');
260
+    BoincForumPrefs::lookup($boinc_user);
261 261
   
262
-  $image_dir = boinc_get_path('user_image');
262
+    $image_dir = boinc_get_path('user_image');
263 263
   
264
-  // Automatically create a content profile
265
-  $now = time();
266
-  $profile_background = null;
267
-  $profile_opinions = null;
268
-  $profile_image = null;
269
-  $avatar_image = null;
270
-  $profile_approved = NULL;
264
+    // Automatically create a content profile
265
+    $now = time();
266
+    $profile_background = null;
267
+    $profile_opinions = null;
268
+    $profile_image = null;
269
+    $avatar_image = null;
270
+    $profile_approved = NULL;
271 271
   
272
-  // Load the BOINC profile, if available
273
-  if ($boinc_user->has_profile) {
272
+    // Load the BOINC profile, if available
273
+    if ($boinc_user->has_profile) {
274 274
     $boinc_profile = BoincProfile::lookup("userid={$boinc_user->id}");
275 275
     $profile_background = $boinc_profile->response1;
276 276
     $profile_opinions = $boinc_profile->response2;
277 277
     if ($boinc_profile->has_picture) {
278
-      // Load picture; load validators; determine where to store it in Drupal
279
-      $image_path = "{$image_dir}/{$boinc_user->id}.jpg";
280
-      $profile_image = get_cck_image_object($image_path, 'field_profile_image', 'profile', TRUE);
281
-      // If the user does not have a different image as an avatar, use this one
282
-      if (!$boinc_user->prefs->avatar) {
278
+        // Load picture; load validators; determine where to store it in Drupal
279
+        $image_path = "{$image_dir}/{$boinc_user->id}.jpg";
280
+        $profile_image = get_cck_image_object($image_path, 'field_profile_image', 'profile', TRUE);
281
+        // If the user does not have a different image as an avatar, use this one
282
+        if (!$boinc_user->prefs->avatar) {
283 283
         $avatar_image = get_cck_image_object($image_path, 'field_image', 'profile', TRUE);
284
-      }
284
+        }
285 285
     }
286 286
     if ($boinc_user->prefs->avatar) {
287
-      $image_path = "{$image_dir}/{$boinc_user->id}_avatar.jpg";
288
-      $avatar_image = get_cck_image_object($image_path, 'field_image', 'profile', TRUE);
287
+        $image_path = "{$image_dir}/{$boinc_user->id}_avatar.jpg";
288
+        $avatar_image = get_cck_image_object($image_path, 'field_image', 'profile', TRUE);
289 289
     }
290 290
     $profile_approved = $boinc_profile->verification ? TRUE : FALSE;
291
-  }
292
-  $default_input_format = db_result(db_query("
291
+    }
292
+    $default_input_format = db_result(db_query("
293 293
     SELECT format FROM {filter_formats} WHERE name = '%s'", 'Rich text'));
294
-  if (!$default_input_format) $default_input_format = 1;
295
-  
296
-  // Populate the profile object
297
-  $profile_node = new stdClass();
298
-  $profile_node->title = $boinc_user->name;
299
-  $profile_node->uid = $account->uid;
300
-  $profile_node->body = '';
301
-  $profile_node->type = 'profile'; 
302
-  $profile_node->created = $now;
303
-  $profile_node->changed = $now;
304
-  $profile_node->status = 1;
305
-  $profile_node->promote = 0;
306
-  $profile_node->sticky = 0;
307
-  $profile_node->format = $default_input_format;
308
-  $profile_node->name = $account->name; // Set to link profile to account uid!
309
-  $profile_node->field_country[]['value'] = $boinc_user->country;
310
-  $profile_node->field_zip[]['value'] = $boinc_user->postal_code;
311
-  $profile_node->field_url[]['value'] = $boinc_user->url;
312
-  $profile_node->field_background[]['value'] = $profile_background;
313
-  $profile_node->field_opinions[]['value'] = $profile_opinions;
314
-  $profile_node->field_image[] = $avatar_image;
315
-  $profile_node->field_profile_image[] = $profile_image;
316
-  
317
-  // Save the profile object to the database
318
-  // This will automatically set the author uid if node->name has been set
319
-  $profile_node = node_submit($profile_node);
320
-  node_save($profile_node);
321
-  
322
-  // Mark profile as approved if it has already been vetted somehow
323
-  if ($profile_approved OR !$boinc_user->has_profile) {
294
+    if (!$default_input_format) $default_input_format = 1;
295
+  
296
+    // Populate the profile object
297
+    $profile_node = new stdClass();
298
+    $profile_node->title = $boinc_user->name;
299
+    $profile_node->uid = $account->uid;
300
+    $profile_node->body = '';
301
+    $profile_node->type = 'profile'; 
302
+    $profile_node->created = $now;
303
+    $profile_node->changed = $now;
304
+    $profile_node->status = 1;
305
+    $profile_node->promote = 0;
306
+    $profile_node->sticky = 0;
307
+    $profile_node->format = $default_input_format;
308
+    $profile_node->name = $account->name; // Set to link profile to account uid!
309
+    $profile_node->field_country[]['value'] = $boinc_user->country;
310
+    $profile_node->field_zip[]['value'] = $boinc_user->postal_code;
311
+    $profile_node->field_url[]['value'] = $boinc_user->url;
312
+    $profile_node->field_background[]['value'] = $profile_background;
313
+    $profile_node->field_opinions[]['value'] = $profile_opinions;
314
+    $profile_node->field_image[] = $avatar_image;
315
+    $profile_node->field_profile_image[] = $profile_image;
316
+  
317
+    // Save the profile object to the database
318
+    // This will automatically set the author uid if node->name has been set
319
+    $profile_node = node_submit($profile_node);
320
+    node_save($profile_node);
321
+  
322
+    // Mark profile as approved if it has already been vetted somehow
323
+    if ($profile_approved OR !$boinc_user->has_profile) {
324 324
     $profile_node->moderate = 0;
325 325
     node_save($profile_node);
326
-  }
326
+    }
327 327
   
328
-  return;
328
+    return;
329 329
 }
330 330
 
331 331
 function boincuser_account_cross_reference($uid, $boinc_id) {
332 332
     // Cross reference Drupal account with BOINC
333 333
     $reference = db_query("INSERT INTO {boincuser} SET uid=%d, boinc_id=%d", $uid, $boinc_id);
334 334
     if (!$reference) {
335
-      drupal_set_message(t("Error connecting BOINC account."), 'error');
336
-      return false;
335
+        drupal_set_message(t("Error connecting BOINC account."), 'error');
336
+        return false;
337 337
     }
338 338
     return true;
339 339
 }
@@ -342,35 +342,35 @@  discard block
 block discarded – undo
342 342
  * Convert any BOINC forum thread subscriptions to Drupal flag subscriptions
343 343
  */
344 344
 function boincuser_pull_subscriptions($account = NULL) {
345
-  if (!$account) {
345
+    if (!$account) {
346 346
     global $user;
347 347
     $account = user_load($user->id);
348
-  }
349
-  elseif (is_numeric($account)) {
348
+    }
349
+    elseif (is_numeric($account)) {
350 350
     $account = user_load($account);
351
-  }
351
+    }
352 352
   
353
-  // Get any subscriptions for this user
354
-  db_set_active('boinc_rw');
355
-  $subscriptions = db_query('
353
+    // Get any subscriptions for this user
354
+    db_set_active('boinc_rw');
355
+    $subscriptions = db_query('
356 356
     SELECT threadid FROM {subscriptions}
357 357
     WHERE userid = %d', $account->boincuser_id);
358
-  db_set_active('default');
358
+    db_set_active('default');
359 359
   
360
-  $flag = flag_get_flag('subscriptions') or die('no "subscriptions" flag defined');
361
-  $count = 0;
362
-  while ($thread_id = db_result($subscriptions)) {
360
+    $flag = flag_get_flag('subscriptions') or die('no "subscriptions" flag defined');
361
+    $count = 0;
362
+    while ($thread_id = db_result($subscriptions)) {
363 363
     // For each BOINC thread ID subscribed, look up the corresponding node ID
364 364
     $nid = db_result(db_query('
365 365
       SELECT nid FROM {boincimport_temp_topic}
366 366
       WHERE topic_id = %d', $thread_id));
367 367
     // Flag this node for the user
368 368
     if ($nid > 0) {
369
-      $flag->flag('flag', $nid, $account);
370
-      $count++;
369
+        $flag->flag('flag', $nid, $account);
370
+        $count++;
371
+    }
371 372
     }
372
-  }
373
-  return $count;
373
+    return $count;
374 374
 }
375 375
 
376 376
 
@@ -382,12 +382,12 @@  discard block
 block discarded – undo
382 382
  * User account update validation handler.
383 383
  */
384 384
 function boincuser_account_validate($edit, $account) {
385
-  // Include BOINC database objects library, load BOINC account data
386
-  require_boinc('boinc_db');
387
-  $boinc_user = BoincUser::lookup_email_addr($account->mail);
388
-  $changing_email = ($edit['mail'] AND $edit['mail'] != $account->mail) ? true : false;
389
-  $changing_pass = ($edit['pass']) ? true : false;
390
-  if ($changing_email) {
385
+    // Include BOINC database objects library, load BOINC account data
386
+    require_boinc('boinc_db');
387
+    $boinc_user = BoincUser::lookup_email_addr($account->mail);
388
+    $changing_email = ($edit['mail'] AND $edit['mail'] != $account->mail) ? true : false;
389
+    $changing_pass = ($edit['pass']) ? true : false;
390
+    if ($changing_email) {
391 391
     // E-mail address is set to change; check for an existing BOINC user
392 392
     // Check previous email addresses as well, this user's current
393 393
     // email cannot be the same as another user's previous email
@@ -398,50 +398,50 @@  discard block
 block discarded – undo
398 398
 
399 399
     $boinc_user_already_exists = ( BoincUser::lookup_email_addr($edit['mail']) || BoincUser::lookup_prev_email_addr($edit['mail']) );
400 400
     if ($boinc_user_already_exists) {
401
-      form_set_error('mail', bts('A BOINC account already exists for @email.', array('@email' => $edit['mail']), NULL, 'boinc:add-new-user'));
401
+        form_set_error('mail', bts('A BOINC account already exists for @email.', array('@email' => $edit['mail']), NULL, 'boinc:add-new-user'));
402 402
     }
403 403
 
404 404
     // Check email has not been changed in last X days (default X=7).
405 405
     $duration = 86400 * 7;
406 406
     if ( (($boinc_user->email_addr_change_time + $duration) > time()) and (!(user_access('administer users'))) ) {
407
-      form_set_error('email_addr_change_time',
407
+        form_set_error('email_addr_change_time',
408 408
         bts('Your email address was changed within the past seven (7) days. You must wait until !futuredate to change your email again. If you need to reverse this change, please look for an email sent to !prev_email_addr.',
409 409
         array(
410
-          '!futuredate' => date('F j, Y \a\t H:i T', $boinc_user->email_addr_change_time + $duration),
411
-          '!prev_email_addr' => $boinc_user->previous_email_addr,
410
+            '!futuredate' => date('F j, Y \a\t H:i T', $boinc_user->email_addr_change_time + $duration),
411
+            '!prev_email_addr' => $boinc_user->previous_email_addr,
412 412
         ),
413 413
         NULL, 'boinc:account-credentials-change')
414
-      );
414
+        );
415
+    }
415 416
     }
416
-  }
417 417
 
418
-  // If user is changing email or password, require that the current
419
-  // password has been given as well.
420
-  if (($changing_email OR $changing_pass) AND !user_access('administer users')) {
418
+    // If user is changing email or password, require that the current
419
+    // password has been given as well.
420
+    if (($changing_email OR $changing_pass) AND !user_access('administer users')) {
421 421
     // If changing email or password, require current password
422 422
     // (except in cases where password is being reset)
423 423
     if (isset($_SESSION['reset_pass'])) {
424
-      unset($_SESSION['reset_pass']);
424
+        unset($_SESSION['reset_pass']);
425 425
     }
426 426
     else {
427
-      $given_hash = md5($edit['current_pass'] . strtolower($account->mail));
428
-      if (!$edit['current_pass']) {
427
+        $given_hash = md5($edit['current_pass'] . strtolower($account->mail));
428
+        if (!$edit['current_pass']) {
429 429
         form_set_error('current_pass', bts('Authentication is required when changing E-mail address or setting new password.', array(), NULL, 'boinc:account-credentials-change'));
430
-      }
431
-      elseif ( (!password_verify($given_hash, $boinc_user->passwd_hash)) and ($given_hash != $boinc_user->passwd_hash) ) {
430
+        }
431
+        elseif ( (!password_verify($given_hash, $boinc_user->passwd_hash)) and ($given_hash != $boinc_user->passwd_hash) ) {
432 432
         form_set_error('current_pass', bts('Password entered is not valid. Please verify that it is correct.', array(), NULL, 'boinc:account-credentials-change'));
433
-      }
433
+        }
434 434
 
435 435
     }
436
-  }
436
+    }
437 437
 
438
-  // If an admin tries to change the email and NOT the password, show
439
-  // error message. BOINC requires both to be changed together.
440
-  if ($changing_email AND !$changing_pass AND user_access('administer users')) {
438
+    // If an admin tries to change the email and NOT the password, show
439
+    // error message. BOINC requires both to be changed together.
440
+    if ($changing_email AND !$changing_pass AND user_access('administer users')) {
441 441
     form_set_error('pass', bts('If changing a user\'s email, you must also change the password simultaneously.', array(), NULL, 'boinc:account-credentials-change'));
442
-  }
442
+    }
443 443
   
444
-  // Expansion required to allow account key in place of passwd...?
444
+    // Expansion required to allow account key in place of passwd...?
445 445
   
446 446
 }
447 447
 
@@ -454,12 +454,12 @@  discard block
 block discarded – undo
454 454
  * Password request validation handler.
455 455
  */
456 456
 function boincuser_request_pass_validate($form, &$form_state) {
457
-  $edit = $form_state['values'];
458
-  // The Drupal submit function expects a "name" field, even though
459
-  // it contains an email address and we will not allow a user name
460
-  if (!$edit['name']) form_set_error('name', bts('Please enter your email address', array(), NULL, 'boinc:forgot-password'));
461
-  elseif (!valid_email_address($edit['name'])) form_set_error('name', bts('@email is not a well formed email address, please verify', array('@email' => $edit['name']), NULL, 'boinc:forgot-password'));
462
-  else {
457
+    $edit = $form_state['values'];
458
+    // The Drupal submit function expects a "name" field, even though
459
+    // it contains an email address and we will not allow a user name
460
+    if (!$edit['name']) form_set_error('name', bts('Please enter your email address', array(), NULL, 'boinc:forgot-password'));
461
+    elseif (!valid_email_address($edit['name'])) form_set_error('name', bts('@email is not a well formed email address, please verify', array('@email' => $edit['name']), NULL, 'boinc:forgot-password'));
462
+    else {
463 463
     // set email addrress to lower case
464 464
     $lower_email_addr = strtolower($edit['name']);
465 465
 
@@ -469,110 +469,110 @@  discard block
 block discarded – undo
469 469
     require_boinc('boinc_db');
470 470
     $boinc_user = BoincUser::lookup_email_addr($lower_email_addr);
471 471
     if ($boinc_user) {
472
-      // If the user is in BOINC but not Drupal, bring them over...
473
-      boincuser_register_make_drupal_user($boinc_user);
472
+        // If the user is in BOINC but not Drupal, bring them over...
473
+        boincuser_register_make_drupal_user($boinc_user);
474 474
     } else {
475
-      // If there is no existing BOINC user either, show an error
476
-      form_set_error('name', bts('No account exists for @email -- please create an account using a BOINC client -- !instructions',
477
-      array(
478
-          '@email' => $edit['name'],
479
-          '!instructions' => l(bts('Instructions', array(), NULL, 'boinc:forgot-password'), 'join')
480
-      ), NULL, 'boinc:forgot-password'));
481
-    }
482
-  }
475
+        // If there is no existing BOINC user either, show an error
476
+        form_set_error('name', bts('No account exists for @email -- please create an account using a BOINC client -- !instructions',
477
+        array(
478
+            '@email' => $edit['name'],
479
+            '!instructions' => l(bts('Instructions', array(), NULL, 'boinc:forgot-password'), 'join')
480
+        ), NULL, 'boinc:forgot-password'));
481
+    }
482
+    }
483 483
 }
484 484
 
485 485
 /**
486 486
  * The definition of the authenticator login form.
487 487
  */
488 488
 function boincuser_authloginform() {
489
-  $headers = apache_request_headers();
490
-  $project_name = variable_get('site_name', 'Drupal-BOINC');
491
-  $project_domain = $headers['Host'];
492
-  $form['heading'] = array(
489
+    $headers = apache_request_headers();
490
+    $project_name = variable_get('site_name', 'Drupal-BOINC');
491
+    $project_domain = $headers['Host'];
492
+    $form['heading'] = array(
493 493
     '#type' => 'markup',
494 494
     '#value' => '<h3>' . bts("If you forgot your account's email address, or you can't receive email there:", array(), NULL, 'boinc:authenticator-login-page') . '</h3>'
495
-  );
496
-  $form['instructions'] = array(
495
+    );
496
+    $form['instructions'] = array(
497 497
     '#type' => 'markup',
498 498
     '#value' => '' .
499
-      '<p>' . bts("If you have run BOINC under the account, you can still access it. Here's how:", array(), NULL, 'boinc:authenticator-login-page') .
500
-      '  <ul>' .
501
-      '    <li>' . bts('Go to the BOINC data directory on your computer (see !boinc_wiki for help finding this).', array('!boinc_wiki' => l(bts('BOINC documentation', array(), NULL, 'boinc:authenticator-login-page'), 'http://boinc.berkeley.edu/wiki/BOINC_Data_directory')), NULL, 'boinc:authenticator-login-page') . '</li>' .
502
-      '    <li>' . bts('Find your account file for this project; it will have a name like %file (where the project URL is %url).', array('%file' => "account_{$project_domain}.xml", '%url' => "http://{$project_domain}"), NULL, 'boinc:authenticator-login-page') . '</li>' .
503
-      '    <li>' . bts("Open the file in a text editor like Notepad. You'll see something like:", array(), NULL, 'boinc:authenticator-login-page') .
504
-      '      <pre>' .
505
-      '&lt;account&gt;' . "\n" .
506
-      "  &lt;master_url&gt;http://{$project_domain}/&lt;/master_url&gt;" . "\n" .
507
-      '  &lt;authenticator&gt;8b8496fdd26df7dc0423ecd43c09a56b&lt;/authenticator&gt;' . "\n" .
508
-      "  &lt;project_name&gt;{$project_name}&lt;/project_name&gt;" . "\n" .
509
-      '  ...' . "\n" .
510
-      '&lt;/account&gt;' .
511
-      '      </pre>' .
512
-      '    </li>' .
513
-      '    <li>' . bts('Select and Copy the string between &lt;authenticator&gt; and &lt;/authenticator&gt; (%auth in the above example).', array('%auth' => '8b8496fdd26df7dc0423ecd43c09a56b'), NULL, 'boinc:authenticator-login-page') . '</li>' .
514
-      '    <li>' . bts('Paste the string into the field below, and click OK.', array(), NULL, 'boinc:authenticator-login-page') . '</li>' .
515
-      '    <li>' . bts('You will now be logged in to your account; update the email and password of your account.', array(), NULL, 'boinc:authenticator-login-page') . '</li>' .
516
-      '  </ul>' .
517
-      '</p>'
518
-  );
519
-  $form['authenticator'] = array(
499
+        '<p>' . bts("If you have run BOINC under the account, you can still access it. Here's how:", array(), NULL, 'boinc:authenticator-login-page') .
500
+        '  <ul>' .
501
+        '    <li>' . bts('Go to the BOINC data directory on your computer (see !boinc_wiki for help finding this).', array('!boinc_wiki' => l(bts('BOINC documentation', array(), NULL, 'boinc:authenticator-login-page'), 'http://boinc.berkeley.edu/wiki/BOINC_Data_directory')), NULL, 'boinc:authenticator-login-page') . '</li>' .
502
+        '    <li>' . bts('Find your account file for this project; it will have a name like %file (where the project URL is %url).', array('%file' => "account_{$project_domain}.xml", '%url' => "http://{$project_domain}"), NULL, 'boinc:authenticator-login-page') . '</li>' .
503
+        '    <li>' . bts("Open the file in a text editor like Notepad. You'll see something like:", array(), NULL, 'boinc:authenticator-login-page') .
504
+        '      <pre>' .
505
+        '&lt;account&gt;' . "\n" .
506
+        "  &lt;master_url&gt;http://{$project_domain}/&lt;/master_url&gt;" . "\n" .
507
+        '  &lt;authenticator&gt;8b8496fdd26df7dc0423ecd43c09a56b&lt;/authenticator&gt;' . "\n" .
508
+        "  &lt;project_name&gt;{$project_name}&lt;/project_name&gt;" . "\n" .
509
+        '  ...' . "\n" .
510
+        '&lt;/account&gt;' .
511
+        '      </pre>' .
512
+        '    </li>' .
513
+        '    <li>' . bts('Select and Copy the string between &lt;authenticator&gt; and &lt;/authenticator&gt; (%auth in the above example).', array('%auth' => '8b8496fdd26df7dc0423ecd43c09a56b'), NULL, 'boinc:authenticator-login-page') . '</li>' .
514
+        '    <li>' . bts('Paste the string into the field below, and click OK.', array(), NULL, 'boinc:authenticator-login-page') . '</li>' .
515
+        '    <li>' . bts('You will now be logged in to your account; update the email and password of your account.', array(), NULL, 'boinc:authenticator-login-page') . '</li>' .
516
+        '  </ul>' .
517
+        '</p>'
518
+    );
519
+    $form['authenticator'] = array(
520 520
     '#title' => bts('Log in with authenticator', array(), NULL, 'boinc:authenticator-login-page'),
521 521
     '#type' => 'textfield',
522 522
     '#size' => 60,
523 523
     '#maxlength' => 32,
524 524
     '#required' => TRUE,
525 525
     '#description' => null
526
-  );
526
+    );
527 527
   
528
-  // Form control
529
-  $form['form control tabs prefix'] = array(
528
+    // Form control
529
+    $form['form control tabs prefix'] = array(
530 530
     '#value' => '<ul class="form-control tab-list">',
531 531
     '#weight' => 1001,
532
-  );
533
-  $form['submit'] = array(
532
+    );
533
+    $form['submit'] = array(
534 534
     '#prefix' => '<li class="first tab">',
535 535
     '#type' => 'submit',
536 536
     '#value' => bts('OK', array(), NULL, 'boinc:form-ok'),
537 537
     '#suffix' => '</li>',
538 538
     '#weight' => 1002,
539
-  );
540
-  $form['form control tabs'] = array(
539
+    );
540
+    $form['form control tabs'] = array(
541 541
     '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/password') . '</li>',
542 542
     '#weight' => 1003,
543
-  );
544
-  $form['form control tabs suffix'] = array(
543
+    );
544
+    $form['form control tabs suffix'] = array(
545 545
     '#value' => '</ul>',
546 546
     '#weight' => 1004,
547
-  );
548
-  return $form;
547
+    );
548
+    return $form;
549 549
 }
550 550
 
551 551
 /**
552 552
  * The authenticator login validation handler
553 553
  */
554 554
 function boincuser_authloginform_validate($form, &$form_state) {
555
-  $authenticator = $form_state['values']['authenticator'];
556
-  if (strlen($authenticator) != 32) {
555
+    $authenticator = $form_state['values']['authenticator'];
556
+    if (strlen($authenticator) != 32) {
557 557
     // We notify the form API that this field has failed validation.
558 558
     form_set_error('authenticator', bts('That authenticator is not valid.', array(), NULL, 'boinc:authenticator-login-page'));
559
-  } else {
559
+    } else {
560 560
     require_boinc('boinc_db');
561 561
     $boinc_user = BoincUser::lookup("authenticator='".addslashes($authenticator)."'");
562 562
     if (!$boinc_user) form_set_error('authenticator', bts('There is no account with that authenticator.', array(), NULL, 'boinc:authenticator-login-page'));
563
-  }
563
+    }
564 564
 }
565 565
 
566 566
 /**
567 567
  * The authenticator login submit handler
568 568
  */
569 569
 function boincuser_authloginform_submit($form, &$form_state) {
570
-  global $user;
571
-  $authenticator = $form_state['values']['authenticator'];
572
-  require_boinc('boinc_db');
573
-  $boinc_user = BoincUser::lookup("authenticator='".addslashes($authenticator)."'");
574
-  if (!$user = user_load(get_drupal_id($boinc_user->id))) drupal_set_message(t('An unresolved error occurred while logging into this account.'));
575
-  else $form_state['redirect'] = 'account/info/edit';
570
+    global $user;
571
+    $authenticator = $form_state['values']['authenticator'];
572
+    require_boinc('boinc_db');
573
+    $boinc_user = BoincUser::lookup("authenticator='".addslashes($authenticator)."'");
574
+    if (!$user = user_load(get_drupal_id($boinc_user->id))) drupal_set_message(t('An unresolved error occurred while logging into this account.'));
575
+    else $form_state['redirect'] = 'account/info/edit';
576 576
 }
577 577
 
578 578
 
@@ -580,44 +580,44 @@  discard block
 block discarded – undo
580 580
  * The definition of the moderator reject user profile form.
581 581
  */
582 582
 function boincuser_moderate_profile_reject_form(&$form_state, $uid) {
583
-  $form_state['storage']['reject_profile_uid'] = $uid;
584
-  $form['reason'] = array(
583
+    $form_state['storage']['reject_profile_uid'] = $uid;
584
+    $form['reason'] = array(
585 585
     '#title' => bts('Reason for rejecting this profile', array(), NULL, 'boinc:moderate-user'),
586 586
     '#type' => 'textarea',
587 587
     '#description' => bts('This reason will be included in an email to the user. Please write a brief explanation of the problem and how to fix it.', array(), NULL, 'boinc:moderate-user'),
588 588
     '#default_value' => '',
589
-  );
589
+    );
590 590
   
591
-  // Form control
592
-  $form['form control tabs prefix'] = array(
591
+    // Form control
592
+    $form['form control tabs prefix'] = array(
593 593
     '#value' => '<ul class="form-control tab-list">',
594 594
     '#weight' => 1001,
595
-  );
596
-  $form['submit'] = array(
595
+    );
596
+    $form['submit'] = array(
597 597
     '#prefix' => '<li class="first tab">',
598 598
     '#type' => 'submit',
599 599
     '#value' => bts('Submit', array(), NULL, 'boinc:form-submit'),
600 600
     '#suffix' => '</li>',
601 601
     '#weight' => 1002,
602
-  );
603
-  $form['form control tabs'] = array(
602
+    );
603
+    $form['form control tabs'] = array(
604 604
     '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/{$uid}") . '</li>',
605 605
     '#weight' => 1003,
606
-  );
607
-  $form['form control tabs suffix'] = array(
606
+    );
607
+    $form['form control tabs suffix'] = array(
608 608
     '#value' => '</ul>',
609 609
     '#weight' => 1004,
610
-  );
611
-  return $form;
610
+    );
611
+    return $form;
612 612
 }
613 613
 
614 614
 /**
615 615
  * The moderator reject user profile submit handler
616 616
  */
617 617
 function boincuser_moderate_profile_reject_form_submit($form, &$form_state) {
618
-  $uid = $form_state['storage']['reject_profile_uid'];
619
-  $reason = $form_state['values']['reason'];
620
-  boincuser_moderate_profile_reject($uid, $reason);
618
+    $uid = $form_state['storage']['reject_profile_uid'];
619
+    $reason = $form_state['values']['reason'];
620
+    boincuser_moderate_profile_reject($uid, $reason);
621 621
 }
622 622
 
623 623
 
@@ -625,52 +625,52 @@  discard block
 block discarded – undo
625 625
  * The definition of the ban user form.
626 626
  */
627 627
 function boincuser_moderate_user_ban_form(&$form_state, $uid) {
628
-  $form_state['storage']['ban_user_uid'] = $uid;
629
-  $form['reason'] = array(
628
+    $form_state['storage']['ban_user_uid'] = $uid;
629
+    $form['reason'] = array(
630 630
     '#title' => bts('Reason for banning this user', array(), NULL, 'boinc:moderate-user'),
631 631
     '#type' => 'textarea',
632 632
     '#description' => bts('This reason will be included in an email to the user. Please write a brief explanation of why the user is being banned.', array(), NULL, 'boinc:moderate-user'),
633 633
     '#default_value' => '',
634
-  );
635
-  $form['duration'] = array(
634
+    );
635
+    $form['duration'] = array(
636 636
     '#title' => bts('Duration of the ban', array(), NULL, 'boinc:moderate-user'),
637 637
     '#type' => 'textfield',
638 638
     '#description' => bts('The number of days until the ban expires. Set to 0 to ban permanently.', array(), NULL, 'boinc:moderate-user'),
639 639
     '#default_value' => '',
640
-  );
640
+    );
641 641
   
642
-  // Form control
643
-  $form['form control tabs prefix'] = array(
642
+    // Form control
643
+    $form['form control tabs prefix'] = array(
644 644
     '#value' => '<ul class="form-control tab-list">',
645 645
     '#weight' => 1001,
646
-  );
647
-  $form['submit'] = array(
646
+    );
647
+    $form['submit'] = array(
648 648
     '#prefix' => '<li class="first tab">',
649 649
     '#type' => 'submit',
650 650
     '#value' => bts('Submit', array(), NULL, 'boinc:form-submit'),
651 651
     '#suffix' => '</li>',
652 652
     '#weight' => 1002,
653
-  );
654
-  $form['form control tabs'] = array(
653
+    );
654
+    $form['form control tabs'] = array(
655 655
     '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "account/{$uid}") . '</li>',
656 656
     '#weight' => 1003,
657
-  );
658
-  $form['form control tabs suffix'] = array(
657
+    );
658
+    $form['form control tabs suffix'] = array(
659 659
     '#value' => '</ul>',
660 660
     '#weight' => 1004,
661
-  );
662
-  return $form;
661
+    );
662
+    return $form;
663 663
 }
664 664
 
665 665
 /**
666 666
  * The ban user submit handler
667 667
  */
668 668
 function boincuser_moderate_user_ban_form_submit($form, &$form_state) {
669
-  $uid = $form_state['storage']['ban_user_uid'];
670
-  $reason = $form_state['values']['reason'];
671
-  $duration = $form_state['values']['duration'];
672
-  if ($duration) $duration = $duration * 24*60*60;
673
-  boincuser_moderate_user_ban($uid, $reason, $duration);
669
+    $uid = $form_state['storage']['ban_user_uid'];
670
+    $reason = $form_state['values']['reason'];
671
+    $duration = $form_state['values']['duration'];
672
+    if ($duration) $duration = $duration * 24*60*60;
673
+    boincuser_moderate_user_ban($uid, $reason, $duration);
674 674
 }
675 675
 
676 676
 
@@ -678,10 +678,10 @@  discard block
 block discarded – undo
678 678
  * Hack to fix submission of the flag friend unfriend form
679 679
  */
680 680
 function boincuser_fix_unfriend_form_submit($form, &$form_state) {
681
-  // Leaving action as "unfriend" causes problems
682
-  if ($form_state['values']['action'] == 'unfriend') {
681
+    // Leaving action as "unfriend" causes problems
682
+    if ($form_state['values']['action'] == 'unfriend') {
683 683
     $form_state['values']['action'] = 'unflag';
684
-  }
684
+    }
685 685
 }
686 686
 
687 687
 /*  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *
@@ -689,102 +689,102 @@  discard block
 block discarded – undo
689 689
  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  */
690 690
 
691 691
 function boincuser_termsofuse_form() {
692
-  global $user;
692
+    global $user;
693 693
 
694
-  // If user has already signed terms of use, and got to this form in error, send them to site home.
695
-  if (boincuser_check_termsofuse($user)) {
694
+    // If user has already signed terms of use, and got to this form in error, send them to site home.
695
+    if (boincuser_check_termsofuse($user)) {
696 696
     drupal_goto();
697
-  }
697
+    }
698 698
 
699
-  drupal_set_message( bts('WARNING: You have not agreed to our terms of use. Please agree to the terms of use before continuing.', array(), NULL, 'boinc:termsofuse-form'), 'warning' );
699
+    drupal_set_message( bts('WARNING: You have not agreed to our terms of use. Please agree to the terms of use before continuing.', array(), NULL, 'boinc:termsofuse-form'), 'warning' );
700 700
 
701
-  $form = array();
702
-  drupal_add_js(drupal_get_path('module', 'boincuser') . '/boincuser.js');
703
-  $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
701
+    $form = array();
702
+    drupal_add_js(drupal_get_path('module', 'boincuser') . '/boincuser.js');
703
+    $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
704 704
 
705
-  // Fieldset to hold all of the form as a container
706
-  $form['termsofuse'] = array(
705
+    // Fieldset to hold all of the form as a container
706
+    $form['termsofuse'] = array(
707 707
     '#type'   => 'fieldset',
708 708
     '#prefix' => '<div id="termsofuse-wrapper">', // This is our wrapper div.
709 709
     '#suffix' => '</div>',
710 710
     '#tree'   => TRUE,
711
-  );
711
+    );
712 712
 
713
-  $form['termsofuse']['title1'] = array(
713
+    $form['termsofuse']['title1'] = array(
714 714
     '#weight' => -12,
715 715
     '#value' => '<h2>' . bts( variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), NULL, 'project:termsofuse-form' ) . '</h2>',
716 716
     '#prefix' => '<div id="register-title1">',
717 717
     '#suffix' => '</div>',
718
-  );
718
+    );
719 719
 
720
-  // Terms of use section
721
-  $form['termsofuse']['body'] = array(
720
+    // Terms of use section
721
+    $form['termsofuse']['body'] = array(
722 722
     '#weight' => -10,
723 723
     '#value' => bts($termsofuse, array(), NULL, 'project:termsofuse-form'),
724 724
     '#prefix' => '<div id="register-termsofuse">',
725 725
     '#suffix' => '</div>',
726
-  );
726
+    );
727 727
 
728
-  $form['termsofuse']['agreeTOU'] = array(
728
+    $form['termsofuse']['agreeTOU'] = array(
729 729
     '#type'   => 'checkbox',
730 730
     '#title'  => bts(variable_get('boinc_weboptions_agreequestion', 'Do you agree with the above terms of use?'), array(), NULL, 'project:termsofuse-form'),
731 731
     '#weight' => -8,
732 732
     '#prefix' => '<div id="register-checkbox">',
733 733
     '#suffix' => '</div>',
734
-  );
734
+    );
735 735
 
736
-  $form['termsofuse']['spacer'] = array(
736
+    $form['termsofuse']['spacer'] = array(
737 737
     '#prefix' => '<div class="clearfix" id="register-title2">',
738 738
     '#value'  => '&nbsp;',
739 739
     '#suffix' => '</div>',
740
-  );
740
+    );
741 741
 
742
-  // Form Control
743
-  $form['submit'] = array(
742
+    // Form Control
743
+    $form['submit'] = array(
744 744
     '#prefix' => '<p><p><p><li class="first tab" id="register-submit">',
745 745
     '#type' => 'submit',
746 746
     '#value' => bts('Yes', array(), NULL, 'boinc:form-submit'),
747 747
     '#suffix' => '</li>',
748
-  );
749
-  $form['form control tabs'] = array(
748
+    );
749
+    $form['form control tabs'] = array(
750 750
     '#value' => '<li class="tab">' . l(bts('NO - LOGOUT', array(), NULL, 'boinc:form-cancel'), '/logout') . '</li>',
751
-  );
752
-  if (module_exists('boincuser_delete')) {
751
+    );
752
+    if (module_exists('boincuser_delete')) {
753 753
     $deletelink = '/user/' . $user->uid . '/delete';
754 754
     $form['deleteaccount'] = array(
755
-      '#value' => '<li class="tab">' . l(bts('NO - DELETE ACCOUNT', array(), NULL, 'boinc:form-delete-user'), $deletelink) . '</li>',
755
+        '#value' => '<li class="tab">' . l(bts('NO - DELETE ACCOUNT', array(), NULL, 'boinc:form-delete-user'), $deletelink) . '</li>',
756 756
     );
757
-  }
757
+    }
758 758
 
759
-  // Set form redirect
760
-  $form['#redirect'] = $_REQUEST['destination'];
759
+    // Set form redirect
760
+    $form['#redirect'] = $_REQUEST['destination'];
761 761
 
762
-  // Add the current user's data into the form
763
-  $form['#account'] = $user;
762
+    // Add the current user's data into the form
763
+    $form['#account'] = $user;
764 764
 
765
-  return $form;
765
+    return $form;
766 766
 }
767 767
 
768 768
 function boincuser_termsofuse_form_validate($form, &$form_state) {
769
-  // Check TOU agreement
770
-  if (!$form_state['values']['termsofuse']['agreeTOU']) {
769
+    // Check TOU agreement
770
+    if (!$form_state['values']['termsofuse']['agreeTOU']) {
771 771
     form_set_error('termsofuse', bts('ERROR: You must acknowledge our terms of use by clicking the checkbox before registering for an account.', array(), NULL, 'boinc:termsofuse-form'));
772
-  }
772
+    }
773 773
 }
774 774
 
775 775
 function boincuser_termsofuse_form_submit($form, &$form_state) {
776
-  $user = $form['#account'];
777
-  if (!boincuser_consentto_termsofuse($user)) {
776
+    $user = $form['#account'];
777
+    if (!boincuser_consentto_termsofuse($user)) {
778 778
     form_set_error('termsofuse',
779
-      bts('There was an error in agreeing to the terms of use. The @project administrators have been notified.',
779
+        bts('There was an error in agreeing to the terms of use. The @project administrators have been notified.',
780 780
         array('@project' => variable_get('site_name', 'Drupal-BOINC')), NULL, 'boinc:termsofuse-form')
781 781
     );
782
-  }
782
+    }
783 783
 
784
-  // Delete session messages
785
-  if ($_SESSION['messages']['warning']) {
784
+    // Delete session messages
785
+    if ($_SESSION['messages']['warning']) {
786 786
     unset($_SESSION['messages']['warning']);
787
-  }
787
+    }
788 788
 }
789 789
 
790 790
 /**
@@ -793,89 +793,89 @@  discard block
 block discarded – undo
793 793
  * removed after used.
794 794
  */
795 795
 function boincuser_revertemail(&$form_state, $token) {
796
-  require_boinc('token');
797
-  require_boinc('util');
796
+    require_boinc('token');
797
+    require_boinc('util');
798 798
 
799
-  global $user;
800
-  $form = array();
799
+    global $user;
800
+    $form = array();
801 801
 
802
-  // drupal JS for dynamic password validation
803
-  _user_password_dynamic_validation();
802
+    // drupal JS for dynamic password validation
803
+    _user_password_dynamic_validation();
804 804
 
805
-  // check BOINC user exists
806
-  $account = user_load(array('uid' => $user->uid));
807
-  $uid = $user->uid;
808
-  $boincid = $account->boincuser_id;
809
-  // check $token is valid
810
-  if (!is_valid_token($boincid, $token, 'E')) {
805
+    // check BOINC user exists
806
+    $account = user_load(array('uid' => $user->uid));
807
+    $uid = $user->uid;
808
+    $boincid = $account->boincuser_id;
809
+    // check $token is valid
810
+    if (!is_valid_token($boincid, $token, 'E')) {
811 811
     drupal_set_message(bts('ERROR: You have supplied an incorrect (most likely expired) token. Please obtain a new token by !link your email address.',
812 812
     array(
813
-      '!link' => l(bts('changing', array(), NULL, 'boinc:revert-email-change'), "/account/info/edit"),
813
+        '!link' => l(bts('changing', array(), NULL, 'boinc:revert-email-change'), "/account/info/edit"),
814 814
     ),
815 815
     NULL, 'boinc:revert-email-change'), 'error');
816 816
     drupal_goto();
817
-  }
817
+    }
818 818
 
819
-  // Attach account and token to this form.
820
-  $form['_account'] = array('#type' => 'value', '#value' => $account);
821
-  $form['_token'] = array('#type' => 'value', '#value' => $token);
819
+    // Attach account and token to this form.
820
+    $form['_account'] = array('#type' => 'value', '#value' => $account);
821
+    $form['_token'] = array('#type' => 'value', '#value' => $token);
822 822
 
823
-  // Instructions
824
-  $form['main']['instructions1'] = array(
823
+    // Instructions
824
+    $form['main']['instructions1'] = array(
825 825
     '#value' => '<p>'.
826 826
     bts('In order to change your email back to your previous email address, <strong>!prev_email</strong>, you must also change your password.',
827
-      array(
827
+        array(
828 828
         '!prev_email' => $account->boincuser_previous_email_addr,
829
-      ),
830
-      NULL, 'boinc:revert-email-change').
829
+        ),
830
+        NULL, 'boinc:revert-email-change').
831 831
     '</p>',
832
-  );
832
+    );
833 833
 
834
-  $form['main']['pass'] = array(
834
+    $form['main']['pass'] = array(
835 835
     '#type' => 'password_confirm',
836 836
     '#description' => 'Enter a new password in both fields',
837 837
     '#size' => 17,
838
-  );
839
-
840
-  // Wrap action buttons for styling consistency
841
-  $form['buttons']['form control tabs prefix'] = array(
842
-      '#value' => '<ul class="form-control tab-list">',
843
-      '#weight' => 1001,
844
-  );
845
-  $form['buttons']['submit']['#type'] = 'submit';
846
-  $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
847
-  $form['buttons']['submit']['#value'] = bts('Submit', array(), NULL, 'boinc:form-submit');
848
-  $form['buttons']['submit']['#suffix'] = '</li>';
849
-  $form['buttons']['submit']['#weight'] = 1002;
850
-  $form['buttons']['cancel'] = array(
851
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/info/edit') . '</li>',
852
-      '#weight' => 1005,
853
-  );
854
-  $form['buttons']['form control tabs suffix'] = array(
855
-      '#value' => '</ul>',
856
-      '#weight' => 1010,
857
-  );
858
-
859
-  return $form;
838
+    );
839
+
840
+    // Wrap action buttons for styling consistency
841
+    $form['buttons']['form control tabs prefix'] = array(
842
+        '#value' => '<ul class="form-control tab-list">',
843
+        '#weight' => 1001,
844
+    );
845
+    $form['buttons']['submit']['#type'] = 'submit';
846
+    $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
847
+    $form['buttons']['submit']['#value'] = bts('Submit', array(), NULL, 'boinc:form-submit');
848
+    $form['buttons']['submit']['#suffix'] = '</li>';
849
+    $form['buttons']['submit']['#weight'] = 1002;
850
+    $form['buttons']['cancel'] = array(
851
+        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/info/edit') . '</li>',
852
+        '#weight' => 1005,
853
+    );
854
+    $form['buttons']['form control tabs suffix'] = array(
855
+        '#value' => '</ul>',
856
+        '#weight' => 1010,
857
+    );
858
+
859
+    return $form;
860 860
 }
861 861
 
862 862
 /**
863 863
  * Validation handler for revertemail form
864 864
  */
865 865
 function boincuser_revertemail_validate($form, &$form_state) {
866
-  // Load account and boincuser
867
-  $account = $form_state['values']['_account'];
868
-  $boinc_user = BoincUser::lookup_id_nocache($account->boincuser_id);
866
+    // Load account and boincuser
867
+    $account = $form_state['values']['_account'];
868
+    $boinc_user = BoincUser::lookup_id_nocache($account->boincuser_id);
869 869
 
870
-  if (BoincUser::lookup_email_addr($boinc_user->previous_email_addr)) {
870
+    if (BoincUser::lookup_email_addr($boinc_user->previous_email_addr)) {
871 871
     rules_invoke_event('boincuser_revert_email_error', $boinc_user->previous_email_addr, variable_get('boinc_admin_mailing_list_subject_tag', ''));
872 872
     form_set_error('mail',
873
-      bts('An account already exists for @email. Previous email address cannot be used because another account is using it as their email address. The @project administrators have been notified.',
873
+        bts('An account already exists for @email. Previous email address cannot be used because another account is using it as their email address. The @project administrators have been notified.',
874 874
         array(
875
-          '@email' => $boinc_user->previous_email_addr,
876
-          '@project' => variable_get('site_name', 'Drupal-BOINC'),
875
+            '@email' => $boinc_user->previous_email_addr,
876
+            '@project' => variable_get('site_name', 'Drupal-BOINC'),
877 877
         ), NULL, 'boinc:add-new-user'));
878
-  }
878
+    }
879 879
 
880 880
 }
881 881
 
@@ -883,25 +883,25 @@  discard block
 block discarded – undo
883 883
  * Submit handler for revertemail form
884 884
  */
885 885
 function boincuser_revertemail_submit($form, &$form_state) {
886
-  require_boinc('password_compat/password');
886
+    require_boinc('password_compat/password');
887 887
 
888
-  // Load account and boincuser
889
-  $account = $form_state['values']['_account'];
890
-  $boinc_user = BoincUser::lookup_id_nocache($account->boincuser_id);
888
+    // Load account and boincuser
889
+    $account = $form_state['values']['_account'];
890
+    $boinc_user = BoincUser::lookup_id_nocache($account->boincuser_id);
891 891
 
892
-  $pem = strtolower($boinc_user->previous_email_addr);
892
+    $pem = strtolower($boinc_user->previous_email_addr);
893 893
 
894
-  // Set new password based on previous email address and entered
895
-  // password.
896
-  $new_passwd_hash = password_hash( md5($form_state['values']['pass'].$pem), PASSWORD_DEFAULT);
894
+    // Set new password based on previous email address and entered
895
+    // password.
896
+    $new_passwd_hash = password_hash( md5($form_state['values']['pass'].$pem), PASSWORD_DEFAULT);
897 897
 
898
-  $boinc_user->update("email_addr='${pem}', previous_email_addr='', email_addr_change_time=0, passwd_hash='${new_passwd_hash}'");
898
+    $boinc_user->update("email_addr='${pem}', previous_email_addr='', email_addr_change_time=0, passwd_hash='${new_passwd_hash}'");
899 899
 
900
-  // Set email in drupal database to previous email
901
-  user_save($account, array('mail' => $pem));
900
+    // Set email in drupal database to previous email
901
+    user_save($account, array('mail' => $pem));
902 902
 
903
-  // delete the token
904
-  $result = delete_token($account->boincuser_id, $form_state['values']['_token'], 'E');
903
+    // delete the token
904
+    $result = delete_token($account->boincuser_id, $form_state['values']['_token'], 'E');
905 905
 
906
-  drupal_goto('account');
906
+    drupal_goto('account');
907 907
 }
Please login to merge, or discard this patch.
drupal/sites/default/boinc/modules/boincuser/boincuser.module 4 patches
Braces   +15 added lines, -25 removed lines patch added patch discarded remove patch
@@ -418,11 +418,9 @@  discard block
 block discarded – undo
418 418
 
419 419
         if ($edit['boincuser_name']) {
420 420
           $myname = $edit['boincuser_name'];
421
-        }
422
-        else if ($edit['name']) {
421
+        } else if ($edit['name']) {
423 422
           $myname = $edit['name'];
424
-        }
425
-        else {
423
+        } else {
426 424
           $myname = 'noname';
427 425
         }
428 426
 
@@ -434,8 +432,7 @@  discard block
 block discarded – undo
434 432
         // If the 'pass' variable is already a hash, then don't hash it again.
435 433
         if ($edit['boinchash_flag']) {
436 434
           $user_params['passwd_hash'] = $edit['pass'];
437
-        }
438
-        else {
435
+        } else {
439 436
           // The passwd_hash here is only the md5() hash. This is
440 437
           // because BOINC make_user(), called later, will run
441 438
           // password_hash() on this md5 hash.
@@ -506,8 +503,7 @@  discard block
 block discarded – undo
506 503
               $prev_email = $account->mail;
507 504
               $mytime = (user_access('administer users')) ? $boinc_user->email_addr_change_time : time();
508 505
               $querypart = "email_addr='{$lower_email_addr}', passwd_hash='{$passwd_hash}', previous_email_addr = '{$prev_email}', email_addr_change_time = $mytime";
509
-            }
510
-            else {
506
+            } else {
511 507
               $querypart = "email_addr='{$lower_email_addr}', passwd_hash='{$passwd_hash}'";
512 508
             }
513 509
 
@@ -750,8 +746,7 @@  discard block
 block discarded – undo
750 746
       case FLAG_FRIEND_APPROVAL:
751 747
         if ($action == 'flag') {
752 748
           $form['flag_friend_submit']['#value'] = bts('Approve request', array(), NULL, 'boinc:friends-page');
753
-        }
754
-        elseif ($action == 'unflag') {
749
+        } elseif ($action == 'unflag') {
755 750
           unset($form['actions']);
756 751
           $form['flag_friend_submit']['#value'] = bts('Deny request', array(), NULL, 'boinc:friends-page');
757 752
         }
@@ -1527,8 +1522,7 @@  discard block
 block discarded – undo
1527 1522
         array(
1528 1523
           '!boinccmd' => l('boinccmd --project_attach', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1529 1524
         ), NULL, 'boinc:join-page') . '</li>';
1530
-    }
1531
-    else {
1525
+    } else {
1532 1526
       $output .= '<li>' . bts("If you're running a command-line version of BOINC,
1533 1527
         please follow the <b>!instructionslink</b> to first <i>create an account</i>, and then <i>attach</i> to this project. Use the same project URL as above.",
1534 1528
         array(
@@ -1563,8 +1557,7 @@  discard block
 block discarded – undo
1563 1557
         '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'),
1564 1558
         '@sitename' => $site_name,
1565 1559
       ), NULL, 'boinc:join-page') . '</li>';
1566
-    }
1567
-    else if ( menu_valid_path(array('link_path' => $ruleslink)) ) {
1560
+    } else if ( menu_valid_path(array('link_path' => $ruleslink)) ) {
1568 1561
       $output .= '  <li>' . bts("Read our !rules_and_policies.", array(
1569 1562
         '!rules_and_policies' => l(bts('Rules and Policies', array(), NULL, 'boinc:join-page'), $ruleslink),
1570 1563
       ), NULL, 'boinc:join-page') . '</li>';
@@ -1606,8 +1599,7 @@  discard block
 block discarded – undo
1606 1599
   ));
1607 1600
   if ($current_uotd->uotd_time < strtotime('today midnight')) {
1608 1601
     $uotd = boincuser_select_user_of_the_day();
1609
-  }
1610
-  else {
1602
+  } else {
1611 1603
     $uotd = user_load($current_uotd->uid);
1612 1604
   }
1613 1605
   $uotd_image = boincuser_get_user_profile_image($uotd->uid, FALSE);
@@ -1618,8 +1610,7 @@  discard block
 block discarded – undo
1618 1610
   $output .= '  <div>' . bts($site_message, array(), NULL, "project:front page") . ' ' . l(bts('Learn more', array(), NULL, 'boinc:front-page'), 'about') . '</div>';
1619 1611
   if ($user->uid) {
1620 1612
     $output .= '  <div>' . l(bts('View account', array(), NULL, 'boinc:front-page'), 'dashboard', array('attributes' => array('class' => 'join button'))) . '</div>';
1621
-  }
1622
-  else {
1613
+  } else {
1623 1614
     $output .= '  <div>' . l(bts('Join now', array(), NULL, 'boinc:front-page'), 'join', array('attributes' => array('class' => 'join button'))) . '</div>';
1624 1615
   }
1625 1616
   $output .= '</div>';
@@ -1704,12 +1695,10 @@  discard block
 block discarded – undo
1704 1695
     if ( ($params['passwd_hash'] == $boinc_user->passwd_hash) or
1705 1696
     password_verify($params['passwd_hash'], $boinc_user->passwd_hash) ) {
1706 1697
       $output = array('authenticator' => $boinc_user->authenticator);
1707
-    }
1708
-    else {
1698
+    } else {
1709 1699
       xml_error(-137);
1710 1700
     }
1711
-  }
1712
-  else {
1701
+  } else {
1713 1702
     // Verify that there isn't somehow a Drupal user already (not possible with proper function)
1714 1703
     if ($existing_user = user_load(array('mail' => $params['email_addr']))) {
1715 1704
       xml_error(-137, 'account error');
@@ -2193,7 +2182,9 @@  discard block
 block discarded – undo
2193 2182
     'cpid' => $cpid
2194 2183
   );
2195 2184
   $args = array();
2196
-  foreach ($get as $arg => $value) $args[] = "{$arg}=" . rawurlencode($value);
2185
+  foreach ($get as $arg => $value) {
2186
+      $args[] = "{$arg}=" . rawurlencode($value);
2187
+  }
2197 2188
   $query = '?' . implode('&', $args);
2198 2189
   
2199 2190
   // Load XML from RPC
@@ -2324,8 +2315,7 @@  discard block
 block discarded – undo
2324 2315
       if ($node->uid == 0 || strlen($node->name) == 0) {
2325 2316
         // @see user_validate_name(). !'0' === TRUE.
2326 2317
         $document->ss_name = '0';
2327
-      }
2328
-      else {
2318
+      } else {
2329 2319
         $document->ss_name = $account->boincuser_name;
2330 2320
         // We want the name to be searchable for keywords.
2331 2321
         $document->tos_name = $account->boincuser_name;
Please login to merge, or discard this patch.
Upper-Lower-Casing   +168 added lines, -168 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     'weight' => 5
84 84
   );
85 85
   $items['moderate/profile/%/reject'] = array(
86
-    'title' => bts('Reject profile', array(), NULL, 'boinc:moderate-user'),
86
+    'title' => bts('Reject profile', array(), null, 'boinc:moderate-user'),
87 87
     'description' => 'Reject profile content',
88 88
     'page callback' => 'drupal_get_form',
89 89
     'page arguments' => array('boincuser_moderate_profile_reject_form', 2),
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     'weight' => 5
93 93
   );
94 94
   $items['moderate/user/%/ban'] = array(
95
-    'title' => bts('Ban user', array(), NULL, 'boinc:moderate-ban-user'),
95
+    'title' => bts('Ban user', array(), null, 'boinc:moderate-ban-user'),
96 96
     'description' => 'Ban a user from using community features',
97 97
     'page callback' => 'drupal_get_form',
98 98
     'page arguments' => array('boincuser_moderate_user_ban_form', 2),
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     'weight' => 5
124 124
   );
125 125
   $items['user/login/auth'] = array(
126
-    'title' => bts('Authenticator login', array(), NULL, 'boinc:authenticator-login-page'),
126
+    'title' => bts('Authenticator login', array(), null, 'boinc:authenticator-login-page'),
127 127
     'description' => 'Log in using a user authenticator',
128 128
     'page callback' => 'drupal_get_form',
129 129
     'page arguments' => array('boincuser_authloginform'),
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     'type' => MENU_CALLBACK,
132 132
   );
133 133
   $items['user/termsofuse'] = array(
134
-    'title' => bts('Terms of Use', array(), NULL, 'boinc:termsofuse-form'),
134
+    'title' => bts('Terms of Use', array(), null, 'boinc:termsofuse-form'),
135 135
     'description' => 'A site\'s term of use.',
136 136
     'page callback' => 'drupal_get_form',
137 137
     'page arguments' => array('boincuser_termsofuse_form'),
@@ -185,19 +185,19 @@  discard block
 block discarded – undo
185 185
     'title' => 'Create Account RPC',
186 186
     'description' => 'RPC for creating user accounts.',
187 187
     'page callback' => 'boincuser_create_account',
188
-    'access callback' => TRUE,
188
+    'access callback' => true,
189 189
     'type' => MENU_CALLBACK
190 190
   );
191 191
   $items['account_finish.php'] = array(
192 192
     'title' => 'Welcome to ' . variable_get('site_name', 'Drupal-BOINC'),
193 193
     'description' => 'RPC for after a user has created an account.',
194 194
     'page callback' => 'boincuser_account_finish',
195
-    'access callback' => TRUE,
195
+    'access callback' => true,
196 196
     'type' => MENU_CALLBACK,
197 197
   );
198 198
   $items['boincuser/autocomplete'] = array(
199 199
     'page callback' => '_boincuser_user_name_autocomplete',
200
-    'access callback' => TRUE,
200
+    'access callback' => true,
201 201
     'type' => MENU_CALLBACK,
202 202
   );
203 203
   $items['user/%user/recoveremail/%'] = array(
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
     'title' => t('Recover previous email'),
213 213
     'description' => t('redirect'),
214 214
     'page callback' => '_boincuser_redirect_recover_email',
215
-    'access callback' => TRUE,
215
+    'access callback' => true,
216 216
     'type' => MENU_CALLBACK,
217 217
   );
218 218
   return $items;
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
   // Check if user has agreed to the terms of use. If not, send the
248 248
   // user to the terms-of-use form. This is only makes sense if the
249 249
   // termsofuse is enabled, by having text in the termsofuse variable.
250
-  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
250
+  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', false);
251 251
   $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
252 252
   if ( (!empty($termsofuse)) and ($user->uid) ) {
253 253
     if ( !boincuser_check_termsofuse($user) and ($existinguser_tou) ) {
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
  * Implementation of hook_user(); add custom actions to standard
297 297
  * Drupal user operations
298 298
  */
299
-function boincuser_user($op, &$edit, &$account, $category = NULL) {
299
+function boincuser_user($op, &$edit, &$account, $category = null) {
300 300
   require_boinc('boinc_db');
301 301
   require_boinc('user');
302 302
   require_boinc('xml');
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
       $account->boincuser_email_addr_change_time = $boinc_user->email_addr_change_time;
346 346
       db_set_active('default');
347 347
       // Set Drupal team ID
348
-      $account->team = NULL;
348
+      $account->team = null;
349 349
       if ($account->boincteam_id) {
350 350
         $account->team = db_result(db_query("
351 351
           SELECT nid FROM {boincteam} WHERE team_id = %d",
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
         $boinc_user = boincuser_register_make_user($user_params);
454 454
         if (!$boinc_user) {
455 455
           // Account exists with this email addr
456
-          form_set_error('email', bts('Error creating BOINC account.', array(), NULL, 'boinc:add-new-user'));
456
+          form_set_error('email', bts('Error creating BOINC account.', array(), null, 'boinc:add-new-user'));
457 457
           return;
458 458
         }
459 459
 
@@ -499,9 +499,9 @@  discard block
 block discarded – undo
499 499
         case 'user_account':
500 500
           // Ensure that BOINC data is altered
501 501
 
502
-          $changing_email = ($edit['mail'] AND $edit['mail'] != $boinc_user->email_addr) ? true : false;
502
+          $changing_email = ($edit['mail'] and $edit['mail'] != $boinc_user->email_addr) ? true : false;
503 503
           $changing_pass = ($edit['pass']) ? true : false;
504
-          if ($changing_email OR $changing_pass) {
504
+          if ($changing_email or $changing_pass) {
505 505
             // set email address to lower-case
506 506
             $lower_email_addr = strtolower($edit['mail']);
507 507
 
@@ -582,13 +582,13 @@  discard block
 block discarded – undo
582 582
  *(forward compatible to Drupal 7).
583 583
  */
584 584
 function boincuser_user_login(&$edit, $account) {
585
-  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
585
+  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', false);
586 586
   $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
587 587
 
588 588
   // Use the same code as boincuser_form_alter(), for case
589 589
   // 'user_profile_form', if the refering page is the user password
590 590
   // reset form, then do not check for terms of use.
591
-  $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/$account->uid") === FALSE) ? 0 : 1;
591
+  $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/$account->uid") === false) ? 0 : 1;
592 592
   if ($reset_pass) {
593 593
     return;
594 594
   }
@@ -736,7 +736,7 @@  discard block
 block discarded – undo
736 736
       
737 737
       // General friend form overrides
738 738
       $form['flag_friend_submit']['#prefix'] = '<li class="first tab">';
739
-      $form['flag_friend_submit']['#value'] = bts('Send request', array(), NULL, 'boinc:friends-page');
739
+      $form['flag_friend_submit']['#value'] = bts('Send request', array(), null, 'boinc:friends-page');
740 740
       $form['flag_friend_submit']['#type'] = 'submit';
741 741
       $form['flag_friend_submit']['#suffix'] = '</li>';
742 742
       $form['flag_friend_submit']['#weight'] = 1002;
@@ -745,7 +745,7 @@  discard block
 block discarded – undo
745 745
       case FLAG_FRIEND_BOTH:
746 746
       case FLAG_FRIEND_FLAGGED:
747 747
         unset($form['actions']);
748
-        $form['flag_friend_submit']['#value'] = bts('Remove friend', array(), NULL, 'boinc:friends-remove');
748
+        $form['flag_friend_submit']['#value'] = bts('Remove friend', array(), null, 'boinc:friends-remove');
749 749
         // Add in our hack handler to fix the flag_friend module
750 750
         $final_handler = array_pop($form['#submit']);
751 751
         $form['#submit'][] = 'boincuser_fix_unfriend_form_submit';
@@ -753,21 +753,21 @@  discard block
 block discarded – undo
753 753
         break;
754 754
       case FLAG_FRIEND_PENDING:
755 755
         unset($form['actions']);
756
-        $form['flag_friend_submit']['#value'] = bts('Remove request', array(), NULL, 'boinc:friends-page');
756
+        $form['flag_friend_submit']['#value'] = bts('Remove request', array(), null, 'boinc:friends-page');
757 757
         break;
758 758
       case FLAG_FRIEND_APPROVAL:
759 759
         if ($action == 'flag') {
760
-          $form['flag_friend_submit']['#value'] = bts('Approve request', array(), NULL, 'boinc:friends-page');
760
+          $form['flag_friend_submit']['#value'] = bts('Approve request', array(), null, 'boinc:friends-page');
761 761
         }
762 762
         elseif ($action == 'unflag') {
763 763
           unset($form['actions']);
764
-          $form['flag_friend_submit']['#value'] = bts('Deny request', array(), NULL, 'boinc:friends-page');
764
+          $form['flag_friend_submit']['#value'] = bts('Deny request', array(), null, 'boinc:friends-page');
765 765
         }
766 766
         break;
767 767
       case FLAG_FRIEND_UNFLAGGED:
768 768
       default:
769 769
         $user_links[] = array(
770
-          'title' => bts('Add as friend', array(), NULL, 'boinc:friends-add'),
770
+          'title' => bts('Add as friend', array(), null, 'boinc:friends-add'),
771 771
           'href' => "flag/confirm/flag/friend/{$account->uid}"
772 772
         );
773 773
       }
@@ -777,7 +777,7 @@  discard block
 block discarded – undo
777 777
     }
778 778
     
779 779
     $form['cancel'] = array(
780
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $cancel_dest) . '</li>',
780
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), $cancel_dest) . '</li>',
781 781
       '#weight' => 1004,
782 782
     );
783 783
     $form['form control tabs suffix'] = array(
@@ -800,7 +800,7 @@  discard block
 block discarded – undo
800 800
       '#weight' => 1001,
801 801
     );
802 802
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
803
-    $form['buttons']['submit']['#value'] = bts('Save changes', array(), NULL, 'boinc:form-save');
803
+    $form['buttons']['submit']['#value'] = bts('Save changes', array(), null, 'boinc:form-save');
804 804
     $form['buttons']['submit']['#suffix'] = '</li>';
805 805
     $form['buttons']['submit']['#weight'] = 1002;
806 806
     $form['buttons']['preview']['#prefix'] = '<li class="tab">';
@@ -810,7 +810,7 @@  discard block
 block discarded – undo
810 810
     $form['buttons']['preview_changes']['#suffix'] = '</li>';
811 811
     $form['buttons']['preview_changes']['#weight'] = 1004;
812 812
     $form['buttons']['cancel'] = array(
813
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
813
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
814 814
       '#weight' => 1005,
815 815
     );
816 816
     $form['buttons']['delete']['#prefix'] = '<li class="tab">';
@@ -838,11 +838,11 @@  discard block
 block discarded – undo
838 838
       '#weight' => 1001,
839 839
     );
840 840
     $form['actions']['submit']['#prefix'] = '<li class="first tab">';
841
-    $form['actions']['submit']['#value'] = bts('Delete', array(), NULL, 'boinc:form-delete');
841
+    $form['actions']['submit']['#value'] = bts('Delete', array(), null, 'boinc:form-delete');
842 842
     $form['actions']['submit']['#suffix'] = '</li>';
843 843
     $form['actions']['submit']['#weight'] = 1002;
844 844
     $form['actions']['cancel'] = array(
845
-        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
845
+        '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
846 846
       '#weight' => 1005,
847 847
     );
848 848
     $form['actions']['form control tabs suffix'] = array(
@@ -862,14 +862,14 @@  discard block
 block discarded – undo
862 862
       '#weight' => 1001,
863 863
     );
864 864
     $form['privatemsg']['submit']['#prefix'] = '<li class="first tab">';
865
-    $form['privatemsg']['submit']['#value'] = bts('Send message', array(), NULL, 'boinc:private-message');
865
+    $form['privatemsg']['submit']['#value'] = bts('Send message', array(), null, 'boinc:private-message');
866 866
     $form['privatemsg']['submit']['#suffix'] = '</li>';
867 867
     $form['privatemsg']['submit']['#weight'] = 1002;
868 868
     $form['privatemsg']['preview']['#prefix'] = '<li class="tab">';
869 869
     $form['privatemsg']['preview']['#suffix'] = '</li>';
870 870
     $form['privatemsg']['preview']['#weight'] = 1003;
871 871
     $form['privatemsg']['cancel'] = array(
872
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
872
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), $_GET['q']) . '</li>',
873 873
       '#weight' => 1004,
874 874
     );
875 875
     $form['privatemsg']['form control tabs suffix'] = array(
@@ -884,18 +884,18 @@  discard block
 block discarded – undo
884 884
   // Login form
885 885
   case 'user_login':
886 886
   case 'user_login_block':
887
-      drupal_set_title(bts('Login', array(), NULL, 'boinc:menu-link'));
887
+      drupal_set_title(bts('Login', array(), null, 'boinc:menu-link'));
888 888
     // Replace name with email in login form
889 889
     unset($form['name']);
890 890
     array_unshift($form, array(
891 891
       'email' => array(
892 892
         '#type' => 'textfield',
893
-        '#title' => bts('Email address', array(), NULL, 'boinc:email-address-to-login'),
893
+        '#title' => bts('Email address', array(), null, 'boinc:email-address-to-login'),
894 894
         '#size' => ($form_id == 'user_login_block') ? 15 : 60,
895 895
         '#maxlength' => EMAIL_MAX_LENGTH,
896
-        '#required' => TRUE,
896
+        '#required' => true,
897 897
         '#attributes' => array('tabindex' => '1'),
898
-        '#description' => bts('Enter your @s email address.', array('@s' => variable_get('site_name', 'Drupal-BOINC')), NULL, 'boinc:standard-login-page')
898
+        '#description' => bts('Enter your @s email address.', array('@s' => variable_get('site_name', 'Drupal-BOINC')), null, 'boinc:standard-login-page')
899 899
       ),
900 900
       'validation_source' => array(
901 901
         '#type' => 'hidden',
@@ -911,7 +911,7 @@  discard block
 block discarded – undo
911 911
     );
912 912
     $form['buttons']['submit'] = $form['submit'];
913 913
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
914
-    $form['buttons']['submit']['#value'] = bts('Log in', array(), NULL, 'boinc:standard-login-page');
914
+    $form['buttons']['submit']['#value'] = bts('Log in', array(), null, 'boinc:standard-login-page');
915 915
     $form['buttons']['submit']['#suffix'] = '</li>';
916 916
     $form['buttons']['submit']['#weight'] = 1002;
917 917
     $form['buttons']['form control tabs suffix'] = array(
@@ -927,7 +927,7 @@  discard block
 block discarded – undo
927 927
     if (isset($form_state['post']['email']) and isset($form_state['post']['pass'])) {
928 928
       // Find the local validation function's entry so we can replace it.
929 929
       $array_key = array_search('user_login_authenticate_validate', $form['#validate']);
930
-      if ($array_key === FALSE) {
930
+      if ($array_key === false) {
931 931
         // Could not find it. Some other module must have run form_alter().
932 932
         // We will simply add our validation just before the final validator.
933 933
         $final_validator = array_pop($form['#validate']);
@@ -955,26 +955,26 @@  discard block
 block discarded – undo
955 955
     }
956 956
 
957 957
     // Set special message if user has not agreed to TOU
958
-    $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
958
+    $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', false);
959 959
     $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
960 960
     if ( (!boincuser_check_termsofuse($account)) and ($existinguser_tou) and (!empty($termsofuse)) and (!user_access('administer users')) ) {
961 961
       drupal_set_message(
962 962
         bts('INFO: You have not agreed to the terms of use for @project. You may use this form to change your email address and/or password. Please note: you may not delete your account within seven (7) days of changing your email address.',
963 963
         array(
964 964
           '@project' => variable_get('site_name','Drupal-BOINC'),
965
-        ), NULL, 'boinc:account-credentials-change')
965
+        ), null, 'boinc:account-credentials-change')
966 966
       , 'info');
967 967
     }
968 968
 
969 969
     // A bit hackish... but don't require the user to enter his password if
970 970
     // coming from the password reset function
971
-    $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/{$form['#uid']}") === FALSE) ? 0 : 1;
971
+    $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/{$form['#uid']}") === false) ? 0 : 1;
972 972
     if ($reset_pass) {
973 973
       $_SESSION['reset_pass'] = 1;
974 974
     }
975 975
 
976 976
     // Adjust form elements already present
977
-    $form['account']['name']['#title'] = bts('Drupal Username', array(), NULL, 'boinc:drupal-username');
977
+    $form['account']['name']['#title'] = bts('Drupal Username', array(), null, 'boinc:drupal-username');
978 978
     $form['account']['name']['#size'] = 40;
979 979
     $form['account']['name']['#attributes']['autocomplete'] = 'off';
980 980
     $form['account']['name']['#description'] .= '<p>This is the drupal (internal) username. The title above shows the BOINC username, which is the display name used publicly that the user can change in Community Preferences.';
@@ -985,11 +985,11 @@  discard block
 block discarded – undo
985 985
       // Add BOINC username (aka displayname)
986 986
       $form['account']['boincuser_name'] = array(
987 987
         '#type' => 'textfield',
988
-        '#title' => bts('BOINC Username', array(), NULL, 'boinc:user-or-team-name'),
988
+        '#title' => bts('BOINC Username', array(), null, 'boinc:user-or-team-name'),
989 989
         '#default_value' => $account->boincuser_name,
990 990
         '#maxlength' => USERNAME_MAX_LENGTH,
991
-        '#required' => TRUE,
992
-        '#description' => bts('This is the BOINC (external) username. This is the same setting as found in Account -> Preferences -> Community.', array(), NULL, 'boinc:username-change'),
991
+        '#required' => true,
992
+        '#description' => bts('This is the BOINC (external) username. This is the same setting as found in Account -> Preferences -> Community.', array(), null, 'boinc:username-change'),
993 993
         '#size' => 40,
994 994
       );
995 995
     }
@@ -998,23 +998,23 @@  discard block
 block discarded – undo
998 998
     // ago, it cannot be changed again.
999 999
     $duration = TOKEN_DURATION_ONE_WEEK;
1000 1000
     if (($account->boincuser_email_addr_change_time + $duration) > time() and (!user_access('administer users'))) {
1001
-      $form['account']['mail']['#required'] = FALSE;
1001
+      $form['account']['mail']['#required'] = false;
1002 1002
       $form['account']['mailhelp'] = array(
1003 1003
         '#value' => bts("You email address was changed within the past seven (7) days. Please look for an email to !prev_email if you need to revert this change. You may change your email address on !time.",
1004 1004
           array(
1005 1005
             '!prev_email' => $account->boincuser_previous_email_addr,
1006 1006
             '!time' => date('F j, Y \a\t G:i T', $account->boincuser_email_addr_change_time + $duration),
1007
-          ), NULL, 'boinc:account-credentials-change'),
1007
+          ), null, 'boinc:account-credentials-change'),
1008 1008
       );
1009 1009
     }
1010 1010
 
1011
-    if (!$reset_pass AND ($user->uid == $account->uid OR !user_access('administer users'))) {
1011
+    if (!$reset_pass and ($user->uid == $account->uid or !user_access('administer users'))) {
1012 1012
       // Add a password authenticator, required to change email or pw
1013 1013
       $form['account']['current_pass'] = array(
1014 1014
         '#type' => 'password',
1015
-        '#title' => bts('Enter your password to save changes', array(), NULL, 'boinc:account-credentials-change'),
1015
+        '#title' => bts('Enter your password to save changes', array(), null, 'boinc:account-credentials-change'),
1016 1016
         '#description' => bts('Enter your current password if changing your email
1017
-          address or password.', array(), NULL, 'boinc:account-credentials-change'),
1017
+          address or password.', array(), null, 'boinc:account-credentials-change'),
1018 1018
         '#size' => 17,
1019 1019
         '#attributes' => array(
1020 1020
           'autocomplete' => 'off',
@@ -1026,35 +1026,35 @@  discard block
 block discarded – undo
1026 1026
     $form['account']['boincuser_id'] = array(
1027 1027
       '#value' => '
1028 1028
         <div class="form-item">
1029
-          <label>' . bts('BOINC user ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1029
+          <label>' . bts('BOINC user ID', array(), null, 'boinc:account-credentials-change') . '</label>
1030 1030
           <span>' . $account->boincuser_id . '</span>
1031 1031
         </div>',
1032 1032
     );
1033 1033
     $form['account']['user_id'] = array(
1034 1034
       '#value' => '
1035 1035
         <div class="form-item">
1036
-          <label>' . bts('Drupal user ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1036
+          <label>' . bts('Drupal user ID', array(), null, 'boinc:account-credentials-change') . '</label>
1037 1037
           <span>' . $account->uid . '</span>
1038 1038
         </div>',
1039 1039
     );
1040 1040
     $form['account']['account_key'] = array(
1041 1041
       '#value' => '
1042 1042
         <div class="form-item">
1043
-          <label>' . bts('Account key', array(), NULL, 'boinc:account-credentials-change') . '</label>
1043
+          <label>' . bts('Account key', array(), null, 'boinc:account-credentials-change') . '</label>
1044 1044
           <span>' . $account->boincuser_account_key . '</span>
1045 1045
         </div>',
1046 1046
     );
1047 1047
     $form['account']['weak_account_key'] = array(
1048 1048
       '#value' => '
1049 1049
         <div class="form-item">
1050
-          <label>' . bts('Weak account key', array(), NULL, 'boinc:account-credentials-change') . '</label>
1050
+          <label>' . bts('Weak account key', array(), null, 'boinc:account-credentials-change') . '</label>
1051 1051
           <span>' . "{$account->boincuser_id}_{$account->boincuser_weak_auth}" . '</span>
1052 1052
         </div>',
1053 1053
     );
1054 1054
     $form['account']['cpid'] = array(
1055 1055
       '#value' => '
1056 1056
         <div class="form-item">
1057
-          <label>' . bts('Cross-project ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1057
+          <label>' . bts('Cross-project ID', array(), null, 'boinc:account-credentials-change') . '</label>
1058 1058
           <span>' . $account->boincuser_cpid . '</span>
1059 1059
         </div>',
1060 1060
     );
@@ -1069,14 +1069,14 @@  discard block
 block discarded – undo
1069 1069
       '#weight' => 1001,
1070 1070
     );
1071 1071
     $form['submit']['#prefix'] = '<li class="first tab">';
1072
-    $form['submit']['#value'] = bts('Save changes', array(), NULL, 'boinc:form-save');
1072
+    $form['submit']['#value'] = bts('Save changes', array(), null, 'boinc:form-save');
1073 1073
     $form['submit']['#suffix'] = '</li>';
1074 1074
     $form['submit']['#weight'] = 1002;
1075 1075
     $form['cancel'] = array(
1076
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1076
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1077 1077
       '#weight' => 1003,
1078 1078
     );
1079
-    if (isset($form['delete']) AND is_array($form['delete'])) {
1079
+    if (isset($form['delete']) and is_array($form['delete'])) {
1080 1080
       $form['delete']['#prefix'] = '<li class="first alt tab">';
1081 1081
       $form['delete']['#suffix'] = '</li>';
1082 1082
       $form['delete']['#weight'] = 1004;
@@ -1138,7 +1138,7 @@  discard block
 block discarded – undo
1138 1138
 
1139 1139
     // Set form['title'], but hide it
1140 1140
     $form['title']['#default_value'] = $account->boincuser_name;
1141
-    $form['title']['#access'] = FALSE;
1141
+    $form['title']['#access'] = false;
1142 1142
 
1143 1143
     $form['separator_bottom'] = array(
1144 1144
       '#value' => '<div class="separator buttons"></div>',
@@ -1159,7 +1159,7 @@  discard block
 block discarded – undo
1159 1159
       '#weight' => 1001,
1160 1160
     );
1161 1161
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
1162
-    $form['buttons']['submit']['#value'] = bts('Save changes', array(), NULL, 'boinc:form-save');
1162
+    $form['buttons']['submit']['#value'] = bts('Save changes', array(), null, 'boinc:form-save');
1163 1163
     $form['buttons']['submit']['#suffix'] = '</li>';
1164 1164
     $form['buttons']['submit']['#weight'] = 1002;
1165 1165
     $form['buttons']['preview']['#prefix'] = '<li class="tab">';
@@ -1169,12 +1169,12 @@  discard block
 block discarded – undo
1169 1169
     $form['buttons']['preview_changes']['#suffix'] = '</li>';
1170 1170
     $form['buttons']['preview_changes']['#weight'] = 1004;
1171 1171
     $form['buttons']['cancel'] = array(
1172
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1172
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1173 1173
       '#weight' => 1005,
1174 1174
     );
1175 1175
     $form['buttons']['delete']['#prefix'] = '<li class="tab">';
1176 1176
     $form['buttons']['delete']['#suffix'] = '</li>';
1177
-    $form['buttons']['delete']['#value'] = bts('Clear User Profile', array(), NULL, 'boinc:form-save');
1177
+    $form['buttons']['delete']['#value'] = bts('Clear User Profile', array(), null, 'boinc:form-save');
1178 1178
     $form['buttons']['delete']['#weight'] = 1006;
1179 1179
     $form['buttons']['delete']['#submit'] = array('_boincuser_node_profile_delete_submit');
1180 1180
     $form['buttons']['form control tabs suffix'] = array(
@@ -1208,11 +1208,11 @@  discard block
 block discarded – undo
1208 1208
     array_unshift($form, array(
1209 1209
       'boincuser_name' => array(
1210 1210
         '#type' => 'textfield', 
1211
-        '#title' => bts('Name', array(), NULL, 'boinc:user-or-team-name'), 
1211
+        '#title' => bts('Name', array(), null, 'boinc:user-or-team-name'), 
1212 1212
         '#default_value' => $edit['boincuser_name'], 
1213 1213
         '#maxlength' => USERNAME_MAX_LENGTH, 
1214
-        '#description' => bts('Spaces are allowed; punctuation is not allowed except for periods, hyphens, and underscores.', array(), NULL, 'boinc:user-register'), 
1215
-        '#required' => TRUE
1214
+        '#description' => bts('Spaces are allowed; punctuation is not allowed except for periods, hyphens, and underscores.', array(), null, 'boinc:user-register'), 
1215
+        '#required' => true
1216 1216
       ),
1217 1217
     ));
1218 1218
     // Set name temporarily to dummy value to beat validation
@@ -1232,27 +1232,27 @@  discard block
 block discarded – undo
1232 1232
         '#type'   => 'fieldset',
1233 1233
         '#prefix' => '<div id="termsofuse-wrapper">', // This is our wrapper div.
1234 1234
         '#suffix' => '</div>',
1235
-        '#tree'   => TRUE,
1235
+        '#tree'   => true,
1236 1236
         '#weight' => -15,
1237 1237
       );
1238 1238
 
1239 1239
       $form['termsofuse']['title1'] = array(
1240 1240
         '#weight' => -12,
1241
-        '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), NULL, 'project:user-register' ) . '</h2>',
1241
+        '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), null, 'project:user-register' ) . '</h2>',
1242 1242
         '#prefix' => '<div id="register-title1">',
1243 1243
         '#suffix' => '</div>',
1244 1244
       );
1245 1245
 
1246 1246
       $form['termsofuse']['body'] = array(
1247 1247
         '#weight' => -10,
1248
-        '#value' => bts($termsofuse, array(), NULL, 'project:user-register'),
1248
+        '#value' => bts($termsofuse, array(), null, 'project:user-register'),
1249 1249
         '#prefix' => '<div id="register-termsofuse">',
1250 1250
         '#suffix' => '</div>',
1251 1251
       );
1252 1252
 
1253 1253
       $form['termsofuse']['agreeTOU'] = array(
1254 1254
         '#type' => 'checkbox',
1255
-        '#title' => bts(variable_get('boinc_weboptions_agreequestion', 'Do you agree with the above terms of use?'), array(), NULL, 'project:user-register'),
1255
+        '#title' => bts(variable_get('boinc_weboptions_agreequestion', 'Do you agree with the above terms of use?'), array(), null, 'project:user-register'),
1256 1256
         '#weight' => -8,
1257 1257
         '#prefix' => '<div id="register-checkbox">',
1258 1258
         '#suffix' => '</div>',
@@ -1261,7 +1261,7 @@  discard block
 block discarded – undo
1261 1261
 
1262 1262
     $form['title2'] = array(
1263 1263
       '#weight' => -6,
1264
-      '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle2', 'Fill in your name, email, and choose a secure passphrase.'), array(), NULL, 'project:user-register') . '</h2>',
1264
+      '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle2', 'Fill in your name, email, and choose a secure passphrase.'), array(), null, 'project:user-register') . '</h2>',
1265 1265
       '#prefix' => '<div id="register-title2">',
1266 1266
       '#suffix' => '</div>',
1267 1267
     );
@@ -1281,26 +1281,26 @@  discard block
 block discarded – undo
1281 1281
     
1282 1282
   // Request new password form
1283 1283
   case 'user_pass':
1284
-    drupal_set_title(bts('Forgot password', array(), NULL, 'boinc:forgot-password'));
1284
+    drupal_set_title(bts('Forgot password', array(), null, 'boinc:forgot-password'));
1285 1285
     // Replace name/email text box with email only; retain "name" label
1286 1286
     // for compatibility with standard Drupal submit function
1287 1287
     unset($form['name']);
1288 1288
     array_unshift($form, array(
1289 1289
       'name' => array(
1290 1290
         '#type' => 'textfield',
1291
-        '#title' => bts('Email address', array(), NULL, 'boinc:email-address-to-login'),
1291
+        '#title' => bts('Email address', array(), null, 'boinc:email-address-to-login'),
1292 1292
         '#size' => 60,
1293 1293
         '#maxlength' => EMAIL_MAX_LENGTH,
1294
-        '#required' => TRUE,
1294
+        '#required' => true,
1295 1295
         '#description' => bts(
1296 1296
           'Enter your email address to receive instructions for resetting your password (or use the !authenticator_login).',
1297 1297
           array(
1298 1298
             '!authenticator_login' => l(
1299
-              bts('authenticator-based login', array(), NULL, 'boinc:forgot-password'),
1299
+              bts('authenticator-based login', array(), null, 'boinc:forgot-password'),
1300 1300
               'user/login/auth'
1301 1301
             )
1302 1302
           )
1303
-        , NULL, 'boinc:forgot-password'),
1303
+        , null, 'boinc:forgot-password'),
1304 1304
       ),
1305 1305
     ));
1306 1306
     
@@ -1311,11 +1311,11 @@  discard block
 block discarded – undo
1311 1311
     );
1312 1312
     $form['buttons']['submit'] = $form['submit'];
1313 1313
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
1314
-    $form['buttons']['submit']['#value'] = bts('Send', array(), NULL, 'boinc:form-send');
1314
+    $form['buttons']['submit']['#value'] = bts('Send', array(), null, 'boinc:form-send');
1315 1315
     $form['buttons']['submit']['#suffix'] = '</li>';
1316 1316
     $form['buttons']['submit']['#weight'] = 1002;
1317 1317
     $form['buttons']['cancel'] = array(
1318
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/login') . '</li>',
1318
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), 'user/login') . '</li>',
1319 1319
       '#weight' => 1005,
1320 1320
     );
1321 1321
     $form['buttons']['form control tabs suffix'] = array(
@@ -1332,7 +1332,7 @@  discard block
 block discarded – undo
1332 1332
     break;
1333 1333
     
1334 1334
   case 'views_exposed_form':
1335
-      $form['submit']['#value'] = bts('Search', array(), NULL, 'boinc:search-user');
1335
+      $form['submit']['#value'] = bts('Search', array(), null, 'boinc:search-user');
1336 1336
     break;
1337 1337
   }
1338 1338
 }
@@ -1364,7 +1364,7 @@  discard block
 block discarded – undo
1364 1364
 function boincuser_process_password_confirm($element) {
1365 1365
   // Check if parent element is "account".
1366 1366
   if ($element['#array_parents'][0] == 'account') {
1367
-    $element['pass1']['#title'] = bts('Change password', array(), NULL, 'boinc:forgot-password');
1367
+    $element['pass1']['#title'] = bts('Change password', array(), null, 'boinc:forgot-password');
1368 1368
   }
1369 1369
   return $element;
1370 1370
 }
@@ -1384,7 +1384,7 @@  discard block
 block discarded – undo
1384 1384
 /**
1385 1385
  * Implementation of hook_token_values
1386 1386
  */
1387
-function boincuser_token_values($type, $object = NULL, $options = array()) {
1387
+function boincuser_token_values($type, $object = null, $options = array()) {
1388 1388
   if ($type == 'user') {
1389 1389
     $account = user_load($object->uid);
1390 1390
     $tokens['display-name'] = $account->boincuser_name;
@@ -1450,13 +1450,13 @@  discard block
 block discarded – undo
1450 1450
   require_boinc('boinc_db');
1451 1451
   $num_deleted = BoincUserDeleted::delete_expired();
1452 1452
   if ($num_deleted>0) {
1453
-    watchdog('boincuser', "Deleted ${num_deleted} users from user_deleted table", WATCHDOG_NOTICE);
1453
+    watchdog('boincuser', "deleted ${num_deleted} users from user_deleted table", WATCHDOG_NOTICE);
1454 1454
   }
1455 1455
 
1456 1456
   // Delete expired tokens from token table
1457 1457
   $tokens_deleted = BoincToken::delete_expired();
1458 1458
   if ($tokens_deleted>0) {
1459
-    watchdog('boincuser', "Deleted ${tokens_deleted} tokens from token table", WATCHDOG_NOTICE);
1459
+    watchdog('boincuser', "deleted ${tokens_deleted} tokens from token table", WATCHDOG_NOTICE);
1460 1460
   }
1461 1461
 }
1462 1462
 
@@ -1498,8 +1498,8 @@  discard block
 block discarded – undo
1498 1498
   if (!isset($account->roles[$verified_contributor])) {
1499 1499
     drupal_set_message(bts(
1500 1500
         'You may only create or modify your user profile after earning @count credits.',
1501
-        array('@count' => $min_credit_to_post), NULL, 'boinc:view-profile'
1502
-    ), 'warning', FALSE);
1501
+        array('@count' => $min_credit_to_post), null, 'boinc:view-profile'
1502
+    ), 'warning', false);
1503 1503
   }
1504 1504
 
1505 1505
   // For now, just call the user module profile view function
@@ -1542,35 +1542,35 @@  discard block
 block discarded – undo
1542 1542
     if ($registration_enabled) {
1543 1543
       $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1544 1544
       array(
1545
-        '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'),
1545
+        '!create_an_account' => l(bts('create an account', array(), null, 'boinc:join-page'), 'user/registration'),
1546 1546
         '@sitename' => $site_name,
1547
-      ), NULL, 'boinc:join-page') . '</li>';
1547
+      ), null, 'boinc:join-page') . '</li>';
1548 1548
     }
1549
-    $output .= '  <li>' . bts("Install BOINC on this device if not already present.", array(), NULL, 'boinc:join-page') . '</li>';
1549
+    $output .= '  <li>' . bts("Install BOINC on this device if not already present.", array(), null, 'boinc:join-page') . '</li>';
1550 1550
     $output .= '  <li>' . bts("Select <i>Tools / Add Project</i>. Choose @sitename from the list, or enter @siteurl.",
1551 1551
     array(
1552 1552
       '@sitename' => $site_name,
1553 1553
       '@siteurl' => $base_url,
1554
-    ), NULL, 'boinc:join-page') . '</li>';
1554
+    ), null, 'boinc:join-page') . '</li>';
1555 1555
     if ($registration_enabled) {
1556 1556
       $output .= '<li>' . bts("If you're running a command-line or pre-5.0 version of BOINC, use <b>!boinccmd</b> to add the project.",
1557 1557
         array(
1558 1558
           '!boinccmd' => l('boinccmd --project_attach', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1559
-        ), NULL, 'boinc:join-page') . '</li>';
1559
+        ), null, 'boinc:join-page') . '</li>';
1560 1560
     }
1561 1561
     else {
1562 1562
       $output .= '<li>' . bts("If you're running a command-line version of BOINC,
1563 1563
         please follow the <b>!instructionslink</b> to first <i>create an account</i>, and then <i>attach</i> to this project. Use the same project URL as above.",
1564 1564
         array(
1565 1565
           '!instructionslink' => l('instructions', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1566
-        ), NULL, 'boinc:join-page') . '</li>';
1566
+        ), null, 'boinc:join-page') . '</li>';
1567 1567
     }
1568 1568
     $output .= '<li>' . bts("If you're running a pre-5.0 version of BOINC, please
1569 1569
       upgrade to a more recent version of BOINC to create an account
1570 1570
       at @this_project.",
1571 1571
       array(
1572 1572
         '@this_project' => $site_name,
1573
-      ), NULL, 'boinc:join-page') . '</li>';
1573
+      ), null, 'boinc:join-page') . '</li>';
1574 1574
     $output .=  '</ol>';
1575 1575
     break;
1576 1576
   case 'new':
@@ -1590,26 +1590,26 @@  discard block
 block discarded – undo
1590 1590
     if ($registration_enabled) {
1591 1591
       $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1592 1592
       array(
1593
-        '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'),
1593
+        '!create_an_account' => l(bts('create an account', array(), null, 'boinc:join-page'), 'user/registration'),
1594 1594
         '@sitename' => $site_name,
1595
-      ), NULL, 'boinc:join-page') . '</li>';
1595
+      ), null, 'boinc:join-page') . '</li>';
1596 1596
     }
1597 1597
     else if ( menu_valid_path(array('link_path' => $ruleslink)) ) {
1598 1598
       $output .= '  <li>' . bts("Read our !rules_and_policies.", array(
1599
-        '!rules_and_policies' => l(bts('Rules and Policies', array(), NULL, 'boinc:join-page'), $ruleslink),
1600
-      ), NULL, 'boinc:join-page') . '</li>';
1599
+        '!rules_and_policies' => l(bts('Rules and Policies', array(), null, 'boinc:join-page'), $ruleslink),
1600
+      ), null, 'boinc:join-page') . '</li>';
1601 1601
     }
1602
-    $output .= '  <li>' . bts('Download the BOINC desktop software.', array(), NULL, 'boinc:join-page');
1602
+    $output .= '  <li>' . bts('Download the BOINC desktop software.', array(), null, 'boinc:join-page');
1603 1603
     $output .= '    <p>';
1604 1604
     $output .= '      <a class="button" href="http://boinc.berkeley.edu/download.php">Download</a>';
1605 1605
     $output .= '    </p>';
1606
-    $output .= '    ' . bts("For Android devices, download BOINC from the Google Play Store or Amazon App Store.", array(), NULL, 'boinc:join-page');
1606
+    $output .= '    ' . bts("For Android devices, download BOINC from the Google Play Store or Amazon App Store.", array(), null, 'boinc:join-page');
1607 1607
     $output .= '  </li>';
1608
-    $output .= '  <li>' . bts('Run the installer.', array(), NULL, 'boinc:join-page') . '</li>';
1608
+    $output .= '  <li>' . bts('Run the installer.', array(), null, 'boinc:join-page') . '</li>';
1609 1609
     $output .= '  <li>' . bts('Choose @sitename from the list, or enter @siteurl.', array(
1610 1610
       '@sitename' => $site_name,
1611 1611
       '@siteurl' => $base_url,
1612
-    ), NULL, 'boinc:join-page') . '</li>';
1612
+    ), null, 'boinc:join-page') . '</li>';
1613 1613
     $output .=  '</ol>';
1614 1614
   }
1615 1615
   $output .= '</div>';
@@ -1640,17 +1640,17 @@  discard block
 block discarded – undo
1640 1640
   else {
1641 1641
     $uotd = user_load($current_uotd->uid);
1642 1642
   }
1643
-  $uotd_image = boincuser_get_user_profile_image($uotd->uid, FALSE);
1643
+  $uotd_image = boincuser_get_user_profile_image($uotd->uid, false);
1644 1644
   $output = '<h2 class="pane-title">';
1645
-  $output .= ($user->uid) ? bts('Welcome back!', array(), NULL, 'boinc:front-page') : ($site_name ? bts('What is @this_project?', array('@this_project' => $site_name)) : bts('Welcome!', array(), NULL, 'boinc:front-page'));
1645
+  $output .= ($user->uid) ? bts('Welcome back!', array(), null, 'boinc:front-page') : ($site_name ? bts('What is @this_project?', array('@this_project' => $site_name)) : bts('Welcome!', array(), null, 'boinc:front-page'));
1646 1646
   $output .= '</h2>';
1647 1647
   $output .= '<div class="boinc-overview balance-height-front">';
1648
-  $output .= '  <div>' . bts($site_message, array(), NULL, "project:front page") . ' ' . l(bts('Learn more', array(), NULL, 'boinc:front-page'), 'about') . '</div>';
1648
+  $output .= '  <div>' . bts($site_message, array(), null, "project:front page") . ' ' . l(bts('Learn more', array(), null, 'boinc:front-page'), 'about') . '</div>';
1649 1649
   if ($user->uid) {
1650
-    $output .= '  <div>' . l(bts('View account', array(), NULL, 'boinc:front-page'), 'dashboard', array('attributes' => array('class' => 'join button'))) . '</div>';
1650
+    $output .= '  <div>' . l(bts('View account', array(), null, 'boinc:front-page'), 'dashboard', array('attributes' => array('class' => 'join button'))) . '</div>';
1651 1651
   }
1652 1652
   else {
1653
-    $output .= '  <div>' . l(bts('Join now', array(), NULL, 'boinc:front-page'), 'join', array('attributes' => array('class' => 'join button'))) . '</div>';
1653
+    $output .= '  <div>' . l(bts('Join now', array(), null, 'boinc:front-page'), 'join', array('attributes' => array('class' => 'join button'))) . '</div>';
1654 1654
   }
1655 1655
   $output .= '</div>';
1656 1656
   $output .= '<div class="boinc-overview-details">';
@@ -1658,17 +1658,17 @@  discard block
 block discarded – undo
1658 1658
   $output .= '    <a class="user-of-the-day" href="account/' . $uotd->uid . '">';
1659 1659
   $output .= '      <div class="picture">';
1660 1660
   $output .= theme('imagefield_image', $uotd_image['image'], $uotd_image['alt'],
1661
-    $uotd_image['alt'], array(), FALSE);
1661
+    $uotd_image['alt'], array(), false);
1662 1662
   $output .= '      </div>';
1663
-  $output .= '      <div class="text">' . bts('User of the day', array(), NULL, 'boinc:front-page') . '</div>';
1663
+  $output .= '      <div class="text">' . bts('User of the day', array(), null, 'boinc:front-page') . '</div>';
1664 1664
   $output .= '      <div class="detail">' . $uotd->boincuser_name . '</div>';
1665 1665
   $output .= '    </a>';
1666 1666
   $output .= '    <div class="volunteers">';
1667
-  $output .= '      <div class="text">' . bts('Over 500,000 volunteers and counting.', array(), NULL, 'boinc:front-page') . '</div>';
1667
+  $output .= '      <div class="text">' . bts('Over 500,000 volunteers and counting.', array(), null, 'boinc:front-page') . '</div>';
1668 1668
   $output .= '      <div class="platforms">';
1669
-  $output .= '        <div class="detail platform windows">' . bts('Windows', array(), NULL, 'boinc:front-page') . '</div>';
1670
-  $output .= '        <div class="detail platform mac">' .  bts('Mac', array(), NULL, 'boinc:front-page') . '</div>';
1671
-  $output .= '        <div class="detail platform linux">' . bts('Linux', array(), NULL, 'boinc:front-page') . '</div>';
1669
+  $output .= '        <div class="detail platform windows">' . bts('Windows', array(), null, 'boinc:front-page') . '</div>';
1670
+  $output .= '        <div class="detail platform mac">' .  bts('Mac', array(), null, 'boinc:front-page') . '</div>';
1671
+  $output .= '        <div class="detail platform linux">' . bts('Linux', array(), null, 'boinc:front-page') . '</div>';
1672 1672
   $output .= '      </div>';
1673 1673
   $output .= '    </div>';
1674 1674
   $output .= '  </div>';
@@ -1696,12 +1696,12 @@  discard block
 block discarded – undo
1696 1696
   xml_header();
1697 1697
   
1698 1698
   // Account creation disabled
1699
-  $enablethisRPC = variable_get('boinc_weboptions_enableaccountcreateRPC', TRUE);
1699
+  $enablethisRPC = variable_get('boinc_weboptions_enableaccountcreateRPC', true);
1700 1700
   if (!$enablethisRPC) {
1701 1701
     $mess = bts('Account creation is done through our Web site. Please register at @url', array(
1702 1702
       '@url' => $base_url . '/user/registration',
1703 1703
     ),
1704
-    NULL, 'boinc:create_account');
1704
+    null, 'boinc:create_account');
1705 1705
     xml_error(-208, $mess);
1706 1706
   }
1707 1707
   // Invalid invite code
@@ -1755,7 +1755,7 @@  discard block
 block discarded – undo
1755 1755
       'init' => $params['email_addr'],
1756 1756
       'roles' => array($unrestricted_role => ''),
1757 1757
       'boincuser_name' => $params['user_name'],
1758
-      'boinchash_flag' => TRUE,
1758
+      'boinchash_flag' => true,
1759 1759
     );
1760 1760
 
1761 1761
     // Create the drupal user. If the drupal user cannot be created,
@@ -1792,20 +1792,20 @@  discard block
 block discarded – undo
1792 1792
   }
1793 1793
 
1794 1794
   if (strlen($authtoken) != 32) {
1795
-    drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), NULL, 'boinc:account-finish'), 'error');
1795
+    drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), null, 'boinc:account-finish'), 'error');
1796 1796
     drupal_goto();
1797 1797
   }
1798 1798
 
1799 1799
   require_boinc('boinc_db');
1800 1800
   $boinc_user = BoincUser::lookup("authenticator='".addslashes($authtoken)."'");
1801 1801
   if (!$boinc_user) {
1802
-    drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), NULL, 'boinc:account-finish'), 'error');
1802
+    drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), null, 'boinc:account-finish'), 'error');
1803 1803
     drupal_goto();
1804 1804
   }
1805 1805
   $user = user_load(get_drupal_id($boinc_user->id));
1806 1806
 
1807 1807
   if (!$user) {
1808
-    drupal_set_message(bts('ERROR: There was a problem loading your account. Try logging in with your user name and password.', array(), NULL, 'boinc:account-finish'), 'error');
1808
+    drupal_set_message(bts('ERROR: There was a problem loading your account. Try logging in with your user name and password.', array(), null, 'boinc:account-finish'), 'error');
1809 1809
     drupal_goto();
1810 1810
   }
1811 1811
 
@@ -1826,9 +1826,9 @@  discard block
 block discarded – undo
1826 1826
   // Check moderation page exists
1827 1827
   $moderationpath = drupal_lookup_path('source', variable_get('boinc_weboptions_moderationpage', '') );
1828 1828
   if ( menu_valid_path(array('link_path' => $moderationpath)) ) {
1829
-    $modsentence = bts('Please note: user profiles are subject to !moderation.', array('!moderation' => l(bts('moderation', array(), NULL, 'boinc:account-finish'), $moderationpath, $options)), NULL, 'boinc:account-finish');
1829
+    $modsentence = bts('Please note: user profiles are subject to !moderation.', array('!moderation' => l(bts('moderation', array(), null, 'boinc:account-finish'), $moderationpath, $options)), null, 'boinc:account-finish');
1830 1830
   } else {
1831
-    $modsentence = bts('Please note: user profiles are subject to moderation.', array(), NULL, 'boinc:account-finish');
1831
+    $modsentence = bts('Please note: user profiles are subject to moderation.', array(), null, 'boinc:account-finish');
1832 1832
   }
1833 1833
 
1834 1834
   $username = $user->boincuser_name;
@@ -1837,73 +1837,73 @@  discard block
 block discarded – undo
1837 1837
   array(
1838 1838
     '@user_name' => $username,
1839 1839
     '@site_name' => $site_name,
1840
-  ), NULL, 'boinc:account-finish') . "</p>";
1840
+  ), null, 'boinc:account-finish') . "</p>";
1841 1841
 
1842 1842
   $links = array(
1843 1843
     array(
1844 1844
       'data' => bts('Change your username at !community_preferences.', array(
1845
-        '!community_preferences' => l(bts('Community Preferences', array(), NULL, 'boinc:account-fininsh'), 'account/prefs/community', $options),
1846
-      ), NULL, 'boinc:account-finish'),
1845
+        '!community_preferences' => l(bts('Community Preferences', array(), null, 'boinc:account-fininsh'), 'account/prefs/community', $options),
1846
+      ), null, 'boinc:account-finish'),
1847 1847
       'children' => array(
1848
-        bts('Your username is used to identify yourself to other volunteers on this Web site.', array(), NULL, 'boinc:account-finish'),
1849
-        bts('In addition, you may set your account\'s default language and adjust notification settings.', array(), NULL, 'boinc:account-finish'),
1848
+        bts('Your username is used to identify yourself to other volunteers on this Web site.', array(), null, 'boinc:account-finish'),
1849
+        bts('In addition, you may set your account\'s default language and adjust notification settings.', array(), null, 'boinc:account-finish'),
1850 1850
       ),
1851 1851
     ),
1852 1852
     array(
1853 1853
       'data' => bts('Change your !computing_preferences.', array(
1854
-        '!computing_preferences' => l(bts('Computing Preferences', array(), NULL, 'boinc:account-finish'), 'account/prefs', $options),
1855
-      ), NULL, 'boinc:account-finish'),
1854
+        '!computing_preferences' => l(bts('Computing Preferences', array(), null, 'boinc:account-finish'), 'account/prefs', $options),
1855
+      ), null, 'boinc:account-finish'),
1856 1856
       'children' => array(
1857
-        bts('You may adjust how much CPU, RAM, and Disk space the BOINC client is allowed to use for tasks on your computer.', array(), NULL, 'boinc:account-finish'),
1857
+        bts('You may adjust how much CPU, RAM, and Disk space the BOINC client is allowed to use for tasks on your computer.', array(), null, 'boinc:account-finish'),
1858 1858
         bts('By default, you will run @site_name tasks without any additional configuration.', array(
1859 1859
           '@site_name' => $site_name,
1860
-        ), NULL, 'boinc:account-finish'),
1860
+        ), null, 'boinc:account-finish'),
1861 1861
         bts('It is recommended new volunteers leave the default settings until they gain experience running some tasks. Ask questions in the !forums to get advice before making changes to a setting you don\'t understand.', array(
1862
-          '!forums' => l(bts('forums', array(), NULL, 'boinc:account-finish'), 'community/forum', $options),
1863
-        ), NULL, 'boinc:account-finish'),
1862
+          '!forums' => l(bts('forums', array(), null, 'boinc:account-finish'), 'community/forum', $options),
1863
+        ), null, 'boinc:account-finish'),
1864 1864
       ),
1865 1865
     ),
1866 1866
     array(
1867 1867
         'data' => bts('Create a !user_profile.', array(
1868
-          '!user_profile' => l(bts('User Profile', array(), NULL, 'boinc:account-finish'), '/account/profile/edit', $options),
1869
-        ), NULL, 'boinc:account-finish'),
1868
+          '!user_profile' => l(bts('User Profile', array(), null, 'boinc:account-finish'), '/account/profile/edit', $options),
1869
+        ), null, 'boinc:account-finish'),
1870 1870
       'children' => array(
1871 1871
         bts('A user profile will inform other volunteers who you are and why you joined @site_name.', array(
1872 1872
           '@site_name' => $site_name,
1873
-        ), NULL, 'boinc:account-finish'),
1873
+        ), null, 'boinc:account-finish'),
1874 1874
         $modsentence,
1875 1875
       ),
1876 1876
     ),
1877 1877
     array(
1878 1878
       'data' => bts('Join a !team.', array(
1879
-        '!team' => l(bts('Team', array(), NULL, 'boinc:account-finish'), '/community/teams', $options),
1880
-      ), NULL, 'boinc:account-finish'),
1879
+        '!team' => l(bts('Team', array(), null, 'boinc:account-finish'), '/community/teams', $options),
1880
+      ), null, 'boinc:account-finish'),
1881 1881
       'children' => array(
1882
-        bts('You may join a team, made up of other volunteers.', array(), NULL, 'boinc:account-finish'),
1882
+        bts('You may join a team, made up of other volunteers.', array(), null, 'boinc:account-finish'),
1883 1883
       ),
1884 1884
     ),
1885 1885
     array(
1886 1886
       'data' => bts('Go to your !account_dashboard.', array(
1887
-        '!account_dashboard'=> l(bts('Account Dashboard', array(), NULL, 'boinc:account-finish'), 'account/dashboard', $options),
1888
-      ), NULL, 'boinc:account-finish'),
1887
+        '!account_dashboard'=> l(bts('Account Dashboard', array(), null, 'boinc:account-finish'), 'account/dashboard', $options),
1888
+      ), null, 'boinc:account-finish'),
1889 1889
       'children' => array(
1890
-        bts('Your account dashboard has information and links about your computer(s) and task(s) assigned.', array(), NULL, 'boinc:account-finish'),
1890
+        bts('Your account dashboard has information and links about your computer(s) and task(s) assigned.', array(), null, 'boinc:account-finish'),
1891 1891
       ),
1892 1892
     ),
1893 1893
     array(
1894 1894
       'data' => bts('Visit our !help pages.', array(
1895
-        '!help' => l(bts('Help', array(), NULL, 'boinc:account-finish'), '/help', $options)
1896
-      ), NULL, 'boinc:account-finish'),
1895
+        '!help' => l(bts('Help', array(), null, 'boinc:account-finish'), '/help', $options)
1896
+      ), null, 'boinc:account-finish'),
1897 1897
       'children' => array(
1898 1898
         bts('Ask for help in our community\'s !forums.', array(
1899
-          '!forums' => l(bts('forums', array(), NULL, 'boinc:account-finish'), 'community/forum', $options)
1900
-        ), NULL, 'boinc:account-finish'),
1899
+          '!forums' => l(bts('forums', array(), null, 'boinc:account-finish'), 'community/forum', $options)
1900
+        ), null, 'boinc:account-finish'),
1901 1901
       ),
1902 1902
     ),
1903 1903
   );
1904 1904
 
1905 1905
   //List of links
1906
-  $output .= theme_item_list($links, $title = NULL, $type='ul');
1906
+  $output .= theme_item_list($links, $title = null, $type='ul');
1907 1907
 
1908 1908
   return $output;
1909 1909
 }
@@ -1913,20 +1913,20 @@  discard block
 block discarded – undo
1913 1913
  */
1914 1914
 function boincuser_moderate_community_access() {
1915 1915
   if (user_access('assign community member role')
1916
-  OR user_access('assign all roles')) {
1917
-    return TRUE;
1916
+  or user_access('assign all roles')) {
1917
+    return true;
1918 1918
   }
1919
-  return FALSE;
1919
+  return false;
1920 1920
 }
1921 1921
 
1922 1922
 /**
1923 1923
  * Get the count of items in the moderation queue
1924 1924
  */
1925 1925
 function boincuser_moderation_queue_count($caller = 'user') {
1926
-  $allowed = FALSE;
1926
+  $allowed = false;
1927 1927
   switch ($caller) {
1928 1928
   case 'cron':
1929
-    $allowed = TRUE;
1929
+    $allowed = true;
1930 1930
     break;
1931 1931
   case 'user':
1932 1932
   default:
@@ -1940,7 +1940,7 @@  discard block
 block discarded – undo
1940 1940
       AND moderate = 1"
1941 1941
     ));
1942 1942
   }
1943
-  return NULL;
1943
+  return null;
1944 1944
 }
1945 1945
 
1946 1946
 /**
@@ -1948,10 +1948,10 @@  discard block
 block discarded – undo
1948 1948
  * Allow community membership status to be set for users by direct link rather
1949 1949
  * than through the user account info form.
1950 1950
  */
1951
-function boincuser_control($uid = NULL, $action = NULL) {
1952
-  if (!$uid OR !$account = user_load($uid)) {
1951
+function boincuser_control($uid = null, $action = null) {
1952
+  if (!$uid or !$account = user_load($uid)) {
1953 1953
     // What are you even doing here...
1954
-    return FALSE;
1954
+    return false;
1955 1955
   }
1956 1956
   switch ($action) {
1957 1957
   case 'ban':
@@ -2057,7 +2057,7 @@  discard block
 block discarded – undo
2057 2057
  */
2058 2058
 function boincuser_moderate_user_ban($uid, $reason = '', $duration = '') {
2059 2059
   if (user_access('assign community member role')
2060
-  OR user_access('assign all roles')) {
2060
+  or user_access('assign all roles')) {
2061 2061
     $account = user_load($uid);
2062 2062
     if ($account->uid) {
2063 2063
       module_load_include('inc', 'rules', 'modules/system.rules');
@@ -2137,7 +2137,7 @@  discard block
 block discarded – undo
2137 2137
  * User profile image is managed by the content_profile module rather than core
2138 2138
  * Drupal User so must be inserted into comments, etc. (not so by default)
2139 2139
  */
2140
-function boincuser_get_user_profile_image($uid, $avatar = TRUE) {
2140
+function boincuser_get_user_profile_image($uid, $avatar = true) {
2141 2141
   // Though the function name implies otherwise, get the avatar by default
2142 2142
   $image_field = ($avatar) ? 'field_image_fid' : 'field_profile_image_fid';
2143 2143
   $image_fid = db_result(db_query("
@@ -2150,7 +2150,7 @@  discard block
 block discarded – undo
2150 2150
   if (!$user_image['image']['filepath']) {
2151 2151
     // Load the default image if one does not exist
2152 2152
     $account = user_load($uid);
2153
-    if ($avatar AND module_exists('gravatar') AND user_access('use gravatar', $account) AND $account->gravatar) {
2153
+    if ($avatar and module_exists('gravatar') and user_access('use gravatar', $account) and $account->gravatar) {
2154 2154
       // Use a Gravatar rather than the system default image
2155 2155
       $options = array(
2156 2156
         'size' => 100,
@@ -2178,23 +2178,23 @@  discard block
 block discarded – undo
2178 2178
  * Generate a table of a user's projects
2179 2179
  */
2180 2180
 function boincuser_get_projects_table($account = null) {
2181
-  if ($account AND is_numeric($account)) {
2181
+  if ($account and is_numeric($account)) {
2182 2182
     $account = user_load($account);
2183 2183
   }
2184 2184
   $projects = boincuser_get_projects($account);
2185
-  if (!$projects) return bts('no projects...', array(), NULL, 'boinc:account-dashboard');
2185
+  if (!$projects) return bts('no projects...', array(), null, 'boinc:account-dashboard');
2186 2186
   
2187 2187
   $output = '';
2188 2188
   $output .= '<table class="user-projects">' . "\n";
2189 2189
   $output .= '<thead>' . "\n";
2190 2190
   $output .= '  <tr>' . "\n";
2191
-  $output .= '    <th>' . bts('Name', array(), NULL, 'boinc:project-name:-1:ignoreoverwrite') . '</th>' . "\n";
2192
-  $output .= '    <th class="numeric">' . bts('Avg credit', array(), NULL, 'boinc:account-dashboard') . '</th>' . "\n";
2193
-  $output .= '    <th class="numeric">' . bts('Total credit', array(), NULL, 'boinc:user-or-team-total-credits') . '</th>' . "\n";
2191
+  $output .= '    <th>' . bts('Name', array(), null, 'boinc:project-name:-1:ignoreoverwrite') . '</th>' . "\n";
2192
+  $output .= '    <th class="numeric">' . bts('Avg credit', array(), null, 'boinc:account-dashboard') . '</th>' . "\n";
2193
+  $output .= '    <th class="numeric">' . bts('Total credit', array(), null, 'boinc:user-or-team-total-credits') . '</th>' . "\n";
2194 2194
   $output .= '  </tr>' . "\n";
2195 2195
   $output .= '</thead>' . "\n";
2196 2196
   $output .= '<tbody>' . "\n";
2197
-  foreach ($projects AS $project) {
2197
+  foreach ($projects as $project) {
2198 2198
     $url = rtrim($project->url, '/') . '/show_user.php?userid=' . $project->id;
2199 2199
     $output .= '  <tr>' . "\n";
2200 2200
     $output .= '    <td>' . l($project->name, $url) . '</td>' . "\n";
@@ -2232,7 +2232,7 @@  discard block
 block discarded – undo
2232 2232
   if (in_array($result->code, array(200, 304))) {
2233 2233
     return simplexml_load_string($result->data);
2234 2234
   }
2235
-  return NULL;
2235
+  return null;
2236 2236
 }
2237 2237
 
2238 2238
 /**
@@ -2248,7 +2248,7 @@  discard block
 block discarded – undo
2248 2248
   
2249 2249
   $account_stats = boincuser_get_stats_user_data($account->boincuser_cpid);
2250 2250
   
2251
-  return ($account_stats AND isset($account_stats->project)) ? $account_stats->project : null;
2251
+  return ($account_stats and isset($account_stats->project)) ? $account_stats->project : null;
2252 2252
 }
2253 2253
 
2254 2254
 
@@ -2261,18 +2261,18 @@  discard block
 block discarded – undo
2261 2261
   $profile = content_profile_load('profile', $account->uid);
2262 2262
   $output = '';
2263 2263
   if ($profile) {
2264
-    $profile_is_approved = ($profile->status AND !$profile->moderate);
2264
+    $profile_is_approved = ($profile->status and !$profile->moderate);
2265 2265
     $user_is_moderator = user_access('edit any profile content');
2266 2266
     $is_own_profile = ($user->uid == $account->uid);
2267 2267
     $profile_moderation_path = "moderate/profile/{$account->uid}";
2268 2268
     $links = array();
2269 2269
     
2270
-    if ($profile->moderate AND $user_is_moderator) {
2270
+    if ($profile->moderate and $user_is_moderator) {
2271 2271
       $links['approve_profile'] = array(
2272
-        'title' => bts('Approve profile', array(), NULL, 'boinc:moderate-user'),
2272
+        'title' => bts('Approve profile', array(), null, 'boinc:moderate-user'),
2273 2273
         'href' => "{$profile_moderation_path}/approve",
2274 2274
         'attributes' => array(
2275
-          'title' => bts('Approve this profile content', array(), NULL, 'boinc:moderate-user'),
2275
+          'title' => bts('Approve this profile content', array(), null, 'boinc:moderate-user'),
2276 2276
           'class' => 'first primary tab',
2277 2277
         )
2278 2278
       );
@@ -2285,10 +2285,10 @@  discard block
 block discarded – undo
2285 2285
         )
2286 2286
       );*/
2287 2287
       $links['reject_profile'] = array(
2288
-        'title' => bts('Reject profile', array(), NULL, 'boinc:moderate-user'),
2288
+        'title' => bts('Reject profile', array(), null, 'boinc:moderate-user'),
2289 2289
         'href' => "{$profile_moderation_path}/reject",
2290 2290
         'attributes' => array(
2291
-          'title' => bts('Reject this profile content', array(), NULL, 'boinc:moderate-user'),
2291
+          'title' => bts('Reject this profile content', array(), null, 'boinc:moderate-user'),
2292 2292
           'class' => 'tab',
2293 2293
         )
2294 2294
       );
@@ -2342,7 +2342,7 @@  discard block
 block discarded – undo
2342 2342
 function boincuser_apachesolr_index_documents_alter(array &$documents, $entity, $entity_type, $env_id) {
2343 2343
 
2344 2344
   foreach ($documents as $document) {
2345
-    if ( $document->entity_type=='node' AND $document->bundle=='profile' ) {
2345
+    if ( $document->entity_type=='node' and $document->bundle=='profile' ) {
2346 2346
       // Node information.
2347 2347
       $nid = $document->entity_id;
2348 2348
       $node = node_load($nid);
@@ -2396,7 +2396,7 @@  discard block
 block discarded – undo
2396 2396
     if ($recipient = user_load(array('uid' => $drupalid))) {
2397 2397
       // Double-check that the loaded user matches both boincuser_id
2398 2398
       // and boincuser_name.
2399
-      if ( ($boincid == $recipient->boincuser_id) AND ($boincname == $recipient->boincuser_name) ) {
2399
+      if ( ($boincid == $recipient->boincuser_id) and ($boincname == $recipient->boincuser_name) ) {
2400 2400
         return $recipient;
2401 2401
       }
2402 2402
     }
Please login to merge, or discard this patch.
Indentation   +837 added lines, -837 removed lines patch added patch discarded remove patch
@@ -27,44 +27,44 @@  discard block
 block discarded – undo
27 27
  * with defined URL paths
28 28
  */
29 29
 function boincuser_menu() {
30
-  $items['account/posts'] = array(
30
+    $items['account/posts'] = array(
31 31
     'title' => 'Recent posts',
32 32
     'description' => '',
33 33
     'page callback' => 'boincuser_goto_recent_posts',
34 34
     'access callback' => 'user_is_logged_in',
35 35
     'type' => MENU_CALLBACK,
36
-  );
37
-  $items['account/profile'] = array(
36
+    );
37
+    $items['account/profile'] = array(
38 38
     'title' => '',
39 39
     'description' => '',
40 40
     'page callback' => 'boincuser_view_profile',
41 41
     'access callback' => 'user_is_logged_in',
42 42
     'type' => MENU_NORMAL_ITEM
43
-  );
44
-  $items['account/profile/view'] = array(
43
+    );
44
+    $items['account/profile/view'] = array(
45 45
     'title' => 'View',
46 46
     'description' => 'Show a user profile',
47 47
     'page callback' => 'boincuser_view_profile',
48 48
     'access callback' => 'user_is_logged_in',
49 49
     'type' => MENU_DEFAULT_LOCAL_TASK,
50 50
     'weight' => 0
51
-  );
52
-  $items['account/profile/edit'] = array(
51
+    );
52
+    $items['account/profile/edit'] = array(
53 53
     'title' => 'Edit',
54 54
     'description' => 'Edit a user profile',
55 55
     'page callback' => 'boincuser_edit_profile',
56 56
     'access arguments' => array('edit own profile content'),
57 57
     'type' => MENU_LOCAL_TASK,
58 58
     'weight' => 5
59
-  );
60
-  $items['account/team'] = array(
59
+    );
60
+    $items['account/team'] = array(
61 61
     'title' => 'User team',
62 62
     'description' => '',
63 63
     'page callback' => 'boincuser_goto_team',
64 64
     'access callback' => 'user_is_logged_in',
65 65
     'type' => MENU_CALLBACK,
66
-  );
67
-  $items['moderate/profile/%user/approve'] = array(
66
+    );
67
+    $items['moderate/profile/%user/approve'] = array(
68 68
     'title' => 'Profile approval',
69 69
     'description' => 'Approve profile content',
70 70
     'page callback' => 'boincuser_moderate_profile_approve',
@@ -72,8 +72,8 @@  discard block
 block discarded – undo
72 72
     'access arguments' => array('edit any profile content'),
73 73
     'type' => MENU_CALLBACK,
74 74
     'weight' => 5
75
-  );
76
-  $items['moderate/profile/%user/edit'] = array(
75
+    );
76
+    $items['moderate/profile/%user/edit'] = array(
77 77
     'title' => 'Profile editor',
78 78
     'description' => 'Edit a user profile',
79 79
     'page callback' => 'boincuser_edit_profile',
@@ -81,8 +81,8 @@  discard block
 block discarded – undo
81 81
     'access arguments' => array('edit any profile content'),
82 82
     'type' => MENU_CALLBACK,
83 83
     'weight' => 5
84
-  );
85
-  $items['moderate/profile/%/reject'] = array(
84
+    );
85
+    $items['moderate/profile/%/reject'] = array(
86 86
     'title' => bts('Reject profile', array(), NULL, 'boinc:moderate-user'),
87 87
     'description' => 'Reject profile content',
88 88
     'page callback' => 'drupal_get_form',
@@ -90,60 +90,60 @@  discard block
 block discarded – undo
90 90
     'access arguments' => array('edit any profile content'),
91 91
     'type' => MENU_CALLBACK,
92 92
     'weight' => 5
93
-  );
94
-  $items['moderate/user/%/ban'] = array(
93
+    );
94
+    $items['moderate/user/%/ban'] = array(
95 95
     'title' => bts('Ban user', array(), NULL, 'boinc:moderate-ban-user'),
96 96
     'description' => 'Ban a user from using community features',
97 97
     'page callback' => 'drupal_get_form',
98 98
     'page arguments' => array('boincuser_moderate_user_ban_form', 2),
99 99
     'access callback' => 'boincuser_moderate_community_access',
100 100
     'type' => MENU_CALLBACK,
101
-  );
102
-  $items['join'] = array(
101
+    );
102
+    $items['join'] = array(
103 103
     'title' => '',
104 104
     'description' => '',
105 105
     'page callback' => 'join_page',
106 106
     'access arguments' => array('access content'),
107 107
     'type' => MENU_NORMAL_ITEM
108
-  );
109
-  $items['join/new'] = array(
108
+    );
109
+    $items['join/new'] = array(
110 110
     'title' => bts("I'm new"),
111 111
     'page callback' => 'join_page',
112 112
     'page arguments' => array(1),
113 113
     'access arguments' => array('access content'),
114 114
     'type' => MENU_DEFAULT_LOCAL_TASK,
115 115
     'weight' => 0
116
-  );
117
-  $items['join/boinc'] = array(
116
+    );
117
+    $items['join/boinc'] = array(
118 118
     'title' => bts("I'm a BOINC user"),
119 119
     'page callback' => 'join_page',
120 120
     'page arguments' => array(1),
121 121
     'access arguments' => array('access content'),
122 122
     'type' => MENU_LOCAL_TASK,
123 123
     'weight' => 5
124
-  );
125
-  $items['user/login/auth'] = array(
124
+    );
125
+    $items['user/login/auth'] = array(
126 126
     'title' => bts('Authenticator login', array(), NULL, 'boinc:authenticator-login-page'),
127 127
     'description' => 'Log in using a user authenticator',
128 128
     'page callback' => 'drupal_get_form',
129 129
     'page arguments' => array('boincuser_authloginform'),
130 130
     'access arguments' => array('access content'),
131 131
     'type' => MENU_CALLBACK,
132
-  );
133
-  $items['user/termsofuse'] = array(
132
+    );
133
+    $items['user/termsofuse'] = array(
134 134
     'title' => bts('Terms of Use', array(), NULL, 'boinc:termsofuse-form'),
135 135
     'description' => 'A site\'s term of use.',
136 136
     'page callback' => 'drupal_get_form',
137 137
     'page arguments' => array('boincuser_termsofuse_form'),
138 138
     'access callback' => 'user_is_logged_in',
139 139
     'type' => MENU_CALLBACK,
140
-  );
141
-  $items['user_control'] = array(
140
+    );
141
+    $items['user_control'] = array(
142 142
     'page callback' => 'boincuser_control',
143 143
     'access arguments' => array('access user profiles'),
144 144
     'type' => MENU_CALLBACK
145
-  );
146
-  $items['admin/boinc'] = array(
145
+    );
146
+    $items['admin/boinc'] = array(
147 147
     'title' => 'BOINC configuration',
148 148
     'position' => 'right',
149 149
     'weight' => -8,
@@ -151,8 +151,8 @@  discard block
 block discarded – undo
151 151
     'access arguments' => array('administer site configuration'),
152 152
     'file' => 'system.admin.inc',
153 153
     'file path' => drupal_get_path('module', 'system'),
154
-  );
155
-  $items['admin/boinc/environment'] = array(
154
+    );
155
+    $items['admin/boinc/environment'] = array(
156 156
     'title' => 'Environment: General',
157 157
     'description' => 'Set paths to BOINC functions and any other necessary
158 158
       variables that establish a BOINC environment.',
@@ -161,8 +161,8 @@  discard block
 block discarded – undo
161 161
     'access arguments' => array('administer site configuration'),
162 162
     'type' => MENU_NORMAL_ITEM,
163 163
     'file' => 'boincuser.admin.inc'
164
-  );
165
-  $items['admin/boinc/scheduler'] = array(
164
+    );
165
+    $items['admin/boinc/scheduler'] = array(
166 166
     'title' => 'Environment: Scheduling server URLs',
167 167
     'description' => 'Set BOINC scheduler options.',
168 168
     'page callback' => 'drupal_get_form',
@@ -170,8 +170,8 @@  discard block
 block discarded – undo
170 170
     'access arguments' => array('administer site configuration'),
171 171
     'type' => MENU_NORMAL_ITEM,
172 172
     'file' => 'boincuser.admin.inc'
173
-  );
174
-  $items['admin/boinc/weboptions'] = array(
173
+    );
174
+    $items['admin/boinc/weboptions'] = array(
175 175
     'title' => 'Environment: Website Options',
176 176
     'description' => 'Set options configuring this Drupal-BOINC Web site.',
177 177
     'page callback' => 'drupal_get_form',
@@ -179,117 +179,117 @@  discard block
 block discarded – undo
179 179
     'access arguments' => array('administer site configuration'),
180 180
     'type' => MENU_NORMAL_ITEM,
181 181
     'file' => 'boincuser.admin.inc'
182
-  );
182
+    );
183 183
   
184
-  $items['create_account.php'] = array(
184
+    $items['create_account.php'] = array(
185 185
     'title' => 'Create Account RPC',
186 186
     'description' => 'RPC for creating user accounts.',
187 187
     'page callback' => 'boincuser_create_account',
188 188
     'access callback' => TRUE,
189 189
     'type' => MENU_CALLBACK
190
-  );
191
-  $items['account_finish.php'] = array(
190
+    );
191
+    $items['account_finish.php'] = array(
192 192
     'title' => 'Welcome to ' . variable_get('site_name', 'Drupal-BOINC'),
193 193
     'description' => 'RPC for after a user has created an account.',
194 194
     'page callback' => 'boincuser_account_finish',
195 195
     'access callback' => TRUE,
196 196
     'type' => MENU_CALLBACK,
197
-  );
198
-  $items['boincuser/autocomplete'] = array(
197
+    );
198
+    $items['boincuser/autocomplete'] = array(
199 199
     'page callback' => '_boincuser_user_name_autocomplete',
200 200
     'access callback' => TRUE,
201 201
     'type' => MENU_CALLBACK,
202
-  );
203
-  $items['user/%user/recoveremail/%'] = array(
202
+    );
203
+    $items['user/%user/recoveremail/%'] = array(
204 204
     'title' => t('Recover previous email'),
205 205
     'description' => t('Form to revert email to previous address.'),
206 206
     'page callback' => 'drupal_get_form',
207 207
     'page arguments' => array('boincuser_revertemail', 3),
208 208
     'access callback' => 'user_is_logged_in',
209 209
     'type' => MENU_CALLBACK,
210
-  );
211
-  $items['recover_email.php'] = array(
210
+    );
211
+    $items['recover_email.php'] = array(
212 212
     'title' => t('Recover previous email'),
213 213
     'description' => t('redirect'),
214 214
     'page callback' => '_boincuser_redirect_recover_email',
215 215
     'access callback' => TRUE,
216 216
     'type' => MENU_CALLBACK,
217
-  );
218
-  return $items;
217
+    );
218
+    return $items;
219 219
 }
220 220
 
221 221
 /**
222 222
  * Implementation of hook_init()
223 223
  */
224 224
 function boincuser_init() {
225
-  global $user;
226
-  // Skip this check for charts, which are loaded separately
227
-  // (may get duplicate or unexpected messages otherwise)
228
-  if (substr($_GET['q'], 0, 7) == 'charts/') {
225
+    global $user;
226
+    // Skip this check for charts, which are loaded separately
227
+    // (may get duplicate or unexpected messages otherwise)
228
+    if (substr($_GET['q'], 0, 7) == 'charts/') {
229 229
     return;
230
-  }
230
+    }
231 231
 
232
-  // If admin user, do some basic site functionality checks
233
-  if (user_access('administer site configuration')) {
232
+    // If admin user, do some basic site functionality checks
233
+    if (user_access('administer site configuration')) {
234 234
     // Ensure we have a configured BOINC environment
235 235
     boinc_get_path();
236 236
     boinc_get_scheduler_tags();
237
-  }
237
+    }
238 238
   
239
-  // Check credits for the verified contributor role
240
-  boincuser_check_credit_requirements();
239
+    // Check credits for the verified contributor role
240
+    boincuser_check_credit_requirements();
241 241
   
242
-  if (module_exists('boincteam')) {
242
+    if (module_exists('boincteam')) {
243 243
     // Display any persistent team messages
244 244
     boincteam_show_messages();
245
-  }
245
+    }
246 246
 
247
-  // Check if user has agreed to the terms of use. If not, send the
248
-  // user to the terms-of-use form. This is only makes sense if the
249
-  // termsofuse is enabled, by having text in the termsofuse variable.
250
-  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
251
-  $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
252
-  if ( (!empty($termsofuse)) and ($user->uid) ) {
247
+    // Check if user has agreed to the terms of use. If not, send the
248
+    // user to the terms-of-use form. This is only makes sense if the
249
+    // termsofuse is enabled, by having text in the termsofuse variable.
250
+    $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
251
+    $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
252
+    if ( (!empty($termsofuse)) and ($user->uid) ) {
253 253
     if ( !boincuser_check_termsofuse($user) and ($existinguser_tou) ) {
254 254
 
255
-      // Admins are exempt, otherwise the admin may not be able to
256
-      // access the site!
257
-      $administrator_role = array_search('administrator', user_roles(true));
258
-      if (!isset($user->roles[$administrator_role])) {
255
+        // Admins are exempt, otherwise the admin may not be able to
256
+        // access the site!
257
+        $administrator_role = array_search('administrator', user_roles(true));
258
+        if (!isset($user->roles[$administrator_role])) {
259 259
         $path = drupal_get_path_alias($_GET['q']);
260 260
 
261 261
         // Any paths that should NOT be redirected go here.
262 262
         // The site will not function correctly if these are not exempt!
263 263
         $paths0 = array(
264
-          'user/termsofuse',
265
-          'logout',
266
-          'account/info/edit',
267
-          'user/' . $user->uid . '/edit',
268
-          'user/' . $user->uid . '/recoveremail/*',
269
-          'recover_email.php',
264
+            'user/termsofuse',
265
+            'logout',
266
+            'account/info/edit',
267
+            'user/' . $user->uid . '/edit',
268
+            'user/' . $user->uid . '/recoveremail/*',
269
+            'recover_email.php',
270 270
         );
271 271
         if (module_exists('boincuser_delete')) {
272
-          $paths0[] = 'user/' . $user->uid . '/delete';
273
-          $paths0[] = 'user/' . $user->uid . '/deleteconfirm/*';
274
-          $paths0[] = 'user/' . $user->uid . '/odeleteconfirm/*';
272
+            $paths0[] = 'user/' . $user->uid . '/delete';
273
+            $paths0[] = 'user/' . $user->uid . '/deleteconfirm/*';
274
+            $paths0[] = 'user/' . $user->uid . '/odeleteconfirm/*';
275 275
         }
276 276
 
277 277
         // Paths added by the admin
278 278
         $paths1 = preg_split('/\r\n|\r|\n/', variable_get('boinc_weboptions_pathstoignore', "moderation\ncontent/moderation\nprivacy"));
279 279
         $paths2 = array();
280 280
         if (is_array($paths1)) {
281
-          $paths2 = array_map('strtolower', $paths1);
281
+            $paths2 = array_map('strtolower', $paths1);
282 282
         }
283 283
 
284 284
         // paths to ignore
285 285
         $paths_to_ignore = array_unique( array_merge($paths0, $paths2) );
286 286
 
287 287
         if (!_boincuser_ignore_paths($path, $paths_to_ignore)) {
288
-          drupal_goto('user/termsofuse');
288
+            drupal_goto('user/termsofuse');
289
+        }
289 290
         }
290
-      }
291 291
     }
292
-  }
292
+    }
293 293
 }
294 294
 
295 295
 /**
@@ -297,13 +297,13 @@  discard block
 block discarded – undo
297 297
  * Drupal user operations
298 298
  */
299 299
 function boincuser_user($op, &$edit, &$account, $category = NULL) {
300
-  require_boinc('boinc_db');
301
-  require_boinc('user');
302
-  require_boinc('xml');
300
+    require_boinc('boinc_db');
301
+    require_boinc('user');
302
+    require_boinc('xml');
303 303
 
304
-  require_boinc('password_compat/password');
305
-  // Handle BOINC integration for users with UID > 1 (skip anonymous and admin)
306
-  if (isset($account->uid) && ($account->uid > 1)) {
304
+    require_boinc('password_compat/password');
305
+    // Handle BOINC integration for users with UID > 1 (skip anonymous and admin)
306
+    if (isset($account->uid) && ($account->uid > 1)) {
307 307
     switch($op) {
308 308
     case 'load':
309 309
       // User loading; insert BOINC data into the user object
@@ -311,11 +311,11 @@  discard block
 block discarded – undo
311 311
         SELECT boinc_id, penalty_expiration
312 312
         FROM {boincuser} WHERE uid = %d",
313 313
         $account->uid
314
-      ));
315
-      $account->boincuser_id = $drupal_user->boinc_id;
316
-      $account->boincuser_penalty_expiration = $drupal_user->penalty_expiration;
317
-      db_set_active('boinc_rw');
318
-      $boinc_user = db_fetch_object(db_query("
314
+        ));
315
+        $account->boincuser_id = $drupal_user->boinc_id;
316
+        $account->boincuser_penalty_expiration = $drupal_user->penalty_expiration;
317
+        db_set_active('boinc_rw');
318
+        $boinc_user = db_fetch_object(db_query("
319 319
         SELECT
320 320
           name,
321 321
           authenticator,
@@ -331,29 +331,29 @@  discard block
 block discarded – undo
331 331
         FROM {user}
332 332
         WHERE id = %d",
333 333
         $account->boincuser_id
334
-      ));
335
-      $account->boincuser_name = $boinc_user->name;
336
-      $account->boincuser_account_key = $boinc_user->authenticator;
337
-      $account->boincuser_weak_auth = md5($boinc_user->authenticator . $boinc_user->passwd_hash);
338
-      $account->boincuser_total_credit = round($boinc_user->total_credit);
339
-      $account->boincuser_expavg_credit = round($boinc_user->expavg_credit);
340
-      $account->boincuser_expavg_time = round($boinc_user->expavg_time);
341
-      $account->boincuser_cpid = md5($boinc_user->cross_project_id . $account->mail);
342
-      $account->boincuser_default_pref_set = $boinc_user->venue;
343
-      $account->boincteam_id = $boinc_user->teamid;
344
-      $account->boincuser_previous_email_addr = $boinc_user->previous_email_addr;
345
-      $account->boincuser_email_addr_change_time = $boinc_user->email_addr_change_time;
346
-      db_set_active('default');
347
-      // Set Drupal team ID
348
-      $account->team = NULL;
349
-      if ($account->boincteam_id) {
334
+        ));
335
+        $account->boincuser_name = $boinc_user->name;
336
+        $account->boincuser_account_key = $boinc_user->authenticator;
337
+        $account->boincuser_weak_auth = md5($boinc_user->authenticator . $boinc_user->passwd_hash);
338
+        $account->boincuser_total_credit = round($boinc_user->total_credit);
339
+        $account->boincuser_expavg_credit = round($boinc_user->expavg_credit);
340
+        $account->boincuser_expavg_time = round($boinc_user->expavg_time);
341
+        $account->boincuser_cpid = md5($boinc_user->cross_project_id . $account->mail);
342
+        $account->boincuser_default_pref_set = $boinc_user->venue;
343
+        $account->boincteam_id = $boinc_user->teamid;
344
+        $account->boincuser_previous_email_addr = $boinc_user->previous_email_addr;
345
+        $account->boincuser_email_addr_change_time = $boinc_user->email_addr_change_time;
346
+        db_set_active('default');
347
+        // Set Drupal team ID
348
+        $account->team = NULL;
349
+        if ($account->boincteam_id) {
350 350
         $account->team = db_result(db_query("
351 351
           SELECT nid FROM {boincteam} WHERE team_id = %d",
352
-          $account->boincteam_id
352
+            $account->boincteam_id
353 353
         ));
354
-      }
355
-      // Set post count
356
-      $account->post_count = db_result(db_query("
354
+        }
355
+        // Set post count
356
+        $account->post_count = db_result(db_query("
357 357
         SELECT COUNT(*) +
358 358
         (
359 359
           SELECT COUNT(*) FROM {node}
@@ -366,8 +366,8 @@  discard block
 block discarded – undo
366 366
         WHERE comments.uid = '%d'
367 367
         AND node.status = 1",
368 368
         $account->uid, $account->uid
369
-      ));
370
-      break;
369
+        ));
370
+        break;
371 371
       
372 372
     case 'view':
373 373
       // SAMPLE: Add BOINC data to the user profile
@@ -393,74 +393,74 @@  discard block
 block discarded – undo
393 393
         case 'user_account':
394 394
           // Validate data before updating user account info
395 395
           boincuser_account_validate($edit, $account);
396
-          break;
396
+            break;
397 397
         
398 398
         default:
399 399
           
400 400
         }
401 401
         // We don't want to save validation source, so remove it
402 402
         $edit['validation_source'] = null;
403
-      }
404
-      break;
403
+        }
404
+        break;
405 405
       
406 406
     case 'insert':
407 407
       // New user being added to the system
408 408
       $imported = $_SESSION['importedUser'];
409
-      unset($_SESSION['importedUser']);
409
+        unset($_SESSION['importedUser']);
410 410
       
411
-      watchdog(
411
+        watchdog(
412 412
         'boincuser',
413 413
         'Creating user account for %email_addr',
414 414
         array('%email_addr' => $edit['mail']),
415 415
         WATCHDOG_NOTICE
416
-      );
416
+        );
417 417
       
418
-      // The create_acount RPC will call this block of code when
419
-      // user_save() is used. If user is registering using the Web
420
-      // registration form, create a BOINC user and relationships.
421
-      // Create a BOINC account unless importing from BOINC.
422
-      if (!$imported) {
418
+        // The create_acount RPC will call this block of code when
419
+        // user_save() is used. If user is registering using the Web
420
+        // registration form, create a BOINC user and relationships.
421
+        // Create a BOINC account unless importing from BOINC.
422
+        if (!$imported) {
423 423
 
424 424
         // set email address lower-case
425 425
         $lower_email_addr = strtolower($edit['mail']);
426 426
 
427 427
         if ($edit['boincuser_name']) {
428
-          $myname = $edit['boincuser_name'];
428
+            $myname = $edit['boincuser_name'];
429 429
         }
430 430
         else if ($edit['name']) {
431
-          $myname = $edit['name'];
431
+            $myname = $edit['name'];
432 432
         }
433 433
         else {
434
-          $myname = 'noname';
434
+            $myname = 'noname';
435 435
         }
436 436
 
437 437
         $user_params = array(
438
-          'email_addr' => $lower_email_addr,
439
-          'name' => $myname,
438
+            'email_addr' => $lower_email_addr,
439
+            'name' => $myname,
440 440
         );
441 441
 
442 442
         // If the 'pass' variable is already a hash, then don't hash it again.
443 443
         if ($edit['boinchash_flag']) {
444
-          $user_params['passwd_hash'] = $edit['pass'];
444
+            $user_params['passwd_hash'] = $edit['pass'];
445 445
         }
446 446
         else {
447
-          // The passwd_hash here is only the md5() hash. This is
448
-          // because BOINC make_user(), called later, will run
449
-          // password_hash() on this md5 hash.
450
-          $user_params['passwd_hash'] = md5($edit['pass'].$lower_email_addr);
447
+            // The passwd_hash here is only the md5() hash. This is
448
+            // because BOINC make_user(), called later, will run
449
+            // password_hash() on this md5 hash.
450
+            $user_params['passwd_hash'] = md5($edit['pass'].$lower_email_addr);
451 451
         }
452 452
 
453 453
         $boinc_user = boincuser_register_make_user($user_params);
454 454
         if (!$boinc_user) {
455
-          // Account exists with this email addr
456
-          form_set_error('email', bts('Error creating BOINC account.', array(), NULL, 'boinc:add-new-user'));
457
-          return;
455
+            // Account exists with this email addr
456
+            form_set_error('email', bts('Error creating BOINC account.', array(), NULL, 'boinc:add-new-user'));
457
+            return;
458 458
         }
459 459
 
460 460
         // Add user to community role by default (not banned)
461 461
         $unrestricted_role = array_search('community member', user_roles(true)); 
462 462
         $edit['roles'] = array(
463
-          $unrestricted_role => ''
463
+            $unrestricted_role => ''
464 464
         );
465 465
 
466 466
         // Disable show_hosts flag, set to TRUE by default
@@ -471,14 +471,14 @@  discard block
 block discarded – undo
471 471
         // Cross reference Drupal account with BOINC
472 472
         $reference = db_query("INSERT INTO {boincuser} SET uid='%d', boinc_id='%d'", $account->uid, $boinc_user->id);
473 473
         if (!$reference) {
474
-          drupal_set_message(t('Error connecting BOINC account.'), 'error');
475
-          return;
474
+            drupal_set_message(t('Error connecting BOINC account.'), 'error');
475
+            return;
476 476
         }
477 477
 
478 478
         // if terms of use exist, the user must agree.
479 479
         $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
480 480
         if (!empty($termsofuse)) {
481
-          $reference2 = boincuser_consentto_termsofuse($account);
481
+            $reference2 = boincuser_consentto_termsofuse($account);
482 482
         }
483 483
 
484 484
         // Don't save custom fields to the Drupal user object
@@ -486,10 +486,10 @@  discard block
 block discarded – undo
486 486
         $edit['boinchash_flag'] = null;
487 487
         // Set email address to lower case in Drupal users table
488 488
         if ($account) {
489
-          user_save($account, array('mail' => $lower_email_addr));
489
+            user_save($account, array('mail' => $lower_email_addr));
490 490
         }
491
-      }
492
-      break;
491
+        }
492
+        break;
493 493
       
494 494
     case 'update':
495 495
       if (isset($edit['update_source'])) {
@@ -500,8 +500,8 @@  discard block
 block discarded – undo
500 500
           // Ensure that BOINC data is altered
501 501
 
502 502
           $changing_email = ($edit['mail'] AND $edit['mail'] != $boinc_user->email_addr) ? true : false;
503
-          $changing_pass = ($edit['pass']) ? true : false;
504
-          if ($changing_email OR $changing_pass) {
503
+            $changing_pass = ($edit['pass']) ? true : false;
504
+            if ($changing_email OR $changing_pass) {
505 505
             // set email address to lower-case
506 506
             $lower_email_addr = strtolower($edit['mail']);
507 507
 
@@ -510,70 +510,70 @@  discard block
 block discarded – undo
510 510
             $passwd_hash = password_hash( md5($passwd.$lower_email_addr), PASSWORD_DEFAULT );
511 511
             // Algorithm for changing email and/or password
512 512
             if ($changing_email) {
513
-              // locally store current email to set as previous email
514
-              $prev_email = $account->mail;
515
-              $mytime = (user_access('administer users')) ? $boinc_user->email_addr_change_time : time();
516
-              $querypart = "email_addr='{$lower_email_addr}', passwd_hash='{$passwd_hash}', previous_email_addr = '{$prev_email}', email_addr_change_time = $mytime";
513
+                // locally store current email to set as previous email
514
+                $prev_email = $account->mail;
515
+                $mytime = (user_access('administer users')) ? $boinc_user->email_addr_change_time : time();
516
+                $querypart = "email_addr='{$lower_email_addr}', passwd_hash='{$passwd_hash}', previous_email_addr = '{$prev_email}', email_addr_change_time = $mytime";
517 517
             }
518 518
             else {
519
-              $querypart = "email_addr='{$lower_email_addr}', passwd_hash='{$passwd_hash}'";
519
+                $querypart = "email_addr='{$lower_email_addr}', passwd_hash='{$passwd_hash}'";
520 520
             }
521 521
 
522 522
             // Update user account information
523 523
             $result = $boinc_user->update($querypart);
524 524
 
525 525
             if ($changing_email) {
526
-              // reload account
527
-              $account = user_load($account->uid);
528
-              _boincuser_send_emailchange($account, $lower_email_addr, $prev_email, user_access('administer users'));
526
+                // reload account
527
+                $account = user_load($account->uid);
528
+                _boincuser_send_emailchange($account, $lower_email_addr, $prev_email, user_access('administer users'));
529 529
             }
530 530
 
531 531
             // Change email to edit to lower-case version, this sets
532 532
             // email in Drupal database to the lower-case email
533 533
             // address.
534 534
             $edit['mail'] = strtolower($lower_email_addr);
535
-          }
535
+            }
536 536
 
537
-          // Change boinc username
538
-          if ($edit['boincuser_name'] and ($edit['boincuser_name'] != $boinc_user->name)) {
537
+            // Change boinc username
538
+            if ($edit['boincuser_name'] and ($edit['boincuser_name'] != $boinc_user->name)) {
539 539
             $boincuser_name = $edit['boincuser_name'];
540 540
             $result = $boinc_user->update(
541 541
                 "name='{$boincuser_name}'"
542 542
             );
543
-          }
543
+            }
544 544
 
545
-          break;
545
+            break;
546 546
         case 'user_profile':
547 547
           if ($edit['boincuser_name'] != $boinc_user->name) {
548 548
             $boincuser_name = $edit['boincuser_name'];
549 549
             $result = $boinc_user->update(
550 550
                 "name='{$boincuser_name}'"
551 551
             );
552
-          }
553
-          break;
552
+            }
553
+            break;
554 554
         default:
555 555
         }
556 556
         // We don't want to save update source or duplicate custom fields, so
557 557
         // remove them before continuing to core Drupal routines
558 558
         $edit['update_source'] = null;
559 559
         $edit['boincuser_name'] = null;
560
-      }
561
-      break;
560
+        }
561
+        break;
562 562
 
563 563
     case 'login':
564 564
       // Function is forward compatible to Drupal 7
565 565
       boincuser_user_login($edit, $account);
566
-      break;
566
+        break;
567 567
 
568 568
     case 'delete':
569 569
       // Function is forward compatible to Drupal 7
570 570
       boincuser_user_delete($account);
571
-      break;
571
+        break;
572 572
 
573 573
     default:
574 574
       
575 575
     }
576
-  }
576
+    }
577 577
 }
578 578
 
579 579
 /**
@@ -582,39 +582,39 @@  discard block
 block discarded – undo
582 582
  *(forward compatible to Drupal 7).
583 583
  */
584 584
 function boincuser_user_login(&$edit, $account) {
585
-  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
586
-  $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
587
-
588
-  // Use the same code as boincuser_form_alter(), for case
589
-  // 'user_profile_form', if the refering page is the user password
590
-  // reset form, then do not check for terms of use.
591
-  $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/$account->uid") === FALSE) ? 0 : 1;
592
-  if ($reset_pass) {
585
+    $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
586
+    $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
587
+
588
+    // Use the same code as boincuser_form_alter(), for case
589
+    // 'user_profile_form', if the refering page is the user password
590
+    // reset form, then do not check for terms of use.
591
+    $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/$account->uid") === FALSE) ? 0 : 1;
592
+    if ($reset_pass) {
593 593
     return;
594
-  }
594
+    }
595 595
 
596
-  // Check if user has agreed to terms of use.
597
-  if ( (!empty($termsofuse)) and ($account->uid) and 
596
+    // Check if user has agreed to terms of use.
597
+    if ( (!empty($termsofuse)) and ($account->uid) and 
598 598
        (!boincuser_check_termsofuse($account)) and ($existinguser_tou) ) {
599 599
 
600 600
     // Admins are exempted.
601 601
     $administrator_role = array_search('administrator', user_roles(true));
602 602
     if (!isset($account->roles[$administrator_role])) {
603 603
 
604
-      // Find and save the current destination and use as an parameter
605
-      // to send the user back to here he/she came from.
606
-      $np = ltrim('user/termsofuse', '/');
607
-      $path_for_destination = rawurlencode($np);
604
+        // Find and save the current destination and use as an parameter
605
+        // to send the user back to here he/she came from.
606
+        $np = ltrim('user/termsofuse', '/');
607
+        $path_for_destination = rawurlencode($np);
608 608
 
609
-      $query_for_destination = '';
610
-      $prevdest = $_REQUEST['destination'];
611
-      if ($prevdest) {
609
+        $query_for_destination = '';
610
+        $prevdest = $_REQUEST['destination'];
611
+        if ($prevdest) {
612 612
         $query_for_destination = '?destination=' . $prevdest;
613
-      }
614
-      $_REQUEST['destination'] = $path_for_destination . $query_for_destination;
613
+        }
614
+        $_REQUEST['destination'] = $path_for_destination . $query_for_destination;
615 615
 
616 616
     }
617
-  }
617
+    }
618 618
 }
619 619
 
620 620
 /**
@@ -623,16 +623,16 @@  discard block
 block discarded – undo
623 623
  */
624 624
 function boincuser_user_delete($account) {
625 625
 
626
-  $boincid = $account->boincuser_id;
627
-  // bug in comment module, remove user name from comments. Find all
628
-  // comments with uid=0 and clear the field 'name'.
629
-  $qrc1 = db_query("UPDATE {comments} SET comments.name='' WHERE comments.uid=0");
626
+    $boincid = $account->boincuser_id;
627
+    // bug in comment module, remove user name from comments. Find all
628
+    // comments with uid=0 and clear the field 'name'.
629
+    $qrc1 = db_query("UPDATE {comments} SET comments.name='' WHERE comments.uid=0");
630 630
 
631
-  // Delete entry in drupal boincuser table.
632
-  $qrc2 = db_query("DELETE FROM {boincuser} WHERE uid=%d", $account->uid);
633
-  if (!$qrc2) {
631
+    // Delete entry in drupal boincuser table.
632
+    $qrc2 = db_query("DELETE FROM {boincuser} WHERE uid=%d", $account->uid);
633
+    if (!$qrc2) {
634 634
     watchdog('user', 'Error deleting user account, boincuser table UID: %uid.', array('%uid' => $account->uid), WATCHDOG_ERROR);
635
-  }
635
+    }
636 636
 }
637 637
 
638 638
 
@@ -641,13 +641,13 @@  discard block
 block discarded – undo
641 641
  * Obsolete in Drupal 7...
642 642
  */
643 643
 function boincuser_nodeapi(&$node, $op, $a3 = null, $a4 = null) {
644
-  // In Drupal 7, these operation cases will all exist as their own hooks,
645
-  // so let's approximate that here so that this function can simply be removed
646
-  // upon migration to 7
647
-  switch($op) {
648
-  case 'update':
644
+    // In Drupal 7, these operation cases will all exist as their own hooks,
645
+    // so let's approximate that here so that this function can simply be removed
646
+    // upon migration to 7
647
+    switch($op) {
648
+    case 'update':
649 649
     boincuser_node_update($node);
650
-  }
650
+    }
651 651
 }
652 652
 
653 653
 /**
@@ -655,8 +655,8 @@  discard block
 block discarded – undo
655 655
  * is updated (forward compatible to Drupal 7)
656 656
  */
657 657
 function boincuser_node_update($node) {
658
-  switch($node->type) {
659
-  case 'profile':
658
+    switch($node->type) {
659
+    case 'profile':
660 660
     // Update the BOINC database directly
661 661
     $account = user_load($node->uid);
662 662
     // Save user account data
@@ -668,11 +668,11 @@  discard block
 block discarded – undo
668 668
       UPDATE user
669 669
       SET country = '%s', postal_code = '%s', url = '%s', has_profile = 1
670 670
       WHERE id = %d",
671
-      $country, $postal_code, $url, $account->boincuser_id
671
+        $country, $postal_code, $url, $account->boincuser_id
672 672
     );
673 673
     db_set_active('default');
674 674
     if (!$account_updated) {
675
-      drupal_set_message(t('Error saving BOINC account info.'), 'error');
675
+        drupal_set_message(t('Error saving BOINC account info.'), 'error');
676 676
     }
677 677
     // Save profile data
678 678
     $response1 = $node->field_background[0]['value'];
@@ -683,16 +683,16 @@  discard block
 block discarded – undo
683 683
       SET userid = %d, response1 = '%s', response2 = '%s'
684 684
       ON DUPLICATE KEY UPDATE
685 685
         response1 = '%s', response2 = '%s'",
686
-      $account->boincuser_id, $response1, $response2,
687
-      $response1, $response2
686
+        $account->boincuser_id, $response1, $response2,
687
+        $response1, $response2
688 688
     );
689 689
     db_set_active('default');
690 690
     if (!$profile_updated) {
691
-      drupal_set_message(t('Error saving BOINC profile.'), 'error');
691
+        drupal_set_message(t('Error saving BOINC profile.'), 'error');
692 692
     }
693 693
     break;
694 694
     
695
-  default:
695
+    default:
696 696
     
697 697
   }
698 698
 }
@@ -701,21 +701,21 @@  discard block
 block discarded – undo
701 701
 * Implementation of hook_views_api()
702 702
 */
703 703
 function boincuser_views_api() {
704
-  return array(
704
+    return array(
705 705
     'api' => 2.0,
706 706
     'path' => drupal_get_path('module', 'boincuser')
707
-  );
707
+    );
708 708
 }
709 709
 
710 710
 /**
711 711
 * Implementation of hook_form_alter()
712 712
 */
713 713
 function boincuser_form_alter(&$form, $form_state, $form_id) {
714
-  require_boinc('token');
714
+    require_boinc('token');
715 715
 
716
-  global $user;
717
-  switch ($form_id) {
718
-  case 'flag_confirm':
716
+    global $user;
717
+    switch ($form_id) {
718
+    case 'flag_confirm':
719 719
     // The URL seems to be the only way to put any kind of context to this
720 720
     // request!
721 721
     $action = arg(2);
@@ -724,25 +724,25 @@  discard block
 block discarded – undo
724 724
     
725 725
     // Wrap action buttons for styling consistency
726 726
     $form['form control tabs prefix'] = array(
727
-      '#value' => '<ul class="form-control tab-list">',
728
-      '#weight' => 1001,
727
+        '#value' => '<ul class="form-control tab-list">',
728
+        '#weight' => 1001,
729 729
     );
730 730
     
731 731
     switch ($flag_type) {
732 732
     case 'friend':
733 733
       $friend_id = $form['content_id']['#value'];
734
-      $flag = flag_get_flag('friend');
735
-      $friend_status = flag_friend_determine_friend_status($flag, $friend_id, $user->uid);
734
+        $flag = flag_get_flag('friend');
735
+        $friend_status = flag_friend_determine_friend_status($flag, $friend_id, $user->uid);
736 736
       
737
-      // General friend form overrides
738
-      $form['flag_friend_submit']['#prefix'] = '<li class="first tab">';
739
-      $form['flag_friend_submit']['#value'] = bts('Send request', array(), NULL, 'boinc:friends-page');
740
-      $form['flag_friend_submit']['#type'] = 'submit';
741
-      $form['flag_friend_submit']['#suffix'] = '</li>';
742
-      $form['flag_friend_submit']['#weight'] = 1002;
737
+        // General friend form overrides
738
+        $form['flag_friend_submit']['#prefix'] = '<li class="first tab">';
739
+        $form['flag_friend_submit']['#value'] = bts('Send request', array(), NULL, 'boinc:friends-page');
740
+        $form['flag_friend_submit']['#type'] = 'submit';
741
+        $form['flag_friend_submit']['#suffix'] = '</li>';
742
+        $form['flag_friend_submit']['#weight'] = 1002;
743 743
       
744
-      switch ($friend_status) {
745
-      case FLAG_FRIEND_BOTH:
744
+        switch ($friend_status) {
745
+        case FLAG_FRIEND_BOTH:
746 746
       case FLAG_FRIEND_FLAGGED:
747 747
         unset($form['actions']);
748 748
         $form['flag_friend_submit']['#value'] = bts('Remove friend', array(), NULL, 'boinc:friends-remove');
@@ -751,53 +751,53 @@  discard block
 block discarded – undo
751 751
         $form['#submit'][] = 'boincuser_fix_unfriend_form_submit';
752 752
         $form['#submit'][] = $final_handler;
753 753
         break;
754
-      case FLAG_FRIEND_PENDING:
754
+        case FLAG_FRIEND_PENDING:
755 755
         unset($form['actions']);
756 756
         $form['flag_friend_submit']['#value'] = bts('Remove request', array(), NULL, 'boinc:friends-page');
757 757
         break;
758
-      case FLAG_FRIEND_APPROVAL:
758
+        case FLAG_FRIEND_APPROVAL:
759 759
         if ($action == 'flag') {
760
-          $form['flag_friend_submit']['#value'] = bts('Approve request', array(), NULL, 'boinc:friends-page');
760
+            $form['flag_friend_submit']['#value'] = bts('Approve request', array(), NULL, 'boinc:friends-page');
761 761
         }
762 762
         elseif ($action == 'unflag') {
763
-          unset($form['actions']);
764
-          $form['flag_friend_submit']['#value'] = bts('Deny request', array(), NULL, 'boinc:friends-page');
763
+            unset($form['actions']);
764
+            $form['flag_friend_submit']['#value'] = bts('Deny request', array(), NULL, 'boinc:friends-page');
765 765
         }
766 766
         break;
767
-      case FLAG_FRIEND_UNFLAGGED:
767
+        case FLAG_FRIEND_UNFLAGGED:
768 768
       default:
769 769
         $user_links[] = array(
770
-          'title' => bts('Add as friend', array(), NULL, 'boinc:friends-add'),
771
-          'href' => "flag/confirm/flag/friend/{$account->uid}"
770
+            'title' => bts('Add as friend', array(), NULL, 'boinc:friends-add'),
771
+            'href' => "flag/confirm/flag/friend/{$account->uid}"
772 772
         );
773
-      }
774
-      break;
773
+        }
774
+        break;
775 775
       
776 776
     default:
777 777
     }
778 778
     
779 779
     $form['cancel'] = array(
780
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $cancel_dest) . '</li>',
781
-      '#weight' => 1004,
780
+        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $cancel_dest) . '</li>',
781
+        '#weight' => 1004,
782 782
     );
783 783
     $form['form control tabs suffix'] = array(
784
-      '#value' => '</ul>',
785
-      '#weight' => 1010,
784
+        '#value' => '</ul>',
785
+        '#weight' => 1010,
786 786
     );
787 787
     
788 788
     break;
789 789
     
790
-  // General node edit form
791
-  case 'news_node_form':
790
+    // General node edit form
791
+    case 'news_node_form':
792 792
     $form['separator_bottom'] = array(
793
-      '#value' => '<div class="separator buttons"></div>',
794
-      '#weight' => 999,
793
+        '#value' => '<div class="separator buttons"></div>',
794
+        '#weight' => 999,
795 795
     );
796 796
     
797 797
     // Wrap action buttons for styling consistency
798 798
     $form['buttons']['form control tabs prefix'] = array(
799
-      '#value' => '<ul class="form-control tab-list">',
800
-      '#weight' => 1001,
799
+        '#value' => '<ul class="form-control tab-list">',
800
+        '#weight' => 1001,
801 801
     );
802 802
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
803 803
     $form['buttons']['submit']['#value'] = bts('Save changes', array(), NULL, 'boinc:form-save');
@@ -810,15 +810,15 @@  discard block
 block discarded – undo
810 810
     $form['buttons']['preview_changes']['#suffix'] = '</li>';
811 811
     $form['buttons']['preview_changes']['#weight'] = 1004;
812 812
     $form['buttons']['cancel'] = array(
813
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
814
-      '#weight' => 1005,
813
+        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
814
+        '#weight' => 1005,
815 815
     );
816 816
     $form['buttons']['delete']['#prefix'] = '<li class="tab">';
817 817
     $form['buttons']['delete']['#suffix'] = '</li>';
818 818
     $form['buttons']['delete']['#weight'] = 1006;
819 819
     $form['buttons']['form control tabs suffix'] = array(
820
-      '#value' => '</ul>',
821
-      '#weight' => 1010,
820
+        '#value' => '</ul>',
821
+        '#weight' => 1010,
822 822
     );
823 823
     
824 824
     // Preview is ugly, unset until it works
@@ -826,16 +826,16 @@  discard block
 block discarded – undo
826 826
 
827 827
     break;
828 828
   
829
-  case 'node_delete_confirm':
829
+    case 'node_delete_confirm':
830 830
     $form['separator_bottom'] = array(
831
-      '#value' => '<div class="separator buttons"></div>',
832
-      '#weight' => 999,
831
+        '#value' => '<div class="separator buttons"></div>',
832
+        '#weight' => 999,
833 833
     );
834 834
     
835 835
     // Wrap action buttons for styling consistency
836 836
     $form['actions']['form control tabs prefix'] = array(
837
-      '#value' => '<ul class="form-control tab-list">',
838
-      '#weight' => 1001,
837
+        '#value' => '<ul class="form-control tab-list">',
838
+        '#weight' => 1001,
839 839
     );
840 840
     $form['actions']['submit']['#prefix'] = '<li class="first tab">';
841 841
     $form['actions']['submit']['#value'] = bts('Delete', array(), NULL, 'boinc:form-delete');
@@ -843,23 +843,23 @@  discard block
 block discarded – undo
843 843
     $form['actions']['submit']['#weight'] = 1002;
844 844
     $form['actions']['cancel'] = array(
845 845
         '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
846
-      '#weight' => 1005,
846
+        '#weight' => 1005,
847 847
     );
848 848
     $form['actions']['form control tabs suffix'] = array(
849
-      '#value' => '</ul>',
850
-      '#weight' => 1010,
849
+        '#value' => '</ul>',
850
+        '#weight' => 1010,
851 851
     );
852 852
     $form['#redirect'] = 'account/profile';
853 853
     break;
854 854
     
855
-  case 'privatemsg_new':
855
+    case 'privatemsg_new':
856 856
     
857 857
     $form['privatemsg']['body']['#title'] = '';
858 858
     
859 859
     // Wrap action buttons for styling consistency
860 860
     $form['privatemsg']['form control tabs prefix'] = array(
861
-      '#value' => '<ul class="form-control tab-list">',
862
-      '#weight' => 1001,
861
+        '#value' => '<ul class="form-control tab-list">',
862
+        '#weight' => 1001,
863 863
     );
864 864
     $form['privatemsg']['submit']['#prefix'] = '<li class="first tab">';
865 865
     $form['privatemsg']['submit']['#value'] = bts('Send message', array(), NULL, 'boinc:private-message');
@@ -869,26 +869,26 @@  discard block
 block discarded – undo
869 869
     $form['privatemsg']['preview']['#suffix'] = '</li>';
870 870
     $form['privatemsg']['preview']['#weight'] = 1003;
871 871
     $form['privatemsg']['cancel'] = array(
872
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
873
-      '#weight' => 1004,
872
+        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
873
+        '#weight' => 1004,
874 874
     );
875 875
     $form['privatemsg']['form control tabs suffix'] = array(
876
-      '#value' => '</ul>',
877
-      '#weight' => 1010,
876
+        '#value' => '</ul>',
877
+        '#weight' => 1010,
878 878
     );
879 879
     
880 880
     unset($form['privatemsg']['recipient_display']);
881 881
     
882 882
     break;
883 883
     
884
-  // Login form
885
-  case 'user_login':
884
+    // Login form
885
+    case 'user_login':
886 886
   case 'user_login_block':
887 887
       drupal_set_title(bts('Login', array(), NULL, 'boinc:menu-link'));
888 888
     // Replace name with email in login form
889 889
     unset($form['name']);
890 890
     array_unshift($form, array(
891
-      'email' => array(
891
+        'email' => array(
892 892
         '#type' => 'textfield',
893 893
         '#title' => bts('Email address', array(), NULL, 'boinc:email-address-to-login'),
894 894
         '#size' => ($form_id == 'user_login_block') ? 15 : 60,
@@ -896,18 +896,18 @@  discard block
 block discarded – undo
896 896
         '#required' => TRUE,
897 897
         '#attributes' => array('tabindex' => '1'),
898 898
         '#description' => bts('Enter your @s email address.', array('@s' => variable_get('site_name', 'Drupal-BOINC')), NULL, 'boinc:standard-login-page')
899
-      ),
900
-      'validation_source' => array(
899
+        ),
900
+        'validation_source' => array(
901 901
         '#type' => 'hidden',
902 902
         '#value' => 'user_login'
903
-      )
903
+        )
904 904
     ));
905 905
     $form['#redirect'] = 'home';
906 906
     
907 907
     // Wrap action buttons for styling consistency
908 908
     $form['buttons']['form control tabs prefix'] = array(
909
-      '#value' => '<ul class="form-control tab-list">',
910
-      '#weight' => 1001,
909
+        '#value' => '<ul class="form-control tab-list">',
910
+        '#weight' => 1001,
911 911
     );
912 912
     $form['buttons']['submit'] = $form['submit'];
913 913
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
@@ -915,8 +915,8 @@  discard block
 block discarded – undo
915 915
     $form['buttons']['submit']['#suffix'] = '</li>';
916 916
     $form['buttons']['submit']['#weight'] = 1002;
917 917
     $form['buttons']['form control tabs suffix'] = array(
918
-      '#value' => '</ul>',
919
-      '#weight' => 1010,
918
+        '#value' => '</ul>',
919
+        '#weight' => 1010,
920 920
     );
921 921
     unset($form['submit']);
922 922
     
@@ -925,23 +925,23 @@  discard block
 block discarded – undo
925 925
     isset($form['buttons']['submit']['#attributes']) ? array_push($form['buttons']['submit']['#attributes'], array('tabindex' => '3')) : $form['buttons']['submit']['#attributes'] = array('tabindex' => '3');
926 926
     // If the user login form is being submitted, use BOINC validation handler.
927 927
     if (isset($form_state['post']['email']) and isset($form_state['post']['pass'])) {
928
-      // Find the local validation function's entry so we can replace it.
929
-      $array_key = array_search('user_login_authenticate_validate', $form['#validate']);
930
-      if ($array_key === FALSE) {
928
+        // Find the local validation function's entry so we can replace it.
929
+        $array_key = array_search('user_login_authenticate_validate', $form['#validate']);
930
+        if ($array_key === FALSE) {
931 931
         // Could not find it. Some other module must have run form_alter().
932 932
         // We will simply add our validation just before the final validator.
933 933
         $final_validator = array_pop($form['#validate']);
934 934
         $form['#validate'][] = 'boincuser_login_validate';
935 935
         $form['#validate'][] = $final_validator;
936
-      } else {
936
+        } else {
937 937
         // Replace the local validation function with BOINC validation
938 938
         $form['#validate'][$array_key] = 'boincuser_login_validate';
939
-      }
939
+        }
940 940
     }
941 941
     break;
942 942
     
943
-  // User credentials form
944
-  case 'user_profile_form':
943
+    // User credentials form
944
+    case 'user_profile_form':
945 945
 
946 946
     // Use the displaly name as the title, not the username
947 947
     $account = user_load($form['#uid']);
@@ -949,28 +949,28 @@  discard block
 block discarded – undo
949 949
     
950 950
     // Message for admins
951 951
     if (user_access('administer users')) {
952
-      drupal_set_message(
952
+        drupal_set_message(
953 953
         bts('WARNING: You are editing the information for user. Please note: you may change a user\'s password by itself. But to change the user\'s email address you must change both the email address and the password simultaneously.')
954
-      , 'warning');
954
+        , 'warning');
955 955
     }
956 956
 
957 957
     // Set special message if user has not agreed to TOU
958 958
     $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
959 959
     $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
960 960
     if ( (!boincuser_check_termsofuse($account)) and ($existinguser_tou) and (!empty($termsofuse)) and (!user_access('administer users')) ) {
961
-      drupal_set_message(
961
+        drupal_set_message(
962 962
         bts('INFO: You have not agreed to the terms of use for @project. You may use this form to change your email address and/or password. Please note: you may not delete your account within seven (7) days of changing your email address.',
963 963
         array(
964
-          '@project' => variable_get('site_name','Drupal-BOINC'),
964
+            '@project' => variable_get('site_name','Drupal-BOINC'),
965 965
         ), NULL, 'boinc:account-credentials-change')
966
-      , 'info');
966
+        , 'info');
967 967
     }
968 968
 
969 969
     // A bit hackish... but don't require the user to enter his password if
970 970
     // coming from the password reset function
971 971
     $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/{$form['#uid']}") === FALSE) ? 0 : 1;
972 972
     if ($reset_pass) {
973
-      $_SESSION['reset_pass'] = 1;
973
+        $_SESSION['reset_pass'] = 1;
974 974
     }
975 975
 
976 976
     // Adjust form elements already present
@@ -982,8 +982,8 @@  discard block
 block discarded – undo
982 982
     $form['account']['pass']['#size'] = 17;
983 983
 
984 984
     if (user_access('administer users')) {
985
-      // Add BOINC username (aka displayname)
986
-      $form['account']['boincuser_name'] = array(
985
+        // Add BOINC username (aka displayname)
986
+        $form['account']['boincuser_name'] = array(
987 987
         '#type' => 'textfield',
988 988
         '#title' => bts('BOINC Username', array(), NULL, 'boinc:user-or-team-name'),
989 989
         '#default_value' => $account->boincuser_name,
@@ -991,68 +991,68 @@  discard block
 block discarded – undo
991 991
         '#required' => TRUE,
992 992
         '#description' => bts('This is the BOINC (external) username. This is the same setting as found in Account -> Preferences -> Community.', array(), NULL, 'boinc:username-change'),
993 993
         '#size' => 40,
994
-      );
994
+        );
995 995
     }
996 996
 
997 997
     // If email address was changed less than 7 days (7 * 86400 s)
998 998
     // ago, it cannot be changed again.
999 999
     $duration = TOKEN_DURATION_ONE_WEEK;
1000 1000
     if (($account->boincuser_email_addr_change_time + $duration) > time() and (!user_access('administer users'))) {
1001
-      $form['account']['mail']['#required'] = FALSE;
1002
-      $form['account']['mailhelp'] = array(
1001
+        $form['account']['mail']['#required'] = FALSE;
1002
+        $form['account']['mailhelp'] = array(
1003 1003
         '#value' => bts("You email address was changed within the past seven (7) days. Please look for an email to !prev_email if you need to revert this change. You may change your email address on !time.",
1004
-          array(
1004
+            array(
1005 1005
             '!prev_email' => $account->boincuser_previous_email_addr,
1006 1006
             '!time' => date('F j, Y \a\t G:i T', $account->boincuser_email_addr_change_time + $duration),
1007
-          ), NULL, 'boinc:account-credentials-change'),
1008
-      );
1007
+            ), NULL, 'boinc:account-credentials-change'),
1008
+        );
1009 1009
     }
1010 1010
 
1011 1011
     if (!$reset_pass AND ($user->uid == $account->uid OR !user_access('administer users'))) {
1012
-      // Add a password authenticator, required to change email or pw
1013
-      $form['account']['current_pass'] = array(
1012
+        // Add a password authenticator, required to change email or pw
1013
+        $form['account']['current_pass'] = array(
1014 1014
         '#type' => 'password',
1015 1015
         '#title' => bts('Enter your password to save changes', array(), NULL, 'boinc:account-credentials-change'),
1016 1016
         '#description' => bts('Enter your current password if changing your email
1017 1017
           address or password.', array(), NULL, 'boinc:account-credentials-change'),
1018 1018
         '#size' => 17,
1019 1019
         '#attributes' => array(
1020
-          'autocomplete' => 'off',
1020
+            'autocomplete' => 'off',
1021 1021
         ),
1022
-      );
1022
+        );
1023 1023
     }
1024 1024
     
1025 1025
     // Add account keys, CPID, etc
1026 1026
     $form['account']['boincuser_id'] = array(
1027
-      '#value' => '
1027
+        '#value' => '
1028 1028
         <div class="form-item">
1029 1029
           <label>' . bts('BOINC user ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1030 1030
           <span>' . $account->boincuser_id . '</span>
1031 1031
         </div>',
1032 1032
     );
1033 1033
     $form['account']['user_id'] = array(
1034
-      '#value' => '
1034
+        '#value' => '
1035 1035
         <div class="form-item">
1036 1036
           <label>' . bts('Drupal user ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1037 1037
           <span>' . $account->uid . '</span>
1038 1038
         </div>',
1039 1039
     );
1040 1040
     $form['account']['account_key'] = array(
1041
-      '#value' => '
1041
+        '#value' => '
1042 1042
         <div class="form-item">
1043 1043
           <label>' . bts('Account key', array(), NULL, 'boinc:account-credentials-change') . '</label>
1044 1044
           <span>' . $account->boincuser_account_key . '</span>
1045 1045
         </div>',
1046 1046
     );
1047 1047
     $form['account']['weak_account_key'] = array(
1048
-      '#value' => '
1048
+        '#value' => '
1049 1049
         <div class="form-item">
1050 1050
           <label>' . bts('Weak account key', array(), NULL, 'boinc:account-credentials-change') . '</label>
1051 1051
           <span>' . "{$account->boincuser_id}_{$account->boincuser_weak_auth}" . '</span>
1052 1052
         </div>',
1053 1053
     );
1054 1054
     $form['account']['cpid'] = array(
1055
-      '#value' => '
1055
+        '#value' => '
1056 1056
         <div class="form-item">
1057 1057
           <label>' . bts('Cross-project ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1058 1058
           <span>' . $account->boincuser_cpid . '</span>
@@ -1060,30 +1060,30 @@  discard block
 block discarded – undo
1060 1060
     );
1061 1061
     
1062 1062
     $form['account']['separator_bottom'] = array(
1063
-      '#value' => '<div class="separator buttons"></div>'
1063
+        '#value' => '<div class="separator buttons"></div>'
1064 1064
     );
1065 1065
     
1066 1066
     // Wrap action buttons for styling consistency
1067 1067
     $form['form control tabs prefix'] = array(
1068
-      '#value' => '<ul class="form-control tab-list">',
1069
-      '#weight' => 1001,
1068
+        '#value' => '<ul class="form-control tab-list">',
1069
+        '#weight' => 1001,
1070 1070
     );
1071 1071
     $form['submit']['#prefix'] = '<li class="first tab">';
1072 1072
     $form['submit']['#value'] = bts('Save changes', array(), NULL, 'boinc:form-save');
1073 1073
     $form['submit']['#suffix'] = '</li>';
1074 1074
     $form['submit']['#weight'] = 1002;
1075 1075
     $form['cancel'] = array(
1076
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1077
-      '#weight' => 1003,
1076
+        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1077
+        '#weight' => 1003,
1078 1078
     );
1079 1079
     if (isset($form['delete']) AND is_array($form['delete'])) {
1080
-      $form['delete']['#prefix'] = '<li class="first alt tab">';
1081
-      $form['delete']['#suffix'] = '</li>';
1082
-      $form['delete']['#weight'] = 1004;
1080
+        $form['delete']['#prefix'] = '<li class="first alt tab">';
1081
+        $form['delete']['#suffix'] = '</li>';
1082
+        $form['delete']['#weight'] = 1004;
1083 1083
     }
1084 1084
     $form['form control tabs suffix'] = array(
1085
-      '#value' => '</ul>',
1086
-      '#weight' => 1010,
1085
+        '#value' => '</ul>',
1086
+        '#weight' => 1010,
1087 1087
     );
1088 1088
     
1089 1089
     // Rearrange form elements
@@ -1103,7 +1103,7 @@  discard block
 block discarded – undo
1103 1103
     // Remove redundant / unnecessary form elements
1104 1104
     unset($form['theme_select']);
1105 1105
     if (!module_exists('boincuser_delete')) {
1106
-      unset($form['delete']);
1106
+        unset($form['delete']);
1107 1107
     }
1108 1108
     
1109 1109
     // These are on the Community preferences form (boincwork module)
@@ -1119,18 +1119,18 @@  discard block
 block discarded – undo
1119 1119
     
1120 1120
     // Internal fields to indicate where these user changes are taking place
1121 1121
     array_unshift($form, array(
1122
-      'validation_source' => array(
1122
+        'validation_source' => array(
1123 1123
         '#type' => 'hidden',
1124 1124
         '#value' => 'user_account'
1125
-      ),
1126
-      'update_source' => array(
1125
+        ),
1126
+        'update_source' => array(
1127 1127
         '#type' => 'hidden',
1128 1128
         '#value' => 'user_account'
1129
-      )
1129
+        )
1130 1130
     ));
1131 1131
     break;
1132 1132
     
1133
-  case 'profile_node_form':
1133
+    case 'profile_node_form':
1134 1134
     
1135 1135
     // Use the display name as the title, not the username
1136 1136
     $account = user_load($form['uid']['#value']);
@@ -1141,22 +1141,22 @@  discard block
 block discarded – undo
1141 1141
     $form['title']['#access'] = FALSE;
1142 1142
 
1143 1143
     $form['separator_bottom'] = array(
1144
-      '#value' => '<div class="separator buttons"></div>',
1145
-      '#weight' => 999,
1144
+        '#value' => '<div class="separator buttons"></div>',
1145
+        '#weight' => 999,
1146 1146
     );
1147 1147
     
1148 1148
     if (module_exists('captcha')) {
1149
-      // Add an optional captcha
1150
-      $form['profile_captcha'] = array(
1149
+        // Add an optional captcha
1150
+        $form['profile_captcha'] = array(
1151 1151
         '#type' => 'captcha',
1152 1152
         '#weight' => 1000,
1153
-      );
1153
+        );
1154 1154
     }
1155 1155
     
1156 1156
     // Wrap action buttons for styling consistency
1157 1157
     $form['buttons']['form control tabs prefix'] = array(
1158
-      '#value' => '<ul class="form-control tab-list">',
1159
-      '#weight' => 1001,
1158
+        '#value' => '<ul class="form-control tab-list">',
1159
+        '#weight' => 1001,
1160 1160
     );
1161 1161
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
1162 1162
     $form['buttons']['submit']['#value'] = bts('Save changes', array(), NULL, 'boinc:form-save');
@@ -1169,8 +1169,8 @@  discard block
 block discarded – undo
1169 1169
     $form['buttons']['preview_changes']['#suffix'] = '</li>';
1170 1170
     $form['buttons']['preview_changes']['#weight'] = 1004;
1171 1171
     $form['buttons']['cancel'] = array(
1172
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1173
-      '#weight' => 1005,
1172
+        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1173
+        '#weight' => 1005,
1174 1174
     );
1175 1175
     $form['buttons']['delete']['#prefix'] = '<li class="tab">';
1176 1176
     $form['buttons']['delete']['#suffix'] = '</li>';
@@ -1178,8 +1178,8 @@  discard block
 block discarded – undo
1178 1178
     $form['buttons']['delete']['#weight'] = 1006;
1179 1179
     $form['buttons']['delete']['#submit'] = array('_boincuser_node_profile_delete_submit');
1180 1180
     $form['buttons']['form control tabs suffix'] = array(
1181
-      '#value' => '</ul>',
1182
-      '#weight' => 1010,
1181
+        '#value' => '</ul>',
1182
+        '#weight' => 1010,
1183 1183
     );
1184 1184
     
1185 1185
     $form['#after_build'][] = 'boincuser_profile_node_form_after_build';
@@ -1192,33 +1192,33 @@  discard block
 block discarded – undo
1192 1192
     
1193 1193
     // Internal fields to indicate where these user changes are taking place
1194 1194
     array_unshift($form, array(
1195
-      'validation_source' => array(
1195
+        'validation_source' => array(
1196 1196
         '#type' => 'hidden',
1197 1197
         '#value' => 'user_profile'
1198
-      ),
1199
-      'update_source' => array(
1198
+        ),
1199
+        'update_source' => array(
1200 1200
         '#type' => 'hidden',
1201 1201
         '#value' => 'user_profile'
1202
-      )
1202
+        )
1203 1203
     ));
1204 1204
     break;
1205 1205
   
1206
-  // Registration form
1207
-  case 'user_register':
1206
+    // Registration form
1207
+    case 'user_register':
1208 1208
     array_unshift($form, array(
1209
-      'boincuser_name' => array(
1209
+        'boincuser_name' => array(
1210 1210
         '#type' => 'textfield', 
1211 1211
         '#title' => bts('Name', array(), NULL, 'boinc:user-or-team-name'), 
1212 1212
         '#default_value' => $edit['boincuser_name'], 
1213 1213
         '#maxlength' => USERNAME_MAX_LENGTH, 
1214 1214
         '#description' => bts('Spaces are allowed; punctuation is not allowed except for periods, hyphens, and underscores.', array(), NULL, 'boinc:user-register'), 
1215 1215
         '#required' => TRUE
1216
-      ),
1216
+        ),
1217 1217
     ));
1218 1218
     // Set name temporarily to dummy value to beat validation
1219 1219
     $form['name'] = array(
1220
-      '#type' => 'hidden',
1221
-      '#value' => rand() . '.' . time()
1220
+        '#type' => 'hidden',
1221
+        '#value' => rand() . '.' . time()
1222 1222
     );
1223 1223
 
1224 1224
     // Add JS for submit button disabling
@@ -1228,50 +1228,50 @@  discard block
 block discarded – undo
1228 1228
     $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
1229 1229
     if (!empty($termsofuse)) {
1230 1230
 
1231
-      $form['termsofuse'] = array(
1231
+        $form['termsofuse'] = array(
1232 1232
         '#type'   => 'fieldset',
1233 1233
         '#prefix' => '<div id="termsofuse-wrapper">', // This is our wrapper div.
1234 1234
         '#suffix' => '</div>',
1235 1235
         '#tree'   => TRUE,
1236 1236
         '#weight' => -15,
1237
-      );
1237
+        );
1238 1238
 
1239
-      $form['termsofuse']['title1'] = array(
1239
+        $form['termsofuse']['title1'] = array(
1240 1240
         '#weight' => -12,
1241 1241
         '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), NULL, 'project:user-register' ) . '</h2>',
1242 1242
         '#prefix' => '<div id="register-title1">',
1243 1243
         '#suffix' => '</div>',
1244
-      );
1244
+        );
1245 1245
 
1246
-      $form['termsofuse']['body'] = array(
1246
+        $form['termsofuse']['body'] = array(
1247 1247
         '#weight' => -10,
1248 1248
         '#value' => bts($termsofuse, array(), NULL, 'project:user-register'),
1249 1249
         '#prefix' => '<div id="register-termsofuse">',
1250 1250
         '#suffix' => '</div>',
1251
-      );
1251
+        );
1252 1252
 
1253
-      $form['termsofuse']['agreeTOU'] = array(
1253
+        $form['termsofuse']['agreeTOU'] = array(
1254 1254
         '#type' => 'checkbox',
1255 1255
         '#title' => bts(variable_get('boinc_weboptions_agreequestion', 'Do you agree with the above terms of use?'), array(), NULL, 'project:user-register'),
1256 1256
         '#weight' => -8,
1257 1257
         '#prefix' => '<div id="register-checkbox">',
1258 1258
         '#suffix' => '</div>',
1259
-      );
1259
+        );
1260 1260
     }
1261 1261
 
1262 1262
     $form['title2'] = array(
1263
-      '#weight' => -6,
1264
-      '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle2', 'Fill in your name, email, and choose a secure passphrase.'), array(), NULL, 'project:user-register') . '</h2>',
1265
-      '#prefix' => '<div id="register-title2">',
1266
-      '#suffix' => '</div>',
1263
+        '#weight' => -6,
1264
+        '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle2', 'Fill in your name, email, and choose a secure passphrase.'), array(), NULL, 'project:user-register') . '</h2>',
1265
+        '#prefix' => '<div id="register-title2">',
1266
+        '#suffix' => '</div>',
1267 1267
     );
1268 1268
 
1269 1269
     if (module_exists('captcha')) {
1270
-      // Add an optional captcha
1271
-      $form['register_captcha'] = array(
1270
+        // Add an optional captcha
1271
+        $form['register_captcha'] = array(
1272 1272
         '#type' => 'captcha',
1273 1273
         '#weight' => 1000,
1274
-      );
1274
+        );
1275 1275
     }
1276 1276
     
1277 1277
     $form['#validate'][] = 'boincuser_register_validate';
@@ -1279,35 +1279,35 @@  discard block
 block discarded – undo
1279 1279
     $form['submit']['#weight'] = 1001;
1280 1280
     break;
1281 1281
     
1282
-  // Request new password form
1283
-  case 'user_pass':
1282
+    // Request new password form
1283
+    case 'user_pass':
1284 1284
     drupal_set_title(bts('Forgot password', array(), NULL, 'boinc:forgot-password'));
1285 1285
     // Replace name/email text box with email only; retain "name" label
1286 1286
     // for compatibility with standard Drupal submit function
1287 1287
     unset($form['name']);
1288 1288
     array_unshift($form, array(
1289
-      'name' => array(
1289
+        'name' => array(
1290 1290
         '#type' => 'textfield',
1291 1291
         '#title' => bts('Email address', array(), NULL, 'boinc:email-address-to-login'),
1292 1292
         '#size' => 60,
1293 1293
         '#maxlength' => EMAIL_MAX_LENGTH,
1294 1294
         '#required' => TRUE,
1295 1295
         '#description' => bts(
1296
-          'Enter your email address to receive instructions for resetting your password (or use the !authenticator_login).',
1297
-          array(
1296
+            'Enter your email address to receive instructions for resetting your password (or use the !authenticator_login).',
1297
+            array(
1298 1298
             '!authenticator_login' => l(
1299
-              bts('authenticator-based login', array(), NULL, 'boinc:forgot-password'),
1300
-              'user/login/auth'
1299
+                bts('authenticator-based login', array(), NULL, 'boinc:forgot-password'),
1300
+                'user/login/auth'
1301
+            )
1301 1302
             )
1302
-          )
1303 1303
         , NULL, 'boinc:forgot-password'),
1304
-      ),
1304
+        ),
1305 1305
     ));
1306 1306
     
1307 1307
     // Wrap action buttons for styling consistency
1308 1308
     $form['buttons']['form control tabs prefix'] = array(
1309
-      '#value' => '<ul class="form-control tab-list">',
1310
-      '#weight' => 1001,
1309
+        '#value' => '<ul class="form-control tab-list">',
1310
+        '#weight' => 1001,
1311 1311
     );
1312 1312
     $form['buttons']['submit'] = $form['submit'];
1313 1313
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
@@ -1315,26 +1315,26 @@  discard block
 block discarded – undo
1315 1315
     $form['buttons']['submit']['#suffix'] = '</li>';
1316 1316
     $form['buttons']['submit']['#weight'] = 1002;
1317 1317
     $form['buttons']['cancel'] = array(
1318
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/login') . '</li>',
1319
-      '#weight' => 1005,
1318
+        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/login') . '</li>',
1319
+        '#weight' => 1005,
1320 1320
     );
1321 1321
     $form['buttons']['form control tabs suffix'] = array(
1322
-      '#value' => '</ul>',
1323
-      '#weight' => 1010,
1322
+        '#value' => '</ul>',
1323
+        '#weight' => 1010,
1324 1324
     );
1325 1325
     unset($form['submit']);
1326 1326
     
1327 1327
     // If the form is being submitted, use BOINC validation handler.
1328 1328
     if (isset($form_state['post']['name'])) {
1329
-      // Prepend the BOINC validation function to local validation
1330
-      array_unshift($form['#validate'], 'boincuser_request_pass_validate');
1329
+        // Prepend the BOINC validation function to local validation
1330
+        array_unshift($form['#validate'], 'boincuser_request_pass_validate');
1331 1331
     }
1332 1332
     break;
1333 1333
     
1334
-  case 'views_exposed_form':
1334
+    case 'views_exposed_form':
1335 1335
       $form['submit']['#value'] = bts('Search', array(), NULL, 'boinc:search-user');
1336 1336
     break;
1337
-  }
1337
+    }
1338 1338
 }
1339 1339
 
1340 1340
 /**
@@ -1342,10 +1342,10 @@  discard block
 block discarded – undo
1342 1342
  * built; this is called from boincuser_form_alter()
1343 1343
  */
1344 1344
 function boincuser_profile_node_form_after_build($form, &$form_state) {
1345
-  // Move to community prefs form
1346
-  $form_state['storage']['avatar'] = $form['field_image'];
1347
-  unset($form['field_image']);
1348
-  return $form;
1345
+    // Move to community prefs form
1346
+    $form_state['storage']['avatar'] = $form['field_image'];
1347
+    unset($form['field_image']);
1348
+    return $form;
1349 1349
 }
1350 1350
 
1351 1351
 /**
@@ -1353,8 +1353,8 @@  discard block
 block discarded – undo
1353 1353
  * @see http://api.drupal.org/api/drupal/developer--hooks--core.php/function/hook_elements/6
1354 1354
  */
1355 1355
 function boincuser_elements() {
1356
-  $type['password_confirm']['#process'][] = 'boincuser_process_password_confirm';
1357
-  return $type;
1356
+    $type['password_confirm']['#process'][] = 'boincuser_process_password_confirm';
1357
+    return $type;
1358 1358
 }
1359 1359
 
1360 1360
 /**
@@ -1362,11 +1362,11 @@  discard block
 block discarded – undo
1362 1362
  * profile form
1363 1363
  */
1364 1364
 function boincuser_process_password_confirm($element) {
1365
-  // Check if parent element is "account".
1366
-  if ($element['#array_parents'][0] == 'account') {
1365
+    // Check if parent element is "account".
1366
+    if ($element['#array_parents'][0] == 'account') {
1367 1367
     $element['pass1']['#title'] = bts('Change password', array(), NULL, 'boinc:forgot-password');
1368
-  }
1369
-  return $element;
1368
+    }
1369
+    return $element;
1370 1370
 }
1371 1371
 
1372 1372
 /**
@@ -1374,42 +1374,42 @@  discard block
 block discarded – undo
1374 1374
  * Register theme functions for use in this module.
1375 1375
  */
1376 1376
 function boincuser_theme($existing, $type, $theme, $path) {
1377
-  return array(
1377
+    return array(
1378 1378
     'boincuser_user_pass' => array(
1379
-      'arguments' => array()
1379
+        'arguments' => array()
1380 1380
     )
1381
-  );
1381
+    );
1382 1382
 }
1383 1383
 
1384 1384
 /**
1385 1385
  * Implementation of hook_token_values
1386 1386
  */
1387 1387
 function boincuser_token_values($type, $object = NULL, $options = array()) {
1388
-  if ($type == 'user') {
1388
+    if ($type == 'user') {
1389 1389
     $account = user_load($object->uid);
1390 1390
     $tokens['display-name'] = $account->boincuser_name;
1391 1391
     return $tokens;
1392
-  }
1392
+    }
1393 1393
 }
1394 1394
 
1395 1395
 /**
1396 1396
  * Implementation of hook_token_list
1397 1397
  */
1398 1398
 function boincuser_token_list($type = 'all') {
1399
-  if ($type == 'user' || $type == 'all') {
1399
+    if ($type == 'user' || $type == 'all') {
1400 1400
     $tokens['user']['display-name']      = t("The user's name that should be displayed");
1401 1401
     return $tokens;
1402
-  }
1402
+    }
1403 1403
 }
1404 1404
 
1405 1405
 /**
1406 1406
  * Implementation of hook_views_pre_execute()
1407 1407
  */
1408 1408
 function boincuser_views_pre_execute(&$view) {
1409
-  if ($view->args) {
1409
+    if ($view->args) {
1410 1410
     $account_id = $view->args[0];
1411
-  }
1412
-  if ($view->name=="user_activity") {
1411
+    }
1412
+    if ($view->name=="user_activity") {
1413 1413
     // Run the following custom query for the user_activity view
1414 1414
     $view->build_info['query']= "
1415 1415
       SELECT node_revisions.vid AS vid,
@@ -1441,25 +1441,25 @@  discard block
 block discarded – undo
1441 1441
     
1442 1442
     // count_query determines the pager.  Do this so the right item count is returned.
1443 1443
     $view->build_info['count_query'] = $view->build_info['query'];
1444
-  }
1444
+    }
1445 1445
 }
1446 1446
 
1447 1447
 /**
1448 1448
  * Implementation of hook_cron()
1449 1449
  */
1450 1450
 function boincuser_cron() {
1451
-  // Delete expired users in the BOINC database, user_delete table.
1452
-  require_boinc('boinc_db');
1453
-  $num_deleted = BoincUserDeleted::delete_expired();
1454
-  if ($num_deleted>0) {
1451
+    // Delete expired users in the BOINC database, user_delete table.
1452
+    require_boinc('boinc_db');
1453
+    $num_deleted = BoincUserDeleted::delete_expired();
1454
+    if ($num_deleted>0) {
1455 1455
     watchdog('boincuser', "Deleted ${num_deleted} users from user_deleted table", WATCHDOG_NOTICE);
1456
-  }
1456
+    }
1457 1457
 
1458
-  // Delete expired tokens from token table
1459
-  $tokens_deleted = BoincToken::delete_expired();
1460
-  if ($tokens_deleted>0) {
1458
+    // Delete expired tokens from token table
1459
+    $tokens_deleted = BoincToken::delete_expired();
1460
+    if ($tokens_deleted>0) {
1461 1461
     watchdog('boincuser', "Deleted ${tokens_deleted} tokens from token table", WATCHDOG_NOTICE);
1462
-  }
1462
+    }
1463 1463
 }
1464 1464
 
1465 1465
 /*  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *
@@ -1470,17 +1470,17 @@  discard block
 block discarded – undo
1470 1470
  * Page callback shortcut to recent posts for the logged in user
1471 1471
  */
1472 1472
 function boincuser_goto_recent_posts() {
1473
-  global $user;
1474
-  drupal_goto("account/{$user->uid}/posts");
1473
+    global $user;
1474
+    drupal_goto("account/{$user->uid}/posts");
1475 1475
 }
1476 1476
 
1477 1477
 /**
1478 1478
  * Page callback shortcut to the team of the logged in user
1479 1479
  */
1480 1480
 function boincuser_goto_team() {
1481
-  global $user;
1482
-  $account = user_load($user->uid);
1483
-  drupal_goto("community/teams/{$account->team}");
1481
+    global $user;
1482
+    $account = user_load($user->uid);
1483
+    drupal_goto("community/teams/{$account->team}");
1484 1484
 }
1485 1485
 
1486 1486
 /**
@@ -1489,93 +1489,93 @@  discard block
 block discarded – undo
1489 1489
  * user profile pages, so use a wrapper for display
1490 1490
  */
1491 1491
 function boincuser_view_profile($account = null) {
1492
-  // Create the user profile page
1493
-  if (!$account) {
1492
+    // Create the user profile page
1493
+    if (!$account) {
1494 1494
     global $user;
1495 1495
     $account = $user;
1496
-  }
1496
+    }
1497 1497
 
1498
-  $min_credit_to_post = variable_get('boinc_comment_min_credit', 0);
1499
-  $verified_contributor = array_search('verified contributor', user_roles(true));
1500
-  if (!isset($account->roles[$verified_contributor])) {
1498
+    $min_credit_to_post = variable_get('boinc_comment_min_credit', 0);
1499
+    $verified_contributor = array_search('verified contributor', user_roles(true));
1500
+    if (!isset($account->roles[$verified_contributor])) {
1501 1501
     drupal_set_message(bts(
1502 1502
         'You may only create or modify your user profile after earning @count credits.',
1503 1503
         array('@count' => $min_credit_to_post), NULL, 'boinc:view-profile'
1504 1504
     ), 'warning', FALSE);
1505
-  }
1505
+    }
1506 1506
 
1507
-  // For now, just call the user module profile view function
1508
-  user_build_content($account);
1509
-  return theme('user_profile', $account);
1507
+    // For now, just call the user module profile view function
1508
+    user_build_content($account);
1509
+    return theme('user_profile', $account);
1510 1510
 }
1511 1511
 
1512 1512
 /**
1513 1513
  * Page callback for editing a user profile
1514 1514
  */
1515 1515
 function boincuser_edit_profile($account = null) {
1516
-  // Create the user profile form
1517
-  if (!$account) {
1516
+    // Create the user profile form
1517
+    if (!$account) {
1518 1518
     global $user;
1519 1519
     $account = $user;
1520
-  }
1521
-  // Render the form
1522
-  module_load_include('pages.inc', 'node', 'node');
1523
-  return content_profile_page_edit('profile', $account);
1520
+    }
1521
+    // Render the form
1522
+    module_load_include('pages.inc', 'node', 'node');
1523
+    return content_profile_page_edit('profile', $account);
1524 1524
 }
1525 1525
 
1526 1526
 /**
1527
-  * Join page menu callback.
1528
-  * Display instructions on joining for new or existing BOINC users
1529
-  */
1527
+ * Join page menu callback.
1528
+ * Display instructions on joining for new or existing BOINC users
1529
+ */
1530 1530
 function join_page($type = null) {
1531
-  global $base_url;
1532
-  /* The paths/links to the rules-and-policies page is hardcoded
1531
+    global $base_url;
1532
+    /* The paths/links to the rules-and-policies page is hardcoded
1533 1533
    * here. An improvement would be admin settings for the Join Page
1534 1534
    * where this path could be set.
1535 1535
    */
1536
-  $ruleslinkA = 'rules-and-policies';
1537
-  $ruleslinkB = 'content/rules-and-policies';
1538
-  $site_name = variable_get('site_name', 'Drupal-BOINC');
1539
-  $registration_enabled = variable_get('user_register', 0);
1540
-  $output = '<div class="join">';
1541
-  switch ($type) {
1542
-  case 'boinc':
1536
+    $ruleslinkA = 'rules-and-policies';
1537
+    $ruleslinkB = 'content/rules-and-policies';
1538
+    $site_name = variable_get('site_name', 'Drupal-BOINC');
1539
+    $registration_enabled = variable_get('user_register', 0);
1540
+    $output = '<div class="join">';
1541
+    switch ($type) {
1542
+    case 'boinc':
1543 1543
     $output .= '<ol>';
1544 1544
     if ($registration_enabled) {
1545
-      $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1546
-      array(
1545
+        $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1546
+        array(
1547 1547
         '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'),
1548 1548
         '@sitename' => $site_name,
1549
-      ), NULL, 'boinc:join-page') . '</li>';
1549
+        ), NULL, 'boinc:join-page') . '</li>';
1550 1550
     }
1551 1551
     $output .= '  <li>' . bts("Install BOINC on this device if not already present.", array(), NULL, 'boinc:join-page') . '</li>';
1552 1552
     $output .= '  <li>' . bts("Select <i>Tools / Add Project</i>. Choose @sitename from the list, or enter @siteurl.",
1553 1553
     array(
1554
-      '@sitename' => $site_name,
1555
-      '@siteurl' => $base_url,
1554
+        '@sitename' => $site_name,
1555
+        '@siteurl' => $base_url,
1556 1556
     ), NULL, 'boinc:join-page') . '</li>';
1557 1557
     if ($registration_enabled) {
1558
-      $output .= '<li>' . bts("If you're running a command-line or pre-5.0 version of BOINC, use <b>!boinccmd</b> to add the project.",
1558
+        $output .= '<li>' . bts("If you're running a command-line or pre-5.0 version of BOINC, use <b>!boinccmd</b> to add the project.",
1559 1559
         array(
1560
-          '!boinccmd' => l('boinccmd --project_attach', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1560
+            '!boinccmd' => l('boinccmd --project_attach', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1561 1561
         ), NULL, 'boinc:join-page') . '</li>';
1562 1562
     }
1563 1563
     else {
1564
-      $output .= '<li>' . bts("If you're running a command-line version of BOINC,
1564
+        $output .= '<li>' . bts("If you're running a command-line version of BOINC,
1565 1565
         please follow the <b>!instructionslink</b> to first <i>create an account</i>, and then <i>attach</i> to this project. Use the same project URL as above.",
1566 1566
         array(
1567
-          '!instructionslink' => l('instructions', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1567
+            '!instructionslink' => l('instructions', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1568 1568
         ), NULL, 'boinc:join-page') . '</li>';
1569 1569
     }
1570 1570
     $output .= '<li>' . bts("If you're running a pre-5.0 version of BOINC, please
1571 1571
       upgrade to a more recent version of BOINC to create an account
1572 1572
       at @this_project.",
1573
-      array(
1573
+        array(
1574 1574
         '@this_project' => $site_name,
1575
-      ), NULL, 'boinc:join-page') . '</li>';
1575
+        ), NULL, 'boinc:join-page') . '</li>';
1576 1576
     $output .=  '</ol>';
1577 1577
     break;
1578
-  case 'new':
1578
+    case 'new':
1579 1579
   default:
1580 1580
     // Determine if there is a link to rules-and-policies
1581 1581
     //$ruleslink='';
@@ -1590,16 +1590,16 @@  discard block
 block discarded – undo
1590 1590
     // Join page output
1591 1591
     $output .= '<ol>';
1592 1592
     if ($registration_enabled) {
1593
-      $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1594
-      array(
1593
+        $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1594
+        array(
1595 1595
         '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'),
1596 1596
         '@sitename' => $site_name,
1597
-      ), NULL, 'boinc:join-page') . '</li>';
1597
+        ), NULL, 'boinc:join-page') . '</li>';
1598 1598
     }
1599 1599
     else if ( menu_valid_path(array('link_path' => $ruleslink)) ) {
1600
-      $output .= '  <li>' . bts("Read our !rules_and_policies.", array(
1600
+        $output .= '  <li>' . bts("Read our !rules_and_policies.", array(
1601 1601
         '!rules_and_policies' => l(bts('Rules and Policies', array(), NULL, 'boinc:join-page'), $ruleslink),
1602
-      ), NULL, 'boinc:join-page') . '</li>';
1602
+        ), NULL, 'boinc:join-page') . '</li>';
1603 1603
     }
1604 1604
     $output .= '  <li>' . bts('Download the BOINC desktop software.', array(), NULL, 'boinc:join-page');
1605 1605
     $output .= '    <p>';
@@ -1609,73 +1609,73 @@  discard block
 block discarded – undo
1609 1609
     $output .= '  </li>';
1610 1610
     $output .= '  <li>' . bts('Run the installer.', array(), NULL, 'boinc:join-page') . '</li>';
1611 1611
     $output .= '  <li>' . bts('Choose @sitename from the list, or enter @siteurl.', array(
1612
-      '@sitename' => $site_name,
1613
-      '@siteurl' => $base_url,
1612
+        '@sitename' => $site_name,
1613
+        '@siteurl' => $base_url,
1614 1614
     ), NULL, 'boinc:join-page') . '</li>';
1615 1615
     $output .=  '</ol>';
1616
-  }
1617
-  $output .= '</div>';
1618
-  return $output;
1616
+    }
1617
+    $output .= '</div>';
1618
+    return $output;
1619 1619
 }
1620 1620
 
1621 1621
 /**
1622
-  * Home page content for embedding in Panels page
1623
-  */
1622
+ * Home page content for embedding in Panels page
1623
+ */
1624 1624
 function boincuser_home_page() {
1625
-  global $user;
1626
-  $site_name = variable_get('site_name', 'Drupal-BOINC');
1627
-  // get the front page message from database; this is set in the admin interface under BOINC Other
1628
-  $site_message = variable_get('boinc_other_frontpage','');
1625
+    global $user;
1626
+    $site_name = variable_get('site_name', 'Drupal-BOINC');
1627
+    // get the front page message from database; this is set in the admin interface under BOINC Other
1628
+    $site_message = variable_get('boinc_other_frontpage','');
1629 1629
 
1630
-  // Determine the user of the day
1631
-  $current_uotd = db_fetch_object(db_query("
1630
+    // Determine the user of the day
1631
+    $current_uotd = db_fetch_object(db_query("
1632 1632
     SELECT
1633 1633
       uid,
1634 1634
       uotd_time
1635 1635
     FROM {boincuser}
1636 1636
     ORDER BY uotd_time DESC
1637 1637
     LIMIT 1"
1638
-  ));
1639
-  if ($current_uotd->uotd_time < strtotime('today midnight')) {
1638
+    ));
1639
+    if ($current_uotd->uotd_time < strtotime('today midnight')) {
1640 1640
     $uotd = boincuser_select_user_of_the_day();
1641
-  }
1642
-  else {
1641
+    }
1642
+    else {
1643 1643
     $uotd = user_load($current_uotd->uid);
1644
-  }
1645
-  $uotd_image = boincuser_get_user_profile_image($uotd->uid, FALSE);
1646
-  $output = '<h2 class="pane-title">';
1647
-  $output .= ($user->uid) ? bts('Welcome back!', array(), NULL, 'boinc:front-page') : ($site_name ? bts('What is @this_project?', array('@this_project' => $site_name)) : bts('Welcome!', array(), NULL, 'boinc:front-page'));
1648
-  $output .= '</h2>';
1649
-  $output .= '<div class="boinc-overview balance-height-front">';
1650
-  $output .= '  <div>' . bts($site_message, array(), NULL, "project:front page") . ' ' . l(bts('Learn more', array(), NULL, 'boinc:front-page'), 'about') . '</div>';
1651
-  if ($user->uid) {
1644
+    }
1645
+    $uotd_image = boincuser_get_user_profile_image($uotd->uid, FALSE);
1646
+    $output = '<h2 class="pane-title">';
1647
+    $output .= ($user->uid) ? bts('Welcome back!', array(), NULL, 'boinc:front-page') : ($site_name ? bts('What is @this_project?', array('@this_project' => $site_name)) : bts('Welcome!', array(), NULL, 'boinc:front-page'));
1648
+    $output .= '</h2>';
1649
+    $output .= '<div class="boinc-overview balance-height-front">';
1650
+    $output .= '  <div>' . bts($site_message, array(), NULL, "project:front page") . ' ' . l(bts('Learn more', array(), NULL, 'boinc:front-page'), 'about') . '</div>';
1651
+    if ($user->uid) {
1652 1652
     $output .= '  <div>' . l(bts('View account', array(), NULL, 'boinc:front-page'), 'dashboard', array('attributes' => array('class' => 'join button'))) . '</div>';
1653
-  }
1654
-  else {
1653
+    }
1654
+    else {
1655 1655
     $output .= '  <div>' . l(bts('Join now', array(), NULL, 'boinc:front-page'), 'join', array('attributes' => array('class' => 'join button'))) . '</div>';
1656
-  }
1657
-  $output .= '</div>';
1658
-  $output .= '<div class="boinc-overview-details">';
1659
-  $output .= '  <div class="detail-container">';
1660
-  $output .= '    <a class="user-of-the-day" href="account/' . $uotd->uid . '">';
1661
-  $output .= '      <div class="picture">';
1662
-  $output .= theme('imagefield_image', $uotd_image['image'], $uotd_image['alt'],
1656
+    }
1657
+    $output .= '</div>';
1658
+    $output .= '<div class="boinc-overview-details">';
1659
+    $output .= '  <div class="detail-container">';
1660
+    $output .= '    <a class="user-of-the-day" href="account/' . $uotd->uid . '">';
1661
+    $output .= '      <div class="picture">';
1662
+    $output .= theme('imagefield_image', $uotd_image['image'], $uotd_image['alt'],
1663 1663
     $uotd_image['alt'], array(), FALSE);
1664
-  $output .= '      </div>';
1665
-  $output .= '      <div class="text">' . bts('User of the day', array(), NULL, 'boinc:front-page') . '</div>';
1666
-  $output .= '      <div class="detail">' . $uotd->boincuser_name . '</div>';
1667
-  $output .= '    </a>';
1668
-  $output .= '    <div class="volunteers">';
1669
-  $output .= '      <div class="text">' . bts('Over 500,000 volunteers and counting.', array(), NULL, 'boinc:front-page') . '</div>';
1670
-  $output .= '      <div class="platforms">';
1671
-  $output .= '        <div class="detail platform windows">' . bts('Windows', array(), NULL, 'boinc:front-page') . '</div>';
1672
-  $output .= '        <div class="detail platform mac">' .  bts('Mac', array(), NULL, 'boinc:front-page') . '</div>';
1673
-  $output .= '        <div class="detail platform linux">' . bts('Linux', array(), NULL, 'boinc:front-page') . '</div>';
1674
-  $output .= '      </div>';
1675
-  $output .= '    </div>';
1676
-  $output .= '  </div>';
1677
-  $output .= '</div>';
1678
-  return $output;
1664
+    $output .= '      </div>';
1665
+    $output .= '      <div class="text">' . bts('User of the day', array(), NULL, 'boinc:front-page') . '</div>';
1666
+    $output .= '      <div class="detail">' . $uotd->boincuser_name . '</div>';
1667
+    $output .= '    </a>';
1668
+    $output .= '    <div class="volunteers">';
1669
+    $output .= '      <div class="text">' . bts('Over 500,000 volunteers and counting.', array(), NULL, 'boinc:front-page') . '</div>';
1670
+    $output .= '      <div class="platforms">';
1671
+    $output .= '        <div class="detail platform windows">' . bts('Windows', array(), NULL, 'boinc:front-page') . '</div>';
1672
+    $output .= '        <div class="detail platform mac">' .  bts('Mac', array(), NULL, 'boinc:front-page') . '</div>';
1673
+    $output .= '        <div class="detail platform linux">' . bts('Linux', array(), NULL, 'boinc:front-page') . '</div>';
1674
+    $output .= '      </div>';
1675
+    $output .= '    </div>';
1676
+    $output .= '  </div>';
1677
+    $output .= '</div>';
1678
+    return $output;
1679 1679
 }
1680 1680
 
1681 1681
 /**
@@ -1683,81 +1683,81 @@  discard block
 block discarded – undo
1683 1683
  * Create a new user account based on supplied parameters.
1684 1684
  */
1685 1685
 function boincuser_create_account() {
1686
-  global $base_url;
1686
+    global $base_url;
1687 1687
 
1688
-  require_boinc('boinc_db');
1689
-  require_boinc('user_util');
1690
-  require_boinc('xml');
1691
-  $params = array(
1688
+    require_boinc('boinc_db');
1689
+    require_boinc('user_util');
1690
+    require_boinc('xml');
1691
+    $params = array(
1692 1692
     'email_addr' => isset($_GET['email_addr']) ? $_GET['email_addr'] : '',
1693 1693
     'user_name' => isset($_GET['user_name']) ? $_GET['user_name'] : '',
1694 1694
     'passwd_hash' => isset($_GET['passwd_hash']) ? $_GET['passwd_hash'] : ''
1695
-  );
1695
+    );
1696 1696
   
1697
-  // Begin output
1698
-  xml_header();
1697
+    // Begin output
1698
+    xml_header();
1699 1699
   
1700
-  // Account creation disabled
1701
-  $enablethisRPC = variable_get('boinc_weboptions_enableaccountcreateRPC', TRUE);
1702
-  if (!$enablethisRPC) {
1700
+    // Account creation disabled
1701
+    $enablethisRPC = variable_get('boinc_weboptions_enableaccountcreateRPC', TRUE);
1702
+    if (!$enablethisRPC) {
1703 1703
     $mess = bts('Account creation is done through our Web site. Please register at @url', array(
1704
-      '@url' => $base_url . '/user/registration',
1704
+        '@url' => $base_url . '/user/registration',
1705 1705
     ),
1706 1706
     NULL, 'boinc:create_account');
1707 1707
     xml_error(-208, $mess);
1708
-  }
1709
-  // Invalid invite code
1708
+    }
1709
+    // Invalid invite code
1710 1710
   
1711
-  // Validate input
1712
-  if (user_validate_mail($params['email_addr']) or !is_valid_email_addr($params['email_addr'])) {
1711
+    // Validate input
1712
+    if (user_validate_mail($params['email_addr']) or !is_valid_email_addr($params['email_addr'])) {
1713 1713
     xml_error(-205);
1714
-  }
1714
+    }
1715 1715
 
1716
-  // Make sure user_name is unique and cleaned
1717
-  $unique_name = create_proper_drupalname($params['user_name']);
1718
-  if ($error = user_validate_name($unique_name)) {
1716
+    // Make sure user_name is unique and cleaned
1717
+    $unique_name = create_proper_drupalname($params['user_name']);
1718
+    if ($error = user_validate_name($unique_name)) {
1719 1719
     xml_error(-188, $error);
1720
-  }
1721
-  if (strlen($params['passwd_hash']) != 32) {
1720
+    }
1721
+    if (strlen($params['passwd_hash']) != 32) {
1722 1722
     xml_error(-1, 'password hash length not 32');
1723
-  }
1723
+    }
1724 1724
   
1725
-  // Process input
1726
-  // Check this email against previous email addresses.
1727
-  $tmpuser = BoincUser::lookup_prev_email_addr($params['email_addr']);
1728
-  if ($tmpuser) {
1725
+    // Process input
1726
+    // Check this email against previous email addresses.
1727
+    $tmpuser = BoincUser::lookup_prev_email_addr($params['email_addr']);
1728
+    if ($tmpuser) {
1729 1729
     xml_error(-137);
1730
-  }
1730
+    }
1731 1731
 
1732
-  // Check this email on current email addresses.
1733
-  $boinc_user = BoincUser::lookup_email_addr($params['email_addr']);
1734
-  if ($boinc_user) {
1732
+    // Check this email on current email addresses.
1733
+    $boinc_user = BoincUser::lookup_email_addr($params['email_addr']);
1734
+    if ($boinc_user) {
1735 1735
     // Return authenticator for existing users
1736 1736
     if ( ($params['passwd_hash'] == $boinc_user->passwd_hash) or
1737 1737
     password_verify($params['passwd_hash'], $boinc_user->passwd_hash) ) {
1738
-      $output = array('authenticator' => $boinc_user->authenticator);
1738
+        $output = array('authenticator' => $boinc_user->authenticator);
1739 1739
     }
1740 1740
     else {
1741
-      xml_error(-137);
1741
+        xml_error(-137);
1742 1742
     }
1743
-  }
1744
-  else {
1743
+    }
1744
+    else {
1745 1745
     // Verify that there isn't somehow a Drupal user already (not possible with proper function)
1746 1746
     if ($existing_user = user_load(array('mail' => $params['email_addr']))) {
1747
-      xml_error(-137, 'account error');
1747
+        xml_error(-137, 'account error');
1748 1748
     }
1749 1749
     // Create new account
1750 1750
     $unrestricted_role = array_search('community member', user_roles(true));
1751 1751
 
1752 1752
     $newUser = array(
1753
-      'name' => $unique_name,
1754
-      'pass' => $params['passwd_hash'], // note: passing a hash here requires ALL passwords to be hashed via hook prior to interacting with the hash stored in the db
1755
-      'mail' => $params['email_addr'],
1756
-      'status' => 1,
1757
-      'init' => $params['email_addr'],
1758
-      'roles' => array($unrestricted_role => ''),
1759
-      'boincuser_name' => $params['user_name'],
1760
-      'boinchash_flag' => TRUE,
1753
+        'name' => $unique_name,
1754
+        'pass' => $params['passwd_hash'], // note: passing a hash here requires ALL passwords to be hashed via hook prior to interacting with the hash stored in the db
1755
+        'mail' => $params['email_addr'],
1756
+        'status' => 1,
1757
+        'init' => $params['email_addr'],
1758
+        'roles' => array($unrestricted_role => ''),
1759
+        'boincuser_name' => $params['user_name'],
1760
+        'boinchash_flag' => TRUE,
1761 1761
     );
1762 1762
 
1763 1763
     // Create the drupal user. If the drupal user cannot be created,
@@ -1765,17 +1765,17 @@  discard block
 block discarded – undo
1765 1765
     // The user is created in the 'insert' op in hook_user.
1766 1766
     $user = user_save(null, $newUser);
1767 1767
     if (!$user) {
1768
-      watchdog('boincuser', 'create_account: Failed to create Drupal user account for @email', array('@email' => $params['email_addr']), WATCHDOG_WARNING);
1769
-      xml_error(-137, 'error creating BOINC account');
1768
+        watchdog('boincuser', 'create_account: Failed to create Drupal user account for @email', array('@email' => $params['email_addr']), WATCHDOG_WARNING);
1769
+        xml_error(-137, 'error creating BOINC account');
1770 1770
     }// if drupal user created.
1771 1771
 
1772 1772
     $output = array('authenticator' => $user->boincuser_account_key);
1773
-  }// if existing user found.
1773
+    }// if existing user found.
1774 1774
 
1775
-  // Output authenticator
1776
-  echo " <account_out>\n";
1777
-  echo "   <authenticator>{$output['authenticator']}</authenticator>\n";
1778
-  echo "</account_out>\n";
1775
+    // Output authenticator
1776
+    echo " <account_out>\n";
1777
+    echo "   <authenticator>{$output['authenticator']}</authenticator>\n";
1778
+    echo "</account_out>\n";
1779 1779
 }
1780 1780
 
1781 1781
 /**
@@ -1783,166 +1783,166 @@  discard block
 block discarded – undo
1783 1783
  * account is created using the BOINC clinet.
1784 1784
  */
1785 1785
 function boincuser_account_finish() {
1786
-  global $user;
1786
+    global $user;
1787 1787
 
1788
-  $authtoken = isset($_GET['auth']) ? $_GET['auth'] : '';
1788
+    $authtoken = isset($_GET['auth']) ? $_GET['auth'] : '';
1789 1789
 
1790
-  // Ensure there is a authentication token before continuing
1791
-  if (empty($authtoken)) {
1790
+    // Ensure there is a authentication token before continuing
1791
+    if (empty($authtoken)) {
1792 1792
     drupal_not_found();
1793 1793
     return ;
1794
-  }
1794
+    }
1795 1795
 
1796
-  if (strlen($authtoken) != 32) {
1796
+    if (strlen($authtoken) != 32) {
1797 1797
     drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), NULL, 'boinc:account-finish'), 'error');
1798 1798
     drupal_goto();
1799
-  }
1799
+    }
1800 1800
 
1801
-  require_boinc('boinc_db');
1802
-  $boinc_user = BoincUser::lookup("authenticator='".addslashes($authtoken)."'");
1803
-  if (!$boinc_user) {
1801
+    require_boinc('boinc_db');
1802
+    $boinc_user = BoincUser::lookup("authenticator='".addslashes($authtoken)."'");
1803
+    if (!$boinc_user) {
1804 1804
     drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), NULL, 'boinc:account-finish'), 'error');
1805 1805
     drupal_goto();
1806
-  }
1807
-  $user = user_load(get_drupal_id($boinc_user->id));
1806
+    }
1807
+    $user = user_load(get_drupal_id($boinc_user->id));
1808 1808
 
1809
-  if (!$user) {
1809
+    if (!$user) {
1810 1810
     drupal_set_message(bts('ERROR: There was a problem loading your account. Try logging in with your user name and password.', array(), NULL, 'boinc:account-finish'), 'error');
1811 1811
     drupal_goto();
1812
-  }
1812
+    }
1813 1813
 
1814
-  // Lookup path to custom account finish page
1815
-  $customaccountfinishpath = drupal_lookup_path('source', variable_get('boinc_weboptions_accountfinish', '') );
1816
-  if ( menu_valid_path(array('link_path' => $customaccountfinishpath)) ) {
1814
+    // Lookup path to custom account finish page
1815
+    $customaccountfinishpath = drupal_lookup_path('source', variable_get('boinc_weboptions_accountfinish', '') );
1816
+    if ( menu_valid_path(array('link_path' => $customaccountfinishpath)) ) {
1817 1817
     $node = menu_get_object('node', 1, $customaccountfinishpath);
1818 1818
     if ($node) {
1819
-      return node_page_view($node);
1819
+        return node_page_view($node);
1820
+    }
1820 1821
     }
1821
-  }
1822 1822
 
1823
-  // open links in new window
1824
-  $options = array(
1823
+    // open links in new window
1824
+    $options = array(
1825 1825
     'attributes' => array( 'target' => '_blank' ),
1826
-  );
1826
+    );
1827 1827
 
1828
-  // Check moderation page exists
1829
-  $moderationpath = drupal_lookup_path('source', variable_get('boinc_weboptions_moderationpage', '') );
1830
-  if ( menu_valid_path(array('link_path' => $moderationpath)) ) {
1828
+    // Check moderation page exists
1829
+    $moderationpath = drupal_lookup_path('source', variable_get('boinc_weboptions_moderationpage', '') );
1830
+    if ( menu_valid_path(array('link_path' => $moderationpath)) ) {
1831 1831
     $modsentence = bts('Please note: user profiles are subject to !moderation.', array('!moderation' => l(bts('moderation', array(), NULL, 'boinc:account-finish'), $moderationpath, $options)), NULL, 'boinc:account-finish');
1832
-  } else {
1832
+    } else {
1833 1833
     $modsentence = bts('Please note: user profiles are subject to moderation.', array(), NULL, 'boinc:account-finish');
1834
-  }
1834
+    }
1835 1835
 
1836
-  $username = $user->boincuser_name;
1837
-  $site_name = variable_get('site_name', 'Drupal-BOINC');
1838
-  $output = "<p>" . bts('Thank you @user_name for joining @site_name. Your account has been created. Your BOINC client should start working on assigned tasks soon, without any additional action or configuration. Please visit the links below for more information and additional options. (Links will open in a new window.)',
1839
-  array(
1836
+    $username = $user->boincuser_name;
1837
+    $site_name = variable_get('site_name', 'Drupal-BOINC');
1838
+    $output = "<p>" . bts('Thank you @user_name for joining @site_name. Your account has been created. Your BOINC client should start working on assigned tasks soon, without any additional action or configuration. Please visit the links below for more information and additional options. (Links will open in a new window.)',
1839
+    array(
1840 1840
     '@user_name' => $username,
1841 1841
     '@site_name' => $site_name,
1842
-  ), NULL, 'boinc:account-finish') . "</p>";
1842
+    ), NULL, 'boinc:account-finish') . "</p>";
1843 1843
 
1844
-  $links = array(
1844
+    $links = array(
1845 1845
     array(
1846
-      'data' => bts('Change your username at !community_preferences.', array(
1846
+        'data' => bts('Change your username at !community_preferences.', array(
1847 1847
         '!community_preferences' => l(bts('Community Preferences', array(), NULL, 'boinc:account-fininsh'), 'account/prefs/community', $options),
1848
-      ), NULL, 'boinc:account-finish'),
1849
-      'children' => array(
1848
+        ), NULL, 'boinc:account-finish'),
1849
+        'children' => array(
1850 1850
         bts('Your username is used to identify yourself to other volunteers on this Web site.', array(), NULL, 'boinc:account-finish'),
1851 1851
         bts('In addition, you may set your account\'s default language and adjust notification settings.', array(), NULL, 'boinc:account-finish'),
1852
-      ),
1852
+        ),
1853 1853
     ),
1854 1854
     array(
1855
-      'data' => bts('Change your !computing_preferences.', array(
1855
+        'data' => bts('Change your !computing_preferences.', array(
1856 1856
         '!computing_preferences' => l(bts('Computing Preferences', array(), NULL, 'boinc:account-finish'), 'account/prefs', $options),
1857
-      ), NULL, 'boinc:account-finish'),
1858
-      'children' => array(
1857
+        ), NULL, 'boinc:account-finish'),
1858
+        'children' => array(
1859 1859
         bts('You may adjust how much CPU, RAM, and Disk space the BOINC client is allowed to use for tasks on your computer.', array(), NULL, 'boinc:account-finish'),
1860 1860
         bts('By default, you will run @site_name tasks without any additional configuration.', array(
1861
-          '@site_name' => $site_name,
1861
+            '@site_name' => $site_name,
1862 1862
         ), NULL, 'boinc:account-finish'),
1863 1863
         bts('It is recommended new volunteers leave the default settings until they gain experience running some tasks. Ask questions in the !forums to get advice before making changes to a setting you don\'t understand.', array(
1864
-          '!forums' => l(bts('forums', array(), NULL, 'boinc:account-finish'), 'community/forum', $options),
1864
+            '!forums' => l(bts('forums', array(), NULL, 'boinc:account-finish'), 'community/forum', $options),
1865 1865
         ), NULL, 'boinc:account-finish'),
1866
-      ),
1866
+        ),
1867 1867
     ),
1868 1868
     array(
1869 1869
         'data' => bts('Create a !user_profile.', array(
1870
-          '!user_profile' => l(bts('User Profile', array(), NULL, 'boinc:account-finish'), '/account/profile/edit', $options),
1870
+            '!user_profile' => l(bts('User Profile', array(), NULL, 'boinc:account-finish'), '/account/profile/edit', $options),
1871 1871
         ), NULL, 'boinc:account-finish'),
1872
-      'children' => array(
1872
+        'children' => array(
1873 1873
         bts('A user profile will inform other volunteers who you are and why you joined @site_name.', array(
1874
-          '@site_name' => $site_name,
1874
+            '@site_name' => $site_name,
1875 1875
         ), NULL, 'boinc:account-finish'),
1876 1876
         $modsentence,
1877
-      ),
1877
+        ),
1878 1878
     ),
1879 1879
     array(
1880
-      'data' => bts('Join a !team.', array(
1880
+        'data' => bts('Join a !team.', array(
1881 1881
         '!team' => l(bts('Team', array(), NULL, 'boinc:account-finish'), '/community/teams', $options),
1882
-      ), NULL, 'boinc:account-finish'),
1883
-      'children' => array(
1882
+        ), NULL, 'boinc:account-finish'),
1883
+        'children' => array(
1884 1884
         bts('You may join a team, made up of other volunteers.', array(), NULL, 'boinc:account-finish'),
1885
-      ),
1885
+        ),
1886 1886
     ),
1887 1887
     array(
1888
-      'data' => bts('Go to your !account_dashboard.', array(
1888
+        'data' => bts('Go to your !account_dashboard.', array(
1889 1889
         '!account_dashboard'=> l(bts('Account Dashboard', array(), NULL, 'boinc:account-finish'), 'account/dashboard', $options),
1890
-      ), NULL, 'boinc:account-finish'),
1891
-      'children' => array(
1890
+        ), NULL, 'boinc:account-finish'),
1891
+        'children' => array(
1892 1892
         bts('Your account dashboard has information and links about your computer(s) and task(s) assigned.', array(), NULL, 'boinc:account-finish'),
1893
-      ),
1893
+        ),
1894 1894
     ),
1895 1895
     array(
1896
-      'data' => bts('Visit our !help pages.', array(
1896
+        'data' => bts('Visit our !help pages.', array(
1897 1897
         '!help' => l(bts('Help', array(), NULL, 'boinc:account-finish'), '/help', $options)
1898
-      ), NULL, 'boinc:account-finish'),
1899
-      'children' => array(
1898
+        ), NULL, 'boinc:account-finish'),
1899
+        'children' => array(
1900 1900
         bts('Ask for help in our community\'s !forums.', array(
1901
-          '!forums' => l(bts('forums', array(), NULL, 'boinc:account-finish'), 'community/forum', $options)
1901
+            '!forums' => l(bts('forums', array(), NULL, 'boinc:account-finish'), 'community/forum', $options)
1902 1902
         ), NULL, 'boinc:account-finish'),
1903
-      ),
1903
+        ),
1904 1904
     ),
1905
-  );
1905
+    );
1906 1906
 
1907
-  //List of links
1908
-  $output .= theme_item_list($links, $title = NULL, $type='ul');
1907
+    //List of links
1908
+    $output .= theme_item_list($links, $title = NULL, $type='ul');
1909 1909
 
1910
-  return $output;
1910
+    return $output;
1911 1911
 }
1912 1912
 
1913 1913
 /**
1914 1914
  * Determine if the user has permission to control community access
1915 1915
  */
1916 1916
 function boincuser_moderate_community_access() {
1917
-  if (user_access('assign community member role')
1917
+    if (user_access('assign community member role')
1918 1918
   OR user_access('assign all roles')) {
1919 1919
     return TRUE;
1920
-  }
1921
-  return FALSE;
1920
+    }
1921
+    return FALSE;
1922 1922
 }
1923 1923
 
1924 1924
 /**
1925 1925
  * Get the count of items in the moderation queue
1926 1926
  */
1927 1927
 function boincuser_moderation_queue_count($caller = 'user') {
1928
-  $allowed = FALSE;
1929
-  switch ($caller) {
1930
-  case 'cron':
1928
+    $allowed = FALSE;
1929
+    switch ($caller) {
1930
+    case 'cron':
1931 1931
     $allowed = TRUE;
1932 1932
     break;
1933
-  case 'user':
1933
+    case 'user':
1934 1934
   default:
1935 1935
     $allowed = user_access('edit any profile content');
1936
-  }
1937
-  if ($allowed) {
1936
+    }
1937
+    if ($allowed) {
1938 1938
     return db_result(db_query("
1939 1939
       SELECT COUNT(*)
1940 1940
       FROM {node}
1941 1941
       WHERE type = 'profile'
1942 1942
       AND moderate = 1"
1943 1943
     ));
1944
-  }
1945
-  return NULL;
1944
+    }
1945
+    return NULL;
1946 1946
 }
1947 1947
 
1948 1948
 /**
@@ -1951,43 +1951,43 @@  discard block
 block discarded – undo
1951 1951
  * than through the user account info form.
1952 1952
  */
1953 1953
 function boincuser_control($uid = NULL, $action = NULL) {
1954
-  if (!$uid OR !$account = user_load($uid)) {
1954
+    if (!$uid OR !$account = user_load($uid)) {
1955 1955
     // What are you even doing here...
1956 1956
     return FALSE;
1957
-  }
1958
-  switch ($action) {
1959
-  case 'ban':
1957
+    }
1958
+    switch ($action) {
1959
+    case 'ban':
1960 1960
     if (boincuser_moderate_community_access()) {
1961
-      $penalty_period = variable_get('boinc_penalty_period', 7*24*60*60);
1962
-      $boincuser_record = array(
1961
+        $penalty_period = variable_get('boinc_penalty_period', 7*24*60*60);
1962
+        $boincuser_record = array(
1963 1963
         'uid' => $uid,
1964 1964
         'penalty_expiration' => time() + $penalty_period,
1965
-      );
1966
-      drupal_write_record('boincuser', $boincuser_record, 'uid');
1967
-      $community_role = array_search('community member', user_roles(true));
1968
-      if (isset($account->roles[$community_role])) {
1965
+        );
1966
+        drupal_write_record('boincuser', $boincuser_record, 'uid');
1967
+        $community_role = array_search('community member', user_roles(true));
1968
+        if (isset($account->roles[$community_role])) {
1969 1969
         unset($account->roles[$community_role]);
1970 1970
         user_save($account, array('roles' => $account->roles));
1971
-      }
1971
+        }
1972 1972
     }
1973 1973
     break;
1974
-  case 'lift-ban':
1974
+    case 'lift-ban':
1975 1975
     if (boincuser_moderate_community_access()) {
1976
-      $boincuser_record = array(
1976
+        $boincuser_record = array(
1977 1977
         'uid' => $uid,
1978 1978
         'penalty_expiration' => 0,
1979
-      );
1980
-      drupal_write_record('boincuser', $boincuser_record, 'uid');
1981
-      $community_role = array_search('community member', user_roles(true));
1982
-      if (!isset($account->roles[$community_role])) {
1979
+        );
1980
+        drupal_write_record('boincuser', $boincuser_record, 'uid');
1981
+        $community_role = array_search('community member', user_roles(true));
1982
+        if (!isset($account->roles[$community_role])) {
1983 1983
         $account->roles[$community_role] = 'community member';
1984 1984
         user_save($account, array('roles' => $account->roles));
1985
-      }
1985
+        }
1986 1986
     }
1987 1987
     break;
1988
-  default:
1988
+    default:
1989 1989
   }
1990
-  drupal_goto("account/{$account->uid}");
1990
+    drupal_goto("account/{$account->uid}");
1991 1991
 }
1992 1992
 
1993 1993
 /**
@@ -1995,29 +1995,29 @@  discard block
 block discarded – undo
1995 1995
  * moderation flag.
1996 1996
  */
1997 1997
 function boincuser_moderate_profile_approve($account) {
1998
-  $node = new stdClass;
1999
-  $node->type = 'profile';
2000
-  $node->language = '';
2001
-  $nid = content_profile_profile_exists($node, $account->uid);
2002
-  $profile = node_load($nid);
2003
-  $profile->moderate = 0;
2004
-  $profile->status = 1;
2005
-  node_save($profile);
2006
-  drupal_set_message('This profile has been marked as approved.');
2007
-  drupal_goto();
1998
+    $node = new stdClass;
1999
+    $node->type = 'profile';
2000
+    $node->language = '';
2001
+    $nid = content_profile_profile_exists($node, $account->uid);
2002
+    $profile = node_load($nid);
2003
+    $profile->moderate = 0;
2004
+    $profile->status = 1;
2005
+    node_save($profile);
2006
+    drupal_set_message('This profile has been marked as approved.');
2007
+    drupal_goto();
2008 2008
 }
2009 2009
 
2010 2010
 /**
2011 2011
  * Mark a user profile as rejected and notify the user of the reason.
2012 2012
  */
2013 2013
 function boincuser_moderate_profile_reject($uid, $reason = '') {
2014
-  $account = user_load($uid);
2015
-  $node = new stdClass;
2016
-  $node->type = 'profile';
2017
-  $node->language = '';
2018
-  $nid = content_profile_profile_exists($node, $uid);
2019
-  $profile = node_load($nid);
2020
-  if ($profile->nid) {
2014
+    $account = user_load($uid);
2015
+    $node = new stdClass;
2016
+    $node->type = 'profile';
2017
+    $node->language = '';
2018
+    $nid = content_profile_profile_exists($node, $uid);
2019
+    $profile = node_load($nid);
2020
+    if ($profile->nid) {
2021 2021
     global $user;
2022 2022
     global $base_url;
2023 2023
     global $base_path;
@@ -2028,64 +2028,64 @@  discard block
 block discarded – undo
2028 2028
     $profile->status = 0;
2029 2029
     node_save($profile);
2030 2030
     $settings = array(
2031
-      'from' => '',
2032
-      'subject' => "Profile moderation at {$site_name}",
2033
-      'message' => ''
2034
-      . "{$account->boincuser_name},\n"
2035
-      . "\n"
2036
-      . "{$moderator->boincuser_name} has rejected your profile at"
2037
-      . " {$site_name} for the following reason: \n"
2038
-      . "\n"
2039
-      . "{$reason}\n"
2040
-      . "\n"
2041
-      . "\n"
2042
-      . "Since it has not been approved, your profile is not visible to other"
2043
-      . " {$site_name} users. Please make the needed changes here:\n"
2044
-      . "\n"
2045
-      . "{$site_url}account/profile \n"
2046
-      . "\n"
2047
-      . "Thanks, \n"
2048
-      . "\n"
2049
-      . "{$site_name} support team",
2031
+        'from' => '',
2032
+        'subject' => "Profile moderation at {$site_name}",
2033
+        'message' => ''
2034
+        . "{$account->boincuser_name},\n"
2035
+        . "\n"
2036
+        . "{$moderator->boincuser_name} has rejected your profile at"
2037
+        . " {$site_name} for the following reason: \n"
2038
+        . "\n"
2039
+        . "{$reason}\n"
2040
+        . "\n"
2041
+        . "\n"
2042
+        . "Since it has not been approved, your profile is not visible to other"
2043
+        . " {$site_name} users. Please make the needed changes here:\n"
2044
+        . "\n"
2045
+        . "{$site_url}account/profile \n"
2046
+        . "\n"
2047
+        . "Thanks, \n"
2048
+        . "\n"
2049
+        . "{$site_name} support team",
2050 2050
     );
2051 2051
     rules_action_mail_to_user($account, $settings);
2052 2052
     drupal_set_message('This profile has been marked as rejected.');
2053
-  }
2054
-  drupal_goto();
2053
+    }
2054
+    drupal_goto();
2055 2055
 }
2056 2056
 
2057 2057
 /**
2058 2058
  * Ban a user and send a notification of the reason.
2059 2059
  */
2060 2060
 function boincuser_moderate_user_ban($uid, $reason = '', $duration = '') {
2061
-  if (user_access('assign community member role')
2061
+    if (user_access('assign community member role')
2062 2062
   OR user_access('assign all roles')) {
2063 2063
     $account = user_load($uid);
2064 2064
     if ($account->uid) {
2065
-      module_load_include('inc', 'rules', 'modules/system.rules');
2066
-      if ($duration === '') {
2065
+        module_load_include('inc', 'rules', 'modules/system.rules');
2066
+        if ($duration === '') {
2067 2067
         $duration = variable_get('boinc_penalty_period', 7*24*60*60);
2068
-      }
2069
-      $penalty_expiration = ($duration > 0) ? time() + $duration : 4294967295;
2070
-      $boincuser_record = array(
2068
+        }
2069
+        $penalty_expiration = ($duration > 0) ? time() + $duration : 4294967295;
2070
+        $boincuser_record = array(
2071 2071
         'uid' => $uid,
2072 2072
         'penalty_expiration' => $penalty_expiration,
2073
-      );
2074
-      drupal_write_record('boincuser', $boincuser_record, 'uid');
2073
+        );
2074
+        drupal_write_record('boincuser', $boincuser_record, 'uid');
2075 2075
       
2076
-      $community_role = array_search('community member', user_roles(true));
2077
-      if (isset($account->roles[$community_role])) {
2076
+        $community_role = array_search('community member', user_roles(true));
2077
+        if (isset($account->roles[$community_role])) {
2078 2078
         unset($account->roles[$community_role]);
2079 2079
         user_save($account, array('roles' => $account->roles));
2080
-      }
2080
+        }
2081 2081
       
2082
-      global $user;
2083
-      global $base_url;
2084
-      global $base_path;
2085
-      $site_name = variable_get('site_name', 'Drupal-BOINC');
2086
-      $site_url = $base_url . $base_path;
2087
-      $moderator = user_load($user->uid);
2088
-      $settings = array(
2082
+        global $user;
2083
+        global $base_url;
2084
+        global $base_path;
2085
+        $site_name = variable_get('site_name', 'Drupal-BOINC');
2086
+        $site_url = $base_url . $base_path;
2087
+        $moderator = user_load($user->uid);
2088
+        $settings = array(
2089 2089
         'from' => '',
2090 2090
         'subject' => "User moderation at {$site_name}",
2091 2091
         'message' => ''
@@ -2106,12 +2106,12 @@  discard block
 block discarded – undo
2106 2106
         . "Thanks, \n"
2107 2107
         . "\n"
2108 2108
         . "{$site_name} support team",
2109
-      );
2110
-      rules_action_mail_to_user($account, $settings);
2111
-      drupal_set_message('This user has been banned.');
2109
+        );
2110
+        rules_action_mail_to_user($account, $settings);
2111
+        drupal_set_message('This user has been banned.');
2112 2112
     }
2113
-  }
2114
-  drupal_goto();
2113
+    }
2114
+    drupal_goto();
2115 2115
 }
2116 2116
 
2117 2117
 
@@ -2123,15 +2123,15 @@  discard block
 block discarded – undo
2123 2123
  *
2124 2124
  */
2125 2125
 function boincuser_get_weak_auth($boinc_id = null) {
2126
-  if (!$boinc_id) {
2126
+    if (!$boinc_id) {
2127 2127
     global $user;
2128 2128
     $account = user_load($user->uid);
2129 2129
     $boinc_id = $account->boincuser_id;
2130
-  }
2130
+    }
2131 2131
   
2132
-  $boinc_user = boincuser_load($account->boincuser_id);
2132
+    $boinc_user = boincuser_load($account->boincuser_id);
2133 2133
   
2134
-  return weak_auth($boinc_user);
2134
+    return weak_auth($boinc_user);
2135 2135
 }
2136 2136
 
2137 2137
 /**
@@ -2140,75 +2140,75 @@  discard block
 block discarded – undo
2140 2140
  * Drupal User so must be inserted into comments, etc. (not so by default)
2141 2141
  */
2142 2142
 function boincuser_get_user_profile_image($uid, $avatar = TRUE) {
2143
-  // Though the function name implies otherwise, get the avatar by default
2144
-  $image_field = ($avatar) ? 'field_image_fid' : 'field_profile_image_fid';
2145
-  $image_fid = db_result(db_query("
2143
+    // Though the function name implies otherwise, get the avatar by default
2144
+    $image_field = ($avatar) ? 'field_image_fid' : 'field_profile_image_fid';
2145
+    $image_fid = db_result(db_query("
2146 2146
     SELECT ctp.%s
2147 2147
     FROM {content_type_profile} ctp
2148 2148
     INNER JOIN {node} n ON ctp.nid = n.nid
2149 2149
     WHERE n.uid = %d AND n.type = '%s'",
2150 2150
     $image_field, $uid, 'profile'));
2151
-  $user_image['image'] = field_file_load($image_fid);
2152
-  if (!$user_image['image']['filepath']) {
2151
+    $user_image['image'] = field_file_load($image_fid);
2152
+    if (!$user_image['image']['filepath']) {
2153 2153
     // Load the default image if one does not exist
2154 2154
     $account = user_load($uid);
2155 2155
     if ($avatar AND module_exists('gravatar') AND user_access('use gravatar', $account) AND $account->gravatar) {
2156
-      // Use a Gravatar rather than the system default image
2157
-      $options = array(
2156
+        // Use a Gravatar rather than the system default image
2157
+        $options = array(
2158 2158
         'size' => 100,
2159 2159
         'rating' => 'G',
2160
-      );
2161
-      // Get the Gravatar URL and see if the image exists
2162
-      $url = gravatar_get_gravatar($account->mail, $options);
2163
-      $headers = @get_headers($url);
2164
-      if (preg_match("|200|", $headers[0])) {
2160
+        );
2161
+        // Get the Gravatar URL and see if the image exists
2162
+        $url = gravatar_get_gravatar($account->mail, $options);
2163
+        $headers = @get_headers($url);
2164
+        if (preg_match("|200|", $headers[0])) {
2165 2165
         return $url;
2166
-      }
2166
+        }
2167 2167
     }
2168 2168
     // Get default image if nothing else works
2169 2169
     $content_node_widget_settings = db_result(db_query("SELECT widget_settings FROM {content_node_field_instance} WHERE field_name = '%s'", ($avatar ? 'field_image' : 'field_profile_image')));
2170 2170
     $content_node_widget_settings = unserialize($content_node_widget_settings);
2171 2171
     $user_image['image'] = $content_node_widget_settings['default_image'];
2172
-  }
2173
-  $user = user_load($uid);
2174
-  // Use boinc username for image alt/title attributes
2175
-  $user_image['alt'] = $user->boincuser_name;
2176
-  return $user_image;
2172
+    }
2173
+    $user = user_load($uid);
2174
+    // Use boinc username for image alt/title attributes
2175
+    $user_image['alt'] = $user->boincuser_name;
2176
+    return $user_image;
2177 2177
 }
2178 2178
 
2179 2179
 /**
2180 2180
  * Generate a table of a user's projects
2181 2181
  */
2182 2182
 function boincuser_get_projects_table($account = null) {
2183
-  if ($account AND is_numeric($account)) {
2183
+    if ($account AND is_numeric($account)) {
2184 2184
     $account = user_load($account);
2185
-  }
2186
-  $projects = boincuser_get_projects($account);
2187
-  if (!$projects) return bts('no projects...', array(), NULL, 'boinc:account-dashboard');
2185
+    }
2186
+    $projects = boincuser_get_projects($account);
2187
+    if (!$projects) return bts('no projects...', array(), NULL, 'boinc:account-dashboard');
2188 2188
   
2189
-  $output = '';
2190
-  $output .= '<table class="user-projects">' . "\n";
2191
-  $output .= '<thead>' . "\n";
2192
-  $output .= '  <tr>' . "\n";
2193
-  $output .= '    <th>' . bts('Name', array(), NULL, 'boinc:project-name:-1:ignoreoverwrite') . '</th>' . "\n";
2194
-  $output .= '    <th class="numeric">' . bts('Avg credit', array(), NULL, 'boinc:account-dashboard') . '</th>' . "\n";
2195
-  $output .= '    <th class="numeric">' . bts('Total credit', array(), NULL, 'boinc:user-or-team-total-credits') . '</th>' . "\n";
2196
-  $output .= '  </tr>' . "\n";
2197
-  $output .= '</thead>' . "\n";
2198
-  $output .= '<tbody>' . "\n";
2199
-  foreach ($projects AS $project) {
2189
+    $output = '';
2190
+    $output .= '<table class="user-projects">' . "\n";
2191
+    $output .= '<thead>' . "\n";
2192
+    $output .= '  <tr>' . "\n";
2193
+    $output .= '    <th>' . bts('Name', array(), NULL, 'boinc:project-name:-1:ignoreoverwrite') . '</th>' . "\n";
2194
+    $output .= '    <th class="numeric">' . bts('Avg credit', array(), NULL, 'boinc:account-dashboard') . '</th>' . "\n";
2195
+    $output .= '    <th class="numeric">' . bts('Total credit', array(), NULL, 'boinc:user-or-team-total-credits') . '</th>' . "\n";
2196
+    $output .= '  </tr>' . "\n";
2197
+    $output .= '</thead>' . "\n";
2198
+    $output .= '<tbody>' . "\n";
2199
+    foreach ($projects AS $project) {
2200 2200
     $url = rtrim($project->url, '/') . '/show_user.php?userid=' . $project->id;
2201 2201
     $output .= '  <tr>' . "\n";
2202 2202
     $output .= '    <td>' . l($project->name, $url) . '</td>' . "\n";
2203 2203
     $output .= '    <td class="numeric">' . boincwork_format_stats((float) $project->expavg_credit) . '</td>' . "\n"; 
2204 2204
     $output .= '    <td class="numeric">' . boincwork_format_stats((float) $project->total_credit) . '</td>' . "\n";
2205 2205
     $output .= '  </tr>' . "\n";
2206
-  }
2207
-  $output .= '</tbody>' . "\n";
2208
-  $output .= '</table>' . "\n";
2209
-  $more_link = ($account) ? "user/{$account->uid}/stats" : 'account/stats';
2210
-  //$output .= "<div class=\"more-link\"><a href=\"{$more_link}\">More stats</a></div>" . "\n";
2211
-  return $output;
2206
+    }
2207
+    $output .= '</tbody>' . "\n";
2208
+    $output .= '</table>' . "\n";
2209
+    $more_link = ($account) ? "user/{$account->uid}/stats" : 'account/stats';
2210
+    //$output .= "<div class=\"more-link\"><a href=\"{$more_link}\">More stats</a></div>" . "\n";
2211
+    return $output;
2212 2212
 }
2213 2213
 
2214 2214
 /**
@@ -2216,25 +2216,25 @@  discard block
 block discarded – undo
2216 2216
  */
2217 2217
 function boincuser_get_stats_user_data($cpid = null) {
2218 2218
   
2219
-  // [TODO] Set this stuff in site config!
2220
-  $stats_server = 'stats.gridrepublic.org';
2221
-  $stats_rpc = 'rpc/get_user.php';
2219
+    // [TODO] Set this stuff in site config!
2220
+    $stats_server = 'stats.gridrepublic.org';
2221
+    $stats_rpc = 'rpc/get_user.php';
2222 2222
   
2223
-  // Construct query string
2224
-  $get = array(
2223
+    // Construct query string
2224
+    $get = array(
2225 2225
     'cpid' => $cpid
2226
-  );
2227
-  $args = array();
2228
-  foreach ($get as $arg => $value) $args[] = "{$arg}=" . rawurlencode($value);
2229
-  $query = '?' . implode('&', $args);
2226
+    );
2227
+    $args = array();
2228
+    foreach ($get as $arg => $value) $args[] = "{$arg}=" . rawurlencode($value);
2229
+    $query = '?' . implode('&', $args);
2230 2230
   
2231
-  // Load XML from RPC
2232
-  $target_url = "http://{$stats_server}/{$stats_rpc}{$query}";
2233
-  $result = drupal_http_request($target_url);
2234
-  if (in_array($result->code, array(200, 304))) {
2231
+    // Load XML from RPC
2232
+    $target_url = "http://{$stats_server}/{$stats_rpc}{$query}";
2233
+    $result = drupal_http_request($target_url);
2234
+    if (in_array($result->code, array(200, 304))) {
2235 2235
     return simplexml_load_string($result->data);
2236
-  }
2237
-  return NULL;
2236
+    }
2237
+    return NULL;
2238 2238
 }
2239 2239
 
2240 2240
 /**
@@ -2242,15 +2242,15 @@  discard block
 block discarded – undo
2242 2242
  */
2243 2243
 function boincuser_get_projects($account = null) {
2244 2244
   
2245
-  // Use the current user by default
2246
-  if (!$account) {
2245
+    // Use the current user by default
2246
+    if (!$account) {
2247 2247
     global $user;
2248 2248
     $account = user_load($user->uid);
2249
-  }
2249
+    }
2250 2250
   
2251
-  $account_stats = boincuser_get_stats_user_data($account->boincuser_cpid);
2251
+    $account_stats = boincuser_get_stats_user_data($account->boincuser_cpid);
2252 2252
   
2253
-  return ($account_stats AND isset($account_stats->project)) ? $account_stats->project : null;
2253
+    return ($account_stats AND isset($account_stats->project)) ? $account_stats->project : null;
2254 2254
 }
2255 2255
 
2256 2256
 
@@ -2258,11 +2258,11 @@  discard block
 block discarded – undo
2258 2258
  * Get the links to display under the user profile
2259 2259
  */
2260 2260
 function boincuser_get_profile_links($uid) {
2261
-  global $user;
2262
-  $account = user_load($uid);
2263
-  $profile = content_profile_load('profile', $account->uid);
2264
-  $output = '';
2265
-  if ($profile) {
2261
+    global $user;
2262
+    $account = user_load($uid);
2263
+    $profile = content_profile_load('profile', $account->uid);
2264
+    $output = '';
2265
+    if ($profile) {
2266 2266
     $profile_is_approved = ($profile->status AND !$profile->moderate);
2267 2267
     $user_is_moderator = user_access('edit any profile content');
2268 2268
     $is_own_profile = ($user->uid == $account->uid);
@@ -2270,15 +2270,15 @@  discard block
 block discarded – undo
2270 2270
     $links = array();
2271 2271
     
2272 2272
     if ($profile->moderate AND $user_is_moderator) {
2273
-      $links['approve_profile'] = array(
2273
+        $links['approve_profile'] = array(
2274 2274
         'title' => bts('Approve profile', array(), NULL, 'boinc:moderate-user'),
2275 2275
         'href' => "{$profile_moderation_path}/approve",
2276 2276
         'attributes' => array(
2277
-          'title' => bts('Approve this profile content', array(), NULL, 'boinc:moderate-user'),
2278
-          'class' => 'first primary tab',
2277
+            'title' => bts('Approve this profile content', array(), NULL, 'boinc:moderate-user'),
2278
+            'class' => 'first primary tab',
2279 2279
         )
2280
-      );
2281
-      /*$links['edit_profile'] = array(
2280
+        );
2281
+        /*$links['edit_profile'] = array(
2282 2282
         'title' => bts('Edit profile', array(), NULL, 'boinc:moderate-user'),
2283 2283
         'href' => "{$profile_moderation_path}/edit",
2284 2284
         'attributes' => array(
@@ -2286,27 +2286,27 @@  discard block
 block discarded – undo
2286 2286
           'class' => 'tab',
2287 2287
         )
2288 2288
       );*/
2289
-      $links['reject_profile'] = array(
2289
+        $links['reject_profile'] = array(
2290 2290
         'title' => bts('Reject profile', array(), NULL, 'boinc:moderate-user'),
2291 2291
         'href' => "{$profile_moderation_path}/reject",
2292 2292
         'attributes' => array(
2293
-          'title' => bts('Reject this profile content', array(), NULL, 'boinc:moderate-user'),
2294
-          'class' => 'tab',
2293
+            'title' => bts('Reject this profile content', array(), NULL, 'boinc:moderate-user'),
2294
+            'class' => 'tab',
2295 2295
         )
2296
-      );
2296
+        );
2297 2297
     }
2298 2298
     $output .= '<ul class="tab-list">';
2299 2299
     $count = 0;
2300 2300
     foreach ($links as $key => $link) {
2301
-      $output .= '<li class="' . (($count == 0) ? 'first primary ' : '') . 'tab">';
2302
-      $output .= l($link['title'], $link['href'], array('query' => drupal_get_destination()));
2303
-      $output .= '</li>';
2304
-      $count++;
2301
+        $output .= '<li class="' . (($count == 0) ? 'first primary ' : '') . 'tab">';
2302
+        $output .= l($link['title'], $link['href'], array('query' => drupal_get_destination()));
2303
+        $output .= '</li>';
2304
+        $count++;
2305 2305
     }
2306 2306
     $output .= '<li class="' . (($count) ? '' : 'first ') . 'last tab">' . flag_create_link('abuse_user', $account->uid) . '</li>';
2307 2307
     $output .= '</ul>';
2308
-  }
2309
-  return $output;
2308
+    }
2309
+    return $output;
2310 2310
 /*
2311 2311
 <ul class="tab-list">
2312 2312
   <li class="primary first tab">
@@ -2343,36 +2343,36 @@  discard block
 block discarded – undo
2343 2343
  */
2344 2344
 function boincuser_apachesolr_index_documents_alter(array &$documents, $entity, $entity_type, $env_id) {
2345 2345
 
2346
-  foreach ($documents as $document) {
2346
+    foreach ($documents as $document) {
2347 2347
     if ( $document->entity_type=='node' AND $document->bundle=='profile' ) {
2348
-      // Node information.
2349
-      $nid = $document->entity_id;
2350
-      $node = node_load($nid);
2351
-      $account = user_load($node->uid);
2352
-
2353
-      // Use boincuser name and not drupal user name
2354
-      $document->label = apachesolr_clean_text($account->boincuser_name);
2355
-      // Author information
2356
-      if ($node->uid == 0 || strlen($node->name) == 0) {
2348
+        // Node information.
2349
+        $nid = $document->entity_id;
2350
+        $node = node_load($nid);
2351
+        $account = user_load($node->uid);
2352
+
2353
+        // Use boincuser name and not drupal user name
2354
+        $document->label = apachesolr_clean_text($account->boincuser_name);
2355
+        // Author information
2356
+        if ($node->uid == 0 || strlen($node->name) == 0) {
2357 2357
         // @see user_validate_name(). !'0' === TRUE.
2358 2358
         $document->ss_name = '0';
2359
-      }
2360
-      else {
2359
+        }
2360
+        else {
2361 2361
         $document->ss_name = $account->boincuser_name;
2362 2362
         // We want the name to be searchable for keywords.
2363 2363
         $document->tos_name = $account->boincuser_name;
2364
-      }
2364
+        }
2365 2365
 
2366
-      // Rename "Profle" to "User"
2367
-      $document->bundle = "User";
2368
-      $document->bundle_name = "User";
2366
+        // Rename "Profle" to "User"
2367
+        $document->bundle = "User";
2368
+        $document->bundle_name = "User";
2369 2369
 
2370
-      // Replace the Solr document's created field with the date the user 
2371
-      // account was created. This replaces the node creation date typically 
2372
-      // used for indexing nodes.
2373
-      $document->ds_created = apachesolr_date_iso($account->created);
2370
+        // Replace the Solr document's created field with the date the user 
2371
+        // account was created. This replaces the node creation date typically 
2372
+        // used for indexing nodes.
2373
+        $document->ds_created = apachesolr_date_iso($account->created);
2374
+    }
2374 2375
     }
2375
-  }
2376 2376
 
2377 2377
 }
2378 2378
 
@@ -2384,23 +2384,23 @@  discard block
 block discarded – undo
2384 2384
  * Implementation of hook_privatemsg_name_lookup();
2385 2385
  */
2386 2386
 function boincuser_privatemsg_name_lookup($string) {
2387
-  // Get the BOINC ID from the name string, and lookup the
2388
-  // corresponding drupal user.
2389
-  $boincname = substr($string, 0, strrpos($string, '_'));
2390
-  $boincid = substr($string, strrpos($string, '_') + 1);
2391
-  $drupalid = get_drupal_id($boincid);
2392
-
2393
-  // Name has spaced replaced with special UTF-8 characters in
2394
-  // privatemsg module. We need to convert them back to spaces for the
2395
-  // check below.
2396
-  $boincname = preg_replace("/\\xc2\\xa0/", " ", $boincname);
2397
-  if ($drupalid>0) {
2387
+    // Get the BOINC ID from the name string, and lookup the
2388
+    // corresponding drupal user.
2389
+    $boincname = substr($string, 0, strrpos($string, '_'));
2390
+    $boincid = substr($string, strrpos($string, '_') + 1);
2391
+    $drupalid = get_drupal_id($boincid);
2392
+
2393
+    // Name has spaced replaced with special UTF-8 characters in
2394
+    // privatemsg module. We need to convert them back to spaces for the
2395
+    // check below.
2396
+    $boincname = preg_replace("/\\xc2\\xa0/", " ", $boincname);
2397
+    if ($drupalid>0) {
2398 2398
     if ($recipient = user_load(array('uid' => $drupalid))) {
2399
-      // Double-check that the loaded user matches both boincuser_id
2400
-      // and boincuser_name.
2401
-      if ( ($boincid == $recipient->boincuser_id) AND ($boincname == $recipient->boincuser_name) ) {
2399
+        // Double-check that the loaded user matches both boincuser_id
2400
+        // and boincuser_name.
2401
+        if ( ($boincid == $recipient->boincuser_id) AND ($boincname == $recipient->boincuser_name) ) {
2402 2402
         return $recipient;
2403
-      }
2403
+        }
2404
+    }
2404 2405
     }
2405
-  }
2406 2406
 }
Please login to merge, or discard this patch.
Spacing   +120 added lines, -120 removed lines patch added patch discarded remove patch
@@ -189,7 +189,7 @@  discard block
 block discarded – undo
189 189
     'type' => MENU_CALLBACK
190 190
   );
191 191
   $items['account_finish.php'] = array(
192
-    'title' => 'Welcome to ' . variable_get('site_name', 'Drupal-BOINC'),
192
+    'title' => 'Welcome to '.variable_get('site_name', 'Drupal-BOINC'),
193 193
     'description' => 'RPC for after a user has created an account.',
194 194
     'page callback' => 'boincuser_account_finish',
195 195
     'access callback' => TRUE,
@@ -249,8 +249,8 @@  discard block
 block discarded – undo
249 249
   // termsofuse is enabled, by having text in the termsofuse variable.
250 250
   $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
251 251
   $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
252
-  if ( (!empty($termsofuse)) and ($user->uid) ) {
253
-    if ( !boincuser_check_termsofuse($user) and ($existinguser_tou) ) {
252
+  if ((!empty($termsofuse)) and ($user->uid)) {
253
+    if (!boincuser_check_termsofuse($user) and ($existinguser_tou)) {
254 254
 
255 255
       // Admins are exempt, otherwise the admin may not be able to
256 256
       // access the site!
@@ -264,14 +264,14 @@  discard block
 block discarded – undo
264 264
           'user/termsofuse',
265 265
           'logout',
266 266
           'account/info/edit',
267
-          'user/' . $user->uid . '/edit',
268
-          'user/' . $user->uid . '/recoveremail/*',
267
+          'user/'.$user->uid.'/edit',
268
+          'user/'.$user->uid.'/recoveremail/*',
269 269
           'recover_email.php',
270 270
         );
271 271
         if (module_exists('boincuser_delete')) {
272
-          $paths0[] = 'user/' . $user->uid . '/delete';
273
-          $paths0[] = 'user/' . $user->uid . '/deleteconfirm/*';
274
-          $paths0[] = 'user/' . $user->uid . '/odeleteconfirm/*';
272
+          $paths0[] = 'user/'.$user->uid.'/delete';
273
+          $paths0[] = 'user/'.$user->uid.'/deleteconfirm/*';
274
+          $paths0[] = 'user/'.$user->uid.'/odeleteconfirm/*';
275 275
         }
276 276
 
277 277
         // Paths added by the admin
@@ -282,7 +282,7 @@  discard block
 block discarded – undo
282 282
         }
283 283
 
284 284
         // paths to ignore
285
-        $paths_to_ignore = array_unique( array_merge($paths0, $paths2) );
285
+        $paths_to_ignore = array_unique(array_merge($paths0, $paths2));
286 286
 
287 287
         if (!_boincuser_ignore_paths($path, $paths_to_ignore)) {
288 288
           drupal_goto('user/termsofuse');
@@ -304,7 +304,7 @@  discard block
 block discarded – undo
304 304
   require_boinc('password_compat/password');
305 305
   // Handle BOINC integration for users with UID > 1 (skip anonymous and admin)
306 306
   if (isset($account->uid) && ($account->uid > 1)) {
307
-    switch($op) {
307
+    switch ($op) {
308 308
     case 'load':
309 309
       // User loading; insert BOINC data into the user object
310 310
       $drupal_user = db_fetch_object(db_query("
@@ -334,11 +334,11 @@  discard block
 block discarded – undo
334 334
       ));
335 335
       $account->boincuser_name = $boinc_user->name;
336 336
       $account->boincuser_account_key = $boinc_user->authenticator;
337
-      $account->boincuser_weak_auth = md5($boinc_user->authenticator . $boinc_user->passwd_hash);
337
+      $account->boincuser_weak_auth = md5($boinc_user->authenticator.$boinc_user->passwd_hash);
338 338
       $account->boincuser_total_credit = round($boinc_user->total_credit);
339 339
       $account->boincuser_expavg_credit = round($boinc_user->expavg_credit);
340 340
       $account->boincuser_expavg_time = round($boinc_user->expavg_time);
341
-      $account->boincuser_cpid = md5($boinc_user->cross_project_id . $account->mail);
341
+      $account->boincuser_cpid = md5($boinc_user->cross_project_id.$account->mail);
342 342
       $account->boincuser_default_pref_set = $boinc_user->venue;
343 343
       $account->boincteam_id = $boinc_user->teamid;
344 344
       $account->boincuser_previous_email_addr = $boinc_user->previous_email_addr;
@@ -507,7 +507,7 @@  discard block
 block discarded – undo
507 507
 
508 508
             // Set password hash appropriately
509 509
             $passwd = ($edit['pass']) ? $edit['pass'] : $edit['current_pass'];
510
-            $passwd_hash = password_hash( md5($passwd.$lower_email_addr), PASSWORD_DEFAULT );
510
+            $passwd_hash = password_hash(md5($passwd.$lower_email_addr), PASSWORD_DEFAULT);
511 511
             // Algorithm for changing email and/or password
512 512
             if ($changing_email) {
513 513
               // locally store current email to set as previous email
@@ -594,8 +594,8 @@  discard block
 block discarded – undo
594 594
   }
595 595
 
596 596
   // Check if user has agreed to terms of use.
597
-  if ( (!empty($termsofuse)) and ($account->uid) and 
598
-       (!boincuser_check_termsofuse($account)) and ($existinguser_tou) ) {
597
+  if ((!empty($termsofuse)) and ($account->uid) and 
598
+       (!boincuser_check_termsofuse($account)) and ($existinguser_tou)) {
599 599
 
600 600
     // Admins are exempted.
601 601
     $administrator_role = array_search('administrator', user_roles(true));
@@ -609,9 +609,9 @@  discard block
 block discarded – undo
609 609
       $query_for_destination = '';
610 610
       $prevdest = $_REQUEST['destination'];
611 611
       if ($prevdest) {
612
-        $query_for_destination = '?destination=' . $prevdest;
612
+        $query_for_destination = '?destination='.$prevdest;
613 613
       }
614
-      $_REQUEST['destination'] = $path_for_destination . $query_for_destination;
614
+      $_REQUEST['destination'] = $path_for_destination.$query_for_destination;
615 615
 
616 616
     }
617 617
   }
@@ -644,7 +644,7 @@  discard block
 block discarded – undo
644 644
   // In Drupal 7, these operation cases will all exist as their own hooks,
645 645
   // so let's approximate that here so that this function can simply be removed
646 646
   // upon migration to 7
647
-  switch($op) {
647
+  switch ($op) {
648 648
   case 'update':
649 649
     boincuser_node_update($node);
650 650
   }
@@ -655,7 +655,7 @@  discard block
 block discarded – undo
655 655
  * is updated (forward compatible to Drupal 7)
656 656
  */
657 657
 function boincuser_node_update($node) {
658
-  switch($node->type) {
658
+  switch ($node->type) {
659 659
   case 'profile':
660 660
     // Update the BOINC database directly
661 661
     $account = user_load($node->uid);
@@ -777,7 +777,7 @@  discard block
 block discarded – undo
777 777
     }
778 778
     
779 779
     $form['cancel'] = array(
780
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $cancel_dest) . '</li>',
780
+      '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $cancel_dest).'</li>',
781 781
       '#weight' => 1004,
782 782
     );
783 783
     $form['form control tabs suffix'] = array(
@@ -810,7 +810,7 @@  discard block
 block discarded – undo
810 810
     $form['buttons']['preview_changes']['#suffix'] = '</li>';
811 811
     $form['buttons']['preview_changes']['#weight'] = 1004;
812 812
     $form['buttons']['cancel'] = array(
813
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
813
+      '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}").'</li>',
814 814
       '#weight' => 1005,
815 815
     );
816 816
     $form['buttons']['delete']['#prefix'] = '<li class="tab">';
@@ -842,7 +842,7 @@  discard block
 block discarded – undo
842 842
     $form['actions']['submit']['#suffix'] = '</li>';
843 843
     $form['actions']['submit']['#weight'] = 1002;
844 844
     $form['actions']['cancel'] = array(
845
-        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
845
+        '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}").'</li>',
846 846
       '#weight' => 1005,
847 847
     );
848 848
     $form['actions']['form control tabs suffix'] = array(
@@ -869,7 +869,7 @@  discard block
 block discarded – undo
869 869
     $form['privatemsg']['preview']['#suffix'] = '</li>';
870 870
     $form['privatemsg']['preview']['#weight'] = 1003;
871 871
     $form['privatemsg']['cancel'] = array(
872
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
872
+      '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']).'</li>',
873 873
       '#weight' => 1004,
874 874
     );
875 875
     $form['privatemsg']['form control tabs suffix'] = array(
@@ -957,11 +957,11 @@  discard block
 block discarded – undo
957 957
     // Set special message if user has not agreed to TOU
958 958
     $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
959 959
     $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
960
-    if ( (!boincuser_check_termsofuse($account)) and ($existinguser_tou) and (!empty($termsofuse)) and (!user_access('administer users')) ) {
960
+    if ((!boincuser_check_termsofuse($account)) and ($existinguser_tou) and (!empty($termsofuse)) and (!user_access('administer users'))) {
961 961
       drupal_set_message(
962 962
         bts('INFO: You have not agreed to the terms of use for @project. You may use this form to change your email address and/or password. Please note: you may not delete your account within seven (7) days of changing your email address.',
963 963
         array(
964
-          '@project' => variable_get('site_name','Drupal-BOINC'),
964
+          '@project' => variable_get('site_name', 'Drupal-BOINC'),
965 965
         ), NULL, 'boinc:account-credentials-change')
966 966
       , 'info');
967 967
     }
@@ -1026,36 +1026,36 @@  discard block
 block discarded – undo
1026 1026
     $form['account']['boincuser_id'] = array(
1027 1027
       '#value' => '
1028 1028
         <div class="form-item">
1029
-          <label>' . bts('BOINC user ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1030
-          <span>' . $account->boincuser_id . '</span>
1029
+          <label>' . bts('BOINC user ID', array(), NULL, 'boinc:account-credentials-change').'</label>
1030
+          <span>' . $account->boincuser_id.'</span>
1031 1031
         </div>',
1032 1032
     );
1033 1033
     $form['account']['user_id'] = array(
1034 1034
       '#value' => '
1035 1035
         <div class="form-item">
1036
-          <label>' . bts('Drupal user ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1037
-          <span>' . $account->uid . '</span>
1036
+          <label>' . bts('Drupal user ID', array(), NULL, 'boinc:account-credentials-change').'</label>
1037
+          <span>' . $account->uid.'</span>
1038 1038
         </div>',
1039 1039
     );
1040 1040
     $form['account']['account_key'] = array(
1041 1041
       '#value' => '
1042 1042
         <div class="form-item">
1043
-          <label>' . bts('Account key', array(), NULL, 'boinc:account-credentials-change') . '</label>
1044
-          <span>' . $account->boincuser_account_key . '</span>
1043
+          <label>' . bts('Account key', array(), NULL, 'boinc:account-credentials-change').'</label>
1044
+          <span>' . $account->boincuser_account_key.'</span>
1045 1045
         </div>',
1046 1046
     );
1047 1047
     $form['account']['weak_account_key'] = array(
1048 1048
       '#value' => '
1049 1049
         <div class="form-item">
1050
-          <label>' . bts('Weak account key', array(), NULL, 'boinc:account-credentials-change') . '</label>
1051
-          <span>' . "{$account->boincuser_id}_{$account->boincuser_weak_auth}" . '</span>
1050
+          <label>' . bts('Weak account key', array(), NULL, 'boinc:account-credentials-change').'</label>
1051
+          <span>' . "{$account->boincuser_id}_{$account->boincuser_weak_auth}".'</span>
1052 1052
         </div>',
1053 1053
     );
1054 1054
     $form['account']['cpid'] = array(
1055 1055
       '#value' => '
1056 1056
         <div class="form-item">
1057
-          <label>' . bts('Cross-project ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1058
-          <span>' . $account->boincuser_cpid . '</span>
1057
+          <label>' . bts('Cross-project ID', array(), NULL, 'boinc:account-credentials-change').'</label>
1058
+          <span>' . $account->boincuser_cpid.'</span>
1059 1059
         </div>',
1060 1060
     );
1061 1061
     
@@ -1073,7 +1073,7 @@  discard block
 block discarded – undo
1073 1073
     $form['submit']['#suffix'] = '</li>';
1074 1074
     $form['submit']['#weight'] = 1002;
1075 1075
     $form['cancel'] = array(
1076
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1076
+      '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']).'</li>',
1077 1077
       '#weight' => 1003,
1078 1078
     );
1079 1079
     if (isset($form['delete']) AND is_array($form['delete'])) {
@@ -1169,7 +1169,7 @@  discard block
 block discarded – undo
1169 1169
     $form['buttons']['preview_changes']['#suffix'] = '</li>';
1170 1170
     $form['buttons']['preview_changes']['#weight'] = 1004;
1171 1171
     $form['buttons']['cancel'] = array(
1172
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1172
+      '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']).'</li>',
1173 1173
       '#weight' => 1005,
1174 1174
     );
1175 1175
     $form['buttons']['delete']['#prefix'] = '<li class="tab">';
@@ -1218,11 +1218,11 @@  discard block
 block discarded – undo
1218 1218
     // Set name temporarily to dummy value to beat validation
1219 1219
     $form['name'] = array(
1220 1220
       '#type' => 'hidden',
1221
-      '#value' => rand() . '.' . time()
1221
+      '#value' => rand().'.'.time()
1222 1222
     );
1223 1223
 
1224 1224
     // Add JS for submit button disabling
1225
-    drupal_add_js(drupal_get_path('module', 'boincuser') . '/boincuser.js');
1225
+    drupal_add_js(drupal_get_path('module', 'boincuser').'/boincuser.js');
1226 1226
 
1227 1227
     // Terms of use section
1228 1228
     $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
@@ -1238,7 +1238,7 @@  discard block
 block discarded – undo
1238 1238
 
1239 1239
       $form['termsofuse']['title1'] = array(
1240 1240
         '#weight' => -12,
1241
-        '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), NULL, 'project:user-register' ) . '</h2>',
1241
+        '#value' => '<h2>'.bts(variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), NULL, 'project:user-register').'</h2>',
1242 1242
         '#prefix' => '<div id="register-title1">',
1243 1243
         '#suffix' => '</div>',
1244 1244
       );
@@ -1261,7 +1261,7 @@  discard block
 block discarded – undo
1261 1261
 
1262 1262
     $form['title2'] = array(
1263 1263
       '#weight' => -6,
1264
-      '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle2', 'Fill in your name, email, and choose a secure passphrase.'), array(), NULL, 'project:user-register') . '</h2>',
1264
+      '#value' => '<h2>'.bts(variable_get('boinc_weboptions_registrationtitle2', 'Fill in your name, email, and choose a secure passphrase.'), array(), NULL, 'project:user-register').'</h2>',
1265 1265
       '#prefix' => '<div id="register-title2">',
1266 1266
       '#suffix' => '</div>',
1267 1267
     );
@@ -1315,7 +1315,7 @@  discard block
 block discarded – undo
1315 1315
     $form['buttons']['submit']['#suffix'] = '</li>';
1316 1316
     $form['buttons']['submit']['#weight'] = 1002;
1317 1317
     $form['buttons']['cancel'] = array(
1318
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/login') . '</li>',
1318
+      '#value' => '<li class="tab">'.l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/login').'</li>',
1319 1319
       '#weight' => 1005,
1320 1320
     );
1321 1321
     $form['buttons']['form control tabs suffix'] = array(
@@ -1397,7 +1397,7 @@  discard block
 block discarded – undo
1397 1397
  */
1398 1398
 function boincuser_token_list($type = 'all') {
1399 1399
   if ($type == 'user' || $type == 'all') {
1400
-    $tokens['user']['display-name']      = t("The user's name that should be displayed");
1400
+    $tokens['user']['display-name'] = t("The user's name that should be displayed");
1401 1401
     return $tokens;
1402 1402
   }
1403 1403
 }
@@ -1409,9 +1409,9 @@  discard block
 block discarded – undo
1409 1409
   if ($view->args) {
1410 1410
     $account_id = $view->args[0];
1411 1411
   }
1412
-  if ($view->name=="user_activity") {
1412
+  if ($view->name == "user_activity") {
1413 1413
     // Run the following custom query for the user_activity view
1414
-    $view->build_info['query']= "
1414
+    $view->build_info['query'] = "
1415 1415
       SELECT node_revisions.vid AS vid,
1416 1416
         node.nid AS node_nid,
1417 1417
         node.uid AS users_node_uid,
@@ -1451,13 +1451,13 @@  discard block
 block discarded – undo
1451 1451
   // Delete expired users in the BOINC database, user_delete table.
1452 1452
   require_boinc('boinc_db');
1453 1453
   $num_deleted = BoincUserDeleted::delete_expired();
1454
-  if ($num_deleted>0) {
1454
+  if ($num_deleted > 0) {
1455 1455
     watchdog('boincuser', "Deleted ${num_deleted} users from user_deleted table", WATCHDOG_NOTICE);
1456 1456
   }
1457 1457
 
1458 1458
   // Delete expired tokens from token table
1459 1459
   $tokens_deleted = BoincToken::delete_expired();
1460
-  if ($tokens_deleted>0) {
1460
+  if ($tokens_deleted > 0) {
1461 1461
     watchdog('boincuser', "Deleted ${tokens_deleted} tokens from token table", WATCHDOG_NOTICE);
1462 1462
   }
1463 1463
 }
@@ -1542,38 +1542,38 @@  discard block
 block discarded – undo
1542 1542
   case 'boinc':
1543 1543
     $output .= '<ol>';
1544 1544
     if ($registration_enabled) {
1545
-      $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1545
+      $output .= '<li>'.bts('First !create_an_account here at @sitename.',
1546 1546
       array(
1547 1547
         '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'),
1548 1548
         '@sitename' => $site_name,
1549
-      ), NULL, 'boinc:join-page') . '</li>';
1549
+      ), NULL, 'boinc:join-page').'</li>';
1550 1550
     }
1551
-    $output .= '  <li>' . bts("Install BOINC on this device if not already present.", array(), NULL, 'boinc:join-page') . '</li>';
1552
-    $output .= '  <li>' . bts("Select <i>Tools / Add Project</i>. Choose @sitename from the list, or enter @siteurl.",
1551
+    $output .= '  <li>'.bts("Install BOINC on this device if not already present.", array(), NULL, 'boinc:join-page').'</li>';
1552
+    $output .= '  <li>'.bts("Select <i>Tools / Add Project</i>. Choose @sitename from the list, or enter @siteurl.",
1553 1553
     array(
1554 1554
       '@sitename' => $site_name,
1555 1555
       '@siteurl' => $base_url,
1556
-    ), NULL, 'boinc:join-page') . '</li>';
1556
+    ), NULL, 'boinc:join-page').'</li>';
1557 1557
     if ($registration_enabled) {
1558
-      $output .= '<li>' . bts("If you're running a command-line or pre-5.0 version of BOINC, use <b>!boinccmd</b> to add the project.",
1558
+      $output .= '<li>'.bts("If you're running a command-line or pre-5.0 version of BOINC, use <b>!boinccmd</b> to add the project.",
1559 1559
         array(
1560 1560
           '!boinccmd' => l('boinccmd --project_attach', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1561
-        ), NULL, 'boinc:join-page') . '</li>';
1561
+        ), NULL, 'boinc:join-page').'</li>';
1562 1562
     }
1563 1563
     else {
1564
-      $output .= '<li>' . bts("If you're running a command-line version of BOINC,
1564
+      $output .= '<li>'.bts("If you're running a command-line version of BOINC,
1565 1565
         please follow the <b>!instructionslink</b> to first <i>create an account</i>, and then <i>attach</i> to this project. Use the same project URL as above.",
1566 1566
         array(
1567 1567
           '!instructionslink' => l('instructions', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1568
-        ), NULL, 'boinc:join-page') . '</li>';
1568
+        ), NULL, 'boinc:join-page').'</li>';
1569 1569
     }
1570
-    $output .= '<li>' . bts("If you're running a pre-5.0 version of BOINC, please
1570
+    $output .= '<li>'.bts("If you're running a pre-5.0 version of BOINC, please
1571 1571
       upgrade to a more recent version of BOINC to create an account
1572 1572
       at @this_project.",
1573 1573
       array(
1574 1574
         '@this_project' => $site_name,
1575
-      ), NULL, 'boinc:join-page') . '</li>';
1576
-    $output .=  '</ol>';
1575
+      ), NULL, 'boinc:join-page').'</li>';
1576
+    $output .= '</ol>';
1577 1577
     break;
1578 1578
   case 'new':
1579 1579
   default:
@@ -1585,34 +1585,34 @@  discard block
 block discarded – undo
1585 1585
     //  $ruleslink = drupal_lookup_path('source', $ruleslinkB);
1586 1586
     //}
1587 1587
 
1588
-    $ruleslink = drupal_lookup_path('source', variable_get('boinc_weboptions_rulespolicies', '') );
1588
+    $ruleslink = drupal_lookup_path('source', variable_get('boinc_weboptions_rulespolicies', ''));
1589 1589
 
1590 1590
     // Join page output
1591 1591
     $output .= '<ol>';
1592 1592
     if ($registration_enabled) {
1593
-      $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1593
+      $output .= '<li>'.bts('First !create_an_account here at @sitename.',
1594 1594
       array(
1595 1595
         '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'),
1596 1596
         '@sitename' => $site_name,
1597
-      ), NULL, 'boinc:join-page') . '</li>';
1597
+      ), NULL, 'boinc:join-page').'</li>';
1598 1598
     }
1599
-    else if ( menu_valid_path(array('link_path' => $ruleslink)) ) {
1600
-      $output .= '  <li>' . bts("Read our !rules_and_policies.", array(
1599
+    else if (menu_valid_path(array('link_path' => $ruleslink))) {
1600
+      $output .= '  <li>'.bts("Read our !rules_and_policies.", array(
1601 1601
         '!rules_and_policies' => l(bts('Rules and Policies', array(), NULL, 'boinc:join-page'), $ruleslink),
1602
-      ), NULL, 'boinc:join-page') . '</li>';
1602
+      ), NULL, 'boinc:join-page').'</li>';
1603 1603
     }
1604
-    $output .= '  <li>' . bts('Download the BOINC desktop software.', array(), NULL, 'boinc:join-page');
1604
+    $output .= '  <li>'.bts('Download the BOINC desktop software.', array(), NULL, 'boinc:join-page');
1605 1605
     $output .= '    <p>';
1606 1606
     $output .= '      <a class="button" href="http://boinc.berkeley.edu/download.php">Download</a>';
1607 1607
     $output .= '    </p>';
1608
-    $output .= '    ' . bts("For Android devices, download BOINC from the Google Play Store or Amazon App Store.", array(), NULL, 'boinc:join-page');
1608
+    $output .= '    '.bts("For Android devices, download BOINC from the Google Play Store or Amazon App Store.", array(), NULL, 'boinc:join-page');
1609 1609
     $output .= '  </li>';
1610
-    $output .= '  <li>' . bts('Run the installer.', array(), NULL, 'boinc:join-page') . '</li>';
1611
-    $output .= '  <li>' . bts('Choose @sitename from the list, or enter @siteurl.', array(
1610
+    $output .= '  <li>'.bts('Run the installer.', array(), NULL, 'boinc:join-page').'</li>';
1611
+    $output .= '  <li>'.bts('Choose @sitename from the list, or enter @siteurl.', array(
1612 1612
       '@sitename' => $site_name,
1613 1613
       '@siteurl' => $base_url,
1614
-    ), NULL, 'boinc:join-page') . '</li>';
1615
-    $output .=  '</ol>';
1614
+    ), NULL, 'boinc:join-page').'</li>';
1615
+    $output .= '</ol>';
1616 1616
   }
1617 1617
   $output .= '</div>';
1618 1618
   return $output;
@@ -1625,7 +1625,7 @@  discard block
 block discarded – undo
1625 1625
   global $user;
1626 1626
   $site_name = variable_get('site_name', 'Drupal-BOINC');
1627 1627
   // get the front page message from database; this is set in the admin interface under BOINC Other
1628
-  $site_message = variable_get('boinc_other_frontpage','');
1628
+  $site_message = variable_get('boinc_other_frontpage', '');
1629 1629
 
1630 1630
   // Determine the user of the day
1631 1631
   $current_uotd = db_fetch_object(db_query("
@@ -1647,30 +1647,30 @@  discard block
 block discarded – undo
1647 1647
   $output .= ($user->uid) ? bts('Welcome back!', array(), NULL, 'boinc:front-page') : ($site_name ? bts('What is @this_project?', array('@this_project' => $site_name)) : bts('Welcome!', array(), NULL, 'boinc:front-page'));
1648 1648
   $output .= '</h2>';
1649 1649
   $output .= '<div class="boinc-overview balance-height-front">';
1650
-  $output .= '  <div>' . bts($site_message, array(), NULL, "project:front page") . ' ' . l(bts('Learn more', array(), NULL, 'boinc:front-page'), 'about') . '</div>';
1650
+  $output .= '  <div>'.bts($site_message, array(), NULL, "project:front page").' '.l(bts('Learn more', array(), NULL, 'boinc:front-page'), 'about').'</div>';
1651 1651
   if ($user->uid) {
1652
-    $output .= '  <div>' . l(bts('View account', array(), NULL, 'boinc:front-page'), 'dashboard', array('attributes' => array('class' => 'join button'))) . '</div>';
1652
+    $output .= '  <div>'.l(bts('View account', array(), NULL, 'boinc:front-page'), 'dashboard', array('attributes' => array('class' => 'join button'))).'</div>';
1653 1653
   }
1654 1654
   else {
1655
-    $output .= '  <div>' . l(bts('Join now', array(), NULL, 'boinc:front-page'), 'join', array('attributes' => array('class' => 'join button'))) . '</div>';
1655
+    $output .= '  <div>'.l(bts('Join now', array(), NULL, 'boinc:front-page'), 'join', array('attributes' => array('class' => 'join button'))).'</div>';
1656 1656
   }
1657 1657
   $output .= '</div>';
1658 1658
   $output .= '<div class="boinc-overview-details">';
1659 1659
   $output .= '  <div class="detail-container">';
1660
-  $output .= '    <a class="user-of-the-day" href="account/' . $uotd->uid . '">';
1660
+  $output .= '    <a class="user-of-the-day" href="account/'.$uotd->uid.'">';
1661 1661
   $output .= '      <div class="picture">';
1662 1662
   $output .= theme('imagefield_image', $uotd_image['image'], $uotd_image['alt'],
1663 1663
     $uotd_image['alt'], array(), FALSE);
1664 1664
   $output .= '      </div>';
1665
-  $output .= '      <div class="text">' . bts('User of the day', array(), NULL, 'boinc:front-page') . '</div>';
1666
-  $output .= '      <div class="detail">' . $uotd->boincuser_name . '</div>';
1665
+  $output .= '      <div class="text">'.bts('User of the day', array(), NULL, 'boinc:front-page').'</div>';
1666
+  $output .= '      <div class="detail">'.$uotd->boincuser_name.'</div>';
1667 1667
   $output .= '    </a>';
1668 1668
   $output .= '    <div class="volunteers">';
1669
-  $output .= '      <div class="text">' . bts('Over 500,000 volunteers and counting.', array(), NULL, 'boinc:front-page') . '</div>';
1669
+  $output .= '      <div class="text">'.bts('Over 500,000 volunteers and counting.', array(), NULL, 'boinc:front-page').'</div>';
1670 1670
   $output .= '      <div class="platforms">';
1671
-  $output .= '        <div class="detail platform windows">' . bts('Windows', array(), NULL, 'boinc:front-page') . '</div>';
1672
-  $output .= '        <div class="detail platform mac">' .  bts('Mac', array(), NULL, 'boinc:front-page') . '</div>';
1673
-  $output .= '        <div class="detail platform linux">' . bts('Linux', array(), NULL, 'boinc:front-page') . '</div>';
1671
+  $output .= '        <div class="detail platform windows">'.bts('Windows', array(), NULL, 'boinc:front-page').'</div>';
1672
+  $output .= '        <div class="detail platform mac">'.bts('Mac', array(), NULL, 'boinc:front-page').'</div>';
1673
+  $output .= '        <div class="detail platform linux">'.bts('Linux', array(), NULL, 'boinc:front-page').'</div>';
1674 1674
   $output .= '      </div>';
1675 1675
   $output .= '    </div>';
1676 1676
   $output .= '  </div>';
@@ -1701,7 +1701,7 @@  discard block
 block discarded – undo
1701 1701
   $enablethisRPC = variable_get('boinc_weboptions_enableaccountcreateRPC', TRUE);
1702 1702
   if (!$enablethisRPC) {
1703 1703
     $mess = bts('Account creation is done through our Web site. Please register at @url', array(
1704
-      '@url' => $base_url . '/user/registration',
1704
+      '@url' => $base_url.'/user/registration',
1705 1705
     ),
1706 1706
     NULL, 'boinc:create_account');
1707 1707
     xml_error(-208, $mess);
@@ -1733,8 +1733,8 @@  discard block
 block discarded – undo
1733 1733
   $boinc_user = BoincUser::lookup_email_addr($params['email_addr']);
1734 1734
   if ($boinc_user) {
1735 1735
     // Return authenticator for existing users
1736
-    if ( ($params['passwd_hash'] == $boinc_user->passwd_hash) or
1737
-    password_verify($params['passwd_hash'], $boinc_user->passwd_hash) ) {
1736
+    if (($params['passwd_hash'] == $boinc_user->passwd_hash) or
1737
+    password_verify($params['passwd_hash'], $boinc_user->passwd_hash)) {
1738 1738
       $output = array('authenticator' => $boinc_user->authenticator);
1739 1739
     }
1740 1740
     else {
@@ -1790,7 +1790,7 @@  discard block
 block discarded – undo
1790 1790
   // Ensure there is a authentication token before continuing
1791 1791
   if (empty($authtoken)) {
1792 1792
     drupal_not_found();
1793
-    return ;
1793
+    return;
1794 1794
   }
1795 1795
 
1796 1796
   if (strlen($authtoken) != 32) {
@@ -1812,8 +1812,8 @@  discard block
 block discarded – undo
1812 1812
   }
1813 1813
 
1814 1814
   // Lookup path to custom account finish page
1815
-  $customaccountfinishpath = drupal_lookup_path('source', variable_get('boinc_weboptions_accountfinish', '') );
1816
-  if ( menu_valid_path(array('link_path' => $customaccountfinishpath)) ) {
1815
+  $customaccountfinishpath = drupal_lookup_path('source', variable_get('boinc_weboptions_accountfinish', ''));
1816
+  if (menu_valid_path(array('link_path' => $customaccountfinishpath))) {
1817 1817
     $node = menu_get_object('node', 1, $customaccountfinishpath);
1818 1818
     if ($node) {
1819 1819
       return node_page_view($node);
@@ -1822,12 +1822,12 @@  discard block
 block discarded – undo
1822 1822
 
1823 1823
   // open links in new window
1824 1824
   $options = array(
1825
-    'attributes' => array( 'target' => '_blank' ),
1825
+    'attributes' => array('target' => '_blank'),
1826 1826
   );
1827 1827
 
1828 1828
   // Check moderation page exists
1829
-  $moderationpath = drupal_lookup_path('source', variable_get('boinc_weboptions_moderationpage', '') );
1830
-  if ( menu_valid_path(array('link_path' => $moderationpath)) ) {
1829
+  $moderationpath = drupal_lookup_path('source', variable_get('boinc_weboptions_moderationpage', ''));
1830
+  if (menu_valid_path(array('link_path' => $moderationpath))) {
1831 1831
     $modsentence = bts('Please note: user profiles are subject to !moderation.', array('!moderation' => l(bts('moderation', array(), NULL, 'boinc:account-finish'), $moderationpath, $options)), NULL, 'boinc:account-finish');
1832 1832
   } else {
1833 1833
     $modsentence = bts('Please note: user profiles are subject to moderation.', array(), NULL, 'boinc:account-finish');
@@ -1835,11 +1835,11 @@  discard block
 block discarded – undo
1835 1835
 
1836 1836
   $username = $user->boincuser_name;
1837 1837
   $site_name = variable_get('site_name', 'Drupal-BOINC');
1838
-  $output = "<p>" . bts('Thank you @user_name for joining @site_name. Your account has been created. Your BOINC client should start working on assigned tasks soon, without any additional action or configuration. Please visit the links below for more information and additional options. (Links will open in a new window.)',
1838
+  $output = "<p>".bts('Thank you @user_name for joining @site_name. Your account has been created. Your BOINC client should start working on assigned tasks soon, without any additional action or configuration. Please visit the links below for more information and additional options. (Links will open in a new window.)',
1839 1839
   array(
1840 1840
     '@user_name' => $username,
1841 1841
     '@site_name' => $site_name,
1842
-  ), NULL, 'boinc:account-finish') . "</p>";
1842
+  ), NULL, 'boinc:account-finish')."</p>";
1843 1843
 
1844 1844
   $links = array(
1845 1845
     array(
@@ -1905,7 +1905,7 @@  discard block
 block discarded – undo
1905 1905
   );
1906 1906
 
1907 1907
   //List of links
1908
-  $output .= theme_item_list($links, $title = NULL, $type='ul');
1908
+  $output .= theme_item_list($links, $title = NULL, $type = 'ul');
1909 1909
 
1910 1910
   return $output;
1911 1911
 }
@@ -2022,7 +2022,7 @@  discard block
 block discarded – undo
2022 2022
     global $base_url;
2023 2023
     global $base_path;
2024 2024
     $site_name = variable_get('site_name', 'Drupal-BOINC');
2025
-    $site_url = $base_url . $base_path;
2025
+    $site_url = $base_url.$base_path;
2026 2026
     $moderator = user_load($user->uid);
2027 2027
     $profile->moderate = 0;
2028 2028
     $profile->status = 0;
@@ -2083,7 +2083,7 @@  discard block
 block discarded – undo
2083 2083
       global $base_url;
2084 2084
       global $base_path;
2085 2085
       $site_name = variable_get('site_name', 'Drupal-BOINC');
2086
-      $site_url = $base_url . $base_path;
2086
+      $site_url = $base_url.$base_path;
2087 2087
       $moderator = user_load($user->uid);
2088 2088
       $settings = array(
2089 2089
         'from' => '',
@@ -2187,25 +2187,25 @@  discard block
 block discarded – undo
2187 2187
   if (!$projects) return bts('no projects...', array(), NULL, 'boinc:account-dashboard');
2188 2188
   
2189 2189
   $output = '';
2190
-  $output .= '<table class="user-projects">' . "\n";
2191
-  $output .= '<thead>' . "\n";
2192
-  $output .= '  <tr>' . "\n";
2193
-  $output .= '    <th>' . bts('Name', array(), NULL, 'boinc:project-name:-1:ignoreoverwrite') . '</th>' . "\n";
2194
-  $output .= '    <th class="numeric">' . bts('Avg credit', array(), NULL, 'boinc:account-dashboard') . '</th>' . "\n";
2195
-  $output .= '    <th class="numeric">' . bts('Total credit', array(), NULL, 'boinc:user-or-team-total-credits') . '</th>' . "\n";
2196
-  $output .= '  </tr>' . "\n";
2197
-  $output .= '</thead>' . "\n";
2198
-  $output .= '<tbody>' . "\n";
2190
+  $output .= '<table class="user-projects">'."\n";
2191
+  $output .= '<thead>'."\n";
2192
+  $output .= '  <tr>'."\n";
2193
+  $output .= '    <th>'.bts('Name', array(), NULL, 'boinc:project-name:-1:ignoreoverwrite').'</th>'."\n";
2194
+  $output .= '    <th class="numeric">'.bts('Avg credit', array(), NULL, 'boinc:account-dashboard').'</th>'."\n";
2195
+  $output .= '    <th class="numeric">'.bts('Total credit', array(), NULL, 'boinc:user-or-team-total-credits').'</th>'."\n";
2196
+  $output .= '  </tr>'."\n";
2197
+  $output .= '</thead>'."\n";
2198
+  $output .= '<tbody>'."\n";
2199 2199
   foreach ($projects AS $project) {
2200
-    $url = rtrim($project->url, '/') . '/show_user.php?userid=' . $project->id;
2201
-    $output .= '  <tr>' . "\n";
2202
-    $output .= '    <td>' . l($project->name, $url) . '</td>' . "\n";
2203
-    $output .= '    <td class="numeric">' . boincwork_format_stats((float) $project->expavg_credit) . '</td>' . "\n"; 
2204
-    $output .= '    <td class="numeric">' . boincwork_format_stats((float) $project->total_credit) . '</td>' . "\n";
2205
-    $output .= '  </tr>' . "\n";
2200
+    $url = rtrim($project->url, '/').'/show_user.php?userid='.$project->id;
2201
+    $output .= '  <tr>'."\n";
2202
+    $output .= '    <td>'.l($project->name, $url).'</td>'."\n";
2203
+    $output .= '    <td class="numeric">'.boincwork_format_stats((float)$project->expavg_credit).'</td>'."\n"; 
2204
+    $output .= '    <td class="numeric">'.boincwork_format_stats((float)$project->total_credit).'</td>'."\n";
2205
+    $output .= '  </tr>'."\n";
2206 2206
   }
2207
-  $output .= '</tbody>' . "\n";
2208
-  $output .= '</table>' . "\n";
2207
+  $output .= '</tbody>'."\n";
2208
+  $output .= '</table>'."\n";
2209 2209
   $more_link = ($account) ? "user/{$account->uid}/stats" : 'account/stats';
2210 2210
   //$output .= "<div class=\"more-link\"><a href=\"{$more_link}\">More stats</a></div>" . "\n";
2211 2211
   return $output;
@@ -2225,8 +2225,8 @@  discard block
 block discarded – undo
2225 2225
     'cpid' => $cpid
2226 2226
   );
2227 2227
   $args = array();
2228
-  foreach ($get as $arg => $value) $args[] = "{$arg}=" . rawurlencode($value);
2229
-  $query = '?' . implode('&', $args);
2228
+  foreach ($get as $arg => $value) $args[] = "{$arg}=".rawurlencode($value);
2229
+  $query = '?'.implode('&', $args);
2230 2230
   
2231 2231
   // Load XML from RPC
2232 2232
   $target_url = "http://{$stats_server}/{$stats_rpc}{$query}";
@@ -2298,12 +2298,12 @@  discard block
 block discarded – undo
2298 2298
     $output .= '<ul class="tab-list">';
2299 2299
     $count = 0;
2300 2300
     foreach ($links as $key => $link) {
2301
-      $output .= '<li class="' . (($count == 0) ? 'first primary ' : '') . 'tab">';
2301
+      $output .= '<li class="'.(($count == 0) ? 'first primary ' : '').'tab">';
2302 2302
       $output .= l($link['title'], $link['href'], array('query' => drupal_get_destination()));
2303 2303
       $output .= '</li>';
2304 2304
       $count++;
2305 2305
     }
2306
-    $output .= '<li class="' . (($count) ? '' : 'first ') . 'last tab">' . flag_create_link('abuse_user', $account->uid) . '</li>';
2306
+    $output .= '<li class="'.(($count) ? '' : 'first ').'last tab">'.flag_create_link('abuse_user', $account->uid).'</li>';
2307 2307
     $output .= '</ul>';
2308 2308
   }
2309 2309
   return $output;
@@ -2344,7 +2344,7 @@  discard block
 block discarded – undo
2344 2344
 function boincuser_apachesolr_index_documents_alter(array &$documents, $entity, $entity_type, $env_id) {
2345 2345
 
2346 2346
   foreach ($documents as $document) {
2347
-    if ( $document->entity_type=='node' AND $document->bundle=='profile' ) {
2347
+    if ($document->entity_type == 'node' AND $document->bundle == 'profile') {
2348 2348
       // Node information.
2349 2349
       $nid = $document->entity_id;
2350 2350
       $node = node_load($nid);
@@ -2394,11 +2394,11 @@  discard block
 block discarded – undo
2394 2394
   // privatemsg module. We need to convert them back to spaces for the
2395 2395
   // check below.
2396 2396
   $boincname = preg_replace("/\\xc2\\xa0/", " ", $boincname);
2397
-  if ($drupalid>0) {
2397
+  if ($drupalid > 0) {
2398 2398
     if ($recipient = user_load(array('uid' => $drupalid))) {
2399 2399
       // Double-check that the loaded user matches both boincuser_id
2400 2400
       // and boincuser_name.
2401
-      if ( ($boincid == $recipient->boincuser_id) AND ($boincname == $recipient->boincuser_name) ) {
2401
+      if (($boincid == $recipient->boincuser_id) AND ($boincname == $recipient->boincuser_name)) {
2402 2402
         return $recipient;
2403 2403
       }
2404 2404
     }
Please login to merge, or discard this patch.
html/user/user_agreetermsofuse_action.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 if ($checkct) {
60 60
     $rc1 = consent_to_a_policy($user, $ctid, 1, 0, 'Webform', time());
61 61
     if (!$rc1) {
62
-        error_page("Database error when attempting to INSERT into table consent with ID=$user->id. " . BoincDb::error() . " Please contact site administrators.");
62
+        error_page("Database error when attempting to INSERT into table consent with ID=$user->id. ".BoincDb::error()." Please contact site administrators.");
63 63
     }
64 64
 } else {
65 65
     error_page("Error: consent type for enrollment not found. Please contact site administrators.");
Please login to merge, or discard this patch.
html/inc/prefs_util.inc 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -42,9 +42,9 @@  discard block
 block discarded – undo
42 42
 }
43 43
 
44 44
 abstract class PREF {
45
-    public $desc;       // short description
46
-    public $tooltip;    // longer description, shown as tooltip
47
-    public $tag;        // the pref's primary XML tag
45
+    public $desc; // short description
46
+    public $tooltip; // longer description, shown as tooltip
47
+    public $tag; // the pref's primary XML tag
48 48
     function __construct($desc, $tooltip, $tag) {
49 49
         $this->desc = $desc;
50 50
         $this->tooltip = $tooltip;
@@ -122,15 +122,15 @@  discard block
 block discarded – undo
122 122
 
123 123
 class PREF_BOOL extends PREF {
124 124
     public $default;
125
-    public $invert;     // show to user in opposite sense
126
-    function __construct($desc, $tooltip, $tag, $default, $invert=false) {
125
+    public $invert; // show to user in opposite sense
126
+    function __construct($desc, $tooltip, $tag, $default, $invert = false) {
127 127
         $this->default = $default;
128 128
         $this->invert = $invert;
129 129
         parent::__construct($desc, $tooltip, $tag);
130 130
     }
131 131
     function show_value($prefs) {
132 132
         $tag = $this->tag;
133
-        $v = $this->invert?!$prefs->$tag:$prefs->$tag;
133
+        $v = $this->invert ? !$prefs->$tag : $prefs->$tag;
134 134
         echo "<td>".readonly_checkbox($v)."</td>";
135 135
     }
136 136
     function show_form($prefs, $error) {
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         }
143 143
         echo "<td ".VALUE_ATTRS.">"
144 144
             ."<input type=checkbox name=$this->tag "
145
-            . ($checked?"checked":"")
145
+            . ($checked ? "checked" : "")
146 146
             ."></td>
147 147
         ";
148 148
     }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     function xml_string($prefs) {
156 156
         $tag = $this->tag;
157 157
         return "<$tag>"
158
-            .($prefs->$tag?"1":"0")
158
+            .($prefs->$tag ? "1" : "0")
159 159
             ."</$tag>\n";
160 160
     }
161 161
     function xml_parse(&$prefs, $name, $text) {
@@ -175,9 +175,9 @@  discard block
 block discarded – undo
175 175
     public $consent_type_id; // the consent_type_id from the consent_type table
176 176
     public $consent_name; // the consent_name to configure
177 177
     public $default;
178
-    public $invert;     // show to user in opposite sense
178
+    public $invert; // show to user in opposite sense
179 179
 
180
-    function __construct($desc, $tooltip, $tag, $consent_type_id, $consent_name, $default, $invert=false) {
180
+    function __construct($desc, $tooltip, $tag, $consent_type_id, $consent_name, $default, $invert = false) {
181 181
         $this->consent_type_id = $consent_type_id;
182 182
         $this->consent_name = $consent_name;
183 183
         $this->default = $default;
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
         } else {
232 232
             $value = false;
233 233
         }
234
-        echo "<td>" . readonly_checkbox($value) . "</td>";
234
+        echo "<td>".readonly_checkbox($value)."</td>";
235 235
     }
236 236
     function show_form($user, $error) {
237 237
         $consent_type_id = $this->consent_type_id;
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         }
248 248
         echo "<td ".VALUE_ATTRS.">"
249 249
             ."<input type=checkbox name=$this->tag "
250
-            . ($checked?"checked":"")
250
+            . ($checked ? "checked" : "")
251 251
             ."></td>
252 252
         ";
253 253
     }
@@ -264,8 +264,8 @@  discard block
 block discarded – undo
264 264
         // to this consent type.
265 265
         $cr = BoincLatestConsent::lookup("userid={$user->id} AND consent_type_id='${consent_type_id}'");
266 266
 
267
-        if ( (($cr) and ($cr->consent_flag!=$flag)) or
268
-             (!$cr) ) {
267
+        if ((($cr) and ($cr->consent_flag != $flag)) or
268
+             (!$cr)) {
269 269
             $rc = consent_to_a_policy($user, $consent_type_id, $flag, 0, 'Webform', time());
270 270
             if (!$rc) {
271 271
                 error_page(tra("Database error:").BoincDb::error());
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
         // this is the value if they check the box
302 302
     public $scale;
303 303
 
304
-    function __construct($suffix, $min, $max, $default, $scale=1, $default2=0) {
304
+    function __construct($suffix, $min, $max, $default, $scale = 1, $default2 = 0) {
305 305
         $this->suffix = " $suffix";
306 306
         $this->min = $min;
307 307
         $this->max = $max;
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
         $v .= "$this->suffix ";
321 321
         return $v;
322 322
     }
323
-    function form_str($tag, $v, $had_error, $disabled=false, $id=null) {
323
+    function form_str($tag, $v, $had_error, $disabled = false, $id = null) {
324 324
         if (is_numeric($v)) {
325 325
             $v /= $this->scale;
326 326
             if (!$had_error && ($v < $this->min || $v > $this->max)) {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
             }
329 329
         }
330 330
         if ($disabled) $v = "";
331
-        $i = $id?"id=\"$id\"":"";
331
+        $i = $id ? "id=\"$id\"" : "";
332 332
         return '<input type="text" size="5" class="form-control input-sm" name="'.$tag.'" value="'.$v."\" $disabled $i> &nbsp; $this->suffix ";
333 333
     }
334 334
     function form_convert($in, &$out, &$error) {
@@ -451,8 +451,8 @@  discard block
 block discarded – undo
451 451
         $text_id = $this->tag;
452 452
         $default = $this->num_spec->get_default();
453 453
         $val = $prefs->$tag;
454
-        $c = $val?"checked":"";
455
-        $d = $val?"":"disabled";
454
+        $c = $val ? "checked" : "";
455
+        $d = $val ? "" : "disabled";
456 456
         echo "<td $attrs>"
457 457
             ."<input type=checkbox id=$checkbox_id onClick=\"checkbox_clicked('$checkbox_id', '$text_id', $default)\" $c> &nbsp;"
458 458
             .$this->num_spec->form_str($tag, $prefs->$tag, $had_error, $d, $text_id)
@@ -565,8 +565,8 @@  discard block
 block discarded – undo
565 565
 function hour_select($x, $name, $id, $d) {
566 566
     $s = "";
567 567
     $s .= "<select class=\"selectbox form-control input-sm\" name=$name id=$id $d>\n";
568
-    for ($i=0; $i<24; $i++) {
569
-        $sel = ($x == $i)?"selected":"";
568
+    for ($i = 0; $i < 24; $i++) {
569
+        $sel = ($x == $i) ? "selected" : "";
570 570
         $s .= "<option value=$i $sel> $i:00";
571 571
     }
572 572
     $s .= "</select>\n";
@@ -667,7 +667,7 @@  discard block
 block discarded – undo
667 667
 
668 668
 // row_defs - Display a value for all 4 venues in one row
669 669
 //
670
-function row_defs($pre, $item, $post, $type, $prefs, $tooltip=null) {
670
+function row_defs($pre, $item, $post, $type, $prefs, $tooltip = null) {
671 671
     $gen = $prefs->$item;
672 672
     $hom  = (isset($prefs->home) && isset($prefs->home->$item)) ? $prefs->home->$item : "--";
673 673
     $schl = (isset($prefs->school) && isset($prefs->school->$item)) ? $prefs->school->$item : "--";
@@ -679,10 +679,10 @@  discard block
 block discarded – undo
679 679
         echo "<tr>";
680 680
     }
681 681
     echo "<td ".NAME_ATTRS.">$pre</td>";
682
-    row_field($gen,  $type);
683
-    row_field($hom,  $type);
682
+    row_field($gen, $type);
683
+    row_field($hom, $type);
684 684
     row_field($schl, $type);
685
-    row_field($wrk,  $type);
685
+    row_field($wrk, $type);
686 686
     echo "<td align=left>$post</td></tr>\n";
687 687
 }
688 688
 
@@ -692,16 +692,16 @@  discard block
 block discarded – undo
692 692
 function row_field($value, $type) {
693 693
     echo "<td>";
694 694
     $type = $value === "--" ? "--" : $type;
695
-    switch($type) {
695
+    switch ($type) {
696 696
     case "yesno":
697
-        echo $value ?tra("yes"):tra("no");
697
+        echo $value ?tra("yes") : tra("no");
698 698
         break;
699 699
     case "noyes":
700
-        echo $value ?tra("no"):tra("yes");
700
+        echo $value ?tra("no") : tra("yes");
701 701
         break;
702 702
     case "limit":
703 703
         $x = max_bytes_display_mode($value);
704
-        $y = "$x " . BYTE_ABBR;
704
+        $y = "$x ".BYTE_ABBR;
705 705
         echo $x ? "$y" : tra("no limit");
706 706
         break;
707 707
     case "minutes":
Please login to merge, or discard this patch.
html/inc/consent.inc 2 patches
Upper-Lower-Casing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -44,10 +44,10 @@  discard block
 block discarded – undo
44 44
     if ($checkct) {
45 45
         $consent_result = BoincLatestConsent::lookup("userid={$user->id} AND consent_type_id=$ctid AND consent_flag=1");
46 46
         if ($consent_result) {
47
-            return TRUE;
47
+            return true;
48 48
         }
49 49
     }
50
-    return FALSE;
50
+    return false;
51 51
 }
52 52
 
53 53
 // Checks to see if a particular consent_type name is in
@@ -56,12 +56,12 @@  discard block
 block discarded – undo
56 56
 // if checkenabled=TRUE, if the consent_type is enabled/available for
57 57
 // use. The integer is the consent_type_id- the id from consent_type
58 58
 // table. If the boolean is FALSE, the integer returned is -1.
59
-function check_consent_type($name, $checkenabled=TRUE) {
59
+function check_consent_type($name, $checkenabled=true) {
60 60
     $ct = BoincConsentType::lookup("shortname = '{$name}'");
61 61
     if ($ct and ( !$checkenabled or ($ct->enabled)) ) {
62
-        return array(TRUE, $ct->id);
62
+        return array(true, $ct->id);
63 63
     }
64
-    return array(FALSE, -1);
64
+    return array(false, -1);
65 65
 }
66 66
 
67 67
 // When a user uses the Web site to login, this funtion checks the
Please login to merge, or discard this patch.
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -21,17 +21,17 @@  discard block
 block discarded – undo
21 21
 include_once("../inc/boinc_db.inc");
22 22
 include_once("../inc/util.inc");
23 23
 
24
-define('CONSENT_TYPE_ENROLL','ENROLL');
24
+define('CONSENT_TYPE_ENROLL', 'ENROLL');
25 25
 
26 26
 function consent_to_a_policy($user, $consent_type_id, $consent_flag, $consent_not_required, $source, $ctime = 0) {
27 27
     $mys = BoincDb::escape_string($source);
28
-    if ($ctime==0) {
28
+    if ($ctime == 0) {
29 29
         $mytime = $user->create_time;
30 30
     } else {
31 31
         $mytime = $ctime;
32 32
     }
33 33
     return BoincConsent::insert(
34
-        "(userid, consent_type_id, consent_time, consent_flag, consent_not_required, source) " .
34
+        "(userid, consent_type_id, consent_time, consent_flag, consent_not_required, source) ".
35 35
         "values($user->id, $consent_type_id, $mytime, $consent_flag, $consent_not_required, '$mys')"
36 36
     );
37 37
 
@@ -55,9 +55,9 @@  discard block
 block discarded – undo
55 55
 // if checkenabled=TRUE, if the consent_type is enabled/available for
56 56
 // use. The integer is the consent_type_id- the id from consent_type
57 57
 // table. If the boolean is FALSE, the integer returned is -1.
58
-function check_consent_type($name, $checkenabled=TRUE) {
58
+function check_consent_type($name, $checkenabled = TRUE) {
59 59
     $ct = BoincConsentType::lookup("shortname = '{$name}'");
60
-    if ($ct and ( !$checkenabled or ($ct->enabled)) ) {
60
+    if ($ct and (!$checkenabled or ($ct->enabled))) {
61 61
         return array(TRUE, $ct->id);
62 62
     }
63 63
     return array(FALSE, -1);
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
 function intercept_login($user, $perm, $in_next_url = "") {
70 70
     list($checkct, $ctid) = check_consent_type(CONSENT_TYPE_ENROLL);
71 71
     $config = get_config();
72
-    if ( parse_bool($config, "enable_login_mustagree_termsofuse") and $checkct and check_termsofuse() and (!check_user_consent($user, CONSENT_TYPE_ENROLL))) {
72
+    if (parse_bool($config, "enable_login_mustagree_termsofuse") and $checkct and check_termsofuse() and (!check_user_consent($user, CONSENT_TYPE_ENROLL))) {
73 73
         // sent user to terms-of-use Web form after login
74 74
         $mytoken = create_token($user->id, TOKEN_TYPE_LOGIN_INTERCEPT, TOKEN_DURATION_TWO_HOURS);
75 75
         send_cookie('logintoken', $mytoken, false);
Please login to merge, or discard this patch.
html/inc/keywords.inc 1 patch
Spacing   +57 added lines, -57 removed lines patch added patch discarded remove patch
@@ -22,68 +22,68 @@
 block discarded – undo
22 22
 define('KW_CATEGORY_SCIENCE', 0);
23 23
 define('KW_CATEGORY_LOC', 1);
24 24
 
25
-define('KW_ASTRONOMY',      1);
26
-define('KW_SETI',           2);
27
-define('KW_PULSARS',        3);
28
-define('KW_GW',             4);
29
-define('KW_COSMOLOGY',      5);
30
-define('KW_PHYSICS',        6);
25
+define('KW_ASTRONOMY', 1);
26
+define('KW_SETI', 2);
27
+define('KW_PULSARS', 3);
28
+define('KW_GW', 4);
29
+define('KW_COSMOLOGY', 5);
30
+define('KW_PHYSICS', 6);
31 31
 define('KW_PARTICLE_PHYSICS', 7);
32
-define('KW_NANOSCIENCE',    8);
33
-define('KW_BIOMED',         9);
32
+define('KW_NANOSCIENCE', 8);
33
+define('KW_BIOMED', 9);
34 34
 define('KW_DRUG_DISCOVERY', 10);
35
-define('KW_PROTEINS',       11);
36
-define('KW_GENETICS',       12);
37
-define('KW_DISEASE',        13);
38
-define('KW_CANCER',         14);
39
-define('KW_MATH_CS',        15);
40
-define('KW_AI',             16);
41
-define('KW_OCEANIA',        17);
42
-define('KW_AUSTRALIA',      18);
35
+define('KW_PROTEINS', 11);
36
+define('KW_GENETICS', 12);
37
+define('KW_DISEASE', 13);
38
+define('KW_CANCER', 14);
39
+define('KW_MATH_CS', 15);
40
+define('KW_AI', 16);
41
+define('KW_OCEANIA', 17);
42
+define('KW_AUSTRALIA', 18);
43 43
 
44
-define('KW_EUROPE',         20);
45
-define('KW_GERMANY',        21);
46
-define('KW_ASIA',           22);
47
-define('KW_AMERICAS',       23);
48
-define('KW_US',             24);
49
-define('KW_UCB',            25);
50
-define('KW_AEI',            26);
51
-define('KW_CERN',           27);
52
-define('KW_UW',             28);
53
-define('KW_EARTH_SCI',      29);
54
-define('KW_SPAIN',          30);
55
-define('KW_SAN_JORGE',      31);
56
-define('KW_NUMBER_THEORY',  32);
57
-define('KW_CRYPTO',         33);
58
-define('KW_ENV_RESEARCH',   34);
59
-define('KW_CLIMATE',        35);
60
-define('KW_CZECH',          36);
44
+define('KW_EUROPE', 20);
45
+define('KW_GERMANY', 21);
46
+define('KW_ASIA', 22);
47
+define('KW_AMERICAS', 23);
48
+define('KW_US', 24);
49
+define('KW_UCB', 25);
50
+define('KW_AEI', 26);
51
+define('KW_CERN', 27);
52
+define('KW_UW', 28);
53
+define('KW_EARTH_SCI', 29);
54
+define('KW_SPAIN', 30);
55
+define('KW_SAN_JORGE', 31);
56
+define('KW_NUMBER_THEORY', 32);
57
+define('KW_CRYPTO', 33);
58
+define('KW_ENV_RESEARCH', 34);
59
+define('KW_CLIMATE', 35);
60
+define('KW_CZECH', 36);
61 61
 define('KW_CHARLES_PRAGUE', 37);
62
-define('KW_RECHENKRAFT',    38);
63
-define('KW_RHEINMAIN',      39);
64
-define('KW_HUNGARY',        40);
65
-define('KW_IRELAND',        41);
66
-define('KW_UC_DUBLIN',      42);
67
-define('KW_POLAND',         43);
68
-define('KW_RUSSIA',         44);
62
+define('KW_RECHENKRAFT', 38);
63
+define('KW_RHEINMAIN', 39);
64
+define('KW_HUNGARY', 40);
65
+define('KW_IRELAND', 41);
66
+define('KW_UC_DUBLIN', 42);
67
+define('KW_POLAND', 43);
68
+define('KW_RUSSIA', 44);
69 69
 define('KW_SW_STATE_RUSSIA', 45);
70
-define('KW_RAS',            46);
71
-define('KW_PRBB',           47);
72
-define('KW_UK',             48);
73
-define('KW_OXFORD',         49);
74
-define('KW_CHINA',          50);
75
-define('KW_U_DAYTON',       51);
76
-define('KW_WRIGHT_STATE',   52);
77
-define('KW_USC',            53);
78
-define('KW_FULLERTON',      54);
79
-define('KW_ARIZONA_STATE',  55);
80
-define('KW_U_ILLINOIS',     56);
81
-define('KW_U_WARSAW',       57);
82
-define('KW_RPI',            58);
83
-define('KW_INTERNATIONAL',  59);
84
-define('KW_UND',            60);
85
-define('KW_HOLLAND',        61);
86
-define('KW_CHEMISTRY',      62);
70
+define('KW_RAS', 46);
71
+define('KW_PRBB', 47);
72
+define('KW_UK', 48);
73
+define('KW_OXFORD', 49);
74
+define('KW_CHINA', 50);
75
+define('KW_U_DAYTON', 51);
76
+define('KW_WRIGHT_STATE', 52);
77
+define('KW_USC', 53);
78
+define('KW_FULLERTON', 54);
79
+define('KW_ARIZONA_STATE', 55);
80
+define('KW_U_ILLINOIS', 56);
81
+define('KW_U_WARSAW', 57);
82
+define('KW_RPI', 58);
83
+define('KW_INTERNATIONAL', 59);
84
+define('KW_UND', 60);
85
+define('KW_HOLLAND', 61);
86
+define('KW_CHEMISTRY', 62);
87 87
 
88 88
 $job_keywords = array();
89 89
 
Please login to merge, or discard this patch.