@@ -541,7 +541,7 @@ discard block |
||
541 | 541 | |
542 | 542 | $is_assim_move = is_assim_move($app); |
543 | 543 | |
544 | - page_head("Batch $batch_id"); |
|
544 | + page_head("batch $batch_id"); |
|
545 | 545 | text_start(800); |
546 | 546 | start_table(); |
547 | 547 | row2("name", $batch->name); |
@@ -817,7 +817,7 @@ discard block |
||
817 | 817 | |
818 | 818 | if (get_int('confirmed', true)) { |
819 | 819 | retire_batch($batch); |
820 | - page_head("Batch $batch_id retired"); |
|
820 | + page_head("batch $batch_id retired"); |
|
821 | 821 | return_link(); |
822 | 822 | page_tail(); |
823 | 823 | } else { |
@@ -551,7 +551,7 @@ discard block |
||
551 | 551 | if ($owner) { |
552 | 552 | row2('submitter', $owner->name); |
553 | 553 | } |
554 | - row2("application", $app?$app->name:'---'); |
|
554 | + row2("application", $app ? $app->name : '---'); |
|
555 | 555 | row2("state", batch_state_string($batch->state)); |
556 | 556 | //row2("# jobs", $batch->njobs); |
557 | 557 | //row2("# error jobs", $batch->nerror_jobs); |
@@ -611,10 +611,10 @@ discard block |
||
611 | 611 | "GFLOPS-hours" |
612 | 612 | ]; |
613 | 613 | row_heading_array($x); |
614 | - foreach($wus as $wu) { |
|
614 | + foreach ($wus as $wu) { |
|
615 | 615 | $y = ''; |
616 | 616 | $c = '---'; |
617 | - switch($wu->status) { |
|
617 | + switch ($wu->status) { |
|
618 | 618 | case WU_SUCCESS: |
619 | 619 | $resultid = $wu->canonical_resultid; |
620 | 620 | $y = sprintf('<font color="%s">completed</font>', COLOR_SUCCESS); |
@@ -694,7 +694,7 @@ discard block |
||
694 | 694 | $results = BoincResult::enum("workunitid=$wuid"); |
695 | 695 | $upload_dir = parse_config(get_config(), "<upload_dir>"); |
696 | 696 | $fanout = parse_config(get_config(), "<uldl_dir_fanout>"); |
697 | - foreach($results as $result) { |
|
697 | + foreach ($results as $result) { |
|
698 | 698 | $x = [ |
699 | 699 | "<a href=result.php?resultid=$result->id>$result->id</a>", |
700 | 700 | state_string($result) |
@@ -703,7 +703,7 @@ discard block |
||
703 | 703 | if ($result->server_state == RESULT_SERVER_STATE_OVER) { |
704 | 704 | $phys_names = get_outfile_phys_names($result); |
705 | 705 | $log_names = get_outfile_log_names($result); |
706 | - for ($i=0; $i<count($phys_names); $i++) { |
|
706 | + for ($i = 0; $i < count($phys_names); $i++) { |
|
707 | 707 | if ($is_assim_move) { |
708 | 708 | // file is in |
709 | 709 | // project/results/<batchid>/<wu_name>__file_<log_name> |
@@ -179,7 +179,7 @@ discard block |
||
179 | 179 | foreach ($res_in_prog as $res) { |
180 | 180 | $wus_in_prog[$res->workunitid] = true; |
181 | 181 | } |
182 | - unset($res_in_progress); // does this do anything? |
|
182 | + unset($res_in_progress); // does this do anything? |
|
183 | 183 | |
184 | 184 | $fp_total = 0; |
185 | 185 | $fp_done = 0; |
@@ -352,7 +352,7 @@ discard block |
||
352 | 352 | // get the total size of output files of a batch |
353 | 353 | // |
354 | 354 | function batch_output_file_size($batchid) { |
355 | - $batch_td_size=0; |
|
355 | + $batch_td_size = 0; |
|
356 | 356 | $wus = BoincWorkunit::enum_fields( |
357 | 357 | 'canonical_resultid', |
358 | 358 | "batch=$batchid" |
@@ -385,7 +385,7 @@ discard block |
||
385 | 385 | } |
386 | 386 | |
387 | 387 | function boinc_get_wu_output_files_url($user, $wu_id) { |
388 | - $auth_str = md5($user->authenticator.$wu_id); |
|
388 | + $auth_str = md5($user->authenticator.$wu_id); |
|
389 | 389 | return "get_output.php?cmd=workunit_files&wu_id=$wu_id&auth_str=$auth_str"; |
390 | 390 | } |
391 | 391 | |
@@ -419,7 +419,7 @@ discard block |
||
419 | 419 | if (!file_exists($path)) return null; |
420 | 420 | $x = file_get_contents($path); |
421 | 421 | $n = sscanf($x, "%s %d", $md5, $size); |
422 | - if ($n != 2 || strlen($md5)!=32) { |
|
422 | + if ($n != 2 || strlen($md5) != 32) { |
|
423 | 423 | return null; |
424 | 424 | } |
425 | 425 | return [$md5, $size]; |
@@ -85,7 +85,7 @@ discard block |
||
85 | 85 | // |
86 | 86 | function unzip_batch_file($user, $batch_file) { |
87 | 87 | @mkdir("../../buda_batches"); |
88 | - for ($i=0; $i<1000; $i++) { |
|
88 | + for ($i = 0; $i < 1000; $i++) { |
|
89 | 89 | $batch_dir = "../../buda_batches/$i"; |
90 | 90 | $batch_dir_name = $i; |
91 | 91 | $ret = @mkdir($batch_dir); |
@@ -136,7 +136,7 @@ discard block |
||
136 | 136 | } |
137 | 137 | $job_files = []; |
138 | 138 | $cmdline = ''; |
139 | - foreach(scandir("$batch_dir/$fname") as $f2) { |
|
139 | + foreach (scandir("$batch_dir/$fname") as $f2) { |
|
140 | 140 | if ($f2[0] == '.') continue; |
141 | 141 | if ($f2 == 'cmdline') { |
142 | 142 | $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline")); |
@@ -186,7 +186,7 @@ discard block |
||
186 | 186 | function stage_input_files($batch_dir, $batch_desc, $batch_id) { |
187 | 187 | $n = count($batch_desc->shared_files); |
188 | 188 | $batch_desc->shared_files_phys_names = []; |
189 | - for ($i=0; $i<$n; $i++) { |
|
189 | + for ($i = 0; $i < $n; $i++) { |
|
190 | 190 | $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]); |
191 | 191 | [$md5, $size] = $batch_desc->shared_file_infos[$i]; |
192 | 192 | $phys_name = sprintf('batch_%d_%s', $batch_id, $md5); |
@@ -196,7 +196,7 @@ discard block |
||
196 | 196 | foreach ($batch_desc->jobs as $job) { |
197 | 197 | $n = count($batch_desc->unshared_files); |
198 | 198 | $job->phys_names = []; |
199 | - for ($i=0; $i<$n; $i++) { |
|
199 | + for ($i = 0; $i < $n; $i++) { |
|
200 | 200 | $path = sprintf('%s/%s/%s', |
201 | 201 | $batch_dir, $job->dir, $batch_desc->unshared_files[$i] |
202 | 202 | ); |
@@ -245,7 +245,7 @@ discard block |
||
245 | 245 | } |
246 | 246 | $wrapper_cmdline = sprintf('"--dockerfile %s %s %s"', |
247 | 247 | $variant_desc->dockerfile, |
248 | - $wrapper_verbose?'--verbose':'', |
|
248 | + $wrapper_verbose ? '--verbose' : '', |
|
249 | 249 | $cmdline |
250 | 250 | ); |
251 | 251 | $cmd = sprintf( |
@@ -294,7 +294,7 @@ discard block |
||
294 | 294 | $max_runtime_days = (double)$max_runtime_days; |
295 | 295 | if ($max_runtime_days <= 0) error_page('bad runtime limit'); |
296 | 296 | if ($max_runtime_days > 100) error_page('bad runtime limit'); |
297 | - $max_fpops = $max_runtime_days * 4.3e9 * 86400; |
|
297 | + $max_fpops = $max_runtime_days*4.3e9*86400; |
|
298 | 298 | |
299 | 299 | $exp_runtime_days = get_str('exp_runtime_days'); |
300 | 300 | if (!is_numeric($exp_runtime_days)) error_page('bad expected runtime'); |
@@ -304,7 +304,7 @@ discard block |
||
304 | 304 | if ($exp_runtime_days > $max_runtime_days) { |
305 | 305 | error_page('exp must be < max runtime'); |
306 | 306 | } |
307 | - $exp_fpops = $exp_runtime_days * 4.3e9 * 86400; |
|
307 | + $exp_fpops = $exp_runtime_days*4.3e9*86400; |
|
308 | 308 | |
309 | 309 | $app_desc = get_buda_desc($app); |
310 | 310 |
@@ -5,7 +5,7 @@ |
||
5 | 5 | require_once('../inc/util.inc'); |
6 | 6 | require_once('../inc/sandbox.inc'); |
7 | 7 | |
8 | -function sb_file_select($user, $suffix=null) { |
|
8 | +function sb_file_select($user, $suffix = null) { |
|
9 | 9 | $sbfiles = sandbox_file_names($user); |
10 | 10 | $sbitems = []; |
11 | 11 | $exp = null; |
@@ -30,14 +30,14 @@ discard block |
||
30 | 30 | $master_url = master_url(); |
31 | 31 | $idx = strpos($master_url, '://'); |
32 | 32 | if ($idx) { |
33 | - $url = substr($master_url, $idx+strlen('://')); |
|
33 | + $url = substr($master_url, $idx + strlen('://')); |
|
34 | 34 | } else { |
35 | 35 | $url = $master_url; |
36 | 36 | } |
37 | 37 | |
38 | 38 | // convert invalid characters into underscores |
39 | 39 | // |
40 | -for ($i=0; $i<strlen($url); $i++) { |
|
40 | +for ($i = 0; $i < strlen($url); $i++) { |
|
41 | 41 | $c = $url[$i]; |
42 | 42 | if (!ctype_alnum($c) && $c != '.' && $c != '-' && $c != '_') { |
43 | 43 | $url[$i] = '_'; |
@@ -46,7 +46,7 @@ discard block |
||
46 | 46 | |
47 | 47 | //remove trailing underscore(s) |
48 | 48 | // |
49 | -$account_file = "account_" . rtrim($url, '_') . ".xml"; |
|
49 | +$account_file = "account_".rtrim($url, '_').".xml"; |
|
50 | 50 | |
51 | 51 | page_head(tra("Account keys")); |
52 | 52 | text_start(); |
@@ -58,12 +58,12 @@ discard block |
||
58 | 58 | <p>", |
59 | 59 | tra("This key can be used to:"), |
60 | 60 | "<ul> |
61 | - <li><a href=get_passwd.php>",tra("log in to your account on the web"),"</a>; |
|
61 | + <li><a href=get_passwd.php>",tra("log in to your account on the web"), "</a>; |
|
62 | 62 | <li>", |
63 | 63 | tra("attach a computer to your account without using the BOINC Manager. |
64 | 64 | To do so, install BOINC, |
65 | 65 | create a file named %1 in the BOINC |
66 | - data directory, and set its contents to:","<b>$account_file</b>")," |
|
66 | + data directory, and set its contents to:","<b>$account_file</b>"), " |
|
67 | 67 | <p><pre>", |
68 | 68 | htmlspecialchars( |
69 | 69 | "<account> |
@@ -77,10 +77,10 @@ discard block |
||
77 | 77 | as described above, but cannot be used to log in to your account or change it in any way. |
78 | 78 | If you want to attach untrusted or insecure computers to your account, |
79 | 79 | do so using your weak account key. |
80 | - Your weak account key is:")," |
|
80 | + Your weak account key is:"), " |
|
81 | 81 | <p><pre>$weak_auth</pre><p> |
82 | 82 | ", |
83 | - tra("The key depends on your account's email address and password. If you change either of these, the weak account key will change.")," |
|
83 | + tra("The key depends on your account's email address and password. If you change either of these, the weak account key will change."), " |
|
84 | 84 | </td></tr></table>" |
85 | 85 | ; |
86 | 86 | text_end(); |
@@ -199,25 +199,25 @@ discard block |
||
199 | 199 | $min = 1e99; |
200 | 200 | $max = 0; |
201 | 201 | foreach ($results as $r) { |
202 | - $f = $r->flops / (4.3e9 *3600); |
|
202 | + $f = $r->flops/(4.3e9*3600); |
|
203 | 203 | if ($f > $max) $max = $f; |
204 | 204 | if ($f < $min) $min = $f; |
205 | 205 | $x[] = $f; |
206 | 206 | } |
207 | 207 | $n = 800; |
208 | 208 | $count = []; |
209 | - for ($i=0; $i<$n; $i++) { |
|
209 | + for ($i = 0; $i < $n; $i++) { |
|
210 | 210 | $count[$i] = 0; |
211 | 211 | } |
212 | 212 | $range = $max - $min; |
213 | 213 | foreach ($x as $f) { |
214 | - $d = intval($n*($f-$min)/$range); |
|
215 | - if ($d >= $n) $d = $n-1; |
|
214 | + $d = intval($n*($f - $min)/$range); |
|
215 | + if ($d >= $n) $d = $n - 1; |
|
216 | 216 | $count[$d] += 1; |
217 | 217 | } |
218 | 218 | $data = []; |
219 | - for ($i=0; $i<$n; $i++) { |
|
220 | - $data[] = [$min+($i*$range)/$n, $count[$i]]; |
|
219 | + for ($i = 0; $i < $n; $i++) { |
|
220 | + $data[] = [$min + ($i*$range)/$n, $count[$i]]; |
|
221 | 221 | } |
222 | 222 | graph($data, 'hours', 'count'); |
223 | 223 | page_tail(); |
@@ -225,7 +225,7 @@ discard block |
||
225 | 225 | |
226 | 226 | $batch = BoincBatch::lookup_id(get_int('batch_id')); |
227 | 227 | if (!$batch) error_page('no batch'); |
228 | -switch(get_str('action')) { |
|
228 | +switch (get_str('action')) { |
|
229 | 229 | case 'err_host': |
230 | 230 | err_host($batch); |
231 | 231 | break; |
@@ -183,7 +183,7 @@ |
||
183 | 183 | } |
184 | 184 | |
185 | 185 | function flops_graph($batch) { |
186 | - page_head("Batch $batch->id job runtimes"); |
|
186 | + page_head("batch $batch->id job runtimes"); |
|
187 | 187 | echo " |
188 | 188 | <p> |
189 | 189 | Runtimes of completed jobs, normalized to an average (4.3 GFLOPS) computer. |