BOINC / boinc

html/user/manage_project.php

Spacing +7 added lines, -7 removed lines

@@ -38,7 +38,7 @@ 
             $app = BoincApp::lookup_id($ua->app_id);
             $names[] = $app->name;
         }
-        $sub = $names?implode(', ', $names):'---';
+        $sub = $names ?implode(', ', $names) : '---';
     }
     if ($u->manage_all) {
         $admin = 'All applications';
@@ -49,7 +49,7 @@ 
             $app = BoincApp::lookup_id($ua->app_id);
             $names[] = $app->name;
         }
-        $admin = $names?implode(', ', $names):'---';
+        $admin = $names ?implode(', ', $names) : '---';
     }
     [$yes, $no] = read_kw_prefs($user);
     global $job_keywords;
@@ -69,7 +69,7 @@ 
         implode('<br>', $kws),
         $u->quota,
         $u->max_jobs_in_progress,
-        ($u->logical_start_time > time())?local_time_str($u->logical_start_time):'---'
+        ($u->logical_start_time > time()) ?local_time_str($u->logical_start_time) : '---'
     );
 }
 
@@ -148,7 +148,7 @@ 
         'max_jobs_in_progress', $usub->max_jobs_in_progress
     );
     form_general('Run jobs only on own computers?',
-        $user->seti_id?'yes':'no'
+        $user->seti_id ? 'yes' : 'no'
     );
     form_submit('Update');
     form_end();
@@ -204,18 +204,18 @@ 
     $manage_apps = array_map('intval', $manage_apps);
     foreach ($apps as $app) {
         $s = in_array($app->id, $submit_apps);
-        $m = in_array($app->id, $manage_apps)?1:0;
+        $m = in_array($app->id, $manage_apps) ? 1 : 0;
         if ($s || $m) {
             BoincUserSubmitApp::insert(
                 "(user_id, app_id, manage) values ($user_id, $app->id, $m)"
             );
         }
     }
-    $quota = (double) get_str('quota');
+    $quota = (double)get_str('quota');
     if ($quota != $us->quota) {
         $us->update("quota=$quota");
     }
-    $mj = (int) get_str('max_jobs_in_progress');
+    $mj = (int)get_str('max_jobs_in_progress');
     if ($mj != $us->max_jobs_in_progress) {
         $us->update("max_jobs_in_progress=$mj");
     }

html/user/submit.php

Spacing +5 added lines, -5 removed lines

@@ -674,7 +674,7 @@ 
         );
     }
     row2("Submitted", time_str($batch->create_time));
-    row2("Application", $app?$app->name:'---');
+    row2("Application", $app ? $app->name : '---');
     row2("State", batch_state_string($batch->state));
     //row2("# jobs", $batch->njobs);
     //row2("# error jobs", $batch->nerror_jobs);
@@ -764,11 +764,11 @@ 
         "GFLOPS-hours"
     ];
     row_heading_array($x);
-    foreach($wus as $wu) {
+    foreach ($wus as $wu) {
         if ($status && $wu->status != $status) continue;
         $y = '';
         $c = '---';
-        switch($wu->status) {
+        switch ($wu->status) {
         case WU_SUCCESS:
             $resultid = $wu->canonical_resultid;
             $y = sprintf('<font color="%s">completed</font>', COLOR_SUCCESS);
@@ -859,7 +859,7 @@ 
             if ($result->id == $wu->canonical_resultid) {
                 $log_names = get_outfile_log_names($result);
                 $nfiles = count($log_names);
-                for ($i=0; $i<$nfiles; $i++) {
+                for ($i = 0; $i < $nfiles; $i++) {
                     $name = $log_names[$i];
                     // don't show 'view' link if it's a .zip
                     $y = "$name: ";
@@ -883,7 +883,7 @@ 
                 $phys_names = get_outfile_phys_names($result);
                 $log_names = get_outfile_log_names($result);
                 $nfiles = count($log_names);
-                for ($i=0; $i<$nfiles; $i++) {
+                for ($i = 0; $i < $nfiles; $i++) {
                     $path = dir_hier_path(
                         $phys_names[$i], $upload_dir, $fanout
                     );

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -661,7 +661,7 @@ 
 
     $is_assim_move = is_assim_move($app);
 
-    page_head("Batch $batch_id");
+    page_head("batch $batch_id");
     text_start(800);
     start_table();
     row2("Batch name", $batch->name);
@@ -963,7 +963,7 @@ 
 
     if (get_int('confirmed', true)) {
         abort_batch($batch);
-        page_head("Batch $batch_id aborted");
+        page_head("batch $batch_id aborted");
         return_link();
         page_tail();
     } else {
@@ -993,7 +993,7 @@ 
 
     if (get_int('confirmed', true)) {
         retire_batch($batch);
-        page_head("Batch $batch_id retired");
+        page_head("batch $batch_id retired");
         return_link();
         page_tail();
     } else {

html/ops/submit_retire.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -166,7 +166,7 @@
     foreach ($batches as $batch) {
         $n = BoincWorkunit::count("batch=$batch->id");
         if ($n == 0) {
-            echo "Batch $batch->id has no jobs\n";
+            echo "batch $batch->id has no jobs\n";
             retire_batch($batch);
         }
     }

html/user/buda_submit.php

Spacing +7 added lines, -7 removed lines

@@ -96,7 +96,7 @@ 
 //
 function unzip_batch_file($user, $batch_file) {
     @mkdir("../../buda_batches");
-    for ($i=0; $i<1000; $i++) {
+    for ($i = 0; $i < 1000; $i++) {
         $batch_dir = "../../buda_batches/$i";
         $batch_dir_name = $i;
         $ret = @mkdir($batch_dir);
@@ -147,7 +147,7 @@ 
         }
         $job_files = [];
         $cmdline = '';
-        foreach(scandir("$batch_dir/$fname") as $f2) {
+        foreach (scandir("$batch_dir/$fname") as $f2) {
             if ($f2[0] == '.') continue;
             if ($f2 == 'cmdline') {
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -201,7 +201,7 @@ 
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
     $n = count($batch_desc->shared_files);
     $batch_desc->shared_files_phys_names = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -211,7 +211,7 @@ 
     foreach ($batch_desc->jobs as $job) {
         $n = count($batch_desc->unshared_files);
         $job->phys_names = [];
-        for ($i=0; $i<$n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $path = sprintf('%s/%s/%s',
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
             );
@@ -250,7 +250,7 @@ 
         $job_cmds .= "$job_cmd\n";
     }
     $wrapper_cmdline = sprintf('"%s %s"',
-        $wrapper_verbose?'--verbose':'',
+        $wrapper_verbose ? '--verbose' : '',
         $cmdline
     );
     $cmd = sprintf(
@@ -301,7 +301,7 @@ 
     if ($max_runtime_days <= 0) error_page('bad runtime limit');
     if ($max_runtime_days > 100) error_page('bad runtime limit');
 
-    $max_fpops = $max_runtime_days * AVG_CPU_FPOPS * 86400;
+    $max_fpops = $max_runtime_days*AVG_CPU_FPOPS*86400;
 
     $exp_runtime_days = get_str('exp_runtime_days');
     if (!is_numeric($exp_runtime_days)) error_page('bad expected runtime');
@@ -311,7 +311,7 @@ 
     if ($exp_runtime_days > $max_runtime_days) {
         error_page('exp must be < max runtime');
     }
-    $exp_fpops = $exp_runtime_days * AVG_CPU_FPOPS * 86400;
+    $exp_fpops = $exp_runtime_days*AVG_CPU_FPOPS*86400;
 
     $app_desc = get_buda_app_desc($app);
 

html/ops/batch_accel.php

Spacing +2 added lines, -2 removed lines

@@ -62,7 +62,7 @@ 
                         break;
                     }
                     $age = $now - $r->sent_time;
-                    if ($age<$batch->expire_time) {
+                    if ($age < $batch->expire_time) {
                         $make_another_result = false;
                         break;
                     }
@@ -72,7 +72,7 @@ 
             if ($make_another_result) {
                 echo "creating another instance for WU $wu->id\n";
                 $query[] = sprintf(
-                    'target_nresults=%d', $wu->target_nresults+1
+                    'target_nresults=%d', $wu->target_nresults + 1
                 );
                 $query[] = sprintf(
                     'transition_time=%f', $now

html/ops/batch_stats.php

Spacing +5 added lines, -5 removed lines

@@ -126,7 +126,7 @@ 
     BoincHost::update_aux("error_rate=0");
     $ltts = [];
     foreach ($hosts as $id=>$x) {
-        $avg = $x->ntt_sum / $x->ntt_n;
+        $avg = $x->ntt_sum/$x->ntt_n;
         if ($avg < 1) {
             $ltts[] = $id;
         }
@@ -150,7 +150,7 @@ 
             $nfast = 0;
             foreach ($hlist as $id=>$count) {
                 $x = $hosts[$id];
-                $avg = $x->ntt_sum / $x->ntt_n;
+                $avg = $x->ntt_sum/$x->ntt_n;
                 if ($avg < 1) {
                     $nfast++;
                 }
@@ -165,7 +165,7 @@ 
         }
 
         $app->update(
-            sprintf('n_size_classes=%d', $accel?1:0)
+            sprintf('n_size_classes=%d', $accel ? 1 : 0)
         );
     }
 }
@@ -186,14 +186,14 @@ 
     foreach ($as as $a) {
         $apps[$a->id] = [];
     }
-    $start = time()-30*86400;
+    $start = time() - 30*86400;
     $batches = BoincBatch::enum(
         sprintf(
             'create_time>%d and state in (%d, %d)',
             $start, BATCH_STATE_IN_PROGRESS, BATCH_STATE_COMPLETE
         )
     );
-    foreach($batches as $batch) {
+    foreach ($batches as $batch) {
         do_batch($batch);
     }
     update_db();

html/user/submit_stats.php

Spacing +6 added lines, -6 removed lines

@@ -238,18 +238,18 @@ 
     }
     $n = 100;
     $count = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $count[$i] = 0;
     }
     $range = $max - $min;
     foreach ($x as $f) {
-        $d = intval($n*($f-$min)/$range);
-        if ($d >= $n) $d = $n-1;
+        $d = intval($n*($f - $min)/$range);
+        if ($d >= $n) $d = $n - 1;
         $count[$d] += 1;
     }
     $data = [];
-    for ($i=0; $i<$n; $i++) {
-        $data[] = [$min+($i*$range)/$n, $count[$i]];
+    for ($i = 0; $i < $n; $i++) {
+        $data[] = [$min + ($i*$range)/$n, $count[$i]];
     }
     if ($flops) {
         graph($data, 'runtime', 'Job runtime (hours)', 'job count');
@@ -314,7 +314,7 @@ 
 
 $batch = BoincBatch::lookup_id(get_int('batch_id'));
 if (!$batch) error_page('no batch');
-switch(get_str('action')) {
+switch (get_str('action')) {
 case 'err_host':
     err_host($batch);
     break;

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -217,7 +217,7 @@ 
             )
         );
     } else {
-        page_head("Batch $batch->id turnaround times");
+        page_head("batch $batch->id turnaround times");
         echo "<p>Turnaround times of completed jobs.<p>";
         $results = BoincResult::enum_fields(
             '(received_time-sent_time)/3600 as val',
@@ -265,7 +265,7 @@ 
 }
 
 function batch_graphs($batch) {
-    page_head("Batch $batch->id job times");
+    page_head("batch $batch->id job times");
     echo "
         <script type=\"text/javascript\" src=\"https://www.gstatic.com/charts/loader.js\"></script>
     ";
@@ -295,7 +295,7 @@ 
         }
     }
     arsort($x);
-    page_head("Batch $batch->id: completed jobs grouped by host");
+    page_head("batch $batch->id: completed jobs grouped by host");
     text_start();
     start_table();
     table_header('Host', 'OS', '# jobs');

html/inc/db_conn.inc

Spacing +9 added lines, -9 removed lines

@@ -22,12 +22,12 @@ 
 // Intended to be subclassed (e.g., BoincDb, BossaDb)
 //
 class DbConn {
-    var $db_conn;       // a mysqli object
-    var $db_name;       // the DB name
+    var $db_conn; // a mysqli object
+    var $db_name; // the DB name
 
     function init_conn($user, $passwd, $host, $name) {
         $x = explode(":", $host);
-        if (sizeof($x)>1) {
+        if (sizeof($x) > 1) {
             $host = $x[0];
             $port = $x[1];
         } else {
@@ -35,7 +35,7 @@ 
         }
         try {
             $this->db_conn = @new mysqli($host, $user, $passwd, $name, $port);
-        } catch(Exception $e) {
+        } catch (Exception $e) {
             return false;
         }
         if (mysqli_connect_error()) {
@@ -136,7 +136,7 @@ 
         return $this->enum_general($classname, $query);
     }
 
-    function enum($table, $classname, $where_clause=null, $order_clause=null) {
+    function enum($table, $classname, $where_clause = null, $order_clause = null) {
         return self::enum_fields(
             $table, $classname, '*', $where_clause, $order_clause
         );
@@ -146,7 +146,7 @@ 
         $query = "update DBNAME.$table set $clause where id=$obj->id";
         return $this->do_query($query);
     }
-    function update_aux($table, $clause, $where='') {
+    function update_aux($table, $clause, $where = '') {
         if ($where) $where = " where $where";
         $query = "update DBNAME.$table set $clause $where";
         return $this->do_query($query);
@@ -182,15 +182,15 @@ 
         if ($x) return (double)$x->$field;
         return false;
     }
-    function count($table, $clause="TRUE") {
+    function count($table, $clause = "TRUE") {
         $query = "select count(*) as total from DBNAME.$table where $clause";
         return $this->get_int($query, 'total');
     }
-    function sum($table, $field, $clause="") {
+    function sum($table, $field, $clause = "") {
         $query = "select sum($field) as total from DBNAME.$table $clause";
         return $this->get_double($query, 'total');
     }
-    function max($table, $field, $clause="") {
+    function max($table, $field, $clause = "") {
         $query = "select max($field) as total from DBNAME.$table $clause";
         return $this->get_double($query, 'total');
     }

html/inc/util_basic.inc

Spacing +7 added lines, -7 removed lines

@@ -56,10 +56,10 @@ 
     return file_exists("$d/stop_sched");
 }
 
-function xml_error($num=-1, $msg=null, $file=null, $line=null) {
+function xml_error($num = -1, $msg = null, $file = null, $line = null) {
     global $xml_outer_tag;
     if (!$msg) {
-        switch($num) {
+        switch ($num) {
         case -112: $msg = "Invalid XML"; break;
         case -136: $msg = "Not found"; break;
         case -137: $msg = "Name or email address is not unique"; break;
@@ -104,7 +104,7 @@ 
 // If it's a single-tag element, and it's present, just return the tag
 //
 function parse_element($xml, $tag) {
-    $closetag = "</" . substr($tag,1);
+    $closetag = "</".substr($tag, 1);
     $x = strstr($xml, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -120,8 +120,8 @@ 
 
 function parse_next_element($xml, $tag, &$cursor) {
     $element = null;
-    $closetag = "</" . substr($tag,1);
-    $pos = substr($xml,$cursor);
+    $closetag = "</".substr($tag, 1);
+    $pos = substr($xml, $cursor);
     $x = strstr($pos, $tag);
     if ($x) {
         if (strstr($tag, "/>")) return $tag;
@@ -203,7 +203,7 @@ 
 
 function time_str($x) {
     if ($x == 0) return "---";
-    return gmdate('j M Y, G:i:s', (int)$x) . " UTC";
+    return gmdate('j M Y, G:i:s', (int)$x)." UTC";
 }
 
 function local_time_str($x) {
@@ -241,7 +241,7 @@ 
 // ALSO: allow spaces.
 //
 function is_valid_filename($x) {
-    if (strlen($x)>255) return false;
+    if (strlen($x) > 255) return false;
     // \w means A-Za-z0-9_
     return preg_match('/^[\w\-. ]+$/', $x);
 }