BOINC / boinc

html/inc/account.inc

Doc Comments +7 added lines

@@ -18,6 +18,10 @@ 
 
 // forms for account creation and login
 
+/**
+ * @param integer $teamid
+ * @param string $next_url
+ */
 function create_account_form($teamid, $next_url) {
     global $recaptcha_public_key;
     echo "
@@ -92,6 +96,9 @@ 
     echo "</form>\n";
 }
 
+/**
+ * @param string $next_url
+ */
 function login_form($next_url) {
     echo "
         <form name=\"f\" method=\"post\" action=\"".secure_url_base()."/login_action.php\">

Indentation +4 added lines, -4 removed lines

@@ -35,10 +35,10 @@
     // Using invitation codes to restrict access?
     //
     if (defined('INVITE_CODES')) {
-         row2(
-             tra("Invitation Code")."<br><small>".tra("A valid invitation code is required to create an account.")."</small>",
-             '<input class="form-control" type="text" name="invite_code" size="30" >'
-         );
+            row2(
+                tra("Invitation Code")."<br><small>".tra("A valid invitation code is required to create an account.")."</small>",
+                '<input class="form-control" type="text" name="invite_code" size="30" >'
+            );
     }
 
     row2(

Spacing +1 added lines, -1 removed lines

@@ -107,7 +107,7 @@
         $x .= '<br><small><a href="get_passwd.php">'.tra("forgot email address?")."</a></small>";
     }
     row2($x, '<input class="form-control" name=email_addr type="text" size=40 tabindex=1>');
-    row2(tra("Password:") . '<br><small><a href="get_passwd.php">' . tra("forgot password?") . "</a></small>",
+    row2(tra("Password:").'<br><small><a href="get_passwd.php">'.tra("forgot password?")."</a></small>",
         '<input class="form-control" type="password" name="passwd" size="40" tabindex="2">'
     );
     row2(tra("Stay logged in"),

html/inc/akismet.inc

Doc Comments +3 added lines

@@ -52,6 +52,9 @@
     }
 }
 
+/**
+ * @param string $path
+ */
 function akismet_request($request, $host, $path, $port = 80) {
     $http_request  = "POST $path HTTP/1.0\r\n";
     $http_request .= "Host: $host\r\n";

Spacing +4 added lines, -4 removed lines

@@ -26,7 +26,7 @@ 
 
     $master_url_enc = urlencode($master_url);
     $response = akismet_request("key=$key&blog=$master_url_enc", "rest.akismet.com", "/1.1/verify-key");
-    if ("valid" == $response[1] ) {
+    if ("valid" == $response[1]) {
         $post = urlencode($post);
         $ip = urlencode($_SERVER['REMOTE_ADDR']);
         $referrer = urlencode($_SERVER['HTTP_REFERER']);
@@ -56,15 +56,15 @@ 
     $http_request  = "POST $path HTTP/1.0\r\n";
     $http_request .= "Host: $host\r\n";
     $http_request .= "Content-Type: application/x-www-form-urlencoded; charset=utf-8\r\n";
-    $http_request .= "Content-Length: " . strlen($request) . "\r\n";
+    $http_request .= "Content-Length: ".strlen($request)."\r\n";
     $http_request .= "User-Agent: BOINC | Akismet 1.1\r\n";
     $http_request .= "\r\n";
     $http_request .= $request;
 
     $response = '';
-    if( false !== ( $fs = @fsockopen($host, $port, $errno, $errstr, 3) ) ) {
+    if (false !== ($fs = @fsockopen($host, $port, $errno, $errstr, 3))) {
         fwrite($fs, $http_request);
-        while ( !feof($fs) )
+        while (!feof($fs))
             $response .= fgets($fs, 1160); // One TCP-IP packet
         fclose($fs);
         $response = explode("\r\n\r\n", $response, 2);

Braces +6 added lines, -3 removed lines

@@ -42,7 +42,8 @@ 
 
         $response = akismet_request($request, "$key.rest.akismet.com", "/1.1/comment-check");
 
-        if ("true" == $response[1]) { // Akismet says it's spam
+        if ("true" == $response[1]) {
+// Akismet says it's spam
             return false;
         } else {
             return true;
@@ -64,8 +65,10 @@ 
     $response = '';
     if( false !== ( $fs = @fsockopen($host, $port, $errno, $errstr, 3) ) ) {
         fwrite($fs, $http_request);
-        while ( !feof($fs) )
-            $response .= fgets($fs, 1160); // One TCP-IP packet
+        while ( !feof($fs) ) {
+                    $response .= fgets($fs, 1160);
+        }
+        // One TCP-IP packet
         fclose($fs);
         $response = explode("\r\n\r\n", $response, 2);
     }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -53,7 +53,7 @@
 }
 
 function akismet_request($request, $host, $path, $port = 80) {
-    $http_request  = "POST $path HTTP/1.0\r\n";
+    $http_request  = "post $path HTTP/1.0\r\n";
     $http_request .= "Host: $host\r\n";
     $http_request .= "Content-Type: application/x-www-form-urlencoded; charset=utf-8\r\n";
     $http_request .= "Content-Length: " . strlen($request) . "\r\n";

html/inc/boinc_db.inc

Doc Comments +107 added lines

@@ -40,6 +40,10 @@ 
     // 2: only use replica_db_user, only try replica_db_host
     // can be set projectwide using <replica_fallback_mode>
     //
+
+    /**
+     * @param boolean $readonly
+     */
     static function get_aux($readonly, $fallback_mode = 0) {
         $config = get_config();
         $user = parse_config($config, '<db_user>');
@@ -204,6 +208,10 @@ 
         $db = BoincDb::get();
         return $db->count('user', $clause);
     }
+
+    /**
+     * @param string $field
+     */
     static function max($field) {
         $db = BoincDb::get();
         return $db->max('user', $field);
@@ -216,6 +224,10 @@ 
         $db = BoincDb::get();
         return $db->enum('user', 'BoincUser', $where_clause, $order_clause);
     }
+
+    /**
+     * @param string $fields
+     */
     static function enum_fields($fields, $where_clause, $order_clause=null) {
         $db = BoincDb::get();
         return $db->enum_fields(
@@ -233,10 +245,19 @@ 
         $db->delete_aux('profile', "userid=$this->id");
         return $db->delete($this, 'user');
     }
+
+    /**
+     * @param string $field
+     */
     static function sum($field) {
         $db = BoincDb::get();
         return $db->sum('user', $field);
     }
+
+    /**
+     * @param string $field
+     * @param string $clause
+     */
     static function percentile($field, $clause, $pct) {
         $db = BoincDb::get();
         return $db->percentile('user', $field, $clause, $pct);
@@ -245,6 +266,10 @@ 
 
 class BoincTeam {
     static $cache;
+
+    /**
+     * @param string $clause
+     */
     static function insert($clause) {
         $db = BoincDb::get();
         $ret = $db->insert('team', $clause);
@@ -282,14 +307,27 @@ 
         $db = BoincDb::get();
         return $db->delete($this, 'team');
     }
+
+    /**
+     * @param string $field
+     * @param string $clause
+     */
     static function percentile($field, $clause, $pct) {
         $db = BoincDb::get();
         return $db->percentile('team', $field, $clause, $pct);
     }
+
+    /**
+     * @param string $field
+     */
     static function max($field) {
         $db = BoincDb::get();
         return $db->max('team', $field);
     }
+
+    /**
+     * @param string $fields
+     */
     static function enum_fields($fields, $where_clause, $order_clause=null) {
         $db = BoincDb::get();
         return $db->enum_fields(
@@ -326,6 +364,12 @@ 
         $db = BoincDb::get();
         return $db->enum('host', 'BoincHost', $where_clause, $order_clause);
     }
+
+    /**
+     * @param string $fields
+     * @param string $where_clause
+     * @param string $order_clause
+     */
     static function enum_fields($fields, $where_clause, $order_clause=null) {
         $db = BoincDb::get();
         return $db->enum_fields(
@@ -358,6 +402,10 @@ 
         $db = BoincDb::get();
         return $db->enum('result', 'BoincResult', $where_clause);
     }
+
+	/**
+	 * @param string $fields
+	 */
 	static function enum_fields($fields, $where_clause, $order_clause) {
         $db = BoincDb::get();
 		return $db->enum_fields('result', 'BoincResult', $fields, $where_clause, $order_clause);
@@ -412,6 +460,10 @@ 
         $db = BoincDb::get();
         return $db->update_aux('workunit', $clause);
     }
+
+    /**
+     * @param string $clause
+     */
     static function count($clause) {
         $db = BoincDb::get();
         return $db->count('workunit', $clause);
@@ -427,6 +479,10 @@ 
         $db = BoincDb::get();
         return $db->lookup('app', 'BoincApp', $clause);
     }
+
+    /**
+     * @param string $where_clause
+     */
     static function enum($where_clause) {
         $db = BoincDb::get();
         return $db->enum('app', 'BoincApp', $where_clause);
@@ -441,6 +497,11 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'app', $clause);
     }
+
+    /**
+     * @param string $field
+     * @param string $clause
+     */
     static function sum($field, $clause=null) {
         $db = BoincDb::get();
         return $db->sum('app', $field, $clause);
@@ -473,6 +534,10 @@ 
 }
 
 class BoincProfile {
+
+    /**
+     * @param string $fields
+     */
     static function lookup_fields($fields, $clause) {
         $db = BoincDb::get();
         return $db->lookup_fields('profile', 'BoincProfile', $fields, $clause);
@@ -489,18 +554,37 @@ 
         $db = BoincDb::get();
         return $db->update_aux('profile', $clause.' where userid='.$this->userid);
     }
+
+    /**
+     * @param string $clause
+     */
     static function update_aux($clause) {
         $db = BoincDb::get();
         return $db->update_aux('profile', $clause);
     }
+
+    /**
+     * @param string $clause
+     */
     static function insert($clause) {
         $db = BoincDb::get();
         return $db->insert('profile', $clause);
     }
+
+    /**
+     * @param string $where_clause
+     * @param string $order_clause
+     */
     static function enum($where_clause=null, $order_clause=null) {
         $db = BoincDb::get();
         return $db->enum('profile', 'BoincProfile', $where_clause, $order_clause);
     }
+
+    /**
+     * @param string $fields
+     * @param string $where_clause
+     * @param string $order_clause
+     */
     static function enum_fields($fields, $where_clause=null, $order_clause=null) {
         $db = BoincDb::get();
         return $db->enum_fields('profile', 'BoincProfile', $fields, $where_clause, $order_clause);
@@ -568,6 +652,10 @@ 
 }
 
 class BoincPlatform {
+
+    /**
+     * @param string $where_clause
+     */
     static function enum($where_clause) {
         $db = BoincDb::get();
         return $db->enum('platform', 'BoincPlatform', $where_clause);
@@ -648,6 +736,10 @@ 
 }
 
 class BoincBadge {
+
+    /**
+     * @param string $where_clause
+     */
     static function enum($where_clause) {
         $db = BoincDb::get();
         return $db->enum('badge', 'BoincBadge', $where_clause);
@@ -743,6 +835,11 @@ 
         $db = BoincDb::get();
         return $db->enum('credit_user', 'BoincCreditUser', $where_clause);
     }
+
+    /**
+     * @param string $field
+     * @param string $clause
+     */
     static function sum($field, $clause) {
         $db = BoincDb::get();
         return $db->sum('credit_user', $field, $clause);
@@ -766,6 +863,11 @@ 
         $db = BoincDb::get();
         return $db->enum('credit_team', 'BoincCreditTeam', $where_clause);
     }
+
+    /**
+     * @param string $field
+     * @param string $clause
+     */
     static function sum($field, $clause) {
         $db = BoincDb::get();
         return $db->sum('credit_team', $field, $clause);
@@ -780,6 +882,11 @@ 
 // 
 // apply this to any user-supplied strings used in queries
 // 
+/**
+ * @param string $x
+ *
+ * @return string
+ */
 function boinc_real_escape_string($x) {
     if (version_compare(phpversion(),"4.3.0")>=0) {
         return BoincDb::escape_string($x);

Indentation +3 added lines, -3 removed lines

@@ -358,10 +358,10 @@
         $db = BoincDb::get();
         return $db->enum('result', 'BoincResult', $where_clause);
     }
-	static function enum_fields($fields, $where_clause, $order_clause) {
+    static function enum_fields($fields, $where_clause, $order_clause) {
         $db = BoincDb::get();
-		return $db->enum_fields('result', 'BoincResult', $fields, $where_clause, $order_clause);
-	}
+        return $db->enum_fields('result', 'BoincResult', $fields, $where_clause, $order_clause);
+    }
     function update($clause) {
         $db = BoincDb::get();
         return $db->update($this, 'result', $clause);

Spacing +10 added lines, -10 removed lines

@@ -212,11 +212,11 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'user', $clause);
     }
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('user', 'BoincUser', $where_clause, $order_clause);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields(
             'user', 'BoincUser', $fields, $where_clause, $order_clause
@@ -265,7 +265,7 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'team', $clause);
     }
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('team', 'BoincTeam', $where_clause, $order_clause);
     }
@@ -290,7 +290,7 @@ 
         $db = BoincDb::get();
         return $db->max('team', $field);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields(
             'team', 'BoincTeam', $fields, $where_clause, $order_clause
@@ -322,11 +322,11 @@ 
         $db = BoincDb::get();
         return $db->delete($this, 'host');
     }
-    static function enum($where_clause, $order_clause=null) {
+    static function enum($where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('host', 'BoincHost', $where_clause, $order_clause);
     }
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields(
             'host', 'BoincHost', $fields, $where_clause, $order_clause
@@ -441,7 +441,7 @@ 
         $db = BoincDb::get();
         return $db->update($this, 'app', $clause);
     }
-    static function sum($field, $clause=null) {
+    static function sum($field, $clause = null) {
         $db = BoincDb::get();
         return $db->sum('app', $field, $clause);
     }
@@ -497,11 +497,11 @@ 
         $db = BoincDb::get();
         return $db->insert('profile', $clause);
     }
-    static function enum($where_clause=null, $order_clause=null) {
+    static function enum($where_clause = null, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum('profile', 'BoincProfile', $where_clause, $order_clause);
     }
-    static function enum_fields($fields, $where_clause=null, $order_clause=null) {
+    static function enum_fields($fields, $where_clause = null, $order_clause = null) {
         $db = BoincDb::get();
         return $db->enum_fields('profile', 'BoincProfile', $fields, $where_clause, $order_clause);
     }
@@ -781,7 +781,7 @@ 
 // apply this to any user-supplied strings used in queries
 // 
 function boinc_real_escape_string($x) {
-    if (version_compare(phpversion(),"4.3.0")>=0) {
+    if (version_compare(phpversion(), "4.3.0") >= 0) {
         return BoincDb::escape_string($x);
     } else {
         $x = str_replace("'", "\'", $x);

html/inc/bolt.inc

Doc Comments +9 added lines

@@ -246,6 +246,9 @@ 
 
 }
 
+/**
+ * @param string $n
+ */
 function name($n) {
     return array('name', $n);
 }
@@ -254,10 +257,16 @@ 
     return array('title', $n);
 }
 
+/**
+ * @param integer $n
+ */
 function number($n) {
     return array('number', $n);
 }
 
+/**
+ * @param string $n
+ */
 function filename($n) {
     return array('filename', $n);
 }

Spacing +6 added lines, -6 removed lines

@@ -30,7 +30,7 @@ 
     public $title;
         // Optional; used when showing course history outline.
     public $is_item;
-    public $attrs;        // course-defined
+    public $attrs; // course-defined
 
     abstract function walk(&$iter, $incr, &$frac_done);
         // multi-purpose function for traversing a course.
@@ -55,7 +55,7 @@ 
             $this->query_string = null;
         } else {
             $this->filename = substr($filename, 0, $p);
-            $this->query_string = substr($filename, $p+1);
+            $this->query_string = substr($filename, $p + 1);
         }
         $this->name = $filename;
         $this->title = $title;
@@ -162,7 +162,7 @@ 
             // look up unit by name
             //
             $child = null;
-            for ($i=0; $i<$n; $i++) {
+            for ($i = 0; $i < $n; $i++) {
                 $c = $this->units[$i];
                 if ($c->name == $child_name) {
                     $child = $c;
@@ -177,7 +177,7 @@ 
                 if ($i >= $n) {
                     // and if index is too big, use last unit
                     //
-                    $i = $n-1;
+                    $i = $n - 1;
                 }
                 $child = $this->units[$i];
             }
@@ -197,7 +197,7 @@ 
                         $this->finished($iter);
                         return true;
                     } else {
-                        $i = ($i+1)%$n;
+                        $i = ($i + 1)%$n;
                     }
                 }
             }
@@ -235,7 +235,7 @@ 
         if (array_key_exists($this->name, $state)) {
             $state_rec = $state[$this->name];
             $child_name = $state_rec['child_name'];
-            foreach($this->units as $c) {
+            foreach ($this->units as $c) {
                 if ($c->name == $child_name) {
                     return $c;
                 }

html/inc/bolt_ex.inc

Doc Comments +8 added lines

@@ -240,6 +240,10 @@ 
 
 class BoltFitbField {
     public $textarea, $nrows, $ncols;
+
+    /**
+     * @param boolean $textarea
+     */
     function __construct($textarea, $nrows, $ncols) {
         $this->textarea = $textarea;
         $this->nrows = $nrows;
@@ -258,6 +262,10 @@ 
 class BoltFitbAnswer {
     public $type;   // 0=constant, 1=regexp, 2=func
     public $ans;
+
+    /**
+     * @param integer $type
+     */
     function __construct($type, $ans) {
         $this->type = $type;
         $this->ans = $ans;

Spacing +14 added lines, -14 removed lines

@@ -21,11 +21,11 @@ 
 // The following is a global var accessed by exercise functions.
 //
 $bolt_ex = null;
-$bolt_ex->mode = 0;     // input: SHOW/SCORE/ANSWER
-$bolt_ex->index = 0;    // input: sequence of this exercise in file
-$bolt_ex->score = 0;    // input/output: cumulative score (if mode = SCORE)
-$bolt_ex->weight = 0;   // input/output: cumulative weight
-$bolt_ex->query_string = "";    // user's response (if SCORE or ANSWER)
+$bolt_ex->mode = 0; // input: SHOW/SCORE/ANSWER
+$bolt_ex->index = 0; // input: sequence of this exercise in file
+$bolt_ex->score = 0; // input/output: cumulative score (if mode = SCORE)
+$bolt_ex->weight = 0; // input/output: cumulative weight
+$bolt_ex->query_string = ""; // user's response (if SCORE or ANSWER)
 
 function weight($w) {
     return array('weight', $w);
@@ -170,9 +170,9 @@ 
             $response = isset($$key);
             $r = $choice[1];
             $correct = ($r && $response) || (!$r && !$response);
-            $color = $correct?"#88ff88":"#ff8888";
-            table_row($c, $r?"yes":"no",
-                array($response?"yes":"no", "bgcolor=$color")
+            $color = $correct ? "#88ff88" : "#ff8888";
+            table_row($c, $r ? "yes" : "no",
+                array($response ? "yes" : "no", "bgcolor=$color")
             );
             $i++;
         }
@@ -215,11 +215,11 @@ 
         if ($y > $rect[3]) $right = false;
         $cx = $rect[0];
         $cy = $rect[2];
-        $sizex = $rect[1]-$rect[0];
-        $sizey = $rect[3]-$rect[2];
-        $ax = $x-4;
-        $ay = $y-4;
-        $color = $right?"green":"red";
+        $sizex = $rect[1] - $rect[0];
+        $sizey = $rect[3] - $rect[2];
+        $ax = $x - 4;
+        $ay = $y - 4;
+        $color = $right ? "green" : "red";
         if ($right) {
             echo "The point you selected (shown in green) is correct.";
         } else {
@@ -256,7 +256,7 @@ 
 }
 
 class BoltFitbAnswer {
-    public $type;   // 0=constant, 1=regexp, 2=func
+    public $type; // 0=constant, 1=regexp, 2=func
     public $ans;
     function __construct($type, $ans) {
         $this->type = $type;

html/inc/bolt_select.inc

Doc Comments +3 added lines

@@ -52,6 +52,9 @@
     }
 }
 
+/**
+ * @param string $n
+ */
 function valuator($n) {
     return array('valuator', $n);
 }

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
 
 function select_cmp($a, $b) {
     if ($a->value == $b->value) return 0;
-    return ($a->value < $b->value)?1:-1;
+    return ($a->value < $b->value) ? 1 : -1;
 }
 
 class BoltSelect extends BoltSet {

html/inc/bolt_snap.inc

Doc Comments +6 added lines

@@ -45,6 +45,9 @@ 
     return "../bolt_snap/compare_snapshot_$x";
 }
 
+/**
+ * @param null|integer $dur
+ */
 function write_compare_snapshot($course_id, $select_name, $xset_name, $dur) {
     $now = time();
     $start = $now - $dur*86400;
@@ -127,6 +130,9 @@ 
     return "../bolt_snap/map_snapshot_".$course_id;
 }
 
+/**
+ * @param null|integer $dur
+ */
 function write_map_snapshot($course_id, $dur) {
     $now = time();
     $start = $now - $dur*86400;

html/inc/bolt_util_ops.inc

Doc Comments +21 added lines

@@ -23,6 +23,9 @@ 
 
 // get names of units of a given type
 
+/**
+ * @param string $type
+ */
 function units_of_type($unit, $type) {
     $names = array();
     if (get_class($unit) == $type) {
@@ -118,6 +121,10 @@ 
 
 //////////// graph drawing
 
+/**
+ * @param integer $n
+ * @param integer $width
+ */
 function compare_bar($title, $n, $width, $lo, $hi) {
     $x1 = $width*$lo;
     $x2 = $width*($hi-$lo);
@@ -137,6 +144,9 @@ 
     ";
 }
 
+/**
+ * @param integer $width
+ */
 function compare_bar_insuff($title, $width) {
     return "
         <tr>
@@ -150,6 +160,10 @@ 
     ";
 }
 
+/**
+ * @param integer[] $x
+ * @param integer $width
+ */
 function outcome_graph($x, $width) {
     $n = $x[0]+$x[1]+$x[2];
     if (!$n) return empty_cell();
@@ -182,6 +196,9 @@ 
     return $s;
 }
 
+/**
+ * @param integer $w
+ */
 function time_graph($t, $w) {
     if ($t == 0) return "<td>---</td>";
     $x = (log10($t)+2)*$w/4;
@@ -193,6 +210,10 @@ 
     </td>";
 }
 
+/**
+ * @param integer $t
+ * @param integer $w
+ */
 function score_graph($t, $w) {
     if ($t == 0) return "<td>---</td>";
     $x = $t*$w;

Spacing +9 added lines, -9 removed lines

@@ -89,10 +89,10 @@ 
         $n++;
         $delta = $x - $m;
         $m += $delta/$n;
-        $m2 += $delta*($x-$m);
+        $m2 += $delta*($x - $m);
     }
     $mean = $m;
-    $stdev = sqrt($m2/($n-1));
+    $stdev = sqrt($m2/($n - 1));
 }
 
 // approximate the 90% confidence interval for the mean of an array
@@ -103,13 +103,13 @@ 
 
     // I'm too lazy to compute the t distribution
     $t_90 = 1.7;
-    $d = $t_90 * $stdev / sqrt($n);
+    $d = $t_90*$stdev/sqrt($n);
     $lo = $mean - $d;
     $hi = $mean + $d;
 }
 
 function test_stats() {
-    $a = array(1,1,1,1,0,1,1,1,3, 1, 1, 1, 1);
+    $a = array(1, 1, 1, 1, 0, 1, 1, 1, 3, 1, 1, 1, 1);
     mean_stdev($a, $mean, $stdev);
     echo "mean: $mean stdev: $stdev\n";
     conf_int_90($a, $lo, $hi);
@@ -120,7 +120,7 @@ 
 
 function compare_bar($title, $n, $width, $lo, $hi) {
     $x1 = $width*$lo;
-    $x2 = $width*($hi-$lo);
+    $x2 = $width*($hi - $lo);
     $a1 = number_format($lo*100);
     $a2 = number_format($hi*100);
     return "
@@ -151,12 +151,12 @@ 
 }
 
 function outcome_graph($x, $width) {
-    $n = $x[0]+$x[1]+$x[2];
+    $n = $x[0] + $x[1] + $x[2];
     if (!$n) return empty_cell();
     $x0 = $width*$x[1]/$n;
     $x1 = $width*$x[0]/$n;
     $x2 = $width*$x[2]/$n;
-    if ($x[1]/$n>0.05) {
+    if ($x[1]/$n > 0.05) {
         $t0 = number_format(100*$x[1]/$n)."%";
     } else {
         $t0 = "";
@@ -184,7 +184,7 @@ 
 
 function time_graph($t, $w) {
     if ($t == 0) return "<td>---</td>";
-    $x = (log10($t)+2)*$w/4;
+    $x = (log10($t) + 2)*$w/4;
     $t = number_format($t, 1);
     return "<td>
         <table class=bolt_bar><tr>
@@ -196,7 +196,7 @@ 
 function score_graph($t, $w) {
     if ($t == 0) return "<td>---</td>";
     $x = $t*$w;
-    $y = (1-$t)*$w;
+    $y = (1 - $t)*$w;
     $t = number_format($t*100);
     $s = "<td>
         <table class=bolt_bar><tr>

html/inc/bolt_xset.inc

Doc Comments +9 added lines

@@ -22,6 +22,9 @@ 
     public $weight;
     public $callback;
 
+    /**
+     * @param null|BoltRefresh $refresh
+     */
     function __construct(
         $name, $units, $number, $repeats, $refresh, $attrs, $callback, $weight
     ) {
@@ -156,10 +159,16 @@ 
 define('REPEAT', 2);
 define('NEXT', 4);
 
+/**
+ * @param integer $f
+ */
 function repeat($s, $u, $f) {
     return new BoltRepeat($s, $u, $f);
 }
 
+/**
+ * @param integer[] $a
+ */
 function refresh($a) {
     return new BoltRefresh($a);
 }

Spacing +6 added lines, -6 removed lines

@@ -52,7 +52,7 @@ 
         $nshown = $state_rec['nshown'];
         $state_rec['scores'][$nshown] = $score;
         $iter->state[$this->name] = $state_rec;
-        $is_last = ($nshown+1 == $this->ntoshow);
+        $is_last = ($nshown + 1 == $this->ntoshow);
         if (!$is_last) {
             return false;
         }
@@ -62,15 +62,15 @@ 
         //   - optionally create or update bolt_refresh record
         //
         $total_score = 0;
-        for ($i=0; $i<$nshown+1; $i++) {
+        for ($i = 0; $i < $nshown + 1; $i++) {
             $total_score += $state_rec['scores'][$i];
         }
-        $avg_score = $total_score/($nshown+1);
+        $avg_score = $total_score/($nshown + 1);
 
         $repeat = null;
         $least = 2;
         foreach ($this->repeats as $r) {
-            if ($avg_score < $r->score && $r->score<$least) {
+            if ($avg_score < $r->score && $r->score < $least) {
                 $repeat = $r;
                 $least = $r->score;
             }
@@ -134,7 +134,7 @@ 
     }
 }
 
-class BoltRefresh{
+class BoltRefresh {
     public $intervals;
     function __construct($i) {
         $this->intervals = $i;
@@ -191,7 +191,7 @@ 
             } else if (get_class($arg) == "BoltRepeat") {
                 $repeats[] = $arg;
             } else if (get_class($arg) == "BoltRefresh") {
-                $refresh= $arg;
+                $refresh = $arg;
             } else {
                 echo "Can't include object of type ".get_class($arg)." within an exercise set.";
             }

Braces +1 added lines, -1 removed lines

@@ -134,7 +134,7 @@
     }
 }
 
-class BoltRefresh{
+class BoltRefresh {
     public $intervals;
     function __construct($i) {
         $this->intervals = $i;