BOINC / boinc

html/user/submit_rpc_handler.php

Spacing +30 added lines, -30 removed lines

@@ -59,7 +59,7 @@ 
     if ($template) {
         $t = (double)$template->workunit->rsc_fpops_est;
     }
-    foreach($r->batch->job as $job) {
+    foreach ($r->batch->job as $job) {
         $y = (double)$job->rsc_fpops_est;
         if ($y) {
             $x += $y;
@@ -85,7 +85,7 @@ 
 function est_elapsed_time($r, $template) {
     // crude estimate: batch FLOPs / project FLOPS
     //
-    return batch_flop_count($r, $template) / project_flops();
+    return batch_flop_count($r, $template)/project_flops();
 }
 
 // if batch-level input template filename was given, read it;
@@ -95,9 +95,9 @@ 
 //
 function read_input_template($app, $r) {
     if ((isset($r->batch)) && (isset($r->batch->workunit_template_file)) && ($r->batch->workunit_template_file)) {
-        $path = project_dir() . "/templates/".$r->batch->workunit_template_file;
+        $path = project_dir()."/templates/".$r->batch->workunit_template_file;
     } else {
-        $path = project_dir() . "/templates/$app->name"."_in";
+        $path = project_dir()."/templates/$app->name"."_in";
     }
     if (file_exists($path)) {
         $x = simplexml_load_file($path);
@@ -145,7 +145,7 @@ 
 function validate_batch($jobs, $template) {
     $i = 0;
     $n = count($template->file_info);
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         $m = count($job->input_files);
         if ($n != $m) {
             log_write("wrong # of input files for job $i: need $n, got $m");
@@ -214,7 +214,7 @@ 
 // stage all the files
 //
 function stage_files(&$jobs, $user) {
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         foreach ($job->input_files as $file) {
             if ($file->mode != "remote") {
                 $file->name = stage_file($file, $user);
@@ -227,7 +227,7 @@ 
 //
 function submit_jobs(
     $jobs, $job_params, $app, $batch_id, $priority, $app_version_num,
-    $input_template_filename,        // batch-level; can also specify per job
+    $input_template_filename, // batch-level; can also specify per job
     $output_template_filename,
     $user
 ) {
@@ -237,7 +237,7 @@ 
     // one line per job
     //
     $x = "";
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         if ($job->name) {
             $x .= " --wu_name $job->name";
         }
@@ -272,7 +272,7 @@ 
         $x .= "\n";
     }
 
-    $cmd = "cd " . project_dir() . "; ./bin/create_work --appname $app->name --batch $batch_id";
+    $cmd = "cd ".project_dir()."; ./bin/create_work --appname $app->name --batch $batch_id";
 
     if ($user->seti_id) {
         $cmd .= " --target_user $user->id ";
@@ -380,7 +380,7 @@ 
 //
 function xml_get_jobs($r) {
     $jobs = array();
-    foreach($r->batch->job as $j) {
+    foreach ($r->batch->job as $j) {
         $job = new StdClass;
         $job->input_files = array();
         $job->command_line = (string)$j->command_line;
@@ -431,16 +431,16 @@ 
 //
 function logical_end_time($r, $jobs, $user, $app) {
     $total_flops = 0;
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         //print_r($job);
         if ($job->rsc_fpops_est) {
             $total_flops += $job->rsc_fpops_est;
         } else if ($job->input_template && $job->input_template->workunit->rsc_fpops_est) {
-            $total_flops += (double) $job->input_template->workunit->rsc_fpops_est;
+            $total_flops += (double)$job->input_template->workunit->rsc_fpops_est;
         } else if ($r->batch->job_params->rsc_fpops_est) {
-            $total_flops += (double) $r->batch->job_params->rsc_fpops_est;
+            $total_flops += (double)$r->batch->job_params->rsc_fpops_est;
         } else {
-            $x = (double) $template->workunit->rsc_fpops_est;
+            $x = (double)$template->workunit->rsc_fpops_est;
             if ($x) {
                 $total_flops += $x;
             } else {
@@ -448,7 +448,7 @@ 
             }
         }
     }
-    $cmd = "cd " . project_dir() . "/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
+    $cmd = "cd ".project_dir()."/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
     $x = exec($cmd);
     if (!is_numeric($x) || (double)$x == 0) {
         xml_error(-1, "$cmd returned $x");
@@ -533,15 +533,15 @@ 
     }
 
     $job_params = new StdClass;
-    $job_params->rsc_disk_bound = (double) $r->batch->job_params->rsc_disk_bound;
-    $job_params->rsc_fpops_est = (double) $r->batch->job_params->rsc_fpops_est;
-    $job_params->rsc_fpops_bound = (double) $r->batch->job_params->rsc_fpops_bound;
-    $job_params->rsc_memory_bound = (double) $r->batch->job_params->rsc_memory_bound;
-    $job_params->delay_bound = (double) $r->batch->job_params->delay_bound;
+    $job_params->rsc_disk_bound = (double)$r->batch->job_params->rsc_disk_bound;
+    $job_params->rsc_fpops_est = (double)$r->batch->job_params->rsc_fpops_est;
+    $job_params->rsc_fpops_bound = (double)$r->batch->job_params->rsc_fpops_bound;
+    $job_params->rsc_memory_bound = (double)$r->batch->job_params->rsc_memory_bound;
+    $job_params->delay_bound = (double)$r->batch->job_params->delay_bound;
         // could add quorum-related stuff
 
-    $input_template_filename = (string) $r->batch->input_template_filename;
-    $output_template_filename = (string) $r->batch->output_template_filename;
+    $input_template_filename = (string)$r->batch->input_template_filename;
+    $output_template_filename = (string)$r->batch->output_template_filename;
         // possibly empty
 
     submit_jobs(
@@ -634,7 +634,7 @@ 
 }
 
 function n_outfiles($wu) {
-    $path = project_dir() . "/$wu->output_template_filename";
+    $path = project_dir()."/$wu->output_template_filename";
     $r = simplexml_load_file($path);
     return count($r->file_info);
 }
@@ -841,7 +841,7 @@ 
 ";
         if ($result->server_state == 5) {   // over?
             $paths = get_outfile_paths($result);
-            foreach($paths as $path) {
+            foreach ($paths as $path) {
                 if (is_file($path)) {
                     $size = filesize($path);
                     echo "        <outfile>
@@ -885,7 +885,7 @@ 
     } else {
         $results = BoincResult::enum("workunitid=$job_id");
         foreach ($results as $r) {
-            switch($r->outcome) {
+            switch ($r->outcome) {
             case 1:
             case 3:
             case 6:
@@ -1000,8 +1000,8 @@ 
     }
 
     $user = check_remote_submit_permissions($r, $app);
-    $in = file_get_contents(project_dir() . "/templates/".$app->name."_in");
-    $out = file_get_contents(project_dir() . "/templates/".$app->name."_out");
+    $in = file_get_contents(project_dir()."/templates/".$app->name."_in");
+    $out = file_get_contents(project_dir()."/templates/".$app->name."_out");
     if ($in === false || $out === false) {
         log_write("template file missing");
         xml_error(-1, "template file missing");
@@ -1013,7 +1013,7 @@ 
 
 function ping($r) {
     xml_start_tag("ping");
-    BoincDb::get();     // errors out if DB down or web disabled
+    BoincDb::get(); // errors out if DB down or web disabled
     echo "<success>1</success>
         </ping>
     ";
@@ -1080,9 +1080,9 @@ 
 $request_log = parse_config(get_config(), "<remote_submit_request_log>");
 if ($request_log) {
     $log_dir = parse_config(get_config(), "<log_dir>");
-    $request_log = $log_dir . "/" . $request_log;
+    $request_log = $log_dir."/".$request_log;
     if ($file = fopen($request_log, "a")) {
-        fwrite($file, "\n<submit_rpc_handler date=\"" . date(DATE_ATOM) . "\">\n" . $_POST['request'] . "\n</submit_rpc_handler>\n");
+        fwrite($file, "\n<submit_rpc_handler date=\"".date(DATE_ATOM)."\">\n".$_POST['request']."\n</submit_rpc_handler>\n");
         fclose($file);
     }
 }

html/user/get_output2.php

Spacing +4 added lines, -4 removed lines

@@ -51,7 +51,7 @@ 
     if ($user->authenticator != $auth) die('bad auth');
 }
 
-function do_result_aux($result, $batch, $file_num=null) {
+function do_result_aux($result, $batch, $file_num = null) {
     $phys_names = get_outfile_phys_names($result);
     $log_names = get_outfile_log_names($result);
     if ($file_num !== null) {
@@ -71,7 +71,7 @@ 
         $dir_path = "submit/$batch->id/$result->name";
         system("rm -r $dir_path");
         mkdir($dir_path);
-        for ($i=0; $i<count($phys_names); $i++) {
+        for ($i = 0; $i < count($phys_names); $i++) {
             $cmd = sprintf('ln -s %s %s/%s',
                 upload_path($phys_names[$i]),
                 $dir_path,
@@ -88,7 +88,7 @@ 
     }
 }
 
-function do_result($result_id, $auth, $file_num=null) {
+function do_result($result_id, $auth, $file_num = null) {
     $result = BoincResult::lookup_id($result_id);
     if (!$result) die("no result $result_id");
     $workunit = BoincWorkunit::lookup_id($result->workunitid);
@@ -135,7 +135,7 @@ 
             system($cmd);
         } else {
             mkdir(sprintf('%s/%s', $dir_path, $result->name));
-            for ($i=0; $i<count($phys_names); $i++) {
+            for ($i = 0; $i < count($phys_names); $i++) {
                 $cmd = sprintf('ln -s %s %s/%s/%s',
                     upload_path($phys_names[$i]),
                     $dir_path,

html/user/submit.php

Spacing +5 added lines, -5 removed lines

@@ -461,7 +461,7 @@ 
     if ($owner) {
         row2('submitter', $owner->name);
     }
-    row2("application", $app?$app->name:'---');
+    row2("application", $app ? $app->name : '---');
     row2("state", batch_state_string($batch->state));
     //row2("# jobs", $batch->njobs);
     //row2("# error jobs", $batch->nerror_jobs);
@@ -523,7 +523,7 @@ 
         $x[] = "Download Results";
     }
     row_heading_array($x);
-    foreach($wus as $wu) {
+    foreach ($wus as $wu) {
         $resultid = $wu->canonical_resultid;
         if ($resultid) {
             $y = '<font color="green">completed</font>';
@@ -532,7 +532,7 @@ 
             $text = "---";
             if ($batch->state == BATCH_STATE_COMPLETE) {
                 $y = '<font color="red">failed</font>';
-            }   else {
+            } else {
                 $y = "in progress";
             }
         }
@@ -595,7 +595,7 @@ 
     $results = BoincResult::enum("workunitid=$wuid");
     $upload_dir = parse_config(get_config(), "<upload_dir>");
     $fanout = parse_config(get_config(), "<uldl_dir_fanout>");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         $x = [
             "<a href=result.php?resultid=$result->id>$result->id</a>",
             state_string($result)
@@ -604,7 +604,7 @@ 
         if ($result->server_state == RESULT_SERVER_STATE_OVER) {
             $phys_names = get_outfile_phys_names($result);
             $log_names = get_outfile_log_names($result);
-            for ($i=0; $i<count($phys_names); $i++) {
+            for ($i = 0; $i < count($phys_names); $i++) {
                 if ($web_app->assim_move) {
                     // file is in
                     // project/results/<batchid>/<wu_name>__file_<log_name>

html/inc/submit_util.inc

Spacing +3 added lines, -3 removed lines

@@ -300,7 +300,7 @@ 
 // get the total size of output files of a batch
 //
 function batch_output_file_size($batchid) {
-    $batch_td_size=0;
+    $batch_td_size = 0;
     $wus = BoincWorkunit::enum("batch=$batchid");
     $fanout = parse_config(get_config(), "<uldl_dir_fanout>");
     $upload_dir = parse_config(get_config(), "<upload_dir>");
@@ -330,7 +330,7 @@ 
 }
 
 function boinc_get_wu_output_files_url($user, $wu_id) {
-    $auth_str =  md5($user->authenticator.$wu_id);
+    $auth_str = md5($user->authenticator.$wu_id);
     return "get_output.php?cmd=workunit_files&wu_id=$wu_id&auth_str=$auth_str";
 }
 
@@ -364,7 +364,7 @@ 
     if (!file_exists($path)) return null;
     $x = file_get_contents($path);
     $n = sscanf($x, "%s %d", $md5, $size);
-    if ($n != 2 || strlen($md5)!=32) {
+    if ($n != 2 || strlen($md5) != 32) {
         return null;
     }
     return [$md5, $size];

html/inc/bootstrap.inc

Spacing +20 added lines, -20 removed lines

@@ -141,12 +141,12 @@ 
         // prefix for links; needed for pages not in top dir
     $user,
         // logged-in user, if any
-    $fixed=false,
+    $fixed = false,
         // if true, navbar is fixed at top of page.
         // NOTE: if you do this, you must set a global var $fixed_navbar
         // to true at compile time
         // (it needs to be set when page_head() is called).
-    $inverse=false
+    $inverse = false
         // white on black?
 ) {
     global $master_url;
@@ -215,7 +215,7 @@ 
 // output a panel.
 // $content_func is a function that generates the panel contents
 //
-function panel($title, $content_func, $class="panel-primary", $body_class="") {
+function panel($title, $content_func, $class = "panel-primary", $body_class = "") {
     echo sprintf('<div class="panel %s">
         ', $class
     );
@@ -242,7 +242,7 @@ 
 // $left_width is the width of left column in 1/12 units.
 // $arg is passed to the functions.
 //
-function grid($top_func, $left_func, $right_func, $left_width=6, $arg=null) {
+function grid($top_func, $left_func, $right_func, $left_width = 6, $arg = null) {
     echo '
         <div class="container-fluid">
     ';
@@ -257,7 +257,7 @@ 
             </div>
         ';
     }
-    $right_width = 12-$left_width;
+    $right_width = 12 - $left_width;
     echo '
         <div class="row">
         <div class="col-sm-'.$left_width.'">
@@ -281,7 +281,7 @@ 
 //      use extra = "name=x"
 //      call forum_focus(x, foo) after defining the field
 //
-function form_start($action, $method='get', $extra='') {
+function form_start($action, $method = 'get', $extra = '') {
     echo sprintf(
         '<div class="container-fluid">
         <form class="form-horizontal" method="%s" action="%s" %s>'
@@ -313,7 +313,7 @@ 
 // just the input field
 //
 function form_input_text_field(
-    $name, $value='', $type='text', $attrs='', $extra=''
+    $name, $value = '', $type = 'text', $attrs = '', $extra = ''
 ) {
     return sprintf(
         '<input %s type="%s" class="form-control" name="%s" value="%s">%s',
@@ -324,7 +324,7 @@ 
 // the whole row
 //
 function form_input_text(
-    $label, $name, $value='', $type='text', $attrs='', $extra=''
+    $label, $name, $value = '', $type = 'text', $attrs = '', $extra = ''
 ) {
     echo sprintf('
         <div class="form-group">
@@ -352,7 +352,7 @@ 
     );
 }
 
-function form_input_textarea($label, $name, $value='', $nrows=4) {
+function form_input_textarea($label, $name, $value = '', $nrows = 4) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -368,7 +368,7 @@ 
 
 // $items is either a string of <option> elements, or an array
 //
-function form_select($label, $name, $items, $selected=null) {
+function form_select($label, $name, $items, $selected = null) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -381,7 +381,7 @@ 
         foreach ($items as $i) {
             echo sprintf(
                 '<option %s value=%s>%s</option>',
-                ($i[0]==$selected)?'selected':'',
+                ($i[0] == $selected) ? 'selected' : '',
                 $i[0], $i[1]
             );
         }
@@ -394,7 +394,7 @@ 
 // same, for multiple select.
 // $selected, if non-null, is a list of selected values
 //
-function form_select_multiple($label, $name, $items, $selected=null) {
+function form_select_multiple($label, $name, $items, $selected = null) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s" for="%s">%s</label>
@@ -406,7 +406,7 @@ 
     foreach ($items as $i) {
         echo sprintf(
             '<option %s value=%s>%s</option>',
-            ($selected && in_array($i[0], $selected))?'selected':'',
+            ($selected && in_array($i[0], $selected)) ? 'selected' : '',
             $i[0], $i[1]
         );
     }
@@ -415,12 +415,12 @@ 
 
 // return a list of string for checkbox items
 //
-function checkbox_item_strings($items, $attrs='') {
+function checkbox_item_strings($items, $attrs = '') {
     $x = [];
     foreach ($items as $i) {
         $x[] = sprintf('<input %s type="checkbox" name="%s" %s> %s
             ',
-            $attrs, $i[0], $i[2]?"checked":"", $i[1]
+            $attrs, $i[0], $i[2] ? "checked" : "", $i[1]
         );
     }
     return $x;
@@ -428,7 +428,7 @@ 
 
 // $items is list of (name, label, checked)
 //
-function form_checkboxes($label, $items, $attrs='') {
+function form_checkboxes($label, $items, $attrs = '') {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s">%s</label>
@@ -454,7 +454,7 @@ 
         FORM_LEFT_CLASS, $label, FORM_RIGHT_CLASS
     );
     foreach ($items as $i) {
-        $checked = ($selected == $i[0])?"checked":"";
+        $checked = ($selected == $i[0]) ? "checked" : "";
         echo sprintf('<input type="radio" name="%s" value="%s" %s> %s <br>
             ',
             $name, $i[0], $checked, $i[1]
@@ -487,7 +487,7 @@ 
 ';
 }
 
-function form_submit($text, $attrs='') {
+function form_submit($text, $attrs = '') {
     form_general(
         "",
         sprintf(
@@ -497,7 +497,7 @@ 
     );
 }
 
-function form_checkbox($label, $name, $checked=false) {
+function form_checkbox($label, $name, $checked = false) {
     echo sprintf('
         <div class="form-group">
             <label align=right class="%s">%s</label>
@@ -508,6 +508,6 @@ 
     echo sprintf('
         <input type="checkbox" name="%s" %s>
         </div>
-        ', $name, $checked?"checked":""
+        ', $name, $checked ? "checked" : ""
     );
 }

html/user/sandbox.php

Spacing +1 added lines, -1 removed lines

@@ -169,7 +169,7 @@
     $notice = "";
     $dir = sandbox_dir($user);
     $count = count($_FILES['new_file']['tmp_name']);
-    for ($i=0; $i<$count; $i++) {
+    for ($i = 0; $i < $count; $i++) {
         $tmp_name = $_FILES['new_file']['tmp_name'][$i];
         if (!is_uploaded_file($tmp_name)) {
             error_page("$tmp_name is not uploaded file");

html/inc/sandbox.inc

Spacing +4 added lines, -4 removed lines

@@ -91,7 +91,7 @@ 
 // return list of files matching given pattern,
 // in the format used for form_select() and form_select_multiple()
 //
-function sandbox_select_items($user, $pattern=null) {
+function sandbox_select_items($user, $pattern = null) {
     $sbfiles = sandbox_file_names($user);
     $sbitems = [];
     foreach ($sbfiles as $f) {
@@ -112,7 +112,7 @@ 
     }
     $files = sandbox_file_names($user);
     foreach ($files as $f) {
-        if ($regexp && !preg_match("/$regexp/",$f)) continue;
+        if ($regexp && !preg_match("/$regexp/", $f)) continue;
         $x .= "<option value=\"$f\">$f</option>\n";
     }
     $x .= "</select>\n";
@@ -160,8 +160,8 @@ 
             '%s <a href="%s&sort_field=%s&sort_rev=%d">%s</a>',
             $title,
             $url, $sort_field,
-            $sort_rev?0:1,
-            $sort_rev?'&uarr;':'&darr;'
+            $sort_rev ? 0 : 1,
+            $sort_rev ? '&uarr;' : '&darr;'
         );
     } else {
         return sprintf(

html/user/buda_submit.php

Spacing +5 added lines, -5 removed lines

@@ -61,7 +61,7 @@ 
 //
 function unzip_batch_file($user, $batch_file) {
     @mkdir("../../buda_batches");
-    for ($i=0; $i<1000; $i++) {
+    for ($i = 0; $i < 1000; $i++) {
         $batch_dir = "../../buda_batches/$i";
         $batch_dir_name = $i;
         $ret = @mkdir($batch_dir);
@@ -112,7 +112,7 @@ 
         }
         $job_files = [];
         $cmdline = '';
-        foreach(scandir("$batch_dir/$fname") as $f2) {
+        foreach (scandir("$batch_dir/$fname") as $f2) {
             if ($f2[0] == '.') continue;
             if ($f2 == 'cmdline') {
                 $cmdline = trim(file_get_contents("$batch_dir/$fname/cmdline"));
@@ -162,7 +162,7 @@ 
 function stage_input_files($batch_dir, $batch_desc, $batch_id) {
     $n = count($batch_desc->shared_files);
     $batch_desc->shared_files_phys_names = [];
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $path = sprintf('%s/%s', $batch_dir, $batch_desc->shared_files[$i]);
         [$md5, $size] = $batch_desc->shared_file_infos[$i];
         $phys_name = sprintf('batch_%d_%s', $batch_id, $md5);
@@ -172,7 +172,7 @@ 
     foreach ($batch_desc->jobs as $job) {
         $n = count($batch_desc->unshared_files);
         $job->phys_names = [];
-        for ($i=0; $i<$n; $i++) {
+        for ($i = 0; $i < $n; $i++) {
             $path = sprintf('%s/%s/%s',
                 $batch_dir, $job->dir, $batch_desc->unshared_files[$i]
             );
@@ -220,7 +220,7 @@ 
     }
     $cw_cmdline = sprintf('"--dockerfile %s %s %s"',
         $variant_desc->dockerfile,
-        $wrapper_verbose?'--verbose':'',
+        $wrapper_verbose ? '--verbose' : '',
         $cmdline
     );
     $cmd = sprintf(

html/user/buda.php

Spacing +3 added lines, -3 removed lines

@@ -32,7 +32,7 @@ 
 // show list of BUDA apps and variants,
 // w/ buttons for adding and deleting
 //
-function app_list($notice=null) {
+function app_list($notice = null) {
     global $buda_root;
     if (!is_dir($buda_root)) {
         mkdir($buda_root);
@@ -96,7 +96,7 @@ 
     $dir = "$buda_root/$app/$variant";
     start_table();
     table_header('name', 'size', 'md5');
-    foreach(scandir($dir) as $f) {
+    foreach (scandir($dir) as $f) {
         if ($f[0] == '.') continue;
         [$md5, $size] = parse_info_file("$dir/.md5/$f");
         table_row(
@@ -172,7 +172,7 @@ 
     //
     $x = "<input_template>\n";
     $ninfiles = 1 + count($variant_desc->input_file_names) + count($variant_desc->app_files);
-    for ($i=0; $i<$ninfiles; $i++) {
+    for ($i = 0; $i < $ninfiles; $i++) {
         $x .= "   <file_info>\n      <no_delete/>\n   </file_info>\n";
     }
     $x .= "   <workunit>\n";