BOINC / boinc

drupal/sites/default/boinc/modules/contrib/privatemsg/privatemsg.author-pane.inc

Indentation +17 added lines, -17 removed lines

@@ -9,45 +9,45 @@
  * Implements hook_preprocess_author_pane().
  */
 function privatemsg_preprocess_author_pane(&$variables) {
-  global $user;
-  $account = $variables['account'];
-  $account_id = $account->uid;
-  $account_name = $account->name;
+    global $user;
+    $account = $variables['account'];
+    $account_id = $account->uid;
+    $account_name = $account->name;
 
-  if (function_exists('author_pane_api') && author_pane_api() == "2") {
+    if (function_exists('author_pane_api') && author_pane_api() == "2") {
     // Author Pane 2.x
 
     // Check if this preprocess needs to be run given who's calling it.
     if (!author_pane_run_preprocess('privatemsg', $variables['caller'])) {
-      return;
+        return;
     }
 
     $url = privatemsg_get_link($account);
     if (!empty($url)) {
-      $variables['privatemsg'] = l('<span>' . t('Send PM') . '</span>', $url, array('attributes' => array('class' => 'author-pane-link', 'title' => t('Send @name a private message', array('@name' => $account_name))), 'html' => TRUE));
+        $variables['privatemsg'] = l('<span>' . t('Send PM') . '</span>', $url, array('attributes' => array('class' => 'author-pane-link', 'title' => t('Send @name a private message', array('@name' => $account_name))), 'html' => TRUE));
 
-      // Early versions of the template used this variable so fill it for
-      // backwards compatability.
-      $variables['privatemsg_link'] = $variables['privatemsg'];
+        // Early versions of the template used this variable so fill it for
+        // backwards compatability.
+        $variables['privatemsg_link'] = $variables['privatemsg'];
     }
-  }
-  else {
+    }
+    else {
     // Author Pane 1.x
 
     $image_path = $variables['image_path'];
 
     // Send private message
     if ($url = privatemsg_get_link($account)) {
-      $img = theme('image', "$image_path/private-message.png", t('Send private message'), t('Send private message'), NULL, TRUE);
-      $variables['privatemsg'] = l($img, $url, array('absolute' => TRUE, 'html' => TRUE));
-      $variables['privatemsg_link'] = l(t('Send private message'), $url, array('attributes' => array('class' => 'author-privatemsg-icon'), 'html' => TRUE));
+        $img = theme('image', "$image_path/private-message.png", t('Send private message'), t('Send private message'), NULL, TRUE);
+        $variables['privatemsg'] = l($img, $url, array('absolute' => TRUE, 'html' => TRUE));
+        $variables['privatemsg_link'] = l(t('Send private message'), $url, array('attributes' => array('class' => 'author-privatemsg-icon'), 'html' => TRUE));
+    }
     }
-  }
 }
 
 /**
  * Implementation of hook_author_pane_allow_preprocess_disable().
  */
 function privatemsg_author_pane_allow_preprocess_disable() {
-  return array('privatemsg' => 'Privatemsg');
+    return array('privatemsg' => 'Privatemsg');
 }

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 
     $url = privatemsg_get_link($account);
     if (!empty($url)) {
-      $variables['privatemsg'] = l('<span>' . t('Send PM') . '</span>', $url, array('attributes' => array('class' => 'author-pane-link', 'title' => t('Send @name a private message', array('@name' => $account_name))), 'html' => TRUE));
+      $variables['privatemsg'] = l('<span>'.t('Send PM').'</span>', $url, array('attributes' => array('class' => 'author-pane-link', 'title' => t('Send @name a private message', array('@name' => $account_name))), 'html' => TRUE));
 
       // Early versions of the template used this variable so fill it for
       // backwards compatability.

Braces +1 added lines, -2 removed lines

@@ -30,8 +30,7 @@
       // backwards compatability.
       $variables['privatemsg_link'] = $variables['privatemsg'];
     }
-  }
-  else {
+  } else {
     // Author Pane 1.x
 
     $image_path = $variables['image_path'];

Upper-Lower-Casing +4 added lines, -4 removed lines

@@ -24,7 +24,7 @@ 
 
     $url = privatemsg_get_link($account);
     if (!empty($url)) {
-      $variables['privatemsg'] = l('<span>' . t('Send PM') . '</span>', $url, array('attributes' => array('class' => 'author-pane-link', 'title' => t('Send @name a private message', array('@name' => $account_name))), 'html' => TRUE));
+      $variables['privatemsg'] = l('<span>' . t('Send PM') . '</span>', $url, array('attributes' => array('class' => 'author-pane-link', 'title' => t('Send @name a private message', array('@name' => $account_name))), 'html' => true));
 
       // Early versions of the template used this variable so fill it for
       // backwards compatability.
@@ -38,9 +38,9 @@ 
 
     // Send private message
     if ($url = privatemsg_get_link($account)) {
-      $img = theme('image', "$image_path/private-message.png", t('Send private message'), t('Send private message'), NULL, TRUE);
-      $variables['privatemsg'] = l($img, $url, array('absolute' => TRUE, 'html' => TRUE));
-      $variables['privatemsg_link'] = l(t('Send private message'), $url, array('attributes' => array('class' => 'author-privatemsg-icon'), 'html' => TRUE));
+      $img = theme('image', "$image_path/private-message.png", t('Send private message'), t('Send private message'), null, true);
+      $variables['privatemsg'] = l($img, $url, array('absolute' => true, 'html' => true));
+      $variables['privatemsg_link'] = l(t('Send private message'), $url, array('attributes' => array('class' => 'author-privatemsg-icon'), 'html' => true));
     }
   }
 }

drupal/sites/default/boinc/modules/contrib/privatemsg/views/views_handler_field_privatemsg_link.inc

Indentation +73 added lines, -73 removed lines

@@ -10,62 +10,62 @@ 
  */
 class views_handler_field_privatemsg_link extends views_handler_field {
 
-  /**
-   * Add uid as a additional field.
-   */
-  function construct() {
+    /**
+     * Add uid as a additional field.
+     */
+    function construct() {
     parent::construct();
     $this->additional_fields['uid'] = 'uid';
-  }
+    }
 
-  /**
-   * Define our additional configuration setting.
-   */
-  function option_definition() {
+    /**
+     * Define our additional configuration setting.
+     */
+    function option_definition() {
     $options = parent::option_definition();
     $options['text'] = array('default' => '', 'translatable' => TRUE);
     $options['subject'] = array('default' => '', 'translatable' => TRUE);
     $options['return'] = array('default' => TRUE, 'translatable' => FALSE);
     return $options;
-  }
-
-  /**
-   * Define the configuration form for our textfield.
-   */
-  function options_form(&$form, &$form_state) {
-     $form['label'] = array(
-      '#type' => 'textfield',
-      '#title' => t('Label'),
-      '#default_value' => isset($this->options['label']) ? $this->options['label'] : '',
-      '#description' => t('The label for this field that will be displayed to end users if the style requires it.'),
+    }
+
+    /**
+     * Define the configuration form for our textfield.
+     */
+    function options_form(&$form, &$form_state) {
+        $form['label'] = array(
+        '#type' => 'textfield',
+        '#title' => t('Label'),
+        '#default_value' => isset($this->options['label']) ? $this->options['label'] : '',
+        '#description' => t('The label for this field that will be displayed to end users if the style requires it.'),
     );
 
     $form['text'] = array(
-      '#type' => 'textfield',
-      '#title' => t('Text to display'),
-      '#default_value' => $this->options['text'],
-      '#description' => t('Define the text to use for the link title. You can use replacement tokens to insert any existing field output.'),
+        '#type' => 'textfield',
+        '#title' => t('Text to display'),
+        '#default_value' => $this->options['text'],
+        '#description' => t('Define the text to use for the link title. You can use replacement tokens to insert any existing field output.'),
     );
 
     $form['subject'] = array(
-      '#type' => 'textfield',
-      '#title' => t('Pre-filled subject'),
-      '#default_value' => $this->options['subject'],
-      '#description' => t('Define the subject that will be pre-filled in the send message form. You can use replacement tokens to insert any existing field output.'),
+        '#type' => 'textfield',
+        '#title' => t('Pre-filled subject'),
+        '#default_value' => $this->options['subject'],
+        '#description' => t('Define the subject that will be pre-filled in the send message form. You can use replacement tokens to insert any existing field output.'),
     );
 
     // Get a list of the available fields and arguments for token replacement.
     $options = array();
     foreach ($this->view->display_handler->get_handlers('field') as $field => $handler) {
-      $options[t('Fields')]["[$field]"] = $handler->ui_name();
-      // We only use fields up to (and including) this one.
-      if ($field == $this->options['id']) {
+        $options[t('Fields')]["[$field]"] = $handler->ui_name();
+        // We only use fields up to (and including) this one.
+        if ($field == $this->options['id']) {
         break;
-      }
+        }
     }
     $count = 0; // This lets us prepare the key as we want it printed.
     foreach ($this->view->display_handler->get_handlers('argument') as $arg => $handler) {
-      $options[t('Arguments')]['%' . ++$count] = $handler->ui_name();
+        $options[t('Arguments')]['%' . ++$count] = $handler->ui_name();
     }
 
 
@@ -73,81 +73,81 @@ 
     $output = t('<p>You must add some additional fields to this display before using this field. These fields may be marked as <em>Exclude from display</em> if you prefer. Note that due to rendering order, you cannot use fields that come after this field; if you need a field not listed here, rearrange your fields.</p>');
     // We have some options, so make a list.
     if (!empty($options)) {
-      $output = t('<p>The following substitution patterns are available for this display. Use the pattern shown on the left to display the value indicated on the right. Note that due to rendering order, you cannot use fields that come after this field; if you need a field not listed here, rearrange your fields.</p>');
-      foreach (array_keys($options) as $type) {
+        $output = t('<p>The following substitution patterns are available for this display. Use the pattern shown on the left to display the value indicated on the right. Note that due to rendering order, you cannot use fields that come after this field; if you need a field not listed here, rearrange your fields.</p>');
+        foreach (array_keys($options) as $type) {
         if (!empty($options[$type])) {
-          $items = array();
-          $title = t(ucwords($type));
-          foreach ($options[$type] as $key => $value) {
+            $items = array();
+            $title = t(ucwords($type));
+            foreach ($options[$type] as $key => $value) {
             $items[] = $key .' == '. $value;
-          }
-          $output .= theme('item_list', $items, $title);
+            }
+            $output .= theme('item_list', $items, $title);
+        }
         }
-      }
     }
 
     $form['help'] = array(
-      '#type' => 'markup',
-      '#id' => 'views-tokens-help',
-      '#value' => '<div><fieldset id="views-tokens-help"><legend>' . t('Replacement patterns') . '</legend>' . $output . '</fieldset></div>',
+        '#type' => 'markup',
+        '#id' => 'views-tokens-help',
+        '#value' => '<div><fieldset id="views-tokens-help"><legend>' . t('Replacement patterns') . '</legend>' . $output . '</fieldset></div>',
     );
 
     $form['return'] = array(
-      '#type' => 'checkbox',
-      '#title' => t('Return to view after message was sent.'),
-      '#default_value' => $this->options['return'],
-      '#description' => t('Should the user be redirected back to the current view when the message was sent.'),
+        '#type' => 'checkbox',
+        '#title' => t('Return to view after message was sent.'),
+        '#default_value' => $this->options['return'],
+        '#description' => t('Should the user be redirected back to the current view when the message was sent.'),
     );
-  }
+    }
 
-  /**
-   * Renders our field, displays a link if the user is allowed to.
-   */
-  function render($values) {
+    /**
+     * Renders our field, displays a link if the user is allowed to.
+     */
+    function render($values) {
     if (isset($values->uid)) {
-      $uid = $values->uid;
+        $uid = $values->uid;
     }
     elseif (isset($values->users_uid)) {
-      $uid = $values->users_uid;
+        $uid = $values->users_uid;
     }
     else {
-      return '';
+        return '';
     }
     $text = t('Write private message');
     if (!empty($this->options['text'])) {
-      $tokens = $this->get_render_tokens($this);
-      $text = strip_tags(strtr($this->options['text'], $tokens));
+        $tokens = $this->get_render_tokens($this);
+        $text = strip_tags(strtr($this->options['text'], $tokens));
     }
     $subject = NULL;
     if (!empty($this->options['subject'])) {
-      $tokens = $this->get_render_tokens($this);
-      $subject = strip_tags(strtr($this->options['subject'], $tokens));
+        $tokens = $this->get_render_tokens($this);
+        $subject = strip_tags(strtr($this->options['subject'], $tokens));
     }
 
     $options = array();
     if ($this->options['return']) {
-      $options['query'] = drupal_get_destination();
+        $options['query'] = drupal_get_destination();
     }
 
     $data = '';
     if (($recipient = user_load($uid)) && ($url = privatemsg_get_link(array($recipient), NULL, $subject))) {
-      $data = l($text, $url, $options);
+        $data = l($text, $url, $options);
     }
     return $data;
-  }
+    }
 
-  /**
-   * Only display the column for users with the appropriate permission.
-   */
-  function access() {
+    /**
+     * Only display the column for users with the appropriate permission.
+     */
+    function access() {
     return privatemsg_user_access('write privatemsg');
-  }
+    }
 
-  /**
-   * Just do some basic checks, don't add "privatemsg_link" as field.
-   */
-  function query() {
+    /**
+     * Just do some basic checks, don't add "privatemsg_link" as field.
+     */
+    function query() {
     $this->ensure_my_table();
     $this->add_additional_fields();
-  }
+    }
 }
\ No newline at end of file

Spacing +3 added lines, -3 removed lines

@@ -65,7 +65,7 @@ 
     }
     $count = 0; // This lets us prepare the key as we want it printed.
     foreach ($this->view->display_handler->get_handlers('argument') as $arg => $handler) {
-      $options[t('Arguments')]['%' . ++$count] = $handler->ui_name();
+      $options[t('Arguments')]['%'.++$count] = $handler->ui_name();
     }
 
 
@@ -79,7 +79,7 @@ 
           $items = array();
           $title = t(ucwords($type));
           foreach ($options[$type] as $key => $value) {
-            $items[] = $key .' == '. $value;
+            $items[] = $key.' == '.$value;
           }
           $output .= theme('item_list', $items, $title);
         }
@@ -89,7 +89,7 @@ 
     $form['help'] = array(
       '#type' => 'markup',
       '#id' => 'views-tokens-help',
-      '#value' => '<div><fieldset id="views-tokens-help"><legend>' . t('Replacement patterns') . '</legend>' . $output . '</fieldset></div>',
+      '#value' => '<div><fieldset id="views-tokens-help"><legend>'.t('Replacement patterns').'</legend>'.$output.'</fieldset></div>',
     );
 
     $form['return'] = array(

Braces +2 added lines, -4 removed lines

@@ -106,11 +106,9 @@
   function render($values) {
     if (isset($values->uid)) {
       $uid = $values->uid;
-    }
-    elseif (isset($values->users_uid)) {
+    } elseif (isset($values->users_uid)) {
       $uid = $values->users_uid;
-    }
-    else {
+    } else {
       return '';
     }
     $text = t('Write private message');

Upper-Lower-Casing +5 added lines, -5 removed lines

@@ -23,9 +23,9 @@ 
    */
   function option_definition() {
     $options = parent::option_definition();
-    $options['text'] = array('default' => '', 'translatable' => TRUE);
-    $options['subject'] = array('default' => '', 'translatable' => TRUE);
-    $options['return'] = array('default' => TRUE, 'translatable' => FALSE);
+    $options['text'] = array('default' => '', 'translatable' => true);
+    $options['subject'] = array('default' => '', 'translatable' => true);
+    $options['return'] = array('default' => true, 'translatable' => false);
     return $options;
   }
 
@@ -118,7 +118,7 @@ 
       $tokens = $this->get_render_tokens($this);
       $text = strip_tags(strtr($this->options['text'], $tokens));
     }
-    $subject = NULL;
+    $subject = null;
     if (!empty($this->options['subject'])) {
       $tokens = $this->get_render_tokens($this);
       $subject = strip_tags(strtr($this->options['subject'], $tokens));
@@ -130,7 +130,7 @@ 
     }
 
     $data = '';
-    if (($recipient = user_load($uid)) && ($url = privatemsg_get_link(array($recipient), NULL, $subject))) {
+    if (($recipient = user_load($uid)) && ($url = privatemsg_get_link(array($recipient), null, $subject))) {
       $data = l($text, $url, $options);
     }
     return $data;

drupal/sites/default/boinc/modules/contrib/privatemsg/views/privatemsg.views.inc

Indentation +12 added lines, -12 removed lines

@@ -5,16 +5,16 @@ 
  */
 
 function privatemsg_views_data() {
-  $data['users']['privatemsg_link'] = array(
+    $data['users']['privatemsg_link'] = array(
     'group' => t('Privatemsg'),
     'title' => t('Send message'),
     'field' => array(
-      'title' => t('Send Privatemsg link'),
-      'help' => t('Displays a link to send a private message to a user.'),
-      'handler' => 'views_handler_field_privatemsg_link',
+        'title' => t('Send Privatemsg link'),
+        'help' => t('Displays a link to send a private message to a user.'),
+        'handler' => 'views_handler_field_privatemsg_link',
     ),
-  );
-  return $data;
+    );
+    return $data;
 }
 
 
@@ -22,17 +22,17 @@ 
  * Implementation of hook_views_handlers().
  */
 function privatemsg_views_handlers() {
-  return array(
+    return array(
     'info' => array(
-      'path' => drupal_get_path('module', 'privatemsg') . '/views',
+        'path' => drupal_get_path('module', 'privatemsg') . '/views',
     ),
     'handlers' => array(
-      // field handlers
-      'views_handler_field_privatemsg_link' => array(
+        // field handlers
+        'views_handler_field_privatemsg_link' => array(
         'parent' => 'views_handler_field',
-      ),
+        ),
     ),
-  );
+    );
 }
 
 

Spacing +1 added lines, -1 removed lines

@@ -24,7 +24,7 @@
 function privatemsg_views_handlers() {
   return array(
     'info' => array(
-      'path' => drupal_get_path('module', 'privatemsg') . '/views',
+      'path' => drupal_get_path('module', 'privatemsg').'/views',
     ),
     'handlers' => array(
       // field handlers

drupal/sites/default/boinc/modules/contrib/privatemsg/privatemsg.api.php

Indentation +55 added lines, -55 removed lines

@@ -122,20 +122,20 @@ 
  *   Names that are already in the list and are excluded
  */
 function hook_privatemsg_sql_autocomplete_alter(&$fragments, $search, $names) {
-  global $user;
-  // Extend the query that searches for usernames
+    global $user;
+    // Extend the query that searches for usernames
 
-  // $fragments is explained in the api documentation in detail
+    // $fragments is explained in the api documentation in detail
 
-  // The query is already set up, it's searching for usernames which start with
-  // $search and are not $names (may be empty)
-  // the main table is {user} a
+    // The query is already set up, it's searching for usernames which start with
+    // $search and are not $names (may be empty)
+    // the main table is {user} a
 
-  // for example, add a join on a table where the user connections are stored
-  // and specify that only users connected with the current user should be
-  // loaded.
-  $fragments['inner_join'] = 'INNER JOIN {my_table} m ON (m.user1 = u.uid AND m.user2 = %d)';
-  $fragments['query_args'][] = $user->uid;
+    // for example, add a join on a table where the user connections are stored
+    // and specify that only users connected with the current user should be
+    // loaded.
+    $fragments['inner_join'] = 'INNER JOIN {my_table} m ON (m.user1 = u.uid AND m.user2 = %d)';
+    $fragments['query_args'][] = $user->uid;
 }
 
 /**
@@ -157,7 +157,7 @@ 
  *   Query fragments array.
  * @param $pmid
  *   the id of the message.
-  * @param $account
+ * @param $account
  *   User object of account for which to load the message.
  */
 function hook_privatemsg_sql_load_alter(&$fragments, $pmid, $account = NULL) {
@@ -274,7 +274,7 @@ 
  *    Message array
  */
 function hook_privatemsg_message_load($message) {
-  return array('my_key' => 'my_value');
+    return array('my_key' => 'my_value');
 }
 
 /**
@@ -302,17 +302,17 @@ 
  *   Message array
  */
 function hook_privatemsg_message_validate($message, $form = FALSE) {
-  global $_privatemsg_invalid_recipients;
-  $_privatemsg_invalid_recipients = array();
+    global $_privatemsg_invalid_recipients;
+    $_privatemsg_invalid_recipients = array();
 
-  $errors = array();
+    $errors = array();
 
-  foreach ($message['recipients'] as $recipient) {
+    foreach ($message['recipients'] as $recipient) {
     if ($recipient->name == 'blocked user') {
-      $_privatemsg_invalid_recipients[] = $recipient->uid;
-      $errors[] = t('%name has chosen to not recieve any more messages from you.', array('%name' => $recipient->name));
+        $_privatemsg_invalid_recipients[] = $recipient->uid;
+        $errors[] = t('%name has chosen to not recieve any more messages from you.', array('%name' => $recipient->name));
+    }
     }
-  }
 }
 
 /**
@@ -325,11 +325,11 @@ 
  *   Message array
  */
 function hook_privatemsg_message_presave_alter(&$message) {
-  // delete recipients which have been marked as invalid
-  global $_privatemsg_invalid_recipients;
-  foreach ($_privatemsg_invalid_recipients as $invalid) {
+    // delete recipients which have been marked as invalid
+    global $_privatemsg_invalid_recipients;
+    foreach ($_privatemsg_invalid_recipients as $invalid) {
     unset($message['recipients'][$invalid]);
-  }
+    }
 }
 /**
  * Act on the $vars before a message is displayed.
@@ -341,8 +341,8 @@ 
  *   Template variables
  */
 function hook_privatemsg_message_view_alter(&$var) {
-  // add a link to each message
-  $vars['message_links'][] = array('title' => t('My link'), 'href' => '/path/to/my/action/'. $vars['message']['mid']);
+    // add a link to each message
+    $vars['message_links'][] = array('title' => t('My link'), 'href' => '/path/to/my/action/'. $vars['message']['mid']);
 }
 
 /**
@@ -355,7 +355,7 @@ 
  *   Message array
  */
 function hook_privatemsg_message_insert($message) {
-  _mymodule_save_data($message['mid']);
+    _mymodule_save_data($message['mid']);
 }
 
 /**
@@ -384,41 +384,41 @@ 
  *   message (The reason why the recipient has been blocked).
  */
 function hook_privatemsg_block_message($author, $recipients) {
-  $blocked = array();
-  // Loop through each recipient and ensure there is no rule blocking this
-  // author from sending them private messages. Use a reference, so when
-  // user_load() is needed here the array is updated, negating the need for
-  // further calls to user_load() later in the code.
-  foreach (array_keys($recipients) as $uid) {
+    $blocked = array();
+    // Loop through each recipient and ensure there is no rule blocking this
+    // author from sending them private messages. Use a reference, so when
+    // user_load() is needed here the array is updated, negating the need for
+    // further calls to user_load() later in the code.
+    foreach (array_keys($recipients) as $uid) {
 
     // Ensure we have a recipient user object which includes roles.
     if (!isset($recipients[$uid]->roles)) {
-      $recipients[$uid] = user_load($uid);
+        $recipients[$uid] = user_load($uid);
     }
     // Note: this is checked whether the author may send the message (see third
     // parameter). Further below is a check whether the recipient may block it.
     if (_pm_block_user_rule_exists($author, $recipients[$uid], PM_BLOCK_USER_DISALLOW_SENDING)) {
-      $blocked[] = array(
+        $blocked[] = array(
         'uid' => $uid,
         'message' => t('Sorry, private messaging rules forbid sending messages to !name.', array('!name' => $recipients[$uid]->name)),
-      );
+        );
+    }
     }
-  }
 
-  $args = array_merge(array($author->uid), array_keys($recipients));
-  $result = db_query('SELECT recipient FROM {pm_block_user} WHERE author = %d AND recipient IN ('. db_placeholders($recipients) .') GROUP BY recipient', $args);
-  while ($row = db_fetch_array($result)) {
+    $args = array_merge(array($author->uid), array_keys($recipients));
+    $result = db_query('SELECT recipient FROM {pm_block_user} WHERE author = %d AND recipient IN ('. db_placeholders($recipients) .') GROUP BY recipient', $args);
+    while ($row = db_fetch_array($result)) {
     $recipient = $recipients[$row['recipient']];
     // If there's a rule disallowing blocking of this message, send it anyway.
     if (_pm_block_user_rule_exists($author, $recipient, PM_BLOCK_USER_DISALLOW_BLOCKING)) {
-      continue;
+        continue;
     }
     $blocked[] = array(
-      'uid' => $row['recipient'],
-      'message' => t('%name has chosen to not recieve any more messages from you.', array('%name' => $recipients[$row['recipient']]->name))
+        'uid' => $row['recipient'],
+        'message' => t('%name has chosen to not recieve any more messages from you.', array('%name' => $recipients[$row['recipient']]->name))
     );
-  }
-  return $blocked;
+    }
+    return $blocked;
 }
 /**
  * Add content to the view thread page.
@@ -452,16 +452,16 @@ 
  * @see privatemsg_list_submit()
  */
 function hook_privatemsg_thread_operations() {
-  return array(
+    return array(
     'operation key' => array(
-      'label' => 'Label of the operation. Only use this if the operation
+        'label' => 'Label of the operation. Only use this if the operation
                   should be displayed automatically in the action form',
-      'callback' => 'privatemsg_thread_change_status', // Function callback that will be executed.
-      'callback arguments' => array('status' => PRIVATEMSG_READ), // Additional arguments to above function
-      'undo callback' => 'privatemsg_thread_change_status',  // Provide a function which can "undo" the operation. Optional.
-      'undo callback arguments' => array('status' => PRIVATEMSG_UNREAD), // Additional arguments to above function.
+        'callback' => 'privatemsg_thread_change_status', // Function callback that will be executed.
+        'callback arguments' => array('status' => PRIVATEMSG_READ), // Additional arguments to above function
+        'undo callback' => 'privatemsg_thread_change_status',  // Provide a function which can "undo" the operation. Optional.
+        'undo callback arguments' => array('status' => PRIVATEMSG_UNREAD), // Additional arguments to above function.
     ),
-  );
+    );
 }
 
 /**
@@ -474,12 +474,12 @@ 
  * up the string.
  */
 function hook_privatemsg_name_lookup($string) {
-  if ((int)$string > 0) {
+    if ((int)$string > 0) {
     // This is a possible uid, try to load a matching user.
     if ($recipient = user_load(array('uid' => $string))) {
-      return $recipient;
+        return $recipient;
+    }
     }
-  }
 }
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -342,7 +342,7 @@ 
  */
 function hook_privatemsg_message_view_alter(&$var) {
   // add a link to each message
-  $vars['message_links'][] = array('title' => t('My link'), 'href' => '/path/to/my/action/'. $vars['message']['mid']);
+  $vars['message_links'][] = array('title' => t('My link'), 'href' => '/path/to/my/action/'.$vars['message']['mid']);
 }
 
 /**
@@ -406,7 +406,7 @@ 
   }
 
   $args = array_merge(array($author->uid), array_keys($recipients));
-  $result = db_query('SELECT recipient FROM {pm_block_user} WHERE author = %d AND recipient IN ('. db_placeholders($recipients) .') GROUP BY recipient', $args);
+  $result = db_query('SELECT recipient FROM {pm_block_user} WHERE author = %d AND recipient IN ('.db_placeholders($recipients).') GROUP BY recipient', $args);
   while ($row = db_fetch_array($result)) {
     $recipient = $recipients[$row['recipient']];
     // If there's a rule disallowing blocking of this message, send it anyway.
@@ -458,7 +458,7 @@ 
                   should be displayed automatically in the action form',
       'callback' => 'privatemsg_thread_change_status', // Function callback that will be executed.
       'callback arguments' => array('status' => PRIVATEMSG_READ), // Additional arguments to above function
-      'undo callback' => 'privatemsg_thread_change_status',  // Provide a function which can "undo" the operation. Optional.
+      'undo callback' => 'privatemsg_thread_change_status', // Provide a function which can "undo" the operation. Optional.
       'undo callback arguments' => array('status' => PRIVATEMSG_UNREAD), // Additional arguments to above function.
     ),
   );

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -160,7 +160,7 @@ 
   * @param $account
  *   User object of account for which to load the message.
  */
-function hook_privatemsg_sql_load_alter(&$fragments, $pmid, $account = NULL) {
+function hook_privatemsg_sql_load_alter(&$fragments, $pmid, $account = null) {
 
 }
 
@@ -176,7 +176,7 @@ 
  * @param $load_all
  *   Deleted messages are only loaded if this is set to TRUE.
  */
-function hook_privatemsg_sql_messages_alter(&$fragments, $threads, $account = NULL, $load_all = FALSE) {
+function hook_privatemsg_sql_messages_alter(&$fragments, $threads, $account = null, $load_all = false) {
 
 }
 
@@ -301,7 +301,7 @@ 
  * @param $message
  *   Message array
  */
-function hook_privatemsg_message_validate($message, $form = FALSE) {
+function hook_privatemsg_message_validate($message, $form = false) {
   global $_privatemsg_invalid_recipients;
   $_privatemsg_invalid_recipients = array();
 

drupal/sites/default/boinc/modules/contrib/privatemsg/privatemsg_filter/privatemsg_filter.admin.inc

Indentation +57 added lines, -57 removed lines

@@ -9,39 +9,39 @@ 
  * Display a list of tags to administer them.
  */
 function privatemsg_tags_admin() {
-  drupal_set_title(t('Tags'));
+    drupal_set_title(t('Tags'));
 
-  $header = array(
+    $header = array(
     'tag' => array(
-      'data'    => t('Tag'),
-      'field'   => 'tag',
-      'class'   => 'privatemsg-filter-header-tag',
-      'sort'    => 'asc',
-      '#weight' => -40,
+        'data'    => t('Tag'),
+        'field'   => 'tag',
+        'class'   => 'privatemsg-filter-header-tag',
+        'sort'    => 'asc',
+        '#weight' => -40,
     ),
     'usage' => array(
-      'data'    => t('Usage'),
-      'field'   => 'count',
-      'class'   => 'privatemsg-filter-header-usage',
-      '#weight' => -30,
+        'data'    => t('Usage'),
+        'field'   => 'count',
+        'class'   => 'privatemsg-filter-header-usage',
+        '#weight' => -30,
     ),
     'public' => array(
-      'data'    => t('Public'),
-      'field'   => 'public',
-      'class'   => 'privatemsg-filter-header-public',
-      '#weight' => -20,
+        'data'    => t('Public'),
+        'field'   => 'public',
+        'class'   => 'privatemsg-filter-header-public',
+        '#weight' => -20,
     ),
     'operations' => array(
-      'data'    => t('Operations'),
-      'class'   => 'privatemsg-filter-header-operations',
-      '#weight' => -10,
+        'data'    => t('Operations'),
+        'class'   => 'privatemsg-filter-header-operations',
+        '#weight' => -10,
     ),
-  );
-  $query = _privatemsg_assemble_query(array('tags', 'privatemsg_filter'));
-  $result = pager_query($query['query'] . tablesort_sql($header), 100);
+    );
+    $query = _privatemsg_assemble_query(array('tags', 'privatemsg_filter'));
+    $result = pager_query($query['query'] . tablesort_sql($header), 100);
 
-  $rows = array();
-  while ($tag = db_fetch_array($result)) {
+    $rows = array();
+    while ($tag = db_fetch_array($result)) {
     $row = array();
     $row['tag'] = check_plain($tag['tag']);
     $row['count'] = $tag['count'];
@@ -50,14 +50,14 @@ 
     $row['operations'] .= ' ' . l(t('delete'), 'admin/settings/messages/tags/delete/' . $tag['tag_id']);
 
     $rows[] = $row;
-  }
+    }
 
-  if (empty($rows)) {
+    if (empty($rows)) {
     // Display a message if now tags are available.
     $rows[] = array(array('data' => t('No tags available.'), 'colspan' => count($header)));
-  }
+    }
 
-  return theme('table', $header, $rows) . theme('pager');
+    return theme('table', $header, $rows) . theme('pager');
 }
 
 /**
@@ -70,36 +70,36 @@ 
  *   new tag form.
  */
 function privatemsg_tags_form(&$form_state, $tag_id = NULL) {
-  $form = array();
+    $form = array();
 
-  if ($tag_id) {
+    if ($tag_id) {
     $tag = db_fetch_array(db_query('SELECT * from {pm_tags} pmt WHERE pmt.tag_id = %d', $tag_id));
     $form['tag_id'] = array(
-      '#value' => $tag_id,
-      '#type' => 'value',
+        '#value' => $tag_id,
+        '#type' => 'value',
     );
     drupal_set_title(t('Edit @tag', array('@tag' => $tag['tag'])));
-  }
+    }
 
-  $form['tag'] = array(
+    $form['tag'] = array(
     '#title' => t('Name'),
     '#type' => 'textfield',
     '#default_value' => empty($tag_id) ? NULL : $tag['tag'],
-  );
+    );
 
-  $form['public'] = array(
+    $form['public'] = array(
     '#title' => t('Public'),
     '#type' => 'checkbox',
     '#default_value' => empty($tag_id) ? TRUE : $tag['public'],
     '#description' => t('Public tags are visible for all users, private tags are only visible if they use them.'),
-  );
+    );
 
-  $form['submit'] = array(
+    $form['submit'] = array(
     '#value' => empty($tag_id) ? t('Create tag') : t('Save tag'),
     '#type'  => 'submit',
-  );
+    );
 
-  return $form;
+    return $form;
 }
 
 /**
@@ -108,34 +108,34 @@ 
  * Make sure that a tag name is unique.
  */
 function privatemsg_tags_form_validate($form, &$form_state) {
-  $tag_id = isset($form_state['values']['tag_id']) ? $form_state['values']['tag_id'] : 0;
-  if ($tag_id) {
+    $tag_id = isset($form_state['values']['tag_id']) ? $form_state['values']['tag_id'] : 0;
+    if ($tag_id) {
     // We are editing an existing tag, exclude the current tag from the search.
     $exists = db_result(db_query("SELECT 1 FROM {pm_tags} WHERE tag = '%s' AND tag_id <> %d", $form_state['values']['tag'], $tag_id));
-  }
-  else {
+    }
+    else {
     $exists = db_result(db_query("SELECT 1 FROM {pm_tags} WHERE tag = '%s'", $form_state['values']['tag']));
-  }
-  if ($exists) {
+    }
+    if ($exists) {
     form_set_error('tag', t('Tag already exists, choose a different name.'));
-  }
+    }
 }
 
 /**
  * Form submit handler for add/edit forms.
  */
 function privatemsg_tags_form_submit($form, &$form_state) {
-  if (!empty($form_state['values']['tag_id'])) {
+    if (!empty($form_state['values']['tag_id'])) {
     // Tag already exists, update the existing tag.
     db_query("UPDATE {pm_tags} SET tag = '%s', public = %d WHERE tag_id = %d", $form_state['values']['tag'], $form_state['values']['public'], $form_state['values']['tag_id']);
     drupal_set_message(t('Tag updated.'));
     $form_state['redirect'] = 'admin/settings/messages/tags';
-  }
-  else {
+    }
+    else {
     // Tag does not yet exist, create a new one.
     db_query("INSERT INTO {pm_tags} (tag, public) VALUES ('%s', %d)", $form_state['values']['tag'], $form_state['values']['public']);
     drupal_set_message(t('Tag created.'));
-  }
+    }
 }
 
 /**
@@ -145,28 +145,28 @@ 
  *   Id of the tag that should be deleted.
  */
 function privatemsg_filter_tags_delete(&$form_state, $tag_id) {
-  $form['tag_id'] = array(
+    $form['tag_id'] = array(
     '#type' => 'value',
     '#value' => $tag_id,
-  );
-  return confirm_form($form,
+    );
+    return confirm_form($form,
     t('Are you sure you want to delete?'),
     isset($_GET['destination']) ? $_GET['destination'] : 'admin/settings/messages/tags',
     t('This action cannot be undone.'),
     t('Delete'),
     t('Cancel')
-  );
+    );
 }
 
 /**
  * Submit handler for the confirm delete form.
  */
 function privatemsg_filter_tags_delete_submit($form, &$form_state) {
-  if ($form_state['values']['confirm']) {
+    if ($form_state['values']['confirm']) {
     db_query('DELETE FROM {pm_tags} WHERE tag_id = %d', $form_state['values']['tag_id']);
     db_query('DELETE FROM {pm_tags_index} WHERE tag_id = %d', $form_state['values']['tag_id']);
 
     drupal_set_message(t('Tag has been deleted'));
-  }
-  $form_state['redirect'] = 'admin/settings/messages/tags';
+    }
+    $form_state['redirect'] = 'admin/settings/messages/tags';
 }
\ No newline at end of file

Spacing +4 added lines, -4 removed lines

@@ -38,7 +38,7 @@ 
     ),
   );
   $query = _privatemsg_assemble_query(array('tags', 'privatemsg_filter'));
-  $result = pager_query($query['query'] . tablesort_sql($header), 100);
+  $result = pager_query($query['query'].tablesort_sql($header), 100);
 
   $rows = array();
   while ($tag = db_fetch_array($result)) {
@@ -46,8 +46,8 @@ 
     $row['tag'] = check_plain($tag['tag']);
     $row['count'] = $tag['count'];
     $row['public'] = $tag['public'] ? t('Yes') : '-';
-    $row['operations'] = l(t('edit'), 'admin/settings/messages/tags/edit/' . $tag['tag_id']);
-    $row['operations'] .= ' ' . l(t('delete'), 'admin/settings/messages/tags/delete/' . $tag['tag_id']);
+    $row['operations'] = l(t('edit'), 'admin/settings/messages/tags/edit/'.$tag['tag_id']);
+    $row['operations'] .= ' '.l(t('delete'), 'admin/settings/messages/tags/delete/'.$tag['tag_id']);
 
     $rows[] = $row;
   }
@@ -57,7 +57,7 @@ 
     $rows[] = array(array('data' => t('No tags available.'), 'colspan' => count($header)));
   }
 
-  return theme('table', $header, $rows) . theme('pager');
+  return theme('table', $header, $rows).theme('pager');
 }
 
 /**

Braces +2 added lines, -4 removed lines

@@ -112,8 +112,7 @@ 
   if ($tag_id) {
     // We are editing an existing tag, exclude the current tag from the search.
     $exists = db_result(db_query("SELECT 1 FROM {pm_tags} WHERE tag = '%s' AND tag_id <> %d", $form_state['values']['tag'], $tag_id));
-  }
-  else {
+  } else {
     $exists = db_result(db_query("SELECT 1 FROM {pm_tags} WHERE tag = '%s'", $form_state['values']['tag']));
   }
   if ($exists) {
@@ -130,8 +129,7 @@ 
     db_query("UPDATE {pm_tags} SET tag = '%s', public = %d WHERE tag_id = %d", $form_state['values']['tag'], $form_state['values']['public'], $form_state['values']['tag_id']);
     drupal_set_message(t('Tag updated.'));
     $form_state['redirect'] = 'admin/settings/messages/tags';
-  }
-  else {
+  } else {
     // Tag does not yet exist, create a new one.
     db_query("INSERT INTO {pm_tags} (tag, public) VALUES ('%s', %d)", $form_state['values']['tag'], $form_state['values']['public']);
     drupal_set_message(t('Tag created.'));

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -69,7 +69,7 @@ 
  *   Tag Id if an edit form should be displayed, NULL for a create
  *   new tag form.
  */
-function privatemsg_tags_form(&$form_state, $tag_id = NULL) {
+function privatemsg_tags_form(&$form_state, $tag_id = null) {
   $form = array();
 
   if ($tag_id) {
@@ -84,13 +84,13 @@ 
   $form['tag'] = array(
     '#title' => t('Name'),
     '#type' => 'textfield',
-    '#default_value' => empty($tag_id) ? NULL : $tag['tag'],
+    '#default_value' => empty($tag_id) ? null : $tag['tag'],
   );
 
   $form['public'] = array(
     '#title' => t('Public'),
     '#type' => 'checkbox',
-    '#default_value' => empty($tag_id) ? TRUE : $tag['public'],
+    '#default_value' => empty($tag_id) ? true : $tag['public'],
     '#description' => t('Public tags are visible for all users, private tags are only visible if they use them.'),
   );
 

drupal/sites/default/boinc/modules/contrib/privatemsg/privatemsg_filter/privatemsg_filter.module

Indentation +314 added lines, -314 removed lines

@@ -9,34 +9,34 @@ 
  * Implements hook_perm().
  */
 function privatemsg_filter_perm() {
-  return array(
+    return array(
     'filter private messages',
     'tag private messages',
     'create private message tags',
-  );
+    );
 }
 
 /**
  * Implements hook_menu().
  */
 function privatemsg_filter_menu() {
-  $items['admin/settings/messages/filter'] = array(
+    $items['admin/settings/messages/filter'] = array(
     'title'            => 'Filter',
     'description'      => 'Configure filter settings.',
     'page callback'    => 'drupal_get_form',
     'page arguments'   => array('privatemsg_filter_admin'),
     'access arguments' => array('administer privatemsg settings'),
     'type'             => MENU_LOCAL_TASK,
-  );
-  $items['admin/settings/messages/tags'] = array(
+    );
+    $items['admin/settings/messages/tags'] = array(
     'title'            => 'Tags',
     'description'      => 'Configure tags.',
     'page callback'    => 'privatemsg_tags_admin',
     'access arguments' => array('administer privatemsg settings'),
     'type'             => MENU_LOCAL_TASK,
     'file'             => 'privatemsg_filter.admin.inc',
-  );
-  $items['admin/settings/messages/tags/list'] = array(
+    );
+    $items['admin/settings/messages/tags/list'] = array(
     'title'            => 'List',
     'description'      => 'Configure tags.',
     'page callback'    => 'privatemsg_tags_admin',
@@ -44,8 +44,8 @@ 
     'type'             => MENU_DEFAULT_LOCAL_TASK,
     'file'             => 'privatemsg_filter.admin.inc',
     'weight'           => -10,
-  );
-  $items['admin/settings/messages/tags/add'] = array(
+    );
+    $items['admin/settings/messages/tags/add'] = array(
     'title'            => 'Add',
     'description'      => 'Configure tags.',
     'page callback'    => 'drupal_get_form',
@@ -53,8 +53,8 @@ 
     'access arguments' => array('administer privatemsg settings'),
     'type'             => MENU_LOCAL_TASK,
     'file'             => 'privatemsg_filter.admin.inc',
-  );
-  $items['admin/settings/messages/tags/edit/%'] = array(
+    );
+    $items['admin/settings/messages/tags/edit/%'] = array(
     'title'            => 'Add',
     'description'      => 'Configure tags.',
     'page callback'    => 'drupal_get_form',
@@ -62,8 +62,8 @@ 
     'access arguments' => array('administer privatemsg settings'),
     'type'             => MENU_CALLBACK,
     'file'             => 'privatemsg_filter.admin.inc',
-  );
-  $items['admin/settings/messages/tags/delete/%'] = array(
+    );
+    $items['admin/settings/messages/tags/delete/%'] = array(
     'title'            => 'Add',
     'description'      => 'Configure tags.',
     'page callback'    => 'drupal_get_form',
@@ -71,62 +71,62 @@ 
     'access arguments' => array('administer privatemsg settings'),
     'type'             => MENU_CALLBACK,
     'file'             => 'privatemsg_filter.admin.inc',
-  );
-  $items['messages/inbox'] = array(
+    );
+    $items['messages/inbox'] = array(
     'title'            => 'Inbox',
     'page callback'    => 'drupal_get_form',
     'page arguments'   => array('privatemsg_list', 'inbox'),
     'access callback'  => 'privatemsg_user_access',
     'type'             => variable_get('privatemsg_filter_default_list', 0) ? MENU_LOCAL_TASK : MENU_DEFAULT_LOCAL_TASK,
     'weight'           => -15,
-  );
-  $items['messages/sent'] = array(
+    );
+    $items['messages/sent'] = array(
     'title'            => 'Sent messages',
     'page callback'    => 'drupal_get_form',
     'page arguments'   => array('privatemsg_list', 'sent'),
     'access callback'  => 'privatemsg_user_access',
     'type'             => MENU_LOCAL_TASK,
     'weight'           => -12,
-  );
-  $items['messages/filter/user-name-autocomplete'] = array(
+    );
+    $items['messages/filter/user-name-autocomplete'] = array(
     'page callback'    => 'privatemsg_user_name_autocomplete',
     'access callback'  => 'privatemsg_user_access',
     'access arguments' => array('write privatemsg'),
     'type'             => MENU_CALLBACK,
-  );
-  $items['messages/filter/tag-autocomplete'] = array(
+    );
+    $items['messages/filter/tag-autocomplete'] = array(
     'page callback'    => 'privatemsg_filter_tags_autocomplete',
     'access callback'  => 'privatemsg_user_access',
     'access arguments' => array('tag private messages'),
     'type'             => MENU_CALLBACK,
     'weight'           => -10,
-  );
-  return $items;
+    );
+    return $items;
 }
 
 /**
  * Implements hook_menu_alter().
  */
 function privatemsg_filter_menu_alter(&$items) {
-  // Rename messages to "All messages".
-  $items['messages/list']['title'] = 'All messages';
+    // Rename messages to "All messages".
+    $items['messages/list']['title'] = 'All messages';
 
-  if (variable_get('privatemsg_filter_default_list', 0) == 0) {
+    if (variable_get('privatemsg_filter_default_list', 0) == 0) {
     // Change default argument of /messages to inbox. and set the task to MENU_LOCAL_TASK.
     $items['messages']['page arguments'] = array('privatemsg_list', 'inbox');
     $items['messages/list']['type'] = MENU_LOCAL_TASK;
-  }
+    }
 }
 
 function privatemsg_filter_admin() {
-  $form = array();
+    $form = array();
 
-  $form['privatemsg_filter_searchbody'] = array(
+    $form['privatemsg_filter_searchbody'] = array(
     '#type'          => 'checkbox',
     '#title'         => t('Search message body'),
     '#description'   => t('WARNING: turning on this feature will slow down search performance by a large factor. Gets worse as your messages database increases.'),
     '#default_value' => variable_get('privatemsg_filter_searchbody', FALSE),
-  );
+    );
 
     $form['privatemsg_filter_tagfield_weight'] = array(
     '#type'          => 'textfield',
@@ -134,9 +134,9 @@ 
     '#description'   => t('Use higher values to push the form lower down the page, lower or negative values to raise it higher.'),
     '#size'          => 4,
     '#default_value' => variable_get('privatemsg_filter_tagfield_weight', 10),
-  );
+    );
 
-  return system_settings_form($form);
+    return system_settings_form($form);
 }
 
 /**
@@ -145,26 +145,26 @@ 
  * Add a filter widget to the message listing pages.
  */
 function privatemsg_filter_form_private_message_settings_alter(&$form, $form_state) {
-  $form['privatemsg_listing']['privatemsg_filter_default_list'] = array(
+    $form['privatemsg_listing']['privatemsg_filter_default_list'] = array(
     '#type' => 'radios',
     '#default_value' => variable_get('privatemsg_filter_default_list', 0),
     '#options' => array(t('Inbox'), t('All messages')),
     '#title' => t('Choose the default list option'),
     '#description' => t('Choose which of the two lists are shown by default when following the messages link.'),
-  );
-  // Add tags to the list of possible columns.
-  $form['privatemsg_listing']['privatemsg_display_fields']['#options']['tags'] = t('Tags');
+    );
+    // Add tags to the list of possible columns.
+    $form['privatemsg_listing']['privatemsg_display_fields']['#options']['tags'] = t('Tags');
 
-  $form['#submit'][] = 'privatemsg_filter_settings_submit';
+    $form['#submit'][] = 'privatemsg_filter_settings_submit';
 }
 
 /**
  * Rebuilding the menu if necessary.
  */
 function privatemsg_filter_settings_submit($form, &$form_state) {
-  if ($form['privatemsg_listing']['privatemsg_filter_default_list']['#default_value'] != $form_state['values']['privatemsg_filter_default_list']) {
+    if ($form['privatemsg_listing']['privatemsg_filter_default_list']['#default_value'] != $form_state['values']['privatemsg_filter_default_list']) {
     menu_rebuild();
-  }
+    }
 }
 
 /**
@@ -174,33 +174,33 @@ 
  *   A single tag or an array of tags.
  */
 function privatemsg_filter_create_tags($tags) {
-  if (!is_array($tags)) {
+    if (!is_array($tags)) {
     $tags = array($tags);
-  }
+    }
 
-  $tag_ids = array();
+    $tag_ids = array();
 
-  foreach ($tags as $tag) {
+    foreach ($tags as $tag) {
     $tag = trim($tag);
     if (empty($tag)) {
-      // Do not save a blank tag.
-      continue;
+        // Do not save a blank tag.
+        continue;
     }
 
     // Check if the tag already exists and only create the tag if it does not.
     $tag_id = db_result(db_query("SELECT tag_id FROM {pm_tags} WHERE tag = '%s'", $tag));
     if (empty($tag_id) && privatemsg_user_access('create private message tags')) {
-      db_query("INSERT INTO {pm_tags} (tag) VALUES ('%s')", $tag);
-      $tag_id = db_last_insert_id('pm_tags', 'tag_id');
+        db_query("INSERT INTO {pm_tags} (tag) VALUES ('%s')", $tag);
+        $tag_id = db_last_insert_id('pm_tags', 'tag_id');
     }
     elseif (empty($tag_id)) {
-      // The user does not have permission to create new tags - disregard this tag and move onto the next.
-      drupal_set_message(t('Tag %tag was ignored because you do not have permission to create new tags.', array('%tag' => $tag)));
-      continue;
+        // The user does not have permission to create new tags - disregard this tag and move onto the next.
+        drupal_set_message(t('Tag %tag was ignored because you do not have permission to create new tags.', array('%tag' => $tag)));
+        continue;
     }
     $tag_ids[] = $tag_id;
-  }
-  return $tag_ids;
+    }
+    return $tag_ids;
 }
 
 /**
@@ -212,21 +212,21 @@ 
  *   Id of the tag.
  */
 function privatemsg_filter_add_tags($threads, $tag_id, $account = NULL) {
-  if (!is_array($threads)) {
+    if (!is_array($threads)) {
     $threads = array($threads);
-  }
-  if (empty($account)) {
+    }
+    if (empty($account)) {
     global $user;
     $account = drupal_clone($user);
-  }
+    }
 
-  foreach ($threads as $thread) {
+    foreach ($threads as $thread) {
     // Make sure that we don't add a tag to a thread twice,
     // only insert if there is no such tag yet.
     if (db_result(db_query('SELECT COUNT(*) FROM {pm_tags_index} WHERE tag_id = %d AND (uid = %d AND thread_id = %d)', $tag_id, $account->uid, $thread)) == 0) {
-      db_query('INSERT INTO {pm_tags_index} (tag_id, uid, thread_id) VALUES (%d, %d, %d)', $tag_id, $account->uid, $thread);
+        db_query('INSERT INTO {pm_tags_index} (tag_id, uid, thread_id) VALUES (%d, %d, %d)', $tag_id, $account->uid, $thread);
+    }
     }
-  }
 }
 
 /**
@@ -238,238 +238,238 @@ 
  *   Id of the tag - set to NULL to remove all tags.
  */
 function privatemsg_filter_remove_tags($threads, $tag_id = NULL, $account = NULL) {
-  if (!is_array($threads)) {
+    if (!is_array($threads)) {
     $threads = array($threads);
-  }
-  if (empty($account)) {
+    }
+    if (empty($account)) {
     global $user;
     $account = drupal_clone($user);
-  }
+    }
 
-  if (is_null($tag_id)) {
+    if (is_null($tag_id)) {
     // Delete all tag mapping.
     foreach ($threads as $thread) {
-      db_query('DELETE FROM {pm_tags_index} WHERE uid = %d AND thread_id = %d', $account->uid, $thread);
+        db_query('DELETE FROM {pm_tags_index} WHERE uid = %d AND thread_id = %d', $account->uid, $thread);
+    }
     }
-  }
-  else {
+    else {
     // Delete tag mapping for the specified tag.
     foreach ($threads as $thread) {
-      db_query('DELETE FROM {pm_tags_index} WHERE uid = %d AND thread_id = %d AND tag_id = %d', $account->uid, $thread, $tag_id);
+        db_query('DELETE FROM {pm_tags_index} WHERE uid = %d AND thread_id = %d AND tag_id = %d', $account->uid, $thread, $tag_id);
+    }
     }
-  }
 }
 
 function privatemsg_filter_get_filter($account) {
-  $filter = array();
-  if (isset($_GET['tags'])) {
+    $filter = array();
+    if (isset($_GET['tags'])) {
     $_GET['tags'] = urldecode($_GET['tags']);
     $tag_data = privatemsg_filter_get_tags_data($account);
     foreach (explode(',', $_GET['tags']) as $tag) {
-      if (isset($tag_data[$tag])) {
+        if (isset($tag_data[$tag])) {
         $filter['tags'][$tag] = $tag;
-      }
-      elseif (in_array($tag, $tag_data)) {
+        }
+        elseif (in_array($tag, $tag_data)) {
         $filter['tags'][array_search($tag, $tag_data)] = array_search($tag, $tag_data);
-      }
+        }
+    }
     }
-  }
 
-  if (isset($_GET['author'])) {
+    if (isset($_GET['author'])) {
     list($filter['author']) = _privatemsg_parse_userstring($_GET['author']);
-  }
+    }
 
-  if (isset($_GET['search'])) {
+    if (isset($_GET['search'])) {
     $filter['search'] = $_GET['search'];
-  }
+    }
 
-  if (!empty($filter)) {
+    if (!empty($filter)) {
     return $filter;
-  }
+    }
 
-  if (!empty($_SESSION['privatemsg_filter'])) {
+    if (!empty($_SESSION['privatemsg_filter'])) {
     return $_SESSION['privatemsg_filter'];
-  }
+    }
 
 }
 
 function privatemsg_filter_get_tags_data($account) {
-  static $tag_data;
+    static $tag_data;
 
-  if (is_array($tag_data)) {
+    if (is_array($tag_data)) {
     return $tag_data;
-  }
+    }
 
-  // Only show the tags that a user have used.
-  $query = _privatemsg_assemble_query(array('tags', 'privatemsg_filter'), $account);
-  $results = db_query($query['query']);
+    // Only show the tags that a user have used.
+    $query = _privatemsg_assemble_query(array('tags', 'privatemsg_filter'), $account);
+    $results = db_query($query['query']);
 
-  $tag_data = array();
-  while ($result = db_fetch_object($results)) {
+    $tag_data = array();
+    while ($result = db_fetch_object($results)) {
     $tag_data[$result->tag_id] = $result->tag;
-  }
-  return $tag_data;
+    }
+    return $tag_data;
 }
 
 function privatemsg_filter_dropdown(&$form_state, $account) {
 
-  drupal_add_css(drupal_get_path('module', 'privatemsg_filter') .'/privatemsg_filter.css');
+    drupal_add_css(drupal_get_path('module', 'privatemsg_filter') .'/privatemsg_filter.css');
 
-  $form['filter'] = array(
+    $form['filter'] = array(
     '#type' => 'fieldset',
     '#title' => t('Filter messages'),
     '#collapsible' => TRUE,
     '#collapsed' => TRUE,
-  );
-  $form['filter']['search'] = array(
+    );
+    $form['filter']['search'] = array(
     '#type' => 'textfield',
     '#title' => variable_get('privatemsg_filter_searchbody', FALSE) ? t('Search messages') : t('Search subjects'),
     '#weight' => -20
-  );
+    );
 
-  $form['filter']['author'] = array(
+    $form['filter']['author'] = array(
     '#type'               => 'textfield',
     '#title'              => t('Participants'),
     '#description'        => t('Separate multiple names with commas.'),
     '#weight'             => -5,
     '#size'               => 50,
     '#autocomplete_path'  => 'messages/filter/user-name-autocomplete',
-  );
+    );
 
-  // Only show form if the user has some messages tagged.
-  if (count($tag_data = privatemsg_filter_get_tags_data($account))) {
+    // Only show form if the user has some messages tagged.
+    if (count($tag_data = privatemsg_filter_get_tags_data($account))) {
     $form['filter']['tags'] = array(
-      '#type' => 'select',
-      '#title' => t('Tags'),
-      '#options' => $tag_data,
-      '#multiple' => TRUE,
-      '#size' => 5,
-      '#weight' => 0
-    );
-  }
+        '#type' => 'select',
+        '#title' => t('Tags'),
+        '#options' => $tag_data,
+        '#multiple' => TRUE,
+        '#size' => 5,
+        '#weight' => 0
+    );
+    }
     $form['filter']['submit'] = array(
-      '#type'     => 'submit',
-      '#value'    => t('Filter'),
-      '#prefix'   => '<div id="privatemsg-filter-buttons">',
-      '#weight'   => 10,
-      '#submit'   => array('privatemsg_filter_dropdown_submit'),
+        '#type'     => 'submit',
+        '#value'    => t('Filter'),
+        '#prefix'   => '<div id="privatemsg-filter-buttons">',
+        '#weight'   => 10,
+        '#submit'   => array('privatemsg_filter_dropdown_submit'),
     );
 
     $form['filter']['save'] = array(
-      '#type'     => 'submit',
-      '#value'    => t('Save filter'),
-      '#suffix'   => '</div>',
-      '#weight'   => 11,
-      '#submit'   => array('privatemsg_filter_dropdown_submit'),
+        '#type'     => 'submit',
+        '#value'    => t('Save filter'),
+        '#suffix'   => '</div>',
+        '#weight'   => 11,
+        '#submit'   => array('privatemsg_filter_dropdown_submit'),
     );
 
     if ($filter = privatemsg_filter_get_filter($account)) {
-      privatemsg_filter_dropdown_set_active($form, $filter);
+        privatemsg_filter_dropdown_set_active($form, $filter);
     }
 
     return $form;
 }
 
 function privatemsg_filter_dropdown_set_active(&$form, $filter) {
-  $form['filter']['#title'] = t('Filter messages (active)');
-  $form['filter']['#collapsed'] = FALSE;
+    $form['filter']['#title'] = t('Filter messages (active)');
+    $form['filter']['#collapsed'] = FALSE;
 
-  if (isset($filter['author'])) {
+    if (isset($filter['author'])) {
     $string = '';
     foreach ($filter['author'] as $author) {
-      $string .= $author->name . ', ';
+        $string .= $author->name . ', ';
     }
     $form['filter']['author']['#default_value'] = $string;
-  }
-  if (isset($filter['tags'])) {
+    }
+    if (isset($filter['tags'])) {
     $form['filter']['tags']['#default_value'] = $filter['tags'];
-  }
-  if (isset($filter['search'])) {
+    }
+    if (isset($filter['search'])) {
     $form['filter']['search']['#default_value'] = $filter['search'];
-  }
-
-  $form['filter']['reset'] = array(
-      '#type'     => 'submit',
-      '#value'    => t('Reset'),
-      '#suffix'   => '</div>',
-      '#weight'   => 12,
-      '#submit'   => array('privatemsg_filter_dropdown_submit'),
-  );
-  unset($form['filter']['save']['#suffix']);
+    }
+
+    $form['filter']['reset'] = array(
+        '#type'     => 'submit',
+        '#value'    => t('Reset'),
+        '#suffix'   => '</div>',
+        '#weight'   => 12,
+        '#submit'   => array('privatemsg_filter_dropdown_submit'),
+    );
+    unset($form['filter']['save']['#suffix']);
 }
 
 function privatemsg_filter_dropdown_submit($form, &$form_state) {
 
-  if (!empty($form_state['values']['author'])) {
+    if (!empty($form_state['values']['author'])) {
     list($form_state['values']['author']) = _privatemsg_parse_userstring($form_state['values']['author']);
-  }
+    }
 
-  switch ($form_state['values']['op']) {
+    switch ($form_state['values']['op']) {
     case t('Save filter'):
       $filter = array();
-      if (!empty($form_state['values']['tags'])) {
+        if (!empty($form_state['values']['tags'])) {
         $filter['tags'] = $form_state['values']['tags'];
-      }
-      if (!empty($form_state['values']['author'])) {
+        }
+        if (!empty($form_state['values']['author'])) {
         $filter['author'] = $form_state['values']['author'];
-      }
-      if (!empty($form_state['values']['search'])) {
+        }
+        if (!empty($form_state['values']['search'])) {
         $filter['search'] = $form_state['values']['search'];
-      }
-      $_SESSION['privatemsg_filter'] = $filter;
-      break;
+        }
+        $_SESSION['privatemsg_filter'] = $filter;
+        break;
     case t('Filter'):
       drupal_goto($_GET['q'], privatemsg_filter_create_get_query($form_state['values']));
-      return;
-      break;
+        return;
+        break;
     case t('Reset'):
       $_SESSION['privatemsg_filter'] = array();
-      break;
-  }
-  $form_state['redirect'] = $_GET['q'];
+        break;
+    }
+    $form_state['redirect'] = $_GET['q'];
 }
 
 function privatemsg_filter_create_get_query($filter) {
-  $query = array();
-  if (isset($filter['tags']) && !empty($filter['tags'])) {
+    $query = array();
+    if (isset($filter['tags']) && !empty($filter['tags'])) {
     $ids = array();
     foreach ($filter['tags'] as $tag) {
-      if ((int)$tag > 0) {
+        if ((int)$tag > 0) {
         $ids[] = $tag;
-      }
-      else {
+        }
+        else {
         $query['tags'][] = $tag;
-      }
+        }
     }
     $sql = 'SELECT pmt.tag FROM {pm_tags} pmt WHERE pmt.tag_id IN ('. implode(', ', $filter['tags']) .')';
     $result = db_query($sql);
     while ($row = db_fetch_object($result)) {
-      $query['tags'][] = $row->tag;
+        $query['tags'][] = $row->tag;
     }
 
     if (isset($query['tags'])) {
-      $query['tags'] = implode(',', $query['tags']);
+        $query['tags'] = implode(',', $query['tags']);
+    }
     }
-  }
 
-  if (isset($filter['author']) && !empty($filter['author'])) {
+    if (isset($filter['author']) && !empty($filter['author'])) {
     foreach ($filter['author'] as $author) {
-      if (is_object($author) && isset($author->uid) && isset($author->name)) {
+        if (is_object($author) && isset($author->uid) && isset($author->name)) {
         $query['author'][] = $author->name;
-      }
-      elseif ($author_obj = user_load($author)) {
+        }
+        elseif ($author_obj = user_load($author)) {
         $query['author'][] = $author_obj->name;
-      }
+        }
     }
     if (isset($query['author'])) {
-      $query['author'] = implode(',', $query['author']);
+        $query['author'] = implode(',', $query['author']);
+    }
     }
-  }
 
-  if (isset($filter['search']) && !empty($filter['search'])) {
+    if (isset($filter['search']) && !empty($filter['search'])) {
     $query['search'] = $filter['search'];
-  }
-  return $query;
+    }
+    return $query;
 }
 
 /**
@@ -478,14 +478,14 @@ 
  * Adds a filter widget to the message listing pages.
  */
 function privatemsg_filter_form_privatemsg_list_alter(&$form, $form_state) {
-  global $user;
+    global $user;
 
-  if (privatemsg_user_access('filter private messages') && !empty($form['#data'])) {
+    if (privatemsg_user_access('filter private messages') && !empty($form['#data'])) {
     $form += privatemsg_filter_dropdown($form_state, $form['#account']);
-  }
+    }
 
-  $fields = array_filter(variable_get('privatemsg_display_fields', array('participants')));
-  if (in_array('tags', $fields)) {
+    $fields = array_filter(variable_get('privatemsg_display_fields', array('participants')));
+    if (in_array('tags', $fields)) {
     // Load thread id's of the current list.
     $threads = array_keys($form['#data']);
 
@@ -495,21 +495,21 @@ 
     // Add them to #data
     $result = db_query($query['query']);
     while ($tag = db_fetch_array($result)) {
-      $form['#data'][$tag['thread_id']]['tags'][$tag['tag_id']] = $tag['tag'];
+        $form['#data'][$tag['thread_id']]['tags'][$tag['tag_id']] = $tag['tag'];
+    }
     }
-  }
 
-  $tags = privatemsg_filter_get_tags_data($user);
-  if (privatemsg_user_access('tag private messages') && !empty($tags) && !empty($form['#data'])) {
+    $tags = privatemsg_filter_get_tags_data($user);
+    if (privatemsg_user_access('tag private messages') && !empty($tags) && !empty($form['#data'])) {
     $options = array();
     $options[] = t('Apply tag...');
     foreach ($tags as $tag_id => $tag) {
-      $options[$tag_id] = $tag;
+        $options[$tag_id] = $tag;
     }
     $form['actions']['tag-add'] = array(
-      '#type'          => 'select',
-      '#options'       => $options,
-      '#default_value' => 0,
+        '#type'          => 'select',
+        '#options'       => $options,
+        '#default_value' => 0,
     );
     $form['actions']['tag-add-submit'] = array(
         '#prefix'     => '<div class="privatemsg-tag-add-submit">',
@@ -521,9 +521,9 @@ 
     );
     $options[0] = t('Remove Tag...');
     $form['actions']['tag-remove'] = array(
-      '#type'          => 'select',
-      '#options'       => $options,
-      '#default_value' => 0,
+        '#type'          => 'select',
+        '#options'       => $options,
+        '#default_value' => 0,
     );
     $form['actions']['tag-remove-submit'] = array(
         '#prefix'     => '<div class="privatemsg-tag-remove-submit">',
@@ -536,7 +536,7 @@ 
 
     // JS for hiding the submit buttons.
     drupal_add_js(drupal_get_path('module', 'privatemsg_filter') .'/privatemsg-filter-list.js');
-  }
+    }
 }
 
 /**
@@ -545,12 +545,12 @@ 
  * @see theme_privatemsg_list_header()
  */
 function phptemplate_privatemsg_list_header__tags() {
-   return array(
+    return array(
     'data' => t('Tags'),
     'key' => 'tags',
     'class' => 'privatemsg-header-tags',
     '#weight' => -42,
-  );
+    );
 }
 
 
@@ -560,48 +560,48 @@ 
  * @see theme_privatemsg_list_field()
  */
 function phptemplate_privatemsg_list_field__tags($thread) {
-  if (!empty($thread['tags'])) {
+    if (!empty($thread['tags'])) {
     $tags = array();
 
     foreach ($thread['tags'] as $tag_id => $tag) {
-      $tags[] = l(strlen($tag) > 15 ? substr($tag, 0, 13) . '...' : $tag, 'messages', array(
+        $tags[] = l(strlen($tag) > 15 ? substr($tag, 0, 13) . '...' : $tag, 'messages', array(
         'attributes' => array('title' => $tag),
         'query' => array('tags' => $tag)
-      ));
+        ));
     }
     return array(
-      'data'  => implode(', ', $tags),
-      'class' => 'privatemsg-list-tags',
+        'data'  => implode(', ', $tags),
+        'class' => 'privatemsg-list-tags',
     );
-  }
+    }
 }
 
 /**
  * Form callback for adding a tag to threads.
  */
 function privatemsg_filter_add_tag_submit($form, &$form_state) {
-  $operation = array(
+    $operation = array(
     'callback' => 'privatemsg_filter_add_tags',
     'callback arguments' => array('tag_id' => $form_state['values']['tag-add']),
     'undo callback' => 'privatemsg_filter_remove_tags',
     'undo callback arguments' => array('tag_id' => $form_state['values']['tag-add']),
-  );
-  drupal_set_message(t('The selected conversations have been tagged.'));
-  privatemsg_operation_execute($operation, $form_state['values']['threads']);
+    );
+    drupal_set_message(t('The selected conversations have been tagged.'));
+    privatemsg_operation_execute($operation, $form_state['values']['threads']);
 }
 
 /**
  * Form callback for removing a tag to threads.
  */
 function privatemsg_filter_remove_tag_submit($form, &$form_state) {
-  $operation = array(
+    $operation = array(
     'callback' => 'privatemsg_filter_remove_tags',
     'callback arguments' => array('tag_id' => $form_state['values']['tag-remove']),
     'undo callback' => 'privatemsg_filter_add_tags',
     'undo callback arguments' => array('tag_id' => $form_state['values']['tag-remove']),
-  );
-  drupal_set_message(t('The tag has been removed from the selected conversations.'));
-  privatemsg_operation_execute($operation, $form_state['values']['threads']);
+    );
+    drupal_set_message(t('The tag has been removed from the selected conversations.'));
+    privatemsg_operation_execute($operation, $form_state['values']['threads']);
 }
 
 /**
@@ -609,114 +609,114 @@ 
  */
 function privatemsg_filter_privatemsg_sql_list_alter(&$fragments, $account, $argument) {
 
-  // Check if its a filtered view.
-  if ($argument == 'sent') {
+    // Check if its a filtered view.
+    if ($argument == 'sent') {
     $fragments['where'][]       = "pm.author = %d";
     $fragments['query_args']['where'][]   = $account->uid;
-  }
-  if ($argument == 'inbox') {
+    }
+    if ($argument == 'inbox') {
     $fragments['having'][]       = '((SELECT pmf.author FROM {pm_message} pmf WHERE pmf.mid = pmi.thread_id) = %d AND COUNT(pmi.thread_id) > 1) OR (SELECT COUNT(*) FROM {pm_message} pmf INNER JOIN {pm_index} pmif ON (pmf.mid = pmif.mid) WHERE pmif.thread_id = pmi.thread_id AND pmf.author <> %d) > 0';
     $fragments['query_args']['having'][]   = $account->uid;
     $fragments['query_args']['having'][]   = $account->uid;
-  }
+    }
 
-  // Filter the message listing by any set tags.
-  if ($filter = privatemsg_filter_get_filter($account)) {
+    // Filter the message listing by any set tags.
+    if ($filter = privatemsg_filter_get_filter($account)) {
     $count = 0;
     if (isset($filter['tags']) && !empty($filter['tags'])) {
-      foreach ($filter['tags'] as $tag) {
+        foreach ($filter['tags'] as $tag) {
         $fragments['inner_join'][]  = "INNER JOIN {pm_tags_index} pmti$count ON (pmti$count.thread_id = pmi.thread_id AND pmti$count.uid = pmi.uid)";
         $fragments['where'][]       = "pmti$count.tag_id = %d";
         $fragments['query_args']['where'][]   = $tag;
         $count++;
-      }
+        }
     }
 
     if (isset($filter['author']) && !empty($filter['author'])) {
-      foreach ($filter['author'] as $author) {
+        foreach ($filter['author'] as $author) {
         $fragments['inner_join'][]  = "INNER JOIN {pm_index} pmi$count ON (pmi$count.mid = pm.mid)";
         $fragments['where'][]       = "pmi$count.uid = %d";
         $fragments['query_args']['where'][]   = $author->uid;
         $count++;
-      }
+        }
     }
 
     if (isset($filter['search']) && !empty($filter['search'])) {
-      if (variable_get('privatemsg_filter_searchbody', FALSE)) {
+        if (variable_get('privatemsg_filter_searchbody', FALSE)) {
         $fragments['where'][]       = "pm.subject LIKE '%s' OR pm.body LIKE '%s'";
         $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
         $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
-      }
-      else {
+        }
+        else {
         $fragments['where'][]       = "pm.subject LIKE '%s'";
         $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
-      }
+        }
+    }
     }
-  }
 }
 
 /**
  * Hook into the view messages page to add a form for tagging purposes.
  */
 function privatemsg_filter_privatemsg_view_messages_alter(&$content, $thread) {
-  if (count($thread['messages']) > 0) {
+    if (count($thread['messages']) > 0) {
     $content['tags']['#value'] = drupal_get_form('privatemsg_filter_form');
     $content['tags']['#weight'] = variable_get('privatemsg_filter_tagfield_weight', 10);
-  }
+    }
 }
 
 /**
  * Form to show and allow modification of tagging information of a conversation.
  */
 function privatemsg_filter_form(&$form_state) {
-  global $user;
-  $thread_id = arg(2);
-
-  // Get a list of current tags for this thread
-  $query = _privatemsg_assemble_query(array('tags', 'privatemsg_filter'), $user, array($thread_id));
-  $results = db_query($query['query']);
-  $count = db_result(db_query($query['count']));
-  $tags = '';
-  while ($tag = db_fetch_array($results)) {
+    global $user;
+    $thread_id = arg(2);
+
+    // Get a list of current tags for this thread
+    $query = _privatemsg_assemble_query(array('tags', 'privatemsg_filter'), $user, array($thread_id));
+    $results = db_query($query['query']);
+    $count = db_result(db_query($query['count']));
+    $tags = '';
+    while ($tag = db_fetch_array($results)) {
     $tags .= $tag['tag'] . ', ';
-  }
+    }
 
-  $form['tags'] = array(
+    $form['tags'] = array(
     '#type' => 'fieldset',
     '#title' => t('Tags'),
     '#access' => privatemsg_user_access('tag private messages'),
     '#collapsible' => TRUE,
     '#collapsed' => empty($count) ? TRUE : FALSE,
-  );
-  $form['tags']['user_id'] = array(
+    );
+    $form['tags']['user_id'] = array(
     '#type' => 'value',
     '#value' => $user->uid,
-  );
-  $form['tags']['thread_id'] = array(
+    );
+    $form['tags']['thread_id'] = array(
     '#type' => 'value',
     '#value' => $thread_id,
-  );
+    );
 
-  $form['tags']['tags'] = array(
+    $form['tags']['tags'] = array(
     '#type'               => 'textfield',
     '#title'              => t('Tags for this conversation'),
     '#description'        => t('Separate multiple tags with commas.'),
     '#size'               => 50,
     '#default_value'      => $tags,
     '#autocomplete_path'  => 'messages/filter/tag-autocomplete',
-  );
+    );
 
-  $form['tags']['submit'] = array(
+    $form['tags']['submit'] = array(
     '#type'     => 'submit',
     '#value'    => t('Tag this conversation'),
     '#submit'   => array('privatemsg_filter_form_submit'),
-  );
+    );
 
-  return $form;
+    return $form;
 }
 
 function privatemsg_filter_form_submit($form, &$form_state) {
-  if (isset($form_state['values']['submit'])) {
+    if (isset($form_state['values']['submit'])) {
     $tags = explode(',', $form_state['values']['tags']);
 
     // Step 1 - Delete all tag mapping. I cannot think of a better way to remove tags that are no longer in the textfield, so ideas welcome.
@@ -727,10 +727,10 @@ 
 
     // Step 3 - Save all the tagging data.
     foreach ($tag_ids as $tag_id) {
-      privatemsg_filter_add_tags($form_state['values']['thread_id'], $tag_id);
+        privatemsg_filter_add_tags($form_state['values']['thread_id'], $tag_id);
     }
     drupal_set_message(t('Tagging information has been saved.'));
-  }
+    }
 }
 
 /**
@@ -741,28 +741,28 @@ 
  */
 function privatemsg_filter_tags_autocomplete($string) {
 
-  // 1: Parse $string and build a list of tags.
-  $tags = array();
-  $fragments = explode(',', $string);
-  foreach ($fragments as $index => $tag) {
+    // 1: Parse $string and build a list of tags.
+    $tags = array();
+    $fragments = explode(',', $string);
+    foreach ($fragments as $index => $tag) {
     $tag = trim($tag);
     $tags[$tag] = $tag;
-  }
+    }
 
-  // 2: Find the next tag suggestion.
-  $fragment = array_pop($tags);
-  $matches = array();
-  if (!empty($fragment)) {
+    // 2: Find the next tag suggestion.
+    $fragment = array_pop($tags);
+    $matches = array();
+    if (!empty($fragment)) {
     $query = _privatemsg_assemble_query(array('tags_autocomplete', 'privatemsg_filter'), $fragment, $tags);
     $result = db_query_range($query['query'], $fragment, 0, 10);
     $prefix = count($tags) ? implode(", ", $tags) .", " : '';
     // 3: Build proper suggestions and print.
     while ($tag = db_fetch_object($result)) {
-      $matches[$prefix . $tag->tag .", "] = $tag->tag;
+        $matches[$prefix . $tag->tag .", "] = $tag->tag;
     }
-  }
-  // convert to object to prevent drupal bug, see http://drupal.org/node/175361
-  drupal_json((object)$matches);
+    }
+    // convert to object to prevent drupal bug, see http://drupal.org/node/175361
+    drupal_json((object)$matches);
 }
 
 /**
@@ -781,19 +781,19 @@ 
  *   Array of names that are already part of the autocomplete field.
  */
 function privatemsg_filter_privatemsg_sql_autocomplete_alter(&$fragments, $search, $names) {
-  global $user;
-  // arg(1) is an additional URL argument passed to the URL when only
-  // users that are listed as recipient for threads of that user should be
-  // displayed.
-  // @todo: Check if these results can be grouped to avoid unecessary loops.
-  if (arg(1) == 'filter') {
+    global $user;
+    // arg(1) is an additional URL argument passed to the URL when only
+    // users that are listed as recipient for threads of that user should be
+    // displayed.
+    // @todo: Check if these results can be grouped to avoid unecessary loops.
+    if (arg(1) == 'filter') {
     // JOIN on index entries where the to be selected user is a recipient.
     $fragments['inner_join'][] = 'INNER JOIN {pm_index} pip ON pip.uid = u.uid';
     // JOIN on rows where the current user is the recipient and that have the
     // same mid as those above.
     $fragments['inner_join'][] = 'INNER JOIN {pm_index} piu ON piu.uid = %d AND pip.mid = piu.mid';
     $fragments['query_args']['join'][] = $user->uid;
-  }
+    }
 }
 
 /**
@@ -809,19 +809,19 @@ 
  *   Limit the number of tags *per thread*.
  */
 function privatemsg_filter_sql_tags(&$fragments, $user = NULL, $threads = NULL, $limit = NULL) {
-  $fragments['primary_table'] = '{pm_tags} t';
-  $fragments['select'][] = 't.tag';
-  $fragments['select'][] = 't.tag_id';
-  $fragments['select'][] = 't.public';
+    $fragments['primary_table'] = '{pm_tags} t';
+    $fragments['select'][] = 't.tag';
+    $fragments['select'][] = 't.tag_id';
+    $fragments['select'][] = 't.public';
 
-  if (!empty($threads)) {
+    if (!empty($threads)) {
     // If the tag list needs to be for specific threads.
     $fragments['select'][] = 'ti.thread_id';
     $fragments['inner_join'][]  = 'INNER JOIN {pm_tags_index} ti on ti.tag_id = t.tag_id';
     $fragments['where'][] = 'ti.thread_id IN (' . db_placeholders($threads) . ')';
     $fragments['query_args']['where'] += $threads;
-  }
-  else {
+    }
+    else {
     // Tag usage counter is only used when we select all tags.
     $fragments['select'][]      = 'COUNT(ti.thread_id) as count';
     // LEFT JOIN so that unused tags are displayed too.
@@ -829,33 +829,33 @@ 
     $fragments['group_by'][]    = 't.tag_id';
     $fragments['group_by'][]    = 't.tag';
     $fragments['group_by'][]    = 't.public';
-  }
-  if (!empty($user)) {
+    }
+    if (!empty($user)) {
     $fragments['where'][]       = 'ti.uid = %d';
     $fragments['query_args']['where'][] = $user->uid;
-  }
-
-  // Only select n tags per thread (ordered per tag_id), see
-  // http://www.xaprb.com/blog/2006/12/07/how-to-select-the-firstleastmax-row-per-group-in-sql/.
-  //
-  // It does select how many tags for that thread/uid combination exist that
-  // have a lower tag_id and does only select those that have less than $limit.
-  //
-  // This should only have a very minor performance impact as most users won't
-  // tag a thread with 1000 different tags.
-  //
-  if ($limit) {
+    }
+
+    // Only select n tags per thread (ordered per tag_id), see
+    // http://www.xaprb.com/blog/2006/12/07/how-to-select-the-firstleastmax-row-per-group-in-sql/.
+    //
+    // It does select how many tags for that thread/uid combination exist that
+    // have a lower tag_id and does only select those that have less than $limit.
+    //
+    // This should only have a very minor performance impact as most users won't
+    // tag a thread with 1000 different tags.
+    //
+    if ($limit) {
     $fragments['where'][] = '(SELECT count(*) FROM {pm_tags_index} AS pmtic
                               WHERE pmtic.thread_id = ti.thread_id
                               AND pmtic.uid = ti.uid
                               AND pmtic.tag_id < ti.tag_id) < %d';
     $fragments['query_args']['where'][] = $limit;
-  }
-  elseif (!empty($threads) || !empty($user)) {
+    }
+    elseif (!empty($threads) || !empty($user)) {
     // Only add a sort when we are not loading the tags for the admin page.
     // Sorting is handled through tablesort_sql() then.
     $fragments['order_by'][] = 't.tag ASC';
-  }
+    }
 }
 
 /**
@@ -869,25 +869,25 @@ 
  *   Array of tags not to be used as suggestions.
  */
 function privatemsg_filter_sql_tags_autocomplete(&$fragments, $search, $tags) {
-  global $user;
-
-  $fragments['primary_table'] = '{pm_tags} pmt';
-  $fragments['select'][] = 'pmt.tag';
-  $fragments['where'][] = "pmt.tag LIKE '%s'";
-  // Escape % to get through the placeholder replacement.
-  $fragments['query_args']['where'][] = $search .'%%';
-  if (!empty($tags)) {
+    global $user;
+
+    $fragments['primary_table'] = '{pm_tags} pmt';
+    $fragments['select'][] = 'pmt.tag';
+    $fragments['where'][] = "pmt.tag LIKE '%s'";
+    // Escape % to get through the placeholder replacement.
+    $fragments['query_args']['where'][] = $search .'%%';
+    if (!empty($tags)) {
     // Exclude tags.
     $fragments['where'][] = "pmt.tag NOT IN (". db_placeholders($tags, 'text') .")";
     $fragments['query_args']['where'] += $tags;
-  }
-  // LEFT JOIN to be able to load public, unused tags.
-  $fragments['inner_join'][]  = 'LEFT JOIN {pm_tags_index} pmti ON pmt.tag_id = pmti.tag_id AND pmti.uid = %d';
-  $fragments['query_args']['join'][] = $user->uid;
-  // Autocomplete should only display Tags used by that user or public tags.
-  // This is done to avoid information disclosure as part of tag names.
-  $fragments['where'][] = '(pmti.uid IS NOT NULL OR pmt.public = 1)';
-  $fragments['order_by'][] = 'pmt.tag ASC';
+    }
+    // LEFT JOIN to be able to load public, unused tags.
+    $fragments['inner_join'][]  = 'LEFT JOIN {pm_tags_index} pmti ON pmt.tag_id = pmti.tag_id AND pmti.uid = %d';
+    $fragments['query_args']['join'][] = $user->uid;
+    // Autocomplete should only display Tags used by that user or public tags.
+    // This is done to avoid information disclosure as part of tag names.
+    $fragments['where'][] = '(pmti.uid IS NOT NULL OR pmt.public = 1)';
+    $fragments['order_by'][] = 'pmt.tag ASC';
 }
 
 /**
@@ -898,10 +898,10 @@ 
  * Implement hook_user().
  */
 function privatemsg_filter_user($op, &$edit, &$account, $category = NULL) {
-  switch ($op) {
-      case 'delete':
+    switch ($op) {
+        case 'delete':
       // Delete tag information of that user.
       db_query("DELETE FROM {pm_tags_index} WHERE uid = %d", $account->uid, $account->uid);
-      break;
-  }
+        break;
+    }
 }

Switch Indentation +24 added lines, -24 removed lines

@@ -405,26 +405,26 @@ 
   }
 
   switch ($form_state['values']['op']) {
-    case t('Save filter'):
-      $filter = array();
-      if (!empty($form_state['values']['tags'])) {
-        $filter['tags'] = $form_state['values']['tags'];
-      }
-      if (!empty($form_state['values']['author'])) {
-        $filter['author'] = $form_state['values']['author'];
-      }
-      if (!empty($form_state['values']['search'])) {
-        $filter['search'] = $form_state['values']['search'];
-      }
-      $_SESSION['privatemsg_filter'] = $filter;
-      break;
-    case t('Filter'):
-      drupal_goto($_GET['q'], privatemsg_filter_create_get_query($form_state['values']));
-      return;
-      break;
-    case t('Reset'):
-      $_SESSION['privatemsg_filter'] = array();
-      break;
+  case t('Save filter'):
+    $filter = array();
+    if (!empty($form_state['values']['tags'])) {
+      $filter['tags'] = $form_state['values']['tags'];
+    }
+    if (!empty($form_state['values']['author'])) {
+      $filter['author'] = $form_state['values']['author'];
+    }
+    if (!empty($form_state['values']['search'])) {
+      $filter['search'] = $form_state['values']['search'];
+    }
+    $_SESSION['privatemsg_filter'] = $filter;
+    break;
+  case t('Filter'):
+    drupal_goto($_GET['q'], privatemsg_filter_create_get_query($form_state['values']));
+    return;
+    break;
+  case t('Reset'):
+    $_SESSION['privatemsg_filter'] = array();
+    break;
   }
   $form_state['redirect'] = $_GET['q'];
 }
@@ -899,9 +899,9 @@ 
  */
 function privatemsg_filter_user($op, &$edit, &$account, $category = NULL) {
   switch ($op) {
-      case 'delete':
-      // Delete tag information of that user.
-      db_query("DELETE FROM {pm_tags_index} WHERE uid = %d", $account->uid, $account->uid);
-      break;
+  case 'delete':
+  // Delete tag information of that user.
+  db_query("DELETE FROM {pm_tags_index} WHERE uid = %d", $account->uid, $account->uid);
+  break;
   }
 }

Spacing +23 added lines, -23 removed lines

@@ -313,7 +313,7 @@ 
 
 function privatemsg_filter_dropdown(&$form_state, $account) {
 
-  drupal_add_css(drupal_get_path('module', 'privatemsg_filter') .'/privatemsg_filter.css');
+  drupal_add_css(drupal_get_path('module', 'privatemsg_filter').'/privatemsg_filter.css');
 
   $form['filter'] = array(
     '#type' => 'fieldset',
@@ -377,7 +377,7 @@ 
   if (isset($filter['author'])) {
     $string = '';
     foreach ($filter['author'] as $author) {
-      $string .= $author->name . ', ';
+      $string .= $author->name.', ';
     }
     $form['filter']['author']['#default_value'] = $string;
   }
@@ -441,7 +441,7 @@ 
         $query['tags'][] = $tag;
       }
     }
-    $sql = 'SELECT pmt.tag FROM {pm_tags} pmt WHERE pmt.tag_id IN ('. implode(', ', $filter['tags']) .')';
+    $sql = 'SELECT pmt.tag FROM {pm_tags} pmt WHERE pmt.tag_id IN ('.implode(', ', $filter['tags']).')';
     $result = db_query($sql);
     while ($row = db_fetch_object($result)) {
       $query['tags'][] = $row->tag;
@@ -535,7 +535,7 @@ 
     );
 
     // JS for hiding the submit buttons.
-    drupal_add_js(drupal_get_path('module', 'privatemsg_filter') .'/privatemsg-filter-list.js');
+    drupal_add_js(drupal_get_path('module', 'privatemsg_filter').'/privatemsg-filter-list.js');
   }
 }
 
@@ -564,7 +564,7 @@ 
     $tags = array();
 
     foreach ($thread['tags'] as $tag_id => $tag) {
-      $tags[] = l(strlen($tag) > 15 ? substr($tag, 0, 13) . '...' : $tag, 'messages', array(
+      $tags[] = l(strlen($tag) > 15 ? substr($tag, 0, 13).'...' : $tag, 'messages', array(
         'attributes' => array('title' => $tag),
         'query' => array('tags' => $tag)
       ));
@@ -611,11 +611,11 @@ 
 
   // Check if its a filtered view.
   if ($argument == 'sent') {
-    $fragments['where'][]       = "pm.author = %d";
-    $fragments['query_args']['where'][]   = $account->uid;
+    $fragments['where'][] = "pm.author = %d";
+    $fragments['query_args']['where'][] = $account->uid;
   }
   if ($argument == 'inbox') {
-    $fragments['having'][]       = '((SELECT pmf.author FROM {pm_message} pmf WHERE pmf.mid = pmi.thread_id) = %d AND COUNT(pmi.thread_id) > 1) OR (SELECT COUNT(*) FROM {pm_message} pmf INNER JOIN {pm_index} pmif ON (pmf.mid = pmif.mid) WHERE pmif.thread_id = pmi.thread_id AND pmf.author <> %d) > 0';
+    $fragments['having'][] = '((SELECT pmf.author FROM {pm_message} pmf WHERE pmf.mid = pmi.thread_id) = %d AND COUNT(pmi.thread_id) > 1) OR (SELECT COUNT(*) FROM {pm_message} pmf INNER JOIN {pm_index} pmif ON (pmf.mid = pmif.mid) WHERE pmif.thread_id = pmi.thread_id AND pmf.author <> %d) > 0';
     $fragments['query_args']['having'][]   = $account->uid;
     $fragments['query_args']['having'][]   = $account->uid;
   }
@@ -627,7 +627,7 @@ 
       foreach ($filter['tags'] as $tag) {
         $fragments['inner_join'][]  = "INNER JOIN {pm_tags_index} pmti$count ON (pmti$count.thread_id = pmi.thread_id AND pmti$count.uid = pmi.uid)";
         $fragments['where'][]       = "pmti$count.tag_id = %d";
-        $fragments['query_args']['where'][]   = $tag;
+        $fragments['query_args']['where'][] = $tag;
         $count++;
       }
     }
@@ -636,20 +636,20 @@ 
       foreach ($filter['author'] as $author) {
         $fragments['inner_join'][]  = "INNER JOIN {pm_index} pmi$count ON (pmi$count.mid = pm.mid)";
         $fragments['where'][]       = "pmi$count.uid = %d";
-        $fragments['query_args']['where'][]   = $author->uid;
+        $fragments['query_args']['where'][] = $author->uid;
         $count++;
       }
     }
 
     if (isset($filter['search']) && !empty($filter['search'])) {
       if (variable_get('privatemsg_filter_searchbody', FALSE)) {
-        $fragments['where'][]       = "pm.subject LIKE '%s' OR pm.body LIKE '%s'";
-        $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
-        $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
+        $fragments['where'][] = "pm.subject LIKE '%s' OR pm.body LIKE '%s'";
+        $fragments['query_args']['where'][]    = '%%'.$filter['search'].'%%';
+        $fragments['query_args']['where'][]    = '%%'.$filter['search'].'%%';
       }
       else {
-        $fragments['where'][]       = "pm.subject LIKE '%s'";
-        $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
+        $fragments['where'][] = "pm.subject LIKE '%s'";
+        $fragments['query_args']['where'][] = '%%'.$filter['search'].'%%';
       }
     }
   }
@@ -678,7 +678,7 @@ 
   $count = db_result(db_query($query['count']));
   $tags = '';
   while ($tag = db_fetch_array($results)) {
-    $tags .= $tag['tag'] . ', ';
+    $tags .= $tag['tag'].', ';
   }
 
   $form['tags'] = array(
@@ -755,10 +755,10 @@ 
   if (!empty($fragment)) {
     $query = _privatemsg_assemble_query(array('tags_autocomplete', 'privatemsg_filter'), $fragment, $tags);
     $result = db_query_range($query['query'], $fragment, 0, 10);
-    $prefix = count($tags) ? implode(", ", $tags) .", " : '';
+    $prefix = count($tags) ? implode(", ", $tags).", " : '';
     // 3: Build proper suggestions and print.
     while ($tag = db_fetch_object($result)) {
-      $matches[$prefix . $tag->tag .", "] = $tag->tag;
+      $matches[$prefix.$tag->tag.", "] = $tag->tag;
     }
   }
   // convert to object to prevent drupal bug, see http://drupal.org/node/175361
@@ -817,8 +817,8 @@ 
   if (!empty($threads)) {
     // If the tag list needs to be for specific threads.
     $fragments['select'][] = 'ti.thread_id';
-    $fragments['inner_join'][]  = 'INNER JOIN {pm_tags_index} ti on ti.tag_id = t.tag_id';
-    $fragments['where'][] = 'ti.thread_id IN (' . db_placeholders($threads) . ')';
+    $fragments['inner_join'][] = 'INNER JOIN {pm_tags_index} ti on ti.tag_id = t.tag_id';
+    $fragments['where'][] = 'ti.thread_id IN ('.db_placeholders($threads).')';
     $fragments['query_args']['where'] += $threads;
   }
   else {
@@ -875,14 +875,14 @@ 
   $fragments['select'][] = 'pmt.tag';
   $fragments['where'][] = "pmt.tag LIKE '%s'";
   // Escape % to get through the placeholder replacement.
-  $fragments['query_args']['where'][] = $search .'%%';
+  $fragments['query_args']['where'][] = $search.'%%';
   if (!empty($tags)) {
     // Exclude tags.
-    $fragments['where'][] = "pmt.tag NOT IN (". db_placeholders($tags, 'text') .")";
+    $fragments['where'][] = "pmt.tag NOT IN (".db_placeholders($tags, 'text').")";
     $fragments['query_args']['where'] += $tags;
   }
   // LEFT JOIN to be able to load public, unused tags.
-  $fragments['inner_join'][]  = 'LEFT JOIN {pm_tags_index} pmti ON pmt.tag_id = pmti.tag_id AND pmti.uid = %d';
+  $fragments['inner_join'][] = 'LEFT JOIN {pm_tags_index} pmti ON pmt.tag_id = pmti.tag_id AND pmti.uid = %d';
   $fragments['query_args']['join'][] = $user->uid;
   // Autocomplete should only display Tags used by that user or public tags.
   // This is done to avoid information disclosure as part of tag names.

Braces +8 added lines, -16 removed lines

@@ -192,8 +192,7 @@ 
     if (empty($tag_id) && privatemsg_user_access('create private message tags')) {
       db_query("INSERT INTO {pm_tags} (tag) VALUES ('%s')", $tag);
       $tag_id = db_last_insert_id('pm_tags', 'tag_id');
-    }
-    elseif (empty($tag_id)) {
+    } elseif (empty($tag_id)) {
       // The user does not have permission to create new tags - disregard this tag and move onto the next.
       drupal_set_message(t('Tag %tag was ignored because you do not have permission to create new tags.', array('%tag' => $tag)));
       continue;
@@ -251,8 +250,7 @@ 
     foreach ($threads as $thread) {
       db_query('DELETE FROM {pm_tags_index} WHERE uid = %d AND thread_id = %d', $account->uid, $thread);
     }
-  }
-  else {
+  } else {
     // Delete tag mapping for the specified tag.
     foreach ($threads as $thread) {
       db_query('DELETE FROM {pm_tags_index} WHERE uid = %d AND thread_id = %d AND tag_id = %d', $account->uid, $thread, $tag_id);
@@ -268,8 +266,7 @@ 
     foreach (explode(',', $_GET['tags']) as $tag) {
       if (isset($tag_data[$tag])) {
         $filter['tags'][$tag] = $tag;
-      }
-      elseif (in_array($tag, $tag_data)) {
+      } elseif (in_array($tag, $tag_data)) {
         $filter['tags'][array_search($tag, $tag_data)] = array_search($tag, $tag_data);
       }
     }
@@ -436,8 +433,7 @@ 
     foreach ($filter['tags'] as $tag) {
       if ((int)$tag > 0) {
         $ids[] = $tag;
-      }
-      else {
+      } else {
         $query['tags'][] = $tag;
       }
     }
@@ -456,8 +452,7 @@ 
     foreach ($filter['author'] as $author) {
       if (is_object($author) && isset($author->uid) && isset($author->name)) {
         $query['author'][] = $author->name;
-      }
-      elseif ($author_obj = user_load($author)) {
+      } elseif ($author_obj = user_load($author)) {
         $query['author'][] = $author_obj->name;
       }
     }
@@ -646,8 +641,7 @@ 
         $fragments['where'][]       = "pm.subject LIKE '%s' OR pm.body LIKE '%s'";
         $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
         $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
-      }
-      else {
+      } else {
         $fragments['where'][]       = "pm.subject LIKE '%s'";
         $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
       }
@@ -820,8 +814,7 @@ 
     $fragments['inner_join'][]  = 'INNER JOIN {pm_tags_index} ti on ti.tag_id = t.tag_id';
     $fragments['where'][] = 'ti.thread_id IN (' . db_placeholders($threads) . ')';
     $fragments['query_args']['where'] += $threads;
-  }
-  else {
+  } else {
     // Tag usage counter is only used when we select all tags.
     $fragments['select'][]      = 'COUNT(ti.thread_id) as count';
     // LEFT JOIN so that unused tags are displayed too.
@@ -850,8 +843,7 @@ 
                               AND pmtic.uid = ti.uid
                               AND pmtic.tag_id < ti.tag_id) < %d';
     $fragments['query_args']['where'][] = $limit;
-  }
-  elseif (!empty($threads) || !empty($user)) {
+  } elseif (!empty($threads) || !empty($user)) {
     // Only add a sort when we are not loading the tags for the admin page.
     // Sorting is handled through tablesort_sql() then.
     $fragments['order_by'][] = 't.tag ASC';

Upper-Lower-Casing +13 added lines, -13 removed lines

@@ -125,7 +125,7 @@ 
     '#type'          => 'checkbox',
     '#title'         => t('Search message body'),
     '#description'   => t('WARNING: turning on this feature will slow down search performance by a large factor. Gets worse as your messages database increases.'),
-    '#default_value' => variable_get('privatemsg_filter_searchbody', FALSE),
+    '#default_value' => variable_get('privatemsg_filter_searchbody', false),
   );
 
     $form['privatemsg_filter_tagfield_weight'] = array(
@@ -211,7 +211,7 @@ 
  * @param $tag_id
  *   Id of the tag.
  */
-function privatemsg_filter_add_tags($threads, $tag_id, $account = NULL) {
+function privatemsg_filter_add_tags($threads, $tag_id, $account = null) {
   if (!is_array($threads)) {
     $threads = array($threads);
   }
@@ -237,7 +237,7 @@ 
  * @param $tag_id
  *   Id of the tag - set to NULL to remove all tags.
  */
-function privatemsg_filter_remove_tags($threads, $tag_id = NULL, $account = NULL) {
+function privatemsg_filter_remove_tags($threads, $tag_id = null, $account = null) {
   if (!is_array($threads)) {
     $threads = array($threads);
   }
@@ -318,12 +318,12 @@ 
   $form['filter'] = array(
     '#type' => 'fieldset',
     '#title' => t('Filter messages'),
-    '#collapsible' => TRUE,
-    '#collapsed' => TRUE,
+    '#collapsible' => true,
+    '#collapsed' => true,
   );
   $form['filter']['search'] = array(
     '#type' => 'textfield',
-    '#title' => variable_get('privatemsg_filter_searchbody', FALSE) ? t('Search messages') : t('Search subjects'),
+    '#title' => variable_get('privatemsg_filter_searchbody', false) ? t('Search messages') : t('Search subjects'),
     '#weight' => -20
   );
 
@@ -342,7 +342,7 @@ 
       '#type' => 'select',
       '#title' => t('Tags'),
       '#options' => $tag_data,
-      '#multiple' => TRUE,
+      '#multiple' => true,
       '#size' => 5,
       '#weight' => 0
     );
@@ -372,7 +372,7 @@ 
 
 function privatemsg_filter_dropdown_set_active(&$form, $filter) {
   $form['filter']['#title'] = t('Filter messages (active)');
-  $form['filter']['#collapsed'] = FALSE;
+  $form['filter']['#collapsed'] = false;
 
   if (isset($filter['author'])) {
     $string = '';
@@ -642,7 +642,7 @@ 
     }
 
     if (isset($filter['search']) && !empty($filter['search'])) {
-      if (variable_get('privatemsg_filter_searchbody', FALSE)) {
+      if (variable_get('privatemsg_filter_searchbody', false)) {
         $fragments['where'][]       = "pm.subject LIKE '%s' OR pm.body LIKE '%s'";
         $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
         $fragments['query_args']['where'][]    = '%%'. $filter['search'] .'%%';
@@ -685,8 +685,8 @@ 
     '#type' => 'fieldset',
     '#title' => t('Tags'),
     '#access' => privatemsg_user_access('tag private messages'),
-    '#collapsible' => TRUE,
-    '#collapsed' => empty($count) ? TRUE : FALSE,
+    '#collapsible' => true,
+    '#collapsed' => empty($count) ? true : false,
   );
   $form['tags']['user_id'] = array(
     '#type' => 'value',
@@ -808,7 +808,7 @@ 
  * @param $limit
  *   Limit the number of tags *per thread*.
  */
-function privatemsg_filter_sql_tags(&$fragments, $user = NULL, $threads = NULL, $limit = NULL) {
+function privatemsg_filter_sql_tags(&$fragments, $user = null, $threads = null, $limit = null) {
   $fragments['primary_table'] = '{pm_tags} t';
   $fragments['select'][] = 't.tag';
   $fragments['select'][] = 't.tag_id';
@@ -897,7 +897,7 @@ 
 /**
  * Implement hook_user().
  */
-function privatemsg_filter_user($op, &$edit, &$account, $category = NULL) {
+function privatemsg_filter_user($op, &$edit, &$account, $category = null) {
   switch ($op) {
       case 'delete':
       // Delete tag information of that user.

drupal/sites/default/boinc/modules/contrib/privatemsg/privatemsg.theme.inc

Indentation +75 added lines, -75 removed lines

@@ -75,11 +75,11 @@ 
  * @see theme_privatemsg_list_field()
  */
 function phptemplate_privatemsg_list_field__participants($thread) {
-  $participants = _privatemsg_generate_user_array($thread['participants'], -4);
-  $field = array();
-  $field['data'] = _privatemsg_format_participants($participants, 3, TRUE);
-  $field['class'] = 'privatemsg-list-participants';
-  return $field;
+    $participants = _privatemsg_generate_user_array($thread['participants'], -4);
+    $field = array();
+    $field['data'] = _privatemsg_format_participants($participants, 3, TRUE);
+    $field['class'] = 'privatemsg-list-participants';
+    return $field;
 }
 
 /**
@@ -88,16 +88,16 @@ 
  * @see theme_privatemsg_list_field()
  */
 function phptemplate_privatemsg_list_field__subject($thread) {
-  $field = array();
-  $options = array();
-  $is_new = '';
-  if (!empty($thread['is_new'])) {
+    $field = array();
+    $options = array();
+    $is_new = '';
+    if (!empty($thread['is_new'])) {
     $is_new = theme_mark(MARK_NEW);
     $options['fragment'] = 'new';
-  }
-  $field['data'] = l($thread['subject'], 'messages/view/' . $thread['thread_id'], $options) . $is_new;
-  $field['class'] = 'privatemsg-list-subject';
-  return $field;
+    }
+    $field['data'] = l($thread['subject'], 'messages/view/' . $thread['thread_id'], $options) . $is_new;
+    $field['class'] = 'privatemsg-list-subject';
+    return $field;
 }
 
 /**
@@ -106,15 +106,15 @@ 
  * @see theme_privatemsg_list_field()
  */
 function phptemplate_privatemsg_list_field__count($thread) {
-  $field = array();
-  $field['data'] = $thread['count'];
-  $options = array();
-  if (!empty($thread['is_new']) && $thread['is_new'] < $thread['count']) {
+    $field = array();
+    $field['data'] = $thread['count'];
+    $options = array();
+    if (!empty($thread['is_new']) && $thread['is_new'] < $thread['count']) {
     $options['fragment'] = 'new';
     $field['data'] .= '<br />' . l((format_plural($thread['is_new'], '(1 new)', '(@count new)')), 'messages/view/' . $thread['thread_id'], $options);
-  }
-  $field['class'] = 'privatemsg-list-count';
-  return $field;
+    }
+    $field['class'] = 'privatemsg-list-count';
+    return $field;
 }
 
 /**
@@ -123,10 +123,10 @@ 
  * @see theme_privatemsg_list_field()
  */
 function phptemplate_privatemsg_list_field__last_updated($thread) {
-  $field = array();
-  $field['data'] = format_date($thread['last_updated'], 'small');
-  $field['class'] = 'privatemsg-list-date';
-  return $field;
+    $field = array();
+    $field['data'] = format_date($thread['last_updated'], 'small');
+    $field['class'] = 'privatemsg-list-date';
+    return $field;
 }
 
 /**
@@ -135,10 +135,10 @@ 
  * @see theme_privatemsg_list_field()
  */
 function phptemplate_privatemsg_list_field__thread_started($thread) {
-  $field = array();
-  $field['data'] = format_date($thread['thread_started'], 'small');
-  $field['class'] = 'privatemsg-list-date-started';
-  return $field;
+    $field = array();
+    $field['data'] = format_date($thread['thread_started'], 'small');
+    $field['class'] = 'privatemsg-list-date-started';
+    return $field;
 }
 
 /**
@@ -162,13 +162,13 @@ 
  * @see theme_privatemsg_list_header()
  */
 function phptemplate_privatemsg_list_header__subject() {
-  return array(
+    return array(
     'data'    => t('Subject'),
     'field'   => 'subject',
     'key'     => 'subject',
     'class'   => 'privatemsg-header-subject',
     '#weight' => -40,
-  );
+    );
 }
 
 /**
@@ -177,12 +177,12 @@ 
  * @see theme_privatemsg_list_header()
  */
 function phptemplate_privatemsg_list_header__count() {
-  return array(
+    return array(
     'data'    => t('Messages'),
     'key'     => 'count',
     'class'   => 'privatemsg-header-count',
     '#weight' => -25,
-  );
+    );
 }
 
 /**
@@ -191,12 +191,12 @@ 
  * @see theme_privatemsg_list_header()
  */
 function phptemplate_privatemsg_list_header__participants() {
-  return array(
+    return array(
     'data'    => t('Participants'),
     'key'     => 'participants',
     'class'   => 'privatemsg-header-participants',
     '#weight' => -30,
-  );
+    );
 }
 
 /**
@@ -205,14 +205,14 @@ 
  * @see theme_privatemsg_list_header()
  */
 function phptemplate_privatemsg_list_header__last_updated() {
-  return array(
+    return array(
     'data'    => t('Last Updated'),
     'field'   => 'last_updated',
     'key'     => 'last_updated',
     'sort'    => 'desc',
     'class'   => 'privatemsg-header-lastupdated',
     '#weight' => -20,
-  );
+    );
 }
 
 /**
@@ -221,13 +221,13 @@ 
  * @see theme_privatemsg_list_header()
  */
 function phptemplate_privatemsg_list_header__thread_started() {
-  return array(
+    return array(
     'data'    => t('Started'),
     'field'   => 'thread_started',
     'key'     => 'thread_started',
     'class'   => 'privatemsg-header-threadstarted',
     '#weight' => -15,
-  );
+    );
 }
 
 /**
@@ -237,70 +237,70 @@ 
  * by the header and field theme patterns.
  */
 function theme_privatemsg_list($form) {
-  $has_posts = !empty($form['#data']);
+    $has_posts = !empty($form['#data']);
 
-  drupal_add_css(drupal_get_path('module', 'privatemsg') .'/styles/privatemsg-list.css');
+    drupal_add_css(drupal_get_path('module', 'privatemsg') .'/styles/privatemsg-list.css');
 
-  // Load the table columns.
-  $columns = array_merge(array('subject', 'last_updated'), array_filter(variable_get('privatemsg_display_fields', array('participants'))));
+    // Load the table columns.
+    $columns = array_merge(array('subject', 'last_updated'), array_filter(variable_get('privatemsg_display_fields', array('participants'))));
 
-  // Load the themed list headers based on the available data.
-  $headers = _privatemsg_list_headers(!empty($form['#data']), $columns);
-  // sort the headers array based on the #weight property.
-  usort($headers, 'element_sort');
+    // Load the themed list headers based on the available data.
+    $headers = _privatemsg_list_headers(!empty($form['#data']), $columns);
+    // sort the headers array based on the #weight property.
+    usort($headers, 'element_sort');
 
-  $themed_rows = array();
-  // Check if there is atleast a single thread.
-  if ($has_posts) {
+    $themed_rows = array();
+    // Check if there is atleast a single thread.
+    if ($has_posts) {
     foreach ($form['#data'] as $thread_id => $data) {
-      // Theme the row.
-      $row = _privatemsg_list_thread($data);
-      $data = array();
-      // Render the checkbox.
-      $data[] = array('data' => drupal_render($form['threads'][$thread_id]), 'class' => 'privatemsg-list-select');
+        // Theme the row.
+        $row = _privatemsg_list_thread($data);
+        $data = array();
+        // Render the checkbox.
+        $data[] = array('data' => drupal_render($form['threads'][$thread_id]), 'class' => 'privatemsg-list-select');
 
-      // Store the #rows data in the same order as the header is, the key property of the header refers to the field that belongs to it.
-      foreach ($headers as $header) {
+        // Store the #rows data in the same order as the header is, the key property of the header refers to the field that belongs to it.
+        foreach ($headers as $header) {
         if (!empty($header['key'])) {
-          if (isset($row['data'][$header['key']])) {
+            if (isset($row['data'][$header['key']])) {
             $data[] = $row['data'][$header['key']];
-          }
-          else {
+            }
+            else {
             // Store a empty value so that the order is still correct.
             $data[] = '';
-          }
+            }
+        }
         }
-      }
-      // Replace the data
-      $row['data'] = $data;
-      $themed_rows[] = $row;
+        // Replace the data
+        $row['data'] = $data;
+        $themed_rows[] = $row;
     }
-  }
-  else {
+    }
+    else {
     // Display a message if now messages are available.
     $themed_rows[] = array(array('data' => t('No messages available.'), 'colspan' => count($headers)));
-  }
+    }
 
-  // Remove any data in header that we don't need anymore.
-  foreach ($headers as $id => $header) {
+    // Remove any data in header that we don't need anymore.
+    foreach ($headers as $id => $header) {
     unset($headers[$id]['key']);
     unset($headers[$id]['#weight']);
-  }
+    }
 
-  // Theme the table, pass all generated information to the table theme function.
-  $form['list'] = array('#value' => theme('table', $headers, $themed_rows, array('class' => 'privatemsg-list')), '#weight' => 5);
-  return drupal_render($form);
+    // Theme the table, pass all generated information to the table theme function.
+    $form['list'] = array('#value' => theme('table', $headers, $themed_rows, array('class' => 'privatemsg-list')), '#weight' => 5);
+    return drupal_render($form);
 }
 
 /**
  * Theme a block which displays the number of new messages a user has.
  */
 function theme_privatemsg_new_block($count) {
-  $text = format_plural($count, 'You have a new message, click here to read it',
+    $text = format_plural($count, 'You have a new message, click here to read it',
                         'You have @count new messages, click here to read them',
                         array('@count' => $count));
 
-  return l($text, 'messages', array('attributes' => array('id' => 'privatemsg-new-link')));
+    return l($text, 'messages', array('attributes' => array('id' => 'privatemsg-new-link')));
 }
 
 /**

Spacing +3 added lines, -3 removed lines

@@ -95,7 +95,7 @@ 
     $is_new = theme_mark(MARK_NEW);
     $options['fragment'] = 'new';
   }
-  $field['data'] = l($thread['subject'], 'messages/view/' . $thread['thread_id'], $options) . $is_new;
+  $field['data'] = l($thread['subject'], 'messages/view/'.$thread['thread_id'], $options).$is_new;
   $field['class'] = 'privatemsg-list-subject';
   return $field;
 }
@@ -111,7 +111,7 @@ 
   $options = array();
   if (!empty($thread['is_new']) && $thread['is_new'] < $thread['count']) {
     $options['fragment'] = 'new';
-    $field['data'] .= '<br />' . l((format_plural($thread['is_new'], '(1 new)', '(@count new)')), 'messages/view/' . $thread['thread_id'], $options);
+    $field['data'] .= '<br />'.l((format_plural($thread['is_new'], '(1 new)', '(@count new)')), 'messages/view/'.$thread['thread_id'], $options);
   }
   $field['class'] = 'privatemsg-list-count';
   return $field;
@@ -239,7 +239,7 @@ 
 function theme_privatemsg_list($form) {
   $has_posts = !empty($form['#data']);
 
-  drupal_add_css(drupal_get_path('module', 'privatemsg') .'/styles/privatemsg-list.css');
+  drupal_add_css(drupal_get_path('module', 'privatemsg').'/styles/privatemsg-list.css');
 
   // Load the table columns.
   $columns = array_merge(array('subject', 'last_updated'), array_filter(variable_get('privatemsg_display_fields', array('participants'))));

Braces +2 added lines, -4 removed lines

@@ -264,8 +264,7 @@ 
         if (!empty($header['key'])) {
           if (isset($row['data'][$header['key']])) {
             $data[] = $row['data'][$header['key']];
-          }
-          else {
+          } else {
             // Store a empty value so that the order is still correct.
             $data[] = '';
           }
@@ -275,8 +274,7 @@ 
       $row['data'] = $data;
       $themed_rows[] = $row;
     }
-  }
-  else {
+  } else {
     // Display a message if now messages are available.
     $themed_rows[] = array(array('data' => t('No messages available.'), 'colspan' => count($headers)));
   }

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
 function phptemplate_privatemsg_list_field__participants($thread) {
   $participants = _privatemsg_generate_user_array($thread['participants'], -4);
   $field = array();
-  $field['data'] = _privatemsg_format_participants($participants, 3, TRUE);
+  $field['data'] = _privatemsg_format_participants($participants, 3, true);
   $field['class'] = 'privatemsg-list-participants';
   return $field;
 }

drupal/sites/default/boinc/modules/node_comment_block/node_comment_block.module

Indentation +35 added lines, -35 removed lines

@@ -9,45 +9,45 @@ 
  * Implements hook_block() for Drupal 6 compatibility
  */
 function node_comment_block_block($op = 'list', $delta = 0, $edit = array()) {
-  switch ($op) {
-  case 'view':
+    switch ($op) {
+    case 'view':
     //$block = node_comment_block_block_view($delta);
     $block = array();
     if ($delta == 'node_comments') {
-      if (arg(0) == 'node' && is_numeric($nid = arg(1)) && !arg(2)) {
+        if (arg(0) == 'node' && is_numeric($nid = arg(1)) && !arg(2)) {
         $node = node_load($nid);
         if ($node->comment !== 0) {
-          $block['subject'] = NULL; // This should be NULL otherwise there will be duplicate h2 elements.
-          $block['content'] = '';
-          if ($node->comment) {
+            $block['subject'] = NULL; // This should be NULL otherwise there will be duplicate h2 elements.
+            $block['content'] = '';
+            if ($node->comment) {
             $block['content'] .= comment_render($node);
-          }
+            }
+        }
         }
-      }
     }
     break;
-  case 'list':
+    case 'list':
     $blocks = node_comment_block_block_info();
     return $blocks;
     break;
-  default:
+    default:
   }
-  return $block;
+    return $block;
 }
 
 /**
  * Port Drupal 7 render() function to Drupal 6
  */
 function render(&$element) {
-  if (is_array($element)) {
+    if (is_array($element)) {
     show($element);
     return drupal_render($element);
-  }
-  else {
+    }
+    else {
     // Safe-guard for inappropriate use of render() on flat variables: return
     // the variable as-is.
     return $element;
-  }
+    }
 }
 
 
@@ -56,50 +56,50 @@ 
  * Implements hook_block_info().
  */
 function node_comment_block_block_info() {
-  $blocks['node_comments'] = array(
+    $blocks['node_comments'] = array(
     'info' => t('Node comments'),
-  );
+    );
 
-  return $blocks;
+    return $blocks;
 }
 
 /**
  * Implements hook_block_view().
  */
 function node_comment_block_block_view($delta = '') {
-  $block = array();
+    $block = array();
 
-  if ($delta == 'node_comments') {
+    if ($delta == 'node_comments') {
     if (arg(0) == 'node' && is_numeric($nid = arg(1)) && !arg(2)) {
-      $node = node_load($nid);
+        $node = node_load($nid);
 
-      if ($node->comment !== 0) {
+        if ($node->comment !== 0) {
         $block['subject'] = NULL; // This should be NULL otherwise there will be duplicate h2 elements.
         $block['content'] = '';
 
         $node = node_view($node);
 
         if ($node['comments']) {
-          $block['content'] .= render($node['comments']);
+            $block['content'] .= render($node['comments']);
+        }
         }
-      }
     }
-  }
+    }
 
-  return $block;
+    return $block;
 }
 
 /**
  * Implements hook_preprocess_HOOK() for nodes.
  */
 function node_comment_block_preprocess_node(&$variables) {
-  $node = $variables['node'];
-  // Only hide standard comments for news content
-  if ($variables['type'] == 'news') {
+    $node = $variables['node'];
+    // Only hide standard comments for news content
+    if ($variables['type'] == 'news') {
     $variables['node']->comment = 0;
-  }
+    }
   
-  /* Drupal 7...
+    /* Drupal 7...
   if ($node->comment !== 0 && $variables['view_mode'] == 'full') {
     if (isset($variables['content']['comments'])) {
       unset($variables['content']['comments']);
@@ -113,10 +113,10 @@ 
  * Implements hook_form_FORM_ID_alter() for block_admin_configure.
  */
 function node_comment_block_form_block_admin_configure_alter(&$form, &$form_state) {
-  if (isset($form['delta'])) {
+    if (isset($form['delta'])) {
     if ($form['delta']['#value'] == 'node_comments') {
-      $form['settings']['title']['#disabled'] = TRUE;
-      $form['settings']['title']['#description'] = t('The title for this block cannot be overridden.');
+        $form['settings']['title']['#disabled'] = TRUE;
+        $form['settings']['title']['#description'] = t('The title for this block cannot be overridden.');
+    }
     }
-  }
 }

Braces +1 added lines, -2 removed lines

@@ -42,8 +42,7 @@
   if (is_array($element)) {
     show($element);
     return drupal_render($element);
-  }
-  else {
+  } else {
     // Safe-guard for inappropriate use of render() on flat variables: return
     // the variable as-is.
     return $element;

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -17,7 +17,7 @@ 
       if (arg(0) == 'node' && is_numeric($nid = arg(1)) && !arg(2)) {
         $node = node_load($nid);
         if ($node->comment !== 0) {
-          $block['subject'] = NULL; // This should be NULL otherwise there will be duplicate h2 elements.
+          $block['subject'] = null; // This should be NULL otherwise there will be duplicate h2 elements.
           $block['content'] = '';
           if ($node->comment) {
             $block['content'] .= comment_render($node);
@@ -74,7 +74,7 @@ 
       $node = node_load($nid);
 
       if ($node->comment !== 0) {
-        $block['subject'] = NULL; // This should be NULL otherwise there will be duplicate h2 elements.
+        $block['subject'] = null; // This should be NULL otherwise there will be duplicate h2 elements.
         $block['content'] = '';
 
         $node = node_view($node);
@@ -115,7 +115,7 @@ 
 function node_comment_block_form_block_admin_configure_alter(&$form, &$form_state) {
   if (isset($form['delta'])) {
     if ($form['delta']['#value'] == 'node_comments') {
-      $form['settings']['title']['#disabled'] = TRUE;
+      $form['settings']['title']['#disabled'] = true;
       $form['settings']['title']['#description'] = t('The title for this block cannot be overridden.');
     }
   }

drupal/sites/default/boinc/modules/boinc_solr_search/boinc_solr_comments/boinc_solr_comments.module

Switch Indentation +13 added lines, -13 removed lines

@@ -280,12 +280,12 @@ 
   }
 
   switch ($op) {
-    case 'delete':
-      // Only call delete function on certain node types
-      if (in_array( $node->type, $node_types)) {
-        boinc_solr_comments_delete($node);
-      }
-      break;
+  case 'delete':
+    // Only call delete function on certain node types
+    if (in_array( $node->type, $node_types)) {
+      boinc_solr_comments_delete($node);
+    }
+    break;
   } //switch
 }
 
@@ -335,13 +335,13 @@ 
  */
 function boinc_solr_comments_comment(&$a1, $op) {
   switch ($op) {
-    case 'view':
-    case 'update':
-      break;
-    case 'delete':
-      // $a1 should be a comment object
-      boinc_solr_comments_deletecomment($a1);
-      break;
+  case 'view':
+  case 'update':
+    break;
+  case 'delete':
+    // $a1 should be a comment object
+    boinc_solr_comments_deletecomment($a1);
+    break;
   }// switch
 }
 

Braces +3 added lines, -6 removed lines

@@ -131,8 +131,7 @@ 
         if ($comment->uid == 0 || strlen($comment->name) == 0) {
           // @see user_validate_name(). !'0' === TRUE.
           $comment_document->ss_name = '0';
-        }
-        else {
+        } else {
           $comment_document->ss_name = $comment->name;
           // We want the name to be searchable for keywords.
           $comment_document->tos_name = $comment->name;
@@ -318,8 +317,7 @@ 
     $solr->deleteByQuery($query);
     // Log the query used for deletion.
     watchdog('Apache Solr', 'Deleted documents from index with query @query', array('@query' => $query), WATCHDOG_INFO);
-  }
-  catch (Exception $e) {
+  } catch (Exception $e) {
       watchdog('Apache Solr', nl2br(check_plain($e->getMessage())), NULL, WATCHDOG_ERROR);
       return FALSE;
   }// try
@@ -376,8 +374,7 @@ 
     $solr->deleteByQuery($query);
     // Log the query used for deletion.
     watchdog('Apache Solr', 'Deleted documents from index with query @query', array('@query' => $query), WATCHDOG_INFO);
-    }
-  catch (Exception $e) {
+    } catch (Exception $e) {
     watchdog('Apache Solr', nl2br(check_plain($e->getMessage())), NULL, WATCHDOG_ERROR);
     return FALSE;
   }// try

Indentation +116 added lines, -116 removed lines

@@ -14,19 +14,19 @@ 
  * Implementation of hook_menu()
  */
 function boinc_solr_comments_menu() {
-  $items = array();
-  $base_path = 'admin/settings/apachesolr/indexcomments';
-  $items[$base_path] = array(
-      'title' => 'Index Comments',
-      'description' => 'Administer Indexing of Comments',
-      'page callback' => 'drupal_get_form',
-      'page arguments' => array('boinc_solr_comments_form'),
-      'access arguments' => array('administer search'),
-      'file' => 'boinc_solr_comments.admin.inc',
-      'weight' => '10',
-  );
-
-  return $items;
+    $items = array();
+    $base_path = 'admin/settings/apachesolr/indexcomments';
+    $items[$base_path] = array(
+        'title' => 'Index Comments',
+        'description' => 'Administer Indexing of Comments',
+        'page callback' => 'drupal_get_form',
+        'page arguments' => array('boinc_solr_comments_form'),
+        'access arguments' => array('administer search'),
+        'file' => 'boinc_solr_comments.admin.inc',
+        'weight' => '10',
+    );
+
+    return $items;
 }
 
 
@@ -58,11 +58,11 @@ 
  *   Environment ID for apache solr.
  */
 function boinc_solr_comments_apachesolr_index_documents_alter(array &$documents, $entity, $entity_type, $env_id) {
-  $comdocs = array();
+    $comdocs = array();
 
-  // Array of node types that will have comments indexed.
-  $node_types = variable_get('boinc_solr_comments_nodetypes', '');
-  if (empty($node_types)) {
+    // Array of node types that will have comments indexed.
+    $node_types = variable_get('boinc_solr_comments_nodetypes', '');
+    if (empty($node_types)) {
     // If the variable has not been set, then by default index
     // comments for all known node types.
     $node_types = array(
@@ -72,28 +72,28 @@ 
         'story'      => 'story',
         'team_forum' => 'team_forum',
     );
-  }
+    }
   
-  // Loop over all documents and alter:
-  foreach ($documents as $document) {
+    // Loop over all documents and alter:
+    foreach ($documents as $document) {
     //dd($document, "index documents alter - document");
 
     $to_process = ( array_key_exists($document->bundle, $node_types) AND $node_types[$document->bundle] );
     if ( $document->entity_type=='node' AND $to_process) {
       
-      // Remove ts_comments if present.
-      if (isset($document->ts_comments)) {
+        // Remove ts_comments if present.
+        if (isset($document->ts_comments)) {
         unset($document->ts_comments);
-      }
-      // Node information.
-      $nid = $document->entity_id;
-      $node = node_load($nid);
+        }
+        // Node information.
+        $nid = $document->entity_id;
+        $node = node_load($nid);
       
-      // Query database for comments of node. Only return comments
-      // with status 0 (0 is published for comments).
-      $sql = 'SELECT cid from {comments} WHERE nid = %d AND status = 0 ORDER by timestamp DESC';
-      $resource = db_query($sql, $nid);
-      while ($row = db_fetch_array($resource)) {
+        // Query database for comments of node. Only return comments
+        // with status 0 (0 is published for comments).
+        $sql = 'SELECT cid from {comments} WHERE nid = %d AND status = 0 ORDER by timestamp DESC';
+        $resource = db_query($sql, $nid);
+        while ($row = db_fetch_array($resource)) {
         // Load the comment from cid.
         $comment = _comment_load($row['cid']);
 
@@ -116,10 +116,10 @@ 
         // Comment object has no language
         $comment_document->ss_language = 'und';
         if (function_exists('drupal_get_path_alias')) {
-          $output = drupal_get_path_alias($comment_document->path, NULL);
-          if ($output && $output != $document->path) {
+            $output = drupal_get_path_alias($comment_document->path, NULL);
+            if ($output && $output != $document->path) {
             $comment_document->path_alias = $output;
-          }
+            }
         }
         
         // Code derived from apachesolr_index_node_solr_document
@@ -129,13 +129,13 @@ 
 
         // Author information
         if ($comment->uid == 0 || strlen($comment->name) == 0) {
-          // @see user_validate_name(). !'0' === TRUE.
-          $comment_document->ss_name = '0';
+            // @see user_validate_name(). !'0' === TRUE.
+            $comment_document->ss_name = '0';
         }
         else {
-          $comment_document->ss_name = $comment->name;
-          // We want the name to be searchable for keywords.
-          $comment_document->tos_name = $comment->name;
+            $comment_document->ss_name = $comment->name;
+            // We want the name to be searchable for keywords.
+            $comment_document->tos_name = $comment->name;
         }
 
         // Index formatted username so it can be searched and sorted
@@ -157,59 +157,59 @@ 
         // Unset the following fields (if set) that don't make sense
         // for a comment.
         if (isset($comment_document->bs_sticky)) {
-          unset($comment_document->bs_sticky);
+            unset($comment_document->bs_sticky);
         }
         if (isset($comment_document->bs_promote)) {
-          unset($comment_document->bs_promote);
+            unset($comment_document->bs_promote);
         }    
         if (isset($comment_document->is_tnid)) {
-          unset($comment_document->is_tnid);
+            unset($comment_document->is_tnid);
         }
         if (isset($comment_document->bs_translate)) {
-          unset($comment_document->bs_translate);
+            unset($comment_document->bs_translate);
         }
         if (isset($comment_document->ts_last_comment_timestamp)) {
-          unset($comment_document->ts_last_comment_timestamp);
+            unset($comment_document->ts_last_comment_timestamp);
         }
         if (isset($comment_document->ds_last_comment_or_change)) {
-          unset($comment_document->ds_last_comment_or_change);
+            unset($comment_document->ds_last_comment_or_change);
         }
         if (isset($comment_document->is_comment_count)) {
-          unset($comment_document->is_comment_count);
+            unset($comment_document->is_comment_count);
         }
 
         // Loop over fields in document and copy relevant values into
         // comment_document.
         foreach ($document as $fieldName => $fieldValue) {
 
-          // Copy over fields [im_taxonomy_vid_1], [tid], [im_vid_1],
-          // [im_vid_Forums], [tm_vid_1_names]
-          if ( ( preg_match('/tid/', $fieldName) OR preg_match('/vid/', $fieldName) ) AND is_array($fieldValue) ) {
+            // Copy over fields [im_taxonomy_vid_1], [tid], [im_vid_1],
+            // [im_vid_Forums], [tm_vid_1_names]
+            if ( ( preg_match('/tid/', $fieldName) OR preg_match('/vid/', $fieldName) ) AND is_array($fieldValue) ) {
             foreach ($fieldValue as $subkey => $subvalue) {
-              $comment_document->addField($fieldName, $subvalue);
+                $comment_document->addField($fieldName, $subvalue);
             }
-          }// if preg_match
+            }// if preg_match
                
-          // Set the access keys so this module will work with
-          // apachesolr_access.
-          if (module_exists('apachesolr_access')) {
+            // Set the access keys so this module will work with
+            // apachesolr_access.
+            if (module_exists('apachesolr_access')) {
             if (preg_match('/^access/', $fieldName) AND is_array($fieldValue)) {
-              foreach ($fieldValue as $subkey => $subvalue) {
+                foreach ($fieldValue as $subkey => $subvalue) {
                 $comment_document->addField($fieldName, $subvalue);
-              }
+                }
             }// if preg_match
-          }// if module_exist
+            }// if module_exist
             
         }// foreach document
         
         $comdocs[] = $comment_document;
-      }// while
+        }// while
     }// if entity_type=node
-  }// documents
+    }// documents
 
-  // Merge the comment documents with the input documents array. These
-  // documents will now be added to the Solr search index.
-  $documents = array_merge($documents, $comdocs);
+    // Merge the comment documents with the input documents array. These
+    // documents will now be added to the Solr search index.
+    $documents = array_merge($documents, $comdocs);
 }
 
 /**
@@ -225,19 +225,19 @@ 
  *   The Solr query used for the search.
  */
 function boinc_solr_comments_apachesolr_process_results(&$results, DrupalSolrQueryInterface $query) {
-  //dpm($query->getSolrParams(), "process_results query getSolrParams");
-  foreach($results as $id => $result) {
+    //dpm($query->getSolrParams(), "process_results query getSolrParams");
+    foreach($results as $id => $result) {
     if ($result['entity_type']=='comment') {
         $results[$id]['type'] = 'Comment';
         $results[$id]['date'] = $result['fields']['changed'];
         if (isset($result['fields']['is_uid'])) {
-          $uid = $result['fields']['is_uid'];
-          $results[$id]['uid']  = $uid;
-          $results[$id]['user'] = theme('username', user_load($uid));
+            $uid = $result['fields']['is_uid'];
+            $results[$id]['uid']  = $uid;
+            $results[$id]['user'] = theme('username', user_load($uid));
         }
     } //if result entity_type == comment
-  }// foreach $result
-  //dpm($results, "process_results array_results");
+    }// foreach $result
+    //dpm($results, "process_results array_results");
 }
 
 /**
@@ -251,8 +251,8 @@ 
  *   The Solr query used for the search.
  */
 function boinc_solr_comments_apachesolr_query_alter($query) {
-  // Add custom field to query results
-  $query->addParam('fl','tos_content_extra');
+    // Add custom field to query results
+    $query->addParam('fl','tos_content_extra');
 }
 
 /*  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *
@@ -265,9 +265,9 @@ 
  * 
  */
 function boinc_solr_comments_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
-  // Array of node types that will have comments indexed.
-  $node_types = variable_get('boinc_solr_comments_nodetypes', '');
-  if (empty($node_types)) {
+    // Array of node types that will have comments indexed.
+    $node_types = variable_get('boinc_solr_comments_nodetypes', '');
+    if (empty($node_types)) {
     // If the variable has not been set, then by default index
     // comments for all known node types.
     $node_types = array(
@@ -277,16 +277,16 @@ 
         'story'      => 'story',
         'team_forum' => 'team_forum',
     );
-  }
+    }
 
-  switch ($op) {
+    switch ($op) {
     case 'delete':
       // Only call delete function on certain node types
       if (in_array( $node->type, $node_types)) {
         boinc_solr_comments_delete($node);
-      }
-      break;
-  } //switch
+        }
+        break;
+    } //switch
 }
 
 
@@ -303,30 +303,30 @@ 
  *   Returns TRUE if the comment was deleted, otherwise return FALSE.
  */
 function boinc_solr_comments_delete($node) {
-  // Load the Solr environment.
-  $env_id = apachesolr_default_environment();
-  // Check to see if Solr is read-only.
-  if (apachesolr_environment_variable_get($env_id, 'apachesolr_read_only', APACHESOLR_READ_WRITE) == APACHESOLR_READ_ONLY) {
+    // Load the Solr environment.
+    $env_id = apachesolr_default_environment();
+    // Check to see if Solr is read-only.
+    if (apachesolr_environment_variable_get($env_id, 'apachesolr_read_only', APACHESOLR_READ_WRITE) == APACHESOLR_READ_ONLY) {
     return FALSE;
-  }
+    }
   
-  // Code derived from apachesolr_index_delete_entity_from_index
-  try {
+    // Code derived from apachesolr_index_delete_entity_from_index
+    try {
     $solr = apachesolr_get_solr($env_id);
     // Custom query to find all comments with parent nid of the node bing deleted.
     $query = "entity_type:comment AND tos_content_extra:" . $node->nid;
     $solr->deleteByQuery($query);
     // Log the query used for deletion.
     watchdog('Apache Solr', 'Deleted documents from index with query @query', array('@query' => $query), WATCHDOG_INFO);
-  }
-  catch (Exception $e) {
-      watchdog('Apache Solr', nl2br(check_plain($e->getMessage())), NULL, WATCHDOG_ERROR);
-      return FALSE;
-  }// try
-
-  // all deletions sucessful
-  apachesolr_set_last_index_updated($env_id, APACHESOLR_REQUEST_TIME);
-  return TRUE;
+    }
+    catch (Exception $e) {
+        watchdog('Apache Solr', nl2br(check_plain($e->getMessage())), NULL, WATCHDOG_ERROR);
+        return FALSE;
+    }// try
+
+    // all deletions sucessful
+    apachesolr_set_last_index_updated($env_id, APACHESOLR_REQUEST_TIME);
+    return TRUE;
 }
 
 /**
@@ -334,15 +334,15 @@ 
  *
  */
 function boinc_solr_comments_comment(&$a1, $op) {
-  switch ($op) {
+    switch ($op) {
     case 'view':
     case 'update':
       break;
     case 'delete':
       // $a1 should be a comment object
       boinc_solr_comments_deletecomment($a1);
-      break;
-  }// switch
+        break;
+    }// switch
 }
 
 /** 
@@ -358,16 +358,16 @@ 
  *   Returns TRUE if the comment was deleted, otherwise return FALSE.
  */
 function boinc_solr_comments_deletecomment($comment) {
-  // Load the Solr environment.
-  $env_id = apachesolr_default_environment();
-  // Check to see if Solr is read-only.
-  if (apachesolr_environment_variable_get($env_id, 'apachesolr_read_only', APACHESOLR_READ_WRITE) == APACHESOLR_READ_ONLY) {
+    // Load the Solr environment.
+    $env_id = apachesolr_default_environment();
+    // Check to see if Solr is read-only.
+    if (apachesolr_environment_variable_get($env_id, 'apachesolr_read_only', APACHESOLR_READ_WRITE) == APACHESOLR_READ_ONLY) {
     return FALSE;
-  }
-  //dd($comment->cid, "delete - nid begin");
+    }
+    //dd($comment->cid, "delete - nid begin");
     
-  // Code derived from apachesolr_index_delete_entity_from_index.
-  try {
+    // Code derived from apachesolr_index_delete_entity_from_index.
+    try {
     $solr = apachesolr_get_solr($env_id);
     $entity_id = $comment->cid;
     $entity_type = 'comment';
@@ -377,14 +377,14 @@ 
     // Log the query used for deletion.
     watchdog('Apache Solr', 'Deleted documents from index with query @query', array('@query' => $query), WATCHDOG_INFO);
     }
-  catch (Exception $e) {
+    catch (Exception $e) {
     watchdog('Apache Solr', nl2br(check_plain($e->getMessage())), NULL, WATCHDOG_ERROR);
     return FALSE;
-  }// try
+    }// try
 
-  // deletion sucessful
-  apachesolr_set_last_index_updated($env_id, APACHESOLR_REQUEST_TIME);
-  return TRUE;
+    // deletion sucessful
+    apachesolr_set_last_index_updated($env_id, APACHESOLR_REQUEST_TIME);
+    return TRUE;
 }
 
 
@@ -399,7 +399,7 @@ 
  */
 
 function boinc_solr_comments_enable() {
-  drupal_set_message( bts('Warning: Your content <a href="@url">must be re-indexed</a> before Apache Solr will search comments.', array('@url' => url('admin/settings/apachesolr/index')), NULL, 'boinc:admin-solr-index-comments-message'), 'warning');
+    drupal_set_message( bts('Warning: Your content <a href="@url">must be re-indexed</a> before Apache Solr will search comments.', array('@url' => url('admin/settings/apachesolr/index')), NULL, 'boinc:admin-solr-index-comments-message'), 'warning');
 }
 
 /** 
@@ -410,12 +410,12 @@ 
  *   The comment to be published (unhidden).
  */
 function boinc_solr_comments_publish($comment) {
-  if ( ($comment->cid) AND ($comment->nid) ) {
+    if ( ($comment->cid) AND ($comment->nid) ) {
     $node = node_load($comment->nid);
     // Tell Solr that the node has been updated, so the comment can be
     // indexed.
     apachesolr_entity_update($node, 'node');
-  }
+    }
 }
 
 /** 
@@ -426,9 +426,9 @@ 
  *   The comment to be unpublished (hidden). 
  */
 function boinc_solr_comments_unpublish($comment) {
-  if ( ($comment->cid) ) {
+    if ( ($comment->cid) ) {
     // Call the deletecomment function for hook comment.
     boinc_solr_comments_deletecomment($comment);
-  }
+    }
 }
 

Spacing +13 added lines, -13 removed lines

@@ -78,8 +78,8 @@ 
   foreach ($documents as $document) {
     //dd($document, "index documents alter - document");
 
-    $to_process = ( array_key_exists($document->bundle, $node_types) AND $node_types[$document->bundle] );
-    if ( $document->entity_type=='node' AND $to_process) {
+    $to_process = (array_key_exists($document->bundle, $node_types) AND $node_types[$document->bundle]);
+    if ($document->entity_type == 'node' AND $to_process) {
       
       // Remove ts_comments if present.
       if (isset($document->ts_comments)) {
@@ -110,7 +110,7 @@ 
         $comment_document->bundle = 'Comment';
         $comment_document->bundle_name = 'Comment';
 
-        $comment_document->path = 'goto/comment/' . $comment->cid;
+        $comment_document->path = 'goto/comment/'.$comment->cid;
         $comment_document->url = url($comment_document->path, $url_options);
 
         // Comment object has no language
@@ -140,7 +140,7 @@ 
 
         // Index formatted username so it can be searched and sorted
         // on.
-        $account = (object) array('uid' => $comment->uid, 'name' => $comment->name);
+        $account = (object)array('uid' => $comment->uid, 'name' => $comment->name);
         $username = check_plain($account->name);
         $comment_document->ss_name_formatted = $username;
         $comment_document->tos_name_formatted = $username;
@@ -184,7 +184,7 @@ 
 
           // Copy over fields [im_taxonomy_vid_1], [tid], [im_vid_1],
           // [im_vid_Forums], [tm_vid_1_names]
-          if ( ( preg_match('/tid/', $fieldName) OR preg_match('/vid/', $fieldName) ) AND is_array($fieldValue) ) {
+          if ((preg_match('/tid/', $fieldName) OR preg_match('/vid/', $fieldName)) AND is_array($fieldValue)) {
             foreach ($fieldValue as $subkey => $subvalue) {
               $comment_document->addField($fieldName, $subvalue);
             }
@@ -226,8 +226,8 @@ 
  */
 function boinc_solr_comments_apachesolr_process_results(&$results, DrupalSolrQueryInterface $query) {
   //dpm($query->getSolrParams(), "process_results query getSolrParams");
-  foreach($results as $id => $result) {
-    if ($result['entity_type']=='comment') {
+  foreach ($results as $id => $result) {
+    if ($result['entity_type'] == 'comment') {
         $results[$id]['type'] = 'Comment';
         $results[$id]['date'] = $result['fields']['changed'];
         if (isset($result['fields']['is_uid'])) {
@@ -252,7 +252,7 @@ 
  */
 function boinc_solr_comments_apachesolr_query_alter($query) {
   // Add custom field to query results
-  $query->addParam('fl','tos_content_extra');
+  $query->addParam('fl', 'tos_content_extra');
 }
 
 /*  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *  *
@@ -282,7 +282,7 @@ 
   switch ($op) {
     case 'delete':
       // Only call delete function on certain node types
-      if (in_array( $node->type, $node_types)) {
+      if (in_array($node->type, $node_types)) {
         boinc_solr_comments_delete($node);
       }
       break;
@@ -314,7 +314,7 @@ 
   try {
     $solr = apachesolr_get_solr($env_id);
     // Custom query to find all comments with parent nid of the node bing deleted.
-    $query = "entity_type:comment AND tos_content_extra:" . $node->nid;
+    $query = "entity_type:comment AND tos_content_extra:".$node->nid;
     $solr->deleteByQuery($query);
     // Log the query used for deletion.
     watchdog('Apache Solr', 'Deleted documents from index with query @query', array('@query' => $query), WATCHDOG_INFO);
@@ -399,7 +399,7 @@ 
  */
 
 function boinc_solr_comments_enable() {
-  drupal_set_message( bts('Warning: Your content <a href="@url">must be re-indexed</a> before Apache Solr will search comments.', array('@url' => url('admin/settings/apachesolr/index')), NULL, 'boinc:admin-solr-index-comments-message'), 'warning');
+  drupal_set_message(bts('Warning: Your content <a href="@url">must be re-indexed</a> before Apache Solr will search comments.', array('@url' => url('admin/settings/apachesolr/index')), NULL, 'boinc:admin-solr-index-comments-message'), 'warning');
 }
 
 /** 
@@ -410,7 +410,7 @@ 
  *   The comment to be published (unhidden).
  */
 function boinc_solr_comments_publish($comment) {
-  if ( ($comment->cid) AND ($comment->nid) ) {
+  if (($comment->cid) AND ($comment->nid)) {
     $node = node_load($comment->nid);
     // Tell Solr that the node has been updated, so the comment can be
     // indexed.
@@ -426,7 +426,7 @@ 
  *   The comment to be unpublished (hidden). 
  */
 function boinc_solr_comments_unpublish($comment) {
-  if ( ($comment->cid) ) {
+  if (($comment->cid)) {
     // Call the deletecomment function for hook comment.
     boinc_solr_comments_deletecomment($comment);
   }

Upper-Lower-Casing +19 added lines, -19 removed lines

@@ -78,8 +78,8 @@ 
   foreach ($documents as $document) {
     //dd($document, "index documents alter - document");
 
-    $to_process = ( array_key_exists($document->bundle, $node_types) AND $node_types[$document->bundle] );
-    if ( $document->entity_type=='node' AND $to_process) {
+    $to_process = ( array_key_exists($document->bundle, $node_types) and $node_types[$document->bundle] );
+    if ( $document->entity_type=='node' and $to_process) {
       
       // Remove ts_comments if present.
       if (isset($document->ts_comments)) {
@@ -98,7 +98,7 @@ 
         $comment = _comment_load($row['cid']);
 
         // Code derived from _apachesolr_index_process_entity_get_document
-        $url_options = array('absolute' => TRUE);
+        $url_options = array('absolute' => true);
         $comment_document = new ApacheSolrdocument();
 
         $comment_document->id = apachesolr_document_id($comment->cid, 'comment');
@@ -116,16 +116,16 @@ 
         // Comment object has no language
         $comment_document->ss_language = 'und';
         if (function_exists('drupal_get_path_alias')) {
-          $output = drupal_get_path_alias($comment_document->path, NULL);
+          $output = drupal_get_path_alias($comment_document->path, null);
           if ($output && $output != $document->path) {
             $comment_document->path_alias = $output;
           }
         }
         
         // Code derived from apachesolr_index_node_solr_document
-        $comment_document->label = truncate_utf8(apachesolr_clean_text($comment->comment), 32, TRUE);
+        $comment_document->label = truncate_utf8(apachesolr_clean_text($comment->comment), 32, true);
         $comment_document->content = apachesolr_clean_text($comment->comment);
-        $comment_document->teaser = truncate_utf8($document->content, 300, TRUE);
+        $comment_document->teaser = truncate_utf8($document->content, 300, true);
 
         // Author information
         if ($comment->uid == 0 || strlen($comment->name) == 0) {
@@ -184,7 +184,7 @@ 
 
           // Copy over fields [im_taxonomy_vid_1], [tid], [im_vid_1],
           // [im_vid_Forums], [tm_vid_1_names]
-          if ( ( preg_match('/tid/', $fieldName) OR preg_match('/vid/', $fieldName) ) AND is_array($fieldValue) ) {
+          if ( ( preg_match('/tid/', $fieldName) or preg_match('/vid/', $fieldName) ) and is_array($fieldValue) ) {
             foreach ($fieldValue as $subkey => $subvalue) {
               $comment_document->addField($fieldName, $subvalue);
             }
@@ -193,7 +193,7 @@ 
           // Set the access keys so this module will work with
           // apachesolr_access.
           if (module_exists('apachesolr_access')) {
-            if (preg_match('/^access/', $fieldName) AND is_array($fieldValue)) {
+            if (preg_match('/^access/', $fieldName) and is_array($fieldValue)) {
               foreach ($fieldValue as $subkey => $subvalue) {
                 $comment_document->addField($fieldName, $subvalue);
               }
@@ -264,7 +264,7 @@ 
  * Implementation of hook_nodeapi()
  * 
  */
-function boinc_solr_comments_nodeapi(&$node, $op, $a3 = NULL, $a4 = NULL) {
+function boinc_solr_comments_nodeapi(&$node, $op, $a3 = null, $a4 = null) {
   // Array of node types that will have comments indexed.
   $node_types = variable_get('boinc_solr_comments_nodetypes', '');
   if (empty($node_types)) {
@@ -307,7 +307,7 @@ 
   $env_id = apachesolr_default_environment();
   // Check to see if Solr is read-only.
   if (apachesolr_environment_variable_get($env_id, 'apachesolr_read_only', APACHESOLR_READ_WRITE) == APACHESOLR_READ_ONLY) {
-    return FALSE;
+    return false;
   }
   
   // Code derived from apachesolr_index_delete_entity_from_index
@@ -320,13 +320,13 @@ 
     watchdog('Apache Solr', 'Deleted documents from index with query @query', array('@query' => $query), WATCHDOG_INFO);
   }
   catch (Exception $e) {
-      watchdog('Apache Solr', nl2br(check_plain($e->getMessage())), NULL, WATCHDOG_ERROR);
-      return FALSE;
+      watchdog('Apache Solr', nl2br(check_plain($e->getMessage())), null, WATCHDOG_ERROR);
+      return false;
   }// try
 
   // all deletions sucessful
   apachesolr_set_last_index_updated($env_id, APACHESOLR_REQUEST_TIME);
-  return TRUE;
+  return true;
 }
 
 /**
@@ -362,7 +362,7 @@ 
   $env_id = apachesolr_default_environment();
   // Check to see if Solr is read-only.
   if (apachesolr_environment_variable_get($env_id, 'apachesolr_read_only', APACHESOLR_READ_WRITE) == APACHESOLR_READ_ONLY) {
-    return FALSE;
+    return false;
   }
   //dd($comment->cid, "delete - nid begin");
     
@@ -378,13 +378,13 @@ 
     watchdog('Apache Solr', 'Deleted documents from index with query @query', array('@query' => $query), WATCHDOG_INFO);
     }
   catch (Exception $e) {
-    watchdog('Apache Solr', nl2br(check_plain($e->getMessage())), NULL, WATCHDOG_ERROR);
-    return FALSE;
+    watchdog('Apache Solr', nl2br(check_plain($e->getMessage())), null, WATCHDOG_ERROR);
+    return false;
   }// try
 
   // deletion sucessful
   apachesolr_set_last_index_updated($env_id, APACHESOLR_REQUEST_TIME);
-  return TRUE;
+  return true;
 }
 
 
@@ -399,7 +399,7 @@ 
  */
 
 function boinc_solr_comments_enable() {
-  drupal_set_message( bts('Warning: Your content <a href="@url">must be re-indexed</a> before Apache Solr will search comments.', array('@url' => url('admin/settings/apachesolr/index')), NULL, 'boinc:admin-solr-index-comments-message'), 'warning');
+  drupal_set_message( bts('Warning: Your content <a href="@url">must be re-indexed</a> before Apache Solr will search comments.', array('@url' => url('admin/settings/apachesolr/index')), null, 'boinc:admin-solr-index-comments-message'), 'warning');
 }
 
 /** 
@@ -410,7 +410,7 @@ 
  *   The comment to be published (unhidden).
  */
 function boinc_solr_comments_publish($comment) {
-  if ( ($comment->cid) AND ($comment->nid) ) {
+  if ( ($comment->cid) and ($comment->nid) ) {
     $node = node_load($comment->nid);
     // Tell Solr that the node has been updated, so the comment can be
     // indexed.