BOINC / boinc

html/ops/badge_assign.php

Spacing +7 added lines, -7 removed lines

@@ -32,7 +32,7 @@ 
 //
 function get_pct_badges($badge_name_prefix, $badge_pctiles, $badge_images) {
     $badges = array();
-    for ($i=0; $i<3; $i++) {
+    for ($i = 0; $i < 3; $i++) {
         $badges[$i] = get_badge($badge_name_prefix."_".$i, "Top ".$badge_pctiles[$i]."% in average credit", $badge_images[$i]);
     }
     return $badges;
@@ -42,11 +42,11 @@ 
 //
 function get_percentiles($is_user, $badge_pctiles) {
     $percentiles = array();
-    for ($i=0; $i<3; $i++) {
+    for ($i = 0; $i < 3; $i++) {
         if ($is_user) {
-            $percentiles[$i] = BoincUser::percentile("expavg_credit", "expavg_credit>1", 100-$badge_pctiles[$i]);
+            $percentiles[$i] = BoincUser::percentile("expavg_credit", "expavg_credit>1", 100 - $badge_pctiles[$i]);
         } else {
-            $percentiles[$i] = BoincTeam::percentile("expavg_credit", "expavg_credit>1", 100-$badge_pctiles[$i]);
+            $percentiles[$i] = BoincTeam::percentile("expavg_credit", "expavg_credit>1", 100 - $badge_pctiles[$i]);
         }
         if ($percentiles[$i] === false) {
             die("Can't get percentiles\n");
@@ -59,7 +59,7 @@ 
 // Unassign other badges.
 //
 function assign_pct_badge($is_user, $item, $percentiles, $badges) {
-    for ($i=0; $i<3; $i++) {
+    for ($i = 0; $i < 3; $i++) {
         if ($item->expavg_credit >= $percentiles[$i]) {
             assign_badge($is_user, $item, $badges[$i]);
             unassign_badges($is_user, $item, $badges, $i);
@@ -73,13 +73,13 @@ 
 // and assign/unassign RAC badges
 //
 function assign_badges($is_user, $badge_pctiles, $badge_images) {
-    $kind = $is_user?"user":"team";
+    $kind = $is_user ? "user" : "team";
     $badges = get_pct_badges($kind."_pct", $badge_pctiles, $badge_images);
     $pctiles = get_percentiles($is_user, $badge_pctiles);
     //echo "thresholds for $kind badges: $pctiles[0] $pctiles[1] $pctiles[2]\n";
 
     $n = 0;
-    $maxid = $is_user?BoincUser::max("id"):BoincTeam::max("id");
+    $maxid = $is_user ?BoincUser::max("id") : BoincTeam::max("id");
     while ($n <= $maxid) {
         $m = $n + 1000;
         if ($is_user) {

html/ops/bolt_map.php

Spacing +9 added lines, -9 removed lines

@@ -103,7 +103,7 @@ 
 
 function spaces($level) {
     $x = "";
-    for ($i=0; $i<$level; $i++) {
+    for ($i = 0; $i < $level; $i++) {
         $x .= "&nbsp;&nbsp;&nbsp;&nbsp;";
     }
     return $x;
@@ -136,7 +136,7 @@ 
 function avg_score($array) {
     $sum = 0;
     $n = count($array);
-    if ($n ==0) return 0;
+    if ($n == 0) return 0;
     foreach ($array as $a) {
         $sum += $a->score;
     }
@@ -152,7 +152,7 @@ 
             $n++;
         }
     }
-    if ($n ==0) return 0;
+    if ($n == 0) return 0;
     return $sum/$n;
 }
 
@@ -235,7 +235,7 @@ 
     global $breakdown, $breakdown_cat;
     global $rownum, $course_id;
 
-    $a = $is_answer?" (answer)":"";
+    $a = $is_answer ? " (answer)" : "";
     $j = ($rownum++)%2;
     echo "<tr class=row$j>";
     if ($breakdown && $breakdown_cat) {
@@ -243,7 +243,7 @@ 
             <td><br></td>
             <td><br></td>
         ";
-    } else  {
+    } else {
         $c = class_name($class);
         echo "
             <td><b>".spaces($level)."$unit->name</b></td>
@@ -277,7 +277,7 @@ 
         echo time_graph($t, 200);
         break;
     case "BoltExercise":
-        $mode = $is_answer?BOLT_MODE_ANSWER:BOLT_MODE_SHOW;
+        $mode = $is_answer ?BOLT_MODE_ANSWER:BOLT_MODE_SHOW;
         $views = get_views($unit, $mode);
         $n = count($views);
         $out = outcomes($views);
@@ -360,7 +360,7 @@ 
     show_unit($unit, $level);
     if ($unit->is_item) return;
     foreach ($unit->units as $u) {
-        show_unit_recurse($u, $level+1);
+        show_unit_recurse($u, $level + 1);
     }
 }
 
@@ -402,9 +402,9 @@ 
         <input type=hidden name=course_id value=$course_id>
         <table width=600><tr><td valign=top>
     ";
-    filter_form($filter?$filter->name():"", $filter_cat);
+    filter_form($filter ? $filter->name() : "", $filter_cat);
     echo "</td><td valign=top>";
-    breakdown_form($breakdown?$breakdown->name():"");
+    breakdown_form($breakdown ? $breakdown->name() : "");
     echo "
         </td></tr></table>
         <p>

html/ops/badge_assign_custom.php

Spacing +6 added lines, -6 removed lines

@@ -77,7 +77,7 @@ 
 ) {
     $badges = array();
     $limit = count($badge_level_names);
-    for ($i=0; $i < $limit; $i++) {
+    for ($i = 0; $i < $limit; $i++) {
         $badges[$i] = get_badge($badge_name_prefix."_".$sub_project["short_name"]."_".$i, "$badge_level_names[$i] in ".$sub_project["name"]." credit", $sub_project["short_name"].$badge_images[$i]);
     }
     return $badges;
@@ -90,7 +90,7 @@ 
     // count from highest to lowest level, so the user get's assigned the
     // highest possible level and the lower levels get removed
     //
-    for ($i=count($levels)-1; $i>=0; $i--) {
+    for ($i = count($levels) - 1; $i >= 0; $i--) {
         if ($item->total_credit >= $levels[$i]) {
             assign_badge($is_user, $item, $badges[$i]);
             unassign_badges($is_user, $item, $badges, $i);
@@ -114,7 +114,7 @@ 
     // count from highest to lowest level, so the user get's assigned the
     // highest possible level and the lower levels get removed
     //
-    for ($i=count($levels)-1; $i>=0; $i--) {
+    for ($i = count($levels) - 1; $i >= 0; $i--) {
         if ($sub_total >= $levels[$i]) {
             assign_badge($is_user, $item, $badges[$i]);
             unassign_badges($is_user, $item, $badges, $i);
@@ -134,7 +134,7 @@ 
     $is_user, $badge_levels, $badge_level_names, $badge_images,
     $subprojects_list
 ) {
-    $kind = $is_user?"user":"team";
+    $kind = $is_user ? "user" : "team";
 
     // get badges for all subprojects including total
     //
@@ -143,7 +143,7 @@ 
     }
 
     $n = 0;
-    $maxid = $is_user?BoincUser::max("id"):BoincTeam::max("id");
+    $maxid = $is_user ?BoincUser::max("id") : BoincTeam::max("id");
     while ($n <= $maxid) {
         $m = $n + 1000;
         if ($is_user) {
@@ -161,7 +161,7 @@ 
                     assign_tot_badge($is_user, $item, $badge_levels, $badges["total"]);
                 } else {
                     // appids come from project/project.inc
-                    $where_clause = "appid in (". implode(',', $sp["appids"]) .")";
+                    $where_clause = "appid in (".implode(',', $sp["appids"]).")";
                     assign_sub_badge(
                         $is_user, $item, $badge_levels, $badges[$sp["short_name"]],
                         $where_clause

html/ops/export_credit_by_app.php

Spacing +7 added lines, -7 removed lines

@@ -28,9 +28,9 @@ 
 function export_item($item, $is_user, $f) {
     global $sub_projects;
 
-    fprintf($f, $is_user?"<user>\n":"<team>\n");
+    fprintf($f, $is_user ? "<user>\n" : "<team>\n");
     fprintf($f, "    <id>$item->id</id>\n");
-    $crs = $is_user?
+    $crs = $is_user ?
         BoincCreditUser::enum("userid=$item->id")
         : BoincCreditTeam::enum("teamid=$item->id")
     ;
@@ -56,16 +56,16 @@ 
         }
     }
 
-    fprintf($f, $is_user?"</user>\n":"</team>\n");
+    fprintf($f, $is_user ? "</user>\n" : "</team>\n");
 }
 
 function export($is_user, $dir) {
     $n = 0;
-    $filename = $is_user?"$dir/user_work":"$dir/team_work";
+    $filename = $is_user ? "$dir/user_work" : "$dir/team_work";
     $f = fopen($filename, "w");
     if (!$f) die("fopen");
-    $is_user?  fprintf($f, "<users>\n"): fprintf($f, "<teams>\n");
-    $maxid = $is_user?BoincUser::max("id"):BoincTeam::max("id");
+    $is_user ?  fprintf($f, "<users>\n") : fprintf($f, "<teams>\n");
+    $maxid = $is_user ?BoincUser::max("id") : BoincTeam::max("id");
     while ($n <= $maxid) {
         $m = $n + 1000;
         if ($is_user) {
@@ -78,7 +78,7 @@ 
         }
         $n = $m;
     }
-    $is_user?  fprintf($f, "</users>\n"): fprintf($f, "</teams>\n");
+    $is_user ?  fprintf($f, "</users>\n") : fprintf($f, "</teams>\n");
     fclose($f);
     system("gzip -f $filename");
 }

html/project.sample/project_specific_prefs.inc

Spacing +15 added lines, -15 removed lines

@@ -33,7 +33,7 @@ 
 //      Also error-check values, and return errors in $errors->*
 
 function option($name, $val) {
-    $x = ($name == $val) ?  "selected" : "";
+    $x = ($name == $val) ? "selected" : "";
     return "<option name='$name' $x>$name\n";
 }
 
@@ -53,7 +53,7 @@ 
 if (APP_SELECT_PREFS) {
     $app_array = array();
     $apps = BoincApp::enum("deprecated=0");
-    foreach($apps as $app) {
+    foreach ($apps as $app) {
         $app_array[] = array($app->id, $app->user_friendly_name);
     }
 } else {
@@ -91,10 +91,10 @@ 
 }
 
 function number_select($name, $max, $n) {
-    $sel = ($n == 0) ? "selected":"";
+    $sel = ($n == 0) ? "selected" : "";
     $x = "<select class=\"form-control input-sm\" name=$name> <option value=0 $sel>".tra("No limit")."</option>";
-    for ($i=1; $i<=$max; $i++) {
-        $sel = ($n == $i) ? "selected":"";
+    for ($i = 1; $i <= $max; $i++) {
+        $sel = ($n == $i) ? "selected" : "";
         $x .= "<option value=$i $sel>$i</option>";
     }
     $x .= "</select>";
@@ -106,7 +106,7 @@ 
     return tra("No limit");
 }
 
-function project_specific_prefs_edit($prefs, $error=false) {
+function project_specific_prefs_edit($prefs, $error = false) {
     global $app_array;
     if (COLOR_PREFS) {
         $x = $prefs->color_scheme;
@@ -132,15 +132,15 @@ 
             } else {
                 $present = true;
             }
-            $checked = $present?"checked":"";
+            $checked = $present ? "checked" : "";
             $x .= "<input type=checkbox name=app_id_$app_id $checked> $app_name<br>";
         }
         tooltip_row2(APP_SELECT_TOOLTIP, APP_SELECT_DESC, $x);
-        $checked = $prefs->allow_non_preferred_apps?"checked":"";
+        $checked = $prefs->allow_non_preferred_apps ? "checked" : "";
         row2(ACCEPT_ANY_DESC, "<input type=checkbox name=allow_non_preferred_apps $checked>");
     }
     if (NON_GRAPHICAL_PREF) {
-        $checked = $prefs->non_graphical?"checked":"";
+        $checked = $prefs->non_graphical ? "checked" : "";
         row2(
             NON_GRAPHICAL_DESC,
             "<input type=checkbox name=non_graphical $checked>"
@@ -216,11 +216,11 @@ 
     return $x;
 }
 
-function project_specific_prefs_show($prefs, $columns=false) {
+function project_specific_prefs_show($prefs, $columns = false) {
     global $app_array;
     if ($columns) {
         if (COLOR_PREFS) {
-            row_defs(COLOR_DESC,"color_scheme", "", "", $prefs);
+            row_defs(COLOR_DESC, "color_scheme", "", "", $prefs);
         }
         if (GFX_CPU_PREFS) {
             row_defs(MAX_GFX_CPU_PCT_DESC, "max_gfx_cpu_pct", "", "", $prefs);
@@ -254,7 +254,7 @@ 
             row2(ACCEPT_ANY_DESC, $prefs->allow_non_preferred_apps_text);
         }
         if (NON_GRAPHICAL_PREF) {
-            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical?tra("yes"):tra("no"));
+            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical ?tra("yes") : tra("no"));
         }
         if (MAX_JOBS_PREF) {
             row2(tra("Max # jobs"), limit_string($prefs->max_jobs));
@@ -277,12 +277,12 @@ 
         $cursor = 0;
         while ($thisxml = parse_next_element($prefs_xml, "<app_id>", $cursor)) {
             if (is_numeric($thisxml)) {
-                $n = (int) $thisxml;
+                $n = (int)$thisxml;
                 $prefs->app_ids[] = $n;
             }
         }
         $prefs->allow_non_preferred_apps = parse_element($prefs_xml, "<allow_non_preferred_apps>");
-        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps?"yes":"no";
+        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps ? "yes" : "no";
     }
     if (NON_GRAPHICAL_PREF) {
         $prefs->non_graphical = parse_bool($prefs_xml, "non_graphical");
@@ -296,6 +296,6 @@ 
     return $prefs;
 }
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 
 ?>

html/user/bolt.php

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     if ($course->hidden && !($user->bolt->flags&BOLT_FLAG_SHOW_ALL)) {
         continue;
     }
-    $e = $user?BoltEnrollment::lookup($user->id, $course->id):null;
+    $e = $user ?BoltEnrollment::lookup($user->id, $course->id) : null;
     if ($e) {
         $start = date_str($e->create_time);
         $view = BoltView::lookup_id($e->last_view_id);

html/user/team.php

Spacing +14 added lines, -14 removed lines

@@ -26,38 +26,38 @@
 
 page_head(tra("Teams"));
 
-echo "<p>".tra("%1 participants may form %2 teams %3.", PROJECT, "<b>", "</b>") ."
+echo "<p>".tra("%1 participants may form %2 teams %3.", PROJECT, "<b>", "</b>")."
     <p>
-    ". tra("You may belong to only one team. You can join or quit a team at any time."). "
+    ". tra("You may belong to only one team. You can join or quit a team at any time.")."
     <p>" .
-    tra("Each team has a %1 founder %2 who may:", "<b>", "</b>") . "
+    tra("Each team has a %1 founder %2 who may:", "<b>", "</b>")."
     <ul>
-    <li> " . tra("edit the team's name and description") . "
-    <li> " . tra("add or remove team admins") . "
-    <li> " . tra("remove members from the team") . "
-    <li> " . tra("disband a team if it has no members") . "
+    <li> " . tra("edit the team's name and description")."
+    <li> " . tra("add or remove team admins")."
+    <li> " . tra("remove members from the team")."
+    <li> " . tra("disband a team if it has no members")."
     </ul>
     <p>" .
-    tra("To join a team, visit its team page and click %1 Join this team %2.", "<b>", "</b>") . "
-    <h3>" . tra("Find a team") . "</h3>
+    tra("To join a team, visit its team page and click %1 Join this team %2.", "<b>", "</b>")."
+    <h3>" . tra("Find a team")."</h3>
 ";
 team_search_form(null);
 echo "
 
-    <h3>" . tra("Top teams") . "</h3>
+    <h3>" . tra("Top teams")."</h3>
     <ul>
-    <li> <a href=\"top_teams.php\">" . tra("All teams") . "</a>
+    <li> <a href=\"top_teams.php\">" . tra("All teams")."</a>
 ";
 
-for ($i=1; $i<count($team_types); $i++) {
+for ($i = 1; $i < count($team_types); $i++) {
     echo "<li> <a href=\"top_teams.php?type=".$i."\">".tra("%1 teams", team_type_name($i))."</a>
     ";
 }
 
 echo "
     </ul>
-    <h3>" . tra("Create a new team") . "</h3>
-    " . tra("If you cannot find a team that is right for you, you can %1 create a team %2.", "<a href=\"team_create_form.php\">","</a>");
+    <h3>" . tra("Create a new team")."</h3>
+    " . tra("If you cannot find a team that is right for you, you can %1 create a team %2.", "<a href=\"team_create_form.php\">", "</a>");
 page_tail();
 
 ?>

html/user/top_teams.php

Spacing +10 added lines, -10 removed lines

@@ -32,11 +32,11 @@ 
 }
 define('ITEM_LIMIT', 10000);
 
-function get_top_teams($offset, $sort_by, $type){
+function get_top_teams($offset, $sort_by, $type) {
     global $teams_per_page;
     $db = BoincDb::get(true);
     $type_clause = null;
-    if ($type){
+    if ($type) {
         $type_clause = "type=$type";
     }
     if ($sort_by == "total_credit") {
@@ -60,26 +60,26 @@ 
 if ($type < 0 || $type >= count($team_types)) {
     $type = 0;
 }
-$type_url="";
-$type_name="";
+$type_url = "";
+$type_name = "";
 if ($type) {
     $type_url = "&type=$type";
     $type_name = team_type_name($type);
 }
 
 $offset = get_int("offset", true);
-if (!$offset) $offset=0;
-if ($offset % $teams_per_page) $offset = 0;
+if (!$offset) $offset = 0;
+if ($offset%$teams_per_page) $offset = 0;
 
 if ($offset < ITEM_LIMIT) {
     $cache_args = "sort_by=$sort_by&offset=$offset$type_url";
-    $cacheddata = get_cached_data(TOP_PAGES_TTL,$cache_args);
+    $cacheddata = get_cached_data(TOP_PAGES_TTL, $cache_args);
     //If we have got the data in cache
-    if ($cacheddata){
+    if ($cacheddata) {
         $data = unserialize($cacheddata); // use the cached data
     } else {
         //if not do queries etc to generate new data
-        $data = get_top_teams($offset,$sort_by,$type);
+        $data = get_top_teams($offset, $sort_by, $type);
         
         // Calculate nusers before storing into the cache
         foreach ($data as $team) {
@@ -115,7 +115,7 @@ 
         echo "<a href=top_teams.php?sort_by=$sort_by&amp;offset=$new_offset".$type_url.">".tra("Previous %1", $teams_per_page)."</a> &middot; ";
 
     }
-    if ($n==$teams_per_page){ //If we aren't on the last page
+    if ($n == $teams_per_page) { //If we aren't on the last page
         $new_offset = $offset + $teams_per_page;
         echo "<a href=top_teams.php?sort_by=$sort_by&amp;offset=$new_offset".$type_url.">".tra("Next %1", $teams_per_page)."</a>";
     }

html/user/forum_thread.php

Spacing +11 added lines, -11 removed lines

@@ -30,7 +30,7 @@ 
 $postid = get_int('postid', true);
 $filter = get_str('filter', true);
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -79,8 +79,8 @@ 
 if ($temp_sort_style) {
     $sort_style = $temp_sort_style;
 } else if ($sort_style) {
-    $forum_style = 0;   // this is deprecated
-    if ($logged_in_user){
+    $forum_style = 0; // this is deprecated
+    if ($logged_in_user) {
         $logged_in_user->prefs->thread_sorting = $sort_style;
         $logged_in_user->prefs->update("thread_sorting=$sort_style");
     } else {
@@ -92,7 +92,7 @@ 
     );
 } else {
     // get the sorting style from the user or a cookie
-    if ($logged_in_user){
+    if ($logged_in_user) {
         $sort_style = $logged_in_user->prefs->thread_sorting;
     } else {
         list($forum_style, $sort_style) = parse_forum_cookie();
@@ -120,10 +120,10 @@ 
 
 if (false) {
 if ($forum->parent_type == 0) {
-    if ($category->is_helpdesk && !$thread->status){
-        if ($logged_in_user){
-            if ($thread->owner == $logged_in_user->id){
-                if ($thread->replies !=0) {
+    if ($category->is_helpdesk && !$thread->status) {
+        if ($logged_in_user) {
+            if ($thread->owner == $logged_in_user->id) {
+                if ($thread->replies != 0) {
                     // Show a "this question has been answered" to the author
                     echo "<p>";
                     show_button(
@@ -189,7 +189,7 @@ 
     // If logged in user is moderator, enable some extra features
     //
     if (is_moderator($logged_in_user, $forum)) {
-        if ($thread->hidden){
+        if ($thread->hidden) {
             show_button_small(
                 "forum_moderate_thread_action.php?action=unhide&amp;thread=".$thread->id."$tokens",
                 tra("Unhide"),
@@ -202,7 +202,7 @@ 
                 tra("Hide this thread")
             );
         }
-        if ($thread->sticky){
+        if ($thread->sticky) {
             show_button_small(
                 "forum_moderate_thread_action.php?action=desticky&amp;thread=".$thread->id."$tokens",
                 tra("Make unsticky"),
@@ -308,5 +308,5 @@ 
 $thread->update("views=views+1");
 
 page_tail();
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>