BOINC / boinc

html/user/weak_auth.php

Spacing +7 added lines, -7 removed lines

@@ -29,14 +29,14 @@ 
 //
 $idx = strpos($master_url, '://');
 if ($idx) {
-    $url = substr($master_url, $idx+strlen('://'));
+    $url = substr($master_url, $idx + strlen('://'));
 } else {
     $url = $master_url;
 }
 
 // convert invalid characters into underscores
 //
-for ($i=0; $i<strlen($url); $i++) {
+for ($i = 0; $i < strlen($url); $i++) {
     $c = $url[$i];
     if (!ctype_alnum($c) && $c != '.' && $c != '-' && $c != '_') {
         $url[$i] = '_';
@@ -45,7 +45,7 @@ 
 
 //remove trailing underscore(s)
 //
-$account_file = "account_" . rtrim($url, '_') . ".xml";
+$account_file = "account_".rtrim($url, '_').".xml";
 
 page_head(tra("Account keys"));
 text_start();
@@ -57,12 +57,12 @@ 
     <p>",
     tra("This key can be used to:"),
     "<ul>
-    <li><a href=get_passwd.php>",tra("log in to your account on the web"),"</a>;
+    <li><a href=get_passwd.php>",tra("log in to your account on the web"), "</a>;
     <li>",
         tra("attach a computer to your account without using the BOINC Manager.
        To do so, install BOINC,
        create a file named %1 in the BOINC
-       data directory, and set its contents to:","<b>$account_file</b>"),"
+       data directory, and set its contents to:","<b>$account_file</b>"), "
     <p><pre>",
     htmlspecialchars(
 "<account>
@@ -76,10 +76,10 @@ 
     as described above, but cannot be used to log in to your account or change it in any way.
     If you want to attach untrusted or insecure computers to your account,
     do so using your weak account key.
-    Your weak account key is:"),"
+    Your weak account key is:"), "
     <p><pre>$weak_auth</pre><p>
     ",
-    tra("The key depends on your account's email address and password.  If you change either of these, the weak account key will change."),"
+    tra("The key depends on your account's email address and password.  If you change either of these, the weak account key will change."), "
     </td></tr></table>"
 ;
 text_end();

html/inc/prefs_util.inc

Spacing +28 added lines, -28 removed lines

@@ -42,9 +42,9 @@ 
 }
 
 abstract class PREF {
-    public $desc;       // short description
-    public $tooltip;    // longer description, shown as tooltip
-    public $tag;        // the pref's primary XML tag
+    public $desc; // short description
+    public $tooltip; // longer description, shown as tooltip
+    public $tag; // the pref's primary XML tag
     function __construct($desc, $tooltip, $tag) {
         $this->desc = $desc;
         $this->tooltip = $tooltip;
@@ -122,15 +122,15 @@ 
 
 class PREF_BOOL extends PREF {
     public $default;
-    public $invert;     // show to user in opposite sense
-    function __construct($desc, $tooltip, $tag, $default, $invert=false) {
+    public $invert; // show to user in opposite sense
+    function __construct($desc, $tooltip, $tag, $default, $invert = false) {
         $this->default = $default;
         $this->invert = $invert;
         parent::__construct($desc, $tooltip, $tag);
     }
     function show_value($prefs) {
         $tag = $this->tag;
-        $v = $this->invert?!$prefs->$tag:$prefs->$tag;
+        $v = $this->invert ? !$prefs->$tag : $prefs->$tag;
         echo "<td>".readonly_checkbox($v)."</td>";
     }
     function show_form($prefs, $error) {
@@ -142,7 +142,7 @@ 
         }
         echo "<td ".VALUE_ATTRS.">"
             ."<input type=checkbox name=$this->tag "
-            . ($checked?"checked":"")
+            . ($checked ? "checked" : "")
             ."></td>
         ";
     }
@@ -155,7 +155,7 @@ 
     function xml_string($prefs) {
         $tag = $this->tag;
         return "<$tag>"
-            .($prefs->$tag?"1":"0")
+            .($prefs->$tag ? "1" : "0")
             ."</$tag>\n";
     }
     function xml_parse(&$prefs, $name, $text) {
@@ -175,9 +175,9 @@ 
     public $consent_type_id; // the consent_type_id from the consent_type table
     public $consent_name; // the consent_name to configure
     public $default;
-    public $invert;     // show to user in opposite sense
+    public $invert; // show to user in opposite sense
 
-    function __construct($desc, $tooltip, $tag, $consent_type_id, $consent_name, $default, $invert=false) {
+    function __construct($desc, $tooltip, $tag, $consent_type_id, $consent_name, $default, $invert = false) {
         $this->consent_type_id = $consent_type_id;
         $this->consent_name = $consent_name;
         $this->default = $default;
@@ -240,7 +240,7 @@ 
         } else {
             $value = false;
         }
-        echo "<td>" . readonly_checkbox($value) . "</td>";
+        echo "<td>".readonly_checkbox($value)."</td>";
     }
     function show_form($user, $error) {
         $consent_type_id = $this->consent_type_id;
@@ -257,7 +257,7 @@ 
         }
         echo "<td ".VALUE_ATTRS.">"
             ."<input type=checkbox name=$this->tag "
-            . ($checked?"checked":"")
+            . ($checked ? "checked" : "")
             ."></td>
         ";
     }
@@ -276,7 +276,7 @@ 
             "userid=$user->id AND consent_type_id='$consent_type_id$'"
         );
 
-        if ((($cr) and ($cr->consent_flag!=$flag)) or (!$cr)) {
+        if ((($cr) and ($cr->consent_flag != $flag)) or (!$cr)) {
             $rc = consent_to_a_policy(
                 $user, $consent_type_id, $flag, 0, 'Webform', time()
             );
@@ -316,7 +316,7 @@ 
         // this is the value if they check the box
     public $scale;
 
-    function __construct($suffix, $min, $max, $default, $scale=1, $default2=0) {
+    function __construct($suffix, $min, $max, $default, $scale = 1, $default2 = 0) {
         $this->suffix = " $suffix";
         $this->min = $min;
         $this->max = $max;
@@ -335,7 +335,7 @@ 
         $v .= "$this->suffix ";
         return $v;
     }
-    function form_str($tag, $v, $had_error, $disabled=false, $id=null) {
+    function form_str($tag, $v, $had_error, $disabled = false, $id = null) {
         if (is_numeric($v)) {
             $v /= $this->scale;
             if (!$had_error && ($v < $this->min || $v > $this->max)) {
@@ -343,7 +343,7 @@ 
             }
         }
         if ($disabled) $v = "";
-        $i = $id?"id=\"$id\"":"";
+        $i = $id ? "id=\"$id\"" : "";
         return '<input type="text" size="5" class="form-control input-sm" name="'.$tag.'" value="'.$v."\" $disabled $i> &nbsp; $this->suffix ";
     }
     function form_convert($in, &$out, &$error) {
@@ -466,8 +466,8 @@ 
         $text_id = $this->tag;
         $default = $this->num_spec->get_default();
         $val = $prefs->$tag;
-        $c = $val?"checked":"";
-        $d = $val?"":"disabled";
+        $c = $val ? "checked" : "";
+        $d = $val ? "" : "disabled";
         echo "<td $attrs>"
             ."<input type=checkbox id=$checkbox_id onClick=\"checkbox_clicked('$checkbox_id', '$text_id', $default)\" $c> &nbsp;"
             .$this->num_spec->form_str($tag, $prefs->$tag, $had_error, $d, $text_id)
@@ -580,8 +580,8 @@ 
 function hour_select($x, $name, $id, $d) {
     $s = "";
     $s .= "<select class=\"selectbox form-control input-sm\" name=$name id=$id $d>\n";
-    for ($i=0; $i<24; $i++) {
-        $sel = ($x == $i)?"selected":"";
+    for ($i = 0; $i < 24; $i++) {
+        $sel = ($x == $i) ? "selected" : "";
         $s .= "<option value=$i $sel> $i:00";
     }
     $s .= "</select>\n";
@@ -682,7 +682,7 @@ 
 
 // row_defs - Display a value for all 4 venues in one row
 //
-function row_defs($pre, $item, $post, $type, $prefs, $tooltip=null) {
+function row_defs($pre, $item, $post, $type, $prefs, $tooltip = null) {
     $gen = $prefs->$item;
     $hom  = (isset($prefs->home) && isset($prefs->home->$item)) ? $prefs->home->$item : "--";
     $schl = (isset($prefs->school) && isset($prefs->school->$item)) ? $prefs->school->$item : "--";
@@ -694,10 +694,10 @@ 
         echo "<tr>";
     }
     echo "<td ".NAME_ATTRS.">$pre</td>";
-    row_field($gen,  $type);
-    row_field($hom,  $type);
+    row_field($gen, $type);
+    row_field($hom, $type);
     row_field($schl, $type);
-    row_field($wrk,  $type);
+    row_field($wrk, $type);
     echo "<td align=left>$post</td></tr>\n";
 }
 
@@ -707,16 +707,16 @@ 
 function row_field($value, $type) {
     echo "<td>";
     $type = $value === "--" ? "--" : $type;
-    switch($type) {
+    switch ($type) {
     case "yesno":
-        echo $value ?tra("yes"):tra("no");
+        echo $value ?tra("yes") : tra("no");
         break;
     case "noyes":
-        echo $value ?tra("no"):tra("yes");
+        echo $value ?tra("no") : tra("yes");
         break;
     case "limit":
         $x = max_bytes_display_mode($value);
-        $y = "$x " . BYTE_ABBR;
+        $y = "$x ".BYTE_ABBR;
         echo $x ? "$y" : tra("no limit");
         break;
     case "minutes":

html/ops/dbinfo.php

Indentation +109 added lines, -109 removed lines

@@ -15,10 +15,10 @@ 
     function __construct($n, $d, $i, $t, $r, $s) {
         $this->name = $n;
         $this->data_size = $d;
-		$this->index_size = $i;
-		$this->total_size = $t;
-		$this->rows = $r;
-		$this->size_per_row = $s;
+        $this->index_size = $i;
+        $this->total_size = $t;
+        $this->rows = $r;
+        $this->size_per_row = $s;
     }
     function __destruct() {
     }
@@ -42,25 +42,25 @@ 
 
 // returns formatted data size
 function size_format($size){
-	$retval = 0;
+    $retval = 0;
 
-	$KB = 1024;
+    $KB = 1024;
     $MB = 1024*1024;
     $GB = 1024*1024*1024;
-	$TB = 1024*1024*1024*1024;
+    $TB = 1024*1024*1024*1024;
 
     if ($size < $KB) {
-	    $retval = $size;
+        $retval = $size;
     } elseif (($size > $KB) && ($size < $MB)) {
-		$retval = sprintf("%.0fK", ($size / $KB));
+        $retval = sprintf("%.0fK", ($size / $KB));
     } elseif ( ($size >= $MB) && ($size < $GB)) {
-		$retval = sprintf("%.2fMB", ($size / $MB));
+        $retval = sprintf("%.2fMB", ($size / $MB));
     } elseif ( ($size >= $GB) && ($size < $TB)) {
-		$retval = sprintf("%.2fGB", ($size / $GB));
-	} elseif ( $size >= $TB ) {
-		$retval = sprintf("%.2fTB", ($size / $TB));
-	}
-	return $retval;
+        $retval = sprintf("%.2fGB", ($size / $GB));
+    } elseif ( $size >= $TB ) {
+        $retval = sprintf("%.2fTB", ($size / $TB));
+    }
+    return $retval;
 }
 
 
@@ -73,9 +73,9 @@ 
     // SQL output
     // mysql> show table status from [table_name];
     // | Name | Engine | Version | Row_format | Rows
-	// | Avg_row_length | Data_length | Max_data_length
-	// | Index_length | Data_free  | Auto_increment | Create_time
-	// | Update_time | Check_time | Collation | Checksum | Create_options | Comment |
+    // | Avg_row_length | Data_length | Max_data_length
+    // | Index_length | Data_free  | Auto_increment | Create_time
+    // | Update_time | Check_time | Collation | Checksum | Create_options | Comment |
     //
 
     $gdata  = 0;
@@ -83,19 +83,19 @@ 
     $gtotal = 0;
     $grows  = 0;
 
-	$i = 0;
-	$db_rec = array();
-	while ($myarr = _mysql_fetch_assoc($result)) {
+    $i = 0;
+    $db_rec = array();
+    while ($myarr = _mysql_fetch_assoc($result)) {
         if ($myarr['Comment'] == 'VIEW') continue;
 
-		// sum grand totals
-		$total  =  $myarr["Data_length"] + $myarr["Index_length"];
-		$gindex += $myarr["Index_length"];
+        // sum grand totals
+        $total  =  $myarr["Data_length"] + $myarr["Index_length"];
+        $gindex += $myarr["Index_length"];
         $gdata  += $myarr["Data_length"];
-		$grows  += $myarr["Rows"];
-		$gtotal += $total;
+        $grows  += $myarr["Rows"];
+        $gtotal += $total;
 
-	    $db_rec[$i] = new DB_REC(
+        $db_rec[$i] = new DB_REC(
             $myarr["Name"],
             $myarr["Data_length"],
             $myarr["Index_length"],
@@ -103,131 +103,131 @@ 
             $myarr["Rows"],
             $myarr["Avg_row_length"]
         );
-		$i++;
-	}
+        $i++;
+    }
     $db_rec[$i] = new DB_REC ("Total", $gdata, $gindex, $gtotal, $grows, "" );
-	return $db_rec;
+    return $db_rec;
 }
 
 // show the DB structure
 //
 function show_db_info($db_name, $db_rec) {
-	echo "<table cols=6>";
-	echo "<tr>";
-	echo "<th colspan=6> Database $db_name </th>";
-	echo "</tr>";
-
-	echo "<tr>";
-	echo "<th>Table</th>";
-	echo "<th>Data Size</th>";
-	echo "<th>Index Size</th>";
-	echo "<th>Total Size</th>";
-	echo "<th>Total Rows</th>";
-	echo "<th>Avg. Size per Row</th>";
-	echo "</tr>";
-
-	for ($i = 0; $i < sizeof($db_rec)-1; $i++){
-		echo "<tr>";
-		echo "<td align=left valign=top class=fieldname>" . $db_rec[$i]->name . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->data_size)  . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->index_size) . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->total_size) . "</td>";
+    echo "<table cols=6>";
+    echo "<tr>";
+    echo "<th colspan=6> Database $db_name </th>";
+    echo "</tr>";
+
+    echo "<tr>";
+    echo "<th>Table</th>";
+    echo "<th>Data Size</th>";
+    echo "<th>Index Size</th>";
+    echo "<th>Total Size</th>";
+    echo "<th>Total Rows</th>";
+    echo "<th>Avg. Size per Row</th>";
+    echo "</tr>";
+
+    for ($i = 0; $i < sizeof($db_rec)-1; $i++){
+        echo "<tr>";
+        echo "<td align=left valign=top class=fieldname>" . $db_rec[$i]->name . "</td>";
+        echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->data_size)  . "</td>";
+        echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->index_size) . "</td>";
+        echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->total_size) . "</td>";
         echo "<td align=left valign=top class=fieldname>" . number_format($db_rec[$i]->rows)     . "</td>";
         echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->size_per_row) . "</td>";
-		echo "</tr>";
-	}
+        echo "</tr>";
+    }
 
-	// Last record is just a summary
-	$i = sizeof($db_rec)-1;
-	echo "<tr>";
+    // Last record is just a summary
+    $i = sizeof($db_rec)-1;
+    echo "<tr>";
     echo "<th align=left>" . $db_rec[$i]->name . "</th>";
     echo "<th align=left>" . size_format($db_rec[$i]->data_size)  . "</th>";
     echo "<th align=left>" . size_format($db_rec[$i]->index_size) . "</th>";
     echo "<th align=left>" . size_format($db_rec[$i]->total_size) . "</th>";
     echo "<th align=left>" . number_format($db_rec[$i]->rows)     . "</th>";
     echo "<th align=left></th>";
-	echo "</tr>";
+    echo "</tr>";
     echo "</table>";
 }
 
 // same as show_db_info but with sortable columns
 //
 function sort_db_info($db_name, $db_rec) {
-	$file_list = array();
+    $file_list = array();
     $file_sort = array();
 
-	$sort =  get_str("sort", true);
-	$r = get_str("r", true);
-
-	if (empty($sort)) $sort = "name";
-	// check for allowed keys
-	if ((strcmp($sort, "name")!=0) &&
-		(strcmp($sort, "data_size")!=0) &&
-		(strcmp($sort, "index_size")!=0) &&
-		(strcmp($sort, "total_size")!=0)  &&
-		(strcmp($sort, "rows")!=0) &&
-		(strcmp($sort, "size_per_row")!=0)
+    $sort =  get_str("sort", true);
+    $r = get_str("r", true);
+
+    if (empty($sort)) $sort = "name";
+    // check for allowed keys
+    if ((strcmp($sort, "name")!=0) &&
+        (strcmp($sort, "data_size")!=0) &&
+        (strcmp($sort, "index_size")!=0) &&
+        (strcmp($sort, "total_size")!=0)  &&
+        (strcmp($sort, "rows")!=0) &&
+        (strcmp($sort, "size_per_row")!=0)
     ) {
-		$sort = "name";
+        $sort = "name";
     }
-	if (empty($r)) $r=0;
-
-	for ($i=0; $i < sizeof($db_rec)-1; $i++){
-		$file_details["name"]         = $db_rec[$i]->name;
-		$file_details["data_size"]    = $db_rec[$i]->data_size;
-		$file_details["index_size"]   = $db_rec[$i]->index_size;
-		$file_details["total_size"]   = $db_rec[$i]->total_size;
-	    $file_details["rows"]         = $db_rec[$i]->rows;
-		$file_details["size_per_row"] = $db_rec[$i]->size_per_row;
-
-		$file_list[$i] = $file_details;
-		$key = strtolower($file_details[$sort]);
-		$file_sort[$i] = $key;
-	}
-
-	if ($r) {
+    if (empty($r)) $r=0;
+
+    for ($i=0; $i < sizeof($db_rec)-1; $i++){
+        $file_details["name"]         = $db_rec[$i]->name;
+        $file_details["data_size"]    = $db_rec[$i]->data_size;
+        $file_details["index_size"]   = $db_rec[$i]->index_size;
+        $file_details["total_size"]   = $db_rec[$i]->total_size;
+        $file_details["rows"]         = $db_rec[$i]->rows;
+        $file_details["size_per_row"] = $db_rec[$i]->size_per_row;
+
+        $file_list[$i] = $file_details;
+        $key = strtolower($file_details[$sort]);
+        $file_sort[$i] = $key;
+    }
+
+    if ($r) {
         arsort($file_sort);
     } else {
         asort($file_sort);
     }
 
-	echo "<table cols=6>";
-	echo "<tr>";
-	echo "<th colspan=6> Database $db_name </th>";
-	echo "</tr>";
+    echo "<table cols=6>";
+    echo "<tr>";
+    echo "<th colspan=6> Database $db_name </th>";
+    echo "</tr>";
 
-	echo "<tr>";
-	echo "<th><a href='dbinfo.php?sort=name&r=" . (!$r) . "'>Table </a></th>";
-	echo "<th><a href='dbinfo.php?sort=data_size&r=" . (!$r) . "'>Data Size</a></th>";
-	echo "<th><a href='dbinfo.php?sort=index_size&r=" . (!$r) . "'>Index Size</a></th>";
-	echo "<th><a href='dbinfo.php?sort=total_size&r=" . (!$r) . "'>Total Size</a></th>";
-	echo "<th><a href='dbinfo.php?sort=rows&r=" . (!$r) . "'>Total Rows</a></th>";
-	echo "<th><a href='dbinfo.php?sort=size_per_row&r=" . (!$r) . "'>Avg. Size per Row</a></th>";
-	echo "</tr>";
+    echo "<tr>";
+    echo "<th><a href='dbinfo.php?sort=name&r=" . (!$r) . "'>Table </a></th>";
+    echo "<th><a href='dbinfo.php?sort=data_size&r=" . (!$r) . "'>Data Size</a></th>";
+    echo "<th><a href='dbinfo.php?sort=index_size&r=" . (!$r) . "'>Index Size</a></th>";
+    echo "<th><a href='dbinfo.php?sort=total_size&r=" . (!$r) . "'>Total Size</a></th>";
+    echo "<th><a href='dbinfo.php?sort=rows&r=" . (!$r) . "'>Total Rows</a></th>";
+    echo "<th><a href='dbinfo.php?sort=size_per_row&r=" . (!$r) . "'>Avg. Size per Row</a></th>";
+    echo "</tr>";
 
     foreach ($file_sort as $key=>$value) {
-		$value = $file_list[$key];
+        $value = $file_list[$key];
 
-		echo "<tr>";
-		echo "<td align=left valign=top class=fieldname>" . $value["name"] . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($value["data_size"])  . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($value["index_size"]) . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($value["total_size"]) . "</td>";
+        echo "<tr>";
+        echo "<td align=left valign=top class=fieldname>" . $value["name"] . "</td>";
+        echo "<td align=left valign=top class=fieldname>" . size_format($value["data_size"])  . "</td>";
+        echo "<td align=left valign=top class=fieldname>" . size_format($value["index_size"]) . "</td>";
+        echo "<td align=left valign=top class=fieldname>" . size_format($value["total_size"]) . "</td>";
         echo "<td align=left valign=top class=fieldname>" . number_format($value["rows"])     . "</td>";
         echo "<td align=left valign=top class=fieldname>" . size_format($value["size_per_row"]) . "</td>";
-		echo "</tr>";
-	}
+        echo "</tr>";
+    }
 
-	// Last record is a summary
-	$i = sizeof($db_rec)-1;
-	echo "<tr>";
+    // Last record is a summary
+    $i = sizeof($db_rec)-1;
+    echo "<tr>";
     echo "<th align=left>" . $db_rec[$i]->name . "</th>";
     echo "<th align=left>" . size_format($db_rec[$i]->data_size)  . "</th>";
     echo "<th align=left>" . size_format($db_rec[$i]->index_size) . "</th>";
     echo "<th align=left>" . size_format($db_rec[$i]->total_size) . "</th>";
     echo "<th align=left>" . number_format($db_rec[$i]->rows)     . "</th>";
     echo "<th align=left></th>";
-	echo "</tr>";
+    echo "</tr>";
 
     echo "</table>";
 }

Spacing +52 added lines, -52 removed lines

@@ -41,7 +41,7 @@ 
 
 
 // returns formatted data size
-function size_format($size){
+function size_format($size) {
 	$retval = 0;
 
 	$KB = 1024;
@@ -52,13 +52,13 @@ 
     if ($size < $KB) {
 	    $retval = $size;
     } elseif (($size > $KB) && ($size < $MB)) {
-		$retval = sprintf("%.0fK", ($size / $KB));
-    } elseif ( ($size >= $MB) && ($size < $GB)) {
-		$retval = sprintf("%.2fMB", ($size / $MB));
-    } elseif ( ($size >= $GB) && ($size < $TB)) {
-		$retval = sprintf("%.2fGB", ($size / $GB));
-	} elseif ( $size >= $TB ) {
-		$retval = sprintf("%.2fTB", ($size / $TB));
+		$retval = sprintf("%.0fK", ($size/$KB));
+    } elseif (($size >= $MB) && ($size < $GB)) {
+		$retval = sprintf("%.2fMB", ($size/$MB));
+    } elseif (($size >= $GB) && ($size < $TB)) {
+		$retval = sprintf("%.2fGB", ($size/$GB));
+	} elseif ($size >= $TB) {
+		$retval = sprintf("%.2fTB", ($size/$TB));
 	}
 	return $retval;
 }
@@ -89,9 +89,9 @@ 
         if ($myarr['Comment'] == 'VIEW') continue;
 
 		// sum grand totals
-		$total  =  $myarr["Data_length"] + $myarr["Index_length"];
+		$total = $myarr["Data_length"] + $myarr["Index_length"];
 		$gindex += $myarr["Index_length"];
-        $gdata  += $myarr["Data_length"];
+        $gdata += $myarr["Data_length"];
 		$grows  += $myarr["Rows"];
 		$gtotal += $total;
 
@@ -105,7 +105,7 @@ 
         );
 		$i++;
 	}
-    $db_rec[$i] = new DB_REC ("Total", $gdata, $gindex, $gtotal, $grows, "" );
+    $db_rec[$i] = new DB_REC("Total", $gdata, $gindex, $gtotal, $grows, "");
 	return $db_rec;
 }
 
@@ -126,25 +126,25 @@ 
 	echo "<th>Avg. Size per Row</th>";
 	echo "</tr>";
 
-	for ($i = 0; $i < sizeof($db_rec)-1; $i++){
+	for ($i = 0; $i < sizeof($db_rec) - 1; $i++) {
 		echo "<tr>";
-		echo "<td align=left valign=top class=fieldname>" . $db_rec[$i]->name . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->data_size)  . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->index_size) . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->total_size) . "</td>";
-        echo "<td align=left valign=top class=fieldname>" . number_format($db_rec[$i]->rows)     . "</td>";
-        echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->size_per_row) . "</td>";
+		echo "<td align=left valign=top class=fieldname>".$db_rec[$i]->name."</td>";
+		echo "<td align=left valign=top class=fieldname>".size_format($db_rec[$i]->data_size)."</td>";
+		echo "<td align=left valign=top class=fieldname>".size_format($db_rec[$i]->index_size)."</td>";
+		echo "<td align=left valign=top class=fieldname>".size_format($db_rec[$i]->total_size)."</td>";
+        echo "<td align=left valign=top class=fieldname>".number_format($db_rec[$i]->rows)."</td>";
+        echo "<td align=left valign=top class=fieldname>".size_format($db_rec[$i]->size_per_row)."</td>";
 		echo "</tr>";
 	}
 
 	// Last record is just a summary
-	$i = sizeof($db_rec)-1;
+	$i = sizeof($db_rec) - 1;
 	echo "<tr>";
-    echo "<th align=left>" . $db_rec[$i]->name . "</th>";
-    echo "<th align=left>" . size_format($db_rec[$i]->data_size)  . "</th>";
-    echo "<th align=left>" . size_format($db_rec[$i]->index_size) . "</th>";
-    echo "<th align=left>" . size_format($db_rec[$i]->total_size) . "</th>";
-    echo "<th align=left>" . number_format($db_rec[$i]->rows)     . "</th>";
+    echo "<th align=left>".$db_rec[$i]->name."</th>";
+    echo "<th align=left>".size_format($db_rec[$i]->data_size)."</th>";
+    echo "<th align=left>".size_format($db_rec[$i]->index_size)."</th>";
+    echo "<th align=left>".size_format($db_rec[$i]->total_size)."</th>";
+    echo "<th align=left>".number_format($db_rec[$i]->rows)."</th>";
     echo "<th align=left></th>";
 	echo "</tr>";
     echo "</table>";
@@ -156,28 +156,28 @@ 
 	$file_list = array();
     $file_sort = array();
 
-	$sort =  get_str("sort", true);
+	$sort = get_str("sort", true);
 	$r = get_str("r", true);
 
 	if (empty($sort)) $sort = "name";
 	// check for allowed keys
-	if ((strcmp($sort, "name")!=0) &&
-		(strcmp($sort, "data_size")!=0) &&
-		(strcmp($sort, "index_size")!=0) &&
-		(strcmp($sort, "total_size")!=0)  &&
-		(strcmp($sort, "rows")!=0) &&
-		(strcmp($sort, "size_per_row")!=0)
+	if ((strcmp($sort, "name") != 0) &&
+		(strcmp($sort, "data_size") != 0) &&
+		(strcmp($sort, "index_size") != 0) &&
+		(strcmp($sort, "total_size") != 0) &&
+		(strcmp($sort, "rows") != 0) &&
+		(strcmp($sort, "size_per_row") != 0)
     ) {
 		$sort = "name";
     }
-	if (empty($r)) $r=0;
+	if (empty($r)) $r = 0;
 
-	for ($i=0; $i < sizeof($db_rec)-1; $i++){
+	for ($i = 0; $i < sizeof($db_rec) - 1; $i++) {
 		$file_details["name"]         = $db_rec[$i]->name;
 		$file_details["data_size"]    = $db_rec[$i]->data_size;
 		$file_details["index_size"]   = $db_rec[$i]->index_size;
 		$file_details["total_size"]   = $db_rec[$i]->total_size;
-	    $file_details["rows"]         = $db_rec[$i]->rows;
+	    $file_details["rows"] = $db_rec[$i]->rows;
 		$file_details["size_per_row"] = $db_rec[$i]->size_per_row;
 
 		$file_list[$i] = $file_details;
@@ -197,35 +197,35 @@ 
 	echo "</tr>";
 
 	echo "<tr>";
-	echo "<th><a href='dbinfo.php?sort=name&r=" . (!$r) . "'>Table </a></th>";
-	echo "<th><a href='dbinfo.php?sort=data_size&r=" . (!$r) . "'>Data Size</a></th>";
-	echo "<th><a href='dbinfo.php?sort=index_size&r=" . (!$r) . "'>Index Size</a></th>";
-	echo "<th><a href='dbinfo.php?sort=total_size&r=" . (!$r) . "'>Total Size</a></th>";
-	echo "<th><a href='dbinfo.php?sort=rows&r=" . (!$r) . "'>Total Rows</a></th>";
-	echo "<th><a href='dbinfo.php?sort=size_per_row&r=" . (!$r) . "'>Avg. Size per Row</a></th>";
+	echo "<th><a href='dbinfo.php?sort=name&r=".(!$r)."'>Table </a></th>";
+	echo "<th><a href='dbinfo.php?sort=data_size&r=".(!$r)."'>Data Size</a></th>";
+	echo "<th><a href='dbinfo.php?sort=index_size&r=".(!$r)."'>Index Size</a></th>";
+	echo "<th><a href='dbinfo.php?sort=total_size&r=".(!$r)."'>Total Size</a></th>";
+	echo "<th><a href='dbinfo.php?sort=rows&r=".(!$r)."'>Total Rows</a></th>";
+	echo "<th><a href='dbinfo.php?sort=size_per_row&r=".(!$r)."'>Avg. Size per Row</a></th>";
 	echo "</tr>";
 
     foreach ($file_sort as $key=>$value) {
 		$value = $file_list[$key];
 
 		echo "<tr>";
-		echo "<td align=left valign=top class=fieldname>" . $value["name"] . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($value["data_size"])  . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($value["index_size"]) . "</td>";
-		echo "<td align=left valign=top class=fieldname>" . size_format($value["total_size"]) . "</td>";
-        echo "<td align=left valign=top class=fieldname>" . number_format($value["rows"])     . "</td>";
-        echo "<td align=left valign=top class=fieldname>" . size_format($value["size_per_row"]) . "</td>";
+		echo "<td align=left valign=top class=fieldname>".$value["name"]."</td>";
+		echo "<td align=left valign=top class=fieldname>".size_format($value["data_size"])."</td>";
+		echo "<td align=left valign=top class=fieldname>".size_format($value["index_size"])."</td>";
+		echo "<td align=left valign=top class=fieldname>".size_format($value["total_size"])."</td>";
+        echo "<td align=left valign=top class=fieldname>".number_format($value["rows"])."</td>";
+        echo "<td align=left valign=top class=fieldname>".size_format($value["size_per_row"])."</td>";
 		echo "</tr>";
 	}
 
 	// Last record is a summary
-	$i = sizeof($db_rec)-1;
+	$i = sizeof($db_rec) - 1;
 	echo "<tr>";
-    echo "<th align=left>" . $db_rec[$i]->name . "</th>";
-    echo "<th align=left>" . size_format($db_rec[$i]->data_size)  . "</th>";
-    echo "<th align=left>" . size_format($db_rec[$i]->index_size) . "</th>";
-    echo "<th align=left>" . size_format($db_rec[$i]->total_size) . "</th>";
-    echo "<th align=left>" . number_format($db_rec[$i]->rows)     . "</th>";
+    echo "<th align=left>".$db_rec[$i]->name."</th>";
+    echo "<th align=left>".size_format($db_rec[$i]->data_size)."</th>";
+    echo "<th align=left>".size_format($db_rec[$i]->index_size)."</th>";
+    echo "<th align=left>".size_format($db_rec[$i]->total_size)."</th>";
+    echo "<th align=left>".number_format($db_rec[$i]->rows)."</th>";
     echo "<th align=left></th>";
 	echo "</tr>";
 

Braces +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
 
 
 // returns formatted data size
-function size_format($size){
+function size_format($size) {
 	$retval = 0;
 
 	$KB = 1024;
@@ -126,7 +126,7 @@ 
 	echo "<th>Avg. Size per Row</th>";
 	echo "</tr>";
 
-	for ($i = 0; $i < sizeof($db_rec)-1; $i++){
+	for ($i = 0; $i < sizeof($db_rec)-1; $i++) {
 		echo "<tr>";
 		echo "<td align=left valign=top class=fieldname>" . $db_rec[$i]->name . "</td>";
 		echo "<td align=left valign=top class=fieldname>" . size_format($db_rec[$i]->data_size)  . "</td>";
@@ -172,7 +172,7 @@ 
     }
 	if (empty($r)) $r=0;
 
-	for ($i=0; $i < sizeof($db_rec)-1; $i++){
+	for ($i=0; $i < sizeof($db_rec)-1; $i++) {
 		$file_details["name"]         = $db_rec[$i]->name;
 		$file_details["data_size"]    = $db_rec[$i]->data_size;
 		$file_details["index_size"]   = $db_rec[$i]->index_size;

html/inc/common_defs.inc

Spacing +57 added lines, -57 removed lines

@@ -27,74 +27,74 @@
 define('BATCH_STATE_RETIRED', 4);
 
 define('ANON_PLATFORM_UNKNOWN', -1);
-define('ANON_PLATFORM_CPU',     -2);
-define('ANON_PLATFORM_NVIDIA',  -3);
-define('ANON_PLATFORM_ATI',     -4);
-define('ANON_PLATFORM_INTEL_GPU',   -5);
-define('ANON_PLATFORM_APPLE_GPU',   -6);
+define('ANON_PLATFORM_CPU', -2);
+define('ANON_PLATFORM_NVIDIA', -3);
+define('ANON_PLATFORM_ATI', -4);
+define('ANON_PLATFORM_INTEL_GPU', -5);
+define('ANON_PLATFORM_APPLE_GPU', -6);
 
-define('RESULT_SERVER_STATE_INACTIVE',       1);
-define('RESULT_SERVER_STATE_UNSENT',         2);
-define('RESULT_SERVER_STATE_IN_PROGRESS',    4);
-define('RESULT_SERVER_STATE_OVER',           5);
+define('RESULT_SERVER_STATE_INACTIVE', 1);
+define('RESULT_SERVER_STATE_UNSENT', 2);
+define('RESULT_SERVER_STATE_IN_PROGRESS', 4);
+define('RESULT_SERVER_STATE_OVER', 5);
 
-define('RESULT_OUTCOME_INIT',             0);
-define('RESULT_OUTCOME_SUCCESS',          1);
-define('RESULT_OUTCOME_COULDNT_SEND',     2);
-define('RESULT_OUTCOME_CLIENT_ERROR',     3);
-define('RESULT_OUTCOME_NO_REPLY',         4);
-define('RESULT_OUTCOME_DIDNT_NEED',       5);
-define('RESULT_OUTCOME_VALIDATE_ERROR',   6);
-define('RESULT_OUTCOME_CLIENT_DETACHED',  7);
+define('RESULT_OUTCOME_INIT', 0);
+define('RESULT_OUTCOME_SUCCESS', 1);
+define('RESULT_OUTCOME_COULDNT_SEND', 2);
+define('RESULT_OUTCOME_CLIENT_ERROR', 3);
+define('RESULT_OUTCOME_NO_REPLY', 4);
+define('RESULT_OUTCOME_DIDNT_NEED', 5);
+define('RESULT_OUTCOME_VALIDATE_ERROR', 6);
+define('RESULT_OUTCOME_CLIENT_DETACHED', 7);
 
-define('VALIDATE_STATE_INIT',        0);
-define('VALIDATE_STATE_VALID',       1);
-define('VALIDATE_STATE_INVALID',     2);
-define('VALIDATE_STATE_NO_CHECK',    3);
-define('VALIDATE_STATE_INCONCLUSIVE',4);
-define('VALIDATE_STATE_TOO_LATE',    5);
+define('VALIDATE_STATE_INIT', 0);
+define('VALIDATE_STATE_VALID', 1);
+define('VALIDATE_STATE_INVALID', 2);
+define('VALIDATE_STATE_NO_CHECK', 3);
+define('VALIDATE_STATE_INCONCLUSIVE', 4);
+define('VALIDATE_STATE_TOO_LATE', 5);
 
-define('WU_ERROR_COULDNT_SEND_RESULT',           1);
-define('WU_ERROR_TOO_MANY_ERROR_RESULTS',        2);
-define('WU_ERROR_TOO_MANY_SUCCESS_RESULTS',      4);
-define('WU_ERROR_TOO_MANY_TOTAL_RESULTS',        8);
-define('WU_ERROR_CANCELLED',                     16);
-define('WU_ERROR_NO_CANONICAL_RESULT',           32);
+define('WU_ERROR_COULDNT_SEND_RESULT', 1);
+define('WU_ERROR_TOO_MANY_ERROR_RESULTS', 2);
+define('WU_ERROR_TOO_MANY_SUCCESS_RESULTS', 4);
+define('WU_ERROR_TOO_MANY_TOTAL_RESULTS', 8);
+define('WU_ERROR_CANCELLED', 16);
+define('WU_ERROR_NO_CANONICAL_RESULT', 32);
 
-define('FILE_DELETE_INIT',       0);
-define('FILE_DELETE_READY',      1);
-define('FILE_DELETE_DONE',       2);
-define('FILE_DELETE_ERROR',      3);
+define('FILE_DELETE_INIT', 0);
+define('FILE_DELETE_READY', 1);
+define('FILE_DELETE_DONE', 2);
+define('FILE_DELETE_ERROR', 3);
 
-define('ASSIMILATE_INIT',       0);
-define('ASSIMILATE_READY',      1);
-define('ASSIMILATE_DONE',       2);
+define('ASSIMILATE_INIT', 0);
+define('ASSIMILATE_READY', 1);
+define('ASSIMILATE_DONE', 2);
 
 // from lib/common_defs.h
 //
-define('RESULT_NEW',                 0);
-define('RESULT_FILES_DOWNLOADING',   1);
-define('RESULT_FILES_DOWNLOADED',    2);
-define('RESULT_COMPUTE_ERROR',       3);
-define('RESULT_FILES_UPLOADING',     4);
-define('RESULT_FILES_UPLOADED',      5);
-define('RESULT_ABORTED',             6);
-define('RESULT_UPLOAD_FAILED',       7);
+define('RESULT_NEW', 0);
+define('RESULT_FILES_DOWNLOADING', 1);
+define('RESULT_FILES_DOWNLOADED', 2);
+define('RESULT_COMPUTE_ERROR', 3);
+define('RESULT_FILES_UPLOADING', 4);
+define('RESULT_FILES_UPLOADED', 5);
+define('RESULT_ABORTED', 6);
+define('RESULT_UPLOAD_FAILED', 7);
 
 // from lib/error_numbers.h
 // returned by some web RPCs
 //
-define('ERR_XML_PARSE',               -112);
-define('ERR_DB_NOT_FOUND',            -136);
-define('ERR_DB_NOT_UNIQUE',           -137);
-define('ERR_DB_CANT_CONNECT',         -138);
-define('ERR_PROJECT_DOWN',            -183);
-define('ERR_BAD_USER_NAME',           -188);
-define('ERR_NO_OPTION',               -191);
-define('ERR_BAD_EMAIL_ADDR',          -205);
-define('ERR_BAD_PASSWD',              -206);
-define('ERR_ACCT_CREATION_DISABLED',  -208);
-define('ERR_ATTACH_FAIL_INIT',        -209);
-define('ERR_ATTACH_FAIL_DOWNLOAD',    -210);
-define('ERR_ACCT_REQUIRE_CONSENT',    -242);
+define('ERR_XML_PARSE', -112);
+define('ERR_DB_NOT_FOUND', -136);
+define('ERR_DB_NOT_UNIQUE', -137);
+define('ERR_DB_CANT_CONNECT', -138);
+define('ERR_PROJECT_DOWN', -183);
+define('ERR_BAD_USER_NAME', -188);
+define('ERR_NO_OPTION', -191);
+define('ERR_BAD_EMAIL_ADDR', -205);
+define('ERR_BAD_PASSWD', -206);
+define('ERR_ACCT_CREATION_DISABLED', -208);
+define('ERR_ATTACH_FAIL_INIT', -209);
+define('ERR_ATTACH_FAIL_DOWNLOAD', -210);
+define('ERR_ACCT_REQUIRE_CONSENT', -242);
 ?>

html/user/gpu_ratios.php

Spacing +6 added lines, -6 removed lines

@@ -34,26 +34,26 @@
 $intel_gpu_credit_sum = 0;
 $apple_gpu_scale_sum = 0;
 $apple_gpu_credit_sum = 0;
-$total_credit_sum= 0;
+$total_credit_sum = 0;
 
 $apps = BoincApp::enum("deprecated=0");
 foreach ($apps as $app) {
     $avs = BoincAppVersion::enum("appid=$app->id and deprecated=0");
     foreach ($avs as $av) {
         if (strstr($av->plan_class, "ati")) {
-            $ati_scale_sum += $av->pfc_scale * $av->expavg_credit;
+            $ati_scale_sum += $av->pfc_scale*$av->expavg_credit;
             $ati_credit_sum += $av->expavg_credit;
         } else if (strstr($av->plan_class, "nvidia") || strstr($av->plan_class, "cuda")) {
-            $nvidia_scale_sum += $av->pfc_scale * $av->expavg_credit;
+            $nvidia_scale_sum += $av->pfc_scale*$av->expavg_credit;
             $nvidia_credit_sum += $av->expavg_credit;
         } else if (strstr($av->plan_class, "intel_gpu")) {
-            $intel_gpu_scale_sum += $av->pfc_scale * $av->expavg_credit;
+            $intel_gpu_scale_sum += $av->pfc_scale*$av->expavg_credit;
             $intel_gpu_credit_sum += $av->expavg_credit;
         } else if (strstr($av->plan_class, "apple_gpu")) {
-            $apple_gpu_scale_sum += $av->pfc_scale * $av->expavg_credit;
+            $apple_gpu_scale_sum += $av->pfc_scale*$av->expavg_credit;
             $apple_gpu_credit_sum += $av->expavg_credit;
         } else {
-            $cpu_scale_sum += $av->pfc_scale * $av->expavg_credit;
+            $cpu_scale_sum += $av->pfc_scale*$av->expavg_credit;
             $cpu_credit_sum += $av->expavg_credit;
         }
         $total_credit_sum += $av->expavg_credit;

html/inc/user_util.inc

Braces +1 added lines, -1 removed lines

@@ -242,7 +242,7 @@
             $users = BoincUser::enum(
                 sprintf("name like '%s%%'", $new_name)
             );
-            foreach ($users as $u){
+            foreach ($users as $u) {
                 echo "<p>$u->name\n";
             }
             page_tail();

Spacing +5 added lines, -5 removed lines

@@ -57,7 +57,7 @@ 
 
 function check_passwd_ui($user, $passwd) {
     $passwd_hash = md5($passwd.$user->email_addr);
-    if(!check_passwd_hash($user, $passwd_hash)) {
+    if (!check_passwd_hash($user, $passwd_hash)) {
         sleep(LOGIN_FAIL_SLEEP_SEC);
         page_head("Password incorrect");
         echo "The password you entered is incorrect. Please go back and try again.\n";
@@ -69,7 +69,7 @@ 
 function is_banned_email_addr($email_addr) {
     global $banned_email_domains;
     if (isset($banned_email_domains)) {
-        foreach($banned_email_domains as $d) {
+        foreach ($banned_email_domains as $d) {
             $x = strstr($email_addr, $d);
             if ($x == $d) return true;
         }
@@ -108,7 +108,7 @@ 
 //
 function make_user(
     $email_addr, $name, $passwd_hash,
-    $country=null, $postal_code=null, $project_prefs=null, $teamid=0
+    $country = null, $postal_code = null, $project_prefs = null, $teamid = 0
 ) {
     if (!is_valid_email_syntax($email_addr)) return null;
         // caller generally has already checked
@@ -243,7 +243,7 @@ 
             $users = BoincUser::enum(
                 sprintf("name like '%s%%'", $new_name)
             );
-            foreach ($users as $u){
+            foreach ($users as $u) {
                 echo "<p>$u->name\n";
             }
             page_tail();
@@ -278,7 +278,7 @@ 
         show_error(tra("Passwords may only include ASCII characters."));
     }
 
-    if (strlen($passwd)<$min_passwd_length) {
+    if (strlen($passwd) < $min_passwd_length) {
         show_error(
             tra("New password is too short: minimum password length is %1 characters.", $min_passwd_length)
         );

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -193,14 +193,14 @@ 
 
     // Check if consent to terms of use has been given.
     //
-    $myconsent = FALSE;
+    $myconsent = false;
     list($checkct, $ctid) = check_consent_type(CONSENT_TYPE_ENROLL);
     if ($checkct and check_termsofuse()) {
         $agree = post_str("agree_to_terms_of_use", true);
         if (!$agree) {
             error_page(tra("You have not agreed to our terms of use. Please agree to the terms of use by navigating back to the previous page, in order to create your account"));
         }
-        $myconsent = TRUE;
+        $myconsent = true;
     }
 
     // see whether the new account should be pre-enrolled in a team,
@@ -211,7 +211,7 @@ 
         $team = BoincTeam::lookup_id($teamid);
         $clone_user = BoincUser::lookup_id($team->userid);
         if (!$clone_user) {
-            error_page("User $team->userid not found");
+            error_page("user $team->userid not found");
         }
         $project_prefs = $clone_user->project_prefs;
     } else {

html/user/edit_forum_preferences_action.php

Spacing +29 added lines, -29 removed lines

@@ -29,7 +29,7 @@ 
 }
 BoincForumPrefs::lookup($user);
 
-if (post_str("action", true)=="reset_confirm"){
+if (post_str("action", true) == "reset_confirm") {
     page_head(tra("Confirm reset"));
     echo tra("This action will erase any changes you have made in your community preferences. To cancel, click your browser's Back button.")."
         <p>
@@ -45,7 +45,7 @@ 
 // If the user has requested a reset of preferences;
 // preserve a few fields.
 //
-if (post_str("action", true)=="reset"){
+if (post_str("action", true) == "reset") {
     $posts = $user->prefs->posts;
     $last_post = $user->prefs->last_post;
     $rated_posts = $user->prefs->rated_posts;
@@ -67,30 +67,30 @@ 
 if (!DISABLE_FORUMS) {
 
 $avatar_type = post_int("avatar_select");
-$newfile=IMAGE_PATH.$user->id."_avatar.jpg";
+$newfile = IMAGE_PATH.$user->id."_avatar.jpg";
 
 // Update the user avatar
-if ($avatar_type<0 or $avatar_type>3) $avatar_type=0;
-if ($avatar_type==0){
-    if (file_exists($newfile)){
+if ($avatar_type < 0 or $avatar_type > 3) $avatar_type = 0;
+if ($avatar_type == 0) {
+    if (file_exists($newfile)) {
         // Delete the file on the server if the user
         // decides not to use an avatar
         //
         unlink($newfile);
     }
-    $avatar_url="";
+    $avatar_url = "";
 } elseif ($avatar_type == 1) {
     $avatar_url = "//www.gravatar.com/avatar/".md5($user->email_addr)."?s=100&amp;d=identicon";
-} elseif ($avatar_type==2){
-    if (($rpc && (post_str("avatar_url", true) != null)) || ($_FILES['picture']['tmp_name']!="")) {
-        if ($_FILES['picture']['tmp_name']!="") {
+} elseif ($avatar_type == 2) {
+    if (($rpc && (post_str("avatar_url", true) != null)) || ($_FILES['picture']['tmp_name'] != "")) {
+        if ($_FILES['picture']['tmp_name'] != "") {
             $file = $_FILES['picture']['tmp_name'];
         } else {
             // Remote image. Download and store locally
             $file = post_str("avatar_url");
         }
         $size = getImageSize($file);
-        if ($size[2]!=2 and $size[2]!=3){
+        if ($size[2] != 2 and $size[2] != 3) {
             //Not the right kind of file
             error_page(tra("Error: Not the right kind of file, only PNG and JPEG are supported."));
         }
@@ -99,30 +99,30 @@ 
         $image2 = intelligently_scale_image($file, 100, 100);
         ImageJPEG($image2, $newfile);
     }
-    if (file_exists($newfile)){
-        $avatar_url=IMAGE_URL.$user->id."_avatar.jpg"; //$newfile;
+    if (file_exists($newfile)) {
+        $avatar_url = IMAGE_URL.$user->id."_avatar.jpg"; //$newfile;
     } else {
         //User didn't upload a compatible file or it went lost on the server
-        $avatar_url="";
+        $avatar_url = "";
     }
 }
 
-$images_as_links = (isset($_POST["forum_images_as_links"]) && $_POST["forum_images_as_links"]!="")?1:0;
-$link_popup = (isset($_POST["forum_link_popup"]) && $_POST["forum_link_popup"]!="")?1:0;
-$hide_avatars = (isset($_POST["forum_hide_avatars"]) && $_POST["forum_hide_avatars"]!="")?1:0;
-$hide_signatures = (isset($_POST["forum_hide_signatures"]) && $_POST["forum_hide_signatures"]!="")?1:0;
-$highlight_special = (isset($_POST["forum_highlight_special"]) && $_POST["forum_highlight_special"]!="")?1:0;
-$jump_to_unread = (isset($_POST["forum_jump_to_unread"]) && $_POST["forum_jump_to_unread"]!="")?1:0;
-$ignore_sticky_posts = (isset($_POST["forum_ignore_sticky_posts"]) && $_POST["forum_ignore_sticky_posts"]!="")?1:0;
-$no_signature_by_default = (isset($_POST["signature_by_default"]) && $_POST["signature_by_default"]!="")?0:1;
+$images_as_links = (isset($_POST["forum_images_as_links"]) && $_POST["forum_images_as_links"] != "") ? 1 : 0;
+$link_popup = (isset($_POST["forum_link_popup"]) && $_POST["forum_link_popup"] != "") ? 1 : 0;
+$hide_avatars = (isset($_POST["forum_hide_avatars"]) && $_POST["forum_hide_avatars"] != "") ? 1 : 0;
+$hide_signatures = (isset($_POST["forum_hide_signatures"]) && $_POST["forum_hide_signatures"] != "") ? 1 : 0;
+$highlight_special = (isset($_POST["forum_highlight_special"]) && $_POST["forum_highlight_special"] != "") ? 1 : 0;
+$jump_to_unread = (isset($_POST["forum_jump_to_unread"]) && $_POST["forum_jump_to_unread"] != "") ? 1 : 0;
+$ignore_sticky_posts = (isset($_POST["forum_ignore_sticky_posts"]) && $_POST["forum_ignore_sticky_posts"] != "") ? 1 : 0;
+$no_signature_by_default = (isset($_POST["signature_by_default"]) && $_POST["signature_by_default"] != "") ? 0 : 1;
 $signature = post_str("signature", true);
-if (strlen($signature)>250) {
+if (strlen($signature) > 250) {
     error_page(tra("Your signature was too long, please keep it less than 250 characters."));
 }
 $forum_sort = post_int("forum_sort");
 $thread_sort = post_int("thread_sort");
 $display_wrap_postcount = post_int("forum_display_wrap_postcount");
-if ($display_wrap_postcount<1) $display_wrap_postcount=1;
+if ($display_wrap_postcount < 1) $display_wrap_postcount = 1;
 
 $signature = BoincDb::escape_string($signature);
 
@@ -141,10 +141,10 @@ 
     }
 } else {
     // todo: clean up the following
-    $add_user_to_filter = (isset($_POST["add_user_to_filter"]) && $_POST["add_user_to_filter"]!="");
-    if ($add_user_to_filter){
+    $add_user_to_filter = (isset($_POST["add_user_to_filter"]) && $_POST["add_user_to_filter"] != "");
+    if ($add_user_to_filter) {
         $user_to_add = trim($_POST["forum_filter_user"]);
-        if ($user_to_add!="" and $user_to_add==strval(intval($user_to_add))){
+        if ($user_to_add != "" and $user_to_add == strval(intval($user_to_add))) {
             $other_user = BoincUser::lookup_id($user_to_add);
             if (!$other_user) {
                 echo tra("No such user:")." ".$user_to_add;
@@ -159,9 +159,9 @@ 
 //
 $ignored_users = get_ignored_list($user);
 // todo: use foreach
-for ($i=0;$i<sizeof($ignored_users);$i++){
+for ($i = 0; $i < sizeof($ignored_users); $i++) {
     $remove = "remove".trim($ignored_users[$i]);
-    if (isset($_POST[$remove]) && $_POST[$remove]!=""){
+    if (isset($_POST[$remove]) && $_POST[$remove] != "") {
         $other_user = BoincUser::lookup_id($ignored_users[$i]);
         if (!$other_user) {
             echo tra("No such user:")." ".$ignored_users[$j];

Braces +11 added lines, -11 removed lines

@@ -29,7 +29,7 @@ 
 }
 BoincForumPrefs::lookup($user);
 
-if (post_str("action", true)=="reset_confirm"){
+if (post_str("action", true)=="reset_confirm") {
     page_head(tra("Confirm reset"));
     echo tra("This action will erase any changes you have made in your community preferences. To cancel, click your browser's Back button.")."
         <p>
@@ -45,7 +45,7 @@ 
 // If the user has requested a reset of preferences;
 // preserve a few fields.
 //
-if (post_str("action", true)=="reset"){
+if (post_str("action", true)=="reset") {
     $posts = $user->prefs->posts;
     $last_post = $user->prefs->last_post;
     $rated_posts = $user->prefs->rated_posts;
@@ -71,8 +71,8 @@ 
 
 // Update the user avatar
 if ($avatar_type<0 or $avatar_type>3) $avatar_type=0;
-if ($avatar_type==0){
-    if (file_exists($newfile)){
+if ($avatar_type==0) {
+    if (file_exists($newfile)) {
         // Delete the file on the server if the user
         // decides not to use an avatar
         //
@@ -81,7 +81,7 @@ 
     $avatar_url="";
 } elseif ($avatar_type == 1) {
     $avatar_url = "//www.gravatar.com/avatar/".md5($user->email_addr)."?s=100&amp;d=identicon";
-} elseif ($avatar_type==2){
+} elseif ($avatar_type==2) {
     if (($rpc && (post_str("avatar_url", true) != null)) || ($_FILES['picture']['tmp_name']!="")) {
         if ($_FILES['picture']['tmp_name']!="") {
             $file = $_FILES['picture']['tmp_name'];
@@ -90,7 +90,7 @@ 
             $file = post_str("avatar_url");
         }
         $size = getImageSize($file);
-        if ($size[2]!=2 and $size[2]!=3){
+        if ($size[2]!=2 and $size[2]!=3) {
             //Not the right kind of file
             error_page(tra("Error: Not the right kind of file, only PNG and JPEG are supported."));
         }
@@ -99,7 +99,7 @@ 
         $image2 = intelligently_scale_image($file, 100, 100);
         ImageJPEG($image2, $newfile);
     }
-    if (file_exists($newfile)){
+    if (file_exists($newfile)) {
         $avatar_url=IMAGE_URL.$user->id."_avatar.jpg"; //$newfile;
     } else {
         //User didn't upload a compatible file or it went lost on the server
@@ -142,9 +142,9 @@ 
 } else {
     // todo: clean up the following
     $add_user_to_filter = (isset($_POST["add_user_to_filter"]) && $_POST["add_user_to_filter"]!="");
-    if ($add_user_to_filter){
+    if ($add_user_to_filter) {
         $user_to_add = trim($_POST["forum_filter_user"]);
-        if ($user_to_add!="" and $user_to_add==strval(intval($user_to_add))){
+        if ($user_to_add!="" and $user_to_add==strval(intval($user_to_add))) {
             $other_user = BoincUser::lookup_id($user_to_add);
             if (!$other_user) {
                 echo tra("No such user:")." ".$user_to_add;
@@ -159,9 +159,9 @@ 
 //
 $ignored_users = get_ignored_list($user);
 // todo: use foreach
-for ($i=0;$i<sizeof($ignored_users);$i++){
+for ($i=0;$i<sizeof($ignored_users);$i++) {
     $remove = "remove".trim($ignored_users[$i]);
-    if (isset($_POST[$remove]) && $_POST[$remove]!=""){
+    if (isset($_POST[$remove]) && $_POST[$remove]!="") {
         $other_user = BoincUser::lookup_id($ignored_users[$i]);
         if (!$other_user) {
             echo tra("No such user:")." ".$ignored_users[$j];

html/user/edit_forum_preferences_form.php

Braces +5 added lines, -4 removed lines

@@ -53,8 +53,9 @@ 
 // ------------ Forum identity -----------
 
 $select_0 = $select_1 = $select_2 = "";
-if (strlen($user->prefs->avatar)){
-    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18)=="//www.gravatar.com") { // Gravatar
+if (strlen($user->prefs->avatar)) {
+    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18)=="//www.gravatar.com") {
+// Gravatar
         $select_1 = "checked=\"true\"";
     } else {
         $select_2 = "checked=\"true\"";
@@ -73,7 +74,7 @@ 
     <input type=\"radio\" id=\"avatar_select_2\" name=\"avatar_select\" value=\"2\" ".$select_2.">
         <label for=\"avatar_select_2\">".tra("Use this uploaded avatar:")."</label> <input type=\"file\" name=\"picture\">"
 );
-if (strlen($user->prefs->avatar)){
+if (strlen($user->prefs->avatar)) {
     row2(tra("Avatar preview")."<br><p class=\"text-muted\">".tra("This is how your avatar will look")."</p>",
     "<img src=\"".$user->prefs->avatar."\" width=\"100\" height=\"100\">");
 }
@@ -103,7 +104,7 @@ 
         tra("Attach signature by default")
     )
 );
-if ($user->prefs->signature!=""){
+if ($user->prefs->signature!="") {
     row2(tra("Signature preview").
         "<br><p class=\"text-muted\">".tra("This is how your signature will look in the forums")."</p>",
         output_transform($user->prefs->signature)

Spacing +20 added lines, -20 removed lines

@@ -38,9 +38,9 @@ 
 // ------------ Notification -----------
 
 row1(tra("Notifications"));
-$ch0 = $user->prefs->pm_notification==0?"checked":"";
-$ch1 = $user->prefs->pm_notification==1?"checked":"";
-$ch2 = $user->prefs->pm_notification==2?"checked":"";
+$ch0 = $user->prefs->pm_notification == 0 ? "checked" : "";
+$ch1 = $user->prefs->pm_notification == 1 ? "checked" : "";
+$ch2 = $user->prefs->pm_notification == 2 ? "checked" : "";
 row2(
     tra("How should we notify you of new private messages, friend requests, posts in subscribed threads, and other events?"),
     "<input type=radio name=pm_notification value=0 $ch0> ".tra("On my Account page (no email)")."
@@ -53,8 +53,8 @@ 
 // ------------ Forum identity -----------
 
 $select_0 = $select_1 = $select_2 = "";
-if (strlen($user->prefs->avatar)){
-    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18)=="//www.gravatar.com") { // Gravatar
+if (strlen($user->prefs->avatar)) {
+    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18) == "//www.gravatar.com") { // Gravatar
         $select_1 = "checked=\"true\"";
     } else {
         $select_2 = "checked=\"true\"";
@@ -73,15 +73,15 @@ 
     <input type=\"radio\" id=\"avatar_select_2\" name=\"avatar_select\" value=\"2\" ".$select_2.">
         <label for=\"avatar_select_2\">".tra("Use this uploaded avatar:")."</label> <input type=\"file\" name=\"picture\">"
 );
-if (strlen($user->prefs->avatar)){
+if (strlen($user->prefs->avatar)) {
     row2(tra("Avatar preview")."<br><p class=\"text-muted\">".tra("This is how your avatar will look")."</p>",
     "<img src=\"".$user->prefs->avatar."\" width=\"100\" height=\"100\">");
 }
 
-$signature_by_default = $user->prefs->no_signature_by_default==false?"checked=\"checked\"":"";
+$signature_by_default = $user->prefs->no_signature_by_default == false ? "checked=\"checked\"" : "";
 
-$signature=$user->prefs->signature;
-$maxlen=250;
+$signature = $user->prefs->signature;
+$maxlen = 250;
 $x = '';
 if (!NO_COMPUTING) {
     $x = tra(
@@ -103,7 +103,7 @@ 
         tra("Attach signature by default")
     )
 );
-if ($user->prefs->signature!=""){
+if ($user->prefs->signature != "") {
     row2(tra("Signature preview").
         "<br><p class=\"text-muted\">".tra("This is how your signature will look in the forums")."</p>",
         output_transform($user->prefs->signature)
@@ -112,13 +112,13 @@ 
 
 // ------------ Message display  -----------
 
-$forum_hide_avatars = $user->prefs->hide_avatars?"checked=\"checked\"":"";
-$forum_hide_signatures = $user->prefs->hide_signatures?"checked=\"checked\"":"";
-$forum_link_popup = $user->prefs->link_popup?"checked=\"checked\"":"";
-$forum_image_as_link = $user->prefs->images_as_links?"checked=\"checked\"":"";
-$forum_jump_to_unread = $user->prefs->jump_to_unread?"checked=\"checked\"":"";
-$forum_ignore_sticky_posts = $user->prefs->ignore_sticky_posts?"checked=\"checked\"":"";
-$forum_highlight_special = $user->prefs->highlight_special?"checked=\"checked\"":"";
+$forum_hide_avatars = $user->prefs->hide_avatars ? "checked=\"checked\"" : "";
+$forum_hide_signatures = $user->prefs->hide_signatures ? "checked=\"checked\"" : "";
+$forum_link_popup = $user->prefs->link_popup ? "checked=\"checked\"" : "";
+$forum_image_as_link = $user->prefs->images_as_links ? "checked=\"checked\"" : "";
+$forum_jump_to_unread = $user->prefs->jump_to_unread ? "checked=\"checked\"" : "";
+$forum_ignore_sticky_posts = $user->prefs->ignore_sticky_posts ? "checked=\"checked\"" : "";
+$forum_highlight_special = $user->prefs->highlight_special ? "checked=\"checked\"" : "";
 
 $forum_minimum_wrap_postcount = intval($user->prefs->minimum_wrap_postcount);
 $forum_display_wrap_postcount = intval($user->prefs->display_wrap_postcount);
@@ -164,7 +164,7 @@ 
                 <input class="btn btn-default" type="submit" name="remove%d" value="%s">
                 <br>
             ',
-            UNIQUE_USER_NAME?'':"$blocked_user->id -",
+            UNIQUE_USER_NAME ? '' : "$blocked_user->id -",
             user_links($blocked_user),
             $blocked_user->id,
             tra("Unblock")
@@ -178,7 +178,7 @@ 
         tra("Blocked users"),
         tra('Ignore message board posts and private messages from these users.')
     ),
-    $blocked_str?$blocked_str:'---'
+    $blocked_str ? $blocked_str : '---'
 );
 row2(
     tra('Block user'),
@@ -188,7 +188,7 @@ 
             <input type="text" name="forum_filter_user" size=12>
             <input class="btn btn-default" type="submit" name="add_user_to_filter" value="%s">
         ',
-        UNIQUE_USER_NAME?tra('User name'):tra('User ID (For instance: 123456789)'),
+        UNIQUE_USER_NAME ?tra('User name') : tra('User ID (For instance: 123456789)'),
         tra("Block")
     )
 );

html/user/pm.php

Braces +4 added lines, -2 removed lines

@@ -285,7 +285,8 @@ 
         // (PM reply fills in the latter)
         //
         $x = explode(' ', $username);
-        if (is_numeric($x[0])) {     // user ID
+        if (is_numeric($x[0])) {
+// user ID
             $userid = (int)$x[0];
             $user = BoincUser::lookup_id($userid);
             if ($user == null) {
@@ -303,7 +304,8 @@ 
                     tra("Could not find user with username %1", $username)
                 );
                 return;
-            } elseif (count($users) > 1) { // Non-unique username
+            } elseif (count($users) > 1) {
+// Non-unique username
                 pm_form_page(
                     $replyto, $userid,
                     tra("%1 is not a unique username; you will have to use user ID", $username)

Spacing +9 added lines, -9 removed lines

@@ -84,20 +84,20 @@ 
             if ($offset === false) $offset = 0;
             if ($offset >= $nmsgs) $offset = 0;
             echo sprintf('Showing messages %d to %d of %d',
-                $offset+1,
-                min($offset+$nshow, $nmsgs),
+                $offset + 1,
+                min($offset + $nshow, $nmsgs),
                 $nmsgs
             );
             if ($offset) {
                 echo sprintf(
                     ' &middot; <a href=pm.php?action=inbox&offset=%d>Previous %d</a>',
-                    max(0, $offset-$nshow), $nshow
+                    max(0, $offset - $nshow), $nshow
                 );
             }
-            if ($offset+$nshow < $nmsgs) {
+            if ($offset + $nshow < $nmsgs) {
                 echo sprintf(
                     ' &middot; <a href=pm.php?action=inbox&offset=%d>Next %d</a>',
-                    $offset+$nshow, $nshow
+                    $offset + $nshow, $nshow
                 );
             }
         }
@@ -112,12 +112,12 @@ 
             array('style="width: 12em;"', 'style="width: 10em;"', "")
         );
         $i = 0;
-        foreach($msgs as $msg) {
-            if ($i<$offset) {
+        foreach ($msgs as $msg) {
+            if ($i < $offset) {
                 $i++;
                 continue;
             }
-            if ($i>=$offset+$nshow) break;
+            if ($i >= $offset + $nshow) break;
             $i++;
             $sender = BoincUser::lookup_id($msg->senderid);
             if (!$sender) {
@@ -391,7 +391,7 @@ 
     $msgs = BoincPrivateMessage::enum(
         "userid=$logged_in_user->id"
     );
-    foreach($msgs as $msg) {
+    foreach ($msgs as $msg) {
         $x = "pm_select_$msg->id";
         if (post_str($x, true)) {
             $msg = BoincPrivateMessage::lookup_id($msg->id);