do_send()

Complexity

Conditions	16
Paths	508

Size

Total Lines	66
Code Lines	44

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

<?php
function do_send($logged_in_user) {
    global $replyto, $userid;
    check_banished($logged_in_user);
    if (VALIDATE_EMAIL_TO_POST) {
        check_validated_email($logged_in_user);
    }
    check_tokens($logged_in_user->authenticator);

    $to = sanitize_tags(post_str("to", true));
    $subject = post_str("subject", true);
    $content = post_str("content", true);

    if (post_str("preview", true) == tra("Preview")) {
        pm_form($replyto, $userid);
    }
    if (($to == null) || ($subject == null) || ($content == null)) {

It seems like you are loosely comparing $content of type mixed|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

It seems like you are loosely comparing $subject of type mixed|string against null; this is ambiguous if the string can be empty. Consider using a strict comparison === instead.

        pm_form($replyto, $userid, tra("You need to fill all fields to send a private message"));
        return;
    }
    if (!akismet_check($logged_in_user, $content)) {
        pm_form($replyto, $userid, tra("Your message was flagged as spam
            by the Akismet anti-spam system.
            Please modify your text and try again.")
        );
    }
    $to = str_replace(", ", ",", $to); // Filter out spaces after separator
    $users = explode(",", $to);

    $userlist = array();
    $userids = array(); // To prevent from spamming a single user by adding it multiple times

    foreach ($users as $username) {
        $user = explode(" ", $username);
        if (is_numeric($user[0])) { // user ID is given
            $userid = $user[0];
            $user = BoincUser::lookup_id($userid);
            if ($user == null) {
                pm_form($replyto, $userid, tra("Could not find user with id %1", $userid));
            }
        } else {
            $users = BoincUser::lookup_name($username);
            if (count($users) == 0) {
                pm_form($replyto, $userid, tra("Could not find user with username %1", $username));
            } elseif (count($users) > 1) { // Non-unique username
                pm_form($replyto, $userid, tra("%1 is not a unique username; you will have to use user ID", $username));
            }
            $user = $users[0];
        }
        BoincForumPrefs::lookup($user);
        if (is_ignoring($user, $logged_in_user)) {
            pm_form($replyto, $userid, tra("User %1 (ID: %2) is not accepting private messages from you.", $user->name, $user->id));
        }
        if (!isset($userids[$user->id])) {
            $userlist[] = $user;
            $userids[$user->id] = true;
        }
    }

    foreach ($userlist as $user) {
        if (!is_moderator($logged_in_user, null)) {
            check_pm_count($logged_in_user->id);
        }
        pm_send_msg($logged_in_user, $user, $subject, $content, true);
    }

    Header("Location: pm.php?action=inbox&sent=1");

Calls to inbuilt PHP functions must be lowercase; expected "header" but found "Header"

}