BOINC / boinc

html/user/forum_post.php

Braces +4 added lines, -4 removed lines

@@ -53,10 +53,10 @@ 
 $preview = post_str("preview", true);
 $warning = null;
 
-if ($content && $title && (!$preview)){
-    if (post_str('add_signature', true) == "add_it"){
+if ($content && $title && (!$preview)) {
+    if (post_str('add_signature', true) == "add_it") {
         $add_signature = true;    // set a flag and concatenate later
-    }  else {
+    } else {
         $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
@@ -111,7 +111,7 @@ 
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
 }
 
-if ($force_title && $title){
+if ($force_title && $title) {
     row2(tra("Title"), htmlspecialchars($title)."<input type=\"hidden\" name=\"title\" value=\"".htmlspecialchars($title)."\">");
 } else {
     row2(tra("Title").$submit_help,

Spacing +10 added lines, -10 removed lines

@@ -53,10 +53,10 @@ 
 $preview = post_str("preview", true);
 $warning = null;
 
-if ($content && $title && (!$preview)){
-    if (post_str('add_signature', true) == "add_it"){
-        $add_signature = true;    // set a flag and concatenate later
-    }  else {
+if ($content && $title && (!$preview)) {
+    if (post_str('add_signature', true) == "add_it") {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
         $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
@@ -68,14 +68,14 @@ 
             $title, $content, $logged_in_user, $forum, $add_signature, $export
         );
         if ($thread) {
-            header('Location: forum_thread.php?id=' . $thread->id);
+            header('Location: forum_thread.php?id='.$thread->id);
         } else {
             error_page("Can't create thread.  $forum_error");
         }
     }
 }
 
-page_head(tra("Create new thread"),'','','', $bbcode_js);
+page_head(tra("Create new thread"), '', '', '', $bbcode_js);
 show_forum_header($logged_in_user);
 
 if ($warning) {
@@ -116,7 +116,7 @@ 
     $submit_help = "<br /><font color=\"red\">".tra("Remember to add a title")."</font>";
 }
 
-if ($force_title && $title){
+if ($force_title && $title) {
     row2(tra("Title"), htmlspecialchars($title)."<input type=\"hidden\" name=\"title\" value=\"".htmlspecialchars($title)."\">");
 } else {
     row2(tra("Title").$submit_help,
@@ -132,9 +132,9 @@ 
 echo "</td></tr>";
 
 if (!$logged_in_user->prefs->no_signature_by_default) {
-    $enable_signature="checked=\"true\"";
+    $enable_signature = "checked=\"true\"";
 } else {
-    $enable_signature="";
+    $enable_signature = "";
 }
 
 if (is_news_forum($forum)) {
@@ -150,5 +150,5 @@ 
 
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

html/user/server_status.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -251,7 +251,7 @@
         $pid = file_get_contents($path);
         if ($pid) {
             $pid = trim($pid);
-            $out = Array();
+            $out = array();
             exec("ps -ww $pid", $out);
             foreach ($out as $y) {
                 if (strstr($y, (string)$pid)) return 1;

Indentation +3 added lines, -3 removed lines

@@ -188,9 +188,9 @@
     
     global $server_version;
     if ( isset($server_version) ) {
-       $url = "https://github.com/BOINC/boinc/tree/server_release/";
-       $url .= explode(".", $server_version)[0] . "." . explode(".", $server_version)[1] . "/" . "$server_version";
-       echo "Upstream server release: <a href=\"" . $url . "\">$server_version</a> <br>";
+        $url = "https://github.com/BOINC/boinc/tree/server_release/";
+        $url .= explode(".", $server_version)[0] . "." . explode(".", $server_version)[1] . "/" . "$server_version";
+        echo "Upstream server release: <a href=\"" . $url . "\">$server_version</a> <br>";
     }
 
     if ($j->db_revision) {

Spacing +13 added lines, -13 removed lines

@@ -30,7 +30,7 @@ 
 require_once("../inc/util.inc");
 require_once("../inc/xml.inc");
 require_once("../inc/boinc_db.inc");
-if(file_exists('../inc/release.inc'))
+if (file_exists('../inc/release.inc'))
     include '../inc/release.inc';
 
 if (!defined('STATUS_PAGE_TTL')) {
@@ -173,7 +173,7 @@ 
         $avg = round($app->info->avg, 2);
         $min = round($app->info->min, 2);
         $max = round($app->info->max, 2);
-        $x = $max?"$avg ($min - $max)":"---";
+        $x = $max ? "$avg ($min - $max)" : "---";
         $u = $app->info->users;
         echo "<tr>
             <td>$app->user_friendly_name</td>
@@ -187,10 +187,10 @@ 
     end_table();
     
     global $server_version;
-    if ( isset($server_version) ) {
+    if (isset($server_version)) {
        $url = "https://github.com/BOINC/boinc/tree/server_release/";
-       $url .= explode(".", $server_version)[0] . "." . explode(".", $server_version)[1] . "/" . "$server_version";
-       echo "Upstream server release: <a href=\"" . $url . "\">$server_version</a> <br>";
+       $url .= explode(".", $server_version)[0].".".explode(".", $server_version)[1]."/"."$server_version";
+       echo "Upstream server release: <a href=\"".$url."\">$server_version</a> <br>";
     }
 
     if ($j->db_revision) {
@@ -254,7 +254,7 @@ 
         $cmd = trim($cmd);
         $x = explode(" ", $cmd);
         $prog = $x[0];
-        $pidname = $prog . '.pid';
+        $pidname = $prog.'.pid';
     }
     $path = "../../pid_$host/$pidname";
     if (is_file($path)) {
@@ -295,12 +295,12 @@ 
     }
     $master_host = $u["host"];
     if ($config->www_host) {
-        $web_host = trim((string) $config->www_host);
+        $web_host = trim((string)$config->www_host);
     } else {
         $web_host = $main_host;
     }
     if ($config->sched_host) {
-        $sched_host = trim((string) $config->sched_host);
+        $sched_host = trim((string)$config->sched_host);
     } else {
         $sched_host = $main_host;
     }
@@ -310,7 +310,7 @@ 
 
     // the upload and download servers are sort of daemons too
     //
-    $url = trim((string) $config->download_url);
+    $url = trim((string)$config->download_url);
     $u = parse_url($url);
     $h = $u["host"];
     if ($h == $master_host) {
@@ -322,14 +322,14 @@ 
     } else {
         $have_remote = true;
     }
-    $url = trim((string) $config->upload_url);
+    $url = trim((string)$config->upload_url);
     $u = parse_url($url);
     $h = $u["host"];
     if ($h == $master_host) {
         $y = new StdClass;
         $y->cmd = "Upload server";
         $y->host = $h;
-        $y->status = !file_exists("../../stop_upload");;
+        $y->status = !file_exists("../../stop_upload"); ;
         $local_daemons[] = $y;
     } else {
         $have_remote = true;
@@ -341,7 +341,7 @@ 
         $y = new StdClass;
         $y->cmd = "Scheduler";
         $y->host = $sched_host;
-        $y->status = !file_exists("../../stop_sched");;
+        $y->status = !file_exists("../../stop_sched"); ;
         $local_daemons[] = $y;
     } else {
         $have_remote = true;
@@ -357,7 +357,7 @@ 
             $disabled_daemons[] = $x;
             continue;
         }
-        $host = $d->host?(string)$d->host:$main_host;
+        $host = $d->host ? (string)$d->host : $main_host;
         if ($host != $web_host) {
             $have_remote = true;
             continue;

html/user/submit.php

Braces +1 added lines, -1 removed lines

@@ -369,7 +369,7 @@
             $text = "---";
             if ($batch->state == BATCH_STATE_COMPLETE) {
                 $y = '<font color="red">failed</font>';
-            }   else {
+            } else {
                 $y = "in progress";
             }
         }

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -308,7 +308,7 @@ 
     $wus = BoincWorkunit::enum("batch = $batch->id");
     $batch = get_batch_params($batch, $wus);
 
-    page_head("Batch $batch_id");
+    page_head("batch $batch_id");
     start_table();
     row2("name", $batch->name);
     row2("application", $app->name);
@@ -393,7 +393,7 @@ 
     $wu = BoincWorkunit::lookup_id($wuid);
     if (!$wu) error_page("no such job");
 
-    page_head("Job $wuid");
+    page_head("job $wuid");
 
     echo "
         <a href=workunit.php?wuid=$wuid>Workunit details</a> &middot;

Spacing +5 added lines, -5 removed lines

@@ -323,7 +323,7 @@ 
     }
     row2("GFLOP/hours, estimated", number_format(credit_to_gflop_hours($batch->credit_estimate), 2));
     row2("GFLOP/hours, actual", number_format(credit_to_gflop_hours($batch->credit_canonical), 2));
-    row2("Output File Size (MB)", number_format(batch_output_file_size($batch->id)/1e6,2));
+    row2("Output File Size (MB)", number_format(batch_output_file_size($batch->id)/1e6, 2));
     end_table();
     if (batch_output_file_size($batch->id) <= 1e8) {
         $url = boinc_get_output_files_url($user, $batch_id);
@@ -357,9 +357,9 @@ 
         "Canonical instance<br><small>click to see result page on BOINC server</smallp>",
         "Download Results"
     );
-    foreach($wus as $wu) {
+    foreach ($wus as $wu) {
         $resultid = $wu->canonical_resultid;
-        $durl = boinc_get_wu_output_files_url($user,$wu->id);
+        $durl = boinc_get_wu_output_files_url($user, $wu->id);
         if ($resultid) {
             $x = "<a href=result.php?resultid=$resultid>$resultid</a>";
             $y = '<font color="green">completed</font>';
@@ -369,7 +369,7 @@ 
             $text = "---";
             if ($batch->state == BATCH_STATE_COMPLETE) {
                 $y = '<font color="red">failed</font>';
-            }   else {
+            } else {
                 $y = "in progress";
             }
         }
@@ -434,7 +434,7 @@ 
     $results = BoincResult::enum("workunitid=$wuid");
     $upload_dir = parse_config(get_config(), "<upload_dir>");
     $fanout = parse_config(get_config(), "<uldl_dir_fanout>");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         echo "<tr>
             <td><a href=result.php?resultid=$result->id>$result->id &middot; $result->name </a></td>
             <td>".state_string($result)."</td>

html/user/bolt.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -42,7 +42,7 @@
         $view = BoltView::lookup_id($e->last_view_id);
         $ago = time_diff(time() - $view->start_time);
         $pct = number_format($view->fraction_done*100, 0);
-        $status = "Started $start
+        $status = "started $start
             <br>Last visit: $ago ago
             <br>$pct% done
         ";

Spacing +1 added lines, -1 removed lines

@@ -36,7 +36,7 @@
     if ($course->hidden && !($user->bolt->flags&BOLT_FLAG_SHOW_ALL)) {
         continue;
     }
-    $e = $user?BoltEnrollment::lookup($user->id, $course->id):null;
+    $e = $user ?BoltEnrollment::lookup($user->id, $course->id) : null;
     if ($e) {
         $start = date_str($e->create_time);
         $view = BoltView::lookup_id($e->last_view_id);

html/user/forum_reply.php

Braces +4 added lines, -4 removed lines

@@ -50,7 +50,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -65,10 +65,10 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
-    if (post_str('add_signature',true)=="add_it"){
+if ($content && (!$preview)) {
+    if (post_str('add_signature',true)=="add_it") {
         $add_signature=true;    // set a flag and concatenate later
-    }  else {
+    } else {
         $add_signature=false;
     }
     check_tokens($logged_in_user->authenticator);

Spacing +13 added lines, -13 removed lines

@@ -50,7 +50,7 @@ 
     $parent_post_id = 0;
 }
 
-if ($filter != "false"){
+if ($filter != "false") {
     $filter = true;
 } else {
     $filter = false;
@@ -65,11 +65,11 @@ 
 }
 
 $warning = null;
-if ($content && (!$preview)){
-    if (post_str('add_signature',true)=="add_it"){
-        $add_signature=true;    // set a flag and concatenate later
-    }  else {
-        $add_signature=false;
+if ($content && (!$preview)) {
+    if (post_str('add_signature', true) == "add_it") {
+        $add_signature = true; // set a flag and concatenate later
+    } else {
+        $add_signature = false;
     }
     check_tokens($logged_in_user->authenticator);
     if (!akismet_check($logged_in_user, $content)) {
@@ -88,7 +88,7 @@ 
     }
 }
 
-page_head(tra("Post to thread"),'','','', $bbcode_js);
+page_head(tra("Post to thread"), '', '', '', $bbcode_js);
 
 show_forum_header($logged_in_user);
 
@@ -142,7 +142,7 @@ 
     $x1 = tra("Message:").bbcode_info().post_warning();
     $x2 = "";
     if ($parent_post) {
-        $x2 .=" ".tra("reply to %1 Message ID %2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
+        $x2 .= " ".tra("reply to %1 Message ID %2:", "<a href=#".$parent_post->id.">", " ".$parent_post->id."</a>");
     }
     $x2 .= "<form action=forum_reply.php?thread=".$thread->id;
 
@@ -153,7 +153,7 @@ 
     $x2 .= " method=\"post\" name=\"post\" onsubmit=\"return checkForm(this)\">\n";
     $x2 .= form_tokens($logged_in_user->authenticator);
     $x2 .= start_table_str().$bbcode_html.end_table_str()."<textarea class=\"form-control\" name=\"content\" rows=\"18\">";
-    $no_quote = get_int("no_quote", true)==1;
+    $no_quote = get_int("no_quote", true) == 1;
     if ($preview) {
         $x2 .= htmlspecialchars($content);
     } else if (!$no_quote) {
@@ -162,9 +162,9 @@ 
         }
     }
     if (!$logged_in_user->prefs->no_signature_by_default) {
-        $enable_signature="checked=\"true\"";
+        $enable_signature = "checked=\"true\"";
     } else {
-        $enable_signature="";
+        $enable_signature = "";
     }
     $x2 .= "</textarea><p> </p>
         <input class=\"btn btn-primary btn-sm \" type=\"submit\" name=\"preview\" value=\"".tra("Preview")."\">
@@ -179,9 +179,9 @@ 
 }
 
 function quote_text($text) {
-    $text = "[quote]" . $text . "[/quote]";
+    $text = "[quote]".$text."[/quote]";
     return $text;
 }
 
-$cvs_version_tracker[]="\$Id$";
+$cvs_version_tracker[] = "\$Id$";
 ?>

html/user/submit_status.php

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -32,7 +32,7 @@
     if (!$batch || $batch->user_id != $user->id) {
         error_page("no batch");
     }
-    page_head("Batch $batch->id");
+    page_head("batch $batch->id");
     $results = BoincResult::enum("batch=$batch->id order by workunitid");
     result_table_start(true, true, null);
     foreach ($results as $result) {

html/user/edit_forum_preferences_form.php

Braces +6 added lines, -5 removed lines

@@ -53,8 +53,9 @@ 
 // ------------ Forum identity -----------
 
 $select_0 = $select_1 = $select_2 = "";
-if (strlen($user->prefs->avatar)){
-    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18)=="//www.gravatar.com") { // Gravatar
+if (strlen($user->prefs->avatar)) {
+    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18)=="//www.gravatar.com") {
+// Gravatar
         $select_1 = "checked=\"true\"";
     } else {
         $select_2 = "checked=\"true\"";
@@ -73,7 +74,7 @@ 
     <input type=\"radio\" id=\"avatar_select_2\" name=\"avatar_select\" value=\"2\" ".$select_2.">
         <label for=\"avatar_select_2\">".tra("Use this uploaded avatar:")."</label> <input type=\"file\" name=\"picture\">"
 );
-if (strlen($user->prefs->avatar)){
+if (strlen($user->prefs->avatar)) {
     row2(tra("Avatar preview")."<br><p class=\"text-muted\">".tra("This is how your avatar will look")."</p>",
     "<img src=\"".$user->prefs->avatar."\" width=\"100\" height=\"100\">");
 }
@@ -92,7 +93,7 @@ 
     textarea_with_counter("signature", 250, $signature)
     ."<br><input type=\"checkbox\" name=\"signature_by_default\" ".$signature_by_default."> ".tra("Attach signature by default")
 );
-if ($user->prefs->signature!=""){
+if ($user->prefs->signature!="") {
     row2(tra("Signature preview").
         "<br><p class=\"text-muted\">".tra("This is how your signature will look in the forums")."</p>",
         output_transform($user->prefs->signature)
@@ -138,7 +139,7 @@ 
 
 $filtered_userlist = get_ignored_list($user);
 $forum_filtered_userlist = "";
-for ($i=0; $i<sizeof($filtered_userlist); $i++){
+for ($i=0; $i<sizeof($filtered_userlist); $i++) {
     $id = (int)$filtered_userlist[$i];
     if ($id) {
         $filtered_user = BoincUser::lookup_id($id);

Spacing +19 added lines, -19 removed lines

@@ -38,9 +38,9 @@ 
 // ------------ Notification -----------
 
 row1(tra("Notifications"));
-$ch0 = $user->prefs->pm_notification==0?"checked":"";
-$ch1 = $user->prefs->pm_notification==1?"checked":"";
-$ch2 = $user->prefs->pm_notification==2?"checked":"";
+$ch0 = $user->prefs->pm_notification == 0 ? "checked" : "";
+$ch1 = $user->prefs->pm_notification == 1 ? "checked" : "";
+$ch2 = $user->prefs->pm_notification == 2 ? "checked" : "";
 row2(
     tra("How should we notify you of new private messages, friend requests, posts in subscribed threads, and other events?"),
     "<input type=radio name=pm_notification value=0 $ch0> ".tra("On my Account page (no email)")."
@@ -53,8 +53,8 @@ 
 // ------------ Forum identity -----------
 
 $select_0 = $select_1 = $select_2 = "";
-if (strlen($user->prefs->avatar)){
-    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18)=="//www.gravatar.com") { // Gravatar
+if (strlen($user->prefs->avatar)) {
+    if (substr($user->prefs->avatar, 0, 23) == 'http://www.gravatar.com' || substr($user->prefs->avatar, 0, 18) == "//www.gravatar.com") { // Gravatar
         $select_1 = "checked=\"true\"";
     } else {
         $select_2 = "checked=\"true\"";
@@ -73,15 +73,15 @@ 
     <input type=\"radio\" id=\"avatar_select_2\" name=\"avatar_select\" value=\"2\" ".$select_2.">
         <label for=\"avatar_select_2\">".tra("Use this uploaded avatar:")."</label> <input type=\"file\" name=\"picture\">"
 );
-if (strlen($user->prefs->avatar)){
+if (strlen($user->prefs->avatar)) {
     row2(tra("Avatar preview")."<br><p class=\"text-muted\">".tra("This is how your avatar will look")."</p>",
     "<img src=\"".$user->prefs->avatar."\" width=\"100\" height=\"100\">");
 }
 
-$signature_by_default = $user->prefs->no_signature_by_default==false?"checked=\"checked\"":"";
+$signature_by_default = $user->prefs->no_signature_by_default == false ? "checked=\"checked\"" : "";
 
-$signature=$user->prefs->signature;
-$maxlen=250;
+$signature = $user->prefs->signature;
+$maxlen = 250;
 row2(
     tra("Signature for message board posts")
     .bbcode_info()
@@ -92,7 +92,7 @@ 
     textarea_with_counter("signature", 250, $signature)
     ."<br><input type=\"checkbox\" name=\"signature_by_default\" ".$signature_by_default."> ".tra("Attach signature by default")
 );
-if ($user->prefs->signature!=""){
+if ($user->prefs->signature != "") {
     row2(tra("Signature preview").
         "<br><p class=\"text-muted\">".tra("This is how your signature will look in the forums")."</p>",
         output_transform($user->prefs->signature)
@@ -101,13 +101,13 @@ 
 
 // ------------ Message display  -----------
 
-$forum_hide_avatars = $user->prefs->hide_avatars?"checked=\"checked\"":"";
-$forum_hide_signatures = $user->prefs->hide_signatures?"checked=\"checked\"":"";
-$forum_link_popup = $user->prefs->link_popup?"checked=\"checked\"":""; 
-$forum_image_as_link = $user->prefs->images_as_links?"checked=\"checked\"":"";
-$forum_jump_to_unread = $user->prefs->jump_to_unread?"checked=\"checked\"":"";
-$forum_ignore_sticky_posts = $user->prefs->ignore_sticky_posts?"checked=\"checked\"":"";
-$forum_highlight_special = $user->prefs->highlight_special?"checked=\"checked\"":"";
+$forum_hide_avatars = $user->prefs->hide_avatars ? "checked=\"checked\"" : "";
+$forum_hide_signatures = $user->prefs->hide_signatures ? "checked=\"checked\"" : "";
+$forum_link_popup = $user->prefs->link_popup ? "checked=\"checked\"" : ""; 
+$forum_image_as_link = $user->prefs->images_as_links ? "checked=\"checked\"" : "";
+$forum_jump_to_unread = $user->prefs->jump_to_unread ? "checked=\"checked\"" : "";
+$forum_ignore_sticky_posts = $user->prefs->ignore_sticky_posts ? "checked=\"checked\"" : "";
+$forum_highlight_special = $user->prefs->highlight_special ? "checked=\"checked\"" : "";
 
 $forum_minimum_wrap_postcount = intval($user->prefs->minimum_wrap_postcount);
 $forum_display_wrap_postcount = intval($user->prefs->display_wrap_postcount);
@@ -138,7 +138,7 @@ 
 
 $filtered_userlist = get_ignored_list($user);
 $forum_filtered_userlist = "";
-for ($i=0; $i<sizeof($filtered_userlist); $i++){
+for ($i = 0; $i < sizeof($filtered_userlist); $i++) {
     $id = (int)$filtered_userlist[$i];
     if ($id) {
         $filtered_user = BoincUser::lookup_id($id);
@@ -168,5 +168,5 @@ 
 end_table();
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>

html/user/submit_rpc_handler.php

Braces +2 added lines, -1 removed lines

@@ -691,7 +691,8 @@
         <id>$result->id</id>
         <state>".state_string($result)."</state>
 ";
-        if ($result->server_state == 5) {   // over?
+        if ($result->server_state == 5) {
+// over?
             $paths = get_outfile_paths($result);
             foreach($paths as $path) {
                 if (is_file($path)) {

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -595,7 +595,7 @@
 // return a batch specified by the command, using either ID or name
 //
 function get_batch($r) {
-    $batch = NULL;
+    $batch = null;
     if (!empty($r->batch_id)) {
         $batch_id = (int)($r->batch_id);
         $batch = BoincBatch::lookup_id($batch_id);

Spacing +31 added lines, -31 removed lines

@@ -54,7 +54,7 @@ 
     if ($template) {
         $t = (double)$template->workunit->rsc_fpops_est;
     }
-    foreach($r->batch->job as $job) {
+    foreach ($r->batch->job as $job) {
         $y = (double)$job->rsc_fpops_est;
         if ($y) {
             $x += $y;
@@ -79,7 +79,7 @@ 
 function est_elapsed_time($r, $template) {
     // crude estimate: batch FLOPs / project FLOPS
     //
-    return batch_flop_count($r, $template) / project_flops();
+    return batch_flop_count($r, $template)/project_flops();
 }
 
 // if batch-level input template filename was given, read it;
@@ -89,9 +89,9 @@ 
 //
 function read_input_template($app, $r) {
     if ((isset($r->batch)) && (isset($r->batch->workunit_template_file)) && ($r->batch->workunit_template_file)) {
-        $path = project_dir() . "/templates/".$r->batch->workunit_template_file;
+        $path = project_dir()."/templates/".$r->batch->workunit_template_file;
     } else {
-        $path = project_dir() . "/templates/$app->name"."_in";
+        $path = project_dir()."/templates/$app->name"."_in";
     }
     if (file_exists($path)) {
         $x = simplexml_load_file($path);
@@ -134,7 +134,7 @@ 
 function validate_batch($jobs, $template) {
     $i = 0;
     $n = count($template->file_info);
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         $m = count($job->input_files);
         if ($n != $m) {
             xml_error(-1, "wrong # of input files for job $i: need $n, got $m");
@@ -189,7 +189,7 @@ 
 // stage all the files
 //
 function stage_files(&$jobs) {
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         foreach ($job->input_files as $file) {
             if ($file->mode != "remote") {
                 $file->name = stage_file($file);
@@ -202,7 +202,7 @@ 
 //
 function submit_jobs(
     $jobs, $job_params, $app, $batch_id, $priority, $app_version_num,
-    $input_template_filename,        // batch-level; can also specify per job
+    $input_template_filename, // batch-level; can also specify per job
     $output_template_filename
 ) {
     global $input_templates, $output_templates;
@@ -211,7 +211,7 @@ 
     // one line per job
     //
     $x = "";
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         if ($job->name) {
             $x .= " --wu_name $job->name";
         }
@@ -243,8 +243,8 @@ 
         $x .= "\n";
     }
 
-    $errfile = "/tmp/create_work_" . getmypid() . ".err";
-    $cmd = "cd " . project_dir() . "; ./bin/create_work --appname $app->name --batch $batch_id --priority $priority";
+    $errfile = "/tmp/create_work_".getmypid().".err";
+    $cmd = "cd ".project_dir()."; ./bin/create_work --appname $app->name --batch $batch_id --priority $priority";
     if ($input_template_filename) {
         $cmd .= " --wu_template templates/$input_template_filename";
     }
@@ -340,7 +340,7 @@ 
 //
 function xml_get_jobs($r) {
     $jobs = array();
-    foreach($r->batch->job as $j) {
+    foreach ($r->batch->job as $j) {
         $job = new StdClass;
         $job->input_files = array();
         $job->command_line = (string)$j->command_line;
@@ -420,16 +420,16 @@ 
     // - use that for batch logical end time and job priority
     //
     $total_flops = 0;
-    foreach($jobs as $job) {
+    foreach ($jobs as $job) {
         //print_r($job);
         if ($job->rsc_fpops_est) {
             $total_flops += $job->rsc_fpops_est;
         } else if ($job->input_template && $job->input_template->workunit->rsc_fpops_est) {
-            $total_flops += (double) $job->input_template->workunit->rsc_fpops_est;
+            $total_flops += (double)$job->input_template->workunit->rsc_fpops_est;
         } else if ($r->batch->job_params->rsc_fpops_est) {
-            $total_flops += (double) $r->batch->job_params->rsc_fpops_est;
+            $total_flops += (double)$r->batch->job_params->rsc_fpops_est;
         } else {
-            $x = (double) $template->workunit->rsc_fpops_est;
+            $x = (double)$template->workunit->rsc_fpops_est;
             if ($x) {
                 $total_flops += $x;
             } else {
@@ -437,7 +437,7 @@ 
             }
         }
     }
-    $cmd = "cd " . project_dir() . "/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
+    $cmd = "cd ".project_dir()."/bin; ./adjust_user_priority --user $user->id --flops $total_flops --app $app->name";
     $x = exec($cmd);
     if (!is_numeric($x) || (double)$x == 0) {
         xml_error(-1, "$cmd returned $x");
@@ -461,15 +461,15 @@ 
     }
     
     $job_params = new StdClass;
-    $job_params->rsc_disk_bound = (double) $r->batch->job_params->rsc_disk_bound;
-    $job_params->rsc_fpops_est = (double) $r->batch->job_params->rsc_fpops_est;
-    $job_params->rsc_fpops_bound = (double) $r->batch->job_params->rsc_fpops_bound;
-    $job_params->rsc_memory_bound = (double) $r->batch->job_params->rsc_memory_bound;
-    $job_params->delay_bound = (double) $r->batch->job_params->delay_bound;
+    $job_params->rsc_disk_bound = (double)$r->batch->job_params->rsc_disk_bound;
+    $job_params->rsc_fpops_est = (double)$r->batch->job_params->rsc_fpops_est;
+    $job_params->rsc_fpops_bound = (double)$r->batch->job_params->rsc_fpops_bound;
+    $job_params->rsc_memory_bound = (double)$r->batch->job_params->rsc_memory_bound;
+    $job_params->delay_bound = (double)$r->batch->job_params->delay_bound;
         // could add quorum-related stuff
 
-    $input_template_filename = (string) $r->batch->input_template_filename;
-    $output_template_filename = (string) $r->batch->output_template_filename;
+    $input_template_filename = (string)$r->batch->input_template_filename;
+    $output_template_filename = (string)$r->batch->output_template_filename;
         // possibly empty
     
     submit_jobs(
@@ -552,7 +552,7 @@ 
 }
 
 function n_outfiles($wu) {
-    $path = project_dir() . "/$wu->output_template_filename";
+    $path = project_dir()."/$wu->output_template_filename";
     $r = simplexml_load_file($path);
     return count($r->file_info);
 }
@@ -748,7 +748,7 @@ 
 ";
         if ($result->server_state == 5) {   // over?
             $paths = get_outfile_paths($result);
-            foreach($paths as $path) {
+            foreach ($paths as $path) {
                 if (is_file($path)) {
                     $size = filesize($path);
                     echo "        <outfile>
@@ -788,7 +788,7 @@ 
     } else {
         $results = BoincResult::enum("workunitid=$job_id");
         foreach ($results as $r) {
-            switch($r->outcome) {
+            switch ($r->outcome) {
             case 1:
             case 3:
             case 6:
@@ -896,8 +896,8 @@ 
     }
 
     list($user, $user_submit) = authenticate_user($r, $app);
-    $in = file_get_contents(project_dir() . "/templates/".$app->name."_in");
-    $out = file_get_contents(project_dir() . "/templates/".$app->name."_out");
+    $in = file_get_contents(project_dir()."/templates/".$app->name."_in");
+    $out = file_get_contents(project_dir()."/templates/".$app->name."_out");
     if ($in === false || $out === false) {
         xml_error(-1, "template file missing");
     }
@@ -908,7 +908,7 @@ 
 
 function ping($r) {
     xml_start_tag("ping");
-    BoincDb::get();     // errors out if DB down or web disabled
+    BoincDb::get(); // errors out if DB down or web disabled
     echo "<success>1</success>
         </ping>
     ";
@@ -974,10 +974,10 @@ 
 if ($request_log) {
     $request_log_dir = parse_config(get_config(), "<log_dir>");
     if ($request_log_dir) {
-        $request_log = $request_log_dir . "/" . $request_log;
+        $request_log = $request_log_dir."/".$request_log;
     }
     if ($file = fopen($request_log, "a+")) {
-        fwrite($file, "\n<submit_rpc_handler date=\"" . date(DATE_ATOM) . "\">\n" . $_POST['request'] . "\n</submit_rpc_handler>\n");
+        fwrite($file, "\n<submit_rpc_handler date=\"".date(DATE_ATOM)."\">\n".$_POST['request']."\n</submit_rpc_handler>\n");
         fclose($file);
     }
 }

html/user/forum_search.php

Braces +4 added lines, -4 removed lines

@@ -56,7 +56,7 @@ 
     </select>");
 
 $forumid = null;
-if (get_str("forumid",true)){
+if (get_str("forumid",true)) {
     $forumid = get_str("forumid");
 }
 $forumlist="<option value=\"-1\">".tra("All")."</option>";
@@ -64,7 +64,7 @@ 
 foreach ($categories as $category) {
     $forums = BoincForum::enum("parent_type=0 and category=$category->id");
     foreach ($forums as $forum) {
-        if ($forum->id==$forumid){
+        if ($forum->id==$forumid) {
             $forumlist.="<option selected value=\"".$forum->id."\">".$forum->title."</option>";
         } else {
             $forumlist.="<option value=\"".$forum->id."\">".$forum->title."</option>";
@@ -76,8 +76,8 @@ 
     '<select class="form-control" name="search_forum">'.$forumlist.'</select');
 
 $sortlist = null;
-foreach ($thread_sort_styles as $id => $style){
-    if ($id == CREATE_TIME_NEW){
+foreach ($thread_sort_styles as $id => $style) {
+    if ($id == CREATE_TIME_NEW) {
         $sortlist.="<option selected value=\"".$id."\">".$style."</option>";
     } else {
         $sortlist.="<option value=\"".$id."\">".$style."</option>";

Spacing +11 added lines, -11 removed lines

@@ -56,18 +56,18 @@ 
     </select>");
 
 $forumid = null;
-if (get_str("forumid",true)){
+if (get_str("forumid", true)) {
     $forumid = get_str("forumid");
 }
-$forumlist="<option value=\"-1\">".tra("All")."</option>";
+$forumlist = "<option value=\"-1\">".tra("All")."</option>";
 $categories = BoincCategory::enum();
 foreach ($categories as $category) {
     $forums = BoincForum::enum("parent_type=0 and category=$category->id");
     foreach ($forums as $forum) {
-        if ($forum->id==$forumid){
-            $forumlist.="<option selected value=\"".$forum->id."\">".$forum->title."</option>";
+        if ($forum->id == $forumid) {
+            $forumlist .= "<option selected value=\"".$forum->id."\">".$forum->title."</option>";
         } else {
-            $forumlist.="<option value=\"".$forum->id."\">".$forum->title."</option>";
+            $forumlist .= "<option value=\"".$forum->id."\">".$forum->title."</option>";
         }
     }
 }
@@ -76,22 +76,22 @@ 
     '<select class="form-control" name="search_forum">'.$forumlist.'</select');
 
 $sortlist = null;
-foreach ($thread_sort_styles as $id => $style){
-    if ($id == CREATE_TIME_NEW){
-        $sortlist.="<option selected value=\"".$id."\">".$style."</option>";
+foreach ($thread_sort_styles as $id => $style) {
+    if ($id == CREATE_TIME_NEW) {
+        $sortlist .= "<option selected value=\"".$id."\">".$style."</option>";
     } else {
-        $sortlist.="<option value=\"".$id."\">".$style."</option>";
+        $sortlist .= "<option value=\"".$id."\">".$style."</option>";
     }
 }
 row2(tra("Sort by"), 
     '<select class="form-control" name="search_sort">'.$sortlist.'</select');
 
 row1("&nbsp;");
-row2("","<input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Start the search")."\">");
+row2("", "<input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Start the search")."\">");
 echo "</form>";
 end_table();
 
 page_tail();
 
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
 ?>