Passed
Push — master ( 8b88f4...c5ef2d )
by Christian
07:24 queued 10s
created
default/boinc/modules/boincuser/boincuser_delete/boincuser_delete.admin.inc 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -65,7 +65,7 @@  discard block
 block discarded – undo
65 65
   $form['#uid'] = $uid;
66 66
 
67 67
   $form['account']['help'] = array(
68
-    '#value' => "<p>" . t("This form will delete this user <strong>without any email notification</strong> sent to the user. Be very careful in deleting users using this form. Once you select the delete type, check the checkbox, enter your password, and click submit, the user's account will be deleted. This will occur <strong>immediately</strong>. There is no 'undo'!") . "</p><p>" . t("You are deleting the following user, link opens in new window:") . "</p>",
68
+    '#value' => "<p>".t("This form will delete this user <strong>without any email notification</strong> sent to the user. Be very careful in deleting users using this form. Once you select the delete type, check the checkbox, enter your password, and click submit, the user's account will be deleted. This will occur <strong>immediately</strong>. There is no 'undo'!")."</p><p>".t("You are deleting the following user, link opens in new window:")."</p>",
69 69
     '#weight' => -1,
70 70
     '#prefix' => "<div id='delete-instructions'>",
71 71
     '#suffix' => "</div>",
@@ -76,16 +76,16 @@  discard block
 block discarded – undo
76 76
     drupal_set_title($account->boincuser_name);
77 77
 
78 78
     $form['account']['boincuser_name'] = array(
79
-      '#value' => t('<li>BOINC username (public displayname): ') . l("{$account->boincuser_name}", "account/{$account->uid}", array('attributes' => array('target' => '_blank'))),
79
+      '#value' => t('<li>BOINC username (public displayname): ').l("{$account->boincuser_name}", "account/{$account->uid}", array('attributes' => array('target' => '_blank'))),
80 80
     );
81 81
     $form['account']['boincuser_id'] = array(
82
-      '#value' => t('<li>BOINC user ID: ') . $account->boincuser_id,
82
+      '#value' => t('<li>BOINC user ID: ').$account->boincuser_id,
83 83
     );
84 84
     $form['account']['drupal_name'] = array(
85
-      '#value' => t('<li>Drupal username (internal): ') . $account->name,
85
+      '#value' => t('<li>Drupal username (internal): ').$account->name,
86 86
     );
87 87
     $form['account']['user_id'] = array(
88
-      '#value' => t('<li>Drupal user ID: ') . $account->uid,
88
+      '#value' => t('<li>Drupal user ID: ').$account->uid,
89 89
     );
90 90
 
91 91
     $form['account']['user_delete_action'] = array(
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
     form_set_error('user_delete_action', t('Please select an action to perform using the radio buttons.'));
149 149
   }
150 150
 
151
-  if ( ($form_state['values']['user_delete_action'] != 'soft_obfuscate') and ($form_state['values']['user_delete_action'] != 'hard_wipe') ) {
151
+  if (($form_state['values']['user_delete_action'] != 'soft_obfuscate') and ($form_state['values']['user_delete_action'] != 'hard_wipe')) {
152 152
     form_set_error('user_delete_action', t('User Delete action not a predefined value, unknown error in radio buttons.'));
153 153
   }
154 154
 
Please login to merge, or discard this patch.
html/user/create_profile.php 1 patch
Spacing   +20 added lines, -20 removed lines patch added patch discarded remove patch
@@ -32,7 +32,7 @@  discard block
 block discarded – undo
32 32
 // If $selection is provided, and if it matches one of the entries in the file,
33 33
 // it will be selected by default.
34 34
 //
35
-function show_combo_box($name, $filename, $selection=null) {
35
+function show_combo_box($name, $filename, $selection = null) {
36 36
     echo "<select name=\"$name\" class=\"form-control\">\n";
37 37
 
38 38
     $file = fopen($filename, "r");
@@ -63,14 +63,14 @@  discard block
 block discarded – undo
63 63
 <tr><td colspan=2>
64 64
 <table border=0 cellpadding=5
65 65
 <tr>
66
-<td valign=top><a href=\"" . IMAGE_URL . $profile->userid . '.jpg' . "\"><img src=\"" . IMAGE_URL . $profile->userid . '_sm.jpg' . "\"></a>
66
+<td valign=top><a href=\"" . IMAGE_URL.$profile->userid.'.jpg'."\"><img src=\"".IMAGE_URL.$profile->userid.'_sm.jpg'."\"></a>
67 67
 </td>
68
-<td valign=top>" .tra("%1 Your profile picture is shown to the left.",  $warning) ."
68
+<td valign=top>" .tra("%1 Your profile picture is shown to the left.", $warning)."
69 69
 <p>".
70
-tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB") ."<br />
70
+tra("To replace it, click the \"Browse\" button and select a JPEG or PNG file (%1 or less).", "50KB")."<br />
71 71
 <input name=picture type=file><br>
72 72
 <p>".
73
-tra("To remove it from your profile, check this box:") . "
73
+tra("To remove it from your profile, check this box:")."
74 74
 <input type=checkbox name=delete_pic>
75 75
 <p>
76 76
 </td></tr>";
@@ -78,7 +78,7 @@  discard block
 block discarded – undo
78 78
         end_table();
79 79
         echo "</td></tr>";
80 80
     } else {
81
-        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB") . "
81
+        rowify(tra("If you would like include a picture with your profile, click the \"Browse\" button and select a JPEG or PNG file. Please select images of %1 or less.", "50KB")."
82 82
 <p>
83 83
 <input name=picture type=file>
84 84
         ");
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
     row1(tra("Language"));
94 94
     echo "<tr><td>
95 95
         <p>" .
96
-        tra("Select the language in which your profile is written:") . "
96
+        tra("Select the language in which your profile is written:")."
97 97
         <p>
98 98
     ";
99 99
     if (isset($profile->language)) {
@@ -110,7 +110,7 @@  discard block
 block discarded – undo
110 110
     if ($recaptcha_public_key) {
111 111
         table_row(boinc_recaptcha_get_html($recaptcha_public_key));
112 112
     }
113
-    table_row("<p><input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Create/edit profile") ."\" name=\"submit\">");
113
+    table_row("<p><input class=\"btn btn-success\" type=\"submit\" value=\"".tra("Create/edit profile")."\" name=\"submit\">");
114 114
 }
115 115
 
116 116
 // Returns an array containing:
@@ -124,7 +124,7 @@  discard block
 block discarded – undo
124 124
 
125 125
     // Determine if the filetype uploaded is supported.
126 126
     // TODO: Change these to constants.
127
-    switch($size[2]) {
127
+    switch ($size[2]) {
128 128
     case '2':    // JPEG
129 129
         $image = imageCreateFromJPEG($fileName);
130 130
         break;
@@ -161,7 +161,7 @@  discard block
 block discarded – undo
161 161
 
162 162
 function show_description() {
163 163
     echo "
164
-        <p>" .tra("Your %1 profile %2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT) . "
164
+        <p>" .tra("Your %1 profile %2 lets you share your opinions and background with the %3 community.", "<b>", "</b>", PROJECT)."
165 165
         <p>
166 166
     ";
167 167
 }
@@ -179,14 +179,14 @@  discard block
 block discarded – undo
179 179
     row1(show_profile_heading1());
180 180
     rowify(show_profile_question1().bbcode_info());
181 181
     show_textarea("response1", $response1);
182
-    row1( show_profile_heading2());
183
-    rowify( show_profile_question2().bbcode_info());
182
+    row1(show_profile_heading2());
183
+    rowify(show_profile_question2().bbcode_info());
184 184
     show_textarea("response2", $response2);
185 185
     show_language_selection($profile);
186 186
 }
187 187
 
188 188
 function show_textarea($name, $text) {
189
-    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">" . $text . "</textarea>");
189
+    rowify("<textarea name=\"$name\" class=\"form-control\" rows=\"10\">".$text."</textarea>");
190 190
 }
191 191
 
192 192
 // $profile is null if user doesn't already have a profile.
@@ -232,8 +232,8 @@  discard block
 block discarded – undo
232 232
         $delete_pic = "off";
233 233
     }
234 234
 
235
-    if (strlen($response1)==0 &&
236
-        strlen($response2)==0 &&
235
+    if (strlen($response1) == 0 &&
236
+        strlen($response2) == 0 &&
237 237
         $delete_pic != "on" &&
238 238
         !is_uploaded_file($_FILES['picture']['tmp_name'])
239 239
     ) {
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         $profile->verification = 0;
248 248
     }
249 249
 
250
-    $profile ? $has_picture = $profile->has_picture: $has_picture = false;
250
+    $profile ? $has_picture = $profile->has_picture : $has_picture = false;
251 251
 
252 252
     if (is_uploaded_file($_FILES['picture']['tmp_name'])) {
253 253
         $has_picture = true;
@@ -262,13 +262,13 @@  discard block
 block discarded – undo
262 262
 
263 263
         // Write the original image file to disk.
264 264
         // TODO: define a constant for image quality.
265
-        ImageJPEG($images[0], IMAGE_PATH . $user->id . '.jpg');
266
-        ImageJPEG($images[1], IMAGE_PATH . $user->id . '_sm.jpg');
265
+        ImageJPEG($images[0], IMAGE_PATH.$user->id.'.jpg');
266
+        ImageJPEG($images[1], IMAGE_PATH.$user->id.'_sm.jpg');
267 267
     }
268 268
     $response1 = sanitize_html($response1);
269 269
     $response2 = sanitize_html($response2);
270 270
 
271
-    $has_picture = $has_picture?1:0;
271
+    $has_picture = $has_picture ? 1 : 0;
272 272
     if ($profile) {
273 273
         $query = " response1 = '".BoincDb::escape_string($response1)."',"
274 274
             ." response2 = '".BoincDb::escape_string($response2)."',"
@@ -310,7 +310,7 @@  discard block
 block discarded – undo
310 310
     page_tail();
311 311
 }
312 312
 
313
-function show_profile_form($profile, $warning=null) {
313
+function show_profile_form($profile, $warning = null) {
314 314
     if ($profile) {
315 315
         page_head(tra("Edit your profile"), null, null, null, boinc_recaptcha_get_head_extra());
316 316
     } else {
Please login to merge, or discard this patch.
html/user/create_account_form.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -66,7 +66,7 @@  discard block
 block discarded – undo
66 66
     }
67 67
 }
68 68
 
69
-form_start("create_account_action.php","post");
69
+form_start("create_account_action.php", "post");
70 70
 create_account_form($teamid, $next_url);
71 71
 global $recaptcha_public_key;
72 72
 if ($recaptcha_public_key) {
@@ -77,5 +77,5 @@  discard block
 block discarded – undo
77 77
 
78 78
 page_tail();
79 79
 
80
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
80
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
81 81
 ?>
Please login to merge, or discard this patch.
html/inc/delete_account.inc 1 patch
Spacing   +8 added lines, -8 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
 if (!defined("DELETE_DELAY")) define("DELETE_DELAY", 2);
43 43
 
44 44
 function is_delete_account_token_valid($userid, $token) {
45
-    if (!is_valid_token($userid, $token, TOKEN_TYPE_DELETE_ACCOUNT) ) {
45
+    if (!is_valid_token($userid, $token, TOKEN_TYPE_DELETE_ACCOUNT)) {
46 46
         sleep(LOGIN_FAIL_SLEEP_SEC);
47 47
         return false;
48 48
     }
@@ -126,7 +126,7 @@  discard block
 block discarded – undo
126 126
 //
127 127
 function is_over_but_not_validated($res) {
128 128
     if ($res->server_state == RESULT_SERVER_STATE_OVER && $res->outcome == RESULT_OUTCOME_SUCCESS &&
129
-            ($res->validate_state == VALIDATE_STATE_INIT || $res->validate_state == VALIDATE_STATE_INCONCLUSIVE) ) {
129
+            ($res->validate_state == VALIDATE_STATE_INIT || $res->validate_state == VALIDATE_STATE_INCONCLUSIVE)) {
130 130
         return true;
131 131
     }    
132 132
     return false;
@@ -144,8 +144,8 @@  discard block
 block discarded – undo
144 144
 //
145 145
 function cancel_results_for_user($user) {
146 146
     $ress = BoincResult::enum("userid = $user->id");
147
-    $cancel_clause="server_state=".RESULT_SERVER_STATE_OVER.", outcome=".RESULT_OUTCOME_CLIENT_DETACHED.", validate_state=".VALIDATE_STATE_INVALID;
148
-    $set_id_clause="hostid=0, userid=0";
147
+    $cancel_clause = "server_state=".RESULT_SERVER_STATE_OVER.", outcome=".RESULT_OUTCOME_CLIENT_DETACHED.", validate_state=".VALIDATE_STATE_INVALID;
148
+    $set_id_clause = "hostid=0, userid=0";
149 149
     foreach ($ress as $res) {
150 150
         if (is_in_progress($res) || is_over_but_not_validated($res)) {
151 151
             $res->update($cancel_clause.", ".$set_id_clause);
@@ -168,12 +168,12 @@  discard block
 block discarded – undo
168 168
 
169 169
     // delete remote submit user
170 170
     //
171
-    delete_remote_submit_user($user);  // from submit_util.inc
171
+    delete_remote_submit_user($user); // from submit_util.inc
172 172
     
173 173
     // remove user's team records
174 174
     //
175
-    user_erase_team_owner($user);      // from team.inc
176
-    user_quit_team($user);        // from team.inc
175
+    user_erase_team_owner($user); // from team.inc
176
+    user_quit_team($user); // from team.inc
177 177
     user_erase_team_delta($user); // from team.inc
178 178
     
179 179
     // Items that do not have logic elsewhere
@@ -199,6 +199,6 @@  discard block
 block discarded – undo
199 199
     BoincConsent::delete_for_user($user->id);
200 200
 
201 201
     // final action
202
-    delete_user($user);  //from user_util.inc
202
+    delete_user($user); //from user_util.inc
203 203
     return 0;
204 204
 }
Please login to merge, or discard this patch.
html/user/user_agreetermsofuse_action.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -59,7 +59,7 @@
 block discarded – undo
59 59
 if ($checkct) {
60 60
     $rc1 = consent_to_a_policy($user, $ctid, 1, 0, 'Webform', time());
61 61
     if (!$rc1) {
62
-        error_page("Database error when attempting to INSERT into table consent with ID=$user->id. " . BoincDb::error() . " Please contact site administrators.");
62
+        error_page("Database error when attempting to INSERT into table consent with ID=$user->id. ".BoincDb::error()." Please contact site administrators.");
63 63
     }
64 64
 } else {
65 65
     error_page("Error: consent type for enrollment not found. Please contact site administrators.");
Please login to merge, or discard this patch.
html/inc/boinc_db.inc 1 patch
Spacing   +16 added lines, -16 removed lines patch added patch discarded remove patch
@@ -208,11 +208,11 @@  discard block
 block discarded – undo
208 208
         $db = BoincDb::get();
209 209
         return $db->update($this, 'user', $clause);
210 210
     }
211
-    static function enum($where_clause, $order_clause=null) {
211
+    static function enum($where_clause, $order_clause = null) {
212 212
         $db = BoincDb::get();
213 213
         return $db->enum('user', 'BoincUser', $where_clause, $order_clause);
214 214
     }
215
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
215
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
216 216
         $db = BoincDb::get();
217 217
         return $db->enum_fields(
218 218
             'user', 'BoincUser', $fields, $where_clause, $order_clause
@@ -261,7 +261,7 @@  discard block
 block discarded – undo
261 261
         $db = BoincDb::get();
262 262
         return $db->update($this, 'team', $clause);
263 263
     }
264
-    static function enum($where_clause, $order_clause=null) {
264
+    static function enum($where_clause, $order_clause = null) {
265 265
         $db = BoincDb::get();
266 266
         return $db->enum('team', 'BoincTeam', $where_clause, $order_clause);
267 267
     }
@@ -286,7 +286,7 @@  discard block
 block discarded – undo
286 286
         $db = BoincDb::get();
287 287
         return $db->max('team', $field);
288 288
     }
289
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
289
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
290 290
         $db = BoincDb::get();
291 291
         return $db->enum_fields(
292 292
             'team', 'BoincTeam', $fields, $where_clause, $order_clause
@@ -322,11 +322,11 @@  discard block
 block discarded – undo
322 322
         $db = BoincDb::get();
323 323
         return $db->delete($this, 'host');
324 324
     }
325
-    static function enum($where_clause, $order_clause=null) {
325
+    static function enum($where_clause, $order_clause = null) {
326 326
         $db = BoincDb::get();
327 327
         return $db->enum('host', 'BoincHost', $where_clause, $order_clause);
328 328
     }
329
-    static function enum_fields($fields, $where_clause, $order_clause=null) {
329
+    static function enum_fields($fields, $where_clause, $order_clause = null) {
330 330
         $db = BoincDb::get();
331 331
         return $db->enum_fields(
332 332
             'host', 'BoincHost', $fields, $where_clause, $order_clause
@@ -445,7 +445,7 @@  discard block
 block discarded – undo
445 445
         $db = BoincDb::get();
446 446
         return $db->update($this, 'app', $clause);
447 447
     }
448
-    static function sum($field, $clause=null) {
448
+    static function sum($field, $clause = null) {
449 449
         $db = BoincDb::get();
450 450
         return $db->sum('app', $field, $clause);
451 451
     }
@@ -501,11 +501,11 @@  discard block
 block discarded – undo
501 501
         $db = BoincDb::get();
502 502
         return $db->insert('profile', $clause);
503 503
     }
504
-    static function enum($where_clause=null, $order_clause=null) {
504
+    static function enum($where_clause = null, $order_clause = null) {
505 505
         $db = BoincDb::get();
506 506
         return $db->enum('profile', 'BoincProfile', $where_clause, $order_clause);
507 507
     }
508
-    static function enum_fields($fields, $where_clause=null, $order_clause=null) {
508
+    static function enum_fields($fields, $where_clause = null, $order_clause = null) {
509 509
         $db = BoincDb::get();
510 510
         return $db->enum_fields('profile', 'BoincProfile', $fields, $where_clause, $order_clause);
511 511
     }
@@ -889,12 +889,12 @@  discard block
 block discarded – undo
889 889
         return $db->enum('consent', 'BoincConsent', $where_clause);
890 890
     }
891 891
 
892
-    static function insert ($clause) {
892
+    static function insert($clause) {
893 893
         $db = BoincDb::get();
894 894
         return $db->insert('consent', $clause);
895 895
     }
896 896
 
897
-    static function update ($clause) {
897
+    static function update($clause) {
898 898
         $db = BoincDb::get();
899 899
         return $db->update_aux('consent', $clause);
900 900
     }
@@ -918,17 +918,17 @@  discard block
 block discarded – undo
918 918
         return $db->lookup('consent_type', 'BoincConsentType', $clause);
919 919
     }
920 920
 
921
-    static function enum($where_clause, $order_clause=null) {
921
+    static function enum($where_clause, $order_clause = null) {
922 922
         $db = BoincDb::get();
923 923
         return $db->enum('consent_type', 'BoincConsentType', $where_clause, $order_clause);
924 924
     }
925 925
 
926
-    static function insert ($clause) {
926
+    static function insert($clause) {
927 927
         $db = BoincDb::get();
928 928
         return $db->insert('consent_type', $clause);
929 929
     }
930 930
 
931
-    static function update ($clause) {
931
+    static function update($clause) {
932 932
         $db = BoincDb::get();
933 933
         return $db->update_aux('consent_type', $clause);
934 934
     }
@@ -953,7 +953,7 @@  discard block
 block discarded – undo
953 953
         return $db->lookup('latest_consent', 'BoincLatestConsent', $clause);
954 954
     }
955 955
 
956
-    static function enum($where_clause, $order_clause=null) {
956
+    static function enum($where_clause, $order_clause = null) {
957 957
         $db = BoincDb::get();
958 958
         return $db->enum('latest_consent', 'BoincLatestConsent', $where_clause, $order_clause);
959 959
     }
@@ -964,7 +964,7 @@  discard block
 block discarded – undo
964 964
 // apply this to any user-supplied strings used in queries
965 965
 // 
966 966
 function boinc_real_escape_string($x) {
967
-    if (version_compare(phpversion(),"4.3.0")>=0) {
967
+    if (version_compare(phpversion(), "4.3.0") >= 0) {
968 968
         return BoincDb::escape_string($x);
969 969
     } else {
970 970
         $x = str_replace("'", "\'", $x);
Please login to merge, or discard this patch.
html/inc/prefs_util.inc 1 patch
Spacing   +29 added lines, -29 removed lines patch added patch discarded remove patch
@@ -42,9 +42,9 @@  discard block
 block discarded – undo
42 42
 }
43 43
 
44 44
 abstract class PREF {
45
-    public $desc;       // short description
46
-    public $tooltip;    // longer description, shown as tooltip
47
-    public $tag;        // the pref's primary XML tag
45
+    public $desc; // short description
46
+    public $tooltip; // longer description, shown as tooltip
47
+    public $tag; // the pref's primary XML tag
48 48
     function __construct($desc, $tooltip, $tag) {
49 49
         $this->desc = $desc;
50 50
         $this->tooltip = $tooltip;
@@ -122,15 +122,15 @@  discard block
 block discarded – undo
122 122
 
123 123
 class PREF_BOOL extends PREF {
124 124
     public $default;
125
-    public $invert;     // show to user in opposite sense
126
-    function __construct($desc, $tooltip, $tag, $default, $invert=false) {
125
+    public $invert; // show to user in opposite sense
126
+    function __construct($desc, $tooltip, $tag, $default, $invert = false) {
127 127
         $this->default = $default;
128 128
         $this->invert = $invert;
129 129
         parent::__construct($desc, $tooltip, $tag);
130 130
     }
131 131
     function show_value($prefs) {
132 132
         $tag = $this->tag;
133
-        $v = $this->invert?!$prefs->$tag:$prefs->$tag;
133
+        $v = $this->invert ? !$prefs->$tag : $prefs->$tag;
134 134
         echo "<td>".readonly_checkbox($v)."</td>";
135 135
     }
136 136
     function show_form($prefs, $error) {
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
         }
143 143
         echo "<td ".VALUE_ATTRS.">"
144 144
             ."<input type=checkbox name=$this->tag "
145
-            . ($checked?"checked":"")
145
+            . ($checked ? "checked" : "")
146 146
             ."></td>
147 147
         ";
148 148
     }
@@ -155,7 +155,7 @@  discard block
 block discarded – undo
155 155
     function xml_string($prefs) {
156 156
         $tag = $this->tag;
157 157
         return "<$tag>"
158
-            .($prefs->$tag?"1":"0")
158
+            .($prefs->$tag ? "1" : "0")
159 159
             ."</$tag>\n";
160 160
     }
161 161
     function xml_parse(&$prefs, $name, $text) {
@@ -175,9 +175,9 @@  discard block
 block discarded – undo
175 175
     public $consent_type_id; // the consent_type_id from the consent_type table
176 176
     public $consent_name; // the consent_name to configure
177 177
     public $default;
178
-    public $invert;     // show to user in opposite sense
178
+    public $invert; // show to user in opposite sense
179 179
 
180
-    function __construct($desc, $tooltip, $tag, $consent_type_id, $consent_name, $default, $invert=false) {
180
+    function __construct($desc, $tooltip, $tag, $consent_type_id, $consent_name, $default, $invert = false) {
181 181
         $this->consent_type_id = $consent_type_id;
182 182
         $this->consent_name = $consent_name;
183 183
         $this->default = $default;
@@ -231,7 +231,7 @@  discard block
 block discarded – undo
231 231
         } else {
232 232
             $value = false;
233 233
         }
234
-        echo "<td>" . readonly_checkbox($value) . "</td>";
234
+        echo "<td>".readonly_checkbox($value)."</td>";
235 235
     }
236 236
     function show_form($user, $error) {
237 237
         $consent_type_id = $this->consent_type_id;
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
         }
248 248
         echo "<td ".VALUE_ATTRS.">"
249 249
             ."<input type=checkbox name=$this->tag "
250
-            . ($checked?"checked":"")
250
+            . ($checked ? "checked" : "")
251 251
             ."></td>
252 252
         ";
253 253
     }
@@ -264,8 +264,8 @@  discard block
 block discarded – undo
264 264
         // to this consent type.
265 265
         $cr = BoincLatestConsent::lookup("userid={$user->id} AND consent_type_id='${consent_type_id}'");
266 266
 
267
-        if ( (($cr) and ($cr->consent_flag!=$flag)) or
268
-             (!$cr) ) {
267
+        if ((($cr) and ($cr->consent_flag != $flag)) or
268
+             (!$cr)) {
269 269
             $rc = consent_to_a_policy($user, $consent_type_id, $flag, 0, 'Webform', time());
270 270
             if (!$rc) {
271 271
                 error_page(tra("Database error:").BoincDb::error());
@@ -301,7 +301,7 @@  discard block
 block discarded – undo
301 301
         // this is the value if they check the box
302 302
     public $scale;
303 303
 
304
-    function __construct($suffix, $min, $max, $default, $scale=1, $default2=0) {
304
+    function __construct($suffix, $min, $max, $default, $scale = 1, $default2 = 0) {
305 305
         $this->suffix = " $suffix";
306 306
         $this->min = $min;
307 307
         $this->max = $max;
@@ -320,7 +320,7 @@  discard block
 block discarded – undo
320 320
         $v .= "$this->suffix ";
321 321
         return $v;
322 322
     }
323
-    function form_str($tag, $v, $had_error, $disabled=false, $id=null) {
323
+    function form_str($tag, $v, $had_error, $disabled = false, $id = null) {
324 324
         if (is_numeric($v)) {
325 325
             $v /= $this->scale;
326 326
             if (!$had_error && ($v < $this->min || $v > $this->max)) {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
             }
329 329
         }
330 330
         if ($disabled) $v = "";
331
-        $i = $id?"id=\"$id\"":"";
331
+        $i = $id ? "id=\"$id\"" : "";
332 332
         return '<input type="text" size="5" class="form-control input-sm" name="'.$tag.'" value="'.$v."\" $disabled $i> &nbsp; $this->suffix ";
333 333
     }
334 334
     function form_convert($in, &$out, &$error) {
@@ -451,8 +451,8 @@  discard block
 block discarded – undo
451 451
         $text_id = $this->tag;
452 452
         $default = $this->num_spec->get_default();
453 453
         $val = $prefs->$tag;
454
-        $c = $val?"checked":"";
455
-        $d = $val?"":"disabled";
454
+        $c = $val ? "checked" : "";
455
+        $d = $val ? "" : "disabled";
456 456
         echo "<td $attrs>"
457 457
             ."<input type=checkbox id=$checkbox_id onClick=\"checkbox_clicked('$checkbox_id', '$text_id', $default)\" $c> &nbsp;"
458 458
             .$this->num_spec->form_str($tag, $prefs->$tag, $had_error, $d, $text_id)
@@ -565,8 +565,8 @@  discard block
 block discarded – undo
565 565
 function hour_select($x, $name, $id, $d) {
566 566
     $s = "";
567 567
     $s .= "<select class=\"selectbox form-control input-sm\" name=$name id=$id $d>\n";
568
-    for ($i=0; $i<24; $i++) {
569
-        $sel = ($x == $i)?"selected":"";
568
+    for ($i = 0; $i < 24; $i++) {
569
+        $sel = ($x == $i) ? "selected" : "";
570 570
         $s .= "<option value=$i $sel> $i:00";
571 571
     }
572 572
     $s .= "</select>\n";
@@ -667,7 +667,7 @@  discard block
 block discarded – undo
667 667
 
668 668
 // row_defs - Display a value for all 4 venues in one row
669 669
 //
670
-function row_defs($pre, $item, $post, $type, $prefs, $tooltip=null) {
670
+function row_defs($pre, $item, $post, $type, $prefs, $tooltip = null) {
671 671
     $gen = $prefs->$item;
672 672
     $hom  = (isset($prefs->home) && isset($prefs->home->$item)) ? $prefs->home->$item : "--";
673 673
     $schl = (isset($prefs->school) && isset($prefs->school->$item)) ? $prefs->school->$item : "--";
@@ -679,10 +679,10 @@  discard block
 block discarded – undo
679 679
         echo "<tr>";
680 680
     }
681 681
     echo "<td ".NAME_ATTRS.">$pre</td>";
682
-    row_field($gen,  $type);
683
-    row_field($hom,  $type);
682
+    row_field($gen, $type);
683
+    row_field($hom, $type);
684 684
     row_field($schl, $type);
685
-    row_field($wrk,  $type);
685
+    row_field($wrk, $type);
686 686
     echo "<td align=left>$post</td></tr>\n";
687 687
 }
688 688
 
@@ -692,16 +692,16 @@  discard block
 block discarded – undo
692 692
 function row_field($value, $type) {
693 693
     echo "<td>";
694 694
     $type = $value === "--" ? "--" : $type;
695
-    switch($type) {
695
+    switch ($type) {
696 696
     case "yesno":
697
-        echo $value ?tra("yes"):tra("no");
697
+        echo $value ?tra("yes") : tra("no");
698 698
         break;
699 699
     case "noyes":
700
-        echo $value ?tra("no"):tra("yes");
700
+        echo $value ?tra("no") : tra("yes");
701 701
         break;
702 702
     case "limit":
703 703
         $x = max_bytes_display_mode($value);
704
-        $y = "$x " . BYTE_ABBR;
704
+        $y = "$x ".BYTE_ABBR;
705 705
         echo $x ? "$y" : tra("no limit");
706 706
         break;
707 707
     case "minutes":
Please login to merge, or discard this patch.
drupal/sites/default/boinc/modules/boincuser/boincuser.admin.inc 1 patch
Spacing   +13 added lines, -13 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@  discard block
 block discarded – undo
120 120
     '#default_value' => $default['boinc_server_status_url'],
121 121
     '#description' => t('An absolute URL or path relative to the site base to the server status page (e.g. %full_url or just %relative_url).',
122 122
       array(
123
-        '%full_url' => $base_url . '/server_status.php',
123
+        '%full_url' => $base_url.'/server_status.php',
124 124
         '%relative_url' => 'server_status.php',
125 125
       )
126 126
     ),
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     '#default_value' => $default['boinc_app_list_url'],
132 132
     '#description' => t('An absolute URL or path relative to the site base to the applications page (e.g. %full_url or just %relative_url).',
133 133
       array(
134
-        '%full_url' => $base_url . '/apps.php',
134
+        '%full_url' => $base_url.'/apps.php',
135 135
         '%relative_url' => 'apps.php',
136 136
       )
137 137
     ),
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
     '#type' => 'checkbox',
355 355
     '#title' => t('Enable create_account.php RPC'),
356 356
     '#default_value' => $default['boinc_weboptions_enableaccountcreateRPC'],
357
-    '#description' => t('If checked, users will be able to create an account remotely using the create_account.php RPC. This option is independent of the user regsitration option found in ') . l(t('User management -> User settings'), '/admin/user/settings') . '. If enabled, user <b>may not be able to see and agree to the terms-of-use</b> to your site\'s privacy and data retention policies!',
357
+    '#description' => t('If checked, users will be able to create an account remotely using the create_account.php RPC. This option is independent of the user regsitration option found in ').l(t('User management -> User settings'), '/admin/user/settings').'. If enabled, user <b>may not be able to see and agree to the terms-of-use</b> to your site\'s privacy and data retention policies!',
358 358
   );
359 359
 
360 360
   $form['boinc_weboptions_registrationtitle'] = array(
@@ -409,32 +409,32 @@  discard block
 block discarded – undo
409 409
     '#rows' => 8,
410 410
     '#description' => t('A list of Drupal URLs/paths to ignore for Terms of Use (ToU). If the option above \'Are existing users forced to agree to the Terms of Use?\' is activated, then some paths need to be ignored when checking if a user has agreed to the ToU. A good example is the logout path, "logout", or else users will not be able to logout!
411 411
 <p>There is a default list of paths that must be ignored or else the site will not function. They are not included in this box. Here you may provide additional paths to be ignored, for example the privacy policy page may be accessible so that users may read it before agreeing to the site\'s ToU.
412
-<p>Paths should be entered one per line. All paths should be <em>lower-case</em> and  should not include a leading \'/\'. Example: account/info/edit will allow the user to visit ' . $base_url . '/account/info/edit without first agreeing to the ToU. Regexp are allowed. Example: account/* will allow the user to visit any path starting with ' . $base_url . '/account/.'),
412
+<p>Paths should be entered one per line. All paths should be <em>lower-case</em> and  should not include a leading \'/\'. Example: account/info/edit will allow the user to visit ' . $base_url.'/account/info/edit without first agreeing to the ToU. Regexp are allowed. Example: account/* will allow the user to visit any path starting with '.$base_url.'/account/.'),
413 413
   );
414 414
 
415 415
   $form['pathtitle'] = array(
416 416
     '#value' => '<h3>Path Options</h3>',
417 417
   );
418 418
 
419
-  $form['boinc_weboptions_accountfinish'] = array (
419
+  $form['boinc_weboptions_accountfinish'] = array(
420 420
     '#type' => 'textfield',
421 421
     '#title' => t('Path to a custom account_finish.php page, should be a path to a node'),
422 422
     '#description' => t('Provide a path to a node which will serve as your site\'s landing page for users create an account using the BOINC client manager. They will be directed to this page after the account is created. If blank, a default account_finish page will be used.<br>Examples: account_finish, content/welcome, node/123'),
423 423
     '#default_value' => $default['boinc_weboptions_accountfinish'],
424 424
   );
425
-  $form['boinc_weboptions_moderationpage'] = array (
425
+  $form['boinc_weboptions_moderationpage'] = array(
426 426
     '#type' => 'textfield',
427 427
     '#title' => t('Path to the site\'s content moderation info page, should be a path to a node'),
428 428
     '#description' => t('Provide a path to a node which will serve as your site\'s page for account/content moderation information. This will be used on the default account_finish page. If blank, no link to a moderation page will be provided. If a path is provided to the custom account_finish.php page (above), this field will be ignored.<br>Examples: moderation, content/moderation, node/456'),
429 429
     '#default_value' => $default['boinc_weboptions_moderationpage'],
430 430
   );
431
-  $form['boinc_weboptions_rulespolicies'] = array (
431
+  $form['boinc_weboptions_rulespolicies'] = array(
432 432
     '#type' => 'textfield',
433 433
     '#title' => t('Path to the site\'s rule and policies page, should be a path to a node'),
434 434
     '#description' => t('Provide a path to a node which will serve as your site\'s rules and policies page. This will be used on the Join page shown to new users. If blank, no link to a rules and policies page will be provided.<br>Examples: rules-and-policies, node/789'),
435 435
     '#default_value' => $default['boinc_weboptions_rulespolicies'],
436 436
   );
437
-  $form['boinc_other_frontpage'] = array (
437
+  $form['boinc_other_frontpage'] = array(
438 438
     '#type' => 'textarea',
439 439
     '#title' => bts('Message for site\'s Home Page', array(), NULL, 'boinc:admin-boinc-other-options'),
440 440
     '#default_value' => $default['boinc_other_frontpage'],
@@ -447,7 +447,7 @@  discard block
 block discarded – undo
447 447
     '#value' => '<h3>Other Options</h3>',
448 448
   );
449 449
 
450
-  $form['boinc_weboptions_blacklisted_usernames'] = array (
450
+  $form['boinc_weboptions_blacklisted_usernames'] = array(
451 451
     '#type' => 'textarea',
452 452
     '#title' => t('BOINC username blacklist'),
453 453
     '#default_value' => $default['boinc_weboptions_blacklisted_usernames'],
@@ -466,17 +466,17 @@  discard block
 block discarded – undo
466 466
   $values = $form_state['values'];
467 467
 
468 468
   $accountfinish = $values['boinc_weboptions_accountfinish'];
469
-  if ( ($accountfinish) AND (!drupal_lookup_path('source', $accountfinish)) ) {
469
+  if (($accountfinish) AND (!drupal_lookup_path('source', $accountfinish))) {
470 470
     form_set_error('boinc weboptions_accountfinish', t('Path to custom account finish page not found. Please provide a valid path, or leave blank to unset.'));
471 471
   }
472 472
 
473 473
   $moderationpage = $values['boinc_weboptions_moderationpage'];
474
-  if ( ($moderationpage) AND (!drupal_lookup_path('source', $moderationpage)) ) {
474
+  if (($moderationpage) AND (!drupal_lookup_path('source', $moderationpage))) {
475 475
     form_set_error('boinc weboptions_moderationpage', t('Path to moderation page not found. Please provide a valid path, or leave blank to unset.'));
476 476
   }
477 477
 
478 478
   $rulespolicies = $values['boinc_weboptions_rulespolicies'];
479
-  if ( ($rulespolicies) AND (!drupal_lookup_path('source', $rulespolicies)) ) {
479
+  if (($rulespolicies) AND (!drupal_lookup_path('source', $rulespolicies))) {
480 480
     form_set_error('boinc weboptions_rulespolicies', t('Path to rules and policies page not found. Please provide a valid path, or leave blank to unset.'));
481 481
   }
482 482
 }
@@ -485,5 +485,5 @@  discard block
 block discarded – undo
485 485
   * Submit BOINC other form
486 486
   */
487 487
 function boincuser_admin_weboptions_submit($form, &$form_state) {
488
-  drupal_set_message( bts("Status: Drupa-BOINC Web site options have been updated", array(), NULL, 'boinc:admin-boinc-website-options') );
488
+  drupal_set_message(bts("Status: Drupa-BOINC Web site options have been updated", array(), NULL, 'boinc:admin-boinc-website-options'));
489 489
 }
Please login to merge, or discard this patch.
html/inc/user.inc 1 patch
Spacing   +14 added lines, -14 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@  discard block
 block discarded – undo
33 33
 // they've participated in
34 34
 //
35 35
 function get_other_projects($user) {
36
-    $cpid = md5($user->cross_project_id . $user->email_addr);
36
+    $cpid = md5($user->cross_project_id.$user->email_addr);
37 37
     $url = "http://boinc.netsoft-online.com/get_user.php?cpid=".$cpid;
38 38
 
39 39
     // Check the cache for that URL
@@ -174,7 +174,7 @@  discard block
 block discarded – undo
174 174
     }
175 175
 
176 176
     if (!NO_STATS) {
177
-        $cpid = md5($user->cross_project_id . $user->email_addr);
177
+        $cpid = md5($user->cross_project_id.$user->email_addr);
178 178
         $x = "";
179 179
         shuffle($cpid_stats_sites);
180 180
         foreach ($cpid_stats_sites as $site) {
@@ -328,7 +328,7 @@  discard block
 block discarded – undo
328 328
 // if $badge_height is > 0, show badges
329 329
 // if $name_limit, limit name to N chars
330 330
 //
331
-function user_links($user, $badge_height=0, $name_limit=0) {
331
+function user_links($user, $badge_height = 0, $name_limit = 0) {
332 332
     BoincForumPrefs::lookup($user);
333 333
     if (is_banished($user)) {
334 334
         return "(banished: ID $user->id)";
@@ -343,13 +343,13 @@  discard block
 block discarded – undo
343 343
         $name = substr($name, 0, $name_limit)."...";
344 344
     }
345 345
     $x .= " <a href=\"".url_base()."show_user.php?userid=".$user->id."\">".$name."</a>";
346
-    if (function_exists("project_user_links")){
346
+    if (function_exists("project_user_links")) {
347 347
         $x .= project_user_links($user);
348 348
     }
349 349
     if ($badge_height) {
350 350
         $x .= badges_string(true, $user, $badge_height);
351 351
     }
352
-    return $name_limit?"<nobr>$x</nobr>":$x;
352
+    return $name_limit ? "<nobr>$x</nobr>" : $x;
353 353
 }
354 354
 
355 355
 function show_community_private($user) {
@@ -396,7 +396,7 @@  discard block
 block discarded – undo
396 396
 
397 397
             // if there's a foundership request, notify the founder
398 398
             //
399
-            if ($user->id==$team->userid && $team->ping_user >0) {
399
+            if ($user->id == $team->userid && $team->ping_user > 0) {
400 400
                 $x .= "<p class=\"text-danger\">".tra("(foundership change request pending)")."</p>";
401 401
             }
402 402
             row2(tra("Member of team"), $x);
@@ -421,7 +421,7 @@  discard block
 block discarded – undo
421 421
     $x = "<a href=\"user_search.php\">".tra("Find friends")."</a><br/>\n";
422 422
     $n = count($friends);
423 423
     if ($n) {
424
-        foreach($friends as $friend) {
424
+        foreach ($friends as $friend) {
425 425
             $fuser = BoincUser::lookup_id($friend->user_dest);
426 426
             if (!$fuser) continue;
427 427
             $x .= friend_links($fuser);
@@ -464,7 +464,7 @@  discard block
 block discarded – undo
464 464
 // Returns a cacheable community links data object
465 465
 // @param user The user to produce a community links object for
466 466
 
467
-function get_community_links_object($user){
467
+function get_community_links_object($user) {
468 468
     $cache_object = new StdClass;
469 469
     $cache_object->post_count = total_posts($user);
470 470
     $cache_object->user = $user;
@@ -472,7 +472,7 @@  discard block
 block discarded – undo
472 472
     $cache_object->friends = array();
473 473
 
474 474
     $friends = BoincFriend::enum("user_src=$user->id and reciprocated=1");
475
-    foreach($friends as $friend) {
475
+    foreach ($friends as $friend) {
476 476
         $fuser = BoincUser::lookup_id($friend->user_dest);
477 477
         if (!$fuser) continue;
478 478
         $cache_object->friends[] = $fuser;
@@ -480,7 +480,7 @@  discard block
 block discarded – undo
480 480
     return $cache_object;
481 481
 }
482 482
 
483
-function community_links($clo, $logged_in_user){
483
+function community_links($clo, $logged_in_user) {
484 484
     $user = $clo->user;
485 485
     $team = $clo->team;
486 486
     $friends = $clo->friends;
@@ -506,15 +506,15 @@  discard block
 block discarded – undo
506 506
                 "<a href=\"friend.php?action=cancel_confirm&userid=$user->id\">".tra("Cancel friendship")."</a>"
507 507
             );
508 508
         } else if ($friend) {
509
-            row2(tra("Friends"),  "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Request pending")."</a>");
509
+            row2(tra("Friends"), "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Request pending")."</a>");
510 510
         } else {
511
-            row2(tra("Friends"),  "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Add as friend")."</a>");
511
+            row2(tra("Friends"), "<a href=\"friend.php?action=add&userid=$user->id\">".tra("Add as friend")."</a>");
512 512
         }
513 513
     }
514 514
     
515 515
     if ($friends) {
516 516
         $x = "";
517
-        foreach($friends as $friend) {
517
+        foreach ($friends as $friend) {
518 518
             $x .= friend_links($friend);
519 519
         }
520 520
         row2(tra("Friends")." (".sizeof($friends).")", $x);
@@ -558,6 +558,6 @@  discard block
 block discarded – undo
558 558
 }
559 559
 
560 560
 
561
-$cvs_version_tracker[]="\$Id$";  //Generated automatically - do not edit
561
+$cvs_version_tracker[] = "\$Id$"; //Generated automatically - do not edit
562 562
 
563 563
 ?>
Please login to merge, or discard this patch.