Passed
Pull Request — master (#5681)
by
unknown
10:29
created
drupal/sites/default/boinc/modules/boincuser/boincuser.module 1 patch
Upper-Lower-Casing   +168 added lines, -168 removed lines patch added patch discarded remove patch
@@ -83,7 +83,7 @@  discard block
 block discarded – undo
83 83
     'weight' => 5
84 84
   );
85 85
   $items['moderate/profile/%/reject'] = array(
86
-    'title' => bts('Reject profile', array(), NULL, 'boinc:moderate-user'),
86
+    'title' => bts('Reject profile', array(), null, 'boinc:moderate-user'),
87 87
     'description' => 'Reject profile content',
88 88
     'page callback' => 'drupal_get_form',
89 89
     'page arguments' => array('boincuser_moderate_profile_reject_form', 2),
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     'weight' => 5
93 93
   );
94 94
   $items['moderate/user/%/ban'] = array(
95
-    'title' => bts('Ban user', array(), NULL, 'boinc:moderate-ban-user'),
95
+    'title' => bts('Ban user', array(), null, 'boinc:moderate-ban-user'),
96 96
     'description' => 'Ban a user from using community features',
97 97
     'page callback' => 'drupal_get_form',
98 98
     'page arguments' => array('boincuser_moderate_user_ban_form', 2),
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     'weight' => 5
124 124
   );
125 125
   $items['user/login/auth'] = array(
126
-    'title' => bts('Authenticator login', array(), NULL, 'boinc:authenticator-login-page'),
126
+    'title' => bts('Authenticator login', array(), null, 'boinc:authenticator-login-page'),
127 127
     'description' => 'Log in using a user authenticator',
128 128
     'page callback' => 'drupal_get_form',
129 129
     'page arguments' => array('boincuser_authloginform'),
@@ -131,7 +131,7 @@  discard block
 block discarded – undo
131 131
     'type' => MENU_CALLBACK,
132 132
   );
133 133
   $items['user/termsofuse'] = array(
134
-    'title' => bts('Terms of Use', array(), NULL, 'boinc:termsofuse-form'),
134
+    'title' => bts('Terms of Use', array(), null, 'boinc:termsofuse-form'),
135 135
     'description' => 'A site\'s term of use.',
136 136
     'page callback' => 'drupal_get_form',
137 137
     'page arguments' => array('boincuser_termsofuse_form'),
@@ -185,19 +185,19 @@  discard block
 block discarded – undo
185 185
     'title' => 'Create Account RPC',
186 186
     'description' => 'RPC for creating user accounts.',
187 187
     'page callback' => 'boincuser_create_account',
188
-    'access callback' => TRUE,
188
+    'access callback' => true,
189 189
     'type' => MENU_CALLBACK
190 190
   );
191 191
   $items['account_finish.php'] = array(
192 192
     'title' => 'Welcome to ' . variable_get('site_name', 'Drupal-BOINC'),
193 193
     'description' => 'RPC for after a user has created an account.',
194 194
     'page callback' => 'boincuser_account_finish',
195
-    'access callback' => TRUE,
195
+    'access callback' => true,
196 196
     'type' => MENU_CALLBACK,
197 197
   );
198 198
   $items['boincuser/autocomplete'] = array(
199 199
     'page callback' => '_boincuser_user_name_autocomplete',
200
-    'access callback' => TRUE,
200
+    'access callback' => true,
201 201
     'type' => MENU_CALLBACK,
202 202
   );
203 203
   $items['user/%user/recoveremail/%'] = array(
@@ -212,7 +212,7 @@  discard block
 block discarded – undo
212 212
     'title' => t('Recover previous email'),
213 213
     'description' => t('redirect'),
214 214
     'page callback' => '_boincuser_redirect_recover_email',
215
-    'access callback' => TRUE,
215
+    'access callback' => true,
216 216
     'type' => MENU_CALLBACK,
217 217
   );
218 218
   return $items;
@@ -247,7 +247,7 @@  discard block
 block discarded – undo
247 247
   // Check if user has agreed to the terms of use. If not, send the
248 248
   // user to the terms-of-use form. This is only makes sense if the
249 249
   // termsofuse is enabled, by having text in the termsofuse variable.
250
-  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
250
+  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', false);
251 251
   $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
252 252
   if ( (!empty($termsofuse)) and ($user->uid) ) {
253 253
     if ( !boincuser_check_termsofuse($user) and ($existinguser_tou) ) {
@@ -296,7 +296,7 @@  discard block
 block discarded – undo
296 296
  * Implementation of hook_user(); add custom actions to standard
297 297
  * Drupal user operations
298 298
  */
299
-function boincuser_user($op, &$edit, &$account, $category = NULL) {
299
+function boincuser_user($op, &$edit, &$account, $category = null) {
300 300
   require_boinc('boinc_db');
301 301
   require_boinc('user');
302 302
   require_boinc('xml');
@@ -345,7 +345,7 @@  discard block
 block discarded – undo
345 345
       $account->boincuser_email_addr_change_time = $boinc_user->email_addr_change_time;
346 346
       db_set_active('default');
347 347
       // Set Drupal team ID
348
-      $account->team = NULL;
348
+      $account->team = null;
349 349
       if ($account->boincteam_id) {
350 350
         $account->team = db_result(db_query("
351 351
           SELECT nid FROM {boincteam} WHERE team_id = %d",
@@ -453,7 +453,7 @@  discard block
 block discarded – undo
453 453
         $boinc_user = boincuser_register_make_user($user_params);
454 454
         if (!$boinc_user) {
455 455
           // Account exists with this email addr
456
-          form_set_error('email', bts('Error creating BOINC account.', array(), NULL, 'boinc:add-new-user'));
456
+          form_set_error('email', bts('Error creating BOINC account.', array(), null, 'boinc:add-new-user'));
457 457
           return;
458 458
         }
459 459
 
@@ -499,9 +499,9 @@  discard block
 block discarded – undo
499 499
         case 'user_account':
500 500
           // Ensure that BOINC data is altered
501 501
 
502
-          $changing_email = ($edit['mail'] AND $edit['mail'] != $boinc_user->email_addr) ? true : false;
502
+          $changing_email = ($edit['mail'] and $edit['mail'] != $boinc_user->email_addr) ? true : false;
503 503
           $changing_pass = ($edit['pass']) ? true : false;
504
-          if ($changing_email OR $changing_pass) {
504
+          if ($changing_email or $changing_pass) {
505 505
             // set email address to lower-case
506 506
             $lower_email_addr = strtolower($edit['mail']);
507 507
 
@@ -583,13 +583,13 @@  discard block
 block discarded – undo
583 583
  *(forward compatible to Drupal 7).
584 584
  */
585 585
 function boincuser_user_login(&$edit, $account) {
586
-  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
586
+  $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', false);
587 587
   $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
588 588
 
589 589
   // Use the same code as boincuser_form_alter(), for case
590 590
   // 'user_profile_form', if the refering page is the user password
591 591
   // reset form, then do not check for terms of use.
592
-  $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/$account->uid") === FALSE) ? 0 : 1;
592
+  $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/$account->uid") === false) ? 0 : 1;
593 593
   if ($reset_pass) {
594 594
     return;
595 595
   }
@@ -737,7 +737,7 @@  discard block
 block discarded – undo
737 737
 
738 738
       // General friend form overrides
739 739
       $form['flag_friend_submit']['#prefix'] = '<li class="first tab">';
740
-      $form['flag_friend_submit']['#value'] = bts('Send request', array(), NULL, 'boinc:friends-page');
740
+      $form['flag_friend_submit']['#value'] = bts('Send request', array(), null, 'boinc:friends-page');
741 741
       $form['flag_friend_submit']['#type'] = 'submit';
742 742
       $form['flag_friend_submit']['#suffix'] = '</li>';
743 743
       $form['flag_friend_submit']['#weight'] = 1002;
@@ -746,7 +746,7 @@  discard block
 block discarded – undo
746 746
       case FLAG_FRIEND_BOTH:
747 747
       case FLAG_FRIEND_FLAGGED:
748 748
         unset($form['actions']);
749
-        $form['flag_friend_submit']['#value'] = bts('Remove friend', array(), NULL, 'boinc:friends-remove');
749
+        $form['flag_friend_submit']['#value'] = bts('Remove friend', array(), null, 'boinc:friends-remove');
750 750
         // Add in our hack handler to fix the flag_friend module
751 751
         $final_handler = array_pop($form['#submit']);
752 752
         $form['#submit'][] = 'boincuser_fix_unfriend_form_submit';
@@ -754,21 +754,21 @@  discard block
 block discarded – undo
754 754
         break;
755 755
       case FLAG_FRIEND_PENDING:
756 756
         unset($form['actions']);
757
-        $form['flag_friend_submit']['#value'] = bts('Remove request', array(), NULL, 'boinc:friends-page');
757
+        $form['flag_friend_submit']['#value'] = bts('Remove request', array(), null, 'boinc:friends-page');
758 758
         break;
759 759
       case FLAG_FRIEND_APPROVAL:
760 760
         if ($action == 'flag') {
761
-          $form['flag_friend_submit']['#value'] = bts('Approve request', array(), NULL, 'boinc:friends-page');
761
+          $form['flag_friend_submit']['#value'] = bts('Approve request', array(), null, 'boinc:friends-page');
762 762
         }
763 763
         elseif ($action == 'unflag') {
764 764
           unset($form['actions']);
765
-          $form['flag_friend_submit']['#value'] = bts('Deny request', array(), NULL, 'boinc:friends-page');
765
+          $form['flag_friend_submit']['#value'] = bts('Deny request', array(), null, 'boinc:friends-page');
766 766
         }
767 767
         break;
768 768
       case FLAG_FRIEND_UNFLAGGED:
769 769
       default:
770 770
         $user_links[] = array(
771
-          'title' => bts('Add as friend', array(), NULL, 'boinc:friends-add'),
771
+          'title' => bts('Add as friend', array(), null, 'boinc:friends-add'),
772 772
           'href' => "flag/confirm/flag/friend/{$account->uid}"
773 773
         );
774 774
       }
@@ -778,7 +778,7 @@  discard block
 block discarded – undo
778 778
     }
779 779
 
780 780
     $form['cancel'] = array(
781
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $cancel_dest) . '</li>',
781
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), $cancel_dest) . '</li>',
782 782
       '#weight' => 1004,
783 783
     );
784 784
     $form['form control tabs suffix'] = array(
@@ -801,7 +801,7 @@  discard block
 block discarded – undo
801 801
       '#weight' => 1001,
802 802
     );
803 803
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
804
-    $form['buttons']['submit']['#value'] = bts('Save changes', array(), NULL, 'boinc:form-save');
804
+    $form['buttons']['submit']['#value'] = bts('Save changes', array(), null, 'boinc:form-save');
805 805
     $form['buttons']['submit']['#suffix'] = '</li>';
806 806
     $form['buttons']['submit']['#weight'] = 1002;
807 807
     $form['buttons']['preview']['#prefix'] = '<li class="tab">';
@@ -811,7 +811,7 @@  discard block
 block discarded – undo
811 811
     $form['buttons']['preview_changes']['#suffix'] = '</li>';
812 812
     $form['buttons']['preview_changes']['#weight'] = 1004;
813 813
     $form['buttons']['cancel'] = array(
814
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
814
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
815 815
       '#weight' => 1005,
816 816
     );
817 817
     $form['buttons']['delete']['#prefix'] = '<li class="tab">';
@@ -839,11 +839,11 @@  discard block
 block discarded – undo
839 839
       '#weight' => 1001,
840 840
     );
841 841
     $form['actions']['submit']['#prefix'] = '<li class="first tab">';
842
-    $form['actions']['submit']['#value'] = bts('Delete', array(), NULL, 'boinc:form-delete');
842
+    $form['actions']['submit']['#value'] = bts('Delete', array(), null, 'boinc:form-delete');
843 843
     $form['actions']['submit']['#suffix'] = '</li>';
844 844
     $form['actions']['submit']['#weight'] = 1002;
845 845
     $form['actions']['cancel'] = array(
846
-        '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
846
+        '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), "node/{$form['nid']['#value']}") . '</li>',
847 847
       '#weight' => 1005,
848 848
     );
849 849
     $form['actions']['form control tabs suffix'] = array(
@@ -863,14 +863,14 @@  discard block
 block discarded – undo
863 863
       '#weight' => 1001,
864 864
     );
865 865
     $form['privatemsg']['submit']['#prefix'] = '<li class="first tab">';
866
-    $form['privatemsg']['submit']['#value'] = bts('Send message', array(), NULL, 'boinc:private-message');
866
+    $form['privatemsg']['submit']['#value'] = bts('Send message', array(), null, 'boinc:private-message');
867 867
     $form['privatemsg']['submit']['#suffix'] = '</li>';
868 868
     $form['privatemsg']['submit']['#weight'] = 1002;
869 869
     $form['privatemsg']['preview']['#prefix'] = '<li class="tab">';
870 870
     $form['privatemsg']['preview']['#suffix'] = '</li>';
871 871
     $form['privatemsg']['preview']['#weight'] = 1003;
872 872
     $form['privatemsg']['cancel'] = array(
873
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
873
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), $_GET['q']) . '</li>',
874 874
       '#weight' => 1004,
875 875
     );
876 876
     $form['privatemsg']['form control tabs suffix'] = array(
@@ -885,18 +885,18 @@  discard block
 block discarded – undo
885 885
   // Login form
886 886
   case 'user_login':
887 887
   case 'user_login_block':
888
-      drupal_set_title(bts('Login', array(), NULL, 'boinc:menu-link'));
888
+      drupal_set_title(bts('Login', array(), null, 'boinc:menu-link'));
889 889
     // Replace name with email in login form
890 890
     unset($form['name']);
891 891
     array_unshift($form, array(
892 892
       'email' => array(
893 893
         '#type' => 'textfield',
894
-        '#title' => bts('Email address', array(), NULL, 'boinc:email-address-to-login'),
894
+        '#title' => bts('Email address', array(), null, 'boinc:email-address-to-login'),
895 895
         '#size' => ($form_id == 'user_login_block') ? 15 : 60,
896 896
         '#maxlength' => EMAIL_MAX_LENGTH,
897
-        '#required' => TRUE,
897
+        '#required' => true,
898 898
         '#attributes' => array('tabindex' => '1'),
899
-        '#description' => bts('Enter your @s email address.', array('@s' => variable_get('site_name', 'Drupal-BOINC')), NULL, 'boinc:standard-login-page')
899
+        '#description' => bts('Enter your @s email address.', array('@s' => variable_get('site_name', 'Drupal-BOINC')), null, 'boinc:standard-login-page')
900 900
       ),
901 901
       'validation_source' => array(
902 902
         '#type' => 'hidden',
@@ -912,7 +912,7 @@  discard block
 block discarded – undo
912 912
     );
913 913
     $form['buttons']['submit'] = $form['submit'];
914 914
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
915
-    $form['buttons']['submit']['#value'] = bts('Log in', array(), NULL, 'boinc:standard-login-page');
915
+    $form['buttons']['submit']['#value'] = bts('Log in', array(), null, 'boinc:standard-login-page');
916 916
     $form['buttons']['submit']['#suffix'] = '</li>';
917 917
     $form['buttons']['submit']['#weight'] = 1002;
918 918
     $form['buttons']['form control tabs suffix'] = array(
@@ -928,7 +928,7 @@  discard block
 block discarded – undo
928 928
     if (isset($form_state['post']['email']) and isset($form_state['post']['pass'])) {
929 929
       // Find the local validation function's entry so we can replace it.
930 930
       $array_key = array_search('user_login_authenticate_validate', $form['#validate']);
931
-      if ($array_key === FALSE) {
931
+      if ($array_key === false) {
932 932
         // Could not find it. Some other module must have run form_alter().
933 933
         // We will simply add our validation just before the final validator.
934 934
         $final_validator = array_pop($form['#validate']);
@@ -956,26 +956,26 @@  discard block
 block discarded – undo
956 956
     }
957 957
 
958 958
     // Set special message if user has not agreed to TOU
959
-    $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', FALSE);
959
+    $existinguser_tou = variable_get('boinc_weboptions_existinguser_tou', false);
960 960
     $termsofuse = variable_get('boinc_weboptions_termsofuse', '');
961 961
     if ( (!boincuser_check_termsofuse($account)) and ($existinguser_tou) and (!empty($termsofuse)) and (!user_access('administer users')) ) {
962 962
       drupal_set_message(
963 963
         bts('INFO: You have not agreed to the terms of use for @project. You may use this form to change your email address and/or password. Please note: you may not delete your account within seven (7) days of changing your email address.',
964 964
         array(
965 965
           '@project' => variable_get('site_name','Drupal-BOINC'),
966
-        ), NULL, 'boinc:account-credentials-change')
966
+        ), null, 'boinc:account-credentials-change')
967 967
       , 'info');
968 968
     }
969 969
 
970 970
     // A bit hackish... but don't require the user to enter his password if
971 971
     // coming from the password reset function
972
-    $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/{$form['#uid']}") === FALSE) ? 0 : 1;
972
+    $reset_pass = (strpos($_SERVER['HTTP_REFERER'], "/user/reset/{$form['#uid']}") === false) ? 0 : 1;
973 973
     if ($reset_pass) {
974 974
       $_SESSION['reset_pass'] = 1;
975 975
     }
976 976
 
977 977
     // Adjust form elements already present
978
-    $form['account']['name']['#title'] = bts('Drupal Username', array(), NULL, 'boinc:drupal-username');
978
+    $form['account']['name']['#title'] = bts('Drupal Username', array(), null, 'boinc:drupal-username');
979 979
     $form['account']['name']['#size'] = 40;
980 980
     $form['account']['name']['#attributes']['autocomplete'] = 'off';
981 981
     $form['account']['name']['#description'] .= '<p>This is the drupal (internal) username. The title above shows the BOINC username, which is the display name used publicly that the user can change in Community Preferences.';
@@ -986,11 +986,11 @@  discard block
 block discarded – undo
986 986
       // Add BOINC username (aka displayname)
987 987
       $form['account']['boincuser_name'] = array(
988 988
         '#type' => 'textfield',
989
-        '#title' => bts('BOINC Username', array(), NULL, 'boinc:user-or-team-name'),
989
+        '#title' => bts('BOINC Username', array(), null, 'boinc:user-or-team-name'),
990 990
         '#default_value' => $account->boincuser_name,
991 991
         '#maxlength' => USERNAME_MAX_LENGTH,
992
-        '#required' => TRUE,
993
-        '#description' => bts('This is the BOINC (external) username. This is the same setting as found in Account -> Preferences -> Community.', array(), NULL, 'boinc:username-change'),
992
+        '#required' => true,
993
+        '#description' => bts('This is the BOINC (external) username. This is the same setting as found in Account -> Preferences -> Community.', array(), null, 'boinc:username-change'),
994 994
         '#size' => 40,
995 995
       );
996 996
     }
@@ -999,23 +999,23 @@  discard block
 block discarded – undo
999 999
     // ago, it cannot be changed again.
1000 1000
     $duration = TOKEN_DURATION_ONE_WEEK;
1001 1001
     if (($account->boincuser_email_addr_change_time + $duration) > time() and (!user_access('administer users'))) {
1002
-      $form['account']['mail']['#required'] = FALSE;
1002
+      $form['account']['mail']['#required'] = false;
1003 1003
       $form['account']['mailhelp'] = array(
1004 1004
         '#value' => bts("You email address was changed within the past seven (7) days. Please look for an email to !prev_email if you need to revert this change. You may change your email address on !time.",
1005 1005
           array(
1006 1006
             '!prev_email' => $account->boincuser_previous_email_addr,
1007 1007
             '!time' => date('F j, Y \a\t G:i T', $account->boincuser_email_addr_change_time + $duration),
1008
-          ), NULL, 'boinc:account-credentials-change'),
1008
+          ), null, 'boinc:account-credentials-change'),
1009 1009
       );
1010 1010
     }
1011 1011
 
1012
-    if (!$reset_pass AND ($user->uid == $account->uid OR !user_access('administer users'))) {
1012
+    if (!$reset_pass and ($user->uid == $account->uid or !user_access('administer users'))) {
1013 1013
       // Add a password authenticator, required to change email or pw
1014 1014
       $form['account']['current_pass'] = array(
1015 1015
         '#type' => 'password',
1016
-        '#title' => bts('Enter your password to save changes', array(), NULL, 'boinc:account-credentials-change'),
1016
+        '#title' => bts('Enter your password to save changes', array(), null, 'boinc:account-credentials-change'),
1017 1017
         '#description' => bts('Enter your current password if changing your email
1018
-          address or password.', array(), NULL, 'boinc:account-credentials-change'),
1018
+          address or password.', array(), null, 'boinc:account-credentials-change'),
1019 1019
         '#size' => 17,
1020 1020
         '#attributes' => array(
1021 1021
           'autocomplete' => 'off',
@@ -1027,35 +1027,35 @@  discard block
 block discarded – undo
1027 1027
     $form['account']['boincuser_id'] = array(
1028 1028
       '#value' => '
1029 1029
         <div class="form-item">
1030
-          <label>' . bts('BOINC user ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1030
+          <label>' . bts('BOINC user ID', array(), null, 'boinc:account-credentials-change') . '</label>
1031 1031
           <span>' . $account->boincuser_id . '</span>
1032 1032
         </div>',
1033 1033
     );
1034 1034
     $form['account']['user_id'] = array(
1035 1035
       '#value' => '
1036 1036
         <div class="form-item">
1037
-          <label>' . bts('Drupal user ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1037
+          <label>' . bts('Drupal user ID', array(), null, 'boinc:account-credentials-change') . '</label>
1038 1038
           <span>' . $account->uid . '</span>
1039 1039
         </div>',
1040 1040
     );
1041 1041
     $form['account']['account_key'] = array(
1042 1042
       '#value' => '
1043 1043
         <div class="form-item">
1044
-          <label>' . bts('Account key', array(), NULL, 'boinc:account-credentials-change') . '</label>
1044
+          <label>' . bts('Account key', array(), null, 'boinc:account-credentials-change') . '</label>
1045 1045
           <span>' . $account->boincuser_account_key . '</span>
1046 1046
         </div>',
1047 1047
     );
1048 1048
     $form['account']['weak_account_key'] = array(
1049 1049
       '#value' => '
1050 1050
         <div class="form-item">
1051
-          <label>' . bts('Weak account key', array(), NULL, 'boinc:account-credentials-change') . '</label>
1051
+          <label>' . bts('Weak account key', array(), null, 'boinc:account-credentials-change') . '</label>
1052 1052
           <span>' . "{$account->boincuser_id}_{$account->boincuser_weak_auth}" . '</span>
1053 1053
         </div>',
1054 1054
     );
1055 1055
     $form['account']['cpid'] = array(
1056 1056
       '#value' => '
1057 1057
         <div class="form-item">
1058
-          <label>' . bts('Cross-project ID', array(), NULL, 'boinc:account-credentials-change') . '</label>
1058
+          <label>' . bts('Cross-project ID', array(), null, 'boinc:account-credentials-change') . '</label>
1059 1059
           <span>' . $account->boincuser_cpid . '</span>
1060 1060
         </div>',
1061 1061
     );
@@ -1070,14 +1070,14 @@  discard block
 block discarded – undo
1070 1070
       '#weight' => 1001,
1071 1071
     );
1072 1072
     $form['submit']['#prefix'] = '<li class="first tab">';
1073
-    $form['submit']['#value'] = bts('Save changes', array(), NULL, 'boinc:form-save');
1073
+    $form['submit']['#value'] = bts('Save changes', array(), null, 'boinc:form-save');
1074 1074
     $form['submit']['#suffix'] = '</li>';
1075 1075
     $form['submit']['#weight'] = 1002;
1076 1076
     $form['cancel'] = array(
1077
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1077
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1078 1078
       '#weight' => 1003,
1079 1079
     );
1080
-    if (isset($form['delete']) AND is_array($form['delete'])) {
1080
+    if (isset($form['delete']) and is_array($form['delete'])) {
1081 1081
       $form['delete']['#prefix'] = '<li class="first alt tab">';
1082 1082
       $form['delete']['#suffix'] = '</li>';
1083 1083
       $form['delete']['#weight'] = 1004;
@@ -1139,7 +1139,7 @@  discard block
 block discarded – undo
1139 1139
 
1140 1140
     // Set form['title'], but hide it
1141 1141
     $form['title']['#default_value'] = $account->boincuser_name;
1142
-    $form['title']['#access'] = FALSE;
1142
+    $form['title']['#access'] = false;
1143 1143
 
1144 1144
     $form['separator_bottom'] = array(
1145 1145
       '#value' => '<div class="separator buttons"></div>',
@@ -1160,7 +1160,7 @@  discard block
 block discarded – undo
1160 1160
       '#weight' => 1001,
1161 1161
     );
1162 1162
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
1163
-    $form['buttons']['submit']['#value'] = bts('Save changes', array(), NULL, 'boinc:form-save');
1163
+    $form['buttons']['submit']['#value'] = bts('Save changes', array(), null, 'boinc:form-save');
1164 1164
     $form['buttons']['submit']['#suffix'] = '</li>';
1165 1165
     $form['buttons']['submit']['#weight'] = 1002;
1166 1166
     $form['buttons']['preview']['#prefix'] = '<li class="tab">';
@@ -1170,12 +1170,12 @@  discard block
 block discarded – undo
1170 1170
     $form['buttons']['preview_changes']['#suffix'] = '</li>';
1171 1171
     $form['buttons']['preview_changes']['#weight'] = 1004;
1172 1172
     $form['buttons']['cancel'] = array(
1173
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1173
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), $_GET['q']) . '</li>',
1174 1174
       '#weight' => 1005,
1175 1175
     );
1176 1176
     $form['buttons']['delete']['#prefix'] = '<li class="tab">';
1177 1177
     $form['buttons']['delete']['#suffix'] = '</li>';
1178
-    $form['buttons']['delete']['#value'] = bts('Clear User Profile', array(), NULL, 'boinc:form-save');
1178
+    $form['buttons']['delete']['#value'] = bts('Clear User Profile', array(), null, 'boinc:form-save');
1179 1179
     $form['buttons']['delete']['#weight'] = 1006;
1180 1180
     $form['buttons']['delete']['#submit'] = array('_boincuser_node_profile_delete_submit');
1181 1181
     $form['buttons']['form control tabs suffix'] = array(
@@ -1209,11 +1209,11 @@  discard block
 block discarded – undo
1209 1209
     array_unshift($form, array(
1210 1210
       'boincuser_name' => array(
1211 1211
         '#type' => 'textfield',
1212
-        '#title' => bts('Name', array(), NULL, 'boinc:user-or-team-name'),
1212
+        '#title' => bts('Name', array(), null, 'boinc:user-or-team-name'),
1213 1213
         '#default_value' => $edit['boincuser_name'],
1214 1214
         '#maxlength' => USERNAME_MAX_LENGTH,
1215
-        '#description' => bts('Spaces are allowed; punctuation is not allowed except for periods, hyphens, and underscores.', array(), NULL, 'boinc:user-register'),
1216
-        '#required' => TRUE
1215
+        '#description' => bts('Spaces are allowed; punctuation is not allowed except for periods, hyphens, and underscores.', array(), null, 'boinc:user-register'),
1216
+        '#required' => true
1217 1217
       ),
1218 1218
     ));
1219 1219
     // Set name temporarily to dummy value to beat validation
@@ -1233,27 +1233,27 @@  discard block
 block discarded – undo
1233 1233
         '#type'   => 'fieldset',
1234 1234
         '#prefix' => '<div id="termsofuse-wrapper">', // This is our wrapper div.
1235 1235
         '#suffix' => '</div>',
1236
-        '#tree'   => TRUE,
1236
+        '#tree'   => true,
1237 1237
         '#weight' => -15,
1238 1238
       );
1239 1239
 
1240 1240
       $form['termsofuse']['title1'] = array(
1241 1241
         '#weight' => -12,
1242
-        '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), NULL, 'project:user-register' ) . '</h2>',
1242
+        '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle', 'Please read and acknowledge our terms of use'), array(), null, 'project:user-register' ) . '</h2>',
1243 1243
         '#prefix' => '<div id="register-title1">',
1244 1244
         '#suffix' => '</div>',
1245 1245
       );
1246 1246
 
1247 1247
       $form['termsofuse']['body'] = array(
1248 1248
         '#weight' => -10,
1249
-        '#value' => bts($termsofuse, array(), NULL, 'project:user-register'),
1249
+        '#value' => bts($termsofuse, array(), null, 'project:user-register'),
1250 1250
         '#prefix' => '<div id="register-termsofuse">',
1251 1251
         '#suffix' => '</div>',
1252 1252
       );
1253 1253
 
1254 1254
       $form['termsofuse']['agreeTOU'] = array(
1255 1255
         '#type' => 'checkbox',
1256
-        '#title' => bts(variable_get('boinc_weboptions_agreequestion', 'Do you agree with the above terms of use?'), array(), NULL, 'project:user-register'),
1256
+        '#title' => bts(variable_get('boinc_weboptions_agreequestion', 'Do you agree with the above terms of use?'), array(), null, 'project:user-register'),
1257 1257
         '#weight' => -8,
1258 1258
         '#prefix' => '<div id="register-checkbox">',
1259 1259
         '#suffix' => '</div>',
@@ -1262,7 +1262,7 @@  discard block
 block discarded – undo
1262 1262
 
1263 1263
     $form['title2'] = array(
1264 1264
       '#weight' => -6,
1265
-      '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle2', 'Fill in your name, email, and choose a secure passphrase.'), array(), NULL, 'project:user-register') . '</h2>',
1265
+      '#value' => '<h2>' . bts(variable_get('boinc_weboptions_registrationtitle2', 'Fill in your name, email, and choose a secure passphrase.'), array(), null, 'project:user-register') . '</h2>',
1266 1266
       '#prefix' => '<div id="register-title2">',
1267 1267
       '#suffix' => '</div>',
1268 1268
     );
@@ -1282,26 +1282,26 @@  discard block
 block discarded – undo
1282 1282
 
1283 1283
   // Request new password form
1284 1284
   case 'user_pass':
1285
-    drupal_set_title(bts('Forgot password', array(), NULL, 'boinc:forgot-password'));
1285
+    drupal_set_title(bts('Forgot password', array(), null, 'boinc:forgot-password'));
1286 1286
     // Replace name/email text box with email only; retain "name" label
1287 1287
     // for compatibility with standard Drupal submit function
1288 1288
     unset($form['name']);
1289 1289
     array_unshift($form, array(
1290 1290
       'name' => array(
1291 1291
         '#type' => 'textfield',
1292
-        '#title' => bts('Email address', array(), NULL, 'boinc:email-address-to-login'),
1292
+        '#title' => bts('Email address', array(), null, 'boinc:email-address-to-login'),
1293 1293
         '#size' => 60,
1294 1294
         '#maxlength' => EMAIL_MAX_LENGTH,
1295
-        '#required' => TRUE,
1295
+        '#required' => true,
1296 1296
         '#description' => bts(
1297 1297
           'Enter your email address to receive instructions for resetting your password (or use the !authenticator_login).',
1298 1298
           array(
1299 1299
             '!authenticator_login' => l(
1300
-              bts('authenticator-based login', array(), NULL, 'boinc:forgot-password'),
1300
+              bts('authenticator-based login', array(), null, 'boinc:forgot-password'),
1301 1301
               'user/login/auth'
1302 1302
             )
1303 1303
           )
1304
-        , NULL, 'boinc:forgot-password'),
1304
+        , null, 'boinc:forgot-password'),
1305 1305
       ),
1306 1306
     ));
1307 1307
 
@@ -1322,11 +1322,11 @@  discard block
 block discarded – undo
1322 1322
     );
1323 1323
     $form['buttons']['submit'] = $form['submit'];
1324 1324
     $form['buttons']['submit']['#prefix'] = '<li class="first tab">';
1325
-    $form['buttons']['submit']['#value'] = bts('Send', array(), NULL, 'boinc:form-send');
1325
+    $form['buttons']['submit']['#value'] = bts('Send', array(), null, 'boinc:form-send');
1326 1326
     $form['buttons']['submit']['#suffix'] = '</li>';
1327 1327
     $form['buttons']['submit']['#weight'] = 1002;
1328 1328
     $form['buttons']['cancel'] = array(
1329
-      '#value' => '<li class="tab">' . l(bts('Cancel', array(), NULL, 'boinc:form-cancel'), 'user/login') . '</li>',
1329
+      '#value' => '<li class="tab">' . l(bts('Cancel', array(), null, 'boinc:form-cancel'), 'user/login') . '</li>',
1330 1330
       '#weight' => 1005,
1331 1331
     );
1332 1332
     $form['buttons']['form control tabs suffix'] = array(
@@ -1343,7 +1343,7 @@  discard block
 block discarded – undo
1343 1343
     break;
1344 1344
 
1345 1345
   case 'views_exposed_form':
1346
-      $form['submit']['#value'] = bts('Search', array(), NULL, 'boinc:search-user');
1346
+      $form['submit']['#value'] = bts('Search', array(), null, 'boinc:search-user');
1347 1347
     break;
1348 1348
   }
1349 1349
 }
@@ -1375,7 +1375,7 @@  discard block
 block discarded – undo
1375 1375
 function boincuser_process_password_confirm($element) {
1376 1376
   // Check if parent element is "account".
1377 1377
   if ($element['#array_parents'][0] == 'account') {
1378
-    $element['pass1']['#title'] = bts('Change password', array(), NULL, 'boinc:forgot-password');
1378
+    $element['pass1']['#title'] = bts('Change password', array(), null, 'boinc:forgot-password');
1379 1379
   }
1380 1380
   return $element;
1381 1381
 }
@@ -1395,7 +1395,7 @@  discard block
 block discarded – undo
1395 1395
 /**
1396 1396
  * Implementation of hook_token_values
1397 1397
  */
1398
-function boincuser_token_values($type, $object = NULL, $options = array()) {
1398
+function boincuser_token_values($type, $object = null, $options = array()) {
1399 1399
   if ($type == 'user') {
1400 1400
     $account = user_load($object->uid);
1401 1401
     $tokens['display-name'] = $account->boincuser_name;
@@ -1463,13 +1463,13 @@  discard block
 block discarded – undo
1463 1463
   require_boinc('boinc_db');
1464 1464
   $num_deleted = BoincUserDeleted::delete_expired();
1465 1465
   if ($num_deleted>0) {
1466
-    watchdog('boincuser', "Deleted ${num_deleted} users from user_deleted table", WATCHDOG_NOTICE);
1466
+    watchdog('boincuser', "deleted ${num_deleted} users from user_deleted table", WATCHDOG_NOTICE);
1467 1467
   }
1468 1468
 
1469 1469
   // Delete expired tokens from token table
1470 1470
   $tokens_deleted = BoincToken::delete_expired();
1471 1471
   if ($tokens_deleted>0) {
1472
-    watchdog('boincuser', "Deleted ${tokens_deleted} tokens from token table", WATCHDOG_NOTICE);
1472
+    watchdog('boincuser', "deleted ${tokens_deleted} tokens from token table", WATCHDOG_NOTICE);
1473 1473
   }
1474 1474
 }
1475 1475
 
@@ -1511,8 +1511,8 @@  discard block
 block discarded – undo
1511 1511
   if (!isset($account->roles[$verified_contributor])) {
1512 1512
     drupal_set_message(bts(
1513 1513
         'You may only create or modify your user profile after earning @count credits.',
1514
-        array('@count' => $min_credit_to_post), NULL, 'boinc:view-profile'
1515
-    ), 'warning', FALSE);
1514
+        array('@count' => $min_credit_to_post), null, 'boinc:view-profile'
1515
+    ), 'warning', false);
1516 1516
   }
1517 1517
 
1518 1518
   // For now, just call the user module profile view function
@@ -1555,35 +1555,35 @@  discard block
 block discarded – undo
1555 1555
     if ($registration_enabled) {
1556 1556
       $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1557 1557
       array(
1558
-        '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'),
1558
+        '!create_an_account' => l(bts('create an account', array(), null, 'boinc:join-page'), 'user/registration'),
1559 1559
         '@sitename' => $site_name,
1560
-      ), NULL, 'boinc:join-page') . '</li>';
1560
+      ), null, 'boinc:join-page') . '</li>';
1561 1561
     }
1562
-    $output .= '  <li>' . bts("Install BOINC on this device if not already present.", array(), NULL, 'boinc:join-page') . '</li>';
1562
+    $output .= '  <li>' . bts("Install BOINC on this device if not already present.", array(), null, 'boinc:join-page') . '</li>';
1563 1563
     $output .= '  <li>' . bts("Select <i>Tools / Add Project</i>. Choose @sitename from the list, or enter @siteurl.",
1564 1564
     array(
1565 1565
       '@sitename' => $site_name,
1566 1566
       '@siteurl' => $base_url,
1567
-    ), NULL, 'boinc:join-page') . '</li>';
1567
+    ), null, 'boinc:join-page') . '</li>';
1568 1568
     if ($registration_enabled) {
1569 1569
       $output .= '<li>' . bts("If you're running a command-line or pre-5.0 version of BOINC, use <b>!boinccmd</b> to add the project.",
1570 1570
         array(
1571 1571
           '!boinccmd' => l('boinccmd --project_attach', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1572
-        ), NULL, 'boinc:join-page') . '</li>';
1572
+        ), null, 'boinc:join-page') . '</li>';
1573 1573
     }
1574 1574
     else {
1575 1575
       $output .= '<li>' . bts("If you're running a command-line version of BOINC,
1576 1576
         please follow the <b>!instructionslink</b> to first <i>create an account</i>, and then <i>attach</i> to this project. Use the same project URL as above.",
1577 1577
         array(
1578 1578
           '!instructionslink' => l('instructions', 'http://boinc.berkeley.edu/wiki/Boinccmd_tool'),
1579
-        ), NULL, 'boinc:join-page') . '</li>';
1579
+        ), null, 'boinc:join-page') . '</li>';
1580 1580
     }
1581 1581
     $output .= '<li>' . bts("If you're running a pre-5.0 version of BOINC, please
1582 1582
       upgrade to a more recent version of BOINC to create an account
1583 1583
       at @this_project.",
1584 1584
       array(
1585 1585
         '@this_project' => $site_name,
1586
-      ), NULL, 'boinc:join-page') . '</li>';
1586
+      ), null, 'boinc:join-page') . '</li>';
1587 1587
     $output .=  '</ol>';
1588 1588
     break;
1589 1589
   case 'new':
@@ -1603,29 +1603,29 @@  discard block
 block discarded – undo
1603 1603
     if ($registration_enabled) {
1604 1604
       $output .= '<li>' . bts('First !create_an_account here at @sitename.',
1605 1605
       array(
1606
-        '!create_an_account' => l(bts('create an account', array(), NULL, 'boinc:join-page'), 'user/registration'),
1606
+        '!create_an_account' => l(bts('create an account', array(), null, 'boinc:join-page'), 'user/registration'),
1607 1607
         '@sitename' => $site_name,
1608
-      ), NULL, 'boinc:join-page') . '</li>';
1608
+      ), null, 'boinc:join-page') . '</li>';
1609 1609
     }
1610 1610
     else if ( menu_valid_path(array('link_path' => $ruleslink)) ) {
1611 1611
       $output .= '  <li>' . bts("Read our !rules_and_policies.", array(
1612
-        '!rules_and_policies' => l(bts('Rules and Policies', array(), NULL, 'boinc:join-page'), $ruleslink),
1613
-      ), NULL, 'boinc:join-page') . '</li>';
1612
+        '!rules_and_policies' => l(bts('Rules and Policies', array(), null, 'boinc:join-page'), $ruleslink),
1613
+      ), null, 'boinc:join-page') . '</li>';
1614 1614
     }
1615
-    $output .= '  <li>' . bts('Download the BOINC desktop software.', array(), NULL, 'boinc:join-page');
1615
+    $output .= '  <li>' . bts('Download the BOINC desktop software.', array(), null, 'boinc:join-page');
1616 1616
     $output .= '    <p>';
1617 1617
     $output .= '      <a class="button" href="http://boinc.berkeley.edu/download.php">Download</a>';
1618 1618
     $output .= '    </p>';
1619 1619
     $output .= '    ' . bts("For Android devices, visit !fdroid_link or download !apk_link directly.", array(
1620 1620
       '!fdroid_link' => '<a href="https://f-droid.org/en/packages/edu.berkeley.boinc">F-Droid</a>',
1621 1621
       '!apk_link' => '<a href="https://boinc.berkeley.edu/download_all.php">BOINC for Android</a>',
1622
-    ), NULL, 'boinc:join-page');
1622
+    ), null, 'boinc:join-page');
1623 1623
     $output .= '  </li>';
1624
-    $output .= '  <li>' . bts('Run the installer.', array(), NULL, 'boinc:join-page') . '</li>';
1624
+    $output .= '  <li>' . bts('Run the installer.', array(), null, 'boinc:join-page') . '</li>';
1625 1625
     $output .= '  <li>' . bts('Choose @sitename from the list, or enter @siteurl.', array(
1626 1626
       '@sitename' => $site_name,
1627 1627
       '@siteurl' => $base_url,
1628
-    ), NULL, 'boinc:join-page') . '</li>';
1628
+    ), null, 'boinc:join-page') . '</li>';
1629 1629
     $output .=  '</ol>';
1630 1630
   }
1631 1631
   $output .= '</div>';
@@ -1656,17 +1656,17 @@  discard block
 block discarded – undo
1656 1656
   else {
1657 1657
     $uotd = user_load($current_uotd->uid);
1658 1658
   }
1659
-  $uotd_image = boincuser_get_user_profile_image($uotd->uid, FALSE);
1659
+  $uotd_image = boincuser_get_user_profile_image($uotd->uid, false);
1660 1660
   $output = '<h2 class="pane-title">';
1661
-  $output .= ($user->uid) ? bts('Welcome back!', array(), NULL, 'boinc:front-page') : ($site_name ? bts('What is @this_project?', array('@this_project' => $site_name)) : bts('Welcome!', array(), NULL, 'boinc:front-page'));
1661
+  $output .= ($user->uid) ? bts('Welcome back!', array(), null, 'boinc:front-page') : ($site_name ? bts('What is @this_project?', array('@this_project' => $site_name)) : bts('Welcome!', array(), null, 'boinc:front-page'));
1662 1662
   $output .= '</h2>';
1663 1663
   $output .= '<div class="boinc-overview balance-height-front">';
1664
-  $output .= '  <div>' . bts($site_message, array(), NULL, "project:front page") . ' ' . l(bts('Learn more', array(), NULL, 'boinc:front-page'), 'about') . '</div>';
1664
+  $output .= '  <div>' . bts($site_message, array(), null, "project:front page") . ' ' . l(bts('Learn more', array(), null, 'boinc:front-page'), 'about') . '</div>';
1665 1665
   if ($user->uid) {
1666
-    $output .= '  <div>' . l(bts('View account', array(), NULL, 'boinc:front-page'), 'dashboard', array('attributes' => array('class' => 'join button'))) . '</div>';
1666
+    $output .= '  <div>' . l(bts('View account', array(), null, 'boinc:front-page'), 'dashboard', array('attributes' => array('class' => 'join button'))) . '</div>';
1667 1667
   }
1668 1668
   else {
1669
-    $output .= '  <div>' . l(bts('Join now', array(), NULL, 'boinc:front-page'), 'join', array('attributes' => array('class' => 'join button'))) . '</div>';
1669
+    $output .= '  <div>' . l(bts('Join now', array(), null, 'boinc:front-page'), 'join', array('attributes' => array('class' => 'join button'))) . '</div>';
1670 1670
   }
1671 1671
   $output .= '</div>';
1672 1672
   $output .= '<div class="boinc-overview-details">';
@@ -1674,17 +1674,17 @@  discard block
 block discarded – undo
1674 1674
   $output .= '    <a class="user-of-the-day" href="account/' . $uotd->uid . '">';
1675 1675
   $output .= '      <div class="picture">';
1676 1676
   $output .= theme('imagefield_image', $uotd_image['image'], $uotd_image['alt'],
1677
-    $uotd_image['alt'], array(), FALSE);
1677
+    $uotd_image['alt'], array(), false);
1678 1678
   $output .= '      </div>';
1679
-  $output .= '      <div class="text">' . bts('User of the day', array(), NULL, 'boinc:front-page') . '</div>';
1679
+  $output .= '      <div class="text">' . bts('User of the day', array(), null, 'boinc:front-page') . '</div>';
1680 1680
   $output .= '      <div class="detail">' . $uotd->boincuser_name . '</div>';
1681 1681
   $output .= '    </a>';
1682 1682
   $output .= '    <div class="volunteers">';
1683
-  $output .= '      <div class="text">' . bts('Over 500,000 volunteers and counting.', array(), NULL, 'boinc:front-page') . '</div>';
1683
+  $output .= '      <div class="text">' . bts('Over 500,000 volunteers and counting.', array(), null, 'boinc:front-page') . '</div>';
1684 1684
   $output .= '      <div class="platforms">';
1685
-  $output .= '        <div class="detail platform windows">' . bts('Windows', array(), NULL, 'boinc:front-page') . '</div>';
1686
-  $output .= '        <div class="detail platform mac">' .  bts('Mac', array(), NULL, 'boinc:front-page') . '</div>';
1687
-  $output .= '        <div class="detail platform linux">' . bts('Linux', array(), NULL, 'boinc:front-page') . '</div>';
1685
+  $output .= '        <div class="detail platform windows">' . bts('Windows', array(), null, 'boinc:front-page') . '</div>';
1686
+  $output .= '        <div class="detail platform mac">' .  bts('Mac', array(), null, 'boinc:front-page') . '</div>';
1687
+  $output .= '        <div class="detail platform linux">' . bts('Linux', array(), null, 'boinc:front-page') . '</div>';
1688 1688
   $output .= '      </div>';
1689 1689
   $output .= '    </div>';
1690 1690
   $output .= '  </div>';
@@ -1712,12 +1712,12 @@  discard block
 block discarded – undo
1712 1712
   xml_header();
1713 1713
 
1714 1714
   // Account creation disabled
1715
-  $enablethisRPC = variable_get('boinc_weboptions_enableaccountcreateRPC', TRUE);
1715
+  $enablethisRPC = variable_get('boinc_weboptions_enableaccountcreateRPC', true);
1716 1716
   if (!$enablethisRPC) {
1717 1717
     $mess = bts('Account creation is done through our Web site. Please register at @url', array(
1718 1718
       '@url' => $base_url . '/user/registration',
1719 1719
     ),
1720
-    NULL, 'boinc:create_account');
1720
+    null, 'boinc:create_account');
1721 1721
     xml_error(-208, $mess);
1722 1722
   }
1723 1723
   // Invalid invite code
@@ -1771,7 +1771,7 @@  discard block
 block discarded – undo
1771 1771
       'init' => $params['email_addr'],
1772 1772
       'roles' => array($unrestricted_role => ''),
1773 1773
       'boincuser_name' => $params['user_name'],
1774
-      'boinchash_flag' => TRUE,
1774
+      'boinchash_flag' => true,
1775 1775
     );
1776 1776
 
1777 1777
     // Create the drupal user. If the drupal user cannot be created,
@@ -1808,20 +1808,20 @@  discard block
 block discarded – undo
1808 1808
   }
1809 1809
 
1810 1810
   if (strlen($authtoken) != 32) {
1811
-    drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), NULL, 'boinc:account-finish'), 'error');
1811
+    drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), null, 'boinc:account-finish'), 'error');
1812 1812
     drupal_goto();
1813 1813
   }
1814 1814
 
1815 1815
   require_boinc('boinc_db');
1816 1816
   $boinc_user = BoincUser::lookup("authenticator='".addslashes($authtoken)."'");
1817 1817
   if (!$boinc_user) {
1818
-    drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), NULL, 'boinc:account-finish'), 'error');
1818
+    drupal_set_message(bts('ERROR: There is no account with that authenticator.', array(), null, 'boinc:account-finish'), 'error');
1819 1819
     drupal_goto();
1820 1820
   }
1821 1821
   $user = user_load(get_drupal_id($boinc_user->id));
1822 1822
 
1823 1823
   if (!$user) {
1824
-    drupal_set_message(bts('ERROR: There was a problem loading your account. Try logging in with your user name and password.', array(), NULL, 'boinc:account-finish'), 'error');
1824
+    drupal_set_message(bts('ERROR: There was a problem loading your account. Try logging in with your user name and password.', array(), null, 'boinc:account-finish'), 'error');
1825 1825
     drupal_goto();
1826 1826
   }
1827 1827
 
@@ -1842,9 +1842,9 @@  discard block
 block discarded – undo
1842 1842
   // Check moderation page exists
1843 1843
   $moderationpath = drupal_lookup_path('source', variable_get('boinc_weboptions_moderationpage', '') );
1844 1844
   if ( menu_valid_path(array('link_path' => $moderationpath)) ) {
1845
-    $modsentence = bts('Please note: user profiles are subject to !moderation.', array('!moderation' => l(bts('moderation', array(), NULL, 'boinc:account-finish'), $moderationpath, $options)), NULL, 'boinc:account-finish');
1845
+    $modsentence = bts('Please note: user profiles are subject to !moderation.', array('!moderation' => l(bts('moderation', array(), null, 'boinc:account-finish'), $moderationpath, $options)), null, 'boinc:account-finish');
1846 1846
   } else {
1847
-    $modsentence = bts('Please note: user profiles are subject to moderation.', array(), NULL, 'boinc:account-finish');
1847
+    $modsentence = bts('Please note: user profiles are subject to moderation.', array(), null, 'boinc:account-finish');
1848 1848
   }
1849 1849
 
1850 1850
   $username = $user->boincuser_name;
@@ -1853,73 +1853,73 @@  discard block
 block discarded – undo
1853 1853
   array(
1854 1854
     '@user_name' => $username,
1855 1855
     '@site_name' => $site_name,
1856
-  ), NULL, 'boinc:account-finish') . "</p>";
1856
+  ), null, 'boinc:account-finish') . "</p>";
1857 1857
 
1858 1858
   $links = array(
1859 1859
     array(
1860 1860
       'data' => bts('Change your username at !community_preferences.', array(
1861
-        '!community_preferences' => l(bts('Community Preferences', array(), NULL, 'boinc:account-fininsh'), 'account/prefs/community', $options),
1862
-      ), NULL, 'boinc:account-finish'),
1861
+        '!community_preferences' => l(bts('Community Preferences', array(), null, 'boinc:account-fininsh'), 'account/prefs/community', $options),
1862
+      ), null, 'boinc:account-finish'),
1863 1863
       'children' => array(
1864
-        bts('Your username is used to identify yourself to other volunteers on this Web site.', array(), NULL, 'boinc:account-finish'),
1865
-        bts('In addition, you may set your account\'s default language and adjust notification settings.', array(), NULL, 'boinc:account-finish'),
1864
+        bts('Your username is used to identify yourself to other volunteers on this Web site.', array(), null, 'boinc:account-finish'),
1865
+        bts('In addition, you may set your account\'s default language and adjust notification settings.', array(), null, 'boinc:account-finish'),
1866 1866
       ),
1867 1867
     ),
1868 1868
     array(
1869 1869
       'data' => bts('Change your !computing_preferences.', array(
1870
-        '!computing_preferences' => l(bts('Computing Preferences', array(), NULL, 'boinc:account-finish'), 'account/prefs', $options),
1871
-      ), NULL, 'boinc:account-finish'),
1870
+        '!computing_preferences' => l(bts('Computing Preferences', array(), null, 'boinc:account-finish'), 'account/prefs', $options),
1871
+      ), null, 'boinc:account-finish'),
1872 1872
       'children' => array(
1873
-        bts('You may adjust how much CPU, RAM, and Disk space the BOINC client is allowed to use for tasks on your computer.', array(), NULL, 'boinc:account-finish'),
1873
+        bts('You may adjust how much CPU, RAM, and Disk space the BOINC client is allowed to use for tasks on your computer.', array(), null, 'boinc:account-finish'),
1874 1874
         bts('By default, you will run @site_name tasks without any additional configuration.', array(
1875 1875
           '@site_name' => $site_name,
1876
-        ), NULL, 'boinc:account-finish'),
1876
+        ), null, 'boinc:account-finish'),
1877 1877
         bts('It is recommended new volunteers leave the default settings until they gain experience running some tasks. Ask questions in the !forums to get advice before making changes to a setting you don\'t understand.', array(
1878
-          '!forums' => l(bts('forums', array(), NULL, 'boinc:account-finish'), 'community/forum', $options),
1879
-        ), NULL, 'boinc:account-finish'),
1878
+          '!forums' => l(bts('forums', array(), null, 'boinc:account-finish'), 'community/forum', $options),
1879
+        ), null, 'boinc:account-finish'),
1880 1880
       ),
1881 1881
     ),
1882 1882
     array(
1883 1883
         'data' => bts('Create a !user_profile.', array(
1884
-          '!user_profile' => l(bts('User Profile', array(), NULL, 'boinc:account-finish'), '/account/profile/edit', $options),
1885
-        ), NULL, 'boinc:account-finish'),
1884
+          '!user_profile' => l(bts('User Profile', array(), null, 'boinc:account-finish'), '/account/profile/edit', $options),
1885
+        ), null, 'boinc:account-finish'),
1886 1886
       'children' => array(
1887 1887
         bts('A user profile will inform other volunteers who you are and why you joined @site_name.', array(
1888 1888
           '@site_name' => $site_name,
1889
-        ), NULL, 'boinc:account-finish'),
1889
+        ), null, 'boinc:account-finish'),
1890 1890
         $modsentence,
1891 1891
       ),
1892 1892
     ),
1893 1893
     array(
1894 1894
       'data' => bts('Join a !team.', array(
1895
-        '!team' => l(bts('Team', array(), NULL, 'boinc:account-finish'), '/community/teams', $options),
1896
-      ), NULL, 'boinc:account-finish'),
1895
+        '!team' => l(bts('Team', array(), null, 'boinc:account-finish'), '/community/teams', $options),
1896
+      ), null, 'boinc:account-finish'),
1897 1897
       'children' => array(
1898
-        bts('You may join a team, made up of other volunteers.', array(), NULL, 'boinc:account-finish'),
1898
+        bts('You may join a team, made up of other volunteers.', array(), null, 'boinc:account-finish'),
1899 1899
       ),
1900 1900
     ),
1901 1901
     array(
1902 1902
       'data' => bts('Go to your !account_dashboard.', array(
1903
-        '!account_dashboard'=> l(bts('Account Dashboard', array(), NULL, 'boinc:account-finish'), 'account/dashboard', $options),
1904
-      ), NULL, 'boinc:account-finish'),
1903
+        '!account_dashboard'=> l(bts('Account Dashboard', array(), null, 'boinc:account-finish'), 'account/dashboard', $options),
1904
+      ), null, 'boinc:account-finish'),
1905 1905
       'children' => array(
1906
-        bts('Your account dashboard has information and links about your computer(s) and task(s) assigned.', array(), NULL, 'boinc:account-finish'),
1906
+        bts('Your account dashboard has information and links about your computer(s) and task(s) assigned.', array(), null, 'boinc:account-finish'),
1907 1907
       ),
1908 1908
     ),
1909 1909
     array(
1910 1910
       'data' => bts('Visit our !help pages.', array(
1911
-        '!help' => l(bts('Help', array(), NULL, 'boinc:account-finish'), '/help', $options)
1912
-      ), NULL, 'boinc:account-finish'),
1911
+        '!help' => l(bts('Help', array(), null, 'boinc:account-finish'), '/help', $options)
1912
+      ), null, 'boinc:account-finish'),
1913 1913
       'children' => array(
1914 1914
         bts('Ask for help in our community\'s !forums.', array(
1915
-          '!forums' => l(bts('forums', array(), NULL, 'boinc:account-finish'), 'community/forum', $options)
1916
-        ), NULL, 'boinc:account-finish'),
1915
+          '!forums' => l(bts('forums', array(), null, 'boinc:account-finish'), 'community/forum', $options)
1916
+        ), null, 'boinc:account-finish'),
1917 1917
       ),
1918 1918
     ),
1919 1919
   );
1920 1920
 
1921 1921
   //List of links
1922
-  $output .= theme_item_list($links, $title = NULL, $type='ul');
1922
+  $output .= theme_item_list($links, $title = null, $type='ul');
1923 1923
 
1924 1924
   return $output;
1925 1925
 }
@@ -1929,20 +1929,20 @@  discard block
 block discarded – undo
1929 1929
  */
1930 1930
 function boincuser_moderate_community_access() {
1931 1931
   if (user_access('assign community member role')
1932
-  OR user_access('assign all roles')) {
1933
-    return TRUE;
1932
+  or user_access('assign all roles')) {
1933
+    return true;
1934 1934
   }
1935
-  return FALSE;
1935
+  return false;
1936 1936
 }
1937 1937
 
1938 1938
 /**
1939 1939
  * Get the count of items in the moderation queue
1940 1940
  */
1941 1941
 function boincuser_moderation_queue_count($caller = 'user') {
1942
-  $allowed = FALSE;
1942
+  $allowed = false;
1943 1943
   switch ($caller) {
1944 1944
   case 'cron':
1945
-    $allowed = TRUE;
1945
+    $allowed = true;
1946 1946
     break;
1947 1947
   case 'user':
1948 1948
   default:
@@ -1956,7 +1956,7 @@  discard block
 block discarded – undo
1956 1956
       AND moderate = 1"
1957 1957
     ));
1958 1958
   }
1959
-  return NULL;
1959
+  return null;
1960 1960
 }
1961 1961
 
1962 1962
 /**
@@ -1964,10 +1964,10 @@  discard block
 block discarded – undo
1964 1964
  * Allow community membership status to be set for users by direct link rather
1965 1965
  * than through the user account info form.
1966 1966
  */
1967
-function boincuser_control($uid = NULL, $action = NULL) {
1968
-  if (!$uid OR !$account = user_load($uid)) {
1967
+function boincuser_control($uid = null, $action = null) {
1968
+  if (!$uid or !$account = user_load($uid)) {
1969 1969
     // What are you even doing here...
1970
-    return FALSE;
1970
+    return false;
1971 1971
   }
1972 1972
   switch ($action) {
1973 1973
   case 'ban':
@@ -2073,7 +2073,7 @@  discard block
 block discarded – undo
2073 2073
  */
2074 2074
 function boincuser_moderate_user_ban($uid, $reason = '', $duration = '') {
2075 2075
   if (user_access('assign community member role')
2076
-  OR user_access('assign all roles')) {
2076
+  or user_access('assign all roles')) {
2077 2077
     $account = user_load($uid);
2078 2078
     if ($account->uid) {
2079 2079
       module_load_include('inc', 'rules', 'modules/system.rules');
@@ -2153,7 +2153,7 @@  discard block
 block discarded – undo
2153 2153
  * User profile image is managed by the content_profile module rather than core
2154 2154
  * Drupal User so must be inserted into comments, etc. (not so by default)
2155 2155
  */
2156
-function boincuser_get_user_profile_image($uid, $avatar = TRUE) {
2156
+function boincuser_get_user_profile_image($uid, $avatar = true) {
2157 2157
   // Though the function name implies otherwise, get the avatar by default
2158 2158
   $image_field = ($avatar) ? 'field_image_fid' : 'field_profile_image_fid';
2159 2159
   $image_fid = db_result(db_query("
@@ -2166,7 +2166,7 @@  discard block
 block discarded – undo
2166 2166
   if (!$user_image['image']['filepath']) {
2167 2167
     // Load the default image if one does not exist
2168 2168
     $account = user_load($uid);
2169
-    if ($avatar AND module_exists('gravatar') AND user_access('use gravatar', $account) AND $account->gravatar) {
2169
+    if ($avatar and module_exists('gravatar') and user_access('use gravatar', $account) and $account->gravatar) {
2170 2170
       // Use a Gravatar rather than the system default image
2171 2171
       $options = array(
2172 2172
         'size' => 100,
@@ -2194,23 +2194,23 @@  discard block
 block discarded – undo
2194 2194
  * Generate a table of a user's projects
2195 2195
  */
2196 2196
 function boincuser_get_projects_table($account = null) {
2197
-  if ($account AND is_numeric($account)) {
2197
+  if ($account and is_numeric($account)) {
2198 2198
     $account = user_load($account);
2199 2199
   }
2200 2200
   $projects = boincuser_get_projects($account);
2201
-  if (!$projects) return bts('no projects...', array(), NULL, 'boinc:account-dashboard');
2201
+  if (!$projects) return bts('no projects...', array(), null, 'boinc:account-dashboard');
2202 2202
 
2203 2203
   $output = '';
2204 2204
   $output .= '<table class="user-projects">' . "\n";
2205 2205
   $output .= '<thead>' . "\n";
2206 2206
   $output .= '  <tr>' . "\n";
2207
-  $output .= '    <th>' . bts('Name', array(), NULL, 'boinc:project-name:-1:ignoreoverwrite') . '</th>' . "\n";
2208
-  $output .= '    <th class="numeric">' . bts('Avg credit', array(), NULL, 'boinc:account-dashboard') . '</th>' . "\n";
2209
-  $output .= '    <th class="numeric">' . bts('Total credit', array(), NULL, 'boinc:user-or-team-total-credits') . '</th>' . "\n";
2207
+  $output .= '    <th>' . bts('Name', array(), null, 'boinc:project-name:-1:ignoreoverwrite') . '</th>' . "\n";
2208
+  $output .= '    <th class="numeric">' . bts('Avg credit', array(), null, 'boinc:account-dashboard') . '</th>' . "\n";
2209
+  $output .= '    <th class="numeric">' . bts('Total credit', array(), null, 'boinc:user-or-team-total-credits') . '</th>' . "\n";
2210 2210
   $output .= '  </tr>' . "\n";
2211 2211
   $output .= '</thead>' . "\n";
2212 2212
   $output .= '<tbody>' . "\n";
2213
-  foreach ($projects AS $project) {
2213
+  foreach ($projects as $project) {
2214 2214
     $url = rtrim($project->url, '/') . '/show_user.php?userid=' . $project->id;
2215 2215
     $output .= '  <tr>' . "\n";
2216 2216
     $output .= '    <td>' . l($project->name, $url) . '</td>' . "\n";
@@ -2248,7 +2248,7 @@  discard block
 block discarded – undo
2248 2248
   if (in_array($result->code, array(200, 304)) || in_array($result->redirect_code, array(200, 304))) {
2249 2249
     return simplexml_load_string($result->data);
2250 2250
   }
2251
-  return NULL;
2251
+  return null;
2252 2252
 }
2253 2253
 
2254 2254
 /**
@@ -2264,7 +2264,7 @@  discard block
 block discarded – undo
2264 2264
 
2265 2265
   $account_stats = boincuser_get_stats_user_data($account->boincuser_cpid);
2266 2266
 
2267
-  return ($account_stats AND isset($account_stats->project)) ? $account_stats->project : null;
2267
+  return ($account_stats and isset($account_stats->project)) ? $account_stats->project : null;
2268 2268
 }
2269 2269
 
2270 2270
 
@@ -2277,18 +2277,18 @@  discard block
 block discarded – undo
2277 2277
   $profile = content_profile_load('profile', $account->uid);
2278 2278
   $output = '';
2279 2279
   if ($profile) {
2280
-    $profile_is_approved = ($profile->status AND !$profile->moderate);
2280
+    $profile_is_approved = ($profile->status and !$profile->moderate);
2281 2281
     $user_is_moderator = user_access('edit any profile content');
2282 2282
     $is_own_profile = ($user->uid == $account->uid);
2283 2283
     $profile_moderation_path = "moderate/profile/{$account->uid}";
2284 2284
     $links = array();
2285 2285
 
2286
-    if ($profile->moderate AND $user_is_moderator) {
2286
+    if ($profile->moderate and $user_is_moderator) {
2287 2287
       $links['approve_profile'] = array(
2288
-        'title' => bts('Approve profile', array(), NULL, 'boinc:moderate-user'),
2288
+        'title' => bts('Approve profile', array(), null, 'boinc:moderate-user'),
2289 2289
         'href' => "{$profile_moderation_path}/approve",
2290 2290
         'attributes' => array(
2291
-          'title' => bts('Approve this profile content', array(), NULL, 'boinc:moderate-user'),
2291
+          'title' => bts('Approve this profile content', array(), null, 'boinc:moderate-user'),
2292 2292
           'class' => 'first primary tab',
2293 2293
         )
2294 2294
       );
@@ -2301,10 +2301,10 @@  discard block
 block discarded – undo
2301 2301
         )
2302 2302
       );*/
2303 2303
       $links['reject_profile'] = array(
2304
-        'title' => bts('Reject profile', array(), NULL, 'boinc:moderate-user'),
2304
+        'title' => bts('Reject profile', array(), null, 'boinc:moderate-user'),
2305 2305
         'href' => "{$profile_moderation_path}/reject",
2306 2306
         'attributes' => array(
2307
-          'title' => bts('Reject this profile content', array(), NULL, 'boinc:moderate-user'),
2307
+          'title' => bts('Reject this profile content', array(), null, 'boinc:moderate-user'),
2308 2308
           'class' => 'tab',
2309 2309
         )
2310 2310
       );
@@ -2358,7 +2358,7 @@  discard block
 block discarded – undo
2358 2358
 function boincuser_apachesolr_index_documents_alter(array &$documents, $entity, $entity_type, $env_id) {
2359 2359
 
2360 2360
   foreach ($documents as $document) {
2361
-    if ( $document->entity_type=='node' AND $document->bundle=='profile' ) {
2361
+    if ( $document->entity_type=='node' and $document->bundle=='profile' ) {
2362 2362
       // Node information.
2363 2363
       $nid = $document->entity_id;
2364 2364
       $node = node_load($nid);
@@ -2412,7 +2412,7 @@  discard block
 block discarded – undo
2412 2412
     if ($recipient = user_load(array('uid' => $drupalid))) {
2413 2413
       // Double-check that the loaded user matches both boincuser_id
2414 2414
       // and boincuser_name.
2415
-      if ( ($boincid == $recipient->boincuser_id) AND ($boincname == $recipient->boincuser_name) ) {
2415
+      if ( ($boincid == $recipient->boincuser_id) and ($boincname == $recipient->boincuser_name) ) {
2416 2416
         return $recipient;
2417 2417
       }
2418 2418
     }
Please login to merge, or discard this patch.