BOINC / boinc

html/user/prefs_remove.php

Spacing +1 added lines, -1 removed lines

@@ -29,7 +29,7 @@
 $venue = get_str("venue");
 $confirmed = get_str("confirmed", true);
 $columns = get_int("cols", true);
-$c = $columns?"&cols=$columns":"";
+$c = $columns ? "&cols=$columns" : "";
 
 if ($confirmed) {
     if ($subset == "global") {

html/user/forum_rate.php

Spacing +2 added lines, -2 removed lines

@@ -34,7 +34,7 @@ 
     $rating = post_int('rating', true);
     if (!$choice) $choice = get_str('choice', true);
 
-    if ($choice == SOLUTION or $choice=="p") {
+    if ($choice == SOLUTION or $choice == "p") {
         $rating = 1;
     } else {
         $rating = -1;
@@ -53,7 +53,7 @@ 
     // Make sure the user has the forum's minimum amount of RAC and total credit
     // before allowing them to rate a post.
     //
-    if ($user->total_credit<$forum->rate_min_total_credit || $user->expavg_credit<$forum->rate_min_expavg_credit) {
+    if ($user->total_credit < $forum->rate_min_total_credit || $user->expavg_credit < $forum->rate_min_expavg_credit) {
         error_page(tra("You need more average or total credit to rate a post."));
     }
 

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
     $user = get_logged_in_user();
 
     if ($choice == null && ($rating == null || $rating > 2 || $rating < -2)) {
-        show_result_page(false, NULL, NULL, $choice);
+        show_result_page(false, null, null, $choice);
     }
 
     $post = BoincPost::lookup_id($post_id);

html/user/pending.php

Spacing +2 added lines, -2 removed lines

@@ -47,7 +47,7 @@ 
     $sum = 0;
     echo "<pending_credit>\n";
     $results = BoincResult::enum("userid=$user->id AND (validate_state=0 OR validate_state=4) AND claimed_credit > 0");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         echo "<result>\n";
         echo "    <resultid>".$result->id."</resultid>\n";
         echo "    <workunitid>".$result->workunitid."</workunitid>\n";
@@ -67,7 +67,7 @@ 
     start_table();
     echo "<tr><th>".tra("Result ID")."</th><th>".tra("Workunit ID")."</th><th>".tra("Host ID")."</th><th>".tra("Claimed credit")."</th></tr>\n";
     $results = BoincResult::enum("userid=$user->id AND (validate_state=0 OR validate_state=4) AND claimed_credit > 0");
-    foreach($results as $result) {
+    foreach ($results as $result) {
         echo "<tr>\n";
         echo "<td><a href=\"result.php?resultid=$result->id\">$result->id</a></td>\n";
         echo "<td><a href=\"workunit.php?wuid=$result->workunitid\">$result->workunitid</a></td>\n";

html/user/profile_menu.php

Spacing +5 added lines, -5 removed lines

@@ -41,7 +41,7 @@ 
 start_table();
 
 $today = getdate(time());
-$UOTD_heading = tra("User of the Day")." -- " . $today['month'] . " " . $today['mday'] . ", " . $today['year'];
+$UOTD_heading = tra("User of the Day")." -- ".$today['month']." ".$today['mday'].", ".$today['year'];
 row1($UOTD_heading);
 echo "<tr><td>";
     $profile = get_current_uotd();
@@ -59,15 +59,15 @@ 
 row1(tra("User Profile Explorer"));
 echo "<tr><td>
     <ul>
-    <li>".tra("View the %1 User Picture Gallery %2.", "<a href=\"" . url_base() . "user_profile/user_gallery_1.html\">", "</a>")."</li>
-    <li>".tra("Browse profiles %1 by country %2.", "<a href=\"" . url_base() . "user_profile/profile_country.html\">", "</a>")."</li>
+    <li>".tra("View the %1 User Picture Gallery %2.", "<a href=\"".url_base()."user_profile/user_gallery_1.html\">", "</a>")."</li>
+    <li>".tra("Browse profiles %1 by country %2.", "<a href=\"".url_base()."user_profile/profile_country.html\">", "</a>")."</li>
     <li>".tra("Browse profiles %1 at random %2, %3 at random with pictures %2, or %4 at random without pictures %2.", "<a href=\"?cmd=rand&amp;pic=-1\">", "</a>",
             "<a href=\"?cmd=rand&amp;pic=1\">", "<a href=\"?cmd=rand&amp;pic=0\">")."</li>
 ";
-if (file_exists(PROFILE_PATH . "profile_alpha.html")) {
+if (file_exists(PROFILE_PATH."profile_alpha.html")) {
     echo "<li>".tra("Alphabetical profile listings:")."<br>";
 
-    include( PROFILE_PATH . "profile_alpha.html" );
+    include(PROFILE_PATH."profile_alpha.html");
 }
 echo "</ul></td></tr>";
 

html/user/add_venue.php

Spacing +3 added lines, -3 removed lines

@@ -27,7 +27,7 @@ 
 $subset = sanitize_tags(get_str("subset"));
 $venue = sanitize_tags(get_str("venue"));
 $columns = get_int("cols", true);
-$c = $columns?"&cols=$columns":"";
+$c = $columns ? "&cols=$columns" : "";
 check_venue($venue);
 check_subset($subset);
 
@@ -42,7 +42,7 @@ 
             $title = tra("Edit %1 preferences", subset_name($subset));
             if ($venue) $title = "$title for $venue";
             page_head($title);
-            $x = $venue?"&venue=$venue":"";
+            $x = $venue ? "&venue=$venue" : "";
 
             echo PREFS_FORM_DESC1;
             echo PREFS_FORM_ERROR_DESC;
@@ -67,7 +67,7 @@ 
             $title = tra("Edit %1 preferences", subset_name($subset));
             if ($venue) $title = "$title for $venue";
             page_head($title);
-            $x = $venue?"&venue=$venue":"";
+            $x = $venue ? "&venue=$venue" : "";
 
             echo PREFS_FORM_ERROR_DESC;
 

html/user/user_search.php

Spacing +6 added lines, -6 removed lines

@@ -25,7 +25,7 @@ 
     $y = [];
     $x[] = sprintf('%s%s',
         user_links($user, BADGE_HEIGHT_MEDIUM),
-        UNIQUE_USER_NAME?'':" (ID $user->id)"
+        UNIQUE_USER_NAME ? '' : " (ID $user->id)"
     );
     $y[] = null;
     if (!DISABLE_TEAMS) {
@@ -108,7 +108,7 @@ 
     $where = "true";
     $search_string = get_str('search_string');
     if (strlen($search_string)) {
-        if (strlen($search_string)<3) {
+        if (strlen($search_string) < 3) {
             error_page(tra("search string must be at least 3 characters"));
         }
         $s = BoincDb::escape_string($search_string);
@@ -140,17 +140,17 @@ 
     $search_type = get_str('search_type', true);
     $order_clause = "id desc";
     if ($search_type == 'rac') {
-        $order_clause ="expavg_credit desc";
+        $order_clause = "expavg_credit desc";
     } else if ($search_type == 'total') {
-        $order_clause ="total_credit desc";
+        $order_clause = "total_credit desc";
     }
 
     $fields = "id, create_time, name, country, total_credit, expavg_credit, teamid, url, has_profile, donated";
     $users = BoincUser::enum_fields($fields, $where, "order by $order_clause limit 100");
     page_head(tra("User search results"));
-    $n=0;
+    $n = 0;
     foreach ($users as $user) {
-        if ($n==0) {
+        if ($n == 0) {
             start_table('table-striped');
             $x = ['Name'];
             $y = [null];

html/user/user_permissions.php

Spacing +5 added lines, -5 removed lines

@@ -27,7 +27,7 @@ 
     start_table('table-striped');
 
     $x = ['User'];
-    for ($i=0; $i<S_NFLAGS; $i++) {
+    for ($i = 0; $i < S_NFLAGS; $i++) {
         $x[] = $special_user_bitfield[$i];
     }
     $x[] = '';
@@ -42,9 +42,9 @@ 
             $pref->userid
         );
         $x = ["$user->name ($user->id)"];
-        for ($j=0; $j<S_NFLAGS; $j++) {
+        for ($j = 0; $j < S_NFLAGS; $j++) {
             $bit = substr($pref->special_user, $j, 1);
-            $c = ($bit == 1)?"checked":"";
+            $c = ($bit == 1) ? "checked" : "";
             $x[] = sprintf(
                 '<input type="checkbox" name="role%d" value="1" %s>',
                 $j, $c
@@ -57,7 +57,7 @@ 
 
     echo '<form action="user_permissions.php" method="POST">';
     $x = ['Add User ID: <input type="text" name="userid" size="6">'];
-    for ($j=0; $j<S_NFLAGS; $j++) {
+    for ($j = 0; $j < S_NFLAGS; $j++) {
         $x[] = sprintf(
             '<input type="checkbox" name="role%d" value="1">',
             $j
@@ -77,7 +77,7 @@ 
     if (!$user) error_page('no user');
     BoincForumPrefs::lookup($user);
 
-    for ($i=0; $i<S_NFLAGS; $i++) {
+    for ($i = 0; $i < S_NFLAGS; $i++) {
         if (post_int("role$i", true) == 1) {
             $bitset .= '1';
             echo "<br> setting $i";

html/project.sample/project_specific_prefs.inc

Spacing +14 added lines, -14 removed lines

@@ -33,7 +33,7 @@ 
 //      Also error-check values, and return errors in $errors->*
 
 function option($name, $val) {
-    $x = ($name == $val) ?  "selected" : "";
+    $x = ($name == $val) ? "selected" : "";
     return "<option name='$name' $x>$name\n";
 }
 
@@ -53,7 +53,7 @@ 
 if (APP_SELECT_PREFS) {
     $app_array = array();
     $apps = BoincApp::enum("deprecated=0");
-    foreach($apps as $app) {
+    foreach ($apps as $app) {
         $app_array[] = array($app->id, $app->user_friendly_name);
     }
 } else {
@@ -91,10 +91,10 @@ 
 }
 
 function number_select($name, $max, $n) {
-    $sel = ($n == 0) ? "selected":"";
+    $sel = ($n == 0) ? "selected" : "";
     $x = "<select class=\"form-control input-sm\" name=$name> <option value=0 $sel>".tra("No limit")."</option>";
-    for ($i=1; $i<=$max; $i++) {
-        $sel = ($n == $i) ? "selected":"";
+    for ($i = 1; $i <= $max; $i++) {
+        $sel = ($n == $i) ? "selected" : "";
         $x .= "<option value=$i $sel>$i</option>";
     }
     $x .= "</select>";
@@ -106,7 +106,7 @@ 
     return tra("No limit");
 }
 
-function project_specific_prefs_edit($prefs, $error=false) {
+function project_specific_prefs_edit($prefs, $error = false) {
     global $app_array;
     if (COLOR_PREFS) {
         $x = $prefs->color_scheme;
@@ -132,15 +132,15 @@ 
             } else {
                 $present = true;
             }
-            $checked = $present?"checked":"";
+            $checked = $present ? "checked" : "";
             $x .= "<input type=checkbox name=app_id_$app_id $checked> $app_name<br>";
         }
         tooltip_row2(APP_SELECT_TOOLTIP, APP_SELECT_DESC, $x);
-        $checked = $prefs->allow_non_preferred_apps?"checked":"";
+        $checked = $prefs->allow_non_preferred_apps ? "checked" : "";
         row2(ACCEPT_ANY_DESC, "<input type=checkbox name=allow_non_preferred_apps $checked>");
     }
     if (NON_GRAPHICAL_PREF) {
-        $checked = $prefs->non_graphical?"checked":"";
+        $checked = $prefs->non_graphical ? "checked" : "";
         row2(
             NON_GRAPHICAL_DESC,
             "<input type=checkbox name=non_graphical $checked>"
@@ -216,11 +216,11 @@ 
     return $x;
 }
 
-function project_specific_prefs_show($prefs, $columns=false) {
+function project_specific_prefs_show($prefs, $columns = false) {
     global $app_array;
     if ($columns) {
         if (COLOR_PREFS) {
-            row_defs(COLOR_DESC,"color_scheme", "", "", $prefs);
+            row_defs(COLOR_DESC, "color_scheme", "", "", $prefs);
         }
         if (GFX_CPU_PREFS) {
             row_defs(MAX_GFX_CPU_PCT_DESC, "max_gfx_cpu_pct", "", "", $prefs);
@@ -254,7 +254,7 @@ 
             row2(ACCEPT_ANY_DESC, $prefs->allow_non_preferred_apps_text);
         }
         if (NON_GRAPHICAL_PREF) {
-            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical?tra("yes"):tra("no"));
+            row2(NON_GRAPHICAL_DESC, $prefs->non_graphical ?tra("yes") : tra("no"));
         }
         if (MAX_JOBS_PREF) {
             row2(tra("Max # jobs"), limit_string($prefs->max_jobs));
@@ -277,12 +277,12 @@ 
         $cursor = 0;
         while ($thisxml = parse_next_element($prefs_xml, "<app_id>", $cursor)) {
             if (is_numeric($thisxml)) {
-                $n = (int) $thisxml;
+                $n = (int)$thisxml;
                 $prefs->app_ids[] = $n;
             }
         }
         $prefs->allow_non_preferred_apps = parse_element($prefs_xml, "<allow_non_preferred_apps>");
-        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps?"yes":"no";
+        $prefs->allow_non_preferred_apps_text = $prefs->allow_non_preferred_apps ? "yes" : "no";
     }
     if (NON_GRAPHICAL_PREF) {
         $prefs->non_graphical = parse_bool($prefs_xml, "non_graphical");

html/inc/stats_sites.inc

Spacing +2 added lines, -2 removed lines

@@ -147,11 +147,11 @@
 
 function site_list($sites) {
     echo "<ul>\n";
-    for ($i=0; $i<count($sites); $i++) {
+    for ($i = 0; $i < count($sites); $i++) {
         $s = $sites[$i];
         $url = $s[0];
         $name = $s[1];
-        $comment = array_key_exists(2, $s)?$s[2]:"";
+        $comment = array_key_exists(2, $s) ? $s[2] : "";
         echo "<li><a href=\"$url\">$name</a> $comment\n";
     }
     echo "</ul>\n";