BOINC / boinc

html/ops/pass_percentage_by_appversion.php

Spacing +11 added lines, -11 removed lines

@@ -106,7 +106,7 @@ 
 $db = BoincDb::get(true);
 $result = $db->do_query($main_query);
 
-if($db->base_errno()) {
+if ($db->base_errno()) {
     echo $db->base_error();
 }
 
@@ -127,7 +127,7 @@ 
     echo "</td>\n";
 
     echo "  <td align=\"left\" valign=\"top\">";
-    if($res->platform)
+    if ($res->platform)
         echo $res->platform;
     else
         echo "unknown";
@@ -144,31 +144,31 @@ 
     echo "&nbsp;&nbsp;</td>\n";
 
     $abs = $res->pass_count;
-    $perc = $abs / $tot * 100;
+    $perc = $abs/$tot*100;
     echo "  <td align=\"right\" valign=\"top\">";
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
     echo "</td>\n";
 
     $abs = $res->fail_count;
-    $perc = $abs / $tot * 100;
+    $perc = $abs/$tot*100;
     echo "  <td align=\"right\" valign=\"top\">";
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
     echo "</td>\n";
 
     $abs = $res->fail_count1;
-    $perc = $abs / $tot * 100;
+    $perc = $abs/$tot*100;
     echo "  <td align=\"right\" valign=\"top\">";
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
     echo "</td>\n";
 
     $abs = $res->fail_count2;
-    $perc = $abs / $tot * 100;
+    $perc = $abs/$tot*100;
     echo "  <td align=\"right\" valign=\"top\">";
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
     echo "</td>\n";
 
     $abs = $res->fail_count3;
-    $perc = $abs / $tot * 100;
+    $perc = $abs/$tot*100;
     echo "  <td align=\"right\" valign=\"top\">";
     if ($abs > 0) {
         echo "<a title=\"$abs\" href=\"ordered_client_errors.php?appid=$query_appid&nsecs=$query_nsecs&appverid=$res->app_version_id\">";
@@ -179,25 +179,25 @@ 
     echo "</td>\n";
 
     $abs = $res->fail_count4;
-    $perc = $abs / $tot * 100;
+    $perc = $abs/$tot*100;
     echo "  <td align=\"right\" valign=\"top\">";
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
     echo "</td>\n";
 
     $abs = $res->fail_count5;
-    $perc = $abs / $tot * 100;
+    $perc = $abs/$tot*100;
     echo "  <td align=\"right\" valign=\"top\">";
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
     echo "</td>\n";
 
     $abs = $res->fail_count6;
-    $perc = $abs / $tot * 100;
+    $perc = $abs/$tot*100;
     echo "  <td align=\"right\" valign=\"top\">";
     printf("<div title=\"%d\">%.4f%%</div>&nbsp;&nbsp;", $abs, $perc);
     echo "</td>\n";
 
     $abs = $res->fail_count7;
-    $perc = $abs / $tot * 100;
+    $perc = $abs/$tot*100;
     echo "  <td align=\"right\" valign=\"top\">";
     if ($abs > 0) {
         echo "<a title=\"$abs\" href=\"db_action.php?table=result&server_state=5&outcome=6&detail=low&nresults=20&clauses=app_version_id+%3D+$res->app_version_id\">";

html/ops/watchdogs.php

Spacing +1 added lines, -1 removed lines

@@ -43,7 +43,7 @@
         sound_alarm("log file ".$file." missing");
     } else if ($t > $last_time) {
         $lines = file($file);
-        $last_line = $lines[count($lines)-1];
+        $last_line = $lines[count($lines) - 1];
         sound_alarm($last_line);
     }
 }

html/ops/hrclass_summary.php

Spacing +42 added lines, -42 removed lines

@@ -21,45 +21,45 @@ 
 // TODO: convert to use new DB interface
 // TODO: document in the wiki
 
-include_once( "../inc/db.inc" );
-include_once( "../inc/util.inc" );
-include_once( "../inc/db_ops.inc" );
-include_once( "../inc/util_ops.inc" );
-include_once( "../inc/prefs.inc" );
-
-$system_string[ 128 ] = "No OS";
-$system_string[ 256 ] = "Linux";
-$system_string[ 384 ] = "Windows";
-$system_string[ 512 ] = "Darwin";
-$system_string[ 640 ] = "FreeBSD";
-
-$cpu_string[ 0 ]  = "Unspecified";
-$cpu_string[ 1 ]  = "No cpu";
-$cpu_string[ 2 ]  = "Intel";
-$cpu_string[ 3 ]  = "AMD";
-$cpu_string[ 4 ]  = "Macintosh";
-$cpu_string[ 5 ]  = "AMD Athlon";
-$cpu_string[ 6 ]  = "AMD Duron";
-$cpu_string[ 7 ]  = "AMD Sempron";
-$cpu_string[ 8 ]  = "AMD Opteron";
-$cpu_string[ 9 ]  = "AMD Athlon 64";
-$cpu_string[ 10 ] = "AMD Athlon XP";
-$cpu_string[ 11 ] = "Intel Xeon";
-$cpu_string[ 12 ] = "Intel Celeron";
-$cpu_string[ 13 ] = "Intel Pentium";
-$cpu_string[ 14 ] = "Intel Pentium II";
-$cpu_string[ 15 ] = "Intel Pentium III";
-$cpu_string[ 16 ] = "Intel Pentium 4";
-$cpu_string[ 17 ] = "Intel Pentium D";
-$cpu_string[ 18 ] = "Intel Pentium M";
-$cpu_string[ 19 ] = "AMD Athlon MP";
-$cpu_string[ 20 ] = "AMD Turion";
-$cpu_string[ 21 ] = "Intel Core2";
+include_once("../inc/db.inc");
+include_once("../inc/util.inc");
+include_once("../inc/db_ops.inc");
+include_once("../inc/util_ops.inc");
+include_once("../inc/prefs.inc");
+
+$system_string[128] = "No OS";
+$system_string[256] = "Linux";
+$system_string[384] = "Windows";
+$system_string[512] = "Darwin";
+$system_string[640] = "FreeBSD";
+
+$cpu_string[0]  = "Unspecified";
+$cpu_string[1]  = "No cpu";
+$cpu_string[2]  = "Intel";
+$cpu_string[3]  = "AMD";
+$cpu_string[4]  = "Macintosh";
+$cpu_string[5]  = "AMD Athlon";
+$cpu_string[6]  = "AMD Duron";
+$cpu_string[7]  = "AMD Sempron";
+$cpu_string[8]  = "AMD Opteron";
+$cpu_string[9]  = "AMD Athlon 64";
+$cpu_string[10] = "AMD Athlon XP";
+$cpu_string[11] = "Intel Xeon";
+$cpu_string[12] = "Intel Celeron";
+$cpu_string[13] = "Intel Pentium";
+$cpu_string[14] = "Intel Pentium II";
+$cpu_string[15] = "Intel Pentium III";
+$cpu_string[16] = "Intel Pentium 4";
+$cpu_string[17] = "Intel Pentium D";
+$cpu_string[18] = "Intel Pentium M";
+$cpu_string[19] = "AMD Athlon MP";
+$cpu_string[20] = "AMD Turion";
+$cpu_string[21] = "Intel Core2";
 
 $query = "SELECT COUNT(workunit.id) AS count FROM workunit LEFT JOIN result ON workunit.id=result.workunitid WHERE result.server_state=2 AND workunit.hr_class=";
 
 function get_mysql_count($hr_class) {
-    $result = _mysql_query("select count(id) as count from workunit where hr_class=" . $hr_class);
+    $result = _mysql_query("select count(id) as count from workunit where hr_class=".$hr_class);
     $count = _mysql_fetch_object($result);
     _mysql_free_result($result);
     return $count->count;
@@ -82,19 +82,19 @@ 
     "hr_class", "System", "CPU", "# unsent results"
 );
 
-$unsentresults = get_mysql_count( 0 );
+$unsentresults = get_mysql_count(0);
 table_row(
-    make_reset_url(0), $system_string[ 128 ], $cpu_string[ 0 ], $unsentresults  );
+    make_reset_url(0), $system_string[128], $cpu_string[0], $unsentresults  );
 
-for ($system = 2; $system < 6; ++$system ) {
-    for ($cpu = 1; $cpu < 22; ++$cpu ) {
-        $hr_class=128*$system+$cpu;
+for ($system = 2; $system < 6; ++$system) {
+    for ($cpu = 1; $cpu < 22; ++$cpu) {
+        $hr_class = 128*$system + $cpu;
 
-        $unsentresults = get_mysql_count( $hr_class );
+        $unsentresults = get_mysql_count($hr_class);
 
         table_row(
             make_reset_url($hr_class),
-            $system_string[$system * 128],
+            $system_string[$system*128],
             $cpu_string[$cpu],
             $unsentresults
         );

html/ops/job_times.php

Spacing +10 added lines, -10 removed lines

@@ -40,9 +40,9 @@ 
     global $count;
     global $varsum;
 
-    $flops = $result->elapsed_time * $result->flops_estimate;
+    $flops = $result->elapsed_time*$result->flops_estimate;
     //printf("%e<br>\n", $flops);
-    $n = (int) ($flops/$quantum);
+    $n = (int)($flops/$quantum);
     if (!array_key_exists($n, $hist)) {
         $hist[$n] = 0;
     }
@@ -50,7 +50,7 @@ 
     $count++;
     $delta = $flops - $mean;
     $mean += $delta/$count;
-    $varsum += $delta*($flops-$mean);
+    $varsum += $delta*($flops - $mean);
 }
 
 function show_stats() {
@@ -59,7 +59,7 @@ 
     global $varsum;
     global $sum;
 
-    $stdev = sqrt($varsum/($count-1));
+    $stdev = sqrt($varsum/($count - 1));
     printf("mean: %e<br>stdev: %e<br>samples: %d", $mean, $stdev, $count);
 }
 
@@ -70,7 +70,7 @@ 
     $sum = 0;
     $n = 0;
     foreach ($hist as $i=>$v) {
-        $sum  += $quantum*$i*$v;
+        $sum += $quantum*$i*$v;
         $n += $v;
     }
     $mean = $sum/$n;
@@ -80,7 +80,7 @@ 
     $sum = 0;
     foreach ($hist as $i=>$v) {
         $d = ($mean - $quantum*$i);
-        $sum  += $d*$d*$v;
+        $sum += $d*$d*$v;
     }
     $stdev = sqrt($sum/$n);
     echo "<br>stdev: ";
@@ -117,7 +117,7 @@ 
         if ($v > $max) $max = $v;
     }
 
-    for ($i=$start; $i<=$end; $i++) {
+    for ($i = $start; $i <= $end; $i++) {
         if (array_key_exists($i, $hist)) {
             $w = 600*$hist[$i]/$max;
         } else {
@@ -152,7 +152,7 @@ 
 function analyze($appid, $app_version_id, $nresults) {
     global $hist;
 
-    $clause = $app_version_id?" and app_version_id = $app_version_id ":"";
+    $clause = $app_version_id ? " and app_version_id = $app_version_id " : "";
 
     $query = "select id, server_state, outcome, elapsed_time, flops_estimate from result where server_state=5 and appid=$appid and outcome=1 and validate_state=1 $clause order by id desc limit $nresults";
     $r = _mysql_query($query);
@@ -183,7 +183,7 @@ 
     ";
     $apps = BoincApp::enum("deprecated=0");
 
-    foreach($apps as $app) {
+    foreach ($apps as $app) {
         echo "<br><input type=radio name=appid value=$app->id>
             $app->user_friendly_name
         ";
@@ -210,7 +210,7 @@ 
     admin_page_tail();
 }
 
-if (get_str('submit', true)=='OK') {
+if (get_str('submit', true) == 'OK') {
     set_time_limit(0);
     $appid = get_int('appid');
     $app_version_id = get_int('app_version_id');

Braces +2 added lines, -1 removed lines

@@ -63,7 +63,8 @@
     printf("mean: %e<br>stdev: %e<br>samples: %d", $mean, $stdev, $count);
 }
 
-function show_stats_hist() {    //deprecated
+function show_stats_hist() {
+//deprecated
     global $hist;
     global $quantum;
 

html/ops/credit_study.php

Spacing +9 added lines, -9 removed lines

@@ -32,7 +32,7 @@ 
 function mean($x) {
     $sum = 0;
     $n = count($x);
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $sum += $x[$i];
     }
     return $sum/$n;
@@ -42,7 +42,7 @@ 
     $sum = 0;
     $n = count($x);
     $m = mean($x);
-    for ($i=0; $i<$n; $i++) {
+    for ($i = 0; $i < $n; $i++) {
         $d = $x[$i] - $m;
         $sum += $d*$d;
         //echo "$x[$i] ";
@@ -56,10 +56,10 @@ 
 // returns the claimed credit for a given result/host and FP weight
 //
 function cc($x, $fpw) {
-    $cps = $x->p_fpops*$fpw + $x->p_iops*(1-$fpw);
+    $cps = $x->p_fpops*$fpw + $x->p_iops*(1 - $fpw);
     $cps /= 1e9;
     $cps /= 864;
-    $cc = $x->cpu_time * $cps;
+    $cc = $x->cpu_time*$cps;
     return $cc;
 }
 
@@ -84,7 +84,7 @@ 
     $nwus = 4000;
 
     $sum = array();
-    for ($i=0; $i<=10; $i++) {
+    for ($i = 0; $i <= 10; $i++) {
         $sum[] = 0;
     }
     $r1 = _mysql_query(
@@ -96,7 +96,7 @@ 
         $r2 = _mysql_query("select * from result where workunitid=$wu->id");
         $found_zero = false;
         while ($result = _mysql_fetch_object($r2)) {
-            if ($result->granted_credit==0) continue;   // skip invalid
+            if ($result->granted_credit == 0) continue; // skip invalid
             $host = BoincHost::lookup_id($result->hostid);
             $r = new StdClass;
             $r->cpu_time = $result->cpu_time;
@@ -105,8 +105,8 @@ 
             $results[] = $r;
         }
         //echo "Wu $wu->id -------------\n";
-        if (count($results)<2) continue;
-        for ($i=0; $i<=10; $i++) {
+        if (count($results) < 2) continue;
+        for ($i = 0; $i <= 10; $i++) {
             $fpw = $i/10.;
             $sum[$i] += fpw_var($results, $fpw);
         }
@@ -120,7 +120,7 @@ 
 Number of workunits analyzed: $n
 
 ";
-    for ($i=0; $i<=10; $i++) {
+    for ($i = 0; $i <= 10; $i++) {
         $fpw = $i/10.;
         $r = $sum[$i]/$n;
         echo "FP weight $fpw: variance is $r\n";

html/ops/autolock.php

Spacing +1 added lines, -1 removed lines

@@ -22,7 +22,7 @@
 $cli_only = true;
 require_once("../inc/util_ops.inc");
 
-$max_age_days = 90;     // lock threads older than this
+$max_age_days = 90; // lock threads older than this
 if ($argc > 2) {
     if ($argv[1] == "--ndays") {
         $max_age_days = $argv[2];

html/ops/wd_nresults_changing.php

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
     return $lines;
 }
 
-function write_count_file($n,$m) {
+function write_count_file($n, $m) {
     $f = fopen("nresults", "w");
     if (!$f) return false;
     $x = sprintf("%d\n%d\n", $n, $m);
@@ -80,12 +80,12 @@ 
     }
     $n = read_count_file();
     if ($n == false) {
-        write_count_file($m,$p);
+        write_count_file($m, $p);
         exit();
     }
     if (trim($n[0]) == $m && trim($n[1]) == $p) {
         fail("Result count hasn't changed\n");
     }
-    write_count_file($m,$p);
+    write_count_file($m, $p);
 
 ?>

html/ops/eah_server_status.php

Indentation +3 added lines, -3 removed lines

@@ -41,9 +41,9 @@
 }
 
 function find_oldest() {
-   $result=_mysql_query("select name,create_time from result where server_state=2 order by create_time limit 1");
-   $x = _mysql_fetch_object($result);
-   return $x->create_time;
+    $result=_mysql_query("select name,create_time from result where server_state=2 order by create_time limit 1");
+    $x = _mysql_fetch_object($result);
+    return $x->create_time;
 }
 
 function daemon_status($host, $pidname) {

Spacing +22 added lines, -22 removed lines

@@ -41,7 +41,7 @@ 
 }
 
 function find_oldest() {
-   $result=_mysql_query("select name,create_time from result where server_state=2 order by create_time limit 1");
+   $result = _mysql_query("select name,create_time from result where server_state=2 order by create_time limit 1");
    $x = _mysql_fetch_object($result);
    return $x->create_time;
 }
@@ -88,25 +88,25 @@ 
 
 
 
-$dbrc = db_init(1);    // 1=soft, remember that DB might be down
+$dbrc = db_init(1); // 1=soft, remember that DB might be down
 
-page_head(PROJECT . " - Server Status");
+page_head(PROJECT." - Server Status");
 
 
 // Date stamp
 
 
-echo "<br ALIGN=RIGHT> ".PROJECT. " server status as of ".
-    date("g:i A T"). " on ". date("l, j F Y ") .
+echo "<br ALIGN=RIGHT> ".PROJECT." server status as of ".
+    date("g:i A T")." on ".date("l, j F Y ").
     " (updated every $Nmin minutes).\n";
 
-$proc_uptime=exec("cat /proc/uptime | cut -d\" \" -f-1");
+$proc_uptime = exec("cat /proc/uptime | cut -d\" \" -f-1");
 $days = (int)($proc_uptime/86400);
-$hours=(int)($proc_uptime/3600);
-$hours=$hours % 24;
-$minutes=(int)($proc_uptime/60);
-$minutes=$minutes % 60;
-echo "<br ALIGN=RIGHT>The ".PROJECT. " main server has been continuously up for ". "$days"." days "."$hours"." hours "."$minutes"." minutes.\n<P>";
+$hours = (int)($proc_uptime/3600);
+$hours = $hours%24;
+$minutes = (int)($proc_uptime/60);
+$minutes = $minutes%60;
+echo "<br ALIGN=RIGHT>The ".PROJECT." main server has been continuously up for "."$days"." days "."$hours"." hours "."$minutes"." minutes.\n<P>";
 
 // tables side by side
 echo "<TABLE><TR><TD align=center> \n";
@@ -152,11 +152,11 @@ 
 if ($dbrc) {
     echo "The database server is not accessable";
 } else {
-    $now=time(0);
-    $s_day=24*3600;
-    $d_ago=$now-$s_day;
-    $s_week=7*$s_day;
-    $w_ago=$now-$s_week;
+    $now = time(0);
+    $s_day = 24*3600;
+    $d_ago = $now - $s_day;
+    $s_week = 7*$s_day;
+    $w_ago = $now - $s_week;
 
     echo "
         <table border=2 cellpadding=6>
@@ -276,12 +276,12 @@ 
         <tr><td>invalid</td><td>".number_format($n)."</td></tr>
     ";
 
-    $n = time(0)-find_oldest();
+    $n = time(0) - find_oldest();
     $days = (int)($n/86400);
-    $hours=(int)($n/3600);
-    $hours=$hours % 24;
-    $minutes=(int)($n/60);
-    $minutes=$minutes % 60;
+    $hours = (int)($n/3600);
+    $hours = $hours%24;
+    $minutes = (int)($n/60);
+    $minutes = $minutes%60;
     echo "
         <tr><td>Oldest Unsent Result</td><td>".$days." d ".$hours." h ".$minutes." m</td></tr>
     ";
@@ -297,7 +297,7 @@ 
 
 // Display cgi-bin restriction status
 
-if (  file_exists("../../cgi-bin/.htaccess") ) {
+if (file_exists("../../cgi-bin/.htaccess")) {
     echo "<P><font color=RED>
         <b>The ".PROJECT." scheduler is currently restricted
 	  to uwm.edu and a few other domains.

html/ops/error_summary.php

Spacing +1 added lines, -1 removed lines

@@ -27,7 +27,7 @@
 $nresults_per_code = get_int('nresults_per_code', true);
 if (!$nresults_per_code) $nresults_per_code = 10;
 
-function compare ($x, $y) {
+function compare($x, $y) {
     return $x->count < $y->count;
 }